⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 12, 2015:

11:15 PM Changeset in webkit [180033] by bshafiei@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merged r180028. rdar://problem/19180955

11:14 PM Changeset in webkit [180032] by bshafiei@apple.com
  • 2 edits in branches/safari-600.4-branch/Source/WebCore

Merged r180028. rdar://problem/19180955

10:48 PM Changeset in webkit [180031] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebKit2

Crash removing RemoteLayerTreeDisplayRefreshMonitor from the drawing area's map
​https://bugs.webkit.org/show_bug.cgi?id=141545
<rdar://problem/17712200>

Reviewed by Simon Fraser.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowScreenDidChange):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

windowScreenDidChange should take uint32_t, since that's what PlatformDisplayID is.

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
RemoteLayerTreeDisplayRefreshMonitor is driven by the page's
RemoteLayerTreeDrawingArea. Because of this, we cannot have the same
sharing of DisplayRefreshMonitors that other platforms use.
In order to ensure that we get a unique DisplayRefreshMonitor
per-DrawingArea, give each page a unique DisplayID derived
from WebPage's unique ID.

10:03 PM Changeset in webkit [180030] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Mark some debug assertions.

  • platform/win/TestExpectations: Mark several debug assertions so

we don't end testing early.

9:53 PM Changeset in webkit [180029] by Brent Fulgham
  • 2 edits
    2 adds in trunk/LayoutTests

[Win] More media rebaselining.

  • platform/win/TestExpectations:
  • platform/win/fast/css/focus-ring-exists-for-search-field-expected.png: Added.
  • platform/win/fast/css/focus-ring-exists-for-search-field-expected.txt: Added.
7:59 PM Changeset in webkit [180028] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Crashes under detectItemAroundHitTestResult when DataDetectors is not available
​https://bugs.webkit.org/show_bug.cgi?id=141549
<rdar://problem/19180955>

Reviewed by Dan Bernstein.

  • editing/mac/DataDetection.mm:

(WebCore::DataDetection::detectItemAroundHitTestResult):
Bail out from data detection if either of the relevant frameworks aren't loaded.

6:30 PM Changeset in webkit [180027] by commit-queue@webkit.org
  • 31 edits
    3 adds in trunk/LayoutTests

[EFL] Need to have new baseline for some tests of fast/ruby since r172874
​https://bugs.webkit.org/show_bug.cgi?id=141462

Unreviewed, EFL gardening. Rebaseline after r172874

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-02-12

  • platform/efl/TestExpectations:
  • platform/efl/fast/ruby/bopomofo-expected.png: Added.
  • platform/efl/fast/ruby/bopomofo-expected.txt:
  • platform/efl/fast/ruby/bopomofo-letter-spacing-expected.png: Added.
  • platform/efl/fast/ruby/bopomofo-letter-spacing-expected.txt:
  • platform/efl/fast/ruby/bopomofo-rl-expected.png: Added.
  • platform/efl/fast/ruby/bopomofo-rl-expected.txt:
  • platform/efl/fast/ruby/ruby-beforeafter-expected.png:
  • platform/efl/fast/ruby/ruby-beforeafter-expected.txt:
  • platform/efl/fast/ruby/ruby-length-expected.png:
  • platform/efl/fast/ruby/ruby-length-expected.txt:
  • platform/efl/fast/ruby/ruby-run-break-expected.png:
  • platform/efl/fast/ruby/ruby-run-break-expected.txt:
  • platform/efl/fast/ruby/ruby-runs-expected.png:
  • platform/efl/fast/ruby/ruby-runs-expected.txt:
  • platform/efl/fast/ruby/ruby-runs-spans-expected.png:
  • platform/efl/fast/ruby/ruby-runs-spans-expected.txt:
  • platform/efl/fast/ruby/ruby-trailing-expected.png:
  • platform/efl/fast/ruby/ruby-trailing-expected.txt:
  • platform/efl/fast/ruby/rubyDOM-insert-rt-expected.png:
  • platform/efl/fast/ruby/rubyDOM-insert-rt-expected.txt:
  • platform/efl/fast/ruby/rubyDOM-insert-text1-expected.png:
  • platform/efl/fast/ruby/rubyDOM-insert-text1-expected.txt:
  • platform/efl/fast/ruby/rubyDOM-insert-text2-expected.png:
  • platform/efl/fast/ruby/rubyDOM-insert-text2-expected.txt:
  • platform/efl/fast/ruby/rubyDOM-insert-text3-expected.png:
  • platform/efl/fast/ruby/rubyDOM-insert-text3-expected.txt:
  • platform/efl/fast/ruby/rubyDOM-remove-rt1-expected.png:
  • platform/efl/fast/ruby/rubyDOM-remove-rt1-expected.txt:
  • platform/efl/fast/ruby/rubyDOM-remove-rt2-expected.png:
  • platform/efl/fast/ruby/rubyDOM-remove-rt2-expected.txt:
  • platform/efl/fast/ruby/rubyDOM-remove-text1-expected.png:
  • platform/efl/fast/ruby/rubyDOM-remove-text1-expected.txt:
5:23 PM Changeset in webkit [180026] by bshafiei@apple.com
  • 5 edits in branches/safari-600.5-branch/Source

Versioning.

5:21 PM Changeset in webkit [180025] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.5.6

New tag.

5:04 PM Changeset in webkit [180024] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

[iOS Media] Audio should hide timeline scrubber until playback starts
​https://bugs.webkit.org/show_bug.cgi?id=141542
<rdar://problem/19820685>

Reviewed by Eric Carlson.

We regressed from the system behaviour in iOS 7, where the timeline
scrubber for an audio element is not shown until the user starts
playback.

  • Modules/mediacontrols/mediaControlsiOS.css:

(video::-webkit-media-controls-panel): Fix the alignment of the flexbox.
(audio::-webkit-media-controls-status-display): Add the style for the status display.

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.configureInlineControls): Start hidden if we are an <audio>.
(ControllerIOS.prototype.configureFullScreenControls): Drive by comment change.
(ControllerIOS.prototype.setPlaying): Unhide the timeline.

5:00 PM Changeset in webkit [180023] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed updates to test expectations to reduce failures on Windows bots.

  • platform/win/TestExpectations: Mark a number of time-outs for Media tests.
4:49 PM Changeset in webkit [180022] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash under RemoteLayerTreeDrawingArea::flushLayers() when closing a tab
​https://bugs.webkit.org/show_bug.cgi?id=141541

Reviewed by Benjamin Poulain.

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
The WebPage pointer can become stale between when it is retrieved
and dereferenced. Retrieve it by ID inside the dispatch_async block
instead of outside of it.

4:13 PM Changeset in webkit [180021] by Beth Dakin
  • 6 edits in trunk/LayoutTests

Re-baselines after ​http://trac.webkit.org/changeset/180018

  • platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div-with-handler-expected.txt:
  • platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler-expected.txt:
  • platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler-expected.txt:
  • platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler-expected.txt:
  • platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-select-with-handler-expected.txt:
3:23 PM Changeset in webkit [180020] by Chris Dumez
  • 11 edits in trunk

Drop the quirks-mode exception for CSS MIME types
​https://bugs.webkit.org/show_bug.cgi?id=141501

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Drop the quirks-mode exception for CSS MIME types.
This matches Firefox's behavior.

This patch is based on the following Blink revision:
​http://src.chromium.org/viewvc/blink?view=revision&revision=189669

Tests:

  • http/tests/misc/css-accept-any-type.html
  • http/tests/security/cross-origin-css.html
  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parseAuthorStyleSheet):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::setCSSStyleSheet):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResourceContent):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::sheetText):
(WebCore::CachedCSSStyleSheet::canUseSheet):

  • loader/cache/CachedCSSStyleSheet.h:

LayoutTests:

Update a couple of layout tests now that we dropped the quirks-mode
exception for CSS MIME types.

  • http/tests/misc/css-accept-any-type-expected.txt:
  • http/tests/misc/css-accept-any-type.html:
  • http/tests/security/cross-origin-css-expected.txt:
  • http/tests/security/cross-origin-css.html:
3:10 PM Changeset in webkit [180019] by Brent Fulgham
  • 2 edits in branches/safari-600.5-branch/Tools

Merge r179996 to correct test system failures.

2015-02-12 Brent Fulgham <Brent Fulgham>

[Win] Test bot infrastructure should not try to find/use old Safari DLLs
​https://bugs.webkit.org/show_bug.cgi?id=141517

Reviewed by Anders Carlsson.

We do not need to locate or use the DLL's that came with Safari, so stop
failing when we cannot find them. Also remove some old Qt cruft from this
script.

  • BuildSlaveSupport/built-product-archive: (archiveBuiltProduct): (extractBuiltProduct):
3:09 PM Changeset in webkit [180018] by Beth Dakin
  • 3 edits
    2 adds in trunk

REGRESSION: Should not send wheel events with a delta of 0
​https://bugs.webkit.org/show_bug.cgi?id=141537
-and corresponding-
rdar://problem/18903118

Reviewed by Simon Fraser.

Source/WebCore:

This code should not have been removed entirely to accommodate rubber-banding, it
just needs to return false instead of true in order to allow the MayBegin and
Ended phases to be handled by the ElasticityController.

  • dom/Element.cpp:

(WebCore::Element::dispatchWheelEvent):

LayoutTests:

  • platform/mac-wk2/tiled-drawing/scrolling/wheel-events-with-no-delta-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/wheel-events-with-no-delta.html: Added.
3:08 PM Changeset in webkit [180017] by Lucas Forschler
  • 5 edits in branches/safari-600.1.17-branch/Source

Versioning.

3:07 PM Changeset in webkit [180016] by Lucas Forschler
  • 1 copy in tags/Safari-600.1.17.9

New Tag.

3:07 PM Changeset in webkit [180015] by Brent Fulgham
  • 4 edits in branches/safari-600.5-branch

[Win] Unreviewed branch build fix.

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Fix

symbol export definition.

Tools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(AccessibilityUIElement::setValue): This needs a default body.

2:24 PM Changeset in webkit [180014] by Brent Fulgham
  • 1 edit
    1 add in branches/safari-600.5-branch/Source/JavaScriptCore

Correct merge error from r180011.

(DllMain):

2:20 PM Changeset in webkit [180013] by dino@apple.com
  • 4 edits in trunk/Source/WebCore

[iOS Media] Implement 3-style media timeline (buffered, played, unavailable)
​https://bugs.webkit.org/show_bug.cgi?id=141526
<rdar://problem/19603337>

Reviewed by Eric Carlson and Antoine Quint.

Implement a 3-style media scrubber for iOS. This draws white for
the region that has been played (before the playhead), black
for the region that is buffered, and is hollow for the rest.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.updateProgress): Update progress is now completely
shared between OS X and iOS. This calls the implementation specific
drawTimelineBackground.
(Controller.prototype.drawTimelineBackground): Move the OS X code to here.

  • Modules/mediacontrols/mediaControlsiOS.css:

(audio::-webkit-media-controls-timeline): New styles for the timeline. Updated thumb image, etc.
(video::-webkit-media-controls-timeline::-webkit-slider-runnable-track):
(audio::-webkit-media-controls-timeline::-webkit-slider-thumb):
(audio::-webkit-media-controls-timeline::-webkit-slider-thumb:active):
(video::-webkit-media-controls-time-remaining-display):

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS): Create a globally unique canvas context name in the constructor.
(ControllerIOS.prototype.createControls): Set the background of the timeline to a canvas.
(ControllerIOS.prototype.addRoundedRect): Helper function.
(ControllerIOS.prototype.drawTimelineBackground): Draw the 3-style content.
(ControllerIOS.prototype.updateProgress): Deleted.

2:20 PM Changeset in webkit [180012] by benjamin@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Simplify the initialization of BytecodeGenerator a bit
​https://bugs.webkit.org/show_bug.cgi?id=141505

Reviewed by Anders Carlsson.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • bytecompiler/BytecodeGenerator.h:

Setup the default initialization at the declaration level
instead of the constructor.

Also made m_scopeNode and m_codeType const to make it explicit
that they are invariant after construction.

  • parser/Nodes.cpp:
  • runtime/Executable.cpp:

Remove 2 useless #includes.

2:19 PM Changeset in webkit [180011] by Brent Fulgham
  • 18 edits
    1 add in branches/safari-600.5-branch

Merge r179993. <rdar://problem/19813975>

2015-02-11 Brent Fulgham <Brent Fulgham>

[Win] [64-bit] Work around MSVC2013 Runtime Bug
​https://bugs.webkit.org/show_bug.cgi?id=141498
<rdar://problem/19803642>

Reviewed by Anders Carlsson.

Disable FMA3 instruction use in the MSVC math library to
work around a VS2013 runtime crash. We can remove this
workaround when we switch to VS2015.

Source/JavaScriptCore:

  • API/tests/testapi.c: Call _set_FMA3_enable(0) to disable FMA3 support.
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Add new files.
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
  • JavaScriptCore.vcxproj/JavaScriptCoreDLL.cpp: Added.
  • JavaScriptCore.vcxproj/jsc/DLLLauncherMain.cpp: Call _set_FMA3_enable(0) to disable FMA3 support.
  • jsc.cpp: Ditto.
  • testRegExp.cpp: Ditto.

Source/WebKit/win:

  • WebKitDLL.cpp: Call _set_FMA3_enable(0) to disable FMA3 support.

Source/WTF:

  • WTF.vcxproj/WTF.vcxproj: Add new files.
  • WTF.vcxproj/WTF.vcxproj.filters: Ditto.
  • wtf/win/WTFDLL.cpp: Added.

Tools:

  • DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to disable FMA3 support.
  • DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
  • DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
  • DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
  • Scripts/webkitperl/httpd.pm: Ditto.
  • TestWebKitAPI/win/main.cpp: Ditto.
  • WinLauncher/Common.cpp: Ditto.
  • win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
2:18 PM Changeset in webkit [180010] by benjamin@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Move the generators for GetScope and SkipScope to the common core in DFGSpeculativeJIT
​https://bugs.webkit.org/show_bug.cgi?id=141506

Reviewed by Michael Saboff.

The generators for the nodes GetScope and SkipScope were
completely identical between 32 and 64bits.

This patch moves the duplicated code to DFGSpeculativeJIT.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetScope):
(JSC::DFG::SpeculativeJIT::compileSkipScope):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

1:33 PM Changeset in webkit [180009] by Brent Fulgham
  • 2 edits in branches/safari-600.1.17-branch/Tools

Merge r179996.

2015-02-12 Brent Fulgham <Brent Fulgham>

[Win] Test bot infrastructure should not try to find/use old Safari DLLs
​https://bugs.webkit.org/show_bug.cgi?id=141517

Reviewed by Anders Carlsson.

We do not need to locate or use the DLL's that came with Safari, so stop
failing when we cannot find them. Also remove some old Qt cruft from this
script.

  • BuildSlaveSupport/built-product-archive: (archiveBuiltProduct): (extractBuiltProduct):
1:31 PM Changeset in webkit [180008] by Antti Koivisto
  • 3 edits in trunk/Source/WebKit2

WebKit persistent cache uses a lot of threads
​https://bugs.webkit.org/show_bug.cgi?id=141520

Reviewed by Andreas Kling.

Parallel retrieves are limited but stores are not. We may end up with lots of backround io
dispatch queue threads if they don't complete fast enough.

This patch adds pending state for write operations similar to what retrieves already have
and limits to number of active operations.

  • NetworkProcess/cache/NetworkCacheStorage.h:

Combine StoreOperation and UpdateOperation and rename to WriteOperation.
Rename RetrieveOperation to ReadOperation.
The idea is to emphasize that these are disk operations.

  • NetworkProcess/cache/NetworkCacheStorageCocoa.mm:

(WebKit::NetworkCacheStorage::dispatchReadOperation):
(WebKit::NetworkCacheStorage::dispatchPendingReadOperations):
(WebKit::retrieveFromMemory):
(WebKit::NetworkCacheStorage::retrieve):
(WebKit::NetworkCacheStorage::store):
(WebKit::NetworkCacheStorage::update):
(WebKit::NetworkCacheStorage::dispatchPendingWriteOperations):

Only allow 3 parallel writes.

(WebKit::NetworkCacheStorage::dispatchFullWriteOperation):
(WebKit::NetworkCacheStorage::dispatchHeaderWriteOperation):

More informative names.

(WebKit::NetworkCacheStorage::dispatchRetrieveOperation): Deleted.
(WebKit::NetworkCacheStorage::dispatchPendingRetrieveOperations): Deleted.
(WebKit::retrieveActive): Deleted.

1:18 PM Changeset in webkit [180007] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Fix some Mac linker warnings
​https://bugs.webkit.org/show_bug.cgi?id=141522

Patch by Daniel Bates <​dabates@apple.com> on 2015-02-12
Reviewed by Alex Christensen.

Following <​https://trac.webkit.org/changeset/179945>, the linker warns about the following hidden WebCore symbols:

ld: warning: cannot export hidden symbol ZN7WebCore20LogNotYetImplementedE from /.../OpenSource/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/Logging.o
ld: warning: cannot export hidden symbol _wkCreateURLPasteboardFlavorTypeName from /.../OpenSource/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/WebCoreSystemInterface.o
ld: warning: cannot export hidden symbol _wkCreateURLNPasteboardFlavorTypeName from /.../OpenSource/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/WebCoreSystemInterface.o

  • WebCore.exp.in: Remove symbols for functions wkCreateURLPasteboardFlavorTypeName and wkCreateURLNPasteboardFlavorTypeName.
  • platform/Logging.h: Export WTFLogChannel for LogNotYetImplemented, which is referenced from

notImplementedLoggingChannel() in file NotImplemented.cpp. We make use of the associated
header, NotImplemented.h, in both WebKit and WebKit2.

  • platform/mac/WebCoreSystemInterface.mm: Remove declarations for functions

wkCreateURLPasteboardFlavorTypeName and wkCreateURLNPasteboardFlavorTypeName that
were inadvertently not removed in r25494.

1:13 PM Changeset in webkit [180006] by Brent Fulgham
  • 18 edits
    2 adds in branches/safari-600.1.17-branch

Merge r179993. <rdar://problem/19803642>

2015-02-11 Brent Fulgham <Brent Fulgham>

[Win] [64-bit] Work around MSVC2013 Runtime Bug
​https://bugs.webkit.org/show_bug.cgi?id=141498
<rdar://problem/19803642>

Reviewed by Anders Carlsson.

Disable FMA3 instruction use in the MSVC math library to
work around a VS2013 runtime crash. We can remove this
workaround when we switch to VS2015.

Source/JavaScriptCore:

  • API/tests/testapi.c: Call _set_FMA3_enable(0) to disable FMA3 support.
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Add new files.
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
  • JavaScriptCore.vcxproj/JavaScriptCoreDLL.cpp: Added.
  • JavaScriptCore.vcxproj/jsc/DLLLauncherMain.cpp: Call _set_FMA3_enable(0) to disable FMA3 support.
  • jsc.cpp: Ditto.
  • testRegExp.cpp: Ditto.

Source/WebKit/win:

  • WebKitDLL.cpp: Call _set_FMA3_enable(0) to disable FMA3 support.

Source/WTF:

  • WTF.vcxproj/WTF.vcxproj: Add new files.
  • WTF.vcxproj/WTF.vcxproj.filters: Ditto.
  • wtf/win/WTFDLL.cpp: Added.

Tools:

  • DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to disable FMA3 support.
  • DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
  • DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
  • DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
  • TestWebKitAPI/win/main.cpp: Ditto.
  • WinLauncher/Common.cpp: Ditto.
  • win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
12:47 PM Changeset in webkit [180005] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Web Inspector: Crash inspecting styles of element with mutated stylesheet
​https://bugs.webkit.org/show_bug.cgi?id=141451

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-02-12
Reviewed by Timothy Hatcher.

Source/WebCore:

Test: inspector/css/stylesheet-with-mutations.html

  • css/CSSStyleSheet.h:
  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::didMutateRules):
Keep a flag on the CSSStyleSheet to know when it has had a rule
mutation from the contents.

  • inspector/InspectorStyleSheet.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::reparseStyleSheet):
When completely replacing the stylesheet's contents, we will have
destroyed any previous rules, so clear the has mutations flag.

(WebCore::selectorsFromSource):
Previously there was a mismatch between the rules the parsed
SourceData had, and the actual CSSSelectors we were iterating.
We use the SourceData so we can get the exact user authored
text instead of generated longhands from actualy selector objects.
Add an ASSERT and bail to catch and more gracefully handle
any possible mismatches in the future.

(WebCore::InspectorStyleSheet::styleSheetMutated):
(WebCore::InspectorStyleSheet::ensureParsedDataReady):
When a CSSStyleSheet has been mutated beyond the inspector's
knowledge right now, fall back to readonly generated selectors.
We should better handle this in the future:
<​https://webkit.org/b/141450> Web Inspector: Better support for CSSOM StyleSheet mutations (insertRule/deleteRule)

LayoutTests:

  • inspector/css/stylesheet-with-mutations-expected.txt: Added.
  • inspector/css/stylesheet-with-mutations.html: Added.

Previously this test would crash, or in debug builds show one
of the two selectors in the rule.

12:30 PM Changeset in webkit [180004] by Brian Burg
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: add keyboard shortcut to enable/disable all breakpoints
​https://bugs.webkit.org/show_bug.cgi?id=141527

Reviewed by Joseph Pecoraro.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel): Bind Command/Control + Y to toggle breakpoints button.

12:00 PM Changeset in webkit [180003] by commit-queue@webkit.org
  • 7 edits
    2 deletes in trunk

Unreviewed, rolling out r179987.
​https://bugs.webkit.org/show_bug.cgi?id=141525

caused debug tests to fail (Requested by alexchristensen on
#webkit).

Reverted changeset:

"[CSS Grid Layout] Invalid initialization of track sizes with
non spanning grid items"
​https://bugs.webkit.org/show_bug.cgi?id=140763
​http://trac.webkit.org/changeset/179987

11:57 AM Changeset in webkit [180002] by achristensen@apple.com
  • 1 edit
    1 delete in trunk/Tools

Removed empty directory.

  • WinCELauncher: Removed.
11:00 AM Changeset in webkit [180001] by Brian Burg
  • 17 edits
    2 moves in trunk/Source/WebInspectorUI

Web Inspector: support adding and removing timelines to the timeline sidebar panel and overview
​https://bugs.webkit.org/show_bug.cgi?id=138434

Reviewed by Timothy Hatcher.

A timeline recording's timelines should not be static. This patch adds relevant machinery to
dynamically add and remove timelines from the Timeline model object and its various views.

From the model side, this is a simple change that adds TimelineAdded and TimelineRemoved events.
The timeline views and timeline sidebar require more extensive changes to support this functionality.
Instead of keeping a fixed set of timeline tree elements, the sidebar view now adds and removes
tree elements to reflect the available timelines for the displayed timeline recording.

This change also includes several minor cleanups, such as appending 'Element' to view properties that
are DOM elements, and renaming TimelineContentView to TimelineRecordingContentView.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype._loadNewRecording):
Populate predefined network, layout, and script timelines here after constructing the recording.

  • UserInterface/Main.html:
  • UserInterface/Models/Timeline.js:

Move hardcoded class names and localized strings to these base class methods. This is not implemented
using overridden methods because not all timeline types have their own subclasses. Add a dummy
implementation of saveIdentityToCookie() to avoid warnings when saving sidebar panel selection state.

(WebInspector.Timeline.prototype.get type):
(WebInspector.Timeline.prototype.get displayName): Added.
(WebInspector.Timeline.prototype.get iconClassName): Added.
(WebInspector.Timeline.prototype.addRecord):

  • UserInterface/Models/TimelineRecording.js:

(WebInspector.TimelineRecording):
(WebInspector.TimelineRecording.prototype.addTimeline.set timeline): Added.
(WebInspector.TimelineRecording.prototype.addTimeline): Added.
(WebInspector.TimelineRecording.prototype.removeTimeline.get this): Added.
(WebInspector.TimelineRecording.prototype.removeTimeline): Added.

  • UserInterface/Views/ContentView.js:

(WebInspector.ContentView):

  • UserInterface/Views/LayoutTimelineView.css:

(.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .navigation-sidebar-panel-content-tree-outline.layout .item .subtitle):
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.layout .item .subtitle): Deleted.

  • UserInterface/Views/LayoutTimelineView.js:

(WebInspector.LayoutTimelineView.prototype._treeElementSelected):
(WebInspector.LayoutTimelineView.prototype._closeStatusButtonClicked):

  • UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype.saveStateToCookie): Fix error message formatting.
(WebInspector.NavigationSidebarPanel.prototype._updateFilter):

  • UserInterface/Views/NetworkTimelineView.css:

(.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .navigation-sidebar-panel-content-tree-outline.network .item .subtitle):
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.network .item .subtitle): Deleted.

  • UserInterface/Views/NetworkTimelineView.js:

(WebInspector.NetworkTimelineView.prototype._closeStatusButtonClicked):

  • UserInterface/Views/ScriptTimelineView.css:

(.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .navigation-sidebar-panel-content-tree-outline.script .item .subtitle):
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.script .item .subtitle): Deleted.

  • UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView.prototype._treeElementSelected):
(WebInspector.ScriptTimelineView.prototype._closeStatusButtonClicked):

  • UserInterface/Views/TimelineOverview.js:

Convert this class to use the representedObject class pattern. It manages its own mapping from timelines
to overview graph views. Append 'Element' to some properties holding DOM elements.
(WebInspector.TimelineOverview):
(WebInspector.TimelineOverview.prototype.get visibleDuration):
(WebInspector.TimelineOverview.prototype.reset):
(WebInspector.TimelineOverview.prototype.updateLayout):
(WebInspector.TimelineOverview.prototype._handleScrollEvent):
(WebInspector.TimelineOverview.prototype._handleWheelEvent):
(WebInspector.TimelineOverview.prototype._timelineRemoved):
(WebInspector.TimelineOverview.prototype.updateLayoutIfNeeded):
(WebInspector.TimelineOverview.prototype._timeRangeSelectionChanged):

  • UserInterface/Views/TimelineRecordingContentView.css: Renamed from Source/WebInspectorUI/UserInterface/Views/TimelineContentView.css.

Remove hard-coded top offsets and heights that need to be dynamically calculated.
(.content-view.timeline-recording > .timeline-overview):
(.content-view.timeline-recording > .view-container):
(.content-view.timeline-recording > .view-container > .timeline-view > .data-grid td):
(.content-view.timeline-recording > .view-container > .timeline-view > .data-grid table.data):

  • UserInterface/Views/TimelineRecordingContentView.js: Renamed from Source/WebInspectorUI/UserInterface/Views/TimelineContentView.js.

Manage timeline views and path components dynamically. Adjust view heights as necessary. Append 'Element'
to some properties holding DOM elements.
(WebInspector.TimelineRecordingContentView):
(WebInspector.TimelineRecordingContentView.prototype.showOverviewTimelineView):
(WebInspector.TimelineRecordingContentView.prototype.showTimelineViewForTimeline):
(WebInspector.TimelineRecordingContentView.prototype.get allowedNavigationSidebarPanels):
(WebInspector.TimelineRecordingContentView.prototype.get supportsSplitContentBrowser):
(WebInspector.TimelineRecordingContentView.prototype.get navigationItems):
(WebInspector.TimelineRecordingContentView.prototype.get currentTimelineView):
(WebInspector.TimelineRecordingContentView.prototype.shown):
(WebInspector.TimelineRecordingContentView.prototype.hidden):
(WebInspector.TimelineRecordingContentView.prototype.filterDidChange):
(WebInspector.TimelineRecordingContentView.prototype.updateLayout):
(WebInspector.TimelineRecordingContentView.prototype.saveToCookie):
(WebInspector.TimelineRecordingContentView.prototype.restoreFromCookie):
(WebInspector.TimelineRecordingContentView.prototype.get matchTreeElementAgainstCustomFilters.checkTimeBounds):
(WebInspector.TimelineRecordingContentView.prototype.get matchTreeElementAgainstCustomFilters):
(WebInspector.TimelineRecordingContentView.prototype._pathComponentSelected):
(WebInspector.TimelineRecordingContentView.prototype._timelineViewSelectionPathComponentsDidChange):
(WebInspector.TimelineRecordingContentView.prototype._showTimelineView):
(WebInspector.TimelineRecordingContentView.prototype._update):
(WebInspector.TimelineRecordingContentView.prototype._updateTimes):
(WebInspector.TimelineRecordingContentView.prototype._startUpdatingCurrentTime):
(WebInspector.TimelineRecordingContentView.prototype._stopUpdatingCurrentTime):
(WebInspector.TimelineRecordingContentView.prototype._capturingStarted):
(WebInspector.TimelineRecordingContentView.prototype._capturingStopped):
(WebInspector.TimelineRecordingContentView.prototype._debuggerPaused):
(WebInspector.TimelineRecordingContentView.prototype._debuggerResumed):
Fix a minor regression where we make a useless call to stop updating the time.

(WebInspector.TimelineRecordingContentView.prototype._recordingTimesUpdated):
(WebInspector.TimelineRecordingContentView.prototype._clearTimeline):
(WebInspector.TimelineRecordingContentView.prototype._timelineRemoved):
(WebInspector.TimelineRecordingContentView.prototype._timelineCountChanged):
(WebInspector.TimelineRecordingContentView.prototype._recordingReset):
(WebInspector.TimelineRecordingContentView.prototype._recordingUnloaded):
(WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):

  • UserInterface/Views/TimelineSidebarPanel.css:

(.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing > .content):
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing > .content): Deleted.

  • UserInterface/Views/TimelineSidebarPanel.js:

Manage timeline tree elements dynamically. Adjust view heights as necessary. Append 'Element'
to some properties holding DOM elements. Keep track of the displayed recording and view explicitly.
(WebInspector.TimelineSidebarPanel):
(WebInspector.TimelineSidebarPanel.prototype.shown):
(WebInspector.TimelineSidebarPanel.prototype.showDefaultContentView):
(WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.looselyCompareRepresentedObjects):
(WebInspector.TimelineSidebarPanel.prototype.showTimelineOverview):
(WebInspector.TimelineSidebarPanel.prototype.updateFilter):
(WebInspector.TimelineSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
(WebInspector.TimelineSidebarPanel.prototype.canShowDifferentContentView):
(WebInspector.TimelineSidebarPanel.prototype.saveStateToCookie):
(WebInspector.TimelineSidebarPanel.prototype.get if):
(WebInspector.TimelineSidebarPanel.prototype._contentBrowserCurrentContentViewDidChange):
(WebInspector.TimelineSidebarPanel.prototype._recordingCountChanged):
(WebInspector.TimelineSidebarPanel.prototype._recordingSelected):
(WebInspector.TimelineSidebarPanel.prototype._recordingLoaded):
(WebInspector.TimelineSidebarPanel.prototype._timelineRemoved):
(WebInspector.TimelineSidebarPanel.prototype._timelineCountChanged):
(WebInspector.TimelineSidebarPanel.createTimelineTreeElement): Deleted.
(WebInspector.TimelineSidebarPanel.prototype.restoreStateFromCookie):

  • UserInterface/Views/TimelineView.css:

(.panel.navigation.timeline.timeline-recording-content-view-showing > .content > .navigation-sidebar-panel-content-tree-outline):
(.panel.navigation.timeline.timeline-content-view-showing > .content > .navigation-sidebar-panel-content-tree-outline): Deleted.

10:50 AM Changeset in webkit [180000] by rniwa@webkit.org
  • 7 edits in trunk/Websites/perf.webkit.org

Perf dashboard should show the results of A/B testing
​https://bugs.webkit.org/show_bug.cgi?id=141500

Reviewed by Chris Dumez.

Added the support for fetching test_runs for a specific test group in /api/runs/, and used it in the
analysis task page to fetch results for each test group.

Merged App.createChartData into App.Manifest.fetchRunsWithPlatformAndMetric so that App.BuildRequest
can use the formatter.

  • public/api/runs.php:

(fetch_runs_for_config_and_test_group): Added.
(fetch_runs_for_config): Just return the fetched rows since main will format them with RunsGenerator.
(main): Use fetch_runs_for_config_and_test_group to fetch rows when a test group id is specified. Also
use RunsGenerator to format results.
(RunsGenerator): Added.
(RunsGenerator::construct): Added.
(RunsGenerator::add_runs): Added.
(RunsGenerator::format_run): Moved.
(RunsGenerator::parse_revisions_array): Moved.

  • public/v2/analysis.js:

(App.TestGroup): Fixed a typo. The property on a test group that refers to an analysis task is "task".
(App.TestGroup._fetchChartData): Added. Fetches all A/B testing results for this group.
(App.BuildRequest.configLetter): Renamed from config since this returns a letter that identifies the
configuration associated with this build request such as "A" and "B".
(App.BuildRequest.statusLabel): Added the missing label for failed build requests.
(App.BuildRequest.url): Added. Returns the URL associated with this build request.
(App.BuildRequest._meanFetched): Added. Retrieve the mean and the build number for this request via
_fetchChartData.

  • public/v2/app.js:

(App.Pane._fetch): Set chartData directly here.
(App.Pane._updateMovingAverageAndEnvelope): Renamed from _computeChartData. No longer sets chartData
now that it's done in App.Pane._fetch.
(App.AnalysisTaskController._fetchedRuns): Updated per createChartData merge.

  • public/v2/data.js:

(Measurement.prototype.buildId): Added.
(TimeSeries.prototype.findPointByBuild): Added.

  • public/v2/index.html: Fixed a bug that build status URL was broken. We can't use link-to helper since

url is not an Ember routed path.

  • public/v2/manifest.js:

(App.Manifest.fetchRunsWithPlatformAndMetric): Takes testGroupId as the third argument. Merged
App.createChartData here so that App.BuildRequest can use the formatter

10:42 AM Changeset in webkit [179999] by Brian Burg
  • 9 edits in trunk/Source/WebInspectorUI

Web Inspector: Large background image fails to load in inspector
​https://bugs.webkit.org/show_bug.cgi?id=141405

Reviewed by Timothy Hatcher.

Convert base64-encoded resource data to binary data using Uint8Array and Blobs.
Use object URLs for blobs instead of data URLs when setting image 'src' attribute
and in @font-face urls. This conversion happens when the backend indicates that
resource content is base64-encoded.

Update image and font clients of resource-fetching functionality so that they use
object URLs correctly. Add some plumbing so that Blobs can be constructed with
the correct mime-type.

  • UserInterface/Base/Utilities.js:

(decodeBase64ToBlob): Added.

  • UserInterface/Models/CSSStyleSheet.js:

(WebInspector.CSSStyleSheet.prototype.get mimeType): Added.

  • UserInterface/Models/Resource.js:

(WebInspector.Resource.prototype.createObjectURL): Added.
(WebInspector.Resource.prototype.getImageSize.imageDidLoad):
(WebInspector.Resource.prototype.getImageSize):
(WebInspector.Resource.prototype.get contentURL): Deleted.

  • UserInterface/Models/Script.js:

(WebInspector.Script.prototype.get mimeType): Added.

  • UserInterface/Models/SourceCode.js:

(WebInspector.SourceCode.prototype.get mimeType): Added.
(WebInspector.SourceCode.prototype._processContent):
(WebInspector.SourceCode.prototype.get contentIsBase64Encoded): Deleted.

  • UserInterface/Models/SourceCodeRevision.js:

(WebInspector.SourceCodeRevision):
(WebInspector.SourceCodeRevision.prototype.copy):
(WebInspector.SourceCodeRevision.prototype.get contentIsBase64Encoded): Deleted.
(WebInspector.SourceCodeRevision.prototype.set contentIsBase64Encoded): Deleted.

  • UserInterface/Views/FontResourceContentView.js:

(WebInspector.FontResourceContentView.prototype.hidden):
(WebInspector.FontResourceContentView.prototype.closed):

  • UserInterface/Views/ImageResourceContentView.js:

(WebInspector.ImageResourceContentView.prototype.contentAvailable):

10:35 AM Changeset in webkit [179998] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
​https://bugs.webkit.org/show_bug.cgi?id=141202

Reviewed by Darin Adler.

  • Scripts/run-jsc-stress-tests:
10:21 AM Changeset in webkit [179997] by Brian Burg
  • 2 edits in trunk/Source/WebCore

REGRESSION(r178060): empty arguments are passed when logging to system console
​https://bugs.webkit.org/show_bug.cgi?id=141511

Reviewed by Timothy Hatcher.

  • page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::messageWithTypeAndLevel): Change premature move to copyRef.

9:48 AM Changeset in webkit [179996] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Test bot infrastructure should not try to find/use old Safari DLLs
​https://bugs.webkit.org/show_bug.cgi?id=141517

Reviewed by Anders Carlsson.

We do not need to locate or use the DLL's that came with Safari, so stop
failing when we cannot find them. Also remove some old Qt cruft from this
script.

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):
(extractBuiltProduct):

9:44 AM Changeset in webkit [179995] by matthew_hanson@apple.com
  • 3 edits in branches/safari-600.5-branch/Source/WebCore

<rdar://problem/17889529> CrashTracer: [USER] com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::SharedBuffer::createPurgeableBuffer const + 14

Reviewed by NOBODY (OOPS!).

Speculative fix for the above crash. The current theory is that a timer is being fired for a
CachedResource that has been freed. Add a marker field in CachedResource to do an early
return from CachedResource::makePurgeable() when this happens.

No new tests because I can't reproduce the crash.

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::makePurgeable):

  • loader/cache/CachedResource.h:
9:37 AM Changeset in webkit [179994] by matthew_hanson@apple.com
  • 7 edits
    2 adds in branches/safari-600.5-branch

Merge r179883. rdar://problem/19790645

9:30 AM WebKitGTK/Eclipse edited by clopez@igalia.com
(diff)
9:20 AM Changeset in webkit [179993] by Brent Fulgham
  • 19 edits
    2 adds in trunk

[Win] [64-bit] Work around MSVC2013 Runtime Bug
​https://bugs.webkit.org/show_bug.cgi?id=141498
<rdar://problem/19803642>

Reviewed by Anders Carlsson.

Disable FMA3 instruction use in the MSVC math library to
work around a VS2013 runtime crash. We can remove this
workaround when we switch to VS2015.

Source/JavaScriptCore:

  • API/tests/testapi.c: Call _set_FMA3_enable(0) to disable

FMA3 support.

to disable FMA3 support.

  • jsc.cpp: Ditto.
  • testRegExp.cpp: Ditto.

Source/WebKit/win:

  • WebKitDLL.cpp: Call _set_FMA3_enable(0) to disable FMA3 support.

Source/WTF:

  • WTF.vcxproj/WTF.vcxproj: Add new files.
  • WTF.vcxproj/WTF.vcxproj.filters: Ditto.
  • wtf/win/WTFDLL.cpp: Added.

Tools:

  • DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to

disable FMA3 support.

  • DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
  • DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
  • DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
  • Scripts/webkitperl/httpd.pm: Ditto.
  • TestWebKitAPI/win/main.cpp: Ditto.
  • WinLauncher/Common.cpp: Ditto.
  • win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
9:12 AM Changeset in webkit [179992] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebKit

Merge r178470. rdar://problem/19739095

9:12 AM WebKitGTK/Eclipse edited by clopez@igalia.com
(diff)
8:48 AM Changeset in webkit [179991] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Unreviewed debug build fix after r179980.

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::currentViewportSize):
Explicitly call constructor.

8:35 AM Changeset in webkit [179990] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Two tests have been failing since r148090.

  • platform/efl/TestExpectations: Skip 2 failure tests.
8:32 AM Changeset in webkit [179989] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

v2 UI should adjust the number of ticks on dashboards based on screen size
​https://bugs.webkit.org/show_bug.cgi?id=141502

Reviewed by Chris Dumez.

  • public/v2/interactive-chart.js:

(App.InteractiveChartComponent._updateDimensionsIfNeeded): Compute the number of ticks based on the
content size.

8:25 AM Changeset in webkit [179988] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL gardening.

  • platform/efl/TestExpectations: Mark two tests failing since r177664.
8:14 AM Changeset in webkit [179987] by svillar@igalia.com
  • 7 edits
    2 adds in trunk

[CSS Grid Layout] Invalid initialization of track sizes with non spanning grid items
​https://bugs.webkit.org/show_bug.cgi?id=140763

Reviewed by Antti Koivisto.

Source/WebCore:

Content sized tracks with non-spanning grid items were not
properly sized because the growth limit was sometimes infinity
(-1) after calling resolveContentBasedTrackSizingFunctions() when
it should not. This patch adds an special initialization phase for
non-spanning grid items as the new track sizing algorithm
describes.

Granted, that was handled in the old algorithm in
distributeSpaceToTracks() as a special case. The problem is that
it regressed after the optimization added in r173868 because that
method is no longer called when the space to distribute is 0.

That's why we could fix this by allowing calls to
distributeSpaceToTracks() with spaceToDistribute>=0 but by fixing
it with an explicit initialization our implementation becomes
closer to the new algorithm and the initialization is now explicit
in the code instead of a side effect of calling
distributeSpaceToTracks() with no space to be distributed. It also
brings a slight performance improvement as we save sorts and hash
lookups.

I also took the change to add caching to several GridTrackSize
methods that were hot on the profiler (each one accounted for ~1%
of the total time, now they account for ~0.3% each).

Test: fast/css-grid-layout/grid-initialize-span-one-items.html

  • rendering/RenderGrid.cpp:

(WebCore::GridItemWithSpan::span): New helper method for ASSERTs.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
Exclude non spanning grid items from the calls to
resolveContentBasedTrackSizingFunctionsForItems().
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForNonSpanningItems):
New method to resolve track sizes only using non-spanning grid
items.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Ensure that it isn't called for non-spanning grid items.

  • rendering/RenderGrid.h:
  • rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::GridTrackSize): Cache return values.
(WebCore::GridTrackSize::setLength): Ditto.
(WebCore::GridTrackSize::setMinMax): Ditto.
(WebCore::GridTrackSize::cacheMinMaxTrackBreadthTypes): New method
that caches the return values for hasXXXTrackBreadth() methods.
(WebCore::GridTrackSize::hasMinOrMaxContentMinTrackBreadth): Use
the cached return value.
(WebCore::GridTrackSize::hasMaxContentMaxTrackBreadth): Ditto.
(WebCore::GridTrackSize::hasMinContentMaxTrackBreadth): Ditto.
(WebCore::GridTrackSize::hasMinOrMaxContentMaxTrackBreadth): Ditto.
(WebCore::GridTrackSize::hasMaxContentMinTrackBreadth): Ditto.
(WebCore::GridTrackSize::hasMinContentMinTrackBreadth): Ditto.
(WebCore::GridTrackSize::hasMinContentMinTrackBreadthAndMinOrMaxContentMaxTrackBreadth):
Ditto.
(WebCore::GridTrackSize::hasMaxContentMinTrackBreadthAndMaxContentMaxTrackBreadth):
Ditto.

LayoutTests:

  • fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt:
  • fast/css-grid-layout/grid-content-sized-columns-resolution.html:
  • fast/css-grid-layout/grid-initialize-span-one-items-expected.txt: Added.
  • fast/css-grid-layout/grid-initialize-span-one-items.html: Added.
8:08 AM Changeset in webkit [179986] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

run-jsc-stress-tests should accept remote host config from JSON file
​https://bugs.webkit.org/show_bug.cgi?id=141509

Reviewed by Michael Saboff.

  • Scripts/run-javascriptcore-tests:

(runJSCStressTests):

  • Scripts/run-jsc-stress-tests:
8:04 AM HackingWebInspector edited by Brian Burg
(diff)
6:25 AM Changeset in webkit [179985] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Remove the USE(ACCELERATED_COMPOSITING) guard from the
MediaPlayerPrivateGStreamerBase destructor.

The guard was removed in r163079. It was still defined through CMake
for the EFL and GTK ports when the guarded code was introduced in
r172828. In r171741 the macro was finally removed for the GTK and EFL
ports as well, but the guards for the affected code weren't updated
so TextureMapperPlatformLayer::Client::platformLayerWillBeDestroyed()
wasn't being called anymore.

Rubber-stamped by Philippe Normand.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):

5:54 AM WebKitGTK edited by clopez@igalia.com
(diff)
5:49 AM WebKitGTK/Eclipse edited by eocanha@igalia.com
(diff)
5:41 AM WebKitGTK/Eclipse created by clopez@igalia.com
5:11 AM WebKitGTK/Roadmap edited by tpopela@redhat.com
(diff)
3:29 AM WebKitGTK/SpeedUpBuild edited by clopez@igalia.com
(diff)
2:48 AM WebKitGTK/SpeedUpBuild edited by clopez@igalia.com
(diff)
12:50 AM Changeset in webkit [179984] by Carlos Garcia Campos
  • 12 edits
    5 adds in trunk

[GTK] Add API to allow overriding the default color chooser implementation
​https://bugs.webkit.org/show_bug.cgi?id=98935

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Add API to allow the user to override the default UI of color
chooser. Similar to the file chooser API, a new run-color-chooser
signal is added to WebKitWebView that passes a WebKitColorChooserRequest
parameter to the signal.

Initial patch by Arnaud Renevier <​a.renevier@sisa.samsung.com>.

  • PlatformGTK.cmake: Add new files to compilation.
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::createColorPicker): Create a
WebKitColorChooser is the view widget is a WebKitWebView or a
WebColorPicker otherwise,

  • UIProcess/API/gtk/WebKitColorChooser.cpp: Added.

(WebKit::WebKitColorChooser::create):
(WebKit::WebKitColorChooser::WebKitColorChooser):
(WebKit::WebKitColorChooser::~WebKitColorChooser):
(WebKit::WebKitColorChooser::endPicker): Chain up to parent class
when not having a request, or finish the request if we have one.
(WebKit::WebKitColorChooser::colorChooserRequestFinished):
(WebKit::WebKitColorChooser::colorChooserRequestRGBAChanged):
(WebKit::WebKitColorChooser::showColorPicker): Create a new
WebKitColorChooserRequest and emit WebKitWebView::run-color-chooser.
If the signal is not handled, fallback to the default color
chooser dialog implemented by the parent class.

  • UIProcess/API/gtk/WebKitColorChooser.h: Added.
  • UIProcess/API/gtk/WebKitColorChooserRequest.cpp: Added.

(webkitColorChooserRequestGetProperty):
(webkitColorChooserRequestSetProperty):
(webkit_color_chooser_request_class_init):
(webkit_color_chooser_request_set_rgba):
(webkit_color_chooser_request_get_rgba):
(webkit_color_chooser_request_get_element_rectangle):
(webkit_color_chooser_request_finish):
(webkit_color_chooser_request_cancel):
(webkitColorChooserRequestCreate):

  • UIProcess/API/gtk/WebKitColorChooserRequest.h: Added.
  • UIProcess/API/gtk/WebKitColorChooserRequestPrivate.h: Added.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init): Add run-color-chooser signal.
(webkitWebViewEmitRunColorChooser): Emit run-color-chooser signal.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
  • UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Add new symbols.
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for WebKitColorChooserRequest.
  • UIProcess/API/gtk/webkit2.h: Include WebKitColorChooserRequest.h

Tools:

Add a color chooser implementation for MiniBrowser using
GtkPopover when the GTK+ version is recent enough.
And a test case to check the new color chooser API.

  • MiniBrowser/gtk/BrowserWindow.c:

(colorChooserRGBAChanged):
(popoverColorClosed):
(colorChooserRequestFinished):
(runColorChooserCallback):
(browserWindowConstructed):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:

(testWebViewColorChooserRequest):
(beforeAll):

Feb 11, 2015:

11:08 PM Changeset in webkit [179983] by Chris Fleizach
  • 2 edits
    1 move in trunk/LayoutTests

AX: Undeprecate ios-simulator accessibility tests
​https://bugs.webkit.org/show_bug.cgi?id=141407

Reviewed by Daniel Bates.

Undeprecate ios accessibility tests.
Modified one failing test (svg-group-element-with-title.html) slightly to get it to pass.

  • platform/ios-sim-deprecated/accessibility: Removed.
  • platform/ios-sim-deprecated/accessibility/accessibility-aria-table-children-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/accessibility-aria-table-children.html: Removed.
  • platform/ios-sim-deprecated/accessibility/accessibility-crash-in-axcontainer-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/accessibility-crash-in-axcontainer.html: Removed.
  • platform/ios-sim-deprecated/accessibility/accessibility-hint-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/accessibility-hint.html: Removed.
  • platform/ios-sim-deprecated/accessibility/aria-label-with-internal-text-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/aria-label-with-internal-text.html: Removed.
  • platform/ios-sim-deprecated/accessibility/aria-pressed-state-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/aria-pressed-state.html: Removed.
  • platform/ios-sim-deprecated/accessibility/centerpoint-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/centerpoint.html: Removed.
  • platform/ios-sim-deprecated/accessibility/disabled-states-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/disabled-states.html: Removed.
  • platform/ios-sim-deprecated/accessibility/dom-focus-fires-on-correct-element-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/dom-focus-fires-on-correct-element.html: Removed.
  • platform/ios-sim-deprecated/accessibility/element-paths-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/element-paths.html: Removed.
  • platform/ios-sim-deprecated/accessibility/file-upload-button-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/file-upload-button.html: Removed.
  • platform/ios-sim-deprecated/accessibility/focus-change-notifications-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/focus-change-notifications.html: Removed.
  • platform/ios-sim-deprecated/accessibility/header-elements-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/header-elements.html: Removed.
  • platform/ios-sim-deprecated/accessibility/identifier-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/identifier.html: Removed.
  • platform/ios-sim-deprecated/accessibility/internal-link-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/internal-link.html: Removed.
  • platform/ios-sim-deprecated/accessibility/landmark-type-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/landmark-type.html: Removed.
  • platform/ios-sim-deprecated/accessibility/link-with-images-text-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/link-with-images-text.html: Removed.
  • platform/ios-sim-deprecated/accessibility/link-with-only-image-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/link-with-only-image.html: Removed.
  • platform/ios-sim-deprecated/accessibility/math-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/math.html: Removed.
  • platform/ios-sim-deprecated/accessibility/mixed-checkboxes-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/mixed-checkboxes.html: Removed.
  • platform/ios-sim-deprecated/accessibility/no-child-link-header-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/no-child-link-header.html: Removed.
  • platform/ios-sim-deprecated/accessibility/non-contiguous-link-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/non-contiguous-link.html: Removed.
  • platform/ios-sim-deprecated/accessibility/out-of-bounds-child-access-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/out-of-bounds-child-access.html: Removed.
  • platform/ios-sim-deprecated/accessibility/password-value-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/password-value.html: Removed.
  • platform/ios-sim-deprecated/accessibility/placeholder-value-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/placeholder-value.html: Removed.
  • platform/ios-sim-deprecated/accessibility/popup-button-value-label-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/popup-button-value-label.html: Removed.
  • platform/ios-sim-deprecated/accessibility/progressbar-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/progressbar.html: Removed.
  • platform/ios-sim-deprecated/accessibility/radio-button-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/radio-button.html: Removed.
  • platform/ios-sim-deprecated/accessibility/secure-text-field-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/secure-text-field.html: Removed.
  • platform/ios-sim-deprecated/accessibility/selected-buttons-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/selected-buttons.html: Removed.
  • platform/ios-sim-deprecated/accessibility/selected-text-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/selected-text.html: Removed.
  • platform/ios-sim-deprecated/accessibility/svg-group-element-with-title-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/svg-group-element-with-title.html: Removed.
  • platform/ios-sim-deprecated/accessibility/svg-path-crash-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/svg-path-crash.html: Removed.
  • platform/ios-sim-deprecated/accessibility/tab-role-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/tab-role.html: Removed.
  • platform/ios-sim-deprecated/accessibility/table-cell-for-row-col-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/table-cell-for-row-col.html: Removed.
  • platform/ios-sim-deprecated/accessibility/table-cell-ranges-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/table-cell-ranges.html: Removed.
  • platform/ios-sim-deprecated/accessibility/table-with-mismatch-column-count-in-initial-section-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/tables-lists-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/tables-lists.html: Removed.
  • platform/ios-sim-deprecated/accessibility/text-line-no-ignored-elements-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/text-line-no-ignored-elements.html: Removed.
  • platform/ios-sim-deprecated/accessibility/text-marker-list-item-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/text-marker-list-item.html: Removed.
  • platform/ios-sim-deprecated/accessibility/text-marker-validation-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/text-marker-validation.html: Removed.
  • platform/ios-sim-deprecated/accessibility/text-role-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/text-role.html: Removed.
  • platform/ios-sim-deprecated/accessibility/textfield-in-axvalue-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/textfield-in-axvalue.html: Removed.
  • platform/ios-sim-deprecated/accessibility/toggle-button-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/toggle-button.html: Removed.
  • platform/ios-sim-deprecated/accessibility/url-test-expected.txt: Removed.
  • platform/ios-sim-deprecated/accessibility/url-test.html: Removed.
  • platform/ios-simulator/accessibility: Copied from LayoutTests/platform/ios-sim-deprecated/accessibility.
  • platform/ios-simulator/accessibility/svg-group-element-with-title.html:
9:09 PM Changeset in webkit [179982] by Darin Adler
  • 22 edits in trunk/Source/WebCore

Streamline and simplify SVGSVGElement and related classes
​https://bugs.webkit.org/show_bug.cgi?id=141463

Reviewed by Antti Koivisto.

  • dom/Document.cpp: Removed unneeded include of SVGSVGElement.h.
  • loader/FrameLoader.cpp: Ditto.
  • rendering/RenderBoxModelObject.cpp: Ditto.
  • rendering/svg/RenderSVGForeignObject.cpp: Ditto.
  • svg/SVGImageElement.cpp: Ditto.
  • svg/SVGMarkerElement.cpp: Ditto.
  • svg/SVGPathElement.cpp: Ditto.
  • svg/SVGPatternElement.cpp: Ditto.
  • svg/SVGTransform.cpp: Ditto.
  • page/FrameView.cpp:

(WebCore::FrameView::scrollToAnchor): Updated to call the SVGSVGElement function
named scrollToAnchor (was setupInitialView). Also refactored to avoid repeating
the expression frame().document() so often.

  • platform/graphics/FloatSize.h: Added operator/.
  • svg/SVGDocument.cpp:

(WebCore::SVGDocument::rootElement): Rearranged to use early return.
(WebCore::SVGDocument::zoomAndPanEnabled): Ditto.
(WebCore::SVGDocument::startPan): Ditto. Also used FloatPoint math instead
of breaking things apart into x and y.
(WebCore::SVGDocument::updatePan): Ditto.

  • svg/SVGDocument.h: Removed some unneeded includes and forward declarations.

Moved function bodies out of the class to make it more readable. Renamed
m_translate to m_panningOffset and made it a FloatSize instead of FloatPoint.

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::startAnimations): Use a modern for loop
and update since timeContainer() now returns a reference.

  • svg/SVGSVGElement.cpp: Removed many unneeded includes.

(WebCore::SVGSVGElement::SVGSVGElement): Moved initialization of scalars to
the class definition. Updated since m_timerContainer is a Ref (later should
change it to be a std::unique_ptr or just directly contained in SVGSVGElement).
(WebCore::SVGSVGElement::~SVGSVGElement): Removed comment that doesn't say much,
but is worded in a confusing way.
(WebCore::SVGSVGElement::contentScriptType): Use NeverDestroyed instead of
DEPRECATED_DEFINE_STATIC_LOCAL.
(WebCore::SVGSVGElement::contentStyleType): Ditto.
(WebCore::SVGSVGElement::viewport): Streamlined a bit.
(WebCore::SVGSVGElement::pixelUnitToMillimeterX): Ditto.
(WebCore::SVGSVGElement::pixelUnitToMillimeterY): Ditto.
(WebCore::SVGSVGElement::currentView): Changed to return a reference.
(WebCore::SVGSVGElement::frameForCurrentScale): Added. Helper for the two
functions below.
(WebCore::SVGSVGElement::currentScale): Updated to use frameForCurrentScale.
(WebCore::SVGSVGElement::setCurrentScale): Ditto.
(WebCore::SVGSVGElement::setCurrentTranslate): Optimized the case where there
is no change to the translation. Also changed the data member's name to
m_currentTranslate to more directly match the DOM API naming.
(WebCore::SVGSVGElement::parseAttribute): Simplified the parsing a bit, and
changed to pass a reference to SVGZoomAndPan::parseAttribute.
(WebCore::SVGSVGElement::svgAttributeChanged): Tweaked formatting and removed
code that converts the renderer pointer to a RenderObject* unnecessarily.
(WebCore::SVGSVGElement::suspendRedraw): Removed FIXME about implementing this,
since we don't really plan to do that.
(WebCore::SVGSVGElement::unsuspendRedraw): Ditto.
(WebCore::SVGSVGElement::unsuspendRedrawAll): Ditto.
(WebCore::SVGSVGElement::forceRedraw): Ditto.
(WebCore::SVGSVGElement::collectIntersectionOrEnclosureList): Changed return
type to Ref, and pass in a function instead of an enumeration value.
(WebCore::SVGSVGElement::getIntersectionList): Updated for above.
(WebCore::SVGSVGElement::getEnclosureList): Ditto.
(WebCore::SVGSVGElement::checkIntersection): Use && instead of early return
for the null check.
(WebCore::SVGSVGElement::checkEnclosure): Ditto.
(WebCore::SVGSVGElement::createSVGLength): Use initialization list syntax
for greater brevity.
(WebCore::SVGSVGElement::createSVGAngle): Ditto.
(WebCore::SVGSVGElement::createSVGPoint): Ditto.
(WebCore::SVGSVGElement::createSVGMatrix): Ditto.
(WebCore::SVGSVGElement::createSVGRect): Ditto.
(WebCore::SVGSVGElement::createSVGTransform): Removed unneeded explicit
constructor invocation.
(WebCore::SVGSVGElement::createSVGTransformFromMatrix): Removed unneeded cast.
(WebCore::SVGSVGElement::insertedInto): Updated since timeContainer() now
returns a reference.
(WebCore::SVGSVGElement::setCurrentTime): Use isfinite instead of isnan, so
we won't store infinity as the current time.
(WebCore::SVGSVGElement::currentViewBoxRect): Renamed locals and changed
to use initializer lists for brevity.
(WebCore::SVGSVGElement::currentViewportSize): Streamlined code by using
initializer lists, using local variables only for things used more than once,
and using the / operator defined above.
(WebCore::SVGSVGElement::viewBoxToViewTransform): Use the concatenate function
in a way that is more straightforward, rather than doing it with a temporary.
(WebCore::SVGSVGElement::scrollToAnchor): Renamed this from
setupInitialView.
(WebCore::SVGSVGElement::inheritViewAttributes): Changed this to work with
references rather than pointers.
(WebCore::SVGSVGElement::getElementById): Use getAllElementsById as the
FIXME comment suggested for better efficiency when there are a lot of descendants
of the <svg> element at the cost of making it less efficient if there are
a lot of elements all with the desired ID, but not inside the <svg> element.
(WebCore::SVGSVGElement::isValid): Moved here from the header.

  • svg/SVGSVGElement.h: Removed unneeded forward declarations. Moved the

animated properties to the top of the file, then other DOM, the other
public members. Changed return types to references and Ref. Moved
function bodies out of the class definition. Made createSVGNumber inline.

  • svg/SVGViewElement.cpp: Removed unneeded includes.

(WebCore::SVGViewElement::isSupportedAttribute): Deleted.
(WebCore::SVGViewElement::parseAttribute): Changed to not rely on
isSupportedAttribute. Eventually I will do this in all the SVG classes.

  • svg/SVGViewSpec.cpp: Removed unneeded include of SVGSVGElement.h.

(WebCore::SVGViewSpec::parseViewSpec): Updated for change in the name
of the parse function in the SVGZoomAndPan class.

  • svg/SVGZoomAndPan.cpp:

(WebCore::SVGZoomAndPan::isKnownAttribute): Deleted.
(WebCore::SVGZoomAndPan::addSupportedAttributes): Deleted.
(WebCore::SVGZoomAndPan::parse): Renamed from parseZoomAndPan since
this is a member of the SVGZoomAndPan class and also has an argument
of SVGZoomAndPanType.
(WebCore::SVGZoomAndPan::parseAttributeValue): Added. Helper so the
template function is not so big. Also write it in a simpler way.
(WebCore::SVGZoomAndPan::ref): Deleted.
(WebCore::SVGZoomAndPan::deref): Deleted.
(WebCore::SVGZoomAndPan::setZoomAndPan): Deleted.

  • svg/SVGZoomAndPan.h: Removed unneeded includes. Reformatted the enum.

Moved function bodies out of the class definition. Removed many unneeded
functions.

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::insertedInto): Updated since timeContainer
now returns a reference rather than a pointer.

8:37 PM Changeset in webkit [179981] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL gardenging. Need to mark pointer/hover media query tests as failure.
These tests have been failed since r179055.

  • platform/efl/TestExpectations:
7:53 PM Changeset in webkit [179980] by Darin Adler
  • 18 edits
    2 adds
    10 deletes in trunk

SVGUseElement follow-up improvements
​https://bugs.webkit.org/show_bug.cgi?id=141382

Reviewed by Antti Koivisto.

Source/WebCore:

  • loader/cache/CachedSVGDocumentClient.h: Removed unneeded forward declaration.
  • page/EventHandler.cpp: Removed unneeded include of SVGUseElement.h.
  • rendering/svg/RenderSVGViewportContainer.cpp: Ditto.
  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::clearTargetDependencies): Removed too-specific
check that assumed that SVG elements in shadow trees are always for <use> elements.
This amounted to an unneeded optimization that could be removed with no bad effect.

  • svg/SVGElement.cpp:

(WebCore::SVGElement::correspondingElement): Removed the assertions so this could
be used more freely outside of cases where the shadow tree state is fully consistent.
It's fine to have this just be a mechanical getter; there's nothing super-tricky
here that needs to be caught by the assertion.
(WebCore::SVGElement::title): Removed unneeded special handling for titles inside
the shadow tree.

  • svg/SVGGElement.cpp:

(WebCore::SVGGElement::create): Added an overload that doesn't require explicitly
passing in the tag name.

  • svg/SVGGElement.h: Ditto.
  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::create): Ditto.

  • svg/SVGSVGElement.h: Ditto.
  • svg/SVGUseElement.cpp: Removed a lot of unneeded includes.

(WebCore::SVGUseElement::SVGUseElement): Removed code to initialize some booleans.
We do that in the class definition now.
(WebCore::SVGUseElement::create): Removed the code that calls the
ensureUserAgentShadowRoot function unconditionally. That's properly done when
needed; no need to do it here.
(WebCore::SVGUseElement::~SVGUseElement): Removed unneeded code to destroy the
shadow tree (that happens automatically) and simplified the code to stop loading
the external document.
(WebCore::SVGUseElement::isSupportedAttribute): Deleted.
(WebCore::SVGUseElement::parseAttribute): Simplified this. Removed assumptions
about the intersection of various sets of attributes, and also removed the
isSupportedAttribute function. This seems to serve no purpose here, or in any
other SVG element class. I plan to remove it everywhere over time.
(WebCore::isWellFormedDocument): Deleted.
(WebCore::SVGUseElement::insertedInto): Simplified code by removing all the
special cases during initial parsing, and did the invalidation here rather than
deferring it to didNotifySubtreeInsertions. Added a call to the new function,
updateExternalDocument, since that won't do anything when the element is not
in a document.
(WebCore::SVGUseElement::didNotifySubtreeInsertions): Deleted.
(WebCore::SVGUseElement::removedFrom): Added code to call clearShadowTree and
updateExternalDocument. Both are efficient when doing nothing, and both are
appropriate since the element is no longer in a document.
(WebCore::SVGUseElement::referencedDocument): Deleted. No longer needed.
(WebCore::SVGUseElement::externalDocument): Streamlined the logic here, removing
multiple unneeded checks.
(WebCore::SVGUseElement::transferSizeAttributesToTargetClone): Renamed since
"target clone" is clear enough within this class, without explicitly stating
"shadow tree". All the clones are in the shadow tree.
(WebCore::SVGUseElement::svgAttributeChanged): Removed unneeded code calling
isSupportedAttribute. Changed the code that detects changes in href to just
call updateExternalDocument (for the document URL) and invalidateShadowTree
(for the fragment). Also updated the transferSizeAttributesToTargetClone logic
to only trigger on width and height and updated names.
(WebCore::SVGUseElement::willAttachRenderers): Updated for the new name of
m_shouldRebuildShadowTree and added a call through to the base class.
(WebCore::createAllowedElementSet): Added. A more efficient way to implement
the initialization of the set for isDisallowedElement.
(WebCore::isDisallowedElement): Simplified this by using the function above,
and also overloaded for both SVGElement and Element for a tiny efficiency boost.
(WebCore::SVGUseElement::clearShadowTree): Renamed form clearResourceReferences.
This is a much more straightforward name. Also deleted the code that sets the
m_needsShadowTreeRecreation flag to false. That should be done by the build
function, not here.
(WebCore::SVGUseElement::buildPendingResource): Made this just invalidate the
shadow tree now instead of explicitly building it.
(WebCore::SVGUseElement::updateShadowTree): Moved the code to create a shadow
tree here from buildPendingResource. ALso changed the logic so that we
always blow away the old shadow tree. Moved the comment about rebuilding things
every time here. Updated the code to use the findTarget and cloneTarget functions,
eliminating the buildShadowTree function entirely. Moved the call to
transferSizeAttributesToShadowTreeTargetClone inside cloneTarget. Also updated
for the name change for m_shouldRebuildShadowTree.
(WebCore::SVGUseElement::targetClone): Renamed from shadowTreeTargetClone.
No need to emphasize "shadow tree" since that's where all clones are.
(WebCore::isDirectReference): Streamlined a bit using "using namespace".
(WebCore::SVGUseElement::toClipPath): Rewrote to use early return and updated
for name changes. Also used ASCIILiteral.
(WebCore::SVGUseElement::rendererClipChild): Changed local variable names.
(WebCore::removeDisallowedElementsFromSubtree): Wrote the iteration in a
slightly more idiomatic style.
(WebCore::SVGUseElement::findTarget): Added. This new function implements
the rule for finding a valid target for a use element. This replaces logic
that was duplicated in two different places and it also includes all the
rules that were formerly in the isValidTarget function. Also, this implements
a correct check for a cycle that handles cases the code in isValidTarget did not.
(WebCore::SVGUseElement::isValidTarget): Deleted.
(WebCore::SVGUseElement::cloneTarget): Added. Helper function used both when
cloning the target of the top level <use> elements and for other <use> elements
inside the shadow tree.
(WebCore::cloneDataAndChildren): Added. Helper function that allows both the
<use> and <symbol> element expanding functions to be shorter and share more code.
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Removed unneeded checks
of cachedDocumentIsStillLoading. Used the new findTarget function, which handles
finding the target cross-document correctly. Removed the incorrect use of
referencedDocument when creating new elements and finding targets. Refactored
to use the new cloneDataAndChildren function and also moved the code that removes
the special attributes here, replacing the transferAttributesToShadowTreeReplacement
function. Made a few other simplifications.
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree): Ditto, just like the
<use> changes only simpler.
(WebCore::SVGUseElement::transferEventListenersToShadowTree): Made this const.
Removed unneeded assertions.
(WebCore::SVGUseElement::invalidateShadowTree): Updated for name change.
(WebCore::SVGUseElement::invalidateDependentShadowTrees): Removed assertion.
(WebCore::SVGUseElement::transferAttributesToShadowTreeReplacement): Deleted.
(WebCore::SVGUseElement::selfHasRelativeLengths): Tweaked names.
(WebCore::SVGUseElement::notifyFinished): Removed the inDocument check, since
this function will only be called for elements that are in a document.
(WebCore::SVGUseElement::cachedDocumentIsStillLoading): Deleted.
(WebCore::SVGUseElement::finishParsingChildren): Removed the code that calls
buildPendingResource here. Shadow tree updating is driven solely by renderer
generation now.
(WebCore::SVGUseElement::updateExternalDocument): Replaced setCachedDocument
with this. This function knows how to load a different document if the URL
has changed, or leave it alone if not, and also stop the load if it should.
(WebCore::SVGUseElement::isValid): Moved this here from the header, since it's
always being called virtually.
(WebCore::SVGUseElement::haveLoadedRequiredResources): Ditto.
(WebCore::SVGUseElement::setHaveFiredLoadEvent): Ditto.
(WebCore::SVGUseElement::haveFiredLoadEvent): Ditto.
(WebCore::SVGUseElement::svgLoadEventTimer): Ditto.

  • svg/SVGUseElement.h: Removed unneeded include. Moved the animated properties

to the top of the class because they are public DOM API and so are logical to
list first. I'd like to do that for other classes too over time. Changed to
derive privately from CachedSVGDocumentClient. Made the function
invalidateDependentShadowTrees private. Removed didNotifySubtreeInsertions,
isSupportedAttribute, clearResourceReferences, buildShadowTree,
transferAttributesToShadowTreeReplacement, isParserInserted, and
m_wasInsertedByParser. Added updateExternalDocument, cloneTarget, targetClone,
updateShadowTree, and clearShadowTree. Also did a couple other renames,
including renaming m_cachedDocument to m_externalDocument.

  • svg/svgtags.in: Removed constructorNeedsCreatedByParser from the <use>

element since we don't have to handle constructing by the parser specially.

LayoutTests:

Modified some tests to be reference tests since the change in implementation slightly changed
the behavior, but not in a way that matters. Other similar updates.

  • TestExpectations: Expect a progression in imported/mozilla/svg/dynamic-use-02.svg.
  • platform/gtk/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png: Removed.
  • platform/gtk/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Removed.
  • platform/gtk/svg/custom/use-property-synchronization-crash-expected.png: Removed.
  • platform/ios-sim-deprecated/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Removed.
  • platform/ios-simulator/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Removed.
  • platform/mac-mountainlion/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Removed.
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png: Removed.
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Removed.
  • platform/mac/svg/custom/use-property-synchronization-crash-expected.png: Removed.
  • svg/animations/use-animate-width-and-height-expected.txt: Updated to expect the new expression

name from the modified test.

  • svg/animations/use-animate-width-and-height.html: THe state of the shadow root now depends on

layout, so force layout before inspecting it.

  • svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.xhtml: Added.
  • svg/custom/relative-sized-shadow-tree-content-with-symbol.xhtml: Made this no longer be a

repaint test. Not sure why we are using those in so many cases. Also made it be a reference test.

  • svg/custom/use-property-synchronization-crash-expected.svg: Added.
  • svg/custom/use-property-synchronization-crash-expected.txt: Removed.
7:46 PM Changeset in webkit [179979] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Mark multi-column failing tests to Failure.
Those tests have been failing since r167808.

  • platform/efl/TestExpectations:
6:33 PM Changeset in webkit [179978] by diorahman@rockybars.com
  • 3 edits
    2 adds in trunk

CSS selector JIT compilation support for :lang()
​https://bugs.webkit.org/show_bug.cgi?id=140818

Reviewed by Benjamin Poulain.

Source/WebCore:

Add the JIT support for :lang(), to ensure :lang() no longer force the engine to
the slow path.

Test: fast/selectors/lang-chained-multiple.html

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
Get rid of the FunctionType::CannotCompile
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsInLanguage):

LayoutTests:

  • fast/selectors/lang-chained-multiple-expected.txt: Added.
  • fast/selectors/lang-chained-multiple.html: Added.
6:25 PM Changeset in webkit [179977] by achristensen@apple.com
  • 3 edits in trunk/Source/WebCore

Fix more weak external symbol errors.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • page/make_settings.pl:

(printGetterAndSetter):
Remove some WEBCORE_EXPORT macros.

5:46 PM Changeset in webkit [179976] by Lucas Forschler
  • 14 edits in branches/safari-600.5-branch

Merged r177377. rdar://problem/19526158

5:25 PM Changeset in webkit [179975] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

iOS build fix.

Unreviewed.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView inputAssistantItem]):
(-[WKContentView _inputAssistantItem]):

5:09 PM Changeset in webkit [179974] by achristensen@apple.com
  • 7 edits in trunk/Source/WebCore

Do not export functions defined in headers.
This prevents weak external symbol errors in some configurations.

  • dom/Range.h:

(WebCore::Range::startContainer):
(WebCore::Range::startOffset):
(WebCore::Range::endContainer):
(WebCore::Range::endOffset):

  • inspector/InspectorController.h:
  • page/Settings.h:

(WebCore::Settings::setMediaKeysStorageDirectory):

  • page/make_settings.pl:

(printGetterAndSetter):

  • platform/network/cocoa/ProtectionSpaceCocoa.h:

(WebCore::ProtectionSpace::encodingRequiresPlatformData):

  • platform/text/TextEncoding.h:

(WebCore::TextEncoding::decode):
Removed WEBCORE_EXPORT macros.

4:46 PM Changeset in webkit [179973] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION: Clicking selected item in the sidebar second time should scroll to the corresponding line
​https://bugs.webkit.org/show_bug.cgi?id=140280

Patch by Nikita Vasilyev <Nikita Vasilyev> on 2015-02-11
Reviewed by Brian Burg.

  • UserInterface/Views/ContentViewContainer.js:

(WebInspector.ContentViewContainer.prototype.showContentView):
Perform scolling regardless of the navigation history. Since scrolling source code doesn't introduce a BackForwardEntry,
it's possible that the actual content view has a different scroll position.

3:57 PM Changeset in webkit [179972] by Chris Dumez
  • 16 edits in trunk/Source

[WK2] Add logging to validate the network cache efficacy (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=141345
<rdar://problem/19632080>

Reviewed by Sam Weinig.

Source/WebCore:

Add a few more diagnostic logging keys for the network cache efficacy
logging.

Source/WebKit2:

Add diagnostic logging messages to validate the network cache efficacy.
The following 4 messages are added:

  • networkCache / retrieval / success
  • networkCache / retrieval / unhandledRequestFailure
  • networkCache / retrieval / noLongerInCacheFailure
  • networkCache / retrieval / unusableCachedEntryFailure

The messages are sent via IPC from the NetworkProcess to the UIProcess,
where the WebPageProxy code already handles diagnostic messages sent by
the WebProcess.

3:40 PM Changeset in webkit [179971] by weinig@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION(r179166): Crash when accessing document.dir on a document with no elements
<rdar://problem/19804351>
​https://bugs.webkit.org/show_bug.cgi?id=141480

Reviewed by Chris Dumez.

Source/WebCore:

Test: fast/dom/document-dir-empty-document-crash.html

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::dir):
Don't unnecessarily dereference the documentElement. is<HTMLHtmlElement>() will handle null just fine.

LayoutTests:

  • fast/dom/document-dir-empty-document-crash-expected.txt: Added.
  • fast/dom/document-dir-empty-document-crash.html: Added.
3:14 PM Changeset in webkit [179970] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

<​https://webkit.org/b/141492> extract-localizable-strings.pl shouldn't update the target file if the contents haven't changed

Avoid updating the target file if the contents haven't changed. This prevents Xcode from copying the identical
file into the framework and resigning it, which avoids the resulting relinking of all targets that depend on
the framework.

Reviewed by Dan Bernstein.

  • extract-localizable-strings.pl: Write our output to a temporary file. If the output differs from the

existing contents of the target file, move the temporary file over the target file. Otherwise, delete
the temporary file.

3:12 PM Changeset in webkit [179969] by Lucas Forschler
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merged r179750. rdar://problem/19739067

3:06 PM Changeset in webkit [179968] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-600.5-branch

Merged r179706. rdar://problem/19739067

3:02 PM Changeset in webkit [179967] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

The callee frame helpers in DFG::SpeculativeJIT should be available to other JITs
​https://bugs.webkit.org/show_bug.cgi?id=141493

Reviewed by Michael Saboff.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::calleeFrameSlot): Deleted.
(JSC::DFG::SpeculativeJIT::calleeArgumentSlot): Deleted.
(JSC::DFG::SpeculativeJIT::calleeFrameTagSlot): Deleted.
(JSC::DFG::SpeculativeJIT::calleeFramePayloadSlot): Deleted.
(JSC::DFG::SpeculativeJIT::calleeArgumentTagSlot): Deleted.
(JSC::DFG::SpeculativeJIT::calleeArgumentPayloadSlot): Deleted.
(JSC::DFG::SpeculativeJIT::calleeFrameCallerFrame): Deleted.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::calleeFrameSlot):
(JSC::AssemblyHelpers::calleeArgumentSlot):
(JSC::AssemblyHelpers::calleeFrameTagSlot):
(JSC::AssemblyHelpers::calleeFramePayloadSlot):
(JSC::AssemblyHelpers::calleeArgumentTagSlot):
(JSC::AssemblyHelpers::calleeArgumentPayloadSlot):
(JSC::AssemblyHelpers::calleeFrameCallerFrame):

3:01 PM Changeset in webkit [179966] by matthew_hanson@apple.com
  • 3 edits in branches/safari-600.5-branch/Source/JavaScriptCore

Merge r179576, r179648. rdar://problem/19709578

2:56 PM Changeset in webkit [179965] by rniwa@webkit.org
  • 4 edits in trunk/Websites/perf.webkit.org

New perf dashboard shows too much space around interesting data points
​https://bugs.webkit.org/show_bug.cgi?id=141487

Reviewed by Chris Dumez.

Revise the y-axis range adjustment algorithm in r179913. Instead of showing the entire moving average,
show the current time series excluding points in the series outside the moving average envelope.

  • public/v2/app.js:

(App.Pane._computeChartData): Don't deal with missing moving average or enveloping strategy here.
(App.Pane._computeMovingAverageAndOutliers): Set isOutliner to true on all data points in the current
time series if the point lies outside the moving average envelope. Don't expose the moving average or
the envelope computed for this purpose if they're not set by the user.

  • public/v2/data.js:

(TimeSeries.prototype.minMaxForTimeRange): Takes a boolean argument, ignoreOutlier. When the flag is set
to true, min/max computation will ignore any point in the series with non-falsy "isOutliner" property.

  • public/v2/interactive-chart.js:

(App.InteractiveChartComponent._constructGraphIfPossible): Unsupport hideMovingAverage and hideEnvelope.
(App.InteractiveChartComponent._computeYAxisDomain): Removed the commented out code. Also moved the code
to deal with showFullYAxis here.
(App.InteractiveChartComponent._minMaxForAllTimeSeries): Rewrote the code. Takes ignoreOutliners as an
argument instead of directly inspecting showFullYAxis.

2:51 PM Changeset in webkit [179964] by Lucas Forschler
  • 2 edits in branches/safari-600.5-branch/Source/WebKit/win

Merged r179841. rdar://problem/19771791

2:48 PM Changeset in webkit [179963] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-600.5-branch

Merged r179772. rdar://problem/19771772

2:48 PM Changeset in webkit [179962] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/win

[WinCairo] Accelerated compositing should be disabled when graphics card does not support it.
​https://bugs.webkit.org/show_bug.cgi?id=140667

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2015-02-11
Reviewed by Alex Christensen.

  • WebCoreSupport/AcceleratedCompositingContext.cpp:

(AcceleratedCompositingContext::scrollNonCompositedContents):
(AcceleratedCompositingContext::acceleratedCompositingAvailable):

  • WebCoreSupport/AcceleratedCompositingContext.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged):

2:43 PM Changeset in webkit [179961] by Lucas Forschler
  • 2 edits in branches/safari-600.5-branch/Source/WebKit2

Merged r179736. rdar://problem/19771783

2:40 PM Changeset in webkit [179960] by Lucas Forschler
  • 1 edit in branches/safari-600.5-branch/Source/WebCore/rendering/RenderQuote.cpp

Clarify logic after r179959.

2:24 PM Changeset in webkit [179959] by Lucas Forschler
  • 6 edits
    2 copies in branches/safari-600.5-branch

Merged r179691. rdar://problem/19739061

2:15 PM Changeset in webkit [179958] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Turn recent assertions into release assertions to help track down crash in DocumentLoader::stopLoadingForPolicyChange()
​https://bugs.webkit.org/show_bug.cgi?id=141484
<rdar://problem/13811738>

Reviewed by Andy Estes.

Turn recent assertions into release assertions to help track down crash in
DocumentLoader::stopLoadingForPolicyChange(). This should increase the
likelyhood of tripping them so that we better understand why this happens.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::detachFromFrame):

1:48 PM Changeset in webkit [179957] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

SetupVarargsFrame should not assume that an inline stack frame would have identical layout to a normal stack frame
​https://bugs.webkit.org/show_bug.cgi?id=141485

Reviewed by Oliver Hunt.

The inlineStackOffset argument was meant to make it easy for the DFG to use this helper for
vararg calls from inlined code, but that doesn't work since the DFG inline call frame
doesn't actually put the argument count at the JSStack::ArgumentCount offset. In fact there
is really no such thing as an inlineStackOffset except when we OSR exit; while the code is
running the stack layout is compacted so that the stackOffset is not meaningful.

  • jit/JITCall.cpp:

(JSC::JIT::compileSetupVarargsFrame):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileSetupVarargsFrame):

  • jit/SetupVarargsFrame.cpp:

(JSC::emitSetupVarargsFrameFastCase):

  • jit/SetupVarargsFrame.h:
1:45 PM Changeset in webkit [179956] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[MSE] SampleMap::addRange() returns an inverted iterator_range, possibly causing a crash when that iterator_range is traversed.
​https://bugs.webkit.org/show_bug.cgi?id=141479
rdar://problem/19067597

Reviewed by Chris Dumez.

When looking backwards through a presentationOrder map to find samples, we then reverse our iterators
and put them in an iterator_range to return to the caller. But in addition to reversing the iterators
themselves, we also need to put them in the iterator_range in reverse order, so that when the caller
iterates from iterator_range.first -> iterator_range.second, they don't end up off the end of the
the underlying storage.

  • Modules/mediasource/SampleMap.cpp:

(WebCore::PresentationOrderSampleMap::findSamplesWithinPresentationRangeFromEnd):

1:36 PM Changeset in webkit [179955] by timothy_horton@apple.com
  • 5 edits
    2 adds in trunk

REGRESSION (iOS 8): PDFs embedded in <object>/<embed> tag don't load at all
​https://bugs.webkit.org/show_bug.cgi?id=141457
<rdar://problem/18221851>

Reviewed by Alexey Proskuryakov.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::objectContentType):
On iOS, if we don't know what to do with a PDF-in-object, treat it as an image.

  • TestExpectations:
  • fast/replaced/pdf-as-object-and-embed-expected.html: Added.
  • fast/replaced/pdf-as-object-and-embed.html: Added.
  • platform/ios-simulator-wk2/TestExpectations:

Add a test that ensures that WebKit2 on iOS treats <object>, <embed>,
and <img> the same when rendering a PDF.

1:33 PM Changeset in webkit [179954] by Lucas Forschler
  • 10 edits
    2 copies in branches/safari-600.5-branch

Merged r179627. rdar://problem/19720096

1:28 PM Changeset in webkit [179953] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-600.5-branch

Merged r179597. rdar://problem/19720061

1:14 PM Changeset in webkit [179952] by Lucas Forschler
  • 4 edits in branches/safari-600.5-branch/Source/WebKit2

Merged r179586. rdar://problem/19771799

1:12 PM Changeset in webkit [179951] by Lucas Forschler
  • 1 edit
    1 copy in branches/safari-600.5-branch/LayoutTests

Merged r179587. rdar://problem/19709589

1:11 PM Changeset in webkit [179950] by Lucas Forschler
  • 7 edits
    1 copy in branches/safari-600.5-branch

Merged r179569. rdar://problem/19709589

1:00 PM Changeset in webkit [179949] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-600.5-branch

Merged r179711. rdar://problem/19709603

12:54 PM Changeset in webkit [179948] by Lucas Forschler
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merged r179563. <rdar://problem/19739078>

12:34 PM Changeset in webkit [179947] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Improve the showFrameTree() output slightly
​https://bugs.webkit.org/show_bug.cgi?id=141482

Reviewed by Zalan Bujtas.

Have showFrameTree() show the Frame's RenderView so it can be correlated with
layer dumps, and show styleRecalc and needsLayout state.

  • page/FrameTree.cpp:

(printFrames):

  • page/FrameView.cpp:

(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive): Add an explanatory
comment about why we don't walk the Frame tree.

12:31 PM Changeset in webkit [179946] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

Make run-jsc-stress-tests --remote work with make-based runner
​https://bugs.webkit.org/show_bug.cgi?id=141079

Reviewed by Darin Adler.

  • Scripts/run-javascriptcore-tests:

(runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.

  • Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,

except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
to avoid code duplication.

12:29 PM Changeset in webkit [179945] by achristensen@apple.com
  • 3 edits in trunk/Source/WebCore

Stop using WebCore.exp.in on Mac and iOS.
​https://bugs.webkit.org/show_bug.cgi?id=141413

Reviewed by Dan Bates.

  • Configurations/Base.xcconfig:

Make symbols hidden by default unless exported by WEBCORE_EXPORT macros.

  • platform/PlatformExportMacros.h:

Start using WEBCORE_EXPORT on Mac and iOS (but not Windows yet).

12:13 PM Changeset in webkit [179944] by ChangSeok Oh
  • 3 edits
    2 adds in trunk

Div having contentEditable and display:flex cannot be edited if it is empty.
​https://bugs.webkit.org/show_bug.cgi?id=141218

Reviewed by Ryosuke Niwa.

Source/WebCore:

RenderFlexibleBox should be treated as a candidate for visible position. Visible selection
in an editable area is recalculated whenever an inner value of div is changed. If the inner value
is empty, the visible selection recalculated with DeleteSelectionCommand::m_endingPostion
is not correct. Because RenderBlockFlow is only considered but not RenderFlexibleBox
in Position::isCandidate so that a calculated ending VisiblePosition for an editable div
having "display : flex" goes weird and VisibleSelection is empty accordingly.

Test: fast/events/key-events-in-editable-flexbox.html

  • dom/Position.cpp:

(WebCore::Position::isCandidate):

LayoutTests:

This tests if an editable flexbox can be reedited after erasing all texts in it.

  • fast/events/key-events-in-editable-flexbox-expected.txt: Added.
  • fast/events/key-events-in-editable-flexbox.html: Added.
12:12 PM Changeset in webkit [179943] by clopez@igalia.com
  • 2 edits in trunk

[CMake] Don't set flag fuse-ld on the C/C++ compiler flags, but on the linker flags.
​https://bugs.webkit.org/show_bug.cgi?id=141481

Reviewed by Csaba Osztrogonác.

  • Source/cmake/OptionsCommon.cmake: Move -fuse-ld=gold to the linker flags.
12:09 PM Changeset in webkit [179942] by ChangSeok Oh
  • 7 edits in trunk/Source

Activate ReliefLogger of a memory pressure handler for linux system.
​https://bugs.webkit.org/show_bug.cgi?id=123611

Reviewed by Anders Carlsson.

Source/WebCore:

Put more logs for the time when a system goes under memory pressure or viceversa.

No new tests since no engine behavior changed.

  • platform/linux/MemoryPressureHandlerLinux.cpp:

(WebCore::MemoryPressureHandler::waitForMemoryPressureEvent): Wait a memory pressure event
from cgroup in a seperated thread. Once a pressure event happens, respondToMemoryPressure()
would be called to get back some resources.
(WebCore::MemoryPressureHandler::install): Install memoryPressureHandler module
to make it work.

Source/WebKit2:

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
Make the parameter, shouldEnableMemoryPressureReliefLogging shareable with COCOA else systems.
(WebKit::WebProcessCreationParameters::encode): ditto.
(WebKit::WebProcessCreationParameters::decode): ditto.

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createNewWebProcess): Set shouldEnableMemoryPressureReliefLogging
to true for linux system.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess): Pass the shouldEnableMemoryPressureReliefLogging value
to MemoryPressureHandler::ReliefLogger::setLoggingEnabled().

11:44 AM Changeset in webkit [179941] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Final preparations to switch to WEBCORE_EXPORT.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.h:

Export the vtable and a function.

11:43 AM Changeset in webkit [179940] by Lucas Forschler
  • 5 edits in branches/safari-600.1.17-branch/Source

Versioning.

11:42 AM Changeset in webkit [179939] by Lucas Forschler
  • 1 copy in tags/Safari-600.1.17.8

New Tag.

10:42 AM Changeset in webkit [179938] by Lucas Forschler
  • 2 edits in branches/safari-600.1.17-branch/Source/WebCore

Merged r174295.

10:36 AM Changeset in webkit [179937] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

performance.now can crash if accessed from a window that has navigated
<rdar://problem/16892506>
​https://bugs.webkit.org/show_bug.cgi?id=141478

Reviewed by Alexey Proskuryakov.

Test: fast/performance/performance-now-crash-on-navigated-window.html

  • page/Performance.cpp:

(WebCore::Performance::now):
Check for a null frame, which can happen when the window has been navigated.

10:33 AM Changeset in webkit [179936] by weinig@apple.com
  • 1 edit
    5 adds in trunk/LayoutTests

performance.now can crash if accessed from a window that has navigated
<rdar://problem/16892506>
​https://bugs.webkit.org/show_bug.cgi?id=141478

Reviewed by Alexey Proskuryakov.

  • fast/performance/performance-now-crash-on-navigated-window-expected.txt: Added.
  • fast/performance/performance-now-crash-on-navigated-window.html: Added.
  • fast/performance/resources: Added.
  • fast/performance/resources/initialFrame.html: Added.
  • fast/performance/resources/secondFrame.html: Added.

Add test for calling performance.now() on from a navigated window.

10:09 AM Changeset in webkit [179935] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

10:07 AM Changeset in webkit [179934] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.18

New tag.

10:03 AM Changeset in webkit [179933] by ap@apple.com
  • 7 edits
    4 adds
    2 deletes in trunk

URL::setUser and URL::setPass don't percent encode
​https://bugs.webkit.org/show_bug.cgi?id=141453
rdar://problem/14844503&16551802&19623145

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/url/url-credentials-escaping.html

http/tests/xmlhttprequest/basic-auth-credentials-escaping.html

Start adding some code that performs escaping in a way that matches the URL Standard.
Right now, it's only used where we failed to do any escaping at all, and over time,
we'll be moving towards a new implementation.

  • html/URLUtils.h:

(WebCore::URLUtils<T>::username):
(WebCore::URLUtils<T>::password):

  • platform/URL.cpp:

(WebCore::isSchemeFirstChar):
(WebCore::URL::user):
(WebCore::URL::pass):
(WebCore::URL::encodedUser):
(WebCore::URL::encodedPass):
(WebCore::URL::setUser):
(WebCore::URL::setPass):
(WebCore::encodeWithURLEscapeSequences):

  • platform/URL.h:

LayoutTests:

  • fast/url/url-credentials-escaping-expected.txt: Added.
  • fast/url/url-credentials-escaping.html: Added.

This change is most directly testable via URL API.

  • http/tests/xmlhttprequest/basic-auth-credentials-escaping-expected.txt: Added.
  • http/tests/xmlhttprequest/basic-auth-credentials-escaping.html: Added.

Verify that this doesn't break XMLHttpRequest authentication.

  • fast/dom/DOMURL/invalid-url-getters-expected.txt: Removed.
  • fast/dom/DOMURL/invalid-url-getters.html: Removed.
  • fast/dom/DOMURL/url-origin-expected.txt:
  • fast/dom/DOMURL/url-origin.html:

Removed tests for invalid URLs, there is no such thing with URL API.

9:58 AM Changeset in webkit [179932] by Yusuke Suzuki
  • 2 edits in trunk/Source/WebKit2

[GTK][EFL] Suppress a warning of unused params
​https://bugs.webkit.org/show_bug.cgi?id=141474

Reviewed by Darin Adler.

Drop unused argument name, directoryName.

  • UIProcess/API/APIWebsiteDataStore.cpp:

(API::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):

9:41 AM WebKitGTK/SpeedUpBuild edited by clopez@igalia.com
(diff)
9:31 AM WebKitGTK/SpeedUpBuild edited by clopez@igalia.com
(diff)
9:11 AM Changeset in webkit [179931] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

run-jsc-stress tests should detect the number of processors on the remote machine too
​https://bugs.webkit.org/show_bug.cgi?id=141196

Reviewed by Darin Adler.

  • Scripts/run-javascriptcore-tests:

(runJSCStressTests): Pass through the --child-processes argument.

  • Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function

to detect the number of local and remote processors with the same algorithm.
Additionally introduced $numChildProcesses to emphasize it isn't necessarily
same as $numProcessors.

9:10 AM Changeset in webkit [179930] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

run-jsc-stress-tests should pass JSC_timeout to remote hosts
​https://bugs.webkit.org/show_bug.cgi?id=141164

Reviewed by Darin Adler.

Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.

  • Scripts/run-jsc-stress-tests:
9:09 AM Changeset in webkit [179929] by achristensen@apple.com
  • 4 edits in trunk/Source/WebCore

Add a few more WEBCORE_EXPORT macros for debug and iOS builds.

  • page/EventHandler.h:
  • page/ios/WebEventRegion.h:
  • platform/sql/SQLiteDatabaseTracker.h:
8:41 AM Changeset in webkit [179928] by Darin Adler
  • 2 edits in trunk/Source/WebCore

REGRESSION(r179476): It broke the !ENABLE(PICTURE_SIZES) build
​https://bugs.webkit.org/show_bug.cgi?id=141327

Reviewed by Csaba Osztrogonác.

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
Put #if around use of m_sizesAttribute.

8:39 AM WebKitGTK/SpeedUpBuild edited by clopez@igalia.com
(diff)
8:35 AM WebKitGTK/SpeedUpBuild edited by clopez@igalia.com
(diff)
8:12 AM Changeset in webkit [179927] by Csaba Osztrogonác
  • 4 edits in trunk/Source/bmalloc

bmalloc buildfix on 32 bit Linux (x86/ARM)
​https://bugs.webkit.org/show_bug.cgi?id=141472

Reviewed by Gyuyoung Kim.

  • bmalloc/Algorithm.h:

(bmalloc::roundUpToMultipleOf):

  • bmalloc/FixedVector.h:

(bmalloc::FixedVector::clear):

  • bmalloc/Sizes.h:

(bmalloc::Sizes::sizeClass):

7:34 AM Changeset in webkit [179926] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r179921.
​https://bugs.webkit.org/show_bug.cgi?id=141473

caused about 30 test failures on yosemite and mavericks
(Requested by alexchristensen on #webkit).

Reverted changeset:

"Div having contentEditable and display:flex cannot be edited
if it is empty."
​https://bugs.webkit.org/show_bug.cgi?id=141218
​http://trac.webkit.org/changeset/179921

7:05 AM Changeset in webkit [179925] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

[Win] Unreviewed build fix.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
5:54 AM Changeset in webkit [179924] by commit-queue@webkit.org
  • 6 edits
    10 adds in trunk/LayoutTests

Unreviewed GTK+ Gardening 11 February.

Patch by Marcos Chavarría Teijeiro <​chavarria1991@gmail.com> on 2015-02-11

  • platform/gtk/TestExpectations:
  • platform/gtk/editing/pasteboard/onpaste-text-html-expected.txt: Rebaselined after r179168.
  • platform/gtk/fast/css/outline-auto-empty-rects-expected.txt: Added. Rebaselined after r177774.
  • platform/gtk/fast/css/pseudo-invalid-form-invalidation-optimization-expected.txt: Added. Rebaselined after r177664.
  • platform/gtk/fast/css/pseudo-valid-form-invalidation-optimization-expected.txt: Added. Rebaselined after r177664.
  • platform/gtk/fast/forms/basic-buttons-expected.txt: Rebaselined after r178078.
  • platform/gtk/fast/line-grid/line-align-right-edges-expected.txt: Rebaselined after r177128.
  • platform/gtk/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Added. Rebaselined after r177774.
  • platform/gtk/fast/table/022-expected.txt: Added. Rebaselined after r177774.
  • platform/gtk/fast/text/wbr-pre-expected.txt: Added. Rebaselined after r177774.
  • platform/gtk/fast/text/whitespace/019-expected.txt: Added. Rebaselined after r177774.
  • platform/gtk/fast/text/whitespace/023-expected.txt: Added. Rebaselined after r177774.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Added. Rebaselined after r177490.
  • platform/gtk/svg/custom/glyph-selection-arabic-forms-expected.txt: Added. Rebaselined after r177774.
  • platform/gtk/svg/custom/glyph-selection-lang-attribute-expected.txt: Rebaselined after r177490.
4:50 AM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com
(diff)
4:15 AM Changeset in webkit [179923] by gyuyoung.kim@samsung.com
  • 20 edits
    1 add in trunk

[EFL][GTK] Use bmalloc instead of tcmalloc
​https://bugs.webkit.org/show_bug.cgi?id=140162

Reviewed by Carlos Garcia Campos.

.:

Add bmalloc directory to build list.

  • CMakeLists.txt: Define BMALLOC_DIR directory.
  • Source/CMakeLists.txt: Add bmalloc path to sub-directories list.

Source/bmalloc:

Support to use bmalloc on EFL and GTK ports.

  • CMakeLists.txt: Added.
  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::allocate):

Fix unused return value caused by posix_memalign().

  • bmalloc/AsyncTask.h:
  • bmalloc/BoundaryTag.h:

(bmalloc::BoundaryTag::clear):

  • bmalloc/Chunk.h:

Change Traits::Page with Traits::PageType in order to fix
-fpermitive build error on EFL and GTK port.

  • bmalloc/EndTag.h:

(bmalloc::EndTag::operator=):

  • bmalloc/Line.h: ditto.
  • bmalloc/MediumTraits.h:
  • bmalloc/Page.h: ditto.
  • bmalloc/PerThread.h:

EFL port doesn't support has_include definition yet.
Define HAVE_PTHREAD_MACHDEP_H according to check if has_include is supported.

  • bmalloc/SmallTraits.h: ditto.
  • bmalloc/VMAllocate.h:

(bmalloc::vmDeallocatePhysicalPages):
(bmalloc::vmAllocatePhysicalPages):

  • bmalloc/Vector.h:

(bmalloc::Vector<T>::push):
(bmalloc::Vector<T>::reallocateBuffer):

Source/WTF:

  • wtf/CMakeLists.txt:
  • wtf/FastMalloc.cpp:

Enable bmalloc on GTK ports, but EFL port will enable it when bmalloc supports
memory statistics.

2:02 AM WebKitGTK/2.4.x edited by tpopela@redhat.com
(diff)
1:03 AM Changeset in webkit [179922] by Carlos Garcia Campos
  • 9 edits
    4 adds in trunk

[GTK] Add default color chooser implementation using GtkColorChooserDialog
​https://bugs.webkit.org/show_bug.cgi?id=141392

Reviewed by Gustavo Noronha Silva.

.:

Enable INPUT_TYPE_COLOR by default for GTK+ port.

  • Source/cmake/OptionsGTK.cmake:

Source/WebKit2:

  • PlatformGTK.cmake: Add new files to compilation.
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::createColorPicker): Call WebColorPickerGtk::create().

  • UIProcess/gtk/WebColorPickerGtk.cpp: Added.

(WebKit::WebColorPickerGtk::create):
(WebKit::WebColorPickerGtk::WebColorPickerGtk):
(WebKit::WebColorPickerGtk::~WebColorPickerGtk):
(WebKit::WebColorPickerGtk::cancel): Set initial color.
(WebKit::WebColorPickerGtk::endPicker): Destroy the color chooser dialog.
(WebKit::WebColorPickerGtk::didChooseColor): Notify the client.
(WebKit::WebColorPickerGtk::colorChooserDialogRGBAChangedCallback):
Update the selected color.
(WebKit::WebColorPickerGtk::colorChooserDialogResponseCallback):
Cancel or finish the operation depending on the dialog response.
(WebKit::WebColorPickerGtk::showColorPicker): Create a
GtkColorChooserDialog to handle the color picker operation.

  • UIProcess/gtk/WebColorPickerGtk.h: Added.

(WebKit::WebColorPickerGtk::initialColor):

Tools:

Enable INPUT_TYPE_COLOR by default for GTK+ port.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Unskip input color tests.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/forms/color/input-appearance-color-expected.txt: Added.
12:51 AM Changeset in webkit [179921] by ChangSeok Oh
  • 3 edits
    2 adds in trunk

Div having contentEditable and display:flex cannot be edited if it is empty.
​https://bugs.webkit.org/show_bug.cgi?id=141218

Reviewed by Ryosuke Niwa.

Source/WebCore:

RenderFlexibleBox should be treated as a candidate for visible position. Visible selection
in an editable area is recalculated whenever an inner value of div is changed. If the inner value
is empty, the visible selection recalculated with DeleteSelectionCommand::m_endingPostion
is not correct. Because RenderBlockFlow is only considered but not RenderFlexibleBox
in Position::isCandidate so that a calculated ending VisiblePosition for an editable div
having "display : flex" goes weird and VisibleSelection is empty accordingly.

Test: fast/events/key-events-in-editable-flexbox.html

  • dom/Position.cpp:

(WebCore::Position::isCandidate):

LayoutTests:

This tests if an editable flexbox can be reedited after erasing all texts in it.

  • fast/events/key-events-in-editable-flexbox-expected.txt: Added.
  • fast/events/key-events-in-editable-flexbox.html: Added.
12:36 AM Changeset in webkit [179920] by dburkart@apple.com
  • 2 edits in trunk/LayoutTests

http/tests/cache/disk-cache-validation.html generates a lot of Perl errors
​https://bugs.webkit.org/show_bug.cgi?id=141393

Reviewed by Darin Adler.

  • http/tests/cache/resources/generate-response.cgi:
12:25 AM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com
(diff)
12:01 AM Changeset in webkit [179919] by commit-queue@webkit.org
  • 17 edits in trunk/Source

Unreviewed, rolling out r179910.
​https://bugs.webkit.org/show_bug.cgi?id=141464

Caused assertions on debug bots (Requested by ap on #webkit).

Reverted changeset:

"[WK2] Add logging to validate the network cache efficacy
(Part 2)"
​https://bugs.webkit.org/show_bug.cgi?id=141345
​http://trac.webkit.org/changeset/179910

Note: See TracTimeline for information about the timeline view.