Context Navigation

← Previous Period
Next Period →

Timeline

Feb 17, 2015:

11:04 PM Changeset in webkit [180257] by benjamin@webkit.org

6 edits in trunk/Source/JavaScriptCore

Clean up OSRExit's considerAddingAsFrequentExitSite()
https://bugs.webkit.org/show_bug.cgi?id=141690

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-02-17
Reviewed by Anders Carlsson.

Looks like some code was removed from CodeBlock::tallyFrequentExitSites()
and the OSRExit were left untouched.

This patch cleans up the two loops and remove the boolean return
on considerAddingAsFrequentExitSite().

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::tallyFrequentExitSites):

dfg/DFGOSRExit.h:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSite):

dfg/DFGOSRExitBase.cpp:

(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSiteSlow):

dfg/DFGOSRExitBase.h:

(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSite):

ftl/FTLOSRExit.h:

(JSC::FTL::OSRExit::considerAddingAsFrequentExitSite):

9:38 PM Changeset in webkit [180256] by Chris Dumez

4 edits in trunk/Source/WebCore

Rename ScopedEventQueue::instance() to singleton()
https://bugs.webkit.org/show_bug.cgi?id=141738

Reviewed by Daniel Bates.

Rename ScopedEventQueue::instance() to singleton(), as per coding
style. Also modernize the code a little bit.

dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchScopedEvent):

dom/ScopedEventQueue.cpp:

(WebCore::ScopedEventQueue::singleton):
(WebCore::ScopedEventQueue::dispatchAllEvents):
(WebCore::ScopedEventQueue::incrementScopingLevel):
(WebCore::ScopedEventQueue::decrementScopingLevel):
(WebCore::ScopedEventQueue::ScopedEventQueue): Deleted.
(WebCore::ScopedEventQueue::~ScopedEventQueue): Deleted.
(WebCore::ScopedEventQueue::instance): Deleted.

dom/ScopedEventQueue.h:

(WebCore::EventQueueScope::EventQueueScope):
(WebCore::EventQueueScope::~EventQueueScope):

9:31 PM Changeset in webkit [180255] by Chris Dumez

2 edits in trunk/Source/WebCore

Remove dead code from FontCache
https://bugs.webkit.org/show_bug.cgi?id=141741

Reviewed by Daniel Bates.

Remove dead code from FontCache:

getFontFamilyForCharacters() has no implementation.
SimpleFontFamily is unused.

platform/graphics/FontCache.h:

8:23 PM Changeset in webkit [180254] by Chris Dumez

2 edits in trunk/Source/WebCore

Rename CSSPropertyAnimationWrapperMap::instance() to singleton()
https://bugs.webkit.org/show_bug.cgi?id=141739

Reviewed by Simon Fraser.

Rename CSSPropertyAnimationWrapperMap::instance() to singleton(), as
per coding style.

page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::singleton):
(WebCore::CSSPropertyAnimation::blendProperties):
(WebCore::CSSPropertyAnimation::animationOfPropertyIsAccelerated):
(WebCore::CSSPropertyAnimation::animatableShorthandsAffectingProperty):
(WebCore::CSSPropertyAnimation::propertiesEqual):
(WebCore::CSSPropertyAnimation::getPropertyAtIndex):
(WebCore::CSSPropertyAnimation::getNumProperties):
(WebCore::CSSPropertyAnimationWrapperMap::instance): Deleted.

8:17 PM Changeset in webkit [180253] by mmaxfield@apple.com

3 edits in trunk/LayoutTests

Update editing/selection/fake-drag.html after r177774
https://bugs.webkit.org/show_bug.cgi?id=141605

Reviewed by Alexey Proskuryakov.

Text metrics changed, so the locations where the "user" interacts with the page should
change accordingly.

editing/selection/fake-drag.html:
platform/mac/TestExpectations:

7:50 PM WebKitGTK/2.8.x edited by clopez@igalia.com

fix typo (diff)

7:12 PM Changeset in webkit [180252] by ap@apple.com

3 edits in trunk/LayoutTests

inspector/css/stylesheet-with-mutations.html is a flaky timeout/crash
https://bugs.webkit.org/show_bug.cgi?id=141601

Skipping the test; it's flaky in such a way that I'm concerned about it breaking
subsequent tests.

platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:

6:59 PM Changeset in webkit [180251] by ddkilzer@apple.com

1 edit
1 delete in trunk/Source/WebCore

REGRESSION (r180224): Remove unused generate-export-file script
<http://webkit.org/b/141491>

generate-export-file: Removed. This was the script used to

create WebCore.exp files for iOS since we couldn't compile a
host-side tool to run like we did on Mac OS X. Dont't tell
anyone, but this was an epic hack I created while merging open
source changes to the internal iOS WebKit repository around the
time that the WebCore.exp.in file was created. End of an era.

6:58 PM Changeset in webkit [180250] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

SoftLinking.h: Update copyright and license; clean up whitespace

platform/win/SoftLinking.h:

6:52 PM Changeset in webkit [180249] by ap@apple.com

2 edits in trunk/Source/JavaScriptCore

Debug build fix after r180247.

ftl/FTLLowerDFGToLLVM.cpp: (JSC::FTL::LowerDFGToLLVM::loweringFailed):

6:45 PM Changeset in webkit [180248] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r180184.
https://bugs.webkit.org/show_bug.cgi?id=141733

Caused infinite recursion on js/function-apply-aliased.html
(Requested by ap_ on #webkit).

Reverted changeset:

"REGRESSION(r180060): C Loop crashes"
https://bugs.webkit.org/show_bug.cgi?id=141671
http://trac.webkit.org/changeset/180184

6:38 PM Changeset in webkit [180247] by msaboff@apple.com

4 edits in trunk/Source/JavaScriptCore

CrashTracer: DFG_CRASH beneath JSC::FTL::LowerDFGToLLVM::compileNode
https://bugs.webkit.org/show_bug.cgi?id=141730

Reviewed by Geoffrey Garen.

Added a new failure handler, loweringFailed(), to LowerDFGToLLVM that reports failures
while processing DFG lowering. For debug builds, the failures are logged identical
to the way the DFG_CRASH() reports them. For release builds, the failures are reported
and that FTL compilation is terminated, but the process is allowed to continue.
Wrapped calls to loweringFailed() in a macro LOWERING_FAILED so the function and
line number are reported at the point of the inconsistancy.

Converted instances of DFG_CRASH to LOWERING_FAILED.

dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl): Added lowerDFGToLLVM() failure check that
will fail the FTL compile.

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
Added new member variable, m_loweringSucceeded, to stop compilation on the first
reported failure.

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):

ftl/FTLLowerDFGToLLVM.h:

Added check for compilation failures and now report those failures via a boolean
return value.

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::createPhiVariables):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileUpsilon):
(JSC::FTL::LowerDFGToLLVM::compilePhi):
(JSC::FTL::LowerDFGToLLVM::compileDoubleRep):
(JSC::FTL::LowerDFGToLLVM::compileValueRep):
(JSC::FTL::LowerDFGToLLVM::compileValueToInt32):
(JSC::FTL::LowerDFGToLLVM::compilePutLocal):
(JSC::FTL::LowerDFGToLLVM::compileArithAddOrSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithDiv):
(JSC::FTL::LowerDFGToLLVM::compileArithMod):
(JSC::FTL::LowerDFGToLLVM::compileArithMinOrMax):
(JSC::FTL::LowerDFGToLLVM::compileArithAbs):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compileArrayifyToStructure):
(JSC::FTL::LowerDFGToLLVM::compileGetById):
(JSC::FTL::LowerDFGToLLVM::compileGetMyArgumentByVal):
(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
(JSC::FTL::LowerDFGToLLVM::compileArrayPush):
(JSC::FTL::LowerDFGToLLVM::compileArrayPop):
(JSC::FTL::LowerDFGToLLVM::compileNewArray):
(JSC::FTL::LowerDFGToLLVM::compileToString):
(JSC::FTL::LowerDFGToLLVM::compileMakeRope):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::LowerDFGToLLVM::compileSwitch):
(JSC::FTL::LowerDFGToLLVM::compare):
(JSC::FTL::LowerDFGToLLVM::boolify):
(JSC::FTL::LowerDFGToLLVM::opposite):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::isArrayType):
(JSC::FTL::LowerDFGToLLVM::exitValueForAvailability):
(JSC::FTL::LowerDFGToLLVM::exitValueForNode):
(JSC::FTL::LowerDFGToLLVM::setInt52):
Changed DFG_CRASH() to LOWERING_FAILED(). Updated related control flow as appropriate.

(JSC::FTL::LowerDFGToLLVM::loweringFailed): New error reporting member function.

4:38 PM Changeset in webkit [180246] by bshafiei@apple.com

5 edits in branches/safari-600.4.10-branch/Source

Versioning.

4:25 PM Changeset in webkit [180245] by bshafiei@apple.com

1 copy in tags/Safari-600.4.10.1

New tag.

3:06 PM Changeset in webkit [180244] by Chris Dumez

3 edits in trunk/Source/WebCore

Slight CachedPage class clean up
https://bugs.webkit.org/show_bug.cgi?id=141693

Reviewed by Andreas Kling.

Slight CachedPage class clean up:

Drop unnecessary m_timeStamp data member
Protect m_needsCaptionPreferencesChanged data member with #if ENABLE(VIDEO_TRACK)
Merge destroy() method into the destructor as this is the only caller
Update clear() to reset 2 data members that were missing

3:02 PM Changeset in webkit [180243] by andersca@apple.com

2 edits in trunk/Source/WebCore

Silence two -Wcast-qual warnings.
rdar://problem/19758266

platform/ios/wak/WKUtilities.c:

(WKRetain):
(WKRelease):

2:54 PM Changeset in webkit [180242] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

REGRESSION (r178595): Clicking on DD highlights sometimes do not work
https://bugs.webkit.org/show_bug.cgi?id=141728
<rdar://problem/19825372>

Reviewed by Beth Dakin.

UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _cancelImmediateActionIfNeeded]):
(-[WKImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
The change that r178595 intended to make was purely that things that we
have no immediate actions for should cancel the immediate action gesture recognizer.
Moving the DataDetectors activation code as well breaks strict ordering
of immediate action callbacks vs. shouldUseActionsWithContext: that they depend on.

2:41 PM Changeset in webkit [180241] by Alan Bujtas

10 edits in trunk/Source/WebCore

Minor RenderTable* class cleanups.
https://bugs.webkit.org/show_bug.cgi?id=141707

Reviewed by Andreas Kling.

Use in-class initializer where possible.
Remove redundant code.
Move multiline implementations out of class declaration.

No change in functionality.

rendering/RenderTableCaption.cpp:

(WebCore::RenderTableCaption::insertedIntoTree):
(WebCore::RenderTableCaption::willBeRemovedFromTree):
(WebCore::RenderTableCaption::containingBlockLogicalWidthForContent): Deleted.

rendering/RenderTableCaption.h:
rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::RenderTableCell):

rendering/RenderTableCell.h:

(WebCore::RenderTableCell::colSpan):
(WebCore::RenderTableCell::rowSpan):
(WebCore::RenderTableCell::setCol):
(WebCore::RenderTableCell::col):
(WebCore::RenderTableCell::section):
(WebCore::RenderTableCell::table):
(WebCore::RenderTableCell::rowIndex):
(WebCore::RenderTableCell::styleOrColLogicalWidth):
(WebCore::RenderTableCell::logicalHeightForRowSizing):
(WebCore::RenderTableCell::isBaselineAligned):
(WebCore::RenderTableCell::borderAdjoiningTableStart):
(WebCore::RenderTableCell::borderAdjoiningTableEnd):
(WebCore::RenderTableCell::borderAdjoiningCellBefore):
(WebCore::RenderTableCell::borderAdjoiningCellAfter):

rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::RenderTableCol):

rendering/RenderTableCol.h:

(WebCore::RenderTableCol::enclosingColumnGroupIfAdjacentBefore):
(WebCore::RenderTableCol::enclosingColumnGroupIfAdjacentAfter):

rendering/RenderTableRow.h:

(WebCore::RenderTableRow::setRowIndex):
(WebCore::RenderTableRow::rowIndex):
(WebCore::RenderTableRow::borderAdjoiningTableStart):
(WebCore::RenderTableRow::borderAdjoiningTableEnd):
(WebCore::RenderTableRow::table):
(WebCore::RenderTableSection::firstRow):
(WebCore::RenderTableSection::lastRow):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::RenderTableSection):
(WebCore::RenderTableSection::dirtiedRows):
(WebCore::RenderTableSection::dirtiedColumns):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::nodeAtPoint):

rendering/RenderTableSection.h:

(WebCore::CellSpan::CellSpan):
(WebCore::RenderTableSection::borderAdjoiningTableStart):
(WebCore::RenderTableSection::borderAdjoiningTableEnd):
(WebCore::RenderTableSection::cellAt):
(WebCore::RenderTableSection::primaryCellAt):
(WebCore::RenderTableSection::rowRendererAt):
(WebCore::RenderTableSection::outerBorderLeft):
(WebCore::RenderTableSection::outerBorderRight):
(WebCore::RenderTableSection::outerBorderTop):
(WebCore::RenderTableSection::outerBorderBottom):
(WebCore::RenderTableSection::numRows):
(WebCore::RenderTableSection::recalcCellsIfNeeded):
(WebCore::RenderTableSection::rowBaseline):
(WebCore::RenderTableSection::fullTableRowSpan):
(WebCore::CellSpan::start): Deleted.
(WebCore::CellSpan::end): Deleted.

2:31 PM Changeset in webkit [180240] by mmaxfield@apple.com

4 edits in trunk/Tools

Windows test results should not fall back to mac-mountainlion after r180176
https://bugs.webkit.org/show_bug.cgi?id=141719

Reviewed by Brent Fulgham.

BuildSlaveSupport/build.webkit.org-config/wkbuild.py:

(_should_file_trigger_build):

Scripts/webkitpy/port/win.py:

(WinPort.default_baseline_search_path):

Scripts/webkitpy/port/win_unittest.py:

(WinPortTest.test_baseline_search_path):

2:30 PM Changeset in webkit [180239] by dbates@webkit.org

3 edits in trunk/Tools

[iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
https://bugs.webkit.org/show_bug.cgi?id=141718

Reviewed by Alex Christensen.

We should only run layout tests if simctl can successfully boot and shutdown the testing device.

Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
Log a error and return False if we are unable to boot the simulator device so that the caller can take
appropriate action, say exit(3) before running any layout tests.

Scripts/webkitpy/xcode/simulator.py:

(Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
with the specified UDID.
(Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
with the specified UDID can successfully boot and shut down. We make at most two attempts to
boot and shut down the device, erasing the device between tries so as to restore the device
to a known good state.

2:13 PM Changeset in webkit [180238] by dbates@webkit.org

5 edits in trunk/Tools

run_webkit_tests.py should not know about iOS Simulator details
https://bugs.webkit.org/show_bug.cgi?id=141711

Reviewed by Alex Christensen.

Run_webkit_tests.py should only parse the iOS-specific command
line options --runtime and --device-type. Let the port-specific
logic in ios.py validate the parsed options and instantiate
internal data structures.

Currently run_webkit_tests.py parses the iOS-specific command
line options --runtime and --device-type, validates them, and
instantiates internal data structures from the parsed strings.
Instead the validation logic and instantiation of internal
data structures should be handled by the iOS port object.

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options): Remove logic to validate --runtime and --device-type
and instantiate internal data structures for them.

Scripts/webkitpy/port/driver.py:

(IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
respectively.

Scripts/webkitpy/port/ios.py: Sort the list of imports.

(IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
object from --runtime, if specified. Otherwise, instantiates a Runtime
object for the latest installed iphonesimulator SDK version.
(IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
object from --device-type, if specified. Otherwise, instantiates
a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
machine, respectively.
(IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
runtime is available to use.
(IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
and simulator_runtime for the iOS Simulator device type and runtime, respectively.

Scripts/webkitpy/xcode/simulator.py:

(Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
with a runtime identifier for the specified iOS version.

1:41 PM Changeset in webkit [180237] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

StackLayoutPhase should use CodeBlock::usesArguments rather than FunctionExecutable::usesArguments
https://bugs.webkit.org/show_bug.cgi?id=141721
rdar://problem/17198633

Reviewed by Michael Saboff.

I've seen cases where the two are out of sync. We know we can trust the CodeBlock::usesArguments because
we use it everywhere else.

No test because I could never reproduce the crash.

dfg/DFGGraph.h:

(JSC::DFG::Graph::usesArguments):

dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):

12:17 PM Changeset in webkit [180236] by Joseph Pecoraro

9 edits in trunk

Web Inspector: Improved Console Support for Bound Functions
https://bugs.webkit.org/show_bug.cgi?id=141635

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::getInternalProperties):
Expose internal properties of a JSBoundFunction.

LayoutTests:

inspector/model/remote-object-get-properties-expected.txt:
inspector/model/remote-object-get-properties.html:

Show that boundFunction has extra properties (targetFunction, boundThis, boundArgs).

inspector/model/remote-object-expected.txt:
inspector/model/remote-object.html:

Include a bound function. Much different from a function now though.

12:17 PM Changeset in webkit [180235] by Joseph Pecoraro

9 edits in trunk

Web Inspector: ES6: Improved Console Support for Promise Objects
https://bugs.webkit.org/show_bug.cgi?id=141634

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

inspector/InjectedScript.cpp:

(Inspector::InjectedScript::getInternalProperties):

inspector/InjectedScriptSource.js:

Include internal properties in previews. Share code
with normal internal property handling.

inspector/JSInjectedScriptHost.cpp:

(Inspector::constructInternalProperty):
(Inspector::JSInjectedScriptHost::getInternalProperties):
Provide internal state of Promises.

inspector/protocol/Runtime.json:

Provide an optional field to distinguish if a PropertyPreview
is for an Internal property or not.

Source/WebInspectorUI:

UserInterface/Protocol/RemoteObject.js:

For now just add Internal Properties and regular properties.
We will address the UI later.

LayoutTests:

inspector/model/remote-object-expected.txt:
inspector/model/remote-object.html:

Include more tests for Promises.

12:10 PM Changeset in webkit [180234] by fpizlo@apple.com

4 edits
3 adds in trunk/Source/JavaScriptCore

Throwing from an FTL call IC slow path may result in tag registers being clobbered on 64-bit CPUs
https://bugs.webkit.org/show_bug.cgi?id=141717
rdar://problem/19863382

Reviewed by Geoffrey Garen.

The best solution is to ensure that the engine catching an exception restores tag registers.

Each of these new test cases reliably crashed prior to this patch and they don't crash at all now.

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_catch):

llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter64.asm:
tests/stress/throw-from-ftl-call-ic-slow-path-cells.js: Added.
tests/stress/throw-from-ftl-call-ic-slow-path-undefined.js: Added.
tests/stress/throw-from-ftl-call-ic-slow-path.js: Added.

11:47 AM Changeset in webkit [180233] by commit-queue@webkit.org

2 edits
3 adds in trunk/LayoutTests

Unreviewed GTK Gardening 17th February.

https://bugs.webkit.org/show_bug.cgi?id=141712

Patch by Marcos Chavarría Teijeiro <chavarria1991@gmail.com> on 2015-02-17

platform/gtk/TestExpectations:
platform/gtk/accessibility/press-targets-center-point-expected.txt: Added. Rebaselined after r180107.
platform/gtk/svg/custom/glyph-selection-non-bmp-expected.txt: Added. Rebaselined after r177774.
platform/gtk/svg/text/textPathBoundsBug-expected.txt: Added. Rebaselined after r177774.

11:09 AM Changeset in webkit [180232] by Csaba Osztrogonác

2 edits in trunk/Source/JavaScriptCore

[ARM] Add the necessary setupArgumentsWithExecState after bug141332
https://bugs.webkit.org/show_bug.cgi?id=141714

Reviewed by Michael Saboff.

jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

11:07 AM Changeset in webkit [180231] by dino@apple.com

3 edits in trunk/Source/WebCore

REGRESSION: Video control fails to hide after playback begins in reflowable EPUB files
https://bugs.webkit.org/show_bug.cgi?id=141689
<rdar://problem/19689286>

Reviewed by Eric Carlson.

The iBooks app turns off the requirement for a user gesture
before triggering playback. When we moved to script-based
media controls there were a few regressions in this setup.
This makes them behave a lot more like iOS 7.

Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.setPlaying): We don't want to hide the controls
yet, just start a hiding timer.

Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.shouldHaveStartPlaybackButton): If we've ever
played before, we don't want to show the big start button. If we
are in the middle of construction, we do want to show it. We no
longer care about the case where you're not in setup and have
the relaxed restrictions (we still want to show the start button
in that case).
(ControllerIOS.prototype.showControls): When we show the controls,
make sure our timeline is up to date. This is necessary for the
cases where we automatically show the controls, such as when we hit
the end of a video.
(ControllerIOS.prototype.updateTime): Make sure to pass the forceUpdate
parameter on to the super-method.
(ControllerIOS.prototype.setPlaying):
(ControllerIOS.prototype.progressFillStyle): Deleted.

11:05 AM Changeset in webkit [180230] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.7.90

WebKitGTK+ 2.7.90

10:47 AM Changeset in webkit [180229] by Brent Fulgham

2 edits in trunk/LayoutTests

[Win] Document some accessibility and animation debug assertions (Unreviewed)

platform/win/TestExpectations:

10:42 AM Changeset in webkit [180228] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Only create the WebKit.framework symlink in PrivateFrameworks when the platform is iphoneos
https://bugs.webkit.org/show_bug.cgi?id=141710
<rdar://problem/19719748>

Reviewed by Andreas Kling.

Don't create the symlink when building for the simulator.

WebKit2.xcodeproj/project.pbxproj:

10:06 AM Changeset in webkit [180227] by dburkart@apple.com

2 edits in trunk/Tools

ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
https://bugs.webkit.org/show_bug.cgi?id=141672

Reviewed by David Kilzer.

asan/webkit-asan-ignore.txt:

10:05 AM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com

(diff)

9:57 AM WebKitGTK/2.8.x created by Carlos Garcia Campos

9:51 AM Changeset in webkit [180226] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.8

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.7.90 release.

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

gtk/NEWS: Add release notes for 2.7.90.

9:30 AM Changeset in webkit [180225] by Chris Dumez

23 edits in trunk/Source

Access MemoryPressureHandler global instance via a singleton() static member function
https://bugs.webkit.org/show_bug.cgi?id=141691

Reviewed by Andreas Kling.

Access MemoryPressureHandler global instance via a singleton() static
Source/WebCore:

member function as per coding style. Also make all other member
functions non-static as callers can just use singleton() to get the
instance and access methods. This avoid having to call
MemoryPressureHandler::singleton() from member functions.

bindings/js/ScriptController.cpp:

(WebCore::collectGarbageAfterWindowShellDestruction):

history/PageCache.cpp:

(WebCore::PageCache::canCache):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):

page/FrameView.cpp:

(WebCore::FrameView::willPaintContents):
(WebCore::FrameView::didPaintContents):
(WebCore::FrameView::computeCoverageRect):

platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::singleton):
(WebCore::MemoryPressureHandler::MemoryPressureHandler):
(WebCore::MemoryPressureHandler::releaseCriticalMemory):
(WebCore::memoryPressureHandler): Deleted.

platform/MemoryPressureHandler.h:

(WebCore::MemoryPressureHandler::setLowMemoryHandler):

platform/cocoa/MemoryPressureHandlerCocoa.mm:

(WebCore::MemoryPressureHandler::platformReleaseMemory):
(WebCore::MemoryPressureHandler::install):
(WebCore::MemoryPressureHandler::holdOff):
(WebCore::respondToMemoryPressureCallback):

platform/graphics/FontCache.cpp:

(WebCore::FontCache::purgeInactiveFontDataIfNeeded):

platform/ios/LegacyTileCache.mm:

(WebCore::LegacyTileCache::createTilesInActiveGrid):

platform/ios/LegacyTileGrid.mm:

(WebCore::LegacyTileGrid::shouldUseMinimalTileCoverage):

platform/ios/LegacyTileLayerPool.mm:

(WebCore::LegacyTileLayerPool::addLayer):

platform/ios/TileControllerMemoryHandlerIOS.cpp:

(WebCore::TileControllerMemoryHandler::tileControllerGainedUnparentedTiles):

platform/linux/MemoryPressureHandlerLinux.cpp:

(WebCore::MemoryPressureHandler::waitForMemoryPressureEvent):

Source/WebKit/mac:

member function.

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(+[WebView registerForMemoryNotifications]):
(+[WebView _isUnderMemoryPressure]):
(+[WebView _clearMemoryPressure]):
(+[WebView _shouldWaitForMemoryClearMessage]):
(WebInstallMemoryPressureHandler):

Source/WebKit2:

member function.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::lowMemoryHandler): Deleted.

NetworkProcess/NetworkProcess.h:
PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::initializeProcess):
(WebKit::PluginProcess::lowMemoryHandler): Deleted.

PluginProcess/PluginProcess.h:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateVisibleContentRects):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::processWillSuspend):

9:23 AM Changeset in webkit [180224] by achristensen@apple.com

5 edits
5 deletes in trunk

Remove WebCore.exp.in and clean up.
https://bugs.webkit.org/show_bug.cgi?id=141491

Reviewed by Andreas Kling.

Source/WebCore:

Configurations/WebCore.xcconfig:

Don't use exported symbols files.

DerivedSources.make:

Don't generate export files.

WebCore.exp.in: Removed.
WebCore.xcodeproj/project.pbxproj:

Removed WebCoreExportFileGenerator targets.

make-export-file-generator: Removed.

Tools:

Scripts/sort-export-file: Removed.
Scripts/webkitpy/style/checker.py:

(_all_categories):
(FileType):
(CheckerDispatcher._file_type):
(CheckerDispatcher._create_checker):
Don't check if the export files are sorted.

Scripts/webkitpy/style/checkers/exportfile.py: Removed.
Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.

9:09 AM Changeset in webkit [180223] by Brent Fulgham

2 edits in trunk/LayoutTests

Document some debug assertions in Accessibility tests (Unreviewed)

platform/win/TestExpectations:

8:53 AM Changeset in webkit [180222] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Tools

Merge r180221 - Unreviewed. Fix GTK+ make distcheck.

Do not exclude bmalloc directory from the tarball.

gtk/manifest.txt.in:

8:38 AM Changeset in webkit [180221] by Carlos Garcia Campos

2 edits in trunk/Tools

Unreviewed. Fix GTK+ make distcheck.

Do not exclude bmalloc directory from the tarball.

gtk/manifest.txt.in:

8:31 AM Changeset in webkit [180220] by gyuyoung.kim@samsung.com

3 edits
1 delete in trunk

[CMAKE] Remove CMakeLists.txt in WK1 port
https://bugs.webkit.org/show_bug.cgi?id=141617

Reviewed by Anders Carlsson.

Nobody uses CMake in WK1 port. Remove it.

CMakeLists.txt:

Source/WebKit:

CMakeLists.txt: Removed.

8:03 AM Changeset in webkit [180219] by mmaxfield@apple.com

4 edits in trunk/LayoutTests

Update svg/animations/animate-text-nested-transforms.html after r177774
https://bugs.webkit.org/show_bug.cgi?id=141686

Reviewed by Andreas Kling.

Text metrics are expected to change.

platform/mac/TestExpectations:
svg/animations/animate-text-nested-transforms-expected.txt:
svg/animations/script-tests/animate-text-nested-transforms.js:

(text.appendChild.rootSVGElement.appendChild.startSample):

8:01 AM Changeset in webkit [180218] by mmaxfield@apple.com

3 edits in trunk/LayoutTests

Update expected result of fast/forms/cursor-at-editable-content-boundary.html after r177774
https://bugs.webkit.org/show_bug.cgi?id=141684

Reviewed by Andreas Kling.

One check no longer fails, and another fails in the same way it did before (but with 1-different
measurement values)

platform/mac/TestExpectations:
platform/mac/fast/forms/cursor-at-editable-content-boundary-expected.txt:

5:44 AM Changeset in webkit [180217] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.8

Branch WebKitGTK+ for 2.8

4:11 AM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com

(diff)

3:57 AM Changeset in webkit [180216] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

Use HashMap::add instead of get/contains + set in DOMObjectCache
https://bugs.webkit.org/show_bug.cgi?id=141558

Rubber-stamped by Žan Doberšek.

bindings/gobject/DOMObjectCache.cpp:

(WebKit::getOrCreateDOMObjectCacheFrameObserver):
(WebKit::DOMObjectCache::put):

2:33 AM Changeset in webkit [180215] by Carlos Garcia Campos

2 edits in trunk/Tools

Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.

I forgot to add the return of a bool function.

TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:

(WebKitDOMNodeTest::testDOMCache):

1:57 AM Changeset in webkit [180214] by Carlos Garcia Campos

9 edits in trunk

[GTK] GObject DOM bindings object are cached forever
https://bugs.webkit.org/show_bug.cgi?id=141558

Reviewed by Sergio Villar Senin.

Source/WebCore:

Rework the DOMObjectCache to avoid having to manually clear the
objects when the frame is destroyed, using a FrameDestructionObserver
instead. When a new object associated to a Frame is added to the
cache, a FrameDestructionObserver is created for the frame if
needed, and the DOM object is tracked by the observer too. When
the frame is detached from the page all its objects are cleared,
and if the aren't additional references, the object is finalized
and removed from the cache normally.
This patch also simplifies and modernizes the code to make it
easier to read an maintain.

bindings/gobject/DOMObjectCache.cpp:

(WebKit::DOMObjectCacheData::DOMObjectCacheData): Add constructor
to initialize its members and simplify the callers.
(WebKit::DOMObjectCacheData::clearObject): Remove the references
added by the cache, ensuring the GObject is not finalized until
the method returns.
(WebKit::DOMObjectCacheData::refObject): Adds a reference owned by
the cache.
(WebKit::domObjectCacheFrameObservers): Map a frame to a FrameDestructionObserver.
(WebKit::getOrCreateDOMObjectCacheFrameObserver): Create a new
FrameDestructionObserver for the given Frame or return the
existing one.
(WebKit::domObjects): Map wrapped object to wrapper object.
(WebKit::DOMObjectCache::forget): Remove the wrapped object from
the cache.
(WebKit::DOMObjectCache::get): Return the wrapped object if it is
in the cache, increasing the cache references.
(WebKit::DOMObjectCache::put): Add the wrapper object to the cache
for the given wrapped object. If it's a Node and has a frame add
the node to the FrameDestructionObserver corresponding to the frame.
(WebKit::getFrameFromHandle): Deleted.
(WebKit::weakRefNotify): Deleted.
(WebKit::DOMObjectCache::clearByFrame): Deleted.
(WebKit::DOMObjectCache::~DOMObjectCache): Deleted.

bindings/gobject/DOMObjectCache.h:

Tools:

Add checks for all DOM objects to ensure they are not leaked. Also
add a dedicated test for the DOM Object Cache.

TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:

(WebKitDOMNodeFilterTest::testTreeWalker):
(WebKitDOMNodeFilterTest::testNodeIterator):

TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:

(WebKitDOMNodeTest::testHierarchyNavigation):
(WebKitDOMNodeTest::testInsertion):
(WebKitDOMNodeTest::testTagNames):
(WebKitDOMNodeTest::testDOMCache):
(registerTests):

TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:

(WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
(WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
(WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):

TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:

(testWebKitDOMObjectCache):
(beforeAll):

TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:

(documentLoadedCallback):

1:42 AM Changeset in webkit [180213] by ChangSeok Oh

2 edits in trunk/Source/WebCore

REGRESSION(r180050): It broke the !ENABLE(CSS_GRID_LAYOUT) build
https://bugs.webkit.org/show_bug.cgi?id=141647

Reviewed by Csaba Osztrogonác.

No new tests since this just fixes a build break.

dom/Position.cpp: Add a build guard ENABLE(CSS_GRID_LAYOUT) for RenderGrid.

(WebCore::Position::isCandidate):

12:58 AM Changeset in webkit [180212] by ap@apple.com

2 edits in trunk/LayoutTests

fast/selectors/nth-last-child-of-register-requirement.html is extremely slow in debug builds
https://bugs.webkit.org/show_bug.cgi?id=141695

TestExpectations: Fixed a copy/paste mistake.

Feb 16, 2015:

11:34 PM Changeset in webkit [180211] by Carlos Garcia Campos

8 edits in trunk

[GTK] WebKitFrame objects are never released
https://bugs.webkit.org/show_bug.cgi?id=141641

Reviewed by Martin Robinson.

Source/WebKit2:

Use a FrameDestructionObserver derived class to wrap our
WebKitFrame objects and delete them when the frame is destroyed,
instead of using willDestroyFrame callback of WKBundlePageLoaderClient
that has never worked.

WebProcess/InjectedBundle/API/gtk/WebKitFrame.cpp:

(webkitFrameGetWebFrame):

WebProcess/InjectedBundle/API/gtk/WebKitFramePrivate.h:
WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(webkitFrameGetOrCreate):
(webkitFrameDestroy):
(webkitWebPageCreate):
(willDestroyFrame): Deleted.

Tools:

Add a way to check GObjects leaks for WebProcess tests and check
WebKitFrame objects are not leaked.

TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:

(WebKitFrameTest::testMainFrame):
(WebKitFrameTest::testURI):
(WebKitFrameTest::testJavaScriptContext):

TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:

(WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
(runTest):

TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:

11:25 PM Changeset in webkit [180210] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Fix the !USE(IOSURFACE) build

Shared/mac/RemoteLayerBackingStore.mm:

SOFT_LINK_MAY_FAIL makes a function that will be unused if !USE(IOSURFACE).

11:17 PM Changeset in webkit [180209] by ap@apple.com

3 edits in trunk/LayoutTests

REGRESSION(?): inspector/css/selector-dynamic-specificity.html sometimes crashes
https://bugs.webkit.org/show_bug.cgi?id=141118

This happens on WK1 too.

platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:

10:42 PM Changeset in webkit [180208] by ap@apple.com

2 edits in trunk/LayoutTests

fast/selectors/nth-last-child-of-register-requirement.html is extremely slow in debug builds
https://bugs.webkit.org/show_bug.cgi?id=141695

TestExpectations: Marked as slow.

8:54 PM Changeset in webkit [180207] by Chris Dumez

5 edits in trunk/Source/WebCore

Keep all memory cache resources in ListHashSets
https://bugs.webkit.org/show_bug.cgi?id=141667

Reviewed by Andreas Kling.

Keep all memory cache resources in ListHashSets instead of manual linked
lists. This simplifies the code a lot and is also more efficient for
retrieving / removing particular CachedResources.

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):

loader/cache/CachedResource.h:
loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::pruneDeadResourcesToSize):
(WebCore::MemoryCache::removeFromLRUList):
(WebCore::MemoryCache::insertInLRUList):
(WebCore::MemoryCache::dumpLRULists):
(WebCore::MemoryCache::lruListFor): Deleted.

loader/cache/MemoryCache.h:

8:26 PM Changeset in webkit [180206] by benjamin@webkit.org

5 edits
10 adds in trunk

CSS JIT: finish :nth-last-child()
https://bugs.webkit.org/show_bug.cgi?id=141629

Reviewed by Andreas Kling.

Source/WebCore:

This patch adds the matcher for :nth-child(An+B of selector list) and
fix a small bug I discovered while working on it.

The matcher is straightforward: count the next siblings matching the selector,
nothing fancy.

While working on it I noticed I forgot the test for IsParsingChildrenFinished
on the simple version of :nth-last-child(). I add it in both matcher, write
a couple of tests, the first part of the tests now succeed, but the second part
fails...

What happened is:
1) We interupt the parsing to execute the JavaScript.

From there, we force the style resolution to get the computed style.

2) When resolving the style, the early check for isFinishedParsingChildren()

quits the function early. This is done *before* we marked the parent
for :nth-last-child() style resolution.

3) After the script, parsing resume and the following elements are added.
4) When resolving the style, only the new elements are marked dirty,

the elements pending their :nth-last-child() style never get udpated.

To fix the problem, I moved the test for FinishedParsingChildren after
the parent marking.

Honestly, those early return for FinishedParsingChildren need to be refined
and they should be tested properly. We should not do this kind of things
for Query for example.

Tests: fast/selectors/nth-last-child-cannot-match-during-parsing-1.html

fast/selectors/nth-last-child-cannot-match-during-parsing-2.html
fast/selectors/nth-last-child-of-cannot-match-during-parsing-1.html
fast/selectors/nth-last-child-of-cannot-match-during-parsing-2.html
fast/selectors/nth-last-child-of-register-requirement.html

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):
Fix the tree marking.

cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
The fragment creation was already done, all I had to do was
accept the compile.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
:nth-child() and :nth-last-child() with a selector list are heavier than :not()
and :matches(), move them accordingly.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthLastChild):
More the early return after the tree marking.

(WebCore::SelectorCompiler::setParentAffectedByLastChildOf):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthLastChildOf):
New matcher, nothing optimized yet.

LayoutTests:

fast/selectors/nth-last-child-cannot-match-during-parsing-1-expected.txt: Added.
fast/selectors/nth-last-child-cannot-match-during-parsing-1.html: Added.
fast/selectors/nth-last-child-cannot-match-during-parsing-2-expected.txt: Added.
fast/selectors/nth-last-child-cannot-match-during-parsing-2.html: Added.
fast/selectors/nth-last-child-of-cannot-match-during-parsing-1-expected.txt: Added.
fast/selectors/nth-last-child-of-cannot-match-during-parsing-1.html: Added.
fast/selectors/nth-last-child-of-cannot-match-during-parsing-2-expected.txt: Added.
fast/selectors/nth-last-child-of-cannot-match-during-parsing-2.html: Added.

Those test cover the bugs related to IsParsingChildrenFinished and style update.

I had to duplicate the tests to have a simple selector because :nth-last-child(n)
and :nth-last-child(2n) are optimized differently.

fast/selectors/nth-last-child-of-register-requirement-expected.txt: Added.
fast/selectors/nth-last-child-of-register-requirement.html: Added.

The ususal register pressure tests. This one is taken directly from
the :nth-child() tests, I just changed the expected values.

fast/selectors/several-nth-last-child.html:

Due to the changes with IsParsingChildrenFinished, this test can no longer
use body:nth-last-child() during parsing. I changed it to an async test.

8:20 PM Changeset in webkit [180205] by commit-queue@webkit.org

7 edits in trunk/Source/WebInspectorUI

Web Inspector: Tweak the styles on the Console
https://bugs.webkit.org/show_bug.cgi?id=140580

Use non-monospace (default sans-serif) font for console messages, but keep using monospace font for objects, functions, and anything else that presumably code.
Display all expandable objects on a separate row.

Patch by Nikita Vasilyev <Nikita Vasilyev> on 2015-02-16
Reviewed by Timothy Hatcher.

UserInterface/Views/ConsoleCommand.js:

(WebInspector.ConsoleCommand.prototype.decorateMessageElement):
(WebInspector.ConsoleCommand.prototype.toMessageElement):

UserInterface/Views/ConsoleGroup.js:

(WebInspector.ConsoleGroup.prototype.addMessage):

UserInterface/Views/ConsoleMessageImpl.js:

(WebInspector.ConsoleMessageImpl.prototype._format):
(WebInspector.ConsoleMessageImpl.prototype._isExpandable):
(WebInspector.ConsoleMessageImpl.prototype._formatParameter):
(WebInspector.ConsoleMessageImpl.prototype.append):
(WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):
(WebInspector.ConsoleMessageImpl.prototype.decorateMessageElement):
(WebInspector.ConsoleMessageImpl.prototype.toMessageElement):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsString): Deleted.

UserInterface/Views/LogContentView.css:

(.console-messages):
(.console-formatted-object):
(.expandable.source-code):
(.console-message):
(.console-item.selected::after):
(.console-messages:focus .console-item.selected::after):
(.console-user-command-result.console-log-level::before):
(.console-item::before):
(.console-message .bubble):
(.console-error-level):
(.console-error-level .section .header .title):
(.console-error-level::before):
(.console-warning-level):
(.console-warning-level .console-message-text):
(.console-warning-level::before):
(.console-user-command::before):
(.console-group-messages .section):
(.console-group-messages .section .header::before):
(.console-group-messages .section .header .title):
(.console-formatted-object, .console-formatted-node, .console-formatted-error, .console-formatted-map, .console-formatted-set, .console-formatted-weakmap):
(.outline-disclosure li):
(.outline-disclosure li.parent::before):
(.console-item): Deleted.
(.console-item.selected): Deleted.
(.console-messages:focus .console-item.selected): Deleted.
(.console-item.selected .console-message::after): Deleted.
(.console-messages:focus .console-item.selected .data-grid tr.selected): Deleted.
(.console-messages:focus .console-item.selected .console-message::after): Deleted.
(.console-message, .console-user-command): Deleted.
(.console-message::before, .console-user-command::before, .javascript-prompt::before, .console-group-title::before): Deleted.
(.console-group): Deleted.
(.console-debug-level .console-message-text): Deleted.
(.console-debug-level::before): Deleted.
(.console-group-messages .section .header): Deleted.
(.console-group-messages .outline-disclosure): Deleted.
(.console-group-messages .outline-disclosure > ol): Deleted.
(.outline-disclosure li.elements-drag-over .selection): Deleted.
(.outline-disclosure ol:focus li.selected .selection): Deleted.
(.outline-disclosure > ol): Deleted.

UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype._mousemove):
(WebInspector.LogContentView.prototype._updateMessagesSelection):
(WebInspector.LogContentView.prototype._isMessageVisible):
(WebInspector.LogContentView.prototype._isMessageSelected):
(WebInspector.LogContentView.prototype._selectAllMessages):
(WebInspector.LogContentView.prototype._unfilteredMessages):
(WebInspector.LogContentView.prototype._visibleMessages):
(WebInspector.LogContentView.prototype._filterMessages):
(WebInspector.LogContentView.prototype._leftArrowWasPressed):
(WebInspector.LogContentView.prototype._propertiesSectionDidUpdateContent):
(WebInspector.LogContentView.prototype._performSearch):

UserInterface/Views/Section.css:

(.section .header .title::before):
(.section.expanded .header .title::before):
(.section .header .title, .event-bar .header .title):
(.properties-tree li.parent::before):
(.section .header::before): Deleted.
(.section.expanded .header::before): Deleted.

6:30 PM Changeset in webkit [180204] by timothy_horton@apple.com

7 edits in trunk/Source/WebKit2

Sometimes RemoteLayerBackingStore ends up non-volatile while the process is suspended
<rdar://problem/19842957>
https://bugs.webkit.org/show_bug.cgi?id=141675

Reviewed by Simon Fraser.

Previously, it was possible to get a layer tree flush in between the
process suspension cleanup code making surfaces volatile and the process
actually being suspended (it was racy because the suspension requires
a few IPC round trips). Depending on how far through the flush we got,
we could sometimes end up either making new non-volatile backing store,
or switching some recently-made-volatile backing store back to non-volatile.
We don't want to have any non-volatile backing store while suspended.

UIProcess/ProcessThrottler.cpp:

(WebKit::ProcessThrottler::updateAssertion):
Inform the WebProcess when it's going from suspended to runnable state.

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::sendProcessDidResume):

UIProcess/WebProcessProxy.h:

Forward the message along.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::processWillSuspend):
(WebKit::WebProcess::cancelProcessWillSuspend):
(WebKit::WebProcess::setAllLayerTreeStatesFrozen):
(WebKit::WebProcess::processDidResume):
Freeze all of this process' pages' layer trees when we start trying to suspend,
and un-freeze them when either suspension is cancelled or we resume.

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

6:28 PM Changeset in webkit [180203] by timothy_horton@apple.com

6 edits in trunk/Source

Adopt CAMachPort-as-layer-contents
https://bugs.webkit.org/show_bug.cgi?id=141687
<rdar://problem/19393233>

Reviewed by Simon Fraser.

No new tests, just a performance bump.

platform/cocoa/MachSendRight.h:

(WebCore::MachSendRight::operator bool):
Add an operator bool() that checks if the underlying port is nonnull.

platform/spi/cocoa/QuartzCoreSPI.h:

Add some SPI.

Shared/mac/RemoteLayerBackingStore.h:
Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::decode):
If we have CAMachPort, just keep the MachSendRight around.

(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
If we have CAMachPort, make one and leak our send right into it. CAMachPort
will adopt the port and destroy it when needed.

(WebKit::RemoteLayerBackingStore::setBufferVolatility):
Tiny style fix.

6:21 PM Changeset in webkit [180202] by mmaxfield@apple.com

4 edits in trunk/LayoutTests

Update cross-frame http tests after r177774
https://bugs.webkit.org/show_bug.cgi?id=141679

Reviewed by Alexey Proskuryakov.

Simply a spacing change

http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt:
http/tests/security/cross-frame-access-callback-explicit-domain-ALLOW-expected.txt:
platform/mac/TestExpectations:

6:17 PM Changeset in webkit [180201] by mmaxfield@apple.com

3 edits in trunk/LayoutTests

Update accessibility/table-cells.html after r177774
https://bugs.webkit.org/show_bug.cgi?id=141680

Reviewed by Chris Fleizach.

Simply needs a rebaseline.

platform/mac/TestExpectations:
platform/mac/accessibility/table-cells-expected.txt:

6:10 PM Changeset in webkit [180200] by mmaxfield@apple.com

2 edits in trunk/LayoutTests

[OS X] Reordering TestExpectations

Unreviewed.

platform/mac/TestExpectations:

6:04 PM Changeset in webkit [180199] by bshafiei@apple.com

7 edits
3 copies in tags/Safari-600.5.6.1

Merged r180191. rdar://problem/19855007

5:54 PM March 2015 Meeting created by Simon Fraser

5:52 PM WikiStart edited by Simon Fraser

(diff)

5:49 PM Changeset in webkit [180198] by Lucas Forschler

7 edits
3 copies in branches/safari-600.5-branch

Merged r180191. rdar://problem/19820463

5:33 PM Changeset in webkit [180197] by mmaxfield@apple.com

2 edits in trunk/LayoutTests

fast/text/glyph-reordering.html no longer fails
https://bugs.webkit.org/show_bug.cgi?id=141678

Reviewed by Sam Weinig.

platform/mac/TestExpectations:

5:33 PM Changeset in webkit [180196] by achristensen@apple.com

4 edits
2 copies
1 add in branches/safari-600.5-branch/LayoutTests

Progress towards making all bots green.

platform/mac-mavericks/css2.1: Added.
platform/mac-mavericks/css2.1/t1202-counter-04-b-expected.txt: Copied from platform/mac/css2.1/t1202-counter-04-b-expected.txt.
platform/mac-mavericks/css2.1/t1202-counters-04-b-expected.txt: Copied from platform/mac/css2.1/t1202-counters-04-b-expected.txt.
platform/mac/TestExpectations:

Skip css3/filters/huge-blur-value.html until bug 141653 is resolved.

platform/mac/css2.1/t1202-counter-04-b-expected.txt:
platform/mac/css2.1/t1202-counters-04-b-expected.txt:

Rebaselined for Yosemite.

5:28 PM Changeset in webkit [180195] by mmaxfield@apple.com

4 edits in trunk/LayoutTests

Update fast/text/decomposed-after-stacked-diacritics.html after r177774
https://bugs.webkit.org/show_bug.cgi?id=141677

Reviewed by Dan Bernstein.

Apply kerning to both spans in the same way.

fast/text/decomposed-after-stacked-diacritics-expected.txt:
fast/text/decomposed-after-stacked-diacritics.html:
platform/mac/TestExpectations:

5:16 PM Changeset in webkit [180194] by mmaxfield@apple.com

4 edits in trunk/LayoutTests

Update fast/regions/cssom/get-regions-by-content-horiz-*.html after r177774
https://bugs.webkit.org/show_bug.cgi?id=141674

Reviewed by Zalan Bujtas.

Text metrics changed, so the text ended up no longer spanning a region boundary.

fast/regions/cssom/get-regions-by-content-horiz-bt.html:
fast/regions/cssom/get-regions-by-content-horiz-tb.html:
platform/mac/TestExpectations:

5:09 PM Changeset in webkit [180193] by weinig@apple.com

18 edits
13 adds in trunk

Add experimental <attachment> element support
https://bugs.webkit.org/show_bug.cgi?id=141626

Reviewed by Tim Horton.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Adds scaffolding for an experimental implementation of an <attachment> element
which can represent a file attachment (e.g. NSTextAttachment in NSAttributedString
parlance).

The implementation is guarded by both an #ifdef (ENABLE(ATTACHMENT_ELEMENT)) and
a setting (Settings::attachmentElementEnabled()).

Tests: fast/attachment/attachment-disabled-dom.html

fast/attachment/attachment-disabled-rendering.html
fast/attachment/attachment-dom.html
fast/attachment/attachment-rendering.html

Configurations/FeatureDefines.xcconfig:

Add new ENABLE_ATTACHMENT_ELEMENT macro.

CMakeLists.txt:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.xcodeproj/project.pbxproj:

Add new files.

dom/make_names.pl:

Add support for checking a setting to determine if a particular tag should be exposed.

html/HTMLAttachmentElement.cpp: Added.
html/HTMLAttachmentElement.h: Added.

Stub out the basics of the new element.

html/HTMLElementsAllInOne.cpp:

Add HTMLAttachmentElement.cpp.

html/HTMLTagNames.in:

Add 'attachment'.

page/Settings.in:

Add attachmentElementEnabled setting.

rendering/RenderAttachment.cpp: Added.
rendering/RenderAttachment.h: Added.

Stub out the basics of the new render. We will probably want to replace this with
a non-replaced render, but this will do as a placeholder for now.

rendering/RenderObject.h:

(WebCore::RenderObject::isAttachment):
Add predicate for type casting.

rendering/RenderingAllInOne.cpp:

Add RenderAttachment.cpp.

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

LayoutTests:

fast/attachment: Added.
fast/attachment/attachment-disabled-dom-expected.txt: Added.
fast/attachment/attachment-disabled-dom.html: Added.
fast/attachment/attachment-disabled-rendering-expected.txt: Added.
fast/attachment/attachment-disabled-rendering.html: Added.
fast/attachment/attachment-dom-expected.txt: Added.
fast/attachment/attachment-dom.html: Added.
fast/attachment/attachment-rendering-expected.txt: Added.
fast/attachment/attachment-rendering.html: Added.

5:06 PM Changeset in webkit [180192] by akling@apple.com

4 edits in trunk/Source/WebCore

GC (almost) immediately when navigating under memory pressure.
<https://webkit.org/b/141663>

Reviewed by Geoffrey Garen.

Since the PageCache is already disabled in memory pressure situations,
we know that detaching the old window shell on navigation is basically
guaranteed to generate a bunch of garbage, we can soften the memory
peak a bit by doing a GC right away instead of scheduling one for soon(tm).

bindings/js/GCController.cpp:

(WebCore::GCController::GCController):
(WebCore::GCController::garbageCollectSoon):
(WebCore::GCController::garbageCollectOnNextRunLoop):
(WebCore::GCController::gcTimerFired):

bindings/js/GCController.h:

Add a GCController::garbageCollectOnNextRunLoop() complement to the
"soon" and "now" options. There was already a zero timer in here for
non-CF builds, so I just used that same timer to implement this
and have the non-CF code path call garbageCollectOnNextRunLoop().

bindings/js/ScriptController.cpp:

(WebCore::collectGarbageAfterWindowShellDestruction):
(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::clearWindowShell):

Under system memory pressure conditions, schedule a full GC on next
runloop iteration instead of just asking for it to happen soon.
We do it on next runloop to ensure that there's no pointer to the
window object on the stack.

5:05 PM Changeset in webkit [180191] by enrica@apple.com

7 edits
3 adds in trunk

Emoji sequences do not render properly.
https://bugs.webkit.org/show_bug.cgi?id=141661
rdar://problem/19820463

Reviewed by Sam Weinig.

Source/WebCore:

Emoji sequences and emoji with variations should be rendered
using the Complex code path and should be treated as graphemes.
This change modifies advanceByCombiningCharacterSequence to add
this logic.

Test: fast/text/emoji.html

WebCore.xcodeproj/project.pbxproj:
platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::characterRangeCodePath):

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::advanceByCombiningCharacterSequence): Implements a simple
logic to treat emoji sequences and emoji with variations as graphemes.

platform/text/CharacterProperties.h: Added.

(WebCore::isEmojiGroupCandidate):
(WebCore::isEmojiModifier):
(WebCore::isVariationSelector):

rendering/RenderText.cpp:

(WebCore::isEmojiGroupCandidate): Deleted.
(WebCore::isEmojiModifier): Deleted.

LayoutTests:

TestExpectations:
fast/text/emoji-expected.txt: Added.
fast/text/emoji.html: Added.

5:02 PM Changeset in webkit [180190] by Alan Bujtas

3 edits in trunk/Source/WebCore

RenderTableRow should check if it has access to its ancestor chain.
https://bugs.webkit.org/show_bug.cgi?id=141668

Reviewed by Andreas Kling.

Preventive fix.

rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):
(WebCore::RenderTableRow::addChild):

rendering/RenderTableRow.h:

4:33 PM Changeset in webkit [180189] by bshafiei@apple.com

5 edits in tags/Safari-601.1.18.1/Source

Versioning.

4:31 PM Changeset in webkit [180188] by bshafiei@apple.com

1 copy in tags/Safari-601.1.18.1

New tag.

4:26 PM Changeset in webkit [180187] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

[iOS] Build fix: declare undeclared identifier 'credential'.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::WebCoreNSURLAuthenticationChallengeClient::receivedCredential):

4:17 PM Changeset in webkit [180186] by bshafiei@apple.com

2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r177625. rdar://problem/19851970

4:16 PM Changeset in webkit [180185] by bshafiei@apple.com

5 edits in branches/safari-600.1.4.15-branch/Source

Versioning.

4:08 PM Changeset in webkit [180184] by msaboff@apple.com

3 edits in trunk/Source/JavaScriptCore

REGRESSION(r180060): C Loop crashes
https://bugs.webkit.org/show_bug.cgi?id=141671

Reviewed by Geoffrey Garen.

Fixed a typo that only affected the C Loop in the prologue() macro in LowLevelInterpreter.asm.
After the stackHeightOKGetCodeBlock label, codeBlockSetter(t1) should be codeBlockGetter(t1).
Fixed the processing of an out of stack exception in llint_stack_check to not get the caller's
frame. This isn't needed, since this helper is only called to check the stack on entry. Any
exception will be handled by a call ancestor.

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_stack_check): Changed to use the current frame for processing an exception.

llint/LowLevelInterpreter.asm: Fixed a typo.

4:02 PM Changeset in webkit [180183] by jer.noble@apple.com

4 edits
1 add in trunk/Source/WebCore

[iOS] Unable to play .mp4 file over http with basic http authentication
https://bugs.webkit.org/show_bug.cgi?id=141503
rdar://problem/15799844

Reviewed by Alexey Proskuryakov.

On iOS, CFNetwork is used for authentication, so the NSURLAuthenticationChallenge
provided by AVAssetResourceLoader needs to be shoehorned into a AuthenticationChallenge
object by way of CFURLAuthChallengeRef.

Create a new class, WebCoreNSURLAuthenticationChallengeClient, whose sole purpose
is to take AuthenticationChallengeClient callbacks and pass them along to a
NSURLAuthenticationChallenge sender.

Create a NSURLAuthenticationChallenge out of the CF version through an SPI, and add
that SPI to a new header. Drive-by fix: take two of our existing SPI calls and move
them into that same header.

WebCore.xcodeproj/project.pbxproj: Add CFNSURLConnectionSPI.h to project.
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::WebCoreNSURLAuthenticationChallengeClient::create): Factory.
(WebCore::WebCoreNSURLAuthenticationChallengeClient::WebCoreNSURLAuthenticationChallengeClient): Simple constructor.
(WebCore::WebCoreNSURLAuthenticationChallengeClient::receivedCredential): Pass to m_challenge.
(WebCore::WebCoreNSURLAuthenticationChallengeClient::receivedRequestToContinueWithoutCredential): Ditto.
(WebCore::WebCoreNSURLAuthenticationChallengeClient::receivedCancellation): Ditto.
(WebCore::WebCoreNSURLAuthenticationChallengeClient::receivedRequestToPerformDefaultHandling): Ditto.
(WebCore::WebCoreNSURLAuthenticationChallengeClient::receivedChallengeRejection): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForResponseToAuthenticationChallenge):

Create an AuthenticationChallenge out of the nsChallenge and client and pass it up
to the HTMLMediaElement.

platform/network/mac/AuthenticationMac.mm:
platform/spi/cocoa/CFNSURLConnectionSPI.h: Added.

3:46 PM Changeset in webkit [180182] by bshafiei@apple.com

2 edits in tags/Safari-600.1.4.15.6/Source/WebKit2

Merged r177625. rdar://problem/19851970

3:38 PM Changeset in webkit [180181] by bshafiei@apple.com

5 edits in tags/Safari-600.1.4.15.6/Source

Versioning.

3:24 PM Changeset in webkit [180180] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

REGRESSION (r176459): Process suspension cleanup timer sometimes never stops
https://bugs.webkit.org/show_bug.cgi?id=141669

Reviewed by Simon Fraser.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::markAllLayersVolatileIfPossible):
r176459 accidentally removed the code to stop the cleanup timer
in the case where we successfully finish marking layers volatile,
causing the timer to continue running once the process comes back
from a suspended state.

3:19 PM Changeset in webkit [180179] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Revert a change in SVGRenderSupport::mapLocalToContainer committed for fixing <https://bugs.webkit.org/show_bug.cgi?id=119626>.
https://bugs.webkit.org/show_bug.cgi?id=138439

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-02-16
Reviewed by Darin Adler.

The change http://trac.webkit.org/changeset/164861 was ported from Blink
but it was was revert later because it broke Chrome SVG rendering. It also
broke the WebKit SVG text search highlighting.

Tests: svg/transforms/svg-geometry-crash.html: This test was added by the
blamed change. A new but correct solution is required to fix the assertion.

rendering/svg/SVGRenderSupport.h:
rendering/svg/SVGRenderSupport.cpp:

Notice that TransformState.applyTransform() does matrix-left-multiplication,
i.e. state = transform * state. But operator*() of AffineTransform and
MatrixTransform does right multiply, i.e. this = this * transform.

(WebCore::SVGRenderSupport::localToParentTransform): Have the calculation
of the SVG localToParentTransform in one shared function.

(WebCore::SVGRenderSupport::mapLocalToContainer): Revert the Blink change.
If the parent is the SVG root, the transform state should be equal to
transform = svg_to_css_mapping * local_to_parent_mapping * transform.

(WebCore::SVGRenderSupport::pushMappingToContainer): Get the localToParent
transform to be pushed in the geometryMap. If the parent is the SVG root,
localToParent = svg_to_css_mapping * local_to_parent_mapping. The original
code was doing the opposite and this is the cause of the assertion which
was fixed wrongly by reversing the correct multiplication order in
SVGRenderSupport::mapLocalToContainer().

3:11 PM Changeset in webkit [180178] by mmaxfield@apple.com

6 edits in trunk/LayoutTests

Update fast/dom/{Element,Range}/getClientRects.html after r177774
https://bugs.webkit.org/show_bug.cgi?id=141665

Reviewed by Alexey Proskuryakov.

Line breaking is different due to different text metrics.

fast/dom/Element/getClientRects-expected.txt:
fast/dom/Element/getClientRects.html:
fast/dom/Range/getClientRects-expected.txt:
fast/dom/Range/getClientRects.html:
platform/mac/TestExpectations:

3:06 PM Changeset in webkit [180177] by bshafiei@apple.com

1 copy in tags/Safari-600.1.4.15.6

New tag.

3:01 PM Changeset in webkit [180176] by mmaxfield@apple.com

1 edit
5456 copies
133 adds
1 delete in trunk/LayoutTests

Delete LayoutTests/platform/mac-mountainlion directory

Rubber-stamped by Brent Fulgham.

The Win port falls back to mac-mountainlion, so this patch moves all files in
platform/mac-mountainlion that aren't already in platform/win into platform/win. It then deletes
the remaining files in platform/mac-mountainlion.

platform/mac-mountainlion: Deleted.
platform/win/{many files}: Moved from platform/mac-mountainlion

2:40 PM Changeset in webkit [180175] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Check for the assume_nonnull feature instead of noescape
https://bugs.webkit.org/show_bug.cgi?id=141666

Reviewed by Dan Bernstein.

Shared/API/Cocoa/WKFoundation.h:

2:38 PM Changeset in webkit [180174] by Alan Bujtas

4 edits
2 adds in trunk

RenderTableCell can't access its parent while in detached state.
https://bugs.webkit.org/show_bug.cgi?id=141639
rdar://problem/19850760

Reviewed by Simon Fraser.

Null check against ancestor chain so that certain methods in RenderTableCell can
be called even if the renderer is not yet attached.

Source/WebCore:

Test: fast/table/table-cell-crash-when-detached-state.html

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::borderLeft):
(WebCore::RenderTableCell::borderRight):
(WebCore::RenderTableCell::borderTop):
(WebCore::RenderTableCell::borderBottom):
(WebCore::RenderTableCell::borderStart):
(WebCore::RenderTableCell::borderEnd):
(WebCore::RenderTableCell::borderBefore):
(WebCore::RenderTableCell::borderAfter):

rendering/RenderTableCell.h:

LayoutTests:

fast/table/table-cell-crash-when-detached-state-expected.txt: Added.
fast/table/table-cell-crash-when-detached-state.html: Added.

2:10 PM Changeset in webkit [180173] by commit-queue@webkit.org

8 edits in trunk

Web Inspector: Scope details sidebar should label objects with constructor names
https://bugs.webkit.org/show_bug.cgi?id=139449

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-02-16
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::internalConstructorName):

runtime/Structure.cpp:

(JSC::Structure::toStructureShape):
Share calculatedClassName.

runtime/JSObject.h:
runtime/JSObject.cpp:

(JSC::JSObject::calculatedClassName):
Elaborate on a way to get an Object's class name.

LayoutTests:

inspector/model/remote-object-expected.txt:
inspector/model/remote-object.html:

Improve the test to include Objects where previously
we would have had poorer class name descriptions.

1:58 PM Changeset in webkit [180172] by mmaxfield@apple.com

3 edits in trunk/LayoutTests

Update expected result for editing/pasteboard/5761530-1.html after r177774
https://bugs.webkit.org/show_bug.cgi?id=141603

Reviewed by Alexey Proskuryakov.

The test used to have incorrect expected output, but the new results are correct.

LayoutTests/editing/pasteboard/5761530-1-expected.txt:
platform/mac/TestExpectations:

1:51 PM Changeset in webkit [180171] by mmaxfield@apple.com

4 edits in trunk/LayoutTests

Update fast/css/css3-ch-unit.html after r177774
https://bugs.webkit.org/show_bug.cgi?id=141657

Reviewed by Zalan Bujtas.

The alphabet is not expected to have the same width as 26 times the average character width.

fast/css/css3-ch-unit-expected.txt:
fast/css/css3-ch-unit.html:
platform/mac/TestExpectations:

1:44 PM Changeset in webkit [180170] by ap@apple.com

2 edits in trunk/LayoutTests

fullscreen/full-screen-plugin.html is very flaky on Yosemite WK2
https://bugs.webkit.org/show_bug.cgi?id=141364

platform/mac-wk2/TestExpectations: Marking as such.

1:26 PM Changeset in webkit [180169] by bshafiei@apple.com

5 edits in tags/Safari-600.5.6.1/Source

Versioning.

1:26 PM Changeset in webkit [180168] by ap@apple.com

2 edits in trunk/LayoutTests

inspector/css/stylesheet-with-mutations.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=141601

platform/mac-wk2/TestExpectations: Marking as such.

1:24 PM Changeset in webkit [180167] by bshafiei@apple.com

1 copy in tags/Safari-600.5.6.1

New tag.

12:41 PM Changeset in webkit [180166] by mmaxfield@apple.com

9 edits in trunk/LayoutTests

Update fast/css/content/content-quotes-*.html after r177774
https://bugs.webkit.org/show_bug.cgi?id=141654

Reviewed by Zalan Bujtas.

Because of printer fonts and LayoutUnits, putting text inside an anonymous renderer
has different metrics than the raw text itself.

fast/css/content/content-quotes-01.html:
fast/css/content/content-quotes-02.html:
fast/css/content/content-quotes-03.html:
fast/css/content/content-quotes-04.html:
fast/css/content/content-quotes-05.html:
fast/css/content/content-quotes-06.html:
fast/css/content/content-quotes-07.html:
platform/mac/TestExpectations:

12:13 PM Changeset in webkit [180165] by ap@apple.com

2 edits in trunk/LayoutTests

Update expectations for css2.1/t1202-counter-04-b.html and css2.1/t1202-counters-04-b.html
rdar://problem/19848737

platform/mac/TestExpectations:

11:56 AM Changeset in webkit [180164] by timothy_horton@apple.com

4 edits in trunk/Tools

Fix the MiniBrowser build with newer clang

MiniBrowser/mac/SettingsController.m:

(-[SettingsController _toggleBooleanDefault:]):

MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController windowWillClose:]):

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController windowWillClose:]):
NSApp is id and clang gets confused about which -delegate we're talking about.

11:43 AM Changeset in webkit [180163] by mmaxfield@apple.com

3 edits in trunk/LayoutTests

Update expected result for compositing/fixed-positioned-pseudo-content-no-compositing.html after r177774
https://bugs.webkit.org/show_bug.cgi?id=141602

Reviewed by Simon Fraser.

Not sure if the change to contentsOpaque is right, so CC'ing smfr to see what he thinks.

compositing/fixed-positioned-pseudo-content-no-compositing-expected.txt:
platform/mac/TestExpectations:

11:38 AM Changeset in webkit [180162] by andersca@apple.com

16 edits in trunk/Source/WebKit2

Add nullability qualifiers to all API headers
https://bugs.webkit.org/show_bug.cgi?id=141652
rdar://problem/19793630

Reviewed by Dan Bernstein.

Shared/API/Cocoa/WKFoundation.h:

Add a WK_NULLABLE_SPECIFIER macro.

UIProcess/API/Cocoa/WKBackForwardListItem.h:
UIProcess/API/Cocoa/WKFrameInfo.h:
UIProcess/API/Cocoa/WKNavigationAction.h:
UIProcess/API/Cocoa/WKNavigationDelegate.h:
UIProcess/API/Cocoa/WKNavigationResponse.h:
UIProcess/API/Cocoa/WKScriptMessage.h:
UIProcess/API/Cocoa/WKScriptMessageHandler.h:
UIProcess/API/Cocoa/WKUIDelegate.h:
UIProcess/API/Cocoa/WKUserContentController.h:
UIProcess/API/Cocoa/WKUserScript.h:
UIProcess/API/Cocoa/WKWebView.h:
UIProcess/API/Cocoa/WKWebViewConfiguration.h:
UIProcess/API/Cocoa/WKWindowFeatures.h:

mac/postprocess-framework-headers.sh:

Handle the WK_NULLABLE_SPECIFIER macro. Change the WK_NULLABLE sed command to replace
all occurrences of WK_NULLABLE instead of just the first one.

11:32 AM Changeset in webkit [180161] by dbates@webkit.org

4 edits in trunk/LayoutTests

[iOS] Gardening; update test expectations

platform/ios-simulator-wk1/TestExpectations:
platform/ios-simulator-wk2/TestExpectations:
platform/ios-simulator/TestExpectations:

11:27 AM Changeset in webkit [180160] by fpizlo@apple.com

21 edits
1 add in trunk/Source/JavaScriptCore

DFG SSA should use GetLocal for arguments, and the GetArgument node type should be removed
https://bugs.webkit.org/show_bug.cgi?id=141623

Reviewed by Oliver Hunt.

During development of https://bugs.webkit.org/show_bug.cgi?id=141332, I realized that I
needed to use GetArgument for loading something that has magically already appeared on the
stack, so currently trunk sort of allows this. But then I realized three things:

A GetArgument with a non-JSValue flush format means speculating that the value on the stack obeys that format, rather than just assuming that that it already has that format. In bug 141332, I want it to assume rather than speculate. That also happens to be more intuitive; I don't think I was wrong to expect that.

The node I really want is GetLocal. I'm just getting the value of the local and I don't want to do anything else.

Maybe it would be easier if we just used GetLocal for all of the cases where we currently use GetArgument.

This changes the FTL to do argument speculations in the prologue just like the DFG does.
This brings some consistency to our system, and allows us to get rid of the GetArgument
node. The speculations that the FTL must do are now made explicit in the m_argumentFormats
vector in DFG::Graph. This has natural DCE behavior: even if all uses of the argument are
dead we will still speculate. We already have safeguards to ensure we only speculate if
there are uses that benefit from speculation (which is a much more conservative criterion
than DCE).

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGDCEPhase.cpp:

(JSC::DFG::DCEPhase::run):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGFlushFormat.h:

(JSC::DFG::typeFilterFor):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

dfg/DFGGraph.h:

(JSC::DFG::Graph::valueProfileFor):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::initialize):

dfg/DFGNode.cpp:

(JSC::DFG::Node::hasVariableAccessData):

dfg/DFGNodeType.h:
dfg/DFGOSRAvailabilityAnalysisPhase.cpp:

(JSC::DFG::OSRAvailabilityAnalysisPhase::run):
(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGPutLocalSinkingPhase.cpp:
dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run):

dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetLocal):
(JSC::FTL::LowerDFGToLLVM::compileGetArgument): Deleted.

tests/stress/dead-speculating-argument-use.js: Added.

(foo):
(o.valueOf):

11:05 AM Changeset in webkit [180159] by mmaxfield@apple.com

4 edits in trunk/LayoutTests

Update editing/selection/move-by-word-visually-mac.html after r177774
https://bugs.webkit.org/show_bug.cgi?id=141609

Reviewed by Alexey Proskuryakov.

Line break occurs in a different place, so option-left and option-right
have slightly different behavior.

editing/selection/move-by-word-visually-mac.html:
editing/selection/move-by-word-visually-mac-expected.txt:
platform/mac/TestExpectations:

10:56 AM Changeset in webkit [180158] by mitz@apple.com

4 edits in trunk/Source/WebKit2

Update SPI availability annotations
https://bugs.webkit.org/show_bug.cgi?id=141588

Reviewed by Anders Carlsson.

Shared/API/Cocoa/WKFoundation.h: Added a definition of NSi_8_3 for when building with

an older SDK.

UIProcess/API/Cocoa/WKErrorPrivate.h:
UIProcess/API/Cocoa/WKUIDelegatePrivate.h:

10:46 AM Changeset in webkit [180157] by matthew_hanson@apple.com

5 edits in branches/safari-600.4.10-branch/Source

Versioning.

10:37 AM Changeset in webkit [180156] by Antti Koivisto

3 edits in trunk/Source/WebKit2

Remove unused InjectedBundle::setCacheModel.

Rubber-stamped by Anders Carlsson.

WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setCacheModel): Deleted.

WebProcess/InjectedBundle/InjectedBundle.h:

10:04 AM Changeset in webkit [180155] by hyatt@apple.com

2 edits in trunk/Source/WebCore

Add ifdefs to avoid adjusting Ruby selection rects to avoid overlap on iOS.
https://bugs.webkit.org/show_bug.cgi?id=141651
<rdar://problem/19182526>

Reviewed by Simon Fraser.

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::selectionBottom):
Add ifdefs to avoid adjusting Ruby selection rects to avoid overlap on iOS.
https://bugs.webkit.org/show_bug.cgi?id=141651
<rdar://problem/19182526>

Reviewed by Simon Fraser.

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::selectionBottom):

10:02 AM Changeset in webkit [180154] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

SoftLinking.h: Update copyright and license; clean up whitespace

platform/mac/SoftLinking.h:

9:55 AM Changeset in webkit [180153] by andersca@apple.com

1 edit in trunk/Source/WebKit2/ChangeLog

Fix typo.

9:50 AM Changeset in webkit [180152] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Build fix for versions of Xcode that support nullability but don't have the AppKit #defines.

Shared/API/Cocoa/WKFoundation.h:

9:47 AM Changeset in webkit [180151] by matthew_hanson@apple.com

1 copy in branches/safari-600.4.10-branch

New branch.

9:47 AM Changeset in webkit [180150] by hyatt@apple.com

12 edits
8 adds in trunk

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

These functions have been re-written to take an enclosing renderer that specified the
decoration. This way they can properly limit the bottom/top computation to only line boxes
that are contained inside the renderer.

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

text-underline-position:under has multiple correctness issues
https://bugs.webkit.org/show_bug.cgi?id=141528

Reviewed by Dean Jackson.

Source/WebCore:

Added a bunch of new tests in fast/text

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::maxLogicalBottomForTextDecorationLine):
(WebCore::InlineFlowBox::minLogicalTopForTextDecorationLine):
(WebCore::InlineFlowBox::computeMaxLogicalBottom): Deleted.

rendering/InlineFlowBox.h:

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):
Tweak the call to get the decoration colors now that quirks mode has been removed.

rendering/RenderElement.cpp:

(WebCore::RenderElement::enclosingRendererWithTextDecoration):

rendering/RenderElement.h:

New function that finds the enclosing renderer that specified a text decoration. For now
this is only used in the "under" position computation, but soon we'll be using it
everywhere.

rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

rendering/RenderObject.h:

Remove the quirks mode argument, since we were always passing true anyway (making the argument dead).

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::maxLogicalBottom): Deleted.

rendering/RootInlineBox.h:

Get rid of these functions and just have InlineTextBoxStyle's computeUnderLineOffset function call
the InlineFlowBox functions directly.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
Re-written to fetch the enclosingRendererWithTextDecoration so that it can be passed to the logical top/bottom
computation to limit which line boxes get included.

LayoutTests:

fast/text/text-underline-first-line-decoration-expected.html: Added.
fast/text/text-underline-first-line-decoration.html: Added.
fast/text/text-underline-position-mixed-fonts-expected.html: Added.
fast/text/text-underline-position-mixed-fonts.html: Added.
fast/text/text-underline-position-subscript-expected.html: Added.
fast/text/text-underline-position-subscript.html: Added.
fast/text/text-underline-vertical-first-line-decoration-expected.html: Added.
fast/text/text-underline-vertical-first-line-decoration.html: Added.

9:17 AM Changeset in webkit [180149] by Antti Koivisto

16 edits
2 adds in trunk

Develop/Disable Caches does not properly disable disk cache
https://bugs.webkit.org/show_bug.cgi?id=141636

Reviewed by Anders Carlsson.

Source/WebKit2:

The menu item sets the cache model to "document viewer" to disable the caches (cache size 0).
However the cache model was never passed to the network process after the initialization.

NetworkProcess/NetworkProcess.messages.in:
NetworkProcess/cache/NetworkCacheStorageCocoa.mm:

(WebKit::NetworkCacheStorage::retrieve):
(WebKit::NetworkCacheStorage::store):
(WebKit::NetworkCacheStorage::update):

Don't try to store or retrieve when the maximum cache size is set to zero.

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setCacheModel):

Message the network process too.

WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetCacheModel): Deleted.

Remove the now unused SPI.

WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:

Tools:

Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
the network process too.

This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):
(WTR::InjectedBundle::setCacheModel):

WebKitTestRunner/InjectedBundle/InjectedBundle.h:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:

Forward to TestController.

(WTR::TestRunner::setCacheModel):

WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

http/tests/cache/disk-cache-disable-expected.txt: Added.
http/tests/cache/disk-cache-disable.html: Added.
http/tests/cache/resources/cache-test.js:

(runTests): Add optional completion handler.

9:16 AM Changeset in webkit [180148] by Antti Koivisto

4 edits
3 adds in trunk

Assertion in disk cache code with redirect to a non-http resource
https://bugs.webkit.org/show_bug.cgi?id=141644

Reviewed by Anders Carlsson.

Source/WebKit2:

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didFinishLoading):

Check that response is HTTP before calling computeFreshnessLifetimeForHTTPFamily.

NetworkProcess/cache/NetworkCache.cpp:

(WebKit::canStore):

Deny storing non-HTTP responses to cache (though the above already covers this).

LayoutTests:

http/tests/cache/disk-cache-redirect-to-data-expected.txt: Added.
http/tests/cache/disk-cache-redirect-to-data.html: Added.
http/tests/cache/resources/redirect-to-data.php: Added.

9:07 AM Changeset in webkit [180147] by Brent Fulgham

2 edits in trunk/Source/WebCore

FEGaussianBlur::calculateUnscaledKernelSize does unspeakable things with signed and unsigned values
https://bugs.webkit.org/show_bug.cgi?id=141596
<rdar://problem/19837103>

Reviewed by Zalan Bujtas.

No new tests. Covered by css3/filters/huge-blur-value.html

Avoid overflowing the signed integer values by not converting from unsigned
until the maximum size has been clamped to the expected max.

platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::calculateUnscaledKernelSize):

8:36 AM Changeset in webkit [180146] by andersca@apple.com

6 edits in trunk/Source/WebKit2

Add support for nullability to the header postprocessing
https://bugs.webkit.org/show_bug.cgi?id=141573

Reviewed by Darin Adler.

Shared/API/Cocoa/WKFoundation.h:
UIProcess/API/Cocoa/WKBackForwardList.h:
mac/postprocess-framework-headers.sh:

8:10 AM Changeset in webkit [180145] by g.czajkowski@samsung.com

2 edits
1 move in trunk/Source/WebKit2

[EFL] Rename WebContextEfl to WebProcessPoolEfl
https://bugs.webkit.org/show_bug.cgi?id=141642

Reviewed by Csaba Osztrogonác.

Although we've renamed almost everything in r177716, this is still
required after r177692.

UIProcess/efl/WebProcessPoolEfl.cpp: Renamed from Source/WebKit2/UIProcess/efl/WebContextEfl.cpp.

7:15 AM Changeset in webkit [180144] by a.badowski@samsung.com

2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

Scripts/webkitpy/common/config/contributors.json:

Change-Id: I5d745aac5c20ab589446a69ef943202a6db4947a

4:43 AM WebKitGTK/2.4.x edited by tpopela@redhat.com

(diff)

4:36 AM Changeset in webkit [180143] by svillar@igalia.com

1 edit
2 adds in trunk/LayoutTests

Unreviewed. Uploading a new test that should have been uploaded as
part of r180142.

fast/css-grid-layout/grid-initialize-span-one-items-expected.txt: Added.
fast/css-grid-layout/grid-initialize-span-one-items.html: Added.

4:00 AM Changeset in webkit [180142] by svillar@igalia.com

7 edits in trunk

[CSS Grid Layout] Invalid initialization of track sizes with non spanning grid items
https://bugs.webkit.org/show_bug.cgi?id=140763

Reviewed by Antti Koivisto.

Source/WebCore:

Content sized tracks with non-spanning grid items were not
properly sized because the growth limit was sometimes infinity
(-1) after calling resolveContentBasedTrackSizingFunctions() when
it should not. This patch adds an special initialization phase for
non-spanning grid items as the new track sizing algorithm
describes.

Granted, that was handled in the old algorithm in
distributeSpaceToTracks() as a special case. The problem is that
it regressed after the optimization added in r173868 because that
method is no longer called when the space to distribute is 0.

That's why we could fix this by allowing calls to
distributeSpaceToTracks() with spaceToDistribute>=0 but by fixing
it with an explicit initialization our implementation becomes
closer to the new algorithm and the initialization is now explicit
in the code instead of a side effect of calling
distributeSpaceToTracks() with no space to be distributed. It also
brings a slight performance improvement as we save sorts and hash
lookups.

I also took the change to add caching to several GridTrackSize
methods that were hot on the profiler (each one accounted for ~1%
of the total time, now they account for ~0.3% each).

Test: fast/css-grid-layout/grid-initialize-span-one-items.html

rendering/RenderGrid.cpp:

(WebCore::GridItemWithSpan::span): New helper method for ASSERTs.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
Exclude non spanning grid items from the calls to
resolveContentBasedTrackSizingFunctionsForItems().
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForNonSpanningItems):
New method to resolve track sizes only using non-spanning grid
items.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Ensure that it isn't called for non-spanning grid items.

rendering/RenderGrid.h:
rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::GridTrackSize): Cache return values.
(WebCore::GridTrackSize::setLength): Ditto.
(WebCore::GridTrackSize::setMinMax): Ditto.
(WebCore::GridTrackSize::cacheMinMaxTrackBreadthTypes): New method
that caches the return values for hasXXXTrackBreadth() methods.
(WebCore::GridTrackSize::hasMinOrMaxContentMinTrackBreadth): Use
the cached return value.
(WebCore::GridTrackSize::hasMaxContentMaxTrackBreadth): Ditto.
(WebCore::GridTrackSize::hasMinContentMaxTrackBreadth): Ditto.
(WebCore::GridTrackSize::hasMinOrMaxContentMaxTrackBreadth): Ditto.
(WebCore::GridTrackSize::hasMaxContentMinTrackBreadth): Ditto.
(WebCore::GridTrackSize::hasMinContentMinTrackBreadth): Ditto.
(WebCore::GridTrackSize::hasMinContentMinTrackBreadthAndMinOrMaxContentMaxTrackBreadth):
Ditto.
(WebCore::GridTrackSize::hasMaxContentMinTrackBreadthAndMaxContentMaxTrackBreadth):
Ditto.

LayoutTests:

fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt:
fast/css-grid-layout/grid-content-sized-columns-resolution.html:
fast/css-grid-layout/grid-initialize-span-one-items-expected.txt: Added.
fast/css-grid-layout/grid-initialize-span-one-items.html: Added.

2:55 AM WebKitGTK/2.4.x edited by tpopela@redhat.com

(diff)

2:24 AM Changeset in webkit [180141] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK] Loading page into WebView shows g_closure_unref warning
https://bugs.webkit.org/show_bug.cgi?id=127474

Patch by Milan Crha <mcrha@redhat.com> on 2015-02-16
Reviewed by Carlos Garcia Campos.

bindings/gobject/GObjectEventListener.cpp:

(WebCore::GObjectEventListener::gobjectDestroyed):

1:42 AM Changeset in webkit [180140] by svillar@igalia.com

6 edits in trunk/Source/WebCore

[CSS Grid Layout] Remove the usage of Length(Undefined) in GridLength
https://bugs.webkit.org/show_bug.cgi?id=141562

Reviewed by Chris Dumez.

From Blink r164154 by <timloh@chromium.org>

The patch simplifies some of the logic in creating and applying
GridLength and GridTrackSize values to RenderStyles by using the
constructors for initialisation instead of deferring to setters.

The rationale behind this change is that neither of
createGridTrackSize() nor createGridTrackBreadth() should be able
to fail, so these are changed to return objects directly instead
of taking an out reference (note that in general failing in
applying properties is incorrect and we should catch these in the
parser).

The quirk value across to the Lengths was also removed because it
doesn't apply to Grid.

css/CSSPropertyNames.in:
css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::createGridTrackBreadth): Return a
GridLength instead of a bool.
(WebCore::StyleBuilderConverter::createGridTrackSize): Return a
GridTrackSize instead of a bool.
(WebCore::StyleBuilderConverter::createGridTrackList): Do not
create temporary GridTrackSizes with undefined Lengths.
(WebCore::StyleBuilderConverter::convertGridTrackSize): Ditto.

rendering/style/GridLength.h:

(WebCore::GridLength::GridLength): It now requires a mandatory
Length argument.
(WebCore::GridLength::length): Deleted.
(WebCore::GridLength::setFlex): Deleted.

rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::GridTrackSize): It now requires a
mandatory GridLength argument.
(WebCore::GridTrackSize::length): Removed no longer valid ASSERTs.
(WebCore::GridTrackSize::minTrackBreadth): Ditto.
(WebCore::GridTrackSize::maxTrackBreadth): Ditto.
(WebCore::GridTrackSize::setLength): Deleted.
(WebCore::GridTrackSize::setMinMax): Deleted.

rendering/style/RenderStyle.h:

12:25 AM Changeset in webkit [180139] by g.czajkowski@samsung.com

2 edits in trunk/Source/WebCore

Removing text node does not remove its associated markers
https://bugs.webkit.org/show_bug.cgi?id=140999

Reviewed by Ryosuke Niwa.

Removing text node via script does not remove its markers.
For example, running the following script:

var div = document.getElementById("testElement");
div.focus();
document.execCommand("InsertText", false, "welllcome ");

Give a time async spellchecker to show its markers and
remove the node.
setTimeout(function() { div.removeChild(div.firstChild); }, 100);

</script>

will cause that DocumentMarkerController still stores the markers for
detached node.

The same issue occurs when the text gets cleared, for example,
<script>

input.value = ""; for HTMLTextAreaElement, HTMLInputElement
or
div.innerHTML = ""; for content editable

</script>

No new tests. Internals marker APIs operate on text node attached
to the element. To test it we could expose document().markers().hasMarkers()
but there is no more useful cases where it could be used.
Another obstacle is that we are in isInShadowTree() so that there is
no possible to register on "DOMSubtreeModified" event.
Test cases attached to the bug:

input.value = "" https://bug-140999-attachments.webkit.org/attachment.cgi?id=245704
elem.removeChild(textNode) https://bug-140999-attachments.webkit.org/attachment.cgi?id=246515

Remove markers when text nodes are about to remove.

dom/Document.cpp:

(WebCore::Document::nodeChildrenWillBeRemoved):
Fixes input.value = ""
(WebCore::Document::nodeWillBeRemoved):
Fixes elem.removeChild(textNode)

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed