Context Navigation

← Previous Period
Next Period →

Timeline

Feb 22, 2015:

11:45 PM Changeset in webkit [180497] by gyuyoung.kim@samsung.com

2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Mark sub-pixel and disk cache tests to failure.

platform/efl/TestExpectations:

10:59 PM Changeset in webkit [180496] by bshafiei@apple.com

5 edits in branches/safari-600.4.10-branch/Source

Versioning.

10:42 PM Changeset in webkit [180495] by bshafiei@apple.com

1 copy in tags/Safari-600.4.10.4

New tag.

9:23 PM Changeset in webkit [180494] by bshafiei@apple.com

4 edits
2 adds in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r180183, r180187. rdar://problem/19871089

6:38 PM Changeset in webkit [180493] by gyuyoung.kim@samsung.com

13 edits in trunk/Source/WebCore

Move std::unique_ptr<>|make_unique<> to WebCore/page/scrolling
https://bugs.webkit.org/show_bug.cgi?id=137877

Reviewed by Sam Weinig.

Clean up unnecessary OwnPtr.h|PassOwnPtr.h includes as well as
change OwnPtr with std::unique_ptr<>|make_unique<>.

No new tests, no behavior changes.

page/scrolling/AsyncScrollingCoordinator.h:
page/scrolling/ScrollingStateFixedNode.cpp:
page/scrolling/ScrollingStateFrameScrollingNode.cpp:
page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::appendChild):

page/scrolling/ScrollingStateNode.h:
page/scrolling/ScrollingStateOverflowScrollingNode.cpp:
page/scrolling/ScrollingStateScrollingNode.cpp:
page/scrolling/ScrollingStateStickyNode.cpp:
page/scrolling/ScrollingTree.h:
page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::appendChild):

page/scrolling/ScrollingTreeNode.h:
page/scrolling/ScrollingTreeScrollingNode.h:

5:55 PM Changeset in webkit [180492] by dino@apple.com

5 edits in trunk

Print a console warning when HTMLCanvasElement exceeds the maximum size
https://bugs.webkit.org/show_bug.cgi?id=141861
<rdar://problem/19729145>

Reviewed by Simon Fraser.

Source/WebCore:

Add a warning if we ever try to create a canvas that is
too big.

No test because:

We can't ref-test against console messages.
The output is platform specific.

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):

LayoutTests:

Add error message to expected results.

fast/canvas/canvas-toDataURL-crash-expected.txt:
fast/canvas/pattern-too-large-to-create-expected.txt:

5:34 PM Changeset in webkit [180491] by weinig@apple.com

2 edits in trunk/LayoutTests

Update results for Mac Yosemite.

platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

3:33 PM Changeset in webkit [180490] by weinig@apple.com

35 edits in trunk

Convert the caps lock indicator to be implemented using the shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=141868

Reviewed by Dan Bernstein.

Source/WebCore:

Re-adds 'caps-lock-indicator' as a valid -webkit-appearance value. It was removed in r74099 to work around a site bug, that should not be a problem anymore.
Converts the caps lock indicator to be implemented as part of the shadow DOM rather than a paint time effect. This gives the proper overflow behavior (it now clips) and behaves correctly in RTL.

css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
Make 'caps-lock-indicator' a valid -webkit-appearance value.

css/CSSValueKeywords.in:

Remove comment that indicated that caps-lock-indicator was not a valid
-webkit-appearance value.

css/html.css:

(input::-webkit-caps-lock-indicator):
Add new default style for the new -webkit-caps-lock-indicator pseudo-element. The
trick employed here is to use a content: image to both implement the painting of
the caps lock indicator, and to get the sizing right (shrink-to-fit, height: 100%).

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::capsLockIndicatorElement):
(WebCore::HTMLInputElement::capsLockStateMayHaveChanged):

html/HTMLInputElement.h:
html/InputType.cpp:

(WebCore::InputType::capsLockStateMayHaveChanged):

html/InputType.h:

(WebCore::InputType::capsLockIndicatorElement):
Pipe notification of changes in the caps locks state to the <input> element
rather than the RenderTextControlSingleLine. Also add an accessor for the caps
lock indicator element in the shadow DOM.

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::forwardEvent):
(WebCore::TextFieldInputType::shouldHaveCapsLockIndicator):
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::capsLockIndicatorElement):
(WebCore::TextFieldInputType::destroyShadowSubtree):
(WebCore::TextFieldInputType::shouldDrawCapsLockIndicator):
(WebCore::TextFieldInputType::capsLockStateMayHaveChanged):

html/TextFieldInputType.h:

Add a new element to the text field shadow DOM to act as the caps lock indicator.
Give it a pseudo-element ID of -webkit-caps-lock-indicator so it can be referenced
from CSS. The element is always in the DOM for a password field. It toggles between
display: none and display: block depending on the state of the caps lock key.

page/EventHandler.cpp:

(WebCore::EventHandler::capsLockStateMayHaveChanged):
Pipe notification of changes in the caps locks state to the <input> element
rather than the RenderTextControlSingleLine.

rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::paint): Deleted.
(WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged): Deleted.

rendering/RenderTextControlSingleLine.h:

Remove logic for drawing the caps lock indicator.

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintMeter):
(WebCore::RenderTheme::adjustCapsLockIndicatorStyle):
(WebCore::RenderTheme::paintCapsLockIndicator):
(WebCore::RenderTheme::shouldHaveCapsLockIndicator):

rendering/RenderTheme.h:

(WebCore::RenderTheme::paintCapsLockIndicator): Deleted.

rendering/RenderThemeIOS.h:
rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::shouldHaveCapsLockIndicator):

rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::shouldHaveCapsLockIndicator):
(WebCore::RenderThemeMac::paintCapsLockIndicator): Deleted.
Now that the caps lock indicator is implemented like other aspects of form controls,
the theme code can be converted to be similar as well.

LayoutTests:

fast/css/appearance-caps-lock-indicator-expected.txt:
fast/css/appearance-caps-lock-indicator.html:
platform/mac/fast/css/text-overflow-input-expected.txt:
platform/mac/fast/forms/basic-inputs-expected.txt:
platform/mac/fast/forms/input-appearance-height-expected.txt:
platform/mac/fast/forms/input-value-expected.txt:
platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
platform/mac/fast/forms/validation-message-appearance-expected.txt:

12:22 PM Changeset in webkit [180489] by ddkilzer@apple.com

5 edits
1 delete in trunk/LayoutTests

[iOS] Gardening: Clean up timeout test for ios-simulator-{wk1,wk2}

Changes for WK1 results:

inspector/css/stylesheet-with-mutations.html
Skip for both WK1 and WK2. Already marked as Skip on mac.
fast/events/dispatch-message-string-data.html
Marked as Slow for both WK1 and WK2. Previously marked as Skip via override on WK2 and marked as Failure on both.

Changes for WK2:

inspector/css/selector-dynamic-specificity.html
Skip on WK1 and WK2. Already marked as Skip on mac and win. Updated bug number for win TestExpectations.
inspector/css/stylesheet-with-mutations.html
See above.
fast/dynamic/window-resize-scrollbars-test.html
Skip on WK1 and WK2 since iOS does not support window resizing and test always times out. Remove old test results.
fast/images/animated-gif-window-resizing.html
Skip on WK1 and WK2 since iOS does not support window resizing and test always times out. Previously skipped on WK1 only.
fast/events/autoscroll-should-not-stop-on-keypress.html
Skip on WK1 and WK2 due to always timing out. Previously skipped on WK1 only.
http/tests/cache/history-navigation-no-resource-revalidation.html
Skip on WK2 due to always timing out. Does not timeout on WK1.
http/tests/navigation/target-blank-opener-post.html
Ditto.
svg/animations/use-animate-width-and-height.html
Ditto.

platform/ios-sim-deprecated/fast/dynamic/window-resize-scrollbars-test-expected.txt: Removed.
platform/ios-simulator-wk1/TestExpectations:
platform/ios-simulator-wk2/TestExpectations:
platform/ios-simulator/TestExpectations:
platform/win/TestExpectations:

10:01 AM Changeset in webkit [180488] by ddkilzer@apple.com

1 edit
5 moves
1 add in trunk/LayoutTests

[iOS] Gardening: Add missing results for WK2 tests

In all cases, WK1 and WK2 results were the same.

platform/ios-simulator/fast/block/positioning/vertical-rl/001-expected.txt: Rename from LayoutTests/platform/ios-sim-deprecated/fast/block/positioning/vertical-rl/001-expected.txt.
platform/ios-simulator/fast/body-propagation/background-color/001-xhtml-expected.txt: Rename from LayoutTests/platform/ios-sim-deprecated/fast/body-propagation/background-color/001-xhtml-expected.txt.
platform/ios-simulator/fast/body-propagation/background-image/001-xhtml-expected.txt: Rename from LayoutTests/platform/ios-sim-deprecated/fast/body-propagation/background-image/001-xhtml-expected.txt.
platform/ios-simulator/fast/body-propagation/overflow/001-xhtml-expected.txt: Rename from LayoutTests/platform/ios-sim-deprecated/fast/body-propagation/overflow/001-xhtml-expected.txt.
platform/ios-simulator/fast/repaint/body-background-image-expected.txt: Rename from LayoutTests/platform/ios-sim-deprecated/fast/repaint/body-background-image-expected.txt.

9:26 AM Changeset in webkit [180487] by ddkilzer@apple.com

1 edit
1 move
1 add in trunk/LayoutTests

[iOS] Gardening: Add missing results for WK1 tests

platform/ios-simulator/fast/css/css2-system-fonts-expected.txt: Rename from LayoutTests/platform/ios-simulator-wk2/fast/css/css2-system-fonts-expected.txt.
Platform-specific results are the same for WK1 and WK2. Regressed in r179196: shared ios-simulator results should not have been removed.
platform/ios-simulator/fast/css/focus-ring-exists-for-search-field-expected.txt: Add.
Platform-specific results were missing for both WK1 and WK2. Regressed in r179796: no ios-simulator results landed.

8:49 AM Changeset in webkit [180486] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Lazily Create GeneralTreeElement Status Elements
https://bugs.webkit.org/show_bug.cgi?id=141873

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-02-22
Reviewed by Timothy Hatcher.

UserInterface/Views/GeneralTreeElement.js:

(WebInspector.GeneralTreeElement.prototype.set status):
(WebInspector.GeneralTreeElement.prototype.onattach):
(WebInspector.GeneralTreeElement.prototype._createElementsIfNeeded):
(WebInspector.GeneralTreeElement.prototype._updateStatusElement):
Lazily create and attach the status element container if
"this.status" is actually used by a GeneralTreeElement subclass.

UserInterface/Views/ResourceTreeElement.js:

(WebInspector.ResourceTreeElement.prototype._updateStatus):
Set to the empty string instead of null to avoid inadvertently
creating status elements for no reason.

8:47 AM Changeset in webkit [180485] by commit-queue@webkit.org

4 edits in trunk/Source/WebInspectorUI

Web Inspector: Give ObjectPreviewView a showTitle/showPreview toggle
https://bugs.webkit.org/show_bug.cgi?id=141874

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-02-22
Reviewed by Timothy Hatcher.

Refactor ObjectTree/ObjectPreview a bit to make it easier
to use expanding/collapsing previews in other places.

UserInterface/Views/ObjectPreviewView.js:

(WebInspector.ObjectPreviewView):
(WebInspector.ObjectPreviewView.prototype.showTitle):
(WebInspector.ObjectPreviewView.prototype.showPreview):
Maintain both a titleElement and previewElement. Show only
one at a time based on showTitle/showPreview APIs.

UserInterface/Views/ObjectTreeView.css:

(.object-tree.expanded .object-preview):

UserInterface/Views/ObjectTreeView.js:

(WebInspector.ObjectTreeView):
(WebInspector.ObjectTreeView.prototype.expand):
(WebInspector.ObjectTreeView.prototype.collapse):
If we have a preview, let PreviewView handle toggling
between a title and preview display.

8:43 AM Changeset in webkit [180484] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Make Console UI icons / lines slightly larger
https://bugs.webkit.org/show_bug.cgi?id=141876

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-02-22
Reviewed by Timothy Hatcher.

In preparation for a new ObjectTree design with larger icons,
increase the size of existing output in the Console / Log
so they don't look so small in comparison. This:

bumps minimum height of lines from 16px to 21px
10x10 icons to be 12x12
recenters icons to match console prompt
realigns icons with console log / object output

UserInterface/Views/LogContentView.css:

(.console-user-command-result.console-log-level::before):
(.console-message, .console-user-command):
(.console-item::before):
(.console-user-command::before):
(:matches(.console-warning-level, .console-error-level, .console-log-level).console-message):
(:matches(.console-warning-level, .console-error-level, .console-log-level)::before):
(.outline-disclosure li):
(.outline-disclosure .expanded li):
Fix a case breaking single-line message height.
Only add padding to expanded trees, not collapsed trees.

UserInterface/Views/QuickConsole.css:

(.quick-console > .console-prompt::before):

Feb 21, 2015:

7:50 PM Changeset in webkit [180483] by commit-queue@webkit.org

10 edits in trunk/Source

Web Inspector: Generate Previews more often for RemoteObject interaction
https://bugs.webkit.org/show_bug.cgi?id=141875

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-02-21
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

inspector/protocol/Runtime.json:

Add generatePreview to getProperties.

inspector/InjectedScript.cpp:

(Inspector::InjectedScript::getProperties):
(Inspector::InjectedScript::getInternalProperties):

inspector/InjectedScript.h:
inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::getProperties):

inspector/agents/InspectorRuntimeAgent.h:

Plumb the generatePreview boolean through to the injected script.

inspector/InjectedScriptSource.js:

Add generatePreview for getProperties.
Fix callFunctionOn to generatePreviews if asked.

Source/WebInspectorUI:

UserInterface/Models/PropertyDescriptor.js:

(WebInspector.PropertyDescriptor.fromPayload):
Fix InternalPropertyDescriptor ingestion. There was no ".internal"
property on these objects, so take a flag.

UserInterface/Protocol/RemoteObject.js:

(WebInspector.RemoteObject.prototype._getPropertyDescriptors):
Fix InternalPropertyDescriptor ingestion by specifying during
importing the internal properties. Also, get previews.

(WebInspector.RemoteObject.prototype.callFunction):
Always get previews when using callFunctionOn.

5:56 PM Changeset in webkit [180482] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

[iOS] Fix build failure after including CoreMediaSoftLink.h in WebVideoFullscreenInterfaceAVKit.mm
<http://webkit.org/b/141816>

Attempt to fix the following build failure:

WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:68:1: error: call to 'CoreMediaLibrary' is ambiguous
SOFT_LINK(CoreMedia, CMTimeRangeContainsTime, Boolean, (CMTimeRange range, CMTime time), (range, time))
^{In file included from WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:34:

In file included from WebCore/platform/cf/CoreMediaSoftLink.h:32:

WebCore/platform/mac/SoftLinking.h:107:79: note: expanded from macro 'SOFT_LINK'

<scratch space>:58:1: note: expanded from here

CoreMediaLibrary}~
In file included from WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:34:
WebCore/platform/cf/CoreMediaSoftLink.h:35:1: note: candidate function
SOFT_LINK_FRAMEWORK_HEADER(WebCore, CoreMedia)
^{In file included from WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:34:

In file included from WebCore/platform/cf/CoreMediaSoftLink.h:32:

WebCore/platform/mac/SoftLinking.h:298:18: note: expanded from macro 'SOFT_LINK_FRAMEWORK_HEADER'

<scratch space>:42:1: note: expanded from here

CoreMediaLibrary}
WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:67:1: note: candidate function
SOFT_LINK_FRAMEWORK(CoreMedia)
^{In file included from WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:34:

In file included from WebCore/platform/cf/CoreMediaSoftLink.h:32:

WebCore/platform/mac/SoftLinking.h:46:18: note: expanded from macro 'SOFT_LINK_FRAMEWORK'

<scratch space>:51:1: note: expanded from here

CoreMediaLibrary}

platform/ios/WebVideoFullscreenInterfaceAVKit.mm: Remove the

SOFT_LINK_FRAMEWORK(CoreMedia) macro since the remaining
SOFT_LINK() and SOFT_LINK_CONSTANT() macros can use the
CoreMediaLibrary() method exposed by CoreMediaSoftLink.h.

1:49 PM Changeset in webkit [180481] by ddkilzer@apple.com

9 edits
1 delete in trunk/Source/WebCore

Add SOFT_LINK_CONSTANT_SOURCE() cross-platform macro and start using it
<http://webkit.org/b/141816>

Reviewed by Alexey Proskuryakov.

WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
Remove CoreMediaSoftLinking.h.

platform/cf/CoreMediaSoftLink.cpp:
Add kCMTimeZero constant.
platform/cf/CoreMediaSoftLink.h:
Add SOFT_LINK_FRAMEWORK_HEADER() macro for CoreMedia.
Add kCMTimeZero constant.

platform/graphics/avfoundation/cf/CoreMediaSoftLinking.h: Remove.

platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
Remove reference to CoreMediaSoftLinking.h and update comment.

(WebCore::MediaPlayerPrivateAVFoundationCF::isAvailable):

Switch to using new method to check if a framework is available.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
Remove all local soft-linking macros for CoreMedia. CoreMediaSoftLink.h handles everything now.

(WebCore::MediaPlayerPrivateAVFoundationObjC::isAvailable):

Switch to using new method to check if a framework is available.

platform/mac/SoftLinking.h:

(SOFT_LINK_FRAMEWORK_HEADER): Add. Defines
is_Name_FrameworkAvailable() macro.
(SOFT_LINK_FRAMEWORK_SOURCE): Update to make it work with
optional framework checks without a separate macro.
(SOFT_LINK_CONSTANT_HEADER): Add.
(SOFT_LINK_CONSTANT_SOURCE): Add.

Support soft-links to constants.

platform/win/SoftLinking.h:

(SOFT_LINK_FRAMEWORK_HELPER): Add. Copied from
SOFT_LINK_LIBRARY_HELPER, with addition of namespace and
non-static function.
(SOFT_LINK_FRAMEWORK): Add. Copied from SOFT_LINK_LIBRARY.
(SOFT_LINK_DEBUG_FRAMEWORK): Add. Copied from
SOFT_LINK_DEBUG_LIBRARY.
(SOFT_LINK_FRAMEWORK_HEADER): Add. Defines
is_Name_FrameworkAvailable() macro.
(SOFT_LINK_FRAMEWORK_SOURCE): Redefine in terms of
SOFT_LINK_FRAMEWORK/SOFT_LINK_DEBUG_FRAMEWORK.
(SOFT_LINK_CONSTANT_HEADER): Add.
(SOFT_LINK_CONSTANT_SOURCE): Add.

Support soft-links to constants.

12:22 PM Changeset in webkit [180480] by youenn.fablet@crf.canon.fr

6 edits in trunk

Tests don't work on some bots: Failed to stop wptwk
https://bugs.webkit.org/show_bug.cgi?id=141235

Reviewed by Ryosuke Niwa.

Tools:

Logging of server subprocesses in launcher script.
Killing of server subprocesses when stopping/before starting.
Removed empty init.py file creation as importer now ensures these files cannot be empty anymore.

Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:

(main): Removed empty init.py file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown.

Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:

(WebPlatformTestServer.init):
(WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
(WebPlatformTestServer):
(WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
(WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown.

Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:

(TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
(TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
(TestWebPlatformTestServer):
(TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.

LayoutTests: