Timeline
Feb 28, 2015:
- 8:36 PM Changeset in webkit [180848] by
-
- 6 edits in trunk/Source
Viewport units should not dirty style just before we do layout
https://bugs.webkit.org/show_bug.cgi?id=141682
Reviewed by Zalan Bujtas.
Source/WebCore:
In documents using viewport units, we dirtied style every time layout changed
the size of the document. This is nonsensical, because viewport units depend on the
viewport size, not the document size.
Move the style dirtying from layout() into availableContentSizeChanged(). Hook
this up for WebKit1 by calling from -[WebFrameView _frameSizeChanged], and,
since that causes availableContentSizeChanged() to be called for WK1 for the first
time, protect the call to updateScrollbars() with a !platformWidget check.
Covered by existing viewport unit tests.
- page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::availableContentSizeChanged):
(WebCore::FrameView::viewportSizeForCSSViewportUnits): Add a FIXME comment. Whether
scrollbars are ignored depends on the value of the overflow property on the root element.
- page/FrameView.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::availableContentSizeChanged):
Source/WebKit/mac:
- WebView/WebFrameView.mm:
(-[WebFrameView _frameSizeChanged]):
- 6:31 PM Changeset in webkit [180847] by
-
- 2 edits in trunk/Source/WebCore
[Cocoa] Purge SQLite page cache when under memory pressure.
<https://webkit.org/b/142139>
<rdar://problem/19997739>
Reviewed by Pratik Solanki.
Call out to sqlite3 cache purging SPI on Cocoa platforms when
we need to free up some extra memory.
- platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::platformReleaseMemory):
- 5:04 PM Changeset in webkit [180846] by
-
- 2 edits in trunk/Source/WebCore
FrameView::layoutTimerFired() should update style if needed before doing layout
https://bugs.webkit.org/show_bug.cgi?id=141688
Reviewed by Andreas Kling.
If the style recalc timer has been scheduled to fire after the layout timer,
when the layout timer fires, we might as well just do the style recalc
too. The call to updateStyleIfNeeded() will cancel the pending style
recalc timer.
This doesn't have much impact on the number of layouts (measured via PLT)
but seems like a reasonable thing to do.
- page/FrameView.cpp:
(WebCore::FrameView::layoutTimerFired):
- 3:06 PM Changeset in webkit [180845] by
-
- 2 edits in trunk/Tools
[iOS] Stop running webkit-build-directory on every layout test
This was originally fixed by David Farler for Bug 135409 in
r172602.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
run webkit-build-directory every time it's called.
- 2:47 PM Changeset in webkit [180844] by
-
- 2 edits in trunk/Tools
W3C importer should use filesystem instead of shutil/host
https://bugs.webkit.org/show_bug.cgi?id=142012
Reviewed by Bem Jones-Bey.
Removed direct use of python shutil and os, except for os.walk which will require its own fix.
- Scripts/webkitpy/w3c/test_importer.py:
(main):
(TestImporter.do_import):
(TestImporter.find_importable_tests):
(TestImporter.import_tests):
(TestImporter.remove_deleted_files):
(TestImporter.write_import_log):
- 2:33 PM Changeset in webkit [180843] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r85798): Lists of crashing/timeouting/stderr tests aren't sorted
https://bugs.webkit.org/show_bug.cgi?id=142081
Reviewed by Ryosuke Niwa.
- fast/harness/results.html:
- 2:20 PM Changeset in webkit [180842] by
-
- 4 edits in trunk/Source/WebKit2
WebsiteDataStore should handle fetching and deleting local storage data
https://bugs.webkit.org/show_bug.cgi?id=142137
Reviewed by Sam Weinig.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::deleteEntriesForOrigins):
Add a new function that deletes entries from multiple origins.
- UIProcess/Storage/StorageManager.h:
Add new members.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchData):
Fetch local storage data as well.
(WebKit::WebsiteDataStore::removeData):
Delete local storage data as well.
- 1:52 PM Changeset in webkit [180841] by
-
- 3 edits in trunk/Source/WebKit2
Fetch cache origins from the network process
https://bugs.webkit.org/show_bug.cgi?id=142135
Reviewed by Dan Bernstein.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::cfURLCacheOrigins):
Add a new helper function that returns a vector of CFURL cache origins.
(WebKit::fetchDiskCacheOrigins):
Fetch the disk cache origins and pass them along to the completion handler. Currently we don't handle the new disk cache.
(WebKit::NetworkProcess::fetchWebsiteData):
Create a callback aggregator and fetch disk cache origins if we're asked for it.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::computeNetworkProcessAccessTypeForDataFetch):
New helper function that computes if we need to launch the network process in order to fetch data.
(WebKit::WebsiteDataStore::fetchData):
Fetch website data from the network process as well.
- 1:41 PM Changeset in webkit [180840] by
-
- 3 edits in trunk/LayoutTests/imported/w3c/web-platform-tests
Unreviewed - set svn:ignore for generated web-platform-tests files - see bug 142110
- 12:58 PM Changeset in webkit [180839] by
-
- 31 edits in trunk/Source/WebCore
Fullscreen video layers are off by one sometimes
https://bugs.webkit.org/show_bug.cgi?id=142122
rdar://problem/19878821
Reviewed by Eric Carlson.
Convert MediaPlayer::naturalSize() to return a FloatSize, since the natural size
isn't always integral (because of preserving pixel aspect ratio etc). Fix all the media
backends to use FloatSizes for natural size. Convert the video image drawing code
paths to FloatSize, since naturalSize is used on the destination rect computation,
and painting should be floating point anyway.
Give the layer created by SourceBufferPrivateAVFObjC a name in debug builds.
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::videoWidth):
(WebCore::HTMLVideoElement::videoHeight):
(WebCore::HTMLVideoElement::paintCurrentFrameInContext):
- html/HTMLVideoElement.h:
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::size):
(WebCore::CanvasRenderingContext2D::drawImage):
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::videoFrameToImage):
- platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayer::naturalSize):
(WebCore::MediaPlayer::paint):
(WebCore::MediaPlayer::paintCurrentFrameInContext):
(WebCore::NullMediaPlayerPrivate::paint): Deleted.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::paintCurrentFrameInContext):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::naturalSize):
(WebCore::MediaPlayerPrivateAVFoundation::setNaturalSize):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paint):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithImageGenerator):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageForTimeInRect):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::naturalSize):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::paint):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::paintCurrentFrameInContext):
- platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
(WebCore::MediaSourcePrivateAVFObjC::naturalSize):
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::naturalSize):
- platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.mm:
(WebCore::VideoTrackPrivateMediaSourceAVFObjC::naturalSize):
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::naturalSize):
(WebCore::MediaPlayerPrivateQTKit::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateQTKit::paint):
- platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
(WebCore::MockMediaPlayerMediaSource::naturalSize):
(WebCore::MockMediaPlayerMediaSource::paint):
- platform/mock/mediasource/MockMediaPlayerMediaSource.h:
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::calculateIntrinsicSize):
(WebCore::RenderVideo::paintReplaced):
- 12:20 PM Changeset in webkit [180838] by
-
- 4 edits in trunk/Source/WebKit2
Simplify WebResourceCacheManagerCFNet.mm code
https://bugs.webkit.org/show_bug.cgi?id=142134
Reviewed by Dan Bernstein.
- ENABLE(CACHE_PARTITIONING) is always true on Mac and iOS, so remove those #ifdefs.
- Make cfURLCacheHostNamesWithCallback and clearCFURLCacheForHostNames public so they can be used by the new WebsiteDataStore code in an upcoming patch.
- Change cfURLCacheHostNamesWithCallback to take an std::function instead of a block.
- WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::getCacheOrigins):
- WebProcess/ResourceCache/WebResourceCacheManager.h:
- WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.mm:
(WebKit::partitionName):
(WebKit::WebResourceCacheManager::cfURLCacheHostNamesWithCallback):
(WebKit::WebResourceCacheManager::clearCFURLCacheForHostNames):
(WebKit::WebResourceCacheManager::cfURLCacheHostNames): Deleted.
- 10:45 AM Changeset in webkit [180837] by
-
- 10 edits1 copy1 move2 adds in trunk/Source/WebKit2
Unreviewed, rolling out r180804.
https://bugs.webkit.org/show_bug.cgi?id=142131
Broke nightlies (Requested by ap on #webkit).
Reverted changeset:
"[WK2] Drop legacy WKBundlePageDiagnosticLoggingClient API"
https://bugs.webkit.org/show_bug.cgi?id=141176
http://trac.webkit.org/changeset/180804
- 7:05 AM Changeset in webkit [180836] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening 1st Mar.
- platform/efl/TestExpectations:
- Unskip tests which have been passed since r180672.
- Skip compositing/webgl.
- 5:22 AM WebKitGTK/2.8.x edited by
- (diff)
- 5:20 AM Changeset in webkit [180835] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8/Source/WTF
Merge r180620 - Enable concurrent JIT on GTK
https://bugs.webkit.org/show_bug.cgi?id=142007
Reviewed by Benjamin Poulain.
Seems weird that GTK keeps it off. No good reason for that as far as I can tell.
- wtf/Platform.h:
- 5:20 AM Changeset in webkit [180834] by
-
- 2 edits1 add in releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore
CMake build of libllvmForJSC.so should limit its export list like the Xcode build does
https://bugs.webkit.org/show_bug.cgi?id=141989
Reviewed by Gyuyoung Kim.
- CMakeLists.txt:
- llvm/library/libllvmForJSC.version: Added.
- 3:59 AM Changeset in webkit [180833] by
-
- 5 edits in releases/WebKitGTK/webkit-2.8/Source/bmalloc
Merge r180604 - Rolling out http://trac.webkit.org/changeset/180430 as it causes the PLT to crash.
<rdar://problem/19948015>
Unreviewed.
- bmalloc/VMHeap.cpp:
(bmalloc::VMHeap::grow):
- bmalloc/VMHeap.h:
- bmalloc/Zone.cpp:
(bmalloc::Zone::Zone):
(bmalloc::Zone::size): Deleted.
- bmalloc/Zone.h:
- 3:55 AM Changeset in webkit [180832] by
-
- 15 edits10 adds in releases/WebKitGTK/webkit-2.8
Merge r180600 - AX: Implement support for ARIA 1.1 'switch' role
https://bugs.webkit.org/show_bug.cgi?id=141986
Reviewed by Chris Fleizach.
Source/WebCore:
Map the role to ATK_ROLE_TOGGLE_BUTTON for Gtk and Efl; on the Mac, to
AXCheckBox with a subrole of AXSwitch. Ensure it looks and acts like a
widget to accessibility APIs (supports and emits notifications when
toggled, doesn't have children, exposes a name and description when
provided).
Tests: accessibility/aria-switch-checked.html
accessibility/aria-switch-sends-notification.html
accessibility/aria-switch-text.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canHaveChildren):
(WebCore::AccessibilityNodeObject::isChecked):
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isARIAInput):
(WebCore::AccessibilityObject::actionVerb):
(WebCore::initializeRoleMap):
(WebCore::AccessibilityObject::supportsChecked):
(WebCore::AccessibilityObject::checkboxOrRadioValue):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isSwitch):
- accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
LayoutTests:
- accessibility/aria-switch-checked-expected.txt: Added.
- accessibility/aria-switch-checked.html: Added.
- accessibility/aria-switch-sends-notification-expected.txt: Added.
- accessibility/aria-switch-sends-notification.html: Added.
- accessibility/aria-switch-text.html: Added.
- accessibility/roles-exposed.html: Added a test case for the new role.
- platform/efl/accessibility/aria-fallback-roles-expected.txt: Added.
- platform/efl/accessibility/aria-switch-text-expected.txt: Added.
- platform/efl/accessibility/roles-exposed-expected.txt: Updated for the new role.
- platform/gtk/accessibility/aria-fallback-roles-expected.txt: Added.
- platform/gtk/accessibility/aria-switch-text-expected.txt: Added.
- platform/gtk/accessibility/roles-exposed-expected.txt: Updated for the new role.
- platform/mac-mavericks/accessibility/roles-exposed-expected.txt: Updated for the new role.
- platform/mac/TestExpectations: Skip the 'checked' notifcation as the Mac doesn't have it.
- platform/mac/accessibility/aria-switch-text-expected.txt: Added.
- platform/mac/accessibility/roles-exposed-expected.txt: Updated for the new role.
- 3:52 AM Changeset in webkit [180831] by
-
- 6 edits in releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore
Merge r180591 - Rolling out r179753. The fix was invalid.
<https://webkit.org/b/141990>
Not reviewed.
- API/tests/testapi.mm:
(threadMain):
(useVMFromOtherThread): Deleted.
(useVMFromOtherThreadAndOutliveVM): Deleted.
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::gatherStackRoots):
- heap/Heap.h:
(JSC::Heap::machineThreads):
- heap/MachineStackMarker.cpp:
(JSC::MachineThreads::Thread::Thread):
(JSC::MachineThreads::MachineThreads):
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::removeThread):
(JSC::MachineThreads::removeCurrentThread):
- heap/MachineStackMarker.h:
- 3:49 AM Changeset in webkit [180830] by
-
- 2 edits in trunk/Tools
W3C test importer should use filesystem to read and write files
https://bugs.webkit.org/show_bug.cgi?id=142084
Reviewed by Bem Jones-Bey.
Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
- Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.import_tests):
(TestImporter.remove_deleted_files):
(TestImporter.write_import_log):
- 3:31 AM Changeset in webkit [180829] by
-
- 13 edits1 add in releases/WebKitGTK/webkit-2.8/Source/bmalloc
Merge r180576 - bmalloc: Added a little more abstraction for large objects
https://bugs.webkit.org/show_bug.cgi?id=141978
Reviewed by Sam Weinig.
Previously, each client needed to manage the boundary tags of
a large object using free functions. This patch introduces a LargeObject
class that does things a little more automatically.
- bmalloc.xcodeproj/project.pbxproj:
- bmalloc/Allocator.cpp:
(bmalloc::Allocator::reallocate): Use the new LargeObject class.
- bmalloc/BeginTag.h:
(bmalloc::BeginTag::isInFreeList): Deleted. Moved this logic into the
LargeObject class.
- bmalloc/BoundaryTag.h:
(bmalloc::BoundaryTag::isSentinel):
(bmalloc::BoundaryTag::compactBegin):
(bmalloc::BoundaryTag::setRange):
(bmalloc::BoundaryTag::initSentinel): Added an explicit API for sentinels,
which we used to create and test for implicitly.
- bmalloc/BoundaryTagInlines.h:
(bmalloc::BoundaryTag::init):
(bmalloc::validate): Deleted.
(bmalloc::validatePrev): Deleted.
(bmalloc::validateNext): Deleted.
(bmalloc::BoundaryTag::mergeLeft): Deleted.
(bmalloc::BoundaryTag::mergeRight): Deleted.
(bmalloc::BoundaryTag::merge): Deleted.
(bmalloc::BoundaryTag::deallocate): Deleted.
(bmalloc::BoundaryTag::split): Deleted.
(bmalloc::BoundaryTag::allocate): Deleted. Moved this logic into the
LargeObject class.
- bmalloc/EndTag.h:
(bmalloc::EndTag::init):
(bmalloc::EndTag::operator=): Deleted. Re-reading this code, I found
special behavior in the assignment operator to be a surprising API.
So, I replaced the assignment operation with an explicit initializing
function.
- bmalloc/Heap.cpp:
(bmalloc::Heap::scavengeLargeRanges):
(bmalloc::Heap::allocateXLarge):
(bmalloc::Heap::findXLarge):
(bmalloc::Heap::deallocateXLarge):
(bmalloc::Heap::allocateLarge):
(bmalloc::Heap::deallocateLarge):
- bmalloc/Heap.h: No behavior changes here -- just adopting the
LargeObject interface.
- bmalloc/LargeObject.h: Added.
(bmalloc::LargeObject::operator!):
(bmalloc::LargeObject::begin):
(bmalloc::LargeObject::size):
(bmalloc::LargeObject::range):
(bmalloc::LargeObject::LargeObject):
(bmalloc::LargeObject::setFree):
(bmalloc::LargeObject::isFree):
(bmalloc::LargeObject::hasPhysicalPages):
(bmalloc::LargeObject::setHasPhysicalPages):
(bmalloc::LargeObject::isValidAndFree):
(bmalloc::LargeObject::merge):
(bmalloc::LargeObject::split):
(bmalloc::LargeObject::validateSelf):
(bmalloc::LargeObject::validate): Moved this code into a class, out of
BoundaryTag free functions.
New to the class are these features:
(1) Every reference to an object is validated upon creation and use.
(2) There's an explicit API for "This is a reference to an object
that might be stale (the DoNotValidate API)".
(3) The begin and end tags are kept in sync automatically.
- bmalloc/SegregatedFreeList.cpp:
(bmalloc::SegregatedFreeList::insert):
(bmalloc::SegregatedFreeList::takeGreedy):
(bmalloc::SegregatedFreeList::take):
- bmalloc/SegregatedFreeList.h: Adopt the LargeObject interface.
- bmalloc/VMHeap.cpp:
(bmalloc::VMHeap::grow):
- bmalloc/VMHeap.h:
(bmalloc::VMHeap::allocateLargeRange):
(bmalloc::VMHeap::deallocateLargeRange): Adopt the LargeObject interface.
- 3:29 AM Changeset in webkit [180828] by
-
- 50 edits2 adds in releases/WebKitGTK/webkit-2.8
Merge r180570 - REGRESSION(r179429): Can't type comments in Facebook
https://bugs.webkit.org/show_bug.cgi?id=141859
Reviewed by Brent Fulgham.
Source/JavaScriptCore:
When window.Symbol is exposed to user-space pages,
Facebook's JavaScript use it (maybe, for immutable-js and React.js's unique key).
However, to work with Symbols completely, it also requires
1) Object.getOwnPropertySymbols (for mixin including Symbols)
2) the latest ES6 Iterator interface that uses Iterator.next and it returns { done: boolean, value: value }.
Since they are not landed yet, comments in Facebook don't work.
This patch introduces RuntimeFlags for JavaScriptCore.
Specifying SymbolEnabled flag under test runner and inspector to continue to work with Symbol.
And drop JavaScriptExperimentsEnabled flag
because it is no longer used and use case of this is duplicated to runtime flags.
- JavaScriptCore.order:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- jsc.cpp:
(GlobalObject::javaScriptRuntimeFlags):
(GlobalObject::javaScriptExperimentsEnabled): Deleted.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::init):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::finishCreation):
(JSC::JSGlobalObject::javaScriptRuntimeFlags):
(JSC::JSGlobalObject::javaScriptExperimentsEnabled): Deleted.
- runtime/RuntimeFlags.h: Added.
(JSC::RuntimeFlags::RuntimeFlags):
(JSC::RuntimeFlags::createAllEnabled):
Source/WebCore:
Enable SymbolEnabled runtime flag in inspector context.
- ForwardingHeaders/runtime/RuntimeFlags.h: Added.
- WebCore.order:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::javaScriptRuntimeFlags):
(WebCore::JSDOMWindowBase::javaScriptExperimentsEnabled): Deleted.
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::javaScriptRuntimeFlags):
(WebCore::JSWorkerGlobalScopeBase::javaScriptExperimentsEnabled): Deleted.
- bindings/js/JSWorkerGlobalScopeBase.h:
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
- page/Settings.h:
- page/Settings.in:
Source/WebKit/mac:
Introduce SymbolEnabled and drop javaScriptExperimentsEnabled.
Private API, javaScriptExperimentsEnabled is dropped.
- Misc/WebNSDictionaryExtras.h:
- Misc/WebNSDictionaryExtras.m:
(-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]):
- WebKit.order:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences _setUnsignedIntValue:forKey:]):
(-[WebPreferences javaScriptRuntimeFlags]):
(-[WebPreferences setJavaScriptRuntimeFlags:]):
(-[WebPreferences setJavaScriptExperimentsEnabled:]): Deleted.
(-[WebPreferences javaScriptExperimentsEnabled]): Deleted.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit/win:
Added Windows support.
- Interfaces/IWebPreferences.idl:
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::javaScriptRuntimeFlags):
(WebPreferences::setJavaScriptRuntimeFlags):
(WebPreferences::isWebSecurityEnabled):
- WebPreferences.h:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Source/WebKit2:
Enable SymbolEnabled in inspector context.
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetJavaScriptRuntimeFlags):
(WKPreferencesGetJavaScriptRuntimeFlags):
(WKPreferencesSetJavaScriptExperimentsEnabled): Deleted.
(WKPreferencesGetJavaScriptExperimentsEnabled): Deleted.
- UIProcess/API/C/WKPreferencesRef.h:
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _javaScriptRuntimeFlags]):
(-[WKPreferences _setJavaScriptRuntimeFlags:]):
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- mac/WebKit2.order:
Tools:
Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
- 3:16 AM WebKitGTK/2.8.x edited by
- (diff)
- 3:14 AM WebKitGTK/2.8.x edited by
- (diff)
- 3:13 AM WebKitGTK/2.8.x edited by
- (diff)
- 3:05 AM Changeset in webkit [180827] by
-
- 4 edits in releases/WebKitGTK/webkit-2.8
Merge r180566 - [GTK] Layout Test accessibility/roles-exposed.html is failing
https://bugs.webkit.org/show_bug.cgi?id=141960
Reviewed by Martin Robinson.
Source/WebCore:
The test was failing because Gtk now uses GtkColorChooserDialog for the
color input, making the input field a button which results in the color
chooser dialog appearing. As a side effect of this change, the input now
has an accessible role of ColorWell, which is currently mapped to
ATK_ROLE_COLOR_CHOOSER (which is by definition the dialog which results
upon activating the button input field). Changed the Gtk platform mapping
to ATK_ROLE_BUTTON, leaving the Efl mapping as-is.
No new tests. Instead, updated and unskipped failing test.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
LayoutTests:
- platform/gtk/TestExpectations: Unskip the failing test.
- platform/gtk/accessibility/roles-exposed-expected.txt: Update the expectations.
- 3:03 AM Changeset in webkit [180826] by
-
- 5 edits in releases/WebKitGTK/webkit-2.8
Merge r180565 - Crash loading local file with WebPageProxy::loadAlternateHTMLString
https://bugs.webkit.org/show_bug.cgi?id=141867
Patch by Michael Catanzaro <Michael Catanzaro> on 2015-02-24
Reviewed by Anders Carlsson.
Source/WebKit2:
WebPageProxy::loadAlternateHTMLString needs to assume read access to unreachableURL as well
as baseURL, because unreachableURL will get added to the back/forward list, causing us to
crash later on when we notice the unexpected URL received in checkURLReceivedFromWebProcess.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadAlternateHTMLString):
Tools:
- TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
(TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
be shared with the new test.
(TestWebKitAPI::TEST): Add a cross-platform test for this crash.
- TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
(testLoadAlternateHTMLForLocalPage):
(beforeAll):
- 3:00 AM Changeset in webkit [180825] by
-
- 3 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore
Merge r180563 - [GTK] Fonts loaded via @font-face look bad
https://bugs.webkit.org/show_bug.cgi?id=140994
Patch by Michael Catanzaro <Michael Catanzaro> on 2015-02-24
Reviewed by Martin Robinson.
We've had several complaints that woff fonts look bad on some websites. This seems to be a
combination of multiple issues. For one, we don't look at Fontconfig settings at all when
creating a web font. This commit changes FontPlatformData::initializeWithFontFace to instead
use sane default settings from Fontconfig when loading a web font, rather than accepting the
default settings from GTK+, which are normally overridden by Fontconfig when loading system
fonts. However, we will hardcode the hinting setting for web fonts to always force use of
the light autohinter, so that we do not use a font's native hints. This avoids compatibility
issues when fonts with poor native hinting are only tested in browsers that do not use the
native hints. It also allows us to sidestep future security vulnerabilities in FreeType's
bytecode interpreter.
The net result of this is that there should be little noticable difference if you have GTK+
set to use slight hinting (which forces use of the autohinter) unless you have customized
Fontconfig configuration, but a dramatic improvement with particular fonts if you use medium
or full hinting. This should reduce complaints about our font rendering on "fancy sites."
No new tests, since the affected fonts we've found are not freely redistributable.
- platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::FontCustomPlatformData::FontCustomPlatformData): Force web fonts to be autohinted.
- platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::getDefaultCairoFontOptions): Renamed to disambiguate.
(WebCore::getDefaultFontconfigOptions): Added.
(WebCore::FontPlatformData::initializeWithFontFace): Always call
FontPlatformData::setCairoOptionsFromFontConfigPattern. If the FontPlatformData was not
created with an FcPattern (e.g. because this is a web font), call
getDefaultFontconfigOptions to get a sane default FcPattern.
(WebCore::FontPlatformData::setOrientation): Renamed call to getDefaultCairoFontOptions.
(WebCore::getDefaultFontOptions): Deleted.
- 2:56 AM Changeset in webkit [180824] by
-
- 18 edits in releases/WebKitGTK/webkit-2.8
Merge r180558 - Always serialize :lang()'s arguments to strings
https://bugs.webkit.org/show_bug.cgi?id=141944
Reviewed by Benjamin Poulain.
Source/WebCore:
As specified in [1] :lang()'s arguments are always serialized to strings.
[1] http://dev.w3.org/csswg/cssom/#serializing-selectors
Related tests are updated.
- css/CSSGrammar.y.in:
- css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::setLangArgumentList):
- css/CSSParserValues.h:
(WebCore::CSSParserString::init):
(WebCore::CSSParserString::clear):
(WebCore::CSSParserString::tokenType): Deleted.
(WebCore::CSSParserString::setTokenType): Deleted.
- css/CSSSelector.cpp:
(WebCore::appendLangArgumentList):
(WebCore::CSSSelector::setLangArgumentList):
- css/CSSSelector.h:
(WebCore::CSSSelector::langArgumentList):
- css/SelectorCheckerTestFunctions.h:
(WebCore::matchesLangPseudoClass):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsInLanguage):
LayoutTests:
Some tests results are updated to reflect the always serialize
:lang()'s arguments to strings.
- fast/css/css-lang-selector-with-string-arguments-text-expected.txt:
- fast/css/css-lang-selector-with-string-arguments-text.html:
- fast/css/parsing-css-lang-expected.txt:
- fast/css/parsing-css-lang.html:
- fast/css/css-selector-text-expected.txt:
- fast/css/css-selector-text.html:
- fast/css/css-set-selector-text-expected.txt:
- fast/css/css-set-selector-text.html:
- fast/dom/css-selectorText-expected.txt:
- 2:51 AM Changeset in webkit [180823] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore
Merge r180554 - Give TemporaryChange for m_inLoadPendingImages assertion a name so it actually does something.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingImages):
- 1:31 AM Changeset in webkit [180822] by
-
- 5 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore
Merge r180548 - EventHandler references deleted Scrollbar
https://bugs.webkit.org/show_bug.cgi?id=141931
<rdar://problem/19915210>
Reviewed by Tim Horton.
Tested by scrollbars/overflow-custom-scrollbar-crash.html
Update the EventHandler class to use a WeakPtr to reference the
last used Scrollbar, rather than retaining the Scrollbar and
artificially extending its life. This keeps the EventHandler
state in proper sync with the state of the render tree, and
avoids cases where we have destroyed a ScrollableArea (and
Scrollbar) but are still sending messages to a fake zombie
version of the element.
- page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::updateLastScrollbarUnderMouse):
- page/EventHandler.h:
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::Scrollbar): Initialize WeakPtrFactory.
- platform/Scrollbar.h:
(WebCore::Scrollbar::createWeakPtr): Added,
- 1:26 AM Changeset in webkit [180821] by
-
- 4 edits in releases/WebKitGTK/webkit-2.8
Merge r180535 - WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
https://bugs.webkit.org/show_bug.cgi?id=141935
Reviewed by Myles C. Maxfield.
Source/WTF:
- wtf/WeakPtr.h:
(WTF::WeakPtr::operator=): Added 'nullptr_t' overload.
(WTF::WeakPtr::clear): Renamed from 'forget'
(WTF::WeakPtr::forget): Deleted.
Tools:
- TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
(TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
tests for assigning from nullptr.
- 1:08 AM Changeset in webkit [180820] by
-
- 4 edits in releases/WebKitGTK/webkit-2.8
Merge r180528 - Source/WTF:
WTF::WeakPtr should have a 'forget' method
https://bugs.webkit.org/show_bug.cgi?id=141923
Reviewed by Myles C. Maxfield.
- wtf/WeakPtr.h:
(WTF::WeakPtr::forget): Added.
Tools:
WTF::WeakPtr should have a 'forget' method.
https://bugs.webkit.org/show_bug.cgi?id=141923
Reviewed by Myles C. Maxfield.
- TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
(TestWebKitAPI::TEST): Added 'Forget' tests case.
- 12:41 AM Changeset in webkit [180819] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.8
Merge r180530 - Default value of HTMLSelectElement size IDL attribute should be 0.
https://bugs.webkit.org/show_bug.cgi?id=141795
Reviewed by Andreas Kling.
Source/WebCore:
Default value of HTMLSelectElement size IDL attribute should be 0.
As in spec: http://www.w3.org/html/wg/drafts/html/master/forms.html#the-select-element, also this matches the behavior of Chrome, IE and
Gecko.
Test: fast/dom/select-size.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseAttribute):
LayoutTests:
- fast/dom/select-size-expected.txt: Added.
- fast/dom/select-size.html: Added.
- 12:38 AM Changeset in webkit [180818] by
-
- 2 edits1 add in releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore
Merge r180516 - r9 is volatile on ARMv7 for iOS 3 and up.
https://bugs.webkit.org/show_bug.cgi?id=141489
rdar://problem/19432916
Reviewed by Michael Saboff.
- jit/RegisterSet.cpp:
(JSC::RegisterSet::calleeSaveRegisters): removed r9 from the list of ARMv7 callee save registers.
- tests/stress/regress-141489.js: Added.
(foo):
Feb 27, 2015:
- 11:26 PM Changeset in webkit [180817] by
-
- 4 edits in trunk/Source
Source/WebCore:
[EFL][GTK] Fix build break after r180790,180798
https://bugs.webkit.org/show_bug.cgi?id=142127
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-02-27
Reviewed by Gyuyoung Kim.
- platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::addEllipse):
Source/WebKit2:
[EFL][GTK] Fix build break after r180790,180798
https://bugs.webkit.org/show_bug.cgi?id=142127
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-02-27
Reviewed by Gyuyoung Kim.
- CMakeLists.txt:
- 11:12 PM Changeset in webkit [180816] by
-
- 2 edits in trunk/Source/WebKit
[Win] Unreviewed build fix.
Adjust project dependencies to ensure a consistent build order.
- WebKit.vcxproj/WebKit.sln:
- 10:21 PM Changeset in webkit [180815] by
-
- 18 edits in trunk
Subpixel-layout: width: max-content; property might cause unnecessary scrollbar.
https://bugs.webkit.org/show_bug.cgi?id=142065
Reviewed by Simon Fraser.
Source/WebCore:
We should not pixelsnap (ceil in this case) logical coordinates during layout.
Should this cause content to be partially cut off, we need to
find the broken piece in the computation logic.
Covered by the unskipped test.
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::paddedLayoutOverflowRect):
LayoutTests:
Rebaseline. Scroll layer shrinks in certain cases.
- platform/mac-mavericks/editing/input/caret-at-the-edge-of-input-expected.txt:
- platform/mac-mavericks/fast/css/text-overflow-input-expected.txt:
- platform/mac-mavericks/fast/forms/basic-inputs-expected.txt:
- platform/mac-mavericks/fast/forms/control-restrict-line-height-expected.txt:
- platform/mac-mavericks/fast/forms/input-disabled-color-expected.txt:
- platform/mac-mavericks/fast/forms/search/search-size-with-decorations-expected.txt:
- platform/mac-mavericks/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/fast/forms/control-restrict-line-height-expected.txt:
- platform/mac/fast/forms/input-appearance-selection-expected.txt:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/mac/fast/forms/input-type-text-min-width-expected.txt:
- platform/mac/fast/forms/minWidthPercent-expected.txt:
- platform/mac/fast/forms/search/search-size-with-decorations-expected.txt:
- platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
- 10:02 PM Changeset in webkit [180814] by
-
- 6 edits1 delete in trunk/Source/WTF
Remove unused PossiblyNull
https://bugs.webkit.org/show_bug.cgi?id=142124
Reviewed by Andreas Kling.
- WTF.vcxproj/WTF.vcxproj: Removed the file.
- WTF.vcxproj/WTF.vcxproj.filters: Ditto.
- WTF.xcodeproj/project.pbxproj: Ditto.
- wtf/CMakeLists.txt: Ditto.
- wtf/PossiblyNull.h: Removed.
- wtf/FastMalloc.h: Moved everything to the left.
Moved member functions out of the TryMallocReturnValue class definition.
(WTF::TryMallocReturnValue::operator PossiblyNull<T>): Deleted.
(WTF::TryMallocReturnValue::getValue): Marked inline, changed to work
only with pointer types, not arbitrary non-pointer types.
- 7:21 PM Changeset in webkit [180813] by
-
- 23 edits2 adds in trunk/Source/JavaScriptCore
[JSC] Use the way number constants are written to help type speculation
https://bugs.webkit.org/show_bug.cgi?id=142072
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-02-27
Reviewed by Filip Pizlo.
This patch changes how we interpret numeric constant based on how they appear
in the source.
Constants that are integers but written with a decimal point now carry that information
to the optimizating tiers. From there, we use that to be more aggressive about typing
math operations toward double operations.
For example, in:
var a = x + 1.0;
var b = y + 1;
The Add for a would be biased toward doubles, the Add for b would speculate
integer as usual.
The gains are tiny but this is a prerequisite to make my next patch useful:
-SunSpider's access-fannkuch: definitely 1.0661x faster
-SunSpider's math-cordic: definitely 1.0266x slower
overal: might be 1.0066x slower.
-Kraken's imaging-darkroom: definitely 1.0333x faster.
- parser/Lexer.cpp:
(JSC::tokenTypeForIntegerLikeToken):
(JSC::Lexer<T>::lex):
The lexer now create two types of tokens for number: INTEGER and DOUBLE.
Those token types only carry information about how the values were
entered, an INTEGER does not have to be an integer, it is only written like one.
Large integer still end up represented as double in memory.
One trap I fell into was typing numbers like 12e3 as double. This kind of literal
is frequently used in integer-typed code, while 12.e3 would appear in double-typed
code.
Because of that, the only signals for double are: decimal point, negative zero,
and ridiculously large values.
- parser/NodeConstructors.h:
(JSC::DoubleNode::DoubleNode):
(JSC::IntegerNode::IntegerNode):
- parser/Nodes.h:
(JSC::NumberNode::value):
(JSC::NumberNode::setValue): Deleted.
Number get specialized in two new kind of nodes in the AST: IntegerNode and DoubleNode.
- bytecompiler/NodesCodegen.cpp:
(JSC::NumberNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createDoubleExpr):
(JSC::ASTBuilder::createIntegerExpr):
(JSC::ASTBuilder::createIntegerLikeNumber):
(JSC::ASTBuilder::createDoubleLikeNumber):
(JSC::ASTBuilder::createNumberFromBinaryOperation):
(JSC::ASTBuilder::createNumberFromUnaryOperation):
(JSC::ASTBuilder::makeNegateNode):
(JSC::ASTBuilder::makeBitwiseNotNode):
(JSC::ASTBuilder::makeMultNode):
(JSC::ASTBuilder::makeDivNode):
(JSC::ASTBuilder::makeModNode):
(JSC::ASTBuilder::makeAddNode):
(JSC::ASTBuilder::makeSubNode):
(JSC::ASTBuilder::makeLeftShiftNode):
(JSC::ASTBuilder::makeRightShiftNode):
(JSC::ASTBuilder::makeURightShiftNode):
(JSC::ASTBuilder::makeBitOrNode):
(JSC::ASTBuilder::makeBitAndNode):
(JSC::ASTBuilder::makeBitXOrNode):
(JSC::ASTBuilder::createNumberExpr): Deleted.
(JSC::ASTBuilder::createNumber): Deleted.
The AST has some optimization to resolve constants before emitting bytecode.
In the new code, the intger representation is kept if both operands where
also represented as integers.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseDeconstructionPattern):
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parseGetterSetter):
(JSC::Parser<LexerType>::parsePrimaryExpression):
(JSC::Parser<LexerType>::printUnexpectedTokenText):
- parser/ParserTokens.h:
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createDoubleExpr):
(JSC::SyntaxChecker::createIntegerExpr):
(JSC::SyntaxChecker::createNumberExpr): Deleted.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::registerName):
(JSC::CodeBlock::constantName):
Change constantName(r, getConstant(r)) -> constantName(r) to simplify
the dump code.
(JSC::CodeBlock::dumpBytecode):
Dump thre soure representation information we have with each constant.
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::shrinkToFit):
(JSC::constantName): Deleted.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::constantsSourceCodeRepresentation):
(JSC::CodeBlock::addConstant):
(JSC::CodeBlock::addConstantLazily):
(JSC::CodeBlock::constantSourceCodeRepresentation):
(JSC::CodeBlock::setConstantRegisters):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::addConstant):
(JSC::UnlinkedCodeBlock::constantsSourceCodeRepresentation):
(JSC::UnlinkedCodeBlock::shrinkToFit):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addConstantValue):
(JSC::BytecodeGenerator::emitLoad):
- bytecompiler/BytecodeGenerator.h:
We have to differentiate between constants that have the same values but are
represented differently in the source. Values like 1.0 and 1 now end up
as different constants.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::addConstantToGraph):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::registerFrozenValues):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::addSpeculationMode):
(JSC::DFG::Graph::addImmediateShouldSpeculateInt32):
ArithAdd is very aggressive toward using Int52, which is quite useful
in many benchmarks.
Here we need to specialize to make sure we don't force our literals
to Int52 if there were represented as double.
There is one exception to that rule: when the other operand is guaranteed
to come from a NodeResultInt32. This is because there is some weird code
doing stuff like:
var b = a|0;
var c = b*2.0;
- dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::setOpAndDefaultFlags):
(JSC::DFG::Node::sourceCodeRepresentation):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- runtime/JSCJSValue.h:
(JSC::EncodedJSValueWithRepresentationHashTraits::emptyValue):
(JSC::EncodedJSValueWithRepresentationHashTraits::constructDeletedValue):
(JSC::EncodedJSValueWithRepresentationHashTraits::isDeletedValue):
(JSC::EncodedJSValueWithRepresentationHash::hash):
(JSC::EncodedJSValueWithRepresentationHash::equal):
- tests/stress/arith-add-with-constants.js: Added.
- tests/stress/arith-mul-with-constants.js: Added.
- 7:16 PM Changeset in webkit [180812] by
-
- 3 edits2 adds in trunk/LayoutTests
[iOS] Gardening: rebaseline fast/attachment results
- platform/ios-simulator/fast/attachment/attachment-disabled-dom-expected.txt: Add.
- platform/ios-simulator/fast/attachment/attachment-disabled-rendering-expected.txt: Update.
- platform/ios-simulator/fast/attachment/attachment-dom-expected.txt: Add.
- platform/ios-simulator/fast/attachment/attachment-rendering-expected.txt: Update.
- 6:51 PM Changeset in webkit [180811] by
-
- 2 edits in trunk/LayoutTests
[iOS] Gardening: Unskip fast/history/page-cache-webdatabase-opened-db.html
- platform/ios-simulator/TestExpectations: Unskip test. It
passes on iOS WK1 and WK2 because WebSQL != IndexedDB.
- 6:51 PM Changeset in webkit [180810] by
-
- 2 edits in trunk/LayoutTests
[iOS] Gardening: Skip some new page-cache tests
- platform/ios-simulator/TestExpectations:
- Skip MediaSource tests: fast/history/page-cache-media-source-closed-2.html fast/history/page-cache-media-source-closed.html fast/history/page-cache-media-source-opened.html
- Skip test that uses drag-and-drop: fast/history/page-cache-createObjectURL.html
- 6:41 PM Changeset in webkit [180809] by
-
- 14 edits in trunk/Source/WebCore
Node::hasEditableStyle and isEditablePosition have too many options
https://bugs.webkit.org/show_bug.cgi?id=142078
Reviewed by Andreas Kling.
Moved the code that dealt with accessibility to htmlediting.cpp from Node. This patch introduces
new editing helper functions hasEditableStyle and isEditableNode for this purpose.
Also removed UserSelectAllTreatment from isContentEditable's arguments in the favor of using
newly extracted computeEditability in call sites that specify this option since isContentEditable
is a public DOM API.
No new tests since there should be no observable behavior changes.
- accessibility/AXObjectCache.h: Removed the declaration of an undefined function.
- dom/Element.cpp:
(WebCore::Element::shouldUseInputMethod): Uses newly added computeEditability.
- dom/Node.cpp:
(WebCore::Node::isContentEditable): Ditto. No longer takes UserSelectAllTreatment as an argument.
(WebCore::Node::isContentRichlyEditable): Ditto.
(WebCore::Node::computeEditability): Renamed from hasEditableStyle to avoid the confusion with
a helper function of the same name. Added ShouldUpdateStyle as an argument to optionally update
style tree. Also returns tri-state Editability enum instead of returning a boolean based on
the value of EditableLevel argument.
(WebCore::Node::isEditableToAccessibility): Moved to htmlediting.cpp.
(WebCore::Node::willRespondToMouseClickEvents): Uses newly added computeEditability.
(WebCore::Node::rootEditableElement): Moved to htmlediting.cpp.
- dom/Node.h: No longer includes EditingBoundary.h.
(WebCore::Node::isContentEditable):
(WebCore::Node::hasEditableStyle): No longer takes EditableType as an argument.
(WebCore::Node::hasRichlyEditableStyle): Ditto.
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Uses newly added isEditableNode.
(WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Ditto.
- editing/DeleteFromTextNodeCommand.cpp:
(WebCore::DeleteFromTextNodeCommand::doApply): Ditto.
- editing/FrameSelection.cpp:
(WebCore::CaretBase::invalidateCaretRect): Ditto.
- editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::doApply): Ditto.
(WebCore::InsertNodeBeforeCommand::doUnapply): Ditto.
- editing/RemoveNodeCommand.cpp:
(WebCore::RemoveNodeCommand::doApply): Ditto.
- editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::hasEditableStyle): Since this is the only caller of isEditablePosition
which sets DoNotUpdateStyle, directly call hasEditableStyle on the container node instead. This was
not possible prior to r180726 because isEditablePosition had to move out of tables.
- editing/VisibleUnits.cpp:
(WebCore::previousLeafWithSameEditability): Uses newly added hasEditableStyle.
(WebCore::nextLeafWithSameEditability): Ditto.
(WebCore::rootEditableOrDocumentElement): Extracted from previousLinePosition. Use helper functions
in htmlediting.cpp instead of member functions of Node since they no longer support EditableType.
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
- editing/htmlediting.cpp:
(WebCore::highestEditableRoot): Uses newly added hasEditableStyle.
(WebCore::isEditableToAccessibility): Moved from Node.
(WebCore::computeEditability): Extracted from isEditablePosition.
(WebCore::hasEditableStyle): Added.
(WebCore::isEditableNode): Added.
(WebCore::isEditablePosition): Now calls computeEditability.
(WebCore::isRichlyEditablePosition): No longer takes EditableType since that variant was never used.
(WebCore::editableRootForPosition): Moved the code from Node::rootEditableElement.
- editing/htmlediting.h:
- 6:14 PM Changeset in webkit [180808] by
-
- 2 edits in trunk/LayoutTests
Test gardening for Windows after r180796.
Unreviewed.
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2015-02-27
- platform/win/TestExpectations:
- 5:57 PM Changeset in webkit [180807] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=142119
Unreviewed. Add fast/canvas/canvas-ellipse-zero-lineto.html
to list of failing tests on Windows.
- platform/win/TestExpectations:
- 5:52 PM Changeset in webkit [180806] by
-
- 2 edits in trunk/Source/bmalloc
Fixed a typo in the previous commit.
- bmalloc/BoundaryTag.h:
(bmalloc::BoundaryTag::setOwner):
- 5:46 PM Changeset in webkit [180805] by
-
- 2 edits in trunk/Source/bmalloc
EFL build fix after r180797.
- bmalloc/BoundaryTag.h:
(bmalloc::BoundaryTag::owner):
(bmalloc::BoundaryTag::setOwner):
- 5:43 PM Changeset in webkit [180804] by
-
- 10 edits1 move3 deletes in trunk/Source/WebKit2
[WK2] Drop legacy WKBundlePageDiagnosticLoggingClient API
https://bugs.webkit.org/show_bug.cgi?id=141176
Reviewed by Sam Weinig.
Drop legacy WKBundlePageDiagnosticLoggingClient WK2 API as we are now
exposing this functionality via WKPageDiagnosticLoggingClient.h on
UIProcess side. The client-side has already been ported over.
- CMakeLists.txt:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI): Deleted.
(WebKit::toDiagnosticLoggingResultType): Deleted.
- UIProcess/API/C/WKAPICast.h:
(WebKit::toAPI):
- UIProcess/API/C/WKDiagnosticLoggingResultType.h: Renamed from Source/WebKit2/Shared/API/c/WKDiagnosticLoggingResultType.h.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetDiagnosticLoggingClient): Deleted.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/API/c/WKBundlePageDiagnosticLoggingClient.h: Removed.
- WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp: Removed.
- WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h: Removed.
- WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.cpp:
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessage):
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithResult):
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithValue):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::close):
(WebKit::WebPage::initializeInjectedBundleDiagnosticLoggingClient): Deleted.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundleDiagnosticLoggingClient): Deleted.
- 5:33 PM Changeset in webkit [180803] by
-
- 5 edits in branches/safari-600.1.4.15-branch/Source
Versioning.
- 5:19 PM Changeset in webkit [180802] by
-
- 2 edits1 move in trunk/Source/WebKit2
Rename WebResourceCacheManagerCFNet.cpp to WebResourceCacheManagerCFNet.mm
Rubber-stamped by Dan Bernstein.
This will let us use lambda to block conversion in a subsequent patch.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.mm: Renamed from Source/WebKit2/WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp.
- 5:13 PM March 2015 Meeting edited by
- (diff)
- 5:05 PM Changeset in webkit [180801] by
-
- 63 edits in trunk/Source
Make ActiveDOMObject::canSuspend() pure virtual
https://bugs.webkit.org/show_bug.cgi?id=142096
<rdar://problem/19923085>
Reviewed by Andreas Kling.
Make ActiveDOMObject::canSuspend() pure virtual so that people at least
try to provide an implementation for it. The default implementation was
returning false unconditionally and thus was preventing pages from
entering the PageCache.
- 4:48 PM Changeset in webkit [180800] by
-
- 1 copy in tags/Safari-600.1.4.15.9
New tag.
- 4:46 PM Changeset in webkit [180799] by
-
- 6 edits in trunk/Source
Unreviewed, rolling out r180203 and r180210.
https://bugs.webkit.org/show_bug.cgi?id=142116
broke process suspension and tile map (Requested by thorton on
#webkit).
Reverted changesets:
"Adopt CAMachPort-as-layer-contents"
https://bugs.webkit.org/show_bug.cgi?id=141687
http://trac.webkit.org/changeset/180203
"Fix the !USE(IOSURFACE) build"
http://trac.webkit.org/changeset/180210
- 4:42 PM Changeset in webkit [180798] by
-
- 13 edits7 adds in trunk
Add WebKit2 SPI to create a DOM File object
https://bugs.webkit.org/show_bug.cgi?id=142109
Patch by Sam Weinig <sam@webkit.org> on 2015-02-27
Reviewed by Tim Horton.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
Make <WebCore/File.h> (and associated files) available to WebKit2.
Source/WebKit2:
Add a new handle type for exposing a DOM File object to script. Follow
the pattern of WKBundleNodeHandleRef and WKBundleRangeHandleRef with the
new class WKBundleFileHandleRef. It can be created for a specific path,
and then the JS wrapper can be obtained via WKBundleFrameGetJavaScriptWrapperForFileForWorld.
- Shared/API/APIObject.h:
- Shared/API/c/WKBase.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
- WebProcess/InjectedBundle/API/c/WKBundleFileHandleRef.cpp: Added.
(WKBundleFileHandleGetTypeID):
(WKBundleFileHandleCreateWithPath):
- WebProcess/InjectedBundle/API/c/WKBundleFileHandleRef.h: Added.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetJavaScriptWrapperForFileForWorld):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
- WebProcess/InjectedBundle/DOM/InjectedBundleFileHandle.cpp: Added.
(WebKit::domHandleCache):
(WebKit::InjectedBundleFileHandle::create):
(WebKit::InjectedBundleFileHandle::getOrCreate):
(WebKit::InjectedBundleFileHandle::InjectedBundleFileHandle):
(WebKit::InjectedBundleFileHandle::~InjectedBundleFileHandle):
(WebKit::InjectedBundleFileHandle::coreFile):
- WebProcess/InjectedBundle/DOM/InjectedBundleFileHandle.h: Added.
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::jsWrapperForWorld):
- WebProcess/WebPage/WebFrame.h:
Tools:
Add a test for WKBundleFileHandleRef.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
(TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
- TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
- 4:29 PM Changeset in webkit [180797] by
-
- 14 edits1 add in trunk/Source/bmalloc
bmalloc: Pathological madvise churn on the free(malloc(x)) benchmark
https://bugs.webkit.org/show_bug.cgi?id=142058
Reviewed by Andreas Kling.
The churn was caused by repeatedly splitting an object with physical
pages from an object without, and then merging them back together again.
The merge would conservatively forget that we had physical pages, forcing
a new call to madvise on the next allocation.
This patch more strictly segregates objects in the heap from objects in
the VM heap, with these changes:
(1) Objects in the heap are not allowed to merge with objects in the VM
heap, and vice versa -- since that would erase our precise knowledge of
which physical pages had been allocated.
(2) The VM heap is exclusively responsible for allocating and deallocating
physical pages.
(3) The heap free list must consider entries for objects that are in the
VM heap to be invalid, and vice versa. (This condition can arise
because the free list does not eagerly remove items.)
With these changes, we can know that any valid object in the heap's free
list already has physical pages, and does not need to call madvise.
Note that the VM heap -- as before -- might sometimes contain ranges
or pieces of ranges that have physical pages, since we allow splitting
of ranges at granularities smaller than the VM page size. These ranges
can eventually merge with ranges in the heap during scavenging.
- bmalloc.xcodeproj/project.pbxproj:
- bmalloc/BoundaryTag.h:
(bmalloc::BoundaryTag::owner):
(bmalloc::BoundaryTag::setOwner):
(bmalloc::BoundaryTag::initSentinel):
(bmalloc::BoundaryTag::hasPhysicalPages): Deleted.
(bmalloc::BoundaryTag::setHasPhysicalPages): Deleted. Replaced the concept
of "has physical pages" with a bit indicating which heap owns the large
object. This is a more precise concept, since the old bit was really a
Yes / Maybe bit.
- bmalloc/Deallocator.cpp:
- bmalloc/FreeList.cpp: Adopt
(bmalloc::FreeList::takeGreedy):
(bmalloc::FreeList::take):
(bmalloc::FreeList::removeInvalidAndDuplicateEntries):
- bmalloc/FreeList.h:
(bmalloc::FreeList::push): Added API for considering the owner when
deciding if a free list entry is valid.
- bmalloc/Heap.cpp:
(bmalloc::Heap::Heap): Adopt new API.
(bmalloc::Heap::scavengeLargeRanges): Scavenge all ranges with no minimum,
since some ranges might be able to merge with ranges in the VM heap, and
they won't be allowed to until we scavenge them.
(bmalloc::Heap::allocateSmallPage):
(bmalloc::Heap::allocateMediumPage):
(bmalloc::Heap::allocateLarge): New VM heap API makes this function
simpler, since we always get back physical pages now.
- bmalloc/Heap.h:
- bmalloc/LargeObject.h:
(bmalloc::LargeObject::end):
(bmalloc::LargeObject::owner):
(bmalloc::LargeObject::setOwner):
(bmalloc::LargeObject::isValidAndFree):
(bmalloc::LargeObject::merge): Do not merge objects across heaps since
that causes madvise churn.
(bmalloc::LargeObject::validateSelf):
(bmalloc::LargeObject::init):
(bmalloc::LargeObject::hasPhysicalPages): Deleted.
(bmalloc::LargeObject::setHasPhysicalPages): Deleted. Propogate the Owner API.
- bmalloc/Owner.h: Added.
- bmalloc/SegregatedFreeList.cpp:
(bmalloc::SegregatedFreeList::SegregatedFreeList):
(bmalloc::SegregatedFreeList::insert):
(bmalloc::SegregatedFreeList::takeGreedy):
(bmalloc::SegregatedFreeList::take):
- bmalloc/SegregatedFreeList.h: Propogate the owner API.
- bmalloc/VMAllocate.h:
(bmalloc::vmDeallocatePhysicalPagesSloppy):
(bmalloc::vmAllocatePhysicalPagesSloppy): Clarified these functions and
removed an edge case.
- bmalloc/VMHeap.cpp:
(bmalloc::VMHeap::VMHeap):
- bmalloc/VMHeap.h:
(bmalloc::VMHeap::allocateSmallPage):
(bmalloc::VMHeap::allocateMediumPage):
(bmalloc::VMHeap::allocateLargeObject):
(bmalloc::VMHeap::deallocateLargeObject): Be sure to give each object
a new chance to merge, since it might have been prohibited from merging
before by virtue of not being in the VM heap.
(bmalloc::VMHeap::allocateLargeRange): Deleted.
(bmalloc::VMHeap::deallocateLargeRange): Deleted.
- 4:28 PM Changeset in webkit [180796] by
-
- 26 edits in trunk/LayoutTests
Updating more tests after r177774
Unreviewed.
Most of these tests simply need to be updated. However, I found two real bugs while
going through these!
- fast/css-generated-content/after-with-inline-continuation-expected.html:
- fast/css-generated-content/after-with-inline-continuation.html:
- fast/inline/hidpi-pixel-gap-between-adjacent-selection-inlines-expected.html:
- fast/inline/hidpi-select-inline-on-subpixel-position-expected.html:
- fast/inline/hidpi-select-inline-on-subpixel-position.html:
- fast/lists/rtl-marker-expected.html:
- fast/lists/rtl-marker.html:
- fast/multicol/cell-shrinkback-expected.html:
- fast/multicol/cell-shrinkback.html:
- fast/multicol/newmulticol/breaks-3-columns-3-expected.html:
- fast/multicol/newmulticol/breaks-3-columns-3.html:
- fast/regions/last-region-border-radius-expected.html:
- fast/regions/last-region-border-radius.html:
- fast/regions/overflow/overflow-first-and-last-regions.html:
- fast/regions/overflow/overflow-in-uniform-regions-dynamic-expected.html:
- fast/regions/overflow/overflow-in-uniform-regions-dynamic.html:
- fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-large-radius-expected.html:
- fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-large-radius.html:
- fast/shapes/shape-outside-floats/shape-outside-rounded-inset-expected.html:
- fast/shapes/shape-outside-floats/shape-outside-rounded-inset.html:
- fast/table/td-width-fifty-percent-regression-expected.html:
- fast/table/td-width-fifty-percent-regression.html:
- fast/text/complex-initial-advance-expected.html:
- fast/text/complex-initial-advance.html:
- platform/mac/TestExpectations:
- 4:23 PM Changeset in webkit [180795] by
-
- 5 edits in trunk
[Subpixel] Subpixelize RenderListMarker
https://bugs.webkit.org/show_bug.cgi?id=142093
Reviewed by Zalan Bujtas.
Source/WebCore:
Use floats instead of ints.
Test: fast/lists/rtl-marker.html
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
(WebCore::RenderListMarker::updateContent):
(WebCore::RenderListMarker::getRelativeMarkerRect):
- rendering/RenderListMarker.h:
LayoutTests:
- platform/mac/TestExpectations: Unskip fast/lists/rtl-marker.html
- 4:09 PM Changeset in webkit [180794] by
-
- 7 edits in trunk/Source/WebCore
<attachment> should be selected immediately upon click, and be drag/copyable upon click
https://bugs.webkit.org/show_bug.cgi?id=142114
<rdar://problem/19982520>
Reviewed by Enrica Casucci.
- css/html.css:
(attachment):
Make attachment use 'user-select: all' to act as a single click-to-select unit.
- html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::setFocus): Deleted.
- html/HTMLAttachmentElement.h:
- rendering/RenderAttachment.cpp:
(WebCore::RenderAttachment::isFocused): Deleted.
(WebCore::RenderAttachment::focusChanged): Deleted.
- rendering/RenderAttachment.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintAttachment):
Remove focus-related code; instead of focusing the element upon click,
we get a selection including just the <attachment>, and everything
behaves much more consistently (copy works, drag works, etc.).
- 4:06 PM Changeset in webkit [180793] by
-
- 4 edits in trunk/LayoutTests
Test gardening, unmark now passing tests.
- TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 4:02 PM Changeset in webkit [180792] by
-
- 7 edits in trunk
[iOS] Some MathML tests crash in RenderMathMLOperator::advanceForGlyph() or boundsForGlyph()
https://bugs.webkit.org/show_bug.cgi?id=141371
Reviewed by David Kilzer.
Source/WebCore:
Null checks.
Covered by existing mathml tests.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::boundsForGlyph):
(WebCore::RenderMathMLOperator::advanceForGlyph):
(WebCore::RenderMathMLOperator::getDisplayStyleLargeOperator):
LayoutTests:
Updating expected results and TestExpectations
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/mathml/opentype/horizontal-munderover-expected.txt:
- platform/ios-simulator/mathml/opentype/large-operators-expected.txt:
- platform/ios-simulator/mathml/opentype/vertical-expected.txt:
- 3:46 PM Changeset in webkit [180791] by
-
- 8 edits2 adds in trunk
Make SourceBuffer ActiveDOMObject suspendable
https://bugs.webkit.org/show_bug.cgi?id=142108
<rdar://problem/19923085>
Reviewed by Jer Noble.
Source/WebCore:
Make SourceBuffer ActiveDOMObject suspendable if it is removed from its
MediaSource and does not have any pending events. This makes it more
likely for pages using SourceBuffer objects to go into the PageCache.
Test: fast/history/page-cache-removed-source-buffer.html
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::canSuspend):
- Modules/mediasource/SourceBuffer.h:
LayoutTests:
Add a layout tests to check that a SourceBuffer removed from its
MediaSource does not prevent a Page from entering PageCache.
- fast/history/page-cache-removed-source-buffer-expected.txt: Added.
- fast/history/page-cache-removed-source-buffer.html: Added.
- 3:40 PM Changeset in webkit [180790] by
-
- 8 edits19 adds in trunk
Add support for canvas ellipse method
https://bugs.webkit.org/show_bug.cgi?id=82791
<rdar://problem/11159172>
Patch by Sam Weinig <sam@webkit.org> on 2015-02-26
Reviewed by Dirk Schulze.
Source/WebCore:
Tests: fast/canvas/canvas-ellipse-360-winding.html
fast/canvas/canvas-ellipse-circumference-fill.html
fast/canvas/canvas-ellipse-circumference.html
fast/canvas/canvas-ellipse-connecting-line.html
fast/canvas/canvas-ellipse-negative-radius.html
fast/canvas/canvas-ellipse-zero-lineto.html
fast/canvas/canvas-ellipse.html
- html/canvas/CanvasPathMethods.h:
- html/canvas/CanvasPathMethods.cpp:
(WebCore::CanvasPathMethods::lineTo):
Convenience for passing a FloatPoint instead of two floats.
(WebCore::normalizeAngles):
Normalizes the angles as described in the HTML spec. Ensuring the startAngle
is greater than 0 and less than 2pi, and the the endAngle is at most 2pi
from the start angle.
(WebCore::CanvasPathMethods::arc):
- Renames some of the parameters to be clearer.
- Normalizes the angles for consistency with ellipse.
- Moves hasInvertibleTransform() higher in the function for consistency.
(WebCore::CanvasPathMethods::ellipse): Added.
- html/canvas/CanvasRenderingContext2D.idl:
- html/canvas/DOMPath.idl:
Add ellipse(...).
- platform/graphics/Path.h:
- platform/graphics/cg/PathCG.cpp:
(WebCore::Path::addArc):
Rename parameters for clarity and use a nullptr.
(WebCore::Path::addEllipse):
Added. Constructs an ellipse via a transformed arc.
LayoutTests:
- fast/canvas/canvas-ellipse-360-winding-expected.txt: Added.
- fast/canvas/canvas-ellipse-360-winding.html: Added.
- fast/canvas/canvas-ellipse-circumference-expected.txt: Added.
- fast/canvas/canvas-ellipse-circumference-fill-expected.txt: Added.
- fast/canvas/canvas-ellipse-circumference-fill.html: Added.
- fast/canvas/canvas-ellipse-circumference.html: Added.
- fast/canvas/canvas-ellipse-connecting-line-expected.html: Added.
- fast/canvas/canvas-ellipse-connecting-line.html: Added.
- fast/canvas/canvas-ellipse-expected.txt: Added.
- fast/canvas/canvas-ellipse-negative-radius-expected.txt: Added.
- fast/canvas/canvas-ellipse-negative-radius.html: Added.
- fast/canvas/canvas-ellipse-zero-lineto-expected.txt: Added.
- fast/canvas/canvas-ellipse-zero-lineto.html: Added.
- fast/canvas/canvas-ellipse.html: Added.
- fast/canvas/script-tests/canvas-ellipse-360-winding.js: Added.
- fast/canvas/script-tests/canvas-ellipse.js: Added.
- fast/canvas/script-tests/js-ellipse-implementation.js: Added.
- platform/mac/fast/canvas/canvas-ellipse-circumference-expected.png: Added.
- platform/mac/fast/canvas/canvas-ellipse-circumference-fill-expected.png: Added.
- 3:37 PM Changeset in webkit [180789] by
-
- 4 edits in trunk/LayoutTests
Test more features of content extensions.
https://bugs.webkit.org/show_bug.cgi?id=142100
Patch by Alex Christensen <achristensen@webkit.org> on 2015-02-27
Reviewed by Brady Eidson.
- http/tests/usercontentfilter/basic-filter.html:
- http/tests/usercontentfilter/basic-filter.html.json:
- platform/mac/http/tests/usercontentfilter/basic-filter-expected.txt:
- 3:35 PM Changeset in webkit [180788] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Use Maps in ResourceCollection instead of objects
https://bugs.webkit.org/show_bug.cgi?id=142101
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-02-27
Reviewed by Timothy Hatcher.
- UserInterface/Models/ResourceCollection.js:
(WebInspector.ResourceCollection):
(WebInspector.ResourceCollection.prototype.resourcesWithType):
(WebInspector.ResourceCollection.prototype.removeAllResources):
(WebInspector.ResourceCollection.prototype.resourceForURL):
(WebInspector.ResourceCollection.prototype._associateWithResource):
(WebInspector.ResourceCollection.prototype._disassociateWithResource):
(WebInspector.ResourceCollection.prototype._resourceURLDidChange):
(WebInspector.ResourceCollection.prototype._resourceTypeDidChange):
Use Maps instead of objects.
- 3:32 PM Changeset in webkit [180787] by
-
- 2 edits in trunk/Tools
Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
https://bugs.webkit.org/show_bug.cgi?id=142112
Reviewed by Filip Pizlo.
Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
<someDir> as the library path.
- Scripts/run-jsc-benchmarks:
- 3:31 PM Changeset in webkit [180786] by
-
- 2 edits in trunk/LayoutTests
Some WebGL tests fail on ATI hardware
https://bugs.webkit.org/show_bug.cgi?id=93560
rdar://problem/19991477
- platform/mac/TestExpectations: Updating expectations, as this is not limited to
Mavericks.
- 3:07 PM Changeset in webkit [180785] by
-
- 7 edits2 adds in trunk
Adding support for serializing HTMLAttachment elements.
https://bugs.webkit.org/show_bug.cgi?id=142026
Reviewed by Tim Horton.
Source/WebCore:
Test: editing/pasteboard/copy-paste-attachment.html
Adding support to serialize the attachment element
and properly handle it when converting a DOM range
to NSAttributedString.
- editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_processElement):
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendCustomAttributes): Create new attribute
for attachment element when serializating.
(WebCore::StyledMarkupAccumulator::appendElement):
(WebCore::createFragmentFromMarkup): Remove the attribute from the attachment element
when creating the fragment.
- html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::file): Added const to file() to
use it in appendCustonAttributes where the element is a const reference.
- html/HTMLAttachmentElement.h:
- html/HTMLAttributeNames.in:
LayoutTests:
- editing/pasteboard/copy-paste-attachment-expected.txt: Added.
- editing/pasteboard/copy-paste-attachment.html: Added.
- 3:00 PM Changeset in webkit [180784] by
-
- 2 edits in trunk/Source/WebCore
<attachment> should have an inactive style (gray in background)
https://bugs.webkit.org/show_bug.cgi?id=142103
<rdar://problem/19982486>
Reviewed by Dan Bernstein.
- rendering/RenderThemeMac.mm:
(WebCore::attachmentLabelInactiveBackgroundColor):
(WebCore::attachmentLabelInactiveTextColor):
(WebCore::RenderThemeMac::paintAttachmentLabelBackground):
(WebCore::RenderThemeMac::paintAttachmentLabel):
Use a gray background and gray text when the selection containing the
attachment isn't focused and active.
- 2:50 PM Changeset in webkit [180783] by
-
- 9 edits7 adds in trunk
Add a "block-cookies" rule to the user content filter.
https://bugs.webkit.org/show_bug.cgi?id=142105
Reviewed by Alex Christensen.
Source/WebCore:
Tests: http/tests/usercontentfilter/block-cookies-basic.html
http/tests/usercontentfilter/block-cookies-send.html
- contentextensions/ContentExtensionRule.h:
- contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::actionForURL):
(WebCore::ContentExtensions::ContentExtensionsBackend::shouldBlockURL): Deleted.
- contentextensions/ContentExtensionsBackend.h:
- contentextensions/ContentExtensionsManager.cpp:
(WebCore::ContentExtensions::ExtensionsManager::loadAction):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
- page/UserContentController.cpp:
(WebCore::UserContentController::actionForURL):
(WebCore::UserContentController::contentFilterBlocksURL): Deleted.
- page/UserContentController.h:
LayoutTests:
- http/tests/cookies/resources/echo-cookies.php: Added.
- http/tests/usercontentfilter/block-cookies-basic-expected.txt: Added.
- http/tests/usercontentfilter/block-cookies-basic.html: Added.
- http/tests/usercontentfilter/block-cookies-basic.html.json: Added.
- http/tests/usercontentfilter/block-cookies-send-expected.txt: Added.
- http/tests/usercontentfilter/block-cookies-send.html: Added.
- http/tests/usercontentfilter/block-cookies-send.html.json: Added.
- 2:45 PM Changeset in webkit [180782] by
-
- 2 edits in trunk/Source/WebKit2
Lookup panel dismisses when pages are loading in other tabs/windows
https://bugs.webkit.org/show_bug.cgi?id=142104
-and corresponding-
rdar://problem/19882137
Reviewed by Tim Horton.
Until rdar://problem/13875766 is resolved, we should only call into Lookup and
DataDetectors for key windows.
- UIProcess/API/mac/WKView.mm:
(-[WKView _dismissContentRelativeChildWindows]):
- 2:17 PM Changeset in webkit [180781] by
-
- 5 edits in trunk
[WinCairo] Unreviewed build fix.
Source/WebCore:
- platform/graphics/BitmapImage.h:
- platform/win/BitmapInfo.h:
Added WEBCORE_EXPORT.
Tools:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
- 1:56 PM Changeset in webkit [180780] by
-
- 6 edits in trunk/Source/WebCore
<attachment>'s label baseline should match that of the surrounding text
https://bugs.webkit.org/show_bug.cgi?id=142099
rdar://problem/19982495
Reviewed by Dan Bernstein.
- rendering/RenderAttachment.cpp:
(WebCore::RenderAttachment::baselinePosition):
- rendering/RenderAttachment.h:
Override baselinePosition and retrieve it from RenderTheme.
- rendering/RenderTheme.h:
(WebCore::RenderTheme::attachmentBaseline):
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::AttachmentLayout::AttachmentLayout):
(WebCore::RenderThemeMac::attachmentBaseline):
Plumb the label baseline from AttachmentLayout to RenderAttachment.
- 1:42 PM Changeset in webkit [180779] by
-
- 12 edits in trunk/Source/WebCore
Unreviewed, rolling out r180752.
https://bugs.webkit.org/show_bug.cgi?id=142098
Causes 10 SVG test failures on Windows. (Requested by
bfulgham_ on #webkit).
Reverted changeset:
"Cache glyph widths to GlyphPages"
https://bugs.webkit.org/show_bug.cgi?id=142028
http://trac.webkit.org/changeset/180752
- 1:40 PM Changeset in webkit [180778] by
-
- 4 edits in trunk/LayoutTests
iOS, GTK, and EFL rebaselines after r180726.
- platform/efl/editing/inserting/5058163-1-expected.txt:
- platform/gtk/editing/inserting/5058163-1-expected.txt:
- platform/ios-simulator-wk2/editing/inserting/5058163-1-expected.txt:
- 1:39 PM Changeset in webkit [180777] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Fix build by defining EAGL_IOSURFACE macro before including <OpenGLES/EAGLPrivate.h>
- platform/spi/ios/OpenGLESSPI.h: Define EAGL_IOSURFACE macro
until header refactoring is completed.
- 1:34 PM Changeset in webkit [180776] by
-
- 6 edits in trunk/LayoutTests
Unreviewed, skip tests added in r180771 on platforms that don't support IndexedDB.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/ios-simulator/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 1:27 PM Changeset in webkit [180775] by
-
- 2 edits in trunk/LayoutTests
[Win] Skip IndexDB tests on Windows since it's not implemented.
- platform/win/TestExpectations:
- 1:18 PM Changeset in webkit [180774] by
-
- 8 edits6 adds in trunk
MediaSource should be suspendable when closed
https://bugs.webkit.org/show_bug.cgi?id=142089
<rdar://problem/19923085>
Reviewed by Jer Noble.
Source/WebCore:
Make MediaSource ActiveDOMObject suspendable when it is in closed state
and it has no pending events. This increases the likelihood of pages
using MediaSource to enter the PageCache.
Tests: fast/history/page-cache-media-source-closed-2.html
fast/history/page-cache-media-source-closed.html
fast/history/page-cache-media-source-opened.html
LayoutTests:
Add layout tests to check that:
- Pages with an open MediaSource do not enter the PageCache
- Pages with an initially closed MediaSource enter the PageCache
- Pages with a MediaSource that changed state from opened to closed enter the PageCache.
- 12:14 PM Changeset in webkit [180773] by
-
- 11 edits in trunk
Add infrastructure for handling website data in the network process
https://bugs.webkit.org/show_bug.cgi?id=142092
Reviewed by Andreas Kling.
Source/WebKit2:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
Send back "Did" messages without actually doing anything for now.
- NetworkProcess/NetworkProcess.h:
Add new members.
- NetworkProcess/NetworkProcess.messages.in:
Add FetchWebsiteData and DeleteWebsiteDataForOrigins messages.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::~NetworkProcessProxy):
Assert that all maps are empty.
(WebKit::NetworkProcessProxy::fetchWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteDataForOrigins):
Add callbacks and send fetch and delete messages respectively.
(WebKit::NetworkProcessProxy::networkProcessCrashedOrFailedToLaunch):
Make sure to invoke all callbacks.
(WebKit::NetworkProcessProxy::didFetchWebsiteData):
Find the callback and invoke it.
(WebKit::NetworkProcessProxy::didDeleteWebsiteDataForOrigins):
Ditto.
- UIProcess/Network/NetworkProcessProxy.h:
Add new members.
- UIProcess/Network/NetworkProcessProxy.messages.in:
Add DidFetchWebsiteData and DidDeleteWebsiteDataForOrigins messages.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connectionDidClose):
Just pass an empty WebsiteData object.
Tools:
Add a menu item that will fetch all website data, delete the returned data records, and
fetch all website data again so we can confirm that it's all empty.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
- 11:52 AM Changeset in webkit [180772] by
-
- 18 edits in trunk/Source/WebCore
Use NeverDestroyed for JS wrapper owners.
<https://webkit.org/b/142090>
Reviewed by Chris Dumez.
Using NeverDestroyed puts these objects in BSS which is preferable
since that prevents them from pinning down entire malloc pages forever.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Use NeverDestroyed instead of DEPRECATED_DEFINE_STATIC_LOCAL.
- bindings/scripts/test/JS/*: Rebaseline bindings tests for this change.
- 11:24 AM Changeset in webkit [180771] by
-
- 7 edits4 adds in trunk
Make IDBDatabase / IDBRequest suspendable
https://bugs.webkit.org/show_bug.cgi?id=142076
<rdar://problem/19923085>
Reviewed by Andreas Kling.
Source/WebCore:
Make IDBDatabase / IDBRequest suspendable under certain conditions to
make it more likely for pages using indexeddb to enter the PageCache.
IDBDatabase is safely suspendable if the database is closed. IDBRequest
is safely suspendable if the request no longer has any pending activity
(i.e. state is DONE and success / failure handler was called). We may
be able to do better later but this is the bare minimum for now.
Tests: fast/history/page-cache-indexed-closed-db.html
fast/history/page-cache-indexed-opened-db.html
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::closeConnection):
(WebCore::IDBDatabase::enqueueEvent):
(WebCore::IDBDatabase::canSuspend):
- Modules/indexeddb/IDBDatabase.h:
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::canSuspend):
- Modules/indexeddb/IDBRequest.h:
LayoutTests:
Add layout tests to make sure that:
- A page with an open indexeddb database is not page-cacheable
- A page with a closed indexeddb database is page-cacheable
- fast/history/page-cache-indexed-closed-db-expected.txt: Added.
- fast/history/page-cache-indexed-closed-db.html: Added.
- fast/history/page-cache-indexed-opened-db-expected.txt: Added.
- fast/history/page-cache-indexed-opened-db.html: Added.
- 11:22 AM Changeset in webkit [180770] by
-
- 7 edits2 adds in trunk
Drop unnecessary DatabaseManager::hasOpenDatabases() in PageCache::canCachePageContainingThisFrame()
https://bugs.webkit.org/show_bug.cgi?id=142052
Reviewed by Andreas Kling.
Source/WebCore:
Drop WebDatabase special-handling from PageCache::canCachePageContainingThisFrame().
DatabaseContext is already an ActiveDOMObject and DatabaseContext::canSuspend() was
returning false so pages using WebDatabase would never enter the PageCache anyway.
This patch also overrides ActiveDOMObject::canSuspend() in DatabaseContext to only
return false when there are open databases. This check is now equivalent to the one
that was in PageCache.
An issue that remains is that DatabaseContext::m_hasOpenDatabases is never reset
to false so once a page opened a database, it will never be page-cacheable. This
will be taken care of separately though.
Test: fast/history/page-cache-webdatabase-opened-db.html
- Modules/webdatabase/DatabaseContext.cpp:
(WebCore::DatabaseContext::canSuspend):
- Modules/webdatabase/DatabaseContext.h:
- history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::hasOpenDatabasesKey): Deleted.
- page/DiagnosticLoggingKeys.h:
LayoutTests:
Add a layout test to check that a page with an open WebDatabase does
not enter the PageCache.
- fast/history/page-cache-webdatabase-opened-db-expected.txt: Added.
- fast/history/page-cache-webdatabase-opened-db.html: Added.
- 11:20 AM Changeset in webkit [180769] by
-
- 6 edits5 adds in trunk/Source/WebCore
Compile DFA to bytecode.
https://bugs.webkit.org/show_bug.cgi?id=142031
Reviewed by Benjamin Poulain.
- WebCore.xcodeproj/project.pbxproj:
- contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::setRuleList):
(WebCore::ContentExtensions::ContentExtensionsBackend::shouldBlockURL):
- contentextensions/ContentExtensionsBackend.h:
- contentextensions/DFA.cpp:
(WebCore::ContentExtensions::DFA::nextState): Deleted.
(WebCore::ContentExtensions::DFA::actions): Deleted.
- contentextensions/DFA.h:
(WebCore::ContentExtensions::DFA::size):
(WebCore::ContentExtensions::DFA::nodeAt):
- contentextensions/DFABytecode.h: Added.
(WebCore::ContentExtensions::instructionSizeWithArguments):
- contentextensions/DFABytecodeCompiler.cpp: Added.
(WebCore::ContentExtensions::append):
(WebCore::ContentExtensions::set32Bits):
(WebCore::ContentExtensions::DFABytecodeCompiler::emitAppendAction):
(WebCore::ContentExtensions::DFABytecodeCompiler::emitJump):
(WebCore::ContentExtensions::DFABytecodeCompiler::emitCheckValue):
(WebCore::ContentExtensions::DFABytecodeCompiler::emitTerminate):
(WebCore::ContentExtensions::DFABytecodeCompiler::reserveBufferCapacity):
(WebCore::ContentExtensions::DFABytecodeCompiler::compileNode):
(WebCore::ContentExtensions::DFABytecodeCompiler::compile):
- contentextensions/DFABytecodeCompiler.h: Added.
(WebCore::ContentExtensions::DFABytecodeCompiler::DFABytecodeCompiler):
- contentextensions/DFABytecodeInterpreter.cpp: Added.
(WebCore::ContentExtensions::getBits):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):
- contentextensions/DFABytecodeInterpreter.h: Added.
(WebCore::ContentExtensions::DFABytecodeInterpreter::DFABytecodeInterpreter):
- 10:50 AM Changeset in webkit [180768] by
-
- 10 edits in trunk/Source/WebKit2
[WK2] REGRESSION(r180465): WebKit::WebPage::editorState() triggers a layout.
https://bugs.webkit.org/show_bug.cgi?id=142015
Reviewed by Alexey Proskuryakov.
We no longer compute the font information at selection
when we update the editor state.
Instead, we request the font information only when the selection
changes and the font panel is visible.
I added an observer to be notified of the font panel visibility
changes to update NSFontManager to reflect the font at the
current selection.
- Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::decode):
- Shared/EditorState.h:
(WebKit::EditorState::EditorState):
- UIProcess/API/mac/WKView.mm:
(-[WKView updateFontPanelIfNeeded]):
(-[WKView _selectionChanged]):
(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):
(-[WKView observeValueForKeyPath:ofObject:change:context:]):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::fontAtSelection):
(WebKit::WebPageProxy::fontAtSelectionCallback):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformEditorState):
(WebKit::WebPage::fontAtSelection):
- 10:43 AM Changeset in webkit [180767] by
-
- 3 edits2 adds in trunk
Use after free in WebCore::RenderNamedFlowFragment::restoreRegionObjectsOriginalStyle
https://bugs.webkit.org/show_bug.cgi?id=138366
Reviewed by Dave Hyatt.
This patch ensures that we clean up RenderNamedFlowFragment::m_renderObjectRegionStyle when embedded flow content is getting destroyed.
In m_renderObjectRegionStyle hash map, we store style information about the named flow's descendant children.
When a child is being detached from the tree, it removes itself from this hashmap.
We do it by traversing up on the ancestor chain and call removeFlowChildInfo() on the parent flow.
However in case of embedded flows (for example multicolumn content inside a region), we need to check whether the parent flow
is inside a flow too and continue the cleanup accordingly.
Source/WebCore:
Test: fast/regions/region-with-multicolumn-embedded-crash.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::removeFromRenderFlowThreadIncludingDescendants):
LayoutTests:
- fast/regions/region-with-multicolumn-embedded-crash-expected.txt: Added.
- fast/regions/region-with-multicolumn-embedded-crash.html: Added.
- 10:33 AM Changeset in webkit [180766] by
-
- 19 edits in trunk/Source
Add API to remove a single content filter.
<rdar://problem/19977764> and https://bugs.webkit.org/show_bug.cgi?id=142088
Reviewed by Sam Weinig.
Source/WebCore:
- page/UserContentController.cpp:
(WebCore::UserContentController::removeUserContentFilter):
- page/UserContentController.h:
Source/WebKit2:
- Shared/WebPageGroupData.h:
- UIProcess/API/C/WKPageGroup.cpp:
(WKPageGroupRemoveUserContentFilter):
- UIProcess/API/C/WKPageGroup.h:
- UIProcess/API/Cocoa/WKUserContentController.mm:
(-[WKUserContentController _removeUserContentFilter:]):
- UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:
- UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::WebUserContentControllerProxy):
(WebKit::WebUserContentControllerProxy::addProcess):
(WebKit::WebUserContentControllerProxy::addUserContentFilter):
(WebKit::WebUserContentControllerProxy::removeUserContentFilter):
(WebKit::WebUserContentControllerProxy::removeAllUserContentFilters):
- UIProcess/UserContent/WebUserContentControllerProxy.h:
- UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::addUserContentFilter):
(WebKit::WebPageGroup::removeUserContentFilter):
- UIProcess/WebPageGroup.h:
- WebProcess/UserContent/WebUserContentController.cpp:
(WebKit::WebUserContentController::removeUserContentFilter):
- WebProcess/UserContent/WebUserContentController.h:
- WebProcess/UserContent/WebUserContentController.messages.in:
- WebProcess/WebPage/WebPageGroupProxy.cpp:
(WebKit::WebPageGroupProxy::WebPageGroupProxy):
(WebKit::WebPageGroupProxy::removeUserContentFilter):
- WebProcess/WebPage/WebPageGroupProxy.h:
- WebProcess/WebPage/WebPageGroupProxy.messages.in:
- 10:09 AM Changeset in webkit [180765] by
-
- 16 edits in trunk
[Win] Remove remaining SafariTheme cruft
https://bugs.webkit.org/show_bug.cgi?id=142075
Reviewed by Anders Carlsson.
Remove reference to SafariTheme-switching preference.
Source/WebCore:
Tested by existing layout tests.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- config.h:
- page/Settings.cpp:
(WebCore::Settings::fontRenderingMode):
(WebCore::Settings::setShouldPaintNativeControls): Deleted.
- page/Settings.h:
(WebCore::Settings::shouldPaintNativeControls): Deleted.
- platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarTheme::nativeTheme):
- rendering/RenderThemeWin.cpp:
(WebCore::RenderTheme::themeForPage):
Source/WebKit/win:
- Interfaces/IWebPreferencesPrivate.idl:
- WebKitClassFactory.cpp:
(WebKitClassFactory::WebKitClassFactory):
(WebKitClassFactory::QueryInterface):
(WebKitClassFactory::AddRef):
(WebKitClassFactory::Release):
(WebKitClassFactory::CreateInstance):
(WebKitClassFactory::LockServer):
- WebPreferences.cpp:
(WebPreferences::shouldPaintNativeControls): Deleted.
(WebPreferences::setShouldPaintNativeControls): Deleted.
- WebPreferences.h:
- WebView.cpp:
(WebView::initWithFrame):
(WebView::notifyPreferencesChanged):
Tools:
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
(prepareConsistentTestingEnvironment):
- 9:49 AM Changeset in webkit [180764] by
-
- 7 edits2 adds in releases/WebKitGTK/webkit-2.8
Merge r180511 - Drawing an SVG image into a canvas using drawImage() ignores globalAlpha.
https://bugs.webkit.org/show_bug.cgi?id=141729.
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-02-23
Reviewed by Simon Fraser.
Source/WebCore:
When drawing an SVG image and the drawing context is set to be transparent,
make sure this transparency is applied to the compositing layer.
Test: svg/canvas/canvas-global-alpha-svg.html
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setAlpha): Make setAlpha() calls the platform
function and sets 'm_state.alpha' to the input value.
(WebCore::GraphicsContext::alpha): Add a new function 'alpha()' which
returns the value of the global alpha.
- platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContextState::GraphicsContextState): Add a new member
'alpha' to the context state since the getter function CGContextGetAlpha
is defined only in a private header file. Also move single line functions
from the source file to the header file.
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::setPlatformAlpha):
(WebCore::GraphicsContext::setAlpha): Deleted.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setPlatformAlpha):
(WebCore::GraphicsContext::setAlpha): Deleted.
Rename setAlpha() to setPlatformAlpha() in the platform files. Add setAlpha()
to the core file. setAlpha() will set the value of 'm_state.alpha' and call
setPlatformAlpha().
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::draw): If the drawing context is transparent, apply its
global alpha value to the compositing layer.
LayoutTests:
Add a new test which draws an SVG image on a canvas after setting its
globalAlpha to a value less than 1.
- svg/canvas/canvas-global-alpha-svg-expected.html: Added.
- svg/canvas/canvas-global-alpha-svg.html: Added.
- 9:35 AM Changeset in webkit [180763] by
-
- 2 edits1 add in releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore
Merge r180505 - Crash in DFGFrozenValue
https://bugs.webkit.org/show_bug.cgi?id=141883
Reviewed by Benjamin Poulain.
If a value might be a cell, then we have to have Graph freeze it rather than trying to
create the FrozenValue directly. Creating it directly is just an optimization for when you
know for sure that it cannot be a cell.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- tests/stress/regress-141883.js: Added. Hacked the original test to be faster while still crashing before this fix.
- 9:34 AM Changeset in webkit [180762] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore
Merge r180503 - [GStreamer] Redundant track language notifications
https://bugs.webkit.org/show_bug.cgi?id=141908
Reviewed by Žan Doberšek.
Invoke languageChanged only if the language code actually
changed.
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfTagsChanged):
- 9:32 AM Changeset in webkit [180761] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8
Merge r180502 - [GTK] Fails to compile with cmake 3.2.x
https://bugs.webkit.org/show_bug.cgi?id=141796
With cmake 3.2.x we have to explicitly ask for X11 otherwise the
X11_X11_LIB variable won't be set thus the X11 linker flags won't be
added and the build will fail.
Patch by Tomas Popela <tpopela@redhat.com> on 2015-02-23
Reviewed by Martin Robinson.
- Source/cmake/OptionsGTK.cmake:
- 9:31 AM Changeset in webkit [180760] by
-
- 5 edits in releases/WebKitGTK/webkit-2.8
Merge r180492 - Print a console warning when HTMLCanvasElement exceeds the maximum size
https://bugs.webkit.org/show_bug.cgi?id=141861
<rdar://problem/19729145>
Reviewed by Simon Fraser.
Source/WebCore:
Add a warning if we ever try to create a canvas that is
too big.
No test because:
- We can't ref-test against console messages.
- The output is platform specific.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
LayoutTests:
Add error message to expected results.
- fast/canvas/canvas-toDataURL-crash-expected.txt:
- fast/canvas/pattern-too-large-to-create-expected.txt:
- 9:27 AM Changeset in webkit [180759] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.8
Merge r180464 - Invalid assert in CompositeEditCommand::insertNodeAfter/insertNodeBefore
https://bugs.webkit.org/show_bug.cgi?id=141854
Reviewed by Ryosuke Niwa.
Inserting content before/after the body as the result of editing is a valid operation.
This assert was originally introduced to cover cases where edited content would get moved
out of body. However, asserting such operation properly is not possible atm.
Source/WebCore:
Test: editing/inserting/insert-as-body-sibling.html
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::insertNodeBefore):
(WebCore::CompositeEditCommand::insertNodeAfter):
LayoutTests:
- editing/inserting/insert-as-body-sibling-expected.txt: Added.
- editing/inserting/insert-as-body-sibling.html: Added.
- 9:22 AM Changeset in webkit [180758] by
-
- 2 edits in trunk/LayoutTests
[Win] Add another batch of debug assert failures.
- platform/win/TestExpectations:
- 9:21 AM Changeset in webkit [180757] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8/Source/WTF
Merge r180434 - RunLoop::dispatch() should drop the mutex before calling wakeUp().
https://bugs.webkit.org/show_bug.cgi?id=141820
Reviewed by Alexey Proskuryakov.
RunLoop::wakeUp() calls into CoreFoundation which could take time,
so scope the mutex just to protect m_functionQueue.
- wtf/RunLoop.cpp:
(WTF::RunLoop::dispatch):
- 9:16 AM Changeset in webkit [180756] by
-
- 9 edits in releases/WebKitGTK/webkit-2.8
Merge r180423 - DFG JIT needs to check for stack overflow at the start of Program and Eval execution
https://bugs.webkit.org/show_bug.cgi?id=141676
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Added stack check to the beginning of the code the DFG copmiler emits for Program and Eval nodes.
To aid in testing the code, I replaced the EvalCodeCache::maxCacheableSourceLength const
a options in runtime/Options.h. The test script, run-jsc-stress-tests, sets that option
to a huge value when running with the "Eager" options. This allows the updated test to
reliably exercise the code in questions.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
Added stack check.
- bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::tryGet):
(JSC::EvalCodeCache::getSlow):
- runtime/Options.h:
Replaced EvalCodeCache::imaxCacheableSourceLength with Options::maximumEvalCacheableSourceLength
so that it can be configured when running the related test.
Tools:
Set the newly added --maximumEvalCacheableSourceLength option for eager test runs. This is needed
to allow the eval out of stack tests to tier up. Without this option, we don't cache the likely
large string expression that we want to eval.
- Scripts/run-jsc-stress-tests:
LayoutTests:
Updated the check for out of stack at eval entry test from using a fixed number of frame to
back track to now adjust the amount of back tracking up the stack based on where we can run a
simple eval(). At that point in the stack we try to cause an out of stack exception.
Also added a second pass of the test that takes the originally failing eval and tiers that
eval expression up to the DFG when used with the agreessive options of run-jsc-stress-tests.
This was done to reduce the amount of time the test takes to run in debug builds.
- js/regress-141098-expected.txt:
- js/script-tests/regress-141098.js:
(testEval):
(probeAndRecurse):
- 9:02 AM Changeset in webkit [180755] by
-
- 3 edits in trunk/LayoutTests
[Win] Rebaseline test after r180726.
- platform/win/TestExpectations: Mark a flaky test.
- platform/win/editing/inserting/5058163-1-expected.txt:
- 8:59 AM Changeset in webkit [180754] by
-
- 2 edits in trunk/Source/WebCore
Add comment about CSS value name mangling
Unreviewed
- css/CSSParser.cpp:
(WebCore::cssValueKeywordID):
- 8:50 AM Changeset in webkit [180753] by
-
- 12 edits in releases/WebKitGTK/webkit-2.8
Merge r180413 - Language ranges containing asterisks must be quoted as strings
https://bugs.webkit.org/show_bug.cgi?id=141659
Reviewed by Benjamin Poulain.
Source/WebCore:
As specified in [1], the language ranges containing asterisks must be quoted as strings.
[1] http://dev.w3.org/csswg/selectors-4/#the-lang-pseudo.
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::realLex):
LayoutTests:
Ensure language ranges containing asterisks are quoted as strings.
- fast/css/css-selector-text-expected.txt:
- fast/css/css-selector-text.html:
- fast/css/parsing-css-lang-expected.txt:
- fast/css/parsing-css-lang.html:
- fast/selectors/lang-extended-filtering-expected.txt:
- fast/selectors/lang-extended-filtering.html:
- fast/selectors/lang-valid-extended-filtering-expected.txt:
- fast/selectors/lang-valid-extended-filtering.html:
- 8:12 AM Changeset in webkit [180752] by
-
- 12 edits in trunk/Source/WebCore
Cache glyph widths to GlyphPages
https://bugs.webkit.org/show_bug.cgi?id=142028
Reviewed by Andreas Kling.
Currently we have a separate cache in Font for glyph widths. In practice we always need
the widths so we can just cache them in GlyphPages. This simplifies the code and removes
a per-character hash lookup from WidthIterator.
- platform/graphics/Font.cpp:
(WebCore::Font::Font):
(WebCore::Font::initCharWidths):
(WebCore::Font::platformGlyphInit):
(WebCore::createAndFillGlyphPage):
(WebCore::Font::computeWidthForGlyph):
Rename to make it clear this doesn't cache.
(WebCore::GlyphPage::setGlyphDataForIndex):
Initialize the width.
This could go to GlyphPage.cpp if we had one.
- platform/graphics/Font.h:
(WebCore::Font::glyphZeroWidth):
(WebCore::Font::isZeroWidthSpaceGlyph):
(WebCore::Font::zeroGlyph): Deleted.
(WebCore::Font::setZeroGlyph): Deleted.
(WebCore::Font::widthForGlyph): Deleted.
- platform/graphics/FontCascade.cpp:
(WebCore::offsetToMiddleOfGlyph):
- platform/graphics/FontCascadeFonts.cpp:
(WebCore::FontCascadeFonts::glyphDataForCharacter):
- platform/graphics/GlyphPage.h:
(WebCore::GlyphData::GlyphData):
Return width too as part of GlyphData.
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::setGlyphDataForCharacter):
(WebCore::GlyphPage::setGlyphDataForIndex):
(WebCore::GlyphPage::GlyphPage):
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advanceInternal):
No need to lookup width separately now.
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::advanceForGlyph):
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::missingGlyphForFont):
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::initializeFont):
- 6:57 AM Changeset in webkit [180751] by
-
- 3 edits in releases/WebKitGTK/webkit-2.8/Source/bmalloc
Merge r180430 - bmalloc should implement malloc introspection (to stop false-positive leaks when MallocStackLogging is off)
https://bugs.webkit.org/show_bug.cgi?id=141802
Reviewed by Andreas Kling.
Rolling back in with a fix for a crash seen while using GuardMalloc.
- bmalloc/VMHeap.cpp:
(bmalloc::VMHeap::grow):
- bmalloc/VMHeap.h:
- bmalloc/Zone.cpp: Re-land the old patch.
(bmalloc::Zone::size): Be sure to implement the size() function since
it's accessible indirectly via the malloc_zone_from_ptr public API --
and GuardMalloc calls it all the time.
(bmalloc::Zone::Zone):
- bmalloc/Zone.h: Re-land the old patch.
- 6:51 AM Changeset in webkit [180750] by
-
- 3 edits in releases/WebKitGTK/webkit-2.8/Source/bmalloc
Merge r180363 - bmalloc should implement malloc introspection (to stop false-positive leaks when MallocStackLogging is off)
https://bugs.webkit.org/show_bug.cgi?id=141802
Reviewed by Andreas Kling.
Fixed a last-minute type.
The macro is OS, not PLATFORM.
- bmalloc/VMHeap.cpp:
(bmalloc::VMHeap::grow):
- bmalloc/VMHeap.h:
- bmalloc/Zone.h:
- 6:48 AM Changeset in webkit [180749] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.8/Source/bmalloc
Merge r180359 - bmalloc should implement malloc introspection (to stop false-positive leaks when MallocStackLogging is off)
https://bugs.webkit.org/show_bug.cgi?id=141802
Reviewed by Andreas Kling.
This patch does the bare minimum to stop false positive leaks from
being reported by the Darwin leaks tool. We register each super chunk
as a single object, and then request that the leaks tool scan it.
- bmalloc.xcodeproj/project.pbxproj: Added an abstraction for the malloc
zone introspection API.
- bmalloc/Algorithm.h: Missing #include.
- bmalloc/VMHeap.cpp:
(bmalloc::VMHeap::grow):
- bmalloc/VMHeap.h: Adopt the new abstraction.
- bmalloc/Zone.cpp: Added.
(bmalloc::remoteRead): Helper for reading an object out of another process.
(bmalloc::Zone::enumerator):
(bmalloc::Zone::Zone): Register a malloc zone so that we will participate
in introspection.
- bmalloc/Zone.h: Added.
(bmalloc::Zone::superChunks):
(bmalloc::Zone::addSuperChunk): Use a non-dynamically-allocated vector
since our dynamic allocations will not be scanned by leaks since they
will have the malloc VM tag.
- 6:43 AM Changeset in webkit [180748] by
-
- 6 edits2 adds in releases/WebKitGTK/webkit-2.8
Merge r180337 - REGRESSION(r179347): Clearing the PageCache no longer clears the PageCache.
<https://webkit.org/b/141788>
Reviewed by Anders Carlsson.
Source/WebCore:
Once again we've fallen into the TemporaryChange trap:
TemporaryChange<unsigned>(m_member, temporaryValue);
The code above doesn't actually do anything. Since the TemporaryChange local is not named,
it immediately goes out of scope and restores the original value of m_member.
Unless someone knows a C++ trick to prevent these, we'll need to add a style checker pass
to catch bugs like this. Whatever we do will be done separately from this bug.
Test: fast/history/page-cache-clearing.html
- history/PageCache.cpp:
(WebCore::PageCache::pruneToSizeNow): Name the local so it lives longer.
- testing/Internals.cpp:
(WebCore::Internals::clearPageCache):
(WebCore::Internals::pageCacheSize):
- testing/Internals.h:
- testing/Internals.idl: Add a way to clear the page cache and query its size from
window.internals to facilitate writing a simple test for this bug.
LayoutTests:
Add a simple test that navigates to a temporary page which immediately does a history.back
navigation. Upon returning to the first page, check that the page cache now has 1 entry,
and that clearing the page cache makes that entry go away.
- fast/history/page-cache-clearing-expected.txt: Added.
- fast/history/page-cache-clearing.html: Added.
- 6:35 AM Changeset in webkit [180747] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore
Merge r180336 - Roll out r180280.
Crashes under IDBDatabase::closeConnection.
https://bugs.webkit.org/show_bug.cgi?id=141745
rdar://problem/19816412
- Modules/indexeddb/IDBDatabase.cpp: (WebCore::IDBDatabase::closeConnection):
- 6:31 AM Changeset in webkit [180746] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.8
Merge r180328 - REGRESSION(r174761) Dangling spanner pointer in RenderMultiColumnSpannerPlaceholder.
https://bugs.webkit.org/show_bug.cgi?id=138224
Reviewed by Dave Hyatt.
It's wrong to call flowThreadRelativeWillBeRemoved(child).
RenderMultiColumnFlowThread::removeFlowChildInfo() does not mean that the child is actually about to be removed.
Should this introduce any regressions, we need to deal with those separately.
Source/WebCore:
Test: fast/multicol/crash-when-spanner-gets-moved-around.html
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::removeFlowChildInfo): Deleted.
- rendering/RenderMultiColumnFlowThread.h:
LayoutTests:
- fast/multicol/crash-when-spanner-gets-moved-around-expected.txt: Added.
- fast/multicol/crash-when-spanner-gets-moved-around.html: Added.
- 6:26 AM Changeset in webkit [180745] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore
Merge r180280 - Crashes under IDBDatabase::closeConnection.
https://bugs.webkit.org/show_bug.cgi?id=141745
rdar://problem/19816412
Reviewed by David Kilzer.
- Modules/indexeddb/IDBDatabase.cpp: (WebCore::IDBDatabase::closeConnection):
Add a missing protector.
- 6:25 AM Changeset in webkit [180744] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.8
Merge r180278 - Justified ruby can cause lines to grow beyond their container
https://bugs.webkit.org/show_bug.cgi?id=141732
Reviewed by David Hyatt.
Source/WebCore:
After we re-layout RenderRubyRuns, this can change the environment upon which
ruby's overhang calculation is sensitive to. Before this patch, we would recalculate
the overhang after the RenderRubyRun gets relaid out. However, doing such causes the
effective width of the RenderRubyRun to change, which causes out subsequent
justification calculations to be off.
Therefore, we have a cycle; the amount of ruby overhang can change the justification
in a line, and the layout of the line affects the ruby overhang calculation. Instead
of performing a layout in a loop until it converges, this patch simply observes that
having a flush right edge is more valuable than having a perfectly correct overhang.
It therefore simply removes the secondary overhang calculation.
Test: fast/text/ruby-justification-flush.html
- rendering/RenderBlockFlow.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::updateRubyForJustifiedText):
(WebCore::RenderBlockFlow::computeExpansionForJustifiedText):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):
LayoutTests:
Make sure that the right edge of a justified ruby line matches up with
the same line without ruby.
- fast/text/ruby-justification-flush-expected.html: Added.
- fast/text/ruby-justification-flush.html: Added.
- 6:19 AM Changeset in webkit [180743] by
-
- 4 edits1 copy in releases/WebKitGTK/webkit-2.8/Source/bmalloc
Merge r180272 - bmalloc: VMHeap should keep a record of all of its VM ranges (for malloc introspection)
https://bugs.webkit.org/show_bug.cgi?id=141759
Reviewed by Andreas Kling.
- bmalloc.xcodeproj/project.pbxproj:
- bmalloc/SuperChunk.h: Added.
(bmalloc::SuperChunk::create):
(bmalloc::SuperChunk::SuperChunk):
(bmalloc::SuperChunk::smallChunk):
(bmalloc::SuperChunk::mediumChunk):
(bmalloc::SuperChunk::largeChunk): Factored out super chunk creation
into a separate class, for clarity and type safety.
- bmalloc/VMHeap.cpp:
(bmalloc::VMHeap::grow):
(bmalloc::VMHeap::allocateSuperChunk): Renamed "allocateSuperChunk" to
"grow" because Andreas found "allocateSuperChunk" to be unclear.
- bmalloc/VMHeap.h: Track all our VM ranges. We will use this information
for malloc introspection.
(bmalloc::VMHeap::allocateSmallPage):
(bmalloc::VMHeap::allocateMediumPage):
(bmalloc::VMHeap::allocateLargeRange): Updated for renames.
- 4:20 AM Changeset in webkit [180742] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8/Source/bmalloc
Merge r180264 - Build bmalloc through CMake as a static library. It's then linked either
into the WTF library (if built as a shared library) or into the JSC and
WebKit2 libraries. There's no need to build it as a standalone shared library.
Rubber-stamped by Carlos Garcia Campos.
- CMakeLists.txt:
- 4:16 AM Changeset in webkit [180741] by
-
- 9 edits2 adds in releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore
Merge r180258 - Fix the C-Loop LLInt build
https://bugs.webkit.org/show_bug.cgi?id=141618
Reviewed by Filip Pizlo.
I broke C-Loop when moving the common code of pow()
to JITOperations because that file is #ifdefed out
when the JITs are disabled.
It would be weird to move it back to MathObject since
the function needs to know about the calling conventions.
To avoid making a mess, I just gave the function its own file
that is used by both the runtime and the JIT.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAbstractInterpreterInlines.h:
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- runtime/MathCommon.cpp: Added.
(JSC::fdlibmScalbn):
(JSC::fdlibmPow):
(JSC::isDenormal):
(JSC::isEdgeCase):
(JSC::mathPowInternal):
(JSC::operationMathPow):
- runtime/MathCommon.h: Added.
- runtime/MathObject.cpp:
- 4:15 AM BadContent edited by
- add one more spammer (diff)
- 4:13 AM Changeset in webkit [180740] by
-
- 6 edits in releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore
Merge r180257 - Clean up OSRExit's considerAddingAsFrequentExitSite()
https://bugs.webkit.org/show_bug.cgi?id=141690
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-02-17
Reviewed by Anders Carlsson.
Looks like some code was removed from CodeBlock::tallyFrequentExitSites()
and the OSRExit were left untouched.
This patch cleans up the two loops and remove the boolean return
on considerAddingAsFrequentExitSite().
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::tallyFrequentExitSites):
- dfg/DFGOSRExit.h:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSite):
- dfg/DFGOSRExitBase.cpp:
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSiteSlow):
- dfg/DFGOSRExitBase.h:
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSite):
- ftl/FTLOSRExit.h:
(JSC::FTL::OSRExit::considerAddingAsFrequentExitSite):
- 4:09 AM Changeset in webkit [180739] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore
Merge r180248 - Unreviewed, rolling out r180184.
https://bugs.webkit.org/show_bug.cgi?id=141733
Caused infinite recursion on js/function-apply-aliased.html
(Requested by ap_ on #webkit).
Reverted changeset:
"REGRESSION(r180060): C Loop crashes"
https://bugs.webkit.org/show_bug.cgi?id=141671
http://trac.webkit.org/changeset/180184
Unreviewed, Restoring the C LOOP insta-crash fix in r180184.
Fixed a typo that only affected the C Loop in the prologue() macro in LowLevelInterpreter.asm.
After the stackHeightOKGetCodeBlock label, codeBlockSetter(t1) should be codeBlockGetter(t1).
- llint/LowLevelInterpreter.asm: Fixed a typo.
- 4:08 AM BadContent edited by
- add one more spammer (diff)
- 4:03 AM Changeset in webkit [180738] by
-
- 3 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore
Merge r180244 - Slight CachedPage class clean up
https://bugs.webkit.org/show_bug.cgi?id=141693
Reviewed by Andreas Kling.
Slight CachedPage class clean up:
- Drop unnecessary m_timeStamp data member
- Protect m_needsCaptionPreferencesChanged data member with #if ENABLE(VIDEO_TRACK)
- Merge destroy() method into the destructor as this is the only caller
- Update clear() to reset 2 data members that were missing
- 4:00 AM Changeset in webkit [180737] by
-
- 3 edits in releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore
Merge r180237 - StackLayoutPhase should use CodeBlock::usesArguments rather than FunctionExecutable::usesArguments
https://bugs.webkit.org/show_bug.cgi?id=141721
rdar://problem/17198633
Reviewed by Michael Saboff.
I've seen cases where the two are out of sync. We know we can trust the CodeBlock::usesArguments because
we use it everywhere else.
No test because I could never reproduce the crash.
- dfg/DFGGraph.h:
(JSC::DFG::Graph::usesArguments):
- dfg/DFGStackLayoutPhase.cpp:
(JSC::DFG::StackLayoutPhase::run):
- 3:57 AM Changeset in webkit [180736] by
-
- 4 edits3 adds in releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore
Merge r180234 - Throwing from an FTL call IC slow path may result in tag registers being clobbered on 64-bit CPUs
https://bugs.webkit.org/show_bug.cgi?id=141717
rdar://problem/19863382
Reviewed by Geoffrey Garen.
The best solution is to ensure that the engine catching an exception restores tag registers.
Each of these new test cases reliably crashed prior to this patch and they don't crash at all now.
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_catch):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter64.asm:
- tests/stress/throw-from-ftl-call-ic-slow-path-cells.js: Added.
- tests/stress/throw-from-ftl-call-ic-slow-path-undefined.js: Added.
- tests/stress/throw-from-ftl-call-ic-slow-path.js: Added.
- 3:54 AM Changeset in webkit [180735] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore
Merge r180232 - [ARM] Add the necessary setupArgumentsWithExecState after bug141332
https://bugs.webkit.org/show_bug.cgi?id=141714
Reviewed by Michael Saboff.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- 3:51 AM Changeset in webkit [180734] by
-
- 4 edits in releases/WebKitGTK/webkit-2.8
Merge r180649 - ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
<https://webkit.org/b/141672>
Reviewed by Alexey Proskuryakov.
ASan does not like the fact that we memcpy the stack for GC scans. So,
we're working around this by using our own memcpy (asanUnsafeMemcpy)
implementation that we can tell ASan to ignore.
Source/JavaScriptCore:
- heap/MachineStackMarker.cpp:
(JSC::asanUnsafeMemcpy):
Tools:
Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
which isn't effective for working around this issue.
- asan/webkit-asan-ignore.txt:
- 12:03 AM Changeset in webkit [180733] by
-
- 6 edits2 copies in branches/safari-600.1.4.15-branch
Merged r173806. rdar://problem/19871063
- 12:00 AM WebKitGTK/2.6.x edited by
- Readded the fonts changes with the regression fix (diff)
