Timeline
Mar 8, 2015:
- 1:47 AM Changeset in webkit [181235] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8/Tools
Merge r181075 - Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
In r180927 we updated the libsoup version used by the jhbuild. In
this new version the sniffer uses image/x-icon instead of
image/vnd.microsoft.icon for blank.ico resource.
- TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
(testWebResourceMimeType):
- 1:46 AM Changeset in webkit [181234] by
-
- 4 edits in releases/WebKitGTK/webkit-2.8
Merge r181074 - [SOUP] Check TLS errors as soon as they are set in the SoupMessage
https://bugs.webkit.org/show_bug.cgi?id=142244
Reviewed by Sergio Villar Senin.
Source/WebCore:
Connect to the notify::tls-errors signal of SoupMessage to cancel
the load earlier in case of TLS failure, preventing any private
data from being sent to the server before the TLS errors are checked.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::tlsErrorsChangedCallback):
(WebCore::gotHeadersCallback):
(WebCore::createSoupMessageForHandleAndRequest):
Tools:
Check that the SSL server doesn't process any request in case of
TLS errors when the policy is set to FAIL.
- TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
(testTLSErrorsPolicy):
(testTLSErrorsRedirect):
(testTLSErrorsHTTPAuth):
(testLoadFailedWithTLSErrors):
(testSubresourceLoadFailedWithTLSErrors):
(httpsServerCallback):
- 1:44 AM Changeset in webkit [181233] by
-
- 3 edits in releases/WebKitGTK/webkit-2.8/Source/WebKit2
Merge r181073 - [SOUP] Disable RC4
https://bugs.webkit.org/show_bug.cgi?id=140014
Patch by Michael Catanzaro <Michael Catanzaro> on 2015-03-05
Reviewed by Carlos Garcia Campos.
Disallow RC4-based ciphersuites when performing TLS negotiation,
because it is no longer considered secure.
- NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:
(main):
- WebProcess/EntryPoint/unix/WebProcessMain.cpp:
(main):
- 1:43 AM Changeset in webkit [181232] by
-
- 4 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore
Merge r181072 - TextCheckingParagraph::isEmpty() is sufficient to check whether paragraph is empty
https://bugs.webkit.org/show_bug.cgi?id=142276
Reviewed by Darin Adler.
TextCheckingParagraph::isEmpty() already calls TextCheckingParagraph::isRangeEmpty().
There is no need to call them both at the caller site.
No new tests. No behavior change.
- editing/Editor.cpp:
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
Update caller site.
- editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingParagraph::isEmpty):
Avoid using helepers here to get rid of them as they are
no longer needed outside TextCheckingParagraph.
- editing/TextCheckingHelper.h:
(WebCore::TextCheckingParagraph::isTextEmpty): Deleted.
(WebCore::TextCheckingParagraph::isRangeEmpty): Deleted.
Do not expose isTextEmpty() and isRangeEmpty().
- 1:42 AM Changeset in webkit [181231] by
-
- 5 edits in releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore
Merge r181060 - GC should compute stack bounds and dump registers at the earliest opportunity.
<https://webkit.org/b/142310>
<rdar://problem/20045624>
Reviewed by Geoffrey Garen.
Make Heap::collect() a wrapper function around a collectImpl() where the work is actually done.
The wrapper function that grabs a snapshot of the current stack boundaries and register values
on entry, and sanitizes the stack on exit.
This is a speculative fix for what appears to be overly conservative behavior in the garbage
collector following r178364 which caused a measurable regression in memory usage on Membuster.
The theory being that we were putting pointers to dead things on the stack before scanning it,
and by doing that ended up marking things that we'd otherwise discover to be garbage.
- heap/Heap.cpp:
(JSC::Heap::markRoots):
(JSC::Heap::gatherStackRoots):
(JSC::Heap::collect):
(JSC::Heap::collectImpl):
- heap/Heap.h:
- heap/MachineStackMarker.cpp:
(JSC::MachineThreads::gatherFromCurrentThread):
(JSC::MachineThreads::gatherConservativeRoots):
- heap/MachineStackMarker.h:
- 1:20 AM Changeset in webkit [181230] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore
Merge r181059 - Silence GCC's -Wstrict-prototypes
https://bugs.webkit.org/show_bug.cgi?id=142278
Patch by Debarshi Ray <debarshir@gnome.org> on 2015-03-04
Reviewed by Alexey Proskuryakov.
- API/JSContextRef.h:
- 1:17 AM Changeset in webkit [181229] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore
Merge r181038 - REGRESSION (r179597): Can't see power saver banner for plugins
https://bugs.webkit.org/show_bug.cgi?id=142312
<rdar://problem/20040517>
Reviewed by Brent Fulgham.
We were being a bit too restrictive when deciding a child
should not create a renderer. All shadow root children
of the snapshotted plugin need one.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::childShouldCreateRenderer):
Test if we're part of the shadow tree.
- 1:12 AM Changeset in webkit [181228] by
-
- 4 edits in releases/WebKitGTK/webkit-2.8
Merge r180998 - [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
https://bugs.webkit.org/show_bug.cgi?id=142225
Patch by Debarshi Ray <debarshir@gnome.org> on 2015-03-04
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewRequestFavicon):
(webkitWebViewWatchForChangesInFavicon):
(webkitWebViewDisconnectFaviconDatabaseSignalHandlers):
(webkitWebViewConstructed):
(webkitWebViewGetProperty):
(webkitWebViewDispose):
(webkitWebViewLoadChanged):
(webkitWebViewLoadFailedWithTLSErrors):
(webkit_web_view_get_context):
(webkit_web_view_download_uri):
Tools:
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
(testWebViewWebContextLifetime):
(beforeAll):
- 1:11 AM Changeset in webkit [181227] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore
Merge r180997 - [GStreamer] the GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED should be wrapped by a ifdef
https://bugs.webkit.org/show_bug.cgi?id=142274
Patch by Philippe Normand <pnormand@igalia.com> on 2015-03-04
Reviewed by Carlos Garcia Campos.
Don't handle scheduling queries if building against versions of
GStreamer older than 1.2.0.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcQueryWithParent):
- 1:06 AM Changeset in webkit [181226] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.8
Merge r181168 - Setting any of the <object> element plugin controlling attributes does not have any affect.
https://bugs.webkit.org/show_bug.cgi?id=141936.
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-03-06
Reviewed by Simon Fraser.
Source/WebCore:
When setting any of the <object> element plugin controlling attributes
dynamically we need to mark the the element to be dirty by calling
setNeedsStyleRecalc(), so it has to recreate its renderer when needed.
Tests: fast/css/image-object-hover-inherit.html
svg/as-object/svg-in-object-dynamic-attribute-change.html
- dom/Element.h: Delete unimplemented function.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseAttribute): Mark the element dirty by
calling setNeedsStyleRecalc() when one of the plugin controlling attributes
gets changed. We have to clear m_useFallbackContent because the attribute's
new value might fix the object rendering.
- html/HTMLObjectElement.h: Add a function to clear m_useFallbackContent.
LayoutTests:
- fast/css/image-object-hover-inherit-expected.html: Added.
- fast/css/image-object-hover-inherit.html: Added.
A guarding test to catch the case of reconstructing the image <object>
renderer while performing a synchronous resolveTree() followed by page
rendering or dump render tree.
- svg/as-object/resources/lime100x100.html: Added.
- svg/as-object/resources/lime100x100.png: Added.
- svg/as-object/resources/lime100x100.svg: Added.
- svg/as-object/resources/red100x100.svg: Added.
- svg/as-object/svg-in-object-dynamic-attribute-change-expected.html: Added.
- svg/as-object/svg-in-object-dynamic-attribute-change.html: Added.
Ensure that changing the 'type' and the 'data' attributes of the <object>
element will have the expected outcome. Also make sure that the <object>
element renderer falls back correctly when setting any of the attributes
to some unexpected value.
- 12:49 AM Changeset in webkit [181225] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8/Source/bmalloc
Merge r180964 - bmalloc: Don't branch when setting the owner of a large object
https://bugs.webkit.org/show_bug.cgi?id=142241
Reviewed by Andreas Kling.
- bmalloc/BoundaryTag.h:
(bmalloc::BoundaryTag::owner):
(bmalloc::BoundaryTag::setOwner):
- 12:47 AM Changeset in webkit [181224] by
-
- 6 edits in releases/WebKitGTK/webkit-2.8/Source/bmalloc
Merge r180953 - bmalloc: Miscellaneous cleanup
https://bugs.webkit.org/show_bug.cgi?id=142231
Reviewed by Andreas Kling.
No performance change -- maybe a tiny reduction in memory use.
- bmalloc/Heap.cpp: Moved the sleep function into StaticMutex, since
it's a helper for working with mutexes.
(bmalloc::Heap::scavenge): Make sure to wait before we start any
scavenging, since individual scavenging functions now always scavenge
at least one page before waiting themselves.
(bmalloc::Heap::scavengeSmallPages):
(bmalloc::Heap::scavengeMediumPages):
(bmalloc::Heap::scavengeLargeObjects): Use the new wait helper to
simplify this code. Also, we now require our caller to wait until at
least one deallocation is desirable. This simplifies our loop.
(bmalloc::Heap::allocateSmallPage):
(bmalloc::Heap::allocateMediumPage):
(bmalloc::Heap::allocateXLarge):
(bmalloc::Heap::allocateLarge): Don't freak out any time the heap does
an allocation. Only consider the heap to be growing if it actually needs
to allocate new VM. This allows us to shrink the heap back down from a
high water mark more reliably even if heap activity continues.
(bmalloc::sleep): Deleted.
(bmalloc::Heap::scavengeLargeRanges): Renamed to match our use of
"LargeObject".
- bmalloc/Heap.h:
- bmalloc/LargeObject.h:
(bmalloc::LargeObject::operator bool): Added to simplify a while loop.
- bmalloc/StaticMutex.h:
(bmalloc::sleep):
(bmalloc::waitUntilFalse): New helper for waiting until a condition
becomes reliably false.
- bmalloc/Vector.h:
(bmalloc::Vector<T>::~Vector): Oops! Don't deallocate the null pointer.
We don't actually run any Vector destructors, but an iteration of this
patch did, and then crashed. So, let's fix that.
- 12:20 AM Changeset in webkit [181223] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore
Merge r180938 - [Win64] JSC compile error.
https://bugs.webkit.org/show_bug.cgi?id=142216
Patch by peavo@outlook.com <peavo@outlook.com> on 2015-03-03
Reviewed by Mark Lam.
There is missing a version of setupArgumentsWithExecState when NUMBER_OF_ARGUMENT_REGISTERS == 4.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- 12:10 AM Changeset in webkit [181222] by
-
- 7 edits in trunk
Remove willDestroyFrame in WKBundlePageLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=142389
Reviewed by Anders Carlsson.
Source/WebKit2:
I added willDestroyFrame in r154540 but I realized recently that
it has never actually worked. Adding the callback to
WKBundlePageLoaderClient was the first mistake, since frames are
handled by WebProcess and DidDestroyFrame message is indeed a
WebProcessProxy not a WebPageProxy one. Second mistake was calling
the callback from WebFrameLoaderClient::frameLoaderDestroyed(),
since at that point the frame has already been detached from the
page and so WebFrame::page() always returns nullptr. So, this in
fact dead code and since r180211 nobody is using it.
- WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h:
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkitWebPageCreate): Use verion 6 instead of version 7 of loader client.
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::willDestroyFrame): Deleted.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::frameLoaderDestroyed):
Tools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
Mar 7, 2015:
- 10:32 PM Changeset in webkit [181260] by
-
- 16 edits in trunk/LayoutTests
Last test gardening after r177774 (for reals this time)
https://bugs.webkit.org/show_bug.cgi?id=139968
Unreviewed.
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2015-03-08
- platform/mac/TestExpectations:
- platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
- platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
- platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
- platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
- platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
- platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
- platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
- svg/text/select-textLength-spacingAndGlyphs-squeeze-1.svg:
- svg/text/select-textLength-spacingAndGlyphs-squeeze-2.svg:
- svg/text/select-textLength-spacingAndGlyphs-squeeze-3.svg:
- svg/text/select-textLength-spacingAndGlyphs-squeeze-4.svg:
- svg/text/select-textLength-spacingAndGlyphs-stretch-1.svg:
- svg/text/select-textLength-spacingAndGlyphs-stretch-2.svg:
- svg/text/select-textLength-spacingAndGlyphs-stretch-3.svg:
- 9:55 PM Changeset in webkit [181259] by
-
- 12 edits in trunk/Source
[iOS Media] Video buffer progress missing on iPhones
https://bugs.webkit.org/show_bug.cgi?id=142462
Reviewed by Eric Carlson.
Source/WebCore:
The fullscreen controller on the iPhone idiom was using
the media duration as its maximum loaded time, meaning the
download progress was missing (it looked like everything
was already downloaded). The fix is to calculate
what the maximum buffered time is from the HTMLMediaElement,
and send that to the fullscreen controller.
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.drawTimelineBackground): While implementing
the native function I noticed that the JS controls forgot that
the buffered time ranges are ordered, and thus they don't need
to search through the array. The last range will be the highest.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::maxBufferedTime): New helper function
to calculate the highest buffered time in the media source.
- html/HTMLMediaElement.h:
- platform/ios/WebVideoFullscreenInterface.h: New setBufferedTime method.
- platform/ios/WebVideoFullscreenInterfaceAVKit.h:
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::setDuration): No longer set
the loadedTimeRanges.
(WebVideoFullscreenInterfaceAVKit::setBufferedTime): Calculate a normalized
value of the maximum loaded/buffered time, and tell the platform controller
to show that range.
- platform/ios/WebVideoFullscreenModelVideoElement.mm:
(WebVideoFullscreenModelVideoElement::updateForEventName): Send the maximum
buffered time.
Source/WebKit2:
Coordinate the SetBufferedTime message between the Web and UI
processes.
- UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in: New message SetBufferedTime.
- WebProcess/ios/WebVideoFullscreenManager.h:
- WebProcess/ios/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::setBufferedTime):
- 9:25 PM Changeset in webkit [181258] by
-
- 3 edits in trunk/LayoutTests
Fix the tests for the new double-child descendant in css-set-selector-text
https://bugs.webkit.org/show_bug.cgi?id=141882
Reviewed by Andreas Kling.
In 178592, I copied the rules from css-selector-text.html without removing
the declarations.
Kudos to Dhi Aurrahman for catching this.
- fast/css/css-set-selector-text-expected.txt:
- fast/css/css-set-selector-text.html:
- 9:15 PM Changeset in webkit [181257] by
-
- 4 edits in trunk
[Win] WTF::WorkQueue does not balance ref/deref properly
https://bugs.webkit.org/show_bug.cgi?id=142471
Reviewed by Antti Koivisto.
Source/WTF:
Make sure we deref the count when we execute a function in the
WorkQueue.
- wtf/win/WorkQueueWin.cpp:
(WTF::WorkQueue::performWorkOnRegisteredWorkThread):
Tools:
- TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
(TestWebKitAPI::TEST): Check that the refcount is correct.
- 7:55 PM Changeset in webkit [181256] by
-
- 2 edits in trunk/Source/WebCore
Crash in WebCore::NotificationCenter::stop()
https://bugs.webkit.org/show_bug.cgi?id=142444
<rdar://problem/20082520>
Reviewed by Darin Adler.
Rework the patch in r181219 so that we do not need a Ref<NotificationCenter> protector
in NotificationCenter::stop(). Instead, we put the client in a local variable and null
out m_client *before* calling NotificationClient::clearNotifications().
No new tests, already covered by:
http/tests/notifications/event-listener-crash.html
- Modules/notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::stop):
- 7:07 PM Changeset in webkit [181255] by
-
- 2 edits in trunk/Tools
Do not show passing test result on output of EFL layout test
https://bugs.webkit.org/show_bug.cgi?id=142380
Reviewed by Darin Adler.
To show passing tests has caused inconvenience when we detect problem tests
in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
in order not to show passing tests in the output of EFL layout test.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitTests.start):
- 6:58 PM Changeset in webkit [181254] by
-
- 2 edits in trunk/Tools
Unreviewed build fix.
- TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
(TestWebKitAPI::TEST): Remove two unused variables.
- 6:44 PM Changeset in webkit [181253] by
-
- 2 edits in trunk/LayoutTests
Change bug number for svg/custom/svg-fonts-without-missing-glyph.xhtml
Unreviewed.
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2015-03-08
- platform/mac/TestExpectations:
- 6:30 PM Changeset in webkit [181252] by
-
- 7 edits7 adds in trunk/Source/WebKit2
[Content Extensions] Add scaffolding for the WKUserContentExtensionStore
https://bugs.webkit.org/show_bug.cgi?id=142464
Reviewed by Dan Bernstein.
- Shared/API/APIObject.h:
Add a UserContentExtensionStore type and move the UserContentExtension type into the correct section (UIProcess).
- Shared/API/c/WKBase.h:
Add the WKUserContentExtensionStoreRef C-SPI type.
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
Add allocation support for UserContentExtensionStore (and UserContentExtension while we are there, it will be
needed shortly).
- UIProcess/API/APIUserContentExtensionStore.cpp: Added.
(API::UserContentExtensionStore::UserContentExtensionStore):
(API::UserContentExtensionStore::~UserContentExtensionStore):
- UIProcess/API/APIUserContentExtensionStore.h: Added.
Stub out the UserContentExtensionStore.
- UIProcess/API/C/WKAPICast.h:
Add casting for the UserContentExtensionStore.
- UIProcess/API/C/WKUserContentExtensionStoreRef.cpp: Added.
(WKUserContentExtensionStoreGetTypeID):
- UIProcess/API/C/WKUserContentExtensionStoreRef.h: Added.
- UIProcess/API/Cocoa/_WKUserContentExtensionStore.h: Added.
- UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm: Added.
(-[_WKUserContentExtensionStore init]):
(-[_WKUserContentExtensionStore dealloc]):
(-[_WKUserContentExtensionStore _apiObject]):
- UIProcess/API/Cocoa/_WKUserContentExtensionStoreInternal.h: Added.
(WebKit::wrapper):
Stub out SPI for the UserContentExtensionStore.
- WebKit2.xcodeproj/project.pbxproj:
- CMakeLists.txt:
Add new files.
- 6:17 PM Changeset in webkit [181251] by
-
- 5 edits in trunk/Source/WebKit2
AX: Expose a frame's accessible name through WK2 C SPI
<rdar://problem/19653068>
https://bugs.webkit.org/show_bug.cgi?id=142468
Reviewed by Dan Bernstein.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameSetAccessibleName):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::setAccessibleName):
- WebProcess/WebPage/WebFrame.h:
Add SPI to set a frame's accessible name. This matches the Legacy WebKit SPI -[WebFrame setAccessibleName:].
- 4:58 PM Changeset in webkit [181250] by
-
- 3 edits in trunk/Source/JavaScriptCore
JITThunks keeps finalized Weaks around, pinning WeakBlocks.
<https://webkit.org/b/142454>
Reviewed by Darin Adler.
Make JITThunks a WeakHandleOwner so it can keep its host function map free of stale entries.
This fixes an issue I was seeing where a bunch of WeakBlocks stuck around with nothing but
finalized Weak<NativeExecutable> entries.
- jit/JITThunks.h:
- jit/JITThunks.cpp:
(JSC::JITThunks::finalize): Make JITThunks inherit from WeakHandleOwner so it can receive
a callback when the NativeExecutables get garbage collected.
(JSC::JITThunks::hostFunctionStub): Pass 'this' as the handle owner when creating Weaks.
- 4:55 PM Changeset in webkit [181249] by
-
- 4 edits1 add in trunk/Tools
Add some WorkQueue tests to TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=142447
Reviewed by Sam Weinig.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
(TestWebKitAPI::simpleTest):
(TestWebKitAPI::longTest):
(TestWebKitAPI::thirdTest):
(TestWebKitAPI::finishedTests):
(TestWebKitAPI::TEST):
(TestWebKitAPI::longTest2):
- 4:47 PM Changeset in webkit [181248] by
-
- 3 edits in trunk/Source/JavaScriptCore
BuiltinExecutables keeps finalized Weaks around, pinning WeakBlocks.
<https://webkit.org/b/142460>
Reviewed by Geoffrey Garen.
Make BuiltinExecutables a WeakHandleOwner so it can clear out its respective Weak members
if and when their pointees get garbage collected.
This fixes an issue I've seen locally where a WeakBlock is pinned down by a single one of
these Weak<BuiltinExecutables>.
- builtins/BuiltinExecutables.h: Make BuiltinExecutables inherit from WeakHandleOwner.
- builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::finalize): Clear out the relevant member pointer when it's been
garbage collected. We use the WeakImpl's "context" field to pass the address of the member.
- 4:39 PM Changeset in webkit [181247] by
-
- 3 edits in trunk/Source/WebCore
Don't call RenderLayerCompositor::needsToBeComposited() so many times
https://bugs.webkit.org/show_bug.cgi?id=142441
Reviewed by Brent Fulgham.
Save one call to needsToBeComposited() per RenderLayer while rebuilding compositing
layers, and a call to isRunningAcceleratedTransformAnimation() in some cases.
computeCompositingRequirements() already knows if the layer will be composited, so
pass that to updateBacking() in the form of a "yes/no/don't" know enum. However,
since updateBacking() no longer calls needsToBeComposited(), we need to call
requiresCompositingForPosition() to get the viewportConstrainedNotCompositedReason flags.
isRunningAcceleratedTransformAnimation() will only be true for a layer which has a
direct compositing reason, so only call isRunningAcceleratedTransformAnimation()
in that case.
- rendering/RenderLayerCompositor.cpp:
(WebCore::rendererForCompositingTests):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::requiresCompositingLayer): Use references.
(WebCore::RenderLayerCompositor::reasonsForCompositing): Use references.
- rendering/RenderLayerCompositor.h:
- 2:32 PM Changeset in webkit [181246] by
-
- 9 edits in trunk/Source/WebKit2
[Content Extensions] Pass compiled content extensions as read-only shared memory rather than copying them
https://bugs.webkit.org/show_bug.cgi?id=142458
Reviewed by Dan Bernstein.
- Shared/WebCompiledContentExtensionData.cpp:
(WebKit::WebCompiledContentExtensionData::encode):
(WebKit::WebCompiledContentExtensionData::decode):
- Shared/WebCompiledContentExtensionData.h:
(WebKit::WebCompiledContentExtensionData::WebCompiledContentExtensionData):
Store the compiled data as a SharedMemory block with offset/size pairs for the
bytecode and actions. While the bytecode offset is currently always 0, this won't
be the case when we map these in from files due to metadata that will be placed
at the top of the files.
- Shared/WebCompiledContentExtension.h:
- Shared/WebCompiledContentExtension.cpp:
(WebKit::WebCompiledContentExtension::createFromCompiledContentExtensionData):
Temporary creation helper. In subsequent patches, this will be removed and replaced
by always passing in shared/mapped data.
(WebKit::WebCompiledContentExtension::create):
(WebKit::WebCompiledContentExtension::WebCompiledContentExtension):
(WebKit::WebCompiledContentExtension::bytecode):
(WebKit::WebCompiledContentExtension::bytecodeLength):
(WebKit::WebCompiledContentExtension::actions):
(WebKit::WebCompiledContentExtension::actionsLength):
Convert to work with the new WebCompiledContentExtension format.
- UIProcess/API/C/WKUserContentFilterRef.cpp:
(WKUserContentFilterCreate):
- UIProcess/API/Cocoa/_WKUserContentFilter.mm:
(-[_WKUserContentFilter initWithName:serializedRules:]):
Switch to using WebCompiledContentExtension::createFromCompiledContentExtensionData().
- WebProcess/UserContent/WebUserContentController.cpp:
(WebKit::WebUserContentController::addUserContentExtensions):
- WebProcess/WebPage/WebPageGroupProxy.cpp:
(WebKit::WebPageGroupProxy::addUserContentExtension):
Update to pass the WebCompiledContentExtensionData directly to the WebCompiledContentExtension.
- 10:02 AM Changeset in webkit [181245] by
-
- 3 edits in trunk/Source/WebCore
In RenderLayerCompositor, track layer bounds and the haveComputedBounds flag together in a struct
https://bugs.webkit.org/show_bug.cgi?id=142449
Reviewed by Brent Fulgham.
Rather than tracking 'layerBounds' and 'haveComputedBounds' separately, group them together
in an OverlapExtent struct and add a function to compute the bounds, which removes
a copy of this code. OverlapExtent will be extended in a future patch.
No behavior change.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::OverlapMap::geometryMap): Allow const access to
the geometryMap, used by computeExtent().
(WebCore::RenderLayerCompositor::computeExtent):
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
- rendering/RenderLayerCompositor.h:
- 3:50 AM Changeset in webkit [181244] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore
Merge r181219 - Crash in WebCore::NotificationCenter::stop()
https://bugs.webkit.org/show_bug.cgi?id=142444
<rdar://problem/20082520>
Reviewed by Andreas Kling.
A use-after-free would sometimes cause us to crash in NotificationCenter::stop().
After investigation, it turns out that NotificationCenter::stop() calls
NotificationClient::clearNotifications() which will destroy the Notification
objects, all of which hold a strong reference to the NotificationCenter. If at
this point, only Notifications are ref'ing the NotificationCenter, this means
that the NotificationCenter will get destroyed right after the call to
NotificationClient::clearNotifications(). However, we reset m_client to null
after calling clearNotifications() and it causes us to crash in this case.
The issue is addressed by adding a Ref<NotificationCenter> protector in
NotificationCenter::stop() so that we make sure the NotificationCenter lives
at least until the end of the method execution.
I was able to consistently reproduce the crash by doing:
Tools/Scripts/run-webkit-tests -1 --debug --repeat-each=30 -g http/tests/notifications/event-listener-crash.html
No new tests, already covered by:
http/tests/notifications/event-listener-crash.html
- Modules/notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::stop):
- 3:49 AM Changeset in webkit [181243] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.8
Merge r181194 - Setting scroll-snap-desination to (100% 100%) locks up WebKit
https://bugs.webkit.org/show_bug.cgi?id=142414
<rdar://problem/20077275>
Reviewed by Dean Jackson.
Source/WebCore:
Tested by css3/scroll-snap/scroll-snap-desination-lock-up.html.
Correct an infinite loop that is triggered when you combine a repeating (100%)
scroll-snap-point-{x,y} along with a 100% scroll-snap-destination value.
- page/scrolling/AxisScrollSnapOffsets.cpp:
(WebCore::updateFromStyle): Make sure we break out of the loop properly when
the scroll-snap-point-{x,y} step is the same as the scroll-snap-destination.
LayoutTests:
- css3/scroll-snap/scroll-snap-desination-lock-up.html: Added.
- css3/scroll-snap/scroll-snap-desination-lock-up-expected.txt: Added.
- 3:27 AM Changeset in webkit [181242] by
-
- 11 edits5 adds5 deletes in trunk/LayoutTests
[iOS] Gardening to skip new tests, rebaseline existing tests
- platform/ios-simulator-wk1/TestExpectations:
- Mark test as flakey.
- platform/ios-simulator-wk2/fast/css/text-overflow-input-expected.txt: Remove.
- platform/ios-simulator-wk2/fast/forms/input-disabled-color-expected.txt: Remove.
- platform/ios-simulator-wk2/fast/forms/input-text-word-wrap-expected.txt: Remove.
- platform/ios-simulator-wk2/fast/forms/minWidthPercent-expected.txt: Remove.
- Superceded by new platform/ios-simulator results.
- platform/ios-simulator/TestExpectations:
- Skip two tests that will always time out on iOS.
- Mark two tests as ImageOnlyFailure that fail consistently.
- platform/ios-simulator/compositing/media-controls-bar-appearance-expected.txt: Add.
- Add result for new test from r180965.
- platform/ios-simulator/fast/attachment/attachment-label-highlight-expected.txt: Add.
- platform/ios-simulator/fast/attachment/attachment-progress-expected.txt: Add.
- platform/ios-simulator/fast/attachment/attachment-subtitle-expected.txt: Add.
- platform/ios-simulator/fast/attachment/attachment-title-expected.txt: Add.
- Add results for new attachment tests.
- platform/ios-simulator/fast/css/text-overflow-input-expected.txt: Update.
- platform/ios-simulator/fast/forms/input-disabled-color-expected.txt: Update.
- platform/ios-simulator/fast/forms/input-text-scroll-left-on-blur-expected.txt: Update.
- platform/ios-simulator/fast/forms/input-text-word-wrap-expected.txt: Update.
- platform/ios-simulator/fast/forms/minWidthPercent-expected.txt: Update.
- platform/ios-simulator/tables/mozilla/bugs/bug59354-expected.txt: Update.
- platform/ios-simulator/tables/mozilla/bugs/bug96334-expected.txt: Update.
- platform/ios-simulator/tables/mozilla/other/move_row-expected.txt: Update.
- Rebaseline after other bug fixes like r180815.
- 3:19 AM Changeset in webkit [181241] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8/Tools
Merge r181159 - [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
https://bugs.webkit.org/show_bug.cgi?id=142385
Reviewed by Sergio Villar Senin.
Use stack allocated GMainLoopSources to make sure they are
cancelled automatically if the test finishes before they have
been processed.
- TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
(testWebViewSyncRequestOnMaxConns):
- 3:18 AM Changeset in webkit [181240] by
-
- 3 edits in releases/WebKitGTK/webkit-2.8/Source/WebKit2
Merge r181138 - REGRESSION(r180924): ASSERTION FAILED: !from.isEmpty() in WebCore::TransformationMatrix::rectToRect
https://bugs.webkit.org/show_bug.cgi?id=142345
Reviewed by Martin Robinson.
This was caused by r180924 that postpones the creation of the
TextureMapper, which could cause that a layer has not yet a size
when TextureMapper::paint() is called. This patch moves the
creation of the TextureMapper to
LayerTreeHostGtk::setNativeSurfaceHandleForCompositing(), so that
it's created as soon as it's possible to create. This method is
called by the drawing area right after creating the
LayerTreeHostGtk if it already have a handler, or when the handle
is received from the UI process.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::initialize): Remove the
nsureTextureMapper call because at this point the layer context ID
is always 0, so it's impossible to create the TextureMapper.
(WebKit::LayerTreeHostGtk::compositeLayersToContext): Remove the
ensureTextureMapper call from here too, since at this point, if we
have a context, we should also have a TextureMapper. Add an ASSERT
right before using the TextureMapper.
(WebKit::LayerTreeHostGtk::setNativeSurfaceHandleForCompositing):
Create the TextureMapper here.
(WebKit::LayerTreeHostGtk::ensureTextureMapper): Deleted.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
- 3:15 AM Changeset in webkit [181239] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore
Merge r181133 - Document::recalcStyle() shouldn't call viewportContentsChanged() if there is a pending layout
https://bugs.webkit.org/show_bug.cgi?id=142140
Reviewed by Darin Adler.
Stop calling FrameView::viewportContentsChanged() in Document::recalcStyle()
if there is a layout pending to avoid doing unncessary work. If there is a
layout pending, we don't need to do anything because viewportContentsChanged()
will be called after layout.
We only need to call FrameView::viewportContentsChanged() in
Document::recalcStyle() if a style recalc does not cause a layout. For e.g.
a '-webkit-transform' could make an animated GIF visible without causing a
layout, in which case we need to resume the animated GIF after style recalc.
No new tests, already covered by:
fast/images/animated-gif-webkit-transform.html
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
- 3:13 AM Changeset in webkit [181238] by
-
- 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore
Merge r181111 - Unreviewed, rolling out r180846.
https://bugs.webkit.org/show_bug.cgi?id=142368
Caused missing image banners in iTunes store pages (Requested
by smfr on #webkit).
Reverted changeset:
"FrameView::layoutTimerFired() should update style if needed
before doing layout"
https://bugs.webkit.org/show_bug.cgi?id=141688
http://trac.webkit.org/changeset/180846
- 3:12 AM Changeset in webkit [181237] by
-
- 3 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore
Merge r181110 - Fix the build when NEON_INTRINSICS is enabled
https://bugs.webkit.org/show_bug.cgi?id=142361
Patch by Sandy Perez <sperez@indaba.es> on 2015-03-05
Reviewed by Csaba Osztrogonác.
- platform/graphics/cpu/arm/filters/FEBlendNEON.h:
(WebCore::FEBlend::platformApplySoftware):
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::standardBoxBlur):
- 3:11 AM Changeset in webkit [181236] by
-
- 11 edits in releases/WebKitGTK/webkit-2.8
Merge r181105 - Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
https://bugs.webkit.org/show_bug.cgi?id=142350
Patch by Chris Dumez <Chris Dumez> on 2015-03-05
Reviewed by Michael Saboff and Benjamin Poulain.
Source/JavaScriptCore:
Call WTFString::hasInfixStartingAt() / hasInfixEndingAt() now that these
methods have been renamed for clarity.
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncStartsWith):
(JSC::stringProtoFuncEndsWith):
Source/WTF:
Fix ASSERTION FAILED: !is8Bit() in StringImpl::characters16() from
WTF::equalInner() after r173761. The code was incorrectly assuming that
if stringImpl is 16-bit, then matchString is 16-bit too, which is not
correct.
Also rename WTFString::startsWith() / endsWith() taking an offset to
hasInfixStartingAt() / hasInfixEndingAt() for clarity. It seems odd
to call it startsWith even though it won't technically *start* with
the pattern if the input offset is greater than zero.
Also drop the caseSensitive argument as it is never used (always true
at call sites.
- wtf/text/StringImpl.cpp:
(WTF::equalInner):
(WTF::StringImpl::hasInfixStartingAt):
(WTF::StringImpl::hasInfixEndingAt):
(WTF::StringImpl::startsWith): Deleted.
(WTF::StringImpl::endsWith): Deleted.
- wtf/text/StringImpl.h:
- wtf/text/WTFString.h:
(WTF::String::hasInfixStartingAt):
(WTF::String::hasInfixEndingAt):
(WTF::String::startsWith): Deleted.
(WTF::String::endsWith): Deleted.
Tools:
Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
- TestWebKitAPI/Tests/WTF/WTFString.cpp:
(TestWebKitAPI::TEST):
LayoutTests:
Update String.startsWith() / endsWith() test to cover cases where the
input string is 8-bit and the pattern is 16-bit, and vice-versa.
- js/script-tests/string-includes.js:
- js/string-includes-expected.txt:
Mar 7, 2015:
- 10:51 PM Changeset in webkit [181221] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening on 8th Mar.
Mark emphasis text test, writing mode test, whitespace test to failure.
Besides update new failure tests to existing bugs.
- platform/efl/TestExpectations:
- 8:57 PM Changeset in webkit [181220] by
-
- 4 edits3 adds in trunk/Source/WTF
[Win] Revive WTF::WorkQueue on Windows
https://bugs.webkit.org/show_bug.cgi?id=142432
Reviewed by Darin Adler.
Revive the Windows implementation of WTF::WorkQueue.
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- wtf/WorkQueue.h:
- wtf/win/WorkItemWin.cpp: Added.
- wtf/win/WorkItemWin.h: Added.
- wtf/win/WorkQueueWin.cpp: Added.
- 7:37 PM Changeset in webkit [181219] by
-
- 2 edits in trunk/Source/WebCore
Crash in WebCore::NotificationCenter::stop()
https://bugs.webkit.org/show_bug.cgi?id=142444
<rdar://problem/20082520>
Reviewed by Andreas Kling.
A use-after-free would sometimes cause us to crash in NotificationCenter::stop().
After investigation, it turns out that NotificationCenter::stop() calls
NotificationClient::clearNotifications() which will destroy the Notification
objects, all of which hold a strong reference to the NotificationCenter. If at
this point, only Notifications are ref'ing the NotificationCenter, this means
that the NotificationCenter will get destroyed right after the call to
NotificationClient::clearNotifications(). However, we reset m_client to null
after calling clearNotifications() and it causes us to crash in this case.
The issue is addressed by adding a Ref<NotificationCenter> protector in
NotificationCenter::stop() so that we make sure the NotificationCenter lives
at least until the end of the method execution.
I was able to consistently reproduce the crash by doing:
Tools/Scripts/run-webkit-tests -1 --debug --repeat-each=30 -g http/tests/notifications/event-listener-crash.html
No new tests, already covered by:
http/tests/notifications/event-listener-crash.html
- Modules/notifications/NotificationCenter.cpp:
(WebCore::NotificationCenter::stop):
- 6:49 PM Changeset in webkit [181218] by
-
- 3 edits in trunk/Source/WebCore
Tidy up RenderLayerCompositor's CompositingState
https://bugs.webkit.org/show_bug.cgi?id=142445
Reviewed by Dan Bernstein.
Make CompositingState a private struct in RenderLayerCompositor.
Since it's a struct, remove the m_ prefix from its data members.
No behavior change.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::CompositingState::CompositingState):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::CompositingState::CompositingState): Deleted.
- rendering/RenderLayerCompositor.h:
- 6:14 PM Changeset in webkit [181217] by
-
- 1 edit2 moves1 delete in trunk/LayoutTests
Improve the event handler test
https://bugs.webkit.org/show_bug.cgi?id=142439
Reviewed by Ryosuke Niwa.
- fast/dom/event-handler-attributes-expected.txt: Renamed from legacy-event-handler-attributes-expected.txt.
Also updated to reflect changes in the test.
- fast/dom/event-handler-attributes.html: Renamed from legacy-event-handler-attributes.html.
Fixed bug in the test that was making document event handler tests falsely report failure.
Removed testing of some HTMLMediaElement attributes that are conditionally present; this test
is intended to test only unconditionally available event handler attributes at this time.
- platform/win/fast/dom/legacy-event-handler-attributes-expected.txt: Removed. The conditional HTMLMediaElement
attributes are the reason the Windows-specific results were needed.
- 5:37 PM Changeset in webkit [181216] by
-
- 4 edits in trunk/Source/WebCore
Unindent EventTarget, EventListener, JSEventLister.h files
https://bugs.webkit.org/show_bug.cgi?id=142440
Reviewed by Alexey Proskuryakov.
- bindings/js/JSEventListener.h:
- dom/EventListener.h:
- dom/EventTarget.h:
Change indentation to match coding style rules.
- 4:23 PM Changeset in webkit [181215] by
-
- 17 edits5 deletes in trunk/Source
Use FastMalloc (bmalloc) instead of BlockAllocator for GC pages
https://bugs.webkit.org/show_bug.cgi?id=140900
Reviewed by Mark Hahnenberg.
Re-landing just the removal of BlockAllocator, which is now unused.
Source/JavaScriptCore:
- API/JSBase.cpp:
- CMakeLists.txt:
- JavaScriptCore.order:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/BlockAllocator.cpp: Removed.
- heap/BlockAllocator.h: Removed.
- heap/GCThreadSharedData.h:
- heap/HandleBlockInlines.h:
- heap/Heap.cpp:
(JSC::Heap::Heap):
- heap/Heap.h:
- heap/HeapInlines.h:
(JSC::Heap::blockAllocator): Deleted.
- heap/HeapTimer.cpp:
- heap/MarkedBlock.h:
- heap/MarkedSpace.h:
- heap/Region.h: Removed.
- heap/SuperRegion.cpp: Removed.
- heap/SuperRegion.h: Removed.
Source/WebCore:
- platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::install):
- 2:20 PM Changeset in webkit [181214] by
-
- 16 edits2 deletes in trunk/Source
Unreviewed, rolling out r181010.
https://bugs.webkit.org/show_bug.cgi?id=142442
Broke media/video-src-invalid-poster.html (Requested by kling
on #webkit).
Reverted changeset:
"Stale entries in WeakGCMaps are keeping tons of WeakBlocks
alive unnecessarily."
https://bugs.webkit.org/show_bug.cgi?id=142115
http://trac.webkit.org/changeset/181010
- 2:10 PM Changeset in webkit [181213] by
-
- 6 edits in trunk/Source/JavaScriptCore
The code to link FunctionExecutable is duplicated everywhere
https://bugs.webkit.org/show_bug.cgi?id=142436
Reviewed by Darin Adler.
Reduced code duplication by factoring out linkInsideExecutable and linkGlobalCode.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock): Calls linkInsideExecutable.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::linkInsideExecutable): Renamed from link. Now takes care of startOffset.
This change was needed to use this function in CodeBlock::CodeBlock. Also, this function no longer takes
lineOffset since this information is already stored in the source code.
(JSC::UnlinkedFunctionExecutable::linkGlobalCode): Extracted from FunctionExecutable::fromGlobalCode.
- bytecode/UnlinkedCodeBlock.h:
- generate-js-builtins: Calls linkGlobalCode.
- runtime/Executable.cpp:
(JSC::ProgramExecutable::initializeGlobalProperties): Calls linkGlobalCode.
(JSC::FunctionExecutable::fromGlobalCode): Calls linkGlobalCode.
- 1:51 PM Changeset in webkit [181212] by
-
- 6 edits in trunk/Source/WebCore
Do a bit of EventNames tidying
https://bugs.webkit.org/show_bug.cgi?id=142438
Reviewed by Anders Carlsson.
- dom/EventNames.h: Sorted the event names into a single list instead of
the rudimentary attempts at organizing the list that simply made it hard
to see what is and is not in the list. Removed two unused event names.
I'm sure there are more. Reorganized the EventName class, now a struct,
into a more conventional "public first" order. Got the function bodies
out of the struct so we can see more clearly what is in the struct.
Made more things const.
(WebCore::EventNames::touchEventNames): Changed the return value to a
std::array of reference wrappers rather than a vector of atomic strings.
This should eliminate unnecessary memory allocation and reference count churn.
- dom/EventNames.cpp: Changed initialization based on the above.
- dom/EventTarget.cpp:
(WebCore::EventTarget::getEventListeners): Use NeverDestroyed instead of
DEPRECATED_DEFINE_LOCAL and also just tightened up the function a bit.
- dom/Node.cpp:
(WebCore::Node::didMoveToNewDocument): Streamlined this function with
modern for loops, auto, and also tried to make what it does a bit clearer,
by making loops that are just based on numbers of event listeners look a
bit less like code that actually iterates a vector of listeners. Also used
the type unsigned instead of size_t.
- platform/ThreadGlobalData.h: Updated since it's a struct instead of class now.
(Why is this file in platform!?)
- 11:14 AM Changeset in webkit [181211] by
-
- 4 edits in branches/safari-600.5-branch/Source/WebKit2
Merged r181176. rdar://problem/20077856
- 11:04 AM Changeset in webkit [181210] by
-
- 5 edits in trunk/Source/JavaScriptCore
Use FastMalloc (bmalloc) instead of BlockAllocator for GC pages
https://bugs.webkit.org/show_bug.cgi?id=140900
Reviewed by Mark Hahnenberg.
Re-landing just the MarkedBlock piece of this patch.
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::allocateBlock):
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::create):
(JSC::MarkedBlock::destroy):
(JSC::MarkedBlock::MarkedBlock):
- heap/MarkedBlock.h:
(JSC::MarkedBlock::capacity):
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::freeBlock):
- 10:03 AM Changeset in webkit [181209] by
-
- 9 edits in trunk
Source/WebCore:
[Win] Increase TestWebKitAPI Test Coverage
https://bugs.webkit.org/show_bug.cgi?id=142433
Reviewed by Darin Adler.
Correct some build deficiencies that prevent TestWebKitAPI
from executing certain tests on Windows.
- WebCore.vcxproj/copyForwardingHeaders.cmd: Copy the interpreter
headers.
- css/CSSParser.h: Export necessary symbols
- css/CSSParserMode.h: Ditto.
- css/StyleProperties.h: Ditto.
Tools:
[Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
https://bugs.webkit.org/show_bug.cgi?id=142433
Reviewed by Darin Adler.
Include more TestWebKitAPI tests when building for Windows. Also
fix a build error in MetaAllocator.cpp caused by one of the
Microsoft headers #defining 'small'.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
- TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
- 9:38 AM Changeset in webkit [181208] by
-
- 6 edits in trunk/Source/JavaScriptCore
fromGlobalCode has an unused Debugger* argument
https://bugs.webkit.org/show_bug.cgi?id=142430
Reviewed by Darin Adler.
Removed the debugger argument from UnlinkedFunctionExecutable::fromGlobalCode and
FunctionExecutable::fromGlobalCode since it's not used in either function.
Also use reference in other arguments.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::fromGlobalCode):
- bytecode/UnlinkedCodeBlock.h:
- runtime/Executable.cpp:
(JSC::FunctionExecutable::fromGlobalCode):
- runtime/Executable.h:
- runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
- 9:34 AM Changeset in webkit [181207] by
-
- 7 edits in trunk/Source/WebCore
Rename SOFT_LINK_FRAMEWORK_{HEADER,SOURCE} to SOFT_LINK_FRAMEWORK_FOR_{HEADER,SOURCE}
<http://webkit.org/b/142434>
Reviewed by Darin Adler.
- platform/cf/CoreMediaSoftLink.cpp:
- platform/cf/CoreMediaSoftLink.h:
- platform/cf/MediaAccessibilitySoftLink.cpp:
- platform/cf/MediaAccessibilitySoftLink.h:
- platform/mac/SoftLinking.h:
- platform/win/SoftLinking.h:
- Do the rename.
