Context Navigation

← Previous Period
Next Period →

Timeline

Mar 17, 2015:

11:09 PM Changeset in webkit [181685] by commit-queue@webkit.org

9 edits
2 deletes in trunk

Unreviewed, rolling out r181667, r181682, and r181683.
https://bugs.webkit.org/show_bug.cgi?id=142812

Broke multiple tests with ASan, plus dependent commits
(Requested by ap on #webkit).

Reverted changesets:

"Simple line layout: Split fragments on renderer boundary on
the fly."
https://bugs.webkit.org/show_bug.cgi?id=142579
http://trac.webkit.org/changeset/181667

"Simple line layout: Change FlowContents::segmentForPosition()
to segmentForRun()."
https://bugs.webkit.org/show_bug.cgi?id=142785
http://trac.webkit.org/changeset/181682

"Simple line layout: Use Vector<>::const_iterator instead of
custom FlowContents::Iterator."
https://bugs.webkit.org/show_bug.cgi?id=142809
http://trac.webkit.org/changeset/181683

10:38 PM Changeset in webkit [181684] by ap@apple.com

3 edits in trunk/LayoutTests

fast/images/animated-png.html is crashing / failing on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=142726

Further tweaked test expectations.

platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:

9:00 PM Changeset in webkit [181683] by Alan Bujtas

3 edits in trunk/Source/WebCore

Simple line layout: Use Vector<>::const_iterator instead of custom FlowContents::Iterator.
https://bugs.webkit.org/show_bug.cgi?id=142809

Reviewed by Antti Koivisto.

FlowContents::Iterator simply iterates on a vector<>. No need to custom implement it.

No change in functionality.

rendering/SimpleLineLayoutFlowContents.h:

(WebCore::SimpleLineLayout::FlowContents::begin):
(WebCore::SimpleLineLayout::FlowContents::end):
(WebCore::SimpleLineLayout::FlowContents::Iterator::Iterator): Deleted.
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator++): Deleted.
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator--): Deleted.
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator==): Deleted.
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator!=): Deleted.
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator*): Deleted.
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator->): Deleted.

rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::TextFragmentIterator::skipToNextPosition):

8:40 PM Changeset in webkit [181682] by Alan Bujtas

4 edits in trunk/Source/WebCore

Simple line layout: Change FlowContents::segmentForPosition() to segmentForRun().
https://bugs.webkit.org/show_bug.cgi?id=142785

Reviewed by Antti Koivisto.

This is in transition to support <br>. A particular position could point to multiple
segments when <br> is directly followed by text.

No change in functionality.

rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::FlowContents::segmentIndexForRunSlow):
(WebCore::SimpleLineLayout::FlowContents::segmentIndexForPositionSlow): Deleted.

rendering/SimpleLineLayoutFlowContents.h:

(WebCore::SimpleLineLayout::FlowContents::segmentForRun):
(WebCore::SimpleLineLayout::FlowContents::segmentIndexForPosition): Deleted.
(WebCore::SimpleLineLayout::FlowContents::segmentForPosition): Deleted.

rendering/SimpleLineLayoutResolver.cpp:

(WebCore::SimpleLineLayout::RunResolver::Run::text):

7:42 PM Changeset in webkit [181681] by ryuan.choi@navercorp.com

12 edits
1 copy
3 adds in trunk

[EFL] Expose JavaScript binding interface through ewk_extension
https://bugs.webkit.org/show_bug.cgi?id=142033

Reviewed by Gyuyoung Kim.

Source/cmake/OptionsEfl.cmake: Added HEADER_INSTALL_DIR variable.

Source/JavaScriptCore:

PlatformEfl.cmake: Install Javascript APIs.

Source/WebKit2:

PlatformEfl.cmake:
UIProcess/API/efl/tests/extensions/extension_sample.cpp: Registered test object for new test case.
UIProcess/API/efl/tests/test_ewk2_javascript_binding.cpp: Added simple binding API test case.

(EWK2ContextTestWithExtension::messageReceivedCallback):
(EWK2ContextTestWithExtension::EWK2ContextTestWithExtension):
(TEST_F):

WebProcess/InjectedBundle/API/efl/EWebKit_Extension.h:
WebProcess/InjectedBundle/API/efl/ewk_extension.cpp:

(EwkExtension::didCreatePage):
(EwkExtension::willDestroyPage):

WebProcess/InjectedBundle/API/efl/ewk_extension.h:
WebProcess/InjectedBundle/API/efl/ewk_extension_private.h:
WebProcess/InjectedBundle/API/efl/ewk_page.cpp: Added.

(toEwkPage):
(EwkPage::EwkPage):
(EwkPage::append):
(EwkPage::remove):
(EwkPage::didFinishDocumentLoadForFrame):
(ewk_page_js_global_context_get):
(ewk_page_client_register):
(ewk_page_client_unregister):

WebProcess/InjectedBundle/API/efl/ewk_page.h: Added.
WebProcess/InjectedBundle/API/efl/ewk_page_private.h: Added.

(EwkPage::page):

efl/ewebkit2-extension.pc.in:

6:50 PM Changeset in webkit [181680] by Brent Fulgham

2 edits in trunk/LayoutTests

[Win] Unreviewed gardening.

Tracked down the tests that were leaving the page cache in a bad state.
By skipping those tests, we can run all the others. These bugs are being
investigated in Bug 140871.

platform/win/TestExpectations:

6:34 PM Changeset in webkit [181679] by timothy_horton@apple.com

4 edits in trunk/Source

Cannot invoke action menus anymore
https://bugs.webkit.org/show_bug.cgi?id=142797
<rdar://problem/20032670>

UIProcess/API/mac/WKView.mm:

Need a respondsToSelector check.

WebView/WebHTMLView.mm:

(-[WebHTMLView otherMouseDown:]):
Need a respondsToSelector check.

6:32 PM Changeset in webkit [181678] by bshafiei@apple.com

5 edits in branches/safari-600.5-branch/Source

Versioning.

6:21 PM Changeset in webkit [181677] by timothy_horton@apple.com

2 edits in trunk/Tools

Fix the iOS build.

WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:

(WTR::InjectedBundle::platformInitialize):

6:21 PM Changeset in webkit [181676] by bshafiei@apple.com

1 copy in tags/Safari-600.5.15

New tag.

6:13 PM Changeset in webkit [181675] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Debugger Sidebar Icons Misaligned
https://bugs.webkit.org/show_bug.cgi?id=142654

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-17
Reviewed by Timothy Hatcher.

The debugger sidebar content was accidentally 1px too small. The
TreeOutline being inside of a .detail-section was getting a smaller
font-size. We should just have the normal font-size for the
debugger navigation sidebar. This matches the Resources sidebar
in the TreeOutline, and icons line up better.

UserInterface/Views/DebuggerSidebarPanel.css:

(.sidebar > .panel.navigation.debugger .details-section):

5:41 PM Changeset in webkit [181674] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit/mac

Fix the iOS build

WebView/WebHTMLView.mm:

5:07 PM Changeset in webkit [181673] by ggaren@apple.com

17 edits in trunk

Function bodies should always include braces
https://bugs.webkit.org/show_bug.cgi?id=142795

Reviewed by Michael Saboff.

Source/JavaScriptCore:

Having a mode for excluding the opening and closing braces from a function
body was unnecessary and confusing.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock): Adopt the new one true linking function.

bytecode/UnlinkedCodeBlock.cpp:

(JSC::generateFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::link):
(JSC::UnlinkedFunctionExecutable::codeBlockFor): No need to pass through
a boolean: there is only one kind of function now.

(JSC::UnlinkedFunctionExecutable::linkInsideExecutable): Deleted.
(JSC::UnlinkedFunctionExecutable::linkGlobalCode): Deleted. Let's only
have one way to do things. This removes the old mode that would pretend
that a function always started at column 1. That pretense was not true:
an attribute event listener does not necessarily start at column 1.

bytecode/UnlinkedCodeBlock.h:
generate-js-builtins: Adopt the new one true linking function.

parser/Parser.h:

(JSC::Parser<LexerType>::parse):
(JSC::parse): needsReparsingAdjustment is always true now, so I removed it.

runtime/Executable.cpp:

(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::ProgramExecutable::initializeGlobalProperties):
(JSC::FunctionExecutable::fromGlobalCode):

runtime/Executable.h:

(JSC::FunctionExecutable::create):
(JSC::FunctionExecutable::bodyIncludesBraces): Deleted. Removed unused stuff.

runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck): Always provide a
leading space because that's what this function's comment says is required
for web compatibility. We used to fake this up after the fact when
stringifying, based on the bodyIncludesBraces flag, but that flag is gone now.

runtime/FunctionPrototype.cpp:

(JSC::insertSemicolonIfNeeded):
(JSC::functionProtoFuncToString): No need to add braces and/or a space
after the fact -- we always have them now.

LayoutTests:

Updated these test results to reflect the fact that JavaScriptCore now
honors the source code text positions provided by WebCore, even for
attribute event handlers.

Unfortunately, the column numbers we used to report were wrong, and they
are still wrong now. The old column numbers were wrong because we would
always pretend that they started on column 1. The new column numbers
are wrong because WebCore records the column number after it finishes
parsing the element, rather than while it is parsing the event listener
attribute.

fast/events/window-onerror2-expected.txt:
fast/profiler/dead-time-expected.txt:
fast/profiler/inline-event-handler-expected.txt:
fast/profiler/stop-profiling-after-setTimeout-expected.txt:
js/dom/script-start-end-locations-expected.txt:

5:03 PM Changeset in webkit [181672] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Removal of multiline completion hint broken in Details sidebar
https://bugs.webkit.org/show_bug.cgi?id=142796

Patch by Tobias Reiss <tobi+webkit@basecode.de> on 2015-03-17
Reviewed by Joseph Pecoraro.

Prioritize CodeMirrorCompletionController over CSSStyleDeclarationTextEditor.
Both classes control the current CodeMirror instance of the Details Sidebar.
This change prevents possible race conditions during complete or delete-complete phases,
especially during operations on multiple styles in one line.

UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor):

4:42 PM Changeset in webkit [181671] by Chris Dumez

7 edits
1 copy
1 move
1 add
1 delete in trunk/Source/WebCore

[Mac][iOS] setSharedTimerFireInterval() / stopSharedTimer() are expensive
https://bugs.webkit.org/show_bug.cgi?id=142752
<rdar://problem/20176731>

Reviewed by Antti Koivisto.

setSharedTimerFireInterval() / stopSharedTimer() are expensive on Mac
and iOS on pages using a lot of timers.

For example, on bing.com / iOS, ~15.4% of the CPU time is spent in
setSharedTimerFireInterval() and ~14.7% of the CPU time is spent in
stopSharedTimer(). The expensive calls are CFRunLoopAddTimer (11.4%),
CFRunLoopTimerInvalidate (14.1%), CFRunLoopTimerCreate (3.3%).

The issue is that we keep creating, adding to run loop modes, and then
destroying the sharedTimer for each firing event. This is very
expensive. In such case, the CFRunLoopTimerRef documentation advises to
"""
... create a repeating timer with an initial firing time in the distant
future (or the initial firing time) and a very large repeat interval—on
the order of decades or more—and add it to all the necessary run loop
modes. Then, when you know when the timer should fire next, you reset
the firing time with CFRunLoopTimerSetNextFireDate, perhaps from the
timer’s own callback function. This technique effectively produces a
reusable, asynchronous timer.
""" [1].

Doing so greatly decreases CPU time spend in:

setSharedTimerFireInterval(): 15.4% -> 4.6%
stopSharedTimer(): 14.6% -> 8.6%

Overall CPU time spent on bing.com in timerFired() goes down from
~61.2% to ~49.5%.

This patch also refactors the SharedTimer code to share as much as
possible between Mac and iOS.

This patch is based in part on the following patch:
http://trac.webkit.org/changeset/143210

[1] https://developer.apple.com/library/prerelease/ios/documentation/CoreFoundation/Reference/CFRunLoopTimerRef/index.html#//apple_ref/c/func/CFRunLoopTimerSetNextFireDate

WebCore.xcodeproj/project.pbxproj:
platform/SharedTimer.h:

(WebCore::SharedTimer::invalidate):
(WebCore::MainThreadSharedTimer::setFiredFunction): Deleted.
(WebCore::MainThreadSharedTimer::setFireInterval): Deleted.
(WebCore::MainThreadSharedTimer::stop): Deleted.

platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::fireTimersInNestedEventLoop):

platform/cf/SharedTimerCF.mm: Added.

(WebCore::applicationDidBecomeActive):
(WebCore::setupPowerObserver):
(WebCore::setSharedTimerFiredFunction):
(WebCore::timerFired):
(WebCore::restartSharedTimer):
(WebCore::invalidateSharedTimer):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):

platform/efl/SharedTimerEfl.cpp:

(WebCore::invalidateSharedTimer):

platform/gtk/SharedTimerGtk.cpp:

(WebCore::invalidateSharedTimer):

platform/ios/SharedTimerIOS.mm: Removed.
platform/mac/PowerObserverMac.h: Copied from Source/WebCore/platform/efl/SharedTimerEfl.cpp.
platform/mac/PowerObserverMac.mm: Renamed from Source/WebCore/platform/mac/SharedTimerMac.mm.

(WebCore::PowerObserver::PowerObserver):
(WebCore::PowerObserver::~PowerObserver):
(WebCore::PowerObserver::didReceiveSystemPowerNotification):

platform/win/SharedTimerWin.cpp:

(WebCore::removeSharedTimer):

4:06 PM Changeset in webkit [181670] by mark.lam@apple.com

3 edits
2 adds in trunk/Source/JavaScriptCore

Refactor execution time limit tests out of testapi.c.
<https://webkit.org/b/142798>

Rubber stamped by Michael Saboff.

These tests were sometimes failing to time out on C loop builds. Let's
refactor them out of the big monolith that is testapi.c so that we can
reason more easily about them and make adjustments if needed.

API/tests/ExecutionTimeLimitTest.cpp: Added.

(currentCPUTime):
(currentCPUTimeAsJSFunctionCallback):
(shouldTerminateCallback):
(cancelTerminateCallback):
(extendTerminateCallback):
(testExecutionTimeLimit):

API/tests/ExecutionTimeLimitTest.h: Added.
API/tests/testapi.c:

(main):
(currentCPUTime): Deleted.
(currentCPUTime_callAsFunction): Deleted.
(shouldTerminateCallback): Deleted.
(cancelTerminateCallback): Deleted.
(extendTerminateCallback): Deleted.

JavaScriptCore.xcodeproj/project.pbxproj:

3:57 PM Changeset in webkit [181669] by dino@apple.com

3 edits in trunk/Tools

check-webkit-style should allow "bool a : 1"
https://bugs.webkit.org/show_bug.cgi?id=142794

Reviewed by Brent Fulgham.

We should allow member bitfields of the form:

bool m_var : 1;

It seems that Visual Studio 8 was the last compiler that
wasn't happy about not using unsigned here. We already have
about 500 cases (in WebCore) where people were ignoring this rule.

Scripts/webkitpy/style/checkers/cpp.py:

(check_language): Allow "bool".

Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.

(CppStyleTest.test_enum_bitfields):
(CppStyleTest.test_plain_integral_bitfields):

3:48 PM Changeset in webkit [181668] by timothy_horton@apple.com

6 edits in trunk/Source

Cannot invoke action menus anymore
https://bugs.webkit.org/show_bug.cgi?id=142797
<rdar://problem/20032670>

Reviewed by Beth Dakin.

UIProcess/API/mac/WKView.mm:

Don't process mouse events that would make an action menu; call super
and let AppKit take care of it. We have to duplicate the macro so that
we can avoid calling super for the internal-only methods.
Also, otherMouseMoved is simply not a thing, so remove it.

WebView/WebHTMLView.mm:

(-[WebHTMLView otherMouseDown:]):
Don't override otherMouseDown: if the event would make an action menu.

platform/spi/mac/NSMenuSPI.h:

Add additional NSMenu SPI.

3:20 PM Changeset in webkit [181667] by Alan Bujtas

7 edits
2 adds in trunk

Simple line layout: Split fragments on renderer boundary on the fly.
https://bugs.webkit.org/show_bug.cgi?id=142579

Reviewed by Antti Koivisto.

Fragment splitting at renderers' boundary at the end of the line is no longer needed.
This patch ensures that TextFragmentIterator::nextTextFragment() does not concatenate
fragments across renderer boundary.

Source/WebCore:

Test: fast/text/simple-line-with-multiple-renderers.html

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::revertRuns):
(WebCore::SimpleLineLayout::LineState::isEmpty):
(WebCore::SimpleLineLayout::LineState::appendFragmentAndCreateRunIfNeeded): Check if fragments need a new run and
whether neighboring fragments need collapsing.
(WebCore::SimpleLineLayout::LineState::revertUncommitted): Revert fragments over multiple renderers if they form
a fragment continuation.
(WebCore::SimpleLineLayout::LineState::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::forceFragmentToLine): Ensure that if a fragment has continuation across multiple renderers,
they all get added to the current line.
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::LineState::appendFragment): Deleted.
(WebCore::SimpleLineLayout::FragmentForwardIterator::FragmentForwardIterator): Deleted.
(WebCore::SimpleLineLayout::FragmentForwardIterator::operator++): Deleted.
(WebCore::SimpleLineLayout::FragmentForwardIterator::operator!=): Deleted.
(WebCore::SimpleLineLayout::FragmentForwardIterator::operator*): Deleted.
(WebCore::SimpleLineLayout::begin): Deleted.
(WebCore::SimpleLineLayout::end): Deleted.
(WebCore::SimpleLineLayout::preWrap): Deleted.
(WebCore::SimpleLineLayout::removeTrailingWhitespace): Deleted.
(WebCore::SimpleLineLayout::updateLineConstrains): Deleted.
(WebCore::SimpleLineLayout::splitRunsAtRendererBoundary): Deleted.
(WebCore::SimpleLineLayout::createTextRuns): Deleted.
(WebCore::SimpleLineLayout::create): Deleted.
(WebCore::SimpleLineLayout::Layout::create): Deleted.

rendering/SimpleLineLayoutFlowContents.h:

(WebCore::SimpleLineLayout::FlowContents::Iterator::operator+):
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator*):
(WebCore::SimpleLineLayout::FlowContents::Iterator::operator->):

rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow): Unrelated fix on non-collapsed tab position.

rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragmentIterator):
(WebCore::SimpleLineLayout::TextFragmentIterator::nextTextFragment):
(WebCore::SimpleLineLayout::TextFragmentIterator::revertToFragment):
(WebCore::SimpleLineLayout::TextFragmentIterator::textWidth):
(WebCore::SimpleLineLayout::TextFragmentIterator::skipToNextPosition):

rendering/SimpleLineLayoutTextFragmentIterator.h:

(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::TextFragment):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::overlapsToNextRenderer):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::isCollapsible):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::operator==):
(WebCore::SimpleLineLayout::TextFragmentIterator::isLineBreak):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::split): Deleted.

LayoutTests:

fast/text/simple-line-with-multiple-renderers-expected.html: Added.
fast/text/simple-line-with-multiple-renderers.html: Added.

3:12 PM Changeset in webkit [181666] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

When tab hides, pause fullscreen and exit normally.
https://bugs.webkit.org/show_bug.cgi?id=142685

Patch by Jeremy Jones <jeremyj@apple.com> on 2015-03-17
Reviewed by Eric Carlson.

Pause fullscreen playback when switching tabs. Exit fullscreen is not necessary and even prevents
the normal flow of teardown. This allows the normal exit fullscreen call to succeed and call its callback.

platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen):

2:29 PM Changeset in webkit [181665] by peavo@outlook.com

2 edits in trunk/Source/WebCore

[WinCairo] Video position is incorrect when located inside a frame.
https://bugs.webkit.org/show_bug.cgi?id=142784

Reviewed by Brent Fulgham.

We need to take the enclosing frame's position into account, when finding the video position.

platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::setSize):

2:15 PM Changeset in webkit [181664] by ggaren@apple.com

16 edits in trunk/Source/JavaScriptCore

Built-in functions should know that they use strict mode
https://bugs.webkit.org/show_bug.cgi?id=142788

Reviewed by Mark Lam.

Even though all of our builtin functions use strict mode, the parser
thinks that they don't. This is because Executable::toStrictness treats
builtin-ness and strict-ness as mutually exclusive.

The fix is to disambiguate builtin-ness from strict-ness.

This bug is currently unobservable because of some other parser bugs. But
it causes lots of test failures once those other bugs are fixed.

API/JSScriptRef.cpp:

(parseScript):

builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::createBuiltinExecutable): Adopt the new API
for a separate value to indicate builtin-ness vs strict-ness.

bytecode/UnlinkedCodeBlock.cpp:

(JSC::generateFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::codeBlockFor): Ditto.

bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::toStrictness): Deleted. This function
was misleading since it pretended that no builtin function was ever
strict, which is the opposite of true.

parser/Lexer.cpp:

(JSC::Lexer<T>::Lexer):

parser/Lexer.h:
parser/Parser.cpp:

(JSC::Parser<LexerType>::Parser):

parser/Parser.h:

(JSC::parse): Adopt the new API.

parser/ParserModes.h: Added JSParserBuiltinMode, and tried to give

existing modes clearer names.

runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode): Adopt the new API.

runtime/CodeCache.h:

(JSC::SourceCodeKey::SourceCodeKey): Be sure to treat strict-ness and
bulitin-ness as separate pieces of the code cache key. We would not want
a user function to match a built-in function in the cache, even if they
agreed about strictness, since builtin functions have different lexing
rules.

runtime/Completion.cpp:

(JSC::checkSyntax):

runtime/Executable.cpp:

(JSC::FunctionExecutable::FunctionExecutable):
(JSC::ProgramExecutable::checkSyntax):

runtime/Executable.h:

(JSC::FunctionExecutable::create):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::createProgramCodeBlock):
(JSC::JSGlobalObject::createEvalCodeBlock): Adopt the new API.

1:47 PM Changeset in webkit [181663] by benjamin@webkit.org

9 edits in trunk

Compile character ranges targeting the same state as range check in the bytecode
https://bugs.webkit.org/show_bug.cgi?id=142759

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-03-17
Reviewed by Alex Christensen.

Source/WebCore:

Previously, character ranges would be compiled as many individual character checks.
For example, a transition on "[a-z]" would do 26 character checks + jump, which leads
to enormous matchines.

With this patch, we find the ranges at lowering time and generate a single instruction
for them: "CheckValueRange". This helps making the machine denser when the input
use character sets.

The second part of this patch goes further in the case where the transitions out of
a state cover the entire alphabet. In that case, we create a fallback transition
on the fly and remove all the ranges made useless.
That case is common when ranges are used with inverse character set (e.g. [^a]+a).

contentextensions/DFABytecode.h:

(WebCore::ContentExtensions::instructionSizeWithArguments):

contentextensions/DFABytecodeCompiler.cpp:

(WebCore::ContentExtensions::DFABytecodeCompiler::emitCheckValueRange):
(WebCore::ContentExtensions::DFABytecodeCompiler::compileNode):
(WebCore::ContentExtensions::DFABytecodeCompiler::compileNodeTransitions):
(WebCore::ContentExtensions::DFABytecodeCompiler::compileCheckForRange):

contentextensions/DFABytecodeCompiler.h:

Extend the compiler to detect ranges and lower them as CheckValueRange.

contentextensions/DFABytecodeInterpreter.cpp:

(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):
Range checks in the interpreter.

contentextensions/NFA.cpp:

(WebCore::ContentExtensions::NFA::setFinal):
This assertion does not make sense with the current codebase. Actions are "compressed",
it is possible to have two patterns with the same action.

contentextensions/NFAToDFA.cpp:

(WebCore::ContentExtensions::simplifyTransitions):
A very simple DFA optimization function: it only reduce the strength of ranges.

(WebCore::ContentExtensions::NFAToDFA::convert):

Tools:

TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::TEST_F):

1:28 PM Changeset in webkit [181662] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r181423): Crash @ generatedcontent.org at com.apple.WebCore: WebCore::MediaPlayer::maximumDurationToCacheMediaTime const + 4
https://bugs.webkit.org/show_bug.cgi?id=142787

Reviewed by Eric Carlson.

Null check m_player before derefencing.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

1:22 PM Changeset in webkit [181661] by youenn.fablet@crf.canon.fr

6 edits in trunk/Tools

W3C test parser and converter should use test importer host
https://bugs.webkit.org/show_bug.cgi?id=142729

Reviewed by Bem Jones-Bey.

When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
This enables adding more TestImporter unit testing.
This patch also ensures that the git object instantiated by TestDownloader is using the
same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.

Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.copytree): Fixes implementation as it creates a runtime error.

Scripts/webkitpy/w3c/test_downloader.py:

(TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
(TestDownloader.checkout_test_repository): Making use of the new git function.

Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.find_importable_tests): Adding host as parameter to the parser.
(TestImporter.import_tests): Adding host as parameter to the converter.

Scripts/webkitpy/w3c/test_importer_unittest.py:

(TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
(TestImporterTest):
(TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests.

Scripts/webkitpy/w3c/test_parser.py:

(TestParser.init): Adding host as parameter constructor.

1:20 PM Changeset in webkit [181660] by Beth Dakin

12 edits in trunk/Source

DOM mouse events have weird timing for force clickable elements in Safari 8.0.3 on
10.10.2
https://bugs.webkit.org/show_bug.cgi?id=142700
-and corresponding-
rdar://problem/20165168

Reviewed by Tim Horton.

Source/WebCore:

This patch adds a new enum and member variable so that EventHandler can keep track
of the current immediate action state.

page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):

A new mouse press even is starting. We can re-set m_immediateActionStage to none
unless a Hit Test has already been performed.
(WebCore::EventHandler::handleMousePressEvent):

If an immediate action was completed, then send mouse to the DOM and return early.
This will prevent us from doing our own normal mouseup behaviors such as
navigating to a link that was clicked — we only want to do that if the click was
not used to perform an immediate action.
(WebCore::EventHandler::handleMouseReleaseEvent):

page/EventHandler.h:

(WebCore::EventHandler::setImmediateActionStage):

Source/WebKit2:

No need to tell the WKImmediateActionController about mouse down any more since we
are expecting it at the beginning of an immediate action interaction.

UIProcess/API/mac/WKView.mm:

(-[WKView mouseDown:]):

Set the delaysPrimaryMouseButtonEvents to NO for the
_immediateActionGestureRecognizer. This will cause AppKit to send up the mouse
events at the expected time.
(-[WKView initWithFrame:processPool:configuration:webView:]):

WebCore::EventHandler now needs to know if an immediate action cancelled or
completed. This plumbs that information down.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::immediateActionDidCancel):
(WebKit::WebPageProxy::immediateActionDidComplete):

UIProcess/WebPageProxy.h:
UIProcess/mac/WKImmediateActionController.h:
UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
(-[WKImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
(-[WKImmediateActionController wkView:willHandleMouseDown:]): Deleted.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Call EventHandler::setImmediateActionStage() with the appropriate stage.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performActionMenuHitTestAtLocation):
(WebKit::WebPage::immediateActionDidCancel):
(WebKit::WebPage::immediateActionDidComplete):

1:11 PM Changeset in webkit [181659] by dino@apple.com

5 edits in trunk/LayoutTests

Implement Scroll Container Animation Triggers
https://bugs.webkit.org/show_bug.cgi?id=142732

Unreviewed attempt to make the test reproducible.

animations/trigger-container-scroll-simple.html: Add a step-start timing

function so the animation instantly moves to the end position.

12:58 PM Changeset in webkit [181658] by dino@apple.com

2 edits in trunk/Source/WebCore

Implement Scroll Container Animation Triggers
https://bugs.webkit.org/show_bug.cgi?id=142732

Attempt to fix the build.

css/CSSComputedStyleDeclaration.cpp: Add an #if ENABLE guard.

12:39 PM Changeset in webkit [181657] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Use a better parameter name for Document.getElementsByClassName
https://bugs.webkit.org/show_bug.cgi?id=142771

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-17
Reviewed by Chris Dumez.

bindings/objc/PublicDOMInterfaces.h:
dom/Document.idl:

12:15 PM Changeset in webkit [181656] by timothy_horton@apple.com

17 edits
2 adds in trunk

Reproducible null deref under ScriptedAnimationController::createDisplayRefreshMonitor
https://bugs.webkit.org/show_bug.cgi?id=142776
<rdar://problem/18921338>

Reviewed by Alexey Proskuryakov.

Test: fast/animation/request-animation-frame-unparented-iframe-crash.html

In some cases (like the new test), we can end up trying to start
requestAnimationFrame on a Document that has no Page. Most paths null-checked
the Page and did the right thing, but one failed to do so. In addition,
the current fallback (when Page is null) can result in us constructing
the wrong kind of DisplayRefreshMonitor, which could lead to trouble
down the road when it's reused. Instead, just completely avoid making a
DisplayRefreshMonitor in the null-page case.

dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::createDisplayRefreshMonitor):
If the page is null, bail.

dom/ScriptedAnimationController.h:
platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::create):
Use Optional<> to make it easy to distinguish between ChromeClient
being unreachable (because we don't have a Page for some reason) and
ChromeClient declaring that it doesn't want to override the type of
DisplayRefreshMonitor that is created.

If ChromeClient was unreachable for some reason, we'll get back an engaged
nullptr and return it (instead of creating a DisplayRefreshMonitor based
on the platform). This avoids creating the wrong type of DisplayRefreshMonitor
in the rare case where we can't reach the ChromeClient (e.g. a freshly unparented
IFrame).

If instead the client returns a disengaged Nullopt, we'll interpret that as
"construct the default type", which falls back on the platform #ifdefs to
decide what to make.

platform/graphics/DisplayRefreshMonitorManager.cpp:

(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient):
(WebCore::DisplayRefreshMonitorManager::scheduleAnimation):
Silently handle the case where we failed to make a DisplayRefreshMonitor.

platform/graphics/DisplayRefreshMonitor.h:
platform/graphics/DisplayRefreshMonitorClient.h:
platform/graphics/GraphicsLayerUpdater.cpp:

(WebCore::GraphicsLayerUpdater::createDisplayRefreshMonitor):

platform/graphics/GraphicsLayerUpdater.h:
rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::createDisplayRefreshMonitor):

rendering/RenderLayerCompositor.h:

Adjust to the new signature of createDisplayRefreshMonitor, and return
an engaged (nullptr) Optional if we can't get to ChromeClient for any reason.

page/ChromeClient.h:

Return Nullopt (indicating a lack of override) by default.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createDisplayRefreshMonitor):

WebProcess/WebCoreSupport/WebChromeClient.h:

Adjust to the new signature.

fast/animation/request-animation-frame-unparented-iframe-crash-expected.txt: Added.
fast/animation/request-animation-frame-unparented-iframe-crash.html: Added.

Add a test that ensures that calling requestAnimationFrame on a recently-unparented
frame doesn't crash.

12:01 PM Changeset in webkit [181655] by dino@apple.com

11 edits
2 adds in trunk

Implement Scroll Container Animation Triggers
https://bugs.webkit.org/show_bug.cgi?id=142732

Reviewed by Simon Fraser.

Source/WebCore:

Test: animations/trigger-container-scroll-simple.html

Basic implementation of container-scroll. It only checks
the page scroll position for trigger values (not the scrolling
container in an overflow).

css/CSSComputedStyleDeclaration.cpp: Add CSSPropertyWebkitAnimationTrigger

so that this property will appear in the inspector.

page/FrameView.cpp:

(WebCore::FrameView::sendScrollEvent): If the page has scrolled, let the animation
controller know about it.

page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::updateStateMachine): Whitespace fix.
(WebCore::AnimationBase::fireAnimationEventsIfNeeded): If there is a trigger,
and the scroll position is past it, then tell the state machine that
we should start.
(WebCore::AnimationBase::timeToNextService): Use the scroll position as
an input to the update timer if a trigger is involved.

page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::ensureCompositeAnimation): Add whitespace.
(WebCore::AnimationControllerPrivate::scrollWasUpdated): Call updateAnimations.
(WebCore::AnimationController::scrollWasUpdated): Call into AnimationControllerPrivate.

page/animation/AnimationController.h:
page/animation/AnimationControllerPrivate.h:

page/animation/CompositeAnimation.cpp: Keep a record of whether we have a scroll

triggered animation.
(WebCore::CompositeAnimation::CompositeAnimation):
(WebCore::CompositeAnimation::updateKeyframeAnimations):

page/animation/CompositeAnimation.h:

(WebCore::CompositeAnimation::hasScrollTriggeredAnimation):

platform/animation/Animation.cpp:

(WebCore::Animation::operator=):

LayoutTests:

Test that checks if an animation only triggers when the page
is scrolled.

animations/trigger-container-scroll-simple-expected.txt: Added.
animations/trigger-container-scroll-simple.html: Added.

11:58 AM Changeset in webkit [181654] by Simon Fraser

7 edits in trunk/Source/WebCore

Move some code from LogicalSelectionOffsetCaches into RenderElement
https://bugs.webkit.org/show_bug.cgi?id=142758

Reviewed by Myles C. Maxfield.

LogicalSelectionOffsetCaches had some useful code regarding containing blocks etc
that should be used in more places, so move it into RenderElement.

No behavior change.

rendering/LogicalSelectionOffsetCaches.h:

(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
(WebCore::isContainingBlockCandidateForAbsolutelyPositionedObject): Deleted.
(WebCore::isNonRenderBlockInline): Deleted.
(WebCore::containingBlockForFixedPosition): Deleted.
(WebCore::containingBlockForAbsolutePosition): Deleted.
(WebCore::containingBlockForObjectInFlow): Deleted.

rendering/RenderBlock.cpp: No need to initialize static data.

(WebCore::RenderBlock::positionedObjects): nullptr

rendering/RenderElement.cpp:

(WebCore::RenderElement::containingBlockForFixedPosition):
(WebCore::RenderElement::containingBlockForAbsolutePosition):
(WebCore::isNonRenderBlockInline):
(WebCore::RenderElement::containingBlockForObjectInFlow):

rendering/RenderElement.h:

(WebCore::RenderElement::canContainAbsolutelyPositionedObjects):

rendering/RenderLayer.cpp:

(WebCore::isContainerForPositioned):

rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock):

11:54 AM March 2015 Meeting edited by Antti Koivisto

(diff)

11:47 AM Disk cache.pdf attached to March 2015 Meeting by Antti Koivisto

Disk cache slides

11:02 AM Changeset in webkit [181653] by achristensen@apple.com

2 edits in trunk/Source/WebCore

[WinCairo] Unreviewed build fix after r181640.

platform/graphics/cairo/GraphicsContext3DCairo.cpp:

Tell Windows how to find ShaderLang.h.

10:50 AM Changeset in webkit [181652] by Brent Fulgham

2 edits in trunk/LayoutTests

[Win] Skip some IndexDB tests that don't apply on Windows.

platform/win/TestExpectations:

9:09 AM Changeset in webkit [181651] by Antti Koivisto

5 edits
2 adds in trunk

Disk cache should support Vary: Cookie
https://bugs.webkit.org/show_bug.cgi?id=142770
Source/WebKit2:

rdar://problem/19764945

Reviewed by Anders Carlsson.

Cookies are not part of the original request but are added by the networking layer when submitting the request.
Fetch them explicitly when resolving Vary: Cookie.

The implementation is not perfect as it fetches the cookie for the cache entry when saving a Vary:Cookie response,
not when making the request. In principle the cookie may have changed in-between. This should be enough to handle
reasonable cases though. Fetching cookies for every request might be too expensive for this rarely used feature.

NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::headerValueForVary):
(WebKit::NetworkCache::encodeStorageEntry):
(WebKit::NetworkCache::verifyVaryingRequestHeaders):

LayoutTests:

Reviewed by Anders Carlsson.

http/tests/cache/disk-cache-vary-cookie-expected.txt: Added.
http/tests/cache/disk-cache-vary-cookie.html: Added.

8:50 AM Changeset in webkit [181650] by fpizlo@apple.com

22 edits in trunk/Source/JavaScriptCore

DFG IR shouldn't have a separate node for every kind of put hint that could be described using PromotedLocationDescriptor
https://bugs.webkit.org/show_bug.cgi?id=142769

Reviewed by Michael Saboff.

When we sink an object allocation, we need to have some way of tracking what stores would
have happened had the allocation not been sunk, so that we know how to rematerialize the
object on OSR exit. Prior to this change, trunk had two ways of describing such a "put
hint":

The PutStrutureHint and PutByOffsetHint node types.
The PromotedLocationDescriptor class, which has an enum with cases StructurePLoc and NamedPropertyPLoc.

We also had ways of converting from a Node with those two node types to a
PromotedLocationDescriptor, and we had a way of converting a PromotedLocationDescriptor to
a Node.

This change removes the redundancy. We now have just one node type that corresponds to a
put hint, and it's called PutHint. It has a PromotedLocationDescriptor as metadata.
Converting between a PutHint node and a PromotedLocationDescriptor and vice-versa is now
trivial.

This means that if we add new kinds of sunken objects, we'll have less pro-forma to write
for the put hints to those objects. This is mainly to simplify the implementation of
arguments elimination in bug 141174.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::mergeRelevantToOSR):

dfg/DFGMayExit.cpp:

(JSC::DFG::mayExit):

dfg/DFGNode.cpp:

(JSC::DFG::Node::convertToPutHint):
(JSC::DFG::Node::convertToPutStructureHint):
(JSC::DFG::Node::convertToPutByOffsetHint):
(JSC::DFG::Node::promotedLocationDescriptor):

dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasPromotedLocationDescriptor):
(JSC::DFG::Node::convertToPutByOffsetHint): Deleted.
(JSC::DFG::Node::convertToPutStructureHint): Deleted.

dfg/DFGNodeType.h:
dfg/DFGOSRAvailabilityAnalysisPhase.cpp:

(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):

dfg/DFGObjectAllocationSinkingPhase.cpp:

(JSC::DFG::ObjectAllocationSinkingPhase::run):
(JSC::DFG::ObjectAllocationSinkingPhase::lowerNonReadingOperationsOnPhantomAllocations):
(JSC::DFG::ObjectAllocationSinkingPhase::handleNode):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGPromoteHeapAccess.h:

(JSC::DFG::promoteHeapAccess):

dfg/DFGPromotedHeapLocation.cpp:

(JSC::DFG::PromotedHeapLocation::createHint):

dfg/DFGPromotedHeapLocation.h:

(JSC::DFG::PromotedLocationDescriptor::imm1):
(JSC::DFG::PromotedLocationDescriptor::imm2):

dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validateCPS):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):

8:48 AM Changeset in webkit [181649] by Chris Dumez

2 edits in trunk/Source/WebCore

'pageLoaded' diagnostic logging is too verbose
https://bugs.webkit.org/show_bug.cgi?id=142727
<rdar://problem/18937048>

Reviewed by Eric Carlson.

Make 'pageLoaded' diagnostic logging less verbose:

Log once per main frame instead of once for subframe
Apply sampling

loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

6:37 AM Changeset in webkit [181648] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.7.92

WebKitGTK+ 2.7.92

6:08 AM Changeset in webkit [181647] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.8

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.7.92 release.

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

gtk/NEWS: Add release notes for 2.7.92.

5:39 AM Changeset in webkit [181646] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore/platform/gtk/po

Merge r181645 - [l10n] Updated Hebrew translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=142781

Patch by Yosef Or Boczko <yoseforb@gnome.org> on 2015-03-17
Reviewed by Carlos Garcia Campos.

he.po:

5:38 AM Changeset in webkit [181645] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Hebrew translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=142781

Patch by Yosef Or Boczko <yoseforb@gnome.org> on 2015-03-17
Reviewed by Carlos Garcia Campos.

he.po:

5:23 AM Changeset in webkit [181644] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r181643 - [GTK] Wrong transfer annotations used in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=142780

Reviewed by Gustavo Noronha Silva.

We are using transfer none for all methods returning a GObject DOM
Object. That's not true. Only objects derived from Node are
automatically released by the DOM object cache and can be transfer
none. All other objects are added to the cache only to avoid
creating the same wrapper twice for the same core object, but
caller should release the returned reference.

bindings/gobject/WebKitDOMCustomUnstable.h:
bindings/scripts/CodeGeneratorGObject.pm:

(GetTransferTypeForReturnType):
(GenerateFunction):

5:22 AM Changeset in webkit [181643] by Carlos Garcia Campos

3 edits in trunk/Source/WebCore

[GTK] Wrong transfer annotations used in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=142780

Reviewed by Gustavo Noronha Silva.

bindings/gobject/WebKitDOMCustomUnstable.h:
bindings/scripts/CodeGeneratorGObject.pm:

(GetTransferTypeForReturnType):
(GenerateFunction):

5:20 AM WebKitGTK/2.8.x edited by Carlos Garcia Campos

(diff)

5:18 AM Changeset in webkit [181642] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore/platform/gtk/po

Merge r181639 - [l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=142306

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2015-03-17
Reviewed by Carlos Garcia Campos.

pl.po:

5:16 AM Changeset in webkit [181641] by Carlos Garcia Campos

5 edits in releases/WebKitGTK/webkit-2.8

Merge r181631 - [GTK] WebKitDOM objects leaking
https://bugs.webkit.org/show_bug.cgi?id=118788

Reviewed by Darin Adler and Sergio Villar Senin.

Source/WebCore:

Use a DOMwindowObserver class, derived from DOMWindowProperty to
be notified when the window object is detached from the frame to
clear the DOM objects associated to that frame in that case too.

bindings/gobject/DOMObjectCache.cpp:

Tools:

Update DOMObjectCache unit test to check that DOM objects are also
released when new contents are loaded in the web view, and the old
document is detached from the frame.

TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:

(testWebKitDOMObjectCache):

TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:

(runTest):

5:14 AM Changeset in webkit [181640] by Carlos Garcia Campos

7 edits
2 adds in releases/WebKitGTK/webkit-2.8/Source

Merge r181629 - [CMake] Use a forwarding header for ANGLE's ShaderLang.h to avoid picking up ANGLE's EGL headers
https://bugs.webkit.org/show_bug.cgi?id=142530

Reviewed by Darin Adler.

Source/ThirdParty/ANGLE:

ANGLE/ShaderLang.h: Added. Includes include/GLSLANG/ShaderLang.h. Used in WebCore

so we can avoid using ANGLE's EGL headers and use the system-default headers instead.

Source/WebCore:

Include the ANGLE's ShaderLang.h through the new forwarding header. This allows
us to not list Source/ThirdParty/ANGLE/include in the list of inclusion directories
and thus avoid ANGLE's EGL and GLES2/GLES3 headers, defaulting to the system-provided
headers instead.

Source/ThirdParty/ANGLE/include/KHR is still used because ANGLE's khrplatform.h is
required by the ShaderLang.h header. Source/ThirdParty/ANGLE/src is not used for the
whole WebCore library anymore, only the ANGLESupport library.

CMakeLists.txt:
platform/graphics/ANGLEWebKitBridge.h:
platform/graphics/cairo/GraphicsContext3DCairo.cpp:

Source/WebKit2:

CMakeLists.txt: Replace the Source/ThirdParty/ANGLE/include/GLSLANG entry

in the list of inclusion directories for WebKit2 with Source/ThirdParty/ANGLE,
possible due to the new forwarding header for ANGLE's ShaderLang.h.

4:57 AM Changeset in webkit [181639] by berto@igalia.com

2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=142306

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2015-03-17
Reviewed by Carlos Garcia Campos.

pl.po:

4:48 AM Changeset in webkit [181638] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/WebKit2

Merge r181620 - REGRESSION(r180924): Unable to build WebKitGTK+ with threaded compositor

Unreviewed build fix.

WebProcess/WebPage/LayerTreeHost.h:

Remove duplicated declaration of setNativeSurfaceHandleForCompositing.

4:47 AM Changeset in webkit [181637] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.8

Merge r181600 - AX: Crash viewing http://www.last.fm/
https://bugs.webkit.org/show_bug.cgi?id=142309

Reviewed by Chris Fleizach.

Source/WebCore:

The crash occurs when a not-yet-rendered object emits a children-changed
signal. If an assistive technology is listening, AT-SPI2 will attempt to
create and cache the state set for the child being added and the creation
of the state set assumes a rendered object.

Test: platform/gtk/accessibility/no-notification-for-unrendered-iframe-children.html

accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::attachWrapper):

LayoutTests:

This test doesn't verify the absence of the crash because the crash seems
to require that an assistive technology is listening for events, and that
AT-SPI2 is caching the tree for that assistive technology -- something we
cannot count on being the case on our bots. (I suspect that the reason non-
assistive technology users of Epiphany were getting hit by this is because
Caribou was listening for events in the background, thus they were AT users
without realizing it. That Caribou issue is in theory now resolved.) What
this test does verify is the absence of children-changed:add accessibility
signals for non-rendered objects, which is the source of the crash given
the aforementioned environment.

platform/gtk/accessibility/no-notification-for-unrendered-iframe-children-expected.txt: Added.
platform/gtk/accessibility/no-notification-for-unrendered-iframe-children.html: Added.

4:46 AM Changeset in webkit [181636] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/WebKit2

Merge r181599 - ASSERT(m_plugin) on plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html
https://bugs.webkit.org/show_bug.cgi?id=142637

Reviewed by Dean Jackson.

WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::pluginSnapshotTimerFired):

m_plugin can be legitimately null.

4:44 AM Changeset in webkit [181635] by Carlos Garcia Campos

8 edits in releases/WebKitGTK/webkit-2.8/Source

Merge r181570 - [ARM] Enable generating idiv instructions if it is supported
https://bugs.webkit.org/show_bug.cgi?id=142725

Reviewed by Michael Saboff.

Source/JavaScriptCore:

assembler/ARMAssembler.h: Added sdiv and udiv implementation for ARM Traditional instruction set.

(JSC::ARMAssembler::sdiv):
(JSC::ARMAssembler::udiv):

assembler/ARMv7Assembler.h: Use HAVE(ARM_IDIV_INSTRUCTIONS) instead of CPU(APPLE_ARMV7S).
assembler/AbstractMacroAssembler.h:

(JSC::isARMv7IDIVSupported):
(JSC::optimizeForARMv7IDIVSupported):
(JSC::isARMv7s): Renamed to isARMv7IDIVSupported().
(JSC::optimizeForARMv7s): Renamed to optimizeForARMv7IDIVSupported().

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithDiv):
(JSC::DFG::SpeculativeJIT::compileArithMod):

Source/WTF:

wtf/Platform.h: Set HAVE_ARM_IDIV_INSTRUCTIONS based on GCC macro too.

4:43 AM Changeset in webkit [181634] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r181565 - URLs visited during private browsing show up in WebpageIcons.db
rdar://problem/11254910 and https://bugs.webkit.org/show_bug.cgi?id=142733

Patch by Sam Weinig. Reviewed by Brady Eidson.

loader/icon/IconController.cpp:

(WebCore::IconController::startLoader): Bail early here if the page is using an ephemeral session.
(WebCore::IconController::continueLoadWithDecision): Instead of here.

4:38 AM Changeset in webkit [181633] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.8/Source/WebKit2

Merge r181555 - Unreviewed. Add new Notification classes to GTK+ API documentation.

Add WebKitNotification and WebKitNotificationPermissionRequest to
the documentation and fix some other typos causing warnings when
generating HTML documentation.

UIProcess/API/gtk/WebKitUserContent.cpp:
UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init):

UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:

4:38 AM Changeset in webkit [181632] by Carlos Garcia Campos

7 edits
26 adds in releases/WebKitGTK/webkit-2.8

Merge r181553 - Add APNG support
https://bugs.webkit.org/show_bug.cgi?id=17022

Patch by Max Stepin <maxstepin@gmail.com> on 2015-03-16
Reviewed by Carlos Garcia Campos.

Source/WebCore:

Test: fast/images/animated-png.html

platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::divide255):
(WebCore::ImageFrame::overRGBA):

platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::frameHeader):
(WebCore::readChunks):
(WebCore::PNGImageReader::PNGImageReader):
(WebCore::PNGImageDecoder::PNGImageDecoder):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::pngComplete):
(WebCore::PNGImageDecoder::readChunks):
(WebCore::PNGImageDecoder::frameHeader):
(WebCore::PNGImageDecoder::init):
(WebCore::PNGImageDecoder::clearFrameBufferCache):
(WebCore::PNGImageDecoder::initFrameBuffer):
(WebCore::PNGImageDecoder::frameComplete):
(WebCore::PNGImageDecoder::processingStart):
(WebCore::PNGImageDecoder::processingFinish):
(WebCore::PNGImageDecoder::fallbackNotAnimated):

platform/image-decoders/png/PNGImageDecoder.h:

(WebCore::PNGImageDecoder::frameCount):
(WebCore::PNGImageDecoder::repetitionCount):
(WebCore::PNGImageDecoder::isComplete):

Source/WTF:

wtf/FeatureDefines.h:

LayoutTests:

fast/images/animated-png-expected.html: Added.
fast/images/animated-png.html: Added.
fast/images/resources/apng00-ref.png: Added.
fast/images/resources/apng00.png: Added.
fast/images/resources/apng01-ref.png: Added.
fast/images/resources/apng01.png: Added.
fast/images/resources/apng02-ref.png: Added.
fast/images/resources/apng02.png: Added.
fast/images/resources/apng04-ref.png: Added.
fast/images/resources/apng04.png: Added.
fast/images/resources/apng08-ref.png: Added.
fast/images/resources/apng08.png: Added.
fast/images/resources/apng10-ref.png: Added.
fast/images/resources/apng10.png: Added.
fast/images/resources/apng11-ref.png: Added.
fast/images/resources/apng11.png: Added.
fast/images/resources/apng12-ref.png: Added.
fast/images/resources/apng12.png: Added.
fast/images/resources/apng14-ref.png: Added.
fast/images/resources/apng14.png: Added.
fast/images/resources/apng18-ref.png: Added.
fast/images/resources/apng18.png: Added.
fast/images/resources/apng24-ref.png: Added.
fast/images/resources/apng24.png: Added.
fast/images/resources/apng26-ref.png: Added.
fast/images/resources/apng26.png: Added.
platform/mac/TestExpectations:

4:10 AM Changeset in webkit [181631] by Carlos Garcia Campos

5 edits in trunk

[GTK] WebKitDOM objects leaking
https://bugs.webkit.org/show_bug.cgi?id=118788

Reviewed by Darin Adler and Sergio Villar Senin.

Source/WebCore:

Use a DOMwindowObserver class, derived from DOMWindowProperty to
be notified when the window object is detached from the frame to
clear the DOM objects associated to that frame in that case too.

bindings/gobject/DOMObjectCache.cpp:

Tools:

Update DOMObjectCache unit test to check that DOM objects are also
released when new contents are loaded in the web view, and the old
document is detached from the frame.

TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:

(testWebKitDOMObjectCache):

TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:

(runTest):

3:04 AM Changeset in webkit [181630] by zandobersek@gmail.com

5 edits in trunk/Source/WebKit2

[WK2] Use C++ lambdas in IPC::Connection
https://bugs.webkit.org/show_bug.cgi?id=138018

Reviewed by Anders Carlsson.

Replace uses of WTF::bind() in the IPC::Connection class with C++ lambdas.

Platform/IPC/Connection.cpp:

(IPC::Connection::dispatchWorkQueueMessageReceiverMessage):
(IPC::Connection::invalidate):
(IPC::Connection::sendMessage):
(IPC::Connection::processIncomingMessage): Simplify the error messages so we
don't have to format strings on-the-fly, removing the issues of cross-thread
string copying altogether.
(IPC::Connection::dispatchDidReceiveInvalidMessage): The parameters are now
of the StringReference type.
(IPC::Connection::enqueueIncomingMessage):

Platform/IPC/Connection.h:
Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::receiveSourceEventHandler):

Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::open):

2:45 AM Changeset in webkit [181629] by zandobersek@gmail.com

7 edits
2 adds in trunk/Source

[CMake] Use a forwarding header for ANGLE's ShaderLang.h to avoid picking up ANGLE's EGL headers
https://bugs.webkit.org/show_bug.cgi?id=142530

Reviewed by Darin Adler.

Source/ThirdParty/ANGLE:

ANGLE/ShaderLang.h: Added. Includes include/GLSLANG/ShaderLang.h. Used in WebCore

so we can avoid using ANGLE's EGL headers and use the system-default headers instead.

Source/WebCore:

CMakeLists.txt:
platform/graphics/ANGLEWebKitBridge.h:
platform/graphics/cairo/GraphicsContext3DCairo.cpp:

Source/WebKit2:

CMakeLists.txt: Replace the Source/ThirdParty/ANGLE/include/GLSLANG entry

in the list of inclusion directories for WebKit2 with Source/ThirdParty/ANGLE,
possible due to the new forwarding header for ANGLE's ShaderLang.h.

2:33 AM Changeset in webkit [181628] by msaboff@apple.com

7 edits in trunk/Source

Windows X86-64 should use the fixed executable allocator
https://bugs.webkit.org/show_bug.cgi?id=142749

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Added jit/ExecutableAllocatorFixedVMPool.cpp to Windows build.

JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
jit/ExecutableAllocatorFixedVMPool.cpp: Don't include unistd.h on Windows.

Source/WTF:

Set ENABLE_EXECUTABLE_ALLOCATOR_FIXED for Windows.
Needed to export MetaAllocator::currentStatistics() for use in JavaScriptCore.

wtf/MetaAllocator.h:
wtf/Platform.h:

2:03 AM Changeset in webkit [181627] by youenn.fablet@crf.canon.fr

2 edits in trunk/Tools

W3C test importer default import folder should be LayoutTests/imported/w3c
https://bugs.webkit.org/show_bug.cgi?id=142728

Reviewed by Bem Jones-Bey.

Scripts/webkitpy/w3c/test_importer.py:

(parse_args): Updating the default destination option value to 'imported/w3c'.

1:43 AM Changeset in webkit [181626] by commit-queue@webkit.org

14 edits
9 adds in trunk/Source/WebInspectorUI

Web Inspector: Show rendering frames (and FPS) in Layout and Rendering timeline
https://bugs.webkit.org/show_bug.cgi?id=142029

Patch by Matt Baker <Matt Baker> on 2015-03-17
Reviewed by Timothy Hatcher.

Add UI for showing runloop records and their child records as a frame histogram,
with the recording time on the x-axis and the frame duration on the y-axis. Each frame
is comprised of colored regions representing the time spent in various activities (script,
layout, etc).

Eventually the Frames timeline will replace the Layout & Rendering timeline. Until the views
for the new timeline are finalized the Layout & Rendering timeline will remain in place.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Main.html:

New string and files.

UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.eventRecorded):
(WebInspector.TimelineManager.prototype.pageDidLoad):
(WebInspector.TimelineManager.prototype._processNestedRecords):
(WebInspector.TimelineManager.prototype._processRecord):
(WebInspector.TimelineManager.prototype._processEvent):
(WebInspector.TimelineManager.prototype._loadNewRecording):
(WebInspector.TimelineManager.prototype.eventRecorded.processRecord): Deleted.
Added support for new runloop record type and nested record handling.

UserInterface/Images/Frames.png: Added.
UserInterface/Images/Frames@2x.png: Added.
UserInterface/Images/FramesLarge.png: Added.
UserInterface/Images/FramesLarge@2x.png: Added.

New images for runloop timeline overview graph and runloop tree records.

UserInterface/Models/RunLoopTimelineRecord.js: Added.

(WebInspector.RunLoopTimelineRecord):
(WebInspector.RunLoopTimelineRecord.prototype.get children):
(WebInspector.RunLoopTimelineRecord.prototype.get durationRemainder):
(WebInspector.RunLoopTimelineRecord.prototype.durationForRecords.get var):
Extends TimelineRecord to add child records and subframe duration details.

UserInterface/Models/Timeline.js:

(WebInspector.Timeline.prototype.get displayName):
(WebInspector.Timeline.prototype.get iconClassName):
New UI strings and icons.

UserInterface/Models/TimelineRecord.js:
UserInterface/Views/ContentView.js:

(WebInspector.ContentView):

UserInterface/Views/LayoutTimelineView.js:

(WebInspector.LayoutTimelineView.prototype._layoutTimelineRecordAdded):

UserInterface/Views/TimelineRecordTreeElement.js:

(WebInspector.TimelineRecordTreeElement):
Added support for new runloop record type.

UserInterface/Views/RunLoopTimelineOverviewGraph.css: Added.

(.timeline-overview-graph.runloop > .divider):
(.timeline-overview-graph.runloop > .divider > span):
New styles for runloop timeline graph.

UserInterface/Views/RunLoopTimelineOverviewGraph.js: Added.

(WebInspector.RunLoopTimelineOverviewGraph):
(WebInspector.RunLoopTimelineOverviewGraph.prototype.updateLayout.createFrame):
(WebInspector.RunLoopTimelineOverviewGraph.prototype.get graphHeightSeconds.this):
(WebInspector.RunLoopTimelineOverviewGraph.prototype.get graphHeightSeconds):
(WebInspector.RunLoopTimelineOverviewGraph.prototype._updateDividers.createDividerAtPosition.get if):
New overview graph for displaying TimelineRecordFrames and horizontal frame budget dividers.

UserInterface/Views/TimelineIcons.css:

(.runloop-icon .icon):
(.runloop-icon.large .icon):
(.runloop-record .icon):

UserInterface/Views/TimelineSidebarPanel.js:

New runloop icon styles.

UserInterface/Views/TimelineOverviewGraph.js:

(WebInspector.TimelineOverviewGraph):
Updated factory to support creation of the new overview graph.

UserInterface/Views/TimelineRecordFrame.css: Added.

(.timeline-record-frame):
(.timeline-record-frame > .frame):
(.timeline-record-frame > .dropped):
(.timeline-record-frame > .frame > .duration):
(.timeline-record-frame > .frame > .duration:first-child):
(.timeline-record-frame > .frame > .duration:last-child):
(.timeline-record-frame > .frame > .duration.timeline-record-type-network):
(.timeline-record-frame > .frame > .duration.timeline-record-type-layout):
(.timeline-record-frame > .frame > .duration.timeline-record-type-script):
New styles for frame bars in the runloop timeline graph.

UserInterface/Views/TimelineRecordFrame.js: Added.

(WebInspector.TimelineRecordFrame):
(WebInspector.TimelineRecordFrame.createCombinedFrames):
(WebInspector.TimelineRecordFrame.prototype.get element):
(WebInspector.TimelineRecordFrame.prototype.get duration):
(WebInspector.TimelineRecordFrame.prototype.get records):
(WebInspector.TimelineRecordFrame.prototype.set records):
(WebInspector.TimelineRecordFrame.prototype._updateChildElements.createDurationElement):
New view representing a single frame within the runloop overview graph.

WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:

New files.

1:41 AM Changeset in webkit [181625] by commit-queue@webkit.org

7 edits in trunk/Source

Web Inspector: Show rendering frames (and FPS) in Layout and Rendering timeline
https://bugs.webkit.org/show_bug.cgi?id=142029

Patch by Matt Baker <Matt Baker> on 2015-03-17
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

inspector/protocol/Timeline.json:

Added new event type for runloop timeline records.

Source/WebCore:

Add new functionality to the Inspector timelines backend to add runloop data to timeline recordings.

inspector/InspectorTimelineAgent.cpp:

(WebCore::currentRunLoop):
(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::internalStop):
(WebCore::toProtocol):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
Install observers for the begining and end of the runloop when recording begins. All other
instrumented timeline events get added as children of the current runloop record, which is
sent to the frontend once the runloop completes.

inspector/InspectorTimelineAgent.h:

platform/cf/RunLoopObserver.cpp:

(WebCore::RunLoopObserver::schedule):
Wrapper changed to allow observing arbitrary runloop activities.

platform/cf/RunLoopObserver.h:

1:39 AM Changeset in webkit [181624] by Philippe Normand

7 edits
1 add in trunk

[GTK] basic OpenWebRTC build support
https://bugs.webkit.org/show_bug.cgi?id=142393

Reviewed by Carlos Garcia Campos.

Source/cmake/FindOpenWebRTC.cmake: Added.
Source/cmake/OptionsGTK.cmake: Look for OpenWebRTC library if

mediastream build is enabled.

Source/WebCore:

PlatformGTK.cmake: Add OpenWebRTC CFLAGS and LDFLAGS.

Tools:

gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This

is not the upstream OpenWebRTC repository. This temporary fork
contains a few patches needed by WebKit for audio/video rendering.

12:58 AM Changeset in webkit [181623] by bshafiei@apple.com

5 edits in tags/Safari-601.1.23.1/Source

Versioning.

12:56 AM Changeset in webkit [181622] by bshafiei@apple.com

1 copy in tags/Safari-601.1.23.1

New tag.

12:55 AM Changeset in webkit [181621] by gyuyoung.kim@samsung.com

7 edits in trunk

[CMake][EFL] Build test tools only for developer mode
https://bugs.webkit.org/show_bug.cgi?id=142761

Reviewed by Csaba Osztrogonác.

Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.

Source/cmake/OptionsEfl.cmake:
Source/cmake/OptionsGTK.cmake: Move ENABLE_MINIBROWSER to common place.
Source/cmake/WebKitFeatures.cmake: Define ENABLE_MINIBROWSER variable.
Source/cmakeconfig.h.cmake:

Tools:

CMakeLists.txt:

12:31 AM Changeset in webkit [181620] by yoon@igalia.com

2 edits in trunk/Source/WebKit2

REGRESSION(r180924): Unable to build WebKitGTK+ with threaded compositor

Unreviewed build fix.

WebProcess/WebPage/LayerTreeHost.h:

Remove duplicated declaration of setNativeSurfaceHandleForCompositing.

12:15 AM Changeset in webkit [181619] by commit-queue@webkit.org

7 edits in trunk

Remove never used "useLayerOnTop" bindings generator argument
https://bugs.webkit.org/show_bug.cgi?id=142773

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-17
Reviewed by Darin Adler.

Source/WebCore:

bindings/scripts/CodeGenerator.pm:
bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/CodeGeneratorObjC.pm:
bindings/scripts/generate-bindings.pl:

Tools:

WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

(new):

Mar 16, 2015:

10:55 PM Changeset in webkit [181618] by rniwa@webkit.org

42 edits in trunk

Enable ES6 classes by default
https://bugs.webkit.org/show_bug.cgi?id=142774

Reviewed by Gavin Barraclough.

Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

Enabled the feature and unskipped tests.

Configurations/FeatureDefines.xcconfig:
tests/stress/class-syntax-no-loop-tdz.js:
tests/stress/class-syntax-no-tdz-in-catch.js:
tests/stress/class-syntax-no-tdz-in-conditional.js:
tests/stress/class-syntax-no-tdz-in-loop-no-inline-super.js:
tests/stress/class-syntax-no-tdz-in-loop.js:
tests/stress/class-syntax-no-tdz.js:
tests/stress/class-syntax-tdz-in-catch.js:
tests/stress/class-syntax-tdz-in-conditional.js:
tests/stress/class-syntax-tdz-in-loop.js:
tests/stress/class-syntax-tdz.js:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/FeatureDefines.h:

Tools:

Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Unskipped tests and also fixed tests so that they can run under run-javascript-tests.

TestExpectations: Unskipped tests.
js/class-syntax-call-expected.txt:
js/class-syntax-declaration-expected.txt:
js/class-syntax-default-constructor-expected.txt:
js/class-syntax-expression-expected.txt:
js/class-syntax-extends-expected.txt:
js/class-syntax-super-expected.txt:
js/dom/reserved-words-as-property-expected.txt: Rebaselined now that "class" is a non-reserved keyword.
js/script-tests/class-syntax-call.js: Don't refer to "window" object as it doesn't exit when ran inside jsc.
js/script-tests/class-syntax-declaration.js: Rebaselined after r181611, which added default constructor support.
js/script-tests/class-syntax-default-constructor.js: Don't refer to "window" object. Also replaced shouldNotBe

by an explicit !== check as the former is not supported when ran inside jsc.

js/script-tests/class-syntax-expression.js: Rebaselined after r181611.
js/script-tests/class-syntax-extends.js: Ditto. Also replaced evalAndLog by shouldNotThrow as the former is not

supported inside jsc.

js/script-tests/class-syntax-super.js: Don't refer to "window" object as it doesn't exist inside jsc.
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.11-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.27-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.5-expected.txt:

10:30 PM Changeset in webkit [181617] by Simon Fraser

4 edits in trunk/Source/WebCore

Update the debug overlays after layout
https://bugs.webkit.org/show_bug.cgi?id=142768

Reviewed by Zalan Bujtas.

The debug overlays need to be updated after layout, in case elements with wheel event handlers
moved around.

DebugPageOverlays::didLayout() is cheap if there are no overlays.

Call DebugPageOverlays::didLayout() for all frames, not just the main frame, since subframes can contribute
to the main frame's event handler region.

page/DebugPageOverlays.cpp:

(WebCore::DebugPageOverlays::regionChanged):

page/DebugPageOverlays.h:

(WebCore::DebugPageOverlays::didLayout):
(WebCore::DebugPageOverlays::didChangeEventHandlers):

page/FrameView.cpp:

(WebCore::FrameView::layout):

10:15 PM Changeset in webkit [181616] by jonlee@apple.com

2 edits in trunk/Source/WebCore

Unreviewed fix for crash after r181608.

WebCore.xcodeproj/project.pbxproj: Include it in the WebCore framework.

9:43 PM Changeset in webkit [181615] by Simon Fraser

6 edits in trunk/Source/WebCore

Generalize the Document code that maintains a set of nodes with event handlers
https://bugs.webkit.org/show_bug.cgi?id=142762

Reviewed by Zalan Bujtas, Darin Adler.

Document.h defines a TouchEventTargetSet type, which will in future be used for
other event types too (wheel events), so rename it to EventTargetSet.

Take didRemoveEventTargetNode() outside the TOUCH_EVENTS #ifdef, and change it
to take a reference.

dom/Document.cpp:

(WebCore::Document::prepareForDestruction): References
(WebCore::Document::didAddTouchEventHandler): Ditto.
(WebCore::Document::didRemoveEventTargetNode): Ditto.

dom/Document.h:

(WebCore::Document::touchEventTargets): No-one calls this; just remove the non

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::~HTMLInputElement): Pass a ref.
(WebCore::HTMLInputElement::didMoveToNewDocument): Pass a ref.

page/DOMWindow.cpp:

(WebCore::DOMWindow::removeAllEventListeners): Pass a ref.

9:41 PM Changeset in webkit [181614] by Joseph Pecoraro

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Add more DOM Native Function parameter strings
https://bugs.webkit.org/show_bug.cgi?id=142760

Reviewed by Timothy Hatcher.

UserInterface/Models/NativeFunctionParameters.js:

Add native parameter strings generated and hand modified
for DOM built-in classes.

UserInterface/Views/ObjectTreePropertyTreeElement.js:

For native constructors "FooConstructor" the description is just
the name of the Constructor not the function string.

9:41 PM Changeset in webkit [181613] by Joseph Pecoraro

7 edits in trunk/Source

Web Inspector: Object Previews in Indexed DB tables
https://bugs.webkit.org/show_bug.cgi?id=140813

Reviewed by Timothy Hatcher.

Source/WebCore:

inspector/InspectorIndexedDBAgent.cpp:

Include previews with object store objects.

Source/WebInspectorUI:

UserInterface/Views/FormattedValue.js:

(WebInspector.FormattedValue.createObjectTreeOrFormattedValueForRemoteObject):
Add a boolean param for ObjectTree construction if it should force allowing object expansion.

UserInterface/Views/IndexedDatabaseEntryDataGridNode.js:

(WebInspector.IndexedDatabaseEntryDataGridNode.prototype.createCellContent):
Switch to creating an ObjectTree or FormattedValue.

UserInterface/Views/IndexedDatabaseObjectStoreContentView.css:

(.content-view.indexed-database-object-store > .data-grid tr.selected):
Change row selection color to match the console's lighter blue instead of dark blue.

(.content-view.indexed-database-object-store > .data-grid .object-tree > :matches(.title, .object-preview)::before):
Adjust object tree disclosure triangle placement for larger line heights.

(.content-view.indexed-database-object-store > .data-grid td .section .header): Deleted.
(.content-view.indexed-database-object-store > .data-grid td .section .header::before): Deleted.
(.content-view.indexed-database-object-store > .data-grid td .section .header .title): Deleted.
(.content-view.indexed-database-object-store > .data-grid:focus tr.selected td .section .header::before): Deleted.
(.content-view.indexed-database-object-store > .data-grid:focus tr.selected td .section.expanded .header::before): Deleted.
(.content-view.indexed-database-object-store > .data-grid:focus tr.selected td .properties-tree li.parent::before): Deleted.
(.content-view.indexed-database-object-store > .data-grid:focus tr.selected td .properties-tree li.parent.expanded::before): Deleted.
(.content-view.indexed-database-object-store > .data-grid:focus tr.selected td .properties-tree li *): Deleted.
Remove now unnecessary styles.

UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:

(.object-tree .object-tree-array-index > .icon):
Increase the specificity to override ".data-grid td .icon" styles.

9:41 PM Changeset in webkit [181612] by Joseph Pecoraro

8 edits in trunk

Web Inspector: Better Console Previews for Arrays / Small Objects
https://bugs.webkit.org/show_bug.cgi?id=142322

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

inspector/InjectedScriptSource.js:

Create deep valuePreviews for simple previewable objects,
such as arrays with 5 values, or basic objects with
3 properties.

Source/WebInspectorUI:

UserInterface/Views/ObjectPreviewView.js:

If there is a sub-preview, show the sub-preview.

UserInterface/Views/ObjectTreeView.js:

(WebInspector.ObjectTreeView):
For an ObjectTree that is not a root (e.g. one inside of
an array/set/map property tree element) allow it to be
expanded even if the preview is lossless.

LayoutTests:

inspector/model/remote-object-expected.txt:
inspector/model/remote-object.html:

Include a test with cyclic values, and update
results which now have sub-previews.

9:02 PM Changeset in webkit [181611] by rniwa@webkit.org

12 edits
3 adds in trunk

Source/JavaScriptCore:
Add support for default constructor
https://bugs.webkit.org/show_bug.cgi?id=142388

Reviewed by Filip Pizlo.

Added the support for default constructors. They're generated by ClassExprNode::emitBytecode
via BuiltinExecutables::createDefaultConstructor.

UnlinkedFunctionExecutable now has the ability to override SourceCode provided by the owner
executable. We can't make store SourceCode in UnlinkedFunctionExecutable since CodeCache can use
the same UnlinkedFunctionExecutable to generate code blocks for multiple functions.

Parser now has the ability to treat any function expression as a constructor of the kind specified
by m_defaultConstructorKind member variable.

builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::createDefaultConstructor): Added.
(JSC::BuiltinExecutables::createExecutableInternal): Generalized from createBuiltinExecutable.
Parse default constructors as normal non-builtin functions. Override SourceCode in the unlinked
function executable since the Miranda function's code is definitely not in the owner executable's
source code. That's the whole point.

builtins/BuiltinExecutables.h:

(UnlinkedFunctionExecutable::createBuiltinExecutable): Added. Wraps createExecutableInternal.

bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
(JSC::UnlinkedFunctionExecutable::linkInsideExecutable):
(JSC::UnlinkedFunctionExecutable::linkGlobalCode):

bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::create):
(JSC::UnlinkedFunctionExecutable::symbolTable): Deleted.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitNewDefaultConstructor): Added.

bytecompiler/BytecodeGenerator.h:
bytecompiler/NodesCodegen.cpp:

(JSC::ClassExprNode::emitBytecode): Generate the default constructor if needed.

parser/Parser.cpp:

(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::parseFunctionInfo): Override ownerClassKind and assume the function as
a constructor if we're parsing a default constructor.
(JSC::Parser<LexerType>::parseClass): Allow omission of the class constructor.

parser/Parser.h:

(JSC::parse):

LayoutTests:
Implement default constructor

Add support for default constructor
https://bugs.webkit.org/show_bug.cgi?id=142388

Reviewed by Filip Pizlo.

Added tests for default constructors.

TestExpectations: Skipped the test since ES6 class syntax isn't enabled by default.
js/class-syntax-default-constructor-expected.txt: Added.
js/class-syntax-default-constructor.html: Added.
js/script-tests/class-syntax-default-constructor.js: Added.

8:56 PM Changeset in webkit [181610] by Nikita Vasilyev

10 edits
2 moves in trunk/Source/WebInspectorUI

Web Inspector: Rename ConsoleMessage and ConsoleMessageImpl to LegacyConsoleMessage and LegacyConsoleMessageImpl respectively
https://bugs.webkit.org/show_bug.cgi?id=142712

As a first step of ConsoleMessage refactoring (https://bugs.webkit.org/show_bug.cgi?id=142599):

Rename WebInspector.ConsoleMessage class to WebInspector.LegacyConsoleMessage
Rename WebInspector.ConsoleMessageImpl class to WebInspector.LegacyConsoleMessageImpl
Rename ConsoleMessage.js file to LegacyConsoleMessage.js
Rename ConsoleMessageImpl file to LegacyConsoleMessageImpl.js

Reviewed by Joseph Pecoraro.

UserInterface/Controllers/JavaScriptLogViewController.js:

(WebInspector.JavaScriptLogViewController.prototype._appendConsoleMessage):

UserInterface/Controllers/LogManager.js:

(WebInspector.LogManager.prototype.messageWasAdded):

UserInterface/Main.html:
UserInterface/Models/DefaultDashboard.js:

(WebInspector.DefaultDashboard.prototype._incrementConsoleMessageType):

UserInterface/Views/ConsoleCommandResult.js:

(WebInspector.ConsoleCommandResult):
(WebInspector.ConsoleCommandResult.prototype.toMessageElement):

UserInterface/Views/ConsoleGroup.js:

(WebInspector.ConsoleGroup.prototype.render):

UserInterface/Views/LegacyConsoleMessage.js: Renamed from Source/WebInspectorUI/UserInterface/Views/ConsoleMessage.js.

(WebInspector.LegacyConsoleMessage):
(WebInspector.LegacyConsoleMessage.prototype.isErrorOrWarning):
(WebInspector.LegacyConsoleMessage.prototype.updateRepeatCount):
(WebInspector.LegacyConsoleMessage.prototype.clone):
(WebInspector.LegacyConsoleMessage.create):

UserInterface/Views/LegacyConsoleMessageImpl.js: Renamed from Source/WebInspectorUI/UserInterface/Views/ConsoleMessageImpl.js.

(WebInspector.LegacyConsoleMessageImpl):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatMessage):
(WebInspector.LegacyConsoleMessageImpl.prototype._shouldDumpStackTrace):
(WebInspector.LegacyConsoleMessageImpl.prototype._shouldHideURL):
(WebInspector.LegacyConsoleMessageImpl.prototype._firstNonNativeCallFrame):
(WebInspector.LegacyConsoleMessageImpl.prototype.get message):
(WebInspector.LegacyConsoleMessageImpl.prototype.get formattedMessage):
(WebInspector.LegacyConsoleMessageImpl.prototype._linkifyLocation):
(WebInspector.LegacyConsoleMessageImpl.prototype._linkifyCallFrame):
(WebInspector.LegacyConsoleMessageImpl.prototype.isErrorOrWarning):
(WebInspector.LegacyConsoleMessageImpl.prototype._format):
(WebInspector.LegacyConsoleMessageImpl.prototype._isExpandable):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameter):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsValue):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsObject):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsString):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsNode):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsArray):
(WebInspector.LegacyConsoleMessageImpl.prototype._rootPropertyPathForObject):
(WebInspector.LegacyConsoleMessageImpl.prototype._userProvidedColumnNames):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsTable):
(WebInspector.LegacyConsoleMessageImpl.prototype.):
(WebInspector.LegacyConsoleMessageImpl.prototype.stringFormatter):
(WebInspector.LegacyConsoleMessageImpl.prototype.floatFormatter):
(WebInspector.LegacyConsoleMessageImpl.prototype.integerFormatter):
(WebInspector.LegacyConsoleMessageImpl.prototype.styleFormatter):
(WebInspector.LegacyConsoleMessageImpl.prototype.isWhitelistedProperty):
(WebInspector.LegacyConsoleMessageImpl.prototype.append):
(WebInspector.LegacyConsoleMessageImpl.prototype._formatWithSubstitutionString):
(WebInspector.LegacyConsoleMessageImpl.prototype.decorateMessageElement):
(WebInspector.LegacyConsoleMessageImpl.prototype.toMessageElement):
(WebInspector.LegacyConsoleMessageImpl.prototype._populateStackTraceTreeElement):
(WebInspector.LegacyConsoleMessageImpl.prototype.updateRepeatCount):
(WebInspector.LegacyConsoleMessageImpl.prototype.toString):
(WebInspector.LegacyConsoleMessageImpl.prototype.get text):
(WebInspector.LegacyConsoleMessageImpl.prototype.isEqual):
(WebInspector.LegacyConsoleMessageImpl.prototype.get stackTrace):
(WebInspector.LegacyConsoleMessageImpl.prototype.clone):
(WebInspector.LegacyConsoleMessageImpl.prototype.get levelString):
(WebInspector.LegacyConsoleMessageImpl.prototype.get clipboardPrefixString):
(WebInspector.LegacyConsoleMessageImpl.prototype.toClipboardString):

UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype.didAppendConsoleMessage):
(WebInspector.LogContentView.prototype._messageAdded):
(WebInspector.LogContentView.prototype._filterMessages):
(WebInspector.LogContentView.prototype._reappendProvisionalMessages):

WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:

8:31 PM Changeset in webkit [181609] by commit-queue@webkit.org

2 edits
1 add in trunk/LayoutTests

[EFL] fast/css/outline-auto-empty-rects.html is failing
https://bugs.webkit.org/show_bug.cgi?id=142570

Unreviewed EFL Gardening. Rebaseline the fast/css/outline-auto-empty-rects.html.

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-03-16

platform/efl/TestExpectations:
platform/efl/fast/css/outline-auto-empty-rects-expected.txt: Added.

8:28 PM Changeset in webkit [181608] by jer.noble@apple.com

7 edits
4 adds in trunk

[Mac] Update missing image UI
https://bugs.webkit.org/show_bug.cgi?id=142592

Reviewed by Darin Adler.

Update the broken image glyphs with new art (including a 3x image).

Test: fast/hidpi/broken-image-icon-very-hidpi.html

Resources/missingImage.png:
Resources/missingImage@2x.png:
Resources/missingImage@3x.png: Added.
WebCore.xcodeproj/project.pbxproj:
loader/cache/CachedImage.cpp:

(WebCore::CachedImage::brokenImage):

7:58 PM Changeset in webkit [181607] by Conrad Shultz

2 edits in trunk/Source/WebKit2

Don't pass nil as a fireDate for NSTimer
https://bugs.webkit.org/show_bug.cgi?id=142765

Reviewed by Dan Bernstein.

While we're here, switch to a selector that conforms to documented NSTimer API.

UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController cancelOperation:]):
Set the timer's fireDate as the future date matching the former interval; update the selector.
(-[WKFullScreenWindowController _watchdogTimerFired:]):
Timer callback; wrap -exitFullScreen.

7:27 PM Changeset in webkit [181606] by gyuyoung.kim@samsung.com

2 edits in trunk/LayoutTests

[EFL] Unreviewed EFL gardening on 17th Mar.

Register new crash, flaky, and timeout tests to EFL TestExpectations files.
Additionally some test related to video, form, accessibility tests are marked as failure.

platform/efl/TestExpectations:

6:47 PM Changeset in webkit [181605] by bshafiei@apple.com

5 edits in branches/safari-600.5-branch/Source

Merged r181587. rdar://problem/20181605

6:04 PM Changeset in webkit [181604] by bshafiei@apple.com

5 edits in branches/safari-600.1.4.15-branch/Source

Versioning.

6:02 PM Changeset in webkit [181603] by bshafiei@apple.com

5 edits in branches/safari-600.5-branch/Source

Versioning.

5:33 PM Changeset in webkit [181602] by dino@apple.com

16 edits
9 adds in trunk

Parsing and Style Resolution of Container-based Animation Triggers
https://bugs.webkit.org/show_bug.cgi?id=142687
<rdar://problem/20170007>

Reviewed by Simon Fraser.

Source/WebCore:

Take 2 after the previous patch was rolled out.

This is the beginning of a prototype implementation of
CSS Animation Triggers, as described by
https://lists.w3.org/Archives/Public/www-style/2014Sep/0135.html

In this patch we parse and resolve the value of a new
CSS property "-webkit-animation-trigger". At the moment it
only accepts one function value "container-scroll", which
will trigger the animation at an absolute position within
an element's scrolling container. We expect the syntax to
change in the near future, as the spec is written.

Tests: animations/trigger-computed-style.html

animations/trigger-parsing.html

WebCore.xcodeproj/project.pbxproj: Add the new files.

css/CSSAnimationTriggerScrollValue.cpp: Added.

(WebCore::CSSAnimationTriggerScrollValue::customCSSText): Output text for computed style.
(WebCore::CSSAnimationTriggerScrollValue::equals): Compare two values.

css/CSSAnimationTriggerScrollValue.h: Added. This holds the CSS side of the

scroll trigger. This name may change in the future to better represent the
type of trigger, but it is good enough for now.
(WebCore::CSSAnimationTriggerScrollValue::create):
(WebCore::CSSAnimationTriggerScrollValue::startValue):
(WebCore::CSSAnimationTriggerScrollValue::endValue):
(WebCore::CSSAnimationTriggerScrollValue::CSSAnimationTriggerScrollValue):

css/CSSComputedStyleDeclaration.cpp:

(WebCore::createAnimationTriggerValue): Maps an AnimationTrigger into a CSSValue.
(WebCore::getAnimationTriggerValue): Gets the current computed style.
(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseAnimationTrigger): Parse the "container-scroll" function
and record the value as a CSSAnimationTriggerScrollValue.
(WebCore::CSSParser::parseAnimationProperty): Handle the new property.

css/CSSParser.h:

css/CSSPropertyNames.in: Add "-webkit-animation-trigger".

css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapAnimationTrigger): Map a CSSValue into a trigger value on
an Animation object.

css/CSSToStyleMap.h:

css/CSSValue.cpp: Handle the new CSSValue type.

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

css/CSSValue.h:

(WebCore::CSSValue::isAnimationTriggerScrollValue):

platform/animation/Animation.cpp: Make sure to initialise m_trigger and m_triggerSet,

and use them in the operator==.

platform/animation/Animation.h: Add AnimationTrigger as a new field.

(WebCore::Animation::isTriggerSet):
(WebCore::Animation::isEmpty):

platform/animation/AnimationTrigger.h: Added. New base class and subclasses for

"auto" and the scrolling trigger.
(WebCore::AnimationTrigger::~AnimationTrigger):
(WebCore::AnimationTrigger::type):
(WebCore::AnimationTrigger::isAutoAnimationTrigger):
(WebCore::AnimationTrigger::isScrollAnimationTrigger):
(WebCore::AnimationTrigger::AnimationTrigger):
(WebCore::AutoAnimationTrigger::create):
(WebCore::AutoAnimationTrigger::~AutoAnimationTrigger):
(WebCore::AutoAnimationTrigger::AutoAnimationTrigger):
(WebCore::ScrollAnimationTrigger::create):
(WebCore::ScrollAnimationTrigger::~ScrollAnimationTrigger):
(WebCore::ScrollAnimationTrigger::startValue):
(WebCore::ScrollAnimationTrigger::setStartValue):
(WebCore::ScrollAnimationTrigger::endValue):
(WebCore::ScrollAnimationTrigger::setEndValue):
(WebCore::ScrollAnimationTrigger::hasEndValue):
(WebCore::ScrollAnimationTrigger::setHasEndValue):
(WebCore::ScrollAnimationTrigger::ScrollAnimationTrigger):

LayoutTests:

Take 2.

New tests that exercise the parser and computed style
of -webkit-animation-trigger.

animations/script-tests/trigger-computed-style.js: Added.

(testComputedTriggerRule):

animations/script-tests/trigger-parsing.js: Added.

(testTriggerRule):

animations/trigger-computed-style-expected.txt: Added.
animations/trigger-computed-style.html: Added.
animations/trigger-parsing-expected.txt: Added.
animations/trigger-parsing.html: Added.

5:29 PM Changeset in webkit [181601] by achristensen@apple.com

8 edits in trunk/Source

Progress towards CMake on Mac
https://bugs.webkit.org/show_bug.cgi?id=142747

Reviewed by Chris Dumez.

Source/JavaScriptCore:

CMakeLists.txt:

Include AugmentableInspectorController.h in CMake build.

Source/WebCore:

CMakeLists.txt:
PlatformMac.cmake:

Added more directories, interfaces, and forwarding headers.
Temporarily disabled the generating of ObjC bindings in CMake builds.

platform/mac/PasteboardMac.mm:

Removed unused include.

Source/WebKit2:

PlatformMac.cmake:

Started adding Mac-specific directories and headers.

5:28 PM WebKitGTK/2.8.x edited by jdiggs@igalia.com

(diff)

5:12 PM Changeset in webkit [181600] by jdiggs@igalia.com

3 edits
2 adds in trunk

AX: Crash viewing http://www.last.fm/
https://bugs.webkit.org/show_bug.cgi?id=142309

Reviewed by Chris Fleizach.

Source/WebCore:

Test: platform/gtk/accessibility/no-notification-for-unrendered-iframe-children.html

accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::attachWrapper):

LayoutTests:

platform/gtk/accessibility/no-notification-for-unrendered-iframe-children-expected.txt: Added.
platform/gtk/accessibility/no-notification-for-unrendered-iframe-children.html: Added.

4:58 PM Changeset in webkit [181599] by ap@apple.com

2 edits in trunk/Source/WebKit2

ASSERT(m_plugin) on plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html
https://bugs.webkit.org/show_bug.cgi?id=142637

Reviewed by Dean Jackson.

WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::pluginSnapshotTimerFired):

m_plugin can be legitimately null.

4:58 PM Changeset in webkit [181598] by ap@apple.com

2 edits in trunk/Tools

Fix webkitpy tests after r181585.

Looks like "me" cannot be anyone's email, it's a special case.

Scripts/webkitpy/common/config/contributors.json:

4:55 PM Changeset in webkit [181597] by commit-queue@webkit.org

12 edits in trunk/Source/WebCore

Unreviewed, rolling out r181492.
https://bugs.webkit.org/show_bug.cgi?id=142756

May have regressed PLT (Requested by anttik on #webkit).

Reverted changeset:

"Cache glyph widths to GlyphPages"
https://bugs.webkit.org/show_bug.cgi?id=142028
http://trac.webkit.org/changeset/181492

4:46 PM Changeset in webkit [181596] by roger_fong@apple.com

8 edits in trunk/Source/WebCore

[WebGL2] Instancing draw calls.
https://bugs.webkit.org/show_bug.cgi?id=126939.
<rdar://problem/15002379>

Reviewed by Dean Jackson.

Tested by a modified version of the 1.0.3 conformance tests:
conformance/extensions/angle-instanced-arrays.html
conformance/extensions/angle-instanced-arrays-out-of-bounds.html

These tests will be landed along with other modified extension conformance tests
once approval from Khronos is received.

html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::clear): Generate error if clearing an integer color buffer.
(WebCore::WebGL2RenderingContext::vertexAttribDivisor): Call method from base class.
(WebCore::WebGL2RenderingContext::drawArraysInstanced): Ditto.
(WebCore::WebGL2RenderingContext::drawElementsInstanced): Ditto.
(WebCore::WebGL2RenderingContext::isIntegerFormat): Ditto.
(WebCore::WebGL2RenderingContext::validateDrawElements): Deleted. Move back to base class.

html/canvas/WebGL2RenderingContext.h:
html/canvas/WebGL2RenderingContext.idl: Add a missing enum.
html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::clear): Copied from WebGLRenderingContextBase.
(WebCore::WebGLRenderingContext::validateDrawElements): Deleted. Move back to base class.

html/canvas/WebGLRenderingContext.h:
html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::clear): Deleted. Moved to WebGLRenderingContext.
(WebCore::WebGLRenderingContextBase::getVertexAttrib): Check for WebGL2 context.
(WebCore::WebGLRenderingContext::validateDrawElements): Ditto.

html/canvas/WebGLRenderingContextBase.h:

4:33 PM Changeset in webkit [181595] by bshafiei@apple.com

1 copy in tags/Safari-600.5.14

New tag.

4:32 PM Changeset in webkit [181594] by bshafiei@apple.com

1 copy in tags/Safari-600.1.4.15.16

New tag.

4:26 PM Changeset in webkit [181593] by commit-queue@webkit.org

15 edits
9 deletes in trunk

Unreviewed, rolling out r181572.
https://bugs.webkit.org/show_bug.cgi?id=142755

Caused weird test failures in transitions and animations
(Requested by dino on #webkit).

Reverted changeset:

"Parsing and Style Resolution of Container-based Animation
Triggers"
https://bugs.webkit.org/show_bug.cgi?id=142687
http://trac.webkit.org/changeset/181572

4:19 PM Changeset in webkit [181592] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, unskip inspector-protocol/dom-debugger/node-removed.html.

It looks like it was an actual failure caused by a patch being
processed by EWS.

TestExpectations:

4:12 PM Changeset in webkit [181591] by yoav@yoav.ws

2 edits in trunk/Source/WebCore

Remove setCachedImage from HTMLImageElement since it is not used
https://bugs.webkit.org/show_bug.cgi?id=142740

Reviewed by Chris Dumez.

No new tests since this patch is just removing dead code.

HTMLImageElement::setCachedImage is not being called by anyone.
This patch removes it, since it's dead code.

html/HTMLImageElement.h:

(WebCore::HTMLImageElement::setCachedImage): Deleted.

4:12 PM Changeset in webkit [181590] by bshafiei@apple.com

2 edits in branches/safari-600.5-branch/Source/WebCore

Merged r181575. rdar://problem/20174803

4:11 PM Changeset in webkit [181589] by roger_fong@apple.com

2 edits in trunk/Source/ThirdParty/ANGLE

[Win] Unreviewed build fix after r181571.

include/GLES2/gl2softlinking.h:

4:11 PM Changeset in webkit [181588] by Nikita Vasilyev

1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json

Unreviewed. Move myself from reviewers to commiters. I was added to reviewers by mistake.

4:01 PM Changeset in webkit [181587] by Brent Fulgham

5 edits in trunk/Source

WebKit1 Clients Are Not Reliably Repainted
https://bugs.webkit.org/show_bug.cgi?id=142750
<rdar://problem/20042453>

Reviewed by Simon Fraser.

Source/WebCore:

page/FrameView.cpp:

(WebCore::FrameView::paintContents): Move "Red Rect" debug painting before
the early return so we can see when this happening in debug builds.

page/FrameView.h:

(WebCore::FrameView::inPaintableState): Added.

Source/WebKit/mac:

Check with the FrameView to see if we are in an immediately paintable state. If we are not,
mark the view as dirty once the _immediateScrollToPoint operation is complete so that the
region will be painted properly.

WebView/WebClipView.mm:

(-[WebClipView _immediateScrollToPoint:]):

3:52 PM Changeset in webkit [181586] by bshafiei@apple.com

2 edits in branches/safari-600.5-branch/Source/WebCore

Merged r181565. rdar://problem/11254910

3:49 PM Changeset in webkit [181585] by Nikita Vasilyev

1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json

Unreviewed. Add myself as a committer.

3:47 PM Changeset in webkit [181584] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

One more URTBF after r181578.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

3:44 PM Changeset in webkit [181583] by ap@apple.com

2 edits in trunk/LayoutTests

inspector-protocol/dom-debugger/node-removed.html crashes on EWS
https://bugs.webkit.org/show_bug.cgi?id=142753

TestExpectations: Skiped it.

3:37 PM Changeset in webkit [181582] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

URTBF after r181578.

WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setCSSAnimationTriggersEnabled): Copy/paste error fixed.

3:25 PM Changeset in webkit [181581] by ap@apple.com

2 edits
1 delete in trunk/LayoutTests

Update results of fast/text/international/bidi-mirror-he-ar.html after <http://trac.webkit.org/changeset/181569>

Yosemite results now match Mavericks. I'm not 100% sure why the results changed
(probably different order of font fallback), but the test clearly still passes.

platform/mac-mavericks/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:

3:21 PM Changeset in webkit [181580] by bshafiei@apple.com

2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged patch for rdar://problem/20155503.

2:52 PM Changeset in webkit [181579] by ap@apple.com

8 edits
1 add in trunk

Add tolerance to WebAudio tests
https://bugs.webkit.org/show_bug.cgi?id=142676

Reviewed by Tim Horton.

Tools:

Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.

Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(TestResultWriter.create_audio_diff_and_write_result):

Scripts/webkitpy/layout_tests/models/test_failures.py:

(FailureAudio.write_failure):

Scripts/webkitpy/port/base.py:

(Port.do_audio_results_differ):
Diff audio failures.

Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing

tests to use real parseable WAV data, and got rid of base64, which there didn't
seem to have been any reason for.

LayoutTests:

fast/harness/results.html: Display a diff link for audio tests, as we now have the diff.

platform/mac/TestExpectations: Unmark tests that should now pass everywhere.

2:24 PM Changeset in webkit [181578] by dino@apple.com

7 edits in trunk/Source/WebKit2

Expose WK2 preference for Animation Triggers runtime flag
https://bugs.webkit.org/show_bug.cgi?id=142744

Reviewed by Anders Carlsson.

Expose CSSAnimationTriggersEnabled, linking it to the runtime enabled
feature flag.

Shared/WebPreferencesDefinitions.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetCSSAnimationTriggersEnabled):
(WKPreferencesGetCSSAnimationTriggersEnabled):

UIProcess/API/C/WKPreferencesRefPrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
(WebKit::InjectedBundle::setCSSAnimationTriggersEnabled):

WebProcess/InjectedBundle/InjectedBundle.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

1:20 PM Changeset in webkit [181577] by Chris Dumez

8 edits
1 copy
2 moves
1 add in trunk

Make DatabaseContext suspendable if there is no pending database activity
https://bugs.webkit.org/show_bug.cgi?id=142716
<rdar://problem/19923085>

Reviewed by Andreas Kling.

Source/WebCore:

Make DatabaseContext suspendable if there is no pending database
activity, i.e:

No pending Database creation JS callback
No pending transaction(s)

Suspending is safe in this case because we are not going to interrupt
any database activity, nor fire any JS event.

This greatly increases the likelihood of pages using websql to enter
the PageCache.

Tests: fast/history/page-cache-webdatabase-no-transaction-db.html

fast/history/page-cache-webdatabase-pending-transaction.html

Modules/webdatabase/Database.cpp:

(WebCore::Database::hasPendingTransaction):

Modules/webdatabase/Database.h:
Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::canSuspend):

Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabase):

Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::hasPendingDatabaseActivity):

Modules/webdatabase/DatabaseThread.h:

LayoutTests:

Add layout tests to check page-cacheability when WebSQL is used,
depending if there is pending database activity or not.

fast/history/page-cache-webdatabase-no-transaction-db-expected.txt: Added.
fast/history/page-cache-webdatabase-no-transaction-db.html: Copied from LayoutTests/fast/history/page-cache-webdatabase-opened-db.html.
fast/history/page-cache-webdatabase-pending-transaction-expected.txt: Renamed from LayoutTests/fast/history/page-cache-webdatabase-opened-db-expected.txt.
fast/history/page-cache-webdatabase-pending-transaction.html: Renamed from LayoutTests/fast/history/page-cache-webdatabase-opened-db.html.

1:06 PM Changeset in webkit [181576] by beidson@apple.com

1 edit in trunk/Source/WebCore/ChangeLog

Fix bug referenced in ChangeLog

1:05 PM Changeset in webkit [181575] by beidson@apple.com

2 edits in trunk/Source/WebCore

Addressing additional review feedback after http://trac.webkit.org/changeset/181565
https://bugs.webkit.org/show_bug.cgi?id=142604

Reviewed by Darin Adler.

loader/icon/IconController.cpp:

(WebCore::IconController::startLoader): Null check page()

12:40 PM Changeset in webkit [181574] by roger_fong@apple.com

2 edits in trunk/Source/WebCore

[Win] Unreviewed build fix attempt after r181571.

WebCore.vcxproj/WebCore.vcxproj:

12:30 PM Changeset in webkit [181573] by roger_fong@apple.com

8 edits in trunk/Source/WebCore

[WebGL2] Multiple Render Targets.
https://bugs.webkit.org/show_bug.cgi?id=126994.
<rdar://problem/15815766>
Reviewed by Dean Jackson.
Tested by a modified version of the 1.0.3 conformance test:
conformance/extensions/webgl-draw-buffers.html
This test will be landed along with other modified extension conformance tests
once approval from Khronos is received.

html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::drawBuffers): Mostly the same as WebGLDrawBuffers::drawBuffersWEBGL.
Returns different error messages, uses non EXT enums.
(WebCore::WebGL2RenderingContext::clearBufferiv): This actually does nothing for now but the validation has been implemented.
(WebCore::WebGL2RenderingContext::clearBufferuiv): Ditto.
(WebCore::WebGL2RenderingContext::clearBufferfv): Ditto.
(WebCore::WebGL2RenderingContext::clearBufferfi): Ditto.
(WebCore::WebGL2RenderingContext::validateFramebufferFuncParameters): Removes the extension object check.
(WebCore::WebGL2RenderingContext::getMaxDrawBuffers):
(WebCore::WebGL2RenderingContext::getMaxColorAttachments): Must return the same thing as getMaxDrawBuffers.
(WebCore::WebGL2RenderingContext::getParameter): Remove extension object checks.

html/canvas/WebGL2RenderingContext.h:
html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::drawBuffersIfNecessary):

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateFramebufferFuncParameters): Copied from WebGLRenderingContextBase.
(WebCore::WebGLRenderingContext::getMaxDrawBuffers): Ditto.
(WebCore::WebGLRenderingContext::getMaxColorAttachments): Ditto.

html/canvas/WebGLRenderingContext.h:
html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::validateFramebufferFuncParameters): Deleted.

html/canvas/WebGLRenderingContextBase.h:

12:08 PM Changeset in webkit [181572] by dino@apple.com

15 edits
9 adds in trunk

Parsing and Style Resolution of Container-based Animation Triggers
https://bugs.webkit.org/show_bug.cgi?id=142687
<rdar://problem/20170007>

Reviewed by Simon Fraser.

Source/WebCore:

This is the beginning of a prototype implementation of
CSS Animation Triggers, as described by
https://lists.w3.org/Archives/Public/www-style/2014Sep/0135.html

Tests: animations/trigger-computed-style.html

animations/trigger-parsing.html

WebCore.xcodeproj/project.pbxproj: Add the new files.

css/CSSAnimationTriggerScrollValue.cpp: Added.

(WebCore::CSSAnimationTriggerScrollValue::customCSSText): Output text for computed style.
(WebCore::CSSAnimationTriggerScrollValue::equals): Compare two values.

css/CSSAnimationTriggerScrollValue.h: Added. This holds the CSS side of the

css/CSSComputedStyleDeclaration.cpp:

css/CSSParser.cpp:

css/CSSParser.h:

css/CSSPropertyNames.in: Add "-webkit-animation-trigger".

css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapAnimationTrigger): Map a CSSValue into a trigger value on
an Animation object.

css/CSSToStyleMap.h:

css/CSSValue.cpp: Handle the new CSSValue type.

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

css/CSSValue.h:

(WebCore::CSSValue::isAnimationTriggerScrollValue):

platform/animation/Animation.h: Add AnimationTrigger as a new field.

(WebCore::Animation::isTriggerSet):
(WebCore::Animation::isEmpty):

platform/animation/AnimationTrigger.h: Added. New base class and subclasses for

LayoutTests:

New tests that exercise the parser and computed style
of -webkit-animation-trigger.

animations/script-tests/trigger-computed-style.js: Added.

(testComputedTriggerRule):

animations/script-tests/trigger-parsing.js: Added.

(testTriggerRule):

animations/trigger-computed-style-expected.txt: Added.
animations/trigger-computed-style.html: Added.
animations/trigger-parsing-expected.txt: Added.
animations/trigger-parsing.html: Added.

12:03 PM Changeset in webkit [181571] by roger_fong@apple.com

21 edits
2 adds in trunk/Source/WebCore

[WebGL2] Vertex Array Objects.
https://bugs.webkit.org/show_bug.cgi?id=126944.
<rdar://problem/15002455>
Reviewed by Dean Jackson.
Tested by a modified version of the 1.0.3 conformance test:
conformance/extensions/oes-vertex-array-object.html
This test will be landed along with other modified extension conformance tests
once approval from Khronos is received.

html/canvas/OESVertexArrayObject.cpp: Associate extension calls only with WebGLRenderingContext.

(WebCore::OESVertexArrayObject::deleteVertexArrayOES):
(WebCore::OESVertexArrayObject::bindVertexArrayOES):

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::initializeVertexArrayObjects):
(WebCore::WebGLRenderingContext::getParameter):

html/canvas/WebGL2RenderingContext.cpp: Implement vertex array object calls as part WebGL2 context.

(WebCore::WebGL2RenderingContext::createVertexArray):
(WebCore::WebGL2RenderingContext::deleteVertexArray):
(WebCore::WebGL2RenderingContext::isVertexArray):
(WebCore::WebGL2RenderingContext::bindVertexArray):
(WebCore::WebGL2RenderingContext::initializeVertexArrayObjects):
(WebCore::WebGL2RenderingContext::getParameter):
Duplicate extension object vertex array object extension methods in GraphicsContext3D.
Implementation may change after we upgrade to newer GL headers and profile.

platform/graphics/GraphicsContext3D.h:
platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::createVertexArray):
(WebCore::GraphicsContext3D::deleteVertexArray):
(WebCore::GraphicsContext3D::isVertexArray):
(WebCore::GraphicsContext3D::bindVertexArray):
Have WebGLVertexArrayObjectOES and WebGLVertexArrayObject inherit from WebGLRenderingContextBase.

CMakeLists.txt:
WebCore.xcodeproj/project.pbxproj:
html/canvas/WebGLVertexArrayObject.cpp:

(WebCore::WebGLVertexArrayObject::create):
(WebCore::WebGLVertexArrayObject::WebGLVertexArrayObject): Use GraphicsContext3D implementation of createVertexArray.
(WebCore::WebGLVertexArrayObject::deleteObjectImpl):

html/canvas/WebGLVertexArrayObject.h:
html/canvas/WebGLVertexArrayObjectBase.cpp: Added.

(WebCore::WebGLVertexArrayObjectBase::WebGLVertexArrayObjectBase):
(WebCore::WebGLVertexArrayObjectBase::setElementArrayBuffer):
(WebCore::WebGLVertexArrayObjectBase::setVertexAttribState):
(WebCore::WebGLVertexArrayObjectBase::unbindBuffer):
(WebCore::WebGLVertexArrayObjectBase::setVertexAttribDivisor):

html/canvas/WebGLVertexArrayObjectBase.h: Added.

(WebCore::WebGLVertexArrayObjectBase::~WebGLVertexArrayObjectBase):
(WebCore::WebGLVertexArrayObjectBase::VertexAttribState::VertexAttribState):
(WebCore::WebGLVertexArrayObjectBase::VertexAttribState::isBound):
(WebCore::WebGLVertexArrayObjectBase::VertexAttribState::validateBinding):
(WebCore::WebGLVertexArrayObjectBase::isDefaultObject):
(WebCore::WebGLVertexArrayObjectBase::hasEverBeenBound):
(WebCore::WebGLVertexArrayObjectBase::setHasEverBeenBound):
(WebCore::WebGLVertexArrayObjectBase::getElementArrayBuffer):
(WebCore::WebGLVertexArrayObjectBase::getVertexAttribState):

html/canvas/WebGLVertexArrayObjectOES.cpp:

(WebCore::WebGLVertexArrayObjectOES::WebGLVertexArrayObjectOES):
(WebCore::WebGLVertexArrayObjectOES::deleteObjectImpl):
(WebCore::WebGLVertexArrayObjectOES::setElementArrayBuffer): Deleted.
(WebCore::WebGLVertexArrayObjectOES::setVertexAttribState): Deleted.
(WebCore::WebGLVertexArrayObjectOES::unbindBuffer): Deleted.
(WebCore::WebGLVertexArrayObjectOES::setVertexAttribDivisor): Deleted.

html/canvas/WebGLVertexArrayObjectOES.h:
html/canvas/WebGLRenderingContextBase.cpp: Use WebGLVertexArrayObjectBase class.

(WebCore::WebGLRenderingContextBase::initializeNewContext):
(WebCore::WebGLRenderingContextBase::disableVertexAttribArray):
(WebCore::WebGLRenderingContextBase::validateVertexAttributes):
(WebCore::WebGLRenderingContextBase::enableVertexAttribArray):
(WebCore::WebGLRenderingContextBase::getVertexAttrib):
(WebCore::WebGLRenderingContextBase::initVertexAttrib0):
(WebCore::WebGLRenderingContextBase::simulateVertexAttrib0):
(WebCore::WebGLRenderingContextBase::restoreStatesAfterVertexAttrib0Simulation):

html/canvas/WebGLRenderingContextBase.h:

(WebCore::WebGLRenderingContextBase::setBoundVertexArrayObject):
Handle construction of WebGLGetInfo using WebGLVertexArrayObject.

bindings/js/JSWebGLRenderingContextBaseCustom.cpp:

(WebCore::toJS):

html/canvas/WebGLGetInfo.cpp:

(WebCore::WebGLGetInfo::WebGLGetInfo):
(WebCore::WebGLGetInfo::getWebGLVertexArrayObjectOES):
(WebCore::WebGLGetInfo::getWebGLVertexArrayObject):

html/canvas/WebGLGetInfo.h:

11:44 AM Changeset in webkit [181570] by Csaba Osztrogonác

8 edits in trunk/Source

[ARM] Enable generating idiv instructions if it is supported
https://bugs.webkit.org/show_bug.cgi?id=142725

Reviewed by Michael Saboff.

Source/JavaScriptCore:

assembler/ARMAssembler.h: Added sdiv and udiv implementation for ARM Traditional instruction set.

(JSC::ARMAssembler::sdiv):
(JSC::ARMAssembler::udiv):

assembler/ARMv7Assembler.h: Use HAVE(ARM_IDIV_INSTRUCTIONS) instead of CPU(APPLE_ARMV7S).
assembler/AbstractMacroAssembler.h:

(JSC::isARMv7IDIVSupported):
(JSC::optimizeForARMv7IDIVSupported):
(JSC::isARMv7s): Renamed to isARMv7IDIVSupported().
(JSC::optimizeForARMv7s): Renamed to optimizeForARMv7IDIVSupported().

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithDiv):
(JSC::DFG::SpeculativeJIT::compileArithMod):

Source/WTF:

wtf/Platform.h: Set HAVE_ARM_IDIV_INSTRUCTIONS based on GCC macro too.

11:30 AM Changeset in webkit [181569] by ap@apple.com

4 edits
1 delete in trunk

[Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
https://bugs.webkit.org/show_bug.cgi?id=142720

Reviewed by Myles C. Maxfield.

Tools:

Activate system copies of Microsoft fonts for the current process, thus overriding
any other ones that could be preferred by the system otherwise.

DumpRenderTree/mac/DumpRenderTree.mm:

(activateSystemCoreWebFonts):
(adjustFonts):

WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:

(WTR::activateSystemCoreWebFonts):
(WTR::activateFonts):

LayoutTests:

platform/mac-mavericks/fast/forms/text-control-intrinsic-widths-expected.txt: Removed.

Mavericks result is no different from Yosemite.

11:23 AM Changeset in webkit [181568] by Brent Fulgham

2 edits in trunk/Source/WebCore

Potentially uninitialized Inspector values
https://bugs.webkit.org/show_bug.cgi?id=142730

Reviewed by Joseph Pecoraro.

inspector/InspectorDOMAgent.cpp:

(WebCore::parseColor): Make sure color values are given an initial value.

11:11 AM Changeset in webkit [181567] by commit-queue@webkit.org

10 edits
2 moves in trunk/Source/WebInspectorUI

Unreviewed, rolling out r181517.
https://bugs.webkit.org/show_bug.cgi?id=142718

This patch broke GTK+ build (Requested by NVI on #webkit).

Reverted changeset:

"Web Inspector: Rename ConsoleMessage and ConsoleMessageImpl
to LegacyConsoleMessage and LegacyConsoleMessageImpl
respectively"
https://bugs.webkit.org/show_bug.cgi?id=142712
http://trac.webkit.org/changeset/181517

10:55 AM Changeset in webkit [181566] by Brent Fulgham

2 edits in trunk/LayoutTests

[Win] Document more debug assertions.

platform/win/TestExpectations:

10:52 AM Changeset in webkit [181565] by beidson@apple.com

2 edits in trunk/Source/WebCore

URLs visited during private browsing show up in WebpageIcons.db
rdar://problem/11254910 and https://bugs.webkit.org/show_bug.cgi?id=142733

Patch by Sam Weinig. Reviewed by Brady Eidson.

loader/icon/IconController.cpp:

(WebCore::IconController::startLoader): Bail early here if the page is using an ephemeral session.
(WebCore::IconController::continueLoadWithDecision): Instead of here.

10:42 AM Changeset in webkit [181564] by Brent Fulgham

2 edits in trunk/LayoutTests

[Win] APNG is not supported on Windows (but it IS supported on WinCairo)

platform/win/TestExpectations:

10:39 AM Changeset in webkit [181563] by fpizlo@apple.com

2 edits
4 adds in trunk/Source/JavaScriptCore

DFG::PutStackSinkingPhase should eliminate GetStacks that have an obviously known source, and emit GetStacks when the stack's value is needed and none is deferred
https://bugs.webkit.org/show_bug.cgi?id=141624

Reviewed by Geoffrey Garen.

Not eliminating GetStacks was an obvious omission from the original PutStackSinkingPhase.
Previously, we would treat GetStacks conservatively and assume that the stack slot
escaped. That's pretty dumb, since a GetStack is a local load of the stack. This change
makes GetStack a no-op from the standpoint of this phase's deferral analysis. At the end
we either keep the GetStack (if there was no concrete deferral) or we replace it with an
identity over the value that would have been stored by the deferred PutStack. Note that
this might be a Phi that the phase creates, so this is strictly stronger than what GCSE
could do.

But this change revealed the fact that this phase never correctly handled side effects in
case that we had done a GetStack, then a side-effect, and then found ourselves wanting the
value on the stack due to (for example) a Phi on a deferred PutStack and that GetStack.
Basically, it's only correct to use the SSA converter's incoming value mapping if we have
a concrete deferral - since anything but a concrete deferral may imply that the value has
been clobbered.

This has no performance change. I believe that the bug was previously benign because we
have so few operations that clobber the stack anymore, and most of those get used in a
very idiomatic way. The GetStack elimination will be very useful for the varargs
simplification that is part of bug 141174.

This includes a test for the case that Speedometer hit, plus tests for the other cases I
thought of once I realized the deeper issue.

dfg/DFGPutStackSinkingPhase.cpp:
tests/stress/get-stack-identity-due-to-sinking.js: Added.

(foo):
(bar):

tests/stress/get-stack-mapping-with-dead-get-stack.js: Added.

(bar):
(foo):

tests/stress/get-stack-mapping.js: Added.

(bar):
(foo):

tests/stress/weird-put-stack-varargs.js: Added.

(baz):
(foo):
(fuzz):
(bar):

10:13 AM Changeset in webkit [181562] by Conrad Shultz

44 edits in trunk/Source

Allow clients to selectively disable plug-ins
https://bugs.webkit.org/show_bug.cgi?id=142506

Reviewed by Anders Carlsson.

Source/WebCore:

Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
from the page). As part of this:

1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying

set of plug-ins.

2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper

down the stack.

3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce

a concrete implementation thereof in WebPlatformStrategies in WebKit2.

4) Add messaging infrastructure to allow clients to set and clear plug-in policies.

While currently only used in a very limited manner, the new declarative plug-in policies are written generically
so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.

dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):
Update to reflect function rename.

loader/SubframeLoader.cpp:

(WebCore::findPluginMIMETypeFromURL):
Adopt getWebVisibleMimesAndPluginIndices().
(WebCore::logPluginRequest):
Update to reflect function rename.
(WebCore::SubframeLoader::shouldUsePlugin):
Ditto.

platform/PlatformStrategies.h:

Export platformStrategies(), since it is now used in WebProcess.cpp.

plugins/DOMMimeType.cpp:

(WebCore::DOMMimeType::type):
(WebCore::DOMMimeType::description):
(WebCore::DOMMimeType::mimeClassInfo):
Adopt getWebVisibleMimesAndPluginIndices().
(WebCore::DOMMimeType::enabledPlugin):
Ditto.

plugins/DOMMimeType.h:

Don't return references in a few places where it is no longer safe to do so.
(WebCore::DOMMimeType::mimeClassInfo): Deleted.

plugins/DOMMimeTypeArray.cpp:

(WebCore::DOMMimeTypeArray::length):
Adopt getWebVisibleMimesAndPluginIndices().
(WebCore::DOMMimeTypeArray::item):
Ditto.
(WebCore::DOMMimeTypeArray::canGetItemsForName):
Ditto.
(WebCore::DOMMimeTypeArray::namedItem):
Ditto.

plugins/DOMPlugin.cpp:

(WebCore::DOMPlugin::pluginInfo):
Adopt getWebVisiblePlugins().
(WebCore::DOMPlugin::item):
Adopt getWebVisibleMimesAndPluginIndices().
(WebCore::DOMPlugin::canGetItemsForName):
Ditto.
(WebCore::DOMPlugin::namedItem):
Ditto.

plugins/DOMPlugin.h:

(WebCore::DOMPlugin::pluginInfo): Deleted.

plugins/DOMPluginArray.cpp:

(WebCore::DOMPluginArray::length):
Adopt getWebVisiblePlugins().
(WebCore::DOMPluginArray::item):
Ditto.
(WebCore::DOMPluginArray::canGetItemsForName):
Ditto.
(WebCore::DOMPluginArray::namedItem):
Ditto.

plugins/PluginData.cpp:

(WebCore::PluginData::PluginData):
Stash the passed-in Page and call initPlugins().
(WebCore::PluginData::getWebVisiblePlugins):
New member function; call through to PluginStrategy::getWebVisiblePluginInfo().
(WebCore::PluginData::getWebVisibleMimesAndPluginIndices):
New member function; build up the mimes and mimePluginIndices vectors in the same manner as before, but
limited to the web-visible plug-ins.
(WebCore::PluginData::supportsWebVisibleMimeType):
Renamed from supportsMimeType(); update to work in terms of web-visible plug-ins.
(WebCore::PluginData::pluginInfoForWebVisibleMimeType):
Renamed from pluginInfoForMimeType(); ditto.
(WebCore::PluginData::pluginNameForWebVisibleMimeType):
Renamed from pluginNameForMimeType(); ditto.
(WebCore::PluginData::pluginFileForWebVisibleMimeType):
Renamed from pluginFileForMimeType(); ditto.
(WebCore::PluginData::initPlugins):
(WebCore::PluginData::supportsMimeType): Deleted.
(WebCore::PluginData::pluginInfoForMimeType): Deleted.
(WebCore::PluginData::pluginNameForMimeType): Deleted.
(WebCore::PluginData::pluginFileForMimeType): Deleted.

plugins/PluginData.h:

Add a member variable for the associate Page; declare the PluginLoadClientPolicy enumeration; add
new members to PluginInfo for the clientLoadPolicy and bundle information.
(WebCore::PluginData::PluginData):
Replace some member functions with new ones that will hide plug-ins upon request from the client;
(WebCore::PluginData::mimes): Deleted.
(WebCore::PluginData::mimePluginIndices): Deleted.

plugins/PluginStrategy.h:

Declare new member functions for retrieving web-visible plug-ins and setting/clearing plug-in policies.

replay/SerializationMethods.cpp:

(JSC::EncodingTraits<PluginData>::encodeValue):
Remove now-obsolete code for handling MIME types and add a FIXME.
(JSC::DeserializedPluginData::DeserializedPluginData):
(JSC::EncodingTraits<PluginData>::decodeValue):
Ditto.
(JSC::EncodingTraits<PluginInfo>::encodeValue):
Handle the new members in PluginInfo.
(JSC::EncodingTraits<PluginInfo>::decodeValue):
Ditto.

replay/WebInputs.json:

Teach Replay about PluginLoadClientPolicy.

Source/WebKit/mac:

Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
from the page). As part of this:

1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying

set of plug-ins.

2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper

down the stack.

3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce

a concrete implementation thereof in WebPlatformStrategies in WebKit2.

4) Add messaging infrastructure to allow clients to set and clear plug-in policies.

Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage getPluginInfoFromPLists]):
Set new members in PluginInfo.

Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage getPluginInfoFromResources]):
Set new members in PluginInfo.

WebCoreSupport/WebPlatformStrategies.h:
WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::getWebVisiblePluginInfo):
Override to wrap getPluginInfo().
(WebPlatformStrategies::setPluginLoadClientPolicy):
Override to do nothing.
(WebPlatformStrategies::clearPluginClientPolicies):
Ditto.

WebView/WebFrame.mm:

(-[WebFrame _canProvideDocumentSource]):
Update to reflect function rename.

Source/WebKit/win:

WebCoreSupport/WebPlatformStrategies.h:
WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::getWebVisiblePluginInfo):
Wrap getPluginInfo();

WebView.cpp:

(WebView::canShowMIMEType):
Update to reflect function rename.

Source/WebKit2:

Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
from the page). As part of this:

1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying

set of plug-ins.

2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper

down the stack.

3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce

a concrete implementation thereof in WebPlatformStrategies in WebKit2.

4) Add messaging infrastructure to allow clients to set and clear plug-in policies.

Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::NetscapePluginModule::getPluginInfo):
Set new PluginInfo members.

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<PluginInfo>::encode):
Handle new PluginInfo members.
(IPC::ArgumentCoder<PluginInfo>::decode):
Ditto.

Shared/WebProcessCreationParameters.h:

Declare a member to store client plug-in policies.

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
Encode the policies.
(WebKit::WebProcessCreationParameters::decode):
Decode the policies.

UIProcess/API/C/WKAPICast.h:

(WebKit::toWKPluginLoadClientPolicy):
Teach how to cast between WebCore and WebKit2 policy definitions.
(WebKit::toPluginLoadClientPolicy):
Ditto.

UIProcess/API/C/WKPluginLoadPolicy.h:

Declare WKPluginLoadClientPolicy, matching PluginLoadClientPolicy in WebCore.

UIProcess/API/C/mac/WKContextPrivateMac.h:
UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextSetPluginLoadClientPolicy):
New function; wrap WebProcessPool::setPluginLoadClientPolicy().
(WKContextClearPluginClientPolicies):
New function; wrap WebProcessPool::clearPluginClientPolicies().

UIProcess/WebProcessPool.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createNewWebProcess):
Copy any client plug-in policies to the new process' creation parameters.
(WebKit::WebProcessPool::setPluginLoadClientPolicy):
Send SetPluginLoadClientPolicy to all processes and stash the passed-in policy info.
(WebKit::WebProcessPool::clearPluginClientPolicies):
Send ClearPluginClientPolicies to all processes and clear any stashed policy info.

WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::pluginInfo):
Set new PluginInfo member.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::pluginSupportsExtension):
Adopt getWebVisibleMimesAndPluginIndices().
(WebKit::WebFrameLoaderClient::objectContentType):
Update to reflect reflect function rename.

WebProcess/WebCoreSupport/WebPlatformStrategies.h:
WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::getPluginInfo):
Pass the Page to populatePluginCache().
(WebKit::WebPlatformStrategies::getWebVisiblePluginInfo):
New member function; wrap getPluginInfo(); if appropriate, filter out plug-ins the client has asked
to block on the current page.
(WebKit::WebPlatformStrategies::setPluginLoadClientPolicy):
New member function; map empty inputs to a wildcard character and insert the new policy into the nested map.
(WebKit::WebPlatformStrategies::clearPluginClientPolicies):
New member function; empty m_hostsToPluginIdentifierData.
(WebKit::WebPlatformStrategies::pluginLoadClientPolicyForHost):
New member function; look up the most specific policy for the given plug-in and host.
(WebKit::WebPlatformStrategies::populatePluginCache):
If appropriate, set the client load policy on the plug-ins; do this irrespective of whether the cache has
been populated since the Page, and therefore host, may change.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::canShowMIMEType):
Update to reflect function rename.

WebProcess/WebProcess.h:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
Enumerate and process the client plug-in policies in the creation parameters.
(WebKit::WebProcess::setPluginLoadClientPolicy):
New member function; wrap PluginStrategy::setPluginLoadClientPolicy.
(WebKit::WebProcess::clearPluginClientPolicies):
New member function; wrap PluginStrategy::clearPluginClientPolicies().

WebProcess/WebProcess.messages.in:

Add messages for setting and clearing policies.

9:52 AM WebKitW3CTesting edited by youenn.fablet@crf.canon.fr

(diff)

9:51 AM Changeset in webkit [181561] by bshafiei@apple.com

1 copy in tags/Safari-601.1.23

New tag.

9:50 AM WebKitW3CTesting created by youenn.fablet@crf.canon.fr

9:49 AM Changeset in webkit [181560] by bshafiei@apple.com

5 edits in trunk/Source

Versioning.

9:47 AM Changeset in webkit [181559] by Chris Dumez

2 edits in trunk/LayoutTests

Mark fast/images/animated-png.html as [ Crash ImageOnlyFailure ]

It seems to fail instead of crash on Yosemite WK1.

platform/mac/TestExpectations:

9:45 AM March 2015 Meeting edited by youenn.fablet@crf.canon.fr

(diff)

9:44 AM Streams API 03132015.pptx attached to March 2015 Meeting by youenn.fablet@crf.canon.fr

Status of Streams API implementation into WebKit

9:42 AM March 2015 Meeting edited by youenn.fablet@crf.canon.fr

(diff)

9:32 AM Changeset in webkit [181558] by benjamin@webkit.org

3 edits in trunk/Source/WTF

Fix StringView after r181525
Unreviewed.

Fix 2 silly mistakes I made in r181525.

wtf/text/StringView.cpp:

(WTF::StringView::startsWith):
(WTF::StringView::startsWithIgnoringASCIICase):
(WTF::StringView::endsWith):
(WTF::StringView::endsWithIgnoringASCIICase):
The implementation was inside the #ifdef.

wtf/text/StringView.h:

The symbols were not exported.

9:32 AM Changeset in webkit [181557] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, mark fast/images/animated-png.html as crashing

Mark fast/images/animated-png.html as crashing on Yosemite. This test
was introduced in r181553.

platform/mac/TestExpectations:

8:45 AM Changeset in webkit [181556] by commit-queue@webkit.org

7 edits in trunk

Update Map/Set to treat -0 and 0 as the same value
https://bugs.webkit.org/show_bug.cgi?id=142709

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-16
Reviewed by Csaba Osztrogonác.

Source/JavaScriptCore:

runtime/MapData.h:

(JSC::MapDataImpl<Entry>::KeyType::KeyType):
No longer special case -0. It will be treated as the same as 0.

LayoutTests:

js/basic-map-expected.txt:
js/basic-set-expected.txt:
js/script-tests/basic-map.js:
js/script-tests/basic-set.js:

Update tests now that -0 and 0 are treated the same.

7:58 AM Changeset in webkit [181555] by Carlos Garcia Campos

4 edits in trunk/Source/WebKit2

Unreviewed. Add new Notification classes to GTK+ API documentation.

Add WebKitNotification and WebKitNotificationPermissionRequest to
the documentation and fix some other typos causing warnings when
generating HTML documentation.

UIProcess/API/gtk/WebKitUserContent.cpp:
UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init):

UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:

7:32 AM Changeset in webkit [181554] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL][WK2] REGRESSION(r178526): test_ewk2_storage_manager has been failed for a long time
https://bugs.webkit.org/show_bug.cgi?id=141249

Patch by Przemyslaw Piorkowski <p.piorkowski@samsung.com> on 2015-03-16
Reviewed by Gyuyoung Kim.

PlatformEfl.cmake: Enable test_ewk2_storage_manager for EFL port - it is passing now.

7:29 AM WebKitGTK/2.8.x edited by Carlos Garcia Campos

(diff)

7:24 AM Changeset in webkit [181553] by commit-queue@webkit.org

8 edits
26 adds in trunk

Add APNG support
https://bugs.webkit.org/show_bug.cgi?id=17022

Patch by Max Stepin <maxstepin@gmail.com> on 2015-03-16
Reviewed by Carlos Garcia Campos.

Source/WebCore:

Test: fast/images/animated-png.html

platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::divide255):
(WebCore::ImageFrame::overRGBA):

platform/image-decoders/png/PNGImageDecoder.cpp:

platform/image-decoders/png/PNGImageDecoder.h:

(WebCore::PNGImageDecoder::frameCount):
(WebCore::PNGImageDecoder::repetitionCount):
(WebCore::PNGImageDecoder::isComplete):

Source/WTF:

wtf/FeatureDefines.h:

LayoutTests:

fast/images/animated-png-expected.html: Added.
fast/images/animated-png.html: Added.
fast/images/resources/apng00-ref.png: Added.
fast/images/resources/apng00.png: Added.
fast/images/resources/apng01-ref.png: Added.
fast/images/resources/apng01.png: Added.
fast/images/resources/apng02-ref.png: Added.
fast/images/resources/apng02.png: Added.
fast/images/resources/apng04-ref.png: Added.
fast/images/resources/apng04.png: Added.
fast/images/resources/apng08-ref.png: Added.
fast/images/resources/apng08.png: Added.
fast/images/resources/apng10-ref.png: Added.
fast/images/resources/apng10.png: Added.
fast/images/resources/apng11-ref.png: Added.
fast/images/resources/apng11.png: Added.
fast/images/resources/apng12-ref.png: Added.
fast/images/resources/apng12.png: Added.
fast/images/resources/apng14-ref.png: Added.
fast/images/resources/apng14.png: Added.
fast/images/resources/apng18-ref.png: Added.
fast/images/resources/apng18.png: Added.
fast/images/resources/apng24-ref.png: Added.
fast/images/resources/apng24.png: Added.
fast/images/resources/apng26-ref.png: Added.
fast/images/resources/apng26.png: Added.
platform/mac/TestExpectations:

5:30 AM Changeset in webkit [181552] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r181513 - Remove a redundant repaint when a layer becomes composited
https://bugs.webkit.org/show_bug.cgi?id=142711

Reviewed by Anders Carlsson.

RenderLayerCompositor::computeCompositingRequirements() doesn't need to call
repaintOnCompositingChange() when a layer is going to become composited,
because updateBacking() does exactly the same thing. I used an assertion
and ran the tests to ensure this wasn't a behavior change.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):

5:28 AM Changeset in webkit [181551] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r181500 - RenderBlock::imageChange() calling const methods on exit
https://bugs.webkit.org/show_bug.cgi?id=142648

Reviewed by Brent Fulgham.

No new tests, no change on behavior.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::imageChanged): Deleted.

rendering/RenderBlock.h:

5:24 AM Changeset in webkit [181550] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore

Merge r181495 - Object allocation sinking phase shouldn't re-decorate previously sunken allocations on each fixpoint operation
https://bugs.webkit.org/show_bug.cgi?id=142686

Reviewed by Oliver Hunt.

Just because promoteHeapAccess() notifies us of an effect to a heap location in a node doesn't
mean that we should handle it as if it was for one of our sinking candidates. Instead we should
prune based on m_sinkCandidates.

This fixes a benign bug where we would generate a lot of repeated IR for some pathological
tests.

dfg/DFGObjectAllocationSinkingPhase.cpp:

(JSC::DFG::ObjectAllocationSinkingPhase::promoteSunkenFields):

5:20 AM Changeset in webkit [181549] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore

Merge r181486 - Prohibit GC while sweeping
https://bugs.webkit.org/show_bug.cgi?id=142638

Reviewed by Andreas Kling.

I noticed in https://bugs.webkit.org/show_bug.cgi?id=142636 that a GC
could trigger a sweep which could trigger another GC. Yo Dawg.

I tried to figure out whether this could cause problems or not and it
made me cross-eyed.

(Some clients like to report extra memory cost during deallocation as a
way to indicate that the GC now owns something exclusively. It's
arguably a bug to communicate with the GC in this way, but we shouldn't
do crazy when this happens.)

This patch makes explicit the fact that we don't allow GC while sweeping.

Usually, sweeping implicitly defers GC by virtue of happening during
allocation. But not always.

heap/Heap.cpp:

(JSC::Heap::collectAllGarbage): Defer GC while sweeping due to an
explicit GC request.

(JSC::Heap::didFinishCollection): Make sure that zombifying sweep
defers GC by not returning to the non-GC state until we're all done.

heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::sweepNextBlock): Defer GC while sweeping due
to a timer.

5:15 AM Changeset in webkit [181548] by ddkilzer@apple.com

2 edits in trunk/Source/WebKit2

[iOS] REGRESSION (r181511): Most layout tests crash with a NULL deref

Follow-up fix for:
[iOS] Presenting a modal sheet on top of a WKWebView causes it to lose focused, active state
<http://webkit.org/b/142702>

UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::isViewWindowActive): Add NULL check for m_webView.
(WebKit::PageClientImpl::isViewFocused): Ditto.

5:14 AM Changeset in webkit [181547] by Carlos Garcia Campos

7 edits in releases/WebKitGTK/webkit-2.8/Source

Merge r181481 - Introduce WTF::Atomic to wrap std::atomic for a friendlier CAS.
<https://webkit.org/b/142661>

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Changed CodeBlock, and the DFG's crashLock to use WTF::Atomic instead of
std::atomic.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::visitAggregate):

bytecode/CodeBlock.h:
dfg/DFGCommon.cpp:

(JSC::DFG::startCrashing):

Source/WTF:

The CAS functions provided by std::atomic takes a reference to the expected
value and modifies it if the CAS fails. However, in a lot of our CAS usage,
we don't want the expected value to change. The solution to this is to
provide a WTF::Atomic struct that wraps std::atomic, and provide CAS
methods that won't alter the expected value if the CAS fails.

The method names in WTF::Atomic are chosen to be identical to those
in std::atomic so that WTF::Atomic can be a simple drop in replacement
for std::atomic.

Also changed ByteSpinLock to use WTF::Atomic instead of std::atomic.

wtf/Atomics.h:

(WTF::Atomic::load):
(WTF::Atomic::store):
(WTF::Atomic::compare_exchange_weak):
(WTF::Atomic::compare_exchange_strong):

wtf/ByteSpinLock.h:

(WTF::ByteSpinLock::ByteSpinLock):
(WTF::ByteSpinLock::lock):

4:48 AM Changeset in webkit [181546] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r181475 - Fix Debug build error 'comparison is always true due to limited range of data type [-Werror=type-limits]'
https://bugs.webkit.org/show_bug.cgi?id=142652

Patch by Joonghun Park <jh718.park@samsung.com> on 2015-03-13
Reviewed by Csaba Osztrogonác.

No new tests, no behavior changes.

Now CSSPropertyID type is uint16_t, so propertyID >= 0 check is needed no more.

css/CSSPrimitiveValue.cpp:

(WebCore::propertyName):

css/makeprop.pl:

4:47 AM Changeset in webkit [181545] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore

Merge r181469 - Change the DFG crashLock to use std::atomic.
<https://webkit.org/b/142649>

Reviewed by Filip Pizlo.

dfg/DFGCommon.cpp:

(JSC::DFG::startCrashing):
(JSC::DFG::isCrashing):

4:45 AM Changeset in webkit [181544] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/WTF

Merge r181462 - Disable Yarr JIT for ARMv7k
https://bugs.webkit.org/show_bug.cgi?id=142645

Reviewed by Oliver Hunt.

Make the setting of ENABLE_YARR_JIT match ENABLE_JIT for ARMv7k.

wtf/Platform.h:

4:42 AM Changeset in webkit [181543] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/WTF

Merge r181461 - Change WTF::ByteSpinLock to use std::atomic.
<https://webkit.org/b/142644>

Reviewed by Filip Pizlo.

wtf/ByteSpinLock.h:

(WTF::ByteSpinLock::ByteSpinLock):
(WTF::ByteSpinLock::lock):
(WTF::ByteSpinLock::unlock):
(WTF::ByteSpinLock::isHeld):

4:22 AM Changeset in webkit [181542] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/bmalloc

Merge r181457 - Assertion failure in bmalloc::LargeObject::validateSelf on Mavericks Debug layout test bot
https://bugs.webkit.org/show_bug.cgi?id=142642

Reviewed by Michael Saboff.

The typical backtrace to this crash shows the main thread trying to
realloc a large string while a DFG compiler thread tries to
free a large vector buffer.

I believe that this is a race condition -- at least in debug builds --
since the main thread will try to validate its object's neighbors
without holding a lock, even though those neighbors might be in the
midst of changing.

In general, there may be sneaky times when it is valid to look at an
object's metadata without holding the heap lock, but it is best not to
do so unless we have a really really good reason to.

bmalloc/Allocator.cpp:

(bmalloc::Allocator::reallocate): Take a lock before reading the metadata
for this object, since we generally require any access to shared heap
metadata to take a lock.

4:21 AM Changeset in webkit [181541] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore

Merge r181456 - Use std::atomic for CodeBlock::m_visitAggregateHasBeenCalled.
<https://webkit.org/b/142640>

Reviewed by Mark Hahnenberg.

We used to spin our own compare and swap on a uint8_t. Now that we can
use C++11, let's use std::atomic instead.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

The CAS here needs std::memory_order_acquire ordering because it requires lock acquisition semantics to visit the CodeBlock.

bytecode/CodeBlock.h:

(JSC::CodeBlockSet::mark):

heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::clearMarksForFullCollection):
(JSC::CodeBlockSet::clearMarksForEdenCollection):

These can go with relaxed ordering because they are all done before the GC starts parallel marking.

4:13 AM Changeset in webkit [181540] by Carlos Garcia Campos

8 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r181449 - Stop using single-include headers that are only available since GStreamer >= 1.2.

https://bugs.webkit.org/show_bug.cgi?id=142537

Patch by Sebastian Dröge <sebastian@centricular.com> on 2015-03-12
Reviewed by Philippe Normand.

platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:
platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
platform/graphics/gstreamer/GStreamerUtilities.cpp:
platform/graphics/gstreamer/GStreamerUtilities.h:
platform/graphics/gstreamer/ImageGStreamer.h:

Instead of using single-include headers for the GStreamer libraries,
directly include the headers we need. The single-include headers were
only added in 1.2, and this would be the only reason why we would
depend on 1.2.

3:43 AM Changeset in webkit [181539] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/WTF

Merge r181436 - [ARM][Linux] GC sometimes stuck in an infinite loop if parallel GC is enabled
https://bugs.webkit.org/show_bug.cgi?id=141290

Reviewed by Carlos Garcia Campos.

wtf/Platform.h: Enable parallel GC after r181319.

3:42 AM Changeset in webkit [181538] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore

Merge r181435 - [cmake] Fix the incremental build issue revealed by r181419
https://bugs.webkit.org/show_bug.cgi?id=142613

Reviewed by Carlos Garcia Campos.

CMakeLists.txt:

3:41 AM Changeset in webkit [181537] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Users of Heap::deprecatedReportExtraMemory should switch to reportExtraMemoryAllocated+reportExtraMemoryVisited
https://bugs.webkit.org/show_bug.cgi?id=142595

Reviewed by Andreas Kling.

Fixed this bug for canvas.

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::memoryCost): Factored out the helper function
required by our IDL generator.

(WebCore::HTMLCanvasElement::createImageBuffer): Use
reportExtraMemoryAllocated.

html/HTMLCanvasElement.h:

html/HTMLCanvasElement.idl: Adopt the IDL for reporting cost in the

right way during GC. This will match our reportExtraMemoryAllocated
with a reportExtraMemoryVisited during GC.

3:30 AM Changeset in webkit [181536] by Carlos Garcia Campos

11 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r181412 - Unreviewed, rolling out r179340 and r179344.
https://bugs.webkit.org/show_bug.cgi?id=142598

Caused images to stay alive forever when navigating away from
the page before they finish loading. (Requested by kling on

Reverted changesets:

"CachedImage: ensure clients overrides imageChanged instead of
notifyFinished"
https://bugs.webkit.org/show_bug.cgi?id=140722
http://trac.webkit.org/changeset/179340

"HTMLImageLoader: fix build failure on assert condition after
r179340"
https://bugs.webkit.org/show_bug.cgi?id=140722
http://trac.webkit.org/changeset/179344

3:27 AM Changeset in webkit [181535] by gyuyoung.kim@samsung.com

3 edits in trunk

[CMake][EFL] Rearrange OptionEFL.cmake to improve readability
https://bugs.webkit.org/show_bug.cgi?id=142722

Reviewed by Csaba Osztrogonác.

Categorize to define cmake variables, to find necessary packages,
use upper case for "glib_conponents" cmake variable name, re-arrange
wrong alphabet sorting, and so on.

CMakeLists.txt: Remove WinCE port.
Source/cmake/OptionsEfl.cmake:

3:19 AM Changeset in webkit [181534] by Carlos Garcia Campos

13 edits in releases/WebKitGTK/webkit-2.8/Source

Merge r181411 - Many users of Heap::reportExtraMemory* are wrong, causing lots of memory growth
https://bugs.webkit.org/show_bug.cgi?id=142593

Reviewed by Andreas Kling.

Adopt deprecatedReportExtraMemory as a short-term fix for runaway
memory growth in these cases where we have not adopted
reportExtraMemoryVisited.

Long-term, we should use reportExtraMemoryAllocated+reportExtraMemoryVisited.
That's tracked by https://bugs.webkit.org/show_bug.cgi?id=142595.

Source/JavaScriptCore:

API/JSBase.cpp:

(JSReportExtraMemoryCost):

runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayValueMap::add):

Source/WebCore:

Using IOSDebug, I can see that the canvas stress test @ http://jsfiddle.net/fvyw4ba0/,
which used to keep > 1000 1MB NonVolatile GPU allocations live, now keeps about 10 live.

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::reportExtraMemoryAllocated):

bindings/js/JSDocumentCustom.cpp:

(WebCore::toJS):

bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

bindings/js/JSNodeListCustom.cpp:

(WebCore::createWrapper):

dom/CollectionIndexCache.cpp:

(WebCore::reportExtraMemoryAllocatedForCollectionIndexCache):

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):

html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::imageChanged):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::dropProtection):

3:13 AM Changeset in webkit [181533] by Carlos Garcia Campos

29 edits in releases/WebKitGTK/webkit-2.8/Source

Merge r181407 - Refactored the JSC::Heap extra cost API for clarity and to make some known bugs more obvious
https://bugs.webkit.org/show_bug.cgi?id=142589

Reviewed by Andreas Kling.

Source/JavaScriptCore:

API/JSBase.cpp:

(JSReportExtraMemoryCost): Added a FIXME to annotate a known bug.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::visitAggregate):

bytecode/CodeBlock.h:

(JSC::CodeBlock::setJITCode): Updated for rename.

heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryAllocatedSlowCase):
(JSC::Heap::deprecatedReportExtraMemorySlowCase): Renamed our reporting
APIs to clarify their relationship to each other: One must report extra
memory at the time of allocation, and at the time the GC visits it.

(JSC::Heap::extraMemorySize):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::sizeAfterCollect):
(JSC::Heap::willStartCollection): Updated for renames. Added explicit
API for deprecated users who can't use our best API.

(JSC::Heap::reportExtraMemoryCostSlowCase): Deleted.
(JSC::Heap::extraSize): Deleted.

heap/Heap.h:
heap/HeapInlines.h:

(JSC::Heap::reportExtraMemoryAllocated):
(JSC::Heap::reportExtraMemoryVisited):
(JSC::Heap::deprecatedReportExtraMemory):
(JSC::Heap::reportExtraMemoryCost): Deleted. Ditto.

heap/SlotVisitor.h:
heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::reportExtraMemoryVisited):
(JSC::SlotVisitor::reportExtraMemoryUsage): Deleted. Moved this
functionality into the Heap since it's pretty detailed in its access
to the heap.

runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::ConstructionContext::ConstructionContext):

runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren): Updated for
renames.

runtime/JSString.cpp:

(JSC::JSString::visitChildren):
(JSC::JSRopeString::resolveRopeToAtomicString):
(JSC::JSRopeString::resolveRope):

runtime/JSString.h:

(JSC::JSString::finishCreation): Updated for renames.

runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayValueMap::add): Added FIXME.

runtime/WeakMapData.cpp:

(JSC::WeakMapData::visitChildren): Updated for rename.

Source/WebCore:

Updated for renames to JSC extra cost APIs.

Added FIXMEs to our 10 use cases that are currently wrong, including
canvas, which is the cause of https://bugs.webkit.org/show_bug.cgi?id=142457.

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::appendBufferInternal):
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete):
(WebCore::SourceBuffer::reportExtraMemoryAllocated):
(WebCore::SourceBuffer::reportExtraMemoryCost): Deleted.

Modules/mediasource/SourceBuffer.h:
bindings/js/JSDocumentCustom.cpp:

(WebCore::toJS):

bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

bindings/js/JSNodeListCustom.cpp:

(WebCore::createWrapper):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

dom/CollectionIndexCache.cpp:

(WebCore::reportExtraMemoryAllocatedForCollectionIndexCache):
(WebCore::reportExtraMemoryCostForCollectionIndexCache): Deleted.

dom/CollectionIndexCache.h:

(WebCore::Iterator>::computeNodeCountUpdatingListCache):

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):

html/HTMLCollection.h:

(WebCore::CollectionNamedElementCache::didPopulate):

html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::imageChanged):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::dropProtection):

3:00 AM Changeset in webkit [181532] by calvaris@igalia.com

2 edits in trunk/Tools

Created Streams API watchlist
https://bugs.webkit.org/show_bug.cgi?id=142684

Reviewed by Benjamin Poulain.

Scripts/webkitpy/common/config/watchlist: Created StreamsAPI

watchlist and added Benjamin, Youenn and me to it.

2:38 AM Changeset in webkit [181531] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.8/Tools

Merge r181399 - [GTK] Add support for handling TLS errors to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=142576

Reviewed by Sergio Villar Senin.

It's useful for testing TLS errors handling itself, but also to
allow ignoring TLS errors when testing.

MiniBrowser/gtk/BrowserWindow.c:

(webViewLoadFailedWithTLSerrors):
(browserWindowConstructed):

2:36 AM Changeset in webkit [181530] by Carlos Garcia Campos

6 edits in releases/WebKitGTK/webkit-2.8

Merge r181395 - [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
https://bugs.webkit.org/show_bug.cgi?id=126688

Reviewed by Gustavo Noronha Silva.

Add ENABLE_MINIBROWSER option, enabled by default for development
builds and disabled for production builds unless explicilty enabled.

Source/cmake/OptionsGTK.cmake:

Tools:

CMakeLists.txt: Build testing tools only for developer builds,

but MiniBrowser when ENABLE_MINIBROWSER option is ON.

MiniBrowser/gtk/CMakeLists.txt: Only add

-DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
and add a rule to install the MiniBrowser.

MiniBrowser/gtk/main.c:

(main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
builds.

2:06 AM Changeset in webkit [181529] by Carlos Garcia Campos

5 edits in releases/WebKitGTK/webkit-2.8

Merge r181392 - [GTK] Do not look for child processes in the UI process binary path
https://bugs.webkit.org/show_bug.cgi?id=135752

Reviewed by Gustavo Noronha Silva.

Source/cmake/OptionsGTK.cmake: Add -DDEVELOPMENT_BUILD=1 to the

build for development builds.

Source/WebKit2:

It's only useful for internal tools and tests, but never when
installed, since we don't install the processes in the bin dir but
in the libexec dir.

Shared/gtk/ProcessExecutablePathGtk.cpp:

(WebKit::findWebKitProcess): Only look or the executables in the
UI process binary path or WEBKIT_EXEC_PATH for development builds.

UIProcess/API/gtk/WebKitWebContext.cpp:

(injectedBundleDirectory): Only check
WEBKIT_INJECTED_BUNDLE_PATH env var for development builds.

1:42 AM Changeset in webkit [181528] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.8

Merge r181387 - Inline block children do not have correct baselines if their children are also block elements
https://bugs.webkit.org/show_bug.cgi?id=142559

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2015-03-11
Reviewed by Darin Adler.

Source/WebCore:

Perform the same computation on child block elements as child inline elements.

Test: fast/text/baseline-inline-block-block-children.html

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::inlineBlockBaseline):

LayoutTests:

fast/text/baseline-inline-block-block-children-expected.html: Added.
fast/text/baseline-inline-block-block-children.html: Added.

1:16 AM Changeset in webkit [181527] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r181385 - [CMake][GStreamer] Building EFL or GTK with ENABLE_VIDEO and without ENABLE_WEB_AUDIO is broken.
https://bugs.webkit.org/show_bug.cgi?id=142577

Reviewed by Carlos Garcia Campos.

No new tests, this is a build fix.

PlatformEfl.cmake: Include GSTREAMER_AUDIO_LIBRARIES on the link step both for ENABLE_VIDEO and ENABLE_WEB_AUDIO.
PlatformGTK.cmake: Idem.

12:40 AM WebKitGTK/2.8.x edited by tpopela@redhat.com

(diff)

12:21 AM Changeset in webkit [181526] by gyuyoung.kim@samsung.com

2 edits in trunk/LayoutTests

[EFL] Unreviewed EFL gardening on 16th Mar.

Mark attachment tests to missing, Set writing mode tests to failure.
Unskip fast/forms/textfield-overflow-by-value-update.html which is
passing on EFL bot.

platform/efl/TestExpectations:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed