Timeline

Mar 28, 2015:

11:58 PM Changeset in webkit [182118] by commit-queue@webkit.org

• 6 edits in trunk/Source/JavaScriptCore

Clean up JavaScriptCore/builtins
​https://bugs.webkit.org/show_bug.cgi?id=143177

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-28
Reviewed by Ryosuke Niwa.

• builtins/ArrayConstructor.js:

(from):

• We can compare to undefined instead of using a typeof undefined check.
• Converge on double quoted strings everywhere.

• builtins/ArrayIterator.prototype.js:

(next):

• builtins/StringIterator.prototype.js:

(next):

• Use shorthand object construction to avoid duplication.
• Improve grammar in error messages.

• tests/stress/array-iterators-next-with-call.js:
• tests/stress/string-iterators.js:
• Update for new error message strings.

7:07 PM Changeset in webkit [182117] by eric.carlson@apple.com

• 8 edits
  1 move
  1 add in trunk/Source/WebCore

[Mac] Update for output device API change
​https://bugs.webkit.org/show_bug.cgi?id=143187

Reviewed by Zalan Bujtas.

The API used for output device is being deprecated, update to the replacement.

• WebCore.xcodeproj/project.pbxproj: Add SPI headers.

• platform/graphics/MediaPlaybackTarget.h:

(WebCore::MediaPlaybackTarget::MediaPlaybackTarget): Update for API change.
(WebCore::MediaPlaybackTarget::setDevicePickerContext):
(WebCore::MediaPlaybackTarget::devicePickerContext):

• platform/graphics/avfoundation/MediaPlaybackTargetMac.mm:

(WebCore::MediaPlaybackTarget::encode):
(WebCore::MediaPlaybackTarget::decode):

• platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h:
• platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:

(WebCore::MediaPlaybackTargetPickerMac::MediaPlaybackTargetPickerMac):
(WebCore::MediaPlaybackTargetPickerMac::~MediaPlaybackTargetPickerMac):
(WebCore::MediaPlaybackTargetPickerMac::outputeDeviceAvailabilityChangedTimerFired):
(WebCore::MediaPlaybackTargetPickerMac::devicePicker):
(WebCore::MediaPlaybackTargetPickerMac::currentDeviceDidChange):
(WebCore::MediaPlaybackTargetPickerMac::stopMonitoringPlaybackTargets):
(-[WebAVOutputDeviceMenuControllerHelper observeValueForKeyPath:ofObject:change:context:]):
(-[WebAVOutputDevicePickerMenuControllerHelper observeValueForKeyPath:ofObject:change:context:]): Deleted.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setWirelessPlaybackTarget):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

• platform/spi/cocoa/AVKitSPI.h: Copied from Source/WebCore/platform/spi/ios/AVKitSPI.h. Moved

from ios directory, added Mac includes and prototypes.

• platform/spi/ios/AVKitSPI.h: Removed.

• platform/spi/mac/AVFoundationSPI.h: Added.

4:17 PM Changeset in webkit [182116] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Optimize RenderLayer::intersectsDamageRect() slightly
​https://bugs.webkit.org/show_bug.cgi?id=143186

Reviewed by Zalan Bujtas.

We can early return from RenderLayer::intersectsDamageRect() if the
damageRect is empty, since nothing will intersect with the empty rect.

Slight performance gain when scrolling overflow-scroll with lots of nested,
clipping layers.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

1:44 PM Changeset in webkit [182115] by andersca@apple.com

• 6 edits in trunk/Source

Remove an unused SPI method from WebKitLegacy
​https://bugs.webkit.org/show_bug.cgi?id=143185

Reviewed by Sam Weinig.

Source/WebCore:

• loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::storeCopyOfCache): Deleted.

• loader/appcache/ApplicationCacheStorage.h:

Source/WebKit/mac:

• WebView/WebDataSource.mm:

(-[WebDataSource _transferApplicationCache:]): Deleted.

• WebView/WebDataSourcePrivate.h:

10:28 AM Changeset in webkit [182114] by saambarati1@gmail.com

• 12 edits
  1 add in trunk/Source

Web Inspector: ES6: Better support for Symbol types in Type Profiler
​https://bugs.webkit.org/show_bug.cgi?id=141257

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

ES6 introduces the new primitive type Symbol. This patch makes JSC's
type profiler support this new primitive type.

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• inspector/protocol/Runtime.json:
• runtime/RuntimeType.cpp:

(JSC::runtimeTypeForValue):

• runtime/RuntimeType.h:

(JSC::runtimeTypeIsPrimitive):

• runtime/TypeSet.cpp:

(JSC::TypeSet::addTypeInformation):
(JSC::TypeSet::dumpTypes):
(JSC::TypeSet::doesTypeConformTo):
(JSC::TypeSet::displayName):
(JSC::TypeSet::inspectorTypeSet):
(JSC::TypeSet::toJSONString):

• runtime/TypeSet.h:

(JSC::TypeSet::seenTypes):

• tests/typeProfiler/driver/driver.js:
• tests/typeProfiler/symbol.js: Added.

(wrapper.foo):
(wrapper.bar):
(wrapper.bar.bar.baz):
(wrapper):

Source/WebInspectorUI:

The Web Inspector's visualization of JSC's type profiler
should have support for the Symbol type.

• UserInterface/Models/TypeSet.js:

(WebInspector.TypeSet):
(WebInspector.TypeSet.prototype.get primitiveTypeNames):

• UserInterface/Views/TypeTokenView.css:

TypeTokenView will display Symbol type tokens using the same color that
Symbol values are displayed as formatted values.

(.type-token-symbol):

• UserInterface/Views/TypeTokenView.js:

(WebInspector.TypeTokenView.prototype._displayTypeName):
(WebInspector.TypeTokenView):

9:38 AM Changeset in webkit [182113] by commit-queue@webkit.org

• 27 edits in trunk

Web Inspector: Adopt Array.prototype.includes and String.prototype.includes
​https://bugs.webkit.org/show_bug.cgi?id=143176

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-28
Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

• UserInterface/Base/Utilities.js:

Remove our custom implementations of Array/String contains functions.

• UserInterface/Base/Main.js:

(WebInspector._updateContentViewForCurrentNavigationSidebar):
(WebInspector._contentBrowserCurrentContentViewDidChange):

• UserInterface/Controllers/CodeMirrorCompletionController.js:

(WebInspector.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions.):
(WebInspector.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions):

• UserInterface/Controllers/CodeMirrorTokenTrackingController.js:

(WebInspector.CodeMirrorTokenTrackingController.prototype._updateHoveredTokenInfo):
(WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):

• UserInterface/Controllers/FrameResourceManager.js:

(WebInspector.FrameResourceManager.prototype._extraDomainsActivated):
(WebInspector.FrameResourceManager):

• UserInterface/Controllers/LayerTreeManager.js:

(WebInspector.LayerTreeManager.prototype.layerTreeMutations):

• UserInterface/Controllers/StorageManager.js:

(WebInspector.StorageManager.prototype._extraDomainsActivated):
(WebInspector.StorageManager):

• UserInterface/Models/Branch.js:

(WebInspector.Branch.prototype.addRevision):

• UserInterface/Models/CSSKeywordCompletions.js:

(WebInspector.CSSKeywordCompletions.forProperty):

• UserInterface/Models/CSSRule.js:

(WebInspector.CSSRule.prototype.get matchedSelectors):

• UserInterface/Models/CSSStyleDeclaration.js:
• UserInterface/Models/Color.js:

(WebInspector.Color.fromString):

• UserInterface/Models/DOMNode.js:
• UserInterface/Models/DOMNodeStyles.js:

(WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):

• UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection.prototype.refresh):

• UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel.prototype._updatePseudoClassCheckboxes):
(WebInspector.CSSStyleDetailsSidebarPanel):

• UserInterface/Views/ContentBrowser.js:

(WebInspector.ContentBrowser.prototype._updateContentViewSelectionPathNavigationItem):

• UserInterface/Views/DOMTreeElement.js:
• UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype._resourceAdded):

• UserInterface/Views/GeneralTreeElement.js:

(WebInspector.GeneralTreeElement.prototype.addClassName):
(WebInspector.GeneralTreeElement.prototype.removeClassName):

• UserInterface/Views/LegacyConsoleMessageImpl.js:

(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsTable):

• UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype._updateMessagesSelection):

• UserInterface/Views/NavigationBar.js:

(WebInspector.NavigationBar.prototype._findNavigationItem):

• UserInterface/Views/Sidebar.js:

(WebInspector.Sidebar.prototype.findSidebarPanel):
Replace contains with includes where appropriate.

LayoutTests:

• inspector/css/pseudo-element-matches.html:

9:33 AM Changeset in webkit [182112] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Tweak node styles in ObjectTreeView
​https://bugs.webkit.org/show_bug.cgi?id=143179

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-28
Reviewed by Timothy Hatcher.

• UserInterface/Views/LogContentView.css:

(.console-group-messages .outline-disclosure.single-node li):

• UserInterface/Views/DOMTreeOutline.css:

(.dom-tree-outline.single-node li):
This style makes sense as a generic DOMTreeOutline style.

• UserInterface/Views/FormattedValue.css:

(.formatted-node > .dom-tree-outline):
(.formatted-node > .dom-tree-outline ol):
(.formatted-node > .dom-tree-outline li.hovered:not(.selected) .selection):
Style for nodes in ObjectTreeView.

• UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:

(.object-tree-array-index .index-value .formatted-node .dom-tree-outline):
Styles for node in Array value.

• UserInterface/Views/FormattedValue.js:

(WebInspector.FormattedValue.createElementForNode):
Address the FIXME.

4:59 AM Changeset in webkit [182111] by commit-queue@webkit.org

• 10 edits in trunk/Source/WebCore

nullptr cleanup in InlineFooBox classes
​https://bugs.webkit.org/show_bug.cgi?id=143178

Patch by Joonghun Park <​jh718.park@samsung.com> on 2015-03-28
Reviewed by Csaba Osztrogonác.

No new tests, no behavior changes

Replace 0 with nullptr in InlineFooBox classes.

• rendering/InlineBox.cpp:

(WebCore::InlineBox::prevLeafChildIgnoringLineBreak):

• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::removeChild):
(WebCore::InlineFlowBox::deleteLine):
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):

• rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::InlineFlowBox):

• rendering/InlineTextBox.h:

(WebCore::InlineTextBox::InlineTextBox):

• rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::getLogicalStartBoxWithNode):
(WebCore::RootInlineBox::getLogicalEndBoxWithNode):

• rendering/RootInlineBox.h:
• rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::SVGInlineTextBox):
(WebCore::SVGInlineTextBox::releasePaintingResource):
(WebCore::SVGInlineTextBox::restoreGraphicsContextAfterTextPainting):

• rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::closestLeafChildForPosition):
(WebCore::findFirstAndLastAttributesInVector):

• rendering/svg/SVGRootInlineBox.h:

2:57 AM Changeset in webkit [182110] by Csaba Osztrogonác

• 3 edits in trunk/LayoutTests

REGRESSION(r181326): It made dfg-int16array.js and dfg-int8array.js fail on AArch64 Linux
​https://bugs.webkit.org/show_bug.cgi?id=142629

Unreviewed gardening, unskip now passing tests after r182091.

• js/script-tests/dfg-int16array.js:
• js/script-tests/dfg-int8array.js:

Mar 27, 2015:

11:01 PM Changeset in webkit [182109] by saambarati1@gmail.com

• 3 edits
  3 adds in trunk

Deconstruction parameters are bound too late
​https://bugs.webkit.org/show_bug.cgi?id=143148

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Currently, a deconstruction pattern named with the same
name as a function will shadow the function. This is
wrong. It should be the other way around.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):

LayoutTests:

• js/regress/deconstructing-parameters-overridden-by-function-expected.txt: Added.
• js/regress/deconstructing-parameters-overridden-by-function.html: Added.
• js/regress/script-tests/deconstructing-parameters-overridden-by-function.js: Added.

(f):
(test):
(.arg):

10:45 PM Changeset in webkit [182108] by Simon Fraser

• 2 edits in trunk/Source/WebCore

More modern loops in RenderLayer.cpp
​https://bugs.webkit.org/show_bug.cgi?id=143175

Reviewed by Ryosuke Niwa.

Use modern loops in more places in RenderLayer.app.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::update3DTransformedDescendantStatus):
(WebCore::RenderLayer::paint):
(WebCore::performOverlapTests):
(WebCore::RenderLayer::paintFixedLayersInNamedFlows):
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::calculateClipRects):

10:45 PM Changeset in webkit [182107] by Simon Fraser

• 2 edits in trunk/Source/WebCore

nullptr cleanup in RenderLayer
​https://bugs.webkit.org/show_bug.cgi?id=143174

Reviewed by Ryosuke Niwa.

Replace 0 with nullptr in RenderLayer.cpp.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::filterRenderer):
(WebCore::RenderLayer::updateLayerPositionsAfterLayout):
(WebCore::RenderLayer::updateLayerPositionsAfterOverflowScroll):
(WebCore::RenderLayer::positionNewlyCreatedOverflowControls):
(WebCore::RenderLayer::enclosingOverflowClipLayer):
(WebCore::RenderLayer::enclosingCompositingLayer):
(WebCore::RenderLayer::enclosingCompositingLayerForRepaint):
(WebCore::RenderLayer::enclosingFilterLayer):
(WebCore::RenderLayer::enclosingFilterRepaintLayer):
(WebCore::RenderLayer::clippingRootForPainting):
(WebCore::RenderLayer::transparentPaintingAncestor):
(WebCore::transparencyClipBox):
(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::removeOnlyThisLayer):
(WebCore::RenderLayer::insertOnlyThisLayer):
(WebCore::accumulateOffsetTowardsAncestor):
(WebCore::RenderLayer::enclosingScrollableArea):
(WebCore::RenderLayer::enclosingPaginationLayerInSubtree):
(WebCore::RenderLayer::enclosingElement):
(WebCore::RenderLayer::enclosingFlowThreadAncestor):
(WebCore::RenderLayer::hitTestFixedLayersInNamedFlows):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):
(WebCore::RenderLayer::hitTestLayerByApplyingTransform):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::updateClipRects):
(WebCore::RenderLayer::clipRects):
(WebCore::RenderLayer::calculateClipRects):

10:04 PM Changeset in webkit [182106] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: TypeProfiler doesn't work on files with ES6 Class Syntax
​https://bugs.webkit.org/show_bug.cgi?id=143169

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-27
Reviewed by Timothy Hatcher.

• UserInterface/Models/ScriptSyntaxTree.js:

(WebInspector.ScriptSyntaxTree.prototype._recurse):
(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
(WebInspector.ScriptSyntaxTree):
Add basic support for Esprima's ES6 Class/Method/Spread nodes.
There are more ES6 features that should be covered, but this
covers all the features we use in Web Inspector source, so
Type Profiling can work with our own source.

Treat Methods like getters / setters right now because their
syntax is very similiar to getters/setters. There is a bug
handling generic ES6 cleanup to better name things.

9:42 PM Changeset in webkit [182105] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught TDZ Exception with Type Profiler
​https://bugs.webkit.org/show_bug.cgi?id=143167

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-27
Reviewed by Timothy Hatcher.

• UserInterface/Views/TypePropertiesSection.js:

(WebInspector.TypePropertyTreeElement):
Avoid TDZ issue by not using "this" before "super".

• UserInterface/Models/ScriptSyntaxTree.js:

(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
(WebInspector.ScriptSyntaxTree):
Better handle unsupported node types by returning null and avoiding an exception.

• UserInterface/Views/SourceCodeTextEditor.js:

Fix an issue I saw once where the sourceCode was a Script itself.

9:41 PM Changeset in webkit [182104] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught exception while debugging, after performSearch callback line does not exists
​https://bugs.webkit.org/show_bug.cgi?id=143172

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-27
Reviewed by Timothy Hatcher.

• UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype.customPerformSearch.searchResultCallback):
(WebInspector.SourceCodeTextEditor.prototype.customPerformSearch):
Gracefully handle if the line does not exist.

9:18 PM Changeset in webkit [182103] by gyuyoung.kim@samsung.com

• 6 edits in trunk

.:
[CMake] Remove unnecessary INCLUDE_IF_EXISTS macro
​https://bugs.webkit.org/show_bug.cgi?id=143138

Reviewed by Csaba Osztrogonác.

INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.

• Source/cmake/OptionsWindows.cmake:

Set "PORT" instead of "PORT_FALLBACK" because there is no benefit to define PORT_FALLBACK.

• Source/cmake/WebKitMacros.cmake:

Tools:
[CMake] Remove unnecessary INCLUDE_IF_EXISTS macro
​https://bugs.webkit.org/show_bug.cgi?id=143138

Reviewed by Csaba Osztrogonác.

INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.

• ImageDiff/CMakeLists.txt:

Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.

• WebKitTestRunner/CMakeLists.txt: ditto.

9:02 PM Changeset in webkit [182102] by rniwa@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

parse doesn't initialize the 16-bit version of the JSC parser with defaultConstructorKind
​https://bugs.webkit.org/show_bug.cgi?id=143170

Reviewed by Benjamin Poulain.

Assert that we never use 16-bit version of the parser to parse a default constructor
since both base and derived default constructors should be using a 8-bit string.

• parser/Parser.h:

(JSC::parse):

8:15 PM Changeset in webkit [182101] by yoon@igalia.com

• 12 edits
  8 adds in trunk/Source

[TexMap] Seperate BitmapTexture related classes implementations from TextureMapper
​https://bugs.webkit.org/show_bug.cgi?id=142386

Reviewed by Žan Doberšek.

TextureMapper and TextureMapperGL are bloated and tightly coupled with
BitmapTexture. We should move these classes to seperated file of their own.
Also, this patch removes friend relationship from TextureMapperGL and its
subsidiary classes.

The main purpose of this refactoring is to expose BitmapTexturePool to
renderers of platformlayers like Video and Canvas. By doing this, each
renderer can acquire textures from the global texture pool to paint
their contents directly.

Source/WebCore:

No new tests needed.

• PlatformEfl.cmake:
• PlatformGTK.cmake:
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

Include BitmapTextureGL and BitmapTexturePool explicitly

• platform/graphics/texmap/BitmapTexture.cpp: Added.
• platform/graphics/texmap/BitmapTexture.h: Added.

(WebCore::BitmapTexture::updateContents):
Exclude BitmapTexture class from TextureMapper

• platform/graphics/texmap/BitmapTextureGL.cpp: Added.
• platform/graphics/texmap/BitmapTextureGL.h: Added.

Exclude BitmapTextureGL class from TextureMapperGL
(WebCore::BitmapTextureGL::clipStack): Added.
Add the getter for clipStack for TextureMapperGL
(WebCore::BitmapTextureGL::Bind): Deleted.
(WebCore::BitmapTextureGL::BindAsSurface): Added.
Bind used TextureMapperGL's internal data directly to compute projection matrix as a friend class,
However, TextureMapperGL can compute projection matrix itself after binding job, so this
friend ship is not needed. Also, this patch renames Bind to BindAsSurface to remove ambiguity.

• platform/graphics/texmap/BitmapTextureImageBuffer.cpp: Added.
• platform/graphics/texmap/BitmapTextureImageBuffer.h: Added.

Exclude BitmapTextureImageBuffer class from TextureMapperImageBuffer

• platform/graphics/texmap/BitmapTexturePool.cpp: Added.
• platform/graphics/texmap/BitmapTexturePool.h: Added.

Exclude BitmapTexturePool class from TextureMapperGL
(WebCore::BitmapTexturePool::acquireTexture):
Modified to use passed GraphicsContext3D instead of TextureMapperGL to remove redundant coupling

• platform/graphics/texmap/TextureMapper.cpp:
• platform/graphics/texmap/TextureMapper.h:

Remove BitmapTexturePool and BitmapTexture from its implementation.

• platform/graphics/texmap/TextureMapperGL.cpp:
• platform/graphics/texmap/TextureMapperGL.h:

Remove BitmapTextureGL from its implementation.
(WebCore::TextureMapperGL::TextureMapperGL):
(WebCore::TextureMapperGL::clipStack):
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::currentSurface):
Add a getter of the current surface for filtering operation in BitmapTextureGL.
It would be clear to move filtering operation from BitmapTextureGL to TextureMapperGL later.

(WebCore::TextureMapperGL::ClipStack):
Move inner class declaration to public.

• platform/graphics/texmap/TextureMapperImageBuffer.cpp:
• platform/graphics/texmap/TextureMapperImageBuffer.h:

Remove BitmapTextureImageBuffer from its implementation.

Source/WebKit2:

• Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp: Include BitmapTextureGL.h explicitly

8:09 PM Changeset in webkit [182100] by rniwa@webkit.org

• 7 edits
  1 add in trunk/Source

ES6 Classes: Runtime error in JIT'd class calling super() with arguments and superclass has default constructor
​https://bugs.webkit.org/show_bug.cgi?id=142862

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

Add a test that used to fail in DFG now that the bug has been fixed by r181993.

• tests/stress/class-syntax-derived-default-constructor.js: Added.

Source/WebInspectorUI:

Removed the workaround for the bug since it has been fixed by r181993.

• UserInterface/Base/Object.js:
• UserInterface/Models/DebuggerDashboard.js:
• UserInterface/Models/NetworkTimeline.js:
• UserInterface/Models/ReplayDashboard.js:
• UserInterface/Models/Revision.js:

7:56 PM Changeset in webkit [182099] by Joseph Pecoraro

• 6 edits
  1 add in trunk/Source/WebInspectorUI

Web Inspector: Add Setter Icon for ObjectTreeView
​https://bugs.webkit.org/show_bug.cgi?id=143129

Reviewed by Timothy Hatcher.

• UserInterface/Images/Pencil.svg: Added.

New icon used to indicate setter properties.

• Localizations/en.lproj/localizedStrings.js:

Remove "Read only" and replace with "Setter".

• UserInterface/Views/ObjectTreeArrayIndexTreeElement.js:

(WebInspector.ObjectTreeArrayIndexTreeElement.prototype._titleFragment):
(WebInspector.ObjectTreeArrayIndexTreeElement):

• UserInterface/Views/ObjectTreePropertyTreeElement.js:

(WebInspector.ObjectTreePropertyTreeElement.prototype._createTitlePropertyStyle):
(WebInspector.ObjectTreePropertyTreeElement.prototype._createTitleAPIStyle):
Update cases that created setter / getter elements.

• UserInterface/Views/ObjectTreeBaseTreeElement.js:

(WebInspector.ObjectTreeBaseTreeElement.prototype.createGetterElement):
(WebInspector.ObjectTreeBaseTreeElement.prototype.createInteractiveGetterElement): Deleted.

• UserInterface/Views/ObjectTreePropertyTreeElement.css:

(.object-tree-property :matches(.getter, .setter)):
(.object-tree-property .spacer):
(.object-tree-property .getter):
(.object-tree-property .setter):
(.object-tree-property .getter + .setter):
New setter element and styles. Setters are always non-interactable right now.

7:55 PM Changeset in webkit [182098] by msaboff@apple.com

• 9 edits in trunk/Source/JavaScriptCore

load8Signed() and load16Signed() should be renamed to avoid confusion
​https://bugs.webkit.org/show_bug.cgi?id=143168

Reviewed by Benjamin Poulain.

Renamed load8Signed() to load8SignedExtendTo32() and load16Signed() to load16SignedExtendTo32().

• assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::load8SignedExtendTo32):
(JSC::MacroAssemblerARM::load16SignedExtendTo32):
(JSC::MacroAssemblerARM::load8Signed): Deleted.
(JSC::MacroAssemblerARM::load16Signed): Deleted.

• assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::load16SignedExtendTo32):
(JSC::MacroAssemblerARM64::load8SignedExtendTo32):
(JSC::MacroAssemblerARM64::load16Signed): Deleted.
(JSC::MacroAssemblerARM64::load8Signed): Deleted.

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load16SignedExtendTo32):
(JSC::MacroAssemblerARMv7::load8SignedExtendTo32):
(JSC::MacroAssemblerARMv7::load16Signed): Deleted.
(JSC::MacroAssemblerARMv7::load8Signed): Deleted.

• assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::load8SignedExtendTo32):
(JSC::MacroAssemblerMIPS::load16SignedExtendTo32):
(JSC::MacroAssemblerMIPS::load8Signed): Deleted.
(JSC::MacroAssemblerMIPS::load16Signed): Deleted.

• assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::load8SignedExtendTo32):
(JSC::MacroAssemblerSH4::load8):
(JSC::MacroAssemblerSH4::load16SignedExtendTo32):
(JSC::MacroAssemblerSH4::load16):
(JSC::MacroAssemblerSH4::load8Signed): Deleted.
(JSC::MacroAssemblerSH4::load16Signed): Deleted.

• assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::load8SignedExtendTo32):
(JSC::MacroAssemblerX86Common::load16SignedExtendTo32):
(JSC::MacroAssemblerX86Common::load8Signed): Deleted.
(JSC::MacroAssemblerX86Common::load16Signed): Deleted.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emitIntTypedArrayGetByVal):

6:57 PM Changeset in webkit [182097] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Use a typedef for the WKPluginLoadClientPolicy enum
​https://bugs.webkit.org/show_bug.cgi?id=143161

Reviewed by Tim Horton.

• UIProcess/API/C/WKPluginLoadPolicy.h:

5:59 PM Changeset in webkit [182096] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exceptions with Context Menus
​https://bugs.webkit.org/show_bug.cgi?id=143162

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-27
Reviewed by Timothy Hatcher.

• UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.contextMenuCleared):

5:57 PM Changeset in webkit [182095] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Disable editing in Metrics section while it is not working
​https://bugs.webkit.org/show_bug.cgi?id=143165

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-27
Reviewed by Timothy Hatcher.

• UserInterface/Views/BoxModelDetailsSectionRow.js:

(WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createElement):
(WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput):
Disable double click to edit while it is not working. The value setter
and add methods no longer exist.

5:56 PM Changeset in webkit [182094] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exceptions evaluating code while paused
​https://bugs.webkit.org/show_bug.cgi?id=143163

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-27
Reviewed by Timothy Hatcher.

• UserInterface/Models/CallFrame.js:

(WebInspector.CallFrame.prototype.collectScopeChainVariableNames):
We define a property named "valueForCaseInsensitiveKey" on Object.prototype
that is readonly. So we should avoid Object.prototype when building our
result list. This should probably move to a Map object eventually.

5:54 PM Changeset in webkit [182093] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove unused testing properties
​https://bugs.webkit.org/show_bug.cgi?id=143156

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-27
Reviewed by Timothy Hatcher.

• UserInterface/Views/LegacyConsoleMessageImpl.js:

(WebInspector.LegacyConsoleMessageImpl.prototype._formatMessage):

• UserInterface/Views/Section.js:

(WebInspector.Section.prototype.get subtitleAsTextForTest): Deleted.

5:51 PM Changeset in webkit [182092] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception: TypeError: Attempted to assign to readonly - DOMNodeDetailsSidebarPanel.js
​https://bugs.webkit.org/show_bug.cgi?id=143139

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-27
Reviewed by Timothy Hatcher.

DataGridNodes do not have a selectable setter. TreeElements do.
DataGridNodes are always selectable. Match current behavior by
removing all instances of attempting to set the selectability
which would, under strict mode, result in an error.

• UserInterface/Views/ApplicationCacheFrameContentView.js:

(WebInspector.ApplicationCacheFrameContentView.prototype._populateDataGrid):

• UserInterface/Views/CookieStorageContentView.js:

(WebInspector.CookieStorageContentView.prototype._rebuildTable):

• UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel.prototype._createAttributesDataGrid):
(WebInspector.DOMNodeDetailsSidebarPanel):

• UserInterface/Views/DOMStorageContentView.js:

(WebInspector.DOMStorageContentView.prototype.reset):

• UserInterface/Views/DataGrid.js:

5:40 PM Changeset in webkit [182091] by msaboff@apple.com

• 5 edits in trunk

Fix flakey dfg-int8array.js and dfg-int16array.js tests for ARM64
​https://bugs.webkit.org/show_bug.cgi?id=138390

Reviewed by Mark Lam.

Source/JavaScriptCore:

Changed load8Signed() and load16Signed() to only sign extend the loaded value to 32 bits
instead of 64 bits. This is what X86-64 does.

• assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::load16Signed):
(JSC::MacroAssemblerARM64::load8Signed):

LayoutTests:

Reenabled the tests for ARM64/iOS. Left the tests disabled for ARM64/linux and will let linux
developers test and reenable under existing but ​https://bugs.webkit.org/show_bug.cgi?id=142629.

• js/script-tests/dfg-int16array.js:
• js/script-tests/dfg-int8array.js:

4:49 PM Changeset in webkit [182090] by Chris Dumez

• 3 edits
  1 move in trunk/Source/WebKit2

[WK2][NetworkCache] Use WTF::WorkQueue abstraction inside NetworkCacheStatistics
​https://bugs.webkit.org/show_bug.cgi?id=143154

Reviewed by Antti Koivisto.

Use WTF::WorkQueue abstraction inside NetworkCacheStatistics, like we
already do in NetworkCacheStorage.

• NetworkProcess/cache/NetworkCacheStatistics.cpp: Renamed from Source/WebKit2/NetworkProcess/cache/NetworkCacheStatisticsCocoa.mm.

(WebKit::NetworkCache::executeSQLCommand):
(WebKit::NetworkCache::executeSQLStatement):
(WebKit::NetworkCache::Statistics::open):
(WebKit::NetworkCache::Statistics::Statistics):
(WebKit::NetworkCache::Statistics::initialize):
(WebKit::NetworkCache::Statistics::bootstrapFromNetworkCache):
(WebKit::NetworkCache::Statistics::shrinkIfNeeded):
(WebKit::NetworkCache::Statistics::recordRetrievalRequest):
(WebKit::NetworkCache::Statistics::recordNotCachingResponse):
(WebKit::NetworkCache::retrieveDecisionToDiagnosticKey):
(WebKit::NetworkCache::Statistics::recordNotUsingCacheForRequest):
(WebKit::NetworkCache::storeDecisionToDiagnosticKey):
(WebKit::NetworkCache::Statistics::recordRetrievalFailure):
(WebKit::NetworkCache::cachedEntryReuseFailureToDiagnosticKey):
(WebKit::NetworkCache::Statistics::recordRetrievedCachedEntry):
(WebKit::NetworkCache::Statistics::markAsRequested):
(WebKit::NetworkCache::Statistics::writeTimerFired):
(WebKit::NetworkCache::Statistics::queryWasEverRequested):
(WebKit::NetworkCache::Statistics::clear):
(WebKit::NetworkCache::Statistics::addHashesToDatabase):
(WebKit::NetworkCache::Statistics::addStoreDecisionsToDatabase):

• NetworkProcess/cache/NetworkCacheStatistics.h:

(WebKit::NetworkCache::Statistics::serialBackgroundIOQueue):

• WebKit2.xcodeproj/project.pbxproj:

4:08 PM Changeset in webkit [182089] by mmaxfield@apple.com

• 6 edits in trunk

Support building WTF on Windows without Cygwin
​https://bugs.webkit.org/show_bug.cgi?id=143084

Reviewed by Brent Fulgham.

Tools:
Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
This patch also migrates to using File::Spec->catfile() for directory separators.

• Scripts/update-webkit-dependency:

(wanted):

• Scripts/update-webkit-support-libs:

(wanted):
(downloadExpectedVersionNumber):
(zipFileVersion):
(toUnixPath): Deleted.

• Scripts/webkitdirs.pm:

(determineSourceDir):
(windowsSourceSourceDir):
(windowsLibrariesDir):
(windowsOutputDir):
(checkInstalledTools):
(buildVisualStudioProject):

Source/WTF:
Windows doesn't have "touch".

• WTF.vcxproj/WTFGenerated.make:

4:01 PM Changeset in webkit [182088] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

WebProcess started by editable WKWebView spends 15% of its initialization time loading DataDetectors
​https://bugs.webkit.org/show_bug.cgi?id=143142
<rdar://problem/20324495>

Reviewed by Anders Carlsson.

Calling DataDetectorsLibrary() is expensive; we should avoid doing it
until actually necessary. When loading a page that makes a caret selection,
ServicesOverlayController was calling DataDetectorsLibrary() (ignoring the fact
that a caret selection can't have any services associated with it) to avoid
crashing on systems where DataDetectors is not available. Instead, we should
first check if there's anything to do, and then check for the existence
of DataDetectors.

• page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::buildPhoneNumberHighlights):
Build the list of phone number ranges, and bail (clearing the potential highlights)
if it is empty, before calling DataDetectorsLibrary().

(WebCore::ServicesOverlayController::buildSelectionHighlight):
Check the list of selection rects, and bail (clearing the potential highlights)
if it is empty, before calling DataDetectorsLibrary().

3:56 PM Changeset in webkit [182087] by rniwa@webkit.org

• 5 edits in trunk/Source/WebKit2

Safari clears selection when its window gets activated via mouse down
​https://bugs.webkit.org/show_bug.cgi?id=143157

Reviewed by Anders Carlsson.

The bug was caused by PlatformMouseEvent created in WebKit2 not having its event number
even though we were correctly calling setActivationEventNumber in WebPage::acceptsFirstMouse.

Fixed the bug by storing [NSEvent eventNumber] in WebMouseEvent on Mac in WebKit2 as done in WebKit1.

• Shared/WebEvent.h:

(WebKit::WebMouseEvent::eventNumber):

• Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):

• Shared/WebMouseEvent.cpp:

(WebKit::WebMouseEvent::WebMouseEvent):
(WebKit::WebMouseEvent::encode):
(WebKit::WebMouseEvent::decode):

• Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebMouseEvent):

3:39 PM WindowsWithoutCygwin edited by mmaxfield@apple.com

(diff)

3:07 PM Changeset in webkit [182086] by andersca@apple.com

• 5 edits in trunk/Source/WebKit2

Only do the Connection::setShouldCloseConnectionOnMachExceptions() hack where necessary
​https://bugs.webkit.org/show_bug.cgi?id=143141
rdar://problem/19471284

Reviewed by Andreas Kling.

• Platform/IPC/Connection.h:
• Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::platformInvalidate):
(IPC::Connection::platformInitialize):
(IPC::Connection::open):

• Shared/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::didFinishLaunching):

• UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didFinishLaunching):

3:04 PM Changeset in webkit [182085] by timothy_horton@apple.com

• 7 edits
  1 add in trunk/Source/WebKit2

Implement iOS WebKit2 PDF Find-in-Page
​https://bugs.webkit.org/show_bug.cgi?id=143065
<rdar://problem/16793370>

Reviewed by Dan Bernstein.

• Platform/spi/ios/CorePDFSPI.h:

Add some SPI.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _countStringMatches:options:maxCount:]):
(-[WKWebView _findString:options:maxCount:]):
(-[WKWebView _hideFindUI]):
If we have a custom content view, forward find-in-page methods to it.

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/API/Cocoa/_WKFindOptions.h:

Move _WKFindOptions into its own file.

• UIProcess/Cocoa/WKWebViewContentProvider.h:

Add find-related methods to the WKWebViewContentProvider protocol.

• UIProcess/ios/WKPDFView.mm:

(-[WKPDFView web_initWithFrame:webView:]):
(-[WKPDFView dealloc]):
Maintain a dispatch queue for searching the PDF.

(-[WKPDFView web_setContentProviderData:suggestedFilename:]):
Fix a type.

(-[WKPDFView _ensureViewForPage:]):
Split the code to create/parent a page view out from _revalidateViews,
so that the find code can create/parent the targetted UIPDFPageView
in order to install the find highlight in it, but before it is scrolled into view.

(-[WKPDFView _revalidateViews]):
Use the stored page index instead of counting again.
Don't unparent page views that have find-in-page highlights in them, because
we won't know enough to recreate them later.

(-[WKPDFView _computePageAndDocumentFrames]):
Put the page index in PDFPageInfo, for reference elsewhere.

(-[WKPDFView _stringCompareOptionsFromWKFindOptions:]):
(-[WKPDFView _computeMatchesForString:options:maxCount:completionHandler:]):
Asynchronously (and on our serial queue) search the PDF for the given string.
We'll cache the most recent results to avoid searching more than once,
cancel existing searches when another begins (since it's a serial queue,
this ensures we'll only have one search active at a time).

(-[WKPDFView web_countStringMatches:options:maxCount:]):
Count the number of matches for the given string, and inform the FindClient
of the result.

(-[WKPDFView _didFindMatch:]):
When we find a match, create a view for it, highlight the match, and
zoom so that it's in-view.

(-[WKPDFView web_findString:options:maxCount:]):
Incrementally search the document for the given string. We do an incremental
search even if we have all of the results so that we can anchor the search
in the right place if the new string is a prefix of the old string, etc.
Wrap around appropriately when searching past the beginning or end of the
document. If we have all of the results (there were less than maxCount results),
look through the cached matches for the incrementally-found result and
report its index to the client.

(-[WKPDFView web_hideFindUI]):
Dismiss the selection and clear some state so we start the next search afresh.

• WebKit2.xcodeproj/project.pbxproj:

3:01 PM Changeset in webkit [182084] by akling@apple.com

• 5 edits in trunk/Source/WebKit2

WebProcessProxy should not retain WebBackForwardListItems forever.
<​https://webkit.org/b/143152>
<rdar://problem/19925709>

Reviewed by Anders Carlsson.

Have WebProcessProxy actually forget about a WebBackForwardListItem after it's removed from
the WebBackForwardList.

This ensures that we don't accumulate too many of these objects, which can get quite large
due to the session state encoded in them.

We already have graceful handling of the case where an incoming IPC message references
a removed back/forward list item.

• UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::didRemoveItem):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::backForwardRemovedItem):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::removeBackForwardItem):

• UIProcess/WebProcessProxy.h:

2:56 PM Changeset in webkit [182083] by saambarati1@gmail.com

• 2 edits in trunk/Source/JavaScriptCore

Add back previously broken assert from bug 141869
​https://bugs.webkit.org/show_bug.cgi?id=143005

Reviewed by Michael Saboff.

• runtime/ExceptionHelpers.cpp:

(JSC::invalidParameterInSourceAppender):

2:56 PM WindowsWithoutCygwin edited by mmaxfield@apple.com

(diff)

2:49 PM WindowsWithoutCygwin edited by mmaxfield@apple.com

(diff)

2:38 PM Changeset in webkit [182082] by Simon Fraser

• 2 edits in trunk/Source/WebKit2

Use the correct timebase to log scrollperf blank pixel counts on iOS
​https://bugs.webkit.org/show_bug.cgi?id=143149

Reviewed by Tim Horton.

MobileSafari and WebKit need to collect scrollperf data using the same timebase;
MobileSafari can't call WTF::monotonicallyIncreasingTime(), so use CFAbsoluteTimeGetCurrent()
everywhere.

• UIProcess/Cocoa/RemoteLayerTreeScrollingPerformanceData.mm:

(WebKit::RemoteLayerTreeScrollingPerformanceData::appendBlankPixelCount):

2:32 PM Changeset in webkit [182081] by jer.noble@apple.com

• 4 edits
  2 adds in trunk

[Mac] Safari fails to fire page "load" event with video[preload=none]
​https://bugs.webkit.org/show_bug.cgi?id=143147

Reviewed by Simon Fraser.

Source/WebCore:

Test: media/video-page-load-preload-none.html

When told to load() when preload == None, set the networkState to Idle.
This causes HTMLMediaElement to set the shouldDelayLoadEvent flag to
false, and allows the page's 'load' event to fire.

Drive-by fix: add setNetworkState() and setReadyState() methods to
MediaPlayerPrivateAVFoundation, reducing a bunch of code duplication.

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::load):
(WebCore::MediaPlayerPrivateAVFoundation::setNetworkState):
(WebCore::MediaPlayerPrivateAVFoundation::setReadyState):
(WebCore::MediaPlayerPrivateAVFoundation::updateStates):

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

LayoutTests:

• media/video-page-load-preload-none-expected.txt: Added.
• media/video-page-load-preload-none.html: Added.

2:10 PM Changeset in webkit [182080] by bshafiei@apple.com

• 2 edits in tags/Safari-601.1.23.4/Source/WebKit2

Merged r182045. rdar://problem/20233711

2:08 PM Changeset in webkit [182079] by bshafiei@apple.com

• 2 edits in tags/Safari-601.1.23.4/Source/WebKit2

Merged r182044. rdar://problem/20233711

2:07 PM Changeset in webkit [182078] by bshafiei@apple.com

• 4 edits in tags/Safari-601.1.23.4/Source/WebKit2

Merged r182037. rdar://problem/20233711

2:02 PM Changeset in webkit [182077] by ap@apple.com

• 2 edits in trunk/Source/WebCore

Calling crypto.webkitSubtle.generateKey causes page memory to never be released
​https://bugs.webkit.org/show_bug.cgi?id=143151
rdar://problem/18940687

Reviewed by Tim Horton.

• crypto/mac/CryptoKeyRSAMac.cpp: (WebCore::CryptoKeyRSA::generatePair): Don't.

1:41 PM Changeset in webkit [182076] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

Null dereference in InbandMetadataTextTrack handling
​https://bugs.webkit.org/show_bug.cgi?id=143144
<rdar://problem/18983250>

Reviewed by Eric Carlson.

• platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.cpp:

(WebCore::InbandMetadataTextTrackPrivateAVF::updatePendingCueEndTimes): Check for null return value from
'client()', just like we do in all other methods.

1:39 PM Changeset in webkit [182075] by Brent Fulgham

• 2 edits
  2 deletes in trunk/LayoutTests

Correct test results after r182012.

The test now produces identical results on all platforms, so update the root test result,
and remove custom non-matching expectations. This corrects Windows, GTK, and EFL builds, and
should not harm the Mac build.

• accessibility/aria-toggle-button-with-title-expected.txt:
• platform/mac/accessibility/aria-toggle-button-with-title-expected.txt: Removed.
• platform/win/accessibility/aria-toggle-button-with-title-expected.txt: Removed.

1:17 PM Changeset in webkit [182074] by Chris Dumez

• 2 edits in trunk/Source/WebKit2

[WK2][NetworkCache] Rename requestNeedsRevalidation() to requestRequiresRevalidation()
​https://bugs.webkit.org/show_bug.cgi?id=143137

Reviewed by Antti Koivisto.

Rename requestNeedsRevalidation() to requestRequiresRevalidation() as I
think it is more accurate. It is not the request that needs revalidating.
The requests just requires us to revalidate the response.

• NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::requestRequiresRevalidation):
(WebKit::NetworkCache::canUse):
(WebKit::NetworkCache::requestNeedsRevalidation): Deleted.

12:44 PM WindowsWithoutCygwin edited by mmaxfield@apple.com

(diff)

12:34 PM WindowsWithoutCygwin edited by mmaxfield@apple.com

(diff)

12:04 PM Changeset in webkit [182073] by oliver@apple.com

• 13 edits in trunk/Source

Forward additional CFNetwork ATS information to child processes
​https://bugs.webkit.org/show_bug.cgi?id=143136

Reviewed by Anders Carlsson.

Source/WebCore:

Declare SPI.

• platform/spi/cf/CFNetworkSPI.h:

Source/WebKit2:

Add additional process creation parameter information, and pass it
to the child processes that actually use CFNetwork.

• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

• Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):

• Shared/Network/NetworkProcessCreationParameters.h:
• Shared/Plugins/PluginProcessCreationParameters.cpp:

(WebKit::PluginProcessCreationParameters::encode):
(WebKit::PluginProcessCreationParameters::decode):

• Shared/Plugins/PluginProcessCreationParameters.h:
• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInitializeNetworkProcess):

• UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::platformInitializePluginProcess):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

12:04 PM Changeset in webkit [182072] by mark.lam@apple.com

• 2 edits in trunk/LayoutTests

Gardening: skipping inspector-protocol/debugger/setBreakpoint-dfg-and-modify-local.html until crash is fixed.
<​https://webkit.org/b/143105>

Not reviewed.

• TestExpectations:

11:24 AM Changeset in webkit [182071] by Chris Dumez

• 9 edits
  2 adds in trunk

[WK2][NetworkCache] We only cache responses with status codes that are cacheable by default
​https://bugs.webkit.org/show_bug.cgi?id=143125
<rdar://problem/20321172>

Reviewed by Antti Koivisto.

Source/WebCore:

Export a couple of extra symbols.

• platform/network/ResourceResponseBase.h:

Source/WebKit2:

We Previously only cached responses with status codes that are cacheable
by default [1]. However, RFC 7234 [2] allows us to cache responses with
other status codes, as long as they have explicit headers allowing
caching:

• 'Expires' header field
• 'max-age' response directive

This patch updates our caching policy accordingly to improve efficiency.

[1] ​http://tools.ietf.org/html/rfc7231#page-48
[2] ​http://tools.ietf.org/html/rfc7234#section-4.3.2

Test: http/tests/cache/disk-cache/disk-cache-307-status-code.html

• NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::canStore):

LayoutTests:

Add layout test to check that responses with status code 307 (which is not
cacheable by default) are cached if they have explicit expiration headers.

Also update a couple of other disk cache tests to cover heuristic
freshness (​http://tools.ietf.org/html/rfc7234#section-4.2.2), relying on
'Last-Modified' header to estimate freshness if usual expiration headers
are not available.

• http/tests/cache/disk-cache/disk-cache-204-status-code-expected.txt:
• http/tests/cache/disk-cache/disk-cache-204-status-code.html:
• http/tests/cache/disk-cache/disk-cache-307-status-code-expected.txt: Added.
• http/tests/cache/disk-cache/disk-cache-307-status-code.html: Added.
• http/tests/cache/disk-cache/disk-cache-404-status-code-expected.txt:
• http/tests/cache/disk-cache/disk-cache-404-status-code.html:

11:00 AM Changeset in webkit [182070] by Csaba Osztrogonác

• 2 edits in trunk/LayoutTests

Unreviewed gardening.

• js/script-tests/array-length-shortening.js: Unskip, r182058 fixed it.

10:30 AM Changeset in webkit [182069] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

HTMLMediaElement will fire 'seeked' before seek completes, leading to currentTime discontinuities.
​https://bugs.webkit.org/show_bug.cgi?id=143132

Reviewed by Eric Carlson.

When seeking, if the ready state rises to >= HAVE_CURRENT_DATA, we will fire the 'seeked'
event and continue playback. However, if a media engine updates the ready state before its
seek operation actually completes, the currentTime it returns may still be the time before
the seek.

Wait until both the ready state rises to HAVE_CURRENT_DATA and m_player->seeking() returns
false before firing the 'seeked' event.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

10:27 AM Changeset in webkit [182068] by ggaren@apple.com

• 28 edits in trunk/Source

Make some more objects use FastMalloc
​https://bugs.webkit.org/show_bug.cgi?id=143122

Reviewed by Csaba Osztrogonác.

Source/JavaScriptCore:

• API/JSCallbackObject.h:
• heap/IncrementalSweeper.h:
• jit/JITThunks.h:
• runtime/JSGlobalObjectDebuggable.h:
• runtime/RegExpCache.h:

Source/WebCore:

• Modules/geolocation/GeolocationController.h:
• Modules/geolocation/NavigatorGeolocation.h:
• Modules/indexeddb/DOMWindowIndexedDatabase.h:
• Modules/notifications/NotificationController.h:
• Modules/webdatabase/DatabaseServer.h:
• css/CSSFontFaceSource.h:
• html/HTMLMediaSession.h:
• inspector/InspectorIndexedDBAgent.h:
• inspector/InspectorReplayAgent.h:
• page/CaptionUserPreferencesMediaAF.h:
• page/PageConsoleClient.h:
• page/PageDebuggable.h:
• page/animation/CSSPropertyAnimation.cpp:
• page/mac/ServicesOverlayController.h:
• platform/RemoteCommandListener.h:
• platform/Timer.h:
• platform/audio/MediaSessionManager.h:
• platform/mac/SystemSleepListenerMac.h:
• platform/mac/ThemeMac.h:
• rendering/svg/RenderSVGResourceSolidColor.h:
• replay/ReplayController.h:

10:02 AM Changeset in webkit [182067] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

FEMorphology::platformApplyGeneric() should bail out if the radius is less than or equal to zero.
​https://bugs.webkit.org/show_bug.cgi?id=142885.

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2015-03-27
Reviewed by Dean Jackson.

Source/WebCore:

FEMorphology class implementation code clean up.

Tests: svg/filters/feMorphology-radius-cases.svg

• platform/graphics/filters/FEMorphology.cpp:

(WebCore::shouldSupersedeExtremum): Reuse code instead of repeating it and
use < and > instead of =< and >=.

(WebCore::pixelArrayIndex): Returns the array index of a pixel in an image
buffer, given: position(x, y), image width and the color channel.

(WebCore::columnExtremum): Returns the extremum of a column of pixels.

(WebCore::kernelExtremum): Returns the extremum of a filter kernel.

(WebCore::FEMorphology::platformApplyGeneric): Apply some code clean-up.
The kernel size should be equal to radius of the filter. The extra pixel
was causing the resulted image to be asymmetric in some cases.

(WebCore::FEMorphology::platformApplyDegenerate):
(WebCore::FEMorphology::platformApplySoftware): After applying scaling, we
still need to check the resulted radius is negative (overflow case) or less
than one (zero radius case) and treat these cases differently.

(WebCore::FEMorphology::morphologyOperator): Deleted.
(WebCore::FEMorphology::radiusX): Deleted.
(WebCore::FEMorphology::radiusY): Deleted.

• platform/graphics/filters/FEMorphology.h:

(WebCore::FEMorphology::morphologyOperator):
(WebCore::FEMorphology::radiusX):
(WebCore::FEMorphology::radiusY):
Move a single line functions from the source file to the header file.

LayoutTests:

• svg/filters/feMorphology-radius-cases-expected.svg: Added.
• svg/filters/feMorphology-radius-cases.svg: Added.

Test different cases for radius of the feMorphology filter. There are three
cases for the radius:

1. radius < 0: This is an error case, the source image should not be rendered.
2. radius = 0: This case is treated as if the filter never exists.
3. radius > 0: If the scaled radius is > 0, the filter is applied.

10:00 AM Changeset in webkit [182066] by bshafiei@apple.com

• 2 edits in tags/Safari-601.1.23.4/Source/WebCore

Merged r182052. rdar://problem/20263463

9:59 AM Changeset in webkit [182065] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Fix WinCairo bot.
​https://bugs.webkit.org/show_bug.cgi?id=143086

Patch by Alex Christensen <​achristensen@webkit.org> on 2015-03-27
Reviewed by Brent Fulgham.

• Scripts/webkitdirs.pm:

(buildVisualStudioProject):
(runSvnUpdateAndResolveChangeLogs):
Use ActivePerl-friendly perl.

9:49 AM Changeset in webkit [182064] by Antti Koivisto

• 4 edits
  2 moves in trunk/Source/WebCore

Move CacheValidation to platform
​https://bugs.webkit.org/show_bug.cgi?id=143133

Reviewed by Chris Dumez.

It deals with platform types only and is currently violating layering.

• WebCore.xcodeproj/project.pbxproj:
• loader/cache/CacheValidation.cpp: Removed.
• loader/cache/CacheValidation.h: Removed.
• platform/network/CacheValidation.cpp: Copied from Source/WebCore/loader/cache/CacheValidation.cpp.
• platform/network/CacheValidation.h: Copied from Source/WebCore/loader/cache/CacheValidation.h.

9:42 AM Changeset in webkit [182063] by Csaba Osztrogonác

• 2 edits in trunk/Tools

URTBF after r182059 to fix the EFL build.

• TestWebKitAPI/CMakeLists.txt:

9:15 AM Changeset in webkit [182062] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r177896.
​https://bugs.webkit.org/show_bug.cgi?id=142978

Loading libgstclutter.so in-process hangs web process
(Requested by mcatanzaro on #webkit).

Reverted changeset:

"[GStreamer] Disable gst-plugin-scanner if seccomp filters are
enabled"
​https://bugs.webkit.org/show_bug.cgi?id=140069
​http://trac.webkit.org/changeset/177896

8:29 AM Changeset in webkit [182061] by bshafiei@apple.com

• 5 edits in tags/Safari-601.1.23.4/Source

Versioning.

8:26 AM Changeset in webkit [182060] by bshafiei@apple.com

• 1 copy in tags/Safari-601.1.23.4

New tag.

8:13 AM Changeset in webkit [182059] by Antti Koivisto

• 11 edits
  2 adds in trunk

Respect cache-control directives in request
​https://bugs.webkit.org/show_bug.cgi?id=143121
Source/WebCore:

rdar://problem/19714040

Reviewed by Chris Dumez.

Test: http/tests/cache/disk-cache/disk-cache-request-headers.html

• loader/cache/CacheValidation.cpp:

(WebCore::isCacheHeaderSeparator):
(WebCore::isControlCharacter):
(WebCore::trimToNextSeparator):
(WebCore::parseCacheHeader):
(WebCore::parseCacheControlDirectives):

Factor Cache-control parsing here so it can be used for both requests and responses.

• loader/cache/CacheValidation.h:
• platform/network/ResourceRequestBase.h:
• platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::ResourceResponseBase):
(WebCore::ResourceResponseBase::parseCacheControlDirectives):
(WebCore::ResourceResponseBase::cacheControlContainsNoCache):
(WebCore::ResourceResponseBase::cacheControlContainsNoStore):
(WebCore::ResourceResponseBase::cacheControlContainsMustRevalidate):
(WebCore::ResourceResponseBase::cacheControlMaxAge):
(WebCore::isCacheHeaderSeparator): Deleted.
(WebCore::isControlCharacter): Deleted.
(WebCore::trimToNextSeparator): Deleted.
(WebCore::parseCacheHeader): Deleted.

• platform/network/ResourceResponseBase.h:

Source/WebKit2:

rdar://problem/19714040

Reviewed by Chris Dumez.

Better support for ​https://tools.ietf.org/html/rfc7234#section-5.2.1

• NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::canUse):

Consider requests with Cache-control: no-cache and max-age=0 expired.

(WebKit::NetworkCache::canStore):

Don't store requests with Cache-control: no-store.

(WebKit::NetworkCache::Cache::store):

• NetworkProcess/cache/NetworkCache.h:
• NetworkProcess/cache/NetworkCacheStatisticsCocoa.mm:

(WebKit::NetworkCache::storeDecisionToDiagnosticKey):

LayoutTests:

Reviewed by Chris Dumez.

• http/tests/cache/disk-cache/disk-cache-request-headers-expected.txt: Added.
• http/tests/cache/disk-cache/disk-cache-request-headers.html: Added.

7:28 AM Changeset in webkit [182058] by msaboff@apple.com

• 3 edits
  3 adds in trunk

Objects with numeric properties intermittently get a phantom 'length' property
​https://bugs.webkit.org/show_bug.cgi?id=142792

Reviewed by Csaba Osztrogonác.

Source/JavaScriptCore:

Fixed a > (greater than) that should be a >> (right shift) in the code that disassembles
test and branch instructions. This function is used for linking tbz/tbnz branches between
two seperately JIT'ed sections of code. Sometime we'd create a bogus tbz instruction in
the failure case checks in the GetById array length stub created for "obj.length" access.
If the failure case code address was at a negative offset from the stub, we'd look for bit 1
being set when we should have been looking for bit 0.

• assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::disassembleTestAndBranchImmediate):

LayoutTests:

New regression test.

• js/regress-142792-expected.txt: Added.
• js/regress-142792.html: Added.
• js/script-tests/regress-142792.js: Added.

(isArrayLike):
(filter):

4:08 AM Changeset in webkit [182057] by Yusuke Suzuki

• 8 edits
  2 adds in trunk/Source/JavaScriptCore

Insert exception check around toPropertyKey call
​https://bugs.webkit.org/show_bug.cgi?id=142922

Reviewed by Geoffrey Garen.

In some places, exception check is missing after/before toPropertyKey.
However, since it calls toString, it's observable to users,

Missing exception checks in Object.prototype methods can be
observed since it would be overridden with toObject(null/undefined) errors.
We inserted exception checks after toPropertyKey.

Missing exception checks in GetById related code can be
observed since it would be overridden with toObject(null/undefined) errors.
In this case, we need to insert exception checks before/after toPropertyKey
since RequireObjectCoercible followed by toPropertyKey can cause exceptions.

JSValue::get checks null/undefined and raise an exception if |this| is null or undefined.
However, we need to check whether the baseValue is object coercible before executing JSValue::toPropertyKey.
According to the spec, we first perform RequireObjectCoercible and check the exception.
And second, we perform ToPropertyKey and check the exception.
Since JSValue::toPropertyKey can cause toString call, this is observable to users.
For example, if the target is not object coercible,
ToPropertyKey should not be executed, and toString should not be executed by ToPropertyKey.
So the order of observable actions (RequireObjectCoercible and ToPropertyKey) should be correct to the spec.

This patch introduces JSValue::requireObjectCoercible and use it because of the following 2 reasons.

1. Using toObject instead of requireObjectCoercible produces unnecessary wrapper object.

toObject converts primitive types into wrapper objects.
But it is not efficient since wrapper objects are not necessary
if we look up methods from primitive values's prototype. (using synthesizePrototype is better).

2. Using the result of toObject is not correct to the spec.

To align to the spec correctly, we cannot use JSObject::get
by using the wrapper object produced by the toObject suggested in (1).
If we use JSObject that is converted by toObject, getter will be called by using this JSObject as |this|.
It is not correct since getter should be called with the original |this| value that may be primitive types.

So in this patch, we use JSValue::requireObjectCoercible
to check the target is object coercible and raise an error if it's not.

• dfg/DFGOperations.cpp:
• jit/JITOperations.cpp:

(JSC::getByVal):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::getByVal):

• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/JSCJSValue.h:
• runtime/JSCJSValueInlines.h:

(JSC::JSValue::requireObjectCoercible):

• runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncHasOwnProperty):
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):
(JSC::objectProtoFuncPropertyIsEnumerable):

• tests/stress/exception-in-to-property-key-should-be-handled-early-in-object-methods.js: Added.

(shouldThrow):
(if):

• tests/stress/exception-in-to-property-key-should-be-handled-early.js: Added.

(shouldThrow):
(.):

3:31 AM Changeset in webkit [182056] by vjaquez@igalia.com

• 5 edits in trunk

[GStreamer] share GL context in pipeline, part 2
​https://bugs.webkit.org/show_bug.cgi?id=143049

Reviewed by Carlos Garcia Campos.

.:

• Source/cmake/OptionsGTK.cmake: USE_GSTREAMER_GL is set only if

OpenGL/ES2 is found and GLX/EGL is found too.

Source/WebCore:

This patch, instead of cluttering the GstGL attributes creation in
::handleSyncMessage(), creates a new method ::ensureGstGLContext(),
where those attributes are defined. This method is guarded by
USE(GSTREAMER_GL)

::handlSyncMessage() shall return nothing, according to GStreamer
documentation, not a boolean.

The GstGL attributes are now GRefPtr<> to avoid memory leaks.

The GstGLAPI and GstGLPlatform are now set given by the pre-processor
directives, and the code in ::ensureGstGLContext() is simpler.

No new tests because this is platform specific and it depends in the
run-time availability and configurations of GstGL elements.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
Don't initialise the GstGL attributes since are GRefPtr<>
(WebCore::MediaPlayerPrivateGStreamer::handleSyncMessage): Changed the
signature to use void instead of gboolean.
(WebCore::MediaPlayerPrivateGStreamer::ensureGstGLContext): New method.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

12:26 AM Changeset in webkit [182055] by timothy@apple.com

• 15 edits in trunk/Source/WebInspectorUI

Web Inspector: Convert more misc View classes to ES6
​https://bugs.webkit.org/show_bug.cgi?id=143128

Reviewed by Joseph Pecoraro.

• UserInterface/Views/CompletionSuggestionsView.js:
• UserInterface/Views/ComputedStyleDetailsPanel.js:
• UserInterface/Views/DashboardContainerView.js:
• UserInterface/Views/DashboardView.js:
• UserInterface/Views/DebuggerDashboardView.js:
• UserInterface/Views/DefaultDashboardView.js:
• UserInterface/Views/FilterBarButton.js:
• UserInterface/Views/MetricsStyleDetailsPanel.js:
• UserInterface/Views/ObjectPreviewView.js:
• UserInterface/Views/ObjectTreeView.js:
• UserInterface/Views/QuickConsole.js:
• UserInterface/Views/ReplayDashboardView.js:
• UserInterface/Views/RulesStyleDetailsPanel.js:
• UserInterface/Views/StyleDetailsPanel.js:

Converted to ES6 classes.

12:26 AM Changeset in webkit [182054] by timothy@apple.com

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Convert TextEditor classes to ES6
​https://bugs.webkit.org/show_bug.cgi?id=143127

Reviewed by Joseph Pecoraro.

• UserInterface/Views/CSSStyleDeclarationTextEditor.js:

Removed a comment about const, we can't use it in strict mode / classes.

• UserInterface/Views/SourceCodeTextEditor.js:
• UserInterface/Views/TextEditor.js:

Converted to ES6 classes.