Timeline



Mar 29, 2015:

9:17 PM Changeset in webkit [182133] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

Fix iOS scrollperf crash after a web process crash
​https://bugs.webkit.org/show_bug.cgi?id=143110

Reviewed by Dean Jackson.

When we destroy the drawing area after a web process crash, we also need to destroy
the scrollingPerformanceData which has a reference to the drawing area.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetState):

9:13 PM Changeset in webkit [182132] by Simon Fraser
  • 24 edits in trunk/Source

Convert arguments to ScrollingCoordinator functions to references
​https://bugs.webkit.org/show_bug.cgi?id=143198

Reviewed by Darin Adler.

Convert all the FrameView* and ScrollableArea* arguments to ScrollingCoordinator functions to
references, and use references in a few other places.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::wheelEventHandlerCountChanged):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState):

  • page/DebugPageOverlays.cpp:

(WebCore::NonFastScrollableRegionOverlay::updateRegion):

  • page/Frame.cpp:

(WebCore::Frame::willDetachPage):

  • page/FrameView.cpp:

(WebCore::FrameView::prepareForDetach):
(WebCore::FrameView::addSlowRepaintObject):
(WebCore::FrameView::removeSlowRepaintObject):
(WebCore::FrameView::addViewportConstrainedObject):
(WebCore::FrameView::removeViewportConstrainedObject):
(WebCore::FrameView::requestScrollPositionUpdate):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::scrollableAreaSetChanged):
(WebCore::FrameView::wheelEvent):

  • page/Page.cpp:

(WebCore::Page::nonFastScrollableRects):

  • page/Page.h:
  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::frameViewNonFastScrollableRegionChanged):
(WebCore::AsyncScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):
(WebCore::AsyncScrollingCoordinator::scrollableAreaScrollbarLayerDidChange):
(WebCore::AsyncScrollingCoordinator::ensureRootStateNodeForFrameView):
(WebCore::AsyncScrollingCoordinator::updateMainFrameScrollLayerPosition):
(WebCore::AsyncScrollingCoordinator::recomputeWheelEventHandlerCountForFrameView):

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::pageDestroyed):
(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):
(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewWheelEventHandlerCountChanged):
(WebCore::ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange):
(WebCore::ScrollingCoordinator::frameViewFixedObjectsDidChange):
(WebCore::ScrollingCoordinator::scrollLayerForScrollableArea):
(WebCore::ScrollingCoordinator::scrollLayerForFrameView):
(WebCore::ScrollingCoordinator::headerLayerForFrameView):
(WebCore::ScrollingCoordinator::footerLayerForFrameView):
(WebCore::ScrollingCoordinator::counterScrollingLayerForFrameView):
(WebCore::ScrollingCoordinator::insetClipLayerForFrameView):
(WebCore::ScrollingCoordinator::contentShadowLayerForFrameView):
(WebCore::ScrollingCoordinator::rootContentLayerForFrameView):
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects):
(WebCore::ScrollingCoordinator::synchronousScrollingReasons):
(WebCore::ScrollingCoordinator::updateSynchronousScrollingReasons):
(WebCore::ScrollingCoordinator::setForceSynchronousScrollLayerPositionUpdates):
(WebCore::ScrollingCoordinator::shouldUpdateScrollLayerPositionSynchronously):
(WebCore::ScrollingCoordinator::replaySessionStateDidChange):
(WebCore::ScrollingCoordinator::synchronousScrollingReasonsAsText):

  • page/scrolling/ScrollingCoordinator.h: Align the bitmask enums to make mistakes easier to spot.

(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::frameViewNonFastScrollableRegionChanged):
(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
(WebCore::ScrollingCoordinator::handleWheelEvent):
(WebCore::ScrollingCoordinator::willDestroyScrollableArea):
(WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):
(WebCore::ScrollingCoordinator::scrollableAreaScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::recomputeWheelEventHandlerCountForFrameView):

  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:

(WebCore::ScrollingCoordinatorCoordinatedGraphics::scrollableAreaScrollLayerDidChange):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::willDestroyScrollableArea):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::requestScrollPositionUpdate):

  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
  • page/scrolling/ios/ScrollingCoordinatorIOS.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::handleWheelEvent):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::~RenderLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateOverflowControlsLayers):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::hasCoordinatedScrolling):
(WebCore::RenderLayerCompositor::scrollingLayerDidChange):
(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore::RenderLayerCompositor::updateLayerForFooter):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::destroyRootLayer):
(WebCore::RenderLayerCompositor::updateScrollCoordinationForThisFrame):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::willRemoveScrollingLayerWithBacking):
(WebCore::RenderLayerCompositor::didAddScrollingLayer):

  • testing/Internals.cpp:

(WebCore::Internals::nonFastScrollableRects):

Source/WebKit2:

  • WebProcess/Scrolling/RemoteScrollingCoordinator.h:
  • WebProcess/Scrolling/RemoteScrollingCoordinator.mm:

(WebKit::RemoteScrollingCoordinator::coordinatesScrollingForFrameView):

8:43 PM WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
8:12 PM Changeset in webkit [182131] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebCore

Use :matches() instead of :-webkit-any() for the sections and headings default style
​https://bugs.webkit.org/show_bug.cgi?id=143197

Reviewed by Darin Adler.

We no longer need to use the :-webkit-any() hack in the default stylesheet.

The pseudo class :matches() also support correct specificity. This is not observable
since those selector do not conflict with any other rule in the default stylesheet.

  • css/CSSSelector.h:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::determineLinkMatchType):

  • css/html.css:

(:matches(article, aside, nav, section) h1):
(:matches(article, aside, nav, section) :matches(article, aside, nav, section) h1):
(:matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) h1):
(:matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) h1):
(:matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) h1):
(:-webkit-any(article,aside,nav,section) h1): Deleted.
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): Deleted.
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): Deleted.
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): Deleted.
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): Deleted.

8:10 PM Changeset in webkit [182130] by benjamin@webkit.org
  • 5 edits
    6 adds in trunk

currentColor computes to the same colour on all elements, even if 'color' is inherited differently
​https://bugs.webkit.org/show_bug.cgi?id=133420

Reviewed by Darin Adler.

Source/WebCore:

When resolving a style with the help of the property cache, we were
completely ignoring currentColor.

Since you can set currentColor on properties that are not inherited,
those properties would just be copied from the cached style, which
may have a completely different inherited color.

This pacth fixes the issue by preventing any MatchResult from hitting
the cache if it contains any non-inherited property that would require
resolution by the cache:
-Using the inherit value.
-Using the currentColor value.

Tests: fast/css/currentColor-on-before-after-pseudo-elements.html

fast/css/currentColor-style-update-reftest.html
fast/css/currentColor-value-style-update.html

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::addElementStyleProperties):
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchUserRules):
(WebCore::ElementRuleCollector::matchUARules):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchResult::addMatchedProperties):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::findFromMatchedPropertiesCache):
(WebCore::StyleResolver::addToMatchedPropertiesCache):
(WebCore::extractDirectionAndWritingMode):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::CascadedProperties::addStyleProperties):
(WebCore::StyleResolver::CascadedProperties::addMatches):

  • css/StyleResolver.h:

(WebCore::StyleResolver::MatchResult::matchedProperties):

LayoutTests:

  • fast/css/currentColor-on-before-after-pseudo-elements-expected.html: Added.
  • fast/css/currentColor-on-before-after-pseudo-elements.html: Added.
  • fast/css/currentColor-style-update-reftest-expected.html: Added.
  • fast/css/currentColor-style-update-reftest.html: Added.
  • fast/css/currentColor-value-style-update-expected.txt: Added.
  • fast/css/currentColor-value-style-update.html: Added.
8:05 PM Changeset in webkit [182129] by benjamin@webkit.org
  • 10 edits in trunk/Source/WebCore

Enable :any-link by default
​https://bugs.webkit.org/show_bug.cgi?id=143201

Reviewed by Sam Weinig.

The pseudo class :any-link has been stable for a while. This patch enables
it by default and remove the -webkit- prefix on the default style.

  • css/CSSDefaultStyleSheets.cpp:
  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:
  • css/RuleSet.cpp:

(WebCore::RuleSet::addRule):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::isCommonPseudoClassSelector):

  • css/SelectorPseudoClassAndCompatibilityElementMap.in:
  • css/html.css:

(a:any-link):
(a:any-link:active):
(:any-link img):
(a:-webkit-any-link): Deleted.
(a:-webkit-any-link:active): Deleted.
(:-webkit-any-link img): Deleted.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementLinkMatching):

7:27 PM Changeset in webkit [182128] by gyuyoung.kim@samsung.com
  • 4 edits
    1 delete in trunk

[CMake] Update old CMakeList.txt in gtest
​https://bugs.webkit.org/show_bug.cgi?id=143192

Reviewed by Darin Adler.

CMake ports have used cmake/gtest/CMakeLists.txt instead of ThirdParty/test/CMakeLists.txt
in order to build gtest. However it looks ThirdParty/test/CMakeLists.txt won't be used anymore.
So this patch moves cmake/gtest/CMakeLists.txt to ThirdPart/test/CMakeLists.txt, and use it.

.:

  • Source/CMakeLists.txt:
  • Source/cmake/gtest/CMakeLists.txt: Removed.

Source/ThirdParty:

  • gtest/CMakeLists.txt:
7:00 PM Changeset in webkit [182127] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

nullptr cleanup in RenderFooBox classes
​https://bugs.webkit.org/show_bug.cgi?id=143182

Patch by Joonghun Park <​jh718.park@samsung.com> on 2015-03-29
Reviewed by Ryosuke Niwa.

No new tests, no behavior changes

Replace 0 with nullptr in RenderFooBox classes.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::RenderBox):
(WebCore::RenderBox::paintFillLayer):
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::positionForPoint):
(WebCore::RenderBox::layoutOverflowRectForPropagation):

  • rendering/RenderBox.h:

(WebCore::RenderBox::setMarginBefore):
(WebCore::RenderBox::setMarginAfter):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::createAnonymousBoxWithSameTypeAs):
(WebCore::RenderBox::setInlineBoxWrapper):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::willBeDestroyed):
(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::firstLetterRemainingText):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::moveChildTo):
(WebCore::RenderBoxModelObject::moveAllChildrenTo):
(WebCore::RenderBoxModelObject::moveChildrenTo):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::reset):
(WebCore::FlexBoxIterator::next):

  • rendering/RenderDeprecatedFlexibleBox.h:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::firstLineBaseline):
(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::deleteLineBoxTree):
(WebCore::RenderLineBoxList::extractLineBox):
(WebCore::RenderLineBoxList::deleteLineBoxes):
(WebCore::RenderLineBoxList::checkConsistency):

  • rendering/RenderLineBoxList.h:

(WebCore::RenderLineBoxList::RenderLineBoxList):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::enclosingScrollableArea):
(WebCore::RenderListBox::setHasVerticalScrollbar):

  • rendering/RenderListBox.h:
6:03 PM Changeset in webkit [182126] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS WK2] WKContentView should implement _selectionClipRect
​https://bugs.webkit.org/show_bug.cgi?id=143143
rdar://problem/20330075

Reviewed by Benjamin Poulain.

UIKit checks if the text delegate responds to this selector
to retrieve the clipping rectangle for the editable element
where the selection is being create.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _selectionClipRect]):

5:33 PM Changeset in webkit [182125] by Darin Adler
  • 3 edits
    2 adds in trunk

HTMLCollection caches incorrect length if item(0) is called before length on an empty collection
​https://bugs.webkit.org/show_bug.cgi?id=143203
Source/WebCore:

rdar://problem/18460462

Reviewed by Antti Koivisto.

Test: fast/dom/htmlcollection-length-after-item-2.html

  • dom/CollectionIndexCache.h:

(CollectionIndexCache::nodeAt): If we hit the end looking for index 0, cache a length
of 0, not a length of 1.

LayoutTests:

Reviewed by Antti Koivisto.

  • fast/dom/htmlcollection-length-after-item-2-expected.txt: Added.
  • fast/dom/htmlcollection-length-after-item-2.html: Added.
4:43 PM Changeset in webkit [182124] by Antti Koivisto
  • 4 edits in trunk/Source/WebKit2

Use st_mtime instead of st_atime to track file access time
​https://bugs.webkit.org/show_bug.cgi?id=143200

Reviewed by Darin Adler.

On OS X atime updates automatically on read so calling Storage::traverse() would always ends up updating access times
for all cache entries to the current time. This would make entry worth computation produce unexpected results.
We update mtime manually on successful cache retrieve only so switching to it fixes the problem.

  • NetworkProcess/cache/NetworkCacheFileSystemPosix.h:

(WebKit::NetworkCache::fileTimes):
(WebKit::NetworkCache::updateFileModificationTimeIfNeeded):
(WebKit::NetworkCache::updateFileAccessTimeIfNeeded): Deleted.

  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::updateFileModificationTime):
(WebKit::NetworkCache::Storage::dispatchReadOperation):
(WebKit::NetworkCache::deletionProbability):
(WebKit::NetworkCache::Storage::updateFileAccessTime): Deleted.

  • NetworkProcess/cache/NetworkCacheStorage.h:
2:54 PM Changeset in webkit [182123] by mmaxfield@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[Win] Addresing post-review comment after r182122
​https://bugs.webkit.org/show_bug.cgi?id=143189

Unreviewed.

1:56 PM Changeset in webkit [182122] by mmaxfield@apple.com
  • 8 edits
    1 copy in trunk/Source/JavaScriptCore

[Win] Allow building JavaScriptCore without Cygwin
​https://bugs.webkit.org/show_bug.cgi?id=143189

Reviewed by Brent Fulgham.

Paths like /usr/bin/ don't exist on Windows.
Hashbangs don't work on Windows. Instead we must explicitly call the executable.
Prefixing commands with environment variables doesn't work on Windows.
Windows doesn't have 'cmp'
Windows uses 'del' instead of 'rm'
Windows uses 'type NUL' intead of 'touch'

  • DerivedSources.make:
  • JavaScriptCore.vcxproj/JavaScriptCoreGenerated.make:
  • JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.make:
  • JavaScriptCore.vcxproj/LLInt/LLIntAssembly/build-LLIntAssembly.pl:
  • JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.make:
  • JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/build-LLIntDesiredOffsets.pl:
  • JavaScriptCore.vcxproj/build-generated-files.pl:
  • UpdateContents.py: Copied from Source/JavaScriptCore/JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/build-LLIntDesiredOffsets.pl.
1:40 PM Changeset in webkit [182121] by Darin Adler
  • 124 edits in trunk/Source/WebCore

Remove unneeded SVG code, including most isSupportedAttribute functions
​https://bugs.webkit.org/show_bug.cgi?id=143194

Reviewed by Antti Koivisto.

  • Removed most implementations of isSupportedAttribute. Others can be removed in future patches. The ones left behind are now all private static member functions. It's dangerous for them to be public because they tend to indicate which attributes are supported at a particular level in the class hierarchy and they are not virtual functions; might want to rethink the function name if we keep any of these long term.
  • Removed unneeded includes, especially of Attr.h and Attribute.h.
  • Changed most parseAttribute and svgAttributeChanged functions so they no longer rely on checking attribute names against a set. Also removed lots of unneeded calls to SVGLangSpace::parseAttribute, which is called by SVGElement::parseAttribute and need not be called by derived classes.
  • Removed return values from parseAttribute functions. Skipping other parseAttribute logic is not an important optimization and makes functions needlessly complex.
  • Moved use of InstanceInvalidationGuard closer to where they are needed. Eventually we may be able to remove many of these.
  • Used auto in a few places where the same type is repeated twice on the same line of code, and auto makes it a bit smaller.
  • Got rid of protected sections in some final classes; doesn't make sense to combine these two. Also moved a few functions from protected to private in other classes.
  • Made a number of functions into static member functions in the base classes such as SVGLangSpace; they were not making any use of the object, and so it was wasteful to compile them as non-static member functions.
  • rendering/svg/RenderSVGImage.cpp: Removed unneeded includes.
  • svg/SVGAElement.cpp: Removed unneeded includes.

(WebCore::SVGAElement::isSupportedAttribute): Deleted.
(WebCore::SVGAElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGAElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGAElement.h: Removed isSupportedAttribute.
  • svg/SVGAnimateMotionElement.cpp: Removed unneeded includes.

(WebCore::SVGAnimateMotionElement::isSupportedAttribute): Deleted.
(WebCore::SVGAnimateMotionElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGAnimateMotionElement.h: Removed isSupportedAttribute.
  • svg/SVGAnimateTransformElement.cpp:

(WebCore::SVGAnimateTransformElement::isSupportedAttribute): Deleted.
(WebCore::SVGAnimateTransformElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGAnimateTransformElement.h: Removed isSupportedAttribute.
  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::isSupportedAttribute): Deleted.
(WebCore::SVGCircleElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGCircleElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGCircleElement.h: Removed isSupportedAttribute.
  • svg/SVGClipPathElement.cpp: Removed unneeded includes.

(WebCore::SVGClipPathElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGComponentTransferFunctionElement.cpp:

(WebCore::SVGComponentTransferFunctionElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGCursorElement.cpp: Removed unneeded includes.

(WebCore::SVGCursorElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGCursorElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGElement.cpp: Removed unneeded includes.
  • svg/SVGEllipseElement.cpp: Removed unneeded includes.

(WebCore::SVGEllipseElement::isSupportedAttribute): Deleted.
(WebCore::SVGEllipseElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGEllipseElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGEllipseElement.h: Removed isSupportedAttribute.
  • svg/SVGExternalResourcesRequired.cpp: Removed unneeded includes.

(WebCore::SVGExternalResourcesRequired::parseAttribute): Don't return a boolean.

  • svg/SVGExternalResourcesRequired.h: Don't return a boolean.
  • svg/SVGFEBlendElement.cpp: Removed unneeded includes.

(WebCore::SVGFEBlendElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEBlendElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEBlendElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEBlendElement.h: Removed isSupportedAttribute.
  • svg/SVGFEColorMatrixElement.cpp: Removed unneeded includes.

(WebCore::SVGFEColorMatrixElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEColorMatrixElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEColorMatrixElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEColorMatrixElement.h: Removed isSupportedAttribute.
  • svg/SVGFEComponentTransferElement.cpp: Removed unneeded includes.

(WebCore::SVGFEComponentTransferElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEComponentTransferElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGFEComponentTransferElement.h: Removed unneeded includes.
  • svg/SVGFECompositeElement.cpp: Removed unneeded includes.

(WebCore::SVGFECompositeElement::isSupportedAttribute): Deleted.
(WebCore::SVGFECompositeElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFECompositeElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp: Removed unneeded includes.

(WebCore::SVGFEConvolveMatrixElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEConvolveMatrixElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: Removed unneeded includes.

(WebCore::SVGFEDiffuseLightingElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEDiffuseLightingElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp: Removed unneeded includes.

(WebCore::SVGFEDisplacementMapElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEDisplacementMapElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEDisplacementMapElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDropShadowElement.cpp: Removed unneeded includes.

(WebCore::SVGFEDropShadowElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEDropShadowElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEDropShadowElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEDropShadowElement.h:
  • svg/SVGFEFloodElement.cpp: Removed unneeded includes.
  • svg/SVGFEGaussianBlurElement.cpp: Removed unneeded includes.

(WebCore::SVGFEGaussianBlurElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEGaussianBlurElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEGaussianBlurElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp: Removed unneeded includes.

(WebCore::SVGFEImageElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEImageElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEImageElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEImageElement.h:
  • svg/SVGFELightElement.cpp: Removed unneeded includes.

(WebCore::SVGFELightElement::isSupportedAttribute): Deleted.
(WebCore::SVGFELightElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFELightElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeNodeElement.cpp: Removed unneeded includes.

(WebCore::SVGFEMergeNodeElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEMergeNodeElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEMergeNodeElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMorphologyElement.cpp: Removed unneeded includes.

(WebCore::SVGFEMorphologyElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEMorphologyElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEMorphologyElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp: Removed unneeded includes.

(WebCore::SVGFEOffsetElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEOffsetElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEOffsetElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp: Removed unneeded includes.

(WebCore::SVGFESpecularLightingElement::isSupportedAttribute): Deleted.
(WebCore::SVGFESpecularLightingElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFESpecularLightingElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp: Removed unneeded includes.

(WebCore::SVGFETileElement::isSupportedAttribute): Deleted.
(WebCore::SVGFETileElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFETileElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp: Removed unneeded includes.

(WebCore::SVGFETurbulenceElement::isSupportedAttribute): Deleted.
(WebCore::SVGFETurbulenceElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFETurbulenceElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.cpp: Removed unneeded includes.

(WebCore::SVGFilterElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGFilterPrimitiveStandardAttributes.cpp: Removed unneeded includes.

(WebCore::SVGFilterPrimitiveStandardAttributes::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGFilterPrimitiveStandardAttributes.h: Removed isSupportedAttribute and also moved a

couple functions out of the class definition.

  • svg/SVGFitToViewBox.cpp: Removed unneeded includes.
  • svg/SVGFontFaceElement.cpp: Removed unneeded includes.
  • svg/SVGFontFaceUriElement.cpp: Removed unneeded includes.
  • svg/SVGForeignObjectElement.cpp: Removed unneeded includes.

(WebCore::SVGForeignObjectElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGGElement.cpp: Removed unneeded includes.

(WebCore::SVGGElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGGlyphElement.cpp: Removed unneeded includes.
  • svg/SVGGlyphRefElement.cpp: Removed unneeded includes.

(WebCore::SVGGlyphRefElement::hasValidGlyphElement): Rewrote to use is<> instead of hasTagName.
(WebCore::SVGGlyphRefElement::parseAttribute): Don't use return value from SVGURIReference::parseAttribute.

  • svg/SVGGradientElement.cpp: Removed unneeded includes.

(WebCore::SVGGradientElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGGraphicsElement.cpp: Removed unneeded includes.

(WebCore::SVGGraphicsElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGImageElement.cpp: Removed unneeded includes.

(WebCore::SVGImageElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGLangSpace.cpp: Removed unneeded includes.

(WebCore::SVGLangSpace::parseAttribute): Removed the return value.

  • svg/SVGLangSpace.h: Converted functions to static member functions and removed the

return value from parseAttribute.

  • svg/SVGLineElement.cpp: Removed unneeded includes.

(WebCore::SVGLineElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGLinearGradientElement.cpp: Removed unneeded includes.

(WebCore::SVGLinearGradientElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGMPathElement.cpp: Removed unneeded includes.

(WebCore::SVGMPathElement::isSupportedAttribute): Deleted.
(WebCore::SVGMPathElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGMPathElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGMPathElement.h: Removed isSupportedAttribute and made didNotifySubtreeInsertions

private instead of protected.

  • svg/SVGMarkerElement.cpp: Removed unneeded includes.

(WebCore::SVGMarkerElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGMaskElement.cpp: Removed unneeded includes.

(WebCore::SVGMaskElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGPathElement.cpp: Removed unneeded includes.

(WebCore::SVGPathElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGPatternElement.cpp: Removed unneeded includes.

(WebCore::SVGPatternElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGPolyElement.cpp: Removed unneeded includes.

(WebCore::SVGPolyElement::isSupportedAttribute): Deleted.
(WebCore::SVGPolyElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGPolyElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGPolyElement.h:
  • svg/SVGRadialGradientElement.cpp: Removed unneeded includes.

(WebCore::SVGRadialGradientElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGRectElement.cpp: Removed unneeded includes.

(WebCore::SVGRectElement::isSupportedAttribute): Deleted.
(WebCore::SVGRectElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGRectElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.cpp: Removed unneeded includes.

(WebCore::SVGSVGElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGScriptElement.cpp: Removed unneeded includes.
  • svg/SVGStopElement.cpp: Removed unneeded includes.

(WebCore::SVGStopElement::isSupportedAttribute): Deleted.
(WebCore::SVGStopElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGStopElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGStopElement.h: Removed isSupportedAttribute.
  • svg/SVGStyleElement.cpp: Removed unneeded includes.

(WebCore::SVGStyleElement::isSupportedAttribute): Deleted.
(WebCore::SVGStyleElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGStyleElement.h: Removed isSupportedAttribute.
  • svg/SVGSymbolElement.cpp: Removed unneeded includes.

(WebCore::SVGSymbolElement::isSupportedAttribute): Deleted.
(WebCore::SVGSymbolElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGSymbolElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGSymbolElement.h: Removed isSupportedAttribute.
  • svg/SVGTRefElement.cpp: Removed unneeded includes.

(WebCore::SVGTRefElement::isSupportedAttribute): Deleted.
(WebCore::SVGTRefElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGTRefElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGTRefElement.h: Removed isSupportedAttribute and made didNotifySubtreeInsertions

private instead of protected.

  • svg/SVGTests.cpp: Removed unneeded includes.

(WebCore::SVGTests::parseAttribute): Removed return value.

  • svg/SVGTests.h: Removed return value of parseAttribute.
  • svg/SVGTextContentElement.cpp: Removed unneeded includes.

(WebCore::SVGTextContentElement::collectStyleForPresentationAttribute): Don't use
isSupportedAttribute. Also removed global to optimize comparing attribute value against
the string "preserve".
(WebCore::SVGTextContentElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGTextContentElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGTextContentElement.h: Made isSupportedAttribute private instead of protected.
  • svg/SVGTextElement.cpp: Removed unneeded includes.
  • svg/SVGTextPathElement.cpp: Removed unneeded includes.

(WebCore::SVGTextPathElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGTextPositioningElement.cpp: Removed unneeded includes.

(WebCore::SVGTextPositioningElement::isSupportedAttribute): Deleted.
(WebCore::SVGTextPositioningElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGTextPositioningElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGTextPositioningElement.h: Removed isSupportedAttribute and made some functions

private insetad of protected.

  • svg/SVGURIReference.cpp: Removed unneeded includes.

(WebCore::SVGURIReference::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGURIReference.h:

(WebCore::SVGURIReference::isExternalURIReference):

  • svg/SVGUseElement.cpp: Removed unneeded includes.

(WebCore::SVGUseElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGViewElement.h: Removed isSupportedAttribute.
  • svg/animation/SVGSMILElement.cpp: Removed unneeded includes.
1:38 PM Changeset in webkit [182120] by Darin Adler
  • 42 edits in trunk/Source/WebCore

Remove unneeded includes of "Attribute.h"
​https://bugs.webkit.org/show_bug.cgi?id=143195

Reviewed by Antti Koivisto.

  • css/StyleResolver.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLAreaElement.cpp:
  • html/HTMLBRElement.cpp:
  • html/HTMLBaseElement.cpp:
  • html/HTMLBodyElement.cpp:
  • html/HTMLButtonElement.cpp:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLDivElement.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFontElement.cpp:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLFrameElement.cpp:
  • html/HTMLFrameElementBase.cpp:
  • html/HTMLFrameSetElement.cpp:
  • html/HTMLHRElement.cpp:
  • html/HTMLIFrameElement.cpp:
  • html/HTMLImageElement.cpp:
  • html/HTMLOListElement.cpp:
  • html/HTMLOptionElement.cpp:
  • html/HTMLParagraphElement.cpp:
  • html/HTMLParamElement.cpp:
  • html/HTMLPlugInElement.cpp:
  • html/HTMLPreElement.cpp:
  • html/HTMLProgressElement.cpp:
  • html/HTMLScriptElement.cpp:
  • html/HTMLSelectElement.cpp:
  • html/HTMLStyleElement.cpp:
  • html/HTMLTableCaptionElement.cpp:
  • html/HTMLTableCellElement.cpp:
  • html/HTMLTableColElement.cpp:
  • html/HTMLTableElement.cpp:
  • html/HTMLTablePartElement.cpp:
  • html/HTMLTextAreaElement.cpp:
  • html/HTMLTextFormControlElement.cpp:
  • html/HTMLUListElement.cpp:
  • html/HTMLVideoElement.cpp:
  • html/parser/HTMLScriptRunner.cpp:
  • inspector/InspectorNodeFinder.cpp:

Removed includes of "Attribute.h".

11:47 AM Changeset in webkit [182119] by youenn.fablet@crf.canon.fr
  • 6 edits
    1 add in trunk/Tools

[buildbot] clean-build script should remove untracked files and revert local changes too
​https://bugs.webkit.org/show_bug.cgi?id=142400

Reviewed by Ryosuke Niwa.

This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.

  • BuildSlaveSupport/clean-build:

(main): Adding call to Tools/Scripts/clean-webkit.

  • Scripts/clean-webkit: Added.

(main): Removes untracked and changed files.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.untracked_files): Retrieves GIT untracked files.

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.untracked_files): Retrieves SVN untracked files.
(SCM):
(SCM.discard_untracked_files): Deletes untracked files/folders.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(SCMTest._shared_test_untracked_files): Unit testing for untracked files.
(test_untracked_files):
(GitSVNTest.test_untracked_files):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.untracked_files):

Mar 28, 2015:

11:58 PM Changeset in webkit [182118] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

Clean up JavaScriptCore/builtins
​https://bugs.webkit.org/show_bug.cgi?id=143177

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-28
Reviewed by Ryosuke Niwa.

  • builtins/ArrayConstructor.js:

(from):

  • We can compare to undefined instead of using a typeof undefined check.
  • Converge on double quoted strings everywhere.
  • builtins/ArrayIterator.prototype.js:

(next):

  • builtins/StringIterator.prototype.js:

(next):

  • Use shorthand object construction to avoid duplication.
  • Improve grammar in error messages.
  • tests/stress/array-iterators-next-with-call.js:
  • tests/stress/string-iterators.js:
  • Update for new error message strings.
7:07 PM Changeset in webkit [182117] by eric.carlson@apple.com
  • 8 edits
    1 move
    1 add in trunk/Source/WebCore

[Mac] Update for output device API change
​https://bugs.webkit.org/show_bug.cgi?id=143187

Reviewed by Zalan Bujtas.

The API used for output device is being deprecated, update to the replacement.

  • WebCore.xcodeproj/project.pbxproj: Add SPI headers.
  • platform/graphics/MediaPlaybackTarget.h:

(WebCore::MediaPlaybackTarget::MediaPlaybackTarget): Update for API change.
(WebCore::MediaPlaybackTarget::setDevicePickerContext):
(WebCore::MediaPlaybackTarget::devicePickerContext):

  • platform/graphics/avfoundation/MediaPlaybackTargetMac.mm:

(WebCore::MediaPlaybackTarget::encode):
(WebCore::MediaPlaybackTarget::decode):

  • platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h:
  • platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:

(WebCore::MediaPlaybackTargetPickerMac::MediaPlaybackTargetPickerMac):
(WebCore::MediaPlaybackTargetPickerMac::~MediaPlaybackTargetPickerMac):
(WebCore::MediaPlaybackTargetPickerMac::outputeDeviceAvailabilityChangedTimerFired):
(WebCore::MediaPlaybackTargetPickerMac::devicePicker):
(WebCore::MediaPlaybackTargetPickerMac::currentDeviceDidChange):
(WebCore::MediaPlaybackTargetPickerMac::stopMonitoringPlaybackTargets):
(-[WebAVOutputDeviceMenuControllerHelper observeValueForKeyPath:ofObject:change:context:]):
(-[WebAVOutputDevicePickerMenuControllerHelper observeValueForKeyPath:ofObject:change:context:]): Deleted.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setWirelessPlaybackTarget):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

  • platform/spi/cocoa/AVKitSPI.h: Copied from Source/WebCore/platform/spi/ios/AVKitSPI.h. Moved

from ios directory, added Mac includes and prototypes.

  • platform/spi/ios/AVKitSPI.h: Removed.
  • platform/spi/mac/AVFoundationSPI.h: Added.
4:17 PM Changeset in webkit [182116] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Optimize RenderLayer::intersectsDamageRect() slightly
​https://bugs.webkit.org/show_bug.cgi?id=143186

Reviewed by Zalan Bujtas.

We can early return from RenderLayer::intersectsDamageRect() if the
damageRect is empty, since nothing will intersect with the empty rect.

Slight performance gain when scrolling overflow-scroll with lots of nested,
clipping layers.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

1:44 PM Changeset in webkit [182115] by andersca@apple.com
  • 6 edits in trunk/Source

Remove an unused SPI method from WebKitLegacy
​https://bugs.webkit.org/show_bug.cgi?id=143185

Reviewed by Sam Weinig.

Source/WebCore:

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::storeCopyOfCache): Deleted.

  • loader/appcache/ApplicationCacheStorage.h:

Source/WebKit/mac:

  • WebView/WebDataSource.mm:

(-[WebDataSource _transferApplicationCache:]): Deleted.

  • WebView/WebDataSourcePrivate.h:
10:28 AM Changeset in webkit [182114] by saambarati1@gmail.com
  • 12 edits
    1 add in trunk/Source

Web Inspector: ES6: Better support for Symbol types in Type Profiler
​https://bugs.webkit.org/show_bug.cgi?id=141257

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

ES6 introduces the new primitive type Symbol. This patch makes JSC's
type profiler support this new primitive type.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • inspector/protocol/Runtime.json:
  • runtime/RuntimeType.cpp:

(JSC::runtimeTypeForValue):

  • runtime/RuntimeType.h:

(JSC::runtimeTypeIsPrimitive):

  • runtime/TypeSet.cpp:

(JSC::TypeSet::addTypeInformation):
(JSC::TypeSet::dumpTypes):
(JSC::TypeSet::doesTypeConformTo):
(JSC::TypeSet::displayName):
(JSC::TypeSet::inspectorTypeSet):
(JSC::TypeSet::toJSONString):

  • runtime/TypeSet.h:

(JSC::TypeSet::seenTypes):

  • tests/typeProfiler/driver/driver.js:
  • tests/typeProfiler/symbol.js: Added.

(wrapper.foo):
(wrapper.bar):
(wrapper.bar.bar.baz):
(wrapper):

Source/WebInspectorUI:

The Web Inspector's visualization of JSC's type profiler
should have support for the Symbol type.

  • UserInterface/Models/TypeSet.js:

(WebInspector.TypeSet):
(WebInspector.TypeSet.prototype.get primitiveTypeNames):

  • UserInterface/Views/TypeTokenView.css:

TypeTokenView will display Symbol type tokens using the same color that
Symbol values are displayed as formatted values.

(.type-token-symbol):

  • UserInterface/Views/TypeTokenView.js:

(WebInspector.TypeTokenView.prototype._displayTypeName):
(WebInspector.TypeTokenView):

9:38 AM Changeset in webkit [182113] by commit-queue@webkit.org
  • 27 edits in trunk

Web Inspector: Adopt Array.prototype.includes and String.prototype.includes
​https://bugs.webkit.org/show_bug.cgi?id=143176

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-28
Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

  • UserInterface/Base/Utilities.js:

Remove our custom implementations of Array/String contains functions.

  • UserInterface/Base/Main.js:

(WebInspector._updateContentViewForCurrentNavigationSidebar):
(WebInspector._contentBrowserCurrentContentViewDidChange):

  • UserInterface/Controllers/CodeMirrorCompletionController.js:

(WebInspector.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions.):
(WebInspector.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions):

  • UserInterface/Controllers/CodeMirrorTokenTrackingController.js:

(WebInspector.CodeMirrorTokenTrackingController.prototype._updateHoveredTokenInfo):
(WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):

  • UserInterface/Controllers/FrameResourceManager.js:

(WebInspector.FrameResourceManager.prototype._extraDomainsActivated):
(WebInspector.FrameResourceManager):

  • UserInterface/Controllers/LayerTreeManager.js:

(WebInspector.LayerTreeManager.prototype.layerTreeMutations):

  • UserInterface/Controllers/StorageManager.js:

(WebInspector.StorageManager.prototype._extraDomainsActivated):
(WebInspector.StorageManager):

  • UserInterface/Models/Branch.js:

(WebInspector.Branch.prototype.addRevision):

  • UserInterface/Models/CSSKeywordCompletions.js:

(WebInspector.CSSKeywordCompletions.forProperty):

  • UserInterface/Models/CSSRule.js:

(WebInspector.CSSRule.prototype.get matchedSelectors):

  • UserInterface/Models/CSSStyleDeclaration.js:
  • UserInterface/Models/Color.js:

(WebInspector.Color.fromString):

  • UserInterface/Models/DOMNode.js:
  • UserInterface/Models/DOMNodeStyles.js:

(WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):

  • UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection.prototype.refresh):

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel.prototype._updatePseudoClassCheckboxes):
(WebInspector.CSSStyleDetailsSidebarPanel):

  • UserInterface/Views/ContentBrowser.js:

(WebInspector.ContentBrowser.prototype._updateContentViewSelectionPathNavigationItem):

  • UserInterface/Views/DOMTreeElement.js:
  • UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype._resourceAdded):

  • UserInterface/Views/GeneralTreeElement.js:

(WebInspector.GeneralTreeElement.prototype.addClassName):
(WebInspector.GeneralTreeElement.prototype.removeClassName):

  • UserInterface/Views/LegacyConsoleMessageImpl.js:

(WebInspector.LegacyConsoleMessageImpl.prototype._formatParameterAsTable):

  • UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype._updateMessagesSelection):

  • UserInterface/Views/NavigationBar.js:

(WebInspector.NavigationBar.prototype._findNavigationItem):

  • UserInterface/Views/Sidebar.js:

(WebInspector.Sidebar.prototype.findSidebarPanel):
Replace contains with includes where appropriate.

LayoutTests:

  • inspector/css/pseudo-element-matches.html:
9:33 AM Changeset in webkit [182112] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Tweak node styles in ObjectTreeView
​https://bugs.webkit.org/show_bug.cgi?id=143179

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-28
Reviewed by Timothy Hatcher.

  • UserInterface/Views/LogContentView.css:

(.console-group-messages .outline-disclosure.single-node li):

  • UserInterface/Views/DOMTreeOutline.css:

(.dom-tree-outline.single-node li):
This style makes sense as a generic DOMTreeOutline style.

  • UserInterface/Views/FormattedValue.css:

(.formatted-node > .dom-tree-outline):
(.formatted-node > .dom-tree-outline ol):
(.formatted-node > .dom-tree-outline li.hovered:not(.selected) .selection):
Style for nodes in ObjectTreeView.

  • UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:

(.object-tree-array-index .index-value .formatted-node .dom-tree-outline):
Styles for node in Array value.

  • UserInterface/Views/FormattedValue.js:

(WebInspector.FormattedValue.createElementForNode):
Address the FIXME.

4:59 AM Changeset in webkit [182111] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

nullptr cleanup in InlineFooBox classes
​https://bugs.webkit.org/show_bug.cgi?id=143178

Patch by Joonghun Park <​jh718.park@samsung.com> on 2015-03-28
Reviewed by Csaba Osztrogonác.

No new tests, no behavior changes

Replace 0 with nullptr in InlineFooBox classes.

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::prevLeafChildIgnoringLineBreak):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::removeChild):
(WebCore::InlineFlowBox::deleteLine):
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::InlineFlowBox):

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::InlineTextBox):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::getLogicalStartBoxWithNode):
(WebCore::RootInlineBox::getLogicalEndBoxWithNode):

  • rendering/RootInlineBox.h:
  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::SVGInlineTextBox):
(WebCore::SVGInlineTextBox::releasePaintingResource):
(WebCore::SVGInlineTextBox::restoreGraphicsContextAfterTextPainting):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::closestLeafChildForPosition):
(WebCore::findFirstAndLastAttributesInVector):

  • rendering/svg/SVGRootInlineBox.h:
2:57 AM Changeset in webkit [182110] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

REGRESSION(r181326): It made dfg-int16array.js and dfg-int8array.js fail on AArch64 Linux
​https://bugs.webkit.org/show_bug.cgi?id=142629

Unreviewed gardening, unskip now passing tests after r182091.

  • js/script-tests/dfg-int16array.js:
  • js/script-tests/dfg-int8array.js:
Note: See TracTimeline for information about the timeline view.