Timeline
Apr 18, 2015:
- 11:56 PM Changeset in webkit [182991] by
-
- 1 copy in tags/Safari-600.6.1
New tag.
- 9:20 PM Changeset in webkit [182990] by
-
- 17 edits in trunk/Source/WebInspectorUI
Web Inspector: Pass multiple arguments to classList.add and classList.remove
https://bugs.webkit.org/show_bug.cgi?id=143914
classList.add and classList.remove can accept multiple arguments, use that.
Reviewed by Timothy Hatcher.
- UserInterface/Base/Main.js:
(WebInspector.updateDockedState):
- UserInterface/Views/DOMTreeDataGrid.js:
(WebInspector.DOMTreeDataGrid):
- UserInterface/Views/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline):
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGridNode.prototype.set hasChildren):
- UserInterface/Views/DatabaseContentView.js:
(WebInspector.DatabaseContentView):
- UserInterface/Views/DetailsSection.js:
(WebInspector.DetailsSection):
- UserInterface/Views/DetailsSectionPropertiesRow.js:
(WebInspector.DetailsSectionPropertiesRow):
- UserInterface/Views/GeneralTreeElement.js:
(WebInspector.GeneralTreeElement.prototype.set classNames):
- UserInterface/Views/NavigationItem.js:
(WebInspector.NavigationItem):
- UserInterface/Views/ResourceContentView.js:
(WebInspector.ResourceContentView):
- UserInterface/Views/ResourceTimelineDataGridNode.js:
(WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent):
- UserInterface/Views/Sidebar.js:
(WebInspector.Sidebar):
- UserInterface/Views/SidebarPanel.js:
(WebInspector.SidebarPanel):
- UserInterface/Views/SourceCodeTextEditor.js:
- UserInterface/Views/TextEditor.js:
(WebInspector.TextEditor):
- UserInterface/Views/TimelineRuler.js:
- 9:19 PM Changeset in webkit [182989] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Make prototype pill’s background semi-transparent
https://bugs.webkit.org/show_bug.cgi?id=143928
Reviewed by Timothy Hatcher.
- UserInterface/Views/ObjectTreePropertyTreeElement.css:
(.object-tree-property.prototype-property):
(.object-tree-property.prototype-property:hover, .object-tree-property.prototype-property:focus):
Slightly highlight the prototype pill when hovering over.
- 8:29 PM Changeset in webkit [182988] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Time elapsed should be right-aligned
https://bugs.webkit.org/show_bug.cgi?id=143927
Reviewed by Eric Carlson.
Current time is left-aligned, which is visually jarring when going from < 1 hour to > 1 hour.
- Modules/mediacontrols/mediaControlsApple.css:
(audio::-webkit-media-controls-current-time-display): Set justify-content to flex-end.
(audio::-webkit-media-controls-time-remaining-display): Explicitly set justify-content to flex-start.
- 3:06 PM Changeset in webkit [182987] by
-
- 2 edits in trunk/Tools
Fix lldb_webkit.py to show StringImpls correctly
https://bugs.webkit.org/show_bug.cgi?id=143920
Reviewed by Andreas Kling.
Update WTFStringImplProvider's is_8bit to use the correct bitmask.
- lldb/lldb_webkit.py:
(WTFStringImplProvider.is_8bit):
- 1:15 PM Changeset in webkit [182986] by
-
- 8 edits1 add in trunk/LayoutTests
[EFL] Unreviewed gardening
Update test expectations for failing tests.
- platform/efl/TestExpectations:
- platform/efl/fast/css/text-overflow-ellipsis-bidi-expected.txt: Rebaseline after r182620.
- platform/efl/fast/dom/focus-contenteditable-expected.txt: Ditto.
- platform/efl/fast/forms/listbox-hit-test-zoomed-expected.txt: Ditto.
- platform/efl/fast/parser/open-comment-in-textarea-expected.txt: Ditto.
- platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt: Ditto.
- platform/efl/inspector-protocol/debugger/regress-133182-expected.txt: Rebaseline after r181810.
- platform/efl/svg/wicd/test-rightsizing-b-expected.txt: Rebaseline after r182620.
- 12:39 PM Changeset in webkit [182985] by
-
- 25 edits2 adds in trunk
REGRESSION (r181656): Animated tiled layers are missing content
https://bugs.webkit.org/show_bug.cgi?id=143911
rdar://problem/20596328
Reviewed by Darin Adler.
Source/WebCore:
After r181656, all requestAnimationFrame was falling back to timers, and not
using the platform's DisplayRefreshMonitor, because of a Nullopt vs nullptr
fumble. As a result, GraphicsLayerUpdater (which updates tiled layers during
animations) was failing to do any updates.
Replace this confusing Optional<> code with simpler code that just forces the
clients to make a DisplayRefreshMonitor if they can, first asking
ChromeClient, and then falling back to createDefaultDisplayRefreshMonitor().
Make lots of things into references, and use C++11 initialization in some places.
Add Internals API to allow a test to get the number of layer flushes that have
occurred.
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::windowScreenDidChange):
(WebCore::ScriptedAnimationController::scheduleAnimation):
(WebCore::ScriptedAnimationController::createDisplayRefreshMonitor):
- dom/ScriptedAnimationController.h:
- page/ChromeClient.h:
- platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::createDefaultDisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::create):
(WebCore::DisplayRefreshMonitor::addClient):
(WebCore::DisplayRefreshMonitor::removeClient):
(WebCore::DisplayRefreshMonitor::displayDidRefresh):
- platform/graphics/DisplayRefreshMonitor.h:
- platform/graphics/DisplayRefreshMonitorClient.cpp:
(WebCore::DisplayRefreshMonitorClient::~DisplayRefreshMonitorClient):
- platform/graphics/DisplayRefreshMonitorClient.h:
- platform/graphics/DisplayRefreshMonitorManager.cpp:
(WebCore::DisplayRefreshMonitorManager::createMonitorForClient):
(WebCore::DisplayRefreshMonitorManager::registerClient):
(WebCore::DisplayRefreshMonitorManager::unregisterClient):
(WebCore::DisplayRefreshMonitorManager::scheduleAnimation):
(WebCore::DisplayRefreshMonitorManager::displayDidRefresh):
(WebCore::DisplayRefreshMonitorManager::windowScreenDidChange):
- platform/graphics/DisplayRefreshMonitorManager.h:
- platform/graphics/GraphicsLayerUpdater.cpp:
(WebCore::GraphicsLayerUpdater::GraphicsLayerUpdater):
(WebCore::GraphicsLayerUpdater::scheduleUpdate):
(WebCore::GraphicsLayerUpdater::screenDidChange):
(WebCore::GraphicsLayerUpdater::displayRefreshFired):
(WebCore::GraphicsLayerUpdater::createDisplayRefreshMonitor):
- platform/graphics/GraphicsLayerUpdater.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::notifyFlushBeforeDisplayRefresh):
(WebCore::RenderLayerCompositor::flushLayersSoon):
(WebCore::RenderLayerCompositor::createDisplayRefreshMonitor):
(WebCore::RenderLayerCompositor::startTrackingLayerFlushes):
(WebCore::RenderLayerCompositor::layerFlushCount):
- rendering/RenderLayerCompositor.h:
- testing/Internals.cpp:
(WebCore::Internals::startTrackingLayerFlushes):
(WebCore::Internals::layerFlushCount):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2:
After r181656, all requestAnimationFrame was falling back to timers, and not
using the platform's DisplayRefreshMonitor, because of a Nullopt vs nullptr
fumble.
Replace this confusing Optional<> code with simpler code that just forces the
clients to make a DisplayRefreshMonitor if they can, first asking
ChromeClient, and then falling back to createDefaultDisplayRefreshMonitor().
Make lots of things into references, and use C++11 initialization in some places.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createDisplayRefreshMonitor):
- WebProcess/WebCoreSupport/WebChromeClient.h:
LayoutTests:
Test that animates a tiled layer, and checks that layer flushes occur while the
animation is running.
- compositing/animation/animation-backing-expected.txt: Added.
- compositing/animation/animation-backing.html: Added.
- 7:57 AM Changeset in webkit [182984] by
-
- 3 edits2 moves1 add in trunk/Source/WebKit2
SwipeShadow images are installed on iOS
https://bugs.webkit.org/show_bug.cgi?id=143915
Reviewed by Tim Horton.
- Configurations/WebKit.xcconfig: Added Resources/Mac/* to
EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*]. We could move more resources there and remove
individual patterns.
- Resources/SwipeShadow.png: Moved to mac.
- Resources/SwipeShadow@2x.png: Moved to mac.
- Resources/mac: Added.
- Resources/mac/SwipeShadow.png: Moved from Source/WebKit2/Resources/SwipeShadow.png.
- Resources/mac/SwipeShadow@2x.png: Moved from Source/WebKit2/Resources/SwipeShadow@2x.png.
- WebKit2.xcodeproj/project.pbxproj: Created mac group in the Resources group and moved
SwipeShadow*.png into it. Updated for file moves.
- 7:42 AM Changeset in webkit [182983] by
-
- 4 edits in trunk/Source/WebKit2
Fix NetworkCache Statistics database bootstrapping after r182803
https://bugs.webkit.org/show_bug.cgi?id=143890
Reviewed by Darin Adler.
Update the NetworkCache Statistics database bootstrapping code to use
the records path instead of the version path. Also check that the
filenames in the folder are valid hashes to discard the *-body files.
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::recordsPath):
(WebKit::NetworkCache::Cache::storagePath): Deleted.
- NetworkProcess/cache/NetworkCache.h:
- NetworkProcess/cache/NetworkCacheStatistics.cpp:
(WebKit::NetworkCache::Statistics::initialize):
(WebKit::NetworkCache::Statistics::bootstrapFromNetworkCache):
(WebKit::NetworkCache::Statistics::shrinkIfNeeded):
Apr 17, 2015:
- 9:04 PM Changeset in webkit [182982] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: All sans-serif font family rules should be set the same way.
https://bugs.webkit.org/show_bug.cgi?id=143909
Reviewed by Timothy Hatcher.
Update styles so that all uses of sans-serif font use -webkit-system-font consistently.
- UserInterface/Views/DefaultDashboardView.css:
(body.mac-platform.legacy .toolbar .dashboard.default > .item):
- UserInterface/Views/ObjectTreePropertyTreeElement.css:
(.object-tree-property .prototype-name):
- UserInterface/Views/ObjectTreeView.css:
(.object-tree-outline li .empty-message):
- UserInterface/Views/RenderingFrameTimelineOverviewGraph.css:
(.timeline-overview-graph.rendering-frame > .divider > .label):
- 7:55 PM Changeset in webkit [182981] by
-
- 2 edits in branches/safari-600.6-branch/Source/WebCore
Merged r181409. rdar://problem/20540512
- 6:04 PM Changeset in webkit [182980] by
-
- 3 edits in trunk/Source/WebKit2
Clients sometimes block for 500ms in waitForPossibleGeometryUpdates
https://bugs.webkit.org/show_bug.cgi?id=143901
<rdar://problem/20488655>
Reviewed by Anders Carlsson.
- Platform/IPC/Connection.cpp:
(IPC::Connection::waitForMessage):
InterruptWaitingIfSyncMessageArrives already cancels waitForMessage if
a sync message arrives while waiting, but it should also avoid waiting
if there's a sync message already in the queue when the waiting starts,
as that will have the same nasty effect.
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::waitForPossibleGeometryUpdate):
If a synchronous message comes in from the Web process while we're waiting,
cancel our synchronous wait for DidUpdateGeometry. This will cause the size
change to not synchronize with the Web process' painting, but that is better
than pointlessly blocking for 500ms.
- 5:46 PM Changeset in webkit [182979] by
-
- 2 edits in trunk/Source/WebKit2
Possible null pointer dereference in WebDiagnosticLoggingClient::logDiagnosticMessageWithValue()
https://bugs.webkit.org/show_bug.cgi?id=143899
<rdar://problem/20584215>
Reviewed by Anders Carlsson.
WebDiagnosticLoggingClient::logDiagnosticMessage*() methods failed to
check that m_page.corePage() was non-null before dereferencing, thus
causing crashes when it is null.
- WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.cpp:
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessage):
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithResult):
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithValue):
- 5:12 PM Changeset in webkit [182978] by
-
- 3 edits in branches/safari-600.6-branch
Rollout r182965.
- 3:45 PM Changeset in webkit [182977] by
-
- 2 edits in trunk/Source/WTF
Use ASan poisoning to taint moved-out-of Refs
https://bugs.webkit.org/show_bug.cgi?id=143894
rdar://problem/19443723
Reviewed by Darin Adler.
- wtf/Ref.h: (WTF::Ref::~Ref):
- 3:29 PM Changeset in webkit [182976] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: Have better inactive window color for pixel borders
https://bugs.webkit.org/show_bug.cgi?id=143888
Reviewed by Joseph Pecoraro.
- UserInterface/Views/FindBanner.css:
(body.window-inactive .find-banner):
- UserInterface/Views/Main.css:
(body.window-inactive.docked.bottom):
(body.window-inactive.docked.right):
(body.window-inactive #split-content-browser):
- UserInterface/Views/NavigationBar.css:
(body.window-inactive .navigation-bar):
- UserInterface/Views/QuickConsole.css:
(body.window-inactive .quick-console):
(.quick-console.showing-log):
- UserInterface/Views/Sidebar.css:
(body.window-inactive .sidebar.left):
(body.window-inactive .sidebar.right):
- 3:28 PM Changeset in webkit [182975] by
-
- 6 edits in trunk/Source/WebKit2
WebKit client should be able to add view controller for link preview.
https://bugs.webkit.org/show_bug.cgi?id=143686
Add delegate methods to WKUIDelegatePrivate so that a WebKit client can prepare a view controller
for link preview and react to the dismissal of this view controller. Also connect WKContentView to
preview gesture recognizer and forwards the delegate callbacks to corresponding delegate methods
in WKUIDelegatePrivate.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2015-04-17
Reviewed by Beth Dakin.
- Platform/spi/ios/UIKitSPI.h:
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/ios/WKContentView.mm:
(-[WKContentView willMoveToWindow:]):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]):
(-[WKContentView gestureRecognizer:canPreventGestureRecognizer:]):
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView previewViewControllerForPosition:inSourceView:]):
(-[WKContentView commitPreviewViewController:]):
(-[WKContentView willPresentPreviewViewController:forPosition:inSourceView:]):
(-[WKContentView didDismissPreviewViewController:committing:]):
- 3:25 PM Changeset in webkit [182974] by
-
- 3 edits2 adds in trunk
Large values for line-height cause integer overflow in RenderStyle::computedLineHeight
https://bugs.webkit.org/show_bug.cgi?id=143863
Reviewed by Rob Buis.
Source/WebCore:
When we compute huge values for line-height through percentage or CSS
calc, we'll overflow the integer and later on
ShapeOutsideInfo::computeDeltasForContainingBlockLine will ASSERT
because it expects non-negative line height. So for the computed
line-height, clamp to an integer range to avoid overflow. Note that
the code path for percentages here is safe because LayoutUnit clamps
to an int on conversion.
This is based on a Blink patch by Rob Buis.
Test: fast/shapes/shape-outside-floats/shape-outside-negative-line-height-crash.html
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::computedLineHeight): Clamp line-height to an
int to avoid overflow.
LayoutTests:
Simplified test from a fuzzer.
- fast/shapes/shape-outside-floats/shape-outside-negative-line-height-crash-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-negative-line-height-crash.html: Added.
- 3:22 PM Changeset in webkit [182973] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Unexpected background at top of console when rubber-banding with selection
https://bugs.webkit.org/show_bug.cgi?id=140710
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-04-17
Reviewed by Timothy Hatcher.
- UserInterface/Views/LogContentView.css:
(.console-messages):
Remove the focus ring on the console's log view, only visible when rubber-banding.
- 2:59 PM Changeset in webkit [182972] by
-
- 2 edits in branches/safari-600.6-branch/LayoutTests
Merged r182299. rdar://problem/20540450
- 2:58 PM Changeset in webkit [182971] by
-
- 7 edits1 delete in trunk/Source
Remove unused BoundsCheckedPointer
https://bugs.webkit.org/show_bug.cgi?id=143896
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- bytecode/SpeculatedType.cpp: The header was included here.
Source/WTF:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/BoundsCheckedPointer.h: Removed.
- wtf/CMakeLists.txt:
- 2:55 PM Changeset in webkit [182970] by
-
- 2 edits in branches/safari-600.6-branch/Source/WebKit2
Merged r182285. rdar://problem/20540450
- 2:52 PM Changeset in webkit [182969] by
-
- 5 edits in branches/safari-600.6-branch
Merged r182284. rdar://problem/20540450
- 2:46 PM Changeset in webkit [182968] by
-
- 3 edits2 copies in branches/safari-600.6-branch
Merged r182051. rdar://problem/20540237
- 2:22 PM Changeset in webkit [182967] by
-
- 5 edits in trunk
[ES6] Fix name enumeration of static functions for Symbol constructor
https://bugs.webkit.org/show_bug.cgi?id=143891
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Fix missing symbolPrototypeTable registration to the js class object.
This patch fixes name enumeration of static functions (Symbol.key, Symbol.keyFor) for Symbol constructor.
- runtime/SymbolConstructor.cpp:
LayoutTests:
Add property names tests for Symbol constructor, Symbol object and Symbol.prototype.
- js/Object-getOwnPropertyNames-expected.txt: Removed.
- js/script-tests/Object-getOwnPropertyNames.js:
- 2:21 PM Changeset in webkit [182966] by
-
- 4 edits in branches/safari-600.6-branch
Merged r181864. rdar://problem/20540342
- 2:18 PM Changeset in webkit [182965] by
-
- 3 edits in branches/safari-600.6-branch
Merged r181409. rdar://problem/20540512
- 1:13 PM Changeset in webkit [182964] by
-
- 3 edits2 adds in trunk
Not able to build WebKit against iOS Simulator 8.3 SDK
https://bugs.webkit.org/show_bug.cgi?id=143883
Reviewed by David Kilzer.
Tools:
Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
so that Xcode uses them.
- Scripts/copy-webkitlibraries-to-product-directory:
WebKitLibraries:
Add WebKitSystemInterface for iOS 8.3.
- libWebKitSystemInterfaceIOSDevice8.3.a: Added.
- libWebKitSystemInterfaceIOSSimulator8.3.a: Added.
- 12:55 PM Changeset in webkit [182963] by
-
- 39 edits6 adds in trunk
Force mouse events should go through normal mouse event handling code paths
https://bugs.webkit.org/show_bug.cgi?id=143749
-and corresponding-
rdar://problem/20472895
Reviewed by Dean Jackson.
Source/WebCore:
This patch moves all of the code to dispatch mouseforcedown, mouseforceup, and
mouseforcechanged into normal mouse event dispatching code. This patch leaves
behind the cancel and click events because we plan to remove those, and it also
leaves mouseforcewillbegin because that is necessarily a very different event more
tied to the NSImmediateActionGestureRecognizer than these other events which are
tied to NSResponder’s pressureChangeWithEvent.
New helper functions.
- dom/Document.cpp:
(WebCore::Document::hasListenerTypeForEventType):
- dom/Document.h:
- dom/Element.cpp:
(WebCore::isForceEvent):
Move the code to ensure the force events have listeners in order to fire to
dispatchMouseEvent, and delete the old implementations.
(WebCore::Element::dispatchMouseEvent):
(WebCore::Element::dispatchMouseForceChanged): Deleted.
(WebCore::Element::dispatchMouseForceDown): Deleted.
(WebCore::Element::dispatchMouseForceUp): Deleted.
- dom/Element.h:
Perform a hit test and pipe the events through dispatchMouseEvent().
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseForceEvent):
- page/EventHandler.h:
New types for the new events.
- platform/PlatformEvent.h:
Forward to EventHandler.
- replay/UserInputBridge.cpp:
(WebCore::UserInputBridge::handleMouseForceEvent):
- replay/UserInputBridge.h:
Source/WebKit2:
This patch makes pressureChangeWithEvent create NativeWebMouseEvents with the
NSEventTypePressures that is gets and sends those down to the web process.
Re-name pressureEvent to lastPressureEvent. Now that event can sometimes be an
NSEventTypePressure, the new name makes it clear how the second parameter differs
from the first.
- Shared/NativeWebMouseEvent.h:
New event types for the new types of events.
- Shared/WebEvent.h:
- Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
- Shared/mac/NativeWebMouseEventMac.mm:
(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
- Shared/mac/WebEventFactory.h:
All of the square-peg, round-hole problems of massaging the NSEventTypePressures
events into WebMouseEvents is taken care of here.
- Shared/mac/WebEventFactory.mm:
(WebKit::mouseButtonForEvent):
(WebKit::globalPointForEvent):
(WebKit::pointForEvent):
(WebKit::WebEventFactory::createWebMouseEvent):
Instead of calling the old inputDeviceForceDidChange, create a NativeWebMouseEvent
and handle it.
- UIProcess/API/mac/WKView.mm:
(-[WKView pressureChangeWithEvent:]):
Handle the new types.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent):
Can delete inputDeviceForceDidChange since it’s no longer used.
(WebKit::WebPageProxy::inputDeviceForceDidChange): Deleted.
- UIProcess/WebPageProxy.h:
Handle the new types of mouse events properly.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::handleMouseEvent):
Delete inputDeviceForceDidChange() and m_lastForceStage.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::inputDeviceForceDidChange): Deleted.
Handle new WebEvent types.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
Tools:
Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner.
Since there is not a way to create an NSEventTypePressure from scratch, we
subclass NSEvent and override all of the critical methods.
- WebKitTestRunner/EventSenderProxy.h:
- WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::mouseForceDown):
(WTR::EventSendingController::mouseForceUp):
(WTR::EventSendingController::mouseForceChanged):
- WebKitTestRunner/InjectedBundle/EventSendingController.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
- WebKitTestRunner/mac/EventSenderProxy.mm:
(-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
(-[EventSenderPressureEvent timestamp]):
(-[EventSenderPressureEvent type]):
(-[EventSenderPressureEvent locationInWindow]):
(-[EventSenderPressureEvent location]):
(-[EventSenderPressureEvent stage]):
(-[EventSenderPressureEvent pressure]):
(-[EventSenderPressureEvent phase]):
(-[EventSenderPressureEvent eventNumber]):
(WTR::EventSenderProxy::mouseForceDown):
(WTR::EventSenderProxy::mouseForceUp):
(WTR::EventSenderProxy::mouseForceChanged):
LayoutTests:
Just a few new tests. More to come.
- fast/events/mouse-force-changed-expected.txt: Added.
- fast/events/mouse-force-changed.html: Added.
- fast/events/mouse-force-down-expected.txt: Added.
- fast/events/mouse-force-down.html: Added.
- fast/events/mouse-force-up-expected.txt: Added.
- fast/events/mouse-force-up.html: Added.
Right now the new tests will only work on Mac 10.10.3 and beyond.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/ios-simulator/TestExpectations:
- platform/mac-mavericks/TestExpectations:
- platform/win/TestExpectations:
- 12:53 PM Changeset in webkit [182962] by
-
- 2 edits in trunk/Source/WebCore
RenderTableCell::computeCollapsed*Border() should check if the cell is still attached to the render tree.
https://bugs.webkit.org/show_bug.cgi?id=143887
rdar://problem/20568989
Reviewed by Simon Fraser.
Detached table cell has no access to its parent table. This is a speculative fix to
avoid dereferencing the invalid table pointer.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
(WebCore::RenderTableCell::computeCollapsedBeforeBorder):
(WebCore::RenderTableCell::computeCollapsedAfterBorder):
- 12:08 PM Changeset in webkit [182961] by
-
- 12 edits6 copies in branches/safari-600.6-branch
Merged r180110. rdar://problem/20540540
- 12:08 PM Changeset in webkit [182960] by
-
- 2 edits in trunk/Tools
build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
https://bugs.webkit.org/show_bug.cgi?id=143885
Reviewed by Tim Horton.
Fixed a case where we have two builds with the same revision(s). An in order build
is one for which the revision is strictly higher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype._checkForInOrderResult):
(BuildbotQueue.prototype.compareIterationsByRevisions):
- 11:50 AM Changeset in webkit [182959] by
-
- 2 edits in trunk/Source/JavaScriptCore
Inline JSFunction allocation in DFG
https://bugs.webkit.org/show_bug.cgi?id=143858
Patch by Basile Clement <basile_clement@apple.com> on 2015-04-17
Reviewed by Filip Pizlo.
Followup to my previous patch which inlines JSFunction allocation when
using FTL, now also enabled in DFG.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileNewFunction):
- 11:35 AM Changeset in webkit [182958] by
-
- 2 edits in trunk/Source/WebCore
Update fullscreen button visibility on fullscreen change.
https://bugs.webkit.org/show_bug.cgi?id=143861.
<rdar://problem/20143218>
Reviewed by Eric Carlson.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller): There is no need for hasVisualMedia to be a class variable.
(Controller.prototype.handleReadyStateChange):
(Controller.prototype.handleFullscreenChange):
(Controller.prototype.updateFullscreenButtons):
- 11:21 AM Changeset in webkit [182957] by
-
- 13 edits2 adds in trunk
REGRESSION: SVG does not support link dragging
https://bugs.webkit.org/show_bug.cgi?id=141597
Reviewed by Darin Adler.
Source/WebCore:
Fixes an issue where a SVG hyperlink cannot be dragged. We should support
dragging an SVG A element just as we support dragging an HTML A element.
Test: fast/events/drag-and-drop-link.html
- page/DragController.cpp: Removed explicit include of header Element.h as it will
be ultimately included by HTMLAnchorElement.h, among other headers.
(WebCore::isDraggableLink): Added. Extracted code from HitTestResult::isLiveLink().
(WebCore::DragController::draggableElement): Call WebCore::isDraggableLink() to
determine whether a element is a hyperlink that can be dragged.
- page/DragController.h:
- page/EventHandler.cpp:
(WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Write code in terms of
WebCore::isDraggableLink().
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::isLiveLink): Deleted.
- rendering/HitTestResult.h:
Source/WebKit/mac:
Write -[WebElementDictionary _isLiveLink] in terms of WebCore::isDraggableLink().
- Misc/WebElementDictionary.mm:
(-[WebElementDictionary _isLiveLink]):
LayoutTests:
Add a test to ensure we do not regress dragging of a HTML hyperlink or a SVG hyperlink.
- fast/events/drag-and-drop-link-expected.txt: Added.
- fast/events/drag-and-drop-link.html: Added.
- platform/efl/TestExpectations: Mark the test as "failure" since EFL does not support drag-and-drop.
- platform/gtk/TestExpectations: Mark the test as "failure" until we implement drag-and-drop support for
GTK+ as part of fixing <https://bugs.webkit.org/show_bug.cgi?id=42194>.
- platform/ios-simulator/TestExpectations: Skip the test since iOS does not implement
drag-and-drop support.
- platform/mac-wk2/TestExpectations: Skip the test until we implement drag-and-drop support in EventSender
for Mac as part of fixing <https://bugs.webkit.org/show_bug.cgi?id=42194>.
- 10:33 AM Changeset in webkit [182956] by
-
- 38 edits6 deletes in trunk
Unreviewed, rolling out r182912 and r182920.
https://bugs.webkit.org/show_bug.cgi?id=143881
Build breakage in some configurations (Requested by ap on
#webkit).
Reverted changesets:
"Force mouse events should go through normal mouse event
handling code paths"
https://bugs.webkit.org/show_bug.cgi?id=143749
http://trac.webkit.org/changeset/182912
- 10:30 AM Changeset in webkit [182955] by
-
- 2 edits in trunk/Source/WebCore
Fix review comments for https://bugs.webkit.org/show_bug.cgi?id=143590
following http://trac.webkit.org/changeset/182876.
Reviewed by Daniel Bates.
- ChangeLog:
Fixed typo.
- style/StyleFontSizeFunctions.cpp:
(WebCore::Style::computedFontSizeFromSpecifiedSize):
Fixed a typo in an enum definition and changed the name of an argument.
- 10:07 AM Changeset in webkit [182954] by
-
- 4 edits in trunk/Source/WebKit2
Network Cache: Read resource record and body in parallel
https://bugs.webkit.org/show_bug.cgi?id=143879
Reviewed by Chris Dumez.
We currently first fetch the record file and then fetch the body blob if needed.
We can do both operations in parallel to reduce latency.
- NetworkProcess/cache/NetworkCacheFileSystemPosix.h:
(WebKit::NetworkCache::traverseCacheFiles):
Do all validation in the client.
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::synchronize):
Maintain a bloom filter that contains the body blobs to avoid unnecessary IO attempts.
Delete any unknown file in cache directory.
(WebKit::NetworkCache::Storage::addToRecordFilter):
More informative name for record filter.
(WebKit::NetworkCache::Storage::mayContain):
(WebKit::NetworkCache::Storage::readRecord):
(WebKit::NetworkCache::Storage::storeBodyAsBlob):
(WebKit::NetworkCache::Storage::dispatchReadOperation):
Start record read IO and body blob read IO in parallel.
(WebKit::NetworkCache::Storage::finishReadOperation):
The read is finished when we have both the record and the blob.
(WebKit::NetworkCache::Storage::dispatchWriteOperation):
(WebKit::NetworkCache::Storage::retrieve):
(WebKit::NetworkCache::Storage::store):
(WebKit::NetworkCache::Storage::traverse):
(WebKit::NetworkCache::Storage::clear):
(WebKit::NetworkCache::Storage::shrink):
(WebKit::NetworkCache::Storage::addToContentsFilter): Deleted.
(WebKit::NetworkCache::Storage::decodeRecord): Deleted.
- NetworkProcess/cache/NetworkCacheStorage.h:
(WebKit::NetworkCache::Storage::ReadOperation::ReadOperation):
ReadOperation is now mutable and gathers the read result.
- 9:49 AM Changeset in webkit [182953] by
-
- 5 edits in tags/Safari-601.1.27.2/Source
Versioning.
- 9:45 AM Changeset in webkit [182952] by
-
- 2 edits in trunk/Source/WebKit2
Stop installing WebKit2.framework
https://bugs.webkit.org/show_bug.cgi?id=143860
rdar://problem/18298491
Reviewed by Dan Bernstein.
- Configurations/WebKit2.xcconfig:
Set SKIP_INSTALL=YES for all SDKs except 10.9 where we still need it.
- 9:44 AM Changeset in webkit [182951] by
-
- 1 copy in tags/Safari-601.1.27.2
New tag.
- 8:32 AM Changeset in webkit [182950] by
-
- 2 edits in trunk/LayoutTests
[GTK] Gardening 17th April.
https://bugs.webkit.org/show_bug.cgi?id=143870
Unreviewed.
Patch by Marcos Chavarría Teijeiro <chavarria1991@gmail.com> on 2015-04-17
- platform/gtk/TestExpectations:
- 5:53 AM Changeset in webkit [182949] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed EFL gardening on 17 April.
Mark 5 form tests and 3 navigation tests to failure.
- platform/efl/TestExpectations:
- 5:00 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 4:58 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 4:14 AM Changeset in webkit [182948] by
-
- 2 edits in trunk/Tools
[GTK] One more unreviewed fix after r182882.
- TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
- 3:43 AM Changeset in webkit [182947] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Silent WebAudio buffers support
https://bugs.webkit.org/show_bug.cgi?id=143869
Reviewed by Carlos Garcia Campos.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcLoop): Set gap flag on silent buffers. The audio
sink can then drop them and avoid un-necessary buffer processing.
- 3:22 AM Changeset in webkit [182946] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed. Fix the build with ENABLE(NETWORK_CACHE) and !ENABLE(SHAREABLE_RESOURCE).
- NetworkProcess/cache/NetworkCacheEntry.cpp:
- NetworkProcess/cache/NetworkCacheFileSystemPosix.h:
(WebKit::NetworkCache::fileTimes): There's no st_birthtime in Linux.
- 3:19 AM Changeset in webkit [182945] by
-
- 3 edits in trunk/Tools
[GTK] Unreviewed speculative clean build fix after r182882.
TestWebKitAPI's forwarding header generator depended on WeKit2's
which generated SOUP related forwarding headers too.
This dependency isn't necessary and was removed by r182882 to make
forwarding header generators parallelizable. But in this case
TestWebKitAPI's and WebKitTestRunner's forwarding header generator
should generate SOUP related forwarding headers too similar to EFL.
- TestWebKitAPI/PlatformGTK.cmake:
- WebKitTestRunner/PlatformGTK.cmake:
- 3:16 AM Changeset in webkit [182944] by
-
- 2 edits in trunk/Source/WebKit2
[SOUP] ResourceRequest cache policy is not encoded/decoded in IPC messages
https://bugs.webkit.org/show_bug.cgi?id=143867
Reviewed by Sergio Villar Senin.
Encode/Decode the ResourceRequest cache policy.
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
(IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):
- 3:13 AM Changeset in webkit [182943] by
-
- 4 edits in trunk
[SOUP] Redirect to non HTTP destination is broken
https://bugs.webkit.org/show_bug.cgi?id=143866
Reviewed by Sergio Villar Senin.
Source/WebCore:
This is because we are passing true unconditionally as
isHTTPFamilyRequest parameter of
createSoupRequestAndMessageForHandle in continueAfterWillSendRequest.
We don't actually need to pass isHTTPFamilyRequest parameter to
createSoupRequestAndMessageForHandle, since it can simply check
that from the given request.
Covered by unit tets and also cache/disk-cache/disk-cache-redirect-to-data.html.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::continueAfterWillSendRequest):
(WebCore::createSoupRequestAndMessageForHandle):
(WebCore::ResourceHandle::start):
Tools:
Add a unit test to check that redirect to a data URI works.
- TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
(testRedirectToDataURI):
(serverCallback):
(beforeAll):
- 3:03 AM Changeset in webkit [182942] by
-
- 7 edits in trunk/LayoutTests
streams/reference-implementation/readable-stream.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=143778
Unreviewed.
Comment out flaky subtests while working on a more complete
solution.
The problem with these tests is that they set a timeout before the
calling done() and this causes some tests to behave
undeterministically, specilly code related to promise
resolution. This could even cause indetermination if the tests
were expected to run correctly.
We think it is better to comment them out and find a more long
term solution that could involve submitting change requests to the
reference tests in the spec. This will be tackled in bug 143774.
- streams/reference-implementation/readable-stream-expected.txt:
- streams/reference-implementation/readable-stream-reader-expected.txt:
- streams/reference-implementation/readable-stream-reader.html:
- streams/reference-implementation/readable-stream-templated-expected.txt:
- streams/reference-implementation/readable-stream-templated.html:
- streams/reference-implementation/readable-stream.html:
