Context Navigation

← Previous Period
Next Period →

Timeline

Apr 25, 2015:

11:54 PM Changeset in webkit [183351] by ap@apple.com

2 edits in trunk/LayoutTests

Mark some tests that take >10 seconds on debug bots as slow.

This is too close to 30 second timeout, so it's likely that these tests would flakily
time out on other configurations, e.g. locally.

TestExpectations:

11:06 PM Changeset in webkit [183350] by mitz@apple.com

19 edits in trunk/Source/WebCore

Updated expected bindings generation test results after r183343.

bindings/scripts/test/ObjC/DOMTestActiveDOMObject.h:
bindings/scripts/test/ObjC/DOMTestCallback.h:
bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.h:
bindings/scripts/test/ObjC/DOMTestEventConstructor.h:
bindings/scripts/test/ObjC/DOMTestEventTarget.h:
bindings/scripts/test/ObjC/DOMTestException.h:
bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.h:
bindings/scripts/test/ObjC/DOMTestInterface.h:
bindings/scripts/test/ObjC/DOMTestMediaQueryListListener.h:
bindings/scripts/test/ObjC/DOMTestNamedConstructor.h:
bindings/scripts/test/ObjC/DOMTestNode.h:
bindings/scripts/test/ObjC/DOMTestNondeterministic.h:
bindings/scripts/test/ObjC/DOMTestObj.h:
bindings/scripts/test/ObjC/DOMTestOverloadedConstructors.h:
bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
bindings/scripts/test/ObjC/DOMTestTypedefs.h:
bindings/scripts/test/ObjC/DOMattribute.h:
bindings/scripts/test/ObjC/DOMreadonly.h:

11:00 PM Changeset in webkit [183349] by timothy_horton@apple.com

4 edits
1 delete in trunk/Source/WebKit2

Further update gesture swipe shadow style
https://bugs.webkit.org/show_bug.cgi?id=144215
<rdar://problem/19295843>

Reviewed by Dan Bernstein.

Resources/mac/SwipeShadow.png: Removed.
Resources/mac/SwipeShadow@2x.png: Removed.
UIProcess/mac/ViewGestureController.h:
UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::beginSwipeGesture):

WebKit2.xcodeproj/project.pbxproj:

Use a CAGradientLayer instead of PNGs for the swipe shadow.

10:20 PM Changeset in webkit [183348] by mmaxfield@apple.com

5 edits in trunk

font-synthesis's initial value is "style weight"
https://bugs.webkit.org/show_bug.cgi?id=144195

Reviewed by Darin Adler.

Source/WebCore:

Updated fast/css3-text/font-synthesis-parse.html.

rendering/style/RenderStyle.h:

LayoutTests:

Updating test.

fast/css3-text/font-synthesis-parse-expected.txt:
fast/css3-text/font-synthesis-parse.html:

9:16 PM Changeset in webkit [183347] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r183305.
https://bugs.webkit.org/show_bug.cgi?id=144213

Crashes on wikipedia (Requested by litherum on #webkit).

Reverted changeset:

"[Cocoa] FontPlatformData's equality check should always use
reference URLs"
https://bugs.webkit.org/show_bug.cgi?id=144168
http://trac.webkit.org/changeset/183305

9:12 PM Changeset in webkit [183346] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught exception ReferenceError: Can't find variable: message LogContentView.js
https://bugs.webkit.org/show_bug.cgi?id=144210

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-04-25
Reviewed by Timothy Hatcher.

UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype._reappendProvisionalMessages):
With recent refactorings this change was missed.

8:42 PM Changeset in webkit [183345] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught exception using WebInspector.contentBrowser
https://bugs.webkit.org/show_bug.cgi?id=144206

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-04-25
Reviewed by Timothy Hatcher.

UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel.showTimelineViewForTimeline.this._timelineTreeElementMap.get select):
Use the current tab's content browser since a global one no longer exists.

7:33 PM Changeset in webkit [183344] by commit-queue@webkit.org

2 edits in trunk/Tools

Add myself to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=144204

Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-04-25
Reviewed by Darin Adler.

Scripts/webkitpy/common/config/contributors.json:

6:38 PM Changeset in webkit [183343] by mitz@apple.com

5 edits in trunk/Source

Source/WebCore:
WebCore part of <rdar://problem/20697966> Avoid using TBD as an argument to NS_AVAILABLE
https://bugs.webkit.org/show_bug.cgi?id=144201

Reviewed by Darin Adler.

Instead of TBD, use the high version number to which it corresponds in CFAvailability.h,
9876.5.

bindings/objc/WebKitAvailability.h: Added a definition of NSi_9876_5, so that we can

use 9876_5 in availability macros. Removed the definition of
AVAILABILITY_INTERNALMAC_TBD, which will no longer be used.

bindings/scripts/CodeGeneratorObjC.pm:

(ReadPublicInterfaces): Use 9876_5 instead of TBD.

Source/WebKit2:
WebKit2 part of <rdar://problem/20697966> Avoid using TBD as an argument to NS_AVAILABLE
https://bugs.webkit.org/show_bug.cgi?id=144201

Reviewed by Darin Adler.

Instead of TBD, we use the high version number to which it corresponds in CFAvailability.h,
9876.5.

mac/MigrateHeadersFromWebKitLegacy.make: To detect not-yet-available declarations in

headers, look for "9876_5" rather than "TBA".

6:28 PM Changeset in webkit [183342] by timothy@apple.com

4 edits in trunk/Source

Update localized strings.

Source/WebCore:

English.lproj/Localizable.strings: Updated.

Source/WebInspectorUI:

Localizations/en.lproj/localizedStrings.js: Updated.

6:27 PM Changeset in webkit [183341] by timothy@apple.com

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Make JSContext debugging work with Tabs UI
https://bugs.webkit.org/show_bug.cgi?id=144203

Reviewed by Joseph Pecoraro.

UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
(WebInspector._isTabTypeAllowed):
(WebInspector.activateExtraDomains):
(WebInspector._updateReloadToolbarButton):
(WebInspector._updateDownloadToolbarButton):

6:26 PM Changeset in webkit [183340] by timothy@apple.com

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Save and restore tab state on reload and between sessions
https://bugs.webkit.org/show_bug.cgi?id=144202

Reviewed by Joseph Pecoraro.

UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
(WebInspector._mainResourceDidChange):
(WebInspector._provisionalLoadStarted):
(WebInspector._restoreCookieForOpenTabs):
(WebInspector._saveCookieForOpenTabs):
(WebInspector._pageHidden):

UserInterface/Views/TabContentView.js:

(WebInspector.TabContentView):
(WebInspector.TabContentView.prototype.restoreStateFromCookie):
(WebInspector.TabContentView.prototype.saveStateToCookie):

6:26 PM Changeset in webkit [183339] by timothy@apple.com

7 edits
1 move
3 adds in trunk/Source/WebInspectorUI

Web Inspector: Split search from ResourceSidebarPanel into a Search tab and sidebar
https://bugs.webkit.org/show_bug.cgi?id=144197

Reviewed by Joseph Pecoraro.

UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
(WebInspector._tabContentViewForType):
(WebInspector._searchTextDidChange):
(WebInspector._focusSearchField):
(WebInspector._domNodeWasInspected):

UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype.get knownNonResourceScripts):

UserInterface/Images/SearchResults.svg: Added.
UserInterface/Main.html:
UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel):
(WebInspector.ResourceSidebarPanel.prototype.showDefaultContentView):
(WebInspector.ResourceSidebarPanel.prototype.treeElementForRepresentedObject):
(WebInspector.ResourceSidebarPanel.prototype._mainFrameDidChange):
(WebInspector.ResourceSidebarPanel.prototype._scriptWasAdded):
(WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
(WebInspector.ResourceSidebarPanel.prototype._addStorageChild):
(WebInspector.ResourceSidebarPanel.prototype._extraDomainsActivated):
(WebInspector.ResourceSidebarPanel.prototype.get contentTreeOutlineToAutoPrune): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch.updateEmptyContentPlaceholderSoon): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch.updateEmptyContentPlaceholder): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch.forEachMatch): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch.resourceCallback): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch.resourcesCallback): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts.scriptCallback): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch.domSearchResults): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch.domCallback): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch): Deleted.
(WebInspector.ResourceSidebarPanel.prototype._showResourcesContentTreeOutline): Deleted.
(WebInspector.ResourceSidebarPanel.prototype._showSearchContentTreeOutline): Deleted.
(WebInspector.ResourceSidebarPanel.prototype._searchFieldChanged): Deleted.
(WebInspector.ResourceSidebarPanel.prototype._searchFieldInput): Deleted.
(WebInspector.ResourceSidebarPanel.prototype._searchTreeElementForResource): Deleted.
(WebInspector.ResourceSidebarPanel.prototype._searchTreeElementForScript): Deleted.
(WebInspector.ResourceSidebarPanel.prototype._focusSearchField): Deleted.
(WebInspector.ResourceSidebarPanel.prototype._scriptsToSearch): Deleted.

UserInterface/Views/SearchBar.js:

(WebInspector.SearchBar):

UserInterface/Views/SearchSidebarPanel.css: Renamed from Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.css.

(.sidebar > .panel.navigation.search > :matches(.content, .empty-content-placeholder)):
(body.mac-platform.legacy .sidebar > .panel.navigation.search > :matches(.content, .empty-content-placeholder)):
(.sidebar > .panel.navigation.search > .search-bar):
(body.mac-platform.legacy .sidebar > .panel.navigation.search > .search-bar):
(.sidebar > .panel.navigation.search > .search-bar > input[type="search"]):
(body.mac-platform.legacy .sidebar > .panel.navigation.search > .search-bar > input[type="search"]):

UserInterface/Views/SearchSidebarPanel.js: Added.

(WebInspector.SearchSidebarPanel):
(WebInspector.SearchSidebarPanel.prototype.closed):
(WebInspector.SearchSidebarPanel.prototype.focusSearchField):
(WebInspector.SearchSidebarPanel.prototype.performSearch.updateEmptyContentPlaceholderSoon):
(WebInspector.SearchSidebarPanel.prototype.performSearch.updateEmptyContentPlaceholder):
(WebInspector.SearchSidebarPanel.prototype.performSearch.forEachMatch):
(WebInspector.SearchSidebarPanel.prototype.performSearch.resourceCallback):
(WebInspector.SearchSidebarPanel.prototype.performSearch.resourcesCallback):
(WebInspector.SearchSidebarPanel.prototype.performSearch.searchScripts.scriptCallback):
(WebInspector.SearchSidebarPanel.prototype.performSearch.searchScripts):
(WebInspector.SearchSidebarPanel.prototype.performSearch.domSearchResults):
(WebInspector.SearchSidebarPanel.prototype.performSearch.domCallback):
(WebInspector.SearchSidebarPanel.prototype.performSearch):
(WebInspector.SearchSidebarPanel.prototype._searchFieldChanged):
(WebInspector.SearchSidebarPanel.prototype._searchFieldInput):
(WebInspector.SearchSidebarPanel.prototype._searchTreeElementForResource):
(WebInspector.SearchSidebarPanel.prototype._searchTreeElementForScript):
(WebInspector.SearchSidebarPanel.prototype._mainResourceDidChange.delayedWork):
(WebInspector.SearchSidebarPanel.prototype._mainResourceDidChange):
(WebInspector.SearchSidebarPanel.prototype._treeElementSelected):

UserInterface/Views/SearchTabContentView.js: Added.

(WebInspector.SearchTabContentView):
(WebInspector.SearchTabContentView.prototype.get type):
(WebInspector.SearchTabContentView.prototype.shown):
(WebInspector.SearchTabContentView.prototype.closed):
(WebInspector.SearchTabContentView.prototype.canShowRepresentedObject):
(WebInspector.SearchTabContentView.prototype.focusSearchField):
(WebInspector.SearchTabContentView.prototype.performSearch):

UserInterface/Views/Toolbar.css:

(.toolbar .item-section.center-right):
(.toolbar .item-section.right):
(.toolbar .search-bar):
(.toolbar .search-bar > input[type="search"]):
(.toolbar .search-bar > input[type="search"]::-webkit-textfield-decoration-container):
(body.window-inactive .toolbar .search-bar > input[type="search"]):
(.toolbar .item): Deleted.

6:25 PM Changeset in webkit [183338] by timothy@apple.com

15 edits
1 add in trunk/Source/WebInspectorUI

Web Inspector: New Toolbar UI for tabs
https://bugs.webkit.org/show_bug.cgi?id=144185

Reviewed by Joseph Pecoraro.

UserInterface/Base/ImageUtilities.js:
UserInterface/Base/Main.js:

(WebInspector.loaded):
(WebInspector.contentLoaded):
(WebInspector.updateDockedState):
(WebInspector._captureDidStart):
(WebInspector._debuggerDidPause):
(WebInspector._debuggerDidResume):
(WebInspector._mainFrameDidChange):
(WebInspector._mainResourceDidChange):
(WebInspector._windowKeyDown):
(WebInspector._windowKeyUp):
(WebInspector._pageHidden):
(WebInspector._undock):
(WebInspector._dockBottom):
(WebInspector._dockRight):
(WebInspector._updateDockNavigationItems):
(WebInspector._domNodeWasInspected):
(WebInspector._inspectModeStateChanged):
(WebInspector._toggleInspectMode):
(WebInspector._downloadWebArchive):
(WebInspector._reloadPageClicked):
(WebInspector._updateDownloadToolbarButton):
(WebInspector.archiveMainFrame):
(WebInspector.canArchiveMainFrame):

UserInterface/Images/Crosshair.svg:
UserInterface/Images/DockBottom.svg:
UserInterface/Images/DockRight.svg:
UserInterface/Images/DownloadArrow.svg:
UserInterface/Images/ReloadToolbar.svg: Added.
UserInterface/Images/Undock.svg:
UserInterface/Views/ActivateButtonToolbarItem.js:

(WebInspector.ActivateButtonToolbarItem):
(WebInspector.ActivateButtonToolbarItem.prototype.set label):

UserInterface/Views/ButtonToolbarItem.css:

(.toolbar .item.button):
(body.window-inactive .toolbar .item.button):
(.toolbar.small-size .item.button > .glyph):

UserInterface/Views/ButtonToolbarItem.js:

(WebInspector.ButtonToolbarItem):
(WebInspector.ButtonToolbarItem.prototype.set label):

UserInterface/Views/DashboardContainerView.css:

(.toolbar .dashboard-container):

UserInterface/Views/Main.css:

(body.docked.bottom):

UserInterface/Views/Toolbar.css:

(.toolbar):
(body.mac-platform:not(.legacy, .docked) .toolbar):
(.toolbar .control-section):
(.toolbar .item-section):
(.toolbar .item-section.left):
(.toolbar .item-section.center-left):
(.toolbar .item-section.center-right):
(.toolbar .item-section.right):

UserInterface/Views/Toolbar.js:

(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype.customUpdateLayout.isOverflowingToolbar):
(WebInspector.Toolbar.prototype.customUpdateLayout):
(WebInspector.Toolbar.prototype.addToolbarItem):

6:24 PM Changeset in webkit [183337] by timothy@apple.com

6 edits in trunk/Source/WebInspectorUI

Web Inspector: Add NavigationBar to the details sidebar
https://bugs.webkit.org/show_bug.cgi?id=144191

Reviewed by Joseph Pecoraro.

UserInterface/Base/Main.js:

(WebInspector.contentLoaded):

UserInterface/Views/DetailsSidebarPanel.js:

(WebInspector.DetailsSidebarPanel):
(WebInspector.DetailsSidebarPanel.prototype.get navigationItem):

UserInterface/Views/NavigationBar.js:

(WebInspector.NavigationBar.prototype.removeNavigationItem):
Remove unused index argument.

UserInterface/Views/Sidebar.css:

(.sidebar > .navigation-bar):
(.sidebar.has-navigation-bar > .panel):

UserInterface/Views/Sidebar.js:

(WebInspector.Sidebar):
(WebInspector.Sidebar.prototype.addSidebarPanel):
(WebInspector.Sidebar.prototype.removeSidebarPanel):
(WebInspector.Sidebar.prototype.set selectedSidebarPanel):
(WebInspector.Sidebar.prototype.get minimumWidth):
(WebInspector.Sidebar.prototype.set width):
(WebInspector.Sidebar.prototype.set collapsed):

6:23 PM Changeset in webkit [183336] by timothy@apple.com

8 edits
6 deletes in trunk/Source

Web Inspector: Remove native window dock controls
https://bugs.webkit.org/show_bug.cgi?id=144184

Reviewed by Joseph Pecoraro.

Source/WebKit:

WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Resources/Dock.pdf: Removed.
Resources/DockLegacy.pdf: Removed.
WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController window]):
(-[WebInspectorWindowController setDockingUnavailable:]):

Source/WebKit2:

Resources/DockBottom.pdf: Removed.
Resources/DockBottomLegacy.pdf: Removed.
Resources/DockRight.pdf: Removed.
Resources/DockRightLegacy.pdf: Removed.
UIProcess/WebInspectorProxy.h:
UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformAttachAvailabilityChanged):

WebKit2.xcodeproj/project.pbxproj:

6:23 PM Changeset in webkit [183335] by timothy@apple.com

5 edits in trunk/Source/WebInspectorUI

Web Inspector: Switch over to a tab based UI
https://bugs.webkit.org/show_bug.cgi?id=144154

Reviewed by Joseph Pecoraro.

UserInterface/Base/Main.js:

(WebInspector.loaded):
(WebInspector.contentLoaded):
(WebInspector._tabContentViewForType):
(WebInspector._rememberOpenTabs):
(WebInspector._windowResized):
(WebInspector._tabBrowserSizeDidChange):
(WebInspector._quickConsoleDidResize):
(WebInspector._sidebarWidthDidChange):
(WebInspector._tabBrowserSelectedTabContentViewDidChange):
(WebInspector._inspectModeStateChanged):
(WebInspector._focusedContentView):

UserInterface/Main.html:
UserInterface/Views/Main.css:

(#tab-browser):

6:22 PM Changeset in webkit [183334] by timothy@apple.com

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove Main.js code we don't need for Tabs
https://bugs.webkit.org/show_bug.cgi?id=144126

Reviewed by Joseph Pecoraro.

UserInterface/Base/Main.js:

(WebInspector.loaded):
(WebInspector.contentLoaded):

6:22 PM Changeset in webkit [183333] by timothy@apple.com

8 edits in trunk/Source/WebInspectorUI

Web Inspector: Change more places that changed WebInspector.navigationSidebar.selectedSidebarPanel to tabs
https://bugs.webkit.org/show_bug.cgi?id=144125

Reviewed by Joseph Pecoraro.

UserInterface/Base/Main.js:

(WebInspector.loaded):
(WebInspector.toggleDetailsSidebar):
(WebInspector.tabContentViewClassForRepresentedObject):
(WebInspector._updateModifierKeys):
(WebInspector._consoleResizerMouseDown.dockedResizerDragEnd):
(WebInspector._consoleResizerMouseDown):
(WebInspector.linkifyURLAsNode):
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):

UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.setTimelineProfilingEnabled):
(InspectorFrontendAPI.showConsole):
(InspectorFrontendAPI.showResources):

UserInterface/Protocol/InspectorObserver.js:

(WebInspector.InspectorObserver.prototype.inspect):

UserInterface/Views/DebuggerTabContentView.js:

(WebInspector.DebuggerTabContentView.prototype.canShowRepresentedObject):
(WebInspector.DebuggerTabContentView.prototype.revealAndSelectBreakpoint):

UserInterface/Views/DefaultDashboardView.js:

(WebInspector.DefaultDashboardView):
(WebInspector.DefaultDashboardView.prototype._resourcesWasClicked):

UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu.revealInSidebar):

UserInterface/Views/TabBrowser.js:

(WebInspector.TabBrowser.bestTabContentViewForClass):

6:21 PM Changeset in webkit [183332] by timothy@apple.com

7 edits
2 adds in trunk/Source/WebInspectorUI

Web Inspector: Make Console work in a tab world
https://bugs.webkit.org/show_bug.cgi?id=144112

Reviewed by Joseph Pecoraro.

UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
(WebInspector.isShowingConsoleTab):
(WebInspector.UIString):
(WebInspector.toggleNavigationSidebar):
(WebInspector.toggleDetailsSidebar):
(WebInspector.tabContentViewClassForRepresentedObject):
(WebInspector.linkifyStringAsFragment):

UserInterface/Images/Console.svg: Added.
UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.showConsole):

UserInterface/Views/ConsoleTabContentView.js: Added.

(WebInspector.ConsoleTabContentView):
(WebInspector.ConsoleTabContentView.prototype.shown):
(WebInspector.ConsoleTabContentView.prototype.showRepresentedObject):
(WebInspector.ConsoleTabContentView.prototype.canShowRepresentedObject):
(WebInspector.ConsoleTabContentView.prototype.get supportsSplitContentBrowser):

UserInterface/Views/DefaultDashboardView.js:

(WebInspector.DefaultDashboardView.prototype._consoleItemWasClicked):

UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype.get navigationItems):
(WebInspector.LogContentView.prototype.shown):
(WebInspector.LogContentView.prototype.didAppendConsoleMessageView):
(WebInspector.LogContentView.prototype._showConsoleTab):

UserInterface/Views/LogIcon.css:

(.log-icon .icon):

UserInterface/Views/Main.css:

(#split-content-browser .hierarchical-path-component.log-icon .icon):
(#split-content-browser .hierarchical-path-component.log-icon .title):
(#split-content-browser .hierarchical-path-component.log-icon select):

6:20 PM Changeset in webkit [183331] by timothy@apple.com

25 edits in trunk/Source/WebInspectorUI

Web Inspector: Make showing a content view work in the tab world
https://bugs.webkit.org/show_bug.cgi?id=144110

Reviewed by Joseph Pecoraro.

UserInterface/Base/Main.js:

(WebInspector.loaded):
(WebInspector.hideSplitConsole):
(WebInspector.showSourceCodeLocation):
(WebInspector.showOriginalUnformattedSourceCodeLocation):
(WebInspector.showOriginalOrFormattedSourceCodeLocation):
(WebInspector.showOriginalOrFormattedSourceCodeTextRange):
(WebInspector.showResourceRequest):
(WebInspector.debuggerToggleBreakpoints):
(WebInspector.debuggerPauseResumeToggle):
(WebInspector.debuggerStepOver):
(WebInspector.debuggerStepInto):
(WebInspector.debuggerStepOut):
(WebInspector._focusChanged):
(WebInspector._mouseWasClicked):
(WebInspector._dragOver):
(WebInspector._captureDidStart):
(WebInspector._debuggerDidPause):
(WebInspector._debuggerDidResume):
(WebInspector._frameWasAdded):
(WebInspector._undock):
(WebInspector._updateDockNavigationItems):

UserInterface/Models/Breakpoint.js:

(WebInspector.Breakpoint.prototype.appendContextMenuItems.revealOriginalSourceCodeLocation):
(WebInspector.Breakpoint.prototype.appendContextMenuItems):

UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.showMainResourceForFrame):

UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype.tokenTrackingControllerHighlightedRangeWasClicked):

UserInterface/Views/ComputedStyleDetailsPanel.js:

(WebInspector.ComputedStyleDetailsPanel.prototype._goToRegionFlowArrowWasClicked):
(WebInspector.ComputedStyleDetailsPanel.prototype._goToContentFlowArrowWasClicked):
(WebInspector.ComputedStyleDetailsPanel):

UserInterface/Views/ContentBrowser.js:

(WebInspector.ContentBrowser.prototype.updateHierarchicalPathForCurrentContentView):

UserInterface/Views/ContentView.js:

(WebInspector.ContentView):

UserInterface/Views/DOMTreeContentView.js:

(WebInspector.DOMTreeContentView.prototype.restoreFromCookie):

UserInterface/Views/DOMTreeDataGridNode.js:

(WebInspector.DOMTreeDataGridNode.prototype._goToArrowWasClicked):

UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype.showDefaultContentView):
(WebInspector.DebuggerSidebarPanel.prototype._addTreeElementForSourceCodeToContentTreeOutline):
(WebInspector.DebuggerSidebarPanel.prototype._treeElementSelected):
(WebInspector.DebuggerSidebarPanel.prototype._addIssue):
(WebInspector.DebuggerSidebarPanel.prototype._handleIssueAdded):

UserInterface/Views/LayerTreeDataGridNode.js:

(WebInspector.LayerTreeDataGridNode.prototype._goToArrowWasClicked):

UserInterface/Views/LayoutTimelineView.js:

(WebInspector.LayoutTimelineView.prototype._treeElementSelected):

UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype.get contentBrowser):
(WebInspector.NavigationSidebarPanel.prototype.set contentBrowser):
(WebInspector.NavigationSidebarPanel.prototype._updateFilter):

UserInterface/Views/NetworkTimelineView.js:

(WebInspector.NetworkTimelineView.prototype._treeElementSelected):

UserInterface/Views/ObjectTreeBaseTreeElement.js:

(WebInspector.ObjectTreeBaseTreeElement.prototype._appendMenusItemsForObject):
(WebInspector.ObjectTreeBaseTreeElement):

UserInterface/Views/OverviewTimelineView.js:

(WebInspector.OverviewTimelineView.prototype._treeElementSelected):

UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel.prototype._goToRequestDataClicked):

UserInterface/Views/ResourceSidebarPanel.js:

UserInterface/Views/ResourceTimelineDataGridNode.js:

(WebInspector.ResourceTimelineDataGridNode.prototype._goToResource):

UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView.prototype._treeElementSelected):

UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerHighlightedRangeWasClicked):

UserInterface/Views/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.prototype._popoverCallStackTreeElementSelected):

UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel):
(WebInspector.TimelineSidebarPanel.prototype.shown):
(WebInspector.TimelineSidebarPanel.showTimelineViewForTimeline):

6:20 PM Changeset in webkit [183330] by timothy@apple.com

5 edits in trunk/Source/WebInspectorUI

Web Inspector: Make debugger keyboard shortcuts global
https://bugs.webkit.org/show_bug.cgi?id=144068

We wont always have a DebuggerSidebarPanel to listen for the shortcuts.

Reviewed by Joseph Pecoraro.

UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
(WebInspector.showSourceCodeForFrame):
(WebInspector.showSourceCode):

UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype.pause):

UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype.restoreStateFromCookie):
(WebInspector.DebuggerSidebarPanel.prototype._debuggerDidResume):
(WebInspector.DebuggerSidebarPanel.prototype._handleIssueAdded):
(WebInspector.DebuggerSidebarPanel.prototype._handleIssuesCleared):
(WebInspector.DebuggerSidebarPanel):

6:19 PM Changeset in webkit [183329] by timothy@apple.com

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove Reload and Download Web Archive buttons from FrameTreeElement
https://bugs.webkit.org/show_bug.cgi?id=144064

The will be global toolbar items soon.

Reviewed by Joseph Pecoraro.

UserInterface/Views/FrameTreeElement.js:
UserInterface/Views/ResourceTreeElement.js:

(WebInspector.ResourceTreeElement.prototype._updateStatus):

6:19 PM Changeset in webkit [183328] by timothy@apple.com

6 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove time and weight from the dashboard
https://bugs.webkit.org/show_bug.cgi?id=144063

These two items were the odd ones out since they are only available
when recording a timeline. We will need the toolbar space soon, so make
this lets us make the dashboard skinnier.

This also removes the exception catching in DashboardContainerView. It doesn't really
help us and it makes debugging an exception harder.

Reviewed by Joseph Pecoraro.

UserInterface/Views/DashboardContainerView.css:

(.toolbar .dashboard-container):

UserInterface/Views/DashboardContainerView.js:

(WebInspector.DashboardContainerView.prototype._dashboardViewForRepresentedObject):

UserInterface/Views/DefaultDashboardView.css:

(body.web .toolbar.collapsed .dashboard.default > .item.resourcesCount):
(body.javascript .toolbar .dashboard.default > .item.resourcesCount):

UserInterface/Views/DefaultDashboardView.js:

(WebInspector.DefaultDashboardView):
(WebInspector.DefaultDashboardView.prototype._updateDisplay):

6:18 PM Changeset in webkit [183327] by timothy@apple.com

16 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove sidebar panel shortcut and image
https://bugs.webkit.org/show_bug.cgi?id=144061

Sidebar panels no longer need a keyboard shortcut or a toolbar image.

Reviewed by Joseph Pecoraro.

UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:

(WebInspector.ApplicationCacheDetailsSidebarPanel):

UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel):

UserInterface/Views/DOMDetailsSidebarPanel.js:

(WebInspector.DOMDetailsSidebarPanel):

UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel):

UserInterface/Views/DebuggerSidebarPanel.js:
UserInterface/Views/DetailsSidebarPanel.js:

(WebInspector.DetailsSidebarPanel):

UserInterface/Views/LayerTreeDetailsSidebarPanel.js:

(WebInspector.LayerTreeDetailsSidebarPanel):

UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel):
(WebInspector.NavigationSidebarPanel.prototype.restoreStateFromCookie):
(WebInspector.NavigationSidebarPanel.prototype.showEmptyContentPlaceholder):
(WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement):
(WebInspector.NavigationSidebarPanel.prototype.show):
(WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):

UserInterface/Views/ProbeDetailsSidebarPanel.js:

(WebInspector.ProbeDetailsSidebarPanel):

UserInterface/Views/RenderingFrameDetailsSidebarPanel.js:
UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel):

UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel):

UserInterface/Views/ScopeChainDetailsSidebarPanel.js:

(WebInspector.ScopeChainDetailsSidebarPanel):

UserInterface/Views/SidebarPanel.js:

(WebInspector.SidebarPanel):
(WebInspector.SidebarPanel.prototype.added):
(WebInspector.SidebarPanel.prototype.removed):
(WebInspector.SidebarPanel.prototype.visibilityDidChange):

UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel):
(WebInspector.TimelineSidebarPanel.prototype.showTimelineViewForTimeline):

6:17 PM Changeset in webkit [183326] by timothy@apple.com

13 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove allowedNavigationSidebarPanels, it isn't needed
https://bugs.webkit.org/show_bug.cgi?id=144056

Reviewed by Joseph Pecoraro.

UserInterface/Views/ApplicationCacheFrameContentView.js:
UserInterface/Views/ContentView.js:
UserInterface/Views/CookieStorageContentView.js:
UserInterface/Views/DOMStorageContentView.js:
UserInterface/Views/DOMTreeContentView.js:
UserInterface/Views/DatabaseContentView.js:
UserInterface/Views/DatabaseTableContentView.js:
UserInterface/Views/FontResourceContentView.js:
UserInterface/Views/FrameDOMTreeContentView.js:
UserInterface/Views/LogContentView.js:
UserInterface/Views/ResourceClusterContentView.js:
UserInterface/Views/TimelineRecordingContentView.js:

6:17 PM Changeset in webkit [183325] by timothy@apple.com

12 edits in trunk/Source/WebInspectorUI

Web Inspector: Support passing extra arguments to ContentViews during construction
https://bugs.webkit.org/show_bug.cgi?id=144055

This allows us to pass the TimelineSidebarPanel to Timeline views since in the future
there could be multiple timeline sidebars, one per tab. So the global instance will
be going away.

This also removes the exception catching in ContentViewContainer. It doesn't really
help us and it makes debugging an exception harder.

Reviewed by Joseph Pecoraro.

UserInterface/Views/ContentBrowser.js:

(WebInspector.ContentBrowser.prototype.showContentViewForRepresentedObject):
(WebInspector.ContentBrowser.prototype.contentViewForRepresentedObject):

UserInterface/Views/ContentView.js:

(WebInspector.ContentView):

UserInterface/Views/ContentViewContainer.js:

(WebInspector.ContentViewContainer.prototype.contentViewForRepresentedObject):
(WebInspector.ContentViewContainer.prototype.showContentViewForRepresentedObject):

UserInterface/Views/LayoutTimelineView.js:

(WebInspector.LayoutTimelineView.prototype._dataGridFiltersDidChange):
(WebInspector.LayoutTimelineView.prototype._treeElementSelected):
(WebInspector.LayoutTimelineView.prototype._closeStatusButtonClicked):

UserInterface/Views/NetworkTimelineView.js:

(WebInspector.NetworkTimelineView.prototype._dataGridFiltersDidChange):
(WebInspector.NetworkTimelineView.prototype._treeElementSelected):
(WebInspector.NetworkTimelineView.prototype._closeStatusButtonClicked):

UserInterface/Views/OverviewTimelineView.js:

(WebInspector.OverviewTimelineView.prototype._treeElementSelected):
(WebInspector.OverviewTimelineView.prototype._closeStatusButtonClicked):

UserInterface/Views/RenderingFrameTimelineView.js:

(WebInspector.RenderingFrameTimelineView):

UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView):
(WebInspector.ScriptTimelineView.prototype._dataGridFiltersDidChange):
(WebInspector.ScriptTimelineView.prototype._treeElementSelected):
(WebInspector.ScriptTimelineView.prototype._closeStatusButtonClicked):

UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView):
(WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
(WebInspector.TimelineRecordingContentView.prototype._contentViewSelectionPathComponentDidChange):
(WebInspector.TimelineRecordingContentView.prototype._updateTimes):
(WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):

UserInterface/Views/TimelineSidebarPanel.js:
UserInterface/Views/TimelineView.js:

(WebInspector.TimelineView):
(WebInspector.TimelineView.prototype.get timelineSidebarPanel):

6:16 PM Changeset in webkit [183324] by timothy@apple.com

4 edits in trunk/Source/WebInspectorUI

Web Inspector: Disable global keyboard shortcuts for background tabs
https://bugs.webkit.org/show_bug.cgi?id=143918

Reviewed by Joseph Pecoraro.

UserInterface/Views/ContentBrowser.js:

(WebInspector.ContentBrowser):
(WebInspector.ContentBrowser.prototype.shown): Added.
(WebInspector.ContentBrowser.prototype.hidden): Added.
Disable shortcuts on the browser and find banner.

UserInterface/Views/ContentBrowserTabContentView.js:

(WebInspector.ContentBrowserTabContentView.prototype.shown): Added.
(WebInspector.ContentBrowserTabContentView.prototype.hidden): Added.
Tell the content browser we were shown or hidden.

UserInterface/Views/FindBanner.js:

(WebInspector.FindBanner):
(WebInspector.FindBanner.prototype.show):
(WebInspector.FindBanner.prototype.enableKeyboardShortcuts): Added.
(WebInspector.FindBanner.prototype.disableKeyboardShortcuts): Added.
Support disabling or enabling the keyboard shortcuts.

6:16 PM Changeset in webkit [183323] by timothy@apple.com

7 edits
4 copies
13 adds in trunk/Source/WebInspectorUI

Web Inspector: Add TabBrowser and TabContentView
https://bugs.webkit.org/show_bug.cgi?id=143886

Reviewed by Joseph Pecoraro.

UserInterface/Images/Debugger.svg: Added.
UserInterface/Images/Elements.svg: Added.
UserInterface/Images/Gear.svg: Added.
UserInterface/Images/NewTabPlus.svg: Added.
UserInterface/Images/Resources.svg:
UserInterface/Images/Timeline.svg: Added.
UserInterface/Images/ToggleLeftSidebar.svg: Added.
UserInterface/Images/ToggleRightSidebar.svg: Added.

UserInterface/Views/ContentBrowserTabContentView.css: Added.

(.content-browser.tab.content-view > .content-browser):

UserInterface/Views/ContentBrowserTabContentView.js: Added.

(WebInspector.ContentBrowserTabContentView):
(WebInspector.ContentBrowserTabContentView.prototype.get contentBrowser):
(WebInspector.ContentBrowserTabContentView.prototype.shown):
(WebInspector.ContentBrowserTabContentView.prototype.hidden):
(WebInspector.ContentBrowserTabContentView.prototype.closed):
(WebInspector.ContentBrowserTabContentView.prototype.updateLayout):
(WebInspector.ContentBrowserTabContentView.prototype.get managesDetailsSidebarPanels):
(WebInspector.ContentBrowserTabContentView.prototype.showDetailsSidebarPanels):
(WebInspector.ContentBrowserTabContentView.prototype.contentBrowserTreeElementForRepresentedObject):
(WebInspector.ContentBrowserTabContentView.prototype._navigationSidebarCollapsedStateDidChange):
(WebInspector.ContentBrowserTabContentView.prototype._detailsSidebarCollapsedStateDidChange):
(WebInspector.ContentBrowserTabContentView.prototype._detailsSidebarPanelSelected):
(WebInspector.ContentBrowserTabContentView.prototype._contentBrowserRepresentedObjectsDidChange):
(WebInspector.ContentBrowserTabContentView.prototype._contentBrowserCurrentContentViewDidChange):
(WebInspector.ContentBrowserTabContentView.prototype._revealAndSelectRepresentedObjectInNavigationSidebar):

UserInterface/Views/DebuggerTabContentView.js: Added.

(WebInspector.DebuggerTabContentView):

UserInterface/Views/ElementsTabContentView.js: Added.

(WebInspector.ElementsTabContentView):
(WebInspector.ElementsTabContentView.prototype._mainFrameDidChange):

UserInterface/Views/ResourcesTabContentView.js: Added.

(WebInspector.ResourcesTabContentView):

UserInterface/Views/SettingsTabContentView.js: Added.

(WebInspector.SettingsTabContentView):

UserInterface/Views/TabBrowser.css: Added.

(.tab-browser):
(.tab-browser > .tab-bar):
(.tab-browser > .content-view-container):
(.tab-browser > .tab-bar + .content-view-container):

UserInterface/Views/TabBrowser.js: Added.

(WebInspector.TabBrowser):
(WebInspector.TabBrowser.prototype.get tabBar):
(WebInspector.TabBrowser.prototype.get navigationSidebar):
(WebInspector.TabBrowser.prototype.get detailsSidebar):
(WebInspector.TabBrowser.prototype.get selectedTabContentView):
(WebInspector.TabBrowser.prototype.updateLayout):
(WebInspector.TabBrowser.prototype.bestTabContentViewForRepresentedObject):
(WebInspector.TabBrowser.prototype.addTabForContentView):
(WebInspector.TabBrowser.prototype.showTabForContentView):
(WebInspector.TabBrowser.prototype.closeTabForContentView):
(WebInspector.TabBrowser.prototype._tabBarItemSelected):
(WebInspector.TabBrowser.prototype._sidebarPanelSelected):
(WebInspector.TabBrowser.prototype._sidebarCollapsedStateDidChange):
(WebInspector.TabBrowser.prototype._showNavigationSidebarPanelForTabContentView):
(WebInspector.TabBrowser.prototype._showDetailsSidebarPanelsForTabContentView):

UserInterface/Views/TabContentView.js: Added.

(WebInspector.TabContentView):
(WebInspector.TabContentView.prototype.get parentTabBrowser):
(WebInspector.TabContentView.prototype.set parentTabBrowser):
(WebInspector.TabContentView.prototype.get tabBarItem):
(WebInspector.TabContentView.prototype.get managesDetailsSidebarPanels):
(WebInspector.TabContentView.prototype.showDetailsSidebarPanels):
(WebInspector.TabContentView.prototype.canShowRepresentedObject):
(WebInspector.TabContentView.prototype.get navigationSidebarPanel):
(WebInspector.TabContentView.prototype.get navigationSidebarCollapsedSetting):
(WebInspector.TabContentView.prototype.get detailsSidebarPanels):
(WebInspector.TabContentView.prototype.get detailsSidebarCollapsedSetting):
(WebInspector.TabContentView.prototype.get detailsSidebarSelectedPanelSetting):

UserInterface/Views/TimelineTabContentView.js: Added.

(WebInspector.TimelineTabContentView):

6:15 PM Changeset in webkit [183322] by timothy@apple.com

2 edits
3 adds in trunk/Source/WebInspectorUI

Web Inspector: Add a WebInspector.TabBar class
https://bugs.webkit.org/show_bug.cgi?id=143442

Reviewed by Joseph Pecoraro.

UserInterface/Main.html:

Added new files.

UserInterface/Protocol/InspectorFrontendHostStub.js:

(window.Symbol):
(WebInspector.InspectorFrontendHostStub.prototype.showContextMenu):
Added some stubs needed to work standalone.

UserInterface/Views/TabBar.css: Added.

(.tab-bar):
(body.window-inactive .tab-bar):
(.tab-bar > .top-border):
(body.window-inactive .tab-bar > .top-border):
(.tab-bar > .item):
(.tab-bar > :nth-child(n + 2 of .item)):
(.tab-bar > .item.pinned):
(.tab-bar > .item.selected):
(.tab-bar > .item.new-tab-button:hover):
(.tab-bar:not(.animating) > .item:not(.selected):hover + .item):
(body.window-inactive .tab-bar > .item):
(body.window-inactive .tab-bar > .item.selected):
(.tab-bar > .item > .close):
(body:not(.window-inactive) .tab-bar:not(.single-tab) > .item:hover > .close):
(.tab-bar.single-tab > .item > .close):
(.tab-bar > .item > .close:hover):
(.tab-bar > .item > .close:active):
(.tab-bar > .item > .flex-space):
(.tab-bar > .item > .flex-space:last-child):
(.tab-bar > .item > .icon):
(.tab-bar > .item.selected > .icon):
(.tab-bar > .item.new-tab-button:hover > .icon):
(.tab-bar > .item > .title):
(.tab-bar > .item > .title > .content):
(.tab-bar:not(.animating) > .item:not(.selected):hover > .title):
(.tab-bar > .item.selected > .title):
(.tab-bar.collapsed > .item):
(.tab-bar.collapsed > .item > .flex-space):
(.tab-bar.collapsed > .item > .close):
(.tab-bar.hide-titles > .item > .title):
(.tab-bar.hide-titles > .item.selected:hover > .icon):
(.tab-bar.hide-titles > .item.selected:hover > .close):
(.tab-bar.static-layout):
(.tab-bar.static-layout > .item):
(.tab-bar.animating.closing-tab > .item):
(.tab-bar.animating:matches(.expanding-tabs, .inserting-tab) > .item):
(.tab-bar.animating.inserting-tab > .item.being-inserted):
(.tab-bar.animating.closing-tab > .item.selected):
(body.window-inactive .tab-bar.animating.closing-tab > .item.selected):
(.tab-bar.dragging-tab > .item.selected):

UserInterface/Views/TabBar.js: Added.

(WebInspector.TabBar):
(WebInspector.TabBar.prototype.get newTabItem):
(WebInspector.TabBar.prototype.set newTabItem):
(WebInspector.TabBar.prototype.addTabBarItem):
(WebInspector.TabBar.prototype.insertTabBarItem.animateTabs):
(WebInspector.TabBar.prototype.insertTabBarItem.removeStyles):
(WebInspector.TabBar.prototype.insertTabBarItem):
(WebInspector.TabBar.prototype.insertTabBarItem.set else):
(WebInspector.TabBar.prototype.insertTabBarItem.set this):
(WebInspector.TabBar.animateTabs.get if):
(WebInspector.TabBar.animateTabs):
(WebInspector.TabBar.removeStyles):
(WebInspector.TabBar.prototype.insertTabBarItem):
(WebInspector.TabBar.prototype.updateLayoutSoon.update):
(WebInspector.TabBar.prototype.updateLayoutSoon):
(WebInspector.TabBar.prototype.updateLayout):
(WebInspector.TabBar.prototype.get selectedTabBarItem):
(WebInspector.TabBar.prototype.set selectedTabBarItem):
(WebInspector.TabBar.prototype.get tabBarItems):
(WebInspector.TabBar.prototype.get element):
(WebInspector.TabBar.prototype._findTabBarItem):
(WebInspector.TabBar.prototype._hasMoreThanOneNormalTab):
(WebInspector.TabBar.prototype._recordTabBarItemSizesAndPositions):
(WebInspector.TabBar.prototype._clearTabBarItemSizesAndPositions):
(WebInspector.TabBar.prototype._finishExpandingTabsAfterClose.):
(WebInspector.TabBar.prototype._finishExpandingTabsAfterClose):
(WebInspector.TabBar.prototype._handleMouseDown):
(WebInspector.TabBar.prototype._handleMouseMoved):
(WebInspector.TabBar.prototype._handleMouseUp):
(WebInspector.TabBar.prototype._handleMouseLeave):
(WebInspector.TabBar.prototype._handleNewTabMouseEnter):

UserInterface/Views/TabBarItem.js: Added.

(WebInspector.TabBarItem):
(WebInspector.TabBarItem.prototype.get identifier):
(WebInspector.TabBarItem.prototype.get element):
(WebInspector.TabBarItem.prototype.get parentTabBar):
(WebInspector.TabBarItem.prototype.set parentTabBar):
(WebInspector.TabBarItem.prototype.get selected):
(WebInspector.TabBarItem.prototype.set selected):
(WebInspector.TabBarItem.prototype.get pinned):
(WebInspector.TabBarItem.prototype.get image):
(WebInspector.TabBarItem.prototype.set image):
(WebInspector.TabBarItem.prototype.get title):
(WebInspector.TabBarItem.prototype.set title):
(WebInspector.TabBarItem.prototype.updateLayout):

6:14 PM Changeset in webkit [183321] by timothy@apple.com

1 edit in trunk/Source/WebInspectorUI/ChangeLog

Web Inspector: Make closing ContentViews more leak proof
https://bugs.webkit.org/show_bug.cgi?id=144200

Remove all listeners on the target objects in close that match the this object.
This makes things more foolproof when something changes or a new listener is
added to the same object. TimelineRecordingContentView also had a leak where
TimelineManager and DebuggerManager listeners were not being removed.

Reviewed by Joseph Pecoraro.

UserInterface/Views/ApplicationCacheFrameContentView.js:

(WebInspector.ApplicationCacheFrameContentView.prototype.closed):

UserInterface/Views/ClusterContentView.js:

(WebInspector.ClusterContentView.prototype.closed):

UserInterface/Views/ContentFlowDOMTreeContentView.js:

(WebInspector.ContentFlowDOMTreeContentView.prototype.closed):

UserInterface/Views/FrameDOMTreeContentView.js:

(WebInspector.FrameDOMTreeContentView.prototype.closed):

UserInterface/Views/ResourceContentView.js:

(WebInspector.ResourceContentView.prototype.closed):

UserInterface/Views/TextResourceContentView.js:

(WebInspector.TextResourceContentView.prototype.closed):

UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype.closed):

6:08 PM Changeset in webkit [183320] by commit-queue@webkit.org

3 edits
3 adds in trunk

Set#keys !== Set#values
https://bugs.webkit.org/show_bug.cgi?id=144190

Patch by Jordan Harband <ljharb@gmail.com> on 2015-04-25
Reviewed by Darin Adler.

Source/JavaScriptCore:

per https://people.mozilla.org/~jorendorff/es6-draft.html#sec-set.prototype.keys
Set#keys should === Set#values

runtime/SetPrototype.cpp:

(JSC::SetPrototype::finishCreation):
(JSC::setProtoFuncValues):
(JSC::setProtoFuncEntries):
(JSC::setProtoFuncKeys): Deleted.

LayoutTests:

js/script-tests/set-keys.js: Added.
js/set-keys-expected.txt: Added.
js/set-keys.html: Added.

6:06 PM Changeset in webkit [183319] by Joseph Pecoraro

10 edits in trunk/Source/JavaScriptCore

Allow for pausing a JSContext when opening a Web Inspector
<rdar://problem/20564788>

Reviewed by Timothy Hatcher.

inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::receivedSetupMessage):

inspector/remote/RemoteInspectorConstants.h:
inspector/remote/RemoteInspectorDebuggable.h:
inspector/remote/RemoteInspectorDebuggableConnection.h:
inspector/remote/RemoteInspectorDebuggableConnection.mm:

(Inspector::RemoteInspectorDebuggableConnection::setup):
On any incoming setup message, we may want to automatically
pause the debuggable. If requested, pause the debuggable
after we have setup the frontend connection.

runtime/JSGlobalObjectDebuggable.h:
runtime/JSGlobalObjectDebuggable.cpp:

(JSC::JSGlobalObjectDebuggable::pause):
Pass through to the inspector controller.

inspector/JSGlobalObjectInspectorController.h:
inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::pause):
Enable pause on next statement.

5:59 PM Changeset in webkit [183318] by timothy@apple.com

8 edits in trunk/Source/WebInspectorUI

Web Inspector: Make closing ContentViews more leak proof
https://bugs.webkit.org/show_bug.cgi?id=144200

Reviewed by Darin Adler.

UserInterface/Views/ApplicationCacheFrameContentView.js:

(WebInspector.ApplicationCacheFrameContentView.prototype.closed):

UserInterface/Views/ClusterContentView.js:

(WebInspector.ClusterContentView.prototype.closed):

UserInterface/Views/ContentFlowDOMTreeContentView.js:

(WebInspector.ContentFlowDOMTreeContentView.prototype.closed):

UserInterface/Views/FrameDOMTreeContentView.js:

(WebInspector.FrameDOMTreeContentView.prototype.closed):

UserInterface/Views/ResourceContentView.js:

(WebInspector.ResourceContentView.prototype.closed):

UserInterface/Views/TextResourceContentView.js:

(WebInspector.TextResourceContentView.prototype.closed):

UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype.closed):

4:47 PM Changeset in webkit [183317] by Darin Adler

5 edits in trunk

Crash if IDBTransaction is aborted right after it's created
https://bugs.webkit.org/show_bug.cgi?id=144199

Reviewed by Simon Fraser.

Source/WebCore:

Test: storage/indexeddb/transaction-abort.html

Modules/indexeddb/IDBTransactionBackend.cpp:

(WebCore::IDBTransactionBackend::IDBTransactionBackend): Don't start the
transaction if it is already complete (has been aborted).

LayoutTests:

platform/mac-wk2/TestExpectations: Unskip storage/indexeddb/transaction-abort.html.
storage/indexeddb/transaction-abort-expected.txt: Updated since the exact text of

the execptions is different from what was marked here as expected.

4:20 PM WebKitEFLLayoutTest edited by Gyuyoung Kim

(diff)

3:03 PM Changeset in webkit [183316] by rniwa@webkit.org

16 edits
3 adds in trunk

class methods should be non-enumerable
https://bugs.webkit.org/show_bug.cgi?id=143181

Reviewed by Darin Adler.

Source/JavaScriptCore:

Fixed the bug by using Object.defineProperty to define methods.

This patch adds the concept of link time constants and uses it to resolve Object.defineProperty
inside CodeBlock's constructor since bytecode can be linked against multiple global objects.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock): Resolve link time constants that are used. Ignore ones with register
index of zero.

bytecode/SpecialPointer.h: Added a new enum for link time constants. It currently contains

exactly one entry for Object.defineProperty.

bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::addConstant): Added. Like addConstant that takes JSValue, allocate a new
constant register for the link time constant we're adding.
(JSC::UnlinkedCodeBlock::registerIndexForLinkTimeConstant): Added.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitMoveLinkTimeConstant): Added. Like addConstantValue, allocate a new
register for the specified link time constant and notify UnlinkedCodeBlock about it.
(JSC::BytecodeGenerator::emitCallDefineProperty): Added. Create a new property descriptor and call
Object.defineProperty with it.

bytecompiler/BytecodeGenerator.h:
bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode): Make static and non-static getters and setters for classes
non-enumerable by using emitCallDefineProperty to define them.
(JSC::PropertyListNode::emitPutConstantProperty): Ditto for a non-accessor properties.
(JSC::ClassExprNode::emitBytecode): Make prototype.constructor non-enumerable and make prototype
property on the class non-writable, non-configurable, and non-enumerable by using defineProperty.

runtime/CommonIdentifiers.h:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init): Set m_definePropertyFunction.
(JSC::JSGlobalObject::visitChildren): Visit m_definePropertyFunction.

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::definePropertyFunction): Added.
(JSC::JSGlobalObject::actualPointerFor): Added a variant that takes LinkTimeConstant.
(JSC::JSGlobalObject::jsCellForLinkTimeConstant): Like actualPointerFor, takes LinkTimeConstant and
returns a JSCell; e.g. Object.defineProperty.

runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::addDefineProperty): Added. Returns Object.defineProperty.

runtime/ObjectConstructor.h:

LayoutTests:

Added a regression test.

Also fixed a test that previously relied on "prototype" property being writable
since this is no longer the case.

js/class-syntax-extends-expected.txt:
js/class-syntax-prototype.html: Added.
js/script-tests/class-syntax-extends.js:
js/script-tests/class-syntax-prototype.js: Added.

3:00 PM Changeset in webkit [183315] by Yusuke Suzuki

5 edits
1 add in trunk

[ES6] Implement String.fromCodePoint
https://bugs.webkit.org/show_bug.cgi?id=144160

Reviewed by Darin Adler.

Source/JavaScriptCore:

This patch implements String.fromCodePoint.
It accepts multiple code points and generates a string that consists of given code points.
The range [0x0000 - 0x10FFFF] is valid for code points.
If the given value is out of range, throw a range error.

When a 0xFFFF <= valid code point is given,
String.fromCodePoint generates a string that contains surrogate pairs.

runtime/StringConstructor.cpp:

(JSC::stringFromCodePoint):
(JSC::constructWithStringConstructor):

tests/stress/string-from-code-point.js: Added.

(shouldBe):
(shouldThrow):
(toCodePoints):
(passThrough):

LayoutTests:

Add String.fromCodePoint.

js/Object-getOwnPropertyNames-expected.txt:
js/script-tests/Object-getOwnPropertyNames.js:

2:43 PM Changeset in webkit [183314] by Martin Robinson

32 edits in trunk

Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
https://bugs.webkit.org/show_bug.cgi?id=144182

Reviewed by Simon Fraser.

Source/cmake/OptionsEfl.cmake: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
Source/cmake/OptionsGTK.cmake: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
Source/cmake/OptionsMac.cmake: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
Source/cmake/WebKitFeatures.cmake: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
Source/cmakeconfig.h.cmake: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.

Source/WebCore:

Configurations/FeatureDefines.xcconfig: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
WebCore.vcxproj/WebCoreCommon.props: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
WebCore.vcxproj/WebCoreTestSupportCommon.props: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
css/CSSComputedStyleDeclaration.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
css/MediaQueryEvaluator.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
platform/graphics/GraphicsContext.h: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
platform/graphics/cairo/GraphicsContextCairo.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
platform/graphics/texmap/TextureMapperImageBuffer.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
rendering/RenderLayer.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
rendering/RenderLayerCompositor.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
rendering/RenderObject.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.

Source/WebKit2:

Configurations/FeatureDefines.xcconfig: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.

Source/WTF:

wtf/FeatureDefines.h: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.

Tools:

DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.

WebKitLibraries:

win/tools/vsprops/FeatureDefines.props: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
win/tools/vsprops/FeatureDefinesCairo.props: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.

1:50 PM Changeset in webkit [183313] by ap@apple.com

2 edits in trunk/LayoutTests

Mavericks fix - no window.performance there.

fast/frames/flattening/resources/iframe-to-resize.html:

1:20 PM Changeset in webkit [183312] by ap@apple.com

2 edits in trunk/LayoutTests

fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
https://bugs.webkit.org/show_bug.cgi?id=144155

Unreviewed. Add more temporary logging to figure out what's going on with the test on bots.

fast/frames/flattening/resources/iframe-to-resize.html:

9:29 AM Changeset in webkit [183311] by commit-queue@webkit.org

4 edits in trunk/Source/WebInspectorUI

Web Inspector: assertion failure when editing inline styles
https://bugs.webkit.org/show_bug.cgi?id=143939

Patch by Tobias Reiss <tobi+webkit@basecode.de> on 2015-04-25
Reviewed by Timothy Hatcher.

Prevent "_updateResourceContent" from being called on inline style changes.
Introduce a flag that marks a CSSStyleSheet as a representation of an
"ElementCSSInlineStyle" (DOM Level 2 spec) and return early.

UserInterface/Controllers/CSSStyleManager.js:

(WebInspector.CSSStyleManager.prototype.styleSheetChanged):

UserInterface/Models/CSSStyleSheet.js:

(WebInspector.CSSStyleSheet):
(WebInspector.CSSStyleSheet.isInlineStyle):
(WebInspector.CSSStyleSheet.prototype.markAsInlineStyle):

UserInterface/Models/DOMNodeStyles.js:

(WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):

8:43 AM Changeset in webkit [183310] by mark.lam@apple.com

2 edits
1 add in trunk/Source/JavaScriptCore

mayExit() is wrong about Branch nodes with ObjectOrOtherUse: they can exit.
https://bugs.webkit.org/show_bug.cgi?id=144152

Reviewed by Filip Pizlo.

Changed the EdgeMayExit functor to recognize ObjectUse, ObjectOrOtherUse,
StringObjectUse, and StringOrStringObjectUse kinds as potentially triggering
OSR exits. This was overlooked in the original code.

While only the ObjectOrOtherUse kind is relevant for manifesting this bug with
the Branch node, the other 3 may also trigger the same bug for other nodes.
To prevent this bug from manifesting with other nodes (and future ones that
are yet to be added to mayExits()'s "potential won't exit" set), we fix the
EdgeMayExit functor to handle all 4 use kinds (instead of just ObjectOrOtherUse).

Also added a test to exercise a code path that will trigger this bug with
the Branch node before the fix is applied.

dfg/DFGMayExit.cpp:
tests/stress/branch-may-exit-due-to-object-or-other-use-kind.js: Added.

(inlinedFunction):
(foo):

1:13 AM Changeset in webkit [183309] by commit-queue@webkit.org

1 edit
31 adds in trunk/Tools

https://bugs.webkit.org/show_bug.cgi?id=144038

Patch by Dewei Zhu <Dewei Zhu> on 2015-04-25
Reviewed by Ryosuke Niwa

Add a script to run Speedometer and JetStream on a browser.

Scripts/run-benchmark: Wrapper script to run benchmark.

(main):

Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
Scripts/webkitpy/benchmark_runner/init.py: Added.
Scripts/webkitpy/benchmark_runner/benchmark_builder/init.py: Added.
Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.

(BenchmarkBuilderFactory):

Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.

(GenericBenchmarkBuilder):
(GenericBenchmarkBuilder.prepare):
(GenericBenchmarkBuilder._copyBenchmarkToTempDir):
(GenericBenchmarkBuilder._applyPatch):
(GenericBenchmarkBuilder.clean):

Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.

(JetStreamBenchmarkBuilder):
(JetStreamBenchmarkBuilder.prepare):
(JetStreamBenchmarkBuilder._runCreateScript):

Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.

(BenchmarkRunner):
(BenchmarkRunner.init):
(BenchmarkRunner.execute):
(BenchmarkRunner.dump):
(BenchmarkRunner.wrap):
(BenchmarkRunner.merge):

Scripts/webkitpy/benchmark_runner/browser_driver/init.py: Added.
Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.

(BrowserDriver):
(BrowserDriver.prepareEnv):
(BrowserDriver.launchUrl):
(BrowserDriver.closeBrowser):

Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.

(BrowserDriverFactory):

Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.

(OSXChromeDriver):
(OSXChromeDriver.prepareEnv):
(OSXChromeDriver.launchUrl):
(OSXChromeDriver.closeBrowsers):

Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.

(OSXSafariDriver):
(OSXSafariDriver.prepareEnv):
(OSXSafariDriver.launchUrl):
(OSXSafariDriver.closeBrowsers):

Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.

(GenericFactory):
(GenericFactory.iterateGetItem):
(GenericFactory.create):

Scripts/webkitpy/benchmark_runner/http_server_driver/init.py: Added.
Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.

(ServerControl):
(ServerControl.render_GET):
(ServerControl.render_POST):

Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.

(HTTPServerDriver):
(HTTPServerDriver.serve):
(HTTPServerDriver.fetchResult):

Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.

(HTTPServerDriverFactory):

Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.

(SimpleHTTPServerDriver):
(SimpleHTTPServerDriver.depends):
(SimpleHTTPServerDriver.init):
(SimpleHTTPServerDriver.serve):
(SimpleHTTPServerDriver.baseUrl):
(SimpleHTTPServerDriver.fetchResult):

Scripts/webkitpy/benchmark_runner/utils.py: Utility module.

(ModuleNotFoundError):
(loadModule):
(getPathFromProjectRoot):
(loadJSONFromFile):
(TimeoutError):
(timeout):
(timeout.init):
(timeout.handle_timeout):
(timeout.enter):
(timeout.exit):

Apr 24, 2015:

11:57 PM Changeset in webkit [183308] by commit-queue@webkit.org

31 edits
1 add in trunk

Unreviewed, rolling out r183288.
https://bugs.webkit.org/show_bug.cgi?id=144189

Made js/sort-with-side-effecting-comparisons.html time out in
debug builds (Requested by ap on #webkit).

Reverted changeset:

"It shouldn't take 1846 lines of code and 5 FIXMEs to sort an
array."
https://bugs.webkit.org/show_bug.cgi?id=144013
http://trac.webkit.org/changeset/183288

10:19 PM Changeset in webkit [183307] by fpizlo@apple.com

6 edits
2 adds in trunk/Source/JavaScriptCore

CRASH in operationCreateDirectArgumentsDuringExit()
https://bugs.webkit.org/show_bug.cgi?id=143962

Reviewed by Geoffrey Garen.

We shouldn't assume that constant-like OSR exit values are always recoverable. They are only
recoverable so long as they are live. Therefore, OSR exit should track liveness of
constants instead of assuming that they are always live.

dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::noticeOSRBirth):
(JSC::DFG::GenerationInfo::appendBirth):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCurrentBlock):

dfg/DFGVariableEvent.cpp:

(JSC::DFG::VariableEvent::dump):

dfg/DFGVariableEvent.h:

(JSC::DFG::VariableEvent::birth):
(JSC::DFG::VariableEvent::id):
(JSC::DFG::VariableEvent::dataFormat):

dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

tests/stress/phantom-direct-arguments-clobber-argument-count.js: Added.

(foo):
(bar):

tests/stress/phantom-direct-arguments-clobber-callee.js: Added.

(foo):
(bar):

8:40 PM Changeset in webkit [183306] by commit-queue@webkit.org

2 edits in trunk/Tools

Unreviewed, rolling out r183303.
https://bugs.webkit.org/show_bug.cgi?id=144181

Change was incorrect, broke builds (Requested by smfr on
#webkit).

Reverted changeset:

"Fix the build."
http://trac.webkit.org/changeset/183303

8:30 PM Changeset in webkit [183305] by mmaxfield@apple.com

2 edits in trunk/Source/WebCore

[Cocoa] FontPlatformData's equality check should always use reference URLs
https://bugs.webkit.org/show_bug.cgi?id=144168

Reviewed by Tim Horton.

<rdar://problem/18985642> is not fixed, so we need to continue using the older
objectForEqualityCheck().

No new tests because there is no behavior change.

platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::objectForEqualityCheck):

8:29 PM Changeset in webkit [183304] by mmaxfield@apple.com

11 edits
2 adds in trunk

Implement parsing support for font-synthesis CSS property
https://bugs.webkit.org/show_bug.cgi?id=144180
Source/WebCore:

<rdar://problem/20692791>
<rdar://problem/20625024>

Reviewed by Tim Horton.

See http://www.w3.org/TR/css-fonts-3/#font-synthesis-prop

This property allows web authors to opt out of font synthesis. This patch only
implements parsing support for the property.

Test: fast/css3-text/font-synthesis-parse.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::fontSynthesisFromStyle): Create a CSSValue for the existing style object.
(WebCore::ComputedStyleExtractor::propertyValue): Call fontSynthesisFromStyle().

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Call parseFontSynthesis().
(WebCore::CSSParser::parseFontSynthesis): Accept the grammar

"none | [ weight

style ]"

css/CSSParser.h: Function signature.
css/CSSPropertyNames.in: New CSS property name.
css/CSSValueKeywords.in: New CSS value names.
css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyValueFontSynthesis): Construct an internal
representation of font-synthesis for a given CSSValue.

rendering/style/RenderStyle.h: Function signature.
rendering/style/RenderStyleConstants.h: Internal representation of

font-synthesis.

rendering/style/StyleRareInheritedData.h: Where we actually store the bits

related to this internal representation.

LayoutTests:

Reviewed by Tim Horton.

fast/css3-text/font-synthesis-parse-expected.txt: Added.
fast/css3-text/font-synthesis-parse.html: Added.

6:31 PM Changeset in webkit [183303] by Simon Fraser

2 edits in trunk/Tools

Fix the build.

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController initWithConfiguration:]):

6:03 PM Changeset in webkit [183302] by Simon Fraser

5 edits in trunk/Source

Have the web inspector report accurate memory use for layers with detached backing store
https://bugs.webkit.org/show_bug.cgi?id=144179

Reviewed by Dean Jackson.
Source/WebCore:

Only report memory use for layers whose backing store is attached.

platform/graphics/ca/GraphicsLayerCA.cpp:
platform/graphics/ca/PlatformCALayer.h: Add backingContributesToMemoryEstimate()

which platforms can override if they allow backing store detaching.

Source/WebKit2:

Remote layers can make their backing store volatile, so the backing only contributes
to reported memory use when attached.

WebProcess/WebPage/mac/PlatformCALayerRemote.h:

6:02 PM Changeset in webkit [183301] by Simon Fraser

26 edits in trunk/LayoutTests

Track a coverage rect through GraphicsLayerCA flushes, use it to mark backing store attached
https://bugs.webkit.org/show_bug.cgi?id=144165

Reviewed by Dean Jackson.

New results for platform/mac-wk2/tiled-drawing tests that dump layer trees.

platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div-expected.txt:
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div-with-handler-expected.txt:
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-expected.txt:
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler-expected.txt:
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-expected.txt:
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-with-handler-expected.txt:
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-expected.txt:
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler-expected.txt:
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-expected.txt:
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler-expected.txt:
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-select-expected.txt:
platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-select-with-handler-expected.txt:
platform/mac-wk2/tiled-drawing/scrolling/fixed/four-bars-zoomed-expected.txt:
platform/mac-wk2/tiled-drawing/simple-document-with-margin-tiles-expected.txt:
platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt:
platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative-expected.txt:
platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
platform/mac-wk2/tiled-drawing/tile-coverage-speculative-expected.txt:
platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:
platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration-expected.txt:
platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt:
platform/mac-wk2/tiled-drawing/visible-rect-content-inset-expected.txt:

6:02 PM Changeset in webkit [183300] by Simon Fraser

30 edits
6 adds in trunk

Track a coverage rect through GraphicsLayerCA flushes, use it to mark backing store attached
https://bugs.webkit.org/show_bug.cgi?id=144165

Reviewed by Dean Jackson.

Source/WebCore:

Push in the clipRect as the secondary rect when doing a GraphicsLayerCA flush,
which maps this rect through all the layers. Each layer tests intersection with
this rect to determine if its backing store should be attached.

This will cause us to drop backing store for layers that don't intersect the
visible part of the view, which is too aggressive. A future patch will add
some padding.

Tests: compositing/visible-rect/coverage-clipped.html

compositing/visible-rect/coverage-scrolling.html

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::GraphicsLayerCA): Remove initialization of things with
C++11 initializers. Initialize the new m_intersectsCoverageRect bit.
(WebCore::GraphicsLayerCA::flushCompositingState): Push the clipRect in as the
secondary coverage rect. A future patch will inflate this on the way down the tree.
(WebCore::GraphicsLayerCA::computeVisibleRect): If we're clipping, and
we have a secondary coverage rect, that rect can be clipped to us too.
(WebCore::GraphicsLayerCA::setVisibleAndCoverageRects):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateBackingStoreAttachment):
(WebCore::GraphicsLayerCA::dumpAdditionalProperties):

platform/graphics/ca/GraphicsLayerCA.h: New CoverageRectChanged bit.

Use more C++11 initializers.
(WebCore::GraphicsLayerCA::coverageRect):

LayoutTests:

Updated results that now include coverage rects, and a new test that includes both visible
and hidden layers.

compositing/contents-scale/animating-expected.txt:
compositing/contents-scale/rounded-contents-scale-expected.txt:
compositing/contents-scale/scaled-ancestor-expected.txt:
compositing/contents-scale/simple-scale-expected.txt:
compositing/contents-scale/z-translate-expected.txt:
compositing/visible-rect/coverage-clipped-expected.txt: Added.
compositing/visible-rect/coverage-clipped.html: Added.
compositing/visible-rect/coverage-scrolling-expected.txt: Added.
compositing/visible-rect/coverage-scrolling.html: Added.
platform/ios-simulator-wk2/compositing/visible-rect/coverage-clipped-expected.txt: Added.
platform/ios-simulator-wk2/compositing/visible-rect/coverage-scrolling-expected.txt: Added.
platform/mac-wk2/compositing/tiling/rotated-tiled-clamped-expected.txt:
platform/mac-wk2/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
platform/mac-wk2/compositing/tiling/tile-cache-zoomed-expected.txt:
platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt:
platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt:
platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
platform/mac/compositing/visible-rect/2d-transformed-expected.txt:
platform/mac/compositing/visible-rect/3d-transform-style-expected.txt:
platform/mac/compositing/visible-rect/3d-transformed-expected.txt:
platform/mac/compositing/visible-rect/animated-expected.txt:
platform/mac/compositing/visible-rect/animated-from-none-expected.txt:
platform/mac/compositing/visible-rect/clipped-by-viewport-expected.txt:
platform/mac/compositing/visible-rect/clipped-visible-rect-expected.txt:
platform/mac/compositing/visible-rect/flipped-preserve-3d-expected.txt:
platform/mac/compositing/visible-rect/iframe-and-layers-expected.txt:
platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
platform/mac/compositing/visible-rect/nested-transform-expected.txt:
platform/mac/compositing/visible-rect/scrolled-expected.txt:

5:25 PM Changeset in webkit [183299] by akling@apple.com

2 edits in trunk/Source/WebKit2

theverge.com burning 100% CPU on iPad (due to window.screenX/Y)
<https://webkit.org/b/144175>
<rdar://problem/20694585>

Reviewed by Anders Carlsson.

Return an empty window rect on iOS WK2 builds. This avoids sending a synchronous
IPC request to the UI process that would give the same result, but spend way
more time and CPU cycles to do so.

With this change, theverge.com CPU usage goes from 100% to ~20% when idle.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::windowRect):

5:19 PM Changeset in webkit [183298] by Brent Fulgham

2 edits in trunk/Tools

Disable ActionMenusPDFTest due to timeout on test bot

TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:

(TestWebKitAPI::TEST):

5:16 PM Changeset in webkit [183297] by Brent Fulgham

5 edits in trunk/Source/WebKit2

TextIndicator for embedded PDFs is slightly offset
https://bugs.webkit.org/show_bug.cgi?id=144172
<rdar://problem/20691304>

Reviewed by Tim Horton.

When I converted the existing DOM Range logic to work with PDFSelections, I omitted the
step where the font ascent was used to adjust the origin used for the TextIndicator. This
patch determines the correct ascent for the range of characters in the selection, and
adjusts the offset by the difference between the ascent and the height of the selection rect.

Also, since the PDFSelection only supplies the bounding rect for the selection, I calculate
an equivalent text bounding box by insetting the rect by half the size of the ascent.

WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::scaleFactor): Add accessor for PDF scale factor.

WebProcess/Plugins/PDF/PDFPlugin.h:
WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::dictionaryPopupInfoForPDFSelectionInPluginView): Adjusted to take the
font ascent and scale factor into account.

5:11 PM Changeset in webkit [183296] by ddkilzer@apple.com

2 edits in trunk/Source/WebKit2

REGRESSION (r183293): Fix iOS EWS build by adding SPI declaration for +[UIPeripheralHost visiblePeripheralFrame]

Fixes the following build failures:

WebKit2/UIProcess/ios/WKPDFView.mm:740:45: error: class method '+visiblePeripheralFrame' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]

CGRect keyboardRect = [UIPeripheralHost visiblePeripheralFrame];

^~

WebKit2/UIProcess/ios/WKPDFView.mm:740:12: error: no viable conversion from 'id' to 'CGRect'

CGRect keyboardRect = [UIPeripheralHost visiblePeripheralFrame];

^~

Platform/spi/ios/UIKitSPI.h:

(+[UIPeripheralHost visiblePeripheralFrame]): Add declaration.

5:11 PM Changeset in webkit [183295] by dino@apple.com

5 edits in trunk/Source/WebCore

AnimationController::scrollWasUpdated() shows up in scrolling profiles on pages that don't use scroll triggers
https://bugs.webkit.org/show_bug.cgi?id=144173
<rdar://problem/20526168>

Reviewed by Simon Fraser.

Keep a list of Animations that care about scroll updates, and only
run the animation update if the list is not empty.

Covered by existing tests.

page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::updateStateMachine): Tell the AnimationController
if this is an animation that depends on scrolling.

page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::animationWillBeRemoved): Call the
new removeFromAnimationsDependentOnScroll as this animation is deleted.
(WebCore::AnimationControllerPrivate::addToAnimationsDependentOnScroll):
(WebCore::AnimationControllerPrivate::removeFromAnimationsDependentOnScroll):
(WebCore::AnimationControllerPrivate::scrollWasUpdated): Only update if
there are animations that care.
(WebCore::AnimationController::wantsScrollUpdates): Helper to expose this
value to FrameView.

page/animation/AnimationController.h:
page/animation/AnimationControllerPrivate.h:

(WebCore::AnimationControllerPrivate::wantsScrollUpdates):

5:09 PM Changeset in webkit [183294] by andersca@apple.com

5 edits
1 copy in trunk/Source/WebKit2

Change _WKWebsiteDataStore to hold on to an internal WKWebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=144171

Reviewed by Tim Horton.

UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _websiteDataStore]):
(-[WKWebViewConfiguration _setWebsiteDataStore:]):

UIProcess/API/Cocoa/_WKWebsiteDataStore.h:
UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:

(-[_WKWebsiteDataStore initWithDataStore:]):
(+[_WKWebsiteDataStore defaultDataStore]):
(+[_WKWebsiteDataStore nonPersistentDataStore]):
(-[_WKWebsiteDataStore isNonPersistent]):
(-[_WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:]):
(-[_WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:]):
(-[_WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:]):

UIProcess/API/Cocoa/_WKWebsiteDataStoreInternal.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKWebsiteDataStore.h.
WebKit2.xcodeproj/project.pbxproj:

4:54 PM Changeset in webkit [183293] by timothy_horton@apple.com

6 edits in trunk/Source

WKPDFView does not support password-protected PDFs
https://bugs.webkit.org/show_bug.cgi?id=144162
<rdar://problem/18411512>

Reviewed by Andy Estes.

Platform/spi/ios/UIKitSPI.h:

Add some SPI.

UIProcess/ios/WKPDFView.h:
UIProcess/ios/WKPDFView.mm:

(-[WKPDFView _didLoadPDFDocument]):
(-[WKPDFView web_setContentProviderData:suggestedFilename:]):
Move creation of the UIPDFDocument (only possible if the CGPDFDocument is unlocked)
and initial setup of the page views out into _didLoadPDFDocument.

If the CGPDFDocument is locked, we'll show some UI to unlock it; otherwise
we'll continue on to _didLoadPDFDocument as previously.

(-[WKPDFView web_setMinimumSize:]):
Resize the password UI instead of the PDF pages if we have it.

(-[WKPDFView _computePageAndDocumentFrames]):
Don't bother doing any work revalidating PDF pages if the document is locked.

(-[WKPDFView _updatePasswordEntryField]):
Make sure that the UIDocumentPassword view is always the size of the scrollview.
This takes care of rotation.

(-[WKPDFView _keyboardDidShow:]):
Make sure that we scroll the password field around, if necessary, to keep it
on screen when editing begins.

(-[WKPDFView _showPasswordEntryField]):
(-[WKPDFView _hidePasswordEntryField]):
Adjust the background color (to match the UIDocumentPasswordView) and disable zooming
while it's up. The UIDocumentPassword view is installed into the scroll view
to match UIWebView behavior.

(-[WKPDFView userDidEnterPassword:forPasswordView:]):
(-[WKPDFView didBeginEditingPassword:inView:]):
(-[WKPDFView didEndEditingPassword:inView:]):
(-[WKPDFView _didFailToUnlock]):
Pop up a dialog informing the user that they entered the wrong password.

(-[WKPDFView _tryToUnlockWithPassword:]):
Try to unlock the document. If it succeeds, hide the unlock UI and go back to
_didLoadPDFDocument.

English.lproj/Localizable.strings:

Add some localizable strings.

4:51 PM Changeset in webkit [183292] by ddkilzer@apple.com

3 edits in trunk/Source/WebCore

Fix iOS EWS builds after updating to iOS 8.3 SDK

platform/spi/cocoa/CoreTextSPI.h:
rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::updateCachedSystemFontDescription):

Update IPHONE_OS_VERSION_MIN_REQUIRED for these constants.

4:29 PM Changeset in webkit [183291] by benjamin@webkit.org

2 edits
1 add in trunk/Source/JavaScriptCore

[JSC] When inserting a NaN into a Int32 array, we convert it to DoubleArray then to ContiguousArray
https://bugs.webkit.org/show_bug.cgi?id=144169

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-04-24
Reviewed by Geoffrey Garen.

runtime/JSObject.cpp:

(JSC::JSObject::convertInt32ForValue):
DoubleArray do not store NaN, they are used for holes.
What happened was:
1) We fail to insert the NaN in the Int32 array because it is a double.
2) We were converting the array to DoubleArray.
3) We were trying to insert the value again. We would fail again because

DoubleArray does not store NaN.

4) We would convert the DoubleArrayt to Contiguous Array, converting the values

to boxed values.

tests/stress/int32array-transition-on-nan.js: Added.

The behavior is not really observable. This only test nothing crashes in those
cases.

(insertNaNWhileFilling):
(testInsertNaNWhileFilling):
(insertNaNAfterFilling):
(testInsertNaNAfterFilling):
(pushNaNWhileFilling):
(testPushNaNWhileFilling):

4:11 PM Changeset in webkit [183290] by beidson@apple.com

2 edits
2 adds in trunk/LayoutTests

Handling additional review feedback after http://trac.webkit.org/changeset/183280
https://bugs.webkit.org/show_bug.cgi?id=144157.

Suggested by, implicitly reviewed by, and explicitly rubber-stamped by Alexey Proskuryakov.

http/tests/security/cors-post-redirect-303-expected.txt: Added.
http/tests/security/cors-post-redirect-303.html: Added.
http/tests/security/resources/cors-post-redirect-target.php:

4:04 PM Changeset in webkit [183289] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

Unreviewed iOS build fix; add declarations to AVKitSPI.h

platform/spi/cocoa/AVKitSPI.h:

4:02 PM Changeset in webkit [183288] by ggaren@apple.com

31 edits
1 delete in trunk

It shouldn't take 1846 lines of code and 5 FIXMEs to sort an array.
https://bugs.webkit.org/show_bug.cgi?id=144013

Reviewed by Mark Lam.

Source/JavaScriptCore:

This patch implements Array.prototype.sort in JavaScript, removing the
C++ implementations. It is simpler and less error-prone to express our
operations in JavaScript, which provides memory safety, exception safety,
and recursion safety.

The performance result is mixed, but net positive in my opinion. It's
difficult to enumerate all the results, since we used to have so many
different sorting modes, and there are lots of different data patterns
across which you might want to measure sorting. Suffice it to say:

(*) The benchmarks we track are faster or unchanged.

(*) Sorting random input using a comparator -- which we think is
common -- is 3X faster.

(*) Sorting random input in a non-array object -- which jQuery does
-- is 4X faster.

(*) Sorting random input in a compact array of integers using a
trivial pattern-matchable comparator is 2X *slower*.

builtins/Array.prototype.js:

(sort.min):
(sort.stringComparator):
(sort.compactSparse): Special case compaction for sparse arrays because
we don't want to hang when sorting new Array(BIG).

(sort.compact):
(sort.merge):
(sort.mergeSort): Use merge sort because it's a reasonably efficient
stable sort. We have evidence that some sites depend on stable sort,
even though the ES6 spec does not mandate it. (See
<http://trac.webkit.org/changeset/33967>.)

This is a textbook implementation of merge sort with three optimizations:

(1) Use iteration instead of recursion;

(2) Use array subscripting instead of array copying in order to
create logical sub-lists without creating physical sub-lists;

(3) Swap src and dst at each iteration instead of copying src into
dst, and only copy src into the subject array at the end if src is
not the subject array.

(sort.inflate):
(sort.comparatorSort):
(sort): Sort in JavaScript for the win.

builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::createExecutableInternal): Allow non-private
names so we can use helper functions.

bytecode/CodeBlock.h:

(JSC::CodeBlock::isNumericCompareFunction): Deleted.

bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):

bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::setIsNumericCompareFunction): Deleted.
(JSC::UnlinkedCodeBlock::isNumericCompareFunction): Deleted.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::setIsNumericCompareFunction): Deleted.

bytecompiler/BytecodeGenerator.h:
bytecompiler/NodesCodegen.cpp:

(JSC::FunctionNode::emitBytecode): We don't do this special casing based
on pattern matching anymore. This was mainly an optimization to avoid
the overhead of calling from C++ to JS, which we now avoid by
sorting in JS.

heap/Heap.cpp:

(JSC::Heap::markRoots):
(JSC::Heap::pushTempSortVector): Deleted.
(JSC::Heap::popTempSortVector): Deleted.
(JSC::Heap::visitTempSortVectors): Deleted.

heap/Heap.h: We don't have temp sort vectors anymore because we sort

in JavaScript using a normal JavaScript array for our temporary storage.

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseInner): Allow capturing so we can use
helper functions.

runtime/ArrayPrototype.cpp:

(JSC::isNumericCompareFunction): Deleted.
(JSC::attemptFastSort): Deleted.
(JSC::performSlowSort): Deleted.
(JSC::arrayProtoFuncSort): Deleted.

runtime/CommonIdentifiers.h: New strings used by sort.

runtime/JSArray.cpp:

(JSC::compareNumbersForQSortWithInt32): Deleted.
(JSC::compareNumbersForQSortWithDouble): Deleted.
(JSC::compareNumbersForQSort): Deleted.
(JSC::compareByStringPairForQSort): Deleted.
(JSC::JSArray::sortNumericVector): Deleted.
(JSC::JSArray::sortNumeric): Deleted.
(JSC::ContiguousTypeAccessor::getAsValue): Deleted.
(JSC::ContiguousTypeAccessor::setWithValue): Deleted.
(JSC::ContiguousTypeAccessor::replaceDataReference): Deleted.
(JSC::ContiguousTypeAccessor<ArrayWithDouble>::getAsValue): Deleted.
(JSC::ContiguousTypeAccessor<ArrayWithDouble>::setWithValue): Deleted.
(JSC::ContiguousTypeAccessor<ArrayWithDouble>::replaceDataReference): Deleted.
(JSC::JSArray::sortCompactedVector): Deleted.
(JSC::JSArray::sort): Deleted.
(JSC::AVLTreeAbstractorForArrayCompare::get_less): Deleted.
(JSC::AVLTreeAbstractorForArrayCompare::set_less): Deleted.
(JSC::AVLTreeAbstractorForArrayCompare::get_greater): Deleted.
(JSC::AVLTreeAbstractorForArrayCompare::set_greater): Deleted.
(JSC::AVLTreeAbstractorForArrayCompare::get_balance_factor): Deleted.
(JSC::AVLTreeAbstractorForArrayCompare::set_balance_factor): Deleted.
(JSC::AVLTreeAbstractorForArrayCompare::compare_key_key): Deleted.
(JSC::AVLTreeAbstractorForArrayCompare::compare_key_node): Deleted.
(JSC::AVLTreeAbstractorForArrayCompare::compare_node_node): Deleted.
(JSC::AVLTreeAbstractorForArrayCompare::null): Deleted.
(JSC::JSArray::sortVector): Deleted.
(JSC::JSArray::compactForSorting): Deleted.

runtime/JSArray.h:

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::finishCreation): Provide some builtins used
by sort.

Source/WTF:

Remove this custom tree implementation because it is unused. (It was
previously used to achieve a stable array sort in certain cases.)

WTF.vcxproj/WTF.vcxproj:
WTF.vcxproj/WTF.vcxproj.filters:
WTF.xcodeproj/project.pbxproj:
wtf/AVLTree.h: Removed.
wtf/CMakeLists.txt:

LayoutTests:

js/script-tests/array-holes.js:
js/array-holes-expected.txt: This result now matches Firefox. We see

'peekaboo', which is a prototype property, rather than a hole, because
sorting uses Get, which sees prototype properties.

The ES6 spec says that sorting should use Get, so this new result
matches the spec a little better -- although the spec also says that the
result of sorting is undefined in this case because of the presence of
an indexed property in the prototype chain.

js/dom/array-prototype-properties-expected.txt: Updated error message

to match other array prototype error messages.

js/comparefn-sort-stability-expected.txt:
js/script-tests/comparefn-sort-stability.js: Made this test bigger in

order to demonstrate that Firefox and Safari use a stable sort, and
Chrome does not.

js/script-tests/array-sort-sparse.js:
js/array-sort-sparse-expected.txt: Added some tests for things I got

wrong in this patch.

3:31 PM Changeset in webkit [183287] by ap@apple.com

2 edits in trunk/LayoutTests

fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
https://bugs.webkit.org/show_bug.cgi?id=144155

Unreviewed follow-up. Added a notifyDone, so that the watchdog timer actually works.

fast/frames/flattening/resources/iframe-to-resize.html:

3:22 PM Changeset in webkit [183286] by enrica@apple.com

6 edits in trunk/Source/WebCore

Make rangeExpandedAroundPositionByCharacters to all platforms.
https://bugs.webkit.org/show_bug.cgi?id=144161

Reviewed by Tim Horton.

No change in functionality, simply making this available
to all platforms.

editing/VisibleUnits.cpp:

(WebCore::rangeExpandedAroundPositionByCharacters):

editing/VisibleUnits.h:
editing/mac/DataDetection.mm:
editing/mac/DictionaryLookup.h:
editing/mac/DictionaryLookup.mm:

(WebCore::rangeExpandedAroundPositionByCharacters): Deleted.

3:05 PM Changeset in webkit [183285] by akling@apple.com

3 edits in trunk/Source/WebCore

Purge PassRefPtr from NamedNodeMap.
<https://webkit.org/b/144091>

Reviewed by Antti Koivisto.

Use RefPtr instead of PassRefPtr in NamedNodeMap.

dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::getNamedItem):
(WebCore::NamedNodeMap::getNamedItemNS):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):
(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::setNamedItemNS):
(WebCore::NamedNodeMap::item):

dom/NamedNodeMap.h:

3:01 PM Changeset in webkit [183284] by bshafiei@apple.com

1 copy in tags/Safari-600.7.3

New tag.

3:00 PM Changeset in webkit [183283] by commit-queue@webkit.org

73 edits
11 deletes in trunk

Unreviewed, rolling out r183266.
https://bugs.webkit.org/show_bug.cgi?id=144164

Broke 32-bit build and a test. (Requested by ap on #webkit).

Reverted changeset:

"AX: richer text change notifications (142719)"
https://bugs.webkit.org/show_bug.cgi?id=142719
http://trac.webkit.org/changeset/183266

2:53 PM Changeset in webkit [183282] by Brent Fulgham

6 edits in trunk

REGRESSION: WebKit2.ActionMenusTest API test fails
https://bugs.webkit.org/show_bug.cgi?id=144149
<rdar://problem/20677770>

Reviewed by Tim Horton.

Source/WebKit2:

Tested by TestWebKitAPI

The 'lookupTextAtLocation' method was not converting the NSEvent coordinates it
was receiving from root view to the plugin view. Consequently, full page PDFs
did hit testing correctly, but an <embed> PDF would not.

Since 'existingSelectionContainsPoint' is exposed as API, I also modified it to
expect 'root view' coordinates and perform the requisite conversions, rather
than expecting 'plugin view' coordinates.

WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::existingSelectionContainsPoint): Expect 'root view' coordinates
for the input.
(WebKit::PDFPlugin::lookupTextAtLocation): Properly convert the passed 'root view'
coordinates to the PDF's view coordinate space.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performActionMenuHitTestAtLocation): Pass hit point using view coordinates,
not content coordinates.

Tools:

TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF

as the 'ActionMenusPDFTest'.

TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:

(TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
to match the hit test on the 'action-menu-target.pdf' test file.

2:39 PM Changeset in webkit [183281] by dbates@webkit.org

2 edits in trunk/Tools

Cleanup: Use @memoized for property IOSSimulator.testing_device
https://bugs.webkit.org/show_bug.cgi?id=141715

Reviewed by Darin Adler.

Simplify the caching of the result of IOSSimulator.testing_device
and make the code more readable by making use of the @memoized declarator
instead of explicitly managing a private instance variable,
IOSSimulator._testing_device, for the cached result.

Scripts/webkitpy/port/ios.py:

(IOSPort.determine_full_port_name):
(IOSSimulatorPort.init): Delete instance variable IOSSimulatorPort._testing_device.
(IOSSimulatorPort):
(IOSSimulatorPort.testing_device): No need to cache the created device object in
IOSSimulatorPort._testing_device since we are marking this function @memoized.
(IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
of caching in local variable since we only make use of this value exactly once in this function.
(IOSPort.init): Deleted; The instance variable IOSPort._testing_device has never
been used since being added in r178622. So, we can remove this constructor since
it's the trivial constructor once we remove the instance variable IOSPort._testing_device.

2:09 PM Changeset in webkit [183280] by beidson@apple.com

4 edits
9 adds in trunk

Origin header is preserved on cross-origin redirects.
https://bugs.webkit.org/show_bug.cgi?id=144157.

Reviewed by Sam Weinig.

Source/WebCore:

Tests: http/tests/security/cors-post-redirect-301.html

http/tests/security/cors-post-redirect-302.html
http/tests/security/cors-post-redirect-307.html
http/tests/security/cors-post-redirect-308.html

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::willSendRequest): Always clear any origin header for cross-origin redirects.

platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::willSendRequest): Ditto.

LayoutTests:

http/tests/security/cors-post-redirect-301-expected.txt: Added.
http/tests/security/cors-post-redirect-301.html: Added.
http/tests/security/cors-post-redirect-302-expected.txt: Added.
http/tests/security/cors-post-redirect-302.html: Added.
http/tests/security/cors-post-redirect-307-expected.txt: Added.
http/tests/security/cors-post-redirect-307.html: Added.
http/tests/security/cors-post-redirect-308-expected.txt: Added.
http/tests/security/cors-post-redirect-308.html: Added.
http/tests/security/resources/cors-post-redirect-target.php: Added.

1:55 PM Changeset in webkit [183279] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Address a review comment from Joe Pecoraro.

UIProcess/API/Cocoa/WKWebsiteDataStore.h:

1:48 PM Changeset in webkit [183278] by andersca@apple.com

10 edits in trunk

Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
https://bugs.webkit.org/show_bug.cgi?id=144158

Reviewed by Beth Dakin.

Source/WebKit2:

UIProcess/API/APIWebsiteDataStore.cpp:

(API::WebsiteDataStore::isPersistent):
(API::WebsiteDataStore::isNonPersistent): Deleted.

UIProcess/API/APIWebsiteDataStore.h:
UIProcess/API/Cocoa/WKWebsiteDataStore.h:
UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore isPersistent]):
(-[WKWebsiteDataStore isNonPersistent]): Deleted.

UIProcess/API/Cocoa/_WKWebsiteDataStore.h:
UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:

(-[_WKWebsiteDataStore isNonPersistent]):

UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController initWithConfiguration:]):

12:33 PM Changeset in webkit [183277] by Brent Fulgham

15 edits in trunk/Source

Immediate action not functional for embedded PDFs
https://bugs.webkit.org/show_bug.cgi?id=143952
<rdar://problem/19842365>

Reviewed by Tim Horton.

Source/WebCore:

Add a dictionary lookup method to allow us to retrieve
relevant information for PDFs.

editing/mac/DictionaryLookup.mm:

(WebCore::dictionaryLookupForPDFSelection): Updated to properly handle cases
where the Lookup engine selects a smaller range than the initial automatic
selection performed on clicking.

Source/WebKit2:

Add a new method to retrieve appropriate dictionary lookup content and update the
hit test result with relevant dictionary content and the bounding rect of the
selection.

WebProcess/Plugins/Netscape/NetscapePlugin.h: Add stub.
WebProcess/Plugins/Netscape/NetscapePlugin.cpp: Initialize plugin type.
WebProcess/Plugins/PDF/PDFPlugin.h:
WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::rectInWindowSpaceForRectInLayoutSpace): New helper function to
convert PDF 'in page' units to the equivalent view units.
(WebKit::PDFPlugin::PDFPlugin): Initialize plugin type.
(WebKit::PDFPlugin::viewRectForSelection): Query a provided PDFSelection for
its bounding rect and return the result in view units.

WebProcess/Plugins/Plugin.h:
WebProcess/Plugins/PluginProxy.cpp: Initialize plugin type.
WebProcess/Plugins/PluginProxy.h: Add stub.
WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::viewRectForSelection): Added.

WebProcess/Plugins/PluginView.h:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::dictionaryPopupInfoForPDFSelectionInPluginView): Added.
(WebKit::textIndicatorTransitionForActionMenu): Added helper function.
(WebKit::WebPage::performActionMenuHitTestAtLocation): Update the hit test information
with relevant dictionary lookup content, and mark the result as a text node (if
appropriate).

12:15 PM Changeset in webkit [183276] by jer.noble@apple.com

2 edits in trunk/Source/WebKit2

[WK2] Only issue a isPlayingAudioDidChange() notification if the audio playing state actually changed.
https://bugs.webkit.org/show_bug.cgi?id=144153

Reviewed by Alexey Proskuryakov.

Check the old state vs. the new state and only issue the change notification if the IsPlayingAudio state changed.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::isPlayingMediaDidChange):

12:08 PM Changeset in webkit [183275] by mmirman@apple.com

3 edits
3 adds in trunk

Source/JavaScriptCore:
Made Object.prototype.proto native getter and setter check that this object not null or undefined
https://bugs.webkit.org/show_bug.cgi?id=141865
rdar://problem/19927273

Reviewed by Filip Pizlo.

runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncProtoGetter):
(JSC::globalFuncProtoSetter):

LayoutTests:
Added tests to ensure that Object.prototype.proto native getter and setter do not coerce undefined to this
https://bugs.webkit.org/show_bug.cgi?id=141865
rdar://problem/19927273

Reviewed by Filip Pizlo.

js/script-tests/sloppy-getter-setter-global-object.js: Added.
js/sloppy-getter-setter-global-object-expected.txt: Added.
js/sloppy-getter-setter-global-object.html: Added.

12:01 PM Changeset in webkit [183274] by Simon Fraser

5 edits in trunk/Source/WebCore

Make it possible to map a secondary quad through TransformState
https://bugs.webkit.org/show_bug.cgi?id=144156

Reviewed by Dean Jackson.

A future patch will need to map two quads simultaneously through TransformState,
so add the ability to provide an optional secondary quad.

This patch also firms up the setQuad() contract, fixing webkit.org/b/106680,
requiring the state to be flattened when setting the quad (and now, the secondary quad).
Previously, setQuad implicitly flattened but failed to update m_mapPoint when
doing so.

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::computeVisibleRect): Now we have to explicitly flatten
before setting the quad.

platform/graphics/ca/GraphicsLayerCA.h: Drive-up #include removal.
platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::operator=): Copy the secondary quad if we have one.
(WebCore::TransformState::translateMappedCoordinates): Move the secondary quad
if we have one.
(WebCore::TransformState::mappedQuad): Code factored into mapQuad().
(WebCore::TransformState::mappedSecondaryQuad): Return the secondary quad mapped
into the state's current coordinate space.
(WebCore::TransformState::mapQuad): Factored code.

platform/graphics/transforms/TransformState.h:

(WebCore::TransformState::setQuad): Make the contract more explicit with assertions.
(WebCore::TransformState::setSecondaryQuad): Ditto when setting the secondary quad.
(WebCore::TransformState::lastPlanarSecondaryQuad):
(WebCore::TransformState::lastPlanarQuad): Deleted.

11:57 AM Changeset in webkit [183273] by Antti Koivisto

3 edits in trunk/Source/WebKit2

CrashTracer: [USER] com.apple.WebKit.Networking at com.apple.WebKit: WebKit::NetworkResourceLoader::~NetworkResourceLoader + 14
https://bugs.webkit.org/show_bug.cgi?id=144147

Reviewed by Chris Dumez.

Storage::storeBodyAsBlob copies the std::function callback for handling mapped bodies in a thread.
This is thread safe only if the function copy is thread safe. It is currently not as we are capturing
RefPtr<NetworkResourceLoader> and NetworkResourceLoader doesn't use thread safe refcounting.

Fix by avoiding copying of the callback. Use same apporach for WriteOperation as we already use for
ReadOperation: count the active operations in progress and delete WriteOperation when everything is
finished. This way we don't need to copy the function out from WriteOperation.

NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::ReadOperation::ReadOperation):
(WebKit::NetworkCache::Storage::WriteOperation::WriteOperation):

Move definition here from the header.

(WebKit::NetworkCache::Storage::~Storage):
(WebKit::NetworkCache::Storage::storeBodyAsBlob):

Increment the operation count when storing a blob, call finishWriteOperation when done.

(WebKit::NetworkCache::Storage::dispatchReadOperation):
(WebKit::NetworkCache::Storage::finishReadOperation):

Count active operations instead of finished operations. This makes the code clearer.

(WebKit::NetworkCache::Storage::dispatchWriteOperation):
(WebKit::NetworkCache::Storage::finishWriteOperation):

Mirror the way ReadOperations work.

NetworkProcess/cache/NetworkCacheStorage.h:

(WebKit::NetworkCache::Storage::ReadOperation::ReadOperation): Deleted.

11:55 AM Changeset in webkit [183272] by ap@apple.com

3 edits in trunk/LayoutTests

fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
https://bugs.webkit.org/show_bug.cgi?id=144155

Reviewed by Anders Carlsson.

Cleaned the test up a little, and added logging to collect some information about
why it fails.

fast/frames/flattening/iframe-flattening-resize-event-count.html:
fast/frames/flattening/resources/iframe-to-resize.html:

11:45 AM Changeset in webkit [183271] by mmaxfield@apple.com

5 edits in trunk/Source/WebCore

[iOS] Reimplement r182512 and r183153 in a cleaner way
https://bugs.webkit.org/show_bug.cgi?id=144151

Reviewed by Enrica Casucci.

On iOS, we create FontPlatformData's ctFont() by round tripping it through a CGFontRef.
This causes the resultant ctFont() to lose system-font-ness. Patches r182512 and r183153
react to this fact by making users of a FontPlatformData use the original font passed in
to the FontPlatformData instead of the FontPlatformData's ctFont(), but only if we
detect that the FontPlatformData represents a system font (the underlying APIs have
different behavior for system fonts and non-system-fonts).

However, on OS X, we create a FontPlatformData's ctFont() directly from the original
font passed in to the constructor. This preserves system-font-ness (because it no
longer has the CGFontRef in the middle of the transformation). Therefore, OS X has the
correct behavior regarding system fonts.

The difference between the two ctFont() creation codepaths seems to be historical
rather than intentional. Rather than change all the call sites of ctFont() to use a
different platform font object if a system font is detected, a cleaner solution is to
simply unify the two ctFont() creation codepaths to the version which preserves system-
font-ness. Doing this will make all users of FontPlatformData automatically have the
correct behavior with no updates.

This patch reverts the relevant parts of r182512 and r183153 in favor of this new
solution.

No new tests because there is no behavior change.

platform/graphics/FontPlatformData.h:

(WebCore::FontPlatformData::hashTableDeletedFontValue): Deleted.

platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::platformWidthForGlyph):

platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::ctFontSize):
(WebCore::FontPlatformData::ctFont):

platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::Font::getCFStringAttributes):

11:26 AM Changeset in webkit [183270] by mmaxfield@apple.com

2 edits in trunk/Source/WebCore

Unreviewed build fix.

platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):

11:12 AM Changeset in webkit [183269] by mmaxfield@apple.com

11 edits in trunk/Source

[Cocoa] Start cleaning up FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=144133

Reviewed by Enrica Casucci.

Source/WebCore:

This is the start of a crusade to ultimately remove one of the CTFontRefs which we have inside
FontPlatformData. This patch starts this effort out by removing the FontPlatformData
constructor which accepts an NSFont. This constructor simply casts the NSFont to a CTFontRef,
and forwards to another constructor. This patch moves this cast to callers of this constructor,
thereby enumerating the places we have left that use NSFont with FontPlatformData.

This patch also cleans up two of the constructors in FontPlatformData.cpp to forward on to
a common constructor.

This patch also collects places inside FontPlatformDataCocoa.mm where we check if a pointer is
not 0 and not -1, and puts this common code inside a new function,
FontPlatformData::isValidCTFontRef().

No new tests because there is no behavior change.

platform/graphics/FontPlatformData.cpp:

(WebCore::FontPlatformData::FontPlatformData): Coalesce constructors.

platform/graphics/FontPlatformData.h:

(WebCore::FontPlatformData::isValidCTFontRef): Check if a pointer is not 0 and not -1.
(WebCore::FontPlatformData::hashTableDeletedFontValue): Deleted.

platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::platformCreateScaledFont): Receive cast which has been hoisted from the deleted
FontPlatformData constructor.
(WebCore::Font::compositeFontReferenceFont): Ditto.

platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::~FontPlatformData): Use isValidCTFontRef().
(WebCore::FontPlatformData::platformDataInit): Ditto.
(WebCore::FontPlatformData::platformDataAssign): Ditto.
(WebCore::FontPlatformData::platformIsEqual): Simplify preprocessor macros.
(WebCore::FontPlatformData::allowsLigatures): Remove unnecessary NSFont use.
(WebCore::FontPlatformData::FontPlatformData): Deleted.

platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Remove unnecessary
NSFont use.

platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::systemFallbackForCharacters): Receive cast which has been hoisted from the
deleted FontPlatformData constructor.
(WebCore::FontCache::createFontPlatformData): Ditto.

platform/mac/DragImageMac.mm:

(WebCore::fontFromNSFont): Ditto.
(WebCore::widthWithFont): Ditto.
(WebCore::drawAtPoint): Ditto.

Source/WebKit/mac:

Receive casts which have been hoisted from the deleted FontPlatformData constructor.

Misc/WebKitNSStringExtras.mm:

(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Receive cast which has
been hoisted from the deleted FontPlatformData constructor.
(-[NSString _web_widthWithFont:]): Ditto.

Misc/WebStringTruncator.mm:

(fontFromNSFont): Ditto.

11:02 AM Changeset in webkit [183268] by timothy@apple.com

4 edits in trunk/Source

REGRESSION: Web Inspector: Start Timeline Recording in Develop menu broken
https://bugs.webkit.org/show_bug.cgi?id=144150

Reviewed by Brian Burg.

Source/WebInspectorUI:

UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.setTimelineProfilingEnabled): Change !== to === when
checking enabled to isCapturing().

Source/WebKit2:

WebProcess/WebPage/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::evaluateCommandOnLoad): Properly treat bools as literals
instead of strings by not using the string version of evaluateCommandOnLoad.

10:26 AM Changeset in webkit [183267] by andersca@apple.com

4 edits in trunk/Source/WebKit2

Add headerdocs for WKWebsiteDataRecord and WKWebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=144138

Reviewed by Darin Adler.

UIProcess/API/Cocoa/WKWebsiteDataRecord.h:
UIProcess/API/Cocoa/WKWebsiteDataStore.h:
UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:]):
(-[WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:]):
(-[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:]):

9:49 AM Changeset in webkit [183266] by commit-queue@webkit.org

73 edits
3 copies
8 adds in trunk

AX: richer text change notifications (142719)
https://bugs.webkit.org/show_bug.cgi?id=142719

Patch by Doug Russell <d_russell@apple.com> on 2015-04-24
Reviewed by Darin Adler.

Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.

Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.

Source/WebCore:

Tests: platform/mac/accessibility/input-replacevalue-userinfo.html

platform/mac/accessibility/selection-change-userinfo.html
platform/mac/accessibility/value-change-userinfo.html

CMakeLists.txt:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::notificationPostTimerFired):
(WebCore::AXObjectCache::passwordNotificationPostTimerFired):
(WebCore::AXObjectCache::showIntent):
(WebCore::AXObjectCache::setTextSelectionIntent):
(WebCore::isPasswordFieldOrContainedByPasswordField):
(WebCore::AXObjectCache::postTextStateChangeNotification):
(WebCore::AXObjectCache::postTextReplacementNotification):
(WebCore::AXObjectCache::enqueuePasswordValueChangeNotification):
(WebCore::AXObjectCache::rootWebArea):
(WebCore::AXObjectCache::selectedChildrenChanged): Deleted.

accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::postTextStateChangeNotification):
(WebCore::AXObjectCache::postTextReplacementNotification):
(WebCore::AXObjectCache::postTextStateChangePlatformNotification):
(WebCore::AXObjectCache::postTextReplacementPlatformNotification):
(WebCore::AXObjectCache::textChangeForEditType):
(WebCore::AXObjectCache::nodeTextChangePlatformNotification):
(WebCore::AXObjectCache::computedObjectAttributeCache): Deleted.
(WebCore::AXObjectCache::getOrCreate): Deleted.
(WebCore::AXObjectCache::attachWrapper): Deleted.

accessibility/AXTextStateChangeIntent.h: Added.

(WebCore::AXTextStateChangeIntent::AXTextStateChangeIntent):

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::passwordFieldOrContainingPasswordField):

accessibility/AccessibilityNodeObject.h:
accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isContainedByPasswordField):

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::passwordFieldOrContainingPasswordField):
(WebCore::AccessibilityObject::isPasswordField): Deleted.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::setSelectedTextRange):
(WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):

accessibility/AccessibilityScrollView.h:
accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::textChangeForEditType):
(WebCore::AXObjectCache::nodeTextChangePlatformNotification):
(WebCore::AXObjectCache::postPlatformNotification): Deleted.

accessibility/ios/AXObjectCacheIOS.mm:

(WebCore::AXObjectCache::postTextStateChangePlatformNotification):
(WebCore::AXObjectCache::postTextReplacementPlatformNotification):

accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::setShouldRepostNotificationsForTests):
(WebCore::AXPostNotificationWithUserInfo):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::postTextStateChangePlatformNotification):
(WebCore::textReplacementChangeDictionary):
(WebCore::AXObjectCache::postTextReplacementPlatformNotification):

accessibility/mac/WebAccessibilityObjectWrapperBase.h:
accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(+[WebAccessibilityObjectWrapperBase accessibilitySetShouldRepostNotifications:]):
(-[WebAccessibilityObjectWrapperBase accessibilityPostedNotification:]):
(arrayRemovingNonJSONTypes):
(dictionaryRemovingNonJSONTypes):
(-[WebAccessibilityObjectWrapperBase accessibilityPostedNotification:userInfo:]):

accessibility/mac/WebAccessibilityObjectWrapperMac.h:
accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(textMarkerRangeFromVisiblePositions):
(-[WebAccessibilityObjectWrapper textMarkerRangeFromVisiblePositions:endPosition:]):

editing/AppendNodeCommand.cpp:

(WebCore::AppendNodeCommand::AppendNodeCommand):
(WebCore::sendAXTextChangedIgnoringLineBreaks):
(WebCore::AppendNodeCommand::doApply):
(WebCore::AppendNodeCommand::doUnapply):

editing/AppendNodeCommand.h:

(WebCore::AppendNodeCommand::create):

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::ApplyStyleCommand):
(WebCore::ApplyStyleCommand::applyBlockStyle): Deleted.

editing/ApplyStyleCommand.h:
editing/CompositeEditCommand.cpp:

(WebCore::EditCommandComposition::unapplyEditType):
(WebCore::CompositeEditCommand::CompositeEditCommand):
(WebCore::CompositeEditCommand::apply):
(WebCore::CompositeEditCommand::insertParagraphSeparator):
(WebCore::CompositeEditCommand::insertNodeBefore):
(WebCore::CompositeEditCommand::appendNode):
(WebCore::CompositeEditCommand::removeNodePreservingChildren):
(WebCore::CompositeEditCommand::insertTextIntoNode):
(WebCore::CompositeEditCommand::deleteTextFromNode):
(WebCore::CompositeEditCommand::replaceTextInNode):
(WebCore::CompositeEditCommand::moveParagraphs):
(WebCore::EditCommandComposition::getNodesInCommand): Deleted.
(WebCore::CompositeEditCommand::applyStyle): Deleted.
(WebCore::CompositeEditCommand::insertLineBreak): Deleted.
(WebCore::CompositeEditCommand::insertNodeAt): Deleted.
(WebCore::CompositeEditCommand::removeChildrenInRange): Deleted.
(WebCore::CompositeEditCommand::inputText): Deleted.

editing/CompositeEditCommand.h:
editing/DeleteFromTextNodeCommand.cpp:

(WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand):
(WebCore::DeleteFromTextNodeCommand::doApply):
(WebCore::DeleteFromTextNodeCommand::doUnapply):

editing/DeleteFromTextNodeCommand.h:

(WebCore::DeleteFromTextNodeCommand::create):
(WebCore::DeleteFromTextNodeCommand::deletedText):

editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
(WebCore::DeleteSelectionCommand::preservesTypingStyle): Deleted.

editing/DeleteSelectionCommand.h:

(WebCore::DeleteSelectionCommand::create):

editing/DictationCommand.cpp:

(WebCore::DictationCommand::insertTextRunWithoutNewlines):
(WebCore::DictationCommand::insertParagraphSeparator):

editing/EditAction.h:
editing/EditCommand.cpp:

(WebCore::EditCommand::EditCommand):
(WebCore::EditCommand::editingAction):
(WebCore::EditCommand::applyEditType):
(WebCore::EditCommand::unapplyEditType):
(WebCore::SimpleEditCommand::SimpleEditCommand):
(WebCore::SimpleEditCommand::notifyAccessibilityForTextChange):
(WebCore::EditCommand::setParent): Deleted.

editing/EditCommand.h:
editing/EditingAllInOne.cpp:
editing/Editor.cpp:

(WebCore::Editor::handleTextEvent):
(WebCore::Editor::deleteSelectionWithSmartDelete):
(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::replaceSelectionWithText):
(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::performCutOrCopy):
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::changeBackToReplacedString):
(WebCore::Editor::transpose):
(WebCore::Editor::changeSelectionAfterCommand):

editing/Editor.h:
editing/EditorCommand.cpp:

(WebCore::executeInsertFragment):

editing/FrameSelection.cpp:

(WebCore::FrameSelection::moveTo):
(WebCore::FrameSelection::moveWithoutValidationTo):
(WebCore::FrameSelection::setSelectionByMouseIfDifferent):
(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance):
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::updateAndRevealSelection):
(WebCore::isBoundary):
(WebCore::FrameSelection::textSelectionIntent):
(WebCore::FrameSelection::modify):
(WebCore::FrameSelection::selectAll):
(WebCore::FrameSelection::wordSelectionContainingCaretSelection):
(WebCore::FrameSelection::modifyMovingBackward): Deleted.
(WebCore::FrameSelection::selectFrameElementInParentIfFullySelected): Deleted.
(WebCore::FrameSelection::selectionAtWordStart): Deleted.

editing/FrameSelection.h:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
(WebCore::FrameSelection::selection): Deleted.

editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):

editing/InsertIntoTextNodeCommand.h:

(WebCore::InsertIntoTextNodeCommand::create):
(WebCore::InsertIntoTextNodeCommand::insertedText):

editing/InsertNodeBeforeCommand.cpp:

(WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand):
(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):

editing/InsertNodeBeforeCommand.h:

(WebCore::InsertNodeBeforeCommand::create):

editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand):

editing/InsertParagraphSeparatorCommand.h:

(WebCore::InsertParagraphSeparatorCommand::create):

editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::InsertTextCommand):

editing/InsertTextCommand.h:

(WebCore::InsertTextCommand::create):
(WebCore::InsertTextCommand::createWithMarkerSupplier):

editing/MoveSelectionCommand.cpp:

(WebCore::MoveSelectionCommand::doApply):

editing/RemoveNodePreservingChildrenCommand.cpp:

(WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand):

editing/RemoveNodePreservingChildrenCommand.h:

(WebCore::RemoveNodePreservingChildrenCommand::create):

editing/ReplaceDeleteFromTextNodeCommand.cpp: Copied from Source/WebCore/editing/AppendNodeCommand.h.

(WebCore::ReplaceDeleteFromTextNodeCommand::ReplaceDeleteFromTextNodeCommand):
(WebCore::ReplaceDeleteFromTextNodeCommand::notifyAccessibilityForTextChange):

editing/ReplaceDeleteFromTextNodeCommand.h: Copied from Source/WebCore/editing/AppendNodeCommand.h.
editing/ReplaceInsertIntoTextNodeCommand.cpp: Added.

(WebCore::ReplaceInsertIntoTextNodeCommand::ReplaceInsertIntoTextNodeCommand):
(WebCore::ReplaceInsertIntoTextNodeCommand::notifyAccessibilityForTextChange):

editing/ReplaceInsertIntoTextNodeCommand.h: Copied from Source/WebCore/editing/RemoveNodePreservingChildrenCommand.h.
editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
(WebCore::ReplaceSelectionCommand::InsertedNodes::didReplaceNode): Deleted.
(WebCore::ReplaceSelectionCommand::insertAsListItems): Deleted.

editing/ReplaceSelectionCommand.h:

(WebCore::ReplaceSelectionCommand::create):

editing/TypingCommand.cpp:

(WebCore::TypingCommand::insertTextRunWithoutNewlines):
(WebCore::TypingCommand::insertParagraphSeparator):

editing/atk/FrameSelectionAtk.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

editing/ios/DictationCommandIOS.cpp:

(WebCore::DictationCommandIOS::DictationCommandIOS):

editing/ios/DictationCommandIOS.h:
editing/mac/FrameSelectionMac.mm:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setInnerTextValue):

page/DragController.cpp:

(WebCore::DragController::concludeEditDrag):

page/EventHandler.cpp:

(WebCore::setInitialKeyboardSelection):

page/FocusController.cpp:

(WebCore::FocusController::advanceFocusInDocumentOrder):

Source/WebKit/mac:

WebCoreSupport/WebEditorClient.mm:

(undoNameForEditAction):

Source/WebKit2:

UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::nameForEditAction):

Tools:

DumpRenderTree/mac/AccessibilityNotificationHandler.h:
DumpRenderTree/mac/AccessibilityNotificationHandler.mm:

(-[AccessibilityNotificationHandler stopObserving]):
(-[AccessibilityNotificationHandler _notificationReceived:]):

DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::removeNotificationListener):

WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:

(-[AccessibilityNotificationHandler _notificationReceived:]):

WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::removeNotificationListener):

LayoutTests:

platform/mac/accessibility/input-replacevalue-userinfo-expected.txt: Added.
platform/mac/accessibility/input-replacevalue-userinfo.html: Added.
platform/mac/accessibility/selection-change-userinfo-expected.txt: Added.
platform/mac/accessibility/selection-change-userinfo.html: Added.
platform/mac/accessibility/value-change-userinfo-expected.txt: Added.
platform/mac/accessibility/value-change-userinfo.html: Added.

9:38 AM Changeset in webkit [183265] by Darin Adler

56 edits
6 deletes in trunk

Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=128007

Reviewed by Anders Carlsson.

Source/WebCore:

PlatformEfl.cmake: Removed OwnPtrCairo source files.
PlatformGTK.cmake: Ditto.
PlatformWinCairo.cmake: Ditto.
WebCore.vcxproj/WebCore.vcxproj: Ditto.
WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.

platform/CrossThreadCopier.cpp: Removed OwnPtr specialization.
platform/CrossThreadCopier.h: Ditto.

platform/ScrollAnimatorNone.cpp: Removed unneeded include.
platform/ThreadGlobalData.cpp: Ditto.
platform/ThreadGlobalData.h: Ditto.
platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.h: Ditto.

platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::processNotification): Use unique_ptr.
(WebCore::AVFWrapper::notificationCallback): Use make_unique.
(WebCore::AVFWrapper::platformLayer): Ditto.

platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::appendPathToCairoContext): Use cairo_path_destroy directly
instead of a smart pointer; the code path is simple enough that it is
clear this way.

platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::ImageBuffer): Use make_unique.

platform/graphics/cairo/ImageBufferDataCairo.h: Use unique_ptr.

platform/graphics/cairo/OwnPtrCairo.cpp: Removed.
platform/graphics/cairo/OwnPtrCairo.h: Removed.

platform/graphics/cairo/PathCairo.cpp:

(WebCore::Path::Path): Use cairo_path_destroy directly instead of a
smart pointer; the code path is simple enough that it is clear this way.
(WebCore::Path::operator=): Ditto.
(WebCore::Path::addPath): Ditto.
(WebCore::Path::apply): Ditto.

platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::clipForPatternFilling): Ditto.

platform/graphics/freetype/FontCacheFreeType.cpp: Removed unneeded include.
platform/graphics/glx/GLContextGLX.cpp: Ditto.

platform/graphics/surfaces/egl/EGLSurface.cpp:

(WebCore::EGLOffScreenSurface::EGLOffScreenSurface): Use make_unique.

platform/graphics/surfaces/glx/GLXConfigSelector.h:

(WebCore::GLXConfigSelector::findMatchingConfig): Use unique_ptr with X11Deleter.
(WebCore::GLXConfigSelector::findMatchingConfigWithVisualId): Ditto.

platform/graphics/surfaces/glx/GLXSurface.cpp:

(WebCore::GLXTransportSurface::GLXTransportSurface): Ditto.
(WebCore::GLXOffScreenSurface::initialize): Ditto.

platform/graphics/surfaces/glx/OwnPtrX11.h: Removed.

platform/graphics/surfaces/glx/X11Helper.cpp:

(WebCore::X11Helper::createOffScreenWindow): Use unique_ptr with X11Deleter.
(WebCore::X11Helper::createPixmap): Ditto.

platform/graphics/surfaces/glx/X11Helper.h: Added X11Deleter,

which can be used with unique_ptr to make it call XFree instead of delete.

platform/graphics/win/FullScreenController.cpp: Use unique_ptr.

(FullScreenController::FullScreenController): Use make_unique.
(FullScreenController::enterFullScreen): Ditto.

platform/graphics/win/FullScreenController.h: Use unique_ptr.

platform/graphics/win/GraphicsContext3DWin.cpp: Removed unneeded includes.

platform/graphics/win/WKCAImageQueue.cpp:

(WebCore::WKCAImageQueue::WKCAImageQueue): Use make_unique.

platform/graphics/win/WKCAImageQueue.h: Use unique_ptr.

platform/network/NetworkStorageSessionStub.cpp: Removed unneeded include.

platform/network/ResourceHandleInternal.h: Use unique_ptr.

platform/network/curl/MultipartHandle.cpp:

(WebCore::MultipartHandle::create): Deleted.

platform/network/curl/MultipartHandle.h: Deleted the create function.

platform/network/curl/ResourceHandleManager.cpp:

(WebCore::headerCallback): Use make_unique.

Source/WebKit2:

NetworkProcess/cache/NetworkCacheEncoder.h: Added an include now

needed that was inherited from OwnPtr.h before.

Source/WTF:

WTF.vcxproj/WTF.vcxproj: Removed OwnPtr source files.
WTF.vcxproj/WTF.vcxproj.filters: Ditto.
WTF.xcodeproj/project.pbxproj: Ditto.
wtf/CMakeLists.txt: Ditto.

wtf/Forward.h: Removed OwnPtr and PassOwnPtr.
wtf/HashTraits.h: Ditto.

wtf/OwnPtr.h: Removed.
wtf/OwnPtrCommon.h: Removed.
wtf/PassOwnPtr.h: Removed.

wtf/SizeLimits.cpp: Removed OwnPtr.
wtf/VectorTraits.h: Removed OwnPtr specialization.

Tools:

DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
DumpRenderTree/win/UIDelegate.h: Ditto.

TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.

TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.

TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.

(TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.

TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.

(TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.

TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:

(WebKitDOMDOMWindowTest::create): Ditto.

TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:

(documentLoadedCallback): Use a queue of DelayedSignal objects instead
of smart pointers to DelayedSIgnal objects.
(uriChangedCallback): Ditto.

8:44 AM Changeset in webkit [183264] by Brent Fulgham

2 edits in trunk/Tools

[Mac] Unreviewed test fix.
https://bugs.webkit.org/show_bug.cgi?id=144149

TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:

(TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
test.

7:39 AM Changeset in webkit [183263] by Antti Koivisto

3 edits in trunk/Source/WebKit2

Network Cache: Make path functions members
https://bugs.webkit.org/show_bug.cgi?id=144146

Reviewed by Carlos Garcia Campos.

This simplifies the code.

NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::partitionPathForKey):
(WebKit::NetworkCache::Storage::recordPathForKey):
(WebKit::NetworkCache::Storage::bodyPathForKey):
(WebKit::NetworkCache::Storage::storeBodyAsBlob):
(WebKit::NetworkCache::Storage::remove):
(WebKit::NetworkCache::Storage::dispatchReadOperation):
(WebKit::NetworkCache::Storage::finishReadOperation):
(WebKit::NetworkCache::Storage::dispatchWriteOperation):
(WebKit::NetworkCache::partitionPathForKey): Deleted.
(WebKit::NetworkCache::recordPathForKey): Deleted.
(WebKit::NetworkCache::bodyPathForKey): Deleted.

NetworkProcess/cache/NetworkCacheStorage.h:

4:42 AM Changeset in webkit [183262] by peavo@outlook.com

4 edits in trunk/Source/WebCore

[Win] Popup menu is not accessible.
https://bugs.webkit.org/show_bug.cgi?id=141704

Reviewed by Brent Fulgham.

Get accessibility information for items in popup menus.

platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::onGetObject):
(WebCore::PopupMenuWin::wndProc):
(WebCore::AccessiblePopupMenu::AccessiblePopupMenu):
(WebCore::AccessiblePopupMenu::~AccessiblePopupMenu):
(WebCore::AccessiblePopupMenu::QueryInterface):
(WebCore::AccessiblePopupMenu::AddRef):
(WebCore::AccessiblePopupMenu::Release):
(WebCore::AccessiblePopupMenu::GetTypeInfoCount):
(WebCore::AccessiblePopupMenu::GetTypeInfo):
(WebCore::AccessiblePopupMenu::GetIDsOfNames):
(WebCore::AccessiblePopupMenu::Invoke):
(WebCore::AccessiblePopupMenu::get_accParent):
(WebCore::AccessiblePopupMenu::get_accChildCount):
(WebCore::AccessiblePopupMenu::get_accChild):
(WebCore::AccessiblePopupMenu::get_accName):
(WebCore::AccessiblePopupMenu::get_accValue):
(WebCore::AccessiblePopupMenu::get_accDescription):
(WebCore::AccessiblePopupMenu::get_accRole):
(WebCore::AccessiblePopupMenu::get_accState):
(WebCore::AccessiblePopupMenu::get_accHelp):
(WebCore::AccessiblePopupMenu::get_accKeyboardShortcut):
(WebCore::AccessiblePopupMenu::get_accFocus):
(WebCore::AccessiblePopupMenu::get_accSelection):
(WebCore::AccessiblePopupMenu::get_accDefaultAction):
(WebCore::AccessiblePopupMenu::accSelect):
(WebCore::AccessiblePopupMenu::accLocation):
(WebCore::AccessiblePopupMenu::accNavigate):
(WebCore::AccessiblePopupMenu::accHitTest):
(WebCore::AccessiblePopupMenu::accDoDefaultAction):
(WebCore::AccessiblePopupMenu::put_accName):
(WebCore::AccessiblePopupMenu::put_accValue):
(WebCore::AccessiblePopupMenu::get_accHelpTopic):

platform/win/PopupMenuWin.h:
platform/win/ScrollbarThemeWin.h:

(WebCore::ScrollbarThemeWin::hasButtons): Deleted.

4:20 AM Changeset in webkit [183261] by Antti Koivisto

7 edits in trunk

Memory cache live resources repeatedly purged during painting
https://bugs.webkit.org/show_bug.cgi?id=144104
Source/WebCore:

<rdar://problem/20667695>

Reviewed by Chris Dumez.

On some PLT pages (like nytimes.com) we get into state where painting repeatedly purges live bitmaps.
This slows down page loads significantly.

This might have regressed because improvements in page caching keep more pages and so resources 'live'.

With this path we do all regular cache pruning asynchronously. If memory is really critical
the low memory handling code will still prune synchronously.

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::didAccessDecodedData):

prune() -> pruneSoon()

loader/cache/MemoryCache.cpp:

Decrease the pruning size target from 0.95 to 0.8 so we don't need to prune so often.

(WebCore::MemoryCache::needsPruning):

Factor into a function.

(WebCore::MemoryCache::prune):
(WebCore::MemoryCache::pruneSoon):

Prune asynchronously.

loader/cache/MemoryCache.h:

LayoutTests:

Reviewed by Chris Dumez.

http/tests/cache/disk-cache/disk-cache-vary-cookie.html:

These clearMemoryCache calls are now done by cache-test.js.

http/tests/cache/disk-cache/resources/cache-test.js:

(loadResources):

Make sure to clear the memory cache explicitly in the beginning so we always hit the disk cache.

(runTests):

4:16 AM Changeset in webkit [183260] by Antti Koivisto

7 edits in trunk

Unreviewed, rolling out r183259.

Wrong ChangeLog.

Reverted changeset:

"Memory cache live resources repeatedly purged during
painting"
https://bugs.webkit.org/show_bug.cgi?id=144104
http://trac.webkit.org/changeset/183259

4:05 AM Changeset in webkit [183259] by Antti Koivisto

7 edits in trunk

Source/WebCore:
CrashTracer: WebProcess at com.apple.WebCore: WebCore::toScriptElementIfPossible + 4
https://bugs.webkit.org/show_bug.cgi?id=144050

Reviewed by Chris Dumez.

We are seeing null Element pointer crashes with this stack:

47 com.apple.WebCore: WebCore::toScriptElementIfPossible + 4 <==
47 com.apple.WebCore: WebCore::ScriptRunner::timerFired + 452
47 com.apple.WebCore: WebCore::ThreadTimers::sharedTimerFiredInternal + 175

The most likely cause seems to be that this code

ASSERT(m_pendingAsyncScripts.contains(scriptElement));
m_scriptsToExecuteSoon.append(m_pendingAsyncScripts.take(scriptElement));

in ScriptRunner::notifyScriptReady fails to find scriptElement and we are left with null entry in
m_scriptsToExecuteSoon. However I haven't managed to repro this or find the exact path how this
could happen. The related code is fragile with lot of state (especially in ScriptElement class)
and involves many opportunities for re-entry via scripts.

No repro, no test case.

dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::timerFired):

Paper this over by adding a null check. We could check m_pendingAsyncScripts.take() above
but this also covers possibility this is caused by something else.

LayoutTests:
Memory cache live resources repeatedly purged during painting
https://bugs.webkit.org/show_bug.cgi?id=144104

Reviewed by Chris Dumez.

http/tests/cache/disk-cache/disk-cache-vary-cookie.html:

These clearMemoryCache calls are now done by cache-test.js.

http/tests/cache/disk-cache/resources/cache-test.js:

(loadResources):

Make sure to clear the memory cache explicitly in the beginning so we always hit the disk cache.

(runTests):

3:21 AM Changeset in webkit [183258] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

Unreviewed. Remove incorrect assert after r183189.

In this case the assert was already there, but it's incorrect
because we are handling uninitialized attachments below in the
same function, and also when sending messages. So, if it's ok to
send uninitialized attachments, it's ok to receive them. This
didn't fail before r183189, because we were only invaliding the
attachments by setting the file descriptor to -1, and they were
handled as null attachments. After r183189, the move operator
resets the moved attachment leaving it uninitialized again.

Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::processMessage):

12:41 AM Changeset in webkit [183257] by bshafiei@apple.com

1 copy in tags/Safari-601.1.29

New tag.

12:40 AM Changeset in webkit [183256] by bshafiei@apple.com

5 edits in trunk/Source

Versioning.

12:17 AM Changeset in webkit [183255] by Carlos Garcia Campos

6 edits in trunk/Source

[SOUP] Use a webkit subdirectory for the disk cache
https://bugs.webkit.org/show_bug.cgi?id=144048

Reviewed by Martin Robinson.

Source/WebCore:

Add a static method to SoupNetworkSession to clear a soup cache
given its directory.

platform/network/soup/SoupNetworkSession.cpp:

(WebCore::strIsNumeric):
(WebCore::SoupNetworkSession::clearCache):

platform/network/soup/SoupNetworkSession.h:

Source/WebKit2:

Recent versions of libsoup remove any file in cache dir not
referenced by the index when the cache is loaded to workaround
leaked resources when load/dump is unbalanced for whatever reason,
like a crash. We currently use $XDG_CACHE_HOME/app-name as default
disk cache directory, but that directory could be used by apps to
cache other things, and the soup cache might end up deleting other
stuff. The soup cache assumes the given directory is only for the
disk cache, so we should ensure that.

NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess): Append
webkit to the given disk cache and clear the previous soup cache if it exists.

WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformInitializeWebProcess): Ditto.

12:05 AM Changeset in webkit [183254] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

Unreviewed. Remove incorrect ASSERT added in r183176.

We allow to encode null attachments.

Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::Handle::releaseAttachment):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed