Timeline

Apr 26, 2015:

11:47 PM Changeset in webkit [183388] by Philippe Normand

• 7 edits
  2 adds in trunk

[JHBuild] Move to upstream OpenWebRTC
​https://bugs.webkit.org/show_bug.cgi?id=144145

Reviewed by Carlos Garcia Campos.

.:

• Source/cmake/FindOpenWebRTC.cmake: Check the presence of the

owr-gst library.

Source/WebCore:

• platform/mediastream/openwebrtc/OpenWebRTCUtilities.cpp:

(WebCore::initializeOpenWebRTC): Update with new owr_init API.

Tools:

• efl/jhbuild.modules: Switch to upstream OpenWebRTC repository

and add a new simple patch to gst-plugins-base, required for
OpenWebRTC build.

• efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
• gtk/jhbuild.modules: Ditto.
• gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.

11:17 PM Changeset in webkit [183387] by Carlos Garcia Campos

• 11 edits
  4 adds
  1 delete in trunk/Source

[SOUP] Add initial implementation of NetworkProcess disk cache
​https://bugs.webkit.org/show_bug.cgi?id=143872

Reviewed by Martin Robinson.

Source/WebCore:

Allow to create a GRefPtr for SoupBuffer. Even though SoupBuffer
is not a GObject and has copy/free functions instead of ref/unref,
it's internally refcounted, so we could use copy/free as
ref/unref.

• PlatformGTK.cmake:
• platform/network/soup/GRefPtrSoup.cpp: Added.

(WTF::refGPtr):
(WTF::derefGPtr):

• platform/network/soup/GRefPtrSoup.h: Added.

Source/WebKit2:

Implement the platform specific parts of the disk cache
implementation for Soup. It's mainly NetworkCache::Data and
NetworkCache::IOChannel.

• CMakeLists.txt:
• NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::dumpFileChanged):
(WebKit::NetworkCache::Cache::initialize):

• NetworkProcess/cache/NetworkCacheBlobStorage.cpp:
• NetworkProcess/cache/NetworkCacheData.h:

(WebKit::NetworkCache::Data::soupBuffer):

• NetworkProcess/cache/NetworkCacheDataSoup.cpp: Added.

(WebKit::NetworkCache::Data::Data):
(WebKit::NetworkCache::Data::empty):
(WebKit::NetworkCache::Data::data):
(WebKit::NetworkCache::Data::isNull):
(WebKit::NetworkCache::Data::apply):
(WebKit::NetworkCache::Data::subrange):
(WebKit::NetworkCache::concatenate):
(WebKit::NetworkCache::MapWrapper::~MapWrapper):
(WebKit::NetworkCache::deleteMapWrapper):
(WebKit::NetworkCache::mapFile):
(WebKit::NetworkCache::Data::adoptMap):
(WebKit::NetworkCache::computeSHA1):
(WebKit::NetworkCache::bytesEqual):

• NetworkProcess/cache/NetworkCacheIOChannel.h:
• NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp: Added.

(WebKit::NetworkCache::IOChannel::IOChannel):
(WebKit::NetworkCache::IOChannel::open):
(WebKit::NetworkCache::fillDataFromReadBuffer):
(WebKit::NetworkCache::inputStreamReadReadyCallback):
(WebKit::NetworkCache::IOChannel::read):
(WebKit::NetworkCache::IOChannel::readSync):
(WebKit::NetworkCache::outputStreamWriteReadyCallback):
(WebKit::NetworkCache::IOChannel::write):

• NetworkProcess/cache/NetworkCacheStorageSoup.cpp: Removed.
• NetworkProcess/gtk/NetworkProcessMainGtk.cpp:
• NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::platformSetCacheModel):
(WebKit::NetworkProcess::clearDiskCache):

• PlatformGTK.cmake:

10:58 PM Changeset in webkit [183386] by ap@apple.com

• 2 edits in trunk/LayoutTests

editing/selection/programmatic-selection-on-mac-is-directionless.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=141122

• platform/wk2/TestExpectations: Mark the test as such. Unfortunately, there are

almost certainly other tests affected by this.

10:39 PM Changeset in webkit [183385] by Manuel Rego Casasnovas

• 5 edits in trunk

[CSS Grid Layout] LayoutBox::hasDefiniteLogicalHeight() should consider abspos boxes as definite
​https://bugs.webkit.org/show_bug.cgi?id=144144

Reviewed by Darin Adler.

Source/WebCore:

Change order in hasDefiniteLogicalHeight() ifs to consider definite
absolutely positioned elements.

Test: fast/css-grid-layout/percent-track-breadths-regarding-container-size.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::hasDefiniteLogicalHeight):

LayoutTests:

Add new test case to check absolutely positioned elements.

• fast/css-grid-layout/percent-track-breadths-regarding-container-size-expected.txt:
• fast/css-grid-layout/percent-track-breadths-regarding-container-size.html:

10:02 PM Changeset in webkit [183384] by Gyuyoung Kim

• 2 edits in trunk/LayoutTests

Class body ending with a semicolon throws a SyntaxError
​https://bugs.webkit.org/show_bug.cgi?id=144244

Patch by Ryosuke Niwa <​rniwa@webkit.org> on 2015-04-26
Reviewed by Darin Adler.

Added a regression test for having a semicolon inside the class definition.

• js/class-syntax-semicolon-expected.txt: Added.
• js/class-syntax-semicolon.html: Added.
• js/script-tests/class-syntax-semicolon.js: Added.

9:20 PM Changeset in webkit [183383] by rniwa@webkit.org

• 3 edits
  3 adds in trunk

Class body ending with a semicolon throws a SyntaxError
​https://bugs.webkit.org/show_bug.cgi?id=144244

Reviewed by Darin Adler.

Source/JavaScriptCore:

The bug was caused by parseClass's inner loop for method definitions not moving onto the next iteration
it encounters a semicolon. As a result, we always expected a method to appear after a semicolon. Fixed
it by continue'ing when it encounters a semicolon.

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):

LayoutTests:

Added a regression test for having a semicolon inside the class definition.

• js/class-syntax-semicolon-expected.txt: Added.
• js/class-syntax-semicolon.html: Added.
• js/script-tests/class-syntax-semicolon.js: Added.

9:18 PM Changeset in webkit [183382] by rniwa@webkit.org

• 7 edits in trunk

Getter or setter method named "prototype" or "constrcutor" should throw SyntaxError
​https://bugs.webkit.org/show_bug.cgi?id=144243

Reviewed by Darin Adler.

Source/JavaScriptCore:

Fixed the bug by adding explicit checks in parseGetterSetter when we're parsing class methods.

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseGetterSetter):

LayoutTests:

Added tests cases to both tests. Also added test cases missing from expression tests.

• js/class-syntax-declaration-expected.txt:
• js/class-syntax-expression-expected.txt:
• js/script-tests/class-syntax-declaration.js:
• js/script-tests/class-syntax-expression.js:

8:51 PM Changeset in webkit [183381] by commit-queue@webkit.org

• 86 edits
  2 adds in trunk

SVGFilterBuilder should drive the builtin sourceAlpha from the passed sourceGraphic
​https://bugs.webkit.org/show_bug.cgi?id=144137

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2015-04-26
Reviewed by Darin Adler.

Source/WebCore:

The SourceAlpha should be driven from the last applied FilterEffect. This
will require the SourceAlpha FilterEffect to wrap a FilterEffect rather
than just getting the SourceGraphic reference from FilterEffectRenderer.

This is based on the Blink patch:
​https://src.chromium.org/viewvc/blink?revision=194115&view=revision.

Test: svg/filters/sourceAlpha-input-filter-effect.html

• platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::create): Make SourceAlpha wraps a FilterEffect
rather than a Filter.

(WebCore::SourceAlpha::determineAbsolutePaintRect): Determine the paint
rect from the wrapped FilterEffect.

(WebCore::SourceAlpha::platformApplySoftware): Extract the alpha channel
from the wrapped FilterEffect.

(WebCore::SourceAlpha::SourceAlpha):

• platform/graphics/filters/SourceAlpha.h:

(WebCore::SourceAlpha::SourceAlpha): Deleted.
Reimplement the constructor of the SourceAlpha such that it wraps the
sourceEffect in its inputEffects.

• rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter): Delete the FIXME
comment and do exactly what it said. This matches the implementation of
Gecko and Blink.

• rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives):
Delete the extra argument.

• svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::SVGFilterBuilder):

• svg/graphics/filters/SVGFilterBuilder.h: Drive the SourceAlpha from the

passed source FilterEffect.

• platform/graphics/filters/FEBlend.cpp:
• platform/graphics/filters/FEBlend.h:
• platform/graphics/filters/FEColorMatrix.cpp:
• platform/graphics/filters/FEColorMatrix.h:
• platform/graphics/filters/FEComponentTransfer.cpp:
• platform/graphics/filters/FEComponentTransfer.h:
• platform/graphics/filters/FEComposite.cpp:
• platform/graphics/filters/FEComposite.h:
• platform/graphics/filters/FEConvolveMatrix.cpp:
• platform/graphics/filters/FEConvolveMatrix.h:
• platform/graphics/filters/FEDiffuseLighting.cpp:
• platform/graphics/filters/FEDiffuseLighting.h:
• platform/graphics/filters/FEDisplacementMap.cpp:
• platform/graphics/filters/FEDisplacementMap.h:
• platform/graphics/filters/FEDropShadow.cpp:
• platform/graphics/filters/FEDropShadow.h:
• platform/graphics/filters/FEFlood.cpp:
• platform/graphics/filters/FEFlood.h:
• platform/graphics/filters/FEGaussianBlur.cpp:
• platform/graphics/filters/FEGaussianBlur.h:
• platform/graphics/filters/FELighting.cpp:
• platform/graphics/filters/FELighting.h:
• platform/graphics/filters/FEMerge.cpp:
• platform/graphics/filters/FEMerge.h:
• platform/graphics/filters/FEMorphology.cpp:
• platform/graphics/filters/FEMorphology.h:
• platform/graphics/filters/FEOffset.cpp:
• platform/graphics/filters/FEOffset.h:
• platform/graphics/filters/FESpecularLighting.cpp:
• platform/graphics/filters/FESpecularLighting.h:
• platform/graphics/filters/FETile.cpp:
• platform/graphics/filters/FETile.h:
• platform/graphics/filters/FETurbulence.cpp:
• platform/graphics/filters/FETurbulence.h:
• platform/graphics/filters/Filter.h:
• platform/graphics/filters/FilterEffect.cpp:
• platform/graphics/filters/FilterEffect.h:
• platform/graphics/filters/SourceGraphic.cpp:
• platform/graphics/filters/SourceGraphic.h:
• rendering/svg/RenderSVGResourceFilter.h:
• rendering/svg/SVGRenderTreeAsText.cpp:

Code clean up: Pointer to reference conversion. It starts by converting
FilterEffect::m_filter from pointer to reference and it kept expanding.
All the creations of FilterEffect were happening by passing "this" so
passing "*this" did not require to check whether the pointer is nil.

• svg/SVGFEBlendElement.cpp:
• svg/SVGFEBlendElement.h:
• svg/SVGFEColorMatrixElement.cpp:
• svg/SVGFEColorMatrixElement.h:
• svg/SVGFEComponentTransferElement.cpp:
• svg/SVGFEComponentTransferElement.h:
• svg/SVGFECompositeElement.cpp:
• svg/SVGFECompositeElement.h:
• svg/SVGFEConvolveMatrixElement.cpp:
• svg/SVGFEConvolveMatrixElement.h:
• svg/SVGFEDiffuseLightingElement.cpp:
• svg/SVGFEDiffuseLightingElement.h:
• svg/SVGFEDisplacementMapElement.cpp:
• svg/SVGFEDisplacementMapElement.h:
• svg/SVGFEDropShadowElement.cpp:
• svg/SVGFEDropShadowElement.h:
• svg/SVGFEFloodElement.cpp:
• svg/SVGFEFloodElement.h:
• svg/SVGFEGaussianBlurElement.cpp:
• svg/SVGFEGaussianBlurElement.h:
• svg/SVGFEImageElement.cpp:
• svg/SVGFEImageElement.h:
• svg/SVGFEMergeElement.cpp:
• svg/SVGFEMergeElement.h:
• svg/SVGFEMorphologyElement.cpp:
• svg/SVGFEMorphologyElement.h:
• svg/SVGFEOffsetElement.cpp:
• svg/SVGFEOffsetElement.h:
• svg/SVGFESpecularLightingElement.cpp:
• svg/SVGFESpecularLightingElement.h:
• svg/SVGFETileElement.cpp:
• svg/SVGFETileElement.h:
• svg/SVGFETurbulenceElement.cpp:
• svg/SVGFETurbulenceElement.h:
• svg/SVGFilterPrimitiveStandardAttributes.h:
• svg/graphics/filters/SVGFEImage.cpp:
• svg/graphics/filters/SVGFEImage.h:

Code clean up: Pointer to reference and PassRefPtr<> to RefPtr<> or Ref<>
conversion.

LayoutTests:

Ensure the SourceAlpha is driven from last applied FilterEffect.

• svg/filters/sourceAlpha-input-filter-effect-expected.html: Added.
• svg/filters/sourceAlpha-input-filter-effect.html: Added.

8:38 PM Changeset in webkit [183380] by benjamin@webkit.org

• 2 edits in trunk/Websites/webkit.org

Improve the status page
​https://bugs.webkit.org/show_bug.cgi?id=144248

Reviewed by Darin Adler.

• status.html:

Lots of minor changes:
-Add a page title.
-Do not use sync XHR. That was nice for testing but that's eveil

and it breaks Firefox.

-Start fetching the json files as soon as possible during page load,

that server takes forever to respond.

-Remove some useless CSS.
-Get rid of mustache. That template thing was awesome but it took

up to 600ms to fetch the file (plus it is not exactly efficient).

-Put both the specifications and the features in the list.

They are referencing each other with links. That seems to work pretty well.

-Use the keywords for filtering.

7:30 PM Changeset in webkit [183379] by Gyuyoung Kim

• 2 edits in trunk/LayoutTests

[EFL] Unreviewed EFL gardening on 27th April.

Unskip 2 tests which have been passed since r183368.

Mark editing/selection/extend-by-character-007.html to missing.
This needs to have new baseline for EFL port.

• platform/efl/TestExpectations:

7:04 PM Changeset in webkit [183378] by Darin Adler

• 3 edits in trunk/Source/WebCore

REGRESSION (r174283): disabled default buttons use impossible-to-read white text on Mac
​https://bugs.webkit.org/show_bug.cgi?id=144237

Reviewed by Simon Fraser.

No test because DumpRenderTree and WebKitTestRunner don't have a good method
for testing behaviors that are specific to active windows. That's the same reason
that the change that caused this bug didn't come with a regression test.

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle): Renamed "e" to "element". Added a comment to
clarify the meaning of the setInsideDefaultButton function, and added an
isDisabledFormControl check so it won't trigger on a disabled button.
(WebCore::RenderTheme::systemColor): Moved CSSValueActivebuttontext into
alphabetical order to match the rest of the switch statement ordering.

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor): Moved CSSValueActivebuttontext into
alphabetical order to match the rest of the switch statement ordering. Also
fixed its behavior on older versions of OS X; it should just return the same
thing that CSSValueButtontext would return in that context.

6:52 PM Changeset in webkit [183377] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Cannot make Timeline time range selection clicking inside Frames Overview
​https://bugs.webkit.org/show_bug.cgi?id=143744

Patch by Matt Baker <Matt Baker> on 2015-04-26
Reviewed by Timothy Hatcher.

Fixed frame rate divider element style so that it is no longer a mouse event target.

• UserInterface/Views/RenderingFrameTimelineOverviewGraph.css:

(.timeline-overview-graph.rendering-frame > .divider):

6:25 PM Changeset in webkit [183376] by timothy@apple.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Allow Timeline tab to show resource when a go-to arrow is clicked in a recording
​https://bugs.webkit.org/show_bug.cgi?id=144240

Only support showing a resource or script if we have that represented object in the Timeline sidebar.

Reviewed by Darin Adler.

• UserInterface/Views/TimelineTabContentView.js:

(WebInspector.TimelineTabContentView.prototype.canShowRepresentedObject):

6:24 PM Changeset in webkit [183375] by timothy@apple.com

• 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Don't use treeElement.revealAndSelect when showing a default content view
​https://bugs.webkit.org/show_bug.cgi?id=144239

Using revealAndSelect will end up calling WebInspector.showRepresentedObject. That is not bad
is most cases, but if the select tab supports the same represented object, it can end up showing
the content view in the wrong tab.

Reviewed by Darin Adler.

• UserInterface/Views/ContentBrowserTabContentView.js:

(WebInspector.ContentBrowserTabContentView.prototype._revealAndSelectRepresentedObjectInNavigationSidebar):

• UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype.showDefaultContentView):

• UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype.showDefaultContentViewForTreeElement):
(WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie):
(WebInspector.NavigationSidebarPanel):
(WebInspector.NavigationSidebarPanel.prototype.showContentViewForCurrentSelection): Deleted.

• UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype.showDefaultContentView):
(WebInspector.ResourceSidebarPanel.prototype._mainFrameDidChange):
(WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
(WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):

5:33 PM Changeset in webkit [183374] by commit-queue@webkit.org

• 2 edits
  3 adds in trunk

Map#forEach does not pass "map" argument to callback.
​https://bugs.webkit.org/show_bug.cgi?id=144187

Patch by Jordan Harband <​ljharb@gmail.com> on 2015-04-26
Reviewed by Darin Adler.

Per ​https://people.mozilla.org/~jorendorff/es6-draft.html#sec-map.prototype.foreach
step 7.a.i., the callback should be called with three arguments.

• runtime/MapPrototype.cpp:

(JSC::mapProtoFuncForEach):

5:27 PM Changeset in webkit [183373] by Yusuke Suzuki

• 37 edits
  3 adds in trunk

[ES6] Implement ES6 template literals
​https://bugs.webkit.org/show_bug.cgi?id=142691

Reviewed by Darin Adler.

.:

Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.

• Source/cmake/WebKitFeatures.cmake:
• Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

This patch implements TemplateLiteral.
Since TaggedTemplate requires some global states and
primitive operations like GetTemplateObject,
we separate the patch. It will be implemented in a subsequent patch.

Template Literal Syntax is guarded by ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
By disabling it, we can disable Template Literal support.

To implement template literals, in this patch,
we newly introduces bytecode op_to_string.
In template literals, we alternately evaluate the expression and
perform ToString onto the result of evaluation.
For example,

${f1()} ${f2()}

In this template literal, execution order is the following,

1. calling f1()
2. ToString(the result of f1())
3. calling f2()
4. ToString(the result of f2())

op_strcat also performs ToString. However, performing ToString
onto expressions are batched in op_strcat, it's not the same to the
template literal spec. In the above example,
ToString(f1()) should be called before calling f2().

• Configurations/FeatureDefines.xcconfig:
• bytecode/BytecodeList.json:
• bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

• bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitToString):
(JSC::BytecodeGenerator::emitToNumber): Deleted.

• bytecompiler/NodesCodegen.cpp:

(JSC::TemplateStringNode::emitBytecode):
(JSC::TemplateLiteralNode::emitBytecode):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

• jit/JIT.h:
• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_to_string):
(JSC::JIT::emitSlow_op_to_string):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_to_string):
(JSC::JIT::emitSlow_op_to_string):

• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• parser/ASTBuilder.h:

(JSC::ASTBuilder::createTemplateString):
(JSC::ASTBuilder::createTemplateStringList):
(JSC::ASTBuilder::createTemplateExpressionList):
(JSC::ASTBuilder::createTemplateLiteral):

• parser/Lexer.cpp:

(JSC::Lexer<T>::Lexer):
(JSC::Lexer<T>::parseIdentifierSlowCase):
(JSC::Lexer<T>::parseString):
(JSC::LineNumberAdder::LineNumberAdder):
(JSC::LineNumberAdder::clear):
(JSC::LineNumberAdder::add):
(JSC::Lexer<T>::parseTemplateLiteral):
(JSC::Lexer<T>::lex):
(JSC::Lexer<T>::scanRegExp):
(JSC::Lexer<T>::scanTrailingTemplateString):
(JSC::Lexer<T>::parseStringSlowCase): Deleted.

• parser/Lexer.h:
• parser/NodeConstructors.h:

(JSC::TemplateExpressionListNode::TemplateExpressionListNode):
(JSC::TemplateStringNode::TemplateStringNode):
(JSC::TemplateStringListNode::TemplateStringListNode):
(JSC::TemplateLiteralNode::TemplateLiteralNode):

• parser/Nodes.h:

(JSC::TemplateExpressionListNode::value):
(JSC::TemplateExpressionListNode::next):
(JSC::TemplateStringNode::cooked):
(JSC::TemplateStringNode::raw):
(JSC::TemplateStringListNode::value):
(JSC::TemplateStringListNode::next):

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseTemplateString):
(JSC::Parser<LexerType>::parseTemplateLiteral):
(JSC::Parser<LexerType>::parsePrimaryExpression):

• parser/Parser.h:
• parser/ParserTokens.h:
• parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createTemplateString):
(JSC::SyntaxChecker::createTemplateStringList):
(JSC::SyntaxChecker::createTemplateExpressionList):
(JSC::SyntaxChecker::createTemplateLiteral):
(JSC::SyntaxChecker::createSpreadExpression): Deleted.

• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/CommonSlowPaths.h:
• tests/stress/template-literal-line-terminators.js: Added.

(test):
(testEval):
(testEvalLineNumber):

• tests/stress/template-literal-syntax.js: Added.

(testSyntax):
(testSyntaxError):

• tests/stress/template-literal.js: Added.

(test):
(testEval):
(testEmbedded):

Source/WebCore:

Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.

• Configurations/FeatureDefines.xcconfig:

Tools:

Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.

• Scripts/webkitperl/FeatureList.pm:

4:41 PM Changeset in webkit [183372] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit2

Remove PluginView::renderer().
​https://bugs.webkit.org/show_bug.cgi?id=144216

Patch by Sungmann Cho <​sungmann.cho@navercorp.com> on 2015-04-26
Reviewed by Darin Adler.

Nobody should have to know about the plug-in view's renderer except the plug-in view itself.

No new tests, no behavior change.

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::convertFromScrollbarToContainingView):
(WebKit::PDFPlugin::convertFromContainingViewToScrollbar):

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::renderer): Deleted.

• WebProcess/Plugins/PluginView.h:

3:54 PM Changeset in webkit [183371] by commit-queue@webkit.org

• 2 edits
  3 adds in trunk

Set#forEach does not pass "key" or "set" arguments to callback.
​https://bugs.webkit.org/show_bug.cgi?id=144188

Patch by Jordan Harband <​ljharb@gmail.com> on 2015-04-26
Reviewed by Darin Adler.

Per ​https://people.mozilla.org/~jorendorff/es6-draft.html#sec-set.prototype.foreach
Set#forEach should pass 3 arguments to the callback.

• runtime/SetPrototype.cpp:

(JSC::setProtoFuncForEach):

3:44 PM Changeset in webkit [183370] by jfernandez@igalia.com

• 11 edits
  2 adds in trunk

[CSS Grid Layout] Support for align-self and align-items in grid layout
​https://bugs.webkit.org/show_bug.cgi?id=133225

Reviewed by Darin Adler.

Source/WebCore:

Implementation of align-self and align-items properties for grid. It supports
different writing-modes and direction. Margins, borders and paddings are also
considered when computing the final position and stretched size.

Overflow handling is still missing and will be added when implemented row-axis
alignment support.

Test: fast/css-grid-layout/grid-align.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight):

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::logicalContentHeightForChild):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::computeOverflowAlignmentOffset):
(WebCore::RenderGrid::endOfRowForChild):
(WebCore::RenderGrid::startOfRowForChild):
(WebCore::RenderGrid::centeredRowPositionForChild):
(WebCore::marginWidthForChild):
(WebCore::marginHeightForChild):
(WebCore::RenderGrid::allowedToStretchLogicalHeightForChild):
(WebCore::RenderGrid::needToStretchChildLogicalHeight):
(WebCore::RenderGrid::marginLogicalHeightForChild):
(WebCore::RenderGrid::availableAlignmentSpaceForChildBeforeStretching):
(WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded):
(WebCore::RenderGrid::rowPositionForChild):
(WebCore::RenderGrid::findChildLogicalPosition):
(WebCore::RenderGrid::populateGridPositions): Deleted.

• rendering/RenderGrid.h:

LayoutTests:

Implementation of align-self and align-items properties ifor grid.

Several layout tests were touched for adapting them to the new grid item's
column-axis position when using RTL direction.

• fast/css-grid-layout/grid-align-expected.txt: Added.
• fast/css-grid-layout/grid-align.html: Added.
• fast/css-grid-layout/grid-element-border-grid-item.html:
• fast/css-grid-layout/grid-element-border-padding-grid-item.html:
• fast/css-grid-layout/grid-element-padding-grid-item.html:
• fast/css-grid-layout/grid-item-margin-auto-columns-rows-horizontal-rtl-expected.html:
• fast/css-grid-layout/grid-item-margin-auto-columns-rows-vertical-rtl-expected.html:
• fast/css-grid-layout/grid-item-margin-resolution.html:

3:31 PM Changeset in webkit [183369] by Gyuyoung Kim

• 2 edits in trunk/Tools

[CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake
​https://bugs.webkit.org/show_bug.cgi?id=144217

Reviewed by Darin Adler.

• WebKitTestRunner/PlatformEfl.cmake:

3:17 PM Changeset in webkit [183368] by commit-queue@webkit.org

• 74 edits
  3 copies
  8 adds in trunk

AX: richer text change notifications (142719)
​https://bugs.webkit.org/show_bug.cgi?id=142719

Patch by Doug Russell <​d_russell@apple.com> on 2015-04-26
Reviewed by Darin Adler.

Richer accessibility value change notifications. Introduce AXTextEditType,
postTextStateChangeNotification and postTextReplacementNotification to give assistive
tech apps more reliable context for responding to changes in web content. Also implement
a mechanism to post value changes in password form fields in coalesced ticks to thwart
analyzing the cadence of changes.

Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
and an overload of postTextReplacementNotification to give assistive tech apps more
reliable context for responding to changes in web content selection. Also block posting
selection changes on password fields.

Source/WebCore:

Tests: platform/mac/accessibility/input-replacevalue-userinfo.html

platform/mac/accessibility/selection-change-userinfo.html
platform/mac/accessibility/value-change-userinfo.html

• CMakeLists.txt:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::notificationPostTimerFired):
(WebCore::AXObjectCache::passwordNotificationPostTimerFired):
(WebCore::AXObjectCache::showIntent):
(WebCore::AXObjectCache::setTextSelectionIntent):
(WebCore::isPasswordFieldOrContainedByPasswordField):
(WebCore::AXObjectCache::postTextStateChangeNotification):
(WebCore::AXObjectCache::postTextReplacementNotification):
(WebCore::AXObjectCache::enqueuePasswordValueChangeNotification):
(WebCore::AXObjectCache::rootWebArea):
(WebCore::AXObjectCache::textChangeForEditType):
(WebCore::AXObjectCache::selectedChildrenChanged): Deleted.
(WebCore::AXObjectCache::frameLoadingEventNotification): Deleted.

• accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::postTextStateChangeNotification):
(WebCore::AXObjectCache::postTextReplacementNotification):
(WebCore::AXObjectCache::postTextStateChangePlatformNotification):
(WebCore::AXObjectCache::postTextReplacementPlatformNotification):
(WebCore::AXObjectCache::textChangeForEditType):
(WebCore::AXObjectCache::nodeTextChangePlatformNotification):
(WebCore::AXObjectCache::computedObjectAttributeCache): Deleted.
(WebCore::AXObjectCache::getOrCreate): Deleted.
(WebCore::AXObjectCache::attachWrapper): Deleted.

• accessibility/AXTextStateChangeIntent.h: Added.

(WebCore::AXTextStateChangeIntent::AXTextStateChangeIntent):

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::passwordFieldOrContainingPasswordField):

• accessibility/AccessibilityNodeObject.h:
• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isContainedByPasswordField):

• accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::passwordFieldOrContainingPasswordField):
(WebCore::AccessibilityObject::isPasswordField): Deleted.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::setSelectedTextRange):
(WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):

• accessibility/AccessibilityScrollView.h:
• accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::nodeTextChangePlatformNotification):

• accessibility/ios/AXObjectCacheIOS.mm:

(WebCore::AXObjectCache::postTextStateChangePlatformNotification):
(WebCore::AXObjectCache::postTextReplacementPlatformNotification):

• accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::setShouldRepostNotificationsForTests):
(WebCore::AXPostNotificationWithUserInfo):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::postTextStateChangePlatformNotification):
(WebCore::textReplacementChangeDictionary):
(WebCore::AXObjectCache::postTextReplacementPlatformNotification):

• accessibility/mac/WebAccessibilityObjectWrapperBase.h:
• accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(+[WebAccessibilityObjectWrapperBase accessibilitySetShouldRepostNotifications:]):
(-[WebAccessibilityObjectWrapperBase accessibilityPostedNotification:]):
(arrayRemovingNonJSONTypes):
(dictionaryRemovingNonJSONTypes):
(-[WebAccessibilityObjectWrapperBase accessibilityPostedNotification:userInfo:]):

• accessibility/mac/WebAccessibilityObjectWrapperMac.h:
• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(textMarkerRangeFromVisiblePositions):
(-[WebAccessibilityObjectWrapper textMarkerRangeFromVisiblePositions:endPosition:]):

• editing/AppendNodeCommand.cpp:

(WebCore::AppendNodeCommand::AppendNodeCommand):
(WebCore::sendAXTextChangedIgnoringLineBreaks):
(WebCore::AppendNodeCommand::doApply):
(WebCore::AppendNodeCommand::doUnapply):

• editing/AppendNodeCommand.h:

(WebCore::AppendNodeCommand::create):

• editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::ApplyStyleCommand):
(WebCore::ApplyStyleCommand::applyBlockStyle): Deleted.

• editing/ApplyStyleCommand.h:
• editing/CompositeEditCommand.cpp:

(WebCore::EditCommandComposition::unapplyEditType):
(WebCore::CompositeEditCommand::CompositeEditCommand):
(WebCore::CompositeEditCommand::apply):
(WebCore::CompositeEditCommand::insertParagraphSeparator):
(WebCore::CompositeEditCommand::insertNodeBefore):
(WebCore::CompositeEditCommand::appendNode):
(WebCore::CompositeEditCommand::removeNodePreservingChildren):
(WebCore::CompositeEditCommand::insertTextIntoNode):
(WebCore::CompositeEditCommand::deleteTextFromNode):
(WebCore::CompositeEditCommand::replaceTextInNode):
(WebCore::CompositeEditCommand::moveParagraphs):
(WebCore::EditCommandComposition::getNodesInCommand): Deleted.
(WebCore::CompositeEditCommand::applyStyle): Deleted.
(WebCore::CompositeEditCommand::insertLineBreak): Deleted.
(WebCore::CompositeEditCommand::insertNodeAt): Deleted.
(WebCore::CompositeEditCommand::removeChildrenInRange): Deleted.
(WebCore::CompositeEditCommand::inputText): Deleted.

• editing/CompositeEditCommand.h:
• editing/DeleteFromTextNodeCommand.cpp:

(WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand):
(WebCore::DeleteFromTextNodeCommand::doApply):
(WebCore::DeleteFromTextNodeCommand::doUnapply):

• editing/DeleteFromTextNodeCommand.h:

(WebCore::DeleteFromTextNodeCommand::create):
(WebCore::DeleteFromTextNodeCommand::deletedText):

• editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
(WebCore::DeleteSelectionCommand::preservesTypingStyle): Deleted.

• editing/DeleteSelectionCommand.h:

(WebCore::DeleteSelectionCommand::create):

• editing/DictationCommand.cpp:

(WebCore::DictationCommand::insertTextRunWithoutNewlines):
(WebCore::DictationCommand::insertParagraphSeparator):

• editing/EditAction.h:
• editing/EditCommand.cpp:

(WebCore::EditCommand::EditCommand):
(WebCore::EditCommand::editingAction):
(WebCore::EditCommand::applyEditType):
(WebCore::EditCommand::unapplyEditType):
(WebCore::SimpleEditCommand::SimpleEditCommand):
(WebCore::SimpleEditCommand::notifyAccessibilityForTextChange):
(WebCore::EditCommand::setParent): Deleted.

• editing/EditCommand.h:
• editing/EditingAllInOne.cpp:
• editing/Editor.cpp:

(WebCore::Editor::handleTextEvent):
(WebCore::Editor::deleteSelectionWithSmartDelete):
(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::replaceSelectionWithText):
(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::performCutOrCopy):
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::changeBackToReplacedString):
(WebCore::Editor::transpose):
(WebCore::Editor::changeSelectionAfterCommand):

• editing/Editor.h:
• editing/EditorCommand.cpp:

(WebCore::executeInsertFragment):

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::moveTo):
(WebCore::FrameSelection::moveWithoutValidationTo):
(WebCore::FrameSelection::setSelectionByMouseIfDifferent):
(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance):
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::updateAndRevealSelection):
(WebCore::isBoundary):
(WebCore::FrameSelection::textSelectionIntent):
(WebCore::FrameSelection::modify):
(WebCore::FrameSelection::selectAll):
(WebCore::FrameSelection::wordSelectionContainingCaretSelection):
(WebCore::FrameSelection::modifyMovingBackward): Deleted.
(WebCore::FrameSelection::selectFrameElementInParentIfFullySelected): Deleted.
(WebCore::FrameSelection::selectionAtWordStart): Deleted.

• editing/FrameSelection.h:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
(WebCore::FrameSelection::selection): Deleted.

• editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):

• editing/InsertIntoTextNodeCommand.h:

(WebCore::InsertIntoTextNodeCommand::create):
(WebCore::InsertIntoTextNodeCommand::insertedText):

• editing/InsertNodeBeforeCommand.cpp:

(WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand):
(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):

• editing/InsertNodeBeforeCommand.h:

(WebCore::InsertNodeBeforeCommand::create):

• editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand):

• editing/InsertParagraphSeparatorCommand.h:

(WebCore::InsertParagraphSeparatorCommand::create):

• editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::InsertTextCommand):

• editing/InsertTextCommand.h:

(WebCore::InsertTextCommand::create):
(WebCore::InsertTextCommand::createWithMarkerSupplier):

• editing/MoveSelectionCommand.cpp:

(WebCore::MoveSelectionCommand::doApply):

• editing/RemoveNodePreservingChildrenCommand.cpp:

(WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand):

• editing/RemoveNodePreservingChildrenCommand.h:

(WebCore::RemoveNodePreservingChildrenCommand::create):

• editing/ReplaceDeleteFromTextNodeCommand.cpp: Copied from Source/WebCore/editing/AppendNodeCommand.h.

(WebCore::ReplaceDeleteFromTextNodeCommand::ReplaceDeleteFromTextNodeCommand):
(WebCore::ReplaceDeleteFromTextNodeCommand::notifyAccessibilityForTextChange):

• editing/ReplaceDeleteFromTextNodeCommand.h: Copied from Source/WebCore/editing/AppendNodeCommand.h.
• editing/ReplaceInsertIntoTextNodeCommand.cpp: Added.

(WebCore::ReplaceInsertIntoTextNodeCommand::ReplaceInsertIntoTextNodeCommand):
(WebCore::ReplaceInsertIntoTextNodeCommand::notifyAccessibilityForTextChange):

• editing/ReplaceInsertIntoTextNodeCommand.h: Copied from Source/WebCore/editing/RemoveNodePreservingChildrenCommand.h.
• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
(WebCore::ReplaceSelectionCommand::InsertedNodes::didReplaceNode): Deleted.
(WebCore::ReplaceSelectionCommand::insertAsListItems): Deleted.

• editing/ReplaceSelectionCommand.h:

(WebCore::ReplaceSelectionCommand::create):

• editing/TypingCommand.cpp:

(WebCore::TypingCommand::insertTextRunWithoutNewlines):
(WebCore::TypingCommand::insertParagraphSeparator):

• editing/atk/FrameSelectionAtk.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

• editing/ios/DictationCommandIOS.cpp:

(WebCore::DictationCommandIOS::DictationCommandIOS):

• editing/ios/DictationCommandIOS.h:
• editing/mac/FrameSelectionMac.mm:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setInnerTextValue):

• page/DragController.cpp:

(WebCore::DragController::concludeEditDrag):

• page/EventHandler.cpp:

(WebCore::setInitialKeyboardSelection):

• page/FocusController.cpp:

(WebCore::FocusController::advanceFocusInDocumentOrder):

Source/WebKit/mac:

• WebCoreSupport/WebEditorClient.mm:

(undoNameForEditAction):

Source/WebKit2:

• UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::nameForEditAction):

Tools:

• DumpRenderTree/mac/AccessibilityNotificationHandler.h:
• DumpRenderTree/mac/AccessibilityNotificationHandler.mm:

(-[AccessibilityNotificationHandler stopObserving]):
(-[AccessibilityNotificationHandler _notificationReceived:]):

• DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::removeNotificationListener):

• WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:

(-[AccessibilityNotificationHandler _notificationReceived:]):

• WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::removeNotificationListener):

LayoutTests:

• platform/mac/accessibility/input-replacevalue-userinfo-expected.txt: Added.
• platform/mac/accessibility/input-replacevalue-userinfo.html: Added.
• platform/mac/accessibility/selection-change-userinfo-expected.txt: Added.
• platform/mac/accessibility/selection-change-userinfo.html: Added.
• platform/mac/accessibility/value-change-userinfo-expected.txt: Added.
• platform/mac/accessibility/value-change-userinfo.html: Added.

2:26 PM Changeset in webkit [183367] by Darin Adler

• 1 edit in trunk/Source/WebCore/ChangeLog

refine

2:25 PM Changeset in webkit [183366] by Darin Adler

• 6 edits
  2 adds in trunk

REGRESSION (r176751): line-height ignored in <button> elements
​https://bugs.webkit.org/show_bug.cgi?id=144234

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/forms/button-line-height.html

• platform/Theme.h: Changed controlFont to return an Optional so we can tell

when the theme is overriding the font. Otherwise if the font from the user-agent
style sheet and the font from the theme are the same, we will think we are not
overriding the font when we actually are.

• platform/mac/ThemeMac.h: Updated controlFont to return Optional.
• platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::controlFont): Ditto.

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle): Set line height only if the font is
overriden by the theme, all the time for PushButtonPart on Mac, and not at all
for other parts. Also tightened up the logic a little since RenderStyle's
setFontDescription already does an "==" comparison; we don't have to do
that twice.

LayoutTests:

• fast/forms/button-line-height-expected.html: Added.
• fast/forms/button-line-height.html: Added.

2:18 PM Changeset in webkit [183365] by Darin Adler

• 4 edits
  2 adds in trunk

REGRESSION (r173801): Use after free in WebCore::NotificationCenter::~NotificationCenter
​https://bugs.webkit.org/show_bug.cgi?id=137163

Reviewed by Andy Estes.

Source/WebCore:

Test: fast/notifications/request-notification-permission-while-reloading.html

The test doesn't crash under WebKit2, but that's still OK for our purposes.

• Modules/notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::NotificationCenter): Initialize m_timer.
(WebCore::NotificationCenter::createNotification): Moved here from the header.
(WebCore::NotificationCenter::requestPermission): Start the timer and ref the notification
center when we need to defer a callback. Also use a lambda for the callback and changed
the argument to match what the bindings actually pass. Before we said PassRefPtr, but the
bindings were not transferring ownership of the VoidCallback. The new type is a little
strange but it's consistent with how the bindings work right now.
(WebCore::NotificationCenter::timerFired): Added. Calls all the callbacks, then does a deref
to match the ref we did above.
(WebCore::NotificationCenter::requestTimedOut): Deleted.
(WebCore::NotificationCenter::NotificationRequestCallback::createAndStartTimer): Deleted.
(WebCore::NotificationCenter::NotificationRequestCallback::NotificationRequestCallback): Deleted.
(WebCore::NotificationCenter::NotificationRequestCallback::startTimer): Deleted.
(WebCore::NotificationCenter::NotificationRequestCallback::timerFired): Deleted.

• Modules/notifications/NotificationCenter.h: Reorganized the header to be a bit more tidy.

Changed the argument type for requestPermission to match the reality of what's passed by the
bindings. Removed NotificationRequestCallback and replaced the m_callbacks HashSet with a
vector of std::function.

LayoutTests:

• fast/notifications/request-notification-permission-while-reloading-expected.txt: Added.
• fast/notifications/request-notification-permission-while-reloading.html: Added.

1:38 PM Changeset in webkit [183364] by Simon Fraser

• 15 edits in trunk/Source/WebCore

Modernize animations code
​https://bugs.webkit.org/show_bug.cgi?id=144196

Reviewed by Darin Adler.

General cleanup in animation-related code.

Use C++ references where possible. Use modern loops. Make classes fast-allocated.
Use C++11 member initialization. Order member variables to optimize packing.

This removes some null checks in CompositeAnimation, but the values in m_transitions
and m_keyframeAnimations can never be null.

No behavior change.

• page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::AnimationBase):
(WebCore::AnimationBase::animationsMatch):
(WebCore::AnimationBase::updateStateMachine):
(WebCore::AnimationBase::fireAnimationEventsIfNeeded):
(WebCore::AnimationBase::beginAnimationUpdateTime):
(WebCore::AnimationBase::getElapsedTime):

• page/animation/AnimationBase.h:

(WebCore::AnimationBase::animation):
(WebCore::AnimationBase::setAnimation):

• page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::ensureCompositeAnimation):
(WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStartTimeResponse):

• page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::CompositeAnimation):
(WebCore::CompositeAnimation::clearRenderer):
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
(WebCore::CompositeAnimation::animate):
(WebCore::CompositeAnimation::getAnimatedStyle):
(WebCore::CompositeAnimation::timeToNextService):
(WebCore::CompositeAnimation::getAnimationForProperty):
(WebCore::CompositeAnimation::computeExtentOfTransformAnimation):
(WebCore::CompositeAnimation::suspendAnimations):
(WebCore::CompositeAnimation::resumeAnimations):
(WebCore::CompositeAnimation::overrideImplicitAnimations):
(WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
(WebCore::CompositeAnimation::isAnimatingProperty):
(WebCore::CompositeAnimation::pauseTransitionAtTime):
(WebCore::CompositeAnimation::numberOfActiveAnimations):

• page/animation/CompositeAnimation.h:

(WebCore::CompositeAnimation::create):
(WebCore::CompositeAnimation::animationController):

• page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::ImplicitAnimation):
(WebCore::ImplicitAnimation::sendTransitionEvent):

• page/animation/ImplicitAnimation.h:

(WebCore::ImplicitAnimation::create):

• page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::getAnimatedStyle):
(WebCore::KeyframeAnimation::computeExtentOfTransformAnimation):
(WebCore::KeyframeAnimation::startAnimation):
(WebCore::KeyframeAnimation::sendAnimationEvent):
(WebCore::KeyframeAnimation::overrideAnimations):
(WebCore::KeyframeAnimation::resumeOverriddenAnimations):
(WebCore::KeyframeAnimation::timeToNextService):

• page/animation/KeyframeAnimation.h:
• platform/animation/Animation.cpp:

(WebCore::Animation::animationsMatch):

• platform/animation/Animation.h:
• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::performOverlapTests):

• rendering/style/KeyframeList.h:

(WebCore::KeyframeList::properties):
(WebCore::KeyframeList::keyframes):
(WebCore::KeyframeList::beginProperties): Deleted.
(WebCore::KeyframeList::endProperties): Deleted.
(WebCore::KeyframeList::operator[]): Deleted.

• rendering/style/RenderStyle.h:

1:36 PM Changeset in webkit [183363] by bshafiei@apple.com

• 4 edits in tags/Safari-601.1.30/Source/WebKit2

Merged r183360. rdar://problem/20702337

1:22 PM Changeset in webkit [183362] by bshafiei@apple.com

• 5 edits in trunk/Source

Versioning.

1:20 PM Changeset in webkit [183361] by bshafiei@apple.com

• 1 copy in tags/Safari-601.1.30

New tag.

1:20 PM Changeset in webkit [183360] by mitz@apple.com

• 4 edits in trunk/Source/WebKit2

<rdar://problem/20702337> REGRESSION (r182952): Plug-in service fails to load because it links against WebKit2.framework
​https://bugs.webkit.org/show_bug.cgi?id=144233

Reviewed by Simon Fraser.

Have the plug-in service link against WebKit.framework rather than WebKit2.framework.

• Configurations/PluginService.32.xcconfig: Removed linker flags for linking against WebKit2

and Foundation from the definition of OTHER_LDFLAGS. Since linking is no longer conditional,
we can just do it in the target’s Link Binary With Libraries build phase.

• Configurations/PluginService.64.xcconfig: Ditto.

• WebKit2.xcodeproj/project.pbxproj: Have Foundation and WebKit listed in the services’ Link

Binariy With Libraries build phases (one service already had WebKit).

12:57 PM Changeset in webkit [183359] by benjamin@webkit.org

• 1 edit
  1 add in trunk/Websites/webkit.org

Start a basic status page on webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=143940

Patch by Benjamin Poulain <​benjamin@webkit.org>, Chris Bateman <​chrisb808@gmail.com> on 2015-04-26
Reviewed by Darin Adler.

• status.html: Added.

Nothing fancy, for now just show the "features" list of the two features.json

12:55 PM Changeset in webkit [183358] by benjamin@webkit.org

• 30 edits
  4 adds
  3 deletes in trunk

[JSC] Implement Math.clz32(), remove Number.clz()
​https://bugs.webkit.org/show_bug.cgi?id=144205

Reviewed by Michael Saboff.

Source/JavaScriptCore:

This patch adds the ES6 function Math.clz32(), and remove the non-standard
Number.clz(). Number.clz() probably came from an older draft.

The new function has a corresponding instrinsic: Clz32Intrinsic,
and a corresponding DFG node: ArithClz32, optimized all the way to LLVM.

• assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::countLeadingZeros32):

• assembler/X86Assembler.h:

(JSC::X86Assembler::bsr_rr):
The x86 assembler did not have countLeadingZeros32() because there is
no native CLZ instruction on that architecture.

I have added the version with bsr + branches for the case of zero.
An other popular version uses cmov to handle the case of zero. I kept
it simple since the Assembler has no support for cmov.

It is unlikely to matter much. If the code is hot enough, LLVM picks
something good based on the surrounding code.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
Constant handling + effect propagation. The node only produces integer (between 0 and 32).

• dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):
Thanks to the definition of toUint32(), we can ignore plenty of details
from doubles.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNodeType.h:
• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithClz32):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLIntrinsicRepository.h:
• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithClz32):

• ftl/FTLOutput.h:

(JSC::FTL::Output::ctlz32):

• jit/ThunkGenerators.cpp:

(JSC::clz32ThunkGenerator):

• jit/ThunkGenerators.h:
• runtime/Intrinsic.h:
• runtime/MathCommon.h:

(JSC::clz32):
Fun fact: InstCombine does not recognize this pattern to eliminate
the branch which makes our FTL version better than the C version.

• runtime/MathObject.cpp:

(JSC::MathObject::finishCreation):
(JSC::mathProtoFuncClz32):

• runtime/NumberPrototype.cpp:

(JSC::clz): Deleted.
(JSC::numberProtoFuncClz): Deleted.

• runtime/VM.cpp:

(JSC::thunkGeneratorForIntrinsic):

• tests/stress/math-clz32-basics.js: Added.

(mathClz32OnInteger):
(testMathClz32OnIntegers):
(verifyMathClz32OnIntegerWithOtherTypes):
(mathClz32OnDouble):
(testMathClz32OnDoubles):
(verifyMathClz32OnDoublesWithOtherTypes):
(mathClz32NoArguments):
(mathClz32TooManyArguments):
(testMathClz32OnConstants):
(mathClz32StructTransition):
(Math.clz32):

LayoutTests:

Basic conformance tests.

• js/Object-getOwnPropertyNames-expected.txt:
• js/math-clz32-expected.txt: Added.
• js/math-clz32.html: Renamed from LayoutTests/js/number-clz.html.
• js/number-clz-expected.txt: Removed.
• js/script-tests/Object-getOwnPropertyNames.js:
• js/script-tests/math-clz32.js: Added.

(objectConvertToString.toString):
(objectRecordToStringCall.toString):
(objectThrowOnToString.toString):
(objectWithValueOf.valueOf):
(objectThrowOnValueOf.valueOf):
(objectThrowOnValueOf.toString):
(objectRecordValueOfCall.valueOf):
(objectRecordConversionCalls.toString):
(objectRecordConversionCalls.valueOf):

• js/script-tests/number-clz.js: Removed.

12:52 PM Changeset in webkit [183357] by Yusuke Suzuki

• 7 edits
  2 adds in trunk

[ES6] Array.from need to accept iterables
​https://bugs.webkit.org/show_bug.cgi?id=141055

Reviewed by Darin Adler.

Source/JavaScriptCore:

ES6 spec requires that Array.from accepts iterable objects.
This patch introduces this functionality, Array.from accepting iterable objects.

Currently, isConstructor is not used. Instead of it, typeof thiObj === "function" is used.
However, it doesn't conform to the spec. While isConstructor queries the given object has [[Construct]],
typeof thisObj === "function" queries the given object has [[Call]].
This will be fixed in the subsequent patch[1].

[1]: ​https://bugs.webkit.org/show_bug.cgi?id=144093

• builtins/ArrayConstructor.js:

(from):

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseInner):

• runtime/CommonIdentifiers.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• tests/stress/array-from-with-iterable.js: Added.

(shouldBe):
(.set for):
(.set var):
(.get var):
(argumentsGenerators):
(.set shouldBe):
(.set new):

• tests/stress/array-from-with-iterator.js: Added.

(shouldBe):
(shouldThrow):
(createIterator.iterator.return):
(createIterator):
(.):

LayoutTests:

Array.from now accepts iterables.

• js/array-from-expected.txt:

11:45 AM Changeset in webkit [183356] by Simon Fraser

• 17 edits in trunk/LayoutTests

New baselines for iOS.

• platform/ios-simulator-wk2/compositing/contents-scale/rounded-contents-scale-expected.txt:
• platform/ios-simulator-wk2/compositing/contents-scale/scaled-ancestor-expected.txt:
• platform/ios-simulator-wk2/compositing/contents-scale/simple-scale-expected.txt:
• platform/ios-simulator-wk2/compositing/contents-scale/z-translate-expected.txt:
• platform/ios-simulator-wk2/compositing/repaint/invalidations-on-composited-layers-expected.txt:
• platform/ios-simulator-wk2/compositing/tiling/tile-cache-zoomed-expected.txt:
• platform/ios-simulator-wk2/compositing/visible-rect/2d-transformed-expected.txt:
• platform/ios-simulator-wk2/compositing/visible-rect/3d-transformed-expected.txt:
• platform/ios-simulator-wk2/compositing/visible-rect/clipped-by-viewport-expected.txt:
• platform/ios-simulator-wk2/compositing/visible-rect/clipped-visible-rect-expected.txt:
• platform/ios-simulator-wk2/compositing/visible-rect/coverage-clipped-expected.txt:
• platform/ios-simulator-wk2/compositing/visible-rect/coverage-scrolling-expected.txt:
• platform/ios-simulator-wk2/compositing/visible-rect/flipped-preserve-3d-expected.txt:
• platform/ios-simulator-wk2/compositing/visible-rect/iframe-and-layers-expected.txt:
• platform/ios-simulator-wk2/compositing/visible-rect/nested-transform-expected.txt:
• platform/ios-simulator-wk2/compositing/visible-rect/scrolled-expected.txt:

11:25 AM Changeset in webkit [183355] by Simon Fraser

• 1 edit
  2 adds in trunk/LayoutTests

New WK1 results for this test.

• platform/mac-wk1/compositing/tiling/transform-origin-tiled-expected.txt: Added.

10:24 AM Changeset in webkit [183354] by Simon Fraser

• 49 edits
  1 copy
  1 add in trunk

Expand compositing coverage rect when scrolling and animating
​https://bugs.webkit.org/show_bug.cgi?id=144214
rdar://problem/20695926

Reviewed by Darin Adler.

Source/WebCore:

r183300 added a secondary rect that gets mapped through graphics layers during
layer flushing, which represents a rect, in layer coordinates, that represents
the portion of this layer that's visible in the viewport.

This patch extends that rect based on scrolling and animating, with the extended
coverage rect being mapped into descendants (where it's used to determine whether
they should detach their backing store). This required moving the responsibility for
extending the coverage rect from TileController (where it was used to compute
tiled extent), to GraphicsLayerCA. Thus, GraphicsLayerCA now owns the concept
of coverage rect, and pushes it onto TileControllers.

Test: compositing/tiling/transform-origin-tiled.html

• platform/graphics/TiledBacking.h: Coverage rect is now pushed onto

TiledBacking from outside; new functions reflect that.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly): No need to pass
old visible rect to commitLayerChangesBeforeSublayers.
(WebCore::accumulatesTransform):
(WebCore::GraphicsLayerCA::recursiveVisibleRectChangeRequiresFlush): Now calls computeVisibleAndCoverageRect(),
then adjustCoverageRect() which adjusts for scrolling and animations.
(WebCore::GraphicsLayerCA::computeVisibleAndCoverageRect): Fetch the coverage rect from the
TransformState, but we can only use this if mapping it through various transforms didn't clamp
it (which can happen with severe rotations in perspective).
(WebCore::GraphicsLayerCA::adjustCoverageRect): If this layer represents the page tiled backing,
ask the TileController to do coverage adjustment (code which should move into here eventually).
For other tiled layers, do motion-based adjustment. This should really be done for all layers
(an animating non-tiled layer may contain a tiled layer).
(WebCore::GraphicsLayerCA::setVisibleAndCoverageRects): The VisibleRectChanged wasn't needed
any more; layers only react to changed in coverage rect now.
(WebCore::GraphicsLayerCA::recursiveCommitChanges): If adjustCoverageRect() changed the
coverage rect, here we push the new rect back into the TransformState so it will affect
descendants.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateCoverage): Coverage and backing store attachment go
hand-in-hand now.
(WebCore::GraphicsLayerCA::changeLayerTypeTo):
(WebCore::GraphicsLayerCA::computeVisibleRect): Deleted.
(WebCore::GraphicsLayerCA::updateBackingStoreAttachment): Deleted.
(WebCore::GraphicsLayerCA::updateVisibleRect): Deleted.

• platform/graphics/ca/GraphicsLayerCA.h:
• platform/graphics/ca/TileController.cpp:

(WebCore::TileController::setVisibleRect): Visible rect is only used for scroll performance
logging now.
(WebCore::TileController::setCoverageRect):
(WebCore::TileController::tilesWouldChangeForCoverageRect):
(WebCore::TileController::revalidateTiles):
(WebCore::TileController::boundsForSize): This is required because when computeTileCoverageRect()
is called at the top of committing the owning layer, we haven't yet pushed a new size to the
underlying platform layer (which TileController::bounds() consults).
(WebCore::TileController::bounds):
(WebCore::TileController::computeTileCoverageRect): Have to push the new size in, since the
underlying layer hasn't been updated yet.
(WebCore::TileController::didRevalidateTiles):
(WebCore::TileController::tilesWouldChangeForVisibleRect): Deleted.

• platform/graphics/ca/TileController.h:
• platform/graphics/ca/TileCoverageMap.cpp:

(WebCore::TileCoverageMap::TileCoverageMap): Add a layer to the tile map that shows
a dark blue outline for the coverage rect.
(WebCore::TileCoverageMap::update): Fix some minor issues with map position when top
content inset is non-zero.

• platform/graphics/ca/TileCoverageMap.h:
• platform/graphics/ca/TileGrid.cpp: Everything is in terms of coverage rect now.

(WebCore::TileGrid::tilesWouldChangeForCoverageRect):
(WebCore::TileGrid::revalidateTiles):
(WebCore::TileGrid::tilesWouldChangeForVisibleRect): Deleted.

• platform/graphics/ca/TileGrid.h:
• platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::operator=):
(WebCore::TransformState::mappedQuad): Pass direction into mapQuad().
(WebCore::TransformState::mappedSecondaryQuad): Ditto.
(WebCore::TransformState::setLastPlanarSecondaryQuad): This function allows a caller
to pass in a secondary quad, and get it mapped into the coordinate space of the last
"flattening" state (since the TransformState may have in-flight XY offset, or transform).
This mapping is achieved by re-using mapQuad(), but in the inverse direction.
(WebCore::TransformState::mapQuad): Make direction a parameter.
(WebCore::TransformState::flattenWithTransform): This code omitted to map the secondary
quad. Failure was detected by tests.

• platform/graphics/transforms/TransformState.h:

(WebCore::TransformState::isMappingSecondaryQuad):
(WebCore::TransformState::direction):
(WebCore::TransformState::inverseDirection):
(WebCore::TransformState::lastPlanarSecondaryQuad): Deleted.

LayoutTests:

New baselines for tests dumping layer output, with coverage rect being affected
by this changeset. One new test for tiling a layer inside overflow:hidden with transform-origin.

• compositing/contents-scale/animating-expected.txt:
• compositing/contents-scale/rounded-contents-scale-expected.txt:
• compositing/contents-scale/scaled-ancestor-expected.txt:
• compositing/contents-scale/simple-scale-expected.txt:
• compositing/tiling/transform-origin-tiled.html: Added.
• platform/mac-wk2/compositing/tiling/rotated-tiled-clamped-expected.txt:
• platform/mac-wk2/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
• platform/mac-wk2/compositing/tiling/tile-cache-zoomed-expected.txt:
• platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
• platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div-expected.txt:
• platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div-with-handler-expected.txt:
• platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-expected.txt:
• platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler-expected.txt:
• platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-expected.txt:
• platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-with-handler-expected.txt:
• platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-expected.txt:
• platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler-expected.txt:
• platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-expected.txt:
• platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler-expected.txt:
• platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-select-expected.txt:
• platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-select-with-handler-expected.txt:
• platform/mac-wk2/tiled-drawing/scrolling/fixed/four-bars-zoomed-expected.txt:
• platform/mac-wk2/tiled-drawing/simple-document-with-margin-tiles-expected.txt:
• platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:
• platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration-expected.txt:
• platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
• platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
• platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
• platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
• platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
• platform/mac/compositing/visible-rect/2d-transformed-expected.txt:
• platform/mac/compositing/visible-rect/3d-transformed-expected.txt:
• platform/mac/compositing/visible-rect/clipped-by-viewport-expected.txt:
• platform/mac/compositing/visible-rect/clipped-visible-rect-expected.txt:
• platform/mac/compositing/visible-rect/iframe-and-layers-expected.txt:
• platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
• platform/mac/compositing/visible-rect/scrolled-expected.txt:

8:47 AM Changeset in webkit [183353] by mitz@apple.com

• 2 edits in trunk/Source/WebKit2

Fixed the build.

• UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _showDocumentPickerMenu]): Suppressed deprecation warnings around use
of -[UIDocumentMenuViewController _setIgnoreApplicationEntitlementForImport:].

6:00 AM Changeset in webkit [183352] by jonowells@apple.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Vertically misaligned text in Object Trees
​https://bugs.webkit.org/show_bug.cgi?id=144029

Reviewed by Timothy Hatcher.

Remove top offset for object tree property titles to fix alignment issue since applying -webkit-system-font
font family to these (​http://trac.webkit.org/changeset/182982).

• UserInterface/Views/ObjectTreePropertyTreeElement.css:

(.object-tree-property > .titles):

Apr 25, 2015:

11:54 PM Changeset in webkit [183351] by ap@apple.com

• 2 edits in trunk/LayoutTests

Mark some tests that take >10 seconds on debug bots as slow.

This is too close to 30 second timeout, so it's likely that these tests would flakily
time out on other configurations, e.g. locally.

• TestExpectations:

11:06 PM Changeset in webkit [183350] by mitz@apple.com

• 19 edits in trunk/Source/WebCore

Updated expected bindings generation test results after r183343.

• bindings/scripts/test/ObjC/DOMTestActiveDOMObject.h:
• bindings/scripts/test/ObjC/DOMTestCallback.h:
• bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.h:
• bindings/scripts/test/ObjC/DOMTestEventConstructor.h:
• bindings/scripts/test/ObjC/DOMTestEventTarget.h:
• bindings/scripts/test/ObjC/DOMTestException.h:
• bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.h:
• bindings/scripts/test/ObjC/DOMTestInterface.h:
• bindings/scripts/test/ObjC/DOMTestMediaQueryListListener.h:
• bindings/scripts/test/ObjC/DOMTestNamedConstructor.h:
• bindings/scripts/test/ObjC/DOMTestNode.h:
• bindings/scripts/test/ObjC/DOMTestNondeterministic.h:
• bindings/scripts/test/ObjC/DOMTestObj.h:
• bindings/scripts/test/ObjC/DOMTestOverloadedConstructors.h:
• bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
• bindings/scripts/test/ObjC/DOMTestTypedefs.h:
• bindings/scripts/test/ObjC/DOMattribute.h:
• bindings/scripts/test/ObjC/DOMreadonly.h:

11:00 PM Changeset in webkit [183349] by timothy_horton@apple.com

• 4 edits
  1 delete in trunk/Source/WebKit2

Further update gesture swipe shadow style
​https://bugs.webkit.org/show_bug.cgi?id=144215
<rdar://problem/19295843>

Reviewed by Dan Bernstein.

• Resources/mac/SwipeShadow.png: Removed.
• Resources/mac/​SwipeShadow@2x.png: Removed.
• UIProcess/mac/ViewGestureController.h:
• UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::beginSwipeGesture):

• WebKit2.xcodeproj/project.pbxproj:

Use a CAGradientLayer instead of PNGs for the swipe shadow.

10:20 PM Changeset in webkit [183348] by mmaxfield@apple.com

• 5 edits in trunk

font-synthesis's initial value is "style weight"
​https://bugs.webkit.org/show_bug.cgi?id=144195

Reviewed by Darin Adler.

Source/WebCore:

Updated fast/css3-text/font-synthesis-parse.html.

• rendering/style/RenderStyle.h:

LayoutTests:

Updating test.

• fast/css3-text/font-synthesis-parse-expected.txt:
• fast/css3-text/font-synthesis-parse.html:

9:16 PM Changeset in webkit [183347] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r183305.
​https://bugs.webkit.org/show_bug.cgi?id=144213

Crashes on wikipedia (Requested by litherum on #webkit).

Reverted changeset:

"[Cocoa] FontPlatformData's equality check should always use
reference URLs"
​https://bugs.webkit.org/show_bug.cgi?id=144168
​http://trac.webkit.org/changeset/183305

9:12 PM Changeset in webkit [183346] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught exception ReferenceError: Can't find variable: message LogContentView.js
​https://bugs.webkit.org/show_bug.cgi?id=144210

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-04-25
Reviewed by Timothy Hatcher.

• UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype._reappendProvisionalMessages):
With recent refactorings this change was missed.

8:42 PM Changeset in webkit [183345] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught exception using WebInspector.contentBrowser
​https://bugs.webkit.org/show_bug.cgi?id=144206

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-04-25
Reviewed by Timothy Hatcher.

• UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel.showTimelineViewForTimeline.this._timelineTreeElementMap.get select):
Use the current tab's content browser since a global one no longer exists.

7:33 PM Changeset in webkit [183344] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Add myself to contributors.json
​https://bugs.webkit.org/show_bug.cgi?id=144204

Patch by Sungmann Cho <​sungmann.cho@navercorp.com> on 2015-04-25
Reviewed by Darin Adler.

• Scripts/webkitpy/common/config/contributors.json:

6:38 PM Changeset in webkit [183343] by mitz@apple.com

• 5 edits in trunk/Source

Source/WebCore:
WebCore part of <rdar://problem/20697966> Avoid using TBD as an argument to NS_AVAILABLE
​https://bugs.webkit.org/show_bug.cgi?id=144201

Reviewed by Darin Adler.

Instead of TBD, use the high version number to which it corresponds in CFAvailability.h,
9876.5.

• bindings/objc/WebKitAvailability.h: Added a definition of NSi_9876_5, so that we can

use 9876_5 in availability macros. Removed the definition of
AVAILABILITY_INTERNALMAC_TBD, which will no longer be used.

• bindings/scripts/CodeGeneratorObjC.pm:

(ReadPublicInterfaces): Use 9876_5 instead of TBD.

Source/WebKit2:
WebKit2 part of <rdar://problem/20697966> Avoid using TBD as an argument to NS_AVAILABLE
​https://bugs.webkit.org/show_bug.cgi?id=144201

Reviewed by Darin Adler.

Instead of TBD, we use the high version number to which it corresponds in CFAvailability.h,
9876.5.

• mac/MigrateHeadersFromWebKitLegacy.make: To detect not-yet-available declarations in

headers, look for "9876_5" rather than "TBA".

6:28 PM Changeset in webkit [183342] by timothy@apple.com

• 4 edits in trunk/Source

Update localized strings.

Source/WebCore:

• English.lproj/Localizable.strings: Updated.

Source/WebInspectorUI:

• Localizations/en.lproj/localizedStrings.js: Updated.

6:27 PM Changeset in webkit [183341] by timothy@apple.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Make JSContext debugging work with Tabs UI
​https://bugs.webkit.org/show_bug.cgi?id=144203

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
(WebInspector._isTabTypeAllowed):
(WebInspector.activateExtraDomains):
(WebInspector._updateReloadToolbarButton):
(WebInspector._updateDownloadToolbarButton):

6:26 PM Changeset in webkit [183340] by timothy@apple.com

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Save and restore tab state on reload and between sessions
​https://bugs.webkit.org/show_bug.cgi?id=144202

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
(WebInspector._mainResourceDidChange):
(WebInspector._provisionalLoadStarted):
(WebInspector._restoreCookieForOpenTabs):
(WebInspector._saveCookieForOpenTabs):
(WebInspector._pageHidden):

• UserInterface/Views/TabContentView.js:

(WebInspector.TabContentView):
(WebInspector.TabContentView.prototype.restoreStateFromCookie):
(WebInspector.TabContentView.prototype.saveStateToCookie):

6:26 PM Changeset in webkit [183339] by timothy@apple.com

• 7 edits
  1 move
  3 adds in trunk/Source/WebInspectorUI

Web Inspector: Split search from ResourceSidebarPanel into a Search tab and sidebar
​https://bugs.webkit.org/show_bug.cgi?id=144197

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
(WebInspector._tabContentViewForType):
(WebInspector._searchTextDidChange):
(WebInspector._focusSearchField):
(WebInspector._domNodeWasInspected):

• UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype.get knownNonResourceScripts):

• UserInterface/Images/SearchResults.svg: Added.
• UserInterface/Main.html:
• UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel):
(WebInspector.ResourceSidebarPanel.prototype.showDefaultContentView):
(WebInspector.ResourceSidebarPanel.prototype.treeElementForRepresentedObject):
(WebInspector.ResourceSidebarPanel.prototype._mainFrameDidChange):
(WebInspector.ResourceSidebarPanel.prototype._scriptWasAdded):
(WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
(WebInspector.ResourceSidebarPanel.prototype._addStorageChild):
(WebInspector.ResourceSidebarPanel.prototype._extraDomainsActivated):
(WebInspector.ResourceSidebarPanel.prototype.get contentTreeOutlineToAutoPrune): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch.updateEmptyContentPlaceholderSoon): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch.updateEmptyContentPlaceholder): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch.forEachMatch): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch.resourceCallback): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch.resourcesCallback): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts.scriptCallback): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch.domSearchResults): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch.domCallback): Deleted.
(WebInspector.ResourceSidebarPanel.prototype.performSearch): Deleted.
(WebInspector.ResourceSidebarPanel.prototype._showResourcesContentTreeOutline): Deleted.
(WebInspector.ResourceSidebarPanel.prototype._showSearchContentTreeOutline): Deleted.
(WebInspector.ResourceSidebarPanel.prototype._searchFieldChanged): Deleted.
(WebInspector.ResourceSidebarPanel.prototype._searchFieldInput): Deleted.
(WebInspector.ResourceSidebarPanel.prototype._searchTreeElementForResource): Deleted.
(WebInspector.ResourceSidebarPanel.prototype._searchTreeElementForScript): Deleted.
(WebInspector.ResourceSidebarPanel.prototype._focusSearchField): Deleted.
(WebInspector.ResourceSidebarPanel.prototype._scriptsToSearch): Deleted.

• UserInterface/Views/SearchBar.js:

(WebInspector.SearchBar):

• UserInterface/Views/SearchSidebarPanel.css: Renamed from Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.css.

(.sidebar > .panel.navigation.search > :matches(.content, .empty-content-placeholder)):
(body.mac-platform.legacy .sidebar > .panel.navigation.search > :matches(.content, .empty-content-placeholder)):
(.sidebar > .panel.navigation.search > .search-bar):
(body.mac-platform.legacy .sidebar > .panel.navigation.search > .search-bar):
(.sidebar > .panel.navigation.search > .search-bar > input[type="search"]):
(body.mac-platform.legacy .sidebar > .panel.navigation.search > .search-bar > input[type="search"]):

• UserInterface/Views/SearchSidebarPanel.js: Added.

(WebInspector.SearchSidebarPanel):
(WebInspector.SearchSidebarPanel.prototype.closed):
(WebInspector.SearchSidebarPanel.prototype.focusSearchField):
(WebInspector.SearchSidebarPanel.prototype.performSearch.updateEmptyContentPlaceholderSoon):
(WebInspector.SearchSidebarPanel.prototype.performSearch.updateEmptyContentPlaceholder):
(WebInspector.SearchSidebarPanel.prototype.performSearch.forEachMatch):
(WebInspector.SearchSidebarPanel.prototype.performSearch.resourceCallback):
(WebInspector.SearchSidebarPanel.prototype.performSearch.resourcesCallback):
(WebInspector.SearchSidebarPanel.prototype.performSearch.searchScripts.scriptCallback):
(WebInspector.SearchSidebarPanel.prototype.performSearch.searchScripts):
(WebInspector.SearchSidebarPanel.prototype.performSearch.domSearchResults):
(WebInspector.SearchSidebarPanel.prototype.performSearch.domCallback):
(WebInspector.SearchSidebarPanel.prototype.performSearch):
(WebInspector.SearchSidebarPanel.prototype._searchFieldChanged):
(WebInspector.SearchSidebarPanel.prototype._searchFieldInput):
(WebInspector.SearchSidebarPanel.prototype._searchTreeElementForResource):
(WebInspector.SearchSidebarPanel.prototype._searchTreeElementForScript):
(WebInspector.SearchSidebarPanel.prototype._mainResourceDidChange.delayedWork):
(WebInspector.SearchSidebarPanel.prototype._mainResourceDidChange):
(WebInspector.SearchSidebarPanel.prototype._treeElementSelected):

• UserInterface/Views/SearchTabContentView.js: Added.

(WebInspector.SearchTabContentView):
(WebInspector.SearchTabContentView.prototype.get type):
(WebInspector.SearchTabContentView.prototype.shown):
(WebInspector.SearchTabContentView.prototype.closed):
(WebInspector.SearchTabContentView.prototype.canShowRepresentedObject):
(WebInspector.SearchTabContentView.prototype.focusSearchField):
(WebInspector.SearchTabContentView.prototype.performSearch):

• UserInterface/Views/Toolbar.css:

(.toolbar .item-section.center-right):
(.toolbar .item-section.right):
(.toolbar .search-bar):
(.toolbar .search-bar > input[type="search"]):
(.toolbar .search-bar > input[type="search"]::-webkit-textfield-decoration-container):
(body.window-inactive .toolbar .search-bar > input[type="search"]):
(.toolbar .item): Deleted.

6:25 PM Changeset in webkit [183338] by timothy@apple.com

• 15 edits
  1 add in trunk/Source/WebInspectorUI

Web Inspector: New Toolbar UI for tabs
​https://bugs.webkit.org/show_bug.cgi?id=144185

Reviewed by Joseph Pecoraro.

• UserInterface/Base/ImageUtilities.js:
• UserInterface/Base/Main.js:

(WebInspector.loaded):
(WebInspector.contentLoaded):
(WebInspector.updateDockedState):
(WebInspector._captureDidStart):
(WebInspector._debuggerDidPause):
(WebInspector._debuggerDidResume):
(WebInspector._mainFrameDidChange):
(WebInspector._mainResourceDidChange):
(WebInspector._windowKeyDown):
(WebInspector._windowKeyUp):
(WebInspector._pageHidden):
(WebInspector._undock):
(WebInspector._dockBottom):
(WebInspector._dockRight):
(WebInspector._updateDockNavigationItems):
(WebInspector._domNodeWasInspected):
(WebInspector._inspectModeStateChanged):
(WebInspector._toggleInspectMode):
(WebInspector._downloadWebArchive):
(WebInspector._reloadPageClicked):
(WebInspector._updateDownloadToolbarButton):
(WebInspector.archiveMainFrame):
(WebInspector.canArchiveMainFrame):

• UserInterface/Images/Crosshair.svg:
• UserInterface/Images/DockBottom.svg:
• UserInterface/Images/DockRight.svg:
• UserInterface/Images/DownloadArrow.svg:
• UserInterface/Images/ReloadToolbar.svg: Added.
• UserInterface/Images/Undock.svg:
• UserInterface/Views/ActivateButtonToolbarItem.js:

(WebInspector.ActivateButtonToolbarItem):
(WebInspector.ActivateButtonToolbarItem.prototype.set label):

• UserInterface/Views/ButtonToolbarItem.css:

(.toolbar .item.button):
(body.window-inactive .toolbar .item.button):
(.toolbar.small-size .item.button > .glyph):

• UserInterface/Views/ButtonToolbarItem.js:

(WebInspector.ButtonToolbarItem):
(WebInspector.ButtonToolbarItem.prototype.set label):

• UserInterface/Views/DashboardContainerView.css:

(.toolbar .dashboard-container):

• UserInterface/Views/Main.css:

(body.docked.bottom):

• UserInterface/Views/Toolbar.css:

(.toolbar):
(body.mac-platform:not(.legacy, .docked) .toolbar):
(.toolbar .control-section):
(.toolbar .item-section):
(.toolbar .item-section.left):
(.toolbar .item-section.center-left):
(.toolbar .item-section.center-right):
(.toolbar .item-section.right):

• UserInterface/Views/Toolbar.js:

(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype.customUpdateLayout.isOverflowingToolbar):
(WebInspector.Toolbar.prototype.customUpdateLayout):
(WebInspector.Toolbar.prototype.addToolbarItem):

6:24 PM Changeset in webkit [183337] by timothy@apple.com

• 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Add NavigationBar to the details sidebar
​https://bugs.webkit.org/show_bug.cgi?id=144191

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Main.js:

(WebInspector.contentLoaded):

• UserInterface/Views/DetailsSidebarPanel.js:

(WebInspector.DetailsSidebarPanel):
(WebInspector.DetailsSidebarPanel.prototype.get navigationItem):

• UserInterface/Views/NavigationBar.js:

(WebInspector.NavigationBar.prototype.removeNavigationItem):
Remove unused index argument.

• UserInterface/Views/Sidebar.css:

(.sidebar > .navigation-bar):
(.sidebar.has-navigation-bar > .panel):

• UserInterface/Views/Sidebar.js:

(WebInspector.Sidebar):
(WebInspector.Sidebar.prototype.addSidebarPanel):
(WebInspector.Sidebar.prototype.removeSidebarPanel):
(WebInspector.Sidebar.prototype.set selectedSidebarPanel):
(WebInspector.Sidebar.prototype.get minimumWidth):
(WebInspector.Sidebar.prototype.set width):
(WebInspector.Sidebar.prototype.set collapsed):

6:23 PM Changeset in webkit [183336] by timothy@apple.com

• 8 edits
  6 deletes in trunk/Source

Web Inspector: Remove native window dock controls
​https://bugs.webkit.org/show_bug.cgi?id=144184

Reviewed by Joseph Pecoraro.

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

• Resources/Dock.pdf: Removed.
• Resources/DockLegacy.pdf: Removed.
• WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController window]):
(-[WebInspectorWindowController setDockingUnavailable:]):

Source/WebKit2:

• Resources/DockBottom.pdf: Removed.
• Resources/DockBottomLegacy.pdf: Removed.
• Resources/DockRight.pdf: Removed.
• Resources/DockRightLegacy.pdf: Removed.
• UIProcess/WebInspectorProxy.h:
• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformAttachAvailabilityChanged):

• WebKit2.xcodeproj/project.pbxproj:

6:23 PM Changeset in webkit [183335] by timothy@apple.com

• 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Switch over to a tab based UI
​https://bugs.webkit.org/show_bug.cgi?id=144154

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Main.js:

(WebInspector.loaded):
(WebInspector.contentLoaded):
(WebInspector._tabContentViewForType):
(WebInspector._rememberOpenTabs):
(WebInspector._windowResized):
(WebInspector._tabBrowserSizeDidChange):
(WebInspector._quickConsoleDidResize):
(WebInspector._sidebarWidthDidChange):
(WebInspector._tabBrowserSelectedTabContentViewDidChange):
(WebInspector._inspectModeStateChanged):
(WebInspector._focusedContentView):

• UserInterface/Main.html:
• UserInterface/Views/Main.css:

(#tab-browser):

6:22 PM Changeset in webkit [183334] by timothy@apple.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove Main.js code we don't need for Tabs
​https://bugs.webkit.org/show_bug.cgi?id=144126

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Main.js:

(WebInspector.loaded):
(WebInspector.contentLoaded):

6:22 PM Changeset in webkit [183333] by timothy@apple.com

• 8 edits in trunk/Source/WebInspectorUI

Web Inspector: Change more places that changed WebInspector.navigationSidebar.selectedSidebarPanel to tabs
​https://bugs.webkit.org/show_bug.cgi?id=144125

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Main.js:

(WebInspector.loaded):
(WebInspector.toggleDetailsSidebar):
(WebInspector.tabContentViewClassForRepresentedObject):
(WebInspector._updateModifierKeys):
(WebInspector._consoleResizerMouseDown.dockedResizerDragEnd):
(WebInspector._consoleResizerMouseDown):
(WebInspector.linkifyURLAsNode):
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):

• UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.setTimelineProfilingEnabled):
(InspectorFrontendAPI.showConsole):
(InspectorFrontendAPI.showResources):

• UserInterface/Protocol/InspectorObserver.js:

(WebInspector.InspectorObserver.prototype.inspect):

• UserInterface/Views/DebuggerTabContentView.js:

(WebInspector.DebuggerTabContentView.prototype.canShowRepresentedObject):
(WebInspector.DebuggerTabContentView.prototype.revealAndSelectBreakpoint):

• UserInterface/Views/DefaultDashboardView.js:

(WebInspector.DefaultDashboardView):
(WebInspector.DefaultDashboardView.prototype._resourcesWasClicked):

• UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu.revealInSidebar):

• UserInterface/Views/TabBrowser.js:

(WebInspector.TabBrowser.bestTabContentViewForClass):

6:21 PM Changeset in webkit [183332] by timothy@apple.com

• 7 edits
  2 adds in trunk/Source/WebInspectorUI

Web Inspector: Make Console work in a tab world
​https://bugs.webkit.org/show_bug.cgi?id=144112

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
(WebInspector.isShowingConsoleTab):
(WebInspector.UIString):
(WebInspector.toggleNavigationSidebar):
(WebInspector.toggleDetailsSidebar):
(WebInspector.tabContentViewClassForRepresentedObject):
(WebInspector.linkifyStringAsFragment):

• UserInterface/Images/Console.svg: Added.
• UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.showConsole):

• UserInterface/Views/ConsoleTabContentView.js: Added.

(WebInspector.ConsoleTabContentView):
(WebInspector.ConsoleTabContentView.prototype.shown):
(WebInspector.ConsoleTabContentView.prototype.showRepresentedObject):
(WebInspector.ConsoleTabContentView.prototype.canShowRepresentedObject):
(WebInspector.ConsoleTabContentView.prototype.get supportsSplitContentBrowser):

• UserInterface/Views/DefaultDashboardView.js:

(WebInspector.DefaultDashboardView.prototype._consoleItemWasClicked):

• UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype.get navigationItems):
(WebInspector.LogContentView.prototype.shown):
(WebInspector.LogContentView.prototype.didAppendConsoleMessageView):
(WebInspector.LogContentView.prototype._showConsoleTab):

• UserInterface/Views/LogIcon.css:

(.log-icon .icon):

• UserInterface/Views/Main.css:

(#split-content-browser .hierarchical-path-component.log-icon .icon):
(#split-content-browser .hierarchical-path-component.log-icon .title):
(#split-content-browser .hierarchical-path-component.log-icon select):

6:20 PM Changeset in webkit [183331] by timothy@apple.com

• 25 edits in trunk/Source/WebInspectorUI

Web Inspector: Make showing a content view work in the tab world
​https://bugs.webkit.org/show_bug.cgi?id=144110

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Main.js:

(WebInspector.loaded):
(WebInspector.hideSplitConsole):
(WebInspector.showSourceCodeLocation):
(WebInspector.showOriginalUnformattedSourceCodeLocation):
(WebInspector.showOriginalOrFormattedSourceCodeLocation):
(WebInspector.showOriginalOrFormattedSourceCodeTextRange):
(WebInspector.showResourceRequest):
(WebInspector.debuggerToggleBreakpoints):
(WebInspector.debuggerPauseResumeToggle):
(WebInspector.debuggerStepOver):
(WebInspector.debuggerStepInto):
(WebInspector.debuggerStepOut):
(WebInspector._focusChanged):
(WebInspector._mouseWasClicked):
(WebInspector._dragOver):
(WebInspector._captureDidStart):
(WebInspector._debuggerDidPause):
(WebInspector._debuggerDidResume):
(WebInspector._frameWasAdded):
(WebInspector._undock):
(WebInspector._updateDockNavigationItems):

• UserInterface/Models/Breakpoint.js:

(WebInspector.Breakpoint.prototype.appendContextMenuItems.revealOriginalSourceCodeLocation):
(WebInspector.Breakpoint.prototype.appendContextMenuItems):

• UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.showMainResourceForFrame):

• UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype.tokenTrackingControllerHighlightedRangeWasClicked):

• UserInterface/Views/ComputedStyleDetailsPanel.js:

(WebInspector.ComputedStyleDetailsPanel.prototype._goToRegionFlowArrowWasClicked):
(WebInspector.ComputedStyleDetailsPanel.prototype._goToContentFlowArrowWasClicked):
(WebInspector.ComputedStyleDetailsPanel):

• UserInterface/Views/ContentBrowser.js:

(WebInspector.ContentBrowser.prototype.updateHierarchicalPathForCurrentContentView):

• UserInterface/Views/ContentView.js:

(WebInspector.ContentView):

• UserInterface/Views/DOMTreeContentView.js:

(WebInspector.DOMTreeContentView.prototype.restoreFromCookie):

• UserInterface/Views/DOMTreeDataGridNode.js:

(WebInspector.DOMTreeDataGridNode.prototype._goToArrowWasClicked):

• UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype.showDefaultContentView):
(WebInspector.DebuggerSidebarPanel.prototype._addTreeElementForSourceCodeToContentTreeOutline):
(WebInspector.DebuggerSidebarPanel.prototype._treeElementSelected):
(WebInspector.DebuggerSidebarPanel.prototype._addIssue):
(WebInspector.DebuggerSidebarPanel.prototype._handleIssueAdded):

• UserInterface/Views/LayerTreeDataGridNode.js:

(WebInspector.LayerTreeDataGridNode.prototype._goToArrowWasClicked):

• UserInterface/Views/LayoutTimelineView.js:

(WebInspector.LayoutTimelineView.prototype._treeElementSelected):

• UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype.get contentBrowser):
(WebInspector.NavigationSidebarPanel.prototype.set contentBrowser):
(WebInspector.NavigationSidebarPanel.prototype._updateFilter):

• UserInterface/Views/NetworkTimelineView.js:

(WebInspector.NetworkTimelineView.prototype._treeElementSelected):

• UserInterface/Views/ObjectTreeBaseTreeElement.js:

(WebInspector.ObjectTreeBaseTreeElement.prototype._appendMenusItemsForObject):
(WebInspector.ObjectTreeBaseTreeElement):

• UserInterface/Views/OverviewTimelineView.js:

(WebInspector.OverviewTimelineView.prototype._treeElementSelected):

• UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel.prototype._goToRequestDataClicked):

• UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel):
(WebInspector.ResourceSidebarPanel.prototype.showDefaultContentView):
(WebInspector.ResourceSidebarPanel.prototype._mainFrameDidChange):
(WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
(WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
(WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
(WebInspector.ResourceSidebarPanel.prototype._storageCleared):

• UserInterface/Views/ResourceTimelineDataGridNode.js:

(WebInspector.ResourceTimelineDataGridNode.prototype._goToResource):

• UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView.prototype._treeElementSelected):

• UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerHighlightedRangeWasClicked):

• UserInterface/Views/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.prototype._popoverCallStackTreeElementSelected):

• UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel):
(WebInspector.TimelineSidebarPanel.prototype.shown):
(WebInspector.TimelineSidebarPanel.showTimelineViewForTimeline):

6:20 PM Changeset in webkit [183330] by timothy@apple.com

• 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Make debugger keyboard shortcuts global
​https://bugs.webkit.org/show_bug.cgi?id=144068

We wont always have a DebuggerSidebarPanel to listen for the shortcuts.

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
(WebInspector.showSourceCodeForFrame):
(WebInspector.showSourceCode):

• UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype.pause):

• UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype.restoreStateFromCookie):
(WebInspector.DebuggerSidebarPanel.prototype._debuggerDidResume):
(WebInspector.DebuggerSidebarPanel.prototype._handleIssueAdded):
(WebInspector.DebuggerSidebarPanel.prototype._handleIssuesCleared):
(WebInspector.DebuggerSidebarPanel):

6:19 PM Changeset in webkit [183329] by timothy@apple.com

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove Reload and Download Web Archive buttons from FrameTreeElement
​https://bugs.webkit.org/show_bug.cgi?id=144064

The will be global toolbar items soon.

Reviewed by Joseph Pecoraro.

• UserInterface/Views/FrameTreeElement.js:
• UserInterface/Views/ResourceTreeElement.js:

(WebInspector.ResourceTreeElement.prototype._updateStatus):

6:19 PM Changeset in webkit [183328] by timothy@apple.com

• 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove time and weight from the dashboard
​https://bugs.webkit.org/show_bug.cgi?id=144063

These two items were the odd ones out since they are only available
when recording a timeline. We will need the toolbar space soon, so make
this lets us make the dashboard skinnier.

This also removes the exception catching in DashboardContainerView. It doesn't really
help us and it makes debugging an exception harder.

Reviewed by Joseph Pecoraro.

• UserInterface/Views/DashboardContainerView.css:

(.toolbar .dashboard-container):

• UserInterface/Views/DashboardContainerView.js:

(WebInspector.DashboardContainerView.prototype._dashboardViewForRepresentedObject):

• UserInterface/Views/DefaultDashboardView.css:

(body.web .toolbar.collapsed .dashboard.default > .item.resourcesCount):
(body.javascript .toolbar .dashboard.default > .item.resourcesCount):

• UserInterface/Views/DefaultDashboardView.js:

(WebInspector.DefaultDashboardView):
(WebInspector.DefaultDashboardView.prototype._updateDisplay):

6:18 PM Changeset in webkit [183327] by timothy@apple.com

• 16 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove sidebar panel shortcut and image
​https://bugs.webkit.org/show_bug.cgi?id=144061

Sidebar panels no longer need a keyboard shortcut or a toolbar image.

Reviewed by Joseph Pecoraro.

• UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:

(WebInspector.ApplicationCacheDetailsSidebarPanel):

• UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel):

• UserInterface/Views/DOMDetailsSidebarPanel.js:

(WebInspector.DOMDetailsSidebarPanel):

• UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel):

• UserInterface/Views/DebuggerSidebarPanel.js:
• UserInterface/Views/DetailsSidebarPanel.js:

(WebInspector.DetailsSidebarPanel):

• UserInterface/Views/LayerTreeDetailsSidebarPanel.js:

(WebInspector.LayerTreeDetailsSidebarPanel):

• UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel):
(WebInspector.NavigationSidebarPanel.prototype.restoreStateFromCookie):
(WebInspector.NavigationSidebarPanel.prototype.showEmptyContentPlaceholder):
(WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement):
(WebInspector.NavigationSidebarPanel.prototype.show):
(WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):

• UserInterface/Views/ProbeDetailsSidebarPanel.js:

(WebInspector.ProbeDetailsSidebarPanel):

• UserInterface/Views/RenderingFrameDetailsSidebarPanel.js:
• UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel):

• UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel):

• UserInterface/Views/ScopeChainDetailsSidebarPanel.js:

(WebInspector.ScopeChainDetailsSidebarPanel):

• UserInterface/Views/SidebarPanel.js:

(WebInspector.SidebarPanel):
(WebInspector.SidebarPanel.prototype.added):
(WebInspector.SidebarPanel.prototype.removed):
(WebInspector.SidebarPanel.prototype.visibilityDidChange):

• UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel):
(WebInspector.TimelineSidebarPanel.prototype.showTimelineViewForTimeline):

6:17 PM Changeset in webkit [183326] by timothy@apple.com

• 13 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove allowedNavigationSidebarPanels, it isn't needed
​https://bugs.webkit.org/show_bug.cgi?id=144056

Reviewed by Joseph Pecoraro.

• UserInterface/Views/ApplicationCacheFrameContentView.js:
• UserInterface/Views/ContentView.js:
• UserInterface/Views/CookieStorageContentView.js:
• UserInterface/Views/DOMStorageContentView.js:
• UserInterface/Views/DOMTreeContentView.js:
• UserInterface/Views/DatabaseContentView.js:
• UserInterface/Views/DatabaseTableContentView.js:
• UserInterface/Views/FontResourceContentView.js:
• UserInterface/Views/FrameDOMTreeContentView.js:
• UserInterface/Views/LogContentView.js:
• UserInterface/Views/ResourceClusterContentView.js:
• UserInterface/Views/TimelineRecordingContentView.js:

6:17 PM Changeset in webkit [183325] by timothy@apple.com

• 12 edits in trunk/Source/WebInspectorUI

Web Inspector: Support passing extra arguments to ContentViews during construction
​https://bugs.webkit.org/show_bug.cgi?id=144055

This allows us to pass the TimelineSidebarPanel to Timeline views since in the future
there could be multiple timeline sidebars, one per tab. So the global instance will
be going away.

This also removes the exception catching in ContentViewContainer. It doesn't really
help us and it makes debugging an exception harder.

Reviewed by Joseph Pecoraro.

• UserInterface/Views/ContentBrowser.js:

(WebInspector.ContentBrowser.prototype.showContentViewForRepresentedObject):
(WebInspector.ContentBrowser.prototype.contentViewForRepresentedObject):

• UserInterface/Views/ContentView.js:

(WebInspector.ContentView):

• UserInterface/Views/ContentViewContainer.js:

(WebInspector.ContentViewContainer.prototype.contentViewForRepresentedObject):
(WebInspector.ContentViewContainer.prototype.showContentViewForRepresentedObject):

• UserInterface/Views/LayoutTimelineView.js:

(WebInspector.LayoutTimelineView.prototype._dataGridFiltersDidChange):
(WebInspector.LayoutTimelineView.prototype._treeElementSelected):
(WebInspector.LayoutTimelineView.prototype._closeStatusButtonClicked):

• UserInterface/Views/NetworkTimelineView.js:

(WebInspector.NetworkTimelineView.prototype._dataGridFiltersDidChange):
(WebInspector.NetworkTimelineView.prototype._treeElementSelected):
(WebInspector.NetworkTimelineView.prototype._closeStatusButtonClicked):

• UserInterface/Views/OverviewTimelineView.js:

(WebInspector.OverviewTimelineView.prototype._treeElementSelected):
(WebInspector.OverviewTimelineView.prototype._closeStatusButtonClicked):

• UserInterface/Views/RenderingFrameTimelineView.js:

(WebInspector.RenderingFrameTimelineView):

• UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView):
(WebInspector.ScriptTimelineView.prototype._dataGridFiltersDidChange):
(WebInspector.ScriptTimelineView.prototype._treeElementSelected):
(WebInspector.ScriptTimelineView.prototype._closeStatusButtonClicked):

• UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView):
(WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
(WebInspector.TimelineRecordingContentView.prototype._contentViewSelectionPathComponentDidChange):
(WebInspector.TimelineRecordingContentView.prototype._updateTimes):
(WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):

• UserInterface/Views/TimelineSidebarPanel.js:
• UserInterface/Views/TimelineView.js:

(WebInspector.TimelineView):
(WebInspector.TimelineView.prototype.get timelineSidebarPanel):

6:16 PM Changeset in webkit [183324] by timothy@apple.com

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Disable global keyboard shortcuts for background tabs
​https://bugs.webkit.org/show_bug.cgi?id=143918

Reviewed by Joseph Pecoraro.

• UserInterface/Views/ContentBrowser.js:

(WebInspector.ContentBrowser):
(WebInspector.ContentBrowser.prototype.shown): Added.
(WebInspector.ContentBrowser.prototype.hidden): Added.
Disable shortcuts on the browser and find banner.

• UserInterface/Views/ContentBrowserTabContentView.js:

(WebInspector.ContentBrowserTabContentView.prototype.shown): Added.
(WebInspector.ContentBrowserTabContentView.prototype.hidden): Added.
Tell the content browser we were shown or hidden.

• UserInterface/Views/FindBanner.js:

(WebInspector.FindBanner):
(WebInspector.FindBanner.prototype.show):
(WebInspector.FindBanner.prototype.enableKeyboardShortcuts): Added.
(WebInspector.FindBanner.prototype.disableKeyboardShortcuts): Added.
Support disabling or enabling the keyboard shortcuts.

6:16 PM Changeset in webkit [183323] by timothy@apple.com

• 7 edits
  4 copies
  13 adds in trunk/Source/WebInspectorUI

Web Inspector: Add TabBrowser and TabContentView
​https://bugs.webkit.org/show_bug.cgi?id=143886

Reviewed by Joseph Pecoraro.

• UserInterface/Images/Debugger.svg: Added.
• UserInterface/Images/Elements.svg: Added.
• UserInterface/Images/Gear.svg: Added.
• UserInterface/Images/NewTabPlus.svg: Added.
• UserInterface/Images/Resources.svg:
• UserInterface/Images/Timeline.svg: Added.
• UserInterface/Images/ToggleLeftSidebar.svg: Added.
• UserInterface/Images/ToggleRightSidebar.svg: Added.

• UserInterface/Views/ContentBrowserTabContentView.css: Added.

(.content-browser.tab.content-view > .content-browser):

• UserInterface/Views/ContentBrowserTabContentView.js: Added.

(WebInspector.ContentBrowserTabContentView):
(WebInspector.ContentBrowserTabContentView.prototype.get contentBrowser):
(WebInspector.ContentBrowserTabContentView.prototype.shown):
(WebInspector.ContentBrowserTabContentView.prototype.hidden):
(WebInspector.ContentBrowserTabContentView.prototype.closed):
(WebInspector.ContentBrowserTabContentView.prototype.updateLayout):
(WebInspector.ContentBrowserTabContentView.prototype.get managesDetailsSidebarPanels):
(WebInspector.ContentBrowserTabContentView.prototype.showDetailsSidebarPanels):
(WebInspector.ContentBrowserTabContentView.prototype.contentBrowserTreeElementForRepresentedObject):
(WebInspector.ContentBrowserTabContentView.prototype._navigationSidebarCollapsedStateDidChange):
(WebInspector.ContentBrowserTabContentView.prototype._detailsSidebarCollapsedStateDidChange):
(WebInspector.ContentBrowserTabContentView.prototype._detailsSidebarPanelSelected):
(WebInspector.ContentBrowserTabContentView.prototype._contentBrowserRepresentedObjectsDidChange):
(WebInspector.ContentBrowserTabContentView.prototype._contentBrowserCurrentContentViewDidChange):
(WebInspector.ContentBrowserTabContentView.prototype._revealAndSelectRepresentedObjectInNavigationSidebar):

• UserInterface/Views/DebuggerTabContentView.js: Added.

(WebInspector.DebuggerTabContentView):

• UserInterface/Views/ElementsTabContentView.js: Added.

(WebInspector.ElementsTabContentView):
(WebInspector.ElementsTabContentView.prototype._mainFrameDidChange):

• UserInterface/Views/ResourcesTabContentView.js: Added.

(WebInspector.ResourcesTabContentView):

• UserInterface/Views/SettingsTabContentView.js: Added.

(WebInspector.SettingsTabContentView):

• UserInterface/Views/TabBrowser.css: Added.

(.tab-browser):
(.tab-browser > .tab-bar):
(.tab-browser > .content-view-container):
(.tab-browser > .tab-bar + .content-view-container):

• UserInterface/Views/TabBrowser.js: Added.

(WebInspector.TabBrowser):
(WebInspector.TabBrowser.prototype.get tabBar):
(WebInspector.TabBrowser.prototype.get navigationSidebar):
(WebInspector.TabBrowser.prototype.get detailsSidebar):
(WebInspector.TabBrowser.prototype.get selectedTabContentView):
(WebInspector.TabBrowser.prototype.updateLayout):
(WebInspector.TabBrowser.prototype.bestTabContentViewForRepresentedObject):
(WebInspector.TabBrowser.prototype.addTabForContentView):
(WebInspector.TabBrowser.prototype.showTabForContentView):
(WebInspector.TabBrowser.prototype.closeTabForContentView):
(WebInspector.TabBrowser.prototype._tabBarItemSelected):
(WebInspector.TabBrowser.prototype._sidebarPanelSelected):
(WebInspector.TabBrowser.prototype._sidebarCollapsedStateDidChange):
(WebInspector.TabBrowser.prototype._showNavigationSidebarPanelForTabContentView):
(WebInspector.TabBrowser.prototype._showDetailsSidebarPanelsForTabContentView):

• UserInterface/Views/TabContentView.js: Added.

(WebInspector.TabContentView):
(WebInspector.TabContentView.prototype.get parentTabBrowser):
(WebInspector.TabContentView.prototype.set parentTabBrowser):
(WebInspector.TabContentView.prototype.get tabBarItem):
(WebInspector.TabContentView.prototype.get managesDetailsSidebarPanels):
(WebInspector.TabContentView.prototype.showDetailsSidebarPanels):
(WebInspector.TabContentView.prototype.canShowRepresentedObject):
(WebInspector.TabContentView.prototype.get navigationSidebarPanel):
(WebInspector.TabContentView.prototype.get navigationSidebarCollapsedSetting):
(WebInspector.TabContentView.prototype.get detailsSidebarPanels):
(WebInspector.TabContentView.prototype.get detailsSidebarCollapsedSetting):
(WebInspector.TabContentView.prototype.get detailsSidebarSelectedPanelSetting):

• UserInterface/Views/TimelineTabContentView.js: Added.

(WebInspector.TimelineTabContentView):

6:15 PM Changeset in webkit [183322] by timothy@apple.com

• 2 edits
  3 adds in trunk/Source/WebInspectorUI

Web Inspector: Add a WebInspector.TabBar class
​https://bugs.webkit.org/show_bug.cgi?id=143442

Reviewed by Joseph Pecoraro.

• UserInterface/Main.html:

Added new files.

• UserInterface/Protocol/InspectorFrontendHostStub.js:

(window.Symbol):
(WebInspector.InspectorFrontendHostStub.prototype.showContextMenu):
Added some stubs needed to work standalone.

• UserInterface/Views/TabBar.css: Added.

(.tab-bar):
(body.window-inactive .tab-bar):
(.tab-bar > .top-border):
(body.window-inactive .tab-bar > .top-border):
(.tab-bar > .item):
(.tab-bar > :nth-child(n + 2 of .item)):
(.tab-bar > .item.pinned):
(.tab-bar > .item.selected):
(.tab-bar > .item.new-tab-button:hover):
(.tab-bar:not(.animating) > .item:not(.selected):hover + .item):
(body.window-inactive .tab-bar > .item):
(body.window-inactive .tab-bar > .item.selected):
(.tab-bar > .item > .close):
(body:not(.window-inactive) .tab-bar:not(.single-tab) > .item:hover > .close):
(.tab-bar.single-tab > .item > .close):
(.tab-bar > .item > .close:hover):
(.tab-bar > .item > .close:active):
(.tab-bar > .item > .flex-space):
(.tab-bar > .item > .flex-space:last-child):
(.tab-bar > .item > .icon):
(.tab-bar > .item.selected > .icon):
(.tab-bar > .item.new-tab-button:hover > .icon):
(.tab-bar > .item > .title):
(.tab-bar > .item > .title > .content):
(.tab-bar:not(.animating) > .item:not(.selected):hover > .title):
(.tab-bar > .item.selected > .title):
(.tab-bar.collapsed > .item):
(.tab-bar.collapsed > .item > .flex-space):
(.tab-bar.collapsed > .item > .close):
(.tab-bar.hide-titles > .item > .title):
(.tab-bar.hide-titles > .item.selected:hover > .icon):
(.tab-bar.hide-titles > .item.selected:hover > .close):
(.tab-bar.static-layout):
(.tab-bar.static-layout > .item):
(.tab-bar.animating.closing-tab > .item):
(.tab-bar.animating:matches(.expanding-tabs, .inserting-tab) > .item):
(.tab-bar.animating.inserting-tab > .item.being-inserted):
(.tab-bar.animating.closing-tab > .item.selected):
(body.window-inactive .tab-bar.animating.closing-tab > .item.selected):
(.tab-bar.dragging-tab > .item.selected):

• UserInterface/Views/TabBar.js: Added.

(WebInspector.TabBar):
(WebInspector.TabBar.prototype.get newTabItem):
(WebInspector.TabBar.prototype.set newTabItem):
(WebInspector.TabBar.prototype.addTabBarItem):
(WebInspector.TabBar.prototype.insertTabBarItem.animateTabs):
(WebInspector.TabBar.prototype.insertTabBarItem.removeStyles):
(WebInspector.TabBar.prototype.insertTabBarItem):
(WebInspector.TabBar.prototype.insertTabBarItem.set else):
(WebInspector.TabBar.prototype.insertTabBarItem.set this):
(WebInspector.TabBar.animateTabs.get if):
(WebInspector.TabBar.animateTabs):
(WebInspector.TabBar.removeStyles):
(WebInspector.TabBar.prototype.insertTabBarItem):
(WebInspector.TabBar.prototype.updateLayoutSoon.update):
(WebInspector.TabBar.prototype.updateLayoutSoon):
(WebInspector.TabBar.prototype.updateLayout):
(WebInspector.TabBar.prototype.get selectedTabBarItem):
(WebInspector.TabBar.prototype.set selectedTabBarItem):
(WebInspector.TabBar.prototype.get tabBarItems):
(WebInspector.TabBar.prototype.get element):
(WebInspector.TabBar.prototype._findTabBarItem):
(WebInspector.TabBar.prototype._hasMoreThanOneNormalTab):
(WebInspector.TabBar.prototype._recordTabBarItemSizesAndPositions):
(WebInspector.TabBar.prototype._clearTabBarItemSizesAndPositions):
(WebInspector.TabBar.prototype._finishExpandingTabsAfterClose.):
(WebInspector.TabBar.prototype._finishExpandingTabsAfterClose):
(WebInspector.TabBar.prototype._handleMouseDown):
(WebInspector.TabBar.prototype._handleMouseMoved):
(WebInspector.TabBar.prototype._handleMouseUp):
(WebInspector.TabBar.prototype._handleMouseLeave):
(WebInspector.TabBar.prototype._handleNewTabMouseEnter):

• UserInterface/Views/TabBarItem.js: Added.

(WebInspector.TabBarItem):
(WebInspector.TabBarItem.prototype.get identifier):
(WebInspector.TabBarItem.prototype.get element):
(WebInspector.TabBarItem.prototype.get parentTabBar):
(WebInspector.TabBarItem.prototype.set parentTabBar):
(WebInspector.TabBarItem.prototype.get selected):
(WebInspector.TabBarItem.prototype.set selected):
(WebInspector.TabBarItem.prototype.get pinned):
(WebInspector.TabBarItem.prototype.get image):
(WebInspector.TabBarItem.prototype.set image):
(WebInspector.TabBarItem.prototype.get title):
(WebInspector.TabBarItem.prototype.set title):
(WebInspector.TabBarItem.prototype.updateLayout):

6:14 PM Changeset in webkit [183321] by timothy@apple.com

• 1 edit in trunk/Source/WebInspectorUI/ChangeLog

Web Inspector: Make closing ContentViews more leak proof
​https://bugs.webkit.org/show_bug.cgi?id=144200

Remove all listeners on the target objects in close that match the this object.
This makes things more foolproof when something changes or a new listener is
added to the same object. TimelineRecordingContentView also had a leak where
TimelineManager and DebuggerManager listeners were not being removed.

Reviewed by Joseph Pecoraro.

• UserInterface/Views/ApplicationCacheFrameContentView.js:

(WebInspector.ApplicationCacheFrameContentView.prototype.closed):

• UserInterface/Views/ClusterContentView.js:

(WebInspector.ClusterContentView.prototype.closed):

• UserInterface/Views/ContentFlowDOMTreeContentView.js:

(WebInspector.ContentFlowDOMTreeContentView.prototype.closed):

• UserInterface/Views/FrameDOMTreeContentView.js:

(WebInspector.FrameDOMTreeContentView.prototype.closed):

• UserInterface/Views/ResourceContentView.js:

(WebInspector.ResourceContentView.prototype.closed):

• UserInterface/Views/TextResourceContentView.js:

(WebInspector.TextResourceContentView.prototype.closed):

• UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype.closed):

6:08 PM Changeset in webkit [183320] by commit-queue@webkit.org

• 3 edits
  3 adds in trunk

Set#keys !== Set#values
​https://bugs.webkit.org/show_bug.cgi?id=144190

Patch by Jordan Harband <​ljharb@gmail.com> on 2015-04-25
Reviewed by Darin Adler.

Source/JavaScriptCore:

per ​https://people.mozilla.org/~jorendorff/es6-draft.html#sec-set.prototype.keys
Set#keys should === Set#values

• runtime/SetPrototype.cpp:

(JSC::SetPrototype::finishCreation):
(JSC::setProtoFuncValues):
(JSC::setProtoFuncEntries):
(JSC::setProtoFuncKeys): Deleted.

LayoutTests:

• js/script-tests/set-keys.js: Added.
• js/set-keys-expected.txt: Added.
• js/set-keys.html: Added.

6:06 PM Changeset in webkit [183319] by Joseph Pecoraro

• 10 edits in trunk/Source/JavaScriptCore

Allow for pausing a JSContext when opening a Web Inspector
<rdar://problem/20564788>

Reviewed by Timothy Hatcher.

• inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::receivedSetupMessage):

• inspector/remote/RemoteInspectorConstants.h:
• inspector/remote/RemoteInspectorDebuggable.h:
• inspector/remote/RemoteInspectorDebuggableConnection.h:
• inspector/remote/RemoteInspectorDebuggableConnection.mm:

(Inspector::RemoteInspectorDebuggableConnection::setup):
On any incoming setup message, we may want to automatically
pause the debuggable. If requested, pause the debuggable
after we have setup the frontend connection.

• runtime/JSGlobalObjectDebuggable.h:
• runtime/JSGlobalObjectDebuggable.cpp:

(JSC::JSGlobalObjectDebuggable::pause):
Pass through to the inspector controller.

• inspector/JSGlobalObjectInspectorController.h:
• inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::pause):
Enable pause on next statement.

5:59 PM Changeset in webkit [183318] by timothy@apple.com

• 8 edits in trunk/Source/WebInspectorUI

Web Inspector: Make closing ContentViews more leak proof
​https://bugs.webkit.org/show_bug.cgi?id=144200

Remove all listeners on the target objects in close that match the this object.
This makes things more foolproof when something changes or a new listener is
added to the same object. TimelineRecordingContentView also had a leak where
TimelineManager and DebuggerManager listeners were not being removed.

Reviewed by Darin Adler.

• UserInterface/Views/ApplicationCacheFrameContentView.js:

(WebInspector.ApplicationCacheFrameContentView.prototype.closed):

• UserInterface/Views/ClusterContentView.js:

(WebInspector.ClusterContentView.prototype.closed):

• UserInterface/Views/ContentFlowDOMTreeContentView.js:

(WebInspector.ContentFlowDOMTreeContentView.prototype.closed):

• UserInterface/Views/FrameDOMTreeContentView.js:

(WebInspector.FrameDOMTreeContentView.prototype.closed):

• UserInterface/Views/ResourceContentView.js:

(WebInspector.ResourceContentView.prototype.closed):

• UserInterface/Views/TextResourceContentView.js:

(WebInspector.TextResourceContentView.prototype.closed):

• UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype.closed):

4:47 PM Changeset in webkit [183317] by Darin Adler

• 5 edits in trunk

Crash if IDBTransaction is aborted right after it's created
​https://bugs.webkit.org/show_bug.cgi?id=144199

Reviewed by Simon Fraser.

Source/WebCore:

Test: storage/indexeddb/transaction-abort.html

• Modules/indexeddb/IDBTransactionBackend.cpp:

(WebCore::IDBTransactionBackend::IDBTransactionBackend): Don't start the
transaction if it is already complete (has been aborted).

LayoutTests:

• platform/mac-wk2/TestExpectations: Unskip storage/indexeddb/transaction-abort.html.
• storage/indexeddb/transaction-abort-expected.txt: Updated since the exact text of

the execptions is different from what was marked here as expected.

4:20 PM WebKitEFLLayoutTest edited by Gyuyoung Kim

(diff)

3:03 PM Changeset in webkit [183316] by rniwa@webkit.org

• 16 edits
  3 adds in trunk

class methods should be non-enumerable
​https://bugs.webkit.org/show_bug.cgi?id=143181

Reviewed by Darin Adler.

Source/JavaScriptCore:

Fixed the bug by using Object.defineProperty to define methods.

This patch adds the concept of link time constants and uses it to resolve Object.defineProperty
inside CodeBlock's constructor since bytecode can be linked against multiple global objects.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock): Resolve link time constants that are used. Ignore ones with register
index of zero.

• bytecode/SpecialPointer.h: Added a new enum for link time constants. It currently contains

exactly one entry for Object.defineProperty.

• bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::addConstant): Added. Like addConstant that takes JSValue, allocate a new
constant register for the link time constant we're adding.
(JSC::UnlinkedCodeBlock::registerIndexForLinkTimeConstant): Added.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitMoveLinkTimeConstant): Added. Like addConstantValue, allocate a new
register for the specified link time constant and notify UnlinkedCodeBlock about it.
(JSC::BytecodeGenerator::emitCallDefineProperty): Added. Create a new property descriptor and call
Object.defineProperty with it.

• bytecompiler/BytecodeGenerator.h:
• bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode): Make static and non-static getters and setters for classes
non-enumerable by using emitCallDefineProperty to define them.
(JSC::PropertyListNode::emitPutConstantProperty): Ditto for a non-accessor properties.
(JSC::ClassExprNode::emitBytecode): Make prototype.constructor non-enumerable and make prototype
property on the class non-writable, non-configurable, and non-enumerable by using defineProperty.

• runtime/CommonIdentifiers.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init): Set m_definePropertyFunction.
(JSC::JSGlobalObject::visitChildren): Visit m_definePropertyFunction.

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::definePropertyFunction): Added.
(JSC::JSGlobalObject::actualPointerFor): Added a variant that takes LinkTimeConstant.
(JSC::JSGlobalObject::jsCellForLinkTimeConstant): Like actualPointerFor, takes LinkTimeConstant and
returns a JSCell; e.g. Object.defineProperty.

• runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::addDefineProperty): Added. Returns Object.defineProperty.

• runtime/ObjectConstructor.h:

LayoutTests:

Added a regression test.

Also fixed a test that previously relied on "prototype" property being writable
since this is no longer the case.

• js/class-syntax-extends-expected.txt:
• js/class-syntax-prototype.html: Added.
• js/script-tests/class-syntax-extends.js:
• js/script-tests/class-syntax-prototype.js: Added.

3:00 PM Changeset in webkit [183315] by Yusuke Suzuki

• 5 edits
  1 add in trunk

[ES6] Implement String.fromCodePoint
​https://bugs.webkit.org/show_bug.cgi?id=144160

Reviewed by Darin Adler.

Source/JavaScriptCore:

This patch implements String.fromCodePoint.
It accepts multiple code points and generates a string that consists of given code points.
The range [0x0000 - 0x10FFFF] is valid for code points.
If the given value is out of range, throw a range error.

When a 0xFFFF <= valid code point is given,
String.fromCodePoint generates a string that contains surrogate pairs.

• runtime/StringConstructor.cpp:

(JSC::stringFromCodePoint):
(JSC::constructWithStringConstructor):

• tests/stress/string-from-code-point.js: Added.

(shouldBe):
(shouldThrow):
(toCodePoints):
(passThrough):

LayoutTests:

Add String.fromCodePoint.

• js/Object-getOwnPropertyNames-expected.txt:
• js/script-tests/Object-getOwnPropertyNames.js:

2:43 PM Changeset in webkit [183314] by Martin Robinson

• 32 edits in trunk

Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
​https://bugs.webkit.org/show_bug.cgi?id=144182

Reviewed by Simon Fraser.

.:

• Source/cmake/OptionsEfl.cmake: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
• Source/cmake/OptionsGTK.cmake: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
• Source/cmake/OptionsMac.cmake: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
• Source/cmake/WebKitFeatures.cmake: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
• Source/cmakeconfig.h.cmake: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.

Source/WebCore:

• Configurations/FeatureDefines.xcconfig: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
• WebCore.vcxproj/WebCoreCommon.props: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
• WebCore.vcxproj/WebCoreTestSupportCommon.props: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
• css/CSSComputedStyleDeclaration.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
• css/MediaQueryEvaluator.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
• platform/graphics/GraphicsContext.h: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
• platform/graphics/cairo/GraphicsContextCairo.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
• platform/graphics/texmap/TextureMapperImageBuffer.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
• rendering/RenderLayer.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
• rendering/RenderLayerCompositor.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
• rendering/RenderObject.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.

Source/WebKit/mac:

• Configurations/FeatureDefines.xcconfig: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.

Source/WebKit2:

• Configurations/FeatureDefines.xcconfig: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.

Source/WTF:

• wtf/FeatureDefines.h: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.

Tools:

• DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.

WebKitLibraries:

• win/tools/vsprops/FeatureDefines.props: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
• win/tools/vsprops/FeatureDefinesCairo.props: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.

1:50 PM Changeset in webkit [183313] by ap@apple.com

• 2 edits in trunk/LayoutTests

Mavericks fix - no window.performance there.

• fast/frames/flattening/resources/iframe-to-resize.html:

1:20 PM Changeset in webkit [183312] by ap@apple.com

• 2 edits in trunk/LayoutTests

fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
​https://bugs.webkit.org/show_bug.cgi?id=144155

Unreviewed. Add more temporary logging to figure out what's going on with the test on bots.

• fast/frames/flattening/resources/iframe-to-resize.html:

9:29 AM Changeset in webkit [183311] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: assertion failure when editing inline styles
​https://bugs.webkit.org/show_bug.cgi?id=143939

Patch by Tobias Reiss <​tobi+webkit@basecode.de> on 2015-04-25
Reviewed by Timothy Hatcher.

Prevent "_updateResourceContent" from being called on inline style changes.
Introduce a flag that marks a CSSStyleSheet as a representation of an
"ElementCSSInlineStyle" (DOM Level 2 spec) and return early.

• UserInterface/Controllers/CSSStyleManager.js:

(WebInspector.CSSStyleManager.prototype.styleSheetChanged):

• UserInterface/Models/CSSStyleSheet.js:

(WebInspector.CSSStyleSheet):
(WebInspector.CSSStyleSheet.isInlineStyle):
(WebInspector.CSSStyleSheet.prototype.markAsInlineStyle):

• UserInterface/Models/DOMNodeStyles.js:

(WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):

8:43 AM Changeset in webkit [183310] by mark.lam@apple.com

• 2 edits
  1 add in trunk/Source/JavaScriptCore

mayExit() is wrong about Branch nodes with ObjectOrOtherUse: they can exit.
​https://bugs.webkit.org/show_bug.cgi?id=144152

Reviewed by Filip Pizlo.

Changed the EdgeMayExit functor to recognize ObjectUse, ObjectOrOtherUse,
StringObjectUse, and StringOrStringObjectUse kinds as potentially triggering
OSR exits. This was overlooked in the original code.

While only the ObjectOrOtherUse kind is relevant for manifesting this bug with
the Branch node, the other 3 may also trigger the same bug for other nodes.
To prevent this bug from manifesting with other nodes (and future ones that
are yet to be added to mayExits()'s "potential won't exit" set), we fix the
EdgeMayExit functor to handle all 4 use kinds (instead of just ObjectOrOtherUse).

Also added a test to exercise a code path that will trigger this bug with
the Branch node before the fix is applied.

• dfg/DFGMayExit.cpp:
• tests/stress/branch-may-exit-due-to-object-or-other-use-kind.js: Added.

(inlinedFunction):
(foo):

1:13 AM Changeset in webkit [183309] by commit-queue@webkit.org

• 1 edit
  31 adds in trunk/Tools

​https://bugs.webkit.org/show_bug.cgi?id=144038

Patch by Dewei Zhu <Dewei Zhu> on 2015-04-25
Reviewed by Ryosuke Niwa

Add a script to run Speedometer and JetStream on a browser.

• Scripts/run-benchmark: Wrapper script to run benchmark.

(main):

• Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
• Scripts/webkitpy/benchmark_runner/init.py: Added.
• Scripts/webkitpy/benchmark_runner/benchmark_builder/init.py: Added.
• Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.

(BenchmarkBuilderFactory):

• Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
• Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.

(GenericBenchmarkBuilder):
(GenericBenchmarkBuilder.prepare):
(GenericBenchmarkBuilder._copyBenchmarkToTempDir):
(GenericBenchmarkBuilder._applyPatch):
(GenericBenchmarkBuilder.clean):

• Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.

(JetStreamBenchmarkBuilder):
(JetStreamBenchmarkBuilder.prepare):
(JetStreamBenchmarkBuilder._runCreateScript):

• Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.

(BenchmarkRunner):
(BenchmarkRunner.init):
(BenchmarkRunner.execute):
(BenchmarkRunner.dump):
(BenchmarkRunner.wrap):
(BenchmarkRunner.merge):

• Scripts/webkitpy/benchmark_runner/browser_driver/init.py: Added.
• Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.

(BrowserDriver):
(BrowserDriver.prepareEnv):
(BrowserDriver.launchUrl):
(BrowserDriver.closeBrowser):

• Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.

(BrowserDriverFactory):

• Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
• Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.

(OSXChromeDriver):
(OSXChromeDriver.prepareEnv):
(OSXChromeDriver.launchUrl):
(OSXChromeDriver.closeBrowsers):

• Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.

(OSXSafariDriver):
(OSXSafariDriver.prepareEnv):
(OSXSafariDriver.launchUrl):
(OSXSafariDriver.closeBrowsers):

• Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
• Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
• Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
• Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
• Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.

(GenericFactory):
(GenericFactory.iterateGetItem):
(GenericFactory.create):

• Scripts/webkitpy/benchmark_runner/http_server_driver/init.py: Added.
• Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.

(ServerControl):
(ServerControl.render_GET):
(ServerControl.render_POST):

• Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.

(HTTPServerDriver):
(HTTPServerDriver.serve):
(HTTPServerDriver.fetchResult):

• Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.

(HTTPServerDriverFactory):

• Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
• Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.

(SimpleHTTPServerDriver):
(SimpleHTTPServerDriver.depends):
(SimpleHTTPServerDriver.init):
(SimpleHTTPServerDriver.serve):
(SimpleHTTPServerDriver.baseUrl):
(SimpleHTTPServerDriver.fetchResult):

• Scripts/webkitpy/benchmark_runner/utils.py: Utility module.

(ModuleNotFoundError):
(loadModule):
(getPathFromProjectRoot):
(loadJSONFromFile):
(TimeoutError):
(timeout):
(timeout.init):
(timeout.handle_timeout):
(timeout.enter):
(timeout.exit):