Context Navigation

← Previous Period
Next Period →

Timeline

May 9, 2015:

11:46 PM Changeset in webkit [184044] by rniwa@webkit.org

6 edits in trunk/Tools

Make arguments of run-benchmark more user friendly
https://bugs.webkit.org/show_bug.cgi?id=144835

Reviewed by Darin Adler.

Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
default values from --platform and --browser as they are required arguments.

Scripts/run-benchmark:

(main): Made --build-directory optional, and removed default values from --platform and --browser.
Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
are not dynamically obtained via BrowserDriverFactory.

Scripts/webkitpy/benchmark_runner/benchmark_runner.py:

(BenchmarkRunner.init): Raise when we can't find the plan file or the plan file is not a valid JSON
file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
run any benchmark in that case.
(BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
the specified file isn't a valid relative or an absolute path.

Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:

(BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
and browsers.
(BrowserDriverFactory.available_browsers): Ditto.

Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:

(OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
calls launchUrl with this argument so removed the default value. Also added a fallback path for when
browserBuildPath was None.

Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:

(OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
so that we can use locally built WebKit to launch Safari.

8:58 PM Changeset in webkit [184043] by mitz@apple.com

3 edits in trunk/Source/WebKit2

Deployment-target NSi_ and NSd_ definitions in WKFoundation.h are redundant
https://bugs.webkit.org/show_bug.cgi?id=144831

Reviewed by Sam Weinig.

Reverted r182846 and r182904.

Shared/API/Cocoa/WKFoundation.h:
WebKit2.xcodeproj/project.pbxproj:

8:22 PM Changeset in webkit [184042] by Chris Dumez

10 edits
2 adds in trunk

Introduce ParentNode.idl / NonDocumentTypeChildNode.idl
https://bugs.webkit.org/show_bug.cgi?id=144825

Reviewed by Sam Weinig.

Source/WebCore:

Introduce ParentNode.idl / NonDocumentTypeChildNode.idl as per DOM
specification and to avoid IDL code duplication:

No Web-Exposed behavior change.

CMakeLists.txt:
DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
dom/CharacterData.idl:
dom/Document.idl:
dom/DocumentFragment.idl:
dom/Element.idl:
dom/NonDocumentTypeChildNode.idl: Copied from Source/WebCore/dom/DocumentFragment.idl.
dom/ParentNode.idl: Copied from Source/WebCore/dom/DocumentFragment.idl.

LayoutTests:

Rebaseline test as the order of the methods changed when iterating.

js/dom/dom-static-property-for-in-iteration-expected.txt:

10:37 AM Changeset in webkit [184041] by Chris Dumez

2 edits in trunk/Source/WebCore

Invalidate the FontCache on WebProcess suspension / critical memory pressure
https://bugs.webkit.org/show_bug.cgi?id=144821

Reviewed by Antti Koivisto.

Invalidate the FontCache on WebProcess suspension / critical memory
pressure to free a bit more memory (an extra 4-16Kb per WebProcess on
the pages I tested). We already purge inactive font data on
non-critical memory warning but invalidating the whole FontCache takes
care of clearing the FontCascade cache and the fontPlatformData cache
as well.

platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::releaseCriticalMemory):

1:39 AM Changeset in webkit [184040] by yoav@yoav.ws

30 edits in trunk

Remove the PICTURE_SIZES build flag
https://bugs.webkit.org/show_bug.cgi?id=144679

Reviewed by Benjamin Poulain.

Removed the PICTURE_SIZES build time flag.

Source/cmake/OptionsEfl.cmake:
Source/cmake/OptionsGTK.cmake:
Source/cmake/OptionsMac.cmake:
Source/cmake/OptionsWindows.cmake:
Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests, since there's no functionality change.

Configurations/FeatureDefines.xcconfig:
css/CSSGrammar.y.in:
css/CSSParser.cpp:

(WebCore::CSSParser::detectAtToken):

css/CSSParser.h:
css/SourceSizeList.cpp:

(WebCore::parseSizesAttribute): Deleted.

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::setBestFitURLAndDPRFromImageCandidate):

html/HTMLImageElement.h:

(WebCore::HTMLImageElement::currentSrc):

html/HTMLImageElement.idl:
html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

html/parser/HTMLSrcsetParser.cpp:

(WebCore::parseDescriptors):
(WebCore::pickBestImageCandidate):

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/FeatureDefines.h:

Tools:

Scripts/webkitperl/FeatureList.pm:

WebKitLibraries:

win/tools/vsprops/FeatureDefines.props:
win/tools/vsprops/FeatureDefinesCairo.props:

1:20 AM Changeset in webkit [184039] by ddkilzer@apple.com

3 edits in trunk/Tools

Layout tests broke due to unexpected simctl output

Scripts/webkitpy/xcode/simulator.py:

(Simulator._parse_devices): Handle new Device Pairs header.

Scripts/webkitpy/xcode/simulator_unittest.py:

(test_device_pairs): Add unit test for Device Pairs header.

May 8, 2015:

11:40 PM Changeset in webkit [184038] by youenn.fablet@crf.canon.fr

3 edits in trunk/LayoutTests

streams/reference-implementation/readable-stream-reader.html and streams/reference-implementation/bad-underlying-sources.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=144813

Reviewed by Alexey Proskuryakov.

Removed small timeouts for tests that went from TIMEOUT to PASS thanks to other patches.

streams/reference-implementation/bad-underlying-sources.html:
streams/reference-implementation/readable-stream-reader.html:

11:33 PM Changeset in webkit [184037] by mmaxfield@apple.com

14 edits in trunk

Remove convenience constructors for TextRun
https://bugs.webkit.org/show_bug.cgi?id=144752

Source/WebCore:

These convenience constructors are unnecessary. Moving the code that makes the StringView
back to the call site will also help us make things more elegant in future refactoring.

Reviewed by Darin Adler.

No new tests because there is no behavior change.

css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText): Remove ambiguous call.

platform/graphics/StringTruncator.cpp:

(WebCore::stringWidth):

platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):

platform/mac/DragImageMac.mm:

(WebCore::widthWithFont):
(WebCore::drawAtPoint):

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::TextFragmentIterator::Style::Style):
(WebCore::SimpleLineLayout::TextFragmentIterator::runWidth):

rendering/TextPainter.cpp:

(WebCore::TextPainter::paintText):

Source/WebKit/mac:

These convenience constructors are unnecessary. Moving the code that makes the StringView
back to the call site will also help us make things more elegant in future refactoring.

Reviewed by Darin Adler.

No new tests because there is no behavior change.

Misc/WebKitNSStringExtras.mm:

(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
(-[NSString _web_widthWithFont:]):

Source/WTF:

Reviewed by Anders Carlsson.

No reason why StringView shouldn't have a StringImpl* constructor.

Test: StringView8Bit in TestWebKitAPI

wtf/text/StringView.h: Add the constructor.

Tools:

Reviewed by Anders Carlsson.

Test the StringView which takes a StringImpl*.

TestWebKitAPI/Tests/WTF/StringView.cpp:

(StringView8Bit): Testing is8Bit() on StringView

10:35 PM Changeset in webkit [184036] by ap@apple.com

2 edits in trunk/LayoutTests

Update results after Sam's patch, the order of properties changed.

js/dom/dom-static-property-for-in-iteration-expected.txt:

8:26 PM Changeset in webkit [184035] by Michael Catanzaro

2 edits in trunk

[GTK] [CMake] Check for required X libraries
https://bugs.webkit.org/show_bug.cgi?id=144823

Reviewed by Martin Robinson.

Error out if missing libXcomposite, libXdamage, libXrender, or libXt.

Source/cmake/OptionsGTK.cmake:

6:14 PM Changeset in webkit [184034] by weinig@apple.com

12 edits
6 adds in trunk

Element Traversal is not just Elements anymore
https://bugs.webkit.org/show_bug.cgi?id=144822

Reviewed by Simon Fraser.

Source/WebCore:

Match other browsers and the new DOM spec at https://dom.spec.whatwg.org by
exposing the element traversal methods on non-Elements.

Makes firstElementChild, lastElementChild and childElementCount available on Document and DocumentFragment in addition to Element.
Makes nextElementSibling and previousElementSibling available on CharacterData in addition to Element.

Tests: fast/dom/element-traversal-on-character-data.html

fast/dom/element-traversal-on-document-fragment.html
fast/dom/element-traversal-on-document.html

dom/CharacterData.idl:

Expose nextElementSibling and previousElementSibling.

dom/ContainerNode.cpp:

(WebCore::ContainerNode::firstElementChild):
(WebCore::ContainerNode::lastElementChild):
(WebCore::ContainerNode::childElementCount):

dom/ContainerNode.h:

Move implementations of firstElementChild, lastElementChild and childElementCount here
from Element to make them shareable.

dom/Document.idl:
dom/DocumentFragment.idl:

Expose firstElementChild, lastElementChild and childElementCount.

dom/Element.cpp:

(WebCore::Element::firstElementChild): Deleted.
(WebCore::Element::lastElementChild): Deleted.
(WebCore::Element::previousElementSibling): Deleted.
(WebCore::Element::nextElementSibling): Deleted.
(WebCore::Element::childElementCount): Deleted.

dom/Element.h:

Move element traversal functions down to Node and ContainerNode.

dom/Element.idl:

Update comments to indicate where these functions are defined now.

dom/Node.cpp:

(WebCore::Node::previousElementSibling):
(WebCore::Node::nextElementSibling):

dom/Node.h:

Move implementations of nextElementSibling and previousElementSibling here
from Element to make them shareable.

LayoutTests:

Add new tests for element traversal functions on Document, DocumentFragment and CharacterData.

fast/dom/element-traversal-on-character-data-expected.txt: Added.
fast/dom/element-traversal-on-character-data.html: Added.
fast/dom/element-traversal-on-document-expected.txt: Added.
fast/dom/element-traversal-on-document-fragment-expected.txt: Added.
fast/dom/element-traversal-on-document-fragment.html: Added.
fast/dom/element-traversal-on-document.html: Added.

5:33 PM Changeset in webkit [184033] by weinig@apple.com

1 edit
5 copies
5 adds in trunk/Tools

[Content Extensions] Add simple tester that takes an extension and compiles it
https://bugs.webkit.org/show_bug.cgi?id=144781

Reviewed by Dan Bates.

ContentExtensionTester: Added.
ContentExtensionTester/Configurations: Added.
ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
ContentExtensionTester/main.m: Added.
Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.

5:18 PM Changeset in webkit [184032] by fpizlo@apple.com

11 edits in trunk/Source/JavaScriptCore

Extend the SaneChain optimization to Contiguous arrays
https://bugs.webkit.org/show_bug.cgi?id=144664

Reviewed by Mark Lam.

Previously if you loaded from a hole, you'd either have to take slow path for the array
load (which means C++ calls and prototype chain walks) or you'd exit (if you hadn't
gathered the necessary profiling yet). But that's unnecessary if we know that the
prototype chain is sane - i.e. has no indexed properties. Then we can just return
Undefined for the hole.

Making this change requires setting more watchpoints on the array prototype chain. But
that hit a horrible bug: ArrayPrototype still uses the static lookup tables and builds
itself up lazily. This means that this increased the number of recompilations we'd get
due to the array prototype chain being built up.

So, this change also removes the laziness and static tables from ArrayPrototype.

But to make that change, I also had to add a helper for eagerly building up a prototype
that has builtin functions.

CMakeLists.txt:
DerivedSources.make:
dfg/DFGArrayMode.h:
dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetByVal):

runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::finishCreation):
(JSC::ArrayPrototype::getOwnPropertySlot): Deleted.

runtime/ArrayPrototype.h:
runtime/JSObject.h:

5:13 PM Changeset in webkit [184031] by Martin Robinson

2 edits
1 add in trunk/LayoutTests

Unreviewed GTK+ gardening

platform/gtk/TestExpectations: Unskip a test that was failing only because the shared

baseline had a failure in it.

platform/gtk/fast/events/event-attribute-expected.txt: Added.

5:01 PM Changeset in webkit [184030] by Martin Robinson

2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening

platform/gtk/TestExpectations: Un-expectation some tests that are now passing.

4:55 PM Changeset in webkit [184029] by Martin Robinson

2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening

Remove expectations for tests that are also skipped for all WebKit2
ports. This will more easily allow us to handle them when they are
eventually (if at all) unskipped for WebKit2.

platform/gtk/TestExpectations:

4:18 PM Changeset in webkit [184028] by Beth Dakin

6 edits in trunk/Source/WebKit2

Shuffle touch-related code to keep the internal builds working
https://bugs.webkit.org/show_bug.cgi?id=144812

Reviewed by Benjamin Poulain.

Shared/NativeWebTouchEvent.h:
Shared/WebEvent.h:
Shared/WebEventConversion.cpp:
Shared/ios/NativeWebTouchEventIOS.mm:

(WebKit::NativeWebTouchEvent::extractWebTouchPoint):
(WebKit::extractWebTouchPoint): Deleted.

Shared/ios/WebPlatformTouchPointIOS.cpp:

4:15 PM Changeset in webkit [184027] by bshafiei@apple.com

2 edits in branches/safari-600.7-branch/Source/WebCore

Merged r183649. rdar://problem/20840113

4:13 PM Changeset in webkit [184026] by mitz@apple.com

2 edits in trunk/Source/WebKit2

<rdar://problem/20757196> NSInternalInconsistencyException raised in -[NSString encodeWithCoder:] beneath createEncodedObject when using WKRemoteObjectEncoder for Safari AutoFill
https://bugs.webkit.org/show_bug.cgi?id=144818

Reviewed by Anders Carlsson.

Allow NSString instances that contain unpaired surrogates to be encoded by
WKRemoteObjectCoder by encoding them directly rather than using
-[NSString encodeWithCoder:].

Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeString): Added. Sets an API::String as the object to encode.
(encodeObject): Changed to use encodeString for NSString instances.
(decodeString): Added. Gets an API::String from the dictionary and returns it as an
NSString.
(decodeObject): Changed to use decodeString for NSString instances.

4:13 PM Changeset in webkit [184025] by bshafiei@apple.com

5 edits
3 copies in branches/safari-600.7-branch

Merged r183646. rdar://problem/20840113

4:11 PM Changeset in webkit [184024] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Fix the build.

Platform/mac/LayerHostingContext.mm:

(WebKit::LayerHostingContext::createFencePort):

4:10 PM Changeset in webkit [184023] by bshafiei@apple.com

5 edits in branches/safari-600.7-branch/Source

Versioning.

4:04 PM Changeset in webkit [184022] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Periodically repaint during resize while using the DynamicSizeWithMinimumViewSize layout strategy
https://bugs.webkit.org/show_bug.cgi?id=144816

Reviewed by Simon Fraser.

UIProcess/mac/WKViewLayoutStrategy.mm:

(-[WKViewDynamicSizeWithMinimumViewSizeLayoutStrategy initWithPage:view:mode:]):
(-[WKViewDynamicSizeWithMinimumViewSizeLayoutStrategy _updateTransientScale:]):
(-[WKViewDynamicSizeWithMinimumViewSizeLayoutStrategy updateLayout]):
Factor out _updateTransientScale from updateLayout.
Keep track of the last viewScaleFactor that we know is being displayed
(_lastCommittedViewScale) and use that for computing the transient scale,
so that we can recompute the transient scale while the UI process's notion
of the actual view scale might have moved ahead of what the Web process has
painted.

3:59 PM Changeset in webkit [184021] by bshafiei@apple.com

2 edits in branches/safari-600.1.4.16-branch/Source/WebCore

Merged r183649. rdar://problem/20840031

3:56 PM Changeset in webkit [184020] by bshafiei@apple.com

5 edits
3 copies in branches/safari-600.1.4.16-branch

Merged r183646. rdar://problem/20840031

3:54 PM Changeset in webkit [184019] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

Creating a large MarkedBlock sometimes results in more than one cell in the block
https://bugs.webkit.org/show_bug.cgi?id=144815

Reviewed by Mark Lam.

Large MarkedBlocks should have one and only one cell. Changed the calculation of
m_endAtom for large blocks to use the location of the first cell + 1. This
assures that large blocks only have one cell.

heap/MarkedBlock.cpp:

(JSC::MarkedBlock::MarkedBlock):

3:11 PM Changeset in webkit [184018] by ap@apple.com

5 edits in trunk/Tools

Build fix.

Reviewed by Dan Bernstein.

DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:

(-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
(-[DumpRenderTreeDraggingInfo resetSpringLoading]):

WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:

(-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
(-[WebKitTestRunnerDraggingInfo resetSpringLoading]):

3:06 PM Changeset in webkit [184017] by bshafiei@apple.com

5 edits in branches/safari-600.1.4.16-branch/Source

Versioning.

2:48 PM Changeset in webkit [184016] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Fix the build.

UIProcess/WebPageProxy.cpp:

2:21 PM Changeset in webkit [184015] by Martin Robinson

14 edits
4 adds in trunk

[GTK] Some tests fail because they do not assume the popup menu captures click events
https://bugs.webkit.org/show_bug.cgi?id=40601

Reviewed by Carlos Garcia Campos.

Tools:

Popdown all attached menus when moving between tests and between each new
event sent to the WebView. This prevents context and popup menus from eating
events.

WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::dispatchEvent): Popdown all menus between dispatching events.
(WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
(WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.

WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::hideAllPopupMenus): Added this helper.

WebKitTestRunner/gtk/TestControllerGtk.cpp:

(WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
longer in the platform-independent file.
(WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.

LayoutTests:

platform/gtk/TestExpectations: Unskip tests that are passing now

and classify remaining failures.

platform/gtk/editing/selection/5354455-2-expected.txt: Rebaselined.
platform/gtk/editing/selection/doubleclick-crash-expected.png: Rebaseline.
platform/gtk/editing/selection/doubleclick-crash-expected.txt: Rebaseline.
platform/gtk/editing/selection/user-select-all-image-with-single-click-expected.txt: Rebaselined.
platform/gtk/editing/selection/user-select-all-with-single-click-expected.txt: Rebaselined.
platform/gtk/fast/events/mouseup-from-button2-expected.txt: Rebaseline.
platform/gtk/fast/events/shadow-event-path-2-expected.txt: Rebaseline.
platform/gtk/fast/events/shadow-event-path-expected.txt: Rebaseline.
platform/gtk/fast/events/updateLayoutForHitTest-expected.txt: Rebaselined.

1:57 PM Changeset in webkit [184014] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Fix the build.

Platform/mac/LayerHostingContext.mm:

(WebKit::LayerHostingContext::createFencePort):

1:50 PM Changeset in webkit [184013] by Brent Fulgham

2 edits in trunk/LayoutTests

[WK2] Scroll-snap tests timeout intermittently for overflow scroll cases
https://bugs.webkit.org/show_bug.cgi?id=144811

platform/mac-wk2/TestExpectations: Mark tests as flaky.

1:43 PM Changeset in webkit [184012] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Fix the build.

Platform/mac/LayerHostingContext.mm:

(WebKit::LayerHostingContext::createFencePort):

1:40 PM Changeset in webkit [184011] by timothy_horton@apple.com

13 edits in trunk/Source/WebKit2

Flip the direction of the fence in scaleViewAndUpdateGeometryFenced
https://bugs.webkit.org/show_bug.cgi?id=144810

Reviewed by Simon Fraser.

Send the fence from the Web process to the UI process, instead of vice versa.
This means that we won't keep the UI process CAContext blocked for the whole
time that the Web process is doing layout/painting/etc. Instead, we'll start
blocking the Web process CAContext immediately after flushing and before committing,
and send the fence to the UI process to be applied immediately. This minimizes
the amount of time in both processes spent blocked on the fence.

Platform/mac/LayerHostingContext.h:
Platform/mac/LayerHostingContext.mm:

(WebKit::LayerHostingContext::createFencePort):
Add createFencePort, which creates a MachSendRight wrapping a CA fence port.
Note that you must setFencePort() with this port if you want the LayerHostingContext's
CAContext to block on it!

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::scaleViewAndUpdateGeometryFenced):
(WebKit::WebPageProxy::machSendRightCallback):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:

Create a callback and send it to the Web process along with scaleViewAndUpdateGeometryFenced.

UIProcess/mac/WKViewLayoutStrategy.mm:

(-[WKViewDynamicSizeWithMinimumViewSizeLayoutStrategy updateLayout]):
When called back, install the fence port in our CAContext; when the commit goes through,
remove the transient scale as we did previously.

WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::replyWithFenceAfterNextFlush):
(WebKit::DrawingArea::updateGeometry): Deleted.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scaleViewAndUpdateGeometryFenced):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Instead of installing a fence created in the UI process, tell the DrawingArea
to create one and reply to the UI process with it after the next flush.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::replyWithFenceAfterNextFlush):
After flushing, before committing, create a fence and reply to any
callbacks that requested fences, and install it in our context.

1:29 PM Changeset in webkit [184010] by Martin Robinson

12 edits in trunk

.:
015-05-08 Michael Catanzaro <Michael Catanzaro>, Martin Robinson <mrobinson@igalia.com>

[GTK] Checks for DEVELOPMENT_BUILD are all wrong
https://bugs.webkit.org/show_bug.cgi?id=144746

Reviewed by Carlos Garcia Campos.

Don't set DEVELOPMENT_BUILD. We check whether it is defined for conditional compilation, not
what it is defined to, so defining it to 0 effectively turned it on always. Instead set
ENABLE_DEVELOPER_MODE so that we can use the ENABLE macro inside WebKit source code.

Source/cmake/OptionsGTK.cmake:

Source/WebCore:
[GTK] Checks for DEVELOPMENT_BUILD are all wrong
https://bugs.webkit.org/show_bug.cgi?id=144746

Reviewed by Carlos Garcia Campos.

Use ENABLE(DEVELOPER_MODE) rather than DEVELOPMENT_BUILD.

platform/gtk/GtkUtilities.cpp:
platform/gtk/GtkUtilities.h:
platform/text/gtk/HyphenationLibHyphen.cpp:

(WebCore::availableLocales):

Source/WebKit2:
[GTK] Checks for DEVELOPMENT_BUILD are all wrong
https://bugs.webkit.org/show_bug.cgi?id=144746

Reviewed by Carlos Garcia Campos.

Use ENABLE(DEVELOPER_MODE) rather than DEVELOPMENT_BUILD.

Shared/gtk/ProcessExecutablePathGtk.cpp:

(WebKit::findWebKitProcess):

UIProcess/API/gtk/WebKitWebContext.cpp:

(injectedBundleDirectory):

UIProcess/gtk/TextCheckerGtk.cpp:

(WebKit::enchantTextChecker):

Tools:
015-05-08 Michael Catanzaro <Michael Catanzaro>, Martin Robinson <mrobinson@igalia.com>

[GTK] Checks for DEVELOPMENT_BUILD are all wrong
https://bugs.webkit.org/show_bug.cgi?id=144746

Reviewed by Carlos Garcia Campos.

Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.

MiniBrowser/gtk/main.c:

(main):

1:07 PM Changeset in webkit [184009] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

MapDataImpl::add() shouldn't do the same hash lookup twice.
https://bugs.webkit.org/show_bug.cgi?id=144759

Reviewed by Gavin Barraclough.

We don't actually need to do a double lookup here, all we need to
do is update the index to point to the correct m_size.

runtime/MapDataInlines.h:

(JSC::JSIterator>::add):

12:43 PM Changeset in webkit [184008] by bshafiei@apple.com

5 edits in branches/safari-601.1.32-branch/Source

Versioning.

12:41 PM Changeset in webkit [184007] by bshafiei@apple.com

1 copy in branches/safari-601.1.32-branch

New Branch.

12:23 PM Changeset in webkit [184006] by akling@apple.com

2 edits in trunk/Source/JavaScriptCore

Micro-optimize JSON serialization of string primitives.
<https://webkit.org/b/144800>

Reviewed by Sam Weinig.

Don't use the out-of-line JSValue::getString() to grab at string primitives
in serialization. Just check if it's a JSString and then downcast to grab at
the WTF::String inside.

2% progression on Kraken/json-stringify-tinderbox.

runtime/JSONObject.cpp:

(JSC::Stringifier::appendStringifiedValue):

12:14 PM Changeset in webkit [184005] by ap@apple.com

3 edits in trunk/Source/WebCore

Crashes in SocketStreamHandleBase::close
https://bugs.webkit.org/show_bug.cgi?id=144767
rdar://problem/20486538

Reviewed by Brady Eidson.

This is a speculative fix, I could not reproduce the crash.

Modules/websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::processFrame):

Normally, processOutgoingFrameQueue() closes the handle in the end when called in
OutgoingFrameQueueClosing state. But there is no definitive protection against
processing two CLOSE frames, in which case we'd try to close the handle twice.

platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::readStreamCallback): Passing empty data to the client
results in the socket being closed, which makes no sense here.

12:07 PM Changeset in webkit [184004] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Fix ProcessLauncher port leak
https://bugs.webkit.org/show_bug.cgi?id=144807
rdar://problem/20593291

Reviewed by Sam Weinig.

UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::connectToService):
xpc_dictionary_set_mach_send increments the send right count so make sure to
balance it with a call to mach_port_deallocate.

12:01 PM Changeset in webkit [184003] by commit-queue@webkit.org

13 edits in trunk

Unreviewed, rolling out r183996.
https://bugs.webkit.org/show_bug.cgi?id=144806

ASan detected use-after free (Requested by ap on #webkit).

Reverted changeset:

"Remove convenience constructors for TextRun"
https://bugs.webkit.org/show_bug.cgi?id=144752
http://trac.webkit.org/changeset/183996

11:59 AM Changeset in webkit [184002] by dbates@webkit.org

1 edit
1 add in trunk

[iOS] WebSQL operations are not performed after device is locked
https://bugs.webkit.org/show_bug.cgi?id=137503
<rdar://problem/20844952>

Rubber-stamped by Alexey Proskuryakov.

Add a manual test to help verify that we do not regress this issue.

ManualTests/ios/execute-sql-transaction-callback-after-locking-unlocking-device-in-earlier-transaction.html: Added.

11:45 AM Changeset in webkit [184001] by eric.carlson@apple.com

4 edits in trunk/Source/WebCore

[Mac] Playback target clients do not unregister on page reload
https://bugs.webkit.org/show_bug.cgi?id=144761

Reviewed by Brady Eidson.

dom/Document.cpp:

(WebCore::Document::prepareForDestruction): Unregister all target picker clients.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::registerWithDocument): Register for page cache callback.
(WebCore::HTMLMediaElement::unregisterWithDocument): Unregister for page cache callback.
(WebCore::HTMLMediaElement::documentWillSuspendForPageCache): New.
(WebCore::HTMLMediaElement::documentDidResumeFromPageCache): New.

11:37 AM Changeset in webkit [184000] by commit-queue@webkit.org

6 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles sidebar editing with incomplete property looks poor in UI
https://bugs.webkit.org/show_bug.cgi?id=141692

Patch by Tobias Reiss <tobi+webkit@basecode.de> on 2015-05-08
Reviewed by Timothy Hatcher.

Add "css-rule" Formatter that breaks CSS declarations into multiple lines,
keeps comments and invalid styles and adds whitespace.

Tools/PrettyPrinting/css-rule-tests/*.css: Added.

Add test cases.

Tools/PrettyPrinting/index.html:

Enable Test setup to be able to run "css-rule" Formatter tests.

UserInterface/Controllers/Formatter.js:

(Formatter.prototype._handleToken):

UserInterface/Controllers/FormatterContentBuilder.js:

(FormatterContentBuilder.prototype.removeLastNewline):
(FormatterContentBuilder.prototype.removeLastWhitespace):
(FormatterContentBuilder.prototype._popFormattedContent):
(FormatterContentBuilder.prototype._popNewLine): Deleted.

UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._formattedContentFromEditor):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update.set this):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update.get this):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update.countNewLineCharacters): Deleted.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update.else): Deleted.

UserInterface/Views/CodeMirrorFormatters.js:

11:20 AM Changeset in webkit [183999] by Beth Dakin

2 edits in trunk/Source/WebKit2

Fix performance tests after r183954
https://bugs.webkit.org/show_bug.cgi?id=144805

Reviewed by Alexey Proskuryakov.

Web* is traditionally a WK1 prefix, so use the WK2 prefix instead in WK2 so that
we don’t have two classes with the same name in the two projects.

UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _defaultAnimationController]):

11:15 AM Changeset in webkit [183998] by Chris Dumez

12 edits
7 adds in trunk

Throttle RequestAnimationFrame in subframes that are outside the viewport
https://bugs.webkit.org/show_bug.cgi?id=144718
<rdar://problem/20688782>

Reviewed by Simon Fraser.

Source/WebCore:

Throttle RequestAnimationFrame in subframes that are outside the
viewport or have "display: none" for performance and power.

Tests: fast/animation/request-animation-frame-throttle-subframe-display-none.html

fast/animation/request-animation-frame-throttle-subframe.html

dom/Document.h:

(WebCore::Document::scriptedAnimationController):

dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::setThrottled):
(WebCore::ScriptedAnimationController::isThrottled):

dom/ScriptedAnimationController.h:
loader/FrameLoader.cpp:

(WebCore::FrameLoader::open):
Call FrameView::setFrameRect() only *after* the view has been
set on the Frame. Otherwise, setFrameRect() ends up calling
viewportContentsChanged() and we hit the
ASSERT(frame().view() == this) assertion in windowClipRect()
because the Frame still has its old FrameView. This is covered
by loader/go-back-to-different-window-size.html layout test.

page/FrameView.cpp:

(WebCore::FrameView::viewportContentsChanged):
(WebCore::FrameView::applyRecursivelyWithVisibleRect):
(WebCore::FrameView::resumeVisibleImageAnimations):
(WebCore::FrameView::updateScriptedAnimationsThrottlingState):
(WebCore::FrameView::resumeVisibleImageAnimationsIncludingSubframes):
(WebCore::FrameView::updateThrottledDOMTimersState):
(WebCore::FrameView::scrollPositionChanged): Deleted.
(WebCore::FrameView::sendResizeEventIfNeeded): Deleted.

page/FrameView.h:
testing/Internals.cpp:

(WebCore::Internals::isRequestAnimationFrameThrottled):
(WebCore::Internals::isTimerThrottled): Deleted.

testing/Internals.h:
testing/Internals.idl:

LayoutTests:

fast/animation/request-animation-frame-throttle-subframe-display-none-expected.txt: Added.
fast/animation/request-animation-frame-throttle-subframe-display-none.html: Added.

Add layout test to test that RequestAnimationFrame is properly throttled
in "display: none" subframes.

fast/animation/request-animation-frame-throttle-subframe-expected.txt: Added.
fast/animation/request-animation-frame-throttle-subframe.html: Added.

Add layout test to test that RequestAnimationFrame is properly throttled
in frames that are outside the viewport.

fast/animation/resources/requestAnimationFrame-frame-2.html: Added.
fast/animation/resources/requestAnimationFrame-frame.html: Added.

platform/win/TestExpectations:

Skip the 2 new tests on Windows as requestAnimationFrame throttling is
only supported on Cocoa.

10:56 AM Changeset in webkit [183997] by dbates@webkit.org

2 edits in trunk/Source/WebCore

Fix the iOS Simulator external SDK build following <http://trac.webkit.org/changeset/181918>

Remove unused iOS Simulator-variant of CARenderServerRenderLayerWithTransform(). Also guard
IOSurfaceRef-variant of CARenderServerRenderLayerWithTransform() with USE(IOSURFACE)
since it is only applicable on platforms that use IOSurface.

platform/spi/cocoa/QuartzCoreSPI.h:

10:18 AM Changeset in webkit [183996] by mmaxfield@apple.com

13 edits in trunk

Remove convenience constructors for TextRun
https://bugs.webkit.org/show_bug.cgi?id=144752

Source/WebCore:

These convenience constructors are unnecessary. Moving the code that makes the StringView
back to the call site will also help us make things more elegant in future refactoring.

Reviewed by Darin Adler.

No new tests because there is no behavior change.

css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText): Remove ambiguous call.

platform/graphics/StringTruncator.cpp:

(WebCore::stringWidth):

platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):

platform/mac/DragImageMac.mm:

(WebCore::widthWithFont):
(WebCore::drawAtPoint):

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::TextFragmentIterator::Style::Style):
(WebCore::SimpleLineLayout::TextFragmentIterator::runWidth):

rendering/TextPainter.cpp:

(WebCore::TextPainter::paintText):

Source/WebKit/mac:

These convenience constructors are unnecessary. Moving the code that makes the StringView
back to the call site will also help us make things more elegant in future refactoring.

Reviewed by Darin Adler.

No new tests because there is no behavior change.

Misc/WebKitNSStringExtras.mm:

(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
(-[NSString _web_widthWithFont:]):

Source/WTF:

Reviewed by Anders Carlsson.

No reason why StringView shouldn't have a StringImpl* constructor.

Test: StringView8Bit in TestWebKitAPI

wtf/text/StringView.h: Add the constructor.

Tools:

Reviewed by Anders Carlsson.

Test the StringView which takes a StringImpl*.

TestWebKitAPI/Tests/WTF/StringView.cpp:

(StringView8Bit): Testing is8Bit() on StringView

9:09 AM Changeset in webkit [183995] by Carlos Garcia Campos

4 edits in trunk

[GTK] WTR doesn't correctly handle the Escape key
https://bugs.webkit.org/show_bug.cgi?id=144788

Reviewed by Martin Robinson.

Tools:

Correctly handle 0x001B character code in GTK+ event sender to be
recognized as Escape key, because gdk_unicode_to_keyval() doesn't
handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
to dismiss popup menus.

Fixes editing/selection/5354455-1.html.

WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::getGDKKeySymForKeyRef):

LayoutTests:

Unskip editing/selection/5354455-1.html.

platform/gtk/TestExpectations:

8:12 AM Changeset in webkit [183994] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[Win] Unskip passing test case after r183981
https://bugs.webkit.org/show_bug.cgi?id=140517

Patch by Hyungwook Lee <hyungwook.lee@navercorp.com> on 2015-05-08
Reviewed by Brent Fulgham.

platform/win/TestExpectations:

8:00 AM Changeset in webkit [183993] by Gyuyoung Kim

2 edits in trunk/LayoutTests

Unreviewed EFL gardening on 8th May.

Mark flaky tests and timeout tests after using xorgdriver on EFL port.

platform/efl/TestExpectations:

4:53 AM Changeset in webkit [183992] by Carlos Garcia Campos

8 edits in trunk

[GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=144748

Reviewed by Sergio Villar Senin.

Source/WebKit2:

This is needed by local applications loaded as a file URI that do XMLHttpRequests.

UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_allow_file_access_from_file_urls):
(webkit_settings_set_allow_file_access_from_file_urls):

UIProcess/API/gtk/WebKitSettings.h:
UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:

Tools:

TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:

(testWebKitSettings): Check the new setting is correctly
initialized and updated.

TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:

(testWebContextSecurityFileXHR): Check XHR to local files is
allowed from file URLs after changing the setting.
(beforeAll): Add new test.

3:44 AM Changeset in webkit [183991] by youenn.fablet@crf.canon.fr

13 edits
2 adds in trunk

[Streams API] ReadableStream constructor start function should be able to error the stream
https://bugs.webkit.org/show_bug.cgi?id=141162

Reviewed by Darin Adler.

Source/WebCore:

This patch implements the functionality of the ReadableStreamController error function.
It basically changes the state of the stream to errored, resolves the ready promise and rejects the closed promise.
Adding support to reject promise with any JSValue.

Support for storing the error is added to both reader and stream.

Test: streams/readable-stream-controller-error.html and rebased tests

Modules/streams/ReadableStream.cpp:

(WebCore::ReadableStream::changeStateToErrored):

Modules/streams/ReadableStream.h:
Modules/streams/ReadableStreamReader.cpp:

(WebCore::ReadableStreamReader::initialize):
(WebCore::ReadableStreamReader::closed):
(WebCore::ReadableStreamReader::changeStateToClosed):
(WebCore::ReadableStreamReader::changeStateToErrored):

Modules/streams/ReadableStreamReader.h:
bindings/js/JSDOMPromise.h:

(WebCore::DeferredWrapper::reject):

bindings/js/JSReadableStreamControllerCustom.cpp:

(WebCore::JSReadableStreamController::error):

bindings/js/JSReadableStreamReaderCustom.cpp:

(WebCore::JSReadableStreamReader::closed):

bindings/js/ReadableJSStream.cpp:

(WebCore::ReadableJSStream::createReader):
(WebCore::ReadableJSStream::storeError):
(WebCore::ReadableJSStream::Reader::storeError):
(WebCore::ReadableJSStream::jsController): Deleted.

bindings/js/ReadableJSStream.h:

LayoutTests:

streams/readable-stream-controller-error-expected.txt: Added.
streams/readable-stream-controller-error.html: Added.
streams/reference-implementation/bad-underlying-sources-expected.txt:
streams/reference-implementation/readable-stream-templated-expected.txt:

2:44 AM Changeset in webkit [183990] by commit-queue@webkit.org

10 edits
5 deletes in trunk

Unreviewed, rolling out r183985.
https://bugs.webkit.org/show_bug.cgi?id=144796

broke loader/go-back-to-different-window-size.html (Requested
by kling on #webkit).

Reverted changeset:

"Throttle RequestAnimationFrame in subframes that are outside
the viewport"
https://bugs.webkit.org/show_bug.cgi?id=144718
http://trac.webkit.org/changeset/183985

2:37 AM Changeset in webkit [183989] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

REGRESSION(r183072): dfg-put-by-id-prototype-check.js.layout-dfg-eager-no-cjit fails on AArch64 Linux
https://bugs.webkit.org/show_bug.cgi?id=144256

Unreviewed gardening, skip the failing test on AArch64 Linux.

js/script-tests/dfg-put-by-val-direct-to-generic-array.js:

1:44 AM Changeset in webkit [183988] by akling@apple.com

9 edits in trunk/Source

Optimize serialization of quoted JSON strings.
<https://webkit.org/b/144754>

Reviewed by Darin Adler.

Source/JavaScriptCore:

Optimized the serialization of quoted strings into JSON by moving the logic into
StringBuilder so it can make smarter decisions about buffering.

12% progression on Kraken/json-stringify-tinderbox (on my Mac Pro.)

bytecompiler/NodesCodegen.cpp:

(JSC::ObjectPatternNode::toString): Use the new StringBuilder API.

runtime/JSONObject.h:
runtime/JSONObject.cpp:

(JSC::Stringifier::Holder::appendNextProperty):
(JSC::appendStringToStringBuilder): Deleted.
(JSC::appendQuotedJSONStringToBuilder): Deleted.
(JSC::Stringifier::appendQuotedString): Deleted.
(JSC::Stringifier::appendStringifiedValue): Moved the bulk of this logic
to StringBuilder and call that from here.

Source/WebKit2:

NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::asJSON): Use the new StringBuilder API.

Source/WTF:

Add a StringBuilder API for appending a quoted JSON string. This is used by
JSON.stringify() to implement efficient appending of strings while escaping
quotes, control characters and \uNNNN-style characters.

The main benefit comes from only doing a single buffer expansion up front,
instead of doing it every time we append something. The fudge factor is pretty
large, since the maximum number of output characters per input character is 6.

The first landing of this patch had two bugs in it: