⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 10, 2015:

11:38 PM Changeset in webkit [184067] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Have MediaStream::getAudioTracks(), MediaStream::getVideoTracks() return const references
​https://bugs.webkit.org/show_bug.cgi?id=144794

Reviewed by Philippe Normand.

  • Modules/mediastream/MediaStream.h: getAudioTracks() and getVideoTracks()

should return a const reference to the member variables, instead of
copying the objects on every call.

10:53 PM Changeset in webkit [184066] by Gyuyoung Kim
  • 66 edits in trunk/Source

Use Ref instead of PassRefPtr in WebCore/page
​https://bugs.webkit.org/show_bug.cgi?id=144841

Reviewed by Darin Adler.

To kill PassRefPtr, this patch replaces PassRefPtr with Ref or RefPtr
in WebCore/page.

Source/WebCore:

No new tests, no behavior changes.

  • page/DebugPageOverlays.cpp:
  • page/EventSource.cpp:

(WebCore::EventSource::create):

  • page/EventSource.h:
  • page/History.h:

(WebCore::History::create):

  • page/Location.h:

(WebCore::Location::create):

  • page/MainFrame.cpp:

(WebCore::MainFrame::create):

  • page/MainFrame.h:
  • page/Navigator.h:

(WebCore::Navigator::create):

  • page/PageOverlay.cpp:

(WebCore::PageOverlay::create):

  • page/PageOverlay.h:
  • page/Performance.h:
  • page/PerformanceEntryList.h:

(WebCore::PerformanceEntryList::create):

  • page/PerformanceMark.h:

(WebCore::PerformanceMark::create):

  • page/PerformanceMeasure.h:

(WebCore::PerformanceMeasure::create):

  • page/PerformanceNavigation.h:

(WebCore::PerformanceNavigation::create):

  • page/PerformanceResourceTiming.h:

(WebCore::PerformanceResourceTiming::create):

  • page/PerformanceTiming.h:

(WebCore::PerformanceTiming::create):

  • page/PerformanceUserTiming.h:

(WebCore::UserTiming::create):

  • page/Screen.h:
  • page/Settings.cpp:

(WebCore::Settings::create):

  • page/Settings.h:
  • page/TextIndicator.cpp:

(WebCore::TextIndicator::create):

  • page/TextIndicator.h:
  • page/UserContentController.cpp:

(WebCore::UserContentController::create):

  • page/UserContentController.h:
  • page/UserMessageHandlerDescriptor.h:

(WebCore::UserMessageHandlerDescriptor::create):

  • page/UserMessageHandlersNamespace.h:
  • page/VisitedLinkStore.h:
  • page/WebKitNamespace.h:

(WebCore::WebKitNamespace::create):

  • page/WebKitPoint.h:

(WebCore::WebKitPoint::create):

  • page/WorkerNavigator.h:

(WebCore::WorkerNavigator::create):

  • page/animation/ImplicitAnimation.h:

(WebCore::ImplicitAnimation::create):

  • page/animation/KeyframeAnimation.h:
  • page/mac/ServicesOverlayController.h:
  • page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::Highlight::createForSelection):
(WebCore::ServicesOverlayController::Highlight::createForTelephoneNumber):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::create):

  • page/scrolling/ScrollingCoordinator.h:
  • page/scrolling/ScrollingStateFixedNode.cpp:

(WebCore::ScrollingStateFixedNode::create):
(WebCore::ScrollingStateFixedNode::clone):

  • page/scrolling/ScrollingStateFixedNode.h:
  • page/scrolling/ScrollingStateFrameScrollingNode.cpp:

(WebCore::ScrollingStateFrameScrollingNode::create):
(WebCore::ScrollingStateFrameScrollingNode::clone):

  • page/scrolling/ScrollingStateFrameScrollingNode.h:
  • page/scrolling/ScrollingStateNode.h:
  • page/scrolling/ScrollingStateOverflowScrollingNode.cpp:

(WebCore::ScrollingStateOverflowScrollingNode::create):
(WebCore::ScrollingStateOverflowScrollingNode::clone):

  • page/scrolling/ScrollingStateOverflowScrollingNode.h:
  • page/scrolling/ScrollingStateStickyNode.cpp:

(WebCore::ScrollingStateStickyNode::create):
(WebCore::ScrollingStateStickyNode::clone):

  • page/scrolling/ScrollingStateStickyNode.h:
  • page/scrolling/ios/ScrollingCoordinatorIOS.mm:

(WebCore::ScrollingCoordinator::create):

  • page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.h:
  • page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm:

(WebCore::ScrollingTreeFrameScrollingNodeIOS::create):

  • page/scrolling/ios/ScrollingTreeIOS.cpp:

(WebCore::ScrollingTreeIOS::create):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinator::create):

  • page/scrolling/mac/ScrollingTreeFixedNode.h:
  • page/scrolling/mac/ScrollingTreeFixedNode.mm:

(WebCore::ScrollingTreeFixedNode::create):

  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::create):

  • page/scrolling/mac/ScrollingTreeMac.cpp:

(ScrollingTreeMac::create):

  • page/scrolling/mac/ScrollingTreeMac.h:
  • page/scrolling/mac/ScrollingTreeStickyNode.h:
  • page/scrolling/mac/ScrollingTreeStickyNode.mm:

(WebCore::ScrollingTreeStickyNode::create):

Source/WebKit2:

(WebKit::WebUserContentController::WebUserContentController):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setTextIndicator):

  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didPerformDictionaryLookup):

  • WebProcess/UserContent/WebUserContentController.cpp:

(WebKit::WebUserContentController::WebUserContentController):

8:56 PM Changeset in webkit [184065] by Simon Fraser
  • 5 edits
    1 copy
    8 adds in trunk

background-position sometimes doesn't work properly with background-attachment: fixed
​https://bugs.webkit.org/show_bug.cgi?id=103757
rdar://problem/18749925

Reviewed by Darin Adler.

Source/WebCore:

Fix sizing issues with fixed backgrounds when top content inset (blurred toolbar) is in
effect.

The primary issue was that positioningAreaSize was including the top content inset
height, and should not have been, but there were also issues with the "fixedBackgroundPaintsInLocalCoordinates"
code path, which kicks in when the root background is fixed.

Tests: platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-cover-local.html

platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-cover.html
platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-local.html
platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-positioned.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

LayoutTests:

Tests various configurations for painting the fixed backgrounds. The existing test was
actually wrong, so fixed to use a gradient (so you can see where the edges of the image are),
and be valid. Testing is complicated by the fact that setting top content inset actually
causes the snapshot to be inset at the top.

  • platform/mac-wk2/tiled-drawing/resources/bordered-image.png: Added.
  • platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-cover-expected.html: Added.
  • platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-cover-local-expected.html: Added.
  • platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-cover-local.html: Copied from LayoutTests/platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment.html.
  • platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-cover.html: Added.
  • platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-expected.html:
  • platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-local-expected.html: Added.
  • platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-local.html: Added.
  • platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-positioned-expected.html: Added.
  • platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-positioned.html: Added.
  • platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment.html:
8:09 PM Changeset in webkit [184064] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[GTK][SOUP] Web and Network processes don't know how to get memory size on OSX
​https://bugs.webkit.org/show_bug.cgi?id=144554

Patch by Philip Chimento <​philip.chimento@gmail.com> on 2015-05-10
Reviewed by Darin Adler.

  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformSetCacheModel): Use WTF::ramSize()
instead of local function. Also use WTF::MB instead of dividing by
1024 * 1024.
(WebKit::getMemorySize): Deleted.

  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformSetCacheModel): Ditto.
(WebKit::getMemorySize): Deleted.

8:07 PM Changeset in webkit [184063] by commit-queue@webkit.org
  • 3 edits in trunk

CMake defines CAIROGL_FOUND, not CAIRO_GL_FOUND
​https://bugs.webkit.org/show_bug.cgi?id=144846

Patch by Philip Chimento <​philip.chimento@gmail.com> on 2015-05-10
Reviewed by Martin Robinson.

  • Source/cmake/FindCairoGL.cmake: Use CAIROGL_* instead of

CAIRO_GL_* throughout, because find_package will define
CAIROGL_FOUND.

  • Source/cmake/OptionsGTK.cmake: Ditto.
8:03 PM Changeset in webkit [184062] by commit-queue@webkit.org
  • 2 edits in trunk

[CMake] Some macros need to be defined/undefined, rather than ON/OFF
​https://bugs.webkit.org/show_bug.cgi?id=144845

Patch by Philip Chimento <​philip.chimento@gmail.com> on 2015-05-10
Reviewed by Martin Robinson.

  • Source/cmake/OptionsGTK.cmake: Only define MOZ_X11 and XP_UNIX

if their corresponding WTF options are ON. The code in npapi.h
relies on these being undefined if they are to be switched off.

6:41 PM Changeset in webkit [184061] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

Use preview view controller from WebKitSystemInterface.
​https://bugs.webkit.org/show_bug.cgi?id=144836

Add a property _allowsLinkPreview to WKWebView so that we can turn on/off preview at runtime. Also,
for client that doesn't provide preview view controller, use the default view controller prepared
by WebKitSystemInterface.

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2015-05-10
Reviewed by Dan Bernstein.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView _allowsLinkPreview]):
(-[WKWebView _setAllowsLinkPreview:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h: Add _allowsLinkPreview property
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView willMoveToWindow:]):

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _registerPreviewInWindow:]):
(-[WKContentView _unregisterPreviewInWindow:]):
(-[WKContentView previewViewControllerForPosition:inSourceView:]): : For client that doesn't provide

preview delegate, use preview view controller in WebKitSystemInterface.

(-[WKContentView commitPreviewViewController:]):

5:57 PM Changeset in webkit [184060] by Martin Robinson
  • 4 edits in trunk

[GTK] fast/events/page-visibility-transition-test.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=114789

Reviewed by Darin Adler.

Tools:

  • WebKitTestRunner/gtk/TestControllerGtk.cpp:

(WTR::TestController::setHidden): Map and unmap the WebView when the harness
requests visibility changes.

LayoutTests:

  • platform/gtk/TestExpectations: Unskip failing tests.
4:28 PM Changeset in webkit [184059] by Darin Adler
  • 2 edits in trunk/Source/WebKit2

Fix internal Apple builds on Mavericks.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _dismissContentRelativeChildWindows]): Added missing conditionals around
some code that is for OS X 10.10 or newer only. There were similar conditionals around
other nearby code in this file, and around other uses of the same method in other files,
so matched the style.

3:49 PM Changeset in webkit [184058] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

iOS internal build fix.

  • Platform/mac/MenuUtilities.mm:
3:15 PM Changeset in webkit [184057] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[EFL] Fix install-dependencies on Ubuntu 14.10/15.04
​https://bugs.webkit.org/show_bug.cgi?id=144798

Reviewed by Darin Adler.

  • efl/install-dependencies:
2:45 PM Changeset in webkit [184056] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Get rid of the public item accessors in BackForwardClient
​https://bugs.webkit.org/show_bug.cgi?id=144827

Patch by Sungmann Cho <​sungmann.cho@navercorp.com> on 2015-05-10
Reviewed by Darin Adler.

Remove backItem(), currentItem(), and forwardItem() from BackForwardClient.
We can still use these functionalities through BackForwardController.

No new tests, no behavior change.

Source/WebCore:

  • history/BackForwardClient.h:

(WebCore::BackForwardClient::backItem): Deleted.
(WebCore::BackForwardClient::currentItem): Deleted.
(WebCore::BackForwardClient::forwardItem): Deleted.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _loadBackForwardListFromOtherView:]):

2:43 PM Changeset in webkit [184055] by commit-queue@webkit.org
  • 33 edits in trunk/Source/WebCore

Rename Length::isPercent() and Length::isPercentNotCalculated().
​https://bugs.webkit.org/show_bug.cgi?id=144791

Patch by Sungmann Cho <​sungmann.cho@navercorp.com> on 2015-05-10
Reviewed by Darin Adler.

  1. Rename these methods as below for consistency and clarity.

Length::isPercentNotCalculated() => Length::isPercent()
Length::isPercent() => Length::isPercentOrCalculated()

  1. Simplify the condition check of length type in SVGLengthContext::valueForLength().

"length.isPercent() && !length.isCalculated()" => "length.isPercent()"

No new tests, no behavior change.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForImageSliceSide):
(WebCore::valueForReflection):
(WebCore::percentageOrZoomAdjustedValue):
(WebCore::lineHeightFromStyle):
(WebCore::ComputedStyleExtractor::propertyValue):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::is100Percent):

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::computeTransformedExtentViaTransformList):

  • platform/Length.h:

(WebCore::Length::percent):
(WebCore::Length::isPercent):
(WebCore::Length::isPercentOrCalculated):
(WebCore::Length::isSpecified):
(WebCore::Length::isPercentNotCalculated): Deleted.

  • platform/graphics/transforms/TranslateTransformOperation.h:
  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::fullRecalc):
(WebCore::shouldScaleColumns):
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):
(WebCore::FixedTableLayout::applyPreferredLogicalWidthQuirks):
(WebCore::FixedTableLayout::layout):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isSelfCollapsingBlock):
(WebCore::RenderBlock::textIndentOffset):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::needsPreferredWidthsRecalculation):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeContentAndScrollbarLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::logicalWidthIsResolvable):
(WebCore::RenderBox::percentageLogicalHeightIsResolvableFromBlock):
(WebCore::RenderBox::hasUnsplittableScrollingOverflow):
(WebCore::RenderBox::layoutOverflowRectForPropagation):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight):
(WebCore::RenderBoxModelObject::relativePositionOffset):
(WebCore::RenderBoxModelObject::computedCSSPadding):
(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):
(WebCore::RenderBoxModelObject::calculateFillTileSize):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp):

  • rendering/RenderElement.cpp:

(WebCore::mustRepaintFillLayers):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidths):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::layOutAxis):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::repaintOrMarkForLayout):

  • rendering/RenderInline.cpp:

(WebCore::computeMargin):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::computeIntrinsicLogicalWidths):

  • rendering/RenderMenuList.cpp:

(RenderMenuList::computeIntrinsicLogicalWidths):

  • rendering/RenderObject.cpp:

(WebCore::objectIsRelayoutBoundary):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computePreferredLogicalWidths):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::computeIntrinsicLogicalWidths):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::convertStyleLogicalHeightToComputedHeight):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computeIntrinsicLogicalWidths):

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticalPositionForBox):

  • rendering/style/GridLength.h:

(WebCore::GridLength::isPercentage):

  • rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::isPercentage):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::computedLineHeight):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::hasRelativeDimensions):

  • svg/SVGLengthContext.cpp:

(WebCore::SVGLengthContext::valueForLength):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::hasRelativeWidth):
(WebCore::SVGImage::hasRelativeHeight):

2:26 PM Changeset in webkit [184054] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Remove unnecessary semicolons.
​https://bugs.webkit.org/show_bug.cgi?id=144844

Patch by Sungmann Cho <​sungmann.cho@navercorp.com> on 2015-05-10
Reviewed by Darin Adler.

No new tests, no behavior change.

Source/WebCore:

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):

  • platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::readString):

  • platform/mediastream/RealtimeMediaSourceCapabilities.h:

(WebCore::RealtimeMediaSourceCapabilities::setHasVideoSource):

  • platform/network/mac/ResourceErrorMac.mm:

(WebCore::ResourceError::nsError):

  • rendering/RenderThemeIOS.mm:

(WebCore::getSharedFunctionRef):

Source/WebKit2:

  • Shared/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:shouldDecodeSourceDataOfMIMEType:]):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::transformHandlesToObjects):

  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::indicatorLocation):

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::idToHistoryItemMap):

2:23 PM Changeset in webkit [184053] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary forward declarations in StyleProperties.h
​https://bugs.webkit.org/show_bug.cgi?id=144843

Patch by Sungmann Cho <​sungmann.cho@navercorp.com> on 2015-05-10
Reviewed by Darin Adler.

No new tests, no behavior change.

  • css/StyleProperties.h:
2:10 PM WebKitGTK/2.4.x edited by Michael Catanzaro
Add bug #126433 (diff)
1:28 PM Changeset in webkit [184052] by Darin Adler
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • Platform/mac/MenuUtilities.mm: Added includes that were somehow omitted in what

I committed before.

1:19 PM Changeset in webkit [184051] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove unnecessary AtomicStringImpl* hash specification in PropertyNameArray.

Follow up to r184050 suggested by Darin.

  • runtime/PropertyNameArray.h:
1:03 PM Changeset in webkit [184050] by akling@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Remove unused things from PropertyNameArray.
<​https://webkit.org/b/144834>

Reviewed by Filip Pizlo.

PropertyNameArray had a bunch of bells and whistles added to it when for-in iteration
was refactored and optimized last year. Then more refactoring happened and this class
doesn't need to ring and toot anymore.

The RefCountedIdentifierSet class disappears since the JSPropertyNameEnumerator wasn't
actually using it for anything and we were just wasting time creating these.

Also made the member functions take AtomicStringImpl* instead of plain StringImpl*.

  • runtime/JSObject.cpp:

(JSC::JSObject::getPropertyNames):

  • runtime/JSPropertyNameEnumerator.cpp:

(JSC::JSPropertyNameEnumerator::create):
(JSC::JSPropertyNameEnumerator::JSPropertyNameEnumerator):

  • runtime/JSPropertyNameEnumerator.h:
  • runtime/PropertyNameArray.cpp:

(JSC::PropertyNameArray::add):
(JSC::PropertyNameArray::setPreviouslyEnumeratedProperties): Deleted.

  • runtime/PropertyNameArray.h:

(JSC::PropertyNameArray::PropertyNameArray):
(JSC::PropertyNameArray::add):
(JSC::PropertyNameArray::addKnownUnique):
(JSC::PropertyNameArray::canAddKnownUniqueForStructure):
(JSC::RefCountedIdentifierSet::contains): Deleted.
(JSC::RefCountedIdentifierSet::size): Deleted.
(JSC::RefCountedIdentifierSet::add): Deleted.
(JSC::PropertyNameArray::identifierSet): Deleted.
(JSC::PropertyNameArray::numCacheableSlots): Deleted.
(JSC::PropertyNameArray::setNumCacheableSlotsForObject): Deleted.
(JSC::PropertyNameArray::setBaseObject): Deleted.
(JSC::PropertyNameArray::setPreviouslyEnumeratedLength): Deleted.

12:28 PM Changeset in webkit [184049] by Darin Adler
  • 2 edits in trunk/Source/WebCore

[Cocoa] Fix paths and resort WebCore project file
​https://bugs.webkit.org/show_bug.cgi?id=144838

Reviewed by Dan Bernstein.

  • WebCore.xcodeproj/project.pbxproj: Re-sorted this file with the

sort-Xcode-project-file script and fixed the paths in the platform/ios directory.

11:33 AM Changeset in webkit [184048] by youenn.fablet@crf.canon.fr
  • 3 edits in trunk/Source/WebCore

[Streams API] Refactor ReadableStreamReader close promise callback cleaning
​https://bugs.webkit.org/show_bug.cgi?id=144799

Reviewed by Darin Adler.

Moved close callback cleaning to releaseStream, which is now releaseStreamAndClean.
Moved that method to private as it is no longer needed by subclasses.

No behavior changes.

  • Modules/streams/ReadableStreamReader.cpp:

(WebCore::ReadableStreamReader::releaseStreamAndClean):
(WebCore::ReadableStreamReader::changeStateToClosed):
(WebCore::ReadableStreamReader::changeStateToErrored):

  • Modules/streams/ReadableStreamReader.h:
11:29 AM Changeset in webkit [184047] by Darin Adler
  • 10 edits
    1 add in trunk/Source

[Cocoa] Don't soft link DataDetectorsCore
​https://bugs.webkit.org/show_bug.cgi?id=144837

Reviewed by Dan Bernstein.

Source/WebCore:

Linking this in the normal way should slightly speed up the web process
startup time. We don't need to soft link it: It's present in the
OS X base system and there is no reference cycle with WebKit.

  • Configurations/WebCore.xcconfig: Added PrivateFrameworks to

FRAMEWORK_SEARCH_PATHS for Mac and added DataDetectorsCore to
OTHER_LDFLAGS_PLATFORM for Mac. We may want to do this later for iOS too.

  • WebCore.xcodeproj/project.pbxproj: Added DataDetectorsCoreSPI.h.
  • editing/mac/DataDetection.mm:

(WebCore::DataDetection::detectItemAroundHitTestResult): Removed check to see
if DataDetectorsCore is available.

  • page/mac/ServicesOverlayController.h: Simplified a forward declaration to

only declare what we actually use.

  • page/mac/ServicesOverlayController.mm: Moved SOFT_LINK from here to the

DataDetectorsSPI.h header.

  • platform/spi/cocoa/DataDetectorsCoreSPI.h: Added. This is the low level

DataDetectorsCore framework, which has no reference cycle with WebKit, and
which we can link to normally. Moved the content here from DataDetectorsSPI.h,
added a USE(APPLE_INTERNAL_SDK) path that uses the system headers, and fixed
the incorrect return type on DDScannerScanQuery, which was detected when
using the system headers in conjunction with this file.

  • platform/spi/mac/DataDetectorsSPI.h: Removed the content of this file that

was actually about DataDetectorsCore. Also added a USE(APPLE_INTERNAL_SDK)
path that uses the system headers and moved a few stray DataDetectors SPI
definitions from elsewhere into this header.

Source/WebKit2:

  • Platform/mac/MenuUtilities.mm: Use DataDetectorsSPI.h instead of doing it here.
  • WebProcess/WebPage/mac/WebPageMac.mm: Removed unneeded include of unused header,

DataDetectorsSPI.h.

7:52 AM Changeset in webkit [184046] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: Don't expose elements as data tables just because they use display: table
​https://bugs.webkit.org/show_bug.cgi?id=144804

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Elements will create RenderTable objects if they have display:table. We shouldn't assume these are accessibility tables.

Test: accessibility/css-table-ignored.html

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isDataTable):

LayoutTests:

  • accessibility/css-table-ignored-expected.txt: Added.
  • accessibility/css-table-ignored.html: Added.
5:23 AM Changeset in webkit [184045] by Nikita Vasilyev
  • 12 edits
    2 adds in trunk/Source/WebInspectorUI

Web Inspector: In the console, show function name next to the source link
​https://bugs.webkit.org/show_bug.cgi?id=144372

Introduce CallFrameView to display counsole message source links. It looks like this:

[f] functionName - filename.js:42

Reviewed by Timothy Hatcher.

  • UserInterface/Base/Main.js:

(WebInspector.createSourceCodeLocationLink):
(WebInspector.linkifyLocation):
(.showSourceCodeLocation):
(WebInspector.linkifyElement):
Abstract this out as it's used in WebInspector.CallFrameView and WebInspector.createSourceCodeLocationLink.

(WebInspector.sourceCodeForURL):
Move this code from Timeline to Main.js as it's used by Console too.

(WebInspector.linkifyURLAsNode):
Remove tooltipText argument as it is never used.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype._callFramesFromPayload):

  • UserInterface/Main.html:
  • UserInterface/Models/CallFrame.js:

(WebInspector.CallFrame.fromPayload):
Abstract this out as it's used in WebInspector.TimelineManager.prototype._callFramesFromPayload and
WebInspector.ConsoleMessageView._appendLocationLink.

(WebInspector.CallFrame):

  • UserInterface/Views/CallFrameTreeElement.js:

(WebInspector.CallFrameTreeElement):
Move it to WebInspector.CallFrameView.iconForCallFrame.

  • UserInterface/Views/CallFrameView.css: Added.

(.call-frame):
(.call-frame .icon):
(.call-frame .titles):
(.call-frame .title):
(.call-frame .source-link):
(.call-frame .title + .subtitle > .source-link):
(.call-frame .subtitle .source-link):
(.call-frame:focus .subtitle .source-link):
(.call-frame .subtitle:empty):
(.call-frame .subtitle):
(.call-frame .colon):
(.call-frame .title + .subtitle::before):

  • UserInterface/Views/CallFrameView.js: Added.

(WebInspector.CallFrameView):
(WebInspector.CallFrameView.iconClassNameForCallFrame):

  • UserInterface/Views/ConsoleMessageView.css:

(.console-message .console-message-location):
(.console-message .call-frame):
(.console-message .go-to-link):
(.console-message .go-to-link:focus):
(.console-message .console-message-url::before):
(.console-saved-variable): Deleted.

  • UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype._appendLocationLink):

  • UserInterface/Views/DebuggerDashboardView.js:
  • UserInterface/Views/Main.css:

(.hidden): Deleted.

  • UserInterface/Views/ProfileNodeTreeElement.js:

(WebInspector.ProfileNodeTreeElement):

  • UserInterface/Views/TimelineDataGridNode.js:

(WebInspector.TimelineDataGridNode.prototype.createCellContent):

May 9, 2015:

11:46 PM Changeset in webkit [184044] by rniwa@webkit.org
  • 6 edits in trunk/Tools

Make arguments of run-benchmark more user friendly
​https://bugs.webkit.org/show_bug.cgi?id=144835

Reviewed by Darin Adler.

Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
default values from --platform and --browser as they are required arguments.

  • Scripts/run-benchmark:

(main): Made --build-directory optional, and removed default values from --platform and --browser.
Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
are not dynamically obtained via BrowserDriverFactory.

  • Scripts/webkitpy/benchmark_runner/benchmark_runner.py:

(BenchmarkRunner.init): Raise when we can't find the plan file or the plan file is not a valid JSON
file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
run any benchmark in that case.
(BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
the specified file isn't a valid relative or an absolute path.

  • Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:

(BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
and browsers.
(BrowserDriverFactory.available_browsers): Ditto.

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:

(OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
calls launchUrl with this argument so removed the default value. Also added a fallback path for when
browserBuildPath was None.

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:

(OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
so that we can use locally built WebKit to launch Safari.

8:58 PM Changeset in webkit [184043] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

Deployment-target NSi_ and NSd_ definitions in WKFoundation.h are redundant
​https://bugs.webkit.org/show_bug.cgi?id=144831

Reviewed by Sam Weinig.

Reverted r182846 and r182904.

  • Shared/API/Cocoa/WKFoundation.h:
  • WebKit2.xcodeproj/project.pbxproj:
8:22 PM Changeset in webkit [184042] by Chris Dumez
  • 10 edits
    2 adds in trunk

Introduce ParentNode.idl / NonDocumentTypeChildNode.idl
​https://bugs.webkit.org/show_bug.cgi?id=144825

Reviewed by Sam Weinig.

Source/WebCore:

Introduce ParentNode.idl / NonDocumentTypeChildNode.idl as per DOM
specification and to avoid IDL code duplication:

No Web-Exposed behavior change.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/CharacterData.idl:
  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/Element.idl:
  • dom/NonDocumentTypeChildNode.idl: Copied from Source/WebCore/dom/DocumentFragment.idl.
  • dom/ParentNode.idl: Copied from Source/WebCore/dom/DocumentFragment.idl.

LayoutTests:

Rebaseline test as the order of the methods changed when iterating.

  • js/dom/dom-static-property-for-in-iteration-expected.txt:
10:37 AM Changeset in webkit [184041] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Invalidate the FontCache on WebProcess suspension / critical memory pressure
​https://bugs.webkit.org/show_bug.cgi?id=144821

Reviewed by Antti Koivisto.

Invalidate the FontCache on WebProcess suspension / critical memory
pressure to free a bit more memory (an extra 4-16Kb per WebProcess on
the pages I tested). We already purge inactive font data on
non-critical memory warning but invalidating the whole FontCache takes
care of clearing the FontCascade cache and the fontPlatformData cache
as well.

  • platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::releaseCriticalMemory):

1:39 AM Changeset in webkit [184040] by yoav@yoav.ws
  • 30 edits in trunk

Remove the PICTURE_SIZES build flag
​https://bugs.webkit.org/show_bug.cgi?id=144679

Reviewed by Benjamin Poulain.

Removed the PICTURE_SIZES build time flag.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsWindows.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests, since there's no functionality change.

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::detectAtToken):

  • css/CSSParser.h:
  • css/SourceSizeList.cpp:

(WebCore::parseSizesAttribute): Deleted.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::setBestFitURLAndDPRFromImageCandidate):

  • html/HTMLImageElement.h:

(WebCore::HTMLImageElement::currentSrc):

  • html/HTMLImageElement.idl:
  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

  • html/parser/HTMLSrcsetParser.cpp:

(WebCore::parseDescriptors):
(WebCore::pickBestImageCandidate):

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.props:
  • win/tools/vsprops/FeatureDefinesCairo.props:
1:20 AM Changeset in webkit [184039] by ddkilzer@apple.com
  • 3 edits in trunk/Tools

Layout tests broke due to unexpected simctl output

  • Scripts/webkitpy/xcode/simulator.py:

(Simulator._parse_devices): Handle new Device Pairs header.

  • Scripts/webkitpy/xcode/simulator_unittest.py:

(test_device_pairs): Add unit test for Device Pairs header.

Note: See TracTimeline for information about the timeline view.