Context Navigation

← Previous Period
Next Period →

Timeline

May 21, 2015:

11:57 PM Changeset in webkit [184760] by jer.noble@apple.com

9 edits in trunk/Source/WebCore

[iOS] Tell AVPlayerLayer when we enter optimized fullscreen mode.
https://bugs.webkit.org/show_bug.cgi?id=145289

Reviewed by Eric Carlson.

AVFoundation would normally already know that its AVPlayerLayer is in optimized
fullscreen mode, but because of the WebProcess/UIProcess split, they need to be
told explicitly in the WebProcess when the UIProcess enters optimized fullscreen
mode.

html/HTMLMediaElement.h:
html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::fullscreenModeChanged): Pass to private().

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::setVideoFullscreenMode): Pass to m_private.
(WebCore::MediaPlayer::fullscreenMode): Pass to m_client.

platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerFullscreenMode): Default implementation returns None.

platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::setVideoFullscreenMode): Default implementation is a no-op.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer): Get the fullscreen

mode from MediaPlayer and tell the AVPlayerLayer if the mode is optimized.

(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenMode):

Ditto.

platform/spi/mac/AVFoundationSPI.h:

11:36 PM Changeset in webkit [184759] by bshafiei@apple.com

15 edits in branches/safari-601.1.32.2-branch/Source

Merged r184740. rdar://problem/21068522

11:35 PM Changeset in webkit [184758] by bshafiei@apple.com

2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184739. rdar://problem/20892362

11:35 PM Changeset in webkit [184757] by bshafiei@apple.com

2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184738. rdar://problem/20830673

11:34 PM Changeset in webkit [184756] by bshafiei@apple.com

5 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184726. rdar://problem/21031414

11:32 PM Changeset in webkit [184755] by fpizlo@apple.com

4 edits
1 add in trunk/Source/JavaScriptCore

CPS rethreading should really get rid of GetLocals
https://bugs.webkit.org/show_bug.cgi?id=145290

Reviewed by Benjamin Poulain.

CPS rethreading is intended to get rid of redundant GetLocals. CSE can also do it, but
the idea is that you should be able to disable CSE and everything would still work. This
fixes a bug in CPS rethreading's GetLocal elimination: we should be calling replaceWith
rather than setReplacement, since setReplacement still leaves the original node.

dfg/DFGCPSRethreadingPhase.cpp:

(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor): Fix the bug.

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode): Eliminating GetLocals means that they turn into Check. We should handle Checks that have zero inputs.

dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validateCPS): Add a validation for what a GetLocal should look like in ThreadedCPS.

tests/stress/get-local-elimination.js: Added.

(foo):

11:12 PM Changeset in webkit [184754] by jdiggs@igalia.com

15 edits
3 adds in trunk

AX: [GTK] Implement computedRoleString in AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=128420

Reviewed by Chris Fleizach.

Source/WebCore:

Expose all ARIA roles (not just landmark-related roles) via an "xml-roles" AtkObject
attribute as per http://www.w3.org/TR/core-aam-1.1/#roleMappingGeneralRules

Expose non-empty computed role strings via AtkObject attribute named "computed-role".
Currently the computed role and the ARIA role value happen to be the same string, but
that might not always be the case. And AtkObject attributes are cheap.

Test: platform/gtk/accessibility/xml-roles-exposed.html.

accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

Tools:

WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::computedRoleString): Implemented.

LayoutTests:

platform/gtk/TestExpectations: Removed roles-computedRoleString from the failing test.
platform/gtk/accessibility/image-link-expected.txt: Updated to reflect the new object attribute.
platform/gtk/accessibility/image-map2-expected.txt: Updated to reflect the new object attribute.
platform/gtk/accessibility/lists-expected.txt: Updated to reflect the new object attribute.
platform/gtk/accessibility/roles-computedRoleString-expected.txt: Added.
platform/gtk/accessibility/table-attributes-expected.txt: Updated to reflect the new object attribute.
platform/gtk/accessibility/table-cell-spans-expected.txt: Updated to reflect the new object attribute.
platform/gtk/accessibility/table-cells-expected.txt: Updated to reflect the new object attribute.
platform/gtk/accessibility/table-detection-expected.txt: Updated to reflect the new object attribute.
platform/gtk/accessibility/table-sections-expected.txt: Updated to reflect the new object attribute.
platform/gtk/accessibility/table-with-rules-expected.txt: Updated to reflect the new object attribute.
platform/gtk/accessibility/xml-roles-exposed-expected.txt: Added.
platform/gtk/accessibility/xml-roles-exposed.html: Added.

10:46 PM Changeset in webkit [184753] by bshafiei@apple.com

5 edits in branches/safari-600.7-branch/Source

Versioning.

10:46 PM Changeset in webkit [184752] by bshafiei@apple.com

5 edits in branches/safari-601.1.32-branch/Source

Versioning.

10:46 PM Changeset in webkit [184751] by bshafiei@apple.com

5 edits in branches/safari-601.1.32.2-branch/Source

Versioning.

9:35 PM Changeset in webkit [184750] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Give Toolbar buttons an active style
https://bugs.webkit.org/show_bug.cgi?id=145292

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-21
Reviewed by Timothy Hatcher.

UserInterface/Views/ButtonToolbarItem.css:

(.toolbar .item.button:active):

8:59 PM Changeset in webkit [184749] by Antti Koivisto

8 edits
2 adds in trunk

MaskImageOperation code does not manage CachedImageClients correctly
https://bugs.webkit.org/show_bug.cgi?id=145276
Source/WebCore:

rdar://problem/20959822

Reviewed by Andreas Kling.

Test: css3/masking/mask-image-client-crash.html

platform/graphics/MaskImageOperation.cpp:

(WebCore::MaskImageOperation::isMaskLoaded):
(WebCore::MaskImageOperation::setImage):

If image changes transfer the clients to the new image.

(WebCore::MaskImageOperation::setRenderLayerImageClient):

Always use setImage.

(WebCore::MaskImageOperation::notifyFinished):

platform/graphics/MaskImageOperation.h:
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

rendering/RenderLayer.h:
rendering/RenderLayerMaskImageInfo.cpp:

(WebCore::RenderLayer::MaskImageInfo::~MaskImageInfo):
(WebCore::RenderLayer::MaskImageInfo::updateMaskImageClients):

Store the MaskImageOperations where we added clients.

(WebCore::RenderLayer::MaskImageInfo::removeMaskImageClients):

Make sure we remove the clients from the same MaskImageOperations we added them to.

rendering/RenderLayerMaskImageInfo.h:

LayoutTests:

Reviewed by Andreas Kling.

css3/masking/mask-image-client-crash-expected.txt: Added.
css3/masking/mask-image-client-crash.html: Added.

7:54 PM Changeset in webkit [184748] by Nikita Vasilyev

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Dashboard debugger information can be clipped
https://bugs.webkit.org/show_bug.cgi?id=144209

Reviewed by Timothy Hatcher.

UserInterface/Views/DashboardContainerView.css:

(.toolbar .dashboard-container):
Make dashboard flexible by using vw (viewport width units).

UserInterface/Views/DefaultDashboardView.css:

(.toolbar .dashboard.default):
Center default dashboard icons in the middle, don't spread them along the dashboard.

7:39 PM Changeset in webkit [184747] by saambarati1@gmail.com

10 edits
2 adds in trunk/Source/JavaScriptCore

Object allocation sinking phase should explicitly create bottom values for CreateActivation sink candidates and CreateActivation should have SymbolTable as a child node
https://bugs.webkit.org/show_bug.cgi?id=145192

Reviewed by Filip Pizlo.

When we sink CreateActivation and generate MaterializeCreateActivation
in the object allocation sinking phase, we now explictly add PutHints for
all variables on the activation setting those variables to their default value
(undefined for Function activations and soon to be JS Empty Value for block scope activations).
This allows us to remove code that fills FTL fast activation allocations with Undefined.

This patch also adds the constant SymbolTable as an OpInfo of CreateActivation and MaterializeCreateActivation
nodes. This is in preparation for ES6 block scoping which will introduce a new
op code that gets lowered to CreateActivation.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGNode.h:

(JSC::DFG::Node::hasCellOperand):
(JSC::DFG::Node::cellOperand):

dfg/DFGObjectAllocationSinkingPhase.cpp:

(JSC::DFG::ObjectAllocationSinkingPhase::lowerNonReadingOperationsOnPhantomAllocations):
(JSC::DFG::ObjectAllocationSinkingPhase::handleNode):
(JSC::DFG::ObjectAllocationSinkingPhase::createMaterialize):
(JSC::DFG::ObjectAllocationSinkingPhase::populateMaterialize):

dfg/DFGPromotedHeapLocation.cpp:

(WTF::printInternal):

dfg/DFGPromotedHeapLocation.h:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCreateActivation):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileCreateActivation):
(JSC::FTL::LowerDFGToLLVM::compileMaterializeCreateActivation):

ftl/FTLOperations.cpp:

(JSC::FTL::operationMaterializeObjectInOSR):

tests/stress/activation-sink-default-value.js: Added.

(bar):

tests/stress/activation-sink-osrexit-default-value.js: Added.

(foo.set result):

6:22 PM Changeset in webkit [184746] by bshafiei@apple.com

1 copy in tags/Safari-601.1.32.5

New tag.

6:15 PM Changeset in webkit [184745] by dbates@webkit.org

5 edits in trunk

Update Autofill button icon
https://bugs.webkit.org/show_bug.cgi?id=145191
<rdar://problem/20178942>

Reviewed by Jessie Berlin.

Source/WebCore:

css/html.css:

(input::-webkit-auto-fill-button):
(input::-webkit-auto-fill-button:active):
(input::-webkit-auto-fill-button:hover):

LayoutTests:

Update expected results.

fast/forms/input-auto-fill-button-expected.txt:
platform/mac-mavericks/fast/forms/input-auto-fill-button-expected.txt:

5:43 PM Changeset in webkit [184744] by bshafiei@apple.com

2 edits in tags/Safari-601.1.32.2.80/Source/WebKit2

Merged r184738. rdar://problem/20830673

5:41 PM Changeset in webkit [184743] by bshafiei@apple.com

5 edits in tags/Safari-601.1.32.2.80/Source

Versioning.

5:39 PM Changeset in webkit [184742] by bshafiei@apple.com

1 copy in tags/Safari-601.1.32.2.80

New tag.

5:35 PM Changeset in webkit [184741] by beidson@apple.com

12 edits
2 adds in trunk/Source

Add an "initiated by user gesture" flag to ResourceRequest.
https://bugs.webkit.org/show_bug.cgi?id=145281

Reviewed by Alex Christensen.

Source/WebCore:

Allow WebKit to tell WebCore what the new property key is:

platform/ios/WebCoreSystemInterfaceIOS.mm:
platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

Add the flag to ResourceRequest, and make sure it encodes/decodes:

platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::initiatedByUserGesture):
(WebCore::ResourceRequestBase::setInitiatedByUserGesture):
(WebCore::ResourceRequestBase::encodeWithoutPlatformData):
(WebCore::ResourceRequestBase::decodeWithoutPlatformData):

Set/get the property on native CFURLRequestRefs:

platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):

Set/get the property on native NSURLRequests:

platform/network/cocoa/ResourceRequestCocoa.mm:

(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):

Source/WebKit/mac:

WebCoreSupport/WebSystemInterface.mm:

(WKResourceRequestIsUserInitiatedKey):
(InitWebCoreSystemInterface):

Source/WebKit2:

Expose a new category on NSURLRequest to allow SPI clients to easily set/get the flag:

Shared/API/Cocoa/_WKNSURLRequestExtras.h: Added.
Shared/API/Cocoa/_WKNSURLRequestExtras.mm: Added.

(-[NSURLRequest _web_isUserInitiated]):
(-[NSMutableURLRequest _web_setIsUserInitiated:]):

WebKit2.xcodeproj/project.pbxproj:

Expose the new property key to WebCore:

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(WKResourceRequestIsUserInitiatedKey):
(InitWebCoreSystemInterface):

5:34 PM Changeset in webkit [184740] by dbates@webkit.org

15 edits in trunk/Source

Rollout <http://trac.webkit.org/changeset/183909>
(https://bugs.webkit.org/show_bug.cgi?id=144657)

Revert <http://trac.webkit.org/changeset/183909> since pausing the database
thread prevents in-progress transactions from completing. We need to think
about this change some more.

Source/WebCore:

Modules/webdatabase/AbstractDatabaseServer.h:
Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::setPauseAllDatabases): Deleted.

Modules/webdatabase/DatabaseManager.h:
Modules/webdatabase/DatabaseServer.cpp:

(WebCore::DatabaseServer::setPauseAllDatabases): Deleted.

Modules/webdatabase/DatabaseServer.h:

Source/WebKit2:

UIProcess/WebPageProxy.h:
UIProcess/ios/WKContentView.mm:

(-[WKContentView _applicationDidEnterBackground:]): Deleted.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::applicationDidEnterBackground): Deleted.

WebProcess/WebCoreSupport/WebDatabaseManager.cpp:

(WebKit::WebDatabaseManager::setPauseAllDatabases): Deleted.

WebProcess/WebCoreSupport/WebDatabaseManager.h:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::applicationWillEnterForeground): Deleted.
(WebKit::WebPage::applicationDidEnterBackground): Deleted.

5:31 PM Changeset in webkit [184739] by enrica@apple.com

2 edits in trunk/Source/WebKit2

[iOS] Crash when taking a snapshot of a large PDF.
https://bugs.webkit.org/show_bug.cgi?id=145286
rdar://problem/20892362

Reviewed by Tim Horton.

The code for the PDF case was incorrectly computing the snapshot rect.
On top of that drawViewHierarchyInRect was ignoring the rect and
always creating an image using the view bounds causing the crash.
We are now always using the IOSurface if we are parented or
an image context when we are not.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):

5:29 PM Changeset in webkit [184738] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Symlink the WebKit dylib instead of just the framework directory
https://bugs.webkit.org/show_bug.cgi?id=145287
rdar://problem/20830673

Reviewed by Dan Bernstein.

WebKit2.xcodeproj/project.pbxproj:

5:12 PM Changeset in webkit [184737] by bshafiei@apple.com

1 copy in tags/Safari-601.1.32.2.5

New tag.

4:33 PM Changeset in webkit [184736] by Joseph Pecoraro

10 edits
1 move
5 adds
3 deletes in trunk/Source/WebInspectorUI

Web Inspector: Improve the UI of the type profiler popover
https://bugs.webkit.org/show_bug.cgi?id=140737

Reviewed by Timothy Hatcher.

Display TypeDescriptions in a Tree similiar to ObjectTrees.
Currently the only information we have in a TypeDescription
is the property names, and not their types, so all we can
display in the tree are names.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Controllers/TypeTokenAnnotator.js:

(WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):

UserInterface/Main.html:
UserInterface/Models/ScriptSyntaxTree.js:

(WebInspector.ScriptSyntaxTree.prototype.updateTypes):

UserInterface/Models/StructureDescription.js: Added.

(WebInspector.StructureDescription):
(WebInspector.StructureDescription.fromPayload):
(WebInspector.StructureDescription.prototype.get fields):
(WebInspector.StructureDescription.prototype.get optionalFields):
(WebInspector.StructureDescription.prototype.get constructorName):
(WebInspector.StructureDescription.prototype.get prototypeStructure):
(WebInspector.StructureDescription.prototype.get imprecise):

UserInterface/Models/TypeDescription.js: Added.

(WebInspector.TypeDescription):
(WebInspector.TypeDescription.fromPayload):
(WebInspector.TypeDescription.prototype.get leastCommonAncestor):
(WebInspector.TypeDescription.prototype.get typeSet):
(WebInspector.TypeDescription.prototype.get structures):
(WebInspector.TypeDescription.prototype.get valid):
(WebInspector.TypeDescription.prototype.get truncated):

UserInterface/Models/TypeSet.js:

(WebInspector.TypeSet):
(WebInspector.TypeSet.prototype.get primitiveTypeNames):

UserInterface/Views/ObjectTreeView.js:

(WebInspector.ObjectTreeView.prototype._updateChildren):

UserInterface/Views/Section.css: Removed.
UserInterface/Views/Section.js: Removed.
UserInterface/Views/SourceCodeTextEditor.css:

(.popover .expandable):

UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor):
(WebInspector.SourceCodeTextEditor.prototype.showPopoverForTypes):
(WebInspector.SourceCodeTextEditor.prototype._populateWithScriptContent):
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler):
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation):
(WebInspector.SourceCodeTextEditor.prototype._showPopoverForObject):

UserInterface/Views/TypePropertiesSection.js: Removed.
UserInterface/Views/TypeTokenView.js:

(WebInspector.TypeTokenView):
(WebInspector.TypeTokenView.titleForPopover):
(WebInspector.TypeTokenView.prototype.update):
(WebInspector.TypeTokenView.prototype._setUpMouseoverHandlers):
(WebInspector.TypeTokenView.prototype._shouldShowPopover):
(WebInspector.TypeTokenView.prototype._displayTypeName):

UserInterface/Views/TypeTreeElement.css: Added.

(.type-tree-element):
(.type-tree-element > .titles):
(.type-tree-element > .disclosure-button):
(.type-tree-element.parent > .disclosure-button):
(.type-tree-element.parent.expanded > .disclosure-button):
(.type-tree-element > .icon):
(.type-tree-element.prototype):
(.type-tree-element.prototype:focus):
(.type-tree-element.prototype + ol):

UserInterface/Views/TypeTreeElement.js: Added.

(WebInspector.TypeTreeElement):
(WebInspector.TypeTreeElement.prototype.get name):
(WebInspector.TypeTreeElement.prototype.get isPrototype):
(WebInspector.TypeTreeElement.prototype.onpopulate):
(WebInspector.TypeTreeElement.prototype.onexpand):

UserInterface/Views/TypeTreeView.css: Renamed from Source/WebInspectorUI/UserInterface/Views/PropertiesSection.js.

(.type-tree):
(.type-tree-outline):
(.type-tree-outline li):
(.type-tree-outline ol):
(.type-tree-outline ol.expanded):
(.type-tree-outline li .empty-message):

UserInterface/Views/TypeTreeView.js: Added.

(WebInspector.TypeTreeView):
(WebInspector.TypeTreeView.prototype.get typeDescription):
(WebInspector.TypeTreeView.prototype.get element):
(WebInspector.TypeTreeView.prototype.get treeOutline):
(WebInspector.TypeTreeView.prototype._populate):

4:30 PM Changeset in webkit [184735] by bshafiei@apple.com

1 copy in tags/Safari-600.7.9

New tag.

3:45 PM Changeset in webkit [184734] by jacob_nielsen@apple.com

19 edits in trunk/Source/WebCore

r184718 and r184725 caused four tests to begin crashing

Unreviewed rollback.

Tests that started crashing:

svg/carto.net/textbox.svg svg/custom/tref-clone-crash.html svg/custom/use-animation-in-fill.html svg/custom/use-multiple-on-nested-disallowed-font.html

svg/SVGAnimateElementBase.cpp:

(WebCore::propertyTypesAreConsistent):

svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):

svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::executeAction):

svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::parseAttribute):

svg/SVGCursorElement.cpp:

(WebCore::SVGCursorElement::~SVGCursorElement):
(WebCore::SVGCursorElement::isSupportedAttribute):

svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::pauseAnimations):
(WebCore::SVGDocumentExtensions::unpauseAnimations):
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements):
(WebCore::SVGDocumentExtensions::isElementWithPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement):
(WebCore::SVGDocumentExtensions::rebuildElements):

svg/SVGElement.cpp:

(WebCore::populateAttributeNameToCSSPropertyIDMap):
(WebCore::populateAttributeNameToAnimatedPropertyTypeMap):
(WebCore::attributeNameToAnimatedPropertyTypeMap):
(WebCore::populateCSSPropertyWithSVGDOMNameToAnimatedPropertyTypeMap):
(WebCore::cssPropertyWithSVGDOMNameToAnimatedPropertyTypeMap):
(WebCore::hasLoadListener):

svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::registerLigaturesInGlyphCache):
(WebCore::SVGKerningMap::insert):
(WebCore::stringMatchesUnicodeRange):

svg/SVGPathByteStream.h:

(WebCore::SVGPathByteStream::begin):
(WebCore::SVGPathByteStream::end):
(WebCore::SVGPathByteStream::append):
(WebCore::SVGPathByteStream::clear):
(WebCore::SVGPathByteStream::isEmpty):

svg/SVGPathUtilities.cpp:

(WebCore::appendSVGPathByteStreamFromSVGPathSeg):

svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::updateAnimations):

svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::parseBeginOrEnd):
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):
(WebCore::SVGSMILElement::notifyDependentsIntervalChanged):
(WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):

svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::clearResultsRecursive):

svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::addBuiltinEffects):

svg/properties/SVGAnimatedProperty.cpp:

(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):

svg/properties/SVGListProperty.h:

(WebCore::SVGListProperty::detachListWrappersAndResize):

svg/properties/SVGPathSegListPropertyTearOff.cpp:

(WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles):

1:27 PM Changeset in webkit [184733] by bshafiei@apple.com

6 edits in branches/safari-601.1.32.2-branch/Source/WebCore

Merged r184728. rdar://problem/21051039

1:26 PM Changeset in webkit [184732] by bshafiei@apple.com

6 edits in branches/safari-601.1.32-branch/Source/WebCore

Merged r184728. rdar://problem/21051039

12:53 PM Changeset in webkit [184731] by bshafiei@apple.com

2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184514. rdar://problem/20368630

12:52 PM Changeset in webkit [184730] by bshafiei@apple.com

12 edits
1 copy in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184503. rdar://problem/20368630

12:51 PM Changeset in webkit [184729] by bshafiei@apple.com

17 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184370. rdar://problem/20368630

12:37 PM Changeset in webkit [184728] by Brent Fulgham

6 edits in trunk/Source/WebCore

Scroll-snap points needs to be updated during programmatic scrolls
https://bugs.webkit.org/show_bug.cgi?id=145216
<rdar://problem/21051039>

Reviewed by Dean Jackson.

Whenever we adjust the current scroll position, make sure we also update the current
active scroll snap offset index (if applicable).

platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation): Call the new 'updateActiveScrollSnapIndexForOffset'
method after moving to a new position.
(WebCore::ScrollAnimator::setCurrentPosition): Ditto.
(WebCore::ScrollAnimator::updateActiveScrollSnapIndexForOffset): New method. Asks the scroll controller to
identify the closest scroll snap offset index. If it finds something relevant, update the ScrollableArea state
to track these new values.

platform/ScrollAnimator.h:
platform/cocoa/ScrollController.h:

(WebCore::ScrollController::activeScrollSnapIndexDidChange):
(WebCore::ScrollController::setScrollSnapIndexDidChange):

platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::setNearestScrollSnapIndexForAxisAndOffset): Added. Find the closest relevant scroll snap offset
index for the given scroll offset, and update the internal scroll snap state to reflect it.
(WebCore::ScrollController::setActiveScrollSnapIndicesForOffset): Given the x and y offset for a scroll,
set the relevant scroll snap offset indices.

platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::immediateScrollTo): Call the new 'updateActiveScrollSnapIndexForOffset' method
after moving to a new position.
(WebCore::ScrollAnimatorMac::immediateScrollBy): Ditto.

12:12 PM Changeset in webkit [184727] by andersca@apple.com

2 edits in trunk/Source/WebKit2

WKWebsiteDataStore doesn't track and remove iOS Safari's offline application cache entries
https://bugs.webkit.org/show_bug.cgi?id=145279
rdar://problem/20657912

Reviewed by Dan Bernstein.

Special-case iOS Safari and WebApp when computing the default application cache directory.

UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm:

(API::applicationCacheDirectory):
(API::WebsiteDataStore::defaultDataStoreConfiguration):

11:54 AM Changeset in webkit [184726] by bweinstein@apple.com

5 edits in trunk/Source/WebKit2

Add a _WKWebKitContentExtensionStore initializer that takes a path.
https://bugs.webkit.org/show_bug.cgi?id=145269 and work towards <rdar://problem/21031414>

Reviewed by Anders Carlsson.

UIProcess/API/APIUserContentExtensionStore.cpp:

(API::UserContentExtensionStore::storeWithPath):

UIProcess/API/APIUserContentExtensionStore.h:
UIProcess/API/Cocoa/_WKUserContentExtensionStore.h:
UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:

(+[_WKUserContentExtensionStore storeWithURL:]):

11:32 AM Changeset in webkit [184725] by Matt Baker

2 edits in trunk/Source/WebCore

Unreviewed build fix.

svg/SVGAnimateElementBase.cpp:

(WebCore::propertyTypesAreConsistent): should be type.properties, not type.properties().

11:24 AM Changeset in webkit [184724] by bshafiei@apple.com

6 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184716.

11:08 AM Changeset in webkit [184723] by youenn.fablet@crf.canon.fr

4 edits in trunk/Source/WebCore

[Streams API] Remove ReadableStreamReader closed promise internal slot
https://bugs.webkit.org/show_bug.cgi?id=145215

Reviewed by Darin Adler.

Using the new JSPromiseDeferred member generated by binding generator to handle closed promise attribute.
Removed internal slots routines previously used to ensure persistency of the promise.

Existing tests cover the changes.

bindings/js/JSReadableStreamReaderCustom.cpp:

(WebCore::JSReadableStreamReader::closed):
(WebCore::JSReadableStreamReader::cancel): Deleted.
(WebCore::JSReadableStreamReader::releaseLock): Deleted.

bindings/js/ReadableJSStream.cpp:

(WebCore::getPropertyFromObject): Deleted.
(WebCore::callFunction): Deleted.
(WebCore::ReadableJSStream::Source::create): Deleted.
(WebCore::ReadableJSStream::Source::Source): Deleted.

bindings/js/ReadableJSStream.h:

10:52 AM Changeset in webkit [184722] by roger_fong@apple.com

3 edits in trunk/Source/WebCore

Media Controls stop updating after hovering for a few seconds.
https://bugs.webkit.org/show_bug.cgi?id=144770.
<rdar://problem/19823121>

Reviewed by Jer Noble.

Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.createBase):
We should never hide controls immediately as a result of mousing out of the controls.
It should only happen when the mouse leaves the video entirely.
(Controller.prototype.updateTimelineMetricsIfNeeded):
Don’t update if controls are hidden, timeline dimensions will be 0.
(Controller.prototype.handlePanelTransitionEnd):
Instead of adjusting visibility via adding and removing classes,
remove controls entirely from the tree.
(Controller.prototype.showControls):
Add controls back into the tree when showing controls.
(Controller.prototype.updateForShowingControls):
Helper method for showControls.
(Controller.prototype.controlsAreHidden):
Controls also hidden if removed from tree.

Remove forceUpdate logic, no longer necessary.
(Controller.prototype.handleDurationChange):
(Controller.prototype.updateProgress):
(Controller.prototype.updateTime):

Override methods to use add and remove panelContainer for iOS.

Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.handlePanelTransitionEnd):
(ControllerIOS.prototype.showControls):
(ControllerIOS.prototype.controlsAreHidden):

10:45 AM Changeset in webkit [184721] by Chris Fleizach

4 edits in trunk/LayoutTests

AX: improve list heuristics (presentational use versus actual lists)
https://bugs.webkit.org/show_bug.cgi?id=134187

Unreviewed layout test fixage.

Skip the list-detection2.html test on GTK until it can be investigated.

https://bugs.webkit.org/show_bug.cgi?id=145273

Fix a failing test on GTK that needed an update after the last set of changes.
Skip the test on windows until a time someone can decide if we even expose or need lists in Windows AX API.

https://bugs.webkit.org/show_bug.cgi?id=145271

platform/gtk/TestExpectations:
platform/gtk/accessibility/list-detection-expected.txt:
platform/win/TestExpectations:

10:45 AM Changeset in webkit [184720] by Chris Dumez

2 edits in trunk/Source/WebCore

Regression(r179293): We no longer call destroyDecodedData() on CachedResources on memory pressure
https://bugs.webkit.org/show_bug.cgi?id=145270
<rdar://problem/20734901>

Reviewed by Andreas Kling.

We no longer call destroyDecodedData() on CachedResources on memory
pressure after r179293. In r179293, we started calling
MemoryCache::evictResources() on memory pressure instead of
MemoryCache::pruneToPercentage(0). However, unlike
MemoryCache::pruneToPercentage(), it appears
MemoryCache::evictResources() removes the CachedResources from the
memory cache without calling destroyDecodedData() on them.
This caused a regression on Membuster.

This patch now calls MemoryCache::pruneLiveResourcesToSize(0) on
critical memory pressure, instead of evictResources(). We don't need to
call pruneDeadResourcesToSize(0) here because the non-critical memory
pressure handler already takes care of this.

During local testing, this change seemed to decrease the overall memory
usage of WebProcesses by ~10MB on Membuster (tested on Yosemite).

platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::releaseNoncriticalMemory):
(WebCore::MemoryPressureHandler::releaseCriticalMemory):

10:36 AM Changeset in webkit [184719] by commit-queue@webkit.org

3 edits
2 adds in trunk

SVG as image uses very tiny default font-size
https://bugs.webkit.org/show_bug.cgi?id=68090

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-05-21
Reviewed by Darin Adler.

Source/WebCore:

When loading a document, WebKit creates a Page object and then changes its setting
from the browser's preferences. This is true for interactive resources also, such as a
stand-alone SVG or an SVG embedded in an <object> tag for example. For non-interactive
resources, like an SVG embedded in an <img> tag for example, this function is called
after loading the resource is finished. This function creates an artificial page and
fabricates a scoped settings for it. This turns out to be problematic for cases like
the default font size because its initial value is zero. We cannot go from WebCore to
WebKit to ask for the global settings. But we can inherit the global settings from the
the master page. This is not the best solution because of two reasons. (1) Once the
resource is cached and the styles for the text elements are calculated, nothing can
change the values of styles except removing the resource itself from the cache if the
browser's preferences change. Also there is no mechanism to notify this artificial
page if the browser's preferences change. (2) An image like a non-interactive SVG,
should be displayed the same way regardless of the browser's preferences. A user may
be able to change the default font size for other text. But this should not affect
images even if they are vector images like SVG. An easy and more agreeable solution
is to hard-code the default font size for this case and do not depend on the global
settings at all.

Test: svg/text/text-default-font-size.html

page/Settings.in: Set the initial value of the setting defaultFontSize to be 16.

LayoutTests:

svg/text/text-default-font-size-expected.html: Added.
svg/text/text-default-font-size.html: Added.

Ensure the default font size for non-interactive SVG images is not zero.

10:34 AM Changeset in webkit [184718] by commit-queue@webkit.org

19 edits in trunk/Source/WebCore

Use modern for-loops in WebCore/svg.
https://bugs.webkit.org/show_bug.cgi?id=145209

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-05-21
Reviewed by Darin Adler.

No new tests, no new tests.

svg/SVGAnimateElementBase.cpp:

(WebCore::propertyTypesAreConsistent):

svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):

svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::executeAction):

svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::parseAttribute):

svg/SVGCursorElement.cpp:

(WebCore::SVGCursorElement::~SVGCursorElement):

svg/SVGDocumentExtensions.cpp:

svg/SVGElement.cpp:

(WebCore::populateAttributeNameToCSSPropertyIDMap):
(WebCore::populateAttributeNameToAnimatedPropertyTypeMap):
(WebCore::populateCSSPropertyWithSVGDOMNameToAnimatedPropertyTypeMap):
(WebCore::hasLoadListener):

svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::registerLigaturesInGlyphCache):
(WebCore::SVGKerningMap::insert):
(WebCore::stringMatchesUnicodeRange):

svg/SVGPathByteStream.h:

(WebCore::SVGPathByteStream::append):

svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::updateAnimations):

svg/animation/SVGSMILElement.cpp:

svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::clearResultsRecursive):

svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::addBuiltinEffects):

svg/properties/SVGAnimatedProperty.cpp:

(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):

svg/properties/SVGListProperty.h:

(WebCore::SVGListProperty::detachListWrappersAndResize):

svg/properties/SVGPathSegListPropertyTearOff.cpp:

(WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles):

10:27 AM Changeset in webkit [184717] by peavo@outlook.com

2 edits in trunk/Source/JavaScriptCore

MSVC internal compiler error when compiling TemplateRegistryKey class.
https://bugs.webkit.org/show_bug.cgi?id=145259

Reviewed by Alex Christensen.

MSVC is not able to handle the brace initialization of a class member in this case.

runtime/TemplateRegistryKey.h:

10:10 AM Changeset in webkit [184716] by ap@apple.com

6 edits in trunk/Source/WebKit2

Build fix. Silence some deprecation warnings.

UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _presentPopoverWithContentViewController:animated:]):

UIProcess/ios/forms/WKFormInputControl.mm:

(-[WKDateTimePopover initWithView:datePickerMode:]):

UIProcess/ios/forms/WKFormPopover.h:
UIProcess/ios/forms/WKFormPopover.mm:
UIProcess/ios/forms/WKFormSelectPopover.mm:

(-[WKSelectPopover initWithView:hasGroups:]):

8:49 AM Changeset in webkit [184715] by youenn.fablet@crf.canon.fr

2 edits in trunk/LayoutTests

streams/reference-implementation/readable-stream.html should now pass
https://bugs.webkit.org/show_bug.cgi?id=145266

Unreviewed.

TestExpectations: removing falky expectation of streams/reference-implementation/readable-stream.html.

8:24 AM Changeset in webkit [184714] by bshafiei@apple.com

5 edits
2 copies in branches/safari-601.1.32.2-branch

Merged r184308. rdar://problem/20895753

5:29 AM Changeset in webkit [184713] by Csaba Osztrogonác

4 edits in trunk/Source/JavaScriptCore

Fix the !ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) build after r184337
https://bugs.webkit.org/show_bug.cgi?id=145248

Reviewed by Yusuke Suzuki.

bytecompiler/BytecodeGenerator.cpp:
bytecompiler/BytecodeGenerator.h:
parser/Parser.cpp:

(JSC::Parser<LexerType>::parseMemberExpression):

5:28 AM Changeset in webkit [184712] by Csaba Osztrogonác

2 edits
2 deletes in trunk/Tools

[EFL] Bump libsoup version to 2.50.0
https://bugs.webkit.org/show_bug.cgi?id=145127

Reviewed by Gyuyoung Kim.

efl/jhbuild.modules:
efl/patches/soup-clang-warning-fix1.patch: Removed.
efl/patches/soup-clang-warning-fix2.patch: Removed.

5:02 AM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com

(diff)

3:51 AM Changeset in webkit [184711] by Csaba Osztrogonác

3 edits in trunk/Source/WebKit2

[EFL] Remove an unused private field from EwkPopupMenuItem class
https://bugs.webkit.org/show_bug.cgi?id=145249

Reviewed by Gyuyoung Kim.

UIProcess/API/efl/ewk_popup_menu.cpp:

(EwkPopupMenu::EwkPopupMenu):

UIProcess/API/efl/ewk_popup_menu_private.h:

2:27 AM Changeset in webkit [184710] by Csaba Osztrogonác

32 edits in trunk/Source/WebKit2

[EFL] Fix mismatched-tags warnings in UIProcess/API/efl
https://bugs.webkit.org/show_bug.cgi?id=145129

Reviewed by Gyuyoung Kim.

UIProcess/API/efl/EwkViewCallbacks.h:
UIProcess/API/efl/ewk_application_cache_manager.h:
UIProcess/API/efl/ewk_auth_request.h:
UIProcess/API/efl/ewk_back_forward_list.h:
UIProcess/API/efl/ewk_back_forward_list_item.h:
UIProcess/API/efl/ewk_color_picker.h:
UIProcess/API/efl/ewk_context.h:
UIProcess/API/efl/ewk_context_menu_item.h:
UIProcess/API/efl/ewk_cookie_manager.h:
UIProcess/API/efl/ewk_database_manager.h:
UIProcess/API/efl/ewk_download_job.h:
UIProcess/API/efl/ewk_error.h:
UIProcess/API/efl/ewk_favicon_database.h:
UIProcess/API/efl/ewk_file_chooser_request.h:
UIProcess/API/efl/ewk_form_submission_request.h:
UIProcess/API/efl/ewk_navigation_data.h:
UIProcess/API/efl/ewk_navigation_policy_decision.h:
UIProcess/API/efl/ewk_object.h:
UIProcess/API/efl/ewk_page_group.h:
UIProcess/API/efl/ewk_popup_menu.h:
UIProcess/API/efl/ewk_popup_menu_item.h:
UIProcess/API/efl/ewk_security_origin.h:
UIProcess/API/efl/ewk_settings.h:
UIProcess/API/efl/ewk_storage_manager.h:
UIProcess/API/efl/ewk_url_request.h:
UIProcess/API/efl/ewk_url_response.h:
UIProcess/API/efl/ewk_url_scheme_request.h:
UIProcess/API/efl/ewk_view.h:
UIProcess/API/efl/ewk_window_features.h:
WebProcess/InjectedBundle/API/efl/ewk_extension.h:
WebProcess/InjectedBundle/API/efl/ewk_page.h:

2:23 AM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com

(diff)

12:26 AM Changeset in webkit [184709] by Gyuyoung Kim

47 edits in trunk/Source/WebCore

Purge PassRefPtr in WebCore/Modules
https://bugs.webkit.org/show_bug.cgi?id=145112

Reviewed by Darin Adler.

As a step to remove PassRefPtr, this patch replaces PassRefPtr with Ref or RefPtr
depends on null of return value.

No new tests, no behavior changes.

Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::create):

Modules/encryptedmedia/MediaKeySession.h:
Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::create):
(WebCore::MediaKeys::createSession):

Modules/encryptedmedia/MediaKeys.h:
Modules/gamepad/Gamepad.h:
Modules/gamepad/NavigatorGamepad.cpp:

(WebCore::NavigatorGamepad::gamepadFromPlatformGamepad):

Modules/gamepad/deprecated/Gamepad.h:
Modules/geolocation/GeolocationError.h:

(WebCore::GeolocationError::create):

Modules/geolocation/GeolocationPosition.h:

(WebCore::GeolocationPosition::create):

Modules/geolocation/Geoposition.h:

(WebCore::Geoposition::create):

Modules/geolocation/PositionError.h:

(WebCore::PositionError::create):

Modules/geolocation/PositionOptions.h:

(WebCore::PositionOptions::create):

Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::create):

Modules/mediacontrols/MediaControlsHost.h:
Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::create):

Modules/mediasource/MediaSource.h:
Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::create):

Modules/mediastream/RTCDataChannel.h:
Modules/mediastream/RTCIceCandidate.cpp:

(WebCore::RTCIceCandidate::create):

Modules/mediastream/RTCIceCandidate.h:
Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::create):

Modules/webaudio/OfflineAudioContext.h:
Modules/webaudio/OfflineAudioDestinationNode.h:

(WebCore::OfflineAudioDestinationNode::create):

Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::create):

Modules/webaudio/OscillatorNode.h:
Modules/webdatabase/Database.cpp:

(WebCore::Database::runTransaction):

Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::originLockFor):

Modules/webdatabase/DatabaseTracker.h:
Modules/webdatabase/SQLError.h:

(WebCore::SQLError::create):

Modules/webdatabase/SQLResultSet.h:

(WebCore::SQLResultSet::create):

Modules/webdatabase/SQLResultSetRowList.h:

(WebCore::SQLResultSetRowList::create):

Modules/webdatabase/SQLStatementBackend.cpp:

(WebCore::SQLStatementBackend::create):

Modules/webdatabase/SQLStatementBackend.h:
Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::create):

Modules/webdatabase/SQLTransactionBackend.h:
Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::create):

Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::create):

Modules/websockets/WebSocket.h:
Modules/websockets/WebSocketChannel.h:

(WebCore::WebSocketChannel::create):

Modules/websockets/WorkerThreadableWebSocketChannel.h:

(WebCore::WorkerThreadableWebSocketChannel::create):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::create):

editing/InsertListCommand.h:

(WebCore::InsertListCommand::create):

workers/Worker.cpp:

(WebCore::Worker::create):

workers/Worker.h:
xml/XPathExpression.cpp:

(WebCore::XPathExpression::createExpression):
(WebCore::XPathExpression::evaluate):

xml/XPathExpression.h:

12:26 AM Changeset in webkit [184708] by Csaba Osztrogonác

4 edits in trunk/Source/WebKit2

Fix mismatched-tags warnings related to CoordinatedGraphics
https://bugs.webkit.org/show_bug.cgi?id=145130

Reviewed by Darin Adler.

Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:

May 20, 2015:

11:39 PM Changeset in webkit [184707] by matthew_hanson@apple.com

5 edits in branches/safari-601.1.32.2-branch/Source/WebCore

Merge r184654. rdar://problem/21044514

11:39 PM Changeset in webkit [184706] by matthew_hanson@apple.com

4 edits in branches/safari-601.1.32.2-branch/Source/JavaScriptCore

Merge r184652. rdar://problem/21002666

11:39 PM Changeset in webkit [184705] by matthew_hanson@apple.com

2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merge r184679. rdar://problem/20990162

11:39 PM Changeset in webkit [184704] by matthew_hanson@apple.com

5 edits in branches/safari-601.1.32.2-branch/Source

Merge r184681. rdar://problem/20924495

10:55 PM Changeset in webkit [184703] by zandobersek@gmail.com

4 edits
6 adds
2 deletes in trunk

[GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
https://bugs.webkit.org/show_bug.cgi?id=145117

Reviewed by Csaba Osztrogonác.

Source/WTF:

Move the MainThreadGtk, RunLoopGtk and WorkQueueGtk implementation files from
Source/WTF/wtf/gtk/ to Source/WTF/wtf/glib/. These implementations are not
GTK-specific and only depend on GLib, so they are renamed as well.

There are other such implementations under Source/WTF/wtf/gobject/ (GObject
is just a subset of GLib) that will be moved under the new directory in
future patches.

wtf/PlatformGTK.cmake:
wtf/glib/MainThreadGLib.cpp: Renamed from Source/WTF/wtf/gtk/MainThreadGtk.cpp.

(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):

wtf/glib/RunLoopGLib.cpp: Renamed from Source/WTF/wtf/gtk/RunLoopGtk.cpp.

(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

wtf/glib/WorkQueueGLib.cpp: Renamed from Source/WTF/wtf/gtk/WorkQueueGtk.cpp.

(WTF::WorkQueue::platformInitialize):
(WTF::WorkQueue::platformInvalidate):
(WTF::WorkQueue::registerSocketEventHandler):
(WTF::WorkQueue::unregisterSocketEventHandler):
(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):

Tools:

Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
Tools/TestWebKitAPI/Tests/WTF/glib/.

TestWebKitAPI/PlatformGTK.cmake:
TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.

(TestWebKitAPI::TEST):

10:52 PM Changeset in webkit [184702] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Unreviewed, rolling out r184667 and r184682.
https://bugs.webkit.org/show_bug.cgi?id=145245

Broke media/media-controls-timeline-updates.html on WebKit2
(Requested by ap on #webkit).

Reverted changesets:

"Media Controls stop updating after hovering for a few
seconds."
https://bugs.webkit.org/show_bug.cgi?id=144770
http://trac.webkit.org/changeset/184667

"Unreviewed. Media Controls stop updating after hovering for a
few seconds."
https://bugs.webkit.org/show_bug.cgi?id=144770
http://trac.webkit.org/changeset/184682

10:16 PM Changeset in webkit [184701] by matthew_hanson@apple.com

4 edits in branches/safari-601.1.32-branch/Source/JavaScriptCore

Merge r184652. rdar://problem/21002666

10:16 PM Changeset in webkit [184700] by jonlee@apple.com

7 edits in trunk/Source/WebCore

[iOS] Update optimized fullscreen controls artwork
https://bugs.webkit.org/show_bug.cgi?id=145208
rdar://problem/21034032

Reviewed by Jer Noble.

Update the artwork when media goes into optimized fullscreen. Add a new UI part
representing return-from-optimized.

Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::mediaUIImageData): Return data for the return button.

Modules/mediacontrols/MediaControlsHost.idl: Add a new part ID.
Modules/mediacontrols/mediaControlsApple.js: Add a new ClassName to apply to the

button when in the proper state.

Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.handlePresentationModeChange): Add the ClassName when the
video goes into optimized fullscreen mode. Remove it otherwise.

platform/ios/WebCoreSystemInterfaceIOS.h:
rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::mediaControlsStyleSheet): Add the return button data to the
stylesheet.

10:13 PM Changeset in webkit [184699] by commit-queue@webkit.org

4 edits in trunk

Web Inspector: array previews should have a much smaller cap on values
https://bugs.webkit.org/show_bug.cgi?id=145195

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-20
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

inspector/InjectedScriptSource.js:

(InjectedScript.RemoteObject.prototype._generatePreview):
Reduce the indexes threshold for previews.

LayoutTests:

inspector/model/remote-object-expected.txt:

Update expected results now that array previews include
a smaller number of items.

10:12 PM Changeset in webkit [184698] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix WebInspector.StackTrace style
https://bugs.webkit.org/show_bug.cgi?id=145240

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-20
Reviewed by Timothy Hatcher.

UserInterface/Models/StackTrace.js:

Reorder and add our usual marker comments.

10:12 PM Changeset in webkit [184697] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

Web Inspector: Use native Arguments detection instead of using toString
https://bugs.webkit.org/show_bug.cgi?id=145235

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-20
Reviewed by Timothy Hatcher.

inspector/InjectedScriptSource.js:

(InjectedScript.prototype._subtype):
Deleted the old string code.

inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::subtype):
Replaced with a stricter, more accurate check.

9:48 PM Changeset in webkit [184696] by Gyuyoung Kim

2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix since r184686.

Patch by Gyuyoung Kim <Gyuyoung Kim> on 2015-05-20

UIProcess/gtk/WebProcessPoolGtk.cpp:

(WebKit::WebProcessPool::legacyPlatformDefaultApplicationCacheDirectory): Add *legacy* prefix.
(WebKit::WebProcessPool::platformDefaultApplicationCacheDirectory): Deleted.

8:17 PM Changeset in webkit [184695] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Build fix after r184591.

public/v2/manifest.js:

8:09 PM Changeset in webkit [184694] by Gyuyoung Kim

2 edits in trunk/Source/WebKit2

Unreviewed EFL build fix since r184686.

Patch by Gyuyoung Kim <Gyuyoung Kim> on 2015-05-20

UIProcess/efl/WebProcessPoolEfl.cpp:

(WebKit::WebProcessPool::legacyPlatformDefaultApplicationCacheDirectory): Add *legacy* prefix.
(WebKit::WebProcessPool::platformDefaultApplicationCacheDirectory): Deleted.

8:06 PM Changeset in webkit [184693] by Chris Dumez

2 edits in trunk/Source/WebKit2

[WK2][iOS] Update WebContent process sandbox profile for AWD logging
https://bugs.webkit.org/show_bug.cgi?id=145229
<rdar://problem/20543269>

Reviewed by Alexey Proskuryakov.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

7:36 PM Changeset in webkit [184692] by barraclough@apple.com

2 edits in trunk/Source/WebKit2

dispatchViewStateChange should not wait for sync reply if the page isn't visible
https://bugs.webkit.org/show_bug.cgi?id=145242
<rdar://problem/20967937>

Reviewed by Ben Poulain.

This is particularly problematic on iOS, since if the page isn't visible the process is likely suspended.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dispatchViewStateChange):
(WebKit::WebPageProxy::waitForDidUpdateViewState):

7:33 PM Changeset in webkit [184691] by hyuki.kim@samsung.com

2 edits in trunk/Tools

[EFL] fix efreet error
https://bugs.webkit.org/show_bug.cgi?id=143670

Reviewed by Gyuyoung Kim.

Fix efreet error by using external variable efreet_cache_update.
As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
efreet error for efreet_cache does not occur.

MiniBrowser/efl/main.c:

(elm_main):

7:09 PM Changeset in webkit [184690] by commit-queue@webkit.org

7 edits
2 adds in trunk

Enable disk cache for range requests
https://bugs.webkit.org/show_bug.cgi?id=144682

Patch by Marcos Chavarría Teijeiro <mchavarria@igalia.com> on 2015-05-20
Reviewed by Antti Koivisto.

Source/WebKit2:

Add Range header value to the network cache key constructor so we take
into account this value. The 206 response code is also marked to be cached.

NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::makeCacheKey):
(WebKit::NetworkCache::isStatusCodeCacheableByDefault):

NetworkProcess/cache/NetworkCacheKey.cpp:

(WebKit::NetworkCache::Key::Key):
(WebKit::NetworkCache::Key::operator=):
(WebKit::NetworkCache::Key::computeHash):
(WebKit::NetworkCache::Key::operator==):
(WebKit::NetworkCache::Key::encode):
(WebKit::NetworkCache::Key::decode):
(WebKit::NetworkCache::Key::stringToHash): Deleted.

NetworkProcess/cache/NetworkCacheKey.h:

LayoutTests:

http/tests/cache/disk-cache/disk-cache-range-expected.txt: Added. Add Test.
http/tests/cache/disk-cache/disk-cache-range.html: Added.
http/tests/cache/disk-cache/resources/generate-response.cgi: Modify script to return 206 and 416 response codes if Range header is present.
platform/gtk/TestExpectations: Remove failing test.

6:37 PM Changeset in webkit [184689] by bshafiei@apple.com

5 edits in branches/safari-601.1.32-branch/Source

Versioning.

6:37 PM Changeset in webkit [184688] by bshafiei@apple.com

5 edits in branches/safari-600.1.4.16-branch/Source

Versioning.

6:37 PM Changeset in webkit [184687] by bshafiei@apple.com

5 edits in branches/safari-601.1.32.2-branch/Source

Versioning.

6:30 PM Changeset in webkit [184686] by andersca@apple.com

4 edits in trunk/Source/WebKit2

WKWebsiteDataStore API doesn't report webkit.org as using Databases or App Cache after visiting http://www.webkit.org/demos/sticky-notes/
https://bugs.webkit.org/show_bug.cgi?id=145238
rdar://problem/20581175

Reviewed by Tim Horton.

Make sure to set the application cache and WebSQL directories when using the legacy data store.

UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::legacyPlatformDefaultApplicationCacheDirectory):
(WebKit::WebProcessPool::platformDefaultApplicationCacheDirectory):
Rename this and move it to the right place.

UIProcess/WebProcessPool.cpp:

(WebKit::legacyWebsiteDataStoreConfiguration):
Rename this and add the application cache and WebSQL directories.

(WebKit::WebProcessPool::WebProcessPool):
Call legacyWebsiteDataStoreConfiguration.

(WebKit::WebProcessPool::applicationCacheDirectory):
Call legacyPlatformDefaultApplicationCacheDirectory.

UIProcess/WebProcessPool.h:

6:28 PM Changeset in webkit [184685] by dino@apple.com

2 edits in trunk/Source/WebCore

Label text for default buttons don’t have the correct white color
https://bugs.webkit.org/show_bug.cgi?id=145221
<rdar://problem/20985817>

Follow-up commit. After discussion with the AppKit team, we've
concluded that a solid white is the color that best matches
the system.

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor): Use Color::white.

6:15 PM Changeset in webkit [184684] by achristensen@apple.com

2 edits in trunk/Source/WebCore

[ContentExtensions] Properly initialize ActionKey.state
https://bugs.webkit.org/show_bug.cgi?id=145237
rdar://problem/20716683

Reviewed by Benjamin Poulain.

contentextensions/DFAMinimizer.cpp:

Initialize ActionKey.state to Valid if it is a valid ActionKey.
Inlining can now be done safely.

6:14 PM Changeset in webkit [184683] by msaboff@apple.com

2 edits in trunk/Tools

Add option to run_jsc_stress_tests to disable JIT testing
https://bugs.webkit.org/show_bug.cgi?id=145233

Reviewed by Mark Lam.

Added --no-jit option.

Scripts/run-jsc-stress-tests:

5:58 PM Changeset in webkit [184682] by roger_fong@apple.com

2 edits in trunk/Source/WebCore

Unreviewed. Media Controls stop updating after hovering for a few seconds.
https://bugs.webkit.org/show_bug.cgi?id=144770.
<rdar://problem/19823121>

Followup to r184667.

Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.showControls):
Only put controls back into the tree if they don’t yet exist in the tree.
Otherwise we interrupt operations like scrubbing.

5:52 PM Changeset in webkit [184681] by enrica@apple.com

5 edits in trunk/Source

[iOS] Using CSS viewport units causes incorrect layout.
https://bugs.webkit.org/show_bug.cgi?id=145225
rdar://problem/20924495

Reviewed by Benjamin Poulain.

Source/WebCore:

page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::initialScaleFromSize):
(WebCore::ViewportConfiguration::initialScale):
(WebCore::ViewportConfiguration::initialScaleIgnoringContentSize):

page/ViewportConfiguration.h:

(WebCore::ViewportConfiguration::initialScaleFromSize):
(WebCore::ViewportConfiguration::initialScaleIgnoringContentSize):

Source/WebKit2:

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateViewportSizeForCSSViewportUnits):

5:51 PM Changeset in webkit [184680] by andersca@apple.com

2 edits in trunk/Source/WebKit/mac

Fix build.

WebView/WebViewInternal.h:

5:14 PM Changeset in webkit [184679] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Allow overriding the waitForDidUpdateViewState timeout
https://bugs.webkit.org/show_bug.cgi?id=145230
<rdar://problem/20990162>

Reviewed by Darin Adler.

UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateViewState):
Use the value from NSUserDefaults, if it exists.
We'll only check once, so changing the default requires a restart of the UI process.

5:11 PM Changeset in webkit [184678] by achristensen@apple.com

2 edits in trunk/Source/WebKit/mac

Unreviewed build fix; LocalizedStrings.h is in WebCore.

WebView/WebActionMenuController.mm:

5:10 PM Changeset in webkit [184677] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Make sure we always have a process pool to perform data store operations with
https://bugs.webkit.org/show_bug.cgi?id=145231
rdar://problem/20618248

Reviewed by Tim Horton.

Make sure that we always return a process pool. If we're a legacy C SPI per-context data store,
find the process pool we're a part of and use that. Otherwise, create a new one.

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::processPools):

4:42 PM Changeset in webkit [184676] by Chris Fleizach

6 edits
2 adds in trunk

AX: improve list heuristics (presentational use versus actual lists)
https://bugs.webkit.org/show_bug.cgi?id=134187

Reviewed by Darin Adler.

Source/WebCore:

Improve heuristics for list detection by:

Not exposing lists without list markers (unless explicitly marked as lists)
Recognizing css: before-content as list markers

Test: accessibility/list-detection2.html

accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::isDescriptionList):
(WebCore::AccessibilityList::childHasPseudoVisibleListItemMarkers):
(WebCore::AccessibilityList::determineAccessibilityRole):

accessibility/AccessibilityList.h:

LayoutTests:

accessibility/list-detection-expected.txt:
accessibility/list-detection.html:
accessibility/list-detection2-expected.txt: Added.
accessibility/list-detection2.html: Added.

4:34 PM Changeset in webkit [184675] by Antti Koivisto

4 edits
2 adds in trunk

REGRESSION (r172591): Can no longer style <optgroup> with colors (LayoutTests/fast/forms/select/optgroup-rendering.html)
https://bugs.webkit.org/show_bug.cgi?id=145227
Source/WebCore:

rdar://problem/20967472

Reviewed by Darin Adler.

Test: fast/forms/select/select-painting.html

Use computedStyle() consistently for option and optgroup items.

rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):

We can always use computedStyle() and it can't be null. If there was renderer style it would return that.

rendering/RenderMenuList.cpp:

(RenderMenuList::itemStyle):
(RenderMenuList::getItemBackgroundColor):

LayoutTests:

Reviewed by Darin Adler.

Add ref test for select painting.

fast/forms/select/select-painting-expected.html: Added.
fast/forms/select/select-painting.html: Added.

4:33 PM Changeset in webkit [184674] by jer.noble@apple.com

2 edits in trunk/Source/WebKit/mac

Unreviewed build fix; WebActionMenuController.mm should directly include LocalizedStrings.h

WebView/WebActionMenuController.mm:

4:27 PM Changeset in webkit [184673] by bshafiei@apple.com

1 copy in tags/Safari-600.1.4.16.4

New tag.

4:26 PM Changeset in webkit [184672] by bshafiei@apple.com

1 copy in tags/Safari-601.1.32.2.4

New tag.

4:26 PM Changeset in webkit [184671] by bshafiei@apple.com

1 copy in tags/Safari-601.1.32.4

New tag.

4:12 PM Changeset in webkit [184670] by jer.noble@apple.com

29 edits
1 copy
1 add in trunk/Source

Touching HTMLMediaElement.h or MediaPlayer.h causes a world rebuild.
https://bugs.webkit.org/show_bug.cgi?id=145193

Reviewed by Eric Carlson.

Source/WebCore:

HTMLMediaElement.h and MediaPlayer.h are included in a number of headers solely for access to the enums
defined within the classes contained within. Move these enums into their own--otherwise empty--classes.
Then add using declarations to pull those inherited enums back into the namespace of HTMLMediaElement
and MediaPlayer.

Classes and headers which do not need to directly include HTMLMediaElement.h can now include HTMLMediaElementEnums.h
instead; the same goes for MediaPlayer.h and MediaPlayerEnums.h.

WebCore.xcodeproj/project.pbxproj: Add new files to project.
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::TrackGroup::TrackGroup): Move definition here from the header.

html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::videoFullscreenGravity): MediaPlayer -> MediaPlayerEnums.
(WebCore::HTMLMediaElement::preloadValue): Ditto.
(WebCore::HTMLMediaElement::TrackGroup::TrackGroup): Deleted; moved to implementation file.

html/HTMLMediaElementEnums.h: Added.
html/MediaControllerInterface.h: Inherit from HTMLMediaElementEnums.
page/ChromeClient.h: HTMLMediaElement -> HTMLMediaElementEnums.
platform/graphics/MediaPlayer.h: MediaPlayer -> MediaPlayerEnums.
platform/graphics/MediaPlayerEnums.h: Added.
platform/ios/WebVideoFullscreenControllerAVKit.h:
platform/ios/WebVideoFullscreenControllerAVKit.mm:

(-[WebVideoFullscreenController enterFullscreen:mode:]): HTMLMediaElement -> HTMLMediaElementEnums.

platform/ios/WebVideoFullscreenInterfaceAVKit.h:
platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::setupFullscreen): Ditto.
(WebVideoFullscreenInterfaceAVKit::setupFullscreenInternal): Ditto.
(WebVideoFullscreenInterfaceAVKit::enterFullscreen): Ditto.
(WebVideoFullscreenInterfaceAVKit::exitFullscreenInternal): Ditto.
(WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal): Ditto.
(WebVideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen): Ditto.
(WebVideoFullscreenInterfaceAVKit::mayAutomaticallyShowVideoOptimized): Ditto.
(WebVideoFullscreenInterfaceAVKit::willStartOptimizedFullscreen): Ditto.
(WebVideoFullscreenInterfaceAVKit::didStopOptimizedFullscreen): Ditto.
(WebVideoFullscreenInterfaceAVKit::didCancelOptimizedFullscreen): Ditto.
(WebVideoFullscreenInterfaceAVKit::setMode): Ditto.
(WebVideoFullscreenInterfaceAVKit::clearMode): Ditto.

platform/ios/WebVideoFullscreenModel.h:
platform/ios/WebVideoFullscreenModelVideoElement.h:
platform/ios/WebVideoFullscreenModelVideoElement.mm:

(WebVideoFullscreenModelVideoElement::setVideoElement): Ditto.
(WebVideoFullscreenModelVideoElement::fullscreenModeChanged): Ditto.

Source/WebKit/mac:

Use HTMLMediaElementEnums instead of HTMLMediaElement.

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::enterVideoFullscreenForVideoElement): HTMLMediaElement -> HTMLMediaElementEnums.

WebView/WebView.mm:

(-[WebView _enterVideoFullscreenForVideoElement:mode:]): Ditto.

WebView/WebViewInternal.h:

Source/WebKit2:

Use HTMLMediaElementEnums instead of HTMLMediaElement.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _isShowingVideoOptimized]): HTMLMediaElement -> HTMLMediaElementEnums.

UIProcess/ios/WebVideoFullscreenManagerProxy.h:
UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in:
UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::hasMode): Ditto.
(WebKit::WebVideoFullscreenModelContext::fullscreenModeChanged): Ditto.
(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID): Ditto.
(WebKit::WebVideoFullscreenManagerProxy::fullscreenModeChanged): Ditto.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::enterVideoFullscreenForVideoElement): Ditto.

WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/ios/WebVideoFullscreenManager.h:

(WebKit::WebVideoFullscreenInterfaceContext::fullscreenMode): Ditto.
(WebKit::WebVideoFullscreenInterfaceContext::setFullscreenMode): Ditto.

WebProcess/ios/WebVideoFullscreenManager.messages.in:
WebProcess/ios/WebVideoFullscreenManager.mm:

(WebKit::WebVideoFullscreenManager::enterVideoFullscreenForVideoElement): Ditto.
(WebKit::WebVideoFullscreenManager::fullscreenModeChanged): Ditto.
(WebKit::WebVideoFullscreenManager::didCleanupFullscreen): Ditto.

4:04 PM Changeset in webkit [184669] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Refactor process pool enumeration code in WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=145218

Reviewed by Tim Horton.

Also make sure to keep the WebProcessPool objects alive for the duration of the various data store
operations. This is the first step towards having the data store create a single process pool lazily if
there are no web views associated with the data store.

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchData):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::processPools):

UIProcess/WebsiteData/WebsiteDataStore.h:

4:01 PM Changeset in webkit [184668] by achristensen@apple.com

2 edits in trunk/Tools

Use correct String for StringView in WTF API tests
https://bugs.webkit.org/show_bug.cgi?id=145226
rdar://problem/20361786

Reviewed by Benjamin Poulain.

TestWebKitAPI/Tests/WTF/StringView.cpp:

(TestWebKitAPI::TEST):
Use patternHolder for pattern.

3:40 PM Changeset in webkit [184667] by roger_fong@apple.com

3 edits in trunk/Source/WebCore

Media Controls stop updating after hovering for a few seconds.
https://bugs.webkit.org/show_bug.cgi?id=144770.
<rdar://problem/19823121>

Reviewed by Jer Noble.

Modules/mediacontrols/mediaControlsApple.js:

Override methods to use add and remove panelContainer for iOS.

Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.handlePanelTransitionEnd):
(ControllerIOS.prototype.showControls):
(ControllerIOS.prototype.controlsAreHidden):

3:25 PM Changeset in webkit [184666] by akling@apple.com

6 edits in trunk/Source/JavaScriptCore

Remove unused MarkedBlock::m_rememberedSet.
<https://webkit.org/b/145224>

Reviewed by Mark Hahnenberg.

The MarkedBlock had a copy of the remembered bit for each of its cells,
and we were maintaining that bitmap despite no one actually ever consulting it.

This patch removes MarkedBlock::m_rememberedSet, freeing up 128 bytes in each
block and making write barriers a little faster.

heap/Heap.cpp:

(JSC::Heap::clearRememberedSet):
(JSC::Heap::addToRememberedSet):

heap/HeapInlines.h:

(JSC::Heap::isRemembered):

heap/MarkedBlock.cpp:

(JSC::MarkedBlock::clearRememberedSet): Deleted.
(JSC::MarkedBlock::clearMarksWithCollectionType):

heap/MarkedBlock.h:

(JSC::MarkedBlock::setRemembered): Deleted.
(JSC::MarkedBlock::clearRemembered): Deleted.
(JSC::MarkedBlock::atomicClearRemembered): Deleted.
(JSC::MarkedBlock::isRemembered): Deleted.

heap/MarkedSpace.h:

(JSC::ClearRememberedSet::operator()): Deleted.
(JSC::MarkedSpace::clearRememberedSet): Deleted.

3:23 PM Changeset in webkit [184665] by Jon Davis

982 edits
587 adds in trunk/Websites/webkit.org

Upgrading WordPress to 4.2.2 release.

3:07 PM Changeset in webkit [184664] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Build fix. Use POSIX timestamp instead of human readable string for the commit time.

public/include/build-requests-fetcher.php:

3:03 PM Changeset in webkit [184663] by bshafiei@apple.com

8 edits in tags/Safari-601.1.32.2.50/Source

Merged r184600. rdar://problem/21024426

2:53 PM Changeset in webkit [184662] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

[Mac] inform media session of all state changes
https://bugs.webkit.org/show_bug.cgi?id=145222

Reviewed by Dean Jackson.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Call updateMediaState.
(WebCore::HTMLMediaElement::mediaPlayerEngineUpdated): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerFirstVideoFrameAvailable): Ditto.
(WebCore::HTMLMediaElement::removeEventListener): Ditto.
(WebCore::HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent): Ditto.

2:52 PM Changeset in webkit [184661] by rniwa@webkit.org

8 edits in trunk/Websites/perf.webkit.org

UI to associate bugs with an analysis task is crappy
https://bugs.webkit.org/show_bug.cgi?id=145198

Reviewed by Andreas Kling.

Make the UI less crappy by linkifying bug numbers and adding an explicit button to disassociate
a bug and a separate select view with a text field to associate a new bug instead of implicitly
updating or deleting the existing record based on what the user had typed.

init-database.sql: Removed the constraint that each bug tracker should appear exactly once for

a given analysis task since it's perfectly reasonable for a given task to be associated with
multiple WebKit bugs.

public/privileged-api/associate-bug.php:

(main): Only remove the bug specified by newly added bugToDelete instead of implicitly deleting
one that matches the analysis task and the bug tracker when the bug number is falsey.

public/v2/analysis.js:

(App.Bug.url): Added.
(App.BugAdapter.deleteRecord): Added. Uses the privileged API to delete the record.

public/v2/app.css:

public/v2/app.js:

(App.AnalysisTaskController.actions.addBug): Added.
(App.AnalysisTaskController.actions.deleteBug): Added.
(App.AnalysisTaskController.associateBug): Deleted.

public/v2/index.html: Updated the templates.

public/v2/manifest.js:

(App.BugTracker.urlFromBugNumber): Added.

2:38 PM Changeset in webkit [184660] by dbates@webkit.org

9 edits
2 adds in trunk

AX: AutoFill button is not accessible with VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=145200
<rdar://problem/20507480>

Reviewed by Chris Fleizach.

Source/WebCore:

Add ARIA label and role attributes to the AutoFill button markup so that VoiceOver
can identify and interact with it.

Test: accessibility/input-auto-fill-button.html

English.lproj/Localizable.strings: Add placeholder localized string for AutoFill button.
html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createAutoFillButton): Add ARIA label and role attributes.

platform/LocalizedStrings.cpp:

(WebCore::AXAutoFillButtonText): Added; returns the localized string for the AutoFill button.

platform/LocalizedStrings.h:
platform/efl/LocalizedStringsEfl.cpp:

(WebCore::AXAutoFillButtonText): Ditto.

platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::AXAutoFillButtonText): Ditto.

LayoutTests:

Test that there is an accessibility element for the AutoFill button.

accessibility/input-auto-fill-button-expected.txt: Added.
accessibility/input-auto-fill-button.html: Added.
platform/win/TestExpectations: For now, mark tests as failing. I suspect the cause

is <https://bugs.webkit.org/show_bug.cgi?id=140798>.

2:36 PM Changeset in webkit [184659] by dino@apple.com

2 edits in trunk/Source/WebCore

Label text for default buttons don’t have the correct white color
https://bugs.webkit.org/show_bug.cgi?id=145221
<rdar://problem/20985817>

Reviewed by Tim Horton.

Use a 85% solid white for the active text color on buttons.

As has been disappointingly pointed out in other patches, we don't
have a good way to test ActiveButtonText since it only applies at
paint time.

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor): Move to an 85% solid white.

2:22 PM Changeset in webkit [184658] by rniwa@webkit.org

3 edits in trunk/Websites/perf.webkit.org

A/B testing rootSets should provide commit times as well as revisions
https://bugs.webkit.org/show_bug.cgi?id=145207

Reviewed by Andreas Kling.

Some continuous build systems need the commit time as well as the revision number / hash so provide one
in the root sets but maintain the backwards compatibility with buildbots that use revision number directly.

public/include/build-requests-fetcher.php:

(BuildRequestsFetcher::fetch_roots_for_set): Made the revision info an associative array that contains
the revision number as well as the commit time.

tools/sync-with-buildbot.py:

(schedule_request): Removed "replacement" which was a superfluous copy of "roots". Use "revision" values
when the JSON configuration refers to "root". This is necessary in buildbot instances that require WebKit
revision to be specified on its own field instead of it being a JSON that contains "revision" and "time".

2:08 PM Changeset in webkit [184657] by ap@apple.com

3 edits in trunk/Source/WebCore

ThreadableLoaderOptions::isolatedCopy() doesn't produce a copy that is safe for sending to another thread
https://bugs.webkit.org/show_bug.cgi?id=145217

Reviewed by Anders Carlsson.

Caught by existing tests, rarely. I don't know how to catch such bugs more reliably.

loader/ThreadableLoader.cpp: (WebCore::ThreadableLoaderOptions::isolatedCopy):
loader/ThreadableLoader.h:

2:07 PM Changeset in webkit [184656] by bshafiei@apple.com

5 edits in branches/safari-600.7-branch/Source

Versioning.

1:57 PM Changeset in webkit [184655] by bshafiei@apple.com

1 copy in tags/Safari-600.7.8

New tag.

1:42 PM Changeset in webkit [184654] by timothy_horton@apple.com

5 edits in trunk/Source/WebCore

Add a mechanism to opt-out of the automatic scaling applied to not-really-responsive sites
https://bugs.webkit.org/show_bug.cgi?id=144760

Reviewed by Darin Adler.

Add a new viewport property, shrink-to-fit, which can be used to disable
the automatic scaling introduced in r181400. This provides sites with a
way to tell WebKit that they're really sure they want to be laid out at
window-width/height, even if they fail to fit within that size.

dom/ViewportArguments.cpp:

(WebCore::ViewportArguments::resolve):
(WebCore::findBooleanValue):
(WebCore::setViewportFeature):

dom/ViewportArguments.h:

(WebCore::ViewportArguments::ViewportArguments):
(WebCore::ViewportArguments::operator==):

page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::shouldIgnoreHorizontalScalingConstraints):
(WebCore::ViewportConfiguration::shouldIgnoreVerticalScalingConstraints):
(WebCore::ViewportConfiguration::webpageParameters):
(WebCore::ViewportConfiguration::textDocumentParameters):
(WebCore::ViewportConfiguration::imageDocumentParameters):
(WebCore::ViewportConfiguration::testingParameters):
(WebCore::booleanViewportArgumentIsSet):
(WebCore::ViewportConfiguration::updateConfiguration):
(WebCore::ViewportConfigurationTextStream::operator<<):
(WebCore::viewportArgumentUserZoomIsSet): Deleted.

page/ViewportConfiguration.h:

(WebCore::ViewportConfiguration::Parameters::Parameters):
Plumb the shrink-to-fit viewport property through.
If shrink-to-fit is set to yes, or not set, we behave as usual; if it is
set to no, we will bail from shouldIgnore[Horizontal|Vertical]ScalingConstraints,
effectively disabling the automatic scaling introduced in r181400.

1:34 PM Changeset in webkit [184653] by Antti Koivisto

4 edits
2 adds in trunk

Assertion failure in WebCore::BidiRun::BidiRun()
https://bugs.webkit.org/show_bug.cgi?id=145203
rdar://problem/20958973

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/text/text-combine-crash.html

rendering/line/BreakingContext.h:

(WebCore::BreakingContext::handleText):

Renove !isCombined() check. RenderCombineText::combineText() doesn't
do any work unless needed and text may become uncombined too.

rendering/line/LineBreaker.cpp:

(WebCore::LineBreaker::skipLeadingWhitespace):

Same here.

LayoutTests:

fast/text/text-combine-crash-expected.txt: Added.
fast/text/text-combine-crash.html: Added.

1:30 PM Changeset in webkit [184652] by akling@apple.com

4 edits in trunk/Source/JavaScriptCore

Eden collections should extend the IncrementalSweeper work list, not replace it.
<https://webkit.org/b/145213>
<rdar://problem/21002666>

Reviewed by Geoffrey Garen.

After an eden collection, the garbage collector was adding all MarkedBlocks containing
new objects to the IncrementalSweeper's work list, to make sure they didn't have to
wait until the next full collection before getting swept.

Or at least, that's what it thought it was doing. It turns out that IncrementalSweeper's
internal work list is really just a reference to Heap::m_blockSnapshot. I didn't realize
this when writing the post-eden sweep code, and instead made eden collections cancel
all pending sweeps and *replace* them with the list of blocks with new objects.

This made it so that rapidly occurring eden collections could prevent large numbers of
heap blocks from ever getting swept. This would manifest as accumulation of MarkedBlocks
when a system under heavy load was also allocating short lived objects at a high rate.
Things would eventually get cleaned up when there was a lull and a full collection was
allowed to run its heap sweep to completion.

Fix this by moving all management of the block snapshot to Heap. snapshotMarkedSpace()
now handles eden collections by merging the list of blocks with new objects into the
existing block snapshot.

heap/Heap.cpp:

(JSC::Heap::snapshotMarkedSpace):
(JSC::Heap::notifyIncrementalSweeper):

heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::startSweeping):
(JSC::IncrementalSweeper::addBlocksAndContinueSweeping): Deleted.

heap/IncrementalSweeper.h:

1:20 PM Changeset in webkit [184651] by youenn.fablet@crf.canon.fr

13 edits
2 adds in trunk

AudioContext resume/close/suspend should reject promises with a DOM exception in lieu of throwing exceptions
https://bugs.webkit.org/show_bug.cgi?id=145064

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added default message for TypeError.

runtime/Error.cpp:

(JSC::throwTypeError):

runtime/Error.h:

Source/WebCore:

Rejecting resume/suspend/close promises with InvalidStateError values in case context is offline.
Removed unneeded calls to postTask for resolving/rejecting promises.
Adding promise rejection of DOM Exception values, 0 being equivalent of no error passed to reject callback.

Test: webaudio/audiocontext-promise-throwing.html

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::suspendContext): Rejecting promise in lieu of throwing exception.
(WebCore::AudioContext::resumeContext): Ditto.
(WebCore::AudioContext::closeContext): Ditto.

Modules/webaudio/AudioContext.h:
bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContext::suspend): Removing ExceptionCode handling.
(WebCore::JSAudioContext::resume): Ditto.
(WebCore::JSAudioContext::close): Ditto.

bindings/js/JSDOMBinding.cpp:

(WebCore::createDOMException): Splitting DOM exception creation from throwing.
(WebCore::setDOMException): Ditto.

bindings/js/JSDOMBinding.h: Adding createDOMException prototype.
bindings/js/JSDOMPromise.h:

(WebCore::DeferredWrapper::reject<ExceptionCode>):

LayoutTests:

Adding test to cover resume/close/suspend rejecting with InvalidStateError.
Updating existing test to cover resume and suspend rejection with no error.

webaudio/audiocontext-promise-throwing-expected.txt: Added.
webaudio/audiocontext-promise-throwing.html: Added.
webaudio/audiocontext-state-expected.txt:
webaudio/audiocontext-state.html:

1:12 PM Changeset in webkit [184650] by commit-queue@webkit.org

8 edits
2 deletes in trunk

Unreviewed, rolling out r184645.
https://bugs.webkit.org/show_bug.cgi?id=145220

Broken build (Requested by jacob_nielsen on #webkit).

Reverted changeset:

"AX: AutoFill button is not accessible with VoiceOver"
https://bugs.webkit.org/show_bug.cgi?id=145200
http://trac.webkit.org/changeset/184645

1:08 PM Changeset in webkit [184649] by bshafiei@apple.com

5 edits in tags/Safari-601.1.32.2.50/Source

Versioning.

1:05 PM Changeset in webkit [184648] by bshafiei@apple.com

1 copy in tags/Safari-601.1.32.2.50

New tag.

12:35 PM Changeset in webkit [184647] by Joseph Pecoraro

2 edits in trunk/Source/JavaScriptCore

No LLInt Test Failure: jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint
https://bugs.webkit.org/show_bug.cgi?id=145219

Reviewed by Mark Lam.

jit/JITOperations.cpp:

Throw the error we just got, instead of a stack overflow exception.
This matches other error handling for callers of prepareForExecution.

11:40 AM Changeset in webkit [184646] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

Add some assertions about the CFG in the loop pre-header creation phase
https://bugs.webkit.org/show_bug.cgi?id=145205

Reviewed by Geoffrey Garen.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::currentNodeOrigin): Add a FIXME.

dfg/DFGLICMPhase.cpp:

(JSC::DFG::LICMPhase::run): Add a FIXME.

dfg/DFGLoopPreHeaderCreationPhase.cpp:

(JSC::DFG::LoopPreHeaderCreationPhase::run): Add the assertions.

10:58 AM Changeset in webkit [184645] by dbates@webkit.org

8 edits
2 adds in trunk

AX: AutoFill button is not accessible with VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=145200
<rdar://problem/20507480>

Reviewed by Chris Fleizach.

Source/WebCore:

Add ARIA label and role attributes to the AutoFill button markup so that VoiceOver
can identify and interact with it.

Test: accessibility/input-auto-fill-button.html

English.lproj/Localizable.strings: Add placeholder localized string for AutoFill button.
html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createAutoFillButton): Add ARIA label and role attributes.

platform/LocalizedStrings.cpp:

(WebCore::AXAutoFillButtonText): Added; returns the localized string for the AutoFill button.

platform/LocalizedStrings.h:
platform/efl/LocalizedStringsEfl.cpp:

(WebCore::AXAutoFillButtonText): Ditto.

platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::AXAutoFillButtonText): Ditto.

LayoutTests:

Test that there is an accessibility element for the AutoFill button.

accessibility/input-auto-fill-button-expected.txt: Added.
accessibility/input-auto-fill-button.html: Added.

10:56 AM Changeset in webkit [184644] by achristensen@apple.com

17 edits in trunk

[Content Extensions] Relax restrictions on triggers that match everything.
https://bugs.webkit.org/show_bug.cgi?id=145069

Reviewed by Benjamin Poulain.

Source/WebCore:

Added API tests that cover the new functionality and test for correctness in behavior.

contentextensions/CompiledContentExtension.cpp:

(WebCore::ContentExtensions::CompiledContentExtension::globalDisplayNoneSelectors):

contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::addUniversalActionsToDFA):
(WebCore::ContentExtensions::compileRuleList):
Put universalActionsWithoutDomains into the DFA from filtersWithoutDomains and
put universalActionsWithDomains into the DFA from filtersWithDomains.

contentextensions/ContentExtensionError.cpp:

(WebCore::ContentExtensions::contentExtensionErrorCategory):

contentextensions/ContentExtensionError.h:

Remove error codes for errors that are not errors any more.

contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad):

contentextensions/ContentExtensionsBackend.h:
contentextensions/DFABytecode.h:

(WebCore::ContentExtensions::instructionSizeWithArguments):

contentextensions/DFABytecodeCompiler.cpp:

(WebCore::ContentExtensions::set32Bits):
(WebCore::ContentExtensions::DFABytecodeCompiler::emitAppendAction):
(WebCore::ContentExtensions::DFABytecodeCompiler::emitJump):
(WebCore::ContentExtensions::DFABytecodeCompiler::emitCheckValue):
(WebCore::ContentExtensions::DFABytecodeCompiler::emitCheckValueRange):
(WebCore::ContentExtensions::DFABytecodeCompiler::compileNode):
(WebCore::ContentExtensions::DFABytecodeCompiler::compile):
(WebCore::ContentExtensions::DFABytecodeCompiler::emitTestFlagsAndAppendAction): Deleted.

contentextensions/DFABytecodeCompiler.h:
contentextensions/DFABytecodeInterpreter.cpp:

(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretTestFlagsAndAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::actionsForDefaultStylesheetFromDFARoot):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):
(WebCore::ContentExtensions::DFABytecodeInterpreter::actionsFromDFARoot): Deleted.

contentextensions/DFABytecodeInterpreter.h:

Add a new bytecode AppendActionDefaultStylesheet to mark actions that are css-display-none
that need to be put in the default stylesheet to be ignored or not as a whole.
css-display-none actions with flags or domain rules and css-display-none actions
after ignore-previous-rules actions are not to be in this precompiled stylesheet, but
they will be applied as needed per page. The precompiled stylesheet is already applied
if no ignore-previous-rules action is triggered.

loader/ResourceLoadInfo.h:

Source/WebKit2:

UIProcess/API/APIUserContentExtensionStore.h:

Increment version number to reflect changes in DFABytecode.

Tools:

TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::TEST_F):
Update and add tests for new possibilities with .*

10:39 AM Changeset in webkit [184643] by youenn.fablet@crf.canon.fr

7 edits in trunk/Source/WebCore

JS binding generator should create a member variable for each Promise attribute of an interface
https://bugs.webkit.org/show_bug.cgi?id=145056

Reviewed by Darin Adler.

For each attribute XXX whose type is Promise, a member m_XXXPromiseDeferred is created, its type being a JSC::Strong of JSPromiseDeferred.
The purpose is to enable custom getters to create the JSPromiseDeferred and store ino the class member to ensure the same promise is returned each time
the custom getter is called.
This patch will enable simplifying ReadableStreamReader custom binding.

Covered by added attribute in TestObj.idl.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_get_test_promise_attr):
(webkit_dom_test_obj_set_nullable_string_value): Deleted.

bindings/scripts/test/GObject/WebKitDOMTestObj.h:
bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjTestPromiseAttr):
(WebCore::jsTestObjAttributeWithReservedEnumType): Deleted.

bindings/scripts/test/JS/JSTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj testPromiseAttr]):
(-[DOMTestObj attribute]): Deleted.

bindings/scripts/test/TestObj.idl:

10:23 AM Changeset in webkit [184642] by commit-queue@webkit.org

11 edits
6 adds in trunk

ES6: Implement Object.setPrototypeOf
https://bugs.webkit.org/show_bug.cgi?id=145202

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-20
Reviewed by Darin Adler.

Source/JavaScriptCore:

runtime/JSGlobalObjectFunctions.h:
runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncProtoSetter):
(JSC::checkProtoSetterAccessAllowed):
Extract a helper to share this code between proto setter and setPrototypeOf.

runtime/ObjectConstructor.cpp:

(JSC::objectConstructorSetPrototypeOf):
Implementation is very similiar to proto setter.

LayoutTests:

http/tests/security/cross-frame-access-object-setPrototypeOf-expected.txt: Added.
http/tests/security/cross-frame-access-object-setPrototypeOf.html: Added.
http/tests/security/resources/cross-frame-iframe-for-object-setPrototypeOf-test.html: Added.

Test covering cross origin restriction behavior.

js/Object-getOwnPropertyNames-expected.txt:
js/script-tests/Object-getOwnPropertyNames.js:

Updated for the new exposed property.

js/cyclic-prototypes-expected.txt:
js/script-tests/cyclic-prototypes.js:

Extend this test to include setPrototypeOf cyclic checks.
Note that setPrototypeOf can still change the prototype
where proto cannot.

js/prototypes-expected.txt:
js/script-tests/prototypes.js:

Extend this test to cover more types previously overlooked.

js/script-tests/setPrototypeOf.js: Added.

(debugEval):
(getObjectDescriptions.myFunction):
(getObjectDescriptions):

js/setPrototypeOf-expected.txt: Added.
js/setPrototypeOf.html: Added.

Test coverage for all the different object / prototype combinations.
This is modeled after the other browser tests with coverage of a
few more basic functionality tests and object types.

10:02 AM Changeset in webkit [184641] by youenn.fablet@crf.canon.fr

3 edits
2 adds in trunk

AudioContext suspend/resume/close should resolve promises immediately when state is already suspended/active/closed
https://bugs.webkit.org/show_bug.cgi?id=145164

Reviewed by Jer Noble.

Source/WebCore:

Test: webaudio/audiocontext-promise.html

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::suspendContext): Immediatly call callbacks whenever possible to resolve/reject promises.
(WebCore::AudioContext::resumeContext): Ditto.
(WebCore::AudioContext::closeContext): Ditto

LayoutTests:

webaudio/audiocontext-promise-expected.txt: Added.
webaudio/audiocontext-promise.html: Added.

9:54 AM Changeset in webkit [184640] by commit-queue@webkit.org

13 edits
3 adds in trunk

ES6: Should not allow duplicate basic proto properties in Object Literals
https://bugs.webkit.org/show_bug.cgi?id=145138

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-20
Reviewed by Darin Adler.

Source/JavaScriptCore:

Implement ES6 Annex B.3.1, which disallows duplicate basic proto
properties in object literals. This doesn't affect computed properties,
shorthand properties, or getters/setters all of which avoid setting
the actual prototype of the object anyway.

interpreter/Interpreter.cpp:

(JSC::eval):
Remove out of date comment. Duplicate property names are allowed
now in ES6, they were not in ES5 strict mode.

parser/ASTBuilder.h:

(JSC::ASTBuilder::getName):
(JSC::ASTBuilder::getType):

parser/SyntaxChecker.h:

(JSC::SyntaxChecker::getName):
Add back getName to get the property name depending on the tree builder.
Also tighten up the parameter types.

runtime/LiteralParser.cpp:

(JSC::LiteralParser<CharType>::parse):
In quick JSON literal parsing for eval, we actually need to evaluate
the proto property assignment, instead of just building up a list
of direct properties. Only do this when not doing a strict JSON parse.

parser/Nodes.h:

Add "Shorthand" to the list of PropertyNode types to allow it to
be distinguished without relying on other information.

parser/Parser.h:
parser/Parser.cpp:

(JSC::Parser<LexerType>::parseProperty):
Add the Shorthand type when parsing a shorthand property.

(JSC::Parser<LexerType>::shouldCheckPropertyForUnderscoreProtoDuplicate):
(JSC::Parser<LexerType>::parseObjectLiteral):
(JSC::Parser<LexerType>::parseStrictObjectLiteral):
Check for duplicate proto properties, and throw a SyntaxError
if that was the case.

LayoutTests:

js/dom/JSON-parse-expected.txt:
js/resources/JSON-parse.js:

Update expected results for JSON parsing using eval() versus JSON.parse.
In eval, an object literal with a "proto" property modifies the prototype.
In JSON.parse, all properties are direct/own properties, no matter their name,
so "proto" does not get special treatment.

js/eval-json-proto-expected.txt: Added.
js/eval-json-proto.html: Added.
js/script-tests/eval-json-proto.js: Added.

Direct test for LiteralParser behavior, in both eval and JSON.parse.

js/object-literal-duplicate-properties-expected.txt:
js/script-tests/object-literal-duplicate-properties.js:

(runProtoTestShouldThrow):
(runProtoTestShouldNotThrow):
Test for all cases of acceptable and unacceptable proto duplicate
properties in literals.

9:18 AM Changeset in webkit [184639] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

Minor cleanups to PluginProcessProxy.
https://bugs.webkit.org/show_bug.cgi?id=145199

Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-05-20
Reviewed by Anders Carlsson.

Remove unnecessary forward declaration.
Remove unnecessary #include.

UIProcess/Plugins/PluginProcessProxy.cpp:
UIProcess/Plugins/PluginProcessProxy.h:

9:13 AM Changeset in webkit [184638] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[GTK] Add some documentation to WebKitWebExtension
https://bugs.webkit.org/show_bug.cgi?id=142786

Patch by Marcos Chavarría Teijeiro <mchavarria@igalia.com> on 2015-05-20
Reviewed by Carlos Garcia Campos.

WebKitWebExtension API documentation lacks of some details and the information
available is in some contributors blog posts. I add the section
documentation with a small guide about how to use WebExtensions.

The code examples were taken from Carlos García and Adrián Pérez blog
posts.

WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:

8:53 AM Changeset in webkit [184637] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit2

Rename WebsiteDataStore::isNonPersistent() to WebsiteDataStore::isPersistent().
https://bugs.webkit.org/show_bug.cgi?id=145111

Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-05-20
Reviewed by Darin Adler.

This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=144158.

UIProcess/API/APIWebsiteDataStore.cpp:

(API::WebsiteDataStore::isPersistent):

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchData):
(WebKit::WebsiteDataStore::removeData):

UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::isPersistent):
(WebKit::WebsiteDataStore::isNonPersistent): Deleted.

8:49 AM Changeset in webkit [184636] by Csaba Osztrogonác

4 edits in trunk/Source/JavaScriptCore

[JSC] Add missing copyrights and licenses for some scripts
https://bugs.webkit.org/show_bug.cgi?id=145044

Reviewed by Darin Adler.

build-symbol-table-index.py:
create-llvm-ir-from-source-file.py:
create-symbol-table-index.py:

8:46 AM Changeset in webkit [184635] by commit-queue@webkit.org

5 edits in trunk

Web Inspector: Slightly better node previews in arrays
https://bugs.webkit.org/show_bug.cgi?id=145188

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-20
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

inspector/InjectedScriptSource.js:

(InjectedScript.prototype._nodeDescription):
(InjectedScript.prototype._nodePreview):
Different stringified representations for a basic object description or in a preview.

(InjectedScript.RemoteObject.prototype._appendPropertyPreviews):
Use the node preview string representation inside previews.

LayoutTests:

inspector/model/remote-object-expected.txt:
inspector/model/remote-object.html:

3:25 AM Changeset in webkit [184634] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.4.9

WebKitGTK+ 2.4.9

3:24 AM Changeset in webkit [184633] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.4

Unreviewed. Update NEWS and Versions.m4 for 2.4.9 release.

Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

NEWS: Added release notes for 2.4.9.

3:12 AM Changeset in webkit [184632] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL] Fix build failure, linker does not find libXext.
https://bugs.webkit.org/show_bug.cgi?id=144100

Patch by Hyungwook Lee <hyungwook.lee@navercorp.com> on 2015-05-20
Reviewed by Gyuyoung Kim.

Move Xext library from WebProcess_LIBRARIES to WebKit2_LIBRARIES.

PlatformEfl.cmake:

2:14 AM Changeset in webkit [184631] by bshafiei@apple.com

7 edits in branches/safari-601.1.32.2-branch/Source/WebCore

Merged r184611. rdar://problem/21031188

2:09 AM Changeset in webkit [184630] by bshafiei@apple.com

19 edits in branches/safari-601.1.32.2-branch/Source

Merged r184596. rdar://problem/21023785

2:07 AM Changeset in webkit [184629] by bshafiei@apple.com

2 edits in branches/safari-601.1.32.2-branch/Source/WebCore

Merged r184589. rdar://problem/21009192

2:06 AM Changeset in webkit [184628] by bshafiei@apple.com

2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184583. rdar://problem/20964171

2:05 AM Changeset in webkit [184627] by bshafiei@apple.com

6 edits in branches/safari-601.1.32.2-branch/Source

Merged r184404. rdar://problem/20619179

12:58 AM Changeset in webkit [184626] by bshafiei@apple.com

19 edits in branches/safari-601.1.32-branch/Source

Merged r184596. rdar://problem/21023785

12:56 AM Changeset in webkit [184625] by bshafiei@apple.com

4 edits in branches/safari-601.1.32-branch/Source/JavaScriptCore

Merged r184542. rdar://problem/20679710

12:55 AM Changeset in webkit [184624] by bshafiei@apple.com

4 edits in branches/safari-601.1.32-branch/Source/JavaScriptCore

Merged r184540. rdar://problem/20679710

12:55 AM Changeset in webkit [184623] by Carlos Garcia Campos

5 edits in trunk/Source/WebCore

REGRESSION(r184420): [GTK] webkit_dom_html_element_get_children has been removed
https://bugs.webkit.org/show_bug.cgi?id=145174

Reviewed by Philippe Normand.

children property has been moved to Element, Document and
DocumentFragment to match the spec, so we need to expose the new
get_children and bring back webkit_dom_html_element_get_children()
as deprecated.

bindings/gobject/WebKitDOMDeprecated.cpp:

(webkit_dom_html_element_get_children):

bindings/gobject/WebKitDOMDeprecated.h:
bindings/gobject/WebKitDOMDeprecated.symbols:
bindings/gobject/webkitdom.symbols:

12:39 AM Changeset in webkit [184622] by commit-queue@webkit.org

12 edits in trunk/Source/WebCore

nullptr cleanup in WebCore/xml.
https://bugs.webkit.org/show_bug.cgi?id=145165

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-05-20
Reviewed by Csaba Osztrogonác.

No new tests, no behavior changes

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::responseXML):
(WebCore::XMLHttpRequest::internalAbort):
(WebCore::XMLHttpRequest::clearResponseBuffers):
(WebCore::XMLHttpRequest::clearRequest):
(WebCore::XMLHttpRequest::didFinishLoading):

xml/XMLHttpRequestProgressEventThrottle.cpp:

(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent):

xml/XSLImportRule.cpp:

(WebCore::XSLImportRule::XSLImportRule):
(WebCore::XSLImportRule::~XSLImportRule):
(WebCore::XSLImportRule::setXSLStyleSheet):
(WebCore::XSLImportRule::loadSheet):

xml/XSLStyleSheet.h:
xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::XSLStyleSheet):
(WebCore::XSLStyleSheet::~XSLStyleSheet):
(WebCore::XSLStyleSheet::clearDocuments):

xml/XSLTProcessorLibxslt.cpp:

(WebCore::saveResultToString):
(WebCore::xsltParamArrayFromParameterMap):
(WebCore::xmlDocPtrFromNode):
(WebCore::XSLTProcessor::transformToString):

xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::clearCurrentNodeStack):
(WebCore::XMLDocumentParser::exitText):
(WebCore::XMLDocumentParser::notifyFinished):

xml/parser/XMLDocumentParser.h:
xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::openFunc):
(WebCore::XMLDocumentParser::XMLDocumentParser):

xml/parser/XMLDocumentParserScope.cpp:
xml/parser/XMLDocumentParserScope.h:

12:26 AM Changeset in webkit [184621] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=144992

Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2015-05-20
Reviewed by Gyuyoung Kim.

MiniBrowser/efl/main.c:

(toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
(on_key_down):
(on_fullscreen_enter):
(on_fullscreen_exit):
(window_create):

12:04 AM Changeset in webkit [184620] by Carlos Garcia Campos

16 edits in trunk/Source

[SOUP] Network Cache: Implement ShareableResource for Soup and enable it for GTK platform
https://bugs.webkit.org/show_bug.cgi?id=144380

Reviewed by Antti Koivisto.

Source/WebCore:

Add a soup implementation of SharedBuffer::tryReplaceContentsWithPlatformBuffer().

Covered by http/tests/cache/disk-cache/ tests.

loader/cache/CachedResource.cpp: Define

CachedResource::tryReplaceEncodedData() also for Soup.

loader/cache/CachedResource.h: Ditto.
platform/soup/SharedBufferSoup.cpp:

(WebCore::SharedBuffer::tryReplaceContentsWithPlatformBuffer):

Source/WebKit2:

It improves the network cache performance, by mmaping big
resources and sending only the file descriptor to the web process
instead of the actual file data. It needs some changes in
cross-platform code, because we can't use the same approach as
mac (it uses a platform specific implementation not available in
other platforms).

NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::store): Use
Data::tryCreateSharedMemory() to create the shared memory used by
the ShareableResource. Also add an ASSERT instead of checking the
shareable resource created is not nullptr, because the
ShareableResource::create() that receives a shared memory should
never return nullptr.

NetworkProcess/cache/NetworkCacheData.h:
NetworkProcess/cache/NetworkCacheDataCocoa.mm:

(WebKit::NetworkCache::Data::tryCreateSharedMemory):

NetworkProcess/cache/NetworkCacheDataSoup.cpp:

(WebKit::NetworkCache::Data::tryCreateSharedMemory): Create a
SharedMemory object to wrap the mapped file, but keeping the ownership.

NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::initializeShareableResourceHandleFromStorageRecord):
Use Data::tryCreateSharedMemory() to create the shared memory used
bythe ShareableResource. Also add an ASSERT instead of checking
the shareable resource created is not nullptr, because the
ShareableResource::create() that receives a shared memory should
never return nullptr.

Platform/SharedMemory.h:
Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::map): Use wrapMap() and initialize
m_isWrappingMap to false.
(WebKit::SharedMemory::wrapMap): Create a SharedMemory object for
the given map, without taking its ownership.
(WebKit::SharedMemory::~SharedMemory): Do not unmap and close the
file descriptor if m_isWrappingMap is true.

Shared/ShareableResource.cpp:

(WebKit::createShareableResourceDeallocator):
(WebKit::ShareableResource::wrapInSharedBuffer): Create a SharedBuffer
wrapping the ShareableResource data.
(WebKit::ShareableResource::Handle::tryWrapInSharedBuffer): Create
a ShareableResource for the handle and create a SharedBuffer
wrapping it.

Shared/ShareableResource.h:
WebKit2Prefix.h: Enable ENABLE_SHAREABLE_RESOURCE for GTK.
WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResource): Get the CFData
from the SharedBuffer for QuickLook instead of wrapping the handle again.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed