⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 24, 2015:

11:55 PM Changeset in webkit [184849] by Carlos Garcia Campos
  • 2 edits in trunk

[GTK] Bump GCC requirements to 4.9.0
​https://bugs.webkit.org/show_bug.cgi?id=145211

Reviewed by Žan Doberšek.

It's required to build with IndexedDB support when using GCC,
clang works just fine. See ​https://bugs.webkit.org/show_bug.cgi?id=98932.

  • Source/cmake/OptionsGTK.cmake:
8:51 PM Changeset in webkit [184848] by commit-queue@webkit.org
  • 7 edits in trunk

Array#findIndex/find should not skip holes
​https://bugs.webkit.org/show_bug.cgi?id=145361
Source/JavaScriptCore:

per ​https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array.prototype.findindex
and ​https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array.prototype.find

Patch by Jordan Harband <​ljharb@gmail.com> on 2015-05-24
Reviewed by Yusuke Suzuki.

  • builtins/Array.prototype.js:

(find): Deleted.
(findIndex): Deleted.

LayoutTests:

Patch by Jordan Harband <​ljharb@gmail.com> on 2015-05-24
Reviewed by Yusuke Suzuki.

  • js/array-find-expected.txt:
  • js/array-findIndex-expected.txt:
  • js/script-tests/array-find.js:
  • js/script-tests/array-findIndex.js:
7:38 PM Changeset in webkit [184847] by Brian Burg
  • 2 edits in trunk/Source/JavaScriptCore

Web Inspector: Uncaught exception when using Inspect tool on SVG elements
​https://bugs.webkit.org/show_bug.cgi?id=145363

Reviewed by Joseph Pecoraro.

The injected script failed by chaining a call to String.prototype.trim to the result of
SVG*Element.className, which is an SVGAnimatedString and lacks useful methods. So, obtain
the class name using Node.getAttribute, which always returns a DOMString.

  • inspector/InjectedScriptSource.js:

(InjectedScriptSource.prototype._getDescription): use getAttribute instead of className.

4:22 PM Changeset in webkit [184846] by weinig@apple.com
  • 13 edits in trunk

Crash when using a removed ScriptMessageHandler
<rdar://problem/20888499>
​https://bugs.webkit.org/show_bug.cgi?id=145359

Reviewed by Dan Bernstein.

Source/WebCore:

Added tests:

WKUserContentController.ScriptMessageHandlerBasicRemove
WKUserContentController.ScriptMessageHandlerCallRemovedHandler

  • page/UserMessageHandler.cpp:

(WebCore::UserMessageHandler::~UserMessageHandler):
(WebCore::UserMessageHandler::postMessage):
(WebCore::UserMessageHandler::name):

  • page/UserMessageHandler.h:

(WebCore::UserMessageHandler::create):

  • page/UserMessageHandler.idl:
  • page/UserMessageHandlerDescriptor.cpp:

(WebCore::UserMessageHandlerDescriptor::UserMessageHandlerDescriptor):

  • page/UserMessageHandlerDescriptor.h:

(WebCore::UserMessageHandlerDescriptor::client):
(WebCore::UserMessageHandlerDescriptor::invalidateClient):
Add support for invalidating the descriptor and throw an exception if someone tries
to post a message using an invalidated descriptor.

  • page/UserMessageHandlersNamespace.cpp:

(WebCore::UserMessageHandlersNamespace::handler):
Add logic to remove message handlers if their descriptor has been invalidated.

Source/WebKit2:

  • WebProcess/UserContent/WebUserContentController.cpp:

(WebKit::WebUserMessageHandlerDescriptorProxy::~WebUserMessageHandlerDescriptorProxy):
Invalidate the descriptor when the message handler client (as implemented by WebUserMessageHandlerDescriptorProxy)
goes away. This will happen if a script message handler is removed at the API level or the WebUserContentController
is destroyed (which will happen if all the pages get destroyed).

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:

Add tests for removing script message handlers.

12:30 PM Changeset in webkit [184845] by mitz@apple.com
  • 17 edits in trunk

Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
​https://bugs.webkit.org/show_bug.cgi?id=145345

Reviewed by Sam Weinig.

Source/bmalloc:

  • Configurations/Base.xcconfig: Also changed to use $(inherited).

Source/JavaScriptCore:

  • Configurations/Base.xcconfig: Also changed to use $(inherited).

Source/WebCore:

  • Configurations/WebCore.xcconfig: Also changed to use $(inherited).

Source/WebInspectorUI:

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

  • Configurations/WebKitLegacy.xcconfig: Also changed to use $(inherited).

Source/WTF:

  • Configurations/Base.xcconfig: Also changed to use $(inherited).

Tools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • LayoutTestRelay/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
11:31 AM Changeset in webkit [184844] by commit-queue@webkit.org
  • 19 edits in trunk/Source/WebCore

Use modern for-loops in WebCore/svg.
​https://bugs.webkit.org/show_bug.cgi?id=145209

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-05-24
Reviewed by Darin Adler.

No new tests, no behavior changes.

  • svg/SVGAnimateElementBase.cpp:

(WebCore::propertyTypesAreConsistent):

  • svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):

  • svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::executeAction):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::parseAttribute):

  • svg/SVGCursorElement.cpp:

(WebCore::SVGCursorElement::~SVGCursorElement):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::pauseAnimations):
(WebCore::SVGDocumentExtensions::unpauseAnimations):
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements):
(WebCore::SVGDocumentExtensions::isElementWithPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement):

  • svg/SVGElement.cpp:

(WebCore::populateAttributeNameToCSSPropertyIDMap):
(WebCore::populateAttributeNameToAnimatedPropertyTypeMap):
(WebCore::populateCSSPropertyWithSVGDOMNameToAnimatedPropertyTypeMap):
(WebCore::hasLoadListener):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

  • svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::registerLigaturesInGlyphCache):
(WebCore::SVGKerningMap::insert):
(WebCore::stringMatchesUnicodeRange):

  • svg/SVGPathByteStream.h:

(WebCore::SVGPathByteStream::append):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::updateAnimations):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::parseBeginOrEnd):
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):
(WebCore::SVGSMILElement::notifyDependentsIntervalChanged):
(WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):

  • svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::clearResultsRecursive):

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::addBuiltinEffects):

  • svg/properties/SVGAnimatedProperty.cpp:

(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):

  • svg/properties/SVGListProperty.h:

(WebCore::SVGListProperty::detachListWrappersAndResize):

  • svg/properties/SVGPathSegListPropertyTearOff.cpp:

(WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles):

10:43 AM Changeset in webkit [184843] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Register media MIME types as supported by HTML view in WebKit1.
​https://bugs.webkit.org/show_bug.cgi?id=145356

Patch by Jeremy Jones <​jeremyj@apple.com> on 2015-05-24
Reviewed by Eric Carlson.

Source/WebCore:

getSupportedMediaMIMETypes is now used in WebKit1.

  • platform/MIMETypeRegistry.h: Export getSupportedMediaMIMETypes.

Source/WebKit/mac:

WebDataSource and WebFrame view knew about suppotedImageMIMETypes and supportedNonImageMIMETypes,
but not a third category supportedMediaMIMETypes. These are now included along-side
supportedNonImageMIMETypes.

  • WebView/WebDataSource.mm:

(+[WebDataSource _repTypesAllowImageTypeOmission:]): use supportedMediaMIMETypes.

  • WebView/WebFrameView.mm:

(+[WebFrameView _viewTypesAllowImageTypeOmission:]): use supportedMediaMIMETypes.

  • WebView/WebHTMLRepresentation.h: declare -supportedMediaMIMETypes
  • WebView/WebHTMLRepresentation.mm:

(+[WebHTMLRepresentation supportedMIMETypes]): include supportedMediaMIMETypes
(+[WebHTMLRepresentation supportedMediaMIMETypes]): added

  • WebView/WebHTMLView.mm:

(+[WebHTMLView supportedMediaMIMETypes]): added

  • WebView/WebHTMLViewPrivate.h: declare -supportedMediaMIMETypes

May 23, 2015:

9:00 PM Changeset in webkit [184842] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.32.2-branch/Source

Versioning.

8:28 PM Changeset in webkit [184841] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.32.2.8

New tag.

8:21 PM Changeset in webkit [184840] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.32.2.82/Source/WebKit2

Merged r184834. rdar://problem/21090327

8:17 PM Changeset in webkit [184839] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.32.2.82/Source

Versioning.

8:15 PM Changeset in webkit [184838] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.32.2.82

New tag.

8:15 PM Changeset in webkit [184837] by Antti Koivisto
  • 5 edits in trunk

Permanent redirects should have long implicit cache lifetime
​https://bugs.webkit.org/show_bug.cgi?id=145348
Source/WebCore:

rdar://problem/20680519

Reviewed by Sam Weinig.

301 Moved Permanently response that doesn't specify explicit lifetime should have long implicit lifetime.
This matches other browsers.

  • platform/network/CacheValidation.cpp:

(WebCore::computeFreshnessLifetimeForHTTPFamily):

Give 301 Moved Permanently (and similarly semantically permanent 410 Gone) long implicit lifetime.

(WebCore::updateRedirectChainStatus):

LayoutTests:

Reviewed by Sam Weinig.

  • http/tests/cache/cache-redirections.html:
  • http/tests/cache/resources/cache-control-redirect.php:

Use less confusing name (max_age->expiration vs. max-age) and fix logic.

8:14 PM Changeset in webkit [184836] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merged r184834. rdar://problem/21090327

8:08 PM Changeset in webkit [184835] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.32.2-branch/Source

Versioning.

7:50 PM Changeset in webkit [184834] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/21090327> /S/L/PrivateFrameworks/WebKit.framework is missing Headers and PrivateHeaders symlinks
​https://bugs.webkit.org/show_bug.cgi?id=145354

Reviewed by David Kilzer.

  • WebKit2.xcodeproj/project.pbxproj: Create Headers and PrivateHeaders symlinks alongside

the dylib symlink.

6:26 PM Changeset in webkit [184833] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Rename ShareableResource::create(Handle&) to map(Handle&) to match SharedMemory.
​https://bugs.webkit.org/show_bug.cgi?id=145288

Patch by Sungmann Cho <​sungmann.cho@navercorp.com> on 2015-05-23
Reviewed by Sam Weinig.

  • Shared/ShareableResource.cpp:

(WebKit::ShareableResource::Handle::tryWrapInSharedBuffer):
(WebKit::ShareableResource::map):
(WebKit::ShareableResource::create): Deleted.

  • Shared/ShareableResource.h:
6:22 PM Changeset in webkit [184832] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Cleanup after r184796
​https://bugs.webkit.org/show_bug.cgi?id=145333

Reviewed by Alexey Proskuryakov.

No new tests because there is no behavior change.

  • platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::RenderingStyleSaver::RenderingStyleSaver): Deleted.
(WebCore::RenderingStyleSaver::~RenderingStyleSaver): Deleted.

2:32 PM Changeset in webkit [184831] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.32.2.7

New tag.

2:04 PM Changeset in webkit [184830] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/WebCore

Merge patch for rdar://problem/21084541.

12:28 PM Changeset in webkit [184829] by Alan Bujtas
  • 6 edits in trunk/LayoutTests

Rebaseline after r184825. Remove artificial extra space between 2 text renderers.

Reviewed by Antti Koivisto.

  • animations/lineheight-animation-expected.txt:
  • animations/simultaneous-start-transform-expected.txt:
  • animations/width-using-ems-expected.txt:
  • fast/events/window-events-bubble-expected.txt:
  • fast/events/window-events-bubble2-expected.txt:
11:41 AM Changeset in webkit [184828] by Yusuke Suzuki
  • 80 edits
    2 copies in trunk

Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
​https://bugs.webkit.org/show_bug.cgi?id=144848

Reviewed by Darin Adler.

Source/JavaScriptCore:

Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.

  • API/JSCallbackObject.h:
  • builtins/BuiltinNames.h:

(JSC::BuiltinNames::isPrivateName):

  • bytecode/BytecodeIntrinsicRegistry.h:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/ComplexGetStatus.cpp:

(JSC::ComplexGetStatus::computeFor):

  • bytecode/ComplexGetStatus.h:
  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeFor):
(JSC::GetByIdStatus::computeForStubInfo):

  • bytecode/GetByIdStatus.h:
  • bytecode/Instruction.h:

(JSC::Instruction::Instruction):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):

  • bytecode/PutByIdStatus.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::visibleNameForParameter):
(JSC::BytecodeGenerator::hasConstant):
(JSC::BytecodeGenerator::addConstant):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGDesiredIdentifiers.cpp:

(JSC::DFG::DesiredIdentifiers::addLazily):
(JSC::DFG::DesiredIdentifiers::at):
(JSC::DFG::DesiredIdentifiers::reallyAdd):

  • dfg/DFGDesiredIdentifiers.h:

(JSC::DFG::DesiredIdentifiers::operator[]):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIn):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::identifierUID):
(JSC::DFG::SpeculativeJIT::callOperation):

  • ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

  • ftl/FTLInlineCacheDescriptor.h:

(JSC::FTL::InlineCacheDescriptor::InlineCacheDescriptor):
(JSC::FTL::InlineCacheDescriptor::uid):
(JSC::FTL::GetByIdDescriptor::GetByIdDescriptor):
(JSC::FTL::PutByIdDescriptor::PutByIdDescriptor):
(JSC::FTL::CheckInDescriptor::CheckInDescriptor):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compilePutById):
(JSC::FTL::LowerDFGToLLVM::compileIn):
(JSC::FTL::LowerDFGToLLVM::compileMaterializeCreateActivation):
(JSC::FTL::LowerDFGToLLVM::getById):

  • ftl/FTLOperations.cpp:

(JSC::FTL::operationMaterializeObjectInOSR):

  • ftl/FTLSlowPathCall.cpp:

(JSC::FTL::callOperation):

  • ftl/FTLSlowPathCall.h:
  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • parser/Nodes.cpp:

(JSC::ProgramNode::setClosedVariables):

  • parser/Nodes.h:

(JSC::ScopeNode::captures):
(JSC::ScopeNode::setClosedVariables):
(JSC::ProgramNode::closedVariables):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::didFinishParsing):
(JSC::Parser<LexerType>::parseContinueStatement):

  • parser/Parser.h:

(JSC::Scope::Scope):
(JSC::Scope::pushLabel):
(JSC::Scope::getLabel):
(JSC::Scope::declareCallee):
(JSC::Scope::declareVariable):
(JSC::Scope::declareParameter):
(JSC::Scope::declareBoundParameter):
(JSC::Scope::useVariable):
(JSC::Scope::copyCapturedVariablesToVector):
(JSC::Parser::closedVariables):
(JSC::ScopeLabelInfo::ScopeLabelInfo): Deleted.

  • parser/SourceProviderCacheItem.h:

(JSC::SourceProviderCacheItem::usedVariables):
(JSC::SourceProviderCacheItem::writtenVariables):
(JSC::SourceProviderCacheItem::create):

  • runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::isPrivateName):

  • runtime/CommonIdentifiers.h:
  • runtime/Identifier.h:

(JSC::Identifier::impl):
(JSC::Identifier::Identifier):
(JSC::parseIndex):
(JSC::IdentifierRepHash::hash):

  • runtime/IdentifierInlines.h:

(JSC::Identifier::fromUid):

  • runtime/IntendedStructureChain.cpp:

(JSC::IntendedStructureChain::mayInterceptStoreTo):

  • runtime/IntendedStructureChain.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/Lookup.h:

(JSC::HashTable::entry):

  • runtime/MapData.h:
  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertySymbols):

  • runtime/PrivateName.h:

(JSC::PrivateName::PrivateName):
(JSC::PrivateName::uid):

  • runtime/PropertyMapHashTable.h:
  • runtime/PropertyName.h:

(JSC::PropertyName::PropertyName):
(JSC::PropertyName::uid):
(JSC::PropertyName::publicName):
(JSC::parseIndex):

  • runtime/PropertyNameArray.h:

(JSC::PropertyNameArray::addKnownUnique):
(JSC::PropertyNameArray::add):

  • runtime/Structure.cpp:

(JSC::StructureTransitionTable::contains):
(JSC::StructureTransitionTable::get):
(JSC::StructureTransitionTable::add):
(JSC::Structure::addPropertyTransitionToExistingStructureImpl):
(JSC::Structure::addPropertyTransitionToExistingStructureConcurrently):
(JSC::Structure::getConcurrently):
(JSC::Structure::add):
(JSC::Structure::remove):
(JSC::Structure::toStructureShape):

  • runtime/Structure.h:

(JSC::PropertyMapEntry::PropertyMapEntry):

  • runtime/StructureInlines.h:

(JSC::Structure::getConcurrently):

  • runtime/StructureTransitionTable.h:

(JSC::StructureTransitionTable::Hash::hash):

  • runtime/Symbol.cpp:

(JSC::Symbol::Symbol):

  • runtime/Symbol.h:
  • runtime/SymbolConstructor.cpp:

(JSC::symbolConstructorFor):
(JSC::symbolConstructorKeyFor):

  • runtime/SymbolTable.cpp:

(JSC::SymbolTable::uniqueIDForVariable):
(JSC::SymbolTable::globalTypeSetForVariable):

  • runtime/SymbolTable.h:
  • runtime/TypeSet.cpp:

(JSC::StructureShape::addProperty):
(JSC::StructureShape::propertyHash):

  • runtime/TypeSet.h:

Source/WebCore:

Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::write):

Source/WTF:

he current AtomicStringImpl accidentally means the symbol OR atomic StringImpl.
t's not correct to its name and it's error prone.

In this patch, we'll introduce/changes classes into WTF.

  1. UniquedStringImpl
It's derived class from StringImpl. And it represents symbol
atomic StringImpl.
  1. SymbolImpl

It's derived class from UniquedStringImpl. Only symbol strings can become this.
It ensures the given StringImpl is symbol in compile time.

  1. AtomicStringImpl

It's derived class from UniquedStringImpl. Only atomic (non-normal && non-symbol) strings can become this.
It ensures the given StringImpl is atomic in compile time.

And, in this time, I just accept UniqueStringImpl in AtomicString. As the result,

  1. Now AtomicStringImpl issue is fixed. Its SymbolImpl is separated and UniquedStringImpl is introduced.
  2. But AtomicString still have both symbol and atomic strings.

This should be solved in the separated patch.

  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/PrintStream.cpp:
  • wtf/PrintStream.h:

(WTF::printInternal):

  • wtf/text/AtomicString.h:

(WTF::AtomicString::AtomicString):

  • wtf/text/AtomicStringImpl.h:
  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::~StringImpl):
(WTF::StringImpl::createSymbol):
(WTF::StringImpl::createSymbolEmpty):

  • wtf/text/StringImpl.h:
  • wtf/text/SymbolImpl.h: Copied from Source/JavaScriptCore/runtime/PrivateName.h.
  • wtf/text/SymbolRegistry.cpp:

(WTF::SymbolRegistry::symbolForKey):
(WTF::SymbolRegistry::keyForSymbol):
(WTF::SymbolRegistry::remove):

  • wtf/text/SymbolRegistry.h:
  • wtf/text/UniquedStringImpl.h: Copied from Source/JavaScriptCore/runtime/PrivateName.h.

Tools:

Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.

  • TestWebKitAPI/Tests/WTF/StringImpl.cpp:
9:21 AM Changeset in webkit [184827] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.32-branch/Source

Versioning.

9:21 AM Changeset in webkit [184826] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.32.2-branch/Source

Versioning.

9:06 AM Changeset in webkit [184825] by Alan Bujtas
  • 4 edits
    2 adds in trunk

Simple line layout: Ignore -webkit-flow-*content while collecting text content for innerText.
​https://bugs.webkit.org/show_bug.cgi?id=145344
rdar://problem/20959522

Reviewed by Antti Koivisto.

This patch ensures that when a -webkit-flow-into content is present in a simple line layout container,
we skip it while collecting the text content for innerText.
It's not always guaranteed that a simple line layout container only contains simple text nodes. In such cases,
we need to ensure that text offset computing only takes the simple text nodes into account.

Source/WebCore:

Test: fast/text/simple-line-layout-inner-text-with-flow-content.html

  • editing/TextIterator.cpp:

(WebCore::TextIterator::handleTextNode):

  • editing/TextIterator.h:

LayoutTests:

  • fast/text/simple-line-layout-inner-text-with-flow-content-expected.txt: Added.
  • fast/text/simple-line-layout-inner-text-with-flow-content.html: Added.
8:07 AM Changeset in webkit [184824] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove code related with unused style classes
​https://bugs.webkit.org/show_bug.cgi?id=145332

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-23
Reviewed by Timothy Hatcher.

  • UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString.append):
(WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString):
The "type-string" class has no styles associated with it. So the entire span can be removed.

  • UserInterface/Views/DOMTreeElement.js:

Both of these style classes have no styles associated with them. Remove the class names.

8:03 AM Changeset in webkit [184823] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Improve native parameter lists a bit
​https://bugs.webkit.org/show_bug.cgi?id=145338

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-23
Reviewed by Timothy Hatcher.

  • UserInterface/Models/NativeFunctionParameters.js:
  • UserInterface/Views/ObjectTreePropertyTreeElement.js:

(WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):

8:01 AM Changeset in webkit [184822] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Update CSS Autocompletion properties and values
​https://bugs.webkit.org/show_bug.cgi?id=145341

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-23
Reviewed by Timothy Hatcher.

  • UserInterface/Models/CSSKeywordCompletions.js:
Note: See TracTimeline for information about the timeline view.