⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 3, 2015:

11:49 PM Changeset in webkit [185194] by Yusuke Suzuki
  • 2 edits in trunk/Tools

Fix options in build-jsc for CMake builds
​https://bugs.webkit.org/show_bug.cgi?id=145636

Reviewed by Gyuyoung Kim.

CMake only accepts -DXXX=YYY style options.
And ensured that ENABLE_JIT=OFF when specifying --cloop.

  • Scripts/build-jsc:
11:45 PM Changeset in webkit [185193] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Added a patch so that the colors displayed on the page could be toggled
in case people need accessibility colors displayed in their browser.
​https://bugs.webkit.org/show_bug.cgi?id=145570
<rdar://problem/20994468>

Added in CSS colors and toggle buttons for checkmarks in the page, so that
the page could be rendered in a specific way for accessibility needs if needed.

Patch by Matthew Daiter <​mdaiter@apple.com> on 2015-06-03
Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:

(updateHiddenPlatforms):
(applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
(toggleAccessibilityColors): Toggle colors on and off
(documentReady): Needed to make changes to the initialization

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(a:hover):
(div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
(div.cellButton.hide, div.accessibilityButton.hide):
(div.cellButton.unhide, div.accessibilityButton.unhide):
(.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
(.popover-tracking:hover):
(.accessibilityButton):
(div.cellButton): Deleted.
(div.cellButton.hide): Deleted.
(div.cellButton.unhide): Deleted.
(.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:

(.status-line.neutral .bubble):
(.status-line.unauthorized .bubble):
(.status-line.danger .bubble.pictogram):
(.status-line.bad .bubble.pictogram):
(.status-line.no-bubble .message):
(.status-line.bad .bubble):
(.status-line.good .bubble):
(.status-line.good .message):
(.status-line.bad .message):
(body.accessibility-colors .status-line.good .bubble):
(body.accessibility-colors .status-line.bad .bubble):
(body.accessibility-colors .status-line.good .message):
(body.accessibility-colors .status-line.bad .message):
(.status-line.danger .message):
(.status-line.unauthorized .message):

11:23 PM Changeset in webkit [185192] by Alan Bujtas
  • 4 edits
    2 copies
    2 adds in trunk

Use borderBoxRect instead of contentBoxRect for backdrop filter.
​https://bugs.webkit.org/show_bug.cgi?id=145606

Reviewed by Simon Fraser.

Backdrop filter should use border box rect. It also needs to take css clip into account.

Source/WebCore:

Tests: css3/filters/backdrop/backdrop-filter-with-cliprect.html

css3/filters/backdrop/backdrop-filter-with-mask.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateBackdropFiltersGeometry):

LayoutTests:

  • css3/filters/backdrop/backdrop-filter-does-not-size-properly-border-and-padding-expected.txt:
  • css3/filters/backdrop/backdrop-filter-with-cliprect-expected.txt: Added.
  • css3/filters/backdrop/backdrop-filter-with-cliprect.html: Added.
  • css3/filters/backdrop/backdrop-filter-with-mask-expected.txt: Added.
  • css3/filters/backdrop/backdrop-filter-with-mask.html: Added.
11:06 PM Changeset in webkit [185191] by youenn.fablet@crf.canon.fr
  • 3 edits in trunk/Source/WebCore

MediaDevices.getUserMedia should put promises in resolve/reject state synchronously
​https://bugs.webkit.org/show_bug.cgi?id=145308

Reviewed by Darin Adler.

Removed the calls to callToMainThread in which were resolved and rejected promises.
Cleaned up the code to remove unneeded callback copies.

Covered by existing tests.

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):
(WebCore::UserMediaRequest::didCreateStream):
(WebCore::UserMediaRequest::failedToCreateStreamWithConstraintsError):
(WebCore::UserMediaRequest::failedToCreateStreamWithPermissionError):

  • Modules/mediastream/UserMediaRequest.h:
10:35 PM Changeset in webkit [185190] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Made WKBackForwardListItemPrivate.h a private header after it was added as internal in r185183.

  • WebKit2.xcodeproj/project.pbxproj:
10:19 PM Changeset in webkit [185189] by Gyuyoung Kim
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening on 4th June.

Skip a test regarding emoji font, mark timeout to animation tests.
Update a track test and a xhr test.

  • platform/efl/TestExpectations:
10:14 PM Changeset in webkit [185188] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[EFL] Implement window_object_cleared callback in EwkPageClient.
​https://bugs.webkit.org/show_bug.cgi?id=145603

Patch by Hyungwook Lee <​hyungwook.lee@navercorp.com> on 2015-06-03
Reviewed by Gyuyoung Kim.

We need to provide right timing for custom JS API that may need to work at the beginning of the page.

  • UIProcess/API/efl/tests/extensions/extension_sample.cpp:
  • WebProcess/InjectedBundle/API/efl/ewk_page.cpp:

(EwkPage::EwkPage):
(EwkPage::didStartProvisionalLoadForFrame):
(EwkPage::didClearWindowObjectForFrame):
(EwkPage::didFinishDocumentLoadForFrame):

  • WebProcess/InjectedBundle/API/efl/ewk_page.h:
  • WebProcess/InjectedBundle/API/efl/ewk_page_private.h:
9:42 PM Changeset in webkit [185187] by Simon Fraser
  • 3 edits
    2 adds in trunk

REGRESSION (r184968): missing media player buttons (control bar exists, but no buttons)
​https://bugs.webkit.org/show_bug.cgi?id=145630

Reviewed by Zalan Bujtas.

Source/WebCore:

r184968 changed the initial value of m_intersectsCoverageRect to false. However,
this triggered a bug with mask layers, whose value of m_intersectsCoverageRect was never
updated.

Fix by copying the value of m_intersectsCoverageRect from the main layer to its
mask layer, just as we do for m_visibleRect and m_coverageRect.

Test: compositing/visible-rect/mask-layer-coverage.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setVisibleAndCoverageRects):

LayoutTests:

Test that dumps coverage info for a layer with a mask.

  • compositing/visible-rect/mask-layer-coverage-expected.txt: Added.
  • compositing/visible-rect/mask-layer-coverage.html: Added.
9:42 PM Changeset in webkit [185186] by Simon Fraser
  • 5 edits in trunk

Layer tree dumps should include mask layers
​https://bugs.webkit.org/show_bug.cgi?id=145629

Reviewed by Zalan Bujtas.
Source/WebCore:

Dumping the layer tree omitted to dump the mask layer, so fix
GraphicsLayer::dumpProperties() to dump this layer.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::dumpProperties):

LayoutTests:

New results.

  • compositing/masks/compositing-clip-path-change-no-repaint-expected.txt:
  • compositing/masks/mask-layer-size-expected.txt:
9:19 PM Changeset in webkit [185185] by commit-queue@webkit.org
  • 5 edits in trunk

AX: Expose field sets to accessibility clients
​https://bugs.webkit.org/show_bug.cgi?id=145585

Source/WebCore:

Expose fieldsets to the accessibility API via a subrole of AXFieldset.

Patch by Greg Hughes <​ghughes@apple.com> on 2015-06-03
Reviewed by Chris Fleizach.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper subrole]):

LayoutTests:

Updated role tests to include the new subrole for fieldsets

Patch by Greg Hughes <​ghughes@apple.com> on 2015-06-03
Reviewed by Chris Fleizach.

  • platform/mac/accessibility/roles-exposed-expected.txt:
8:42 PM Changeset in webkit [185184] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: if a known CSS property has an unsupported value, only strikethrough the value
​https://bugs.webkit.org/show_bug.cgi?id=141262

Patch by Devin Rousso <Devin Rousso> on 2015-06-03
Reviewed by Timothy Hatcher.

  • UserInterface/Models/CSSCompletions.js:

(WebInspector.CSSCompletions.prototype.nameMatchesValidPropertyExactly): Loops through the full property list and returns true only if a property exactly matches the given property name.
(WebInspector.CSSCompletions): Added nameMatchesValidPropertyExactly function.

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded): Added logic to limit the invalid class marker to only the property value if the property name is an actual property.

7:55 PM Changeset in webkit [185183] by andersca@apple.com
  • 4 edits
    1 copy in trunk/Source/WebKit2

Add SPI that returns the snapshot layer contents for a given back/forward list item
​https://bugs.webkit.org/show_bug.cgi?id=145621

Reviewed by Dan Bernstein.

  • UIProcess/API/Cocoa/WKBackForwardListItem.mm:

(-[WKBackForwardListItem _snapshotLayerContents]):

  • UIProcess/API/Cocoa/WKBackForwardListItemInternal.h:
  • UIProcess/API/Cocoa/WKBackForwardListItemPrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardListItemInternal.h.
  • WebKit2.xcodeproj/project.pbxproj:
7:55 PM Changeset in webkit [185182] by mmaxfield@apple.com
  • 4 edits in trunk/Source/WebCore

Remove dead code FontPlatformData::roundsGlyphAdvances()
​https://bugs.webkit.org/show_bug.cgi?id=145628

Reviewed by Simon Fraser.

No new tests because there is no behavior change.

  • WebCore.order:
  • platform/graphics/FontPlatformData.h:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::roundsGlyphAdvances): Deleted.

7:01 PM WebKitGTK/WebKit2Roadmap edited by clopez@igalia.com
(diff)
5:07 PM Changeset in webkit [185181] by Said Abou-Hallawa
  • 2 edits in trunk/LayoutTests

Skip webgl/useWhilePending.html on WebKit 1 following:
<​http://trac.webkit.org/changeset/185172>

Unreviewed.

  • platform/mac-wk1/TestExpectations:
5:03 PM Changeset in webkit [185180] by ryuan.choi@navercorp.com
  • 9 edits
    1 move
    1 delete in trunk/Source/WebCore

[CoordinatedGraphics] Merge CoordinatedTile into Tile
​https://bugs.webkit.org/show_bug.cgi?id=145602

Reviewed by Darin Adler.

CoordinatedTile only implements Tile since Qt and WebKit1/Efl were dropped.
So, there is no reason that CoordinatedTile inherits Tile interface.

No new tests, no behavior changes.

  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
  • platform/graphics/texmap/coordinated/CoordinatedTile.cpp: Renamed to Tile.cpp
  • platform/graphics/texmap/coordinated/CoordinatedTile.h: Merged into Tile.h

(WebCore::CoordinatedTile::coordinate): Deleted.
(WebCore::CoordinatedTile::rect): Deleted.

  • platform/graphics/texmap/coordinated/Tile.cpp: Renamed from CoordinatedTile.cpp.
  • platform/graphics/texmap/coordinated/Tile.h:
  • platform/graphics/texmap/coordinated/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::createTiles):

4:41 PM Changeset in webkit [185179] by commit-queue@webkit.org
  • 8 edits
    3 adds in trunk/Source/WebCore

Add basic Media Session support to HTMLMediaElement.
​https://bugs.webkit.org/show_bug.cgi?id=145581

Patch by Matt Rajca <​mrajca@apple.com> on 2015-06-03
Reviewed by Eric Carlson.

HTMLMediaElements now have:

  • a 'kind' attribute representing the intrinsic media category
  • a 'session' attribute representing the current media session, if any
  • CMakeLists.txt: Include the new HTMLMediaElementMediaSession sources.
  • DerivedSources.make: Include the new IDL file.
  • Modules/mediasession/HTMLMediaElementMediaSession.cpp: Added.

(WebCore::HTMLMediaElementMediaSession::session):

  • Modules/mediasession/HTMLMediaElementMediaSession.h: Added basic translation of the IDL file.

(WebCore::HTMLMediaElementMediaSession::kind):
(WebCore::HTMLMediaElementMediaSession::setKind):
(WebCore::HTMLMediaElementMediaSession::setSession):

  • Modules/mediasession/HTMLMediaElementMediaSession.idl: Added from the Media Session spec.
  • PlatformMac.cmake: Include DOMHTMLMediaElementMediaSession.cpp.
  • WebCore.xcodeproj/project.pbxproj: Include the new HTMLMediaElementMediaSession sources.
  • html/HTMLMediaElement.h: Added accessors for 'kind' and 'session'.

(WebCore::HTMLMediaElement::kind):
(WebCore::HTMLMediaElement::setKind):
(WebCore::HTMLMediaElement::session):
(WebCore::HTMLMediaElement::setSession):

4:35 PM Changeset in webkit [185178] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Unreviewed build fix for Dromaeo.

  • Scripts/webkitpy/benchmark_runner/benchmark_results.py:

(BenchmarkResults._aggregate_results_for_test):

3:51 PM Changeset in webkit [185177] by andersca@apple.com
  • 2 edits in trunk/Tools

Fix build.

  • DumpRenderTree/mac/TestRunnerMac.mm:
3:50 PM Changeset in webkit [185176] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Cleanup after r185175.
​https://bugs.webkit.org/show_bug.cgi?id=145569
<rdar://problem/20671711>

Unreviewed.

No new tests because there is no behavior change.

  • platform/graphics/WidthIterator.h:
3:48 PM Changeset in webkit [185175] by mmaxfield@apple.com
  • 4 edits
    3 adds in trunk

SoftBank Emoji are not transformed by shaping when in a run of their own
​https://bugs.webkit.org/show_bug.cgi?id=145569
<rdar://problem/20671711>

Reviewed by Dean Jackson.

Normally, we don't perform shaping on single glyphs. However, these particular codepoints
need to have shaping run on them, even if they are alone.

Test: fast/text/softbank-emoji.html Note that this test may fail in different locales on
different platforms. This patch disables the test on iOS.

  • Source/WebCore/platform/graphics/WidthIterator.cpp:

(WebCore::applyFontTransforms): Move the length-of-1 check into shouldApplyFontTransforms()
(WebCore::shouldApplyFontTransforms): Return true if we have one of these emoji characters in
a run of its own
(WebCore::advanceInternal): Keep track of the previous character, and use it to call
shouldApplyFontTransforms.

  • Source/WebCore/platform/graphics/WidthIterator.h: shouldApplyFontTransforms() needs

some more information to perform its duties.

3:46 PM Changeset in webkit [185174] by Said Abou-Hallawa
  • 1 edit
    2 adds in trunk/LayoutTests

Add missing expected result files for ios-simulator port following
<​http://trac.webkit.org/changeset/185095>
<​http://trac.webkit.org/changeset/185096>

Unreviewed.

  • platform/ios-simulator/fast/text/crash-complex-text-surrogate-expected.txt: Added.
  • platform/ios-simulator/fast/text/font-weights-zh-expected.txt: Added.
3:35 PM Changeset in webkit [185173] by dbates@webkit.org
  • 3 edits
    3 adds in trunk

Caps lock indicator should not be shown in read-only or disabled field
​https://bugs.webkit.org/show_bug.cgi?id=145612
<rdar://problem/21227454>

Reviewed by Darin Adler.

.:

  • ManualTests/password-caps-lock-should-not-show-in-read-only-field.html: Added.
  • ManualTests/password-caps-lock-should-not-show-when-field-becomes-disabled.html: Added.
  • ManualTests/password-caps-lock-should-not-show-when-field-becomes-read-only.html: Added.

Source/WebCore:

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::disabledAttributeChanged): Update caps lock indicator state.
(WebCore::TextFieldInputType::readonlyAttributeChanged): Ditto.
(WebCore::TextFieldInputType::shouldDrawCapsLockIndicator): Do not draw the caps lock indicator
when the field is read-only or disabled.

3:32 PM Changeset in webkit [185172] by dino@apple.com
  • 8 edits
    2 adds in trunk

Crash in GraphicsContext3D::getInternalFramebufferSize
​https://bugs.webkit.org/show_bug.cgi?id=145479
<rdar://problem/16461048>

Reviewed by Eric Carlson.

Source/WebCore:

If we are in an unitialized or lost state, don't try to access the context.

In order to test this, I added an Internal setting that always
forces WebGL into a pending state.

Test: fast/canvas/webgl/useWhilePending.html

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::create): Check internal settings for
a forced pending state.
(WebCore::WebGLRenderingContextBase::drawingBufferWidth): Guard against a pending state.
(WebCore::WebGLRenderingContextBase::drawingBufferHeight): Ditto.

  • page/Settings.cpp: New Internal setting for forcing a pending policy.

(WebCore::Settings::Settings):
(WebCore::Settings::setForcePendingWebGLPolicy):

  • page/Settings.h:

(WebCore::Settings::isForcePendingWebGLPolicy):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setForcePendingWebGLPolicy):

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:

LayoutTests:

Attemps to use a WebGL context while it is in the pending state.

  • fast/canvas/webgl/useWhilePending-expected.txt: Added.
  • fast/canvas/webgl/useWhilePending.html: Added.
3:29 PM Changeset in webkit [185171] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

AutoFill button should not be shown in read-only or disabled field
​https://bugs.webkit.org/show_bug.cgi?id=145579
<rdar://problem/21212494>

Update expected result for Windows that I inadvertently modified in <​http://trac.webkit.org/changeset/185166>.

  • platform/win/fast/forms/auto-fill-button/input-auto-fill-button-expected.txt:
3:00 PM Changeset in webkit [185170] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

[iOS] Skip compositing/layer-creation/zoomed-clip-intersection.html
eventSender.scalePageBy() needs to be implemented.

Unreviewed garderning.

  • platform/ios-simulator/TestExpectations:
2:43 PM Changeset in webkit [185169] by dbates@webkit.org
  • 3 edits in trunk/Tools

WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac
​https://bugs.webkit.org/show_bug.cgi?id=145616

Skip the test on Mac for now to avoid having the bots turn red due to the flakiness
of the test. Further investigation is needed.

  • TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
  • TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
2:21 PM Changeset in webkit [185168] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Define WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS on iOS
​https://bugs.webkit.org/show_bug.cgi?id=145615
Part of rdar://problem/17380856.

Reviewed by Dan Bernstein.

  • postprocess-headers.sh:
1:52 PM Changeset in webkit [185167] by commit-queue@webkit.org
  • 24 edits in trunk/Source/WebCore

Use modern for-loops in WebCore/page.
​https://bugs.webkit.org/show_bug.cgi?id=145455

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-06-03
Reviewed by Darin Adler.

No new tests, no behavior changes.

  • page/Chrome.cpp:

(WebCore::Chrome::notifyPopupOpeningObservers):

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPSourceList::matches):
(WebCore::CSPDirectiveList::gatherReportURIs):
(WebCore::ContentSecurityPolicy::copyStateFrom):
(WebCore::isAllowedByAll):
(WebCore::isAllowedByAllWithState):
(WebCore::isAllowedByAllWithContext):
(WebCore::isAllowedByAllWithURL):
(WebCore::ContentSecurityPolicy::evalDisabledErrorMessage):
(WebCore::ContentSecurityPolicy::allowPluginType):
(WebCore::ContentSecurityPolicy::reflectedXSSDisposition):
(WebCore::ContentSecurityPolicy::gatherReportURIs):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
(WebCore::DOMWindow::dispatchAllPendingUnloadEvents):
(WebCore::DOMWindow::willDestroyCachedFrame):
(WebCore::DOMWindow::willDestroyDocumentInFrame):
(WebCore::DOMWindow::willDetachDocumentFromFrame):
(WebCore::DOMWindow::disconnectDOMWindowProperties):
(WebCore::DOMWindow::reconnectDOMWindowProperties):
(WebCore::DOMWindow::getMatchedCSSRules):

  • page/DeviceController.cpp:

(WebCore::DeviceController::dispatchDeviceEvent):
(WebCore::DeviceController::fireDeviceEvent):

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::handleTouchEvent):

  • page/FocusController.cpp:

(WebCore::FocusController::setIsVisibleAndActiveInternal):

  • page/Frame.cpp:

(WebCore::Frame::orientationChanged):
(WebCore::Frame::injectUserScriptsForWorld):

  • page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::serviceScriptedAnimations):
(WebCore::FrameView::trackedRepaintRectsAsText):
(WebCore::FrameView::updateWidgetPositions):
(WebCore::FrameView::notifyWidgets):

  • page/Page.cpp:

(WebCore::networkStateChanged):
(WebCore::Page::stringToViewMode):
(WebCore::Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment):
(WebCore::Page::refreshPlugins):
(WebCore::Page::lockAllOverlayScrollbarsToHidden):
(WebCore::Page::pluginViews):
(WebCore::Page::storageBlockingStateChanged):
(WebCore::Page::setIsVisibleInternal):

  • page/PageGroup.cpp:

(WebCore::PageGroup::captionPreferencesChanged):

  • page/PageGroupLoadDeferrer.cpp:

(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

  • page/Performance.cpp:

(WebCore::Performance::webkitGetEntriesByType):
(WebCore::Performance::webkitGetEntriesByName):

  • page/PerformanceResourceTiming.cpp:

(WebCore::passesTimingAllowCheck):

  • page/PerformanceUserTiming.cpp:

(WebCore::convertToEntrySequence):

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::isAccessWhiteListed):

  • page/UserContentURLPattern.cpp:

(WebCore::UserContentURLPattern::matchesPatterns):

  • page/WindowFeatures.cpp:

(WebCore::WindowFeatures::parseDialogFeatures):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
(WebCore::AnimationControllerPrivate::numberOfActiveAnimations):

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::ShorthandPropertyWrapper::equals):
(WebCore::ShorthandPropertyWrapper::blend):

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::setStateScrollingNodeSnapOffsetsAsFloat):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::absoluteNonFastScrollableRegionForFrame):
(WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects):

1:44 PM Changeset in webkit [185166] by dbates@webkit.org
  • 3 edits
    6 moves
    14 adds in trunk

AutoFill button should not be shown in read-only or disabled field
​https://bugs.webkit.org/show_bug.cgi?id=145579
<rdar://problem/21212494>

Reviewed by Darin Adler.

Source/WebCore:

Fixes an issue where the AutoFill button is shown in a read-only or disabled
field. We should not show the AutoFill button in such cases.

Tests: fast/forms/auto-fill-button/hide-auto-fill-button-when-input-becomes-disabled.html

fast/forms/auto-fill-button/hide-auto-fill-button-when-input-becomes-readonly.html
fast/forms/auto-fill-button/input-auto-fill-button.html
fast/forms/auto-fill-button/input-disabled-auto-fill-button.html
fast/forms/auto-fill-button/input-readonly-auto-fill-button.html
fast/forms/auto-fill-button/input-readonly-non-empty-auto-fill-button.html

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::disabledAttributeChanged): Update AutoFill button state.
(WebCore::TextFieldInputType::readonlyAttributeChanged): Ditto.
(WebCore::TextFieldInputType::shouldDrawAutoFillButton): Do not draw AutoFill button
when the field is disabled or read-only.

LayoutTests:

Add tests to ensure that we do no show the AutoFill button in a read-only or disabled field.

Additionally, create directory LayoutTests/fast/forms/auto-fill-button and move existing test
LayoutTests/fast/forms/input-auto-fill-button.html and associated test results into this directory
or the platform-specific variant of this directory.

  • fast/forms/auto-fill-button/hide-auto-fill-button-when-input-becomes-disabled-expected.html: Added.
  • fast/forms/auto-fill-button/hide-auto-fill-button-when-input-becomes-disabled.html: Added.
  • fast/forms/auto-fill-button/hide-auto-fill-button-when-input-becomes-readonly-expected.html: Added.
  • fast/forms/auto-fill-button/hide-auto-fill-button-when-input-becomes-readonly.html: Added.
  • fast/forms/auto-fill-button/input-auto-fill-button-expected.txt: Renamed from LayoutTests/fast/forms/input-auto-fill-button-expected.txt.
  • fast/forms/auto-fill-button/input-auto-fill-button.html: Renamed from LayoutTests/fast/forms/input-auto-fill-button.html.
  • fast/forms/auto-fill-button/input-disabled-auto-fill-button-expected.html: Added.
  • fast/forms/auto-fill-button/input-disabled-auto-fill-button.html: Added.
  • fast/forms/auto-fill-button/input-readonly-auto-fill-button-expected.html: Added.
  • fast/forms/auto-fill-button/input-readonly-auto-fill-button.html: Added.
  • fast/forms/auto-fill-button/input-readonly-non-empty-auto-fill-button-expected.html: Added.
  • fast/forms/auto-fill-button/input-readonly-non-empty-auto-fill-button.html: Added.
  • platform/ios-simulator/fast/forms/auto-fill-button/input-auto-fill-button-expected.png: Renamed from LayoutTests/platform/ios-simulator/fast/forms/input-auto-fill-button-expected.png.
  • platform/ios-simulator/fast/forms/auto-fill-button/input-auto-fill-button-expected.txt: Renamed from LayoutTests/platform/ios-simulator/fast/forms/input-auto-fill-button-expected.txt.
  • platform/mac-mavericks/fast/forms/auto-fill-button/input-auto-fill-button-expected.txt: Renamed from LayoutTests/platform/mac-mavericks/fast/forms/input-auto-fill-button-expected.txt.
  • platform/win/fast/forms/auto-fill-button/input-auto-fill-button-expected.txt: Renamed from LayoutTests/platform/win/fast/forms/input-auto-fill-button-expected.txt.
1:39 PM Changeset in webkit [185165] by andersca@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Remove ChangeLog entry; Mark Lam already fixed this yesterday.

1:37 PM Changeset in webkit [185164] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Search field bottom border doesn't match the rest of the toolbar
​https://bugs.webkit.org/show_bug.cgi?id=145611

Reviewed by Timothy Hatcher.

  • UserInterface/Views/Toolbar.css:

(body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]):

1:36 PM Changeset in webkit [185163] by andersca@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fix build.

The exitingJITType parameter has been removed, so remove its UNUSED_PARAM declaration.

  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeExitSiteData):

1:34 PM Changeset in webkit [185162] by Alan Bujtas
  • 2 edits in trunk/PerformanceTests

Skip Dromaeo/jslib-modify-prototype.html for now.

Unreviewed gardening.

  • Skipped:
1:08 PM Changeset in webkit [185161] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

CallLinkStatus should return takesSlowPath if the GC often cleared the IC
​https://bugs.webkit.org/show_bug.cgi?id=145502

Reviewed by Geoffrey Garen.

CallLinkInfo now remembers when it has been cleared by GC. This has some safeguards for when
a call gets cleared by GC only because we hadn't converted it into a closure call; in that
case the GC will just tell us that it should be a closure call. The DFG will not optimize
a call that was cleared by GC, and the DFG will always prefer a closure call if the GC told
us that the specific callee was dead but the executable wasn't.

This guards us from some scenarios that came up in Speedometer. It's neutral on the pure JS
benchmarks, most likely just because those benchmarks aren't real enough to have interesting
GC of code.

  • bytecode/CallLinkInfo.cpp:

(JSC::CallLinkInfo::visitWeak):
(JSC::CallLinkInfo::dummy):

  • bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::CallLinkInfo):

  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFromCallLinkInfo):

1:04 PM Changeset in webkit [185160] by fpizlo@apple.com
  • 9 edits
    6 adds in trunk

GetById and PutById profiling should be more precise about it takes slow path
​https://bugs.webkit.org/show_bug.cgi?id=145590

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

If a ById access ever takes slow path, we want the DFG and FTL to know this. Previously we
were relying on slow path counts, which conflate slow paths taken due to a megamorphic
access and slow paths taken due to IC building.

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFor):
(JSC::GetByIdStatus::computeForStubInfo):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::StructureStubInfo):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetById):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:

LayoutTests:

Added just two more tests for getters and setters. I needed more microbenchmarks to track
down a regression in an earlier version of this patch.

  • js/regress/getter-prototype-expected.txt: Added.
  • js/regress/getter-prototype.html: Added.
  • js/regress/script-tests/getter-prototype.js: Added.
  • js/regress/script-tests/setter-prototype.js: Added.
  • js/regress/setter-prototype-expected.txt: Added.
  • js/regress/setter-prototype.html: Added.
12:46 PM Changeset in webkit [185159] by Alan Bujtas
  • 21 edits in trunk/LayoutTests

[iOS] Rebaseline expected results for <br>

Unreviewed garderning.

  • platform/ios-simulator-wk2/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/ios-simulator-wk2/fast/forms/listbox-hit-test-zoomed-expected.txt:
  • platform/ios-simulator/http/tests/navigation/postredirect-basic-expected.txt:
  • platform/ios-simulator/http/tests/navigation/postredirect-goback1-expected.txt:
  • platform/ios-simulator/tables/mozilla/bugs/bug106795-expected.txt:
  • platform/ios-simulator/tables/mozilla/bugs/bug1224-expected.txt:
  • platform/ios-simulator/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/ios-simulator/tables/mozilla/bugs/bug131020_iframe-expected.txt:
  • platform/ios-simulator/tables/mozilla/bugs/bug1430-expected.txt:
  • platform/ios-simulator/tables/mozilla/bugs/bug16252-expected.txt:
  • platform/ios-simulator/tables/mozilla/bugs/bug19599-expected.txt:
  • platform/ios-simulator/tables/mozilla/bugs/bug20579-expected.txt:
  • platform/ios-simulator/tables/mozilla/bugs/bug32205-3-expected.txt:
  • platform/ios-simulator/tables/mozilla/bugs/bug82946-2-expected.txt:
  • platform/ios-simulator/tables/mozilla/bugs/bug92143-expected.txt:
  • platform/ios-simulator/tables/mozilla/marvin/tables_cellpadding-expected.txt:
  • platform/ios-simulator/tables/mozilla/marvin/tables_cellspacing-expected.txt:
  • platform/ios-simulator/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug1262-expected.txt:
  • platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
11:48 AM Changeset in webkit [185158] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Improve test coverage for changes made in 145527
​https://bugs.webkit.org/show_bug.cgi?id=145578

Reviewed by Geoffrey Garen.

Added more complexity to poly-setter-combo.js stress test to create more turmoil in the
polymorphic get-by-id / put-by-id with getters and setters to exercise the code change in
​https://bugs.webkit.org/show_bug.cgi?id=145527. By changing the objects that the main test
function sees, we are able to test those paths. Verified with temporary logging code.

  • tests/stress/poly-setter-combo.js:

(Cons2):
(Cons3):
(Cons4):
(foo):
(test):
(runTestWithConstructors):

11:44 AM Changeset in webkit [185157] by Said Abou-Hallawa
  • 1 edit
    3 adds in trunk/LayoutTests

Add missing expected result files for GTK and EFL ports following
<​http://trac.webkit.org/changeset/185095>
<​http://trac.webkit.org/changeset/181351>

Unreviewed.

  • platform/efl/fast/text/crash-complex-text-surrogate-expected.txt: Added.
  • platform/gtk/editing/selection/extend-by-character-007-expected.txt: Added.
  • platform/gtk/fast/text/crash-complex-text-surrogate-expected.txt: Added.
11:37 AM Changeset in webkit [185156] by Brent Fulgham
  • 3 edits
    4 adds in trunk

REGRESSION: (r181879): Scrolling in select/option region in iFrame scrolls both select and iframe
​https://bugs.webkit.org/show_bug.cgi?id=145574
<rdar://problem/20966828>

Reviewed by Simon Fraser.

Source/WebCore:

Tested by platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-select.html

When the scroll gesture is started when the latched scrollable container is not at the limit of its
scroll region, we are NOT supposed to propagate the scroll event to the enclosing region. However,
we were doing two things wrong:
(1) When we recognized we were latching, we were using the right wheel event target, but not using

the latched scrollable container.

(2) Likewise, we were not using latched ScrollableArea when handling wheel events.

Instead, we were using the current scrollable container and ScrollableArea under the mouse pointer,
which could be different from the point we started latching as the content scrolled.

The fix was to properly track the scrollable container and scrollable area during latching.

I attempted to store the latched ScrollableArea in the latchingState object, like we already do for the
scrollable container, but found that this did not work properly. I think the life cycle of the
ScrollableArea may not match the scrollable container, and since they are not reference counted I
simply retrieve the ScrollableArea when needed.

  • page/mac/EventHandlerMac.mm:

(WebCore::scrollableAreaForContainerNode): Helper function to return the correct ScrollableArea
for the two types of RenderBox elements.
(WebCore::latchedToFrameOrBody): Helper predicate to identify Frame and Body elements.
(WebCore::EventHandler::platformPrepareForWheelEvents): Use the correct ScrollableArea for the given
ContainerNode. When latching, make sure to use the ScrollableArea that is related to the latched scrollable
container, not the area currently underneath the mouse pointer.

LayoutTests:

  • platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-select-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-select.html: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/frames/select_iframe.html: Added.
10:33 AM Changeset in webkit [185155] by beidson@apple.com
  • 9 edits
    13 adds in trunk

REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs
​https://bugs.webkit.org/show_bug.cgi?id=145580

Reviewed by Mark Lam.

Source/WebCore:

Tests: fast/loader/fragment-navigation-base-blank.html

fast/loader/iframe-meta-refresh-base-blank.html
fast/loader/iframe-set-location-base-blank.html
fast/loader/refresh-iframe-base-blank.html

Before 183498, callers of FrameLoader::changeLocation() got automatically assigned a frame name of "_self".
After 183498, many remained without a frame name.

Later on, FrameLoader applies the <base> target as their frame name if they don't already have one.

When the <base> target is "_blank", that causes a new window/tab.

Restoring "_self" to these call sites fixes this.

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::openInNewTab):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::navigate):

  • loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::FrameLoadRequest):

  • loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::scheduleLocationChange):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::createWindow):

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame"

LayoutTests:

  • fast/loader/fragment-navigation-base-blank-expected.txt: Added.
  • fast/loader/fragment-navigation-base-blank.html: Added.
  • fast/loader/iframe-meta-refresh-base-blank-expected.txt: Added.
  • fast/loader/iframe-meta-refresh-base-blank.html: Added.
  • fast/loader/iframe-set-location-base-blank-expected.txt: Added.
  • fast/loader/iframe-set-location-base-blank.html: Added.
  • fast/loader/refresh-iframe-base-blank-expected.txt: Added.
  • fast/loader/refresh-iframe-base-blank.html: Added.
  • fast/loader/resources/fragment-navigation-base-blank.html: Added.
  • fast/loader/resources/iframe-meta-refresh-base-blank.html: Added.
  • fast/loader/resources/iframe-set-location-base-blank.html: Added.
  • fast/loader/resources/notify-done-with-window-count.html: Added.
  • fast/loader/resources/refresh-iframe-base-blank-frame.html: Added.
9:56 AM Changeset in webkit [185154] by ap@apple.com
  • 2 edits in trunk/Tools

Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after ​http://trac.webkit.org/r185147

  • TestWebKitAPI/Tests/WebCore/CSSParser.cpp:

(TestWebKitAPI::TEST): Update the syntax.

9:40 AM Changeset in webkit [185153] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

More iOS build fixing.

  • platform/spi/mac/AVFoundationSPI.h:
8:36 AM Changeset in webkit [185152] by Alan Bujtas
  • 4 edits
    2 adds in trunk

Subpixel rendering: Composited layer with subpixel gap does not get painted properly when its position changes.
​https://bugs.webkit.org/show_bug.cgi?id=145587

Reviewed by Simon Fraser.

The composited layer always snaps to an enclosing device pixel (floors) while the renderer rounds.
At certain positions (for example 0.5px on a 1x display), a gap is formed between the layer(0px) and its renderer(1px).
In such cases, when the the renderer moves to a position (1.1px) where the gap is closed, we need to issue repaint on the layer
in order to get the renderering right.

Source/WebCore:

Test: compositing/child-layer-with-subpixel-gap-needs-repaint-when-parent-moves.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterLayout):
(WebCore::devicePixelFractionGapFromRendererChanged):
(WebCore::RenderLayerBacking::updateGeometry):

  • rendering/RenderLayerBacking.h:

LayoutTests:

  • compositing/child-layer-with-subpixel-gap-needs-repaint-when-parent-moves-expected.html: Added.
  • compositing/child-layer-with-subpixel-gap-needs-repaint-when-parent-moves.html: Added.
7:58 AM Changeset in webkit [185151] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught exception starting a NavigationBar drag and mousing over a different NavigationBar
​https://bugs.webkit.org/show_bug.cgi?id=145589

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-03
Reviewed by Timothy Hatcher.

  • UserInterface/Views/NavigationBar.js:

(WebInspector.NavigationBar.prototype._mouseDown):
(WebInspector.NavigationBar.prototype._mouseUp):
When mouse dragging for navigation bars, only match against navigation
bar items inside this navigation bar. Also, fix horizontal detection
of navigation bar items by scanning in the middle of the navigation
bar instead of the top, which missed the items.

7:55 AM Changeset in webkit [185150] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Debugger Popover for Node object should have go-to-arrow to show the node in DOM tree
​https://bugs.webkit.org/show_bug.cgi?id=145594

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-03
Reviewed by Timothy Hatcher.

  • UserInterface/Controllers/DOMTreeManager.js:

(WebInspector.DOMTreeManager.prototype.inspectElement):
Previously we could get an exception later on if we tried to
inspect an element that was not in the DOM. Bail if the node
is not in the DOM or not.

  • UserInterface/Views/SourceCodeTextEditor.css:

(.popover .debugger-popover-content > .title > .go-to-arrow):

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._showPopoverForObject.data.pushNodeToFrontend):
(WebInspector.SourceCodeTextEditor.prototype._showPopoverForObject):
For a node type, add a go-to-arrow in the popover if it is in the DOM or not.

1:16 AM WebKitGTK/StartHacking edited by Diego Pino Garcia
(diff)
12:35 AM Changeset in webkit [185149] by youenn.fablet@crf.canon.fr
  • 2 edits in trunk/Source/WebCore

[Streams API] ReadableStreamReader::closed() should be called once by binding code
​https://bugs.webkit.org/show_bug.cgi?id=145551

Reviewed by Darin Adler.

Covered by existing tests.

  • bindings/js/JSReadableStreamReaderCustom.cpp:

(WebCore::JSReadableStreamReader::closed): Calling ReadableStreamReader::closed only at creation of the promise.

Jun 2, 2015:

11:58 PM Changeset in webkit [185148] by Gyuyoung Kim
  • 2 edits in trunk/Source/WebCore

[EFL][GTK] Fix build error since r185137
​https://bugs.webkit.org/show_bug.cgi?id=145596

Unreviewed, fix build break on EFL and GTK port.

  • dom/Text.cpp:

(WebCore::Text::formatForDebugger): Use strncpy() instead of strlcpy().

11:44 PM Changeset in webkit [185147] by svillar@igalia.com
  • 37 edits in trunk

[CSS Grid Layout] Switch from parenthesis to brackets for grid line names
​https://bugs.webkit.org/show_bug.cgi?id=144996

Reviewed by Darin Adler.

Source/WebCore:

Grid line names are now enclosed by brackets instead of parentheses
as mentioned in the latest version of the spec. Appartently the CSS
code is now more readable and avoids issues with tools like SASS.

  • css/CSSGrammar.y.in:
  • css/CSSGridLineNamesValue.cpp:

(WebCore::CSSGridLineNamesValue::customCSSText):

LayoutTests:

Replaced parentheses by brackets when specifying grid line names.

  • fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
  • fast/css-grid-layout/grid-container-change-named-grid-lines-recompute-child.html:
  • fast/css-grid-layout/grid-element-repeat-get-set-expected.txt:
  • fast/css-grid-layout/grid-element-repeat-get-set.html:
  • fast/css-grid-layout/grid-item-auto-placement-automatic-span.html:
  • fast/css-grid-layout/grid-item-bad-resolution-double-span.html:
  • fast/css-grid-layout/grid-item-column-row-get-set.html:
  • fast/css-grid-layout/grid-item-named-grid-area-resolution.html:
  • fast/css-grid-layout/grid-item-named-grid-line-resolution.html:
  • fast/css-grid-layout/grid-item-negative-position-resolution.html:
  • fast/css-grid-layout/grid-item-position-changed-dynamic.html:
  • fast/css-grid-layout/grid-shorthand-get-set-expected.txt:
  • fast/css-grid-layout/grid-shorthand-get-set.html:
  • fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt:
  • fast/css-grid-layout/grid-template-shorthand-get-set.html:
  • fast/css-grid-layout/named-grid-line-get-set-expected.txt:
  • fast/css-grid-layout/named-grid-line-get-set.html:
  • fast/css-grid-layout/named-grid-lines-computed-style-implicit-tracks-expected.txt:
  • fast/css-grid-layout/named-grid-lines-computed-style-implicit-tracks.html:
  • fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html:
  • fast/css-grid-layout/named-grid-lines-with-named-grid-areas-get-set.html:
  • fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html:
  • fast/css-grid-layout/non-grid-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/non-grid-columns-rows-get-set-multiple-expected.txt:
  • fast/css-grid-layout/non-grid-element-repeat-get-set-expected.txt:
  • fast/css-grid-layout/non-grid-element-repeat-get-set.html:
  • fast/css-grid-layout/non-named-grid-line-get-set-expected.txt:
  • fast/css-grid-layout/non-named-grid-line-get-set.html:
  • fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:

(testInherit):
(testInitial):

  • fast/css-grid-layout/resources/grid-columns-rows-get-set.js:

(testInherit):
(testInitial):

  • fast/css-grid-layout/resources/non-grid-columns-rows-get-set-multiple.js:

(testInherit):
(testInitial):

  • fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js:

(testInherit):
(testInitial):

11:24 PM Changeset in webkit [185146] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

iOS build fix

  • platform/spi/mac/AVFoundationSPI.h:
11:21 PM Changeset in webkit [185145] by commit-queue@webkit.org
  • 9 edits
    2 deletes in trunk

Unreviewed, rolling out r185128 and r185132.
​https://bugs.webkit.org/show_bug.cgi?id=145597

The new test hits a bad assertion (Requested by ap on
#webkit).

Reverted changesets:

"Crash in GraphicsContext3D::getInternalFramebufferSize"
​https://bugs.webkit.org/show_bug.cgi?id=145479
​http://trac.webkit.org/changeset/185128

"Skip webgl/useWhilePending.html on WebKit 1."
​http://trac.webkit.org/changeset/185132

11:19 PM Changeset in webkit [185144] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.34

New tag.

11:18 PM Changeset in webkit [185143] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

10:57 PM Changeset in webkit [185142] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove uses of delete in Sidebar related code
​https://bugs.webkit.org/show_bug.cgi?id=145592

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-02
Reviewed by Timothy Hatcher.

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel.prototype.refresh):
Clear value instead of deleting.

  • UserInterface/Views/SearchSidebarPanel.js:

(WebInspector.SearchSidebarPanel.prototype.performSearch):
Just clear the search identifier. Also assert it (a required string) is always non-falsey.

  • UserInterface/Views/Sidebar.js:

(WebInspector.Sidebar.prototype.resizerDragEnded): Deleted.
This entire callback is unnecessary because whenever we start
a drag we save the value.

10:46 PM Changeset in webkit [185141] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebInspectorUI

Web Inspector: Sidebar and sometimes ContentView scroll position is lost when switching between tabs
​https://bugs.webkit.org/show_bug.cgi?id=145591

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-02
Reviewed by Timothy Hatcher.

  • UserInterface/Views/Sidebar.js:

(WebInspector.Sidebar.prototype.removeSidebarPanel):
When removing a sidebar panel, ensure we call hidden if it was the visible panel.

  • UserInterface/Views/SidebarPanel.js:

(WebInspector.SidebarPanel):
(WebInspector.SidebarPanel.prototype.shown):
(WebInspector.SidebarPanel.prototype.hidden):
Save and restore content element scroll position when sidebar panels are shown / hidden.

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel.prototype.visibilityDidChange):

  • UserInterface/Views/ComputedStyleDetailsPanel.js:

(WebInspector.ComputedStyleDetailsPanel.prototype.shown):

  • UserInterface/Views/DetailsSidebarPanel.js:

(WebInspector.DetailsSidebarPanel.prototype.shown):

  • UserInterface/Views/LayerTreeDetailsSidebarPanel.js:

(WebInspector.LayerTreeDetailsSidebarPanel.prototype.shown):
(WebInspector.LayerTreeDetailsSidebarPanel.prototype.hidden):
Cleanup. Since sidebar panels are using ES6 classes, have super class calls use super!

8:39 PM Changeset in webkit [185140] by ryuan.choi@navercorp.com
  • 8 edits in trunk/Source/WebCore

[CoordinatedGraphics] Refactor TiledBackingStoreClient
​https://bugs.webkit.org/show_bug.cgi?id=145577

Reviewed by Gyuyoung Kim.

This patch removes and simplifies unnecessary virtual methods of TiledBackingStoreClient.

No new tests, no behavior changes.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::didUpdateTileBuffers): Renamed from tiledBackingStorePaintEnd.
(WebCore::CoordinatedGraphicsLayer::tiledBackingStorePaintBegin): Deleted.
(WebCore::CoordinatedGraphicsLayer::tiledBackingStorePaintEnd): Deleted.
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreBackgroundColor):
Deleted because tiledBackingStoreBackgroundColor() is not used anywhere.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
  • platform/graphics/texmap/coordinated/CoordinatedTile.cpp:

(WebCore::CoordinatedTile::updateBackBuffer):
Simplified not to call unnecessary methods. In addition, used modern for loop.
(WebCore::CoordinatedTile::swapBackBufferToFront): Deleted.

  • platform/graphics/texmap/coordinated/CoordinatedTile.h:
  • platform/graphics/texmap/coordinated/Tile.h:
  • platform/graphics/texmap/coordinated/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::updateTileBuffers):

  • platform/graphics/texmap/coordinated/TiledBackingStoreClient.h:
7:46 PM Changeset in webkit [185139] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Use non-monospace font for the frame selector
​https://bugs.webkit.org/show_bug.cgi?id=145586

Reviewed by Timothy Hatcher.

  • UserInterface/Views/HierarchicalPathComponent.css:

(.hierarchical-path-component):

7:33 PM Changeset in webkit [185138] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[EFL] Implement load_started callback in EwkPageClient.
​https://bugs.webkit.org/show_bug.cgi?id=145545

Patch by Hyungwook Lee <​hyungwook.lee@navercorp.com> on 2015-06-02
Reviewed by Gyuyoung Kim.

We need to provide load_started callback to web extension module.

  • UIProcess/API/efl/tests/extensions/extension_sample.cpp:
  • WebProcess/InjectedBundle/API/efl/ewk_page.cpp:

(EwkPage::EwkPage):
(EwkPage::remove):
(EwkPage::didStartProvisionalLoadForFrame):
(EwkPage::didFinishDocumentLoadForFrame):

  • WebProcess/InjectedBundle/API/efl/ewk_page.h:
  • WebProcess/InjectedBundle/API/efl/ewk_page_private.h:
6:29 PM Changeset in webkit [185137] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

AX: debugging attributes for text markers
​https://bugs.webkit.org/show_bug.cgi?id=145283

Patch by Doug Russell <​d_russell@apple.com> on 2015-06-02
Reviewed by Chris Fleizach.

AXTextMarkerDebugDescription: returns the result of
VisiblePosition::formatForDebugger() for the visible position that a text marker
represents.
AXTextMarkerNodeDebugDescription: calls Node::showNode() and
Node::showNodePathForThis() for the visible position that a text marker
represents.
AXTextMarkerNodeTreeDebugDescription: calls Node::showTreeForThis() for the
visible position that a text marker represents.
AXTextMarkerRangeDebugDescription: returns the result of
formatForDebugger(VisiblePositionRange) for the visible position range that a text
marker range represents.

This is debug only tooling. Tests would be flakey and not very helpful.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper debugDescriptionForTextMarker:]):
(-[WebAccessibilityObjectWrapper debugDescriptionForTextMarkerRange:]):
(-[WebAccessibilityObjectWrapper showNodeForTextMarker:]):
(-[WebAccessibilityObjectWrapper showNodeTreeForTextMarker:]):
(formatForDebugger):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

  • dom/Text.cpp:

(WebCore::Text::formatForDebugger):

5:45 PM Changeset in webkit [185136] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

MediaSessions should keep track of their current state.
​https://bugs.webkit.org/show_bug.cgi?id=145575

Patch by Matt Rajca <​mrajca@apple.com> on 2015-06-02
Reviewed by Alex Christensen.

  • Modules/mediasession/MediaSession.h: Per the Media Session spec, the state can be 'Idle', 'Active', or 'Interrupted'. Sessions are created in an 'Idle' state.
4:58 PM Changeset in webkit [185135] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Dashboard arrow icon on the right is overlapped by a long function/file name
​https://bugs.webkit.org/show_bug.cgi?id=145540

Also, increase clickable area of the arrow icon.

Reviewed by Timothy Hatcher.

  • UserInterface/Views/DashboardContainerView.css:

(.dashboard-container .advance-arrow):
(.dashboard-container .advance-arrow.advance-forward):
(.dashboard-container .advance-arrow.advance-backward):

  • UserInterface/Views/DebuggerDashboardView.css:

(.dashboard.debugger > .location):
(.toolbar .dashboard.debugger):
Increase padding on the right so the content of the dashboard would be never be overlayed by the arrow.

4:56 PM Changeset in webkit [185134] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Shift + Cmd + Left/Right shouldn't switch tabs while editing text
​https://bugs.webkit.org/show_bug.cgi?id=145562

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-02
Reviewed by Timothy Hatcher.

  • UserInterface/Views/TabBrowser.js:

(WebInspector.TabBrowser):
Only these keyboard shortcuts should check if we are in an editable field.
Remove the implicit prevent default so they can fall back to system behavior
if necessary.

(WebInspector.TabBrowser.prototype._showNextTabCheckingForEditableField):
(WebInspector.TabBrowser.prototype._showPreviousTabCheckingForEditableField):
Bail if we are in an editable field. Otherwise perform the action and prevent default.

4:51 PM Changeset in webkit [185133] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix when building with internal SDKs
​https://bugs.webkit.org/show_bug.cgi?id=145576
rdar://problem/21089476

Reviewed by Alexey Proskuryakov.

  • platform/spi/mac/AVFoundationSPI.h: Include the right header.
4:45 PM Changeset in webkit [185132] by dino@apple.com
  • 2 edits in trunk/LayoutTests

Skip webgl/useWhilePending.html on WebKit 1.

  • platform/mac-wk1/TestExpectations:
4:33 PM Changeset in webkit [185131] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Gardening: fix broken CLoop build.

Not reviewed.

  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeExitSiteData):

3:23 PM Changeset in webkit [185130] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

No need to guard the sizes attribute against PICTURE_SIZES in preload scanner.
​https://bugs.webkit.org/show_bug.cgi?id=145573
<rdar://problem/21210038>

Reviewed by Myles Maxfield.

The PICTURE_SIZES feature flag doesn't need to be used to
guard preloading of the sizes attribute.

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes): Deleted.
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): Deleted.

3:14 PM Changeset in webkit [185129] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Use UUIDs for WebSQL database filenames instead of a sequential number
​https://bugs.webkit.org/show_bug.cgi?id=145571

Reviewed by Dan Bernstein.

This is a first step towards getting rid of the iOS specific code path where we truncate
database files instead of deleting them (in order to avoid file corruption).

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::generateDatabaseFileName):
(WebCore::DatabaseTracker::fullPathForDatabaseNoLock):

  • platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::getFileNameForNewDatabase): Deleted.

  • platform/sql/SQLiteFileSystem.h:
3:11 PM Changeset in webkit [185128] by dino@apple.com
  • 8 edits
    2 adds in trunk

Crash in GraphicsContext3D::getInternalFramebufferSize
​https://bugs.webkit.org/show_bug.cgi?id=145479
<rdar://problem/16461048>

Reviewed by Eric Carlson.

Source/WebCore:

If we are in an unitialized or lost state, don't try to access the context.

In order to test this, I added an Internal setting that always
forces WebGL into a pending state.

Test: fast/canvas/webgl/useWhilePending.html

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::create): Check internal settings for
a forced pending state.
(WebCore::WebGLRenderingContextBase::drawingBufferWidth): Guard against a pending state.
(WebCore::WebGLRenderingContextBase::drawingBufferHeight): Ditto.

  • page/Settings.cpp: New Internal setting for forcing a pending policy.

(WebCore::Settings::Settings):
(WebCore::Settings::setForcePendingWebGLPolicy):

  • page/Settings.h:

(WebCore::Settings::isForcePendingWebGLPolicy):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setForcePendingWebGLPolicy):

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:

LayoutTests:

Attemps to use a WebGL context while it is in the pending state.

  • fast/canvas/webgl/useWhilePending-expected.txt: Added.
  • fast/canvas/webgl/useWhilePending.html: Added.
3:02 PM Changeset in webkit [185127] by barraclough@apple.com
  • 4 edits in trunk/Source/WebKit2

PDFs always think they're visible on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=145493
<rdar://problem/19668879>

Reviewed by Andreas Kling & Sam Weinig.

The problem here is that WKContentView is currently responsible for notifying the WebPageProxy
that the visibility may have changed, but when a PDF isn't showing the WKContentView isn't in
the view hierarchy and doesn't receive the didMoveToWindow notifications – and the WKPDFView
(which is in the view hierarchy) does not listen for these events.

Visibility of the page should really just track the visibility of the WKWebView (and when
actually assessing the visibility it largely does - the page client checks the web view's
visibility, bar a FIXME, and the foreground/background check, which needs to change).
So notifications should really just come from the WKWebView.

The WKWebView already listens for the didMoveToWindow notification, it just was only updating
the IsInWindow flag. Instead just update all flags, and the call to viewStateDidChange from
WKContentView can just be removed.

There is one problem with this in that it would reverse the order of the calls to
viewStateDidChange & _updateForScreen:, which would mean the the view would become visible before
updating the screen pixel density. To fix this, moving the call to _updateForScreen:
to willMoveToWindow:, to ensure it occurs before the page becomes visible.

This will also change behavior on Mac for WKWebView clients, in coalescing all view state changes
within the didMoveToWindow call. This is the direction we intended to go in anyway (the plan is
to remove the mayHaveChanged argument from viewStateDidChange - we're currently adding unnecessary
IPC traffic).

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView didMoveToWindow]):

  • should update all view state flags.
  • UIProcess/API/ios/WKViewIOS.mm:

(-[WKView didMoveToWindow]):

  • added to match WKWebView.mm, for WebKitTestRunner.
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView willMoveToWindow:]):

  • should _updateForScreen:

(-[WKContentView didMoveToWindow]): Deleted.

  • functionality moved to -[WKWebView didMoveToWindow], -[WKContentView didMoveToWindow].
2:54 PM Changeset in webkit [185126] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk/Source/WebCore

Added a stub implementation of MediaSession, part of the Media Session spec.
​https://bugs.webkit.org/show_bug.cgi?id=145530

Patch by Matt Rajca <​mrajca@apple.com> on 2015-06-02
Reviewed by Eric Carlson.

  • CMakeLists.txt: Added new MediaSession sources.
  • DerivedSources.make:
  • Modules/mediasession/MediaSession.cpp: Added stub implementation.

(WebCore::MediaSession::MediaSession): Per the Media Session spec, a Media Remote Controls object should only be

set for 'content' sessions; it is null otherwise.

(WebCore::MediaSession::~MediaSession):
(WebCore::MediaSession::controls):
(WebCore::MediaSession::releaseSession):

  • Modules/mediasession/MediaSession.h: Added basic translation of IDL file.
  • Modules/mediasession/MediaSession.idl: Added from the Media Session spec.
  • WebCore.xcodeproj/project.pbxproj: Added new MediaSession sources.
2:37 PM Changeset in webkit [185125] by Said Abou-Hallawa
  • 1 edit
    1 add in trunk/LayoutTests

Fix Windows layout test failure following <​http://trac.webkit.org/changeset/185095>
(​https://bugs.webkit.org/show_bug.cgi?id=145537)

Unreviewed.

  • platform/win/fast/text/crash-complex-text-surrogate-expected.txt: Added.
2:35 PM Changeset in webkit [185124] by Alan Bujtas
  • 7 edits
    4 adds in trunk

Backdrop filter is pulling in content from behind the window.
​https://bugs.webkit.org/show_bug.cgi?id=145561
rdar://problem/20909309

Reviewed by Simon Fraser.

This patch ensures that the backdrop filter layer is positioned and sized properly.

The backdrop filter layer should take its size and position from its renderer and not
directly from the composited layer.
In certain cases the composited layer's size is expanded to cover items like box shadow or an absolute positioned descendant.
In such cases, we ended up applying the backdrop filter to those areas as well.

Source/WebCore:

Tests: css3/filters/backdrop/backdrop-filter-does-not-size-properly-absolute.html

css3/filters/backdrop/backdrop-filter-does-not-size-properly-border-and-padding.html

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setBackdropFiltersRect):
(WebCore::GraphicsLayer::backdropFiltersRect):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setBackdropFiltersRect):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateBackdropFilters):
(WebCore::GraphicsLayerCA::updateBackdropFiltersRect):
(WebCore::GraphicsLayerCA::updateContentsRects):
(WebCore::GraphicsLayerCA::updateGeometry): Deleted.

  • platform/graphics/ca/GraphicsLayerCA.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateBackdropFiltersGeometry):
(WebCore::RenderLayerBacking::updateGeometry):

  • rendering/RenderLayerBacking.h:

LayoutTests:

  • css3/filters/backdrop/backdrop-filter-does-not-size-properly-absolute-expected.txt: Added.
  • css3/filters/backdrop/backdrop-filter-does-not-size-properly-absolute.html: Added.
  • css3/filters/backdrop/backdrop-filter-does-not-size-properly-border-and-padding-expected.txt: Added.
  • css3/filters/backdrop/backdrop-filter-does-not-size-properly-border-and-padding.html: Added.
2:30 PM Changeset in webkit [185123] by Chris Dumez
  • 9 edits in trunk/Source/WebKit2

[iOS][WK2] Always mark layers as volatile for background pages
​https://bugs.webkit.org/show_bug.cgi?id=145547
<rdar://problem/20663184>

Reviewed by Simon Fraser.

We previously marked layers as volatile when the WebProcess was about
to be suspended. Most of the time the WebProcess gets suspended when a
page goes into the background. However, it is not always true (see
radar), in which case the layers won't be marked as volatile and use
memory even though they are not visible.

We now mark layers as volatile as soon as the page goes into the
background, instead of relying on the WebProcess suspension mechanism
to do so.

A new ApplicationDidEnterBackground IPC message from the UIProcess to
the WebProcess is added (in addition to the pre-existing
ApplicationWillEnterForeground one). When the WebProcess receives this
message, it will freeze the layer tree state and mark the layers as
volatile (with a timer to keep retrying if needed), similarly to what
is already done in WebProcess::actualPrepareToSuspend().
When the ApplicationWillEnterForeground is received, we unfreeze the
layer tree state. The layers' volatile state will be automatically
updated when they are displayed (see setBufferVolatility() call in
RemoteLayerBackingStore::display()).

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _applicationDidEnterBackground:]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::applicationDidEnterBackground):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::setLayerTreeStateIsFrozen):
(WebKit::WebPage::markLayersVolatileImmediatelyIfPossible):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::volatilityTimerFired):
(WebKit::WebPage::applicationDidEnterBackground):
(WebKit::WebPage::applicationWillEnterForeground):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::markAllLayersVolatileIfPossible):
(WebKit::WebProcess::setAllLayerTreeStatesFrozen):

2:24 PM Changeset in webkit [185122] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

JavaScriptCore: JSExport protocol with an NSInteger property converts negative values to 18446744073709552000
​https://bugs.webkit.org/show_bug.cgi?id=145563

Patch by Keith Miller <​keith_miller@apple.com> on 2015-06-02
Reviewed by Darin Adler.

The Objective-C bindings were improperly converting negative
long long/NSIntegers to 18446744073709552000 because they
were converted to unsigned numbers.

  • API/ObjcRuntimeExtras.h:

(parseObjCType):

  • API/tests/testapi.mm:

(testObjectiveCAPIMain):
(checkNegativeNSIntegers):
(testObjectiveCAPI):

2:14 PM Changeset in webkit [185121] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: ⌘F no longer brings up the find-in-page bar after typing in the quick console
​https://bugs.webkit.org/show_bug.cgi?id=145546

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-02
Reviewed by Timothy Hatcher.

Scope ContentBrowser keyboard events within the ContentBrowser instead
of global, where they might conflict between ContentBrowsers. The scoped
shortcuts now no longer need to be enabled/disabled.

  • UserInterface/Views/ContentBrowser.js:

(WebInspector.ContentBrowser):
Scope the keyboard shortcuts.

(WebInspector.ContentBrowser.prototype.shown):
(WebInspector.ContentBrowser.prototype.hidden):
No longer need to control enabling / disabling these non-global shortcuts.

2:04 PM Changeset in webkit [185120] by eric.carlson@apple.com
  • 4 edits in trunk/Source/WebCore

[Mac] occasional crash in Document::playbackTargetAvailabilityDidChange
​https://bugs.webkit.org/show_bug.cgi?id=145559

Reviewed by Darin Adler.

No new tests, covered by existing tests.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::registerWithDocument): Pass document to m_mediaSession->registerWithDocument.
(WebCore::HTMLMediaElement::unregisterWithDocument): Pass document to m_mediaSession->unRegisterWithDocument.
(WebCore::HTMLMediaElement::documentWillSuspendForPageCache): Ditto.
(WebCore::HTMLMediaElement::documentDidResumeFromPageCache): Ditto.

  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::registerWithDocument): Take a document.
(WebCore::MediaElementSession::unregisterWithDocument): Ditto.

  • html/MediaElementSession.h:
1:22 PM Changeset in webkit [185119] by Said Abou-Hallawa
  • 5 edits
    1 add
    1 delete in trunk/LayoutTests

Fix Mac Mavericks layout test failure following <​http://trac.webkit.org/changeset/185096>
(​https://bugs.webkit.org/show_bug.cgi?id=145478)

Move fast/text/font-weights-zh.html out of the platform directory. The
webkit test runner is not smart enough to ignore the expected results
in the mac directory and get it from the Mavericks directory, if it exists,
when running on Mavericks.

Reviewed by Alexey Proskuryakov.

  • fast/text/font-weights-zh.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/fast/text/font-weights-zh.html: Removed.
  • platform/win/TestExpectations:
  • platform/win-xp/TestExpectations:
  • platform/wincairo/TestExpectations:
1:20 PM Changeset in webkit [185118] by Chris Dumez
  • 6 edits in trunk/Source/WebCore

Calling FrameView::viewportContentsChanged() after style recalcs is too expensive
​https://bugs.webkit.org/show_bug.cgi?id=145554
<rdar://problem/21189478>

Reviewed by Darin Adler and Simon Fraser.

Only call FrameView::viewportContentsChanged() after a style recalc if
composited layers have been updated (and there is no pending layout).

We already viewportContentsChanged() after layout so we only need to
call viewportContentsChanged() after a style recalc if it did not cause
a layout but may have caused an element to become visible. In
particular, this can happen in the case of composited animations (e.g.
using -webkit-transform to move an element inside the viewport).
Therefore, we now only call viewportContentsChanged() after a style
recalc if it caused composited layers to be updated. This avoids a lot
of unnecessary calls to viewportContentsChanged(), which is expensive.

No new tests, already covered by:
fast/images/animated-gif-webkit-transform.html

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • page/FrameView.cpp:

(WebCore::FrameView::updateCompositingLayersAfterStyleChange):

  • page/FrameView.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::didRecalcStyleWithNoPendingLayout):
(WebCore::RenderLayerCompositor::updateCompositingLayers):

  • rendering/RenderLayerCompositor.h:
1:19 PM Changeset in webkit [185117] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Remove use of CTFontSetRenderingParameters()
​https://bugs.webkit.org/show_bug.cgi?id=145560

Reviewed by Simon Fraser.

Instead, always use CTFontSetRenderingStyle().

No new tests because there is no behavior change.

  • platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::RenderingStyleSaver::RenderingStyleSaver): Deleted.
(WebCore::RenderingStyleSaver::~RenderingStyleSaver): Deleted.

1:00 PM Changeset in webkit [185116] by andersca@apple.com
  • 6 edits
    1 copy in trunk/Source/WebCore

Move WKFontAntialiasingStateSaver to its own file
​https://bugs.webkit.org/show_bug.cgi?id=145557
rdar://problem/21134776

Reviewed by Dan Bernstein.

Also rename it to FontAntialiasingStateSaver. Also, change it to use the CoreGraphicsSPI.h header for its
CGFontAntialiasingStyle definition instead of using an explicit typedef.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::drawLayerContents):

  • platform/graphics/ios/FontAntialiasingStateSaver.h: Copied from Source/WebCore/platform/ios/wak/WKGraphics.h.

(WebCore::FontAntialiasingStateSaver::FontAntialiasingStateSaver):
(WebCore::FontAntialiasingStateSaver::setup):
(WebCore::FontAntialiasingStateSaver::restore):

  • platform/ios/LegacyTileCache.mm:

(WebCore::LegacyTileCache::drawWindowContent):

  • platform/ios/wak/WKGraphics.h:

(WKFontAntialiasingStateSaver::WKFontAntialiasingStateSaver): Deleted.

  • platform/ios/wak/WKGraphics.mm:

(WKFontAntialiasingStateSaver::setup): Deleted.
(WKFontAntialiasingStateSaver::restore): Deleted.

12:40 PM Changeset in webkit [185115] by beidson@apple.com
  • 1 edit
    7 adds in trunk/LayoutTests

Add more tests for "should open external urls" flag.
​https://bugs.webkit.org/show_bug.cgi?id=145558

Rubberstamped by Geoff Garen.

  • loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/api-false-followed-by-api-true.html: Added.
  • loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/api-true-followed-by-api-false.html: Added.
  • loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/dispatch-event-click-is-not-user-gesture.html: Added.
  • loader/navigation-policy/should-open-external-urls/resources/do-nothing.html: Added.
12:28 PM Changeset in webkit [185114] by youenn.fablet@crf.canon.fr
  • 22 edits
    3 adds in trunk

Source/WebCore:
[Streams API] Implement ReadableStreamReader read method in closed and errored state
​https://bugs.webkit.org/show_bug.cgi?id=144790

Reviewed by Darin Adler.

Reader delegates read() promise handling to its stream except if reader is no longer locking the stream and stream is readable.
Storing of reader read() promise callbacks as a Vector in ReadableStream.
Added resolution/rejection of read() promises in case of errored/closed streams.

Test: streams/readable-stream-reader-read.html

  • ForwardingHeaders/runtime/IteratorOperations.h: Added.
  • Modules/streams/ReadableStream.cpp:

(WebCore::ReadableStream::cleanCallbacks): Clean the read requests.
(WebCore::ReadableStream::changeStateToClosed): Run success callbacks with undefined for read requests.
(WebCore::ReadableStream::changeStateToErrored): Run failure callbacks with the errors for read requests.
(WebCore::ReadableStream::closed): Parameter name changed.
(WebCore::ReadableStream::read): Added. Succeeds with empty when closed, fails with error when errored, reads a
value if there is one and pushes the callbacks to the queue otherwise.

  • Modules/streams/ReadableStream.h:

(WebCore::ReadableStream::ReadCallbacks::ReadCallbacks): Struct containing success and failure callbacks.

  • Modules/streams/ReadableStreamReader.cpp:

(WebCore::ReadableStreamReader::closed): Parameter name changed.
(WebCore::ReadableStreamReader::read): Invoke success with empty if we streams if we don't have the right reader
and call the stream otherwise to read.

  • Modules/streams/ReadableStreamReader.h:
  • bindings/js/JSReadableStreamReaderCustom.cpp:

(WebCore::JSReadableStreamReader::read): Create the callback lambdas and invoke read. Failure rejects the
promise and success creates the result from the read value.

  • bindings/js/ReadableJSStream.cpp:

(WebCore::ReadableJSStream::hasValue):
(WebCore::ReadableJSStream::read): Not implemented yet.

  • bindings/js/ReadableJSStream.h:

Source/WTF:
[Streams API] Delegate ReadableStreamReader reference counting to ReadableStream
​https://bugs.webkit.org/show_bug.cgi?id=144907

Reviewed by Darin Adler.

  • wtf/Vector.h:

(WTF::Vector::append): Adding not templated append method, forwarding to ValueType templated append method.

LayoutTests:
[Streams API] Implement ReadableStreamReader read method in closed and errored state
​https://bugs.webkit.org/show_bug.cgi?id=144790

Reviewed by Darin Adler.

Added new test. Rebased reference tests (expectations and timeouting/untimeouting tests).
Removed temporarily some tests in streams/reference-implementation/readable-stream-templated.html.
These tests try to check handling promise returned in start method which is not yet supported.
If we did not comment these tests, they would be flaky.

  • streams/readable-stream-reader-read-expected.txt: Added.
  • streams/readable-stream-reader-read.html: Added.
  • streams/reference-implementation/bad-underlying-sources-expected.txt:
  • streams/reference-implementation/bad-underlying-sources.html:
  • streams/reference-implementation/count-queuing-strategy-expected.txt:
  • streams/reference-implementation/count-queuing-strategy.html:
  • streams/reference-implementation/readable-stream-cancel-expected.txt:
  • streams/reference-implementation/readable-stream-expected.txt:
  • streams/reference-implementation/readable-stream-reader-expected.txt:
  • streams/reference-implementation/readable-stream-reader.html:
  • streams/reference-implementation/readable-stream-templated-expected.txt:
  • streams/reference-implementation/readable-stream-templated.html:
  • streams/reference-implementation/readable-stream.html:
12:21 PM Changeset in webkit [185113] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

[Cocoa] FontPlatformData's equality check should always use reference URLs
​https://bugs.webkit.org/show_bug.cgi?id=144168

Reviewed by Tim Horton.

<rdar://problem/18985642> is not fixed, so we need to continue using the older
objectForEqualityCheck().

No new tests because there is no behavior change.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::objectForEqualityCheck):

12:13 PM Changeset in webkit [185112] by aestes@apple.com
  • 2 edits
    5 adds in trunk/Source/WebCore

[Mac] REGRESSION (r175941): Max.app crashes when adding a sound file to a patch due to removing cursor resources from WebCore.framework
​https://bugs.webkit.org/show_bug.cgi?id=145555

Reviewed by Darin Adler.

Re-added the cursor resources used by Max.app and ran sort-Xcode-project-file.

  • Resources/copyCursor.png: Added.
  • Resources/moveCursor.png: Added.
  • Resources/northEastSouthWestResizeCursor.png: Added.
  • Resources/northSouthResizeCursor.png: Added.
  • Resources/northWestSouthEastResizeCursor.png: Added.
  • WebCore.xcodeproj/project.pbxproj:
11:43 AM Changeset in webkit [185111] by beidson@apple.com
  • 45 edits
    49 adds in trunk

WebKit policy delegate should suggest if a navigation should be allowed to open URLs externally.
rdar://problem/21025301 and ​https://bugs.webkit.org/show_bug.cgi?id=145280
Source/WebCore:

Reviewed by Alex Christensen.

Tests: loader/navigation-policy/should-open-external-urls/main-frame-click.html

loader/navigation-policy/should-open-external-urls/main-frame-navigated-programatically-by-subframe.html
loader/navigation-policy/should-open-external-urls/main-frame-with-flag-progamatic.html
loader/navigation-policy/should-open-external-urls/main-frame-without-flag-programatic.html
loader/navigation-policy/should-open-external-urls/subframe-click-target-self.html
loader/navigation-policy/should-open-external-urls/subframe-click-target-top.html
loader/navigation-policy/should-open-external-urls/user-gesture-target-blank-with-flag-from-subframe.html
loader/navigation-policy/should-open-external-urls/user-gesture-target-blank-with-flag.html
loader/navigation-policy/should-open-external-urls/user-gesture-target-blank-without-flag-from-subframe.html
loader/navigation-policy/should-open-external-urls/user-gesture-target-blank-without-flag.html
loader/navigation-policy/should-open-external-urls/user-gesture-window-open-with-flag-from-subframe.html
loader/navigation-policy/should-open-external-urls/user-gesture-window-open-with-flag.html
loader/navigation-policy/should-open-external-urls/user-gesture-window-open-without-flag-from-subframe.html
loader/navigation-policy/should-open-external-urls/user-gesture-window-open-without-flag.html
loader/navigation-policy/should-open-external-urls/window-open-with-flag-from-subframe.html
loader/navigation-policy/should-open-external-urls/window-open-with-flag.html
loader/navigation-policy/should-open-external-urls/window-open-without-flag-from-subframe.html
loader/navigation-policy/should-open-external-urls/window-open-without-flag.html

The "should open external URLs" flag is only for main frames.
It doesn't enforce any sort of policy internal to WebKit, but rather is for notifications to the policy delegate.

It is set from one of two places:
1 - A main frame is navigated by any frame as the result of a user gesture.
2 - WebKit2 API explicitly states the flag is true.

The flag value propagates when:
1 - When a main frame document is navigated to a new main frame document.
2 - When a new window is opened from a page whose main frame had the flag set.
3 - When a new window is opened as the result of a user gesture.

The flag resets to false when:
1 - A subframe navigates a main frame without a user gesture.

This patch is large, but does little more than the following:
1 - Adds a ShouldOpenExternalURLs flag to both FrameLoadRequest and NavigationAction.
2 - Makes sure anybody who creates either of those objects sets a sensible for that flag.
3 - When FrameLoader creates a new DocumentLoader, it sets its flag based on whether or not the load is in a main frame,

whether or not the load is from a user gesture, and based on the initiator's value of the flag.

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):
(WebCore::Document::shouldOpenExternalURLsPolicyToPropagate):

  • dom/Document.h:
  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::handleClick):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::handleClick):

  • html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSAuditorDelegate::didBlockScript):

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::openInNewTab):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::navigate):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::setTriggeringAction):
(WebCore::DocumentLoader::shouldOpenExternalURLsPolicyToPropagate):

  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::shouldOpenExternalURLsPolicy): Deleted.

  • loader/FrameLoadRequest.cpp:

(WebCore::FrameLoadRequest::FrameLoadRequest):

  • loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::FrameLoadRequest):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::loadURLIntoChildFrame):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::applyShouldOpenExternalURLsPolicyToNewDocumentLoader):

  • loader/FrameLoader.h:
  • loader/NavigationAction.cpp:

(WebCore::NavigationAction::NavigationAction):
(WebCore::NavigationAction::copyWithShouldOpenExternalURLsPolicy):

  • loader/NavigationAction.h:

(WebCore::NavigationAction::setShouldOpenExternalURLsPolicy): Deleted.

  • loader/NavigationScheduler.cpp:

(WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
(WebCore::ScheduledRedirect::ScheduledRedirect):
(WebCore::ScheduledLocationChange::ScheduledLocationChange):
(WebCore::ScheduledRefresh::ScheduledRefresh):
(WebCore::ScheduledFormSubmission::ScheduledFormSubmission):
(WebCore::NavigationScheduler::scheduleRedirect):
(WebCore::NavigationScheduler::scheduleLocationChange):
(WebCore::NavigationScheduler::scheduleRefresh):

  • loader/NavigationScheduler.h:
  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadOrRedirectSubframe):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::selectCache):

  • page/ContextMenuController.cpp:

(WebCore::openNewWindow):
(WebCore::ContextMenuController::contextMenuItemSelected):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::open):

  • page/DragController.cpp:

(WebCore::DragController::performDragOperation):

  • page/Location.cpp:

(WebCore::Location::reload):

  • replay/ReplayInputDispatchMethods.cpp:

(WebCore::InitialNavigation::dispatch):

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler):

Source/WebKit/ios:

Reviewed by Alex Christensen.

  • WebView/WebPDFViewPlaceholder.mm:

(-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):

Source/WebKit/mac:

Reviewed by Alex Christensen.

  • Plugins/WebPluginController.mm:

(-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):

  • WebView/WebFrame.mm:

(-[WebFrame loadRequest:]):
(-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):

  • WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

Source/WebKit/win:

Reviewed by Alex Christensen.

  • Plugins/PluginView.cpp:

(WebCore::PluginView::start):
(WebCore::PluginView::performRequest):
(WebCore::PluginView::getURLNotify):
(WebCore::PluginView::getURL):
(WebCore::PluginView::handlePost):

  • WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::searchWithGoogle):

  • WebFrame.cpp:

(WebFrame::loadRequest):
(WebFrame::loadData):

Source/WebKit2:

Reviewed by Alex Christensen.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::clickedLink):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performFrameLoadURLRequest):
(WebKit::PluginView::loadURL):

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::searchWithGoogle):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchCreatePage):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::openInNewTab):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadURLInFrame):
(WebKit::WebPage::loadRequest):
(WebKit::WebPage::loadDataImpl):
(WebKit::WebPage::navigateToPDFLinkWithSimulatedClick):

LayoutTests:

Reviewed by Alex Christensen.

  • loader/navigation-policy/should-open-external-urls/main-frame-click-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/main-frame-click.html: Added.
  • loader/navigation-policy/should-open-external-urls/main-frame-navigated-programatically-by-subframe-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/main-frame-navigated-programatically-by-subframe.html: Added.
  • loader/navigation-policy/should-open-external-urls/main-frame-with-flag-progamatic-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/main-frame-with-flag-progamatic.html: Added.
  • loader/navigation-policy/should-open-external-urls/main-frame-without-flag-programatic-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/main-frame-without-flag-programatic.html: Added.
  • loader/navigation-policy/should-open-external-urls/resources/click-notify-done-in-main.html: Added.
  • loader/navigation-policy/should-open-external-urls/resources/iframe-click-notify-done-target-self.html: Added.
  • loader/navigation-policy/should-open-external-urls/resources/iframe-click-notify-done-target-top.html: Added.
  • loader/navigation-policy/should-open-external-urls/resources/main-frame-with-subframe-click-targets-subframe.html: Added.
  • loader/navigation-policy/should-open-external-urls/resources/main-frame-with-subframe-programatically-navigates-main.html: Added.
  • loader/navigation-policy/should-open-external-urls/resources/programatically-navigate-to-notify-done-target-top.html: Added.
  • loader/navigation-policy/should-open-external-urls/resources/programatically-navigate-to-notify-done.html: Added.
  • loader/navigation-policy/should-open-external-urls/resources/user-gesture-target-blank-to-notify-done-from-subframe.html: Added.
  • loader/navigation-policy/should-open-external-urls/resources/user-gesture-target-blank-to-notify-done.html: Added.
  • loader/navigation-policy/should-open-external-urls/resources/user-gesture-window-open-to-notify-done-from-subframe.html: Added.
  • loader/navigation-policy/should-open-external-urls/resources/user-gesture-window-open-to-notify-done.html: Added.
  • loader/navigation-policy/should-open-external-urls/resources/window-open-to-notify-done-from-subframe.html: Added.
  • loader/navigation-policy/should-open-external-urls/resources/window-open-to-notify-done.html: Added.
  • loader/navigation-policy/should-open-external-urls/subframe-click-target-self-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/subframe-click-target-self.html: Added.
  • loader/navigation-policy/should-open-external-urls/subframe-click-target-top-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/subframe-click-target-top.html: Added.
  • loader/navigation-policy/should-open-external-urls/user-gesture-target-blank-with-flag-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/user-gesture-target-blank-with-flag-from-subframe-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/user-gesture-target-blank-with-flag-from-subframe.html: Added.
  • loader/navigation-policy/should-open-external-urls/user-gesture-target-blank-with-flag.html: Added.
  • loader/navigation-policy/should-open-external-urls/user-gesture-target-blank-without-flag-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/user-gesture-target-blank-without-flag-from-subframe-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/user-gesture-target-blank-without-flag-from-subframe.html: Added.
  • loader/navigation-policy/should-open-external-urls/user-gesture-target-blank-without-flag.html: Added.
  • loader/navigation-policy/should-open-external-urls/user-gesture-window-open-with-flag-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/user-gesture-window-open-with-flag-from-subframe-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/user-gesture-window-open-with-flag-from-subframe.html: Added.
  • loader/navigation-policy/should-open-external-urls/user-gesture-window-open-with-flag.html: Added.
  • loader/navigation-policy/should-open-external-urls/user-gesture-window-open-without-flag-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/user-gesture-window-open-without-flag-from-subframe-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/user-gesture-window-open-without-flag-from-subframe.html: Added.
  • loader/navigation-policy/should-open-external-urls/user-gesture-window-open-without-flag.html: Added.
  • loader/navigation-policy/should-open-external-urls/window-open-with-flag-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/window-open-with-flag-from-subframe-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/window-open-with-flag-from-subframe.html: Added.
  • loader/navigation-policy/should-open-external-urls/window-open-with-flag.html: Added.
  • loader/navigation-policy/should-open-external-urls/window-open-without-flag-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/window-open-without-flag-from-subframe-expected.txt: Added.
  • loader/navigation-policy/should-open-external-urls/window-open-without-flag-from-subframe.html: Added.
  • loader/navigation-policy/should-open-external-urls/window-open-without-flag.html: Added.
10:48 AM Changeset in webkit [185110] by mark.lam@apple.com
  • 2 edits in trunk/Tools

build-jsc's --cloop option is broken.
​https://bugs.webkit.org/show_bug.cgi?id=145516

Reviewed by Darin Adler.

  • Scripts/build-jsc:
  • Make sure to disable the JIT when --cloop is specified. Did analogous fix for --ftljit.
10:36 AM Changeset in webkit [185109] by Yusuke Suzuki
  • 12 edits in trunk/Source

Heap-use-after-free read of size 4 in JavaScriptCore: WTF::StringImpl::isSymbol() (StringImpl.h:496)
​https://bugs.webkit.org/show_bug.cgi?id=145532

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

AtomicStringImpl::lookUp returns AtomicStringImpl*,
it doesn't give any ownership to the caller.
Originally, this is ok because the ownership is taken
by AtomicStringImpl's table (& the register side).

But if we would like to use this returned AtomicStringImpl*,
we should take its ownership immediately.
Because if the register side releases its ownership (ref count),
it will be destroyed.

In JSString::toExistingAtomicString, it returns AtomicStringImpl*.
But it's not appropriate.
If the owner of AtomicStringImpl* is always JSString*, it is ok.
But it looks up the table-registered AtomicStringImpl* from
the AtomicStringImpl table. So JSString* may not have the ownership
of the returned AtomicStringImpl*.

The failure situation is the following.

  1. A creates AtomicStringImpl. A has its ownership. And A registers it to AtomicStringImpl table.
  2. JSString looks up the AtomicStringImpl from the table. It gets AtomicStringImpl*. And JSString doesn't have its ownership. It returns the raw pointer immediately to the users
  3. A is released. There's no owner for AtomicStringImpl*. So it's also destroyed.
  4. Use looked up AtomicStringImpl in (2). It becomes use-after-free.

This patch fixes it by the following changes.

  1. Change the signature of AtomicStringImpl* AtomicStringImpl::lookUp(...) to RefPtr<AtomicStringImpl> AtomicStringImpl::lookUp(..). Use RefPtr because it may return nullptr.
  2. Change the signature of AtomicStringImpl* JSString::toExistingAtomicString(...) to RefPtr<AtomicStringImpl> JSString::toExistingAtomicString(...). Using RefPtr is the same reason.
  3. Receive the result with RefPtr<AtomicStringImpl> in the caller side.
  • dfg/DFGOperations.cpp:
  • jit/JITOperations.cpp:

(JSC::getByVal):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::getByVal):

  • runtime/JSString.cpp:

(JSC::JSRopeString::resolveRopeToExistingAtomicString):

  • runtime/JSString.h:

(JSC::JSString::toExistingAtomicString):

Source/WebCore:

Hold the ownership of AtomicStringImpl*.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::getElementById):

Source/WTF:

Return RefPtr<AtomicStringImpl> instead of AtomicStringImpl*.

  • wtf/text/AtomicStringImpl.cpp:

(WTF::AtomicStringImpl::lookUpSlowCase):
(WTF::AtomicStringImpl::lookUpInternal):

  • wtf/text/AtomicStringImpl.h:

(WTF::AtomicStringImpl::lookUp):

10:26 AM Changeset in webkit [185108] by dbates@webkit.org
  • 3 edits in trunk/Tools

Update ATS keys used in MiniBrowser and WebKitTestRunnerApp

Rubber-stamped by Alexey Proskuryakov.

  • MiniBrowser/mac/Info.plist:
  • WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
2:12 AM Changeset in webkit [185107] by Gyuyoung Kim
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r185091): Crash happens on indexdb tests
​https://bugs.webkit.org/show_bug.cgi?id=145549

Reviewed by Csaba Osztrogonác.

r185091 caused crash on some indexeddb tests. The crash happens because IDBDatabaseError::create() doesn't
dereference count by using ptr(). It makes a crash when dereferencing on ~Ref() destructor. To fix this issue,
this patch uses leakRef() instead of ptr().

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::didCreateObjectStore):
(WebKit::WebIDBServerConnection::didCreateIndex):
(WebKit::WebIDBServerConnection::didDeleteIndex):
(WebKit::WebIDBServerConnection::didPutRecord):
(WebKit::WebIDBServerConnection::didGetRecord):
(WebKit::WebIDBServerConnection::didOpenCursor):
(WebKit::WebIDBServerConnection::didAdvanceCursor):
(WebKit::WebIDBServerConnection::didIterateCursor):
(WebKit::WebIDBServerConnection::didCount):
(WebKit::WebIDBServerConnection::didDeleteRange):
(WebKit::WebIDBServerConnection::didClearObjectStore):
(WebKit::WebIDBServerConnection::didDeleteObjectStore):
(WebKit::WebIDBServerConnection::didChangeDatabaseVersion):

2:08 AM Changeset in webkit [185106] by youenn.fablet@crf.canon.fr
  • 5 edits in trunk/Source/WebCore

SharedBuffer::copy should return a Ref<SharedBuffer>
​https://bugs.webkit.org/show_bug.cgi?id=145499

Reviewed by Andreas Kling.

Changing SharedBuffer::copy to return a Ref<> and adapting some code accordingly.

Covered by existing tests.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse):

  • loader/appcache/ApplicationCacheResource.cpp:

(WebCore::ApplicationCacheResource::deliver):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::copy):

  • platform/SharedBuffer.h:
Note: See TracTimeline for information about the timeline view.