⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 7, 2015:

11:38 PM Changeset in webkit [185312] by Carlos Garcia Campos
  • 3 edits in trunk/Tools

[GTK] Add editor mode to MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=145595

Reviewed by Sergio Villar Senin.

It loads an empty editable web view with an edit toolbar. It makes
easier to test the editor, editing commands and input methods.

  • MiniBrowser/gtk/BrowserWindow.c:

(editingCommandCallback):
(browserWindowSetupEditorToolbar):
(browserWindowConstructed):

  • MiniBrowser/gtk/main.c:

(createBrowserWindow):

11:35 PM Changeset in webkit [185311] by Carlos Garcia Campos
  • 6 edits in trunk/Source/WebKit2

REGRESSION(r185262): [GTK] webkit_web_context_set_disk_cache_directory() doesn't work after r185262
​https://bugs.webkit.org/show_bug.cgi?id=145735

Reviewed by Darin Adler.

  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess): Use
the directory name to clear the old cache, since the disk cache
subdirectory is now added in the UI process.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_set_disk_cache_directory): Update the
WebProcessPool configuration to override the disk cache directory.

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess): Use the
configuration to get the disk cache directory.
(WebKit::WebProcessPool::WebProcessPool): Remove
m_diskCacheDirectory member initialization.

  • UIProcess/WebProcessPool.h: Remove m_diskCacheDirectory member.
  • UIProcess/gtk/WebProcessPoolGtk.cpp:

(WebKit::WebProcessPool::legacyPlatformDefaultNetworkCacheDirectory):
Append the disk cache subdirectory.

7:39 PM Changeset in webkit [185310] by Darin Adler
  • 8 edits
    3 adds
    2 deletes in trunk

REGRESSION (r181720): Unnecessary layout triggered any time animated GIF advances to a new frame
​https://bugs.webkit.org/show_bug.cgi?id=145733

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/images/animated-gif-no-layout.html

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::styleDidChange): Correctly pass ImageSizeChangeNone in cases
where we don't need to report a change in intrinsic size that happened outside the
repaintOrMarkForLayout function.
(WebCore::RenderImage::repaintOrMarkForLayout): Move work that should only be done
when size changed inside the if statement.

  • testing/Internals.cpp:

(WebCore::Internals::layoutCount): Added.

  • testing/Internals.h: Added layoutCount.
  • testing/Internals.idl: Ditto.

LayoutTests:

old one I am fixing and the one new one I am adding) because they don't yet work
under DumpRenderTree.

  • fast/images/animated-gif-no-layout-expected.html: Added.
  • fast/images/animated-gif-no-layout.html: Added.
  • fast/images/gif-loop-count-expected.html: Added. This test was worthless as a render

tree dump test, and only valuable as a pixel test. And that hid the fact that it was
failing under WebKit1. Changing it to a reference test makes it a valuable test again.

  • fast/images/gif-loop-count-expected.png: Removed.
  • fast/images/gif-loop-count-expected.txt: Removed.
  • platform/wk2/TestExpectations: Expect successes on these two tests.
6:39 PM Changeset in webkit [185309] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore

Fix strncpy use in WebCore::Text::formatForDebugger
​https://bugs.webkit.org/show_bug.cgi?id=145608

Reviewed by Darin Adler.

r185137 replaced a call to strncpy with a call to strlcpy, which broke the build on Linux
since strlcpy does not exist there. r185148 reverted this to use strncpy again, but got the
size argument off by one, "introducing" a buffer overrun. But this code has always been
wrong, since it used strncpy without ensuring that the buffer is null-terminated after the
call to strncpy. Fix this as well.

  • dom/Text.cpp:

(WebCore::Text::formatForDebugger):

5:05 PM Changeset in webkit [185308] by andersca@apple.com
  • 5 edits
    2 deletes in trunk/Source/WebKit

Remove WebKitSystemBits
​https://bugs.webkit.org/show_bug.cgi?id=145746

Reviewed by Dan Bernstein.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Fold WebVolumeFreeSize into its only caller and get rid of WebKitSystemBits.

  • Misc/WebKitSystemBits.h: Removed.
  • Misc/WebKitSystemBits.m: Removed.
  • WebView/WebPreferences.mm:
  • WebView/WebView.mm:

(+[WebView _setCacheModel:]):

4:54 PM Changeset in webkit [185307] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Remove another SPI method that hasn't been used since Tiger
​https://bugs.webkit.org/show_bug.cgi?id=145745

Reviewed by Dan Bernstein.

  • WebView/WebView.mm:

(-[WebView handleAuthenticationForResource:challenge:fromDataSource:]): Deleted.

  • WebView/WebViewPrivate.h:
4:44 PM Changeset in webkit [185306] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Remove another unused SPI method
​https://bugs.webkit.org/show_bug.cgi?id=145743

Reviewed by Dan Bernstein.

  • WebView/WebView.mm:

(+[WebView _pointingHandCursor]): Deleted.

  • WebView/WebViewPrivate.h:
4:36 PM Changeset in webkit [185305] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit/mac

Remove unused SPI
​https://bugs.webkit.org/show_bug.cgi?id=145742

Reviewed by Dan Bernstein.

  • WebCoreSupport/WebFrameNetworkingContext.h:
  • WebCoreSupport/WebFrameNetworkingContext.mm:

(WebFrameNetworkingContext::clearPrivateBrowsingSessionCookieStorage): Deleted.

  • WebView/WebView.mm:

(+[WebView _clearPrivateBrowsingSessionCookieStorage]): Deleted.

  • WebView/WebViewPrivate.h:
4:11 PM Changeset in webkit [185304] by commit-queue@webkit.org
  • 1 edit
    49 adds in trunk/Source/WebInspectorUI

Web Inspector: Add PrettyPrinter CSSRule tests
​https://bugs.webkit.org/show_bug.cgi?id=145740

Patch by Tobias Reiss <​tobi+webkit@basecode.de> on 2015-06-07
Reviewed by Brian Burg.

  • Tools/PrettyPrinting/css-rule-tests/add-whitespace-after-colon-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/add-whitespace-after-colon.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/add-whitespace-after-comma-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/add-whitespace-after-comma.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/do-not-append-semicolon-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/do-not-append-semicolon.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/invalid-property-is-not-removed-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/invalid-property-is-not-removed.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/keep-prefixed-value-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/keep-prefixed-value.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-colon-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-colon.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-comment-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-comment.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-invalid-property-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-invalid-property.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-prefixed-property-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-prefixed-property.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-property-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-property.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-semicolon-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/remove-whitespace-before-semicolon.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-comment-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-comment.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-invalid-property-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-invalid-property.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-prefixed-property-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-prefixed-property.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-property-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-comment-followed-by-property.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-comment-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-comment.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-invalid-property-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-invalid-property.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-prefixed-property-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-prefixed-property.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-property-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-invalid-property-followed-by-property.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-comment-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-comment.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-invalid-property-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-invalid-property.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-prefixed-property-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-prefixed-property.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-property-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-property-followed-by-property.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-property-without-semicolon-followed-by-comment-and-property-expected.css: Added.
  • Tools/PrettyPrinting/css-rule-tests/split-property-without-semicolon-followed-by-comment-and-property.css: Added.
10:37 AM Changeset in webkit [185303] by mitz@apple.com
  • 2 edits in trunk/Source/WTF

Reverted r185302 because it broke the build

10:35 AM Changeset in webkit [185302] by mitz@apple.com
  • 2 edits in trunk/Source/WTF

Unifiy the definition of UNREACHABLE_FOR_PLATFORM
​https://bugs.webkit.org/show_bug.cgi?id=145737

Reviewed by Anders Carlsson.

  • wtf/Assertions.h:

(UNREACHABLE_FOR_PLATFORM): Use the macro for clang as well. Its expansion includes
attribute((noreturn)) so the pragmas are unnecessary.

7:42 AM Changeset in webkit [185301] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

CrashTracer: [USER] com.apple.WebKit.WebContent.Development at com.apple.WebCore: WebCore::FrameLoader::subresourceCachePolicy const + 11
​https://bugs.webkit.org/show_bug.cgi?id=145736
rdar://problem/21246971

Reviewed by David Kilzer.

No repro, no test.

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

Null check frame. It may be null during frame teardown.

1:48 AM Changeset in webkit [185300] by Gyuyoung Kim
  • 6 edits in trunk/Source/WebKit2

[EFL][GTK] Fix build break since r185262
​https://bugs.webkit.org/show_bug.cgi?id=145724

Unreviewed, fix build break for EFL and GTK ports.

  • UIProcess/API/APIWebsiteDataStore.cpp:

(API::WebsiteDataStore::defaultLocalStorageDirectory):
(API::WebsiteDataStore::defaultWebSQLDatabaseDirectory):
(API::WebsiteDataStore::defaultNetworkCacheDirectory):
(API::WebsiteDataStore::defaultApplicationCacheDirectory):
(API::WebsiteDataStore::defaultMediaKeysStorageDirectory):
(API::WebsiteDataStore::defaultIndexedDBDatabaseDirectory):

  • UIProcess/efl/WebProcessPoolEfl.cpp:

(WebKit::WebProcessPool::legacyPlatformDefaultNetworkCacheDirectory):
(WebKit::WebProcessPool::platformDefaultDiskCacheDirectory): Deleted.

  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):

Jun 6, 2015:

9:42 PM Changeset in webkit [185299] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Don’t enable manual sandboxing in the iOS Simulator. This should fix all the tests timing out.

  • Configurations/DebugRelease.xcconfig:
7:08 PM Changeset in webkit [185298] by mitz@apple.com
  • 13 edits in trunk/Source/WebKit2

[iOS] Can’t debug with Development XPC services due to automatic sandboxing
​https://bugs.webkit.org/show_bug.cgi?id=145731

Reviewed by Darin Adler.

In iOS, the XPC services are automatically sandboxed based on their entitlements. The
sandbox doesn’t allow them to re-exec, which is necessary for linking against engineering
builds of the WebKit frameworks placed in a non-system location.

The solution is to opt Engineering builds into manual sandboxing.

  • Configurations/BaseTarget.xcconfig:
  • Add ENABLE_MANUAL_SANDBOXING to GCC_PREPROCESSOR_DEFINITIONS when WK_MANUAL_SANDBOXING_ENABLED is YES.
  • Set WK_MANUAL_SANDBOXING_ENABLED to YES for OS X, because we always use manual sandboxing on that platform.
  • Configurations/DebugRelease.xcconfig: Removed unused definition of DEBUG_OR_RELEASE. Set WK_MANUAL_SANDBOXING_ENABLED to YES for all engineering builds.
  • Configurations/BaseXPCService.xcconfig: Define CODE_SIGN_ENTITLEMENTS for iOS to be empty if the service is not installed; to use the base entitlements file from Configurations if manual sandboxing is not enabled; and to use a derived entitlements file, which doesn’t specify a sandbox profile, if manual sandboxing is enabled.
  • Configurations/DatabaseService.Development.xcconfig: Define WK_XPC_SERVICE_IOS_ENTITLEMENTS_BASE and let BaseXPCService.xcconfig define CODE_SIGN_ENTITLEMENTS for iOS.
  • Configurations/DatabaseService.xcconfig: Ditto.
  • Configurations/NetworkService.Development.xcconfig: Ditto.
  • Configurations/NetworkService.xcconfig: Ditto.
  • Configurations/WebContentService.Development.xcconfig: Ditto.
  • Configurations/WebContentService.xcconfig: Ditto.
  • WebKit2.xcodeproj/project.pbxproj:
  • In the Derived Sources target, added a Derive Entitlements for Manual Sandboxing script build phase. When building for iOS with manual sandboxing enabled, it creates copies of the iOS entitlements files with a -no-sandbox suffix and the seatbelt-profiles key removed.
  • In the WebKit target, added a Copy iOS Sandbox Profiles for Manual Sandboxing script build phase. When building for iOS with manual sandboxing enabled, it copies the iOS sandbox profiles into the framework, so that the services can apply them to themselves at runtime.
  • Shared/ios/ChildProcessIOS.mm:

(WebKit::ChildProcess::initializeSandbox): Use ENABLE(MANUAL_SANDBOXING) and don’t define it
here.

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::initializeSandbox): Use ENABLE(MANUAL_SANDBOXING) instead of defining
and using ENABLE_MANUAL_WEBPROCESS_SANDBOXING here.

7:07 PM Changeset in webkit [185297] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Restored binary compatibility with shipping Safari.

Suggested by Anders Carlsson.

  • Misc/WebKitNSStringExtras.mm:

(-[NSString _webkit_fixedCarbonPOSIXPath]): Added an implementation that returns self, so
that Safari doesn’t crash when trying to call this method.

5:09 PM Changeset in webkit [185296] by ap@apple.com
  • 9 edits
    1 add in trunk/LayoutTests

Clean up tests for blocking mixed content
​https://bugs.webkit.org/show_bug.cgi?id=145718

Reviewed by Darin Adler.

Stop using timeouts, which were making the tests flaky.

  • http/tests/xmlhttprequest/access-control-response-with-body.html: This wasn't even

a mixed content test, but the file was reused in one. I now made a separate helper
document, so this is just a regular test now, not another test's resource.

  • http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html:
  • http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html:
  • http/tests/security/mixedContent/resources/frame-with-insecure-frame.html:
  • http/tests/security/mixedContent/resources/frame-with-redirect-http-to-https-frame.html:
  • http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-frame.html:

Refactored to not depend on timeouts.

  • http/tests/security/mixedContent/insecure-xhr-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-xhr-in-main-frame.html:
  • http/tests/security/mixedContent/resources/insecure-xhr-in-main-frame-window.html: Added.

This test still needs a timeout, because of a WebKit bug. I just made it much longer.

3:55 PM Changeset in webkit [185295] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Fixed the build.

  • Plugins/WebBasePluginPackage.mm:
2:22 PM Changeset in webkit [185294] by andersca@apple.com
  • 10 edits in trunk/Source

Remove support from getting plug-in information from Carbon resources
​https://bugs.webkit.org/show_bug.cgi?id=145730

Reviewed by Dan Bernstein.

Source/WebCore:

Remove a now unused function.

  • platform/mac/WebCoreNSStringExtras.h:
  • platform/mac/WebCoreNSStringExtras.mm:

(stringEncodingForResource): Deleted.

Source/WebKit/mac:

No current plug-in versions use this feature, and both Chrome and Mozilla for
Mac stopped looking at Carbon resources years ago.

  • Misc/WebKitNSStringExtras.h:
  • Misc/WebKitNSStringExtras.mm:

(+[NSString _web_encodingForResource:]): Deleted.

  • Plugins/WebBasePluginPackage.mm:
  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _initWithPath:]):
(-[WebNetscapePluginPackage stringForStringListID:andIndex:]): Deleted.
(-[WebNetscapePluginPackage getPluginInfoFromResources]): Deleted.

Source/WebKit2:

No current plug-in versions use this feature, and both Chrome and Mozilla for
Mac stopped looking at Carbon resources years ago.

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::NetscapePluginModule::getPluginInfo):
(WebKit::ResourceMap::ResourceMap): Deleted.
(WebKit::ResourceMap::~ResourceMap): Deleted.
(WebKit::ResourceMap::isValid): Deleted.
(WebKit::getStringListResource): Deleted.
(WebKit::getPluginInfoFromCarbonResources): Deleted.

1:01 PM Changeset in webkit [185293] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit/mac

Remove now unused category methods
​https://bugs.webkit.org/show_bug.cgi?id=145729

Reviewed by Dan Bernstein.

  • Configurations/WebKitLegacy.xcconfig:
  • Misc/WebKitNSStringExtras.h:
  • Misc/WebKitNSStringExtras.mm:

(-[NSString _webkit_fixedCarbonPOSIXPath]): Deleted.

  • Misc/WebNSFileManagerExtras.h:
  • Misc/WebNSFileManagerExtras.mm:

(-[NSFileManager _webkit_startupVolumeName]): Deleted.

12:50 PM Changeset in webkit [185292] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Fix build.

  • WebKit.mac.exp:
12:45 PM Changeset in webkit [185291] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Stop using _webkit_fixedCarbonPOSIXPath in plug-in code
​https://bugs.webkit.org/show_bug.cgi?id=145728

Reviewed by Dan Bernstein.

This code was put in place to support old plug-ins that would pass Carbon paths to NPAPI functions.
WebKit2 never supported this and we've never had any problems so let's just get rid of it.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::loadURL):

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):

12:37 PM Changeset in webkit [185290] by andersca@apple.com
  • 3 edits
    2 deletes in trunk/Source/WebKit

Remove SPI that's no longer used
​https://bugs.webkit.org/show_bug.cgi?id=145727

Reviewed by Dan Bernstein.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • Plugins/WebPluginsPrivate.h: Removed.
  • Plugins/WebPluginsPrivate.m: Removed.
12:22 PM Changeset in webkit [185289] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Only allow plug-ins to create custom MIME property lists on older versions of OS X
​https://bugs.webkit.org/show_bug.cgi?id=145726

Reviewed by Dan Bernstein.

  • Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage getPluginInfoFromPLists]):

1:43 AM Changeset in webkit [185288] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r185284.
​https://bugs.webkit.org/show_bug.cgi?id=145723

it needs some discussion before landing (Requested by dino on
#webkit).

Reverted changeset:

"[iOS] Don't force compositing layers for no-op 3D transforms
on low-memory devices."
​https://bugs.webkit.org/show_bug.cgi?id=145719
​http://trac.webkit.org/changeset/185284

1:21 AM Changeset in webkit [185287] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Typing is slow in Gmail on iPads
​https://bugs.webkit.org/show_bug.cgi?id=145686

Reviewed by Enrica Casucci.

The bug was caused by nextCandidate and nextVisuallyDistinctCandidate traversing through each character
in a text node without a renderer. Skip any node that doesn't have a renderer in both of those functions
and corresponding previous* functions.

It's fine to skip unrendered nodes in PositionIterator because only other clients of PositionIterator
are Position::upstream and Position::downstream and they don't care about un-rendered nodes either.

  • dom/PositionIterator.cpp:

(WebCore::PositionIterator::increment):
(WebCore::PositionIterator::decrement):

  • editing/htmlediting.cpp:

(WebCore::nextVisuallyDistinctCandidate):
(WebCore::previousVisuallyDistinctCandidate):

12:55 AM Changeset in webkit [185286] by mark.lam@apple.com
  • 6 edits in trunk

Returned Exception* values need to be initialized to nullptr when no exceptions are thrown.
​https://bugs.webkit.org/show_bug.cgi?id=145720

Reviewed by Dan Bernstein.

Source/JavaScriptCore:

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluate):

Source/WebCore:

No new tests because this issue is already covered by the existing inspector-protocol tests.

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

LayoutTests:

  • platform/win/TestExpectations:
  • Undoing skipped tests.
Note: See TracTimeline for information about the timeline view.