Timeline
Jun 14, 2015:
- 9:13 PM Changeset in webkit [185547] by
-
- 2 edits in trunk/Source/WebKit2
Fixed the build.
- mac/postprocess-framework-headers.sh:
- 2:10 PM Changeset in webkit [185546] by
-
- 3 edits in trunk/Source/WebKit2
Format string misuse in DatabaseProcessIDBConnection.cpp and UniqueIDBDatabaseBackingStoreSQLite.cpp
https://bugs.webkit.org/show_bug.cgi?id=145960
Reviewed by Darin Adler.
Use PRIu64 and PRIi64 to print uint64_t and int64_t, respectively. These things are
different types on x86_64 Linux (unsigned long) and on Mac (unsigned long long).
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata):
(WebKit::DatabaseProcessIDBConnection::deleteDatabase):
(WebKit::DatabaseProcessIDBConnection::openTransaction):
(WebKit::DatabaseProcessIDBConnection::beginTransaction):
(WebKit::DatabaseProcessIDBConnection::commitTransaction):
(WebKit::DatabaseProcessIDBConnection::resetTransaction):
(WebKit::DatabaseProcessIDBConnection::rollbackTransaction):
(WebKit::DatabaseProcessIDBConnection::changeDatabaseVersion):
(WebKit::DatabaseProcessIDBConnection::createObjectStore):
(WebKit::DatabaseProcessIDBConnection::deleteObjectStore):
(WebKit::DatabaseProcessIDBConnection::clearObjectStore):
(WebKit::DatabaseProcessIDBConnection::createIndex):
(WebKit::DatabaseProcessIDBConnection::deleteIndex):
(WebKit::DatabaseProcessIDBConnection::putRecord):
(WebKit::DatabaseProcessIDBConnection::getRecord):
(WebKit::DatabaseProcessIDBConnection::count):
(WebKit::DatabaseProcessIDBConnection::deleteRange):
(WebKit::DatabaseProcessIDBConnection::openCursor):
(WebKit::DatabaseProcessIDBConnection::cursorAdvance):
(WebKit::DatabaseProcessIDBConnection::cursorIterate):
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::clearObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteIndex):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::generateKeyNumber):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::keyExistsInObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::putRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::uncheckedPutIndexRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getKeyRecordFromObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getKeyRangeRecordFromObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::advanceCursor):
- 2:00 PM Changeset in webkit [185545] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] Clean up postprocess-framework-headers.sh
https://bugs.webkit.org/show_bug.cgi?id=145962
Reviewed by Darin Adler.
- mac/postprocess-framework-headers.sh: Gather all the sed options in a variable, and then
run sed only once on each header. Also, correctly exit with the sed return value if it
fails.
- 1:37 AM Changeset in webkit [185544] by
-
- 2 edits in trunk/Source/WebInspectorUI
[GTK] Web Inspector: Update icon so Rendering Frames timeline distinguish between layout and painting
https://bugs.webkit.org/show_bug.cgi?id=145956
Reviewed by Carlos Garcia Campos.
- UserInterface/Images/gtk/TimelineRecordPaint.svg:
Changed to use green color.
Jun 13, 2015:
- 11:57 PM Changeset in webkit [185543] by
-
- 1 edit1 move1 delete in trunk/LayoutTests
AX: WebKit exposes all Ruby Text as Unknown (Japanese EPUB accessibility blocker)
https://bugs.webkit.org/show_bug.cgi?id=141303
Unreviewed. Move ruby tests to Mac platform only, since they don't apply to other platforms.
- accessibility/ruby-hierarchy-roles-expected.txt: Removed.
- accessibility/ruby-hierarchy-roles.html: Removed.
- platform/mac/accessibility/ruby-hierarchy-roles.html: Copied from LayoutTests/accessibility/ruby-hierarchy-roles.html.
- 9:53 PM Changeset in webkit [185542] by
-
- 13 edits in trunk/Source
[WK2] API::Navigation objects are leaked on history navigation to HistoryItems in PageCache
https://bugs.webkit.org/show_bug.cgi?id=145948
Reviewed by Darin Adler.
Source/WebCore:
API::Navigation objects were leaked on history navigation to
HistoryItems in PageCache. In such case, we would create 2 Navigation
objects instead of 1 and the first one would be leaked. The reason
we create the second one is because we fail to pass along the
navigationID from the UIProcess to the WebProcess and then back to the
UIProcess. On the IPC back to the UIProcess, the navigationID ends up
being 0 so the UIProcess creates a new Navigation object, thinking that
the load was triggered by the WebContent process.
We now pass along the navigationID, even if the HistoryItem is in the
PageCache and we end up reusing the cached DocumentLoader, instead of
creating a new one. A new updateCachedDocumentLoader() delegate is
added to the FrameLoaderClient, similarly to the pre-existing
createDocumentLoader() but for the case where the DocumentLoader gets
reused.
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadDifferentDocumentItem):
- loader/FrameLoaderClient.h:
Source/WebKit/mac:
Add empty implementation for new
FrameLoaderClient::updatedCachedDocumentLoader().
- WebCoreSupport/WebFrameLoaderClient.h:
Source/WebKit/win:
Add empty implementation for new
FrameLoaderClient::updatedCachedDocumentLoader().
- WebCoreSupport/WebFrameLoaderClient.h:
Source/WebKit2:
API::Navigation objects were leaked on history navigation to
HistoryItems in PageCache. In such case, we would create 2 Navigation
objects instead of 1 and the first one would be leaked. The reason
we create the second one is because we fail to pass along the
navigationID from the UIProcess to the WebProcess and then back to the
UIProcess. On the IPC back to the UIProcess, the navigationID ends up
being 0 so the UIProcess creates a new Navigation object, thinking that
the load was triggered by the WebContent process.
We now pass along the navigationID, even if the HistoryItem is in the
PageCache and we end up reusing the cached DocumentLoader, instead of
creating a new one. A new updateCachedDocumentLoader() delegate is
added to the FrameLoaderClient, similarly to the pre-existing
createDocumentLoader() but for the case where the DocumentLoader gets
reused.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::updateCachedDocumentLoader):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::goForward):
(WebKit::WebPage::goBack):
(WebKit::WebPage::goToBackForwardItem):
(WebKit::WebPage::updateCachedDocumentLoader):
- WebProcess/WebPage/WebPage.h:
- 5:24 PM Changeset in webkit [185541] by
-
- 6 edits in trunk/Source/WebKit2
Add private API to force page to always run at foreground priority
https://bugs.webkit.org/show_bug.cgi?id=145946
<rdar://problem/21267221>
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
- copy _alwaysRunsAtForegroundPriority to WebPageConfiguration.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _alwaysRunsAtForegroundPriority]):
(-[WKWebViewConfiguration _setAlwaysRunsAtForegroundPriority:]):
- added _alwaysRunsAtForegroundPriority.
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- added _alwaysRunsAtForegroundPriority.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
- initialize m_alwaysRunsAtForegroundPriority.
(WebKit::WebPageProxy::updateActivityToken):
- if m_alwaysRunsAtForegroundPriority is set always take the foreground activity token.
- UIProcess/WebPageProxy.h:
- added m_alwaysRunsAtForegroundPriority, alwaysRunsAtForegroundPriority.
- 1:42 PM Changeset in webkit [185540] by
-
- 6 edits1 copy1 add in trunk
Web Inspector: console.table() with a list of objects no longer works
https://bugs.webkit.org/show_bug.cgi?id=145952
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-13
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/InjectedScriptSource.js:
(InjectedScript.RemoteObject.prototype._generatePreview):
Calling generatePreview again was actually starting with a preview
of the current object instead of the sub-value. Go down the other
path that correctly generates sub-previews. Leave filtering on the
backend unimplemented, which we were already ignoring.
Source/WebInspectorUI:
- UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments):
(WebInspector.ConsoleMessageView.prototype._formatParameterAsTable):
Don't allow expanding a cosole.table message, and don't output the total
object even if the table preview was lossless, as the experience is poor.
LayoutTests:
- inspector/console/console-api.html:
- inspector/console/console-table-expected.txt: Added.
- inspector/console/console-table.html:
Add a similiar console API test all about console.table().
- 12:28 PM Changeset in webkit [185539] by
-
- 3 edits2 adds in trunk/Websites/perf.webkit.org
Add a script to post new OS X builds to perf dashboard
https://bugs.webkit.org/show_bug.cgi?id=145955
Reviewed by Darin Adler.
Added a new script pull-osx.py and relaxed the restrictions on commits accepted by the dashboard API.
- public/api/report-commits.php:
(main): Allow more characters than [A-Za-z0-9] in revision. e.g. "10.10.3 14D136".
Also allow commits without the author, commit time, and commit message as OS versions do not have those.
- tools/pull-osx.py: Added.
(main): Fetch the list of builds from a website and submit them per submissionSize with submissionInterval.
Once all builds have been submitted, wait for a long time as specified by fetchInterval.
(setup_auth): Sets up basic or digest auth to access the dashboard.
(fetch_available_builds): Fetches and parses the XML document from an internal website.
(textContent): A helper function to get the text content out of a XML node.
(submit_commits): Submits commits to the perf dashboard.
- tools/pull-svn.py:
(fetch_commit):
- tools/util.py: Extracted submit_commits and text_content from pull-svn.py to be reused in pull-osx.py.
- 8:25 AM Changeset in webkit [185538] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark fast/forms/select-element-focus-ring.html to Missing
Unreviwed, gardening for EFL port.
- platform/efl/TestExpectations: The test was added only for Mac port.
- 2:09 AM Changeset in webkit [185537] by
-
- 11 edits in trunk
[Streams API] ReadableJSStream should handle promises returned by JS source start callback
https://bugs.webkit.org/show_bug.cgi?id=145792
Source/JavaScriptCore:
Reviewed by Darin Adler.
Added support for JSFunction implemented by std::function.
- runtime/JSFunction.cpp:
(JSC::getNativeExecutable): Refactored code to share it with the two JSFunction::create
(JSC::JSFunction::create):
(JSC::runStdFunction):
- runtime/JSFunction.h: Added std::function based JSFunction::create prototype.
- runtime.JSPromise.h:
Source/WebCore:
Reviewed by Darin Adler.
Covered by rebased tests.
When calling start callback, the returned value is checked.
If it is not a promise, we do as if it is a resolved promise.
If it is a promise, we call its then() method with two resolve/reject JS functions.
- Modules/streams/ReadableStream.cpp:
- bindings/js/ReadableJSStream.cpp:
(WebCore::ReadableJSStream::invoke): Returns a JSPromise* if any is returned by the JS source callback.
(WebCore::thenPromise): Utility method to call the promise.
(WebCore::createStartResultFulfilledFunction): The promise resolve callback.
(WebCore::ReadableJSStream::doStart): Calls thenPromise if a JSPromise* is returned by invoke.
(WebCore::ReadableJSStream::ReadableJSStream):
- bindings/js/ReadableJSStream.h:
LayoutTests:
Reviewed by Darin Adler.
Rebasing expectations, and removing timeouts for tests that no longer timeout.
- streams/reference-implementation/readable-stream-expected.txt:
- streams/reference-implementation/readable-stream.html:
- 1:29 AM Changeset in webkit [185536] by
-
- 5 edits4 adds in trunk
AX: WebKit exposes all Ruby Text as Unknown (Japanese EPUB accessibility blocker)
https://bugs.webkit.org/show_bug.cgi?id=141303
Patch by Andres Gonzalez <agonzalez334@nc.rr.com> on 2015-06-13
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/ruby-hierarchy-roles.html
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
LayoutTests:
- accessibility/ruby-hierarchy-roles-expected.txt: Added.
- accessibility/ruby-hierarchy-roles.html: Added.
- platform/mac-mavericks/accessibility/ruby-hierarchy-roles-expected.txt: Added.
- platform/mac/accessibility/ruby-hierarchy-roles-expected.txt: Added.
- 1:16 AM Changeset in webkit [185535] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Perf dashboard's v2 UI shouldn't hide auto-detected outliers
https://bugs.webkit.org/show_bug.cgi?id=145940
Reviewed by Darin Adler.
Don't fallback to the default strategies for moving averages and envelope when one is not specified.
Also deleted the code to mark points outside the envelop as outliers.
- public/v2/app.js:
