⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 15, 2015:

11:47 PM Changeset in webkit [185584] by Gyuyoung Kim
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed, following gardening of r185583.

  • platform/efl/TestExpectations: Unskip passing tests, mark new failure tests since disabling USE_NATIVE_XDISPLAY.
11:16 PM Changeset in webkit [185583] by Gyuyoung Kim
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed, gardening on Jun 16th.

Too many flaky tests happens on efl bot when enabling USE_NATIVE_XDISPLAY and DISPLAY.
Those options were enabled for removing TextureMapperImageBuffer. However now EFL Layout Test
can be run without enabling the options. To remove many flaky tests, EFL buildbot disables
the env variables.

Thanks to disable it, many tests can be unskipped which were marked to failure, imageonlyfailure
and so on since r183540.

  • platform/efl/TestExpectations: Unskip passing tests, mark failure tests after disabling USE_NATIVE_XDISPLAY.
10:55 PM Changeset in webkit [185582] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Build fix after r185574.

  • public/v2/app.js:

(set get App.Pane.Ember.Object.extend.):

10:47 PM Changeset in webkit [185581] by ap@apple.com
  • 38 edits
    23 copies
    20 adds in trunk

Add test expectations for El Capitan
​https://bugs.webkit.org/show_bug.cgi?id=146005

Rubber-stamped by Dan Bernstein.

Tools:

Add appropriate tools code.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​ElCapitan@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

Added dashboard support.

  • BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
  • BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:

Trigger the right build queues on check-in.

  • Scripts/webkitpy/common/system/platforminfo.py:
  • Scripts/webkitpy/common/system/platforminfo_unittest.py:
  • Scripts/webkitpy/layout_tests/models/test_expectations.py:
  • Scripts/webkitpy/port/mac.py:
  • Scripts/webkitpy/port/mac_unittest.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • TestResultServer/static-dashboards/flakiness_dashboard.js:

Added cases for El Capitan, and updated tests for new baseline search paths.

LayoutTests:

  • platform/mac-wk1/TestExpectations:
  • platform/mac-yosemite: Added.
  • platform/mac-yosemite/fast: Added.
  • platform/mac-yosemite/fast/dom: Added.
  • platform/mac-yosemite/fast/dom/52776-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/52776-expected.txt.
  • platform/mac-yosemite/fast/text: Added.
  • platform/mac-yosemite/fast/text/complex-text-opacity-expected.txt: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.txt.
  • platform/mac-yosemite/fast/text/hyphenate-locale-expected.txt: Copied from LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt.
  • platform/mac-yosemite/fast/text/international: Added.
  • platform/mac-yosemite/fast/text/international/arabic-justify-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/arabic-justify-expected.txt.
  • platform/mac-yosemite/fast/text/international/bidi-AN-after-L-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.txt.
  • platform/mac-yosemite/fast/text/international/bidi-mirror-he-ar-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt.
  • platform/mac-yosemite/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt.
  • platform/mac-yosemite/fast/text/international/bidi-neutral-run-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-run-expected.txt.
  • platform/mac-yosemite/fast/text/line-initial-and-final-swashes-expected.txt: Copied from LayoutTests/platform/mac/fast/text/line-initial-and-final-swashes-expected.txt.
  • platform/mac-yosemite/js: Added.
  • platform/mac-yosemite/js/dom: Added.
  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt.
  • platform/mac-yosemite/platform: Added.
  • platform/mac-yosemite/platform/mac: Added.
  • platform/mac-yosemite/platform/mac/editing: Added.
  • platform/mac-yosemite/platform/mac/editing/attributed-string: Added.
  • platform/mac-yosemite/platform/mac/editing/attributed-string/anchor-element-expected.txt: Copied from LayoutTests/platform/mac/editing/attributed-string/anchor-element-expected.txt.
  • platform/mac-yosemite/platform/mac/editing/attributed-string/basic-expected.txt: Copied from LayoutTests/platform/mac/editing/attributed-string/basic-expected.txt.
  • platform/mac-yosemite/platform/mac/editing/attributed-string/font-size-expected.txt: Copied from LayoutTests/platform/mac/editing/attributed-string/font-size-expected.txt.
  • platform/mac-yosemite/platform/mac/editing/attributed-string/font-style-variant-effect-expected.txt: Copied from LayoutTests/platform/mac/editing/attributed-string/font-style-variant-effect-expected.txt.
  • platform/mac-yosemite/platform/mac/editing/attributed-string/font-weight-expected.txt: Copied from LayoutTests/platform/mac/editing/attributed-string/font-weight-expected.txt.
  • platform/mac-yosemite/platform/mac/editing/attributed-string/letter-spacing-expected.txt: Copied from LayoutTests/platform/mac/editing/attributed-string/letter-spacing-expected.txt.
  • platform/mac-yosemite/platform/mac/editing/attributed-string/text-decorations-expected.txt: Copied from LayoutTests/platform/mac/editing/attributed-string/text-decorations-expected.txt.
  • platform/mac-yosemite/platform/mac/editing/attributed-string/vertical-align-expected.txt: Copied from LayoutTests/platform/mac/editing/attributed-string/vertical-align-expected.txt.
  • platform/mac-yosemite/platform/mac/fast: Added.
  • platform/mac-yosemite/platform/mac/fast/text: Added.
  • platform/mac-yosemite/platform/mac/fast/text/ligature-subdivision-expected.txt: Copied from LayoutTests/platform/mac/fast/text/ligature-subdivision-expected.txt.
  • platform/mac-yosemite/svg: Added.
  • platform/mac-yosemite/svg/W3C-SVG-1.1: Added.
  • platform/mac-yosemite/svg/W3C-SVG-1.1-SE: Added.
  • platform/mac-yosemite/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png.
  • platform/mac-yosemite/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
  • platform/mac-yosemite/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt.
  • platform/mac-yosemite/svg/text: Added.
  • platform/mac-yosemite/svg/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.txt.
  • platform/mac-yosemite/svg/text/text-intro-05-t-expected.txt: Added.
  • platform/mac/TestExpectations:
  • platform/mac/editing/attributed-string/anchor-element-expected.txt:
  • platform/mac/editing/attributed-string/basic-expected.txt:
  • platform/mac/editing/attributed-string/font-size-expected.txt:
  • platform/mac/editing/attributed-string/font-style-variant-effect-expected.txt:
  • platform/mac/editing/attributed-string/font-weight-expected.txt:
  • platform/mac/editing/attributed-string/letter-spacing-expected.txt:
  • platform/mac/editing/attributed-string/text-decorations-expected.txt:
  • platform/mac/editing/attributed-string/vertical-align-expected.txt:
  • platform/mac/fast/dom/52776-expected.txt:
  • platform/mac/fast/text/complex-text-opacity-expected.txt:
  • platform/mac/fast/text/hyphenate-locale-expected.txt:
  • platform/mac/fast/text/international/arabic-justify-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/mac/fast/text/ligature-subdivision-expected.txt:
  • platform/mac/fast/text/line-initial-and-final-swashes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/mac/svg/text/text-intro-05-t-expected.txt:
10:05 PM Changeset in webkit [185580] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

REGRESSION(r175251, Mavericks Only): Playback may stall
​https://bugs.webkit.org/show_bug.cgi?id=145989
<rdar://problem/21271919>

Unreviewed post-review correction.

Dave Kilzer pointed out that the macro around the waitForVideoOutputMediaDataWillChange
call was incorrect. This patch corrects this error.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput): Correct the
macro definition.

9:57 PM Changeset in webkit [185579] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Fix a typo.

  • tools/pull-os-versions.py:

(main):

9:49 PM Changeset in webkit [185578] by rniwa@webkit.org
  • 1 edit
    1 move in trunk/Websites/perf.webkit.org

Perf dashboard should be able to list iOS versions as well as OS X versions
​https://bugs.webkit.org/show_bug.cgi?id=146003

Reviewed by Stephanie Lewis.

Generalized pull-osx.py so that it can run an arbitrary shell command to fetch OS versions based on
information specified in config.json.

  • tools/pull-os-versions.py: Renamed from pull-osx.py.

(main): Use available_builds_from_command when 'customCommands' is specified.
(available_builds_from_command): Added. Executes a shell command to fetch a list of available builds.
(fetch_available_builds): Now takes the repository name.

7:11 PM Changeset in webkit [185577] by Yusuke Suzuki
  • 13 edits
    3 moves
    1 add
    5 deletes in trunk/Source/JavaScriptCore

[ES6] Introduce %IteratorPrototype% and drop all XXXIteratorConstructor
​https://bugs.webkit.org/show_bug.cgi?id=145963

Reviewed by Darin Adler.

ES6 iterators inherit %IteratorPrototype%.
And these prototype objects of derived iterators don't have @@iterator methods.
Instead they use the %IteratorPrototype%[@@iterator] method.

To encourage inlining in for-of statement, we define this method in JS builtins.

And these iterator prototype objects don't have any constructor function.
This patch drops them (like StringIteratorConstructor).

  • CMakeLists.txt:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • builtins/Iterator.prototype.js: Renamed from Source/JavaScriptCore/runtime/StringIteratorConstructor.cpp.

(SymbolIterator):

  • runtime/ArrayIteratorConstructor.cpp:

(JSC::ArrayIteratorConstructor::finishCreation): Deleted.

  • runtime/ArrayIteratorConstructor.h: Removed.

(JSC::ArrayIteratorConstructor::create): Deleted.
(JSC::ArrayIteratorConstructor::createStructure): Deleted.
(JSC::ArrayIteratorConstructor::ArrayIteratorConstructor): Deleted.

  • runtime/ArrayIteratorPrototype.cpp:

(JSC::ArrayIteratorPrototype::finishCreation):
(JSC::arrayIteratorProtoFuncIterator): Deleted.

  • runtime/IteratorPrototype.cpp: Renamed from Source/JavaScriptCore/runtime/ArrayIteratorConstructor.cpp.

(JSC::IteratorPrototype::finishCreation):

  • runtime/IteratorPrototype.h: Renamed from Source/JavaScriptCore/runtime/SetIteratorConstructor.h.

(JSC::IteratorPrototype::create):
(JSC::IteratorPrototype::createStructure):
(JSC::IteratorPrototype::IteratorPrototype):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::createBuiltinFunction):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::iteratorPrototype):

  • runtime/MapIteratorConstructor.cpp: Removed.

(JSC::MapIteratorConstructor::finishCreation): Deleted.

  • runtime/MapIteratorConstructor.h: Removed.

(JSC::MapIteratorConstructor::create): Deleted.
(JSC::MapIteratorConstructor::createStructure): Deleted.
(JSC::MapIteratorConstructor::MapIteratorConstructor): Deleted.

  • runtime/MapIteratorPrototype.cpp:

(JSC::MapIteratorPrototype::finishCreation): Deleted.
(JSC::MapIteratorPrototypeFuncIterator): Deleted.

  • runtime/SetIteratorConstructor.cpp: Removed.

(JSC::SetIteratorConstructor::finishCreation): Deleted.

  • runtime/SetIteratorConstructor.h:

(JSC::SetIteratorConstructor::create): Deleted.
(JSC::SetIteratorConstructor::createStructure): Deleted.
(JSC::SetIteratorConstructor::SetIteratorConstructor): Deleted.

  • runtime/SetIteratorPrototype.cpp:

(JSC::SetIteratorPrototype::finishCreation): Deleted.
(JSC::SetIteratorPrototypeFuncIterator): Deleted.

  • runtime/StringIteratorConstructor.cpp:

(JSC::StringIteratorConstructor::finishCreation): Deleted.

  • runtime/StringIteratorConstructor.h: Removed.

(JSC::StringIteratorConstructor::create): Deleted.
(JSC::StringIteratorConstructor::createStructure): Deleted.
(JSC::StringIteratorConstructor::StringIteratorConstructor): Deleted.

  • runtime/StringIteratorPrototype.cpp:

(JSC::StringIteratorPrototype::finishCreation):
(JSC::stringIteratorPrototypeIterator): Deleted.

  • tests/stress/iterator-prototype.js: Added.

(shouldBe):
(inheritIteratorPrototype):
(testChain):

7:10 PM Changeset in webkit [185576] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

[iOS WK2] position:fixed elements sometimes truncated on scroll view bouncing
​https://bugs.webkit.org/show_bug.cgi?id=146000
rdar://problem/19448439

Reviewed by Benjamin Poulain.

When in the middle of a rubber-band (UIScrollView bounce), we could send a bad
fixed position rect down to WebCore, causing 100% height elements to get laid out
at the wrong height, possible too short. This occurred when -_updateVisibleContentRects
said we were in a stable state, but the rubber-band offset caused WebPageProxy::computeCustomFixedPositionRect()
to compute a bad rect via constrainedUnobscuredRect.intersect(documentRect).

Fix by not claiming to be in a stable state during rubber-banding. Added _scrollViewIsRubberBanding
to compute that, taking care with floating point comparisons for 3x devices.

  • UIProcess/API/Cocoa/WKWebView.mm:

(isGreaterInDevicePixels):
(-[WKWebView _scrollViewIsRubberBanding]):
(-[WKWebView _updateVisibleContentRects]):

6:57 PM Changeset in webkit [185575] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Removed a superfluous console.log per Chris's comment.

  • public/v2/app.js:
6:40 PM Changeset in webkit [185574] by rniwa@webkit.org
  • 5 edits in trunk/Websites/perf.webkit.org

Analysis task should show all possible revisions for A/B testing
​https://bugs.webkit.org/show_bug.cgi?id=145996

Reviewed by Chris Dumez.

  • public/api/commits.php:

(fetch_commits_between): When the time stamp is not available for commits, use revision numbers
to find revisions between two ranges. This is necessary for OS X and iOS versions since they don't
have a "commit time".

  • public/v2/app.js:

(App.AnalysisTaskController.updateRootConfigurations): Fetch commits between two end points.
(App.AnalysisTaskController._createConfiguration): Extracted from updateRootConfigurations. List
the fetched list of commits if available.
(App.AnalysisTaskController._serializeNumbersSkippingConsecutiveEntries): Added. Serializes an list
of numbers intelligently. For example, [1, 2, 4, 5] turns into "1-2, 4-5". Without this, some lists
of points shown in the A/B testing configurations become too long.

  • public/v2/commits-viewer.js:

(App.CommitsViewerComponent.commitsChanged):

  • public/v2/data.js:

(CommitLogs.fetchCommits): Renamed from fetchForTimeRange.

5:40 PM Changeset in webkit [185573] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: Changing state of radio buttons causes VoiceOver to go busy for a short time.
​https://bugs.webkit.org/show_bug.cgi?id=145933

Reviewed by Dean Jackson.

When radio buttons animate the new focus selection state, the thread activity looks a lot like short burst of
activity to draw, then wait on CoreAnimation to apply those changes.

Since those periods of activity during animation are so short, VoiceOver is not able to query for all the
attributes it needs, and gets stuck in the queue behind rendering.

The fix here is to turn off button state animations while VoiceOver is running.

  • platform/mac/ThemeMac.mm:

(WebCore::updateStates):

4:56 PM Changeset in webkit [185572] by Alan Bujtas
  • 4 edits
    2 adds in trunk

RootInlineBox::m_lineBreakObj becomes invalid when a child renderer is removed and the line does not get marked dirty.
​https://bugs.webkit.org/show_bug.cgi?id=145988
rdar://problem/20959137

Reviewed by David Hyatt.

This patch ensures that we find the right first inline box so that we can dirty the
the appropriate line boxes.
With marking the right line boxes dirty, now we can update RootInlineBox::m_lineBreakObj at the next layout.

Source/WebCore:

Test: fast/inline/crash-when-child-renderer-is-removed-and-line-stays-clean.html

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::setLineBreakInfo): Deleted. Remove misleading assert and comment.

LayoutTests:

  • fast/inline/crash-when-child-renderer-is-removed-and-line-stays-clean-expected.txt: Added.
  • fast/inline/crash-when-child-renderer-is-removed-and-line-stays-clean.html: Added.
4:32 PM Changeset in webkit [185571] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Stylize Node Previews
​https://bugs.webkit.org/show_bug.cgi?id=145990

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-15
Reviewed by Timothy Hatcher.

  • UserInterface/Views/FormattedValue.js:

(WebInspector.FormattedValue.createElementForNodePreview):
Style a node preview like a DOMNode. It is a simple small snippet.

  • UserInterface/Views/ObjectPreviewView.js:

(WebInspector.ObjectPreviewView.prototype._appendPropertyPreviews):
Use node previews in ObjectPreviewViews.

4:06 PM Changeset in webkit [185570] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Media Session: Improve the safety of playback toggling
​https://bugs.webkit.org/show_bug.cgi?id=145986

Patch by Matt Rajca <​mrajca@apple.com> on 2015-06-15
Reviewed by Darin Adler.

  • Modules/mediasession/MediaSession.cpp:

(WebCore::MediaSession::togglePlayback): Improved the safety of the loop so that we don't re-visit elements that

may have been deleted underneath us.

  • Modules/mediasession/MediaSession.h: Added a pointer to the set of iterated active participating elements so we can remove any elements that are deleted from the underlying "real" set.
3:48 PM Changeset in webkit [185569] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

REGRESSION(r175251, Mavericks Only): Playback may stall
​https://bugs.webkit.org/show_bug.cgi?id=145989
<rdar://problem/21271919>

Reviewed by Dean Jackson.

Revert r175251 for Mavericks build targets.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):

3:27 PM Changeset in webkit [185568] by ryuan.choi@navercorp.com
  • 2 edits in trunk/Source/WebKit2

Fix build break when ENABLE_SECCOMP_FILTERS is ON
​https://bugs.webkit.org/show_bug.cgi?id=145967

Reviewed by Carlos Garcia Campos.

Since r183189, ArgumentEncoder::addAttachment requires rvalue reference.

  • Shared/linux/SeccompFilters/OpenSyscall.cpp:

(WebKit::OpenSyscallResult::encode): Use WTF::move().

3:01 PM Changeset in webkit [185567] by Darin Adler
  • 3 edits
    3 adds in trunk

REGRESSION (r182215): Reproducible crash at drawsvg.org due to reentrant layout
​https://bugs.webkit.org/show_bug.cgi?id=145964

Reviewed by Simon Fraser.

Source/WebCore:

Test: svg/as-object/mutate-on-load.html

  • page/FrameView.cpp:

(WebCore::FrameView::forceLayoutParentViewIfNeeded): Don't do a synchronous layout here,
because it can lead indirectly to unwanted layout reentrancy. Instead schedule a layout.

LayoutTests:

  • svg/as-object/mutate-on-load-expected.html: Added.
  • svg/as-object/mutate-on-load.html: Added.
  • svg/as-object/resources/embedded-mutates-on-load.svg: Added.
2:26 PM Changeset in webkit [185566] by msaboff@apple.com
  • 3 edits
    3 adds in trunk

JIT bug - fails when inspector closed, works when open
​https://bugs.webkit.org/show_bug.cgi?id=145243

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

We need to provide the Arguments object as the base when creating the HeapLocation for
GetFromArguments and PutToArguments. Otherwise we endup creating a HeapLocation for
any arguments object, not the one we need.

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

LayoutTests:

New regression test.

  • js/regress-145243-expected.txt: Added.
  • js/regress-145243.html: Added.
  • js/script-tests/regress-145243.js: Added.

(bar):
(foo):
(test):

12:47 PM Changeset in webkit [185565] by matthew_hanson@apple.com
  • 5 edits in tags/Safari-601.1.35.1/Source

Versioning.

12:36 PM Changeset in webkit [185564] by matthew_hanson@apple.com
  • 18 edits in tags/Safari-601.1.35.1

Merge r185487. rdar://problem/21277462

12:29 PM Changeset in webkit [185563] by Chris Dumez
  • 5 edits in trunk/Source/WebKit2

[WK2] BrowsingContextController.loadData API is leaking Navigation objects
​https://bugs.webkit.org/show_bug.cgi?id=145977
<rdar://problem/21305706>

Reviewed by Darin Adler.

BrowsingContextController.loadData API was leaking Navigation objects.
The issue was due to WebPageProxy::loadData() creating a Navigation
object but not passing along the navigationID to the WebProcess when
sending the Messages::WebPage::LoadData IPC. As a result, the
WebProcess would use 0 as navigationID and we would end up creating a
new Navigation object later on for the same navigation.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadData):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadData):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
12:16 PM Changeset in webkit [185562] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Improve some cases of "Object?" Type Annotations
​https://bugs.webkit.org/show_bug.cgi?id=145954

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-15
Reviewed by Timothy Hatcher.

  • UserInterface/Views/TypeTokenView.js:

(WebInspector.TypeTokenView.prototype._displayTypeName):
The TypeSet inclusions cover all types, so we can use the leastCommonAncestor
name as long as the type set is just object or object and null/undefined.
If the typeset includes other primitives then it will gracefully go down
below to become something like Object or (many).

12:07 PM Changeset in webkit [185561] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-601.1.35.1

New Tag.

11:55 AM Changeset in webkit [185560] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Media Session: Active participating elements can change while being iterated
​https://bugs.webkit.org/show_bug.cgi?id=145978

Patch by Matt Rajca <​mrajca@apple.com> on 2015-06-15
Reviewed by Alex Christensen.

  • Modules/mediasession/MediaSession.cpp:

(WebCore::MediaSession::togglePlayback): Iterate through a copy of m_activeParticipatingElements since its contents

can be modified in the loop.

11:50 AM Changeset in webkit [185559] by Joseph Pecoraro
  • 2 edits in trunk/LayoutTests

Unreviewed, gardening for Windows.

  • platform/win/TestExpectations:
11:39 AM Changeset in webkit [185558] by Chris Fleizach
  • 9 edits
    2 adds in trunk

AX: no accessibility support for details element
​https://bugs.webkit.org/show_bug.cgi?id=131111

Reviewed by Darin Adler.

Source/WebCore:

Add accessibility support for Mac for details element by:

1) Returning new subroles for <details> and <summary>
2) Exposing isExpanded property for <details> element.

Test: platform/mac/accessibility/details-summary.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::supportsARIAPressed):
(WebCore::AccessibilityObject::supportsExpanded):
(WebCore::AccessibilityObject::isExpanded):
(WebCore::AccessibilityObject::supportsARIAExpanded): Deleted.

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::canvasHasFallbackContent):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilitySupportsARIAExpanded]):
(-[WebAccessibilityObjectWrapper accessibilityIsExpanded]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):

  • html/HTMLDetailsElement.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

LayoutTests:

  • platform/mac/accessibility/details-summary-expected.txt: Added.
  • platform/mac/accessibility/details-summary.html: Added.
11:08 AM Changeset in webkit [185557] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r185298): Databases service has Web Content service’s entitlements
​https://bugs.webkit.org/show_bug.cgi?id=145980

Reviewed by Darin Adler.

  • Configurations/DatabaseService.xcconfig: Set WK_XPC_SERVICE_IOS_ENTITLEMENTS_BASE to

Databases-iOS.

11:07 AM Changeset in webkit [185556] by jonlee@apple.com
  • 5 edits in trunk/Source/WebKit2

[WK2] Add allowsPictureInPictureMediaPlayback
​https://bugs.webkit.org/show_bug.cgi?id=145901
rdar://problem/21349851

Reviewed by Anders Carlsson.

Replace _allowsAlternateFullscreen with allowsPictureInPictureMediaPlayback.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.h: Add allowsPictureInPictureMediaPlayback.
  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]): Remove _allowsAlternateFullscreen.
(-[WKWebViewConfiguration copyWithZone:]): Replace the variable.
(-[WKWebViewConfiguration _allowsAlternateFullscreen]): Deleted.
(-[WKWebViewConfiguration _setAllowsAlternateFullscreen:]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: Remove the SPI.
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]): Update to use the new API.

10:23 AM Changeset in webkit [185555] by commit-queue@webkit.org
  • 6 edits in trunk

Source/WebCore:
[Content Extensions] Limit number of rules.
​https://bugs.webkit.org/show_bug.cgi?id=145663

Patch by Alex Christensen <​achristensen@webkit.org> on 2015-06-15
Reviewed by Benjamin Poulain.

Added an API test to make sure that parsing fails when there are too many rules.

  • contentextensions/ContentExtensionError.cpp:

(WebCore::ContentExtensions::contentExtensionErrorCategory):

  • contentextensions/ContentExtensionError.h:
  • contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::loadEncodedRules):
Fail to parse a content extension with more than 50000 rules.

Tools:
[Content Extensions] Make max NFA size and max rule count user defaults.
​https://bugs.webkit.org/show_bug.cgi?id=145663

Patch by Alex Christensen <​achristensen@webkit.org> on 2015-06-15
Reviewed by Benjamin Poulain.

  • TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::TEST_F):

9:57 AM Changeset in webkit [185554] by ap@apple.com
  • 14 edits in trunk

-[WKWebView evaluateJavaScript] provides a misleading error when the return cannot be serialized
​https://bugs.webkit.org/show_bug.cgi?id=145900

Reviewed by Sam Weinig.

Source/WebCore:

  • English.lproj/Localizable.strings:

Source/WebKit2:

We used to conflate to cases: (1) when there was a JavaScript exception, and
(2) when the result could not be serialized for IPC. Turns out that it was quite
misleading!

  • UIProcess/API/C/WKPage.cpp:

(WKPageRunJavaScriptInMainFrame):

  • UIProcess/API/Cocoa/WKError.h:
  • UIProcess/API/Cocoa/WKError.mm:

(localizedDescriptionForErrorCode):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView evaluateJavaScript:completionHandler:]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::scriptValueCallback):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_run_javascript):
(resourcesStreamReadCallback):

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:

(TEST): Added tests.

9:36 AM Changeset in webkit [185553] by Carlos Garcia Campos
  • 8 edits in trunk

[SOUP] Custom URI schemes don't work for requests containing a fragment identifier
​https://bugs.webkit.org/show_bug.cgi?id=145969

Reviewed by Sergio Villar Senin.

Source/WebCore:

For URIs like foo:bar#baz, what the custom protocol manager
receives in the UI process is foo:bar, so the user can't handle fragments.

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupRequest): If the SoupRequest
is a WebKitSoupRequestGeneric, call
webkitSoupRequestGenericSetRequest with the ResourceRequest.

  • platform/network/soup/WebKitSoupRequestGeneric.cpp:

(webkitSoupRequestGenericSetRequest):
(webkitSoupRequestGenericGetRequest):

  • platform/network/soup/WebKitSoupRequestGeneric.h:

Source/WebKit2:

Use the WebKitSoupRequestGeneric request instead of creating a new one
from the SoupRequest URI, since that is the network one and doesn't
contain the fragment identifier part.

  • Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp:

(WebKit::CustomProtocolManagerImpl::start):

Tools:

Add a test case to the custom URI schemes unit test.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:

(testWebContextURIScheme):

8:43 AM Changeset in webkit [185552] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL] Make send/receive messages to communicate the Web and UI Processes using Injected Bundle.
​https://bugs.webkit.org/show_bug.cgi?id=145685

Patch by Hyungwook Lee <​hyungwook.lee@navercorp.com> on 2015-06-15
Reviewed by Gyuyoung Kim.

To have extensible port specific API facility using Injected Bundle,
we need to load libewebkit_extension_manager.so in default that is same as what gtk port does.

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::EwkContext):
(EwkContext::~EwkContext):
(EwkContext::findOrCreateWrapper):
(bundlePathForExtension):
(EwkContext::create): Deleted.

  • UIProcess/API/efl/ewk_context_private.h:
  • WebProcess/efl/ExtensionManagerEfl.cpp:

(WebKit::ExtensionManagerEfl::initialize):

8:34 AM Changeset in webkit [185551] by Carlos Garcia Campos
  • 8 edits
    3 moves in trunk/Source

[SOUP] Move WebKitSoupRequestGeneric to platform layer
​https://bugs.webkit.org/show_bug.cgi?id=145968

Reviewed by Sergio Villar Senin.

Source/WebCore:

  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • platform/network/soup/WebKitSoupRequestGeneric.cpp: Renamed from Source/WebKit2/WebProcess/soup/WebKitSoupRequestGeneric.cpp.

(webkitSoupRequestGenericFinalize):
(webkit_soup_request_generic_init):
(webkitSoupRequestGenericSendAsync):
(webkitSoupRequestGenericSendFinish):
(webkitSoupRequestGenericGetContentLength):
(webkitSoupRequestGenericGetContentType):
(webkit_soup_request_generic_class_init):
(webkitSoupRequestGenericSetContentLength):
(webkitSoupRequestGenericSetContentType):

  • platform/network/soup/WebKitSoupRequestGeneric.h: Renamed from Source/WebKit2/WebProcess/soup/WebKitSoupRequestGeneric.h.
  • platform/network/soup/WebKitSoupRequestGenericClient.h: Renamed from Source/WebKit2/WebProcess/soup/WebKitSoupRequestGenericClient.h.

Source/WebKit2:

  • PlatformEfl.cmake: Remove WebKitSoupRequestGeneric.
  • PlatformGTK.cmake: Ditto.
  • Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp:
  • Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.h:
6:09 AM Changeset in webkit [185550] by Csaba Osztrogonác
  • 2 edits
    1 add in trunk/Tools

[GTK] Fix deprecated-register warning in the generated WebKitMarshal.cpp
​https://bugs.webkit.org/show_bug.cgi?id=145922

Reviewed by Carlos Garcia Campos.

  • gtk/jhbuild.modules:
  • gtk/patches/glib-warning-fix.patch: Added.
4:20 AM Changeset in webkit [185549] by Csaba Osztrogonác
  • 4 edits in trunk/Source/WebKit2

Fix unused private field warning in PageBanner.h
​https://bugs.webkit.org/show_bug.cgi?id=145925

Reviewed by Darin Adler.

  • WebProcess/WebPage/PageBanner.cpp:

(WebKit::PageBanner::~PageBanner):

  • WebProcess/WebPage/PageBanner.h: Initialize m_type, m_webPage, m_mouseDownInBanner, and m_isHidden here instead of in the constructor.
  • WebProcess/WebPage/mac/PageBannerMac.mm: Use PLATFORM(MAC) instead of !PLATFORM(IOS), they are same in objc files.
4:09 AM Changeset in webkit [185548] by Carlos Garcia Campos
  • 5 edits
    1 add in trunk/Source/WebKit2

[SOUP] Make WebKitSoupRequestGeneric independent from CustomProtocolManagerImpl
​https://bugs.webkit.org/show_bug.cgi?id=145966

Reviewed by Sergio Villar Senin.

Add WebKitSoupRequestGenericClient with start and finish methods,
that are implemented by WebKitSoupRequestGeneric.
This allows us to move WebKitSoupRequestGeneric to platform layer.

  • Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp:

(WebKit::CustomProtocolManagerImpl::registerScheme):
(WebKit::CustomProtocolManagerImpl::start):

  • Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.h:
  • WebProcess/soup/WebKitSoupRequestGeneric.cpp:

(webkitSoupRequestGenericSendAsync):
(webkitSoupRequestGenericSendFinish):

  • WebProcess/soup/WebKitSoupRequestGeneric.h:
  • WebProcess/soup/WebKitSoupRequestGenericClient.h: Added.

Jun 14, 2015:

9:13 PM Changeset in webkit [185547] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed the build.

  • mac/postprocess-framework-headers.sh:
2:10 PM Changeset in webkit [185546] by Michael Catanzaro
  • 3 edits in trunk/Source/WebKit2

Format string misuse in DatabaseProcessIDBConnection.cpp and UniqueIDBDatabaseBackingStoreSQLite.cpp
​https://bugs.webkit.org/show_bug.cgi?id=145960

Reviewed by Darin Adler.

Use PRIu64 and PRIi64 to print uint64_t and int64_t, respectively. These things are
different types on x86_64 Linux (unsigned long) and on Mac (unsigned long long).

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata):
(WebKit::DatabaseProcessIDBConnection::deleteDatabase):
(WebKit::DatabaseProcessIDBConnection::openTransaction):
(WebKit::DatabaseProcessIDBConnection::beginTransaction):
(WebKit::DatabaseProcessIDBConnection::commitTransaction):
(WebKit::DatabaseProcessIDBConnection::resetTransaction):
(WebKit::DatabaseProcessIDBConnection::rollbackTransaction):
(WebKit::DatabaseProcessIDBConnection::changeDatabaseVersion):
(WebKit::DatabaseProcessIDBConnection::createObjectStore):
(WebKit::DatabaseProcessIDBConnection::deleteObjectStore):
(WebKit::DatabaseProcessIDBConnection::clearObjectStore):
(WebKit::DatabaseProcessIDBConnection::createIndex):
(WebKit::DatabaseProcessIDBConnection::deleteIndex):
(WebKit::DatabaseProcessIDBConnection::putRecord):
(WebKit::DatabaseProcessIDBConnection::getRecord):
(WebKit::DatabaseProcessIDBConnection::count):
(WebKit::DatabaseProcessIDBConnection::deleteRange):
(WebKit::DatabaseProcessIDBConnection::openCursor):
(WebKit::DatabaseProcessIDBConnection::cursorAdvance):
(WebKit::DatabaseProcessIDBConnection::cursorIterate):

  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::clearObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteIndex):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::generateKeyNumber):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::keyExistsInObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::putRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::uncheckedPutIndexRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getKeyRecordFromObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getKeyRangeRecordFromObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::advanceCursor):

2:00 PM Changeset in webkit [185545] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

[Cocoa] Clean up postprocess-framework-headers.sh
​https://bugs.webkit.org/show_bug.cgi?id=145962

Reviewed by Darin Adler.

  • mac/postprocess-framework-headers.sh: Gather all the sed options in a variable, and then

run sed only once on each header. Also, correctly exit with the sed return value if it
fails.

1:37 AM Changeset in webkit [185544] by Andres Gomez
  • 2 edits in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Update icon so Rendering Frames timeline distinguish between layout and painting
​https://bugs.webkit.org/show_bug.cgi?id=145956

Reviewed by Carlos Garcia Campos.

  • UserInterface/Images/gtk/TimelineRecordPaint.svg:

Changed to use green color.

Note: See TracTimeline for information about the timeline view.