Timeline
Jun 21, 2015:
- 11:32 PM Changeset in webkit [185818] by
-
- 9 edits in trunk/Source
Page load performance regression due to bugs.webkit.org/show_bug.cgi?id=145542
https://bugs.webkit.org/show_bug.cgi?id=146198
Unreviewed rollout.
Source/WebCore:
- platform/network/DNSResolveQueue.cpp:
(WebCore::DNSResolveQueue::DNSResolveQueue):
(WebCore::DNSResolveQueue::isUsingProxy):
(WebCore::DNSResolveQueue::add):
(WebCore::DNSResolveQueue::timerFired):
- platform/network/DNSResolveQueue.h:
- platform/network/cf/DNSCFNet.cpp:
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::clientCallback):
(WebCore::DNSResolveQueue::platformResolve):
(WebCore::proxyIsEnabledInSystemPreferences): Deleted.
(WebCore::isUsingProxy): Deleted.
(WebCore::DNSResolveQueue::platformMaybeResolveHost): Deleted.
- platform/network/soup/DNSSoup.cpp:
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_prefetch_dns):
Source/WTF:
- wtf/glib/GUniquePtr.h:
- 9:48 PM Changeset in webkit [185817] by
-
- 2 edits in trunk/Source/WebKit2
WKApplicationCacheManagerDeleteEntriesForOrigin() has wrong WebsiteDataTypes.
https://bugs.webkit.org/show_bug.cgi?id=146180
Patch by Hyungwook Lee <hyungwook.lee@navercorp.com> on 2015-06-21
Reviewed by Sam Weinig.
Modify to use correct WebsiteDataTypes in WKApplicationCacheManagerDeleteEntriesForOrigin()
- UIProcess/API/C/WKApplicationCacheManager.cpp:
(WKApplicationCacheManagerDeleteEntriesForOrigin):
- 9:25 PM Changeset in webkit [185816] by
-
- 5 edits1 add in trunk
REGRESSION (r172975): navigator.language unable to tell region for Traditional Chinese users
https://bugs.webkit.org/show_bug.cgi?id=146121
rdar://problem/21395180
Reviewed by Darin Adler.
Source/WebCore:
Revert to previous behavior, which is wrong in many ways, but not as wrong as the new one.
- platform/mac/Language.mm:
(WebCore::httpStyleLanguageCode):
(WebCore::platformUserPreferredLanguages):
- platform/spi/cf/CFBundleSPI.h:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: Added.
(-[NavigatorLanguageDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::overrideAppleLanguages):
(TestWebKitAPI::languageForSystemLanguage):
(TestWebKitAPI::TEST):
- 8:25 PM Changeset in webkit [185815] by
-
- 2 edits in trunk/LayoutTests
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html is slow on Mavericks WK1 Debug builds
The Flakiness Dashboard says that this test times out, but only
on Mavericks WK1 Debug builds (and the leaks bot):
- platform/mac-wk1/TestExpectations: Mark test as slow on
Mavericks Debug builds:
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html
- 4:44 PM Changeset in webkit [185814] by
-
- 3 edits in trunk/Source/WebKit2
<rdar://problem/21444762> REGRESSION (r184215): Plug-in services crash on launch on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=146195
Reviewed by Sam Weinig.
- Configurations/PluginService.32.xcconfig: Changed the Yosemite definition of
INFOPLIST_FILE such that it would also apply to the macosx10.10.internal SDK.
- Configurations/PluginService.64.xcconfig: Ditto.
- 2:14 PM Changeset in webkit [185813] by
-
- 23 edits in trunk/Source/WebCore
Give Node::didNotifySubtreeInsertions() a better name
https://bugs.webkit.org/show_bug.cgi?id=146170
Reviewed by Darin Adler.
didNotifySubtreeInsertions() is not a good name. It sounds like we are notifying the subtree insertions, which doesn't make sense.
This function is really about notifying the Node that the subtree it's a part of has finished being inserted into the DOM
(i.e. all nodes have received their call to insertedInto()). Change the name to finishedInsertingSubtree() to better reflect this.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::notifyChildInserted):
- dom/ContainerNodeAlgorithms.h:
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
- dom/Element.cpp:
(WebCore::Element::addShadowRoot):
- dom/Node.h:
(WebCore::Node::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::Node::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::ScriptElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- dom/ScriptElement.h:
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::insertedInto):
(WebCore::HTMLFrameElementBase::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- html/HTMLFrameElementBase.h:
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::insertedInto):
(WebCore::HTMLScriptElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::HTMLScriptElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- html/HTMLScriptElement.h:
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::insertedInto):
(WebCore::SVGFEImageElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::SVGFEImageElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- svg/SVGFEImageElement.h:
- svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::insertedInto):
(WebCore::SVGMPathElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::SVGMPathElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- svg/SVGMPathElement.h:
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::insertedInto):
(WebCore::SVGScriptElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::SVGScriptElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- svg/SVGScriptElement.h:
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::insertedInto):
(WebCore::SVGTRefElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::SVGTRefElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- svg/SVGTRefElement.h:
- svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::insertedInto):
(WebCore::SVGTextPathElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::SVGTextPathElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- svg/SVGTextPathElement.h:
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::insertedInto):
(WebCore::SVGSMILElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::SVGSMILElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- svg/animation/SVGSMILElement.h:
- 9:44 AM Changeset in webkit [185812] by
-
- 3 edits in trunk/LayoutTests
fast/fixed-layout/fixed-layout.html times out on Apple WK2 bots
The Flakiness Dashboard says this test times out on Apple
WebKit2 platforms by not calling testRunner.notifyDone():
- fast/css-grid-layout/flex-content-sized-columns-resize.html:
Use the same mechanism here that was just added in r185811.
- fast/fixed-layout/fixed-layout.html: Switch to using a
zero-delay timer instead of document.body.offsetTop.
- 9:16 AM Changeset in webkit [185811] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r185809): fast/css-grid-layout/flex-content-sized-columns-resize.html hangs on WK1
Since window.resize() occurs in the same runloop as the load on
WK1, testRunner.notifyDone() would never get called.
- fast/css-grid-layout/flex-content-sized-columns-resize.html:
Call document.body.offsetTop to ensure layout occurs at the
initial window size before calling window.resize().
- 9:01 AM Changeset in webkit [185810] by
-
- 2 edits in trunk/Source/WebKit2
Build fix.
- Shared/API/Cocoa/WKFoundation.h: Don’t use generics if the SDK doesn’t support them.
- 8:57 AM Changeset in webkit [185809] by
-
- 2 edits in trunk/LayoutTests
fast/css-grid-layout/flex-content-sized-columns-resize.html is flaky
The Flakiness Dashboard says this test is flaky on Apple and EFL
WebKit2 platforms:
It currently doesn't wait for window.resize() to complete, which
is likely the source of flakiness.
- fast/css-grid-layout/flex-content-sized-columns-resize.html:
Switch to using notifyDone() inside a window.onresize function,
and make the test work in a web browser without TestRunner.
- 6:19 AM Changeset in webkit [185808] by
-
- 2 edits in trunk/Source/WebKit2
[SOUP] Use GTask in WebKitSoupRequestInputStream
https://bugs.webkit.org/show_bug.cgi?id=146184
Reviewed by Carlos Garcia Campos.
Replace deprecated use of GSimpleAsyncResult with GTask.
- WebProcess/soup/WebKitSoupRequestInputStream.cpp:
(AsyncReadData::AsyncReadData):
(webkitSoupRequestInputStreamReadAsyncResultComplete):
(webkitSoupRequestInputStreamPendingReadAsyncComplete):
(webkitSoupRequestInputStreamReadAsync):
(webkitSoupRequestInputStreamReadFinish):
- 6:15 AM Changeset in webkit [185807] by
-
- 4 edits in trunk/Source/WebKit2
Fix format strings in NetworkCache.cpp and NetworkCacheStatistics.cpp and WebIDBServerConnection.cpp
https://bugs.webkit.org/show_bug.cgi?id=146172
Reviewed by Darin Adler.
Use the correct %"PRIu64" and %"PRIi64" for uint64_t and int64_t, instead of %llu and %lli.
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::retrieve):
- NetworkProcess/cache/NetworkCacheStatistics.cpp:
(WebKit::NetworkCache::Statistics::initialize):
(WebKit::NetworkCache::Statistics::recordNotUsingCacheForRequest):
(WebKit::NetworkCache::Statistics::recordRetrievalFailure):
(WebKit::NetworkCache::Statistics::recordRetrievedCachedEntry):
(WebKit::NetworkCache::Statistics::recordRevalidationSuccess):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::deleteDatabase):
(WebKit::WebIDBServerConnection::didDeleteDatabase):
(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata):
(WebKit::WebIDBServerConnection::didGetOrEstablishIDBDatabaseMetadata):
(WebKit::WebIDBServerConnection::openTransaction):
(WebKit::WebIDBServerConnection::didOpenTransaction):
(WebKit::WebIDBServerConnection::beginTransaction):
(WebKit::WebIDBServerConnection::didBeginTransaction):
(WebKit::WebIDBServerConnection::commitTransaction):
(WebKit::WebIDBServerConnection::didCommitTransaction):
(WebKit::WebIDBServerConnection::resetTransaction):
(WebKit::WebIDBServerConnection::didResetTransaction):
(WebKit::WebIDBServerConnection::rollbackTransaction):
(WebKit::WebIDBServerConnection::didRollbackTransaction):
(WebKit::WebIDBServerConnection::createObjectStore):
(WebKit::WebIDBServerConnection::didCreateObjectStore):
(WebKit::WebIDBServerConnection::createIndex):
(WebKit::WebIDBServerConnection::didCreateIndex):
(WebKit::WebIDBServerConnection::deleteIndex):
(WebKit::WebIDBServerConnection::didDeleteIndex):
(WebKit::WebIDBServerConnection::get):
(WebKit::WebIDBServerConnection::put):
(WebKit::WebIDBServerConnection::didPutRecord):
(WebKit::WebIDBServerConnection::didGetRecord):
(WebKit::WebIDBServerConnection::didOpenCursor):
(WebKit::WebIDBServerConnection::didAdvanceCursor):
(WebKit::WebIDBServerConnection::didIterateCursor):
(WebKit::WebIDBServerConnection::count):
(WebKit::WebIDBServerConnection::didCount):
(WebKit::WebIDBServerConnection::deleteRange):
(WebKit::WebIDBServerConnection::didDeleteRange):
(WebKit::WebIDBServerConnection::clearObjectStore):
(WebKit::WebIDBServerConnection::didClearObjectStore):
(WebKit::WebIDBServerConnection::deleteObjectStore):
(WebKit::WebIDBServerConnection::didDeleteObjectStore):
(WebKit::WebIDBServerConnection::changeDatabaseVersion):
(WebKit::WebIDBServerConnection::didChangeDatabaseVersion):
(WebKit::WebIDBServerConnection::openCursor):
(WebKit::WebIDBServerConnection::cursorAdvance):
(WebKit::WebIDBServerConnection::cursorIterate):
- 6:15 AM Changeset in webkit [185806] by
-
- 13 edits in trunk/Tools
[CMake] Ignore warnings from system headers when compiling Tools
https://bugs.webkit.org/show_bug.cgi?id=146185
Reviewed by Martin Robinson.
Use the SYSTEM argument to the include_directories() command to silence compiler warnings
from system headers that we don't control.
- DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
- ImageDiff/CMakeLists.txt: Also, remove an EFL include directory from here...
- ImageDiff/PlatformEfl.cmake: ...and put it here where it belongs.
- ImageDiff/PlatformGTK.cmake:
- MiniBrowser/efl/CMakeLists.txt:
- MiniBrowser/gtk/CMakeLists.txt:
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/PlatformGTK.cmake:
- TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
- WebKitTestRunner/CMakeLists.txt:
- WebKitTestRunner/PlatformEfl.cmake:
- WebKitTestRunner/PlatformGTK.cmake:
- 3:06 AM Changeset in webkit [185805] by
-
- 5 edits in trunk
libwebkit2gtk fails to link without opengl
https://bugs.webkit.org/show_bug.cgi?id=138332
Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-06-21
Reviewed by Carlos Garcia Campos.
.:
- Source/cmake/OptionsGTK.cmake: USE(TEXTURE_MAPPER) must be
enabled regardless of whether OpenGL is, because certain symbols
such as WebCore::GraphicsLayer::create() need to be built.
Source/WebCore:
- CMakeLists.txt: The third-party ANGLE directories need to be
included even if ENABLE(GRAPHICS_CONTEXT_3D) is false. They must
be included after the OpenGL headers as the comment says.
- platform/graphics/texmap/BitmapTexturePool.cpp: Remove
reference to no longer existent header file.
Jun 20, 2015:
- 11:43 PM Changeset in webkit [185804] by
-
- 9 edits in trunk/Source
Deselection of text causes a noticeable jump on force touch machines
https://bugs.webkit.org/show_bug.cgi?id=146173
<rdar://problem/20992842>
Reviewed by Sam Weinig.
Source/WebCore:
When we have a TextIndicator of type Crossfade, we end up putting
a layer with the blue highlight + text painted into it on top of the
content, and cross-fading that layer to the yellow-highlighted text.
This is necessary for BounceAndCrossfade TextIndicators, because the
blue highlight has to bounce, but is not necessary for Crossfade-only
ones; we can just fade in the yellow highlight on top of the
existing blue page highlight, and all is well.
So, get rid of the Crossfade TextIndicator type and use FadeIn, separately
keeping track of whether or not we can add a margin (we still can't
add a margin to TextIndicators that indicate the page's current selection,
because the blue highlight cannot have the margin applied to it, and we
want the bounds to match exactly).
- page/TextIndicator.cpp:
(WebCore::TextIndicator::createWithRange):
If the range is the same as the selection, turn off the margin.
We were previously doing this based on the presentation transition, but now
there's no difference in presentation transition in this case.
(WebCore::TextIndicator::createWithSelectionInFrame):
(WebCore::TextIndicator::wantsBounce):
(WebCore::TextIndicator::wantsContentCrossfade):
(WebCore::TextIndicator::wantsFadeIn):
(WebCore::TextIndicator::wantsManualAnimation):
- page/TextIndicator.h:
Get rid of TextIndicatorPresentationTransition::Crossfade.
(WebCore::TextIndicator::setWantsMargin):
(WebCore::TextIndicator::wantsMargin):
Keep track of whether we want a margin.
- page/mac/TextIndicatorWindow.mm:
(-[WebTextIndicatorView initWithFrame:textIndicator:margin:]):
Determine if we should use a margin based on wantsMargin instead of the
presentation transition.
Source/WebKit/mac:
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _animationControllerForText]):
Get rid of TextIndicatorPresentationTransition::Crossfade.
Source/WebKit2:
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<TextIndicatorData>::encode):
(IPC::ArgumentCoder<TextIndicatorData>::decode):
Encode/decode wantsMargin.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performImmediateActionHitTestAtLocation):
(WebKit::textIndicatorTransitionForImmediateAction): Deleted.
Get rid of TextIndicatorPresentationTransition::Crossfade.
- 8:27 PM Changeset in webkit [185803] by
-
- 5 edits in trunk/Source/WebKit2
[Cocoa] Actually use Objective-C lightweight generics when the compiler supports them
https://bugs.webkit.org/show_bug.cgi?id=146183
Reviewed by Sam Weinig.
- Shared/API/Cocoa/WKFoundation.h: When the compiler supports Objective-C generics, define
WK_ARRAY and WK_SET to use them. Also added a definition of WK_DICTIONARY.
- UIProcess/API/Cocoa/WKWebViewPrivate.h: Use WK_DICTIONARY for the options dictionary of
-_loadRequest:withOptions:.
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:]): Made the completion
halder type match the declaration, now that NSArray and WK_ARRAY(WKWebsiteDataRecord *) are
not the same.
- mac/postprocess-framework-headers.sh: Also rewrite WK_DICTIONARY.
- 4:00 PM Changeset in webkit [185802] by
-
- 4 edits in trunk
[EFL][GTK] Define GLIB_VERSION_MIN_REQUIRED and require glib 2.36 for GTK
https://bugs.webkit.org/show_bug.cgi?id=146181
Reviewed by Martin Robinson.
.:
Bump our GLib requirement to 2.36 to reflect reality, since we are using GTask.
- Source/cmake/OptionsGTK.cmake:
Source/WTF:
Define GLIB_VERSION_MIN_REQUIRED to avoid deprecation warnings.
- wtf/Platform.h:
- 3:50 PM Changeset in webkit [185801] by
-
- 2 edits in trunk/Tools
[GTK] Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=146186
Reviewed by Martin Robinson.
Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser to silence several dozen
deprecation warnings. (MiniBrowser is unique in that it does not include wtf/Platform.h.)
- MiniBrowser/gtk/CMakeLists.txt:
- 3:47 PM Changeset in webkit [185800] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Unable to select parent element in the DOM tree path bar
https://bugs.webkit.org/show_bug.cgi?id=145810
Reviewed by Timothy Hatcher.
- UserInterface/Views/DOMTreeContentView.js:
(WebInspector.DOMTreeContentView.prototype.get selectionPathComponents):
- UserInterface/Views/HierarchicalPathComponent.js:
(WebInspector.HierarchicalPathComponent.prototype.get selectedPathComponent):
(WebInspector.HierarchicalPathComponent.prototype._selectElementMouseUp):
(WebInspector.HierarchicalPathComponent.prototype._selectElementSelectionChanged):
(WebInspector.HierarchicalPathComponent):
(WebInspector.HierarchicalPathComponent.prototype._selectElementMouseDown): Deleted.
- 1:50 PM Changeset in webkit [185799] by
-
- 7 edits in trunk/Source/WebKit2
[WK2][iOS] Avoid synchronous IPC on view state change when the content is not visible
https://bugs.webkit.org/show_bug.cgi?id=146179
<rdar://problem/20923432>
Reviewed by Tim Horton.
After r170787, viewStateChange() would cause a synchronous IPC between
the UIProcess and the WebProcess when the view becomes visible. This
was to avoid painting empty / black tiles when unsuspending the
WebProcess on tab switch, in the event volatile IOSurfaces were purged.
However, this sync IPC can have performance implications and is not
needed when the content is not actually visible yet (e.g.
hideContentUntilNextUpdate() was called, or the tab was killed).
This patch avoids the synchronous IPC when the content is hidden and
exposes a private API on WKWebView so that clients can ask for the
content to be hidden until the next update. This would allow for
clients to avoid the synchronous IPC if they don't need the content
to be displayed synchronously (e.g. the view is obscured).
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _hideContentUntilNextUpdate]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::hasVisibleContent):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dispatchViewStateChange):
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::isContentHidden):
- 9:48 AM Changeset in webkit [185798] by
-
- 3 edits4 copies in trunk/LayoutTests
REGRESSION (r185779): fast/canvas/{canvas-toDataURL-crash,pattern-too-large-to-create}.html are broken
This layout test started failing after the fix for:
Extremely large canvas crashes on pre-El Capitan machines
https://bugs.webkit.org/show_bug.cgi?id=146169
<rdar://problem/21410046>
Different limits require different test results for each
platform. This is the same fix for these tests as r185793.
- fast/canvas/canvas-toDataURL-crash-expected.txt: Update.
- fast/canvas/pattern-too-large-to-create-expected.txt: Update.
- Set limit to 268435456.
- platform/ios-simulator/fast/canvas/canvas-toDataURL-crash-expected.txt: Copied from LayoutTests/fast/canvas/canvas-toDataURL-crash-expected.txt.
- platform/ios-simulator/fast/canvas/pattern-too-large-to-create-expected.txt: Copied from LayoutTests/fast/canvas/pattern-too-large-to-create-expected.txt.
- Set limit to 16777216.
- platform/mac-yosemite/fast/canvas/canvas-toDataURL-crash-expected.txt: Copied from LayoutTests/fast/canvas/canvas-toDataURL-crash-expected.txt.
- platform/mac-yosemite/fast/canvas/pattern-too-large-to-create-expected.txt: Copied from LayoutTests/fast/canvas/pattern-too-large-to-create-expected.txt.
- Set limit to 67108864.
- 9:30 AM Changeset in webkit [185797] by
-
- 2 edits in trunk/LayoutTests
fast/canvas/webgl/tex-image-and-uniform-binding-bugs.html is slow on Mavericks WK1 Debug builds
The Flakiness Dashboard says that this test times out, but only
on Mavericks WK1 Debug builds:
- platform/mac-wk1/TestExpectations: Mark test as slow on
Mavericks Debug builds:
- fast/canvas/webgl/tex-image-and-uniform-binding-bugs.html
- 9:16 AM Changeset in webkit [185796] by
-
- 2 edits in trunk/LayoutTests
editing/selection/leak-document-with-selection-inside.html is flaky
<http://webkit.org/b/146182>
- TestExpectations: Mark as flaky:
- editing/selection/leak-document-with-selection-inside.html
- 9:06 AM Changeset in webkit [185795] by
-
- 2 edits in trunk/Source/WebKit2
Check for SHA1 certificates ignores subresources
https://bugs.webkit.org/show_bug.cgi?id=146159
Reviewed by Dan Bernstein.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame): Call
PageLoadState::didDisplayOrRunInsecureContent if a certificate chain contains a non-root
SHA1 certificate when the frame is not the main frame.
- 8:57 AM Changeset in webkit [185794] by
-
- 2 edits in trunk/Source/WebKit2
Added availability information to a recently-added delegate method.
Suggested by Alexey Proskuryakov and Anders Carlsson.
- UIProcess/API/Cocoa/WKUIDelegate.h: Annotated -webViewDidClose:.
- 8:10 AM Changeset in webkit [185793] by
-
- 2 edits3 adds in trunk/LayoutTests
REGRESSION (r185779): fast/canvas/canvas-too-large-to-draw.html is still broken
This layout test started failing after the fix for:
Extremely large canvas crashes on pre-El Capitan machines
https://bugs.webkit.org/show_bug.cgi?id=146169
<rdar://problem/21410046>
Different limits require different test results for each
platform. Also update the line number from 35 to 36 since the
html test file was modified in r185792.
- fast/canvas/canvas-too-large-to-draw-expected.txt:
- Update limit to 16384x16384 for El Capitan (and other ports) and update line number.
- platform/ios-simulator/fast/canvas/canvas-too-large-to-draw-expected.txt: Added.
- New results with 4096x4096 limit for iOS.
- platform/mac-yosemite/fast/canvas/canvas-too-large-to-draw-expected.txt: Added.
- New results with 8192x8192 limit for Mac OS X 10.10.x and older.
- 7:26 AM Changeset in webkit [185792] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r185779): fast/canvas/canvas-too-large-to-draw.html broken prior to El Capitan
This layout test started failing after the fix for:
Extremely large canvas crashes on pre-El Capitan machines
https://bugs.webkit.org/show_bug.cgi?id=146169
<rdar://problem/21410046>
- fast/canvas/canvas-too-large-to-draw.html: Update test for new
expectations after r185779.
- 4:04 AM Changeset in webkit [185791] by
-
- 12 edits1 add in trunk
[ES6] Destructuring assignment need to accept iterables
https://bugs.webkit.org/show_bug.cgi?id=144111
Reviewed by Darin Adler.
Source/JavaScriptCore:
This patch makes that destructuring assignments to array binding patterns accept iterables.
Previously, it just access the indexed properties.
After this patch, it iterates the given value by using ES6 iterator protocol.
The iteration becomes different from the for-of case.
- Since there's no break/continue case, finally scope is not necessary.
- When the error is raised, the close status of the iterator becomes true. So IteratorClose is not called for that.
- Since the array binding patterns requires a limited count of iterations (if there is no rest(...rest) case), IteratorClose is called when the iteration does not consume the all values of the iterator.
- Since the array binding patterns requires a specified count of iterations, iterator's next call is skipped when iterator becomes closed.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitIteratorClose):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayPatternNode::bindValue):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::finishArrayPattern):
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseDeconstructionPattern):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::operatorStackPop):
- tests/stress/destructuring-assignment-accepts-iterables.js: Added.
(shouldBe):
(shouldThrow):
(.set shouldThrow):
LayoutTests:
From this patch, we use iterators for destructuring assignments to array binding patterns.
So test results become different.
- js/destructuring-assignment-expected.txt:
- js/parser-syntax-check-expected.txt:
- js/script-tests/destructuring-assignment.js:
- 2:18 AM Changeset in webkit [185790] by
-
- 7 edits in trunk
[EFL] Do not consider test directories when DEVELOPER_MODE is OFF
https://bugs.webkit.org/show_bug.cgi?id=146171
Reviewed by Gyuyoung Kim.
.:
- Source/cmake/OptionsEfl.cmake:
Exposed ENABLE_DEVELOPER_MODE to Compiler and CMake definition when DEVELOPER_MODE is ON.
Source/WebCore:
- platform/efl/EflInspectorUtilities.cpp:
(WebCore::inspectorResourcePath): Only used WEB_INSPECTOR_DIR which CMake decides properly.
Source/WebKit2:
- PlatformEfl.cmake:
Do not define SOURCE_DIR when DEVELOPER_MODE is OFF for seccomp filter
not to allow jhbuild directory.
- Shared/efl/ProcessExecutablePathEfl.cpp:
(WebKit::findProcessPath): Guard test code to ENABLE(DEVELOPER_MODE).
