Timeline
Jun 29, 2015:
- 11:47 PM Changeset in webkit [186109] by
-
- 6 edits in trunk/Source/WebCore
[Streams API] ReadableStreamReader.closed should use DOMPromise
https://bugs.webkit.org/show_bug.cgi?id=146406
Reviewed by Darin Adler.
Added storage of ClosedPromise as Optional of ReadableStream.
Updated code accordingly.
Covered by existing tests.
- Modules/streams/ReadableStream.cpp:
(WebCore::ReadableStream::clearCallbacks):
(WebCore::ReadableStream::releaseReader):
(WebCore::ReadableStream::changeStateToErrored):
(WebCore::ReadableStream::closed):
- Modules/streams/ReadableStream.h:
- Modules/streams/ReadableStreamReader.cpp:
(WebCore::ReadableStreamReader::closed):
- Modules/streams/ReadableStreamReader.h:
- bindings/js/JSReadableStreamReaderCustom.cpp:
(WebCore::JSReadableStreamReader::closed):
- 11:02 PM Changeset in webkit [186108] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Unreviewed GTK build fix since r186088 and r186095.
https://bugs.webkit.org/show_bug.cgi?id=146449
- PlatformGTK.cmake:
- UIProcess/API/gtk/PageClientImpl.h:
- 10:33 PM Changeset in webkit [186107] by
-
- 3 edits in trunk/Source/WebCore
[iOS WK2] WKWebViews in Facebook app start off black
https://bugs.webkit.org/show_bug.cgi?id=146445
rdar://problem/21600433
Reviewed by Tim Horton.
If -isOpaque is toggled on a WKWebView, we failed to make the page tiles non-opaque
for a while. After r183775, RenderLayerCompositor::rootBackgroundTransparencyChanged() was called,
but only considered the computed document background color, and not the view transparency.
Fix by having rootBackgroundTransparencyChanged() simply use viewHasTransparentBackground(),
which checks the FrameView transparency. Now we just need to store a transparency bool rather
than the old color (we only checked its alpha anyway).
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rootBackgroundTransparencyChanged):
- 7:38 PM Changeset in webkit [186106] by
-
- 2 edits1 copy in trunk/LayoutTests
Another rebaseline after r186086.
WebKit2 needs the original expected result.
- platform/mac-wk2/editing/style: Copied from LayoutTests/platform/mac/editing/style/unbold-in-bold-expected.txt.
- platform/mac/editing/style/unbold-in-bold-expected.txt:
- 7:05 PM Changeset in webkit [186105] by
-
- 2 edits in trunk/LayoutTests
Rebaseline after r186086.
- platform/mac/editing/style/unbold-in-bold-expected.txt:
- 6:26 PM Changeset in webkit [186104] by
-
- 2 edits in trunk/Source/WebCore
WebKit should use 80% black background for PiP indicator
https://bugs.webkit.org/show_bug.cgi?id=146444
<rdar://problem/21555726>
Reviewed by Sam Weinig.
Change the black background to a slightly less black background.
This also involved making the placard artwork white, in order
to keep it visible against the new grey.
- Modules/mediacontrols/mediaControlsiOS.css:
(audio::-webkit-media-controls-wireless-playback-status):
(audio::-webkit-media-controls-wireless-playback-status.small):
(audio::-webkit-media-controls-wireless-playback-status.picture-in-picture):
- 6:09 PM Changeset in webkit [186103] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed EFL build fix since r186088 and r186095.
- CMakeLists.txt: Remove ConnectionStack.cpp.
- UIProcess/CoordinatedGraphics/WebView.h: Override virtual didFailLoadForMainFrame().
- 5:47 PM Changeset in webkit [186102] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Unable to select the text of an inline error message
https://bugs.webkit.org/show_bug.cgi?id=145813
Reviewed by Timothy Hatcher.
- UserInterface/Views/CodeMirrorOverrides.css:
(.CodeMirror-linewidget):
- UserInterface/Views/TextEditor.js:
(WebInspector.TextEditor.prototype.createWidgetForLine):
- 5:40 PM Changeset in webkit [186101] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Remove harmless error for not getting named flows
https://bugs.webkit.org/show_bug.cgi?id=146417
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-29
Reviewed by Darin Adler.
- UserInterface/Controllers/DOMTreeManager.js:
- 5:37 PM Changeset in webkit [186100] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Network errors (404) are missing location link in console messages
https://bugs.webkit.org/show_bug.cgi?id=146442
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-29
Reviewed by Darin Adler.
- UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._appendLocationLink):
Restore behavior of adding a location link for network messages with urls.
- 5:32 PM Changeset in webkit [186099] by
-
- 6 edits in trunk/Source
Flag sync XHRs from the network process so they can be handled appropriately.
<rdar://problem/21579162> and https://bugs.webkit.org/show_bug.cgi?id=146441
Reviewed by Darin Adler.
Source/WebCore:
- platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::loadingSynchronousXHR): Added so clients of asynchronous
loads can signal they should be treated like synchronous loads at the platform level.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::start): Adjust SchedulingBehavior based on the client.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start): Adjust SchedulingBehavior based on the client.
Source/WebKit2:
- NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::loadingSynchronousXHR): Return isSynchronous().
- 5:27 PM Changeset in webkit [186098] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: iOS 8: Resources Timeline Data does not show up
https://bugs.webkit.org/show_bug.cgi?id=146433
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-29
Reviewed by Timothy Hatcher.
There were a couple issues with initializing the legacy base timestamp
for attempting to dynamically compute monotonically increasing timestamps
for timeline events for legacy backends.
- Sometimes legacy timestamps were in seconds since epochs, sometimes milliseconds. The frontend did not handle both.
- On navigations, even while resetting the base timestamp for the first new record received, the main resource still had a will send request time computed from the previous page's time system. This patch re-uses the original timestamp for this main resource as the new base and all future records are computed relative to this.
- UserInterface/Controllers/FrameResourceManager.js:
(WebInspector.FrameResourceManager.prototype.resourceRequestWillBeSent):
(WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
- UserInterface/Models/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.prototype.get originalRequestWillBeSentTimestamp):
For legacy timestamp calculations, save the original request will be sent
timestamp on the Resource in case it is needed.
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype._loadNewRecording):
When auto-starting a new recording for a navigation / reload, use the
main resource's request will be sent timestamp as the new base.
- UserInterface/Models/TimelineRecording.js:
Address legacy timeline timestamps by handling both legacy timestamps
that may be seconds / milliseconds.
- 5:24 PM Changeset in webkit [186097] by
-
- 2 edits in trunk/Source/WebCore
AX: PlatformSpeechSynthesizer code doesn't catch Objective-C exceptions
https://bugs.webkit.org/show_bug.cgi?id=146419
Reviewed by Simon Fraser.
Make sure ObjC exception resulting from calling into the platform cause problems in WebKit.
- platform/ios/PlatformSpeechSynthesizerIOS.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:]):
(-[WebSpeechSynthesisWrapper pause]):
(-[WebSpeechSynthesisWrapper resume]):
(-[WebSpeechSynthesisWrapper cancel]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didStartSpeechUtterance:]):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::pause):
- 5:15 PM Changeset in webkit [186096] by
-
- 2 edits in trunk/Source/WebKit2
Remove an empty group from the Xcode project.
- WebKit2.xcodeproj/project.pbxproj:
- 4:46 PM Changeset in webkit [186095] by
-
- 4 edits2 deletes in trunk/Source/WebKit2
Get rid of ConnectionStack
https://bugs.webkit.org/show_bug.cgi?id=146437
Reviewed by Andreas Kling.
Just use a TemporaryChange and a static variable instead.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::setGlobalException):
(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
- Shared/ConnectionStack.cpp: Removed.
(WebKit::ConnectionStack::singleton): Deleted.
- Shared/ConnectionStack.h: Removed.
(WebKit::ConnectionStack::current): Deleted.
(WebKit::ConnectionStack::CurrentConnectionPusher::CurrentConnectionPusher): Deleted.
(WebKit::ConnectionStack::CurrentConnectionPusher::~CurrentConnectionPusher): Deleted.
- WebKit2.xcodeproj/project.pbxproj:
- 4:14 PM Changeset in webkit [186094] by
-
- 2 edits in trunk/Source/WebCore
Removing an element from a media session should also remove it from the sets of active participating elements
https://bugs.webkit.org/show_bug.cgi?id=146420
Reviewed by Eric Carlson.
- Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::removeMediaElement):
- 4:08 PM Changeset in webkit [186093] by
-
- 2 edits in trunk/WebKitLibraries
[Win] Activate SSE support for 32-bit builds.
https://bugs.webkit.org/show_bug.cgi?id=144923
Patch by Hyungwook Lee <hyungwook.lee@navercorp.com> on 2015-06-29
Reviewed by Brent Fulgham.
- win/tools/vsprops/common.props:
- 4:01 PM Changeset in webkit [186092] by
-
- 5 edits in trunk/Source/WebKit2
Fix the build.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didFailLoadForMainFrame]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didFailLoadForMainFrame):
- 3:59 PM Changeset in webkit [186091] by
-
- 12 edits in trunk
Temporarily disable PICTURE_SIZES
https://bugs.webkit.org/show_bug.cgi?id=146435
<rdar://problem/21087013>
Source/JavaScriptCore:
Reviewed by Tim Horton.
Temporarily disable PICTURE_SIZES because it causes problems with out
of date <picture> polyfills.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Reviewed by Tim Horton.
Temporarily disable PICTURE_SIZES because it causes problems with out
of date <picture> polyfills.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
Reviewed by Tim Horton.
Temporarily disable PICTURE_SIZES because it causes problems with out
of date <picture> polyfills.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Temporarily disable PICTURE_SIZES because it causes problems with out
of date <picture> polyfills.
Temporarily disable PICTURE_SIZES until Safari branches.
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
Reviewed by Tim Horton.
Temporarily disable PICTURE_SIZES because it causes problems with out
of date <picture> polyfills.
- wtf/FeatureDefines.h:
LayoutTests:
Reviewed by Tim Horton.
Skip HTMLImageElement.sizes tests.
- 3:42 PM Changeset in webkit [186090] by
-
- 3 edits in trunk/Source/WebCore
Fix the build.
- editing/cocoa/HTMLConverter.mm:
- platform/spi/cocoa/NSAttributedStringSPI.h:
- 3:35 PM Changeset in webkit [186089] by
-
- 2 edits in trunk/Source/WebCore
Fix the build.
- platform/spi/cocoa/NSAttributedStringSPI.h:
- 3:07 PM Changeset in webkit [186088] by
-
- 10 edits in trunk/Source/WebKit2
Don't try to access a possibly deallocated WebFrameProxy object
https://bugs.webkit.org/show_bug.cgi?id=146428
rdar://problem/21446364
Reviewed by Tim Horton.
Make sure to call isMainFrame before calling out to the client inside
WebPageProxy::didFailLoadForFrame, matching what we do for WebPageProxy::didFinishLoadForFrame.
Also, add a ViewGestureController::didFailLoadForMainFrame function and call that instead of
calling didFinishLoadForMainFrame in the failure case.
- UIProcess/API/mac/WKView.mm:
(-[WKView _didFailLoadForMainFrame]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFailLoadForFrame):
- UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::mainFrameLoadDidReachTerminalState):
(WebKit::ViewGestureController::didFinishLoadForMainFrame): Deleted.
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didFailLoadForMainFrame):
- UIProcess/mac/ViewGestureController.h:
(WebKit::ViewGestureController::didFinishLoadForMainFrame):
(WebKit::ViewGestureController::didFailLoadForMainFrame):
- UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::mainFrameLoadDidReachTerminalState):
(WebKit::ViewGestureController::didFinishLoadForMainFrame): Deleted.
- 2:56 PM Changeset in webkit [186087] by
-
- 2 edits in trunk/Source/WebKit2
Disable default gesture recognizers on preview.
https://bugs.webkit.org/show_bug.cgi?id=146424
rdar://problem/21572828
We should disable default gesture recognizers on preview, to avoid activating links or
triggering touch events accidentally. We can enable them after preview finishes.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2015-06-29
Reviewed by Beth Dakin.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView willPresentPreviewViewController:forPosition:inSourceView:]):
(-[WKContentView didDismissPreviewViewController:committing:]):
- 2:38 PM Changeset in webkit [186086] by
-
- 20 edits3 adds in trunk/Source
Font panel doesn't get updated when bolding text via cmd+b in Mail on OS X
https://bugs.webkit.org/show_bug.cgi?id=146379
Reviewed by Darin Adler.
Source/WebCore:
The bug was caused by WebKit not updating the font panel when the typing style changes.
There was also a bug that WebKit never updated font attributes on OS X.
Fixed the bugs by always updating the font panel after applying style instead of only
when the selection changes and setting the font attributes.
I tried really had to write a WebKit API test but I couldn't get it to work so there are
no new tests :(
- WebCore.xcodeproj/project.pbxproj:
- editing/Editor.cpp:
(WebCore::Editor::applyStyle):
(WebCore::Editor::shouldApplyStyle):
(WebCore::Editor::applyParagraphStyle):
(WebCore::Editor::applyStyleToSelection):
(WebCore::Editor::applyParagraphStyleToSelection):
(WebCore::Editor::selectionStartHasStyle):
(WebCore::Editor::document):
(WebCore::Editor::styleForSelectionStart): Deleted.
- editing/Editor.h:
- editing/cocoa/EditorCocoa.h: Added. Shares the declaration for NSUnderlineStyle in iOS.
- editing/cocoa/EditorCocoa.mm: Added.
(WebCore::Editor::styleForSelectionStart): Moved from Editor.cpp
(WebCore::Editor::getTextDecorationAttributesRespectingTypingStyle): Extracted from iOS's
fontAttributesForSelectionStart implementation.
- editing/cocoa/HTMLConverter.mm:
- editing/ios/EditorIOS.mm:
(WebCore::Editor::fontAttributesForSelectionStart):
- editing/mac/EditorMac.mm:
(WebCore::Editor::fontAttributesForSelectionStart):
- loader/EmptyClients.h:
- page/EditorClient.h:
Source/WebKit/mac:
Update the font panel when newly added EditorClient::didApplyStyle is called. Also set the font attributes
in _updateFontPanel so that underline and strike through states will be reflected.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::shouldApplyStyle):
(updateFontPanelIfNeeded): Extracted from respondToChangedContents.
(WebEditorClient::didApplyStyle): Added.
(WebEditorClient::respondToChangedContents):
- WebView/WebHTMLView.mm:
(-[WebHTMLView _updateFontPanel]): Sets font attributes as well as font.
Source/WebKit/win:
- WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::didApplyStyle): Added.
- WebCoreSupport/WebEditorClient.h:
Source/WebKit2:
Since font panel doesn't open in WebKit2 at the moment, just add an empty implementation of didApplyStyle
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::didApplyStyle):
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebPage/WebPage.h:
- 2:11 PM Changeset in webkit [186085] by
-
- 2 edits in trunk/Tools
Add timeout in run-webkit-tests for launching the simulator
https://bugs.webkit.org/show_bug.cgi?id=146371
Reviewed by Darin Adler.
Adds a default 5-minute timeout using the timeout class in webkitpy.benchmark_runner.utils
for the otherwise infinitely patient wait_until_device_is_in_state method.
- Scripts/webkitpy/xcode/simulator.py:
(Simulator.DeviceState):
(Simulator):
(Simulator.wait_until_device_is_in_state):
(Simulator.device_state):
- 2:01 PM Changeset in webkit [186084] by
-
- 3 edits in trunk/Source/WebCore
MediaSession: use a HashSet for the collection of participating elements
https://bugs.webkit.org/show_bug.cgi?id=146421
Reviewed by Eric Carlson.
- Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::addMediaElement):
(WebCore::MediaSession::removeMediaElement):
- Modules/mediasession/MediaSession.h:
- 1:53 PM Changeset in webkit [186083] by
-
- 14 edits in trunk/Source
Setting to enable/disable media controls sizing on page zoom
https://bugs.webkit.org/show_bug.cgi?id=146423
<rdar://problem/18379634>
Reviewed by Eric Carlson.
Add a new setting "MediaControlsScaleWithPageZoom" that can disable
the behaviour we currently implement on iOS, where the media controls
attempt to remain at a fixed size independent of page zoom.
Source/WebCore:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setMediaControlsDependOnPageScaleFactor): Do not
set this value to true if the new setting is disabled.
- page/Settings.cpp:
- page/Settings.in: Add the new setting.
Source/WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Initialize to false on iOS, true otherwise.
(-[WebPreferences mediaControlsScaleWithPageZoom]):
(-[WebPreferences setMediaControlsScaleWithPageZoom:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h: Initialize to false on iOS, true otherwise.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetMediaControlsScaleWithPageZoom):
(WKPreferencesGetMediaControlsScaleWithPageZoom):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 12:56 PM Changeset in webkit [186082] by
-
- 10 edits in trunk/Source/WebKit2
[WK2][iOS] Swipe gesture snapshot stays up for 3 seconds when swiping back after top-hit navigation
https://bugs.webkit.org/show_bug.cgi?id=146415
<rdar://problem/21595801>
Reviewed by Tim Horton.
Swipe gesture snapshot previously stayed up for 3 seconds when swiping
back after a top-hit navigation. This is because we do not restore the
scroll position in this case and the ViewGestureController was waiting
for the scroll position to be restored before taking down the snapshot.
This patch adds a fail-safe mechanism so that the WebProcess can let
the UIProcess know (via a CouldNotRestorePageState IPC) that the page
state (including scroll position) could not be restored so that it can
let the ViewGestureController it should not wait for the scroll
position to be restored.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _couldNotRestorePageState]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::couldNotRestorePageState):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::couldNotRestorePageState):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::restorePageState):
- 12:52 PM Changeset in webkit [186081] by
-
- 32 edits10 adds2 deletes in trunk
WebRTC: Update the MediaStream API
https://bugs.webkit.org/show_bug.cgi?id=146313
Reviewed by Eric Carlson.
Source/WebCore:
Update the MediaStream API (MediaStream, MediaStreamTrack and
RealtimeMediaSource) to match the Media Capture and Stream
specification [1]. Notable changes:
Updated event handling to synchronously update corresponding
state/attributes as events are dispatched.
Removed 'new' state from MediaStreamTrack. A track is either 'live' or
'ended'. As a consequence 'started' event is also removed.
MediaStreamTrack always has a source (disconnected source concept was
removed from the spec). Therefore, more state can be kept at the source
without going away.
Calculate MediaStream.active internally, from the track set, instead of
setting it externally.
Updated RealtimeMediaSource Observer interface.
Replaced MediaStream's separate audio and video track lists with a
single track set (more aligned with spec).
Updated MediaStream constructor to adopt instead of clone track
arguments (or tracks from MediaStream argument).
Removed MediaStreamTrack.getSources() and corresponding test (removed
from spec).
Test status: 3 added, 8 existing enabled (some updated) and 1 removed.
[1] http://w3c.github.io/mediacapture-main/archives/20150523/getusermedia.html
Tests: fast/mediastream/MediaStreamTrack-clone.html
fast/mediastream/MediaStreamTrack-kind.html
fast/mediastream/MediaStreamTrack-stop.html
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::clone):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
(WebCore::MediaStream::getTrackById):
(WebCore::MediaStream::getAudioTracks):
(WebCore::MediaStream::getVideoTracks):
(WebCore::MediaStream::getTracks):
(WebCore::MediaStream::contextDestroyed):
(WebCore::MediaStream::trackDidEnd):
(WebCore::MediaStream::activeStatusChanged):
(WebCore::MediaStream::didAddTrackToPrivate):
(WebCore::MediaStream::didRemoveTrackFromPrivate):
(WebCore::MediaStream::internalAddTrack):
(WebCore::MediaStream::internalRemoveTrack):
(WebCore::MediaStream::scheduleActiveStateChange):
(WebCore::MediaStream::activityEventTimerFired):
(WebCore::MediaStream::trackVectorForType):
(WebCore::MediaStream::~MediaStream): Deleted.
(WebCore::MediaStream::registry): Deleted.
(WebCore::MediaStream::addObserver): Deleted.
(WebCore::MediaStream::removeObserver): Deleted.
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStream.idl:
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::kind):
(WebCore::MediaStreamTrack::id):
(WebCore::MediaStreamTrack::label):
(WebCore::MediaStreamTrack::enabled):
(WebCore::MediaStreamTrack::setEnabled):
(WebCore::MediaStreamTrack::muted):
(WebCore::MediaStreamTrack::readonly):
(WebCore::MediaStreamTrack::remote):
(WebCore::MediaStreamTrack::readyState):
(WebCore::MediaStreamTrack::ended):
(WebCore::MediaStreamTrack::clone):
(WebCore::MediaStreamTrack::stopProducingData):
(WebCore::MediaStreamTrack::states):
(WebCore::MediaStreamTrack::getCapabilities):
(WebCore::MediaStreamTrack::applyConstraints):
(WebCore::MediaStreamTrack::trackEnded):
(WebCore::MediaStreamTrack::trackMutedChanged):
(WebCore::MediaStreamTrack::stop):
(WebCore::MediaStreamTrack::getConstraints): Deleted.
(WebCore::MediaStreamTrack::addObserver): Deleted.
(WebCore::MediaStreamTrack::removeObserver): Deleted.
(WebCore::MediaStreamTrack::configureTrackRendering): Deleted.
(WebCore::MediaStreamTrack::activeDOMObjectName): Deleted.
(WebCore::MediaStreamTrack::canSuspendForPageCache): Deleted.
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/MediaStreamTrack.idl:
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::didRemoveRemoteStream): Deleted.
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::didCreateStream):
- platform/mediastream/MediaStreamPrivate.cpp:
(WebCore::MediaStreamPrivate::create):
(WebCore::MediaStreamPrivate::MediaStreamPrivate):
(WebCore::MediaStreamPrivate::tracks):
(WebCore::MediaStreamPrivate::updateActiveState):
(WebCore::MediaStreamPrivate::addTrack):
(WebCore::MediaStreamPrivate::removeTrack):
- platform/mediastream/MediaStreamPrivate.h:
(WebCore::MediaStreamPrivate::active): Deleted.
- platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::create):
(WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate):
(WebCore::MediaStreamTrackPrivate::~MediaStreamTrackPrivate):
(WebCore::MediaStreamTrackPrivate::label):
(WebCore::MediaStreamTrackPrivate::setEnabled):
(WebCore::MediaStreamTrackPrivate::endTrack):
(WebCore::MediaStreamTrackPrivate::clone):
(WebCore::MediaStreamTrackPrivate::type):
(WebCore::MediaStreamTrackPrivate::applyConstraints):
(WebCore::MediaStreamTrackPrivate::sourceStopped):
(WebCore::MediaStreamTrackPrivate::sourceMutedChanged):
(WebCore::MediaStreamTrackPrivate::preventSourceFromStopping):
(WebCore::MediaStreamTrackPrivate::muted): Deleted.
(WebCore::MediaStreamTrackPrivate::readonly): Deleted.
(WebCore::MediaStreamTrackPrivate::remote): Deleted.
(WebCore::MediaStreamTrackPrivate::constraints): Deleted.
(WebCore::MediaStreamTrackPrivate::states): Deleted.
(WebCore::MediaStreamTrackPrivate::capabilities): Deleted.
- platform/mediastream/MediaStreamTrackPrivate.h:
(WebCore::MediaStreamTrackPrivate::id):
(WebCore::MediaStreamTrackPrivate::ended):
(WebCore::MediaStreamTrackPrivate::enabled):
(WebCore::MediaStreamTrackPrivate::setClient):
(WebCore::MediaStreamTrackPrivate::source): Deleted.
(WebCore::MediaStreamTrackPrivate::client): Deleted.
- platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::RealtimeMediaSource):
(WebCore::RealtimeMediaSource::reset):
(WebCore::RealtimeMediaSource::setMuted):
(WebCore::RealtimeMediaSource::readonly):
(WebCore::RealtimeMediaSource::stop):
(WebCore::RealtimeMediaSource::requestStop):
(WebCore::RealtimeMediaSource::addObserver): Deleted.
(WebCore::RealtimeMediaSource::removeObserver): Deleted.
- platform/mediastream/RealtimeMediaSource.h:
(WebCore::RealtimeMediaSource::stopped):
(WebCore::RealtimeMediaSource::id): Deleted.
(WebCore::RealtimeMediaSource::muted): Deleted.
(WebCore::RealtimeMediaSource::setReadonly): Deleted.
- platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:
(WebCore::RealtimeMediaSourceCenterOwr::createMediaStream): Deleted.
- platform/mock/MockRealtimeMediaSourceCenter.cpp:
(WebCore::MockRealtimeMediaSourceCenter::createMediaStream): Deleted.
LayoutTests:
Test status: 3 added, 8 existing enabled (some updated) and 1 removed.
- TestExpectations:
- fast/mediastream/MediaStream-add-ended-tracks-expected.txt:
- fast/mediastream/MediaStream-add-ended-tracks.html:
- fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
- fast/mediastream/MediaStream-add-remove-tracks.html:
- fast/mediastream/MediaStream-add-tracks-to-inactive-stream.html:
- fast/mediastream/MediaStream-clone-expected.txt: Added.
- fast/mediastream/MediaStream-clone.html:
- fast/mediastream/MediaStream-construct-with-ended-tracks-expected.txt: Added.
- fast/mediastream/MediaStream-construct-with-ended-tracks.html:
- fast/mediastream/MediaStream-getTracks-expected.txt:
- fast/mediastream/MediaStream-getTracks.html:
- fast/mediastream/MediaStreamConstructor.html:
- fast/mediastream/MediaStreamTrack-clone-expected.txt: Added.
- fast/mediastream/MediaStreamTrack-clone.html: Added.
- fast/mediastream/MediaStreamTrack-getSources-expected.txt: Removed.
- fast/mediastream/MediaStreamTrack-getSources.html: Removed. Tested method removed from spec.
- fast/mediastream/MediaStreamTrack-kind-expected.txt: Added.
- fast/mediastream/MediaStreamTrack-kind.html: Added.
- fast/mediastream/MediaStreamTrack-stop-expected.txt: Added.
- fast/mediastream/MediaStreamTrack-stop.html: Added.
- fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt:
- fast/mediastream/MediaStreamTrackEvent-constructor.html:
- fast/mediastream/resources/getUserMedia-helper.js: Added.
(.reject):
(getUserMedia):
(defaultRejectOrCatch):
- platform/gtk/TestExpectations:
- 12:43 PM Changeset in webkit [186080] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION: Web Inspector: Jump to Definition is broken
https://bugs.webkit.org/show_bug.cgi?id=146376
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-29
Reviewed by Timothy Hatcher.
- UserInterface/Views/ObjectTreeBaseTreeElement.js:
(WebInspector.ObjectTreeBaseTreeElement.prototype._appendMenusItemsForObject):
Allow changing tabs when jumping to function definition.
- 12:40 PM Changeset in webkit [186079] by
-
- 14 edits4 adds in trunk
Make the NFA transitions range-based
https://bugs.webkit.org/show_bug.cgi?id=146338
Reviewed by Alex Christensen.
Source/WebCore:
Change the NFA to use range based transition for any kind of transition.
The fallback transition is also absorbed as ranges.
Previously, the NFA would only have single transitions and a fallback
transition for all cases not covered by single transitions.
The problem with that design was that character ranges (e.g. [a-z]) were
extended as individual transitions. Something like [a] would cover
most of the alphabet with transitions.
When converting the NFA to DFA, the time is proportional to the number of states
multiplied by the number of transitions. With many individual transitions,
the run time was an order of magnitude higher than what we want.
This patch changes the NFA to only handle ranges of characters. A single transition
becomes a range with the character as first and last character in the range
('a' becomes 'a' to 'a').
Ranges of characters are handled direclty (e.g. [a-z] becomes a single 'a' to 'z' transition).
In the context of the state machines, ranges have identifies (the target of the transitions).
When two ranges collide, they have to be split such that each part retain its target
except the intersection that gets the union of the targets.
Handling the union of ranges efficiently is critical because we have to do
it for every NFA node in any subset when building the DFA. The helper
class that does that is MutableRange.
The union of ranges is done efficiently because of preconditions on our list of ranges:
-The ranges must be sorted.
-No range in a list can intersect any other range in the same list.
To merge two ranges, we can go over them in order and split them part by part.
It is easy to find what goes where because they are both sorted and we can
compare the characters of each to know how to move forward.
The time to merge 2 range list is proportional to O(n+m) where 'n' and 'm' are
the number of ranges in each list.
Since taking the union of two lists usually create new ranges, we have to allocate
those somewhere efficiently. To do that, MutableRange support an inline capacity,
which is used for the NFAToDFA Convertion.
---
With ranges, the NFA-to-DFA conversion changes very little:
-Each NFA nodes contains a list of ranges and each range has a list of targets.
-The subset construction select any number of NFA nodes corresponding to
a single deterministic state.
-For the subset, we can use MutableRange to merge the ranges of every
NFA node in the set. The resulting list has rangeis with targets corresponding
to the union of all the transitions.
-We go over all the ranges the same way we used to go over the transitions.
Since the DFA does not support ranges, the ranges are spread as individual
transitions + fallback transition.
---
With the efficient merging solved, we still need the actual NFA to use ranges
instead of individual transitions.
I could have used MutableRange for that but it is not the most compact
way to represent ranges that do not need merging.
Instead, the NFA uses a custom structure: ImmutableNFA. It is basically
the same thing, but in that one you cannot change a list of range
after creating it.
Consequently, the sorted ranges in ImmutableNFA are also subsequent
in memory, which is really nice to go over them efficiently
when merging ranges in the NFA-to-DFA conversion. :)
When building the NFA, we don't know all the transitions when creating
each node, BUT we know that we have very few node "unfinished" at any
time. Since we build by going depth-first in the prefix-tree, we only
have the max-depth of live nodes in the worst case.
To help building the NFA out of the prefix tree, we have
ImmutableNFANodeBuilder. It keeps all the informations about a NFA node,
but in a non-compact, mutable form. When a ImmutableNFANodeBuilder
is destroyed, it serialize the information into the immutable NFA.
- WebCore.xcodeproj/project.pbxproj:
- contentextensions/CombinedURLFilters.cpp:
(WebCore::ContentExtensions::generateNFAForSubtree):
(WebCore::ContentExtensions::CombinedURLFilters::processNFAs):
- contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::compileRuleList):
- contentextensions/DFA.cpp:
(WebCore::ContentExtensions::DFA::empty):
- contentextensions/DFA.h:
- contentextensions/ImmutableNFA.h: Added.
(WebCore::ContentExtensions::ImmutableNFA::ConstTargetIterator::operator*):
(WebCore::ContentExtensions::ImmutableNFA::ConstTargetIterator::operator->):
(WebCore::ContentExtensions::ImmutableNFA::ConstTargetIterator::operator==):
(WebCore::ContentExtensions::ImmutableNFA::ConstTargetIterator::operator!=):
(WebCore::ContentExtensions::ImmutableNFA::ConstTargetIterator::operator++):
(WebCore::ContentExtensions::ImmutableNFA::IterableConstTargets::begin):
(WebCore::ContentExtensions::ImmutableNFA::IterableConstTargets::end):
(WebCore::ContentExtensions::ImmutableNFA::ConstRangeIterator::operator*):
(WebCore::ContentExtensions::ImmutableNFA::ConstRangeIterator::operator->):
(WebCore::ContentExtensions::ImmutableNFA::ConstRangeIterator::operator==):
(WebCore::ContentExtensions::ImmutableNFA::ConstRangeIterator::operator!=):
(WebCore::ContentExtensions::ImmutableNFA::ConstRangeIterator::operator++):
(WebCore::ContentExtensions::ImmutableNFA::ConstRangeIterator::data):
(WebCore::ContentExtensions::ImmutableNFA::IterableConstRange::begin):
(WebCore::ContentExtensions::ImmutableNFA::IterableConstRange::end):
(WebCore::ContentExtensions::ImmutableNFA::IterableConstRange::debugPrint):
(WebCore::ContentExtensions::ImmutableNFA::transitionsForNode):
(WebCore::ContentExtensions::ImmutableNFA::root):
(WebCore::ContentExtensions::ImmutableNFA::finalize):
(WebCore::ContentExtensions::ImmutableNFA::memoryUsed):
- contentextensions/ImmutableNFANodeBuilder.h: Added.
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::ImmutableNFANodeBuilder):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::~ImmutableNFANodeBuilder):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::addTransition):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::addEpsilonTransition):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::setActions):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::operator=):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::finalize):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::sinkActions):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::sinkTransitions):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::sinkEpsilonTransitions):
- contentextensions/MutableRange.h: Added.
(WebCore::ContentExtensions::MutableRange::MutableRange):
(WebCore::ContentExtensions::MutableRange::operator=):
(WebCore::ContentExtensions::MutableRange::size):
- contentextensions/MutableRangeList.h: Added.
(WebCore::ContentExtensions::MutableRangeList::ConstIterator::operator*):
(WebCore::ContentExtensions::MutableRangeList::ConstIterator::operator->):
(WebCore::ContentExtensions::MutableRangeList::ConstIterator::operator==):
(WebCore::ContentExtensions::MutableRangeList::ConstIterator::operator!=):
(WebCore::ContentExtensions::MutableRangeList::ConstIterator::operator++):
(WebCore::ContentExtensions::MutableRangeList::begin):
(WebCore::ContentExtensions::MutableRangeList::end):
(WebCore::ContentExtensions::MutableRangeList::appendRange):
(WebCore::ContentExtensions::MutableRangeList::extend):
(WebCore::ContentExtensions::MutableRangeList::isEmpty):
(WebCore::ContentExtensions::MutableRangeList::clear):
(WebCore::ContentExtensions::MutableRangeList::debugPrint):
(WebCore::ContentExtensions::MutableRangeList::insertBetween):
(WebCore::ContentExtensions::MutableRangeList::initializeFrom):
- contentextensions/NFA.cpp:
(WebCore::ContentExtensions::NFA::debugPrintDot):
(WebCore::ContentExtensions::NFA::NFA): Deleted.
(WebCore::ContentExtensions::NFA::createNode): Deleted.
(WebCore::ContentExtensions::NFA::memoryUsed): Deleted.
(WebCore::ContentExtensions::NFA::addTransition): Deleted.
(WebCore::ContentExtensions::NFA::addEpsilonTransition): Deleted.
(WebCore::ContentExtensions::NFA::addTransitionsOnAnyCharacter): Deleted.
(WebCore::ContentExtensions::NFA::setActions): Deleted.
(WebCore::ContentExtensions::NFA::graphSize): Deleted.
(WebCore::ContentExtensions::NFA::restoreToGraphSize): Deleted.
(WebCore::ContentExtensions::printRange): Deleted.
(WebCore::ContentExtensions::printTransitions): Deleted.
- contentextensions/NFA.h:
(WebCore::ContentExtensions::NFA::root): Deleted.
(WebCore::ContentExtensions::NFA::addRuleId): Deleted.
- contentextensions/NFANode.h:
- contentextensions/NFAToDFA.cpp:
(WebCore::ContentExtensions::epsilonClosureExcludingSelf):
(WebCore::ContentExtensions::resolveEpsilonClosures):
(WebCore::ContentExtensions::NodeIdSetToUniqueNodeIdSetSource::NodeIdSetToUniqueNodeIdSetSource):
(WebCore::ContentExtensions::NodeIdSetToUniqueNodeIdSetTranslator::translate):
(WebCore::ContentExtensions::DataConverterWithEpsilonClosure::convert):
(WebCore::ContentExtensions::DataConverterWithEpsilonClosure::extend):
(WebCore::ContentExtensions::createCombinedTransition):
(WebCore::ContentExtensions::canUseFallbackTransition):
(WebCore::ContentExtensions::findBestFallbackTarget):
(WebCore::ContentExtensions::getOrCreateDFANode):
(WebCore::ContentExtensions::NFAToDFA::convert):
(WebCore::ContentExtensions::populateTransitions): Deleted.
- contentextensions/NFAToDFA.h:
- contentextensions/Term.h:
(WebCore::ContentExtensions::Term::Term):
(WebCore::ContentExtensions::Term::generateGraph):
(WebCore::ContentExtensions::Term::generateSubgraphForAtom):
(WebCore::ContentExtensions::Term::Term::generateGraph): Deleted.
Tools:
- TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
Test some new interesting cases.
- 12:12 PM Changeset in webkit [186078] by
-
- 2 edits2 adds in trunk/LayoutTests
Media Session: test session attribute of newly-created media elements
https://bugs.webkit.org/show_bug.cgi?id=146412
Reviewed by Eric Carlson.
- media/session/default-session-expected.txt: Added.
- media/session/default-session.html: Added.
- platform/mac/TestExpectations: Media Session support is disabled by default.
- 12:08 PM Changeset in webkit [186077] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][iOS] Add WKWebView private API to save a back/forward snapshot
https://bugs.webkit.org/show_bug.cgi?id=146398
<rdar://problem/21584231>
Reviewed by Dan Bernstein.
Add WKWebView private API to save a back/forward snapshot so that the
client can make sure a back/forward snapshot is available even when
swapping WKWebView upon navigation.
This matches the WKView.saveBackForwardSnapshotForItem API we have on
Mac.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView saveBackForwardSnapshotForItem:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- 12:04 PM Changeset in webkit [186076] by
-
- 10 edits in trunk/Source
Binding generator should allow using JSC::Value for "any" parameter in lieu of ScriptValue
https://bugs.webkit.org/show_bug.cgi?id=146403
Reviewed by Darin Adler.
Source/JavaScriptCore:
- bindings/ScriptValue.h: Added implicit conversion to JSC::JSValue.
Source/WebCore:
Covered by existing tests.
Enabling new APIs to use JSC::JSValue by using implicit case from ScriptValue to JSC::JSValue.
Updated binding generator to include ScruptValue header in the needed JSXX.cpp files.
Applied approach to ReadableStreamController.error.
- Modules/streams/ReadableStreamController.h:
(WebCore::ReadableStreamController::error):
- Modules/streams/ReadableStreamController.idl:
- bindings/js/JSReadableStreamControllerCustom.cpp:
(WebCore::constructJSReadableStreamController): Deleted.
- bindings/js/ReadableJSStream.cpp:
(WebCore::ReadableJSStream::error):
- bindings/js/ReadableJSStream.h:
- bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative):
- bindings/scripts/test/JS/JSTestObj.cpp:
- 11:56 AM Changeset in webkit [186075] by
-
- 10 edits1 delete in trunk/Source
Use DISPATCH_SOURCE_TYPE_MEMORYPRESSURE instead of DISPATCH_SOURCE_TYPE_MEMORYSTATUS
https://bugs.webkit.org/show_bug.cgi?id=146413
Source/WebCore:
rdar://problem/21295036
Reviewed by Andreas Kling.
Replace SPI with API.
- WebCore.xcodeproj/project.pbxproj:
- platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::install):
- platform/mac/WebCoreSystemInterface.h:
- platform/spi/cocoa/DispatchSPI.h: Removed.
Source/WebKit/mac:
Reviewed by Andreas Kling.
Replace SPI with API.
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Deleted.
- WebView/WebView.mm:
(+[WebView registerForMemoryNotifications]):
Source/WebKit2:
Reviewed by Andreas Kling.
Replace SPI with API.
- UIProcess/ios/WebMemoryPressureHandlerIOS.mm:
(WebKit::WebMemoryPressureHandler::WebMemoryPressureHandler):
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Deleted.
- 11:46 AM Changeset in webkit [186074] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Pausing a media element should discard buffered data immediately if under memory pressure.
<https://webkit.org/b/146410>
<rdar://problem/20366883>
Reviewed by Darin Adler.
When moving a media element into paused state, call purgeBufferedDataIfPossible()
right away if the system is under memory pressure.
This ensures that mediaserverd drops its forward-looking frame queue right
away instead of waiting for a new pressure notification.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::pauseInternal):
- 10:43 AM Changeset in webkit [186073] by
-
- 5 edits in trunk/Source/WebKit2
[iOS] Hardware Keyboard: All combinations of arrow keys and space key do not scroll the view.
https://bugs.webkit.org/show_bug.cgi?id=146290
rdar://problem/18466015
We don't normally get called by the keyboard to handle the event if we are not
interacting with editable content. In order to receive all the hardware keyboard events
we need to implement _handleKeyUIEvent which is called for every key event
when the view is first responder. This gives us the opportunity to send each keystroke
to the WebProcess to let any Javascript handler intercept it and then perform the default
action for the key combination.
Unfortunately this mechanism does not provide key repeat, which is implemented in the
keyboard layer. In order to have it at least for the arrow keys, we use the keyCommands
mechanism only for those.
Reviewed by Darin Adler.
- Platform/spi/ios/UIKitSPI.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _scrollByOffset:]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView canPerformAction:withSender:]):
(-[WKContentView keyCommands]):
(-[WKContentView _arrowKey:]):
(-[WKContentView _handleKeyUIEvent:]):
(-[WKContentView handleKeyEvent:]):
(-[WKContentView handleKeyWebEvent:]):
(-[WKContentView _interpretKeyEvent:isCharEvent:]):
- 10:33 AM Changeset in webkit [186072] by
-
- 3 edits in trunk/Source/WebCore
Media Session: Media elements should report a null session for Default sessions
https://bugs.webkit.org/show_bug.cgi?id=146373
Reviewed by Eric Carlson.
If a media element's current session is a 'Default' media session, its session property should report null in
the JavaScript API.
- Modules/mediasession/MediaSession.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::session):
- 10:18 AM Changeset in webkit [186071] by
-
- 4 edits in trunk
[Mac] Disable QTKit by default.
https://bugs.webkit.org/show_bug.cgi?id=146352
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-06-29
Reviewed by Darin Adler.
Source/WebCore:
Fix the the requirement for enabling QTKit and AVFoundation.
- page/Settings.cpp:
(WebCore::invalidateAfterGenericFamilyChange): Remove the requirement
for enabling QTKit and AVFoundation. The initial state of QTKit should
be disabled on all OS X ports. And the initial state of AVFoundation
should be enabled on all OS X ports.
LayoutTests:
- platform/mac/TestExpectations: Skip media tests which require QTKit on
all OS X ports.
- 9:50 AM Changeset in webkit [186070] by
-
- 2 edits3 adds in trunk/LayoutTests
Test existence of controls on MediaSession
https://bugs.webkit.org/show_bug.cgi?id=146356
Reviewed by Eric Carlson.
- media/session/controls-existence-expected.txt: Added.
- media/session/controls-existence.html: Added.
- platform/mac/TestExpectations: Media Session support is disabled by default.
- 8:22 AM Changeset in webkit [186069] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed EFL gardening on 29th Jun.
https://bugs.webkit.org/show_bug.cgi?id=146409
Remove the duplicated results and rebaseline the missing tests.
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-06-29
- platform/efl/TestExpectations:
- platform/efl/editing/execCommand/paste-1-expected.txt: Added.
- platform/efl/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added.
- 3:09 AM Changeset in webkit [186068] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Purge unused favicons from IconDatabase after 30 days.
https://bugs.webkit.org/show_bug.cgi?id=146334
Patch by Hyungwook Lee <hyungwook.lee@navercorp.com> on 2015-06-29
Reviewed by Gyuyoung Kim.
We need purge unused favicons from IconDatabase for database size control.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::performURLImport):
Jun 28, 2015:
- 11:51 PM Changeset in webkit [186067] by
-
- 3 edits in trunk/Source/WebKit2
Fixed the iOS 8.x build after r186066.
- UIProcess/ios/WebVideoFullscreenManagerProxy.h:
- UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::create):
- 11:43 PM Changeset in webkit [186066] by
-
- 2 edits in trunk/Source/WebKit2
Fixed the iOS build after r186059.
- UIProcess/ios/WebVideoFullscreenManagerProxy.h:
- 11:26 PM Changeset in webkit [186065] by
-
- 2 edits27 adds in trunk/LayoutTests
[EFL] Unreviewed add new baseline for missing tests
Some tests need to have own test expectations for EFL port.
- platform/efl/TestExpectations:
- platform/efl/accessibility/auto-filled-value-expected.txt: Added.
- platform/efl/accessibility/img-fallsback-to-title-expected.txt: Added.
- platform/efl/accessibility/internal-link-anchors2-expected.txt: Added.
- platform/efl/accessibility/math-multiscript-attributes-expected.txt: Added.
- platform/efl/accessibility/meter-element-expected.txt: Added.
- platform/efl/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
- platform/efl/compositing/iframes/resizer-expected.txt: Added.
- platform/efl/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.
- platform/efl/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Added.
- platform/efl/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
- platform/efl/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Added.
- platform/efl/css2.1/t1604-c542-letter-sp-00-b-a-expected.txt: Added.
- platform/efl/css3/flexbox/flexbox-baseline-margins-expected.txt: Added.
- platform/efl/editing/selection/contains-boundaries-expected.txt: Added.
- platform/efl/editing/selection/mixed-editability-10-expected.txt: Added.
- platform/efl/editing/selection/replaced-boundaries-3-expected.txt: Added.
- platform/efl/editing/style/5065910-expected.txt: Added.
- platform/efl/editing/style/font-family-with-space-expected.txt: Added.
- platform/efl/fast/css/named-images-expected.txt: Added.
- platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
- platform/efl/ietestcenter/css3/text/textshadow-005-expected.txt: Added.
- platform/efl/printing/media-queries-print-expected.txt: Added.
- platform/efl/printing/setPrinting-expected.txt: Added.
- platform/efl/printing/simultaneous-position-float-change-expected.txt: Added.
- platform/efl/printing/width-overflow-expected.txt: Added.
- platform/efl/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt: Added.
- 10:29 PM Changeset in webkit [186064] by
-
- 6 edits in trunk/Source/WebCore
Add support for 'Default' media session types
https://bugs.webkit.org/show_bug.cgi?id=146355
Reviewed by Darin Adler.
- Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::MediaSession): Added a new constructor for creating 'Default' media sessions.
(WebCore::MediaSession::kind): 'Default' media sessions are represented by an empty string.
- Modules/mediasession/MediaSession.h:
- dom/Document.cpp:
(WebCore::Document::defaultMediaSession): Lazily construct the default media session.
- dom/Document.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): New media elements are assigned to the 'Default' media session.
- 10:05 PM Changeset in webkit [186063] by
-
- 2 edits in trunk/Source/WebKit2
AX: iOS: Crash at accessibilityObjectForMainFramePlugin()
https://bugs.webkit.org/show_bug.cgi?id=146399
Reviewed by Darin Adler.
Could not reproduce issue, but the invalid address seems to indicate this is a nullptr access is happening when we try to get the plugin of the m_page variable when
it has not been initialized.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::accessibilityObjectForMainFramePlugin):
- 9:47 PM Changeset in webkit [186062] by
-
- 1 edit16 adds in trunk/LayoutTests
[EFL] Unreviewed, gardening.
Add missing expectation results in fast/ directory.
- platform/efl/fast/css/resize-corner-tracking-transformed-iframe-expected.txt: Added.
- platform/efl/fast/forms/select-element-focus-ring-expected.txt: Added.
- platform/efl/fast/regions/auto-size/autoheight-regions-mark-expected.txt: Added.
- platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
- platform/efl/fast/regions/flows-dependency-same-flow-expected.txt: Added.
- platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
- platform/efl/fast/regions/region-dynamic-after-before-expected.txt: Added.
- platform/efl/fast/regions/region-generated-content-before-after-expected.txt: Added.
- platform/efl/fast/regions/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
- platform/efl/fast/regions/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added.
- platform/efl/fast/regions/repaint/region-painting-invalidation-expected.txt: Added.
- platform/efl/fast/regions/repaint/region-painting-via-layout-expected.txt: Added.
- platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Added.
- platform/efl/fast/repaint/block-selection-gap-in-table-cell-expected.txt: Added.
- platform/efl/fast/ruby/select-ruby-expected.txt: Added.
- 8:18 PM Changeset in webkit [186061] by
-
- 2 edits in trunk/LayoutTests
ASAN crashes in js/regress-141098.html
<http://webkit.org/b/145007>
- TestExpectations: Remove test from skip list as it no longer
crashes with ASan enabled:
- js/regress-141098.html
- 8:18 PM Changeset in webkit [186060] by
-
- 2 edits in trunk/Source/WebKit/mac
[Mac] Remove redundant call to colorUsingColorSpaceName:
https://bugs.webkit.org/show_bug.cgi?id=146397
Reviewed by Alexey Proskuryakov.
- WebView/WebHTMLView.mm:
(extractUnderlines): Remove call to the colorUsingColorSpaceName: method,
since colorFromNSColor already calls it. No need to do it twice.
- 6:19 PM Changeset in webkit [186059] by
-
- 62 edits in trunk/Source/WebKit2
Use Ref/RefPtr instead of PassRefPtr in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=146190
Reviewed by Darin Adler.
As a step to remove PassRefPtr, this patch reduces use of PassRefPtr in WebKit2.
- Shared/API/c/WKContextMenuItem.cpp:
(WKContextMenuItemCreateAsAction):
(WKContextMenuItemCreateAsCheckableAction):
- Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::create):
- Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
- Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.cpp:
(WebKit::ThreadSafeCoordinatedSurface::create):
- Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.h:
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::create):
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::create):
- Shared/Plugins/NPRemoteObjectMap.h:
- Shared/WebBatteryStatus.h:
(WebKit::WebBatteryStatus::create):
- Shared/WebCertificateInfo.h:
(WebKit::WebCertificateInfo::create):
- Shared/WebContextMenuItem.h:
(WebKit::WebContextMenuItem::create):
- Shared/WebRenderObject.cpp:
(WebKit::WebRenderObject::create):
- Shared/WebRenderObject.h:
(WebKit::WebRenderObject::create):
- UIProcess/API/APINavigationData.h:
(API::NavigationData::create):
- UIProcess/API/APISession.cpp:
(API::Session::createEphemeral):
- UIProcess/API/APISession.h:
- UIProcess/API/APISessionState.cpp:
(API::SessionState::create):
- UIProcess/API/APISessionState.h:
- UIProcess/API/APIUserScript.h:
- UIProcess/API/APIWebsiteDataStore.cpp:
(API::WebsiteDataStore::createNonPersistentDataStore):
(API::WebsiteDataStore::create):
- UIProcess/API/APIWebsiteDataStore.h:
- UIProcess/API/C/WKCredential.cpp:
(WKCredentialCreate):
(WKCredentialCreateWithCertificateInfo):
- UIProcess/API/C/WKPage.cpp:
(WKPageCopySessionState):
(WKPageSetPageContextMenuClient):
- UIProcess/API/C/WKSessionStateRef.cpp:
(WKSessionStateCreateFromData):
- UIProcess/API/C/WKUserScriptRef.cpp:
(WKUserScriptCreateWithSource):
- UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.mm:
(-[WKNSURLAuthenticationChallengeSender useCredential:forAuthenticationChallenge:]):
- UIProcess/API/Cocoa/WKProcessGroup.mm:
(-[WKProcessGroup _setAllowsSpecificHTTPSCertificate:forHost:]):
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _setAllowsSpecificHTTPSCertificate:forHost:]):
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(+[WKWebsiteDataStore nonPersistentDataStore]):
- UIProcess/API/efl/ewk_auth_request_private.h:
(EwkAuthRequest::create):
- UIProcess/API/efl/ewk_back_forward_list_item_private.h:
(EwkBackForwardListItem::create):
- UIProcess/API/efl/ewk_context.cpp:
(EwkContext::create):
- UIProcess/API/efl/ewk_context_menu_private.h:
(EwkContextMenu::create):
- UIProcess/API/efl/ewk_download_job_private.h:
(EwkDownloadJob::create):
- UIProcess/API/efl/ewk_file_chooser_request_private.h:
(EwkFileChooserRequest::create):
- UIProcess/API/efl/ewk_form_submission_request_private.h:
(EwkFormSubmissionRequest::create):
- UIProcess/API/efl/ewk_navigation_data_private.h:
(EwkNavigationData::create):
- UIProcess/API/efl/ewk_security_origin_private.h:
(EwkSecurityOrigin::create):
- UIProcess/Authentication/AuthenticationChallengeProxy.h:
(WebKit::AuthenticationChallengeProxy::create):
- UIProcess/Authentication/AuthenticationDecisionListener.h:
(WebKit::AuthenticationDecisionListener::create):
- UIProcess/Authentication/WebCredential.h:
(WebKit::WebCredential::create):
- UIProcess/Authentication/WebProtectionSpace.h:
(WebKit::WebProtectionSpace::create):
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::HistoryClient::didNavigateWithNavigationData):
- UIProcess/Databases/DatabaseProcessProxy.cpp:
(WebKit::DatabaseProcessProxy::create):
- UIProcess/Databases/DatabaseProcessProxy.h:
- UIProcess/Launcher/ProcessLauncher.h:
(WebKit::ProcessLauncher::create):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::create):
- UIProcess/Notifications/WebNotificationManagerProxy.h:
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::create):
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/Scrolling/RemoteScrollingTree.cpp:
(WebKit::RemoteScrollingTree::create):
- UIProcess/Scrolling/RemoteScrollingTree.h:
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::create):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::WebProcessPool):
- UIProcess/efl/WebPopupMenuListenerEfl.h:
(WebKit::WebPopupMenuListenerEfl::create):
- UIProcess/efl/WebViewEfl.cpp:
(WebKit::WebView::create):
- UIProcess/ios/WebVideoFullscreenManagerProxy.h:
- UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::create):
- 5:33 PM Changeset in webkit [186058] by
-
- 3 edits2 deletes in trunk/Source/WebKit2
[Cocoa] Remove _WKSecurityOrigin.{h,mm}
https://bugs.webkit.org/show_bug.cgi?id=146402
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKSecurityOrigin.mm: Declare and define _WKSecurityOrigin here.
(-[WKSecurityOrigin methodSignatureForSelector:]): Moved into a WKBinaryCompatibility
category.
(-[WKSecurityOrigin forwardInvocation:]): Ditto.
- UIProcess/API/Cocoa/_WKSecurityOrigin.h: Removed.
- UIProcess/API/Cocoa/_WKSecurityOrigin.mm: Removed.
- WebKit2.xcodeproj/project.pbxproj: Removed references to _WKSecurityOrigin.{h,mm}.
- 4:30 PM Changeset in webkit [186057] by
-
- 2 edits in trunk/Tools
[Xcode] Use the same environment for command-line and IDE builds
https://bugs.webkit.org/show_bug.cgi?id=146401
Reviewed by Anders Carlsson.
- Scripts/webkitdirs.pm:
(XcodeOptions): Set the UseSanitizedBuildSystemEnvironment user default to YES, which makes
xcodebuild use the same environment Xcode uses.
- 4:07 PM Changeset in webkit [186056] by
-
- 2 edits in trunk/LayoutTests
Fix warning about duplicate test expectation: js/regress-141098.html
Fixes the following warning when running layout tests:
LayoutTests/TestExpectations:523 More specific entry for js/regress-141098.html on line LayoutTests/TestExpectations:523 overrides line LayoutTests/TestExpectations:519. js/regress-141098.html
- TestExpectations: Comment out duplicate:
- js/regress-141098.html
- 3:51 PM Changeset in webkit [186055] by
-
- 2 edits in trunk/LayoutTests
Mark http/tests/contentextensions/character-set-basic-support.html as flaky on mac-wk2
- platform/mac-wk2/TestExpectations: Mark ask flaky:
- http/tests/contentextensions/character-set-basic-support.html
- 3:16 PM Changeset in webkit [186054] by
-
- 4 edits in trunk/Source/WebCore
[iOS] Drop buffered data in paused media elements on memory pressure.
<https://webkit.org/b/146369>
<rdar://problem/20366883>
Reviewed by Eric Carlson.
To avoid getting crushed under mediaserverd memory growth when viewing
a page with multiple media elements, add a step to the memory pressure
handler that drops buffered data from all media elements that are
not currently playing.
On a test page with a bunch of embedded YouTube videos, this pass frees
up ~4MB per paused video when the system memory pressure hits.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::allMediaElements):
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::purgeBufferedDataIfPossible):
- html/HTMLMediaElement.h:
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::releaseCriticalMemory):
- 1:36 PM Changeset in webkit [186053] by
-
- 6 edits in tags/Safari-601.1.37.1
Merge r186046. rdar://problem/21581792
- 1:33 PM Changeset in webkit [186052] by
-
- 5 edits in tags/Safari-601.1.37.1/Source
Versioning.
- 1:22 PM Changeset in webkit [186051] by
-
- 1 copy in tags/Safari-601.1.37.1
New Tag.
- 12:09 PM Changeset in webkit [186050] by
-
- 2 edits in trunk
CairoGL should be checked unconditionally
https://bugs.webkit.org/show_bug.cgi?id=146390
Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-06-28
Reviewed by Darin Adler.
- Source/cmake/OptionsGTK.cmake: Move check for CairoGL so that
it is run unconditionally; this is necessary because its result
is used later on, outside of any conditions.
- 11:53 AM Changeset in webkit [186049] by
-
- 5 edits3 adds in trunk
Crash: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::CachedFrameBase::restore + 333
https://bugs.webkit.org/show_bug.cgi?id=146388
<rdar://problem/21567343>
Reviewed by Darin Adler.
Source/WebCore:
Pages that are currently loading are not supposed to go into the
PageCache. However, PageCache::canCache() only checks if the
FrameLoader's documentLoader is loading. If the subframe is in
provisional load stage, we would fail to detect that the frame is
actually loading because the FrameLoader active documentLoader would
be the provisional documentLoader, not the regular documentLoader.
Therefore, the page would get added to the PageCache and the frame
would keep loading while in the PageCache.
On http://www.audiusa.com/models, this is what was happening. It was
crashing because the subframe would finish loading while in the
PageCache, in which case we would fire the 'load' event and the
content 'load' event handler would then proceed to remove the iframe.
Upon restoring the PageCache entry, we would run into trouble as we
would have a CachedFrame whose Frame has been removed.
The solution proposed is to prevent page-caching if a subframe is in
provisional load stage.
Test: http/tests/navigation/page-cache-iframe-provisional-load.html
- history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::provisionalLoadKey):
- page/DiagnosticLoggingKeys.h:
LayoutTests:
Add layout test to cover the case where a subframe is currently in
provisional load stage when checking if the page if page-cacheable.
The test also removes the iframe once loaded in order to cause a crash
if the frame were to finish loading while in the page cache.
- http/tests/navigation/page-cache-iframe-provisional-load-expected.txt: Added.
- http/tests/navigation/page-cache-iframe-provisional-load.html: Added.
- http/tests/navigation/resources/page-cache-helper-slow.html: Added.
- 10:57 AM Changeset in webkit [186048] by
-
- 2 edits in trunk/Source/WebKit2
Tried to fix the EFL buid after r186046.
- UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::PageUIClientEfl):
- 9:18 AM Changeset in webkit [186047] by
-
- 5 edits in trunk
[ES6] Implement ES6 arrow function syntax. No Line terminator between function parameters and =>
https://bugs.webkit.org/show_bug.cgi?id=146394
Source/JavaScriptCore:
Patch by Aleksandr Skachkov <gskachkov@gmail.com> on 2015-06-28
Reviewed by Yusuke Suzuki.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseFunctionInfo):
LayoutTests:
Patch by Skachkov Oleksandr <gskachkov@gmail.com> on 2015-06-28
Reviewed by Yusuke Suzuki.
- js/arrowfunction-syntax-errors-expected.txt:
- js/script-tests/arrowfunction-syntax-errors.js:
- 9:05 AM Changeset in webkit [186046] by
-
- 6 edits in trunk
REGRESSION (r185915): Source-incompatible change in WKPageUIClient
https://bugs.webkit.org/show_bug.cgi?id=146396
Reviewed by Anders Carlsson.
Source/WebKit2:
- UIProcess/API/C/WKPageUIClient.h: Renamed
runJavaScript{Alert,Confirm,Prompt}_deprecatedForUseWithV0 back to runJavaScript{Alert,Confirm,Prompt}
in client versions prior to V5.
Tools:
- TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
(TestWebKitAPI::runJavaScriptAlert): Removed _deprecatedForUseWithV0 suffix from the name.
(TestWebKitAPI::TEST): Updated for renames.
- TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
(runJavaScriptAlert): Removed suffix.
(TestWebKitAPI::FullscreenZoomInitialFrame::initializeView): Updated.
- TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
(runJavaScriptAlert): Removed suffix.
(TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView): Updated.
- 8:33 AM Changeset in webkit [186045] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION: Page footers are displayed above the bottom of the WebView due to tiled scaling
https://bugs.webkit.org/show_bug.cgi?id=146393
<rdar://problem/21113217>
Reviewed by Sam Weinig.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded):
Don't include the top content inset in the layout size.
- 5:39 AM Changeset in webkit [186044] by
-
- 5 edits in trunk
[Streams API] Add support for chunks with customized sizes
https://bugs.webkit.org/show_bug.cgi?id=146312
Reviewed by Darin Adler.
Source/WebCore:
Covered by rebased tests.
- bindings/js/ReadableJSStream.cpp:
(WebCore::ReadableJSStream::read): Decrement totalQueueSize with the chunk specific size.
(WebCore::ReadableJSStream::enqueue): Calls retrieveSize, enqueue chunk with its size and increment totalQueueSize.
(WebCore::ReadableJSStream::retrieveChunkSize): Calls size JS callback and convert it to double.
- bindings/js/ReadableJSStream.h:
LayoutTests:
- streams/reference-implementation/bad-strategies-expected.txt:
- 5:16 AM Changeset in webkit [186043] by
-
- 6 edits in trunk/Source/WebCore
[Streams API]Remove ReadableStreamController.close custom binding
https://bugs.webkit.org/show_bug.cgi?id=146380
Reviewed by Darin Adler.
No change in behavior.
- Modules/streams/ReadableStreamController.h:
(WebCore::ReadableStreamController::close): Calling ReadableJSStream close method.
- Modules/streams/ReadableStreamController.idl: Removed Custom.
- bindings/js/JSReadableStreamControllerCustom.cpp:
(WebCore::JSReadableStreamController::close): Deleted.
- bindings/js/ReadableJSStream.cpp:
(WebCore::ReadableJSStream::close): Moved custom binding code here.
- bindings/js/ReadableJSStream.h:
- 12:43 AM Changeset in webkit [186042] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Wrong border color of console messages when filters are enabled
https://bugs.webkit.org/show_bug.cgi?id=146392
Reviewed by Timothy Hatcher.
- UserInterface/Views/LogContentView.css:
(.console-error-level:not(.filtered-out, .filtered-out-by-search) + .console-item):
(.console-warning-level:not(.filtered-out, .filtered-out-by-search) + .console-item):
