⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 1, 2015:

11:59 PM Changeset in webkit [186220] by achristensen@apple.com
  • 8 edits in trunk/Source

Source/ThirdParty/ANGLE:
Re-enable WebGL on WinCairo
​https://bugs.webkit.org/show_bug.cgi?id=146537

Reviewed by Csaba Osztrogonác.

  • ANGLE.vcxproj/DirectX32.props:
  • ANGLE.vcxproj/DirectX64.props:
  • ANGLE.vcxproj/libGLESv2Common.props:

Update DirectX directories to use the Windows SDK instead of the June 2010 DirectX SDK.

Source/WebKit:
Re-enable WebGL on WinCairo.
​https://bugs.webkit.org/show_bug.cgi?id=146537

Reviewed by Csaba Osztrogonác.

  • WebKit.vcxproj/WebKit.sln:

Build the ANGLE projects on WinCairo again.

Source/WTF:
Re-enable WebGL on WinCairo
​https://bugs.webkit.org/show_bug.cgi?id=146537

Reviewed by Csaba Osztrogonác.

  • wtf/FeatureDefines.h:

Enable WebGL on WinCairo again.

11:41 PM Changeset in webkit [186219] by achristensen@apple.com
  • 3 edits in trunk/LayoutTests

Fix test from r186208 and r186216.

  • http/tests/misc/webtiming-resolution-expected.txt:
  • http/tests/misc/webtiming-resolution.html:

Properly and explicitly test if the time delta is close to a multiple of the expected resolution.

9:46 PM Changeset in webkit [186218] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Web Inspector: Aggregate profile call information on the backend to drastically reduce profile sizes
​https://bugs.webkit.org/show_bug.cgi?id=146536

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-01
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • inspector/protocol/Timeline.json:

Change a CPUProfile from sending a required "calls" param to sending a required
"callInfo" param which includes aggregated information about the calls.

Source/WebCore:

  • inspector/TimelineRecordFactory.cpp:

(WebCore::buildAggregateCallInfoInspectorObject):
(WebCore::buildInspectorObject):
Replace the array of Call objects with a single aggregated call info object.

Source/WebInspectorUI:

Since we still support legacy backends, the frontend documents where
it is handling legacy backends with compatibility comments.

  • UserInterface/Models/ProfileNode.js:

(WebInspector.ProfileNode):
(WebInspector.ProfileNode.prototype.get callInfo):
Handle a ProfileNode created with callInfo or calls. They are mutually exclusive.

  • UserInterface/Models/ScriptTimelineRecord.js:

(WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload.profileNodeFromPayload):
If the profile has per-call information, construct ProfileNodeCall objects, otherwise
just construct the ProfileNode with the aggregate callInfo value.

  • UserInterface/Views/ScriptTimelineDataGridNode.js:

(WebInspector.ScriptTimelineDataGridNode.prototype.get data):
When we have aggregate call information we cannot easily partition a script,
so we instead treat the entire script as one large atomic unit in the timeline.
If the timeline range has any portion of the script, show the entire script.
Users used to be able to select a portion of a script and view the relevant
functions called in just that sliver, but this doesn't appear to be a well
known feature or commonly used. In fact, given the small ranges of time it
could be confusing for users.

  • UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype.matchTreeElementAgainstCustomFilters):
Treat as a discrete unit.

9:30 PM Changeset in webkit [186217] by Devin Rousso
  • 4 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: When autocompleting, pressing tab twice shouldn't insert a tab character
​https://bugs.webkit.org/show_bug.cgi?id=145885

Reviewed by Timothy Hatcher.

  • UserInterface/Controllers/CodeMirrorCompletionController.js:

(WebInspector.CodeMirrorCompletionController):
(WebInspector.CodeMirrorCompletionController.prototype.updateCompletions): Resolves the promise as having completions.
(WebInspector.CodeMirrorCompletionController.prototype.hideCompletions): Resolves the promise as not having completions.
(WebInspector.CodeMirrorCompletionController.prototype.completeAtCurrentPositionIfNeeded): Returns a WrappedPromise that allows
callers of this function to determine if the autocomplete had any values or was instead not shown.
(WebInspector.CodeMirrorCompletionController.prototype._resolveUpdatePromise):

  • UserInterface/Main.html: Added WrappedPromise class.
  • UserInterface/Models/WrappedPromise.js: Added WrappedPromise object to expose resolve and reject functions.
  • UserInterface/Views/ConsolePrompt.js:

(WebInspector.ConsolePrompt.prototype._handleTabKey): Attempts to find completions for current text. If there are none, beep.

9:01 PM Changeset in webkit [186216] by Chris Dumez
  • 3 edits in trunk/LayoutTests

Reduce resolution of performance.now
​https://bugs.webkit.org/show_bug.cgi?id=146531

Reviewed by Simon Fraser.

Make layout test introduced in r186208.

  • http/tests/misc/webtiming-resolution-expected.txt:
  • http/tests/misc/webtiming-resolution.html:
6:30 PM Changeset in webkit [186215] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG::freezeFragile should register the frozen value's structure
​https://bugs.webkit.org/show_bug.cgi?id=136055
rdar://problem/21042120

Reviewed by Mark Lam and Geoffrey Garen.

This fixes weird concurrency bugs where the constant folding phase tries to convert
something to a constant but then crashes because the constant's structure wasn't
registered. The AI was registering the structure of any value it saw, but constant folding
wasn't - and that's fine so long as there ain't no concurrency.

The best fix is to just make it impossible to introduce a constant into the IR without
registering its structure. That's what this change does. This is not only a great
concurrency fix - it also makes the compiler somewhat easier to hack on because it's one
less case of structure registering that you have to remember about.

  • dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::setOSREntryValue): No need to register.
(JSC::DFG::AbstractValue::set): We still call register, but just to get the watchpoint state.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::freezeFragile): Register the structure.

  • dfg/DFGStructureRegistrationPhase.cpp:

(JSC::DFG::StructureRegistrationPhase::run): Assert that these are all registered.

5:51 PM Changeset in webkit [186214] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Web Inspector: [Mac] InspectorFrontendHost.beep() doesn't play a sound, sandbox warnings
​https://bugs.webkit.org/show_bug.cgi?id=146525

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-01
Reviewed by Timothy Hatcher.

  • WebProcess/com.apple.WebProcess.sb.in:

Get NSBeep working without any sandbox warnings.

5:48 PM Changeset in webkit [186213] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.17-branch/Source

Versioning.

5:47 PM Changeset in webkit [186212] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Make the first click on a rule section create a newline for easy property addition
​https://bugs.webkit.org/show_bug.cgi?id=146490

Reviewed by Timothy Hatcher.

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._highlightNextNameOrValue):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleEnterKey): Inserts a semicolon if the line is missing one.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleMouseDown): If the user clicks on a property with the editor being
unfocused, the name/value containing the cursor will be highlighted. If instead the user clicks at the end of a line, the
cursor's position is saved for mouseUp.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleMouseUp): If the mouseDown cursor position was saved and is equal
to the current cursor's position (the user did not drag), add a newline after the current line and place the cursor on that line.
(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleTabKey):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleTabKey.highlightNextNameOrValue): Deleted.

5:40 PM Changeset in webkit [186211] by Chris Dumez
  • 3 edits in trunk/LayoutTests

Unreviewed, rebaseline js/dom/global-constructors-attributes.html after r186198.

  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
5:36 PM Changeset in webkit [186210] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] REGRESSION (r185124) CACFLayer handling broken
​https://bugs.webkit.org/show_bug.cgi?id=146530
<rdar://problem/21642241>

Reviewed by Tim Horton.

At some point in the past, the set of LayerChange flags
overflowed the default MSVC enum type of 'int'. This caused
Windows rendering code to not receive various update notifications.

Zalan's change moved the DebugIndicatorsChanged flag into that
overflow set, which made it obvious that something was wrong.

The fix is to tell the compiler to use a compatible base type
for the enum.

  • platform/graphics/ca/GraphicsLayerCA.h: Prevent overflow.
5:32 PM Changeset in webkit [186209] by bshafiei@apple.com
  • 5 edits in branches/safari-600.8-branch/Source

Versioning.

5:29 PM Changeset in webkit [186208] by achristensen@apple.com
  • 3 edits
    2 adds in trunk

Reduce resolution of performance.now.
​https://bugs.webkit.org/show_bug.cgi?id=146531
rdar://problem/20116796

Reviewed by Simon Fraser.

Source/WebCore:

Test: http/tests/misc/webtiming-resolution.html

  • page/Performance.cpp:

(WebCore::Performance::now):
Floor the time returned by performance.now to the nearest 5 microseconds.

LayoutTests:

  • http/tests/misc/webtiming-resolution-expected.txt: Added.
  • http/tests/misc/webtiming-resolution.html: Added.
5:07 PM Changeset in webkit [186207] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Ignore Visual Studio warning in SegmentedVector
​https://bugs.webkit.org/show_bug.cgi?id=146514

Patch by Alex Christensen <​achristensen@webkit.org> on 2015-07-01
Reviewed by Andreas Kling.

  • wtf/SegmentedVector.h:

(WTF::SegmentedVector::deleteAllSegments):
Use pragmas to ignore the 0 element array warning.

5:05 PM Changeset in webkit [186206] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[iOS] Build fix

Patch by Eric Carlson <​eric.carlson@apple.com> on 2015-07-01
Reviewed by Brent Fulgham.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(-[WebAVVideoLayer enterPIPModeRedirectingVideoToLayer:]): Renamed from enterOptimizedFullScreenModeRedirectingVideoToLayer.
(-[WebAVVideoLayer leavePIPMode]): Renamed from leaveOptimizedFullScreenMode.
(-[WebAVVideoLayer enterOptimizedFullScreenModeRedirectingVideoToLayer:]): Deleted.
(-[WebAVVideoLayer leaveOptimizedFullScreenMode]): Deleted.

5:02 PM Changeset in webkit [186205] by mmaxfield@apple.com
  • 5 edits
    3 adds in trunk

[iOS] Support bold and thin italicized system fonts
​https://bugs.webkit.org/show_bug.cgi?id=146463
<rdar://problem/20948885>

Reviewed by Darin Adler.

Source/WebCore:

Add the italicized attribute to font descriptors.

Test: fast/text/weighted-italicized-system-font.html

  • platform/graphics/ios/FontCacheIOS.mm:

(WebCore::createCTFontWithFamilyNameAndWeight):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::fontWithFamilySpecialCase):
(WebCore::fontWithFamily):

  • platform/spi/cocoa/CoreTextSPI.h:

LayoutTests:

  • fast/text/weighted-italicized-system-font-expected.html: Added.
  • fast/text/weighted-italicized-system-font.html: Added.
5:00 PM Changeset in webkit [186204] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Remove code to recompute rounded window corners
​https://bugs.webkit.org/show_bug.cgi?id=146534

Reviewed by Simon Fraser.

This code is no longer needed since we're always layer-backed now.

  • UIProcess/API/mac/WKView.mm:

(-[WKView displayIfNeeded]): Deleted.
(-[WKView _cacheWindowBottomCornerRect]): Deleted.

  • UIProcess/API/mac/WKViewInternal.h:
4:36 PM Changeset in webkit [186203] by ggaren@apple.com
  • 2 edits in trunk/Source/bmalloc

bmalloc: realloc of an XLarge range can unmap adjacent VM ranges
​https://bugs.webkit.org/show_bug.cgi?id=146535

Reviewed by Anders Carlsson.

This bug causes a crash when running fast/css/large-list-of-rules-crash.html
with the fix applied for ​https://bugs.webkit.org/show_bug.cgi?id=146519.

  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::reallocate): Start at object + newSize since starting
at object + oldSize means deleting the adjacent VM range.

4:28 PM Changeset in webkit [186202] by mmirman@apple.com
  • 13 edits
    5 deletes in trunk

Unreviewed, rolling out r185889
​https://bugs.webkit.org/show_bug.cgi?id=146528
rdar://problem/21573959

Patch breaks chromeexperiments.com

Reverted changeset:

Source/JavaScriptCore:

(.):

  • runtime/JSBoundSlotBaseFunction.cpp: Removed.
  • runtime/JSBoundSlotBaseFunction.h: Removed.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init): Deleted.
(JSC::JSGlobalObject::visitChildren): Deleted.

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::boundSlotBaseFunctionStructure): Deleted.

  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::getBoundSlotBaseFunctionForGetterSetter): Deleted.

  • runtime/VM.cpp:

(JSC::VM::VM): Deleted.

  • runtime/VM.h:

LayoutTests:

  • inspector-protocol/runtime/getProperties-expected.txt:
  • js/dom/native-bindings-descriptors-expected.txt: Removed.
  • js/dom/native-bindings-descriptors.html: Removed.
  • js/dom/script-tests/native-bindings-descriptors.js: Removed.
4:26 PM Changeset in webkit [186201] by achristensen@apple.com
  • 17 edits
    1 delete in trunk/Source

Fix ANGLE Windows build after r186169.
​https://bugs.webkit.org/show_bug.cgi?id=146532

Reviewed by Brent Fulgham.

Source/ThirdParty/ANGLE:

  • ANGLE.vcxproj/libEGL.vcxproj:
  • ANGLE.vcxproj/libEGL.vcxproj.filters:
  • ANGLE.vcxproj/libGLESv2.vcxproj:
  • ANGLE.vcxproj/libGLESv2.vcxproj.filters:
  • ANGLE.vcxproj/libGLESv2Common.props:
  • ANGLE.vcxproj/translator_common.vcxproj:
  • ANGLE.vcxproj/translator_common.vcxproj.filters:
  • ANGLE.vcxproj/translator_glsl.vcxproj:
  • ANGLE.vcxproj/translator_glsl.vcxproj.filters:
  • ANGLE.vcxproj/translator_hlsl.vcxproj:
  • ANGLE.vcxproj/translator_hlsl.vcxproj.filters:

Update Windows build to build new files.

Source/WebCore:

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:

Don't compile OpenGLShims.cpp or Extensions3DOpenGL.cpp on Windows
because Windows uses OpenGLES through ANGLE, not OpenGL.

  • platform/graphics/ANGLEWebKitBridge.h:

Use OpenGLESShims.h on Windows instead of OpenGLShims.h.

  • platform/graphics/OpenGLESShims.h:

Added needed definitions from OpenGL to compile successfully.

  • platform/graphics/win/GL/glext.h: Removed.
4:17 PM Changeset in webkit [186200] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Web page doesn't update its loading state when web process becomes suspended if there are pending network requests (XHR).
​https://bugs.webkit.org/show_bug.cgi?id=146439

When web page is loading, we hold a background activity token in NavigationState and we release the token when the page done
loading. A web page can start loading subresources (like XHR) after the page is loaded, and WebPageProxy will update its
_networkRequestsInProgress state which will notify the client there is network actvity on-going. Since we don't hold
the background activity token after page is loaded, the WebContent process could become suspended without notifying the client
and the client will lose track of the loading state.

The first thought was to hold another background activity when _networkRequestsInProgress flag is set in NavigationState.
However, this could result in side-effect that a WebContent process can stay active for too long if there is a long lasting
XHR resquest.

This patch fix this by notifying the client that network activity is stopped when WebContent process is going to be suspended.
We also cache the networkRequestsInProgress state for suspended process, so that when it becomes foreground, we can tell
the client the correct state of network activity.

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2015-07-01
Reviewed by Dan Bernstein.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy): Initialize m_hasNetworkRequestsOnSuspended.
(WebKit::WebPageProxy::processWillBecomeSuspended): If there is pending requests on suspend, cache the network activity state

and notify the client.

(WebKit::WebPageProxy::processWillBecomeForground): Restore the network activity state when the process becomes foreground.
(WebKit::WebPageProxy::resetState):

  • UIProcess/WebPageProxy.h: Add a data member m_hasNetworkRequestsOnSuspended to cache the network activity state on process

suspend.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didSetAssertionState):

4:09 PM Changeset in webkit [186199] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Turn off mediastreamaudiosourcenode.html test
​https://bugs.webkit.org/show_bug.cgi?id=146527
<rdar://problem/21641223>

Patch by Matthew Daiter <​mdaiter@apple.com> on 2015-07-01
Reviewed by Simon Fraser.

  • platform/mac/TestExpectations:
3:38 PM Changeset in webkit [186198] by dino@apple.com
  • 24 edits in trunk/Source

Disable the experimental WebGL2 implementation
​https://bugs.webkit.org/show_bug.cgi?id=146526
<rdar://problem/21641235>

Reviewed by Myles Maxfield.

Source/JavaScriptCore:

Add (and disable) an ENABLE_WEBGL2 flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Add (and disable) an ENABLE_WEBGL2 flag. Also protect
anything that is specific to WebGL2.

Covered by running the WebGL 1.0.2 conformance suite
and our LayoutTests.

  • Configurations/FeatureDefines.xcconfig:
  • bindings/js/JSCanvasRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSWebGL2RenderingContextCustom.cpp:
  • bindings/js/JSWebGLRenderingContextBaseCustom.cpp:

(WebCore::toJS):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::is3dType):

  • html/canvas/WebGL2RenderingContext.cpp:
  • html/canvas/WebGL2RenderingContext.h:
  • html/canvas/WebGL2RenderingContext.idl:
  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::drawBuffersIfNecessary):

  • html/canvas/WebGLGetInfo.cpp:
  • html/canvas/WebGLGetInfo.h:
  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::create):

  • html/canvas/WebGLVertexArrayObject.cpp:
  • html/canvas/WebGLVertexArrayObject.h:
  • html/canvas/WebGLVertexArrayObject.idl:

Source/WebKit/mac:

Add (and disable) an ENABLE_WEBGL2 flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Add (and disable) an ENABLE_WEBGL2 flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

Add (and disable) an ENABLE_WEBGL2 flag.

  • wtf/FeatureDefines.h:
3:22 PM Changeset in webkit [186197] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Fix missing space.

  • platform/mac/TestExpectations:
2:54 PM Changeset in webkit [186196] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Never try to pass URLs to LaunchServices when they're the same domain as the current URL.
<rdar://problem/20731429> and ​https://bugs.webkit.org/show_bug.cgi?id=146521

Reviewed by Alex Christensen.

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::tryAppLink): Compare the proposed URL to the current URL to see if they’re in the same domain.
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):

2:52 PM Changeset in webkit [186195] by Chris Dumez
  • 7 edits
    2 adds in trunk

Regression(183998): Disqus comments take a very long time to load
​https://bugs.webkit.org/show_bug.cgi?id=146522
<rdar://problem/21590601>

Reviewed by Simon Fraser.

Source/WebCore:

Stop throttling requestAnimationFrame() in iframes that are not visible
due to them being zero-sized or display:none. Those are usually utility
iframes and throttling them is risky.

Se still throttle requestAnimationFrame() in iframes that would be
visible in theory but are currently not noticeable because they are
outside the viewport.

Test:

  • fast/animation/request-animation-frame-throttle-subframe.html
  • fast/animation/request-animation-frame-throttle-subframe-display-none.html
  • fast/animation/request-animation-frame-throttle-subframe-zero-size.html
  • page/FrameView.cpp:

(WebCore::FrameView::updateScriptedAnimationsAndTimersThrottlingState):

LayoutTests:

  • fast/animation/request-animation-frame-throttle-subframe-display-none-expected.txt:
  • fast/animation/request-animation-frame-throttle-subframe-display-none.html:

Update layout test as we changed behavior here. We no longer throttle display:none
iframes.

  • fast/animation/request-animation-frame-throttle-subframe-zero-size-expected.txt: Added.
  • fast/animation/request-animation-frame-throttle-subframe-zero-size.html: Added.

Add layout test to check that we don't throttle RaF in iframes that are zero-sized.

  • fast/animation/resources/requestAnimationFrame-frame-2.html:
  • fast/animation/resources/requestAnimationFrame-frame.html:

Update use of requestAnimationFrame() to be more representative of real world usage.

2:34 PM Changeset in webkit [186194] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

WKWebView snapshots have the wrong scale after rotation
​https://bugs.webkit.org/show_bug.cgi?id=146476
<rdar://problem/18345247>

Reviewed by Anders Carlsson.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):
"Coordinate" -> "Coordinates".

(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):
Defer any snapshotting that happens during a resize until after
the resize completes. This will ensure that (in the case of an IOSurface
snapshot) the tiles are up to date, and (in the case of a software snapshot)
that our understanding of the scale and scroll offset of the WKContentView
are up to date, so that we can correctly convert from view to content coordinates
in the UI process.

(-[WKWebView _endAnimatedResize]):
Perform the deferred snapshotting after the resize completes.

2:21 PM Changeset in webkit [186193] by Simon Fraser
  • 2 edits in trunk/Source/WebKit/mac

Fix the iOS build.

  • WebCoreSupport/WebUserMediaClient.mm:

(-[WebUserMediaPolicyListener denyOnlyThisRequest]): Remove ASSERT_NOT_REACHED,
because it caused the compiler to warn about noreturn.

1:53 PM Changeset in webkit [186192] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Mark compositing/masks/compositing-clip-path-origin.html as being image-flakey.

  • platform/mac/TestExpectations:
1:31 PM Changeset in webkit [186191] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

REGRESSION (r179168): Characters overlap after resizing the font on the copy-pasted Japanese text
​https://bugs.webkit.org/show_bug.cgi?id=146492

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by WebKit serializing the used line-height size (e.g. 18px) in the copied content
instead of string "normal" and removeStyleFromRulesAndContext failing to strip it down when text with
a font that influences the line height got pasted. This is because the used value of line-height
property of the context and the pasted content doesn't match when the context doesn't use the same font.

Fixed the bug by not considering line-height as a list of editing properties we try to preserve. This is
fine because we don't provide editing operations to directly manipulate line-height.

Test: editing/pasteboard/cjk-line-height.html

  • editing/EditingStyle.cpp:

(WebCore::editingProperties): Removed CSSPropertyLineHeight.

LayoutTests:

Added a regression test. Also reverted the bad rebaseline in r179168:
​http://trac.webkit.org/changeset/179168/trunk/LayoutTests/editing/pasteboard/simplfiying-markup-should-not-strip-content-expected.txt

  • editing/pasteboard/cjk-line-height-expected.txt: Added.
  • editing/pasteboard/cjk-line-height.html: Added.
  • editing/pasteboard/simplfiying-markup-should-not-strip-content-expected.txt:
1:07 PM Changeset in webkit [186190] by bshafiei@apple.com
  • 1 copy in branches/safari-600.8-branch

New Branch.

1:07 PM Changeset in webkit [186189] by bshafiei@apple.com
  • 1 copy in branches/safari-600.1.4.17-branch

New Branch.

12:34 PM Changeset in webkit [186188] by bshafiei@apple.com
  • 5 edits
    1 copy
    1 delete in tags/Safari-601.1.38/Source/WebKit2

Roll out r185936. rdar://problem/21637235

12:33 PM Changeset in webkit [186187] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.38/Source

Roll out r185939. rdar://problem/21637235

12:32 PM Changeset in webkit [186186] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.38/Source/WebCore

Roll out r185951. rdar://problem/21637235

12:29 PM Changeset in webkit [186185] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

REGRESSION (r184296): View keeps scrolling upward
​https://bugs.webkit.org/show_bug.cgi?id=146497
<rdar://problem/21524942>

Reviewed by Darin Adler.

Avoid improperly triggering the ScrollController wheel event handling
logic when the wheel event deltaX/deltaY are zero. On certain sites,
this caused a programmatic JavaScript scroll to be triggered unexpectedly,
scrolling the page back to some initial state.

This bug was introduced while trying to make sure scrollbars were notified
when the wheel event had come to an end. Revise that change so that we still
follow the right code path for non-stretchable regions. However, make sure
that for zero-delta wheel events we make sure to properly handle the wheel
event phase.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::shouldForwardWheelEventsToParent): New helper function
to reduce the complexity of the logic in handleWheelEvent.
(WebCore::ScrollAnimatorMac::handleWheelEvent): When wheel events should be forwarded
to the parent scroll view, if the event was handled or has no change in position
trigger the 'handleWheelEventPhase' logic so that scrollbars are hidden, etc.

12:11 PM Changeset in webkit [186184] by Beth Dakin
  • 2 edits in trunk/Source/WebKit2

This is a quick follow-on to ​http://trac.webkit.org/changeset/186132

Rubber-stamped by Darin Adler.

Make this a one-liner.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation):

12:08 PM Changeset in webkit [186183] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

Hide the inline controls when going into PiP
​https://bugs.webkit.org/show_bug.cgi?id=146487
<rdar://problem/19881159>

Reviewed by Eric Carlson.

When the presentation mode is PiP, toggle a class
on the container element so that we can completely
hide the control toolbar. The placard should still
remain visible.

  • Modules/mediacontrols/mediaControlsiOS.css:

(video::-webkit-media-controls-panel-container.picture-in-picture): Add
a rule that hides the toolbar when PiP is active.

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.showControls):
(ControllerIOS.prototype.handlePresentationModeChange): Toggle a
class. Also fix a bug I noticed where exiting from PiP was
not auto-hiding the controls until the user tapped.

11:44 AM Changeset in webkit [186182] by commit-queue@webkit.org
  • 30 edits in trunk

Source/JavaScriptCore:
Enable MEDIA_STREAM flag
​https://bugs.webkit.org/show_bug.cgi?id=145947
<rdar://problem/21365829>

Patch by Matthew Daiter <​mdaiter@apple.com> on 2015-07-01
Reviewed by Eric Carlson.

  • Configurations/FeatureDefines.xcconfig: Added MEDIA_STREAM flag

Source/WebCore:
Enable MEDIA_STREAM flag
​https://bugs.webkit.org/show_bug.cgi?id=145947
<rdar://problem/21365829>

Patch by Matthew Daiter <​mdaiter@apple.com> on 2015-07-01
Reviewed by Eric Carlson.

  • Configurations/FeatureDefines.xcconfig: Added MEDIA_STREAM flag
  • Modules/mediastream/MediaStreamTrack.h:
  • WebCore.xcodeproj/project.pbxproj: Changed project headers to

private headers

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/mac/AVAudioCaptureSource.mm:
  • platform/mediastream/mac/AVCaptureDeviceManager.mm:

(WebCore::refreshCaptureDeviceList): Deleted.

  • platform/mediastream/mac/AVMediaCaptureSource.mm:

(WebCore::AVMediaCaptureSource::startProducingData):
(WebCore::AVMediaCaptureSource::stopProducingData):

Source/WebKit/mac:
Enable MEDIA_STREAM flag
​https://bugs.webkit.org/show_bug.cgi?id=145947
<rdar://problem/21365829>

Patch by Matthew Daiter <​mdaiter@apple.com> on 2015-07-01
Reviewed by Eric Carlson.

  • Configurations/FeatureDefines.xcconfig: Added MEDIA_STREAM flag
  • WebCoreSupport/WebUserMediaClient.h: Changed signatures
  • WebCoreSupport/WebUserMediaClient.mm: Changed signatures

(WebUserMediaClient::requestPermission):
(WebUserMediaClient::cancelRequest):
(-[WebUserMediaPolicyListener denyOnlyThisRequest]):
(-[WebUserMediaPolicyListener shouldClearCache]):

Source/WebKit2:
Enable MEDIA_STREAM flag
​https://bugs.webkit.org/show_bug.cgi?id=145947
<rdar://problem/21365829>

Patch by Matthew Daiter <​mdaiter@apple.com> on 2015-07-01
Reviewed by Eric Carlson.

  • Configurations/FeatureDefines.xcconfig: Add MEDIA_STREAM flag
  • WebKit2.xcodeproj/project.pbxproj: Changed some project to private

declarations of headers

  • WebProcess/WebCoreSupport/WebUserMediaClient.cpp:
  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::userMediaPermissionRequestManager):

Tools:
Enabled MEDIA_STREAM flag
​https://bugs.webkit.org/show_bug.cgi?id=145947
<rdar://problem/21365829>

Patch by Matthew Daiter <​mdaiter@apple.com> on 2015-07-01
Reviewed by Eric Carlson.

  • TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:

LayoutTests:
Enable MEDIA_STREAM flag
​https://bugs.webkit.org/show_bug.cgi?id=145947
<rdar://problem/21365829>

Patch by Matthew Daiter <​mdaiter@apple.com> on 2015-07-01
Reviewed by Eric Carlson.

*
platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
Added attributes to tests
*
platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
Ditto

  • platform/mac/js/dom/global-constructors-attributes-expected.txt:

Ditto

10:35 AM Changeset in webkit [186181] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

REGRESSION (r185016): Intermittent crash in WebCore::TextTrackList::remove
​https://bugs.webkit.org/show_bug.cgi?id=146493
<rdar://problem/21511122>

Reviewed by Eric Carlson.

The m_textTracks member is frequently null checked during other operations, but
was not checked during track removal. This needs to be corrected.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::removeTextTrack): Check that m_textTracks is
not null before using it during track removal.

10:22 AM Changeset in webkit [186180] by Antti Koivisto
  • 7 edits
    2 adds in trunk

PNG mask images are loaded with Accept:image/svg+xml
​https://bugs.webkit.org/show_bug.cgi?id=146509
Source/WebCore:

rdar://problem/21584740

Reviewed by Simon Fraser.

For some strange reason MaskImageOperation code loads all mask images, including non-SVG ones
using CachedSVGDocument. Resulting bad accept header may cause server to reject the request.

This is far from ideal but as a quick fix we can override the accept header for mask images to
allow any image type.

Test: http/tests/misc/mask-image-accept.html

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

  • loader/cache/CachedResourceRequest.h:

(WebCore::CachedResourceRequest::acceptOverride):
(WebCore::CachedResourceRequest::setAcceptOverride):

  • loader/cache/CachedSVGDocumentReference.cpp:

(WebCore::CachedSVGDocumentReference::load):

  • loader/cache/CachedSVGDocumentReference.h:

(WebCore::CachedSVGDocumentReference::loadRequested):
(WebCore::CachedSVGDocumentReference::setAcceptsAnyImageType):
(WebCore::CachedSVGDocumentReference::document):

  • platform/graphics/MaskImageOperation.cpp:

(WebCore::MaskImageOperation::ensureCachedSVGDocumentReference):

LayoutTests:

Reviewed by Simon Fraser.

  • http/tests/misc/mask-image-accept-expected.html: Added.
  • http/tests/misc/mask-image-accept.html: Added.
10:13 AM Changeset in webkit [186179] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit/mac

REGRESSION (185319): Reproducible crash in WebHistoryItem launching FluidApp.
<rdar://problem/21598293> and ​https://bugs.webkit.org/show_bug.cgi?id=146494

Reviewed by Darin Adler.

  • History/WebHistoryItem.mm:

(-[WebHistoryItem initFromDictionaryRepresentation:]): Don’t reference members of a Vector

that don’t exist.

9:53 AM Changeset in webkit [186178] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Check shouldOpenExternalURLs instead of isProcessingUserGesture before passing URL to LaunchServices.
<rdar://problem/20577859> and ​https://bugs.webkit.org/show_bug.cgi?id=146513

Reviewed by Darin Adler.

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::tryAppLink): The expected value of isProcessingUserGesture is lost over redirects.

shouldOpenExternalURLs actually fits this role perfectly.

8:54 AM Changeset in webkit [186177] by jer.noble@apple.com
  • 4 edits
    11 adds in trunk

[MSE] Failures on W3C media-source tests regarding MIME types
​https://bugs.webkit.org/show_bug.cgi?id=146499

Reviewed by Eric Carlson.

Source/WebCore:

Tests: http/tests/media/media-source/SourceBuffer-abort-readyState.html

http/tests/media/media-source/SourceBuffer-abort-removed.html
http/tests/media/media-source/SourceBuffer-abort-updating.html
http/tests/media/media-source/SourceBuffer-abort.html

Multiple failures in the W3C media-source test suite due to two failures in isTypeSupported MIME type handling:

  • MIME types without codec strings were being rejected.
  • MIME types with codec strings which are rejected by the system are being reported as supported.

For the first, stop rejecting MIME types with non-existent codec strings. For MIME types which do have non-empty
codec strings, treat a "Maybe" response as unsupported.

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::isTypeSupported):

LayoutTests:

Import four new tests from the w3c test suite <​https://github.com/w3c/web-platform-tests.git>.

  • http/tests/media/media-source/SourceBuffer-abort-readyState.html: Added.
  • http/tests/media/media-source/SourceBuffer-abort-removed.html: Added.
  • http/tests/media/media-source/SourceBuffer-abort-updating.html: Added.
  • http/tests/media/media-source/SourceBuffer-abort.html: Added.
  • http/tests/media/white.mp4: Added.
  • http/tests/media/white.webm: Added.
  • platform/mac/TestExpectations:
  • platform/mac/http/tests/media/media-source/SourceBuffer-abort-expected.txt: Added.
  • platform/mac/http/tests/media/media-source/SourceBuffer-abort-readyState-expected.txt: Added.
  • platform/mac/http/tests/media/media-source/SourceBuffer-abort-removed-expected.txt: Added.
  • platform/mac/http/tests/media/media-source/SourceBuffer-abort-updating-expected.txt: Added.
  • platform/mac/http/tests/media/media-source/mediasource-is-type-supported-expected.txt: Added.
8:44 AM Changeset in webkit [186176] by Michael Catanzaro
  • 2 edits in trunk/Source/WebKit2

[GTK] [Wayland] Build broken with ENABLE_WAYLAND_TARGET=ON
​https://bugs.webkit.org/show_bug.cgi?id=146512

Unreviewed, fix build with ENABLE_WAYLAND_TARGET=ON after r185949.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreateWebPage):

7:51 AM Changeset in webkit [186175] by Martin Robinson
  • 5 edits
    2 copies in trunk

[GTK] REGRESSION(r183936): Test /webkit2/WebKitWebContext/spell-checker fails since r183936
​https://bugs.webkit.org/show_bug.cgi?id=144828

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Instead of setting spell checking languages unconditionally when building int
developer mode, add some C API that allows setting them in WebKitTestRunner.

  • PlatformGTK.cmake: Add the new C API file to the source list.
  • UIProcess/API/C/gtk/WKTextCheckerGtk.cpp:

(WKTextCheckerSetSpellCheckingLanguages): Added this function which allows settings
the spell checking languages from the C API.

  • UIProcess/API/C/gtk/WKTextCheckerGtk.h: Added.
  • UIProcess/gtk/TextCheckerGtk.cpp:

(WebKit::enchantTextChecker): Remove the hack which sets the spell checking languages automatically
for development builds.

Tools:

  • WebKitTestRunner/gtk/main.cpp:

(main): Use the new WKTextChecker API to set the spell checking languages
when the process is starting up.

1:55 AM Changeset in webkit [186174] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Mac] Numerous CGColor leaks in swipe gestures
​https://bugs.webkit.org/show_bug.cgi?id=146501

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-01
Reviewed by Tim Horton.

  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::beginSwipeGesture):

1:51 AM Changeset in webkit [186173] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Mac] Confusing RetainPtr use in TiledCoreAnimationDrawingArea
​https://bugs.webkit.org/show_bug.cgi?id=146503

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-01
Reviewed by Tim Horton.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):
Simplify adoption into a new RetainPtr.

Jun 30, 2015:

11:26 PM Changeset in webkit [186172] by achristensen@apple.com
  • 4 edits in trunk/Source

[Win] Unreviewed build fix after r186169.

Source/WebKit:

  • WebKit.vcxproj/WebKit.sln:

Temporarily don't build ANGLE projects on Windows.

Source/WTF:

  • wtf/FeatureDefines.h:

Temporarily disable WebGL on WinCairo. It was already temporarily disabled on AppleWin.

11:23 PM Changeset in webkit [186171] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

11:18 PM Changeset in webkit [186170] by bshafiei@apple.com
  • 6 edits in tags/Safari-601.1.38/Source/WebKit2

Roll out r186148. rdar://problem/20655729

11:17 PM Changeset in webkit [186169] by achristensen@apple.com
  • 160 edits
    541 adds
    85 deletes in trunk/Source

Update ANGLE to b11e2483742db884bd0af41f78f528240577356b.
​https://bugs.webkit.org/show_bug.cgi?id=145010

Reviewed by Dean Jackson.

Source/ThirdParty/ANGLE:

Huge list of source changes omitted.
ROLL DEPS!

Source/WebCore:

  • CMakeLists.txt:
  • platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::appendSymbol):
(WebCore::getStructInfo):
(WebCore::getSymbolInfo):
(WebCore::ANGLEWebKitBridge::cleanupCompilers):
(WebCore::ANGLEWebKitBridge::compileShaderSource):
(WebCore::getValidationResultValue): Deleted.

  • platform/graphics/ANGLEWebKitBridge.h:

(WebCore::ANGLEShaderSymbol::isSampler):

  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::SymbolInfo::SymbolInfo):

  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/opengl/Extensions3DOpenGL.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::checkVaryingsPacking):
(WebCore::GraphicsContext3D::precisionsMatch):
Update WebCore to reflect changes in ANGLE.

11:15 PM Changeset in webkit [186168] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.38

New tag.

11:08 PM Changeset in webkit [186167] by Gyuyoung Kim
  • 2 edits
    1 add in trunk/LayoutTests

[EFL] Unreviewed gardening.

Some tests are flaky or timeout after bumping Ubuntu version from 14.04 to 15.04.
Mark the tests to flaky or timeout.

  • platform/efl/TestExpectations:
  • platform/efl/compositing/tiling/rotated-tiled-clamped-expected.txt: Added.
10:59 PM Changeset in webkit [186166] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, skip this test for now. We can unskip it when this feature is enabled.

  • js/script-tests/intl.js:
9:30 PM Changeset in webkit [186165] by Alan Bujtas
  • 5 edits
    2 adds in trunk

Frame flattening: Hit-testing an iframe could end up destroying the associated inline tree context.
​https://bugs.webkit.org/show_bug.cgi?id=146447
rdar://problem/20613501

Reviewed by Simon Fraser.

This patch ensures that the render tree associated with the document on which
the hit-test is initiated does not get laid out, unless it was directly mutated prior to the hittest.

Hit-test requirements:

  1. A clean the render tree before hit-testing gets propagated to the renderers.

Document::updateLayout() ensures it by calling both updateStyleIfNeeded() and layout() not only on the current tree, but also
on the ancestors if needed.

  1. No render tree mutation while hit-testing the renderers.

When an iframe is being hit-tested, this hit-test could bubble down to the child frame's render view.
In order to ensure #1, we call Document::updateLayout() on the current (subframe) document.
If updateStyleIfNeeded() mutates the render tree, we mark it dirty for layout(). However frame flattening also
marks the parent renderer (RenderIFrame) dirty.
While calling layout() to clean the current render tree, we end up laying out the parent tree too.
Laying out the parent tree could end up destroying the inline tree context from where the
hittest just bubbled down. (InlineFlowBox -> RenderWidget -> RenderView).

This patch protects the render tree from such unintentional inline tree mutation during hittesting.
After the initial layout we set a layout disallow flag on the frame view to defer subsequent layouts.
This patch only changes behavior when frame flattening is enabled, but in future we may always want to enable this.

Source/WebCore:

Test: fast/frames/flattening/hittest-iframe-while-style-changes-crash.html

  • page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore::FrameView::startLayoutAtMainFrameViewIfNeeded): Deleted. -> Assertion in no longer valid.

  • page/FrameView.h:
  • rendering/RenderView.cpp:

(WebCore::FrameFlatteningLayoutDisallower::FrameFlatteningLayoutDisallower):
(WebCore::FrameFlatteningLayoutDisallower::~FrameFlatteningLayoutDisallower):
(WebCore::RenderView::hitTest): Protect the render tree from subsequent layouts.

LayoutTests:

  • fast/frames/flattening/hittest-iframe-while-style-changes-crash-expected.txt: Added.
  • fast/frames/flattening/hittest-iframe-while-style-changes-crash.html: Added.
7:39 PM Changeset in webkit [186164] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

Fix CoordinatedGraphics.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::didFlushRootLayer):

7:07 PM Changeset in webkit [186163] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: add " = $0" hint after selected element in main DOMTreeOutline
​https://bugs.webkit.org/show_bug.cgi?id=145739

Patch by Devin Rousso <Devin Rousso> on 2015-06-30
Reviewed by Timothy Hatcher.

  • UserInterface/Views/DOMTreeOutline.css: Adds a semi-opaque " = $0" to the selected element in the DOM tree.

(.dom-tree-outline li.selected > span::after):
(.dom-tree-outline:focus li.selected > span::after):

7:03 PM Changeset in webkit [186162] by Simon Fraser
  • 3 edits in trunk/Source/WebKit2

More Gtk/EFL fixing.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::didFlushRootLayer):

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::flushPendingLayerChanges):

7:01 PM Changeset in webkit [186161] by commit-queue@webkit.org
  • 25 edits
    5 adds in trunk

Implement ECMAScript Internationalization API
​https://bugs.webkit.org/show_bug.cgi?id=90906

Patch by Andy VanWagoner <​thetalecrafter@gmail.com> on 2015-06-30
Reviewed by Benjamin Poulain.

.:

Begin implementing the Intl apis behind ENABLE_INTL flag.
Create the base Intl namespace object.

  • Source/cmake/WebKitFeatures.cmake: add ENABLE_INTL flag

Source/JavaScriptCore:

  • CMakeLists.txt: add IntlObject.cpp
  • Configurations/FeatureDefines.xcconfig: add ENABLE_INTL flag
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: add IntlObject
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: add IntlObject
  • JavaScriptCore.xcodeproj/project.pbxproj: add IntlObject
  • runtime/CommonIdentifiers.h: add "Intl" name
  • runtime/IntlObject.cpp: Added.

(JSC::IntlObject::IntlObject):
(JSC::IntlObject::create):
(JSC::IntlObject::finishCreation):
(JSC::IntlObject::createStructure):

  • runtime/IntlObject.h: Added.
  • runtime/JSGlobalObject.cpp: Add global Intl

(JSC::JSGlobalObject::init):

Source/WebCore:

Test: js/intl.html

  • Configurations/FeatureDefines.xcconfig: add ENABLE_INTL flag

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: add ENABLE_INTL flag

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig: add ENABLE_INTL flag

Source/WTF:

  • wtf/FeatureDefines.h: add ENABLE_INTL flag

Tools:

  • Scripts/webkitperl/FeatureList.pm: add ENABLE_INTL flag

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.props: add ENABLE_INTL flag
  • win/tools/vsprops/FeatureDefinesCairo.props: add ENABLE_INTL flag

LayoutTests:

  • TestExpectations: Skip intl until enabled
  • js/intl-expected.txt: Added.
  • js/intl.html: Added.
  • js/script-tests/intl.js: Added.

(global):

6:51 PM Changeset in webkit [186160] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

scroll-snap-points do not work very well with mechanical scroll wheel events
​https://bugs.webkit.org/show_bug.cgi?id=142501
<rdar://problem/20093511>

Patch by Wenson Hsieh <​whsieh@berkeley.edu> on 2015-06-30
Reviewed by Brent Fulgham.

Source/WebCore:

Stateless scroll events generated by scrolling with a mechanical mouse wheel now trigger scroll
snapping after a fixed delay.

Test: platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-stateless.html

  • platform/cocoa/ScrollController.h: Added member to track stateless scrolling.
  • platform/cocoa/ScrollController.mm: Added constant for delay for stateless scroll snapping.

(WebCore::ScrollController::processWheelEventForScrollSnapOnAxis): Triggers timer upon stateless scroll events.
(WebCore::ScrollController::horizontalScrollSnapTimerFired): Timer now handles stateless scrolling updates.
(WebCore::ScrollController::verticalScrollSnapTimerFired): See above.
(WebCore::ScrollController::beginScrollSnapAnimation): Handles stateless scroll snapping.

LayoutTests:

  • platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-stateless-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-stateless.html: Added.
6:46 PM Changeset in webkit [186159] by Simon Fraser
  • 5 edits in trunk/Source

Fix Mac and Windows builds.

Source/WebKit/win:

  • WebCoreSupport/AcceleratedCompositingContext.cpp:

(AcceleratedCompositingContext::flushPendingLayerChanges):

  • WebView.cpp:

(WebView::flushPendingGraphicsLayerChanges):

Source/WebKit2:

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

6:33 PM Changeset in webkit [186158] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.37.1.2/Source

Versioning.

6:30 PM Changeset in webkit [186157] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.37.1.2

New tag.

6:15 PM Changeset in webkit [186156] by Simon Fraser
  • 6 edits in trunk/Source/WebCore

Try to fix Gtk and EFL builds.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::flushCompositingState):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:

(WebCore::CompositingCoordinator::flushPendingLayerChanges):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
6:08 PM Changeset in webkit [186155] by Simon Fraser
  • 10 edits in trunk/Source

[iOS] Missing tiles inside position:fixed on scrolling
​https://bugs.webkit.org/show_bug.cgi?id=146485
rdar://problem/21226861

Reviewed by Tim Horton.

Layer flushing adjusts the coverage rect for tiled layers, but does so at times
when position:fixed layers are moved around by the scrolling tree. The computed
coverage rect then doesn't reflect the layer's on-screen position, causing missing
tiles.

Fix by pushing the notion of being in a "stable state" onto FrameView, and passing
that state into the layer flush. When not in a stable state, flushing doesn't change
the visible and coverage rects for layers that are viewport-constrained.

Source/WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::reset):

  • page/FrameView.h: Remove some velocity-related data members that were unused.
  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::flushCompositingState):
(WebCore::GraphicsLayer::flushCompositingStateForThisLayerOnly):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::flushCompositingState):
(WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerCA::setVisibleAndCoverageRects): If this is a viewport-constrained
layer, and the viewport is not stable, don't touch the rects.
(WebCore::GraphicsLayerCA::recursiveCommitChanges):

  • platform/graphics/ca/GraphicsLayerCA.h:

(WebCore::GraphicsLayerCA::CommitState::CommitState):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

Source/WebKit2:

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateVisibleContentRects):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):

6:01 PM Changeset in webkit [186154] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Rename GraphicsLayer's allowsBackingStoreDetachment to isViewportConstrained
​https://bugs.webkit.org/show_bug.cgi?id=146483

Reviewed by Tim Horton.

What GraphicsLayer really needs to know is whether some other thread/process
is moving its platform layers around behind its back, and this is is better
expressed as "isViewportConstrained" rather than "allowsBackingStoreDetachment".

The sense of the flag is flipped, and boolean logic adjusted accordingly.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setIsViewportConstrained):
(WebCore::GraphicsLayer::isViewportConstrained):
(WebCore::GraphicsLayer::setAllowsBackingStoreDetachment): Deleted.
(WebCore::GraphicsLayer::allowsBackingStoreDetachment): Deleted.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::setVisibleAndCoverageRects):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::setIsScrollCoordinatedWithViewportConstrainedRole):

5:46 PM Changeset in webkit [186153] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[EFL] Implement ewk_favicon_database_clear() API.
​https://bugs.webkit.org/show_bug.cgi?id=146337

Patch by Hyungwook Lee <​hyungwook.lee@navercorp.com> on 2015-06-30
Reviewed by Gyuyoung Kim.

We need to provide way to clear favicon data.

  • UIProcess/API/efl/ewk_favicon_database.cpp:

(EwkFaviconDatabase::getIconSurfaceSynchronously):
(EwkFaviconDatabase::clearFaviconDatabase):
(EwkFaviconDatabase::iconDataReadyForPageURL):
(ewk_favicon_database_icon_change_callback_del):
(ewk_favicon_database_clear):

  • UIProcess/API/efl/ewk_favicon_database.h:
  • UIProcess/API/efl/ewk_favicon_database_private.h:
  • UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:

(TEST_F):

5:39 PM Changeset in webkit [186152] by akling@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] Ignore viewport rect changes during zoom bouncing.
<​https://webkit.org/b/146480>

Reviewed by Benjamin Poulain.

When the user has pinch-zoomed past the maximum zoom scale and lets go of the screen,
we animate a bounce back to the maximum scale.

Suppress viewport rect updates during this bounce animation since we don't need them
anyway. This fixes an issue where we'd sometimes get a weird rect during the animation
and if could send that to the web process, causing it to generate tiles for a part of
the page that's not actually exposed.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _updateVisibleContentRects]):

5:36 PM Changeset in webkit [186151] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Errors in read() are not handled in WTF::cryptographicallyRandomValuesFromOS.
​https://bugs.webkit.org/show_bug.cgi?id=146473

Patch by Keith Miller <​keith_miller@apple.com> on 2015-06-30
Reviewed by Filip Pizlo.

We were not checking if errors occurred in WTF::cryptographicallyRandomValuesFromOS.
We now buffer the data until enough bits of entropy exist to fill the buffer
rather than crash. Additionally, added two crash functions so we can distinguish
between the two reasons why we crashed in traces.

  • wtf/OSRandomSource.cpp:

(WTF::crashUnableToOpenFD):
(WTF::crashUnableToReadFromFD):
(WTF::cryptographicallyRandomValuesFromOS):

5:17 PM Changeset in webkit [186150] by Chris Dumez
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, rebaseline editing/style/unbold-in-bold.html on WK2.

  • platform/mac-wk2/editing/style/unbold-in-bold-expected.txt: Added.
5:16 PM Changeset in webkit [186149] by Chris Dumez
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed, revert bad wk2 baseline done in r186106.

  • platform/mac-wk2/editing/style: Removed.
5:08 PM Changeset in webkit [186148] by enrica@apple.com
  • 6 edits in trunk/Source/WebKit2

<rdar://problem/20655729> WebKit should heuristically exclude scrolling touch events from the user gesture category

Reviewed by Benjamin Poulain.

  • Platform/spi/ios/UIKitSPI.h:
  • Shared/WebEvent.h:

(WebKit::WebTouchEvent::WebTouchEvent):
(WebKit::WebTouchEvent::position):
(WebKit::WebTouchEvent::isPotentialTap):
(WebKit::WebTouchEvent::isGesture):
(WebKit::WebTouchEvent::gestureScale):
(WebKit::WebTouchEvent::gestureRotation):

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent):

  • Shared/ios/NativeWebTouchEventIOS.mm:

(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):

  • Shared/ios/WebTouchEventIOS.cpp:

(WebKit::WebTouchEvent::encode):
(WebKit::WebTouchEvent::decode):
Pipe isPotentialTap through.

4:33 PM Changeset in webkit [186147] by bshafiei@apple.com
  • 5 edits
    1 copy
    1 delete in tags/Safari-601.1.37.0.1/Source/WebKit2

Roll out r185936. rdar://problem/21597179

4:30 PM Changeset in webkit [186146] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.37.0.1/Source

Roll out r185939. rdar://problem/21597179

4:27 PM Changeset in webkit [186145] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.37.0.1/Source/WebCore

Roll out r185951. rdar://problem/21597179

4:15 PM Changeset in webkit [186144] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.37.0.1/Source

Versioning.

4:10 PM Changeset in webkit [186143] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.37.0.1

New tag.

3:58 PM Changeset in webkit [186142] by fpizlo@apple.com
  • 3 edits in trunk/PerformanceTests

Update the JetStream documentation to reflect the recent changes
​https://bugs.webkit.org/show_bug.cgi?id=146474

Reviewed by Geoffrey Garen.

  • JetStream/create.rb: Bump the version.
  • JetStream/in-depth-TEMPLATE.html: Add cdjs documentation. Remove cordic documentation. Change documentation for splay and mandreel.
3:58 PM Changeset in webkit [186141] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: ProfileNode cleanup
​https://bugs.webkit.org/show_bug.cgi?id=146472

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-30
Reviewed by Timothy Hatcher.

  • UserInterface/Models/ProfileNode.js:

(WebInspector.ProfileNode):
Use Array.prototype.every instead of reduce.
Correct the name of a function to be what callers expect!

3:51 PM Changeset in webkit [186140] by clopez@igalia.com
  • 3 edits in trunk/Source/WebKit2

[GTK] [EFL] Unreviewed build fix after r186118.

Add if PLATFORM(COCOA) back.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::nonVisibleProcessCleanupTimerFired):

  • WebProcess/WebProcess.h:
3:21 PM Changeset in webkit [186139] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

CABackdropFilter should set windowServerAware to false
​https://bugs.webkit.org/show_bug.cgi?id=146469
<rdar://problem/21618614>

Reviewed by Simon Fraser.

  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(PlatformCALayerCocoa::PlatformCALayerCocoa): Set windowServerAware
to false on Mac (it's not available on iOS).

3:20 PM Changeset in webkit [186138] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: iOS 8: Profile Nodes not showing in JavaScript Timeline
​https://bugs.webkit.org/show_bug.cgi?id=146471

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-30
Reviewed by Brian Burg.

  • UserInterface/Models/ScriptTimelineRecord.js:

(WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload.profileNodeCallFromPayload):
For legacy backends, convert the startTime to the proper timestamp type.

3:19 PM Changeset in webkit [186137] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Rolling out r175171
​https://bugs.webkit.org/show_bug.cgi?id=146470
<rdar://problem/21349934>

Unreviewed, rolling out <​http://trac.webkit.org/changeset/175171>. It
wasn't a huge win and Brady says it caused crash at
<rdar://problem/21349934>.

  • platform/network/cf/ResourceRequest.h:
  • platform/network/cocoa/ResourceRequestCocoa.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):

3:19 PM Changeset in webkit [186136] by basile_clement@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Allow object allocation sinking through GetScope, GetExecutable and SkipScope nodes
​https://bugs.webkit.org/show_bug.cgi?id=146431

Reviewed by Filip Pizlo.

  • dfg/DFGNode.h:

(JSC::DFG::Node::isFunctionAllocation):
(JSC::DFG::Node::isPhantomFunctionAllocation):

  • dfg/DFGObjectAllocationSinkingPhase.cpp:

(JSC::DFG::ObjectAllocationSinkingPhase::handleNode):

  • dfg/DFGPromoteHeapAccess.h:

(JSC::DFG::promoteHeapAccess):

3:16 PM Changeset in webkit [186135] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, revert bad WK1 rebaseline done in r186106.

  • platform/mac/editing/style/unbold-in-bold-expected.txt:
3:00 PM Changeset in webkit [186134] by Simon Fraser
  • 4 edits in trunk/Source

Crash under _layoutForNodeHighlight: when inspecting espn.com
​https://bugs.webkit.org/show_bug.cgi?id=146422

Reviewed by Joseph Pecoraro.
Source/WebKit/mac:

When inspecting espn.com, MobileSafari sometimes crashes, because
highlight.quads is empty. I was not able to quickly determine why.

Fix by bailing in this case.

  • WebInspector/WebNodeHighlightView.mm:

(-[WebNodeHighlightView _layoutForNodeHighlight:parent:]):

Source/WebKit2:

When inspecting espn.com, MobileSafari sometimes crashes, because
highlight.quads is empty. I was not able to quickly determine why.

Fix by bailing in this case.

  • UIProcess/WKInspectorHighlightView.mm:

(-[WKInspectorHighlightView _layoutForNodeHighlight:]):

2:45 PM Changeset in webkit [186133] by Matt Baker
  • 24 edits
    1 add in trunk/Source

Web Inspector: Reduce rendering frames "Other" time by instrumenting compositing
​https://bugs.webkit.org/show_bug.cgi?id=146168

Reviewed by Brian Burg.

Source/JavaScriptCore:

  • inspector/protocol/Timeline.json:

New timeline record type for compositing events.

Source/WebCore:

Added Inspector instrumentation for measuring CoreAnimation compositing time. We mark the start of a composite
event when the LayerFlushScheduler triggers a scheduled layer flush. InspectorController now exports a function
for marking the end of the composite event, which should be called during the CA transaction post-commit phase
(based on platform support). Lacking platform support, the event is considered complete after CoreAnimation
runloop observers have run.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::didComposite):

  • inspector/InspectorController.h:

New export for instrumentation in WebKit2.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willCompositeImpl):
(WebCore::InspectorInstrumentation::didCompositeImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willComposite):
(WebCore::InspectorInstrumentation::didComposite):
Plumbing for new instrumentation.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::internalStop):
(WebCore::InspectorTimelineAgent::willComposite):
(WebCore::InspectorTimelineAgent::didComposite):
(WebCore::toProtocol):

  • inspector/InspectorTimelineAgent.h:

New Composite event type and instrumentation.

  • page/FrameView.cpp:

(WebCore::FrameView::flushCompositingStateIncludingSubframes):
Hook for start of compositing.

  • platform/spi/cocoa/QuartzCoreSPI.h:

New header include and interface declaration.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype._processRecord):
Added handling for new Composite record type. Paint records with a parent Composite record
are flagged to simplify processing after the event hierarchy is unpacked.

  • UserInterface/Images/TimelineRecordComposite.svg: Added.

New composite record icon.

  • UserInterface/Models/LayoutTimelineRecord.js:

(WebInspector.LayoutTimelineRecord):
(WebInspector.LayoutTimelineRecord.displayNameForEventType):
(WebInspector.LayoutTimelineRecord.prototype.get duringComposite): Added
Composite record support.

  • UserInterface/Models/RenderingFrameTimelineRecord.js:

(WebInspector.RenderingFrameTimelineRecord.prototype.durationForTask.get validRecordForTaskType):
Add compositing time when bucketing runloop tasks, ignoring Paint events that are
contained within a Composite event.

  • UserInterface/Views/LayoutTimelineOverviewGraph.js:

(WebInspector.LayoutTimelineOverviewGraph.prototype._layoutTimelineRecordAdded):
Add Composite records to paint timeline row.

  • UserInterface/Views/RenderingFrameTimelineView.js:

(WebInspector.RenderingFrameTimelineView.prototype._processPendingRecords):
Small unrelated fix.

  • UserInterface/Views/TimelineIcons.css:

(.composite-record .icon):

  • UserInterface/Views/TimelineRecordBar.css:

(.timeline-record-bar.timeline-record-type-layout.layout-timeline-record-composite > .segment):

  • UserInterface/Views/TimelineRecordTreeElement.js:

(WebInspector.TimelineRecordTreeElement):
New styles and tree element icon.

Source/WebKit2:

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
Added CA transaction post-commit handlers to instrument end of composite.

2:40 PM Changeset in webkit [186132] by Beth Dakin
  • 4 edits in trunk/Source

The bounds on InteractionInformationAtPosition should be more precise
​https://bugs.webkit.org/show_bug.cgi?id=146468
-and corresponding-
rdar://problem/20739834

Reviewed by Enrica Casucci and Simon Fraser.

Source/WebCore:

Export absoluteContentQuad().

  • rendering/RenderBox.h:

Source/WebKit2:

For links, get the TextQuads from the Range, and for images, look at the
absoluteContentQuad(). All other items can continue to use absoluteBoundingBox.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation):

2:37 PM Changeset in webkit [186131] by Jon Davis
  • 2 edits in trunk/Tools

Added myself, Jonathan Davis, as a committer.

2:01 PM Changeset in webkit [186130] by Jon Davis
  • 2 edits in trunk/Websites/webkit.org

Added WebKit feature status page to navigation.

1:31 PM Changeset in webkit [186129] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Addressing post-review comments in r185756.

  • html/RubyTextElement.cpp:

(WebCore::RubyTextElement::createElementRenderer):

1:03 PM Changeset in webkit [186128] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Addressing post-review comments in r185916

  • platform/LayoutUnit.h:

(WebCore::roundToDevicePixel):

12:53 PM Changeset in webkit [186127] by mrajca@apple.com
  • 2 edits in trunk/Source/WebCore

MediaSession: Use setSessionInternal to set the default media session in HTMLMediaElement's constructor
​https://bugs.webkit.org/show_bug.cgi?id=146465

Reviewed by Eric Carlson.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):

12:48 PM Changeset in webkit [186126] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Disable Spintracer when getting the list of plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=146467
rdar://problem/21616640

Reviewed by Tim Horton.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::populatePluginCache):

12:12 PM Changeset in webkit [186125] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Java Plugin cannot launch JavaUpdater.app after renaming
​https://bugs.webkit.org/show_bug.cgi?id=146464
rdar://problem/19747153

Reviewed by Tim Horton.

Check for both "JavaUpdater.app" and "Java Updater.app".

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::isJavaUpdaterURL):

11:26 AM Changeset in webkit [186124] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit/mac

Remove the WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS ifdefs now that this is always true
​https://bugs.webkit.org/show_bug.cgi?id=146462

Reviewed by Dan Bernstein.

  • Misc/WebDownload.h:
  • WebView/WebFrameLoadDelegate.h:
  • WebView/WebPolicyDelegate.h:
  • WebView/WebResourceLoadDelegate.h:
  • WebView/WebUIDelegate.h:
  • WebView/WebView.h:
  • postprocess-headers.sh:
11:10 AM Changeset in webkit [186123] by mrajca@apple.com
  • 5 edits in trunk/Source/WebCore

Media Session: implement algorithm for updating a media element's session (6.1)
​https://bugs.webkit.org/show_bug.cgi?id=146460

Reviewed by Darin Adler.

In addition to storing a pointer to the new media session, we now:

  • pause the media element if it is 'active' in the current media session
  • remove the media element from the current media session
  • release the current media session if there are no more active media elements
  • set the default media session if the new media session is null
  • update the 'kind' attribute to match the kind of the new media session
  • Modules/mediasession/MediaSession.cpp:

(WebCore::MediaSession::isMediaElementActive):
(WebCore::MediaSession::hasActiveMediaElements):

  • Modules/mediasession/MediaSession.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setSession):
(WebCore::HTMLMediaElement::setSessionInternal):

  • html/HTMLMediaElement.h:
11:08 AM Changeset in webkit [186122] by Chris Dumez
  • 3 edits in trunk/Source/WebKit2

[WK2] Avoid taking a useless / blank navigation snapshot when navigating after restoring sessionState
​https://bugs.webkit.org/show_bug.cgi?id=146446
<rdar://problem/21584231>

Reviewed by Darin Adler.

We currently take a useless / blank navigation snapshot when navigating
after restoring the back / forward list from a sessionState object.
This is because we get a current HistoryItem from the sessionState
which we have never really navigated to. We then take a navigation
snapshot for the current HistoryItem when navigating away as we usually
do. However, in this case, the HistoryItem was imported and there is
nothing to snapshot.

Taking this snapshot is not only wasteful, it can also potentially
overwrite the snapshot that was set by the client using
WKWebView._saveBackForwardSnapshotForItem() SPI.

To address the problem, this patch suppresses navigation snapshotting
after restoring the back / forward list from a session state and until
the next load is committed.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::recordNavigationSnapshot):
(WebKit::WebPageProxy::restoreFromSessionState):
(WebKit::WebPageProxy::didCommitLoadForFrame):

  • UIProcess/WebPageProxy.h:
10:32 AM Changeset in webkit [186121] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit/win

[Win] webViewAddMessageToConsole always gets 1 for isError
​https://bugs.webkit.org/show_bug.cgi?id=146457
<rdar://problem/21606395>

Reviewed by Zalan Bujtas.

  • WebCoreSupport/WebChromeClient.cpp:

(messageIsError): Added.
(WebChromeClient::addMessageToConsole): Only pass true for
isError if the message is an error message.

10:20 AM Changeset in webkit [186120] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: iOS 8: Uncaught Exception expanding Object Prototype
​https://bugs.webkit.org/show_bug.cgi?id=146427

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-30
Reviewed by Timothy Hatcher.

  • UserInterface/Views/ObjectTreePropertyTreeElement.js:

(WebInspector.ObjectTreePropertyTreeElement.prototype._updateProperties):

  • UserInterface/Views/ObjectTreeView.js:

(WebInspector.ObjectTreeView.prototype._updateProperties):
We are supposed to receive value properties for proto properties
so that we can immediately start showing information about the property.
When that is not the case, which appeared to only be on legacy
backends for the top level prototype, just ignore it.

10:16 AM Changeset in webkit [186119] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Misc. Timeline cleanup
​https://bugs.webkit.org/show_bug.cgi?id=146430

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-30
Reviewed by Timothy Hatcher.

  • UserInterface/Models/Timeline.js:

(WebInspector.Timeline.prototype.reset):
Nobody listens for this event. Just remove it.

  • UserInterface/Models/TimelineRecording.js:

Avoiding doing multiple lookups.

  • UserInterface/Views/TimelineDataGridNode.js:
  • UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype._updateTimes):

  • UserInterface/Views/TimelineView.js:

(WebInspector.TimelineView.prototype.updateLayout):
Eliminate some unnecessary deletes.

10:12 AM Changeset in webkit [186118] by andersca@apple.com
  • 13 edits in trunk/Source

Get rid of unused WKSI functions
​https://bugs.webkit.org/show_bug.cgi?id=146443

Reviewed by Tim Horton.

Source/WebCore:

  • platform/graphics/cg/PathCG.cpp:

(WebCore::Path::platformAddPathForRoundedRect):
Just call CGPathAddRoundedRect directly.

  • platform/ios/WebCoreSystemInterfaceIOS.mm:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Deleted.

Source/WebKit2:

  • UIProcess/API/Cocoa/WKWebView.mm:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Deleted.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::nonVisibleProcessCleanupTimerFired):

  • WebProcess/WebProcess.h:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::destroyRenderingResources):

9:39 AM Changeset in webkit [186117] by Brent Fulgham
  • 2 edits in trunk/Tools

Unreviewed build fix.

  • Scripts/update-webkit-dependency: Try to build even if we cannot connect

to developer.apple.com to get update libraries.

9:31 AM Changeset in webkit [186116] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.37.1.1/Source

Versioning.

9:27 AM Changeset in webkit [186115] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.37.1.1

New tag.

4:26 AM Changeset in webkit [186114] by peavo@outlook.com
  • 3 edits in trunk/Source/WebKit/win

[WinCairo] Compile error, WebEditorClient::didApplyStyle() should not have any parameters.
​https://bugs.webkit.org/show_bug.cgi?id=146450

Reviewed by Csaba Osztrogonác.

  • WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::shouldApplyStyle):
(WebEditorClient::didApplyStyle):

  • WebCoreSupport/WebEditorClient.h:
2:53 AM Changeset in webkit [186113] by calvaris@igalia.com
  • 4 edits in trunk

[Streams API] Finish pulling must always be done asynchronously as it is the expected promise behavior (according to the spec)
​https://bugs.webkit.org/show_bug.cgi?id=146408

Reviewed by Darin Adler.

Source/WebCore:

Current tests cover the case already.

  • Modules/streams/ReadableStream.cpp:

(WebCore::ReadableStream::pull): Call finishPull() in a postTask to delay it and simulate the promise
resolution.

LayoutTests:

  • streams/reference-implementation/readable-stream-expected.txt: Updated expectation to PASS
2:27 AM Changeset in webkit [186112] by calvaris@igalia.com
  • 5 edits in trunk

[Streams API] Synced bad strategy test with reference implementation
​https://bugs.webkit.org/show_bug.cgi?id=146411

Reviewed by Darin Adler.

Source/WebCore:

Current tests cover the case.

  • bindings/js/ReadableJSStream.cpp:

(WebCore::ReadableJSStream::retrieveChunkSize): Check for negative size then running the JavaScript function.

LayoutTests:

  • streams/reference-implementation/bad-strategies-expected.txt:
  • streams/reference-implementation/bad-strategies.html: There are three tests that are merged into one and a

fourth check is added. Updated expectations accordingly.

12:50 AM Changeset in webkit [186111] by youenn.fablet@crf.canon.fr
  • 6 edits in trunk/Source/WebCore

[Streams API] Remove ReadableStream.getReader() custom binding
​https://bugs.webkit.org/show_bug.cgi?id=146404

Reviewed by Darin Adler.

Covered by existing tests.

  • Modules/streams/ReadableStream.cpp:

(WebCore::ReadableStream::getReader): Updated to take an exception.

  • Modules/streams/ReadableStream.h:
  • Modules/streams/ReadableStream.idl: Updated to remove custom binding.
  • bindings/js/JSReadableStreamCustom.cpp:

(WebCore::JSReadableStream::getReader): Deleted.

  • bindings/js/JSReadableStreamReaderCustom.cpp:

(WebCore::constructJSReadableStreamReader): Updated to pass an exception to getReader.

12:17 AM Changeset in webkit [186110] by Philippe Normand
  • 2 edits in trunk

[CMake] Error when gst-plugins-base is missing is too confusing
​https://bugs.webkit.org/show_bug.cgi?id=145682

Reviewed by Carlos Garcia Campos.

  • Source/cmake/OptionsGTK.cmake: Error out if the required

GStreamer libraries are not found on the host.

Note: See TracTimeline for information about the timeline view.