Context Navigation

Reviewed by Sam Weinig.

This simplifies the WatchpointSet API by making it so that when Watchpoint::fire() is
called, the Watchpoint is no longer in the set. This means that you don't have to remember
to remove it from the set's list (currently we do that implicitly as part of whatever
any particular Watchpoint::fireInternal() does), and you can now write adaptive
watchpoints that re-add themselves to a different set if they determine that the thing
they are actually watching is still intact but now needs to be watched in a different way
(like watching for whether some singleton object has a property of some name).

bytecode/Watchpoint.cpp:

(JSC::Watchpoint::~Watchpoint): Add a comment about why this is necessary.
(JSC::Watchpoint::fire): Make this out-of-line, private, and make it assert that we're no longer on the list.
(JSC::WatchpointSet::fireAllWatchpoints): Make this remove the watchpoint from the list before firing it.

bytecode/Watchpoint.h:

(JSC::Watchpoint::fire): Deleted. I moved this to Watchpoint.cpp.

6:39 PM Changeset in webkit [186744] by ddkilzer@apple.com

10 edits
2 adds in branches/safari-600.1.4.17-branch

Merge r184434, and a small part of r173173. rdar://problem/21716506

6:39 PM Changeset in webkit [186743] by ddkilzer@apple.com

4 edits
1 add in branches/safari-600.1.4.17-branch/Tools

Make run-webkit-tests work with iOS Simulator

Merge r179788, r179793.

3:09 PM Changeset in webkit [186742] by ddkilzer@apple.com

2 edits in branches/safari-600.1.4.17-branch/Source/WebKit2

Merge r184991. rdar://problem/21716545

12:41 PM Changeset in webkit [186741] by Chris Fleizach

3 edits
2 adds in trunk

AX: WEB: VoiceOver for iOS does not read <iframe> elements during linear (swipe) navigation.
https://bugs.webkit.org/show_bug.cgi?id=146861

Reviewed by Darin Adler.

Source/WebCore:

AttachmentViews exist only on WK1 so we need account for both platforms.

Test: platform/ios-simulator/accessibility/iframe-access.html

accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):

LayoutTests:

platform/ios-simulator/accessibility/iframe-access-expected.txt: Added.
platform/ios-simulator/accessibility/iframe-access.html: Added.

9:28 AM Changeset in webkit [186740] by youenn.fablet@crf.canon.fr

5 edits in trunk/Source/WebCore

[Streams API] Templating ReadableJSStream
https://bugs.webkit.org/show_bug.cgi?id=146802

Reviewed by Darin Adler.

Introducing ReadableStream::clearValues to clear queued values when cancelling and going into error state.

Introducing ReadableEnqueuingStream to handle the stream queue, as a class template.
Specialized ReadableEnqueuingStream for the purpose of ReadableJSStream (storage of JSValue with variable size).

Updated some static functions to accept a ReadableStream in lieu of the more specialized ReadableJSStream.

Covered by existing tests.

Modules/streams/ReadableStream.cpp:

(WebCore::ReadableStream::changeStateToErrored):
(WebCore::ReadableStream::cancelNoCheck):

Modules/streams/ReadableStream.h:

(WebCore::ReadableEnqueuingStream::ReadableEnqueuingStream):
(WebCore::ReadableEnqueuingStream::enqueueChunk):
(WebCore::ReadableEnqueuingStream<ChunkType>::read):

bindings/js/ReadableJSStream.cpp:

(WebCore::ReadableEnqueuingStream<ReadableJSStreamValue>::read):
(WebCore::ReadableEnqueuingStream<ReadableJSStreamValue>::enqueueChunk):
(WebCore::createPullResultFulfilledFunction):
(WebCore::createCancelResultFulfilledFunction):
(WebCore::ReadableJSStream::ReadableJSStream):
(WebCore::ReadableJSStream::enqueue):

bindings/js/ReadableJSStream.h:

(WebCore::ReadableJSStreamValue::create):
(WebCore::ReadableEnqueuingStream<ReadableJSStreamValue>::desiredSize):
(WebCore::ReadableEnqueuingStream<ReadableJSStreamValue>::ReadableEnqueuingStream):

7:46 AM Changeset in webkit [186739] by ddkilzer@apple.com

2 edits in branches/safari-600.8-branch/Source/WebKit2

Merge r184991. rdar://problem/21716403

12:36 AM Changeset in webkit [186738] by bshafiei@apple.com

5 edits in branches/safari-601.1-branch/Source

Versioning.

12:33 AM Changeset in webkit [186737] by bshafiei@apple.com

5 edits in tags/Safari-601.1.39.1/Source

Versioning.

12:32 AM Changeset in webkit [186736] by bshafiei@apple.com

1 copy in tags/Safari-601.1.39.1

New tag.

12:29 AM Changeset in webkit [186735] by bshafiei@apple.com

2 edits in branches/safari-601.1-branch/Source/WTF

Merged r186720. rdar://problem/21221902

12:28 AM Changeset in webkit [186734] by bshafiei@apple.com

9 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r186719. rdar://problem/21221902

12:26 AM Changeset in webkit [186733] by bshafiei@apple.com

11 edits
1 copy
1 delete in branches/safari-601.1-branch/Source

Merged r186718. rdar://problem/21221902

12:23 AM Changeset in webkit [186732] by bshafiei@apple.com

2 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r186716. rdar://problem/21507154

12:22 AM Changeset in webkit [186731] by bshafiei@apple.com

2 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r186713. rdar://problem/21507154

12:15 AM Changeset in webkit [186730] by bshafiei@apple.com

2 edits in branches/safari-601.1-branch/Source/WebCore

Merged r186727.

12:06 AM Changeset in webkit [186729] by bshafiei@apple.com

2 edits in tags/Safari-601.1.39.0.1/Source/WebCore

Merged r186727.

Jul 11, 2015:

11:43 PM Changeset in webkit [186728] by Gyuyoung Kim

2 edits in trunk/LayoutTests

[EFL] Unreviewed, EFL gardening on 12th Jul.

Mark some ax tests and editing tests to failure since r186694 and r185692.

platform/efl/TestExpectations:

10:37 PM Changeset in webkit [186727] by bshafiei@apple.com

2 edits in trunk/Source/WebCore

Unreviewed build fix.

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::load):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cancelLoad):

9:28 PM Changeset in webkit [186726] by bshafiei@apple.com

5 edits in tags/Safari-601.1.39.0.1/Source

Versioning.

9:24 PM Changeset in webkit [186725] by bshafiei@apple.com

1 copy in tags/Safari-601.1.39.0.1

New tag.

9:23 PM Changeset in webkit [186724] by Nikita Vasilyev

10 edits in trunk/Source

Web Inspector: Inspector should be able to be docked to the bottom of a narrow window
https://bugs.webkit.org/show_bug.cgi?id=146871

Reviewed by Timothy Hatcher.

Source/WebCore:

inspector/InspectorFrontendClientLocal.cpp:

Source/WebInspectorUI:

UserInterface/Views/Toolbar.css:

(@media (max-width: 539px)): Hide download button to fit search field into the screen.

Source/WebKit/mac:

WebCoreSupport/WebInspectorClient.mm:

Source/WebKit2:

UIProcess/WebInspectorProxy.cpp:
UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCanAttach):

WebProcess/WebPage/WebInspector.cpp:

9:14 PM Changeset in webkit [186723] by bshafiei@apple.com

5 edits in trunk/Source

Versioning.

8:58 PM Changeset in webkit [186722] by bshafiei@apple.com

1 copy in branches/safari-601.1-branch

New Branch.

7:59 PM Changeset in webkit [186721] by timothy@apple.com

1 edit
3 adds in trunk/Websites/webkit.org

Add some images for a blog post.

blog-files/inspector-elements-network-tabs.png: Added.
blog-files/inspector-tab-bar.png: Added.
blog-files/inspector-tab-icons.svg: Added.

6:54 PM Changeset in webkit [186720] by Joseph Pecoraro

2 edits in trunk/Source/WTF

Unreviewed build fix, restrict APP_LINKS to just iOS.

wtf/Platform.h:

5:51 PM WebKitGTK/Releasing edited by Martin Robinson

Warning that contents are out of date (diff)

3:58 PM Changeset in webkit [186719] by Joseph Pecoraro

9 edits in trunk/Source/WebKit2

Allow clients to opt-out of default app link link actions
https://bugs.webkit.org/show_bug.cgi?id=146883
<rdar://problem/21221902>

Reviewed by Dan Bernstein.

UIProcess/API/APIUIClient.h:

(API::UIClient::shouldIncludeAppLinkActionsForElement):

UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
UIProcess/Cocoa/UIDelegate.h:
UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::shouldIncludeAppLinkActionsForElement):
Plumbing for a new delegate message to ask the client if they
would like app link actions or not. Default is yes.

UIProcess/ios/WKActionSheetAssistant.h:
UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant showImageSheet]):
(-[WKActionSheetAssistant showLinkSheet]):
(-[WKActionSheetAssistant defaultActionsForLinkSheet:]):
(-[WKActionSheetAssistant defaultActionsForImageSheet:]):
Pass elementInfo into methods generating default actions.

(-[WKActionSheetAssistant _appendOpenActionsForURL:actions:elementInfo:]):
When generating open actions, if the process has AppLink capabilities
ask the client if they want to include AppLink actions or fall back
to the basic Open action.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView actionSheetAssistant:shouldIncludeAppLinkActionsForElement:]):
(-[WKContentView previewViewControllerForPosition:inSourceView:]):

UIProcess/ios/WKPDFView.mm:

(-[WKPDFView actionSheetAssistant:shouldIncludeAppLinkActionsForElement:]):
Assistant delegate implementations forward to the UIDelegate.

3:58 PM Changeset in webkit [186718] by Joseph Pecoraro

11 edits
1 move in trunk/Source

Update default link action sheets for app links
https://bugs.webkit.org/show_bug.cgi?id=146658
<rdar://problem/21221902>

Reviewed by Dan Bernstein.

Source/WebCore:

English.lproj/Localizable.strings:
platform/spi/ios/LaunchServicesSPI.h:

Source/WebKit2:

Shared/mac/SandboxUtilities.h:
Shared/mac/SandboxUtilities.mm: Renamed from Source/WebKit2/Shared/mac/SandboxUtilities.cpp.

(WebKit::processHasEntitlement):

UIProcess/ApplicationStateTracker.mm:

(WebKit::applicationType):
(WebKit::hasEntitlement): Deleted.

WebKit2.xcodeproj/project.pbxproj:

Share a helper for checking if the current process has an entitlement.

UIProcess/API/Cocoa/_WKElementAction.h:
UIProcess/API/Cocoa/_WKElementAction.mm:

(+[_WKElementAction _elementActionWithType:title:actionHandler:]):
(+[_WKElementAction _elementActionWithType:customTitle:assistant:]):

UIProcess/API/Cocoa/_WKElementActionInternal.h:

Add an internal way to make an element action with a standard type and regular handler.
We use this for the new standard types that don't have a default implementation.

UIProcess/ios/WKActionSheetAssistant.mm:

(applicationHasAppLinkEntitlements):
(appLinkForURL):
Helpers checking access to app links and fetching app links.

(-[WKActionSheetAssistant _appendOpenActionsForURL:actions:]):
(-[WKActionSheetAssistant defaultActionsForLinkSheet]):
(-[WKActionSheetAssistant defaultActionsForImageSheet]):
Create "Open in Safari" and "Open in 'App'" default actions for AppLinks,
otherwise add the normal default "Open" action.

3:29 PM Changeset in webkit [186717] by Devin Rousso

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Improve runtime of pseudo-element sidebar style ordering
https://bugs.webkit.org/show_bug.cgi?id=146866

Reviewed by Timothy Hatcher.

UserInterface/Models/CSSRule.js:

(WebInspector.CSSRule.prototype.update): Determines the most specific selector and saves it to a variable.
(WebInspector.CSSRule.prototype.get mostSpecificSelector): Returns the most specific selector.
(WebInspector.CSSRule.prototype.selectorIsGreater): Compares the most specific selector to a given selector.
(WebInspector.CSSRule.prototype._determineMostSpecificSelector):
Searches through the selector list to find and return the selector that is the most specific.
(WebInspector.CSSRule):

UserInterface/Views/RulesStyleDetailsPanel.js:

(WebInspector.RulesStyleDetailsPanel.prototype.refresh):

2:30 PM Changeset in webkit [186716] by enrica@apple.com

2 edits in trunk/Source/WebKit2

Remove incorrect overriding of inputAssistantItem in WKContentView.
https://bugs.webkit.org/show_bug.cgi?id=146863
rdar://problem/21507154

Reviewed by Sam Weinig.

Correction to the patch in r186713.
We need to provide the inputAssistantItem from the responder.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView inputAccessoryView]):

1:35 PM Changeset in webkit [186715] by benjamin@webkit.org

4 edits in trunk/Source/WebCore

Fix CONTENT_EXTENSIONS_STATE_MACHINE_DEBUGGING
https://bugs.webkit.org/show_bug.cgi?id=146879

Reviewed by Andreas Kling.

Some of my recent changes broke CONTENT_EXTENSIONS_STATE_MACHINE_DEBUGGING :(

contentextensions/CombinedURLFilters.cpp:

(WebCore::ContentExtensions::prefixTreeVertexToString):
(WebCore::ContentExtensions::recursivePrint):
(WebCore::ContentExtensions::CombinedURLFilters::print):

contentextensions/ContentExtensionsDebugging.h:
contentextensions/DFA.cpp:

(WebCore::ContentExtensions::DFA::debugPrintDot):

1:15 PM Changeset in webkit [186714] by Chris Dumez

5 edits in trunk

Unreviewed, rolling out r186689 and r186710.
https://bugs.webkit.org/show_bug.cgi?id=146880

May have caused a PLT regression and broken a layout test
(Requested by cdumez on #webkit).

Reverted changesets:

"[WK2] Increase the QoS of some of our WorkQueues to match the
one of our processes"
https://bugs.webkit.org/show_bug.cgi?id=146855
http://trac.webkit.org/changeset/186689

"REGRESSION (r186689?): fast/frames/frame-limit.html timeout
on Mavericks {Release,Debug} WK2 bots"
https://bugs.webkit.org/show_bug.cgi?id=146876
http://trac.webkit.org/changeset/186710

Patch by Commit Queue <commit-queue@webkit.org> on 2015-07-11

12:02 PM Changeset in webkit [186713] by enrica@apple.com

2 edits in trunk/Source/WebKit2

Remove incorrect overriding of inputAssistantItem in WKContentView.
https://bugs.webkit.org/show_bug.cgi?id=146863
rdar://problem/21507154

Reviewed by Dan Bernstein.

Removing implementation of inputAssistantItem and moving initialization
of formAccessoryView to inputAccessoryView to avoid interfering with
the keyboard handling of the assistant bar.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView inputAccessoryView]):
(-[WKContentView inputAssistantItem]): Deleted.
(-[WKContentView _inputAssistantItem]): Deleted.

11:19 AM Changeset in webkit [186712] by Simon Fraser

22 edits in trunk/Source

[iOS WK2] Scrolling issues on horizontally scrollable RTL pages
https://bugs.webkit.org/show_bug.cgi?id=146872
rdar://problem/7569416

Reviewed by Sam Weinig.

Horizontally scrollable RTL pages in WebKit2 had a variety of issues: they had
a gap down the right edge, and unreachable content on the left side, focussing
form fields scrolled to the wrong location, and programmatic scrolls scrolled
to the wrong place.

Fix by plumbing the WebCore notion of scrollOrigin through to the UI process,
and using it in various places. There are three main aspects to the patch:

scroll origin is included in RemoteLayerTreeTransaction, and plumbed through to -[WKWebView _scrollToContentOffset:] for correct programmatic scrolling,

Source/WebCore:

including zooming to focussed form elements.

WebPageProxy::computeCustomFixedPositionRect() uses the actual documentRect() rather than just conjuring up a rect with a zero origin, which makes position:fixed work correctly.
_interactionViewsContainerView (which hosts tap highlights) is positioned to coincide with the origin of the documentRect (i.e. at the scroll origin, which may not be top-left). This allows tap highlights to show in the correct location.
ScrollView::unobscuredContentRect() is fixed to take scroll origin into account; if the returned rect is wrong, RenderLayer::hitTest() incorrectly clips the hit testing area.

platform/ios/ScrollViewIOS.mm:

(WebCore::ScrollView::unobscuredContentRect):

Source/WebKit2:

including zooming to focused form elements. The WKContentView's boundsOrigin
is set to the scroll origin so that the view coordinates match document coordinates.

WebPageProxy::computeCustomFixedPositionRect() uses the actual documentRect() rather than just conjuring up a rect with a zero origin, which makes position:fixed work correctly.
_interactionViewsContainerView (which hosts tap highlights) is positioned to coincide with the origin of the documentRect (i.e. at the scroll origin, which may not be top-left). This allows tap highlights to show in the correct location.
ScrollView::unobscuredContentRect() is fixed to take scroll origin into account; if the returned rect is wrong, RenderLayer::hitTest() incorrectly clips the hit testing area.

Shared/mac/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::scrollOrigin):
(WebKit::RemoteLayerTreeTransaction::setScrollOrigin):

Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
(WebKit::RemoteLayerTreeTransaction::description): Dump some more info.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _scrollToContentOffset:scrollOrigin:]):
(-[WKWebView _scrollToContentOffset:]): Deleted.

UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::requestScroll):

UIProcess/API/gtk/PageClientImpl.h:
UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::requestScroll):

UIProcess/CoordinatedGraphics/WebView.h:
UIProcess/PageClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestScroll):

UIProcess/WebPageProxy.h:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::requestScroll):
(WebKit::PageClientImpl::documentRect):
(WebKit::PageClientImpl::contentsSize): Deleted.

UIProcess/ios/WKContentView.mm:

(-[WKContentView _didCommitLayerTree:]):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::computeCustomFixedPositionRect):

UIProcess/mac/PageClientImpl.h:
UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::requestScroll):

UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::willCommitLayerTree):

8:44 AM Changeset in webkit [186711] by ddkilzer@apple.com

2 edits in trunk/LayoutTests

http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html crashes on Windows

<http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2FXFrameOptions%2Fx-frame-options-deny-meta-tag-parent-same-origin-deny.html>

platform/win/TestExpectations: Mark tests as crashing:
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html

8:18 AM Changeset in webkit [186710] by ddkilzer@apple.com

2 edits in trunk/LayoutTests

REGRESSION (r186689?): fast/frames/frame-limit.html timeout on Mavericks {Release,Debug} WK2 bots

Fix tracked by: <http://webkit.org/b/146876>

platform/mac-wk2/TestExpectations: Mark test as timing out:
fast/frames/frame-limit.html

7:17 AM Changeset in webkit [186709] by ddkilzer@apple.com

3 edits in trunk/LayoutTests

REGRESSION (r186697): Fix Yosemite, El Capitan test results for js/dom/global-constructors-attributes.html

platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
platform/mac/js/dom/global-constructors-attributes-expected.txt:
Move MediaStream results into alphabetical order to fix test failures.

1:42 AM Changeset in webkit [186708] by Devin Rousso

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Warning icon tooltip for numbers with no units could be improved
https://bugs.webkit.org/show_bug.cgi?id=146859

Reviewed by Timothy Hatcher.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded):
If the property's value is incorrect and is comprised of only numbers, that must mean that the value needs
to have units (like "px") after the number. Added another warning icon case to support this scenario.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed