⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 13, 2015:

6:58 PM Changeset in webkit [186799] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Unreviewed build fix.

  • platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:

(WebCore::InbandTextTrackPrivateAVCF::readNativeSampleBuffer): Don't try to build
the new Legible Output API features if they aren't available in the build
environment.

6:11 PM Changeset in webkit [186798] by Brent Fulgham
  • 7 edits in trunk/Source/WebCore

[Win] Update Media Player logic for new Legible Output API
https://bugs.webkit.org/show_bug.cgi?id=146922
<rdar://problem/20542574>

Reviewed by Eric Carlson.

  • AVFoundationSupport.py: Check for updated AVFCF feature.
  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processNativeSamples): Update to call the
new 'readNativeSampleBuffer' method.
(WebCore::InbandTextTrackPrivateAVF::readNativeSampleBuffer): Added. This is a no-op
on Windows if it has the new AVCF API. Otherwise, it contains the same implementation
that has always been used in 'processNativeSamples'.

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
  • platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:

(WebCore::InbandTextTrackPrivateAVCF::readNativeSampleBuffer): Added. Use the new
Legible Output API instead of the old CoreMedia solution if it is available.

  • platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.h:

(WebCore::InbandTextTrackPrivateAVCF::mediaSelectionOption):

  • platform/graphics/avfoundation/cf/InbandTextTrackPrivateLegacyAVCF.cpp:

(WebCore::InbandTextTrackPrivateLegacyAVCF::readNativeSampleBuffer): Add a stub implementation.

  • platform/graphics/avfoundation/cf/InbandTextTrackPrivateLegacyAVCF.h:
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::createPlayerItem): Use the new Legible Output API if it is available.

5:10 PM Changeset in webkit [186797] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Fix a typo.

  • public/js/helper-classes.js:
4:53 PM Changeset in webkit [186796] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught exception in inspector for some ConsoleMessages
https://bugs.webkit.org/show_bug.cgi?id=146919

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-13
Reviewed by Brian Burg.

  • UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype._appendLocationLink):
The parameters list may not exist, so null check it before use.

4:27 PM Changeset in webkit [186795] by basile_clement@apple.com
  • 14 edits in trunk

Object cycles should not prevent allocation elimination/sinking
https://bugs.webkit.org/show_bug.cgi?id=143073

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This patch introduces a new allocation sinking phase that is able to
sink cycles, in DFGAllocationCycleSinkingPhase.cpp. This phase
supersedes the old allocation sinking phase in
DFGObjectAllocationSinkingPhase.cpp, as that previous phase was never
able to sink allocation cycles while the new phase sometimes can; see
DFGAllocationCycleSinkingPhase.cpp for details.

For now, the new sinking phase is kept behind a
JSC_enableAllocationCycleSinking flag that reverts to the old sinking
phase when false (i.e., by default). This also removes the old
JSC_enableObjectAllocationSinking flag. run-javascriptcore-tests
defaults to using the new sinking phase.

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::addStructureSet): Allow empty structure sets

  • dfg/DFGLazyNode.cpp:

(JSC::DFG::LazyNode::dump): Prettier dump

  • dfg/DFGNode.h:

(JSC::DFG::Node::cellOperand): Move to opInfo for MaterializeCreateActivation
(JSC::DFG::Node::hasStructureSet): Add MaterializeNewObject
(JSC::DFG::Node::objectMaterializationData): Move to opInfo2

  • dfg/DFGOSRAvailabilityAnalysisPhase.cpp: Remove unused header
  • dfg/DFGObjectAllocationSinkingPhase.cpp:

(JSC::DFG::ObjectAllocationSinkingPhase::ObjectAllocationSinkingPhase): Deleted.
(JSC::DFG::ObjectAllocationSinkingPhase::run): Deleted.
(JSC::DFG::ObjectAllocationSinkingPhase::performSinking): Deleted.
(JSC::DFG::ObjectAllocationSinkingPhase::determineMaterializationPoints): Deleted.
(JSC::DFG::ObjectAllocationSinkingPhase::placeMaterializationPoints): Deleted.
(JSC::DFG::ObjectAllocationSinkingPhase::lowerNonReadingOperationsOnPhantomAllocations): Deleted.
(JSC::DFG::ObjectAllocationSinkingPhase::promoteSunkenFields): Deleted.
(JSC::DFG::ObjectAllocationSinkingPhase::resolve): Deleted.
(JSC::DFG::ObjectAllocationSinkingPhase::handleNode): Deleted.
(JSC::DFG::ObjectAllocationSinkingPhase::createMaterialize): Deleted.
(JSC::DFG::ObjectAllocationSinkingPhase::populateMaterialize): Deleted.

  • dfg/DFGObjectAllocationSinkingPhase.h:
  • dfg/DFGPromotedHeapLocation.h: Add a hash and a helper function to PromotedLocationDescriptor

(JSC::DFG::PromotedLocationDescriptor::PromotedLocationDescriptor):
(JSC::DFG::PromotedLocationDescriptor::operator bool):
(JSC::DFG::PromotedLocationDescriptor::neededForMaterialization):
(JSC::DFG::PromotedLocationDescriptorHash::hash):
(JSC::DFG::PromotedLocationDescriptorHash::equal):

  • dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validateSSA): Assert that most nodes never see a phantom allocation

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileMaterializeNewObject): Use the new structureSet() operand
(JSC::FTL::DFG::LowerDFGToLLVM::compileMaterializeCreateActivation): Node has a new child

  • ftl/FTLOSRExitCompiler.cpp: Handle materialization cycles

(JSC::FTL::compileStub):

  • ftl/FTLOperations.cpp: Handle materialization cycles

(JSC::FTL::operationPopulateObjectInOSR):
(JSC::FTL::operationMaterializeObjectInOSR):

  • ftl/FTLOperations.h: Handle materialization cycles
  • tests/stress/correctly-sink-object-even-though-it-dies.js: Added.

(clobber):
(foo):

  • tests/stress/eliminate-object-read-over-call.js: Added.

(clobber):
(foo):

  • tests/stress/materialize-object-on-edge.js: Added.

(call):
(foo):

  • tests/stress/object-sinking-stress.js: Added.

(foo):

  • tests/stress/sink-object-cycle.js: Added.

(clobber):
(foo):

  • tests/stress/sink-object-past-put.js: Added.

(clobber):
(foo):

  • tests/stress/sinkable-new-object-in-loop.js: Added.

(foo):

LayoutTests:

Add a few microbenchmarks that show performance improvement when
sinking or elimininating object cycles.

  • js/regress/elidable-new-object-cycle-expected.txt: Added.
  • js/regress/elidable-new-object-cycle.html: Added.
  • js/regress/script-tests/elidable-new-object-cycle.js: Added.

(sumOfArithSeries):
(foo):

  • js/regress/script-tests/sinkable-closure-cycle.js: Added.

(factorial.f):
(factorial):

  • js/regress/script-tests/sinkable-new-object-cycle.js: Added.

(sumOfArithSeries):
(verify):
(foo):

  • js/regress/sinkable-closure-cycle-expected.txt: Added.
  • js/regress/sinkable-closure-cycle.html: Added.
  • js/regress/sinkable-new-object-cycle-expected.txt: Added.
  • js/regress/sinkable-new-object-cycle.html: Added.
4:11 PM Changeset in webkit [186794] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Cleanup: Avoid extraneous increment and decrement of reference count of ScriptArguments in ConsoleClient
https://bugs.webkit.org/show_bug.cgi?id=146920

Reviewed by Brian Burg.

Remove local variable RefPtr<ScriptArguments> and copy constructor call with an argument that
was initialized with an rvalue reference. The argument itself is an lvalue reference.

  • runtime/ConsoleClient.cpp:

(JSC::ConsoleClient::printConsoleMessageWithArguments):
(JSC::ConsoleClient::internalMessageWithTypeAndLevel):

4:06 PM Changeset in webkit [186793] by ddkilzer@apple.com
  • 6 edits
    12 adds in branches/safari-600.1.4.17-branch

Merge r186663. rdar://problem/21708241

4:00 PM Changeset in webkit [186792] by basile_clement@apple.com
  • 21 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Clean up register naming
https://bugs.webkit.org/show_bug.cgi?id=146849

Reviewed by Michael Saboff.

This changes register naming conventions in the llint and baseline JIT
in order to use as few (native) callee-save registers as possible on
64-bits platforms. It also introduces significant changes in the way
registers names are defined in the LLint and baseline JIT in order to
enable a simpler convention about which registers can be aliased that
is valid across all architecture, and described in
llint/LowLevelInterpreter.asm.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • jit/FPRInfo.h:

(JSC::FPRInfo::toRegister):
(JSC::FPRInfo::toIndex):

  • jit/GPRInfo.h:

(JSC::GPRInfo::toIndex):
(JSC::GPRInfo::toRegister):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_mod):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emitSlow_op_loop_hint):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_new_object):

  • jit/RegisterPreservationWrapperGenerator.cpp:

(JSC::generateRegisterPreservationWrapper):
(JSC::generateRegisterRestoration):

  • jit/ThunkGenerators.cpp:

(JSC::arityFixupGenerator):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/arm.rb:
  • offlineasm/arm64.rb:
  • offlineasm/cloop.rb:
  • offlineasm/mips.rb:
  • offlineasm/registers.rb:
  • offlineasm/sh4.rb:
  • offlineasm/x86.rb:
3:51 PM Changeset in webkit [186791] by mrajca@apple.com
  • 12 edits
    1 move in trunk/Source

Media Session: add plumbing for delivering start/end-of-interruption events
https://bugs.webkit.org/show_bug.cgi?id=146837

Reviewed by Tim Horton.

WebCore:

  • Modules/mediasession/MediaSessionEvents.h: Renamed from MediaEventTypes.h and added new constants for interruption events.
  • WebCore.xcodeproj/project.pbxproj: Renamed MediaEventTypes.h.
  • page/Page.h: Added stub.
  • page/Page.cpp: Added stub.

WebKit2: Added plumbing.

  • UIProcess/API/C/WKPage.cpp:

(WKPageHandleMediaSessionInterruptionEvent):

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleMediaSessionInterruptionEvent):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::handleMediaSessionInterruptionEvent):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
3:38 PM Changeset in webkit [186790] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.17-branch/LayoutTests

Merge r186542. rdar://problem/21708151

3:28 PM Changeset in webkit [186789] by bshafiei@apple.com
  • 4 edits in tags/Safari-601.1.40/Source

Merged r186777. rdar://problem/21789252

3:26 PM Changeset in webkit [186788] by bshafiei@apple.com
  • 4 edits in branches/safari-601.1-branch/Source

Merged r186777. rdar://problem/21789252

3:24 PM Changeset in webkit [186787] by bshafiei@apple.com
  • 4 edits in tags/Safari-601.1.39.2/Source

Merged r186777. rdar://problem/21789252

3:24 PM Changeset in webkit [186786] by Simon Fraser
  • 5 edits in trunk/Source

[iOS WK2] When choosing an initial viewport scale, take overflow on the <body> into account
https://bugs.webkit.org/show_bug.cgi?id=146918
rdar://problem/9222837

Reviewed by Tim Horton.

Use as input to the viewport scaling algorithm a contents size from the FrameView
that takes overflow on the viewport renderer into account. This prevents unexpected
viewports scaling on pages that have content that overflows their expressed contents size,
but apply overflow to the <body>.

Source/WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::contentsSizeRespectingOverflow): Look for overflow:hidden on each axis of
the m_viewportRenderer, which is computed post-layout by calculateScrollbarModesForLayout()
and is used for scrollbar logic on OS X. Clip unscaledDocumentRect on each axis, and then
apply page scale.

  • page/FrameView.h:

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mainFrameDidLayout): Use contentsSizeRespectingOverflow(),
rather than raw contentsSize(), to determine scaling.

3:16 PM Changeset in webkit [186785] by ddkilzer@apple.com
  • 6 edits in branches/safari-600.1.4.17-branch/Source/WebKit2

Merge r186531. rdar://problem/21708155

3:09 PM Changeset in webkit [186784] by fpizlo@apple.com
  • 2 edits in trunk/PerformanceTests

Update JetStream version number to 1.1.

Rubber stamped by Ryosuke Niwa.

  • JetStream/create.rb:
3:09 PM Changeset in webkit [186783] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.39.2/Source

Versioning.

3:05 PM Changeset in webkit [186782] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.39.2

New tag.

2:48 PM Changeset in webkit [186781] by ddkilzer@apple.com
  • 13 edits
    1 add in branches/safari-600.1.4.17-branch/Source

Merge r186530. rdar://problem/21708151

2:40 PM Changeset in webkit [186780] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Update WebCore Features.json
https://bugs.webkit.org/show_bug.cgi?id=146914

Reviewed by Benjamin Poulain.

  • features.json: Update with notes for CSS Scroll Snap Points, Filter Effects,

backdrop-filters, and initial-letter.

2:38 PM Changeset in webkit [186779] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed the build.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _registerPreviewInWindow:]):
(-[WKContentView _unregisterPreviewInWindow:]):

1:50 PM Changeset in webkit [186778] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

Removed now-unused SPI -[WKWebView _loadRequest:withOptions:].

Rubber-stamped by Anders Carlsson.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _loadRequest:withOptions:]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
1:44 PM Changeset in webkit [186777] by andersca@apple.com
  • 4 edits in trunk/Source

Apps linked with a deployment target of iOS 7.x or earlier crash when using modern WebKit API
https://bugs.webkit.org/show_bug.cgi?id=146913
rdar://problem/21789252

Reviewed by Dan Bernstein.

Source/JavaScriptCore:

Make a top-level symlink from /System/Library/PrivateFrameworks/JavaScriptCore.framework to
/System/Library/Frameworks/JavaScriptCore.framework.

Source/WebKit2:

Make a top-level symlink from /System/Library/PrivateFrameworks/WebKit.framework to
/System/Library/Frameworks/WebKit.framework.

  • WebKit2.xcodeproj/project.pbxproj:
1:10 PM Changeset in webkit [186776] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

If Watchpoint::fire() looks at the state of the world, it should definitely see its set invalidated, and maybe it should see the object of interest in the transitioned-to state
https://bugs.webkit.org/show_bug.cgi?id=146897

Reviewed by Mark Lam.

The idea is to eventually support adaptive watchpoints. An adaptive watchpoint will be
able to watch for a condition that is more fine-grained than any one watchpoint set. For
example, we might watch a singleton object to see if it ever acquires a property called
"foo". So long as it doesn't have such a property, we don't want to invalidate any code.
But if it gets that property, then we should deoptimize. Current watchpoints will
invalidate code as soon as any property is added (or deleted), because they will use the
transition watchpoint set of the singleton object's structure, and that fires anytime
there is any transition.

An adaptive watchpoint would remember the singleton object, and when it got fired, it
would check if the object's new structure has the property "foo". If not, it would check
if the object's new structure is watchable (i.e. has a valid transition watchpoint set).
If the property is missing and the structure is watchable, it would add itself to the
watchpoint set of the new structure. Otherwise, it would deoptimize.

There are two problems with this idea, and this patch fixes these problems. First, we
usually fire the transition watchpoint before we do the structure transition. This means
that if the fire() method looked at the singleton object's structure, it would see the old
structure, not the new one. It would have no way of knowing what the new structure is.
Second, inside the fire() method, the watchpoint set being invalidated still appears
valid, since we change the state after we fire all watchpoints.

This patch addresses both issues. Now, in the most important case (addPropertyTransition),
we fire the watchpoint set after we have modified the object. This is accomplished using
a deferral scope called DeferredStructureTransitionWatchpointFire. In cases where there is
no deferral, the adaptive watchpoint will conservatively resort to deoptimization because
it would find that the singleton object's structure is no longer watchable. This is
because in the absence of deferral, the singleton object would still have the original
structure, but that structure's watchpoint set would now report itself as having been
invalidated.

  • bytecode/Watchpoint.cpp:

(JSC::WatchpointSet::fireAllSlow): Change the state of the set before firing all watchpoints.
(JSC::WatchpointSet::fireAllWatchpoints):

  • runtime/JSObject.h:

(JSC::JSObject::putDirectInternal): Use the deferral scope.

  • runtime/Structure.cpp:

(JSC::Structure::Structure): Pass the deferral scope to didTransitionFromThisStructure.
(JSC::Structure::addPropertyTransition): Pass the deferral scope to create().
(JSC::StructureFireDetail::dump): This is no longer anonymous.
(JSC::DeferredStructureTransitionWatchpointFire::DeferredStructureTransitionWatchpointFire): Start with a null structure.
(JSC::DeferredStructureTransitionWatchpointFire::~DeferredStructureTransitionWatchpointFire): Fire the watchpoint if there is a structure.
(JSC::DeferredStructureTransitionWatchpointFire::add): Add a structure. Logically this is a list of deferred things, but we assert that there only will be one (happens to be true now).
(JSC::Structure::didTransitionFromThisStructure): Defer the watchpoint firing if there is a deferral scope.

  • runtime/Structure.h:

(JSC::StructureFireDetail::StructureFireDetail): Move this to the header.

  • runtime/StructureInlines.h:

(JSC::Structure::create): Pass the deferral scope to the constructor.

1:07 PM Changeset in webkit [186775] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.40/Source/WebKit2

Merged r186770. rdar://problem/21686508

1:05 PM Changeset in webkit [186774] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r186770. rdar://problem/21686508

1:04 PM Changeset in webkit [186773] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.39.0.2/Source/WebKit2

Merged r186770. rdar://problem/21686508

1:02 PM Changeset in webkit [186772] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.39.0.2/Source

Versioning.

12:58 PM Changeset in webkit [186771] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.39.0.2

New tag.

12:54 PM Changeset in webkit [186770] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Silverlight causes tabs to hang
https://bugs.webkit.org/show_bug.cgi?id=146912
rdar://problem/21686508

Reviewed by Sam Weinig.

Make sure to link production builds of the legacy plug-in process against the shim on 10.11 and newer.

  • Configurations/PluginProcess.xcconfig:
12:50 PM Changeset in webkit [186769] by Brent Fulgham
  • 10 edits in trunk/Source/WebCore

Change MediaPlayer Media Stream method signatures to use references
https://bugs.webkit.org/show_bug.cgi?id=146839
<rdar://problem/21769035>

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-13
Reviewed by Darin Adler.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::loadWithNextMediaEngine):

  • platform/graphics/MediaPlayerPrivate.h: Changed to references
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::load): Ditto

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::load): Ditto

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/mock/mediasource/MockMediaPlayerMediaSource.h:
12:11 PM Changeset in webkit [186768] by clopez@igalia.com
  • 2 edits in trunk/Source/WebCore

GTK] Build race with -DENABLE_WAYLAND_TARGET=ON
https://bugs.webkit.org/show_bug.cgi?id=146740

Reviewed by Martin Robinson.

No new tests, no behavior changes.

  • PlatformGTK.cmake: platform/graphics/wayland sources should be

included into WebCore source list instead of WebCorePlatformGTK.
Also move the add_custom_command() block into if(ENABLE_WAYLAND_TARGET),
this is not strictly needed to fix this bug, but it seems cleaner.

12:03 PM Changeset in webkit [186767] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Use -apple-system-monospaced-numbers for line numbers
https://bugs.webkit.org/show_bug.cgi?id=146898

Reviewed by Timothy Hatcher.

  • UserInterface/Views/CodeMirrorOverrides.css:

(.CodeMirror .CodeMirror-linenumber): Decrease font-size by 1px to make 4 digit numbers fit.

10:59 AM Changeset in webkit [186766] by commit-queue@webkit.org
  • 2 edits
    4 adds in trunk/Source/WebCore

Adding MediaStream Engine building blocks to the code repo
https://bugs.webkit.org/show_bug.cgi?id=146789
<rdar://problem/21747025>

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-13
Reviewed by Brent Fulgham.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h: Added.

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setLoadingProgresssed):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setHasAvailableVideoFrame):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::createWeakPtr):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: Added.

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::MediaPlayerPrivateMediaStreamAVFObjC):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::~MediaPlayerPrivateMediaStreamAVFObjC):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::registerMediaEngine):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::isAvailable):
(WebCore::mimeTypeCache):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::getSupportedTypes):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::supportsType):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::load):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::cancelLoad):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::prepareToPlay):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::platformMedia):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::platformLayer):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::play):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::playInternal):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::pause):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::pauseInternal):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::paused):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVolume):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::supportsScanning):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setMuted):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::naturalSize):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::hasVideo):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::hasAudio):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVisible):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::durationMediaTime):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::seeking):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setRateDouble):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setPreservesPitch):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::networkState):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::readyState):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::seekable):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::maxMediaTimeSeekable):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::minMediaTimeSeekable):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::buffered):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::didLoadingProgress):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setSize):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::hasAvailableVideoFrame):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::supportsAcceleratedRendering):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::movieLoadType):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::prepareForRendering):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::engineDescription):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::languageOfPrimaryAudioTrack):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::shouldBePlaying):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::addDisplayLayer):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::removeDisplayLayer):

  • platform/graphics/avfoundation/objc/MediaStreamPrivateAVFObjC.h: Added.
  • platform/graphics/avfoundation/objc/MediaStreamPrivateAVFObjC.mm: Added.

(WebCore::MediaStreamPrivateAVFObjC::create):
(WebCore::MediaStreamPrivateAVFObjC::MediaStreamPrivateAVFObjC):
(WebCore::MediaStreamPrivateAVFObjC::~MediaStreamPrivateAVFObjC):
(WebCore::MediaStreamPrivateAVFObjC::duration):
(WebCore::MediaStreamPrivateAVFObjC::buffered):
(WebCore::MediaStreamPrivateAVFObjC::readyState):
(WebCore::MediaStreamPrivateAVFObjC::hasAudio):
(WebCore::MediaStreamPrivateAVFObjC::hasVideo):
(WebCore::MediaStreamPrivateAVFObjC::naturalSize):

  • platform/mediastream/MediaStreamPrivate.h:

(WebCore::MediaStreamPrivate::MediaStreamPrivate): Added constructor.

10:17 AM Changeset in webkit [186765] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Skip failing table-related AX tests
https://bugs.webkit.org/show_bug.cgi?id=146903

  • platform/win/TestExpectations:
9:54 AM Changeset in webkit [186764] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

[iOS] Cancel AirPlay explicitly when exiting from full screen
https://bugs.webkit.org/show_bug.cgi?id=146902
<rdar://problem/20923632>

Reviewed by Brent Fulgham.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.h:
  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::~WebVideoFullscreenInterfaceAVKit): Call setExternalPlayback(false)

if playing to an external screen.

9:25 AM Changeset in webkit [186763] by ddkilzer@apple.com
  • 28 edits
    4 adds in branches/safari-600.1.4.17-branch

Merge r186476. rdar://problem/21708269

8:42 AM Changeset in webkit [186762] by Michael Catanzaro
  • 3 edits in trunk/Source/WebKit2

[Linux] SeccompFilters: handle alternate install prefixes
https://bugs.webkit.org/show_bug.cgi?id=140065

Reviewed by Žan Doberšek.

If the install prefix is something other than /usr, e.g. /usr/local or
~/jhbuild/install, then we want to make sure to allow libraries and data
from that prefix.

  • PlatformEfl.cmake:
  • Shared/linux/SeccompFilters/SyscallPolicy.cpp:

(WebKit::SyscallPolicy::addDefaultWebProcessPolicy):

6:15 AM WebKitGTK/2.8.x edited by Michael Catanzaro
Propose r186761 -- this is a good patch! (diff)
12:44 AM Changeset in webkit [186761] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] Contents not correctly laid out when the web view is not realized
https://bugs.webkit.org/show_bug.cgi?id=142532

Reviewed by Darin Adler.

The problem is that we are not reporting any size until the web
view is realized, so any web view loaded in a separate tab in the
browser, will report 0x0 as the window.innerWidth,
window.innerHeight until the view is realized. Websites that use
the window.innerWidth/innerHeight during the page load to decide
how to lay out the contents will be rendered wrongly.
I haven't been able to reproduce this with unit tests, as this
requires the particular case of same window but different web
views using tabs for example.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::viewSize): Always report the drawing area
size to make usre it's in sync with the WebProcess page size.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseSizeAllocate): Remove the optimization of only
report the size when it has changed, since both the redirected
window and the drawing area already do that check. Also remove the
optimization of waiting until the view is mapped to report its
size, since that's often too late for websites using the window
size during load.
(webkitWebViewBaseMap): Never report size on map, it should have
already been reported by size-allocate.

12:13 AM Changeset in webkit [186760] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1-branch/Source

Versioning.

12:11 AM Changeset in webkit [186759] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.40

New tag.

Jul 12, 2015:

11:59 PM Changeset in webkit [186758] by bshafiei@apple.com
  • 3 edits
    2 copies in branches/safari-601.1-branch

Merged r186741. rdar://problem/21051187

11:56 PM Changeset in webkit [186757] by bshafiei@apple.com
  • 22 edits in branches/safari-601.1-branch/Source

Merged r186712. rdar://problem/20483550

11:54 PM Changeset in webkit [186756] by bshafiei@apple.com
  • 11 edits in branches/safari-601.1-branch/Source

Merged r186707. rdar://problem/21779205

11:52 PM Changeset in webkit [186755] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r186703. rdar://problem/21555051

11:50 PM Changeset in webkit [186754] by bshafiei@apple.com
  • 2 edits
    2 copies in branches/safari-601.1-branch/Source/JavaScriptCore

Merged r186702. rdar://problem/21736607

11:49 PM Changeset in webkit [186753] by bshafiei@apple.com
  • 45 edits
    4 copies in branches/safari-601.1-branch/Source/JavaScriptCore

Merged r186691. rdar://problem/21771059

11:47 PM Changeset in webkit [186752] by bshafiei@apple.com
  • 6 edits in branches/safari-601.1-branch/Source

Merged r186684. rdar://problem/21501819

11:45 PM Changeset in webkit [186751] by bshafiei@apple.com
  • 4 edits in branches/safari-601.1-branch/Source/WebCore

Merged r186683. rdar://problem/21371589

11:44 PM Changeset in webkit [186750] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r186678. rdar://problem/21251875

11:11 PM Changeset in webkit [186749] by ddkilzer@apple.com
  • 8 edits
    8 adds in branches/safari-600.1.4.17-branch

Merge r185769. rdar://problem/21727217

10:24 PM Changeset in webkit [186748] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Add -apple-system-monospaced-numbers to font and font-family autocomplete
https://bugs.webkit.org/show_bug.cgi?id=146865

Reviewed by Daniel Bates.

  • UserInterface/Models/CSSKeywordCompletions.js:
9:28 PM Changeset in webkit [186747] by ddkilzer@apple.com
  • 3 edits
    2 adds in branches/safari-600.1.4.17-branch

Merge r186474. rdar://problem/21716537

9:07 PM Changeset in webkit [186746] by ddkilzer@apple.com
  • 4 edits
    2 adds in branches/safari-600.1.4.17-branch

Merge r185572. rdar://problem/21716531

7:16 PM Changeset in webkit [186745] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Watchpoints should be removed from their owning WatchpointSet before they are fired
https://bugs.webkit.org/show_bug.cgi?id=146895

Reviewed by Sam Weinig.

This simplifies the WatchpointSet API by making it so that when Watchpoint::fire() is
called, the Watchpoint is no longer in the set. This means that you don't have to remember
to remove it from the set's list (currently we do that implicitly as part of whatever
any particular Watchpoint::fireInternal() does), and you can now write adaptive
watchpoints that re-add themselves to a different set if they determine that the thing
they are actually watching is still intact but now needs to be watched in a different way
(like watching for whether some singleton object has a property of some name).

  • bytecode/Watchpoint.cpp:

(JSC::Watchpoint::~Watchpoint): Add a comment about why this is necessary.
(JSC::Watchpoint::fire): Make this out-of-line, private, and make it assert that we're no longer on the list.
(JSC::WatchpointSet::fireAllWatchpoints): Make this remove the watchpoint from the list before firing it.

  • bytecode/Watchpoint.h:

(JSC::Watchpoint::fire): Deleted. I moved this to Watchpoint.cpp.

6:39 PM Changeset in webkit [186744] by ddkilzer@apple.com
  • 10 edits
    2 adds in branches/safari-600.1.4.17-branch

Merge r184434, and a small part of r173173. rdar://problem/21716506

6:39 PM Changeset in webkit [186743] by ddkilzer@apple.com
  • 4 edits
    1 add in branches/safari-600.1.4.17-branch/Tools

Make run-webkit-tests work with iOS Simulator

Merge r179788, r179793.

3:09 PM Changeset in webkit [186742] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.1.4.17-branch/Source/WebKit2

Merge r184991. rdar://problem/21716545

12:41 PM Changeset in webkit [186741] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: WEB: VoiceOver for iOS does not read <iframe> elements during linear (swipe) navigation.
https://bugs.webkit.org/show_bug.cgi?id=146861

Reviewed by Darin Adler.

Source/WebCore:

AttachmentViews exist only on WK1 so we need account for both platforms.

Test: platform/ios-simulator/accessibility/iframe-access.html

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):

LayoutTests:

  • platform/ios-simulator/accessibility/iframe-access-expected.txt: Added.
  • platform/ios-simulator/accessibility/iframe-access.html: Added.
9:28 AM Changeset in webkit [186740] by youenn.fablet@crf.canon.fr
  • 5 edits in trunk/Source/WebCore

[Streams API] Templating ReadableJSStream
https://bugs.webkit.org/show_bug.cgi?id=146802

Reviewed by Darin Adler.

Introducing ReadableStream::clearValues to clear queued values when cancelling and going into error state.

Introducing ReadableEnqueuingStream to handle the stream queue, as a class template.
Specialized ReadableEnqueuingStream for the purpose of ReadableJSStream (storage of JSValue with variable size).

Updated some static functions to accept a ReadableStream in lieu of the more specialized ReadableJSStream.

Covered by existing tests.

  • Modules/streams/ReadableStream.cpp:

(WebCore::ReadableStream::changeStateToErrored):
(WebCore::ReadableStream::cancelNoCheck):

  • Modules/streams/ReadableStream.h:

(WebCore::ReadableEnqueuingStream::ReadableEnqueuingStream):
(WebCore::ReadableEnqueuingStream::enqueueChunk):
(WebCore::ReadableEnqueuingStream<ChunkType>::read):

  • bindings/js/ReadableJSStream.cpp:

(WebCore::ReadableEnqueuingStream<ReadableJSStreamValue>::read):
(WebCore::ReadableEnqueuingStream<ReadableJSStreamValue>::enqueueChunk):
(WebCore::createPullResultFulfilledFunction):
(WebCore::createCancelResultFulfilledFunction):
(WebCore::ReadableJSStream::ReadableJSStream):
(WebCore::ReadableJSStream::enqueue):

  • bindings/js/ReadableJSStream.h:

(WebCore::ReadableJSStreamValue::create):
(WebCore::ReadableEnqueuingStream<ReadableJSStreamValue>::desiredSize):
(WebCore::ReadableEnqueuingStream<ReadableJSStreamValue>::ReadableEnqueuingStream):

7:46 AM Changeset in webkit [186739] by ddkilzer@apple.com
  • 2 edits in branches/safari-600.8-branch/Source/WebKit2

Merge r184991. rdar://problem/21716403

12:36 AM Changeset in webkit [186738] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1-branch/Source

Versioning.

12:33 AM Changeset in webkit [186737] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.39.1/Source

Versioning.

12:32 AM Changeset in webkit [186736] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.39.1

New tag.

12:29 AM Changeset in webkit [186735] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WTF

Merged r186720. rdar://problem/21221902

12:28 AM Changeset in webkit [186734] by bshafiei@apple.com
  • 9 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r186719. rdar://problem/21221902

12:26 AM Changeset in webkit [186733] by bshafiei@apple.com
  • 11 edits
    1 copy
    1 delete in branches/safari-601.1-branch/Source

Merged r186718. rdar://problem/21221902

12:23 AM Changeset in webkit [186732] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r186716. rdar://problem/21507154

12:22 AM Changeset in webkit [186731] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r186713. rdar://problem/21507154

12:15 AM Changeset in webkit [186730] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merged r186727.

12:06 AM Changeset in webkit [186729] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.39.0.1/Source/WebCore

Merged r186727.

Note: See TracTimeline for information about the timeline view.