⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 23, 2015:

11:56 PM Changeset in webkit [187303] by Lucas Forschler
  • 7 edits in branches/safari-601.1-branch/Source

Merged r187129. rdar://problem/18477459

11:34 PM Changeset in webkit [187302] by matthew_hanson@apple.com
  • 7 edits
    7 copies in branches/safari-601.1-branch

Roll over ChangeLogs.

11:33 PM Changeset in webkit [187301] by Lucas Forschler
  • 10 edits in branches/safari-601.1-branch

Merged r187125. rdar://problem/21847618

11:31 PM Changeset in webkit [187300] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/Source/WebInspectorUI

Merged r187123. rdar://problem/21925581

11:29 PM Changeset in webkit [187299] by Lucas Forschler
  • 3 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r187117. rdar://problem/21921061

11:27 PM Changeset in webkit [187298] by Lucas Forschler
  • 4 edits
    4 copies in branches/safari-601.1-branch

Merged r187116. rdar://problem/21110936

11:24 PM Changeset in webkit [187297] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r187115. rdar://problem/21838764

11:21 PM Changeset in webkit [187296] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/Source/WebKit/ios

Merged r187113. rdar://problem/21920008

11:20 PM Changeset in webkit [187295] by Lucas Forschler
  • 3 edits in branches/safari-601.1-branch/Source/WebKit/ios

Merged r187107. rdar://problem/21920008

11:10 PM Changeset in webkit [187294] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r187045. rdar://problem/21433691

11:06 PM Changeset in webkit [187293] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/LayoutTests

Merged r186994. rdar://problem/21787807

11:04 PM Changeset in webkit [187292] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-601.1-branch

Merged r186981. rdar://problem/21787807

11:01 PM Changeset in webkit [187291] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r186977. rdar://problem/20864286

10:58 PM Changeset in webkit [187290] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r186806. rdar://problem/21795569

9:58 PM Changeset in webkit [187289] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix 32-bit build after r187272.

  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::mediaDocumentNaturalSizeChanged):
Added some WK_API_ENABLED.

9:53 PM Changeset in webkit [187288] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/21929532> REGRESSION (r184026): Safari AutoFill with Contact info for phone number is broken
https://bugs.webkit.org/show_bug.cgi?id=147249

Reviewed by Sam Weinig.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeObject): Use encodeString only for strings that encode as NSString or
NSMutableString. It can’t encode arbitrary NSString subclasses.
(decodeObject): Use decodeString for NSMutableString as well.

9:38 PM Changeset in webkit [187287] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Unreviewed build fix after r187245.

  • PlatformWin.cmake:

Add GDIUtilities.cpp to CMake build.

9:16 PM Changeset in webkit [187286] by Alan Bujtas
  • 2 edits in trunk/Source/WebKit2

[iOS] REGRESSION (187131): Loading CuteOverload zooms in to the top left corner.
https://bugs.webkit.org/show_bug.cgi?id=147251
rdar://problem/21953359

Calling zoomToRect() should result in essentially the same zoom scale as if we
called setZoomScale with the new page scale factor.

Reviewed by Benjamin Poulain.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):

7:48 PM Changeset in webkit [187285] by bshafiei@apple.com
  • 3 edits
    2 copies in branches/safari-600.1.4.17-branch

Merged r187248. rdar://problem/21976051

7:44 PM Changeset in webkit [187284] by bshafiei@apple.com
  • 3 edits
    2 copies in branches/safari-600.8-branch

Merged r187248. rdar://problem/21976049

7:35 PM Changeset in webkit [187283] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Implement WebAssembly modules
https://bugs.webkit.org/show_bug.cgi?id=147222

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-07-23
Reviewed by Filip Pizlo.

Make JSWASMModule inherit from JSDestructibleObject so that the destructor is called.

  • wasm/JSWASMModule.h:
7:23 PM Changeset in webkit [187282] by commit-queue@webkit.org
  • 14 edits in trunk/Source

Linking WebKit2 to be able to grab media sources from a UID
https://bugs.webkit.org/show_bug.cgi?id=147202
<rdar://problem/21947608>

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-23
Reviewed by Brent Fulgham.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mediastream/RealtimeMediaSourceCenter.h:
  • platform/mediastream/mac/AVCaptureDeviceManager.h:
  • platform/mediastream/mac/AVCaptureDeviceManager.mm:

(WebCore::AVCaptureDeviceManager::sourceWithUID):

  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::sourceWithUID):

  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:
  • platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:

(WebCore::RealtimeMediaSourceCenterOwr::sourceWithUID):

  • platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.h:
  • platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::sourceWithUID):

  • platform/mock/MockRealtimeMediaSourceCenter.h:

Source/WebKit2:

  • UIProcess/UserMediaPermissionRequestProxy.cpp:

(WebKit::UserMediaPermissionRequestProxy::getDeviceNameForUID):

  • UIProcess/UserMediaPermissionRequestProxy.h:
6:22 PM Changeset in webkit [187281] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit/win

Unreviewed build fix after r187245.

  • WebView.cpp:

WM_DPICHANGED is #defined, which causes problems if we try to use it as a variable name.

6:00 PM Changeset in webkit [187280] by Matt Baker
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: jittery cursor when adjusting time interval using timeline grabbers
https://bugs.webkit.org/show_bug.cgi?id=147095

Reviewed by Brian Burg.

  • UserInterface/Views/TimelineRuler.css:

(.timeline-ruler.resizing-selection > .selection-drag):
Override selection-drag element's cursor when "resizing-selection" selector is applied.
(.timeline-ruler.allows-time-range-selection.creating-selection): Deleted.
Renamed "creating-selection" selector to "resizing-selection" to reflect its new role.

  • UserInterface/Views/TimelineRuler.js:

(WebInspector.TimelineRuler.prototype._handleMouseMove):
(WebInspector.TimelineRuler.prototype._handleMouseUp):
(WebInspector.TimelineRuler.prototype._handleSelectionHandleMouseDown):
(WebInspector.TimelineRuler.prototype._handleSelectionHandleMouseUp):
Toggle cursor styles.

5:55 PM Changeset in webkit [187279] by achristensen@apple.com
  • 37 edits in trunk

Remove compile and runtime flags for promises.
https://bugs.webkit.org/show_bug.cgi?id=147244

Reviewed by Yusuke Suzuki.

.:

  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsWindows.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

  • API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject<Parent>::JSCallbackObject):

  • API/JSContextRef.cpp:

(JSGlobalContextCreateInGroup):

  • Configurations/FeatureDefines.xcconfig:
  • inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::getInternalProperties):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::create):
(JSC::JSGlobalObject::syntaxErrorConstructor):
(JSC::JSGlobalObject::typeErrorConstructor):
(JSC::JSGlobalObject::URIErrorConstructor):
(JSC::JSGlobalObject::promiseConstructor):
(JSC::JSGlobalObject::nullGetterFunction):
(JSC::JSGlobalObject::nullSetterFunction):
(JSC::JSGlobalObject::applyFunction):
(JSC::JSGlobalObject::definePropertyFunction):
(JSC::JSGlobalObject::arrayProtoValuesFunction):
(JSC::JSGlobalObject::initializePromiseFunction):
(JSC::JSGlobalObject::newPromiseDeferredFunction):
(JSC::JSGlobalObject::throwTypeErrorGetterSetter):
(JSC::JSGlobalObject::regExpPrototype):
(JSC::JSGlobalObject::errorPrototype):
(JSC::JSGlobalObject::iteratorPrototype):
(JSC::JSGlobalObject::promisePrototype):
(JSC::JSGlobalObject::debuggerScopeStructure):
(JSC::JSGlobalObject::withScopeStructure):
(JSC::JSGlobalObject::iteratorResultStructure):
(JSC::JSGlobalObject::iteratorResultStructureOffset):
(JSC::JSGlobalObject::regExpMatchesArrayStructure):
(JSC::JSGlobalObject::promiseStructure):

  • runtime/JSPromise.cpp:

(JSC::JSPromise::result):

  • runtime/JSPromise.h:
  • runtime/JSPromiseConstructor.cpp:

(JSC::constructPromise):

  • runtime/JSPromiseConstructor.h:
  • runtime/JSPromiseDeferred.cpp:

(JSC::JSPromiseDeferred::visitChildren):

  • runtime/JSPromiseDeferred.h:
  • runtime/JSPromisePrototype.cpp:

(JSC::JSPromisePrototype::getOwnPropertySlot):

  • runtime/JSPromisePrototype.h:
  • runtime/RuntimeFlags.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • bindings/js/JSDOMPromise.cpp:

(WebCore::rejectPromiseWithExceptionIfAny):

  • bindings/js/JSDOMPromise.h:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • WebView/WebPreferencesPrivate.h:

Source/WebKit/win:

  • Interfaces/IWebPreferencesPrivate.idl:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Source/WTF:

  • wtf/FeatureDefines.h:
5:32 PM Changeset in webkit [187278] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

AX: AccessibilityNodeObject::childrenChanged() generates too many AXLiveRegionChanged notifications
https://bugs.webkit.org/show_bug.cgi?id=147211
<rdar://problem/19908029>

Patch by Nan Wang <n_wang@apple.com> on 2015-07-23
Reviewed by Chris Fleizach.

Source/WebCore:

AccessibilityNodeObject::childrenChanged() can be called repeatedly, generating a live region
change notification each time. Sometimes, so many happen that VoiceOver hangs. We can use a timer
to make sure that we coalesce these notifications.

Test: platform/mac/accessibility/aria-multiple-liveregions-notification.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXComputedObjectAttributeCache::getIgnored):
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::frameLoadingEventNotification):
(WebCore::AXObjectCache::postLiveRegionChangeNotification):
(WebCore::AXObjectCache::liveRegionChangedNotificationPostTimerFired):
(WebCore::AXObjectCache::handleScrollbarUpdate):

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::childrenChanged):

LayoutTests:

  • platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt:
  • platform/mac/accessibility/aria-liveregions-notifications-always-sent.html:
  • platform/mac/accessibility/aria-liveregions-notifications-expected.txt:
  • platform/mac/accessibility/aria-liveregions-notifications.html:
  • platform/mac/accessibility/aria-multiple-liveregions-notification-expected.txt: Added.
  • platform/mac/accessibility/aria-multiple-liveregions-notification.html: Added.
5:28 PM Changeset in webkit [187277] by bshafiei@apple.com
  • 2 edits in branches/safari-600.8-branch/LayoutTests

Roll out r187241. rdar://problem/21707900

5:27 PM Changeset in webkit [187276] by bshafiei@apple.com
  • 3 edits
    2 deletes in branches/safari-600.8-branch

Roll out r185838. rdar://problem/21707900

5:23 PM Changeset in webkit [187275] by bshafiei@apple.com
  • 3 edits
    2 deletes in branches/safari-600.1.4.17-branch

Roll out r185838. rdar://problem/21708257

5:19 PM Changeset in webkit [187274] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebCore

[iOS] Frame snapshots don't factor in page scale
https://bugs.webkit.org/show_bug.cgi?id=147239
<rdar://problem/21905756>

Reviewed by Simon Fraser.

  • page/FrameSnapshotting.cpp:

(WebCore::snapshotFrameRect):
Apply page scale when determining the backing store size and setting up the context.

  • page/TextIndicator.cpp:

(WebCore::TextIndicator::createWithSelectionInFrame):
Don't assume snapshotFrameRect gave us an image with scale=deviceScale, because it
will factor in the pageScale too.

  • platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::resolutionScale):
Expose resolutionScale.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):
This has been true for a long time.

5:08 PM Changeset in webkit [187273] by Jon Davis
  • 2 edits in trunk/Source/WebCore

Adding Web Components to feature status page.
https://bugs.webkit.org/show_bug.cgi?id=147209

Reviewed by Timothy Hatcher.

  • features.json:
4:46 PM Changeset in webkit [187272] by jer.noble@apple.com
  • 26 edits in trunk/Source

Notify the UI delegate when a MediaDocument's natural size changes
https://bugs.webkit.org/show_bug.cgi?id=147182

Reviewed by Simon Fraser.

Source/WebCore:

Notify the MediaDocument that it's underlying media element has changed its natural size, either when
the media engine notifies us that the size changed, or when the ready state progresses to HAVE_METADATA.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setReadyState): Notify the media document.
(WebCore::HTMLMediaElement::mediaPlayerSizeChanged): Ditto.

  • html/MediaDocument.cpp:

(WebCore::MediaDocument::mediaElementNaturalSizeChanged): Pass to the chrome client.

  • html/MediaDocument.h:
  • page/ChromeClient.h:

Source/WebKit2:

Pipe notifications of media document natural size changes up from the chrome client, through
to the UIProcess, through the page client, through the WKWebView, to the UIDelegate.

  • UIProcess/API/APIUIClient.h:

(API::UIClient::mediaDocumentNaturalSizeChanged):

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _mediaDocumentNaturalSizeChanged:]):

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::mediaDocumentNaturalSizeChanged):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::mediaDocumentNaturalSizeChanged):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::mediaDocumentNaturalSizeChanged):

  • UIProcess/mac/PageClientImpl.h:
  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::mediaDocumentNaturalSizeChanged):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::mediaDocumentNaturalSizeChanged):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mediaDocumentNaturalSizeChanged):

  • WebProcess/WebPage/WebPage.h:
  • UIProcess/API/gtk/PageClientImpl.h: Add default, empty implementation of new pure-virtual method.
  • UIProcess/efl/WebViewEfl.h: Ditto.
4:43 PM Changeset in webkit [187271] by Simon Fraser
  • 3 edits
    4 adds in trunk

Layer z-ordering is incorrect when scrolling on page witih position:fixed
https://bugs.webkit.org/show_bug.cgi?id=147220
rdar://problem/15849697&21929247

Reviewed by Dean Jackson.

Source/WebCore:

Overlap testing for compositing uses the currently laid out position of fixed
elements, without taking into account the fact that async scrolling can move
them around, and possibly under other non-composited elements. This manifested
as position:fixed elements moving over other elements on some pages when
scrolling, when they should have moved behind.

Fix by expanding the overlap map entry for position:fixed elements to create
an rect for the area they cover at all scroll locations, taking min and max
scroll offsets into account.

Also add a couple more LOG(Compositing) statements.

Tests: compositing/layer-creation/fixed-overlap-extent-rtl.html

compositing/layer-creation/fixed-overlap-extent.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::fixedPositionOffset):
(WebCore::RenderLayerCompositor::computeExtent):
(WebCore::RenderLayerCompositor::needsFixedRootBackgroundLayer):
(WebCore::RenderLayerCompositor::rootBackgroundTransparencyChanged):

LayoutTests:

Tests that reveal the overlap area by creating lots of small layers, and dumping
the layer tree.

  • compositing/layer-creation/fixed-overlap-extent-expected.txt: Added.
  • compositing/layer-creation/fixed-overlap-extent-rtl-expected.txt: Added.
  • compositing/layer-creation/fixed-overlap-extent-rtl.html: Added.
  • compositing/layer-creation/fixed-overlap-extent.html: Added.
4:33 PM Changeset in webkit [187270] by ggaren@apple.com
  • 3 edits in trunk/Source/bmalloc

bmalloc: Shrink the super chunk size (again)
https://bugs.webkit.org/show_bug.cgi?id=147240

Reviewed by Andreas Kling.

Shrinking to 8MB reduced VM exhaustion crashes but did not eliminate them.
Let's try 4MB.

(My previous comment was that the maximum fast object was 2MB. But it
was 4MB! Now it's 2MB for realsies.)

  • bmalloc/Sizes.h:
4:20 PM Changeset in webkit [187269] by Brian Burg
  • 7 edits
    4 adds
    2 deletes in trunk/LayoutTests

Web Inspector: rewrite inspector-protocol/console tests to use new testing patterns
https://bugs.webkit.org/show_bug.cgi?id=147231

Reviewed by Joseph Pecoraro.

Restructure existing protocol tests for Console.messageAdded to use Promises and
modern event listener test interfaces. Add some new functionality to make it easier
install multiple protocol event listeners without clobbering.

This test also splits warnings-errors.html into two tests, one to cover CSS parser
warnings and one for JavaScript parser and runtime errors.

  • http/tests/inspector-protocol/resources/InspectorTest.js:

(InspectorTest.sendCommand): Support arguments packaged in an object. This style is preferable
in tests because it is very explicit about what functionality and messages are covered.

(InspectorTest.awaitEvent): Added. This is a single-shot event listener that resolves a
promise when the desired protocol event is dispatched.

(InspectorTest.addEventListener): Reimplemented, based on code from WebInspector.Object.
Allows multiple listeners to be registered for a single protocol event.

(InspectorTest.AsyncTestSuite.prototype.runTestCases):
(InspectorTest.AsyncTestSuite):
(InspectorTest.SyncTestSuite.prototype.runTestCases):
(InspectorTest.SyncTestSuite):
(InspectorTest.log): Improve the formatting of test suite/test case output.

(InspectorFrontendAPI.dispatchMessageAsync): Dispatch to an array of listeners if available.
(InspectorTest.importScript): Clarify that this method performs a synchronous load.
(.InspectorTest.eventHandler.eventName): Deleted.

  • inspector-protocol/async-test-suite-expected.txt: Rebaseline whitespace.
  • inspector-protocol/sync-test-suite-expected.txt: Rebaseline whitespace.
  • inspector-protocol/console/console-message-expected.txt:
  • inspector-protocol/console/console-message.html:
  • inspector-protocol/console/css-source-locations-expected.txt: Added.
  • inspector-protocol/console/css-source-locations.html: Added.
  • inspector-protocol/console/js-source-locations-expected.txt: Added.
  • inspector-protocol/console/js-source-locations.html: Added.
  • inspector-protocol/console/warnings-errors-expected.txt: Removed.
  • inspector-protocol/console/warnings-errors.html: Removed.
  • inspector-protocol/runtime/getProperties-expected.txt: Rebaseline whitespace.
4:16 PM Changeset in webkit [187268] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

Removing one incorrect annotation from the previous change.

Unreviewed.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
4:08 PM Changeset in webkit [187267] by enrica@apple.com
  • 3 edits in trunk/Source/WebKit2

[iOS] Add another preview delegate for didDismissPreview.
https://bugs.webkit.org/show_bug.cgi?id=147241
rdar://problem/21664211

Reviewed by Tim Horton and Yongjun Zhang.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _previewItemController:didDismissPreview:committing:]):

4:06 PM Changeset in webkit [187266] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/21910578> Second pass at [iOS] Keyboard shortcuts that take focus away from the web view end up typing a letter into the newly focused field
https://bugs.webkit.org/show_bug.cgi?id=146732

Reviewed by Darin Adler.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _interpretKeyEvent:isCharEvent:]): Rather than checking if the view is
first responder, which it might still be when the Web Content processes invokes this
callback, check if we are in editable content before forwarding the event to the keyboard.

3:53 PM Changeset in webkit [187265] by ap@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

Windows test result gardening after Mac libxml changes.

  • platform/win/fast/dom/adopt-attribute-crash-expected.txt: Added.
  • platform/win/fast/parser/xml-colon-entity-expected.txt: Added.
  • platform/win/fast/parser/xml-declaration-missing-ending-mark-expected.txt: Added.
  • platform/win/svg/custom/bug78807-expected.txt: Added.
3:32 PM Changeset in webkit [187264] by jer.noble@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Unreviewed build fix after r187251; rename flag -> allows.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setAllowsMediaDocumentInlinePlayback):

3:29 PM Changeset in webkit [187263] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] Unreviewed build fix after r187251.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setAllowsMediaDocumentInlinePlayback):
Use the correct name for the boolean to pass along to SetAllowsMediaDocumentInlinePlayback.

3:23 PM Changeset in webkit [187262] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

Relax media playback restrictions if the allowsMediaDocumentInlinePlayback property is set.
https://bugs.webkit.org/show_bug.cgi?id=147234

Reviewed by Darin Adler.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::prepareForLoad): Moved restriction check into MediaElementSession.

  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::playbackPermitted): Check if is a top-level media document and if

allowsMediaDocumentInilnePlayback is set, and return early.

(WebCore::MediaElementSession::effectivePreloadForElement): Ditto.
(WebCore::MediaElementSession::allowsAutomaticMediaDataLoading): Ditto.

  • html/MediaElementSession.h:
3:19 PM Changeset in webkit [187261] by bshafiei@apple.com
  • 3 edits
    2 adds in branches/safari-600.8-branch

Merged r187189. rdar://problem/21707927

3:18 PM Changeset in webkit [187260] by bshafiei@apple.com
  • 3 edits
    2 adds in branches/safari-600.1.4.17-branch

Merged r187189. rdar://problem/21708281

3:16 PM Changeset in webkit [187259] by enrica@apple.com
  • 3 edits in trunk/Source/WebKit2

One more iOS build fix.

Unreviewed.

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/ios/WKContentViewInteraction.h:
3:15 PM Changeset in webkit [187258] by commit-queue@webkit.org
  • 15 edits in trunk/Source

Bridged passing lists of devices between the UIProcess and the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=147056
<rdar://problem/21883094>

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-23
Reviewed by Brent Fulgham.

Source/WebCore:

  • Modules/mediastream/UserMediaRequest.h: Added fields to store and

retrieve lists of devices
(WebCore::UserMediaRequest::deviceUIDsVideo):
(WebCore::UserMediaRequest::deviceUIDsAudio):

Source/WebKit2:

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp: Modified file

to reflect changes made to the header in the .messages.in file
(WebKit::UserMediaPermissionRequestManagerProxy::createRequest): Ditto
(WebKit::UserMediaPermissionRequestManagerProxy::didReceiveUserMediaPermissionDecision):

  • UIProcess/UserMediaPermissionRequestManagerProxy.h: Ditto
  • UIProcess/UserMediaPermissionRequestProxy.cpp: Ditto

(WebKit::UserMediaPermissionRequestProxy::UserMediaPermissionRequestProxy):

  • UIProcess/UserMediaPermissionRequestProxy.h:

(WebKit::UserMediaPermissionRequestProxy::create):
(WebKit::UserMediaPermissionRequestProxy::deviceUIDsVideo):
(WebKit::UserMediaPermissionRequestProxy::deviceUIDsAudio):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestUserMediaPermissionForFrame):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Changed heading
  • WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::startRequest):
(WebKit::UserMediaPermissionRequestManager::didReceiveUserMediaPermissionDecision):

  • WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveUserMediaPermissionDecision):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Changed heading
3:06 PM Changeset in webkit [187257] by mrajca@apple.com
  • 6 edits
    2 adds in trunk

Media Session: add support for ducking media elements https://bugs.webkit.org/show_bug.cgi?id=147089

Reviewed by Eric Carlson.

Test: media/session/transient-interruptions.html

  • Modules/mediasession/MediaSession.cpp:

(WebCore::MediaSession::handleDuckInterruption): Duck the active media elements.
(WebCore::MediaSession::handleUnduckInterruption): Unduck the active media elements.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateVolume): Lower the volume of media elements to 25% when ducked (constant determined empirically).
(WebCore::HTMLMediaElement::setShouldDuck): Call updateVolume to change the volume of the underlying media player.

  • html/HTMLMediaElement.h:
3:02 PM Changeset in webkit [187256] by mrajca@apple.com
  • 6 edits in trunk/Source/WebCore

Media Session: add infrastructure for testing ducking https://bugs.webkit.org/show_bug.cgi?id=147080

Reviewed by Jer Noble.

We need to expose a media element's underlying media player's volume to tests so we can test ducking.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::playerVolume):

  • html/HTMLMediaElement.h:
  • testing/Internals.cpp:

(WebCore::Internals::mediaElementPlayerVolume):

  • testing/Internals.h:
  • testing/Internals.idl:
3:00 PM Changeset in webkit [187255] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Adopt the new _previewItemControllerDidCancelPreview delegate method.
https://bugs.webkit.org/show_bug.cgi?id=147238

Don't allow hightlight long press to trigger tap if the link preview is cancelled because
the link is not preview-able.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2015-07-23
Reviewed by Beth Dakin.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _previewItemControllerDidCancelPreview:]):

2:26 PM Changeset in webkit [187254] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk/Source/JavaScriptCore

Implement WebAssembly modules
https://bugs.webkit.org/show_bug.cgi?id=147222

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-07-23
Reviewed by Mark Lam.

Introducing the boilerplate data structure for the WebAssembly module.
WebAssembly functionality will be added in a subsequent patch.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wasm/JSWASMModule.cpp: Added.

(JSC::JSWASMModule::visitChildren):

  • wasm/JSWASMModule.h: Added.

(JSC::JSWASMModule::create):
(JSC::JSWASMModule::createStructure):
(JSC::JSWASMModule::JSWASMModule):

2:19 PM Changeset in webkit [187253] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

iOS build fix after http://trac.webkit.org/changeset/187238.

Unreviewed.

  • Platform/spi/ios/UIKitSPI.h:
2:17 PM Changeset in webkit [187252] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebKit2

[WK2] Add a WKWebView property for whether the view is displaying a media document
https://bugs.webkit.org/show_bug.cgi?id=147233

Reviewed by Beth Dakin.

Add a _isDisplayingStandaloneMediaDocument property, which queries the frame for whether
the current MIME type is one which our media engines support.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _isDisplayingStandaloneMediaDocument]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::isDisplayingStandaloneMediaDocument):

  • UIProcess/WebFrameProxy.h:
2:15 PM Changeset in webkit [187251] by jer.noble@apple.com
  • 16 edits in trunk/Source

[iOS] Add an explicit API to allow media documents to (temporarily) play inline
https://bugs.webkit.org/show_bug.cgi?id=147181

Reviewed by Beth Dakin.

Source/WebCore:

Add listeners for the new allowsMediaDocumentInlinePlayback API. When this value becomes
NO, force any playing MediaDocuments to enter fullscreen mode.

  • dom/Document.cpp:

(WebCore::Document::registerForAllowsMediaDocumentInlinePlaybackChangedCallbacks): Added registration method.
(WebCore::Document::unregisterForAllowsMediaDocumentInlinePlaybackChangedCallbacks): Added deregistration method.
(WebCore::Document::allowsMediaDocumentInlinePlaybackChanged): Notify all listeners.

  • dom/Document.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::registerWithDocument): Listen for allowsMediaDocumentInlinePlayback changes.
(WebCore::HTMLMediaElement::unregisterWithDocument): Stop listening to same.
(WebCore::HTMLMediaElement::allowsMediaDocumentInlinePlaybackChanged): Enter fullscreen mode if the value

changes to false during playback.

  • html/HTMLMediaElement.h:
  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback): Early true if the override value is set.

  • page/Page.cpp:

(WebCore::Page::setAllowsMediaDocumentInlinePlayback): Notify all documents of the changed value.

  • page/Page.h:

(WebCore::Page::allowsMediaDocumentInlinePlayback): Simple getter.

Source/WebKit2:

Add a WKWebView(Private) API which allows MediaDocuments loaded by the view to play their contents inline, regardless
of whether inline playback is restricted on the current device.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setRequiresUserActionForMediaPlayback:]): Added. Pass through to WebPageProxy.
(-[WKWebView _allowsMediaDocumentInlinePlayback]): Ditto.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::allowsMediaDocumentInlinePlayback): Simple getter.
(WebKit::WebPageProxy::setAllowsMediaDocumentInlinePlayback): Set, and conditionally pass the new value to WebPage.

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setAllowsMediaDocumentInlinePlayback): Set, and conditionally notify WebCore page of the change.

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::allowsMediaDocumentInlinePlayback): Simple getter.

  • WebProcess/WebPage/WebPage.messages.in: Add new messages.
1:53 PM Changeset in webkit [187250] by Beth Dakin
  • 2 edits in trunk/Source/WebKit2

Should not allow previews of 1x1 images
https://bugs.webkit.org/show_bug.cgi?id=147237
-and corresponding-
rdar://problem/21968460

Reviewed by Tim Horton.

1x1 images are used on some sites to cover actual images, which leads to a
misleading preview experience. There is not any reason why you would really
want to preview an image this small nor any reason to believe that the
preview would result in anything useful.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation):

1:24 PM Changeset in webkit [187249] by Devin Rousso
  • 18 edits
    2 adds in trunk

Web Inspector: Add a function to CSSCompletions to get a list of supported system fonts
https://bugs.webkit.org/show_bug.cgi?id=147009

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

  • inspector/protocol/CSS.json: Added getSupportedSystemFontFamilyNames function.

Source/WebCore:

Test: inspector/css/get-system-fonts.html

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getSupportedSystemFontFamilyNames):
Gets the list of system fonts (implemented in each platform) and returns that list.

  • inspector/InspectorCSSAgent.h:
  • platform/graphics/FontCache.h:
  • platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FontCache::systemFontFamilies):

  • platform/graphics/ios/FontCacheIOS.mm:

(WebCore::FontCache::systemFontFamilies):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::systemFontFamilies):

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::systemFontFamilies):

Source/WebInspectorUI:

  • UserInterface/Base/Main.js:

(WebInspector.loaded):
(WebInspector.activateExtraDomains):

  • UserInterface/Base/Test.js:

(WebInspector.loaded):

  • UserInterface/Models/CSSCompletions.js:

(WebInspector.CSSCompletions.requestCSSCompletions.fontFamilyNamesCallback):
(WebInspector.CSSCompletions.requestCSSCompletions):
Now also grabs the list of system font family names and adds that list to the existing completion
list for both font and font-family in CSSKeywordCompletions.
(WebInspector.CSSCompletions.requestCSSNameCompletions): Deleted.

LayoutTests:

Skip the get-system-fonts test until it is implemented.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/win/TestExpectations:

Added the get-system-fonts test that returns the list of system fonts.

  • inspector/css/get-system-fonts-expected.html:
  • inspector/css/get-system-fonts.html:
1:18 PM Changeset in webkit [187248] by beidson@apple.com
  • 3 edits
    2 adds in trunk

Crash in WebPlatformStrategies::createPingHandle - Deref a null NetworkingContext.
<rdar://problem/21949735> and https://bugs.webkit.org/show_bug.cgi?id=147227

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::createPingHandle): Skip it if there's a null NetworkingContext.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher.html: Added.
1:05 PM Changeset in webkit [187247] by timothy@apple.com
  • 4 edits
    3 adds in trunk/Websites/webkit.org

Change some images for a blog post and add 2x images.

  • blog-files/inspector-elements-tab-2x.png: Added.
  • blog-files/inspector-elements-tab.png: Updated.
  • blog-files/inspector-network-tab-2x.png: Added.
  • blog-files/inspector-network-tab.png: Updated.
  • blog-files/inspector-tab-bar-2x.png: Added.
  • blog-files/inspector-tab-bar.png: Updated.
1:02 PM Changeset in webkit [187246] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1-branch/Source

Versioning.

12:30 PM Changeset in webkit [187245] by Brent Fulgham
  • 20 edits
    2 adds in trunk

Source/WebCore:
[Win] Implement High DPI support features
https://bugs.webkit.org/show_bug.cgi?id=146335
<rdar://problem/21558269>

Reviewed by Alex Christensen.

  • platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(WebCore::PlatformCALayerWinInternal::drawTile): Don't translate the CGContext to the position
of the CACFLayerRef; the underlying context is already in the right position.

  • platform/win/PlatformMouseEventWin.cpp: Update class to adjust mouse

event coordinates based on scaling factor.
(WebCore::deviceScaleFactor):
(WebCore::positionForEvent):

  • platform/win/ScrollbarThemeWin.cpp:

(WebCore::scrollbarThicknessInPixels):
(WebCore::ScrollbarThemeWin::scrollbarThickness):
(WebCore::ScrollbarThemeWin::themeChanged):

  • platform/win/WheelEventWin.cpp: Update class to adjust wheel event

coordinates based on scaling factor.
(WebCore::deviceScaleFactor):
(WebCore::positionForEvent):
(WebCore::globalPositionForEvent):
(WebCore::PlatformWheelEvent::PlatformWheelEvent):

Source/WebKit/win:
[Win] Implement High DPI support features
https://bugs.webkit.org/show_bug.cgi?id=146335
<rdar://problem/21558269>

Reviewed by Alex Christensen.

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::transitionToCommittedForNewPage): Size
page for current device scale factor.

  • WebFrame.cpp:

(WebFrame::paintDocumentRectToContext): Account for device scale factor.
(WebFrame::paintScrollViewRectToContextAtPoint): Ditto.

  • WebView.cpp:

(WebView::repaint): Adjust paint rect for device scale factor.
(WebView::scrollBackingStore): Adjust coordinates for scale factor.
(WebView::sizeChanged): Ditto.
(WebView::updateBackingStore): Ditto.
(WebView::paint): Ditto.
(WebView::paintIntoBackingStore): Ditto.
(WebView::handleContextMenuEvent): Ditto.
(WebView::gestureNotify): Ditto.
(WebView::gesture): Ditto.
(WebView::initializeToolTipWindow): Adjust max tool tip width
for device scale factor.
(WebView::selectionRect): Adjust coordinates for scale factor.
(WebView::elementAtPoint): Ditto.
(WebView::scrollOffset): Ditto.
(WebView::scrollBy): Ditto.
(WebView::visibleContentRect): Ditto.
(WebView::paintContents): Ditto.

  • WebView.h:

Tools:
[Win] Implement proper High DPI support features
https://bugs.webkit.org/show_bug.cgi?id=146335
<rdar://problem/21558269>

Reviewed by Alex Christensen.

Update WinLauncher to take device scaling factor into account.

  • WinLauncher/Common.cpp:

(resizeSubViews): Make sure toolbars and URL bar are properly sized and using
a valid font.
(computeFullDesktopFrame): Handle high DPI desktops.
(WndProc): Make comments more precise.

  • WinLauncher/WinLauncher.cpp:

(WinLauncher::init): Determine device scale factor at launch.
(WinLauncher::updateDeviceScaleFactor): Added.

  • WinLauncher/WinLauncher.h:
  • WinLauncher/WinLauncherWebHost.h: Use C++11 initialization.
  • WinLauncher/WinMain.cpp: Size interface based on scaling factor.

(wWinMain): Ditto.

  • win/DLLLauncher/DLLLauncherMain.cpp:

(wWinMain): Tell Windows we understand high DPI.

12:15 PM Changeset in webkit [187244] by mmaxfield@apple.com
  • 4 edits
    1 add in trunk

REGRESSION(r182236): Justified Arabic text does not expand
https://bugs.webkit.org/show_bug.cgi?id=147217

Reviewed by Simon Fraser.

When I was writing r182236, I got confused between the levels of the string hierarchy in ComplexTextController.
I've added a comment in the header which should make it easier to get it right.

Test: fast/text/international/arabic-justify.html

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • platform/graphics/mac/ComplexTextController.h:
12:08 PM Changeset in webkit [187243] by ap@apple.com
  • 3 edits in branches/safari-601.1-branch

Merge r186900.

2015-07-16 David Kilzer <ddkilzer@apple.com>

Mark fast/canvas/canvas-too-large-to-draw.html as crashing on El Capitan

Fix is tracked by <rdar://problem/21857102>.

  • platform/mac/TestExpectations: Mark test as crashing:
  • fast/canvas/canvas-too-large-to-draw.html
12:01 PM Changeset in webkit [187242] by ap@apple.com
  • 2 edits in branches/safari-601.1-branch/LayoutTests

More test gardening.

  • platform/mac/TestExpectations:
11:52 AM Changeset in webkit [187241] by andersca@apple.com
  • 2 edits in branches/safari-600.8-branch/LayoutTests

Skip a couple of region selection tests.

  • platform/mac/TestExpectations:
11:34 AM Changeset in webkit [187240] by timothy_horton@apple.com
  • 1 edit
    4 deletes in trunk/Source/WebKit2

Remove some files that should have been removed with WebKit2 Windows
https://bugs.webkit.org/show_bug.cgi?id=147223

Reviewed by Csaba Osztrogonác.

  • Shared/API/c/cf/WKURLRequestCF.cpp: Removed.
  • Shared/API/c/cf/WKURLRequestCF.h: Removed.
  • Shared/API/c/cf/WKURLResponseCF.cpp: Removed.
  • Shared/API/c/cf/WKURLResponseCF.h: Removed.
11:21 AM Changeset in webkit [187239] by timothy@apple.com
  • 3 edits in trunk/Websites/webkit.org

Change some images for a blog post.

  • blog-files/inspector-elements-tab.png:
  • blog-files/inspector-network-tab.png:
11:04 AM Changeset in webkit [187238] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the build

  • Platform/spi/ios/UIKitSPI.h:
11:03 AM Changeset in webkit [187237] by timothy@apple.com
  • 2 edits
    2 adds
    1 delete in trunk/Websites/webkit.org

Add and change some images for a blog post.

  • blog-files/inspector-elements-network-tabs.png: Removed.
  • blog-files/inspector-elements-tab.png: Added.
  • blog-files/inspector-network-tab.png: Added.
  • blog-files/inspector-tab-bar.png:
10:30 AM Changeset in webkit [187236] by Brent Fulgham
  • 6 edits in trunk/Websites/webkit.org

Correct rest of the images to match.

  • blog-files/backdrop-filters/backdrop_correct_1x.jpg:
  • blog-files/backdrop-filters/backdrop_correct_2x.jpg:
  • blog-files/backdrop-filters/backdrop_invert_1x.jpg:
  • blog-files/backdrop-filters/backdrop_invert_2x.jpg:
  • blog-files/backdrop-filters/backdrop_mixed_1x.jpg:
10:26 AM Changeset in webkit [187235] by achristensen@apple.com
  • 2 edits in trunk/Tools

[Win] Unreviewed build fix after r187169.

  • Scripts/build-webkit:

Correctly find WebKit.sln.

10:21 AM Changeset in webkit [187234] by Brent Fulgham
  • 6 edits in trunk/Websites/webkit.org

Adjust image sizes to avoid page scaling.

  • blog-files/backdrop-filters/Screen_OSX_Yosemite_Finder-iCloud-WaterBg_1x.jpg:
  • blog-files/backdrop-filters/Screen_OSX_Yosemite_Finder-iCloud-WaterBg_2x.jpg:
  • blog-files/backdrop-filters/Screen_V_iOS8_ControlCenter_BlueGradient_1x.jpg:
  • blog-files/backdrop-filters/Screen_V_iOS8_ControlCenter_BlueGradient_2x.jpg:
  • blog-files/backdrop-filters/backdrop_mixed_2x.jpg:
10:19 AM Changeset in webkit [187233] by ap@apple.com
  • 4 edits in branches/safari-601.1-branch

Merge r186677, which is a follow-up fix to r186642.

2015-07-10 Brady Eidson <beidson@apple.com>

ASSERT restoring from page cache as DocumentLoader reattaches to its Frame.
<rdar://problem/21766282> and https://bugs.webkit.org/show_bug.cgi?id=146786

Reviewed by NOBODY (Fixing obvious boneheaded mistake in r186642)

No new tests (Covered by existing)

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::attachToFrame): Bail if reattaching to the current Frame, which happens when restoring from the page cache.
10:04 AM Changeset in webkit [187232] by ap@apple.com
  • 23 edits in branches/safari-601.1-branch/LayoutTests

More test updates for features that are disabled on this branch.

  • css3/parse-align-content-expected.txt:
  • css3/parse-align-items-expected.txt:
  • css3/parse-align-self-expected.txt:
  • css3/parse-justify-content-expected.txt:
  • fast/css/css-selector-text-expected.txt:
  • fast/css/css-set-selector-text-expected.txt:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/parse-justify-items-expected.txt:
  • fast/css/parse-justify-items.html:
  • fast/css/read-only-read-write-input-basics-expected.html:
  • fast/css/read-only-read-write-input-basics.html:
  • fast/dom/navigator-detached-no-crash-expected.txt:
  • fast/selectors/read-only-read-write-input-basics-expected.txt:
  • js/dom/dom-static-property-for-in-iteration-expected.txt:
  • platform/mac-mavericks/accessibility/roles-exposed-expected.txt:
  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/TestExpectations:
  • platform/mac/accessibility/roles-exposed-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
9:24 AM Changeset in webkit [187231] by ap@apple.com
  • 3 edits in branches/safari-601.1-branch

Merge r187194.

2015-07-22 Myles C. Maxfield <mmaxfield@apple.com>

[El Capitan] Test Gardening

Unreviewed.

  • platform/mac/fast/text/ligature-subdivision-expected.txt:
9:21 AM Changeset in webkit [187230] by ap@apple.com
  • 28 edits
    13 copies in branches/safari-601.1-branch

Merge r187126.

2015-07-21 Myles C. Maxfield <mmaxfield@apple.com>

[El Capitan] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=147059

  • platform/mac-yosemite/fast/dom/52776-expected.png: Copied from LayoutTests/platform/mac/fast/dom/52776-expected.png.
  • platform/mac-yosemite/fast/text/complex-text-opacity-expected.png: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.png.
  • platform/mac-yosemite/fast/text/font-weights-expected.png: Copied from LayoutTests/platform/mac/fast/text/font-weights-expected.png.
  • platform/mac-yosemite/fast/text/indic-expected.png: Copied from LayoutTests/platform/mac/fast/text/indic-expected.png.
  • platform/mac-yosemite/fast/text/indic-expected.txt: Copied from LayoutTests/platform/mac/fast/text/indic-expected.txt.
  • platform/mac-yosemite/fast/text/international/bidi-AN-after-L-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.png.
  • platform/mac-yosemite/fast/text/international/bidi-mirror-he-ar-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png.
  • platform/mac-yosemite/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png.
  • platform/mac-yosemite/fast/text/international/bidi-neutral-run-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-run-expected.png.
  • platform/mac-yosemite/fast/text/international/danda-space-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/danda-space-expected.png.
  • platform/mac-yosemite/fast/text/international/danda-space-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/danda-space-expected.txt.
  • platform/mac-yosemite/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png.
  • platform/mac-yosemite/svg/text/text-intro-05-t-expected.png: Copied from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.png.
  • platform/mac/fast/dom/52776-expected.png:
  • platform/mac/fast/dom/52776-expected.txt:
  • platform/mac/fast/text/arabic-times-new-roman-expected.png:
  • platform/mac/fast/text/arabic-times-new-roman-expected.txt:
  • platform/mac/fast/text/complex-text-opacity-expected.png:
  • platform/mac/fast/text/complex-text-opacity-expected.txt:
  • platform/mac/fast/text/font-weights-expected.png:
  • platform/mac/fast/text/font-weights-expected.txt:
  • platform/mac/fast/text/indic-expected.png:
  • platform/mac/fast/text/indic-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/mac/fast/text/international/danda-space-expected.png:
  • platform/mac/fast/text/international/danda-space-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/mac/svg/text/text-intro-05-t-expected.png:
  • platform/mac/svg/text/text-intro-05-t-expected.txt:
9:17 AM Changeset in webkit [187229] by ap@apple.com
  • 11 edits
    8 copies in branches/safari-601.1-branch/LayoutTests

Merge r187148.

2015-07-21 Alexey Proskuryakov <ap@apple.com>

Update Mac test results for libxml2 v2.9.2.

These results will probably become cross-platform eventually, but for now it's just Mac.

  • platform/mac-yosemite/fast/dom/adopt-attribute-crash-expected.txt: Copied from LayoutTests/fast/dom/adopt-attribute-crash-expected.txt.
  • platform/mac-yosemite/fast/parser: Added.
  • platform/mac-yosemite/fast/parser/xml-colon-entity-expected.txt: Copied from LayoutTests/fast/parser/xml-colon-entity-expected.txt.
  • platform/mac-yosemite/fast/parser/xml-declaration-missing-ending-mark-expected.txt: Copied from LayoutTests/fast/parser/xml-declaration-missing-ending-mark-expected.txt.
  • platform/mac-yosemite/fast/xsl: Added.
  • platform/mac-yosemite/fast/xsl/xslt-extra-content-at-end-expected.png: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png.
  • platform/mac-yosemite/fast/xsl/xslt-extra-content-at-end-expected.txt: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt.
  • platform/mac-yosemite/fast/xsl/xslt-missing-namespace-in-xslt-expected.png: Copied from LayoutTests/platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.png.
  • platform/mac-yosemite/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt: Copied from LayoutTests/platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt.
  • platform/mac-yosemite/svg/custom: Added.
  • platform/mac-yosemite/svg/custom/bug78807-expected.txt: Copied from LayoutTests/svg/custom/bug78807-expected.txt.
  • platform/mac-yosemite/svg/custom/missing-xlink-expected.png: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.png.
  • platform/mac-yosemite/svg/custom/missing-xlink-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.txt.
  • platform/mac-yosemite/svg/custom/path-bad-data-expected.png: Copied from LayoutTests/platform/mac/svg/custom/path-bad-data-expected.png.
  • platform/mac-yosemite/svg/custom/path-bad-data-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/path-bad-data-expected.txt.
  • platform/mac-yosemite/svg/custom/use-font-face-crash-expected.png: Copied from LayoutTests/platform/mac/svg/custom/use-font-face-crash-expected.png.
  • platform/mac-yosemite/svg/custom/use-font-face-crash-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/use-font-face-crash-expected.txt.
  • platform/mac/fast/dom/adopt-attribute-crash-expected.txt: Added.
  • platform/mac/fast/parser/xml-colon-entity-expected.txt: Added.
  • platform/mac/fast/parser/xml-declaration-missing-ending-mark-expected.txt: Added.
  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png:
  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt:
  • platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.png:
  • platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
  • platform/mac/svg/custom/bug78807-expected.txt: Added.
  • platform/mac/svg/custom/missing-xlink-expected.png:
  • platform/mac/svg/custom/missing-xlink-expected.txt:
  • platform/mac/svg/custom/path-bad-data-expected.png:
  • platform/mac/svg/custom/path-bad-data-expected.txt:
  • platform/mac/svg/custom/use-font-face-crash-expected.png:
  • platform/mac/svg/custom/use-font-face-crash-expected.txt:
7:02 AM Changeset in webkit [187228] by msaboff@apple.com
  • 2 edits in trunk/LayoutTests

Application cache abort() tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=87633

These AppCache tests are flakey:
http/tests/appcache/deferred-events-delete-while-raising-timer.html
http/tests/appcache/deferred-events-delete-while-raising.html
http/tests/appcache/deferred-events.html
http/tests/appcache/fail-on-update-2.html

7:00 AM Changeset in webkit [187227] by Matt Baker
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: wrong cursor shown when selecting time interval from timeline overview
https://bugs.webkit.org/show_bug.cgi?id=147094

Reviewed by Timothy Hatcher.

  • UserInterface/Views/TimelineRuler.css:

(.timeline-ruler.allows-time-range-selection.creating-selection):
New cursor style for entire ruler element.

  • UserInterface/Views/TimelineRuler.js:

(WebInspector.TimelineRuler.prototype._handleMouseMove):
(WebInspector.TimelineRuler.prototype._handleMouseUp):
Toggle cursor style when dragging to create a new selection in the overview.

5:21 AM Changeset in webkit [187226] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/win

[Win] Fix typos in PluginViewWin.cpp: kWebPluginViewdowClassName -> kWebPluginViewClassName
https://bugs.webkit.org/show_bug.cgi?id=147214

Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-07-23
Reviewed by Csaba Osztrogonác.

  • Plugins/PluginViewWin.cpp:

(WebCore::registerPluginView):
(WebCore::PluginView::platformStart):

3:11 AM Changeset in webkit [187225] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore
Fix the build for IPHONE_OS_VERSION_MIN_REQUIRED <= 80200
!HAVE(AVKIT)
  • platform/ios/WebVideoFullscreenControllerAVKit.mm:

(elementRectInWindow):
This helper is only used in the #else block, so move it there.

3:05 AM Changeset in webkit [187224] by timothy_horton@apple.com
  • 1 edit
    1 delete in trunk/Source/WebKit2

Remove files that were meant to be removed in r173929

  • WebProcess/WebPage/mac/WebInspectorMac.mm: Removed.
2:58 AM Changeset in webkit [187223] by timothy_horton@apple.com
  • 1 edit
    1 delete in trunk/Source/WebKit2

Remove files that were meant to be removed in r168213

  • UIProcess/API/Cocoa/WKErrorRecoveryAttempting.h: Removed.
2:50 AM Changeset in webkit [187222] by timothy_horton@apple.com
  • 1 edit
    3 deletes in trunk/Source/WebKit2

Remove files that were meant to be removed in r168229

  • UIProcess/API/Cocoa/WKSession.h: Removed.
  • UIProcess/API/Cocoa/WKSession.mm: Removed.
  • UIProcess/API/Cocoa/WKSessionInternal.h: Removed.
2:18 AM Changeset in webkit [187221] by timothy_horton@apple.com
  • 1 edit
    2 deletes in trunk/Source/WebKit2

Remove files that were meant to be removed in r165014

  • WebProcess/WebPage/mac/WKAccessibilityWebPageObject.h: Removed.
  • WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm: Removed.
1:23 AM Changeset in webkit [187220] by Carlos Garcia Campos
  • 14 edits in trunk

[GTK] Add API to allow executing editing commands that require an argument
https://bugs.webkit.org/show_bug.cgi?id=146781

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Commands like InsertImage or CreateLink receive an argument, but
we only have webkit_web_view_execute_editing_command() that
doesn't receive any argument. This patch adds
webkit_web_view_execute_editing_command_with_argument() for those
commands. It also adds WEBKIT_EDITING_COMMAND_INSERT_IMAGE and
WEBKIT_EDITING_COMMAND_CREATE_LINK to the predefined editing commands.

  • UIProcess/API/gtk/WebKitEditingCommands.h: Add

WEBKIT_EDITING_COMMAND_INSERT_IMAGE and WEBKIT_EDITING_COMMAND_CREATE_LINK.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_execute_editing_command_with_argument):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Add new symbols.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::executeEditCommand): Pass also the argument
to the message.

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::executeEditCommand): Add the argument parameter
to the message handler.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Add argument parameter

to ExecuteEditCommand message.

Tools:

Add buttons to insert image/link to the MiniBrowser edit toolbar,
and test cases for insert image/link commands too.

  • MiniBrowser/gtk/BrowserWindow.c:

(insertImageCommandCallback):
(insertLinkCommandCallback):
(browserWindowSetupEditorToolbar):
(browserWindowConstructed):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:

(testWebViewEditorInsertImage):
(testWebViewEditorCreateLink):
(beforeAll):

12:58 AM Changeset in webkit [187219] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the build

  • platform/spi/cocoa/QuartzCoreSPI.h:
12:31 AM Changeset in webkit [187218] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unregistering and re-registering a user message handler does not work
https://bugs.webkit.org/show_bug.cgi?id=138142

Reviewed by Martin Robinson.

This has probably been fixed in r184846, enable the test case
blocked on it.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:

(testUserContentManagerScriptMessageReceived):

Jul 22, 2015:

10:44 PM Changeset in webkit [187217] by commit-queue@webkit.org
  • 14 edits in trunk

Add ENABLE_WEBASSEMBLY feature flag for WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=147212

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-07-22
Reviewed by Filip Pizlo.

.:

  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
10:31 PM Changeset in webkit [187216] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the build

  • platform/spi/cocoa/QuartzCoreSPI.h:
10:09 PM Changeset in webkit [187215] by timothy_horton@apple.com
  • 5 edits in trunk/Source

Use updated CoreAnimation snapshot SPI.
https://bugs.webkit.org/show_bug.cgi?id=147197
<rdar://problem/21032083>

Reviewed by Tim Horton.
Patch by James Savage.

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):

  • platform/spi/cocoa/QuartzCoreSPI.h:
9:58 PM Changeset in webkit [187214] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Simplify DFG::DesiredIdentifiers and make it possible to turn a UniquedStringImpl* into an identifierNumber at any time
https://bugs.webkit.org/show_bug.cgi?id=147218

Reviewed by Sam Weinig.

I want to be able to take a UniquedStringImpl* and turn it into an identifierNumber at
various points in my work on https://bugs.webkit.org/show_bug.cgi?id=146929. Currently,
most Nodes that deal with identifiers use identifierNumbers and you can only create an
identifierNumber in BytecodeGenerator. DFG::ByteCodeParser does sort of have the
ability to create new identifierNumbers when inlining - it takes the inlined code's
identifiers and either gives them new numbers or reuses numbers from the enclosing
code.

This patch takes that basic functionality and puts it in
DFG::DesiredIdentifiers::ensure(). Anyone can call this at any time to turn a
UniquedStringImpl* into an identifierNumber. This data structure is already used by
Plan to properly install any newly created identifier table entries into the CodeBlock.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::noticeArgumentsUse):
(JSC::DFG::ByteCodeParser::linkBlocks):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::buildOperandMapsIfNecessary): Deleted.

  • dfg/DFGDesiredIdentifiers.cpp:

(JSC::DFG::DesiredIdentifiers::DesiredIdentifiers):
(JSC::DFG::DesiredIdentifiers::numberOfIdentifiers):
(JSC::DFG::DesiredIdentifiers::ensure):
(JSC::DFG::DesiredIdentifiers::at):
(JSC::DFG::DesiredIdentifiers::addLazily): Deleted.

  • dfg/DFGDesiredIdentifiers.h:
9:51 PM Changeset in webkit [187213] by fpizlo@apple.com
  • 2 edits
    2 adds in trunk/Source/JavaScriptCore

Simplify things like CompareEq(@x,@x)
https://bugs.webkit.org/show_bug.cgi?id=145850

Reviewed by Sam Weinig.

This simplifies x==x to true, except in cases where x might be a double (in which case this
might still be false if x is NaN).

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • tests/stress/nan-equal-untyped.js: Added.

(foo):
(test):

  • tests/stress/nan-equal.js: Added.

(foo):

9:47 PM Changeset in webkit [187212] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the build

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):

9:45 PM Changeset in webkit [187211] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

Web Inspector: Timeline should immediately start moving play head when starting a new recording
https://bugs.webkit.org/show_bug.cgi?id=147210

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-22
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • inspector/protocol/Timeline.json:

Add timestamps to recordingStarted and recordingStopped events.

Source/WebCore:

Test: inspector/timeline/recording-start-stop-timestamps.html

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::internalStop):
Include the current timestamp when starting / stopping a recording.

Source/WebInspectorUI:

  • UserInterface/Protocol/TimelineObserver.js:

(WebInspector.TimelineObserver.prototype.recordingStarted):
(WebInspector.TimelineObserver.prototype.recordingStopped):
Pass on the new timestamps.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.capturingStarted):
(WebInspector.TimelineManager.prototype.capturingStopped):
Pass on the new timestamps in the events.

  • UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype._capturingStarted):
Pass on the new timestamp from the event as it can be used to update the currentTime.

(WebInspector.TimelineRecordingContentView.prototype._startUpdatingCurrentTime):
If provided a startTime we can use that as the new currentTime. Otherwise fallback
to determining a good currentTime from the next incoming record for legacy backends.

(WebInspector.TimelineRecordingContentView.prototype._recordingTimesUpdated):
Update the comment, as there is now a solution but this is required for legacy backends.

LayoutTests:

  • inspector/timeline/recording-start-stop-timestamps-expected.txt: Added.
  • inspector/timeline/recording-start-stop-timestamps.html: Added.

Add a test for Timeline.recordingStarted and Timeline.recordingStopped events.

9:24 PM Changeset in webkit [187210] by Wenson Hsieh
  • 3 edits
    2 adds in trunk

Coordinates-based snap offsets don't update correctly when container is scrolled
https://bugs.webkit.org/show_bug.cgi?id=147215

Reviewed by Brent Fulgham.

Source/WebCore:

Fixes the way we append the snap offsets of child elements with coordinates. We
now consider the scroll offset of the parent scroll snapping container, so snap
offset recomputations don't fail on scroll snapping containers.

Test: css3/scroll-snap/scroll-snap-coordinate-overflow-resize.html

  • page/scrolling/AxisScrollSnapOffsets.cpp:

(WebCore::appendChildSnapOffsets): Fixed to consider the scroll offset of the

parent container.

LayoutTests:

Tests that snap offsets update properly on scrolled containers.

  • css3/scroll-snap/scroll-snap-coordinate-overflow-resize-expected.txt: Added.
  • css3/scroll-snap/scroll-snap-coordinate-overflow-resize.html: Added.
9:18 PM Changeset in webkit [187209] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Timeline's Current Time does not jump forward to new start time when starting a new recording, causes timeline to appear delayed and broken
https://bugs.webkit.org/show_bug.cgi?id=147204

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-22
Reviewed by Timothy Hatcher.

  • UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype._recordingTimesUpdated):
We were skipping a timeline, but it might have a new event record with
a new start time. This ensures we get an updated current time which makes
sense, and we jump forward to that time in the main timeline.

9:15 PM Changeset in webkit [187208] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Needed to add methods to get PreviewCaptureLayers from Video
https://bugs.webkit.org/show_bug.cgi?id=147011
<rdar://problem/21861999>

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-22
Reviewed by Jer Noble.

  • platform/mediastream/mac/AVVideoCaptureSource.h: Added in preview

layer to class
(WebCore::AVVideoCaptureSource::previewLayer):

  • platform/mediastream/mac/AVVideoCaptureSource.mm: Instantiate

previewLayer on load
(WebCore::AVVideoCaptureSource::setupCaptureSession):

8:54 PM Changeset in webkit [187207] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: TimelineRuler shouldn't dispatch selection changed event unless it actually changes
https://bugs.webkit.org/show_bug.cgi?id=147219

Reviewed by Timothy Hatcher.

Moved to a "suppress next" model for suppressing dispatch of TimelineRuler's selection changed event. The
ruler's _timeRangeSelectionChanged flag is now reset only when an event is finally dispatched.

  • UserInterface/Views/TimelineRuler.js:

(WebInspector.TimelineRuler):
(WebInspector.TimelineRuler.prototype._updateSelection):
(WebInspector.TimelineRuler.prototype._dispatchTimeRangeSelectionChangedEvent):
Check for this._timeRangeSelectionChanged moved into dispatch function.
(WebInspector.TimelineRuler.prototype._handleMouseDown):
(WebInspector.TimelineRuler.prototype._handleMouseMove):
(WebInspector.TimelineRuler.prototype._handleMouseUp):
We now suppress the next dispatch only, rather than a toggle.

8:36 PM Changeset in webkit [187206] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] The "Missing Plug-in" buttons are not showing up on some flash contents
https://bugs.webkit.org/show_bug.cgi?id=147191

Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-07-22
Reviewed by Gyuyoung Kim.

Currently, WebKitEFL doesn't show the "Missing Plug-in" buttons if the plugin-related tags
don't have a "type" attribute. In such a case, WebCore tries to guess the MIME type from
the extensions by using MIMETypeRegistry::getMIMETypeForExtension(). For WebKitEFL,
MIMETypeRegistry::getMIMETypeForExtension() goes through |extensionMap|, which is a simple
array of <extension, mime type>, looking for the mime type for the given extension.
But |extensionMap| in MIMETypeRegistryEfl.cpp doesn't have the information for ".swf",
so WebCore fails to guess the MIME type and regard the content type as ObjectContentFrame,
not ObjectContentNetscapePlugin.

  • platform/efl/MIMETypeRegistryEfl.cpp:
7:36 PM Changeset in webkit [187205] by Yusuke Suzuki
  • 19 edits
    1 copy
    1 add in trunk/Source/JavaScriptCore

Introducing construct ability into JS executables
https://bugs.webkit.org/show_bug.cgi?id=147183

Reviewed by Geoffrey Garen.

Decouple the construct ability from the builtin functions.
Currently, all builtin functions are not constructors after r182995.
In that patch, when the given function is builtin JS function, we recognize it as the non-constructor function.

But, we need to relax it to implement some constructors in builtins JS.
By decoupling the construct ability from whether the function is builtin or not, we can provide

  1. constructors written in builtin JS
  2. non-constructors in normal JS functions

(1) is needed for Promise constructor.
And (2) is needed for method functions and arrow functions.

This patch introduces ConstructAbility into the unlinked function executables.
It holds whether the given JS function has the construct ability or not.
By leveraging this, this patch disables the construct ability of the method definitions, setters, getters and arrow functions.

And at the same time, this patch introduces the annotation for constructor in builtin JS.
We can define the function as follows,

constructor Promise(executor)
{

...

}

(JSC::BuiltinExecutables::createDefaultConstructor):
(JSC::BuiltinExecutables::createExecutableInternal):

  • builtins/BuiltinExecutables.h:
  • builtins/Iterator.prototype.js:

(symbolIterator):
(SymbolIterator): Deleted.

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):

  • bytecode/UnlinkedCodeBlock.h:
  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::makeFunction):

  • generate-js-builtins:

(getCopyright):
(Function):
(Function.init):
(Function.mangleName):
(getFunctions):
(mangleName): Deleted.

  • jit/JITOperations.cpp:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::setUpCall):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):

  • runtime/CodeCache.cpp:

(JSC::CodeCache::getFunctionExecutableFromGlobalCode):

  • runtime/CommonIdentifiers.h:
  • runtime/ConstructAbility.h: Copied from Source/JavaScriptCore/builtins/Iterator.prototype.js.
  • runtime/Executable.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::getConstructData):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • tests/stress/non-constructors.js: Added.

(shouldThrow):
(.prototype.method):
(.prototype.get getter):
(.prototype.set setter):
(.method):
(.get shouldThrow):
(.set shouldThrow):
(set var.test.get getter):
(set var.test.set setter):
(set var.test.normal):
(.set var):
(.set new):

6:54 PM Changeset in webkit [187204] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Rank sources for fitness for UIDs in bestSourcesForTypeAndConstraints
https://bugs.webkit.org/show_bug.cgi?id=147206
<rdar://problem/21950653>

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-22
Reviewed by Jer Noble.

  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::RealtimeMediaSource):

  • platform/mediastream/RealtimeMediaSource.h:

(WebCore::RealtimeMediaSource::fitnessScore):
(WebCore::RealtimeMediaSource::setFitnessScore):

  • platform/mediastream/mac/AVCaptureDeviceManager.mm:

(WebCore::AVCaptureDeviceManager::bestSourcesForTypeAndConstraints):

6:47 PM Changeset in webkit [187203] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

Video controls, though hidden, are still interactive when in PiP
https://bugs.webkit.org/show_bug.cgi?id=147216
<rdar://problem/21012688>

Reviewed by Simon Fraser.

Explicitly add the PiP class to the controls container so that
we can hang a pointer-events: none off it.

  • Modules/mediacontrols/mediaControlsiOS.css:

(video::-webkit-media-controls-panel.picture-in-picture): Add a pointer-events: none.

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.handlePresentationModeChange): Add/remove a PiP class
to the controls panel when necessary.

6:21 PM Changeset in webkit [187202] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r187196.
https://bugs.webkit.org/show_bug.cgi?id=147213

broke all the iOS builds (Requested by thorton on #webkit).

Reverted changeset:

"Use updated CoreAnimation snapshot SPI."
https://bugs.webkit.org/show_bug.cgi?id=147197
http://trac.webkit.org/changeset/187196

6:20 PM Changeset in webkit [187201] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.8-branch/Source

Versioning.

6:19 PM Changeset in webkit [187200] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-600.8.5

New Tag.

6:19 PM Changeset in webkit [187199] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the build

  • UIProcess/ios/WKContentViewInteraction.h:
6:08 PM Changeset in webkit [187198] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] Adjust the preview architecture
https://bugs.webkit.org/show_bug.cgi?id=147203
<rdar://problem/21945775>

Reviewed by Simon Fraser.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _dataForPreviewItemController:atPosition:type:]):
Link previews should win over image previews if both are possible.

5:57 PM Changeset in webkit [187197] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.42

New tag.

5:53 PM Changeset in webkit [187196] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Use updated CoreAnimation snapshot SPI.
https://bugs.webkit.org/show_bug.cgi?id=147197

Patch by James Savage <James Savage> on 2015-07-22
Reviewed by Tim Horton.

Source/WebCore:

  • platform/spi/cocoa/QuartzCoreSPI.h:

Source/WebKit2:

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):

5:44 PM Changeset in webkit [187195] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION (Safari 7): Pseudo element rules are not labelled with media queries in Styles panel
https://bugs.webkit.org/show_bug.cgi?id=147207

Reviewed by Timothy Hatcher.

  • UserInterface/Views/RulesStyleDetailsPanel.js:

(WebInspector.RulesStyleDetailsPanel.prototype.refresh.insertMediaOrInheritanceLabel):
(WebInspector.RulesStyleDetailsPanel.prototype.refresh.insertAllMatchingPseudoStyles):
Now inserts pseudo-styles based on whether their selector specificity is greater than
the previous style's selector specificity.
(WebInspector.RulesStyleDetailsPanel.prototype.refresh):

5:04 PM Changeset in webkit [187194] by mmaxfield@apple.com
  • 2 edits in trunk/LayoutTests

[El Capitan] Test Gardening

Unreviewed.

  • platform/mac/fast/text/ligature-subdivision-expected.txt:
4:23 PM Changeset in webkit [187193] by timothy_horton@apple.com
  • 6 edits in trunk/Source/WebKit2

[iOS] Adjust the preview architecture
https://bugs.webkit.org/show_bug.cgi?id=147203
<rdar://problem/21945775>

Reviewed by Beth Dakin.

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setAllowsLinkPreview:]): Deleted.

  • UIProcess/ios/WKContentView.mm:

(-[WKContentView willMoveToWindow:]): Deleted.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _registerPreview]):
(-[WKContentView _unregisterPreview]):
(-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]):
(-[WKContentView _dataForPreviewItemController:atPosition:type:]):
(-[WKContentView _presentationRectForPreviewItemController:]):
(-[WKContentView _presentedViewControllerForPreviewItemController:]):
(-[WKContentView _previewItemController:commitPreview:]):
(-[WKContentView _previewItemController:willPresentPreview:forPosition:inSourceView:]):
(-[WKContentView _previewItemController:didDismissPreview:committing:]):
(-[WKContentView _presentationSnapshotForPreviewItemController:]):
(-[WKContentView _presentationRectsForPreviewItemController:]):
(-[WKContentView gestureRecognizerShouldBegin:]): Deleted.
(-[WKContentView _registerPreviewInWindow:]): Deleted.
(-[WKContentView _unregisterPreviewInWindow:]): Deleted.
(-[WKContentView previewViewControllerForPosition:inSourceView:]): Deleted.
(-[WKContentView commitPreviewViewController:]): Deleted.
(-[WKContentView willPresentPreviewViewController:forPosition:inSourceView:]): Deleted.
(-[WKContentView didDismissPreviewViewController:committing:]): Deleted.
Register and unregister in setup/cleanupInteraction instead of when moving between windows.
Implement 'shouldBegin' instead of interacting directly with the recognizer.
Make use of system enums instead of our own.
Let UIPreviewItemController handle shrink-wrapping and the indicator view.

3:51 PM Changeset in webkit [187192] by matthew_hanson@apple.com
  • 1 edit
    1 add in branches/safari-600.8-branch/Tools

Add ModalAlertsSPI.cpp, which was missed in the merge of r185915.

Reviewed by Jeff Miller.

  • TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp: Added.
3:51 PM Changeset in webkit [187191] by Gyuyoung Kim
  • 4 edits
    2 copies
    4 moves
    3 adds in trunk/Source/WebKit2

[EFL] Support indexeddb for WK2
https://bugs.webkit.org/show_bug.cgi?id=145867

Reviewed by Csaba Osztrogonác.

Add stub implementation for indexeddb. Move KeyedDecoder and KeyedEncoder from gtk to glib
in order to share it between GTK and EFL ports.

  • DatabaseProcess/EntryPoint/unix/DatabaseProcessMain.cpp:
  • DatabaseProcess/efl/DatabaseProcessMainEfl.cpp: Copied from Source/WebKit2/DatabaseProcess/EntryPoint/unix/DatabaseProcessMain.cpp.

(WebKit::DatabaseProcessMainUnix):

  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • Shared/glib/KeyedDecoder.cpp: Renamed from Source/WebKit2/Shared/gtk/KeyedDecoder.cpp.

(WebKit::KeyedDecoder::KeyedDecoder):
(WebKit::KeyedDecoder::~KeyedDecoder):
(WebKit::KeyedDecoder::dictionaryFromGVariant):
(WebKit::KeyedDecoder::decodeBytes):
(WebKit::KeyedDecoder::decodeSimpleValue):
(WebKit::KeyedDecoder::decodeBool):
(WebKit::KeyedDecoder::decodeUInt32):
(WebKit::KeyedDecoder::decodeInt32):
(WebKit::KeyedDecoder::decodeInt64):
(WebKit::KeyedDecoder::decodeFloat):
(WebKit::KeyedDecoder::decodeDouble):
(WebKit::KeyedDecoder::decodeString):
(WebKit::KeyedDecoder::beginObject):
(WebKit::KeyedDecoder::endObject):
(WebKit::KeyedDecoder::beginArray):
(WebKit::KeyedDecoder::beginArrayElement):
(WebKit::KeyedDecoder::endArrayElement):
(WebKit::KeyedDecoder::endArray):

  • Shared/glib/KeyedDecoder.h: Renamed from Source/WebKit2/Shared/gtk/KeyedDecoder.h.
  • Shared/glib/KeyedEncoder.cpp: Renamed from Source/WebKit2/Shared/gtk/KeyedEncoder.cpp.

(WebKit::KeyedEncoder::KeyedEncoder):
(WebKit::KeyedEncoder::~KeyedEncoder):
(WebKit::KeyedEncoder::encodeBytes):
(WebKit::KeyedEncoder::encodeBool):
(WebKit::KeyedEncoder::encodeUInt32):
(WebKit::KeyedEncoder::encodeInt32):
(WebKit::KeyedEncoder::encodeInt64):
(WebKit::KeyedEncoder::encodeFloat):
(WebKit::KeyedEncoder::encodeDouble):
(WebKit::KeyedEncoder::encodeString):
(WebKit::KeyedEncoder::beginObject):
(WebKit::KeyedEncoder::endObject):
(WebKit::KeyedEncoder::beginArray):
(WebKit::KeyedEncoder::beginArrayElement):
(WebKit::KeyedEncoder::endArrayElement):
(WebKit::KeyedEncoder::endArray):
(WebKit::KeyedEncoder::finishEncoding):

  • Shared/glib/KeyedEncoder.h: Renamed from Source/WebKit2/Shared/gtk/KeyedEncoder.h.
  • UIProcess/Databases/efl/DatabaseProcessProxyEfl.cpp: Copied from Source/WebKit2/DatabaseProcess/EntryPoint/unix/DatabaseProcessMain.cpp.

(WebKit::DatabaseProcessProxy::platformGetLaunchOptions):

3:09 PM Changeset in webkit [187190] by Michael Catanzaro
  • 2 edits in trunk/Source/WebKit2

[Seccomp] Canonicalize filesystem path when whitelisting it
https://bugs.webkit.org/show_bug.cgi?id=142986

Reviewed by Žan Doberšek.

  • Shared/linux/SeccompFilters/SyscallPolicy.cpp:

(WebKit::canonicalizeFileName):
(WebKit::SyscallPolicy::addFilePermission):
(WebKit::SyscallPolicy::addDirectoryPermission):

2:55 PM Changeset in webkit [187189] by dino@apple.com
  • 4 edits
    2 adds in trunk

Out of bounds in WebGLRenderingContext::simulateVertexAttrib0
https://bugs.webkit.org/show_bug.cgi?id=147176
<rdar://problem/21567767>

Reviewed by Oliver Hunt.

Source/WebCore:

Test: fast/canvas/webgl/out-of-bounds-simulated-vertexAttrib0-drawArrays.html

Add overflow checking for the drawing calls, specifically the way
they may simulate vertexAttrib0.

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::validateDrawArrays): Call new validation method.
(WebCore::WebGLRenderingContextBase::validateDrawElements): Ditto.
(WebCore::WebGLRenderingContextBase::validateSimulatedVertexAttrib0): New method that
validates the parameters used to create the simulated attribute.
(WebCore::WebGLRenderingContextBase::simulateVertexAttrib0): No need to do overflow
checking here now that the validation method does it for us.
(WebCore::WebGLRenderingContextBase::validateVertexAttributes): Deleted.

  • html/canvas/WebGLRenderingContextBase.h: Add new validation method.

LayoutTests:

  • fast/canvas/webgl/out-of-bounds-simulated-vertexAttrib0-drawArrays-expected.txt: Added.
  • fast/canvas/webgl/out-of-bounds-simulated-vertexAttrib0-drawArrays.html: Added.
2:42 PM Changeset in webkit [187188] by Brent Fulgham
  • 1 edit
    11 adds in trunk/Websites/webkit.org

Add some images needed for an upcoming blog post.

  • blog-files/backdrop-filters: Added.
  • blog-files/backdrop-filters/Screen_OSX_Yosemite_Finder-iCloud-WaterBg_1x.jpg: Added.
  • blog-files/backdrop-filters/Screen_OSX_Yosemite_Finder-iCloud-WaterBg_2x.jpg: Added.
  • blog-files/backdrop-filters/Screen_V_iOS8_ControlCenter_BlueGradient_1x.jpg: Added.
  • blog-files/backdrop-filters/Screen_V_iOS8_ControlCenter_BlueGradient_2x.jpg: Added.
  • blog-files/backdrop-filters/backdrop_correct_1x.jpg: Added.
  • blog-files/backdrop-filters/backdrop_correct_2x.jpg: Added.
  • blog-files/backdrop-filters/backdrop_invert_1x.jpg: Added.
  • blog-files/backdrop-filters/backdrop_invert_2x.jpg: Added.
  • blog-files/backdrop-filters/backdrop_mixed_1x.jpg: Added.
  • blog-files/backdrop-filters/backdrop_mixed_2x.jpg: Added.
2:41 PM Changeset in webkit [187187] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187183. rdar://problem/21930899

2:40 PM Changeset in webkit [187186] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187181. rdar://problem/21928170

2:36 PM Changeset in webkit [187185] by commit-queue@webkit.org
  • 11 edits in trunk

Web Inspector: AppCache manifest 404 doesn't produce errors in console, manifest resource request always loading indicator
https://bugs.webkit.org/show_bug.cgi?id=147135

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-22
Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didReceiveResponse):
Always pass a document loader instead of passing null for the manifest request.

(WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
Since we will be cancelling the resource handle ourselves in didReceiveResponse
before receiving the didFail resource handle delegates, we should update the
inspector about this resource load failing due to a cancel.

(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
Update the MessageSource from "Other" to "AppCache".

LayoutTests:

  • http/tests/appcache/404-manifest-expected.txt:
  • http/tests/appcache/abort-cache-ondownloading-manifest-404-expected.txt:
  • http/tests/appcache/deferred-events-delete-while-raising-expected.txt:
  • http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt:
  • http/tests/appcache/deferred-events-expected.txt:
  • http/tests/appcache/fail-on-update-2-expected.txt:
  • http/tests/appcache/fail-on-update-expected.txt:
  • http/tests/appcache/remove-cache-expected.txt:

Update with new Console errors about manifest 404s.

2:31 PM Changeset in webkit [187184] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Enable exception fuzzing for GCC too
https://bugs.webkit.org/show_bug.cgi?id=146831

Reviewed by Darin Adler.

  • jit/JITOperations.cpp:
2:31 PM Changeset in webkit [187183] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix fullscreen and PiP video animation and sizing regressions.
https://bugs.webkit.org/show_bug.cgi?id=147189
<rdar://problem/21930899>

Patch by Jeremy Jones <jeremyj@apple.com> on 2015-07-22
Reviewed by Jer Noble.

Fixes WK1 specific regressions introduced by r187044. Flicker when entering fullscreen,
wrong animation and missing initial animation rects.

  • platform/ios/WebVideoFullscreenControllerAVKit.mm:

(elementRectInWindow): Added.
(WebVideoFullscreenControllerContext::didSetupFullscreen): Clear background decreases flash.
(WebVideoFullscreenControllerContext::fullscreenMayReturnToInline): Use consistent inline rect.
(WebVideoFullscreenControllerContext::setVideoLayerFrame):
Clear the transform on the web thread instead of on the UI thread.
(WebVideoFullscreenControllerContext::setUpFullscreen): Use consistent inline rect.
(WebVideoFullscreenControllerContext::exitFullscreen): Use consistent inline rect.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerLayer resolveBounds]): Clear transform after setting frame.

2:29 PM Changeset in webkit [187182] by jhoneycutt@apple.com
  • 2 edits in trunk/Tools

Add --ios-simulator to run-api-tests --help.

Rubber-stamped by Dan Bates.

  • Scripts/run-api-tests:
2:27 PM Changeset in webkit [187181] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Adopt AVKit's AVSimplePlayerLayerView change for PiP.
https://bugs.webkit.org/show_bug.cgi?id=147186
<rdar://problem/21928170>

Patch by Jeremy Jones <jeremyj@apple.com> on 2015-07-22
Reviewed by Jer Noble.

Adopt AVKit changes by inheriting from UIView instead of from AVPictureInPicturePlayerLayerView.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebAVPlayerLayerView_layerClass): Style.
(WebAVPlayerLayerView_playerController): Style.
(WebAVPlayerLayerView_videoView): Style.
(getWebAVPictureInPicturePlayerLayerViewClass): Inherit from UIView.

2:06 PM Changeset in webkit [187180] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.17-branch/Source/WebKit2

Merged r187174. rdar://problem/21877914

2:03 PM Changeset in webkit [187179] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.17-branch/Source

Versioning.

1:59 PM Changeset in webkit [187178] by Simon Fraser
  • 3 edits in trunk/Source/WebKit2

Add logging for TiledCoreAnimationDrawingArea resizing
https://bugs.webkit.org/show_bug.cgi?id=147180

Reviewed by Tim Horton.

Add a "Resize" log channel for WebKit2, and use it to log data in scaleViewToFitDocumentIfNeeded().

  • Platform/Logging.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded):

1:49 PM Changeset in webkit [187177] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

Introduce release assert for using threads before threading is initialized
https://bugs.webkit.org/show_bug.cgi?id=147200

Reviewed by Michael Saboff.

This will help bugs where you use createThread() before calling initializeThreading().

  • wtf/ThreadIdentifierDataPthreads.cpp:

(WTF::ThreadIdentifierData::initialize):

1:36 PM Changeset in webkit [187176] by matthew_hanson@apple.com
  • 11 edits in branches/safari-600.8-branch

Merge r185915. rdar://problem/21716368

1:31 PM Changeset in webkit [187175] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fixed pool allocation should always be aligned
https://bugs.webkit.org/show_bug.cgi?id=147201

Reviewed by Simon Fraser.

Passing an unaligned size to the allocator can cause asserts or even worse things. The
Options reservation value isn't going to be aligned.

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):

12:56 PM Changeset in webkit [187174] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Encode/Decode underlying errors when serializing NSErrors
<rdar://problem/21818117>
https://bugs.webkit.org/show_bug.cgi?id=147199

Reviewed by Anders Carlsson.

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<CertificateInfo>::decode):
(IPC::encodeNSError):
(IPC::ArgumentCoder<ResourceError>::encodePlatformData):
(IPC::decodeNSError):
(IPC::ArgumentCoder<ResourceError>::decodePlatformData):
Break out encoding/decoding of the NSErrors into a helpers so they can be called
for the underlying error.

12:15 PM Changeset in webkit [187173] by Beth Dakin
  • 9 edits in trunk/Source

Animated images should animate in previews
https://bugs.webkit.org/show_bug.cgi?id=147173
-and corresponding-
rdar://problem/21637698

Reviewed by Dan Bernstein.

Source/WebCore:

New virtual function to indicate whether or not the image is animated.

  • platform/graphics/BitmapImage.h:
  • platform/graphics/Image.h:

(WebCore::Image::isAnimated):

Source/WebKit2:

InteractionInformationAtPosition needs to know if it’s an animated image.

  • Shared/InteractionInformationAtPosition.cpp:

(WebKit::InteractionInformationAtPosition::encode):
(WebKit::InteractionInformationAtPosition::decode):

  • Shared/InteractionInformationAtPosition.h:

New delegate method to create a link preview view controller for animated
images.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:

Treat animated images more like link previews.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView previewViewControllerForPosition:inSourceView:]):

Set info.isAnimatedImage

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation):

12:00 PM Changeset in webkit [187172] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
https://bugs.webkit.org/show_bug.cgi?id=147043

Patch by Jason Marcell <jmarcell@apple.com> on 2015-07-22
Reviewed by Daniel Bates and Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:

(Buildbot.prototype._normalizeQueueInfo):
The _normalizeQueueInfo method now calls the defaultBranches getter instead of using hardcoded values
in cases where the queue.branch property is not set and the queue is not a combined queue.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:

(BuildbotCombinedQueueView):
Ensuring uniformity of repository branches within a combined queue.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot.prototype.get defaultBranches):
Added; provides a WebKit-specific implementation that sets the queue.branches dictionary to have a
single entry for "openSource" as the default set of branches. Note that we intentionally omitted a
base class implementation of the defaultBranches getter so as to cause a JavaScript TypeError when a
sub-queue of a combined queue does not specify property branch and the derived Buildbot class does not
implement defaultBranches so that a person can either update the definition of the sub-queue or
implement defaultBranches in the derived Buildbot class they are using.

11:52 AM Changeset in webkit [187171] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[WinCairo] SVG path not rendered with all-zero dasharray
https://bugs.webkit.org/show_bug.cgi?id=146997

Patch by Jinyoung Hur <hur.ims@navercorp.com> on 2015-07-22
Reviewed by Martin Robinson.

Source/WebCore:

All-zero dash array should not be passed to cairo_set_dash() as an argument, because it will cause an internal Cairo error.
Rather call cairo_set_dash() with num_dashes=0 to disable dash line.

Tests: fast/canvas/canvas-lineDash.html

svg/custom/zero-dasharray.html

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::setLineDash):

LayoutTests:

Canvas 2D context and SVG stroke tests with all-zero dash array are added.

  • fast/canvas/canvas-lineDash-expected.txt:
  • fast/canvas/script-tests/canvas-lineDash.js:
  • svg/custom/zero-dasharray.html: Added
  • svg/custom/zero-dasharray-expected.html: Added
11:47 AM Changeset in webkit [187170] by Wenson Hsieh
  • 2 edits in trunk/Source/WebCore

Search fields render placeholder text improperly.
https://bugs.webkit.org/show_bug.cgi?id=147192
<rdar://problem/21901076>

Reviewed by Alexey Proskuryakov.

Due to changes in the way AppKit renders search inputs, we must now explicitly
set the placeholder text of a search input rendered using the Mac theme to be
an empty string when rendering the search input box (not including the actual
placeholder text).

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::setSearchCellState): Force the placeholder text of

the NSSearchFieldCell for the Mac theme to be an empty string.

11:14 AM Changeset in webkit [187169] by achristensen@apple.com
  • 3 edits in trunk/Tools

Switch WinCairo build to use CMake.
https://bugs.webkit.org/show_bug.cgi?id=147169

Reviewed by Brent Fulgham.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(determineConfiguration):
(determineArchitecture):
(determinePassedConfiguration):
(passedConfiguration):
(jhbuildWrapperPrefixIfNeeded):
(generateBuildSystemFromCMakeProject):
It's CMake time! We now use the CMake files to generate a solution in WebKitBuild/Release/WebKit.sln and build that.

11:09 AM Changeset in webkit [187168] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

Need the ability to give only best source UIDs to UserMedia request
https://bugs.webkit.org/show_bug.cgi?id=147171
<rdar://problem/21931121>

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-22
Reviewed by Eric Carlson.

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::constraintsValidated):

  • Modules/mediastream/UserMediaRequest.h:

(WebCore::UserMediaRequest::videoDeviceUIDs):
(WebCore::UserMediaRequest::audioDeviceUIDs):

  • platform/mediastream/MediaStreamCreationClient.h:
  • platform/mediastream/mac/AVCaptureDeviceManager.h:
  • platform/mediastream/mac/AVCaptureDeviceManager.mm:

(WebCore::AVCaptureDeviceManager::bestSourcesForTypeAndConstraints):
(WebCore::AVCaptureDeviceManager::bestSourceForTypeAndConstraints): Deleted.

  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::validateRequestConstraints):
(WebCore::RealtimeMediaSourceCenterMac::createMediaStream):

  • platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::validateRequestConstraints):

11:04 AM Changeset in webkit [187167] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Enable STATIC_ASSERT_IS_TRIVIALLY_DESTRUCTIBLE for GCC
https://bugs.webkit.org/show_bug.cgi?id=146829

Reviewed by Brent Fulgham.

  • heap/GCAssertions.h:
10:56 AM Changeset in webkit [187166] by basile_clement@apple.com
  • 39 edits
    5 adds in branches/jsc-tailcall

jsc-tailcall: Add new opcodes for tail calls
https://bugs.webkit.org/show_bug.cgi?id=146484

Reviewed by Michael Saboff.

Source/JavaScriptCore:

This patch introduces two new opcodes, op_tail_call and
op_tail_call_varargs, to perform tail calls, and implements them in the
LLInt and baseline JIT. Their use prevents DFG and FTL compilation for
now. They are currently implemented by sliding the call frame and
masquerading as our own caller right before performing an actual call.

This required to change the operationLink family of operation to return
a SlowPathReturnType instead of a char* in order to distinguish between
exception cases (must not trash the caller frame) and actual call case
(must trash the caller frame).

This is also a semantics change, since the Function.caller property is
now leaking tail calls. Since tail calls are only used in strict mode,
which poisons this property, the only way of seeing this semantics
change is when a sloppy function calls a strict function that then
tail-calls a sloppy function. Previously, the second sloppy function's
caller would have been the strict function (i.e. raises a TypeError
when the .caller attribute is accessed), while it is now the first
sloppy function.

Finally, this patch adds a couple of tests to check that tail calls run
in constant stack space, as well as tests checking that tail calls are
recognized correctly. Those tests use the handy aforementioned leaking
of tail calls through Function.caller. Moreover, this patch also adds
(as per the spec) statements following a label as tail positions, and
removes the body of a with statement (in disagreement with the spec) as
a tail position since with statements are not allowed in strict mode.

  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::nearTailCall):
(JSC::MacroAssemblerARM::linkCall):

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::nearTailCall):
(JSC::MacroAssemblerARM64::linkCall):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::nearTailCall):
(JSC::MacroAssemblerARMv7::linkCall):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::nearTailCall):
(JSC::MacroAssemblerMIPS::linkCall):

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::nearTailCall):
(JSC::MacroAssemblerSH4::linkCall):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::linkCall):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::nearTailCall):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::linkCall):

  • assembler/RepatchBuffer.h:

(JSC::RepatchBuffer::relink):

  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::callTypeFor):
(JSC::CallLinkInfo::isVarargsCallType):
(JSC::CallLinkInfo::isTailCallType):
(JSC::CallLinkInfo::setSlowStub):
(JSC::CallLinkInfo::clearSlowStub):
(JSC::CallLinkInfo::slowStub):

  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFromLLInt):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitTailCall):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitTailCallVarargs):

  • bytecompiler/NodesCodegen.cpp:

(JSC::LabelNode::emitBytecode):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • ftl/FTLJSCallBase.cpp:

(JSC::FTL::JSCallBase::link):

  • interpreter/Interpreter.h:

(JSC::Interpreter::isCallBytecode):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::emit_op_tail_call):
(JSC::JIT::emit_op_tail_call_varargs):
(JSC::JIT::emitSlow_op_tail_call):
(JSC::JIT::emitSlow_op_tail_call_varargs):

  • jit/JITCall32_64.cpp:

(JSC::JIT::emitSlow_op_tail_call):
(JSC::JIT::emitSlow_op_tail_call_varargs):
(JSC::JIT::emit_op_tail_call):
(JSC::JIT::emit_op_tail_call_varargs):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):

  • jit/JITInlines.h:

(JSC::JIT::emitNakedTailCall):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:

(JSC::operationLinkFor):
(JSC::operationVirtualFor):
(JSC::operationLinkPolymorphicCallFor):

  • jit/Repatch.cpp:

(JSC::generateByIdStub):
(JSC::linkSlowFor):
(JSC::linkFor):
(JSC::revertCall):
(JSC::unlinkFor):
(JSC::linkVirtualFor):
(JSC::linkPolymorphicCall):

  • jit/ThunkGenerators.cpp:

(JSC::slowPathFor):
(JSC::linkThunkFor):
(JSC::linkCallThunk):
(JSC::linkCallThunkGenerator):
(JSC::linkConstructThunkGenerator):
(JSC::linkCallThatPreservesRegsThunkGenerator):
(JSC::linkConstructThatPreservesRegsThunkGenerator):
(JSC::linkPolymorphicCallThunkFor):
(JSC::linkPolymorphicCallThunk):
(JSC::linkPolymorphicCallThunkGenerator):
(JSC::linkPolymorphicCallThatPreservesRegsThunkGenerator):
(JSC::virtualThunkFor):
(JSC::virtualThunk):
(JSC::virtualCallThunkGenerator):
(JSC::virtualConstructThunkGenerator):
(JSC::virtualCallThatPreservesRegsThunkGenerator):
(JSC::virtualConstructThatPreservesRegsThunkGenerator):
(JSC::unreachableGenerator):
(JSC::prepareForTailCall):

  • jit/ThunkGenerators.h:
  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • tests/stress/mutual-tail-call-no-stack-overflow.js: Added.

(shouldThrow):
(sloppyCountdown.even):
(sloppyCountdown.odd):
(strictCountdown.even):
(strictCountdown.odd):
(strictCountdown):

  • tests/stress/tail-call-no-stack-overflow.js: Added.

(shouldThrow):
(strictLoop):

  • tests/stress/tail-call-recognize.js: Added.

(callerMustBeRun):
(callerMustBeStrict):
(runTests):

  • tests/stress/tail-call-varargs-no-stack-overflow.js: Added.

(shouldThrow):
(strictLoop):

LayoutTests:

  • js/caller-property-expected.txt:
  • js/script-tests/caller-property.js: Function.caller has had semantics change: it nows leaks tail calls

(strictCaller):
(strictTailCaller):

  • js/script-tests/class-syntax-super.js:
  • js/script-tests/dfg-strict-mode-to-this.js: Temporarily disabled since it has a tail call and requires DFG
10:21 AM Changeset in webkit [187165] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Source/WebCore:
Fix toJSDOMWindow() in the case of an object that has the actual JS DOM window in its prototype chain.
https://bugs.webkit.org/show_bug.cgi?id=146785

Patch by Mark Dittmer <mark.s.dittmer@gmail.com> on 2015-07-22
Reviewed by Mark Lam.

  • bindings/js/JSDOMWindowBase.cpp: toJSDOMWindow(): Walk the prototype chain of the given JSValue until a JSDOMWindow or JSDOMWindowShell is found.

LayoutTests:
New test: Object.create(window).location will trigger a crash when toJSDOMWindow() returns NULL on an object that have the JS DOM Window in its prototype chain.
https://bugs.webkit.org/show_bug.cgi?id=146785

Patch by Mark Dittmer <mark.s.dittmer@gmail.com> on 2015-07-22
Reviewed by Mark Lam.

  • js/property-of-window-as-prototype-expected.txt:
  • js/property-of-window-as-prototype.html:
10:17 AM Changeset in webkit [187164] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove revealing getVideoTracks() and getAudioTracks()
https://bugs.webkit.org/show_bug.cgi?id=147126
<rdar://problem/21908723>

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-22
Reviewed by Eric Carlson.

  • Modules/mediastream/MediaStream.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::MediaPlayerPrivateMediaStreamAVFObjC):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::load): Modded to use
tracks() instead of getVideo/AudioTracks()
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::platformLayer): Ditto
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::playInternal): Ditto
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::pauseInternal): Ditto
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setMuted): Ditto
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::naturalSize): Ditto
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::hasVideo): Ditto
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::hasAudio): Ditto
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::currentMediaTime):
Changed to a FIXME

  • platform/mediastream/MediaStreamPrivate.h:
10:12 AM Changeset in webkit [187163] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Ensure MediaPlayerPrivateAVFoundation doesn't load MediaStreams
https://bugs.webkit.org/show_bug.cgi?id=147119
<rdar://problem/21904955>

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-22
Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Set

networkstate to error when loading MediaStreams

10:09 AM Changeset in webkit [187162] by ap@apple.com
  • 5 edits in branches/safari-601.1-branch

Merge r186980.

2015-07-17 Simon Fraser <Simon Fraser>

Attempt to fix the build.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::webkitCurrentPlaybackTargetIsWireless):
  • html/HTMLMediaElement.h:
10:04 AM Changeset in webkit [187161] by achristensen@apple.com
  • 16 edits in trunk

Fix quirks in CMake build on Mac and Windows
https://bugs.webkit.org/show_bug.cgi?id=147174

Reviewed by Gyuyoung Kim.

.:

  • CMakeLists.txt:
  • Source/cmake/OptionsWindows.cmake:

Added options I removed in r187022. They are indeed needed.

  • Source/cmake/WebKitFS.cmake:

Make the DerivedSources/WebKit directory.

Source/JavaScriptCore:

  • PlatformMac.cmake:

Add JSRemoteInspector.cpp and remove semicolon from command to make it actually run.

Source/WebCore:

  • PlatformMac.cmake:

Removed files that don't exist any more.

  • platform/win/WindowsTouch.h:

Only use definitions of touch structures when compiling with VS2012.

Source/WebKit:

  • PlatformMac.cmake:

Fixed syntax, removed files that don't exist any more.

Source/WebKit/win:

  • WebView.cpp:

Include winuser.h to get definitions of touch-related structures like tagGESTUREINFO.

Tools:

  • CMakeLists.txt:

Don't build DumpRenderTree with CMake for now (until we get that working).

  • WinLauncher/CMakeLists.txt:

Renamed WinLauncherLauncher to WinLauncher and WinLauncher to WinLauncherLib to match the Visual Studio build.

9:08 AM Changeset in webkit [187160] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix cast-align warning in NetworkStateNotifierEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=145915

Reviewed by Gyuyoung Kim.

  • platform/network/efl/NetworkStateNotifierEfl.cpp:

(WebCore::NetworkStateNotifier::readSocketCallback):

8:56 AM Changeset in webkit [187159] by Michael Catanzaro
  • 3 edits
    2 adds in trunk/Source/WebKit2

[Seccomp Filters] Add helpers to get XDG base directory locations
https://bugs.webkit.org/show_bug.cgi?id=142982

Reviewed by Zan Dobersek.

  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • Shared/linux/SeccompFilters/XDGBaseDirectory.h: Added.
  • Shared/linux/SeccompFilters/XDGBaseDirectoryGLib.cpp: Added.

(WebKit::userHomeDirectory):
(WebKit::userCacheDirectory):
(WebKit::userConfigDirectory):
(WebKit::userDataDirectory):
(WebKit::userRuntimeDirectory):

8:44 AM Changeset in webkit [187158] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Change syntax highlighting color for regular expressions to make them more readable
https://bugs.webkit.org/show_bug.cgi?id=146956

Reviewed by Timothy Hatcher.

  • UserInterface/Views/FormattedValue.css:

(.formatted-regexp):

  • UserInterface/Views/SyntaxHighlightingDefaultTheme.css:

(.syntax-highlighted :matches(.css-string, .javascript-string, .html-attribute-value)):
(.syntax-highlighted .javascript-regexp):
(.syntax-highlighted :matches(.css-string, .javascript-string, .javascript-regexp, .html-attribute-value)): Deleted.

7:57 AM Changeset in webkit [187157] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Swedish translation
https://bugs.webkit.org/show_bug.cgi?id=147190

Patch by Josef Andersson <josef.andersson@fripost.org> on 2015-07-22

  • sv.po:
7:53 AM Changeset in webkit [187156] by Gyuyoung Kim
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2ContextTestMultipleProcesses.ewk_context_network_process_model fails to pass
https://bugs.webkit.org/show_bug.cgi?id=142967

Reviewed by Csaba Osztrogonác.

Though processIdentifier() can return 0 when a page is not closed, ewk_context_network_process_model has
not been considered process id can be 0. This patch adds a protection logic which doesn't test when process
id is 0 at the moment.

  • UIProcess/API/efl/tests/test_ewk2_context.cpp:

(TEST_F):

6:20 AM Changeset in webkit [187155] by ryuan.choi@navercorp.com
  • 3 edits in trunk/Source/WebCore

[GTK][EFL] Remove dead functions in LocalizedStrings
https://bugs.webkit.org/show_bug.cgi?id=147188

Reviewed by Csaba Osztrogonác.

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::contextMenuItemTagHideMediaControls):
(WebCore::contextMenuitemTagHideMediaControls): Fixed typo since r152117.
(WebCore::inactivePluginText): Deleted since r151530.
(WebCore::textTrackClosedCaptionsText): Deleted since r141864.

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::inactivePluginText): Deleted since r151530.
(WebCore::textTrackClosedCaptionsText): Deleted since r141864.

1:15 AM Changeset in webkit [187154] by calvaris@igalia.com
  • 3 edits in trunk/Tools

[check-webkit-style] .lut.h files shouldn't raise a sorting issue
https://bugs.webkit.org/show_bug.cgi?id=147146

Reviewed by Darin Adler.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_include_line): Avoid checking previous lines if it it is a lut.h include.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(OrderOfIncludesTest.test_check_alphabetical_include_order): Added test.

1:13 AM Changeset in webkit [187153] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix some warnings when generating GTK+ HTML API docs.

  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add

WebKitWebsiteDataManager and WebKitWebEditor.

12:21 AM WebKitGTK/Releasing edited by Carlos Garcia Campos
(diff)
12:16 AM Changeset in webkit [187152] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.9.4

WebKitGTK+ 2.9.4

12:13 AM WebKitGTK/Releasing edited by Carlos Garcia Campos
(diff)
12:10 AM Changeset in webkit [187151] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.9.4 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.9.4.
Note: See TracTimeline for information about the timeline view.