Timeline
Jul 24, 2015:
- 11:02 PM Changeset in webkit [187385] by
-
- 2 edits1 delete in trunk/Source/WebCore
Remove a file that was accidentally added in r142320
- PlatformMac.cmake:
- platform/mac/PlatformSpeechSynthesisMac.mm: Removed.
It looks like Chris added PlatformSpeechSynthesisMac and
PlatformSpeechSynthesizerMac but only meant to add the latter.
- 10:59 PM Changeset in webkit [187384] by
-
- 1 edit2 deletes in trunk/Source/WebCore
Remove a file that was supposed to be removed in r158096
- platform/graphics/mac/WebTiledLayer.h: Removed.
- platform/graphics/mac/WebTiledLayer.mm: Removed.
- 10:38 PM Changeset in webkit [187383] by
-
- 2 edits in trunk/Source/WebKit2
iOS 8 build fix attempt after r187215.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]): Deleted.
- 10:29 PM Changeset in webkit [187382] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Build fix in ProtectionSpaceBase.cpp
https://bugs.webkit.org/show_bug.cgi?id=147289
Reviewed by Brent Fulgham.
Fix the build break for [-Werror=return-type] error.
- platform/network/ProtectionSpaceBase.cpp:
(WebCore::ProtectionSpaceBase::isPasswordBased):
- 9:32 PM Changeset in webkit [187381] by
-
- 3 edits in trunk/LayoutTests
[Win] Test results gardening.
- platform/win/TestExpectations:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 8:51 PM Changeset in webkit [187380] by
-
- 14 edits2 adds in trunk
text-overflow: ellipsis is broken by text-align: right and padding-left
https://bugs.webkit.org/show_bug.cgi?id=121902
Reviewed by Zalan Bujtas.
Source/WebCore:
Right offsets (which include padding) are not the same as widths (which don't).
Test: fast/inline/padding-ellipsis-right.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::updateLogicalWidthForRightAlignedBlock):
(WebCore::RenderBlockFlow::checkLinesForTextOverflow):
LayoutTests:
Updating expected results.
- fast/inline/padding-ellipsis-right-expected.html: Added.
- fast/inline/padding-ellipsis-right.html: Added.
- platform/mac/fast/css/text-overflow-ellipsis-text-align-center-expected.png:
- platform/mac/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
- platform/mac/fast/css/text-overflow-ellipsis-text-align-left-expected.png:
- platform/mac/fast/css/text-overflow-ellipsis-text-align-left-expected.txt:
- platform/mac/fast/css/text-overflow-ellipsis-text-align-right-expected.png:
- platform/mac/fast/css/text-overflow-ellipsis-text-align-right-expected.txt:
- platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png:
- platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
- platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png:
- platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png:
- platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt:
- 8:41 PM Changeset in webkit [187379] by
-
- 2 edits in trunk/Source/WebCore
Tried to fix the iOS 9 build after r187375.
- platform/network/mac/CookieJarMac.mm:
- 8:13 PM Changeset in webkit [187378] by
-
- 2 edits in trunk/Tools
Unreviewed, updated my nick name in contributors.json
- Scripts/webkitpy/common/config/contributors.json:
- 7:37 PM Changeset in webkit [187377] by
-
- 10 edits2 adds in trunk
[MSE] Incorrect sample timestamps when using "sequence" mode
https://bugs.webkit.org/show_bug.cgi?id=147252
Patch by Sajid Anwar <sajidanwar94@gmail.com> on 2015-07-24
Reviewed by Jer Noble.
Source/WebCore:
Test: media/media-source/media-source-sequence-timestamps.html
According to the specification, the "sequence" mode indicates that the samples in the buffer will use generated timestamps
instead of the presentation/decode timestamps already present in the sample. The current implementation always adds
the current timestamp offset to the samples' timestamps, as expected for "segments" mode.
Add a method to media samples to allow their presentation and decode timestamps to be set to specific values.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Fix an algorithm condition to align with the specification, and
correctly set the presentation and decode timestamps of samples when in "sequence" mode.
- platform/MediaSample.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::MediaSampleAVFObjC::setTimestamps): Add a new method to set the values of a sample's presentation and decode timestamps.
- platform/mock/mediasource/MockBox.h:
(WebCore::MockBox::setTimestamps): Set m_presentationTimestamp and m_decodeTimestamp.
- platform/mock/mediasource/MockSourceBufferPrivate.cpp:
(WebCore::MockMediaSample::offsetTimestampsBy): Pass to MockBox.
- testing/Internals.cpp:
(WebCore::Internals::setShouldGenerateTimestamps): Expose the internal
setShouldGenerateTimestampsmethod of SourceBuffer.
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- media/media-source/media-source-sequence-timestamps-expected.txt: Added.
- media/media-source/media-source-sequence-timestamps.html: Added.
- 6:08 PM Changeset in webkit [187376] by
-
- 2 edits in trunk/Source/WebKit2
Don't create UIWebFormAccessory if we don't require accessory view.
https://bugs.webkit.org/show_bug.cgi?id=147283
Don't try to intialize _formAccessoryView if requiresAccessoryView returns false since we don't
need it yet.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2015-07-24
Reviewed by Dan Bernstein.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView inputAccessoryView]):
- 5:33 PM Changeset in webkit [187375] by
-
- 9 edits in trunk/Source
WKWebsiteDataStore remove methods don't properly delete cookies
https://bugs.webkit.org/show_bug.cgi?id=147282
rdar://problem/21948230
Reviewed by Sam Weinig.
Source/WebCore:
Rename deleteCookiesForHostname to deleteCookiesForHostnames and
make it take a vector of hostnames instead.
Also, fix the Mac implementation to not be O(n2) by putting all cookies
in a dictionary keyed on the domain.
Also make sure to call _saveStorage after deleting cookies.
Finally, get rid of deleteCookiesForHostname from CookieJarCFNet.cpp and
use the Mac implementation on iOS as well. Just stub out deleteCookiesForHostnames
on Windows since nobody is calling it.
- platform/network/PlatformCookieJar.h:
- platform/network/cf/CookieJarCFNet.cpp:
(WebCore::deleteCookiesForHostnames):
(WebCore::deleteCookiesForHostname): Deleted.
- platform/network/mac/CookieJarMac.mm:
(WebCore::deleteCookiesForHostnames):
(WebCore::deleteAllCookiesModifiedSince):
(WebCore::deleteCookiesForHostname): Deleted.
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::deleteCookiesForHostnames):
(WebCore::deleteCookiesForHostname): Deleted.
- platform/spi/cf/CFNetworkSPI.h:
Source/WebKit2:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
Call deleteCookiesForHostnames instead of iterating over each hostname.
- WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::deleteCookiesForHostname):
Call deleteCookiesForHostnames.
- 5:29 PM Changeset in webkit [187374] by
-
- 1 copy in tags/Safari-601.1.43
New tag.
- 5:29 PM Changeset in webkit [187373] by
-
- 1 copy in tags/Safari-600.8.6
New tag.
- 5:29 PM Changeset in webkit [187372] by
-
- 1 copy in tags/Safari-600.1.4.17.4
New tag.
- 4:26 PM Changeset in webkit [187371] by
-
- 18 edits2 adds in trunk
AX: scrollable elements do not allow 3-finger swipe
https://bugs.webkit.org/show_bug.cgi?id=141893
Reviewed by Mario Sanchez Prada.
Source/WebCore:
To allow iOS Accessibility to perform by-page scrolling in overflow areas, we move
that scrolling code into AccessibilityObject and then iterate all the possible ScrollableAreas,
rather than just finding the parents that are ScrollViews.
Test: platform/ios-simulator/accessibility/scroll-in-overflow-div.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::scrollAreaAndAncestor):
(WebCore::AccessibilityObject::scrollPosition):
(WebCore::AccessibilityObject::scrollVisibleContentRect):
(WebCore::AccessibilityObject::scrollContentsSize):
(WebCore::AccessibilityObject::scrollByPage):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityScroll:]):
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
(-[WebAccessibilityObjectWrapper _accessibilityScrollPosition]):
(-[WebAccessibilityObjectWrapper _accessibilityScrollSize]):
(-[WebAccessibilityObjectWrapper _accessibilityScrollVisibleRect]):
(-[WebAccessibilityObjectWrapper accessibilityElementDidBecomeFocused]):
Tools:
Support global notification listeners for iOS code.
Fix an issue in DRT where the dictionary of data was not being passed back to the layout test for the notication callback.
Implement scrollUp/Down/Left/Right.
- DumpRenderTree/AccessibilityController.h:
- DumpRenderTree/AccessibilityUIElement.cpp:
(increaseTextSelectionCallback):
(scrollPageUpCallback):
(scrollPageDownCallback):
(scrollPageLeftCallback):
(scrollPageRightCallback):
(decreaseTextSelectionCallback):
(getElementTextLengthCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/ios/AccessibilityControllerIOS.mm:
(AccessibilityController::~AccessibilityController):
(AccessibilityController::elementAtPoint):
(AccessibilityController::addNotificationListener):
(AccessibilityController::platformResetToConsistentState):
(AccessibilityController::removeNotificationListener):
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::subrole):
(AccessibilityUIElement::scrollPageUp):
(AccessibilityUIElement::scrollPageDown):
(AccessibilityUIElement::scrollPageLeft):
(AccessibilityUIElement::scrollPageRight):
(AccessibilityUIElement::roleDescription):
- DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
(-[AccessibilityNotificationHandler _notificationReceived:]):
- WebKitTestRunner/InjectedBundle/AccessibilityController.h:
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::linkedElement):
(WTR::AccessibilityUIElement::headerElementAtIndex):
(WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
(WTR::AccessibilityUIElement::scrollPageUp):
(WTR::AccessibilityUIElement::scrollPageDown):
(WTR::AccessibilityUIElement::scrollPageLeft):
(WTR::AccessibilityUIElement::scrollPageRight):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
(WTR::AccessibilityController::addNotificationListener):
(WTR::AccessibilityController::removeNotificationListener):
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
(WTR::AccessibilityUIElement::scrollPageUp):
(WTR::AccessibilityUIElement::scrollPageDown):
(WTR::AccessibilityUIElement::scrollPageLeft):
(WTR::AccessibilityUIElement::scrollPageRight):
(WTR::AccessibilityUIElement::increaseTextSelection):
LayoutTests:
- platform/ios-simulator/accessibility/scroll-in-overflow-div-expected.txt: Added.
- platform/ios-simulator/accessibility/scroll-in-overflow-div.html: Added.
- 4:24 PM Changeset in webkit [187370] by
-
- 14 edits in trunk
Source/WebCore:
[Win] Connect UserScript and UserStyleSheet through WebView.
https://bugs.webkit.org/show_bug.cgi?id=147279
<rdar://problem/21990767>
Reviewed by Dean Jackson.
Tested by http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher.html as well
as many skipped tests.
- DerivedSources.cpp: Conditionally compile JSSecurityPolicyViolationEvent.cpp if CSP_NEXT is enabled.
- DerivedSources.make: Generate bindings for SecurityPolicyViolationEvent.idl.
- WebCore.vcxproj/WebCore.vcxproj: Add missing files.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
Source/WebKit/win:
[Win] Connect UserScript and UserStyleSheet through WebView.
https://bugs.webkit.org/show_bug.cgi?id=147279
<rdar://problem/21990767>
Reviewed by Dean Jackson.
- Interfaces/IWebViewPrivate.idl: Add updated API for 'addUserScriptToGroup' and
'addUserStyleSheetToGroup'
- WebView.cpp:
(WebView::addUserScriptToGroup): Add implementation.
(toStringVector): Added helper function.
(WebView::addUserStyleSheetToGroup): Add implementation.
(WebView::removeUserScriptFromGroup): Ditto.
(WebView::removeUserStyleSheetFromGroup): Ditto.
(WebView::removeUserScriptsFromGroup): Ditto.
(WebView::removeUserStyleSheetsFromGroup): Ditto.
(WebView::removeAllUserContentFromGroup): Ditto.
- WebView.h:
Tools:
[Win] Activate CSP_NEXT and Connect UserScript and UserStyleSheet through WebView.
https://bugs.webkit.org/show_bug.cgi?id=147279
<rdar://problem/21990767>
Reviewed by Dean Jackson.
- DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::addUserScript):
(TestRunner::addUserStyleSheet):
(TestRunner::setDeveloperExtrasEnabled):
- 4:12 PM Changeset in webkit [187369] by
-
- 5 edits1 delete in branches/safari-600.8-branch
Merge patch for r187189. rdar://problem/21707927
- 4:05 PM Changeset in webkit [187368] by
-
- 5 edits1 delete in branches/safari-600.1.4.17-branch
Merge patch for r187189. rdar://problem/21708281
- 3:43 PM Changeset in webkit [187367] by
-
- 6 edits in trunk/Source/WebCore
[Cocoa] Clean up server trust handling in ResourceHandle.
https://bugs.webkit.org/show_bug.cgi?id=147277
rdar://problem/21394410
Reviewed by Brady Eidson.
- platform/network/ProtectionSpaceBase.h: (WebCore::ProtectionSpaceBase::isPasswordBased):
- platform/network/ProtectionSpaceBase.cpp: (WebCore::ProtectionSpaceBase::isPasswordBased):
Added. This is somewhat weak, as authentication schemes could change, but I couldn't find
any better way.
- platform/network/ResourceHandle.h:
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::tryHandlePasswordBasedAuthentication):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::tryHandlePasswordBasedAuthentication):
Factored out password handling, and made sure to not try that for server trust.
- 3:35 PM WhitespaceCollapsing edited by
- (diff)
- 3:32 PM WhitespaceCollapsing created by
- 3:25 PM Changeset in webkit [187366] by
-
- 3 edits in trunk/Source/WebCore
[iOS]: Inline video controls are blurry on scaled-down pages on non-retina devices.
https://bugs.webkit.org/show_bug.cgi?id=147272
rdar://problem/21429111
Reviewed by Simon Fraser.
Blurry inline video controls are the result of transform scaling up the content when the page
is zoomed out (page scale > 1).
This patch addresses the blurriness by switching to css zoom when the content is being scaled up.
While transform scale is a paint time operation, css zoom triggers layout and the content is getting
painted on a non-scaled graphics context.
- Modules/mediacontrols/mediaControlsiOS.css:
(audio::-webkit-media-controls-timeline-container):
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.set pageScaleFactor):
- 3:15 PM Changeset in webkit [187365] by
-
- 1 edit1 add in trunk/Websites/webkit.org
Add image for a blog post
- blog-files/el-capitan-system-font.png: Added.
- 3:01 PM Changeset in webkit [187364] by
-
- 2 edits in trunk/Source/WebKit2
Networking process crash in NetworkConnectionToWebProcess::convertMainResourceLoadToDownload while attempting to download a blob
https://bugs.webkit.org/show_bug.cgi?id=147276
rdar://problem/21423353
Reviewed by Andreas Kling.
We currently don't support downloading blobs, so for now just bail if we encounter a null loader inside
convertMainResourceLoadToDownload (which happens when trying to download a blob URL).
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didCleanupResourceLoader):
Rewrite the assertion to be more clear - it's fine to do an extra hash lookup in debug builds.
(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):
Bail if loader is null.
- 2:45 PM Changeset in webkit [187363] by
-
- 7 edits2 adds in trunk/Source/JavaScriptCore
Avoid 2 times name iteration in Object.assign
https://bugs.webkit.org/show_bug.cgi?id=147268
Reviewed by Geoffrey Garen.
Object.assign calls Object.getOwnPropertyNames & Object.getOwnPropertySymbols to collect all the names.
But exposing the private API that collects both at the same time makes the API efficient when the given Object has so many non-indexed properties.
Since Object.assign is so generic API (some form of utility API), the form of the given Object is not expected.
So the taken object may have so many non-indexed properties.
In this patch, we introduce
ownEnumerablePropertyKeysprivate function.
It is minor changed version of[[OwnPropertyKeys]]in the ES6 spec;
It only includes enumerable properties.
By filtering out the non-enumerable properties in the exposed private function,
we avoid calling @objectGetOwnPropertyDescriptor for each property at the same time.
- builtins/ObjectConstructor.js:
(assign):
- runtime/CommonIdentifiers.h:
- runtime/EnumerationMode.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/ObjectConstructor.cpp:
(JSC::ownEnumerablePropertyKeys):
- runtime/ObjectConstructor.h:
- tests/stress/object-assign-enumerable.js: Added.
(shouldBe):
- tests/stress/object-assign-order.js: Added.
(shouldBe):
- 2:29 PM Changeset in webkit [187362] by
-
- 2 edits in trunk/Source/bmalloc
vmmap crash at JavaScriptCore: 0x31cd12f6 (the JavaScript malloc zone enumerator)
https://bugs.webkit.org/show_bug.cgi?id=147274
Reviewed by Anders Carlsson.
It's not really clear why vmmap sometimes fails to read the target
process, but we can avoid a crash when it does. This is useful because
you'll still get all the non-bmalloc data out of the target process,
and bmalloc might not even be relevant to your investigation.
- bmalloc/Zone.cpp:
(bmalloc::remoteRead): Check for failure.
- 2:08 PM Changeset in webkit [187361] by
-
- 9 edits in branches/safari-600.1.4.17-branch
Merged r187359. rdar://problem/21708243
- 2:03 PM Changeset in webkit [187360] by
-
- 3 edits in trunk/Source/bmalloc
JavaScriptCore bmalloc should not register its malloc zone more than once
https://bugs.webkit.org/show_bug.cgi?id=147273
Reviewed by Andreas Kling.
This was a goof: The Zone constructor, by virtue of running automatically,
was registering a Zone inside the analysis process.
- bmalloc/Zone.cpp:
(bmalloc::remoteRead): Clarify that the pointer is remote.
(bmalloc::enumerator):
(bmalloc::Zone::Zone):
- bmalloc/Zone.h: Separate the normal constructor and the remote constructor.
The remote constructor skips zone registration since its goal is not
to register a zone in the current process or do any allocation but rather
to mirror the bytes of the zone from the target process.
- 1:41 PM Changeset in webkit [187359] by
-
- 9 edits in branches/safari-600.8-branch
Fix fallout from merging changes for
<rdar://problem/21707887> CSP doesn't prevent image loading of <object> when page contains <video controls> and ENABLE(MEDIA_CONTROLS_SCRIPT) is enabled
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Tweaked http/tests/security/isolatedWorld/image-load-should-not-bypass-main-world-csp.html so that
it will test allowing evals in non-main worlds.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::initScript):
Due to ContentSecurityPolicy::allowEval being modified on ToT, we'd always end up passing true for
the overrideContentSecurityPolicy parameter (since the ContentSecurityPolicy::SuppressReport parameter
was incorrectly treated as a boolean).
Fix this by merging part of the fix for bug 141316.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::defaultCachedResourceOptions):
The correct ContentSecurityPolicyImposition should be DoPolicyCheck. This was the case on ToT but for
some reason it was changed to SkipPolicyCheck when the patch was merged.
- page/DOMSecurityPolicy.cpp:
(WebCore::DOMSecurityPolicy::allowsEval):
Pass false for overrideContentSecurityPolicy.
LayoutTests:
- http/tests/security/contentSecurityPolicy/resources/track.vtt:
Replace this with a track.vtt from ToT which is actually a valid .vtt file that will parse properly.
- http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-object.html:
Tweak this test so it will work on the branch - setting object.data in order to force an object's URL to be loaded
when it's already got a renderer only works on ToT, so do it before appending the object element.
- http/tests/security/isolatedWorld/image-load-should-not-bypass-main-world-csp-expected.txt:
Copy the test result from ToT and get rid of the merge conflict.
- http/tests/security/isolatedWorld/image-load-should-not-bypass-main-world-csp.html:
Copy the test from ToT which also gives us a test for allowing eval in non-main script worlds.
- 1:31 PM Changeset in webkit [187358] by
-
- 2 edits in trunk/Source/WebCore
Remove WEBCORE_EXPORT from Page::allowsMediaDocumentInlinePlayback()
https://bugs.webkit.org/show_bug.cgi?id=147260
Reviewed by Daniel Bates.
- page/Page.h:
(WebCore::Page::allowsMediaDocumentInlinePlayback):
- 1:22 PM Changeset in webkit [187357] by
-
- 4 edits in trunk/Tools
Call fixChangeLogPatch when generating patches from webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=147248
Reviewed by Geoffrey Garen.
When two consecutive patches are from the same author, diff tools
create wrong-looking diffs for ChangeLog files where the apparent added
author is actually the previous patch's author line, making it awkward
to read - and things only get worse when committing a patch and a
followup fix for the same bug shortly after.
We have a perl function in VCSUtils.pm, fixChangeLogPatch, to corrects
this, which we use in perl scripts (svn-create-patch et al). But it is
not used by webkit-patch, which is a python script, and thus creates
"bad" diffs.
In the long term, we should probably port fixChangeLogPatch to python -
but in the short term, let's make webkit-patch call perl to run
fixChangeLogPatch. We are already making various external calls there
anyway.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.create_patch):
- Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.fix_changelog_patch):
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.create_patch):
- 12:48 PM Changeset in webkit [187356] by
-
- 13 edits in trunk/Source
Remove runtime flags for symbols
https://bugs.webkit.org/show_bug.cgi?id=147246
Reviewed by Alex Christensen.
Source/JavaScriptCore:
- runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::finishCreation):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init): Deleted.
- runtime/JSGlobalObject.h:
- runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::finishCreation):
- runtime/RuntimeFlags.h:
Source/WebKit/mac:
- WebView/WebPreferencesPrivate.h:
Source/WebKit/win:
- Interfaces/IWebPreferencesPrivate.idl:
Source/WebKit2:
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- 12:31 PM Changeset in webkit [187355] by
-
- 26 edits3 adds in trunk
Object.getOwnPropertySymbols on large list takes very long
https://bugs.webkit.org/show_bug.cgi?id=146137
Reviewed by Mark Lam.
Source/JavaScriptCore:
Before this patch, Object.getOwnPropertySymbols collects all the names including strings.
And after it's done, filter the names to only retrieve the symbols.
But it's so time consuming if the given object is a large non-holed array since it has
many indexed properties and all the indexes have to be converted to uniqued_strings and
added to the collection of property names (though they may not be of the requested type
and will be filtered out later)
This patch introduces PropertyNameMode.
We leverage this mode in 2 places.
- PropertyNameArray side
It is set in PropertyNameArray and it filters the incoming added identifiers based on the mode.
It ensures that PropertyNameArray doesn't become so large in the pathological case.
And it ensures that non-expected typed keys by the filter (Symbols or Strings) are never added
to the property name array collections.
However it does not solve the whole problem because the huge array still incurs the many
"indexed property to uniqued string" conversion and the large iteration before adding the keys
to the property name array.
- getOwnPropertyNames side
So we can use the PropertyNameMode in the caller side (getOwnPropertyNames) as a hint.
When the large iteration may occur, the caller side can use the PropertyNameMode as a hint to
avoid the iteration.
But we cannot exclusively rely on these caller side checks because it would require that we
exhaustively add the checks to all custom implementations of getOwnPropertyNames as well.
This process requires manual inspection of many pieces of code, and is error prone. Instead,
we only apply the caller side check in a few strategic places where it is known to yield
performance benefits; and we rely on the filter in PropertyNameArray::add() to reject the wrong
types of properties for all other calls to PropertyNameArray::add().
In this patch, there's a concept in use that is not clear just from reading the code, and hence
should be documented here. When selecting the PropertyNameMode for the PropertyNameArray to be
instantiated, we apply the following logic:
- Only JavaScriptCore code is aware of ES6 Symbols.
We can assume that pre-existing external code that interfaces JSC are only looking for string named properties. This includes:
- WebCore bindings
- Serializer bindings
- NPAPI bindings
- Objective C bindings
- In JSC, code that compute object storage space needs to iterate both Symbol and String named properties. Hence, use PropertyNameMode::Both.
- In JSC, ES6 APIs that work with Symbols should use PropertyNameMode::Symbols.
- In JSC, ES6 APIs that work with String named properties should use PropertyNameMode::Strings.
- API/JSObjectRef.cpp:
(JSObjectCopyPropertyNames):
- bindings/ScriptValue.cpp:
(Deprecated::jsToInspectorValue):
- bytecode/ObjectAllocationProfile.h:
(JSC::ObjectAllocationProfile::possibleDefaultPropertyCount):
- runtime/EnumerationMode.h:
(JSC::EnumerationMode::EnumerationMode):
(JSC::EnumerationMode::includeSymbolProperties): Deleted.
- runtime/GenericArgumentsInlines.h:
(JSC::GenericArguments<Type>::getOwnPropertyNames):
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertyNames):
- runtime/JSLexicalEnvironment.cpp:
(JSC::JSLexicalEnvironment::getOwnNonIndexPropertyNames):
- runtime/JSONObject.cpp:
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):
- runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertyNames):
- runtime/JSPropertyNameEnumerator.cpp:
(JSC::JSPropertyNameEnumerator::create):
- runtime/JSPropertyNameEnumerator.h:
(JSC::propertyNameEnumerator):
- runtime/JSSymbolTableObject.cpp:
(JSC::JSSymbolTableObject::getOwnNonIndexPropertyNames):
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorGetOwnPropertySymbols):
(JSC::objectConstructorKeys):
(JSC::defineProperties):
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):
- runtime/PropertyNameArray.h:
(JSC::PropertyNameArray::PropertyNameArray):
(JSC::PropertyNameArray::mode):
(JSC::PropertyNameArray::addKnownUnique):
(JSC::PropertyNameArray::add):
(JSC::PropertyNameArray::isUidMatchedToTypeMode):
(JSC::PropertyNameArray::includeSymbolProperties):
(JSC::PropertyNameArray::includeStringProperties):
- runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertyNames):
- runtime/Structure.cpp:
(JSC::Structure::getPropertyNamesFromStructure):
Source/WebCore:
- bindings/js/Dictionary.cpp:
(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
- bridge/NP_jsobject.cpp:
(_NPN_Enumerate):
Source/WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::enumerate):
Source/WebKit2:
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::enumerate):
LayoutTests:
- js/regress/object-get-own-property-symbols-on-large-array-expected.txt: Added.
- js/regress/object-get-own-property-symbols-on-large-array.html: Added.
- js/regress/script-tests/object-get-own-property-symbols-on-large-array.js: Added.
(trial):
- 11:56 AM Changeset in webkit [187354] by
-
- 6 edits in branches/jsc-tailcall/Source/JavaScriptCore
jsc-tailcall: Repatching tail calls as jump should depend on the opcode, not the JS CallLinkInfo
https://bugs.webkit.org/show_bug.cgi?id=147243
Reviewed by Michael Saboff.
When linking, we are currently looking at data from the JS CallLinkInfo
to determine if we have a call or jump opcode. However, even with a
tail call, the slow path uses a call opcode for simplicity.
This adds the information that we are performing a tail call into the
CodeLocationNearCall class, which allows us to link as jump or call
based on the actual opcode.
This is a conceptual error that couldn't be found on X86 architecture
since the patching of jump and calls is identical there.
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::repatchNearCall):
- assembler/CodeLocation.h:
(JSC::CodeLocationNearCall::CodeLocationNearCall):
(JSC::CodeLocationNearCall::isTail):
(JSC::CodeLocationCommon::nearCallAtOffset):
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::locationOfNearCall):
- assembler/RepatchBuffer.h:
(JSC::RepatchBuffer::relink):
- jit/Repatch.cpp:
(JSC::linkSlowFor):
(JSC::linkFor):
(JSC::revertCall):
(JSC::linkPolymorphicCall):
- 11:51 AM Changeset in webkit [187353] by
-
- 4 edits in trunk/Source/WebCore
REGRESSION (r187149): Build fails when CSS_SELECTORS_LEVEL4 is disabled
This is a follow-up fix to:
[CSS Selectors Level 4] Add #ifdefs to the new '>>' descendant combinator
<https://bugs.webkit.org/show_bug.cgi?id=147184>
- css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::appendTagHistory):
- css/CSSParserValues.h:
- css/CSSSelector.h:
- Change ENABLE_CSS_SELECTORS_LEVEL4 to ENABLE(CSS_SELECTORS_LEVEL4).
- 11:48 AM Changeset in webkit [187352] by
-
- 3 edits2 adds in trunk
Web Inspector: Editing non-inspector-stylesheet rule selectors fails after the first change
https://bugs.webkit.org/show_bug.cgi?id=147229
Reviewed by Timothy Hatcher.
Source/WebCore:
Test: inspector/css/modify-rule-selector.html
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::setRuleSelector):
Now checks to see if the stylesheet is not mutated before making the change to the
rule's selector, and if so mark it as not mutated to allow future edits.
LayoutTests:
- inspector/css/modify-rule-selector-expected.txt: Added.
- inspector/css/modify-rule-selector.html: Added.
- 11:40 AM Changeset in webkit [187351] by
-
- 15 edits1 add in trunk
[ES6] Add support for default parameters
https://bugs.webkit.org/show_bug.cgi?id=38409
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
This patch implements ES6 default parameters according to the ES6
specification. This patch builds off the components introduced with
"let" scoping and parsing function parameters in the same parser
arena as the function itself. "let" scoping allows functions with default
parameter values to place their parameters under the TDZ. Parsing function
parameters in the same parser arena allows the FunctionParameters AST node
refer to ExpressionNodes.
The most subtle part of this patch is how we allocate lexical environments
when functions have default parameter values. If a function has default
parameter values then there must be a separate lexical environment for
its parameters. Then, the function's "var" lexical environment must have
the parameter lexical environment as its parent. The BytecodeGenerator
takes great care to not allocate the "var" lexical environment before its
really needed.
The "arguments" object for a function with default parameters will never be
a mapped arugments object. It will always be a cloned arugments object.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::~BytecodeGenerator):
(JSC::BytecodeGenerator::initializeDefaultParameterValuesAndSetupFunctionScopeStack):
(JSC::BytecodeGenerator::initializeNextParameter):
(JSC::BytecodeGenerator::initializeVarLexicalEnvironment):
(JSC::BytecodeGenerator::visibleNameForParameter):
(JSC::BytecodeGenerator::emitLoadGlobalObject):
(JSC::BytecodeGenerator::pushLexicalScopeInternal):
(JSC::BytecodeGenerator::pushLexicalScope):
(JSC::BytecodeGenerator::popLexicalScope):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::lastOpcodeID):
- bytecompiler/NodesCodegen.cpp:
(JSC::FunctionNode::emitBytecode):
- jit/JITOperations.cpp:
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createElementList):
(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::appendParameter):
(JSC::ASTBuilder::createClause):
(JSC::ASTBuilder::createClauseList):
- parser/Nodes.h:
(JSC::FunctionParameters::size):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::hasDefaultParameterValues):
(JSC::FunctionParameters::append):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseVariableDeclarationList):
(JSC::Parser<LexerType>::createBindingPattern):
(JSC::Parser<LexerType>::tryParseDestructuringPatternExpression):
(JSC::Parser<LexerType>::parseDestructuringPattern):
(JSC::Parser<LexerType>::parseFormalParameters):
(JSC::Parser<LexerType>::parseFunctionParameters):
- parser/Parser.h:
(JSC::Scope::declareParameter):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createElementList):
(JSC::SyntaxChecker::createFormalParameterList):
(JSC::SyntaxChecker::appendParameter):
(JSC::SyntaxChecker::createClause):
(JSC::SyntaxChecker::createClauseList):
- tests/stress/es6-default-parameters.js: Added.
(assert):
(shouldThrow):
(shouldThrowSyntaxError):
(shouldThrowTDZ):
(basic):
(basicFunctionCaptureInDefault.basicFunctionCaptureInDefault.basicCaptured):
(basicCaptured.basicCaptured.tricky):
(strict):
(playground):
(scoping):
(augmentsArguments1):
(augmentsArguments2):
(augmentsArguments3):
(augmentsArguments4):
(augmentsArguments5):
LayoutTests:
- js/destructuring-assignment-default-values-expected.txt:
- js/parser-syntax-check-expected.txt:
- js/script-tests/destructuring-assignment-default-values.js:
(shouldThrow): Deleted.
- js/script-tests/parser-syntax-check.js:
- 11:39 AM Changeset in webkit [187350] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Add custom parameter lists for new DOM append/prepend/before/after/replaceWith methods
https://bugs.webkit.org/show_bug.cgi?id=147257
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-24
Reviewed by Timothy Hatcher.
- UserInterface/Models/NativeFunctionParameters.js:
- 11:36 AM Changeset in webkit [187349] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove JS Promise constructor unused piece of code
https://bugs.webkit.org/show_bug.cgi?id=147262
Reviewed by Geoffrey Garen.
- runtime/JSPromiseConstructor.cpp:
(JSC::constructPromise): Deleted.
- runtime/JSPromiseConstructor.h: Removed JSC::constructPromise.
- 11:32 AM Changeset in webkit [187348] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add WASM files to vcxproj files.
https://bugs.webkit.org/show_bug.cgi?id=147264
Reviewed by Geoffrey Garen.
This is a follow up to http://trac.webkit.org/changeset/187254 where WASM files
were introduced but were not able to be added to the vcxproj files yet.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- 11:23 AM Changeset in webkit [187347] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
DFG::safeToExecute() is wrong for MultiGetByOffset, doesn't consider the structures of the prototypes that get loaded from
https://bugs.webkit.org/show_bug.cgi?id=147250
Reviewed by Geoffrey Garen.
This fixes a nasty - but currently benign - bug in DFG::safeToExecute(). That function
will tell you if hoisting a node to some point is safe in the sense that the node will
not crash the VM if it executes at that point. A node may be unsafe to execute if we
cannot prove that at that point, the memory it is loading is not garbage. This is a
necessarily loose notion - for example it's OK to hoist a load if we haven't proved
that the load makes semantic sense at that point, since anyway the place where the node
did get used will still be guarded by any such semantic checks. But because we may also
hoist uses of the load, we need to make sure that it doesn't produce a garbage value.
Also, we need to ensure that the load won't trap. Hence safeToExecute() returns true
anytime we can be sure that a node will not produce a garbage result (i.e. a malformed
JSValue or object pointer) and will not trap when executed at the point in question.
The bug is that this verification isn't performed for the loads from prototypes inside
MultiGetByOffset. DFG::ByteCodeParser will guard MultiGetByOffset with CheckStructure's
on the prototypes. So, hypothetically, you might end up hoisting a MultiGetByOffset
above those structure checks, which would mean that we might load a value from a memory
location without knowing that the location is valid. It might then return the value
loaded.
This never happens in practice. Those structure checks are more hoistable that the
MultiGetByOffset, since they read a strict subset of the MultiGetByOffset's abstract
heap reads. Also, we hoist in program order. So, those CheckStructure's will always be
hoisted before the MultiGetByOffset gets hoisted.
But we should fix this anyway. DFG::safeToExecute() has a clear definition of what a
"true" return means for IR transformations, and it fails in satisfying that definition
for MultiGetByOffset.
There are various approaches we can use for making this safe. I considered two:
1) Have MultiGetByOffset refer to the prototypes it is loading from in IR, so that we
can check if it's safe to load from them.
2) Turn off MultiGetByOffset hoisting when it will emit loads from prototypes, and the
prototype structure isn't being watched.
I ended up using (2), because it will be the most natural solution once I finish
https://bugs.webkit.org/show_bug.cgi?id=146929. Already now, it's somewhat more natural
than (1) since that requires more extensive IR changes. Also, (2) will give us what we
want in *most* cases: we will usually watch the prototype structure, and we will
usually constant-fold loads from prototypes. Both of these usually-true things would
have to become false for MultiGetByOffset hoisting to be disabled by this change.
This change also adds my attempt at a test, though it's not really a test of this bug.
This bug is currently benign. But, the test does at least trigger the logic to run,
which is better than nothing.
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- tests/stress/multi-get-by-offset-hoist-around-structure-check.js: Added.
(foo):
- 10:59 AM Changeset in webkit [187346] by
-
- 6 edits in branches/safari-601.1-branch/Source/WebCore
Merged r187149. rdar://problem/21935769
- 10:51 AM Changeset in webkit [187345] by
-
- 2 edits in trunk/Source/WebKit2
Recode.net gets into a continual resize loop in split fullscreen
https://bugs.webkit.org/show_bug.cgi?id=147266
rdar://problem/21409047
Reviewed by Tim Horton.
In split fullscreen, we use fixed layout and scale to shrink pages down to
fit a given width. This is re-evaluated every time the document width changes.
However some pages, like recode.net, end up continually resizing because
when laid out unconstrained they use a narrower width than when laid out with
a fixed layout size. In fixed layout, they actually use more width than the fixed
layout size.
Detect and break this cycle by just not re-scaling when we've done one fixed layout,
and the document is now taking more width than the fixed layout width.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded):
- 9:07 AM Changeset in webkit [187344] by
-
- 7 edits in trunk
CSS "content" property is missing in getComputedStyles
https://bugs.webkit.org/show_bug.cgi?id=147255
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-24
Reviewed by Simon Fraser.
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
LayoutTests:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/css/getComputedStyle/resources/property-names.js:
- svg/css/getComputedStyle-basic-expected.txt:
- 7:49 AM Changeset in webkit [187343] by
-
- 2 edits in trunk/LayoutTests
[EFL] many fast tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=145835
Unreviewed gardening. These tests aren't flakey now, let's unskip them.
- platform/efl/TestExpectations:
- 7:17 AM Changeset in webkit [187342] by
-
- 9 edits7 adds in trunk/LayoutTests
[EFL] Multi-column tests have been failed since r167808
https://bugs.webkit.org/show_bug.cgi?id=141496
Unreviewed gardening, updated expected results.
- platform/efl/TestExpectations:
- platform/efl/fast/multicol/client-rects-expected.png:
- platform/efl/fast/multicol/client-rects-expected.txt:
- platform/efl/fast/multicol/client-rects-spanners-complex-expected.png: Added.
- platform/efl/fast/multicol/client-rects-spanners-complex-expected.txt:
- platform/efl/fast/multicol/client-rects-spanners-expected.png: Added.
- platform/efl/fast/multicol/client-rects-spanners-expected.txt:
- platform/efl/fast/multicol/layers-split-across-columns-expected.png:
- platform/efl/fast/multicol/layers-split-across-columns-expected.txt:
- platform/efl/fast/multicol/newmulticol/client-rects-expected.png: Added.
- platform/efl/fast/multicol/newmulticol/client-rects-expected.txt:
- platform/efl/fast/multicol/pagination/LeftToRight-tb-hittest-expected.png: Added.
- platform/efl/fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt: Added.
- platform/efl/fast/multicol/pagination/RightToLeft-rl-hittest-expected.png: Added.
- platform/efl/fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt: Added.
- 7:06 AM Changeset in webkit [187341] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening, unskip now passing tests.
- platform/efl/TestExpectations:
- 5:59 AM Changeset in webkit [187340] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening. Updated since MEDIA_STREAM is enabled.
- platform/efl/js/dom/constructor-length-expected.txt:
- 5:51 AM Changeset in webkit [187339] by
-
- 2 edits in trunk/Source/WTF
Remove the unused GCC workaround - std::is_trivially_destructible
https://bugs.webkit.org/show_bug.cgi?id=147226
Reviewed by Darin Adler.
- wtf/StdLibExtras.h:
- 5:06 AM Changeset in webkit [187338] by
-
- 17 edits5 adds in trunk/Source
[GStreamer] Crashes during plugin installation
https://bugs.webkit.org/show_bug.cgi?id=144099
Reviewed by Philippe Normand.
Source/WebCore:
Add new methods to MediaPlayerClient and ChromeClient to request
the API layer to start the installer when there are missing media
plugins.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::requestInstallMissingPlugins): Pass
the request to the ChromeClient.
- html/HTMLMediaElement.h:
- page/ChromeClient.h:
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::requestInstallMissingPlugins):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Invalidate any pending request to install missing media plugins.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): In case of
missing plugins message, start a request to install them if
supported by GST.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(WebCore::MediaPlayerRequestInstallMissingPluginsCallback::create):
(WebCore::MediaPlayerRequestInstallMissingPluginsCallback::MediaPlayerRequestInstallMissingPluginsCallback):
(WebCore::MediaPlayerRequestInstallMissingPluginsCallback::invalidate):
(WebCore::MediaPlayerRequestInstallMissingPluginsCallback::complete):
Source/WebKit2:
Move the missing plugins installation to the UI process, ensuring
there's a single installer running and cancelling the request when
the page is closed or the media player is deleted.
- PlatformEfl.cmake: Add new files to compilation.
- PlatformGTK.cmake: Ditto.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in: Add
RequestInstallMissingMediaPlugins message.
- UIProcess/gstreamer/WebPageProxyGStreamer.cpp: Added.
(WebKit::WebPageProxy::requestInstallMissingMediaPlugins): Call
gst_install_plugins_async() and send
DidEndRequestInstallMissingMediaPlugins message back to the web
process when done.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::requestInstallMissingMediaPlugins): Call
WebPage::requestInstallMissingMediaPlugins().
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close): Invalidate the install missing plugins
request callback.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in: Add
DidEndRequestInstallMissingMediaPlugins message.
- WebProcess/WebPage/gstreamer/WebPageGStreamer.cpp: Added.
(WebKit::WebPage::requestInstallMissingMediaPlugins): Send
RequestInstallMissingMediaPlugins to the UI process or complete
the request early if there's already a request in progress.
(WebKit::WebPage::didEndRequestInstallMissingMediaPlugins):
Complete the request.
- 4:58 AM Changeset in webkit [187337] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed. Fix the build with MEDIA_STREAM disabled after r187282.
RealtimeMediaSource is only defined when MEDIA_STREAM is enabled.
- UIProcess/UserMediaPermissionRequestProxy.cpp:
- UIProcess/UserMediaPermissionRequestProxy.h:
- 4:27 AM Changeset in webkit [187336] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION(r187100): [GTK] ASSERTION FAILED: Attempt to access post layout data before receiving it when typing backspace
https://bugs.webkit.org/show_bug.cgi?id=147196
Reviewed by Žan Doberšek.
Do not try to use the PostLayoutData from EditorState when
isMissingPostLayoutData is true. That happens when there's a
layout pending, and EditorStateChanged is sent again after that
layout with the post layout data. So we can just return early and
wait until the second message.
- UIProcess/API/gtk/WebKitEditorState.cpp:
(webkitEditorStateChanged):
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseUpdateTextInputState):
- 1:48 AM Changeset in webkit [187335] by
-
- 12 edits in branches/safari-601.1-branch
Merge custom patch for rdar://problem/21953865
- 1:23 AM Changeset in webkit [187334] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merge r187036. rdar://problem/21901881
- 1:18 AM Changeset in webkit [187333] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187268. rdar://problem/21664211
- 1:03 AM Changeset in webkit [187332] by
-
- 2 edits in trunk/Tools
commit-queue flags in webkit-patch are confusing
https://bugs.webkit.org/show_bug.cgi?id=88694
Patch by Dean Johnson <dean_johnson@apple.com> on 2015-07-24
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/tool/steps/options.py:
(Options): Updated help string to be more descriptive.
- 12:55 AM Changeset in webkit [187331] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187288. rdar://problem/21929532
- 12:54 AM Changeset in webkit [187330] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187286. rdar://problem/21953359
- 12:54 AM Changeset in webkit [187329] by
-
- 5 edits in branches/safari-601.1-branch/Source/WebCore
Merge r187274. rdar://problem/21905756
- 12:54 AM Changeset in webkit [187328] by
-
- 3 edits4 adds in branches/safari-601.1-branch
Merge r187271. rdar://problem/21929247
- 12:54 AM Changeset in webkit [187327] by
-
- 3 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187267. rdar://problem/21664211
- 12:54 AM Changeset in webkit [187326] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187266. rdar://problem/21910578
- 12:54 AM Changeset in webkit [187325] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187255. rdar://problem/21875510
- 12:54 AM Changeset in webkit [187324] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187250. rdar://problem/21968460
- 12:54 AM Changeset in webkit [187323] by
-
- 3 edits2 adds in branches/safari-601.1-branch
Merge r187248. rdar://problem/21949735
- 12:54 AM Changeset in webkit [187322] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merge r187219. rdar://problem/21032083
- 12:54 AM Changeset in webkit [187321] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merge r187216. rdar://problem/21032083
- 12:54 AM Changeset in webkit [187320] by
-
- 5 edits in branches/safari-601.1-branch/Source
Merge r187215. rdar://problem/21032083
- 12:54 AM Changeset in webkit [187319] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187212. rdar://problem/21945775
- 12:54 AM Changeset in webkit [187318] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebInspectorUI
Merge r187209. rdar://problem/21946519
- 12:54 AM Changeset in webkit [187317] by
-
- 3 edits in branches/safari-601.1-branch/Source/WebCore
Merge r187203. rdar://problem/21012688
- 12:54 AM Changeset in webkit [187316] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187199. rdar://problem/21945775
- 12:54 AM Changeset in webkit [187315] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187198. rdar://problem/21945775
- 12:54 AM Changeset in webkit [187314] by
-
- 6 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187193. rdar://problem/21945775
- 12:54 AM Changeset in webkit [187313] by
-
- 4 edits2 adds in branches/safari-601.1-branch
Merge r187189. rdar://problem/21567767
- 12:54 AM Changeset in webkit [187312] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187174. rdar://problem/21818117
- 12:54 AM Changeset in webkit [187311] by
-
- 9 edits in branches/safari-601.1-branch/Source
Merge r187173. rdar://problem/21637698
- 12:54 AM Changeset in webkit [187310] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merge r187170. rdar://problem/21901076
- 12:54 AM Changeset in webkit [187309] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merge r187144. rdar://problem/21931728
- 12:54 AM Changeset in webkit [187308] by
-
- 2 edits in branches/safari-601.1-branch/Source/JavaScriptCore
Merge r187139. rdar://problem/21847618
- 12:08 AM Changeset in webkit [187307] by
-
- 4 edits20 copies in branches/safari-601.1-branch
Merged r187133. rdar://problem/21919408
- 12:06 AM Changeset in webkit [187306] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merged r187131. rdar://problem/21046961
- 12:03 AM Changeset in webkit [187305] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merged r187136. rdar://problem/18477459
- 12:02 AM Changeset in webkit [187304] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merged r187130. rdar://problem/21630806
Jul 23, 2015:
- 11:56 PM Changeset in webkit [187303] by
-
- 7 edits in branches/safari-601.1-branch/Source
Merged r187129. rdar://problem/18477459
- 11:34 PM Changeset in webkit [187302] by
-
- 7 edits7 copies in branches/safari-601.1-branch
Roll over ChangeLogs.
- 11:33 PM Changeset in webkit [187301] by
-
- 10 edits in branches/safari-601.1-branch
Merged r187125. rdar://problem/21847618
- 11:31 PM Changeset in webkit [187300] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebInspectorUI
Merged r187123. rdar://problem/21925581
- 11:29 PM Changeset in webkit [187299] by
-
- 3 edits in branches/safari-601.1-branch/Source/WebKit2
Merged r187117. rdar://problem/21921061
- 11:27 PM Changeset in webkit [187298] by
-
- 4 edits4 copies in branches/safari-601.1-branch
Merged r187116. rdar://problem/21110936
- 11:24 PM Changeset in webkit [187297] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merged r187115. rdar://problem/21838764
- 11:21 PM Changeset in webkit [187296] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit/ios
Merged r187113. rdar://problem/21920008
- 11:20 PM Changeset in webkit [187295] by
-
- 3 edits in branches/safari-601.1-branch/Source/WebKit/ios
Merged r187107. rdar://problem/21920008
- 11:10 PM Changeset in webkit [187294] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merged r187045. rdar://problem/21433691
- 11:06 PM Changeset in webkit [187293] by
-
- 2 edits in branches/safari-601.1-branch/LayoutTests
Merged r186994. rdar://problem/21787807
- 11:04 PM Changeset in webkit [187292] by
-
- 3 edits2 copies in branches/safari-601.1-branch
Merged r186981. rdar://problem/21787807
- 11:01 PM Changeset in webkit [187291] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merged r186977. rdar://problem/20864286
- 10:58 PM Changeset in webkit [187290] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merged r186806. rdar://problem/21795569
- 9:58 PM Changeset in webkit [187289] by
-
- 2 edits in trunk/Source/WebKit2
Fix 32-bit build after r187272.
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::mediaDocumentNaturalSizeChanged):
Added some WK_API_ENABLED.
- 9:53 PM Changeset in webkit [187288] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/21929532> REGRESSION (r184026): Safari AutoFill with Contact info for phone number is broken
https://bugs.webkit.org/show_bug.cgi?id=147249
Reviewed by Sam Weinig.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(encodeObject): Use encodeString only for strings that encode as NSString or
NSMutableString. It can’t encode arbitrary NSString subclasses.
(decodeObject): Use decodeString for NSMutableString as well.
- 9:38 PM Changeset in webkit [187287] by
-
- 2 edits in trunk/Source/WebCore
[Win] Unreviewed build fix after r187245.
- PlatformWin.cmake:
Add GDIUtilities.cpp to CMake build.
- 9:16 PM Changeset in webkit [187286] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] REGRESSION (187131): Loading CuteOverload zooms in to the top left corner.
https://bugs.webkit.org/show_bug.cgi?id=147251
rdar://problem/21953359
Calling zoomToRect() should result in essentially the same zoom scale as if we
called setZoomScale with the new page scale factor.
Reviewed by Benjamin Poulain.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLayerTree:]):
- 7:48 PM Changeset in webkit [187285] by
-
- 3 edits2 copies in branches/safari-600.1.4.17-branch
Merged r187248. rdar://problem/21976051
- 7:44 PM Changeset in webkit [187284] by
-
- 3 edits2 copies in branches/safari-600.8-branch
Merged r187248. rdar://problem/21976049
- 7:35 PM Changeset in webkit [187283] by
-
- 2 edits in trunk/Source/JavaScriptCore
Implement WebAssembly modules
https://bugs.webkit.org/show_bug.cgi?id=147222
Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-07-23
Reviewed by Filip Pizlo.
Make JSWASMModule inherit from JSDestructibleObject so that the destructor is called.
- wasm/JSWASMModule.h:
- 7:23 PM Changeset in webkit [187282] by
-
- 14 edits in trunk/Source
Linking WebKit2 to be able to grab media sources from a UID
https://bugs.webkit.org/show_bug.cgi?id=147202
<rdar://problem/21947608>
Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-23
Reviewed by Brent Fulgham.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- platform/mediastream/RealtimeMediaSourceCenter.h:
- platform/mediastream/mac/AVCaptureDeviceManager.h:
- platform/mediastream/mac/AVCaptureDeviceManager.mm:
(WebCore::AVCaptureDeviceManager::sourceWithUID):
- platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:
(WebCore::RealtimeMediaSourceCenterMac::sourceWithUID):
- platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:
- platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:
(WebCore::RealtimeMediaSourceCenterOwr::sourceWithUID):
- platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.h:
- platform/mock/MockRealtimeMediaSourceCenter.cpp:
(WebCore::MockRealtimeMediaSourceCenter::sourceWithUID):
- platform/mock/MockRealtimeMediaSourceCenter.h:
Source/WebKit2:
- UIProcess/UserMediaPermissionRequestProxy.cpp:
(WebKit::UserMediaPermissionRequestProxy::getDeviceNameForUID):
- UIProcess/UserMediaPermissionRequestProxy.h:
- 6:22 PM Changeset in webkit [187281] by
-
- 2 edits in trunk/Source/WebKit/win
Unreviewed build fix after r187245.
- WebView.cpp:
WM_DPICHANGED is #defined, which causes problems if we try to use it as a variable name.
- 6:00 PM Changeset in webkit [187280] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: jittery cursor when adjusting time interval using timeline grabbers
https://bugs.webkit.org/show_bug.cgi?id=147095
Reviewed by Brian Burg.
- UserInterface/Views/TimelineRuler.css:
(.timeline-ruler.resizing-selection > .selection-drag):
Override selection-drag element's cursor when "resizing-selection" selector is applied.
(.timeline-ruler.allows-time-range-selection.creating-selection): Deleted.
Renamed "creating-selection" selector to "resizing-selection" to reflect its new role.
- UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler.prototype._handleMouseMove):
(WebInspector.TimelineRuler.prototype._handleMouseUp):
(WebInspector.TimelineRuler.prototype._handleSelectionHandleMouseDown):
(WebInspector.TimelineRuler.prototype._handleSelectionHandleMouseUp):
Toggle cursor styles.
- 5:55 PM Changeset in webkit [187279] by
-
- 37 edits in trunk
Remove compile and runtime flags for promises.
https://bugs.webkit.org/show_bug.cgi?id=147244
Reviewed by Yusuke Suzuki.
.:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/OptionsWindows.cmake:
- Source/cmake/WebKitFeatures.cmake:
Source/JavaScriptCore:
- API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject<Parent>::JSCallbackObject):
- API/JSContextRef.cpp:
(JSGlobalContextCreateInGroup):
- Configurations/FeatureDefines.xcconfig:
- inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::getInternalProperties):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::create):
(JSC::JSGlobalObject::syntaxErrorConstructor):
(JSC::JSGlobalObject::typeErrorConstructor):
(JSC::JSGlobalObject::URIErrorConstructor):
(JSC::JSGlobalObject::promiseConstructor):
(JSC::JSGlobalObject::nullGetterFunction):
(JSC::JSGlobalObject::nullSetterFunction):
(JSC::JSGlobalObject::applyFunction):
(JSC::JSGlobalObject::definePropertyFunction):
(JSC::JSGlobalObject::arrayProtoValuesFunction):
(JSC::JSGlobalObject::initializePromiseFunction):
(JSC::JSGlobalObject::newPromiseDeferredFunction):
(JSC::JSGlobalObject::throwTypeErrorGetterSetter):
(JSC::JSGlobalObject::regExpPrototype):
(JSC::JSGlobalObject::errorPrototype):
(JSC::JSGlobalObject::iteratorPrototype):
(JSC::JSGlobalObject::promisePrototype):
(JSC::JSGlobalObject::debuggerScopeStructure):
(JSC::JSGlobalObject::withScopeStructure):
(JSC::JSGlobalObject::iteratorResultStructure):
(JSC::JSGlobalObject::iteratorResultStructureOffset):
(JSC::JSGlobalObject::regExpMatchesArrayStructure):
(JSC::JSGlobalObject::promiseStructure):
- runtime/JSPromise.cpp:
(JSC::JSPromise::result):
- runtime/JSPromise.h:
- runtime/JSPromiseConstructor.cpp:
(JSC::constructPromise):
- runtime/JSPromiseConstructor.h:
- runtime/JSPromiseDeferred.cpp:
(JSC::JSPromiseDeferred::visitChildren):
- runtime/JSPromiseDeferred.h:
- runtime/JSPromisePrototype.cpp:
(JSC::JSPromisePrototype::getOwnPropertySlot):
- runtime/JSPromisePrototype.h:
- runtime/RuntimeFlags.h:
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- bindings/js/JSDOMPromise.cpp:
(WebCore::rejectPromiseWithExceptionIfAny):
- bindings/js/JSDOMPromise.h:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
- WebView/WebPreferencesPrivate.h:
Source/WebKit/win:
- Interfaces/IWebPreferencesPrivate.idl:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
Source/WTF:
- wtf/FeatureDefines.h:
- 5:32 PM Changeset in webkit [187278] by
-
- 9 edits2 adds in trunk
AX: AccessibilityNodeObject::childrenChanged() generates too many AXLiveRegionChanged notifications
https://bugs.webkit.org/show_bug.cgi?id=147211
<rdar://problem/19908029>
Patch by Nan Wang <n_wang@apple.com> on 2015-07-23
Reviewed by Chris Fleizach.
Source/WebCore:
AccessibilityNodeObject::childrenChanged() can be called repeatedly, generating a live region
change notification each time. Sometimes, so many happen that VoiceOver hangs. We can use a timer
to make sure that we coalesce these notifications.
Test: platform/mac/accessibility/aria-multiple-liveregions-notification.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXComputedObjectAttributeCache::getIgnored):
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::frameLoadingEventNotification):
(WebCore::AXObjectCache::postLiveRegionChangeNotification):
(WebCore::AXObjectCache::liveRegionChangedNotificationPostTimerFired):
(WebCore::AXObjectCache::handleScrollbarUpdate):
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::childrenChanged):
LayoutTests:
- platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt:
- platform/mac/accessibility/aria-liveregions-notifications-always-sent.html:
- platform/mac/accessibility/aria-liveregions-notifications-expected.txt:
- platform/mac/accessibility/aria-liveregions-notifications.html:
- platform/mac/accessibility/aria-multiple-liveregions-notification-expected.txt: Added.
- platform/mac/accessibility/aria-multiple-liveregions-notification.html: Added.
- 5:28 PM Changeset in webkit [187277] by
-
- 2 edits in branches/safari-600.8-branch/LayoutTests
Roll out r187241. rdar://problem/21707900
- 5:27 PM Changeset in webkit [187276] by
-
- 3 edits2 deletes in branches/safari-600.8-branch
Roll out r185838. rdar://problem/21707900
- 5:23 PM Changeset in webkit [187275] by
-
- 3 edits2 deletes in branches/safari-600.1.4.17-branch
Roll out r185838. rdar://problem/21708257
- 5:19 PM Changeset in webkit [187274] by
-
- 5 edits in trunk/Source/WebCore
[iOS] Frame snapshots don't factor in page scale
https://bugs.webkit.org/show_bug.cgi?id=147239
<rdar://problem/21905756>
Reviewed by Simon Fraser.
- page/FrameSnapshotting.cpp:
(WebCore::snapshotFrameRect):
Apply page scale when determining the backing store size and setting up the context.
- page/TextIndicator.cpp:
(WebCore::TextIndicator::createWithSelectionInFrame):
Don't assume snapshotFrameRect gave us an image with scale=deviceScale, because it
will factor in the pageScale too.
- platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::resolutionScale):
Expose resolutionScale.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMap):
This has been true for a long time.
- 5:08 PM Changeset in webkit [187273] by
-
- 2 edits in trunk/Source/WebCore
Adding Web Components to feature status page.
https://bugs.webkit.org/show_bug.cgi?id=147209
Reviewed by Timothy Hatcher.
- features.json:
- 4:46 PM Changeset in webkit [187272] by
-
- 26 edits in trunk/Source
Notify the UI delegate when a MediaDocument's natural size changes
https://bugs.webkit.org/show_bug.cgi?id=147182
Reviewed by Simon Fraser.
Source/WebCore:
Notify the MediaDocument that it's underlying media element has changed its natural size, either when
the media engine notifies us that the size changed, or when the ready state progresses to HAVE_METADATA.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setReadyState): Notify the media document.
(WebCore::HTMLMediaElement::mediaPlayerSizeChanged): Ditto.
- html/MediaDocument.cpp:
(WebCore::MediaDocument::mediaElementNaturalSizeChanged): Pass to the chrome client.
- html/MediaDocument.h:
- page/ChromeClient.h:
Source/WebKit2:
Pipe notifications of media document natural size changes up from the chrome client, through
to the UIProcess, through the page client, through the WKWebView, to the UIDelegate.
- UIProcess/API/APIUIClient.h:
(API::UIClient::mediaDocumentNaturalSizeChanged):
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _mediaDocumentNaturalSizeChanged:]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::mediaDocumentNaturalSizeChanged):
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::mediaDocumentNaturalSizeChanged):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::mediaDocumentNaturalSizeChanged):
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::mediaDocumentNaturalSizeChanged):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::mediaDocumentNaturalSizeChanged):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mediaDocumentNaturalSizeChanged):
- WebProcess/WebPage/WebPage.h:
- UIProcess/API/gtk/PageClientImpl.h: Add default, empty implementation of new pure-virtual method.
- UIProcess/efl/WebViewEfl.h: Ditto.
- 4:43 PM Changeset in webkit [187271] by
-
- 3 edits4 adds in trunk
Layer z-ordering is incorrect when scrolling on page witih position:fixed
https://bugs.webkit.org/show_bug.cgi?id=147220
rdar://problem/15849697&21929247
Reviewed by Dean Jackson.
Source/WebCore:
Overlap testing for compositing uses the currently laid out position of fixed
elements, without taking into account the fact that async scrolling can move
them around, and possibly under other non-composited elements. This manifested
as position:fixed elements moving over other elements on some pages when
scrolling, when they should have moved behind.
Fix by expanding the overlap map entry for position:fixed elements to create
an rect for the area they cover at all scroll locations, taking min and max
scroll offsets into account.
Also add a couple more LOG(Compositing) statements.
Tests: compositing/layer-creation/fixed-overlap-extent-rtl.html
compositing/layer-creation/fixed-overlap-extent.html
- rendering/RenderLayerCompositor.cpp:
(WebCore::fixedPositionOffset):
(WebCore::RenderLayerCompositor::computeExtent):
(WebCore::RenderLayerCompositor::needsFixedRootBackgroundLayer):
(WebCore::RenderLayerCompositor::rootBackgroundTransparencyChanged):
LayoutTests:
Tests that reveal the overlap area by creating lots of small layers, and dumping
the layer tree.
- compositing/layer-creation/fixed-overlap-extent-expected.txt: Added.
- compositing/layer-creation/fixed-overlap-extent-rtl-expected.txt: Added.
- compositing/layer-creation/fixed-overlap-extent-rtl.html: Added.
- compositing/layer-creation/fixed-overlap-extent.html: Added.
- 4:33 PM Changeset in webkit [187270] by
-
- 3 edits in trunk/Source/bmalloc
bmalloc: Shrink the super chunk size (again)
https://bugs.webkit.org/show_bug.cgi?id=147240
Reviewed by Andreas Kling.
Shrinking to 8MB reduced VM exhaustion crashes but did not eliminate them.
Let's try 4MB.
(My previous comment was that the maximum fast object was 2MB. But it
was 4MB! Now it's 2MB for realsies.)
- bmalloc/Sizes.h:
- 4:20 PM Changeset in webkit [187269] by
-
- 7 edits4 adds2 deletes in trunk/LayoutTests
Web Inspector: rewrite inspector-protocol/console tests to use new testing patterns
https://bugs.webkit.org/show_bug.cgi?id=147231
Reviewed by Joseph Pecoraro.
Restructure existing protocol tests for Console.messageAdded to use Promises and
modern event listener test interfaces. Add some new functionality to make it easier
install multiple protocol event listeners without clobbering.
This test also splits warnings-errors.html into two tests, one to cover CSS parser
warnings and one for JavaScript parser and runtime errors.
- http/tests/inspector-protocol/resources/InspectorTest.js:
(InspectorTest.sendCommand): Support arguments packaged in an object. This style is preferable
in tests because it is very explicit about what functionality and messages are covered.
(InspectorTest.awaitEvent): Added. This is a single-shot event listener that resolves a
promise when the desired protocol event is dispatched.
(InspectorTest.addEventListener): Reimplemented, based on code from WebInspector.Object.
Allows multiple listeners to be registered for a single protocol event.
(InspectorTest.AsyncTestSuite.prototype.runTestCases):
(InspectorTest.AsyncTestSuite):
(InspectorTest.SyncTestSuite.prototype.runTestCases):
(InspectorTest.SyncTestSuite):
(InspectorTest.log): Improve the formatting of test suite/test case output.
(InspectorFrontendAPI.dispatchMessageAsync): Dispatch to an array of listeners if available.
(InspectorTest.importScript): Clarify that this method performs a synchronous load.
(.InspectorTest.eventHandler.eventName): Deleted.
- inspector-protocol/async-test-suite-expected.txt: Rebaseline whitespace.
- inspector-protocol/sync-test-suite-expected.txt: Rebaseline whitespace.
- inspector-protocol/console/console-message-expected.txt:
- inspector-protocol/console/console-message.html:
- inspector-protocol/console/css-source-locations-expected.txt: Added.
- inspector-protocol/console/css-source-locations.html: Added.
- inspector-protocol/console/js-source-locations-expected.txt: Added.
- inspector-protocol/console/js-source-locations.html: Added.
- inspector-protocol/console/warnings-errors-expected.txt: Removed.
- inspector-protocol/console/warnings-errors.html: Removed.
- inspector-protocol/runtime/getProperties-expected.txt: Rebaseline whitespace.
- 4:16 PM Changeset in webkit [187268] by
-
- 2 edits in trunk/Source/WebKit2
Removing one incorrect annotation from the previous change.
Unreviewed.
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- 4:08 PM Changeset in webkit [187267] by
-
- 3 edits in trunk/Source/WebKit2
[iOS] Add another preview delegate for didDismissPreview.
https://bugs.webkit.org/show_bug.cgi?id=147241
rdar://problem/21664211
Reviewed by Tim Horton and Yongjun Zhang.
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _previewItemController:didDismissPreview:committing:]):
- 4:06 PM Changeset in webkit [187266] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/21910578> Second pass at [iOS] Keyboard shortcuts that take focus away from the web view end up typing a letter into the newly focused field
https://bugs.webkit.org/show_bug.cgi?id=146732
Reviewed by Darin Adler.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _interpretKeyEvent:isCharEvent:]): Rather than checking if the view is
first responder, which it might still be when the Web Content processes invokes this
callback, check if we are in editable content before forwarding the event to the keyboard.
- 3:53 PM Changeset in webkit [187265] by
-
- 1 edit4 adds in trunk/LayoutTests
Windows test result gardening after Mac libxml changes.
- platform/win/fast/dom/adopt-attribute-crash-expected.txt: Added.
- platform/win/fast/parser/xml-colon-entity-expected.txt: Added.
- platform/win/fast/parser/xml-declaration-missing-ending-mark-expected.txt: Added.
- platform/win/svg/custom/bug78807-expected.txt: Added.
- 3:32 PM Changeset in webkit [187264] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Unreviewed build fix after r187251; rename flag -> allows.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setAllowsMediaDocumentInlinePlayback):
- 3:29 PM Changeset in webkit [187263] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Unreviewed build fix after r187251.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setAllowsMediaDocumentInlinePlayback):
Use the correct name for the boolean to pass along to SetAllowsMediaDocumentInlinePlayback.
- 3:23 PM Changeset in webkit [187262] by
-
- 4 edits in trunk/Source/WebCore
Relax media playback restrictions if the allowsMediaDocumentInlinePlayback property is set.
https://bugs.webkit.org/show_bug.cgi?id=147234
Reviewed by Darin Adler.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::prepareForLoad): Moved restriction check into MediaElementSession.
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::playbackPermitted): Check if is a top-level media document and if
allowsMediaDocumentInilnePlayback is set, and return early.
(WebCore::MediaElementSession::effectivePreloadForElement): Ditto.
(WebCore::MediaElementSession::allowsAutomaticMediaDataLoading): Ditto.
- html/MediaElementSession.h:
- 3:19 PM Changeset in webkit [187261] by
-
- 3 edits2 adds in branches/safari-600.8-branch
Merged r187189. rdar://problem/21707927
- 3:18 PM Changeset in webkit [187260] by
-
- 3 edits2 adds in branches/safari-600.1.4.17-branch
Merged r187189. rdar://problem/21708281
- 3:16 PM Changeset in webkit [187259] by
-
- 3 edits in trunk/Source/WebKit2
One more iOS build fix.
Unreviewed.
- Platform/spi/ios/UIKitSPI.h:
- UIProcess/ios/WKContentViewInteraction.h:
- 3:15 PM Changeset in webkit [187258] by
-
- 15 edits in trunk/Source
Bridged passing lists of devices between the UIProcess and the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=147056
<rdar://problem/21883094>
Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-23
Reviewed by Brent Fulgham.
Source/WebCore:
- Modules/mediastream/UserMediaRequest.h: Added fields to store and
retrieve lists of devices
(WebCore::UserMediaRequest::deviceUIDsVideo):
(WebCore::UserMediaRequest::deviceUIDsAudio):
Source/WebKit2:
- UIProcess/UserMediaPermissionRequestManagerProxy.cpp: Modified file
to reflect changes made to the header in the .messages.in file
(WebKit::UserMediaPermissionRequestManagerProxy::createRequest): Ditto
(WebKit::UserMediaPermissionRequestManagerProxy::didReceiveUserMediaPermissionDecision):
- UIProcess/UserMediaPermissionRequestManagerProxy.h: Ditto
- UIProcess/UserMediaPermissionRequestProxy.cpp: Ditto
(WebKit::UserMediaPermissionRequestProxy::UserMediaPermissionRequestProxy):
- UIProcess/UserMediaPermissionRequestProxy.h:
(WebKit::UserMediaPermissionRequestProxy::create):
(WebKit::UserMediaPermissionRequestProxy::deviceUIDsVideo):
(WebKit::UserMediaPermissionRequestProxy::deviceUIDsAudio):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestUserMediaPermissionForFrame):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in: Changed heading
- WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:
(WebKit::UserMediaPermissionRequestManager::startRequest):
(WebKit::UserMediaPermissionRequestManager::didReceiveUserMediaPermissionDecision):
- WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveUserMediaPermissionDecision):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in: Changed heading
- 3:06 PM Changeset in webkit [187257] by
-
- 6 edits2 adds in trunk
Media Session: add support for ducking media elements https://bugs.webkit.org/show_bug.cgi?id=147089
Reviewed by Eric Carlson.
Test: media/session/transient-interruptions.html
- Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::handleDuckInterruption): Duck the active media elements.
(WebCore::MediaSession::handleUnduckInterruption): Unduck the active media elements.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateVolume): Lower the volume of media elements to 25% when ducked (constant determined empirically).
(WebCore::HTMLMediaElement::setShouldDuck): Call updateVolume to change the volume of the underlying media player.
- html/HTMLMediaElement.h:
- 3:02 PM Changeset in webkit [187256] by
-
- 6 edits in trunk/Source/WebCore
Media Session: add infrastructure for testing ducking https://bugs.webkit.org/show_bug.cgi?id=147080
Reviewed by Jer Noble.
We need to expose a media element's underlying media player's volume to tests so we can test ducking.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::playerVolume):
- html/HTMLMediaElement.h:
- testing/Internals.cpp:
(WebCore::Internals::mediaElementPlayerVolume):
- testing/Internals.h:
- testing/Internals.idl:
- 3:00 PM Changeset in webkit [187255] by
-
- 2 edits in trunk/Source/WebKit2
Adopt the new _previewItemControllerDidCancelPreview delegate method.
https://bugs.webkit.org/show_bug.cgi?id=147238
Don't allow hightlight long press to trigger tap if the link preview is cancelled because
the link is not preview-able.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2015-07-23
Reviewed by Beth Dakin.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _previewItemControllerDidCancelPreview:]):
- 2:26 PM Changeset in webkit [187254] by
-
- 3 edits3 adds in trunk/Source/JavaScriptCore
Implement WebAssembly modules
https://bugs.webkit.org/show_bug.cgi?id=147222
Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-07-23
Reviewed by Mark Lam.
Introducing the boilerplate data structure for the WebAssembly module.
WebAssembly functionality will be added in a subsequent patch.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- wasm/JSWASMModule.cpp: Added.
(JSC::JSWASMModule::visitChildren):
- wasm/JSWASMModule.h: Added.
(JSC::JSWASMModule::create):
(JSC::JSWASMModule::createStructure):
(JSC::JSWASMModule::JSWASMModule):
- 2:19 PM Changeset in webkit [187253] by
-
- 2 edits in trunk/Source/WebKit2
iOS build fix after http://trac.webkit.org/changeset/187238.
Unreviewed.
- Platform/spi/ios/UIKitSPI.h:
- 2:17 PM Changeset in webkit [187252] by
-
- 5 edits in trunk/Source/WebKit2
[WK2] Add a WKWebView property for whether the view is displaying a media document
https://bugs.webkit.org/show_bug.cgi?id=147233
Reviewed by Beth Dakin.
Add a _isDisplayingStandaloneMediaDocument property, which queries the frame for whether
the current MIME type is one which our media engines support.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _isDisplayingStandaloneMediaDocument]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::isDisplayingStandaloneMediaDocument):
- UIProcess/WebFrameProxy.h:
- 2:15 PM Changeset in webkit [187251] by
-
- 16 edits in trunk/Source
[iOS] Add an explicit API to allow media documents to (temporarily) play inline
https://bugs.webkit.org/show_bug.cgi?id=147181
Reviewed by Beth Dakin.
Source/WebCore:
Add listeners for the new allowsMediaDocumentInlinePlayback API. When this value becomes
NO, force any playing MediaDocuments to enter fullscreen mode.
- dom/Document.cpp:
(WebCore::Document::registerForAllowsMediaDocumentInlinePlaybackChangedCallbacks): Added registration method.
(WebCore::Document::unregisterForAllowsMediaDocumentInlinePlaybackChangedCallbacks): Added deregistration method.
(WebCore::Document::allowsMediaDocumentInlinePlaybackChanged): Notify all listeners.
- dom/Document.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::registerWithDocument): Listen for allowsMediaDocumentInlinePlayback changes.
(WebCore::HTMLMediaElement::unregisterWithDocument): Stop listening to same.
(WebCore::HTMLMediaElement::allowsMediaDocumentInlinePlaybackChanged): Enter fullscreen mode if the value
changes to false during playback.
- html/HTMLMediaElement.h:
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback): Early true if the override value is set.
- page/Page.cpp:
(WebCore::Page::setAllowsMediaDocumentInlinePlayback): Notify all documents of the changed value.
- page/Page.h:
(WebCore::Page::allowsMediaDocumentInlinePlayback): Simple getter.
Source/WebKit2:
Add a WKWebView(Private) API which allows MediaDocuments loaded by the view to play their contents inline, regardless
of whether inline playback is restricted on the current device.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setRequiresUserActionForMediaPlayback:]): Added. Pass through to WebPageProxy.
(-[WKWebView _allowsMediaDocumentInlinePlayback]): Ditto.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::allowsMediaDocumentInlinePlayback): Simple getter.
(WebKit::WebPageProxy::setAllowsMediaDocumentInlinePlayback): Set, and conditionally pass the new value to WebPage.
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setAllowsMediaDocumentInlinePlayback): Set, and conditionally notify WebCore page of the change.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::allowsMediaDocumentInlinePlayback): Simple getter.
- WebProcess/WebPage/WebPage.messages.in: Add new messages.
- 1:53 PM Changeset in webkit [187250] by
-
- 2 edits in trunk/Source/WebKit2
Should not allow previews of 1x1 images
https://bugs.webkit.org/show_bug.cgi?id=147237
-and corresponding-
rdar://problem/21968460
Reviewed by Tim Horton.
1x1 images are used on some sites to cover actual images, which leads to a
misleading preview experience. There is not any reason why you would really
want to preview an image this small nor any reason to believe that the
preview would result in anything useful.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
- 1:24 PM Changeset in webkit [187249] by
-
- 18 edits2 adds in trunk
Web Inspector: Add a function to CSSCompletions to get a list of supported system fonts
https://bugs.webkit.org/show_bug.cgi?id=147009
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- inspector/protocol/CSS.json: Added getSupportedSystemFontFamilyNames function.
Source/WebCore:
Test: inspector/css/get-system-fonts.html
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getSupportedSystemFontFamilyNames):
Gets the list of system fonts (implemented in each platform) and returns that list.
- inspector/InspectorCSSAgent.h:
- platform/graphics/FontCache.h:
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::systemFontFamilies):
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::FontCache::systemFontFamilies):
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::systemFontFamilies):
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::systemFontFamilies):
Source/WebInspectorUI:
- UserInterface/Base/Main.js:
(WebInspector.loaded):
(WebInspector.activateExtraDomains):
- UserInterface/Base/Test.js:
(WebInspector.loaded):
- UserInterface/Models/CSSCompletions.js:
(WebInspector.CSSCompletions.requestCSSCompletions.fontFamilyNamesCallback):
(WebInspector.CSSCompletions.requestCSSCompletions):
Now also grabs the list of system font family names and adds that list to the existing completion
list for both font and font-family in CSSKeywordCompletions.
(WebInspector.CSSCompletions.requestCSSNameCompletions): Deleted.
LayoutTests:
Skip the get-system-fonts test until it is implemented.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/win/TestExpectations:
Added the get-system-fonts test that returns the list of system fonts.
- inspector/css/get-system-fonts-expected.html:
- inspector/css/get-system-fonts.html:
- 1:18 PM Changeset in webkit [187248] by
-
- 3 edits2 adds in trunk
Crash in WebPlatformStrategies::createPingHandle - Deref a null NetworkingContext.
<rdar://problem/21949735> and https://bugs.webkit.org/show_bug.cgi?id=147227
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createPingHandle): Skip it if there's a null NetworkingContext.
LayoutTests:
- http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher.html: Added.
- 1:05 PM Changeset in webkit [187247] by
-
- 4 edits3 adds in trunk/Websites/webkit.org
Change some images for a blog post and add 2x images.
- blog-files/inspector-elements-tab-2x.png: Added.
- blog-files/inspector-elements-tab.png: Updated.
- blog-files/inspector-network-tab-2x.png: Added.
- blog-files/inspector-network-tab.png: Updated.
- blog-files/inspector-tab-bar-2x.png: Added.
- blog-files/inspector-tab-bar.png: Updated.
- 1:02 PM Changeset in webkit [187246] by
-
- 5 edits in branches/safari-601.1-branch/Source
Versioning.
- 12:30 PM Changeset in webkit [187245] by
-
- 20 edits2 adds in trunk
Source/WebCore:
[Win] Implement High DPI support features
https://bugs.webkit.org/show_bug.cgi?id=146335
<rdar://problem/21558269>
Reviewed by Alex Christensen.
- platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(WebCore::PlatformCALayerWinInternal::drawTile): Don't translate the CGContext to the position
of the CACFLayerRef; the underlying context is already in the right position.
- platform/win/PlatformMouseEventWin.cpp: Update class to adjust mouse
event coordinates based on scaling factor.
(WebCore::deviceScaleFactor):
(WebCore::positionForEvent):
- platform/win/ScrollbarThemeWin.cpp:
(WebCore::scrollbarThicknessInPixels):
(WebCore::ScrollbarThemeWin::scrollbarThickness):
(WebCore::ScrollbarThemeWin::themeChanged):
- platform/win/WheelEventWin.cpp: Update class to adjust wheel event
coordinates based on scaling factor.
(WebCore::deviceScaleFactor):
(WebCore::positionForEvent):
(WebCore::globalPositionForEvent):
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
Source/WebKit/win:
[Win] Implement High DPI support features
https://bugs.webkit.org/show_bug.cgi?id=146335
<rdar://problem/21558269>
Reviewed by Alex Christensen.
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::transitionToCommittedForNewPage): Size
page for current device scale factor.
- WebFrame.cpp:
(WebFrame::paintDocumentRectToContext): Account for device scale factor.
(WebFrame::paintScrollViewRectToContextAtPoint): Ditto.
- WebView.cpp:
(WebView::repaint): Adjust paint rect for device scale factor.
(WebView::scrollBackingStore): Adjust coordinates for scale factor.
(WebView::sizeChanged): Ditto.
(WebView::updateBackingStore): Ditto.
(WebView::paint): Ditto.
(WebView::paintIntoBackingStore): Ditto.
(WebView::handleContextMenuEvent): Ditto.
(WebView::gestureNotify): Ditto.
(WebView::gesture): Ditto.
(WebView::initializeToolTipWindow): Adjust max tool tip width
for device scale factor.
(WebView::selectionRect): Adjust coordinates for scale factor.
(WebView::elementAtPoint): Ditto.
(WebView::scrollOffset): Ditto.
(WebView::scrollBy): Ditto.
(WebView::visibleContentRect): Ditto.
(WebView::paintContents): Ditto.
- WebView.h:
Tools:
[Win] Implement proper High DPI support features
https://bugs.webkit.org/show_bug.cgi?id=146335
<rdar://problem/21558269>
Reviewed by Alex Christensen.
Update WinLauncher to take device scaling factor into account.
- WinLauncher/Common.cpp:
(resizeSubViews): Make sure toolbars and URL bar are properly sized and using
a valid font.
(computeFullDesktopFrame): Handle high DPI desktops.
(WndProc): Make comments more precise.
- WinLauncher/WinLauncher.cpp:
(WinLauncher::init): Determine device scale factor at launch.
(WinLauncher::updateDeviceScaleFactor): Added.
- WinLauncher/WinLauncher.h:
- WinLauncher/WinLauncherWebHost.h: Use C++11 initialization.
- WinLauncher/WinMain.cpp: Size interface based on scaling factor.
(wWinMain): Ditto.
- win/DLLLauncher/DLLLauncherMain.cpp:
(wWinMain): Tell Windows we understand high DPI.
- 12:15 PM Changeset in webkit [187244] by
-
- 4 edits1 add in trunk
REGRESSION(r182236): Justified Arabic text does not expand
https://bugs.webkit.org/show_bug.cgi?id=147217
Reviewed by Simon Fraser.
When I was writing r182236, I got confused between the levels of the string hierarchy in ComplexTextController.
I've added a comment in the header which should make it easier to get it right.
Test: fast/text/international/arabic-justify.html
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
- platform/graphics/mac/ComplexTextController.h:
- 12:08 PM Changeset in webkit [187243] by
-
- 3 edits in branches/safari-601.1-branch
Merge r186900.
2015-07-16 David Kilzer <ddkilzer@apple.com>
Mark fast/canvas/canvas-too-large-to-draw.html as crashing on El Capitan
Fix is tracked by <rdar://problem/21857102>.
- platform/mac/TestExpectations: Mark test as crashing:
- fast/canvas/canvas-too-large-to-draw.html
- 12:01 PM Changeset in webkit [187242] by
-
- 2 edits in branches/safari-601.1-branch/LayoutTests
More test gardening.
- platform/mac/TestExpectations:
- 11:52 AM Changeset in webkit [187241] by
-
- 2 edits in branches/safari-600.8-branch/LayoutTests
Skip a couple of region selection tests.
- platform/mac/TestExpectations:
- 11:34 AM Changeset in webkit [187240] by
-
- 1 edit4 deletes in trunk/Source/WebKit2
Remove some files that should have been removed with WebKit2 Windows
https://bugs.webkit.org/show_bug.cgi?id=147223
Reviewed by Csaba Osztrogonác.
- Shared/API/c/cf/WKURLRequestCF.cpp: Removed.
- Shared/API/c/cf/WKURLRequestCF.h: Removed.
- Shared/API/c/cf/WKURLResponseCF.cpp: Removed.
- Shared/API/c/cf/WKURLResponseCF.h: Removed.
- 11:21 AM Changeset in webkit [187239] by
-
- 3 edits in trunk/Websites/webkit.org
Change some images for a blog post.
- blog-files/inspector-elements-tab.png:
- blog-files/inspector-network-tab.png:
- 11:04 AM Changeset in webkit [187238] by
-
- 2 edits in trunk/Source/WebKit2
Fix the build
- Platform/spi/ios/UIKitSPI.h:
- 11:03 AM Changeset in webkit [187237] by
-
- 2 edits2 adds1 delete in trunk/Websites/webkit.org
Add and change some images for a blog post.
- blog-files/inspector-elements-network-tabs.png: Removed.
- blog-files/inspector-elements-tab.png: Added.
- blog-files/inspector-network-tab.png: Added.
- blog-files/inspector-tab-bar.png:
- 10:30 AM Changeset in webkit [187236] by
-
- 6 edits in trunk/Websites/webkit.org
Correct rest of the images to match.
- blog-files/backdrop-filters/backdrop_correct_1x.jpg:
- blog-files/backdrop-filters/backdrop_correct_2x.jpg:
- blog-files/backdrop-filters/backdrop_invert_1x.jpg:
- blog-files/backdrop-filters/backdrop_invert_2x.jpg:
- blog-files/backdrop-filters/backdrop_mixed_1x.jpg:
- 10:26 AM Changeset in webkit [187235] by
-
- 2 edits in trunk/Tools
[Win] Unreviewed build fix after r187169.
- Scripts/build-webkit:
Correctly find WebKit.sln.
- 10:21 AM Changeset in webkit [187234] by
-
- 6 edits in trunk/Websites/webkit.org
Adjust image sizes to avoid page scaling.
- blog-files/backdrop-filters/Screen_OSX_Yosemite_Finder-iCloud-WaterBg_1x.jpg:
- blog-files/backdrop-filters/Screen_OSX_Yosemite_Finder-iCloud-WaterBg_2x.jpg:
- blog-files/backdrop-filters/Screen_V_iOS8_ControlCenter_BlueGradient_1x.jpg:
- blog-files/backdrop-filters/Screen_V_iOS8_ControlCenter_BlueGradient_2x.jpg:
- blog-files/backdrop-filters/backdrop_mixed_2x.jpg:
- 10:19 AM Changeset in webkit [187233] by
-
- 4 edits in branches/safari-601.1-branch
Merge r186677, which is a follow-up fix to r186642.
2015-07-10 Brady Eidson <beidson@apple.com>
ASSERT restoring from page cache as DocumentLoader reattaches to its Frame.
<rdar://problem/21766282> and https://bugs.webkit.org/show_bug.cgi?id=146786
Reviewed by NOBODY (Fixing obvious boneheaded mistake in r186642)
No new tests (Covered by existing)
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::attachToFrame): Bail if reattaching to the current Frame, which happens when restoring from the page cache.
- 10:04 AM Changeset in webkit [187232] by
-
- 23 edits in branches/safari-601.1-branch/LayoutTests
More test updates for features that are disabled on this branch.
- css3/parse-align-content-expected.txt:
- css3/parse-align-items-expected.txt:
- css3/parse-align-self-expected.txt:
- css3/parse-justify-content-expected.txt:
- fast/css/css-selector-text-expected.txt:
- fast/css/css-set-selector-text-expected.txt:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/css/parse-justify-items-expected.txt:
- fast/css/parse-justify-items.html:
- fast/css/read-only-read-write-input-basics-expected.html:
- fast/css/read-only-read-write-input-basics.html:
- fast/dom/navigator-detached-no-crash-expected.txt:
- fast/selectors/read-only-read-write-input-basics-expected.txt:
- js/dom/dom-static-property-for-in-iteration-expected.txt:
- platform/mac-mavericks/accessibility/roles-exposed-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/accessibility/roles-exposed-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 9:24 AM Changeset in webkit [187231] by
-
- 3 edits in branches/safari-601.1-branch
Merge r187194.
2015-07-22 Myles C. Maxfield <mmaxfield@apple.com>
[El Capitan] Test Gardening
Unreviewed.
- platform/mac/fast/text/ligature-subdivision-expected.txt:
- 9:21 AM Changeset in webkit [187230] by
-
- 28 edits13 copies in branches/safari-601.1-branch
Merge r187126.
2015-07-21 Myles C. Maxfield <mmaxfield@apple.com>
[El Capitan] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=147059
- platform/mac-yosemite/fast/dom/52776-expected.png: Copied from LayoutTests/platform/mac/fast/dom/52776-expected.png.
- platform/mac-yosemite/fast/text/complex-text-opacity-expected.png: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.png.
- platform/mac-yosemite/fast/text/font-weights-expected.png: Copied from LayoutTests/platform/mac/fast/text/font-weights-expected.png.
- platform/mac-yosemite/fast/text/indic-expected.png: Copied from LayoutTests/platform/mac/fast/text/indic-expected.png.
- platform/mac-yosemite/fast/text/indic-expected.txt: Copied from LayoutTests/platform/mac/fast/text/indic-expected.txt.
- platform/mac-yosemite/fast/text/international/bidi-AN-after-L-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.png.
- platform/mac-yosemite/fast/text/international/bidi-mirror-he-ar-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png.
- platform/mac-yosemite/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png.
- platform/mac-yosemite/fast/text/international/bidi-neutral-run-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-run-expected.png.
- platform/mac-yosemite/fast/text/international/danda-space-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/danda-space-expected.png.
- platform/mac-yosemite/fast/text/international/danda-space-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/danda-space-expected.txt.
- platform/mac-yosemite/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png.
- platform/mac-yosemite/svg/text/text-intro-05-t-expected.png: Copied from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.png.
- platform/mac/fast/dom/52776-expected.png:
- platform/mac/fast/dom/52776-expected.txt:
- platform/mac/fast/text/arabic-times-new-roman-expected.png:
- platform/mac/fast/text/arabic-times-new-roman-expected.txt:
- platform/mac/fast/text/complex-text-opacity-expected.png:
- platform/mac/fast/text/complex-text-opacity-expected.txt:
- platform/mac/fast/text/font-weights-expected.png:
- platform/mac/fast/text/font-weights-expected.txt:
- platform/mac/fast/text/indic-expected.png:
- platform/mac/fast/text/indic-expected.txt:
- platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
- platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
- platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
- platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
- platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
- platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
- platform/mac/fast/text/international/bidi-neutral-run-expected.png:
- platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
- platform/mac/fast/text/international/danda-space-expected.png:
- platform/mac/fast/text/international/danda-space-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
- platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
- platform/mac/svg/text/text-intro-05-t-expected.png:
- platform/mac/svg/text/text-intro-05-t-expected.txt:
- 9:17 AM Changeset in webkit [187229] by
-
- 11 edits8 copies in branches/safari-601.1-branch/LayoutTests
Merge r187148.
2015-07-21 Alexey Proskuryakov <ap@apple.com>
Update Mac test results for libxml2 v2.9.2.
These results will probably become cross-platform eventually, but for now it's just Mac.
- platform/mac-yosemite/fast/dom/adopt-attribute-crash-expected.txt: Copied from LayoutTests/fast/dom/adopt-attribute-crash-expected.txt.
- platform/mac-yosemite/fast/parser: Added.
- platform/mac-yosemite/fast/parser/xml-colon-entity-expected.txt: Copied from LayoutTests/fast/parser/xml-colon-entity-expected.txt.
- platform/mac-yosemite/fast/parser/xml-declaration-missing-ending-mark-expected.txt: Copied from LayoutTests/fast/parser/xml-declaration-missing-ending-mark-expected.txt.
- platform/mac-yosemite/fast/xsl: Added.
- platform/mac-yosemite/fast/xsl/xslt-extra-content-at-end-expected.png: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png.
- platform/mac-yosemite/fast/xsl/xslt-extra-content-at-end-expected.txt: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt.
- platform/mac-yosemite/fast/xsl/xslt-missing-namespace-in-xslt-expected.png: Copied from LayoutTests/platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.png.
- platform/mac-yosemite/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt: Copied from LayoutTests/platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt.
- platform/mac-yosemite/svg/custom: Added.
- platform/mac-yosemite/svg/custom/bug78807-expected.txt: Copied from LayoutTests/svg/custom/bug78807-expected.txt.
- platform/mac-yosemite/svg/custom/missing-xlink-expected.png: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.png.
- platform/mac-yosemite/svg/custom/missing-xlink-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.txt.
- platform/mac-yosemite/svg/custom/path-bad-data-expected.png: Copied from LayoutTests/platform/mac/svg/custom/path-bad-data-expected.png.
- platform/mac-yosemite/svg/custom/path-bad-data-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/path-bad-data-expected.txt.
- platform/mac-yosemite/svg/custom/use-font-face-crash-expected.png: Copied from LayoutTests/platform/mac/svg/custom/use-font-face-crash-expected.png.
- platform/mac-yosemite/svg/custom/use-font-face-crash-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/use-font-face-crash-expected.txt.
- platform/mac/fast/dom/adopt-attribute-crash-expected.txt: Added.
- platform/mac/fast/parser/xml-colon-entity-expected.txt: Added.
- platform/mac/fast/parser/xml-declaration-missing-ending-mark-expected.txt: Added.
- platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png:
- platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt:
- platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.png:
- platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
- platform/mac/svg/custom/bug78807-expected.txt: Added.
- platform/mac/svg/custom/missing-xlink-expected.png:
- platform/mac/svg/custom/missing-xlink-expected.txt:
- platform/mac/svg/custom/path-bad-data-expected.png:
- platform/mac/svg/custom/path-bad-data-expected.txt:
- platform/mac/svg/custom/use-font-face-crash-expected.png:
- platform/mac/svg/custom/use-font-face-crash-expected.txt:
- 7:02 AM Changeset in webkit [187228] by
-
- 2 edits in trunk/LayoutTests
Application cache abort() tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=87633
These AppCache tests are flakey:
http/tests/appcache/deferred-events-delete-while-raising-timer.html
http/tests/appcache/deferred-events-delete-while-raising.html
http/tests/appcache/deferred-events.html
http/tests/appcache/fail-on-update-2.html
- 7:00 AM Changeset in webkit [187227] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: wrong cursor shown when selecting time interval from timeline overview
https://bugs.webkit.org/show_bug.cgi?id=147094
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineRuler.css:
(.timeline-ruler.allows-time-range-selection.creating-selection):
New cursor style for entire ruler element.
- UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler.prototype._handleMouseMove):
(WebInspector.TimelineRuler.prototype._handleMouseUp):
Toggle cursor style when dragging to create a new selection in the overview.
- 5:21 AM Changeset in webkit [187226] by
-
- 2 edits in trunk/Source/WebKit/win
[Win] Fix typos in PluginViewWin.cpp: kWebPluginViewdowClassName -> kWebPluginViewClassName
https://bugs.webkit.org/show_bug.cgi?id=147214
Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-07-23
Reviewed by Csaba Osztrogonác.
- Plugins/PluginViewWin.cpp:
(WebCore::registerPluginView):
(WebCore::PluginView::platformStart):
- 3:11 AM Changeset in webkit [187225] by
-
- 2 edits in trunk/Source/WebCore
Fix the build for IPHONE_OS_VERSION_MIN_REQUIRED <= 80200 !HAVE(AVKIT) - platform/ios/WebVideoFullscreenControllerAVKit.mm:
(elementRectInWindow):
This helper is only used in the #else block, so move it there.
- 3:05 AM Changeset in webkit [187224] by
-
- 1 edit1 delete in trunk/Source/WebKit2
Remove files that were meant to be removed in r173929
- WebProcess/WebPage/mac/WebInspectorMac.mm: Removed.
- 2:58 AM Changeset in webkit [187223] by
-
- 1 edit1 delete in trunk/Source/WebKit2
Remove files that were meant to be removed in r168213
- UIProcess/API/Cocoa/WKErrorRecoveryAttempting.h: Removed.
- 2:50 AM Changeset in webkit [187222] by
-
- 1 edit3 deletes in trunk/Source/WebKit2
Remove files that were meant to be removed in r168229
- UIProcess/API/Cocoa/WKSession.h: Removed.
- UIProcess/API/Cocoa/WKSession.mm: Removed.
- UIProcess/API/Cocoa/WKSessionInternal.h: Removed.
- 2:18 AM Changeset in webkit [187221] by
-
- 1 edit2 deletes in trunk/Source/WebKit2
Remove files that were meant to be removed in r165014
- WebProcess/WebPage/mac/WKAccessibilityWebPageObject.h: Removed.
- WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm: Removed.
- 1:23 AM Changeset in webkit [187220] by
-
- 14 edits in trunk
[GTK] Add API to allow executing editing commands that require an argument
https://bugs.webkit.org/show_bug.cgi?id=146781
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
Commands like InsertImage or CreateLink receive an argument, but
we only have webkit_web_view_execute_editing_command() that
doesn't receive any argument. This patch adds
webkit_web_view_execute_editing_command_with_argument() for those
commands. It also adds WEBKIT_EDITING_COMMAND_INSERT_IMAGE and
WEBKIT_EDITING_COMMAND_CREATE_LINK to the predefined editing commands.
- UIProcess/API/gtk/WebKitEditingCommands.h: Add
WEBKIT_EDITING_COMMAND_INSERT_IMAGE and WEBKIT_EDITING_COMMAND_CREATE_LINK.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_execute_editing_command_with_argument):
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Add new symbols.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::executeEditCommand): Pass also the argument
to the message.
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::executeEditCommand): Add the argument parameter
to the message handler.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in: Add argument parameter
to ExecuteEditCommand message.
Tools:
Add buttons to insert image/link to the MiniBrowser edit toolbar,
and test cases for insert image/link commands too.
- MiniBrowser/gtk/BrowserWindow.c:
(insertImageCommandCallback):
(insertLinkCommandCallback):
(browserWindowSetupEditorToolbar):
(browserWindowConstructed):
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
(testWebViewEditorInsertImage):
(testWebViewEditorCreateLink):
(beforeAll):
- 12:58 AM Changeset in webkit [187219] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the build
- platform/spi/cocoa/QuartzCoreSPI.h:
- 12:31 AM Changeset in webkit [187218] by
-
- 2 edits in trunk/Tools
Unregistering and re-registering a user message handler does not work
https://bugs.webkit.org/show_bug.cgi?id=138142
Reviewed by Martin Robinson.
This has probably been fixed in r184846, enable the test case
blocked on it.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
(testUserContentManagerScriptMessageReceived):
