Context Navigation

← Previous Period
Next Period →

Timeline

Jul 25, 2015:

11:30 PM Changeset in webkit [187405] by Nikita Vasilyev

4 edits in trunk/Source/WebInspectorUI

Web Inspector: Start using Node.prototype.remove
https://bugs.webkit.org/show_bug.cgi?id=147304

Reviewed by Timothy Hatcher.

UserInterface/Base/Main.js:

(WebInspector.elementDragStart):
(WebInspector.elementDragEnd):
(WebInspector.revertDomChanges):

UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype._updateSearchHighlight.updateEntryHide):
(WebInspector.DOMTreeElement.prototype._updateSearchHighlight):
(WebInspector.DOMTreeElement.prototype.remove.removeNodeCallback):
(WebInspector.DOMTreeElement.prototype.remove):

UserInterface/Views/Resizer.js:

(WebInspector.Resizer.prototype._resizerMouseDown):
(WebInspector.Resizer.prototype._resizerMouseUp):
(WebInspector.Resizer):

11:23 PM Changeset in webkit [187404] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix color declaration for not-executed comments
https://bugs.webkit.org/show_bug.cgi?id=147305

Reviewed by Timothy Hatcher.

UserInterface/Views/SyntaxHighlightingDefaultTheme.css:

(.cm-s-default .basic-block-has-not-executed.cm-comment):
This was an RGB color mispelled as HSL. Replace "hsl" with "rgb"
and convert it to HSL.

11:19 PM Changeset in webkit [187403] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Start using Node.prototype.replaceWith
https://bugs.webkit.org/show_bug.cgi?id=147303

Reviewed by Timothy Hatcher.

UserInterface/Views/Popover.js:

(WebInspector.Popover.prototype._update):

10:46 PM Changeset in webkit [187402] by Nikita Vasilyev

21 edits in trunk/Source/WebInspectorUI

Web Inspector: Start using Node.prototype.append
https://bugs.webkit.org/show_bug.cgi?id=147301

Convert all instances of element.appendChild(document.createTextNode(aString))
to element.append(aString).

Reviewed by Timothy Hatcher.

UserInterface/Base/DOMUtilities.js:
UserInterface/Base/Main.js:

(WebInspector.linkifyLocation):
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):

UserInterface/Models/Breakpoint.js:

(WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement):

UserInterface/Views/BoxModelDetailsSectionRow.js:

(WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics):

UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection.prototype.refresh):

UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel):

UserInterface/Views/ChartDetailsSectionRow.js:

(WebInspector.ChartDetailsSectionRow.prototype._createLegendItem):

UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments):
(WebInspector.ConsoleMessageView.prototype._appendFormattedArguments):

UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility.accessibilityPropertiesCallback):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility):

UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype._insertInLastAttributePosition):
(WebInspector.DOMTreeElement.prototype._buildAttributeDOM):
(WebInspector.DOMTreeElement.prototype._buildTagDOM):
(WebInspector.DOMTreeElement.prototype._nodeTitleInfo):
defaultElement variable is unused, remove it.

UserInterface/Views/DataGrid.js:

(WebInspector.DataGridNode.prototype.createCell.get if):
(WebInspector.DataGridNode.prototype.createCell):

UserInterface/Views/DebuggerDashboardView.js:

(WebInspector.DebuggerDashboardView.prototype._rebuildLocation):

UserInterface/Views/EventListenerSectionGroup.js:

(WebInspector.EventListenerSectionGroup.prototype._functionTextOrLink):
(WebInspector.EventListenerSectionGroup):

UserInterface/Views/FormattedValue.js:

(WebInspector.FormattedValue.createLinkifiedElementString):
(WebInspector.FormattedValue.createElementForNodePreview):

UserInterface/Views/ObjectPreviewView.js:

(WebInspector.ObjectPreviewView.prototype._appendEntryPreviews):
(WebInspector.ObjectPreviewView.prototype._appendPropertyPreviews):

UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestDataSection):
(WebInspector.ResourceDetailsSidebarPanel):

UserInterface/Views/RulesStyleDetailsPanel.js:

(WebInspector.RulesStyleDetailsPanel.prototype.refresh.addNewRuleButton):
(WebInspector.RulesStyleDetailsPanel.prototype.refresh.insertMediaOrInheritanceLabel):

UserInterface/Views/SearchResultTreeElement.js:

(WebInspector.SearchResultTreeElement.truncateAndHighlightTitle):

UserInterface/Views/SyntaxHighlightingSupport.js:

(.appendText):
(WebInspector.syntaxHighlightStringAsDocumentFragment):

UserInterface/Views/TimelineDataGridNode.js:

(WebInspector.TimelineDataGridNode.prototype.createCellContent):

10:12 PM Changeset in webkit [187401] by Yusuke Suzuki

8 edits
4 adds in trunk/Source/JavaScriptCore

[ES6] Add Reflect namespace and add Reflect.deleteProperty
https://bugs.webkit.org/show_bug.cgi?id=147287

Reviewed by Sam Weinig.

This patch just creates the namespace for ES6 Reflect APIs.
And add template files to implement the actual code.

Not to keep the JS generated properties C array empty,
we added one small method, Reflect.deleteProperty in this patch.

CMakeLists.txt:
DerivedSources.make:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
builtins/ReflectObject.js: Added.

(deleteProperty):

runtime/CommonIdentifiers.h:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

runtime/ReflectObject.cpp: Added.

(JSC::ReflectObject::ReflectObject):
(JSC::ReflectObject::finishCreation):
(JSC::ReflectObject::getOwnPropertySlot):

runtime/ReflectObject.h: Added.

(JSC::ReflectObject::create):
(JSC::ReflectObject::createStructure):

tests/stress/reflect-delete-property.js: Added.

(shouldBe):
(shouldThrow):

7:53 PM Changeset in webkit [187400] by ap@apple.com

2 edits in branches/safari-601.1-branch/LayoutTests

Updating an expectation to actually work (it's a reftest, so it needs ImageOnlyFailure).

platform/mac/TestExpectations:

7:28 PM Changeset in webkit [187399] by ap@apple.com

2 edits in trunk/LayoutTests

REGRESSION (r186569): media/restore-from-page-cache.html is very flaky
https://bugs.webkit.org/show_bug.cgi?id=147254

platform/mac/TestExpectations: Updated the expectations, because the problem is

not limited to Debug Mavericks.

7:13 PM Changeset in webkit [187398] by ap@apple.com

2 edits in trunk/Source/WebCore

Remove an never failing check for client() in ResourceHandle::canAuthenticateAgainstProtectionSpace.

Requested by Brady Eidson in bug 147277.

platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace):

7:09 PM Changeset in webkit [187397] by ap@apple.com

15 edits in branches/safari-601.1-branch/LayoutTests

Update test results after r187346 ('>>' descendant combinator).

fast/css/css-selector-text-expected.txt:
fast/css/css-set-selector-text-expected.txt:
fast/css/parsing-css-attribute-case-insensitive-value-1-expected.txt:
fast/css/parsing-css-attribute-case-insensitive-value-4-expected.txt:
fast/css/parsing-css-descendant-combinator-doubled-child-syntax-expected.txt:
fast/selectors/case-insensitive-attribute-register-requirement-2-expected.txt:
fast/selectors/element-closest-descendant-combinator-doubled-child-syntax-expected.txt:
fast/selectors/element-matches-attribute-ascii-case-insensitive-html-expected.txt:
fast/selectors/element-matches-descendant-combinator-doubled-child-syntax-expected.txt:
fast/selectors/nth-child-matching-first-expected.txt:
fast/selectors/nth-last-child-matching-first-expected.txt:
fast/selectors/querySelector-attribute-ascii-case-insensitive-html-expected.txt:
fast/selectors/querySelector-descendant-combinator-doubled-child-syntax-expected.txt:
platform/mac/TestExpectations:

6:38 PM Changeset in webkit [187396] by ap@apple.com

2 edits in trunk/LayoutTests

REGRESSION?: Frame scrollability tests are very flaky
https://bugs.webkit.org/show_bug.cgi?id=147300

platform/mac-wk2/TestExpectations: Marking them as such.

6:30 PM Changeset in webkit [187395] by ap@apple.com

4 edits in trunk/LayoutTests

inspector/css/modify-rule-selector.html times out (flakily on some platforms, and
every time on others).
https://bugs.webkit.org/show_bug.cgi?id=147229

platform/gtk/TestExpectations:
platform/mac-wk2/TestExpectations:
platform/win/TestExpectations:

Added expectations.

6:01 PM Changeset in webkit [187394] by ap@apple.com

2 edits in trunk/LayoutTests

aria-liveregions-notifications tests are very flaky
https://bugs.webkit.org/show_bug.cgi?id=147299

platform/mac/TestExpectations: Marked them as such.

5:31 PM Changeset in webkit [187393] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Expose TextIndicator-backed snapshot and rect gathering on DOMNode
https://bugs.webkit.org/show_bug.cgi?id=147298
<rdar://problem/21905839>

Reviewed by Sam Weinig.

bindings/objc/DOM.mm:

(-[DOMNode getPreviewSnapshotImage:andRects:]):
No need to multiply by device scale here.

4:28 PM Changeset in webkit [187392] by timothy_horton@apple.com

4 edits in trunk/Source/WebCore

Expose TextIndicator-backed snapshot and rect gathering on DOMNode
https://bugs.webkit.org/show_bug.cgi?id=147298
<rdar://problem/21905839>

bindings/objc/DOM.mm:

(-[DOMNode getPreviewSnapshotImage:andRects:]):

bindings/objc/DOMExtensions.h:
bindings/objc/DOMPrivate.h:

Move this to a private header.

4:11 PM Changeset in webkit [187391] by timothy_horton@apple.com

3 edits in trunk/Source/WebCore

Expose TextIndicator-backed snapshot and rect gathering on DOMNode
https://bugs.webkit.org/show_bug.cgi?id=147298
<rdar://problem/21905839>

Reviewed by Sam Weinig.

bindings/objc/DOM.mm:

(-[DOMNode getPreviewSnapshotImage:andRects:]):

bindings/objc/DOMExtensions.h:

10:51 AM Changeset in webkit [187390] by jer.noble@apple.com

37 edits in branches/safari-601.1-branch/Source

Merge r187251, r187252, r187262, r187263, r187272, r187289. rdar://problem/20689512

Source/WebCore:

2015-07-21 Jer Noble <jer.noble@apple.com>

Notify the UI delegate when a MediaDocument's natural size changes
https://bugs.webkit.org/show_bug.cgi?id=147182

Reviewed by Simon Fraser.

Notify the MediaDocument that it's underlying media element has changed its natural size, either when
the media engine notifies us that the size changed, or when the ready state progresses to HAVE_METADATA.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): Notify the media document. (WebCore::HTMLMediaElement::mediaPlayerSizeChanged): Ditto.
html/MediaDocument.cpp: (WebCore::MediaDocument::mediaElementNaturalSizeChanged): Pass to the chrome client.
html/MediaDocument.h:
page/ChromeClient.h:

2015-07-23 Jer Noble <jer.noble@apple.com>

Relax media playback restrictions if the allowsMediaDocumentInlinePlayback property is set.
https://bugs.webkit.org/show_bug.cgi?id=147234

Reviewed by Darin Adler.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForLoad): Moved restriction check into MediaElementSession.
html/MediaElementSession.cpp: (WebCore::MediaElementSession::playbackPermitted): Check if is a top-level media document and if

allowsMediaDocumentInilnePlayback is set, and return early.

(WebCore::MediaElementSession::effectivePreloadForElement): Ditto.
(WebCore::MediaElementSession::allowsAutomaticMediaDataLoading): Ditto.

html/MediaElementSession.h:

2015-07-21 Jer Noble <jer.noble@apple.com>

[iOS] Add an explicit API to allow media documents to (temporarily) play inline
https://bugs.webkit.org/show_bug.cgi?id=147181

Reviewed by Beth Dakin.

Add listeners for the new allowsMediaDocumentInlinePlayback API. When this value becomes
NO, force any playing MediaDocuments to enter fullscreen mode.

dom/Document.cpp: (WebCore::Document::registerForAllowsMediaDocumentInlinePlaybackChangedCallbacks): Added registration method. (WebCore::Document::unregisterForAllowsMediaDocumentInlinePlaybackChangedCallbacks): Added deregistration method. (WebCore::Document::allowsMediaDocumentInlinePlaybackChanged): Notify all listeners.
dom/Document.h:
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::registerWithDocument): Listen for allowsMediaDocumentInlinePlayback changes. (WebCore::HTMLMediaElement::unregisterWithDocument): Stop listening to same. (WebCore::HTMLMediaElement::allowsMediaDocumentInlinePlaybackChanged): Enter fullscreen mode if the value

changes to false during playback.

html/HTMLMediaElement.h:
html/MediaElementSession.cpp: (WebCore::MediaElementSession::requiresFullscreenForVideoPlayback): Early true if the override value is set.
page/Page.cpp: (WebCore::Page::setAllowsMediaDocumentInlinePlayback): Notify all documents of the changed value.
page/Page.h: (WebCore::Page::allowsMediaDocumentInlinePlayback): Simple getter.

Source/WebKit2:

2015-07-23 Alex Christensen <achristensen@webkit.org>

Fix 32-bit build after r187272.

UIProcess/mac/PageClientImpl.mm: (WebKit::PageClientImpl::mediaDocumentNaturalSizeChanged): Added some WK_API_ENABLED.

2015-07-23 Alex Christensen <achristensen@webkit.org>

[iOS] Unreviewed build fix after r187251.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setAllowsMediaDocumentInlinePlayback): Use the correct name for the boolean to pass along to SetAllowsMediaDocumentInlinePlayback.

2015-07-21 Jer Noble <jer.noble@apple.com>

Notify the UI delegate when a MediaDocument's natural size changes
https://bugs.webkit.org/show_bug.cgi?id=147182

Reviewed by Simon Fraser.

Pipe notifications of media document natural size changes up from the chrome client, through
to the UIProcess, through the page client, through the WKWebView, to the UIDelegate.

UIProcess/API/APIUIClient.h: (API::UIClient::mediaDocumentNaturalSizeChanged):
UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _mediaDocumentNaturalSizeChanged:]):
UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/Cocoa/UIDelegate.h:
UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::setDelegate): (WebKit::UIDelegate::UIClient::mediaDocumentNaturalSizeChanged):
UIProcess/PageClient.h:
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::mediaDocumentNaturalSizeChanged):
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::mediaDocumentNaturalSizeChanged):
UIProcess/mac/PageClientImpl.h:
UIProcess/mac/PageClientImpl.mm: (WebKit::PageClientImpl::mediaDocumentNaturalSizeChanged):
WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::mediaDocumentNaturalSizeChanged):
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::mediaDocumentNaturalSizeChanged):
WebProcess/WebPage/WebPage.h:
UIProcess/API/gtk/PageClientImpl.h: Add default, empty implementation of new pure-virtual method.
UIProcess/efl/WebViewEfl.h: Ditto.

2015-07-23 Jer Noble <jer.noble@apple.com>

Unreviewed build fix after r187251; rename flag -> allows.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setAllowsMediaDocumentInlinePlayback):

2015-07-23 Jer Noble <jer.noble@apple.com>

[WK2] Add a WKWebView property for whether the view is displaying a media document
https://bugs.webkit.org/show_bug.cgi?id=147233

Reviewed by Beth Dakin.

Add a _isDisplayingStandaloneMediaDocument property, which queries the frame for whether
the current MIME type is one which our media engines support.

UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _isDisplayingStandaloneMediaDocument]):
UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::isDisplayingStandaloneMediaDocument):
UIProcess/WebFrameProxy.h:

2015-07-21 Jer Noble <jer.noble@apple.com>

[iOS] Add an explicit API to allow media documents to (temporarily) play inline
https://bugs.webkit.org/show_bug.cgi?id=147181

Reviewed by Beth Dakin.

Add a WKWebView(Private) API which allows MediaDocuments loaded by the view to play their contents inline, regardless
of whether inline playback is restricted on the current device.

UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _setRequiresUserActionForMediaPlayback:]): Added. Pass through to WebPageProxy. (-[WKWebView _allowsMediaDocumentInlinePlayback]): Ditto.
UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::allowsMediaDocumentInlinePlayback): Simple getter. (WebKit::WebPageProxy::setAllowsMediaDocumentInlinePlayback): Set, and conditionally pass the new value to WebPage.
UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setAllowsMediaDocumentInlinePlayback): Set, and conditionally notify WebCore page of the change.
WebProcess/WebPage/WebPage.h: (WebKit::WebPage::allowsMediaDocumentInlinePlayback): Simple getter.
WebProcess/WebPage/WebPage.messages.in: Add new messages.

7:46 AM Changeset in webkit [187389] by clopez@igalia.com

2 edits in trunk/Source/WTF

REGRESSION (bmalloc): WebKit performance tests don't report memory stats.
https://bugs.webkit.org/show_bug.cgi?id=141247

Reviewed by Geoffrey Garen.

Meanwhile a better way of getting memory stats with bmalloc is not found
(see bug 136592), we can report as memory stats the resident set size
information that the operating system provides to us.

This at least should be good enough to get back the memory stats on the
performance tests and being able to track down memory usage regressions
at https://perf.webkit.org

wtf/FastMalloc.cpp:

(WTF::fastMallocStatistics): Report maxrss data as committedVMBytes.

2:19 AM Changeset in webkit [187388] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Another build fix. Removed the unused argument.

platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(PlatformCALayer::setTileSize):

1:07 AM Changeset in webkit [187387] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

iOS build fix after r187384.

platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(PlatformCALayer::setTileSize):

12:59 AM Changeset in webkit [187386] by Chris Fleizach

2 edits in trunk/Source/WebCore

AX: iOS: Video "start playback" playback controls not accessible
https://bugs.webkit.org/show_bug.cgi?id=147285

Reviewed by Jer Noble.

The start playback control also needs the right label.

Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.createBase):

Jul 24, 2015:

11:02 PM Changeset in webkit [187385] by timothy_horton@apple.com

2 edits
1 delete in trunk/Source/WebCore

Remove a file that was accidentally added in r142320

PlatformMac.cmake:
platform/mac/PlatformSpeechSynthesisMac.mm: Removed.

It looks like Chris added PlatformSpeechSynthesisMac and
PlatformSpeechSynthesizerMac but only meant to add the latter.

10:59 PM Changeset in webkit [187384] by timothy_horton@apple.com

1 edit
2 deletes in trunk/Source/WebCore

Remove a file that was supposed to be removed in r158096

platform/graphics/mac/WebTiledLayer.h: Removed.
platform/graphics/mac/WebTiledLayer.mm: Removed.

10:38 PM Changeset in webkit [187383] by rniwa@webkit.org

2 edits in trunk/Source/WebKit2

iOS 8 build fix attempt after r187215.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]): Deleted.

10:29 PM Changeset in webkit [187382] by jinwoo7.song@samsung.com

2 edits in trunk/Source/WebCore

[EFL] Build fix in ProtectionSpaceBase.cpp
https://bugs.webkit.org/show_bug.cgi?id=147289

Reviewed by Brent Fulgham.

Fix the build break for [-Werror=return-type] error.

platform/network/ProtectionSpaceBase.cpp:

(WebCore::ProtectionSpaceBase::isPasswordBased):

9:32 PM Changeset in webkit [187381] by Brent Fulgham

3 edits in trunk/LayoutTests

[Win] Test results gardening.

platform/win/TestExpectations:
platform/win/js/dom/global-constructors-attributes-expected.txt:

8:51 PM Changeset in webkit [187380] by mmaxfield@apple.com

14 edits
2 adds in trunk

text-overflow: ellipsis is broken by text-align: right and padding-left
https://bugs.webkit.org/show_bug.cgi?id=121902

Reviewed by Zalan Bujtas.

Source/WebCore:

Right offsets (which include padding) are not the same as widths (which don't).

Test: fast/inline/padding-ellipsis-right.html

rendering/RenderBlockLineLayout.cpp:

(WebCore::updateLogicalWidthForRightAlignedBlock):
(WebCore::RenderBlockFlow::checkLinesForTextOverflow):

LayoutTests:

Updating expected results.

fast/inline/padding-ellipsis-right-expected.html: Added.
fast/inline/padding-ellipsis-right.html: Added.
platform/mac/fast/css/text-overflow-ellipsis-text-align-center-expected.png:
platform/mac/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
platform/mac/fast/css/text-overflow-ellipsis-text-align-left-expected.png:
platform/mac/fast/css/text-overflow-ellipsis-text-align-left-expected.txt:
platform/mac/fast/css/text-overflow-ellipsis-text-align-right-expected.png:
platform/mac/fast/css/text-overflow-ellipsis-text-align-right-expected.txt:
platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png:
platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png:
platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png:
platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt:

8:41 PM Changeset in webkit [187379] by mitz@apple.com

2 edits in trunk/Source/WebCore

Tried to fix the iOS 9 build after r187375.

platform/network/mac/CookieJarMac.mm:

8:13 PM Changeset in webkit [187378] by hyungwook.lee@navercorp.com

2 edits in trunk/Tools

Unreviewed, updated my nick name in contributors.json

Scripts/webkitpy/common/config/contributors.json:

7:37 PM Changeset in webkit [187377] by commit-queue@webkit.org

10 edits
2 adds in trunk

[MSE] Incorrect sample timestamps when using "sequence" mode
https://bugs.webkit.org/show_bug.cgi?id=147252

Patch by Sajid Anwar <sajidanwar94@gmail.com> on 2015-07-24
Reviewed by Jer Noble.

Source/WebCore:

Test: media/media-source/media-source-sequence-timestamps.html

According to the specification, the "sequence" mode indicates that the samples in the buffer will use generated timestamps
instead of the presentation/decode timestamps already present in the sample. The current implementation always adds
the current timestamp offset to the samples' timestamps, as expected for "segments" mode.

Add a method to media samples to allow their presentation and decode timestamps to be set to specific values.

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Fix an algorithm condition to align with the specification, and

correctly set the presentation and decode timestamps of samples when in "sequence" mode.

platform/MediaSample.h:
platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::MediaSampleAVFObjC::setTimestamps): Add a new method to set the values of a sample's presentation and decode timestamps.

platform/mock/mediasource/MockBox.h:

(WebCore::MockBox::setTimestamps): Set m_presentationTimestamp and m_decodeTimestamp.

platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockMediaSample::offsetTimestampsBy): Pass to MockBox.

testing/Internals.cpp:

(WebCore::Internals::setShouldGenerateTimestamps): Expose the internal setShouldGenerateTimestamps method of SourceBuffer.

testing/Internals.h:
testing/Internals.idl:

LayoutTests:

media/media-source/media-source-sequence-timestamps-expected.txt: Added.
media/media-source/media-source-sequence-timestamps.html: Added.

6:08 PM Changeset in webkit [187376] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Don't create UIWebFormAccessory if we don't require accessory view.
https://bugs.webkit.org/show_bug.cgi?id=147283

Don't try to intialize _formAccessoryView if requiresAccessoryView returns false since we don't
need it yet.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2015-07-24
Reviewed by Dan Bernstein.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView inputAccessoryView]):

5:33 PM Changeset in webkit [187375] by andersca@apple.com

9 edits in trunk/Source

WKWebsiteDataStore remove methods don't properly delete cookies
https://bugs.webkit.org/show_bug.cgi?id=147282
rdar://problem/21948230

Reviewed by Sam Weinig.

Source/WebCore:

Rename deleteCookiesForHostname to deleteCookiesForHostnames and
make it take a vector of hostnames instead.

Also, fix the Mac implementation to not be O(n2) by putting all cookies
in a dictionary keyed on the domain.

Also make sure to call _saveStorage after deleting cookies.

Finally, get rid of deleteCookiesForHostname from CookieJarCFNet.cpp and
use the Mac implementation on iOS as well. Just stub out deleteCookiesForHostnames
on Windows since nobody is calling it.

platform/network/PlatformCookieJar.h:
platform/network/cf/CookieJarCFNet.cpp:

(WebCore::deleteCookiesForHostnames):
(WebCore::deleteCookiesForHostname): Deleted.

platform/network/mac/CookieJarMac.mm:

(WebCore::deleteCookiesForHostnames):
(WebCore::deleteAllCookiesModifiedSince):
(WebCore::deleteCookiesForHostname): Deleted.

platform/network/soup/CookieJarSoup.cpp:

(WebCore::deleteCookiesForHostnames):
(WebCore::deleteCookiesForHostname): Deleted.

platform/spi/cf/CFNetworkSPI.h:

Source/WebKit2:

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
Call deleteCookiesForHostnames instead of iterating over each hostname.

WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::deleteCookiesForHostname):
Call deleteCookiesForHostnames.

5:29 PM Changeset in webkit [187374] by bshafiei@apple.com

1 copy in tags/Safari-601.1.43

New tag.

5:29 PM Changeset in webkit [187373] by bshafiei@apple.com

1 copy in tags/Safari-600.8.6

New tag.

5:29 PM Changeset in webkit [187372] by bshafiei@apple.com

1 copy in tags/Safari-600.1.4.17.4

New tag.

4:26 PM Changeset in webkit [187371] by Chris Fleizach

18 edits
2 adds in trunk

AX: scrollable elements do not allow 3-finger swipe
https://bugs.webkit.org/show_bug.cgi?id=141893

Reviewed by Mario Sanchez Prada.

Source/WebCore:

To allow iOS Accessibility to perform by-page scrolling in overflow areas, we move
that scrolling code into AccessibilityObject and then iterate all the possible ScrollableAreas,
rather than just finding the parents that are ScrollViews.

Test: platform/ios-simulator/accessibility/scroll-in-overflow-div.html

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::scrollAreaAndAncestor):
(WebCore::AccessibilityObject::scrollPosition):
(WebCore::AccessibilityObject::scrollVisibleContentRect):
(WebCore::AccessibilityObject::scrollContentsSize):
(WebCore::AccessibilityObject::scrollByPage):

accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityScroll:]):
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
(-[WebAccessibilityObjectWrapper _accessibilityScrollPosition]):
(-[WebAccessibilityObjectWrapper _accessibilityScrollSize]):
(-[WebAccessibilityObjectWrapper _accessibilityScrollVisibleRect]):
(-[WebAccessibilityObjectWrapper accessibilityElementDidBecomeFocused]):

Tools:

Support global notification listeners for iOS code.
Fix an issue in DRT where the dictionary of data was not being passed back to the layout test for the notication callback.
Implement scrollUp/Down/Left/Right.

DumpRenderTree/AccessibilityController.h:
DumpRenderTree/AccessibilityUIElement.cpp:

(increaseTextSelectionCallback):
(scrollPageUpCallback):
(scrollPageDownCallback):
(scrollPageLeftCallback):
(scrollPageRightCallback):
(decreaseTextSelectionCallback):
(getElementTextLengthCallback):
(AccessibilityUIElement::getJSClass):

DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/ios/AccessibilityControllerIOS.mm:

(AccessibilityController::~AccessibilityController):
(AccessibilityController::elementAtPoint):
(AccessibilityController::addNotificationListener):
(AccessibilityController::platformResetToConsistentState):
(AccessibilityController::removeNotificationListener):

DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::subrole):
(AccessibilityUIElement::scrollPageUp):
(AccessibilityUIElement::scrollPageDown):
(AccessibilityUIElement::scrollPageLeft):
(AccessibilityUIElement::scrollPageRight):
(AccessibilityUIElement::roleDescription):

DumpRenderTree/mac/AccessibilityNotificationHandler.mm:

(-[AccessibilityNotificationHandler _notificationReceived:]):

WebKitTestRunner/InjectedBundle/AccessibilityController.h:
WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::linkedElement):
(WTR::AccessibilityUIElement::headerElementAtIndex):
(WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
(WTR::AccessibilityUIElement::scrollPageUp):
(WTR::AccessibilityUIElement::scrollPageDown):
(WTR::AccessibilityUIElement::scrollPageLeft):
(WTR::AccessibilityUIElement::scrollPageRight):

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:

(WTR::AccessibilityController::addNotificationListener):
(WTR::AccessibilityController::removeNotificationListener):

WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
(WTR::AccessibilityUIElement::scrollPageUp):
(WTR::AccessibilityUIElement::scrollPageDown):
(WTR::AccessibilityUIElement::scrollPageLeft):
(WTR::AccessibilityUIElement::scrollPageRight):
(WTR::AccessibilityUIElement::increaseTextSelection):

LayoutTests:

platform/ios-simulator/accessibility/scroll-in-overflow-div-expected.txt: Added.
platform/ios-simulator/accessibility/scroll-in-overflow-div.html: Added.

4:24 PM Changeset in webkit [187370] by Brent Fulgham

14 edits in trunk

Source/WebCore:
[Win] Connect UserScript and UserStyleSheet through WebView.
https://bugs.webkit.org/show_bug.cgi?id=147279
<rdar://problem/21990767>

Reviewed by Dean Jackson.

Tested by http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher.html as well
as many skipped tests.

DerivedSources.cpp: Conditionally compile JSSecurityPolicyViolationEvent.cpp if CSP_NEXT is enabled.
DerivedSources.make: Generate bindings for SecurityPolicyViolationEvent.idl.
WebCore.vcxproj/WebCore.vcxproj: Add missing files.
WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.

Source/WebKit/win:
[Win] Connect UserScript and UserStyleSheet through WebView.
https://bugs.webkit.org/show_bug.cgi?id=147279
<rdar://problem/21990767>

Reviewed by Dean Jackson.

Interfaces/IWebViewPrivate.idl: Add updated API for 'addUserScriptToGroup' and

'addUserStyleSheetToGroup'

WebView.cpp:

(WebView::addUserScriptToGroup): Add implementation.
(toStringVector): Added helper function.
(WebView::addUserStyleSheetToGroup): Add implementation.
(WebView::removeUserScriptFromGroup): Ditto.
(WebView::removeUserStyleSheetFromGroup): Ditto.
(WebView::removeUserScriptsFromGroup): Ditto.
(WebView::removeUserStyleSheetsFromGroup): Ditto.
(WebView::removeAllUserContentFromGroup): Ditto.

WebView.h:

Tools:
[Win] Activate CSP_NEXT and Connect UserScript and UserStyleSheet through WebView.
https://bugs.webkit.org/show_bug.cgi?id=147279
<rdar://problem/21990767>

Reviewed by Dean Jackson.

DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::addUserScript):
(TestRunner::addUserStyleSheet):
(TestRunner::setDeveloperExtrasEnabled):

4:12 PM Changeset in webkit [187369] by bshafiei@apple.com

5 edits
1 delete in branches/safari-600.8-branch

Merge patch for r187189. rdar://problem/21707927

4:05 PM Changeset in webkit [187368] by bshafiei@apple.com

5 edits
1 delete in branches/safari-600.1.4.17-branch

Merge patch for r187189. rdar://problem/21708281

3:43 PM Changeset in webkit [187367] by ap@apple.com

6 edits in trunk/Source/WebCore

[Cocoa] Clean up server trust handling in ResourceHandle.
https://bugs.webkit.org/show_bug.cgi?id=147277
rdar://problem/21394410

Reviewed by Brady Eidson.

platform/network/ProtectionSpaceBase.h: (WebCore::ProtectionSpaceBase::isPasswordBased):
platform/network/ProtectionSpaceBase.cpp: (WebCore::ProtectionSpaceBase::isPasswordBased):

Added. This is somewhat weak, as authentication schemes could change, but I couldn't find
any better way.

platform/network/ResourceHandle.h:
platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::tryHandlePasswordBasedAuthentication):

platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::tryHandlePasswordBasedAuthentication):
Factored out password handling, and made sure to not try that for server trust.

3:35 PM WhitespaceCollapsing edited by mmaxfield@apple.com

(diff)

3:32 PM WhitespaceCollapsing created by mmaxfield@apple.com

3:25 PM Changeset in webkit [187366] by Alan Bujtas

3 edits in trunk/Source/WebCore

[iOS]: Inline video controls are blurry on scaled-down pages on non-retina devices.
https://bugs.webkit.org/show_bug.cgi?id=147272
rdar://problem/21429111

Reviewed by Simon Fraser.

Blurry inline video controls are the result of transform scaling up the content when the page
is zoomed out (page scale > 1).
This patch addresses the blurriness by switching to css zoom when the content is being scaled up.
While transform scale is a paint time operation, css zoom triggers layout and the content is getting
painted on a non-scaled graphics context.

Modules/mediacontrols/mediaControlsiOS.css:

(audio::-webkit-media-controls-timeline-container):

Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.set pageScaleFactor):

3:15 PM Changeset in webkit [187365] by mmaxfield@apple.com

1 edit
1 add in trunk/Websites/webkit.org

Add image for a blog post

blog-files/el-capitan-system-font.png: Added.

3:01 PM Changeset in webkit [187364] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Networking process crash in NetworkConnectionToWebProcess::convertMainResourceLoadToDownload while attempting to download a blob
https://bugs.webkit.org/show_bug.cgi?id=147276
rdar://problem/21423353

Reviewed by Andreas Kling.

We currently don't support downloading blobs, so for now just bail if we encounter a null loader inside
convertMainResourceLoadToDownload (which happens when trying to download a blob URL).

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didCleanupResourceLoader):
Rewrite the assertion to be more clear - it's fine to do an extra hash lookup in debug builds.

(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):
Bail if loader is null.

2:45 PM Changeset in webkit [187363] by Yusuke Suzuki

7 edits
2 adds in trunk/Source/JavaScriptCore

Avoid 2 times name iteration in Object.assign
https://bugs.webkit.org/show_bug.cgi?id=147268

Reviewed by Geoffrey Garen.

Object.assign calls Object.getOwnPropertyNames & Object.getOwnPropertySymbols to collect all the names.
But exposing the private API that collects both at the same time makes the API efficient when the given Object has so many non-indexed properties.
Since Object.assign is so generic API (some form of utility API), the form of the given Object is not expected.
So the taken object may have so many non-indexed properties.

In this patch, we introduce ownEnumerablePropertyKeys private function.
It is minor changed version of [[OwnPropertyKeys]] in the ES6 spec;
It only includes enumerable properties.

By filtering out the non-enumerable properties in the exposed private function,
we avoid calling @objectGetOwnPropertyDescriptor for each property at the same time.

builtins/ObjectConstructor.js:

(assign):

runtime/CommonIdentifiers.h:
runtime/EnumerationMode.h:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

runtime/ObjectConstructor.cpp:

(JSC::ownEnumerablePropertyKeys):

runtime/ObjectConstructor.h:
tests/stress/object-assign-enumerable.js: Added.

(shouldBe):

tests/stress/object-assign-order.js: Added.

(shouldBe):

2:29 PM Changeset in webkit [187362] by ggaren@apple.com

2 edits in trunk/Source/bmalloc

vmmap crash at JavaScriptCore: 0x31cd12f6 (the JavaScript malloc zone enumerator)
https://bugs.webkit.org/show_bug.cgi?id=147274

Reviewed by Anders Carlsson.

It's not really clear why vmmap sometimes fails to read the target
process, but we can avoid a crash when it does. This is useful because
you'll still get all the non-bmalloc data out of the target process,
and bmalloc might not even be relevant to your investigation.

bmalloc/Zone.cpp:

(bmalloc::remoteRead): Check for failure.

2:08 PM Changeset in webkit [187361] by bshafiei@apple.com

9 edits in branches/safari-600.1.4.17-branch

Merged r187359. rdar://problem/21708243

2:03 PM Changeset in webkit [187360] by ggaren@apple.com

3 edits in trunk/Source/bmalloc

JavaScriptCore bmalloc should not register its malloc zone more than once
https://bugs.webkit.org/show_bug.cgi?id=147273

Reviewed by Andreas Kling.

This was a goof: The Zone constructor, by virtue of running automatically,
was registering a Zone inside the analysis process.

bmalloc/Zone.cpp:

(bmalloc::remoteRead): Clarify that the pointer is remote.

(bmalloc::enumerator):
(bmalloc::Zone::Zone):

bmalloc/Zone.h: Separate the normal constructor and the remote constructor.

The remote constructor skips zone registration since its goal is not
to register a zone in the current process or do any allocation but rather
to mirror the bytes of the zone from the target process.

1:41 PM Changeset in webkit [187359] by andersca@apple.com

9 edits in branches/safari-600.8-branch

Fix fallout from merging changes for
<rdar://problem/21707887> CSP doesn't prevent image loading of <object> when page contains <video controls> and ENABLE(MEDIA_CONTROLS_SCRIPT) is enabled

Reviewed by Alexey Proskuryakov.

Source/WebCore:
Tweaked http/tests/security/isolatedWorld/image-load-should-not-bypass-main-world-csp.html so that
it will test allowing evals in non-main worlds.

bindings/js/ScriptController.cpp:

(WebCore::ScriptController::initScript):
Due to ContentSecurityPolicy::allowEval being modified on ToT, we'd always end up passing true for
the overrideContentSecurityPolicy parameter (since the ContentSecurityPolicy::SuppressReport parameter
was incorrectly treated as a boolean).
Fix this by merging part of the fix for bug 141316.

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::defaultCachedResourceOptions):
The correct ContentSecurityPolicyImposition should be DoPolicyCheck. This was the case on ToT but for
some reason it was changed to SkipPolicyCheck when the patch was merged.

page/DOMSecurityPolicy.cpp:

(WebCore::DOMSecurityPolicy::allowsEval):
Pass false for overrideContentSecurityPolicy.

LayoutTests:

http/tests/security/contentSecurityPolicy/resources/track.vtt:

Replace this with a track.vtt from ToT which is actually a valid .vtt file that will parse properly.

http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-object.html:

Tweak this test so it will work on the branch - setting object.data in order to force an object's URL to be loaded
when it's already got a renderer only works on ToT, so do it before appending the object element.

http/tests/security/isolatedWorld/image-load-should-not-bypass-main-world-csp-expected.txt:

Copy the test result from ToT and get rid of the merge conflict.

http/tests/security/isolatedWorld/image-load-should-not-bypass-main-world-csp.html:

Copy the test from ToT which also gives us a test for allowing eval in non-main script worlds.

1:31 PM Changeset in webkit [187358] by ap@apple.com

2 edits in trunk/Source/WebCore

Remove WEBCORE_EXPORT from Page::allowsMediaDocumentInlinePlayback()
https://bugs.webkit.org/show_bug.cgi?id=147260

Reviewed by Daniel Bates.

page/Page.h:

(WebCore::Page::allowsMediaDocumentInlinePlayback):

1:22 PM Changeset in webkit [187357] by basile_clement@apple.com

4 edits in trunk/Tools

Call fixChangeLogPatch when generating patches from webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=147248

Reviewed by Geoffrey Garen.

When two consecutive patches are from the same author, diff tools
create wrong-looking diffs for ChangeLog files where the apparent added
author is actually the previous patch's author line, making it awkward
to read - and things only get worse when committing a patch and a
followup fix for the same bug shortly after.

We have a perl function in VCSUtils.pm, fixChangeLogPatch, to corrects
this, which we use in perl scripts (svn-create-patch et al). But it is
not used by webkit-patch, which is a python script, and thus creates
"bad" diffs.

In the long term, we should probably port fixChangeLogPatch to python -
but in the short term, let's make webkit-patch call perl to run
fixChangeLogPatch. We are already making various external calls there
anyway.

Scripts/webkitpy/common/checkout/scm/git.py:

(Git.create_patch):

Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.fix_changelog_patch):

Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.create_patch):

12:48 PM Changeset in webkit [187356] by Yusuke Suzuki

13 edits in trunk/Source

Remove runtime flags for symbols
https://bugs.webkit.org/show_bug.cgi?id=147246

Reviewed by Alex Christensen.

Source/JavaScriptCore:

runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::finishCreation):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init): Deleted.

runtime/JSGlobalObject.h:
runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::finishCreation):

runtime/RuntimeFlags.h:

Source/WebKit/mac:

WebView/WebPreferencesPrivate.h:

Source/WebKit/win:

Interfaces/IWebPreferencesPrivate.idl:

Source/WebKit2:

UIProcess/API/C/WKPreferencesRefPrivate.h:
UIProcess/API/Cocoa/WKPreferencesPrivate.h:

12:31 PM Changeset in webkit [187355] by Yusuke Suzuki

26 edits
3 adds in trunk

Object.getOwnPropertySymbols on large list takes very long
https://bugs.webkit.org/show_bug.cgi?id=146137

Reviewed by Mark Lam.

Source/JavaScriptCore:

Before this patch, Object.getOwnPropertySymbols collects all the names including strings.
And after it's done, filter the names to only retrieve the symbols.
But it's so time consuming if the given object is a large non-holed array since it has
many indexed properties and all the indexes have to be converted to uniqued_strings and
added to the collection of property names (though they may not be of the requested type
and will be filtered out later)

This patch introduces PropertyNameMode.
We leverage this mode in 2 places.

PropertyNameArray side

It is set in PropertyNameArray and it filters the incoming added identifiers based on the mode.
It ensures that PropertyNameArray doesn't become so large in the pathological case.
And it ensures that non-expected typed keys by the filter (Symbols or Strings) are never added
to the property name array collections.
However it does not solve the whole problem because the huge array still incurs the many
"indexed property to uniqued string" conversion and the large iteration before adding the keys
to the property name array.

getOwnPropertyNames side

So we can use the PropertyNameMode in the caller side (getOwnPropertyNames) as a hint.
When the large iteration may occur, the caller side can use the PropertyNameMode as a hint to
avoid the iteration.
But we cannot exclusively rely on these caller side checks because it would require that we
exhaustively add the checks to all custom implementations of getOwnPropertyNames as well.
This process requires manual inspection of many pieces of code, and is error prone. Instead,
we only apply the caller side check in a few strategic places where it is known to yield
performance benefits; and we rely on the filter in PropertyNameArray::add() to reject the wrong
types of properties for all other calls to PropertyNameArray::add().

In this patch, there's a concept in use that is not clear just from reading the code, and hence
should be documented here. When selecting the PropertyNameMode for the PropertyNameArray to be
instantiated, we apply the following logic:

Only JavaScriptCore code is aware of ES6 Symbols.

We can assume that pre-existing external code that interfaces JSC are only looking for string named properties. This includes:

WebCore bindings
Serializer bindings
NPAPI bindings
Objective C bindings

In JSC, code that compute object storage space needs to iterate both Symbol and String named properties. Hence, use PropertyNameMode::Both.
In JSC, ES6 APIs that work with Symbols should use PropertyNameMode::Symbols.
In JSC, ES6 APIs that work with String named properties should use PropertyNameMode::Strings.

API/JSObjectRef.cpp:

(JSObjectCopyPropertyNames):

bindings/ScriptValue.cpp:

(Deprecated::jsToInspectorValue):

bytecode/ObjectAllocationProfile.h:

(JSC::ObjectAllocationProfile::possibleDefaultPropertyCount):

runtime/EnumerationMode.h:

(JSC::EnumerationMode::EnumerationMode):
(JSC::EnumerationMode::includeSymbolProperties): Deleted.

runtime/GenericArgumentsInlines.h:

(JSC::GenericArguments<Type>::getOwnPropertyNames):

runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertyNames):

runtime/JSLexicalEnvironment.cpp:

(JSC::JSLexicalEnvironment::getOwnNonIndexPropertyNames):

runtime/JSONObject.cpp:

(JSC::Stringifier::Stringifier):
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):

runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertyNames):

runtime/JSPropertyNameEnumerator.cpp:

(JSC::JSPropertyNameEnumerator::create):

runtime/JSPropertyNameEnumerator.h:

(JSC::propertyNameEnumerator):

runtime/JSSymbolTableObject.cpp:

(JSC::JSSymbolTableObject::getOwnNonIndexPropertyNames):

runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorGetOwnPropertySymbols):
(JSC::objectConstructorKeys):
(JSC::defineProperties):
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):

runtime/PropertyNameArray.h:

(JSC::PropertyNameArray::PropertyNameArray):
(JSC::PropertyNameArray::mode):
(JSC::PropertyNameArray::addKnownUnique):
(JSC::PropertyNameArray::add):
(JSC::PropertyNameArray::isUidMatchedToTypeMode):
(JSC::PropertyNameArray::includeSymbolProperties):
(JSC::PropertyNameArray::includeStringProperties):

runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertyNames):

runtime/Structure.cpp:

(JSC::Structure::getPropertyNamesFromStructure):

Source/WebCore:

bindings/js/Dictionary.cpp:

(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):

bridge/NP_jsobject.cpp:

(_NPN_Enumerate):

Source/WebKit/mac:

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::enumerate):

Source/WebKit2:

WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::enumerate):

LayoutTests:

js/regress/object-get-own-property-symbols-on-large-array-expected.txt: Added.
js/regress/object-get-own-property-symbols-on-large-array.html: Added.
js/regress/script-tests/object-get-own-property-symbols-on-large-array.js: Added.

(trial):

11:56 AM Changeset in webkit [187354] by basile_clement@apple.com

6 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Repatching tail calls as jump should depend on the opcode, not the JS CallLinkInfo
https://bugs.webkit.org/show_bug.cgi?id=147243

Reviewed by Michael Saboff.

When linking, we are currently looking at data from the JS CallLinkInfo
to determine if we have a call or jump opcode. However, even with a
tail call, the slow path uses a call opcode for simplicity.

This adds the information that we are performing a tail call into the
CodeLocationNearCall class, which allows us to link as jump or call
based on the actual opcode.

This is a conceptual error that couldn't be found on X86 architecture
since the patching of jump and calls is identical there.

assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::repatchNearCall):

assembler/CodeLocation.h:

(JSC::CodeLocationNearCall::CodeLocationNearCall):
(JSC::CodeLocationNearCall::isTail):
(JSC::CodeLocationCommon::nearCallAtOffset):

assembler/LinkBuffer.h:

(JSC::LinkBuffer::locationOfNearCall):

assembler/RepatchBuffer.h:

(JSC::RepatchBuffer::relink):

jit/Repatch.cpp:

(JSC::linkSlowFor):
(JSC::linkFor):
(JSC::revertCall):
(JSC::linkPolymorphicCall):

11:51 AM Changeset in webkit [187353] by ddkilzer@apple.com

4 edits in trunk/Source/WebCore

REGRESSION (r187149): Build fails when CSS_SELECTORS_LEVEL4 is disabled

This is a follow-up fix to:

[CSS Selectors Level 4] Add #ifdefs to the new '>>' descendant combinator
<https://bugs.webkit.org/show_bug.cgi?id=147184>

css/CSSParserValues.cpp:

(WebCore::CSSParserSelector::appendTagHistory):

css/CSSParserValues.h:
css/CSSSelector.h:
Change ENABLE_CSS_SELECTORS_LEVEL4 to ENABLE(CSS_SELECTORS_LEVEL4).

11:48 AM Changeset in webkit [187352] by Devin Rousso

3 edits
2 adds in trunk

Web Inspector: Editing non-inspector-stylesheet rule selectors fails after the first change
https://bugs.webkit.org/show_bug.cgi?id=147229

Reviewed by Timothy Hatcher.

Source/WebCore:

Test: inspector/css/modify-rule-selector.html

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::setRuleSelector):
Now checks to see if the stylesheet is not mutated before making the change to the
rule's selector, and if so mark it as not mutated to allow future edits.

LayoutTests:

inspector/css/modify-rule-selector-expected.txt: Added.
inspector/css/modify-rule-selector.html: Added.

11:40 AM Changeset in webkit [187351] by saambarati1@gmail.com

15 edits
1 add in trunk

[ES6] Add support for default parameters
https://bugs.webkit.org/show_bug.cgi?id=38409

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This patch implements ES6 default parameters according to the ES6
specification. This patch builds off the components introduced with
"let" scoping and parsing function parameters in the same parser
arena as the function itself. "let" scoping allows functions with default
parameter values to place their parameters under the TDZ. Parsing function
parameters in the same parser arena allows the FunctionParameters AST node
refer to ExpressionNodes.

The most subtle part of this patch is how we allocate lexical environments
when functions have default parameter values. If a function has default
parameter values then there must be a separate lexical environment for
its parameters. Then, the function's "var" lexical environment must have
the parameter lexical environment as its parent. The BytecodeGenerator
takes great care to not allocate the "var" lexical environment before its
really needed.

The "arguments" object for a function with default parameters will never be
a mapped arugments object. It will always be a cloned arugments object.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::~BytecodeGenerator):
(JSC::BytecodeGenerator::initializeDefaultParameterValuesAndSetupFunctionScopeStack):
(JSC::BytecodeGenerator::initializeNextParameter):
(JSC::BytecodeGenerator::initializeVarLexicalEnvironment):
(JSC::BytecodeGenerator::visibleNameForParameter):
(JSC::BytecodeGenerator::emitLoadGlobalObject):
(JSC::BytecodeGenerator::pushLexicalScopeInternal):
(JSC::BytecodeGenerator::pushLexicalScope):
(JSC::BytecodeGenerator::popLexicalScope):

bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::lastOpcodeID):

bytecompiler/NodesCodegen.cpp:

(JSC::FunctionNode::emitBytecode):

jit/JITOperations.cpp:
parser/ASTBuilder.h:

(JSC::ASTBuilder::createElementList):
(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::appendParameter):
(JSC::ASTBuilder::createClause):
(JSC::ASTBuilder::createClauseList):

parser/Nodes.h:

(JSC::FunctionParameters::size):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::hasDefaultParameterValues):
(JSC::FunctionParameters::append):

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseVariableDeclarationList):
(JSC::Parser<LexerType>::createBindingPattern):
(JSC::Parser<LexerType>::tryParseDestructuringPatternExpression):
(JSC::Parser<LexerType>::parseDestructuringPattern):
(JSC::Parser<LexerType>::parseFormalParameters):
(JSC::Parser<LexerType>::parseFunctionParameters):

parser/Parser.h:

(JSC::Scope::declareParameter):

parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createElementList):
(JSC::SyntaxChecker::createFormalParameterList):
(JSC::SyntaxChecker::appendParameter):
(JSC::SyntaxChecker::createClause):
(JSC::SyntaxChecker::createClauseList):

tests/stress/es6-default-parameters.js: Added.

(assert):
(shouldThrow):
(shouldThrowSyntaxError):
(shouldThrowTDZ):
(basic):
(basicFunctionCaptureInDefault.basicFunctionCaptureInDefault.basicCaptured):
(basicCaptured.basicCaptured.tricky):
(strict):
(playground):
(scoping):
(augmentsArguments1):
(augmentsArguments2):
(augmentsArguments3):
(augmentsArguments4):
(augmentsArguments5):

LayoutTests:

js/destructuring-assignment-default-values-expected.txt:
js/parser-syntax-check-expected.txt:
js/script-tests/destructuring-assignment-default-values.js:

(shouldThrow): Deleted.

js/script-tests/parser-syntax-check.js:

11:39 AM Changeset in webkit [187350] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Add custom parameter lists for new DOM append/prepend/before/after/replaceWith methods
https://bugs.webkit.org/show_bug.cgi?id=147257

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-24
Reviewed by Timothy Hatcher.

UserInterface/Models/NativeFunctionParameters.js:

11:36 AM Changeset in webkit [187349] by calvaris@igalia.com

3 edits in trunk/Source/JavaScriptCore

Remove JS Promise constructor unused piece of code
https://bugs.webkit.org/show_bug.cgi?id=147262

Reviewed by Geoffrey Garen.

runtime/JSPromiseConstructor.cpp:

(JSC::constructPromise): Deleted.

runtime/JSPromiseConstructor.h: Removed JSC::constructPromise.

11:32 AM Changeset in webkit [187348] by mark.lam@apple.com

3 edits in trunk/Source/JavaScriptCore

Add WASM files to vcxproj files.
https://bugs.webkit.org/show_bug.cgi?id=147264

Reviewed by Geoffrey Garen.

This is a follow up to http://trac.webkit.org/changeset/187254 where WASM files
were introduced but were not able to be added to the vcxproj files yet.

JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:

11:23 AM Changeset in webkit [187347] by fpizlo@apple.com

2 edits
1 add in trunk/Source/JavaScriptCore

DFG::safeToExecute() is wrong for MultiGetByOffset, doesn't consider the structures of the prototypes that get loaded from
https://bugs.webkit.org/show_bug.cgi?id=147250

Reviewed by Geoffrey Garen.

This fixes a nasty - but currently benign - bug in DFG::safeToExecute(). That function
will tell you if hoisting a node to some point is safe in the sense that the node will
not crash the VM if it executes at that point. A node may be unsafe to execute if we
cannot prove that at that point, the memory it is loading is not garbage. This is a
necessarily loose notion - for example it's OK to hoist a load if we haven't proved
that the load makes semantic sense at that point, since anyway the place where the node
did get used will still be guarded by any such semantic checks. But because we may also
hoist uses of the load, we need to make sure that it doesn't produce a garbage value.
Also, we need to ensure that the load won't trap. Hence safeToExecute() returns true
anytime we can be sure that a node will not produce a garbage result (i.e. a malformed
JSValue or object pointer) and will not trap when executed at the point in question.

The bug is that this verification isn't performed for the loads from prototypes inside
MultiGetByOffset. DFG::ByteCodeParser will guard MultiGetByOffset with CheckStructure's
on the prototypes. So, hypothetically, you might end up hoisting a MultiGetByOffset
above those structure checks, which would mean that we might load a value from a memory
location without knowing that the location is valid. It might then return the value
loaded.

This never happens in practice. Those structure checks are more hoistable that the
MultiGetByOffset, since they read a strict subset of the MultiGetByOffset's abstract
heap reads. Also, we hoist in program order. So, those CheckStructure's will always be
hoisted before the MultiGetByOffset gets hoisted.

But we should fix this anyway. DFG::safeToExecute() has a clear definition of what a
"true" return means for IR transformations, and it fails in satisfying that definition
for MultiGetByOffset.

There are various approaches we can use for making this safe. I considered two:

1) Have MultiGetByOffset refer to the prototypes it is loading from in IR, so that we

can check if it's safe to load from them.

2) Turn off MultiGetByOffset hoisting when it will emit loads from prototypes, and the

prototype structure isn't being watched.

I ended up using (2), because it will be the most natural solution once I finish
https://bugs.webkit.org/show_bug.cgi?id=146929. Already now, it's somewhat more natural
than (1) since that requires more extensive IR changes. Also, (2) will give us what we
want in *most* cases: we will usually watch the prototype structure, and we will
usually constant-fold loads from prototypes. Both of these usually-true things would
have to become false for MultiGetByOffset hoisting to be disabled by this change.

This change also adds my attempt at a test, though it's not really a test of this bug.
This bug is currently benign. But, the test does at least trigger the logic to run,
which is better than nothing.

dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

tests/stress/multi-get-by-offset-hoist-around-structure-check.js: Added.

(foo):

10:59 AM Changeset in webkit [187346] by Lucas Forschler

6 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187149. rdar://problem/21935769

10:51 AM Changeset in webkit [187345] by Simon Fraser

2 edits in trunk/Source/WebKit2

Recode.net gets into a continual resize loop in split fullscreen
https://bugs.webkit.org/show_bug.cgi?id=147266
rdar://problem/21409047

Reviewed by Tim Horton.

In split fullscreen, we use fixed layout and scale to shrink pages down to
fit a given width. This is re-evaluated every time the document width changes.
However some pages, like recode.net, end up continually resizing because
when laid out unconstrained they use a narrower width than when laid out with
a fixed layout size. In fixed layout, they actually use more width than the fixed
layout size.

Detect and break this cycle by just not re-scaling when we've done one fixed layout,
and the document is now taking more width than the fixed layout width.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded):

9:07 AM Changeset in webkit [187344] by commit-queue@webkit.org

7 edits in trunk

CSS "content" property is missing in getComputedStyles
https://bugs.webkit.org/show_bug.cgi?id=147255

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-24
Reviewed by Simon Fraser.

Source/WebCore:

css/CSSComputedStyleDeclaration.cpp:

LayoutTests:

fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/css/getComputedStyle/resources/property-names.js:
svg/css/getComputedStyle-basic-expected.txt:

7:49 AM Changeset in webkit [187343] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[EFL] many fast tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=145835

Unreviewed gardening. These tests aren't flakey now, let's unskip them.

platform/efl/TestExpectations:

7:17 AM Changeset in webkit [187342] by Csaba Osztrogonác

9 edits
7 adds in trunk/LayoutTests

[EFL] Multi-column tests have been failed since r167808
https://bugs.webkit.org/show_bug.cgi?id=141496

Unreviewed gardening, updated expected results.

platform/efl/TestExpectations:
platform/efl/fast/multicol/client-rects-expected.png:
platform/efl/fast/multicol/client-rects-expected.txt:
platform/efl/fast/multicol/client-rects-spanners-complex-expected.png: Added.
platform/efl/fast/multicol/client-rects-spanners-complex-expected.txt:
platform/efl/fast/multicol/client-rects-spanners-expected.png: Added.
platform/efl/fast/multicol/client-rects-spanners-expected.txt:
platform/efl/fast/multicol/layers-split-across-columns-expected.png:
platform/efl/fast/multicol/layers-split-across-columns-expected.txt:
platform/efl/fast/multicol/newmulticol/client-rects-expected.png: Added.
platform/efl/fast/multicol/newmulticol/client-rects-expected.txt:
platform/efl/fast/multicol/pagination/LeftToRight-tb-hittest-expected.png: Added.
platform/efl/fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt: Added.
platform/efl/fast/multicol/pagination/RightToLeft-rl-hittest-expected.png: Added.
platform/efl/fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt: Added.

7:06 AM Changeset in webkit [187341] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening, unskip now passing tests.

platform/efl/TestExpectations:

5:59 AM Changeset in webkit [187340] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening. Updated since MEDIA_STREAM is enabled.

platform/efl/js/dom/constructor-length-expected.txt:

5:51 AM Changeset in webkit [187339] by Csaba Osztrogonác

2 edits in trunk/Source/WTF

Remove the unused GCC workaround - std::is_trivially_destructible
https://bugs.webkit.org/show_bug.cgi?id=147226

Reviewed by Darin Adler.

wtf/StdLibExtras.h:

5:06 AM Changeset in webkit [187338] by Carlos Garcia Campos

17 edits
5 adds in trunk/Source

[GStreamer] Crashes during plugin installation
https://bugs.webkit.org/show_bug.cgi?id=144099

Reviewed by Philippe Normand.

Source/WebCore:

Add new methods to MediaPlayerClient and ChromeClient to request
the API layer to start the installer when there are missing media
plugins.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::requestInstallMissingPlugins): Pass
the request to the ChromeClient.

html/HTMLMediaElement.h:
page/ChromeClient.h:
platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::requestInstallMissingPlugins):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Invalidate any pending request to install missing media plugins.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): In case of
missing plugins message, start a request to install them if
supported by GST.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(WebCore::MediaPlayerRequestInstallMissingPluginsCallback::create):
(WebCore::MediaPlayerRequestInstallMissingPluginsCallback::MediaPlayerRequestInstallMissingPluginsCallback):
(WebCore::MediaPlayerRequestInstallMissingPluginsCallback::invalidate):
(WebCore::MediaPlayerRequestInstallMissingPluginsCallback::complete):

Source/WebKit2:

Move the missing plugins installation to the UI process, ensuring
there's a single installer running and cancelling the request when
the page is closed or the media player is deleted.

PlatformEfl.cmake: Add new files to compilation.
PlatformGTK.cmake: Ditto.
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in: Add

RequestInstallMissingMediaPlugins message.

UIProcess/gstreamer/WebPageProxyGStreamer.cpp: Added.

(WebKit::WebPageProxy::requestInstallMissingMediaPlugins): Call
gst_install_plugins_async() and send
DidEndRequestInstallMissingMediaPlugins message back to the web
process when done.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::requestInstallMissingMediaPlugins): Call
WebPage::requestInstallMissingMediaPlugins().

WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close): Invalidate the install missing plugins
request callback.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in: Add

DidEndRequestInstallMissingMediaPlugins message.

WebProcess/WebPage/gstreamer/WebPageGStreamer.cpp: Added.

(WebKit::WebPage::requestInstallMissingMediaPlugins): Send
RequestInstallMissingMediaPlugins to the UI process or complete
the request early if there's already a request in progress.
(WebKit::WebPage::didEndRequestInstallMissingMediaPlugins):
Complete the request.

4:58 AM Changeset in webkit [187337] by Carlos Garcia Campos

3 edits in trunk/Source/WebKit2

Unreviewed. Fix the build with MEDIA_STREAM disabled after r187282.

RealtimeMediaSource is only defined when MEDIA_STREAM is enabled.

UIProcess/UserMediaPermissionRequestProxy.cpp:
UIProcess/UserMediaPermissionRequestProxy.h:

4:27 AM Changeset in webkit [187336] by Carlos Garcia Campos

3 edits in trunk/Source/WebKit2

REGRESSION(r187100): [GTK] ASSERTION FAILED: Attempt to access post layout data before receiving it when typing backspace
https://bugs.webkit.org/show_bug.cgi?id=147196

Reviewed by Žan Doberšek.

Do not try to use the PostLayoutData from EditorState when
isMissingPostLayoutData is true. That happens when there's a
layout pending, and EditorStateChanged is sent again after that
layout with the post layout data. So we can just return early and
wait until the second message.