Context Navigation

WebContent process main thread should have fixed priority on iOS 9.
Priority decay regresses PLT and fixing the main thread's priority
gives up a ~3% progression on warm PLT (tested on iPhone 5s).

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

9:52 PM Changeset in webkit [187411] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Add missing builtin files to the JavaScriptCore Xcode project
https://bugs.webkit.org/show_bug.cgi?id=147312

Patch by Sam Weinig <sam@webkit.org> on 2015-07-26
Reviewed by Darin Adler.

JavaScriptCore.xcodeproj/project.pbxproj:

Add missing files.

2:17 PM Changeset in webkit [187410] by Yusuke Suzuki

2 edits
1 add in trunk/Source/JavaScriptCore

[ES6] Implement Reflect.isExtensible
https://bugs.webkit.org/show_bug.cgi?id=147308

Reviewed by Sam Weinig.

This patch implements Reflect.isExtensible.
It is similar to Object.isExtensible.
The difference is that it raises an error if the first argument is not an object.

runtime/ReflectObject.cpp:

(JSC::reflectObjectIsExtensible):

tests/stress/reflect-is-extensible.js: Added.

(shouldBe):
(shouldThrow):

2:10 PM Changeset in webkit [187409] by Yusuke Suzuki

2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix the debug build due to touching the non-declared variable in ASSERT
https://bugs.webkit.org/show_bug.cgi?id=147307

runtime/ObjectConstructor.cpp:

(JSC::ownPropertyKeys):

2:02 PM Changeset in webkit [187408] by Yusuke Suzuki

4 edits
1 add in trunk/Source/JavaScriptCore

[ES6] Implement Reflect.ownKeys
https://bugs.webkit.org/show_bug.cgi?id=147307

Reviewed by Sam Weinig.

This patch implements Reflect.ownKeys.
In this patch, we refactor the existing code to list up own keys in the object.
Such code is used by Object.getOwnPropertyNames, Object.getOwnPropertyKeys, Object.keys and @ownEnumerableKeys.
We factor out the listing up own keys as ownPropertyKeys function and also use it in Reflect.ownKeys.

runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorGetOwnPropertySymbols):
(JSC::objectConstructorKeys):
(JSC::ownEnumerablePropertyKeys):
(JSC::ownPropertyKeys):

runtime/ObjectConstructor.h:
runtime/ReflectObject.cpp:

(JSC::reflectObjectOwnKeys):

tests/stress/reflect-own-keys.js: Added.

(shouldBe):
(shouldThrow):
(shouldBeArray):

1:52 PM Changeset in webkit [187407] by Yusuke Suzuki

4 edits
1 add in trunk/Source/JavaScriptCore

[ES6] Implement Reflect.apply
https://bugs.webkit.org/show_bug.cgi?id=147306

Reviewed by Sam Weinig.

Implement Reflect.apply.
The large part of this can be implemented by the @apply builtin annotation.
The only thing which is different from the Funciton.prototype.apply is the third parameter,
"argumentsList" is needed to be an object.

builtins/ReflectObject.js:

(apply):
(deleteProperty):

runtime/ReflectObject.cpp:
tests/stress/reflect-apply.js: Added.

(shouldBe):
(shouldThrow):
(get shouldThrow):
(.get shouldThrow):
(get var.array.get length):
(get var.array.get 0):
(.get var):

tests/stress/reflect-delete-property.js:

12:14 PM Changeset in webkit [187406] by mitz@apple.com

3 edits in trunk/Source/WebKit2

Suppressed an Xcode 7 warning about including a nib in an iOS build product.

Configurations/BaseLegacyProcess.xcconfig: Exclude xib files on iOS.
Configurations/BaseXPCService.xcconfig: Ditto.

Jul 25, 2015:

11:30 PM Changeset in webkit [187405] by Nikita Vasilyev

4 edits in trunk/Source/WebInspectorUI

Web Inspector: Start using Node.prototype.remove
https://bugs.webkit.org/show_bug.cgi?id=147304

Reviewed by Timothy Hatcher.

UserInterface/Base/Main.js:

(WebInspector.elementDragStart):
(WebInspector.elementDragEnd):
(WebInspector.revertDomChanges):

UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype._updateSearchHighlight.updateEntryHide):
(WebInspector.DOMTreeElement.prototype._updateSearchHighlight):
(WebInspector.DOMTreeElement.prototype.remove.removeNodeCallback):
(WebInspector.DOMTreeElement.prototype.remove):

UserInterface/Views/Resizer.js:

(WebInspector.Resizer.prototype._resizerMouseDown):
(WebInspector.Resizer.prototype._resizerMouseUp):
(WebInspector.Resizer):

11:23 PM Changeset in webkit [187404] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix color declaration for not-executed comments
https://bugs.webkit.org/show_bug.cgi?id=147305

Reviewed by Timothy Hatcher.

UserInterface/Views/SyntaxHighlightingDefaultTheme.css:

(.cm-s-default .basic-block-has-not-executed.cm-comment):
This was an RGB color mispelled as HSL. Replace "hsl" with "rgb"
and convert it to HSL.

11:19 PM Changeset in webkit [187403] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Start using Node.prototype.replaceWith
https://bugs.webkit.org/show_bug.cgi?id=147303

Reviewed by Timothy Hatcher.

UserInterface/Views/Popover.js:

(WebInspector.Popover.prototype._update):

10:46 PM Changeset in webkit [187402] by Nikita Vasilyev

21 edits in trunk/Source/WebInspectorUI

Web Inspector: Start using Node.prototype.append
https://bugs.webkit.org/show_bug.cgi?id=147301

Convert all instances of element.appendChild(document.createTextNode(aString))
to element.append(aString).

Reviewed by Timothy Hatcher.

UserInterface/Base/DOMUtilities.js:
UserInterface/Base/Main.js:

(WebInspector.linkifyLocation):
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):

UserInterface/Models/Breakpoint.js:

(WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement):

UserInterface/Views/BoxModelDetailsSectionRow.js:

(WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics):

UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection.prototype.refresh):

UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel):

UserInterface/Views/ChartDetailsSectionRow.js:

(WebInspector.ChartDetailsSectionRow.prototype._createLegendItem):

UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments):
(WebInspector.ConsoleMessageView.prototype._appendFormattedArguments):

UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility.accessibilityPropertiesCallback):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility):

UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype._insertInLastAttributePosition):
(WebInspector.DOMTreeElement.prototype._buildAttributeDOM):
(WebInspector.DOMTreeElement.prototype._buildTagDOM):
(WebInspector.DOMTreeElement.prototype._nodeTitleInfo):
defaultElement variable is unused, remove it.

UserInterface/Views/DataGrid.js:

(WebInspector.DataGridNode.prototype.createCell.get if):
(WebInspector.DataGridNode.prototype.createCell):

UserInterface/Views/DebuggerDashboardView.js:

(WebInspector.DebuggerDashboardView.prototype._rebuildLocation):

UserInterface/Views/EventListenerSectionGroup.js:

(WebInspector.EventListenerSectionGroup.prototype._functionTextOrLink):
(WebInspector.EventListenerSectionGroup):

UserInterface/Views/FormattedValue.js:

(WebInspector.FormattedValue.createLinkifiedElementString):
(WebInspector.FormattedValue.createElementForNodePreview):

UserInterface/Views/ObjectPreviewView.js:

(WebInspector.ObjectPreviewView.prototype._appendEntryPreviews):
(WebInspector.ObjectPreviewView.prototype._appendPropertyPreviews):

UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestDataSection):
(WebInspector.ResourceDetailsSidebarPanel):

UserInterface/Views/RulesStyleDetailsPanel.js:

(WebInspector.RulesStyleDetailsPanel.prototype.refresh.addNewRuleButton):
(WebInspector.RulesStyleDetailsPanel.prototype.refresh.insertMediaOrInheritanceLabel):

UserInterface/Views/SearchResultTreeElement.js:

(WebInspector.SearchResultTreeElement.truncateAndHighlightTitle):

UserInterface/Views/SyntaxHighlightingSupport.js:

(.appendText):
(WebInspector.syntaxHighlightStringAsDocumentFragment):

UserInterface/Views/TimelineDataGridNode.js:

(WebInspector.TimelineDataGridNode.prototype.createCellContent):

10:12 PM Changeset in webkit [187401] by Yusuke Suzuki

8 edits
4 adds in trunk/Source/JavaScriptCore

[ES6] Add Reflect namespace and add Reflect.deleteProperty
https://bugs.webkit.org/show_bug.cgi?id=147287

Reviewed by Sam Weinig.

This patch just creates the namespace for ES6 Reflect APIs.
And add template files to implement the actual code.

Not to keep the JS generated properties C array empty,
we added one small method, Reflect.deleteProperty in this patch.

CMakeLists.txt:
DerivedSources.make:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
builtins/ReflectObject.js: Added.

(deleteProperty):

runtime/CommonIdentifiers.h:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

runtime/ReflectObject.cpp: Added.

(JSC::ReflectObject::ReflectObject):
(JSC::ReflectObject::finishCreation):
(JSC::ReflectObject::getOwnPropertySlot):

runtime/ReflectObject.h: Added.

(JSC::ReflectObject::create):
(JSC::ReflectObject::createStructure):

tests/stress/reflect-delete-property.js: Added.

(shouldBe):
(shouldThrow):

7:53 PM Changeset in webkit [187400] by ap@apple.com

2 edits in branches/safari-601.1-branch/LayoutTests

Updating an expectation to actually work (it's a reftest, so it needs ImageOnlyFailure).

platform/mac/TestExpectations:

7:28 PM Changeset in webkit [187399] by ap@apple.com

2 edits in trunk/LayoutTests

REGRESSION (r186569): media/restore-from-page-cache.html is very flaky
https://bugs.webkit.org/show_bug.cgi?id=147254

platform/mac/TestExpectations: Updated the expectations, because the problem is

not limited to Debug Mavericks.

7:13 PM Changeset in webkit [187398] by ap@apple.com

2 edits in trunk/Source/WebCore

Remove an never failing check for client() in ResourceHandle::canAuthenticateAgainstProtectionSpace.

Requested by Brady Eidson in bug 147277.

platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace):

7:09 PM Changeset in webkit [187397] by ap@apple.com

15 edits in branches/safari-601.1-branch/LayoutTests

Update test results after r187346 ('>>' descendant combinator).

fast/css/css-selector-text-expected.txt:
fast/css/css-set-selector-text-expected.txt:
fast/css/parsing-css-attribute-case-insensitive-value-1-expected.txt:
fast/css/parsing-css-attribute-case-insensitive-value-4-expected.txt:
fast/css/parsing-css-descendant-combinator-doubled-child-syntax-expected.txt:
fast/selectors/case-insensitive-attribute-register-requirement-2-expected.txt:
fast/selectors/element-closest-descendant-combinator-doubled-child-syntax-expected.txt:
fast/selectors/element-matches-attribute-ascii-case-insensitive-html-expected.txt:
fast/selectors/element-matches-descendant-combinator-doubled-child-syntax-expected.txt:
fast/selectors/nth-child-matching-first-expected.txt:
fast/selectors/nth-last-child-matching-first-expected.txt:
fast/selectors/querySelector-attribute-ascii-case-insensitive-html-expected.txt:
fast/selectors/querySelector-descendant-combinator-doubled-child-syntax-expected.txt:
platform/mac/TestExpectations:

6:38 PM Changeset in webkit [187396] by ap@apple.com

2 edits in trunk/LayoutTests

REGRESSION?: Frame scrollability tests are very flaky
https://bugs.webkit.org/show_bug.cgi?id=147300

platform/mac-wk2/TestExpectations: Marking them as such.

6:30 PM Changeset in webkit [187395] by ap@apple.com

4 edits in trunk/LayoutTests

inspector/css/modify-rule-selector.html times out (flakily on some platforms, and
every time on others).
https://bugs.webkit.org/show_bug.cgi?id=147229

platform/gtk/TestExpectations:
platform/mac-wk2/TestExpectations:
platform/win/TestExpectations:

Added expectations.

6:01 PM Changeset in webkit [187394] by ap@apple.com

2 edits in trunk/LayoutTests

aria-liveregions-notifications tests are very flaky
https://bugs.webkit.org/show_bug.cgi?id=147299

platform/mac/TestExpectations: Marked them as such.

5:31 PM Changeset in webkit [187393] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Expose TextIndicator-backed snapshot and rect gathering on DOMNode
https://bugs.webkit.org/show_bug.cgi?id=147298
<rdar://problem/21905839>

Reviewed by Sam Weinig.

bindings/objc/DOM.mm:

(-[DOMNode getPreviewSnapshotImage:andRects:]):
No need to multiply by device scale here.

4:28 PM Changeset in webkit [187392] by timothy_horton@apple.com

4 edits in trunk/Source/WebCore

Expose TextIndicator-backed snapshot and rect gathering on DOMNode
https://bugs.webkit.org/show_bug.cgi?id=147298
<rdar://problem/21905839>

bindings/objc/DOM.mm:

(-[DOMNode getPreviewSnapshotImage:andRects:]):

bindings/objc/DOMExtensions.h:
bindings/objc/DOMPrivate.h:

Move this to a private header.

4:11 PM Changeset in webkit [187391] by timothy_horton@apple.com

3 edits in trunk/Source/WebCore

Expose TextIndicator-backed snapshot and rect gathering on DOMNode
https://bugs.webkit.org/show_bug.cgi?id=147298
<rdar://problem/21905839>

Reviewed by Sam Weinig.

bindings/objc/DOM.mm:

(-[DOMNode getPreviewSnapshotImage:andRects:]):

bindings/objc/DOMExtensions.h:

10:51 AM Changeset in webkit [187390] by jer.noble@apple.com

37 edits in branches/safari-601.1-branch/Source

Merge r187251, r187252, r187262, r187263, r187272, r187289. rdar://problem/20689512

Source/WebCore:

2015-07-21 Jer Noble <jer.noble@apple.com>

Notify the UI delegate when a MediaDocument's natural size changes
https://bugs.webkit.org/show_bug.cgi?id=147182

Reviewed by Simon Fraser.

Notify the MediaDocument that it's underlying media element has changed its natural size, either when
the media engine notifies us that the size changed, or when the ready state progresses to HAVE_METADATA.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): Notify the media document. (WebCore::HTMLMediaElement::mediaPlayerSizeChanged): Ditto.
html/MediaDocument.cpp: (WebCore::MediaDocument::mediaElementNaturalSizeChanged): Pass to the chrome client.
html/MediaDocument.h:
page/ChromeClient.h:

2015-07-23 Jer Noble <jer.noble@apple.com>

Relax media playback restrictions if the allowsMediaDocumentInlinePlayback property is set.
https://bugs.webkit.org/show_bug.cgi?id=147234

Reviewed by Darin Adler.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForLoad): Moved restriction check into MediaElementSession.
html/MediaElementSession.cpp: (WebCore::MediaElementSession::playbackPermitted): Check if is a top-level media document and if

allowsMediaDocumentInilnePlayback is set, and return early.

(WebCore::MediaElementSession::effectivePreloadForElement): Ditto.
(WebCore::MediaElementSession::allowsAutomaticMediaDataLoading): Ditto.

html/MediaElementSession.h:

2015-07-21 Jer Noble <jer.noble@apple.com>

[iOS] Add an explicit API to allow media documents to (temporarily) play inline
https://bugs.webkit.org/show_bug.cgi?id=147181

Reviewed by Beth Dakin.

Add listeners for the new allowsMediaDocumentInlinePlayback API. When this value becomes
NO, force any playing MediaDocuments to enter fullscreen mode.

dom/Document.cpp: (WebCore::Document::registerForAllowsMediaDocumentInlinePlaybackChangedCallbacks): Added registration method. (WebCore::Document::unregisterForAllowsMediaDocumentInlinePlaybackChangedCallbacks): Added deregistration method. (WebCore::Document::allowsMediaDocumentInlinePlaybackChanged): Notify all listeners.
dom/Document.h:
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::registerWithDocument): Listen for allowsMediaDocumentInlinePlayback changes. (WebCore::HTMLMediaElement::unregisterWithDocument): Stop listening to same. (WebCore::HTMLMediaElement::allowsMediaDocumentInlinePlaybackChanged): Enter fullscreen mode if the value

changes to false during playback.

html/HTMLMediaElement.h:
html/MediaElementSession.cpp: (WebCore::MediaElementSession::requiresFullscreenForVideoPlayback): Early true if the override value is set.
page/Page.cpp: (WebCore::Page::setAllowsMediaDocumentInlinePlayback): Notify all documents of the changed value.
page/Page.h: (WebCore::Page::allowsMediaDocumentInlinePlayback): Simple getter.

Source/WebKit2:

2015-07-23 Alex Christensen <achristensen@webkit.org>

Fix 32-bit build after r187272.

UIProcess/mac/PageClientImpl.mm: (WebKit::PageClientImpl::mediaDocumentNaturalSizeChanged): Added some WK_API_ENABLED.

2015-07-23 Alex Christensen <achristensen@webkit.org>

[iOS] Unreviewed build fix after r187251.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setAllowsMediaDocumentInlinePlayback): Use the correct name for the boolean to pass along to SetAllowsMediaDocumentInlinePlayback.

2015-07-21 Jer Noble <jer.noble@apple.com>

Notify the UI delegate when a MediaDocument's natural size changes
https://bugs.webkit.org/show_bug.cgi?id=147182

Reviewed by Simon Fraser.

Pipe notifications of media document natural size changes up from the chrome client, through
to the UIProcess, through the page client, through the WKWebView, to the UIDelegate.

UIProcess/API/APIUIClient.h: (API::UIClient::mediaDocumentNaturalSizeChanged):
UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _mediaDocumentNaturalSizeChanged:]):
UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/Cocoa/UIDelegate.h:
UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::setDelegate): (WebKit::UIDelegate::UIClient::mediaDocumentNaturalSizeChanged):
UIProcess/PageClient.h:
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::mediaDocumentNaturalSizeChanged):
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::mediaDocumentNaturalSizeChanged):
UIProcess/mac/PageClientImpl.h:
UIProcess/mac/PageClientImpl.mm: (WebKit::PageClientImpl::mediaDocumentNaturalSizeChanged):
WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::mediaDocumentNaturalSizeChanged):
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::mediaDocumentNaturalSizeChanged):
WebProcess/WebPage/WebPage.h:
UIProcess/API/gtk/PageClientImpl.h: Add default, empty implementation of new pure-virtual method.
UIProcess/efl/WebViewEfl.h: Ditto.

2015-07-23 Jer Noble <jer.noble@apple.com>

Unreviewed build fix after r187251; rename flag -> allows.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setAllowsMediaDocumentInlinePlayback):

2015-07-23 Jer Noble <jer.noble@apple.com>

[WK2] Add a WKWebView property for whether the view is displaying a media document
https://bugs.webkit.org/show_bug.cgi?id=147233

Reviewed by Beth Dakin.

Add a _isDisplayingStandaloneMediaDocument property, which queries the frame for whether
the current MIME type is one which our media engines support.

UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _isDisplayingStandaloneMediaDocument]):
UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::isDisplayingStandaloneMediaDocument):
UIProcess/WebFrameProxy.h:

2015-07-21 Jer Noble <jer.noble@apple.com>

[iOS] Add an explicit API to allow media documents to (temporarily) play inline
https://bugs.webkit.org/show_bug.cgi?id=147181

Reviewed by Beth Dakin.

Add a WKWebView(Private) API which allows MediaDocuments loaded by the view to play their contents inline, regardless
of whether inline playback is restricted on the current device.

UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _setRequiresUserActionForMediaPlayback:]): Added. Pass through to WebPageProxy. (-[WKWebView _allowsMediaDocumentInlinePlayback]): Ditto.
UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::allowsMediaDocumentInlinePlayback): Simple getter. (WebKit::WebPageProxy::setAllowsMediaDocumentInlinePlayback): Set, and conditionally pass the new value to WebPage.
UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setAllowsMediaDocumentInlinePlayback): Set, and conditionally notify WebCore page of the change.
WebProcess/WebPage/WebPage.h: (WebKit::WebPage::allowsMediaDocumentInlinePlayback): Simple getter.
WebProcess/WebPage/WebPage.messages.in: Add new messages.

7:46 AM Changeset in webkit [187389] by clopez@igalia.com

2 edits in trunk/Source/WTF

REGRESSION (bmalloc): WebKit performance tests don't report memory stats.
https://bugs.webkit.org/show_bug.cgi?id=141247

Reviewed by Geoffrey Garen.

Meanwhile a better way of getting memory stats with bmalloc is not found
(see bug 136592), we can report as memory stats the resident set size
information that the operating system provides to us.

This at least should be good enough to get back the memory stats on the
performance tests and being able to track down memory usage regressions
at https://perf.webkit.org