Timeline
Aug 2, 2015:
- 9:33 PM Changeset in webkit [187733] by
-
- 6 edits in trunk
Investigate HashTable::HashTable(const HashTable&) and HashTable::operator=(const HashTable&) performance for hash-based static analyses
https://bugs.webkit.org/show_bug.cgi?id=118455
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-08-02
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
LivenessAnalysisPhase lights up like a christmas tree in profiles.
This patch cuts its cost by 4.
About half of the gains come from removing many rehash() when copying
the HashSet.
The last quarter is achieved by having a special add() function for initializing
a HashSet.
This makes benchmarks progress by 1-2% here and there. Nothing massive.
- dfg/DFGLivenessAnalysisPhase.cpp:
(JSC::DFG::LivenessAnalysisPhase::process):
The m_live HashSet is only useful per block. When we are done with it,
we can transfer it to liveAtHead to avoid a copy.
Source/WTF:
Previously, when copying a HashTable, we would start from scratch
with an empty table and insert elements one by one, growing-rehashing
the table as needed.
With this patch, we have 2 improvements to remove most of the cost.
First, we compute a good size from the start. This removes all the
reallocations and rehashs.
This is where the biggest gain comes from.
The second part is a simpler version of add() when we know that
we cannot find a bucket with the same key and there cannot
be any deleted bucket.
This removes most branches from the hot loop, cutting another 25%
of the time.
- wtf/HashTable.h:
(WTF::KeyTraits>::addUniqueForInitialization):
(WTF::KeyTraits>::HashTable):
Tools:
- TestWebKitAPI/Tests/WTF/HashSet.cpp:
(TestWebKitAPI::TEST):
- 6:44 PM Changeset in webkit [187732] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Unnamespaced Formatter classes break CSSStyleDeclarationTextEditor
https://bugs.webkit.org/show_bug.cgi?id=147544
Reviewed by Brian Burg.
Added Formatter and FormatterContentBuilder to WebInspector namespace.
- UserInterface/Controllers/Formatter.js:
- UserInterface/Controllers/FormatterContentBuilder.js:
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._formattedContentFromEditor):
- UserInterface/Views/TextEditor.js:
(WebInspector.TextEditor.prototype.prettyPrint.prettyPrintAndUpdateEditor):
(WebInspector.TextEditor.prototype.prettyPrint):
- 12:28 PM Changeset in webkit [187731] by
-
- 2 edits in trunk/Source/WebCore
AX: On some complex sites, iOS instantly crashes once VoiceOver is turned on
https://bugs.webkit.org/show_bug.cgi?id=147529
Reviewed by Dan Bernstein.
Sometimes after focusing on a node, it seems like the entire document is destroyed.
Accessibility the axObjectCache returns nullptr and we crash.
Despite my best efforts, I couldn't make a layout test that reproduced this. It's possible
the entire document needs to be destroyed and replaced with something.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setFocused):
- 11:48 AM Changeset in webkit [187730] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION (r187689): Timeline overview graph layout is broken
https://bugs.webkit.org/show_bug.cgi?id=147539
Reviewed by Brian Burg.
Removed timeline argument being passed to TimelineOverviewGraph constructor.
- UserInterface/Views/LayoutTimelineOverviewGraph.js:
(WebInspector.LayoutTimelineOverviewGraph):
- UserInterface/Views/NetworkTimelineOverviewGraph.js:
(WebInspector.NetworkTimelineOverviewGraph):
- UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
(WebInspector.RenderingFrameTimelineOverviewGraph):
- UserInterface/Views/ScriptTimelineOverviewGraph.js:
(WebInspector.ScriptTimelineOverviewGraph):
Aug 1, 2015:
- 5:48 PM Changeset in webkit [187729] by
-
- 35 edits2 adds in trunk
[OS X] Font fallback is not language-sensitive
https://bugs.webkit.org/show_bug.cgi?id=147390
Reviewed by Dean Jackson.
Source/WebCore:
We need to make our font fallback code sensitive to locale.
Test: fast/text/fallback-language-han.html
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::lookupCTFont):
(WebCore::FontCache::systemFallbackForCharacters):
LayoutTests:
Updating tests.
- css3/line-break/line-break-auto-centered-expected.html:
- css3/line-break/line-break-auto-centered.html:
- css3/line-break/line-break-auto-postfixes-expected.html:
- css3/line-break/line-break-auto-postfixes.html:
- css3/line-break/line-break-loose-centered-expected.html:
- css3/line-break/line-break-loose-centered.html:
- css3/line-break/line-break-loose-hyphens-expected.html:
- css3/line-break/line-break-loose-hyphens.html:
- css3/line-break/line-break-loose-postfixes-expected.html:
- css3/line-break/line-break-loose-postfixes.html:
- css3/line-break/line-break-loose-sound-marks-expected.html:
- css3/line-break/line-break-loose-sound-marks.html:
- css3/line-break/line-break-normal-centered-expected.html:
- css3/line-break/line-break-normal-centered.html:
- css3/line-break/line-break-normal-hyphens-expected.html:
- css3/line-break/line-break-normal-hyphens.html:
- css3/line-break/line-break-normal-postfixes-expected.html:
- css3/line-break/line-break-normal-postfixes.html:
- css3/line-break/line-break-normal-sound-marks-expected.html:
- css3/line-break/line-break-normal-sound-marks.html:
- css3/line-break/line-break-strict-centered-expected.html:
- css3/line-break/line-break-strict-centered.html:
- css3/line-break/line-break-strict-hyphens-expected.html:
- css3/line-break/line-break-strict-hyphens.html:
- css3/line-break/line-break-strict-postfixes-expected.html:
- css3/line-break/line-break-strict-postfixes.html:
- css3/line-break/line-break-strict-sound-marks-expected.html:
- css3/line-break/line-break-strict-sound-marks.html:
- fast/text/fallback-language-han-expected.html: Added.
- fast/text/fallback-language-han.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/win/TestExpectations:
- 4:49 PM Changeset in webkit [187728] by
-
- 2 edits in trunk/Source/WebCore
CharacterFallbackMapKey should be locale-specific
https://bugs.webkit.org/show_bug.cgi?id=147532
Reviewed by Dean Jackson.
This is in preparation for locale-specific font fallback.
No new tests because there is no behavior change.
- platform/graphics/Font.cpp:
(WebCore::CharacterFallbackMapKey::CharacterFallbackMapKey):
(WebCore::CharacterFallbackMapKey::operator==):
(WebCore::CharacterFallbackMapKeyHash::hash):
(WebCore::Font::systemFallbackFontForCharacter):
- 4:39 PM Changeset in webkit [187727] by
-
- 5 edits in branches/safari-601.1-branch/Source
Versioning.
- 2:53 PM Changeset in webkit [187726] by
-
- 2 edits in trunk/Source/WebKit
Fix 64-bit CMake build on Windows.
- PlatformWin.cmake:
Win64 needs PaintHooks.asm.
- 1:43 PM Changeset in webkit [187725] by
-
- 2 edits in trunk/LayoutTests
[Win] Test gardening
Unreviewed
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2015-08-01
- platform/win/TestExpectations:
- 1:15 PM Changeset in webkit [187724] by
-
- 2 edits in trunk/Source/WebCore
Expand CharacterFallbackMapKey to a struct
https://bugs.webkit.org/show_bug.cgi?id=147530
Reviewed by Dean Jackson.
This is in prepraration for making this struct locale-specific.
No new tests because there is no behavior change.
- platform/graphics/Font.cpp:
(WebCore::CharacterFallbackMapKey::CharacterFallbackMapKey):
(WebCore::CharacterFallbackMapKey::isHashTableDeletedValue):
(WebCore::CharacterFallbackMapKey::operator==):
(WebCore::CharacterFallbackMapKeyHash::hash):
(WebCore::CharacterFallbackMapKeyHash::equal):
(WebCore::Font::systemFallbackFontForCharacter):
- 1:14 PM Changeset in webkit [187723] by
-
- 2 edits in trunk/Source/WTF
HashTraits<AtomicString> can use SimpleClassHashTraits
https://bugs.webkit.org/show_bug.cgi?id=147528
Reviewed by Andreas Kling.
No point in duplicating the code inside SimpleClassHashTraits.
- wtf/text/AtomicStringHash.h:
(WTF::HashTraits<WTF::AtomicString>::constructDeletedValue): Deleted.
(WTF::HashTraits<WTF::AtomicString>::isDeletedValue): Deleted.
- 1:08 PM Changeset in webkit [187722] by
-
- 2 edits in trunk/Source/WebCore
Fix the build after r187721
Unreviewed.
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2015-08-01
- bindings/js/JSDOMBinding.h:
(WebCore::createWrapper):
- 12:55 PM Changeset in webkit [187721] by
-
- 6 edits in trunk/Source
Fix compile errors with VS2015
https://bugs.webkit.org/show_bug.cgi?id=147526
Reviewed by Myles Maxfield.
Source/WebCore:
- bindings/js/JSDOMBinding.h:
(WebCore::createWrapper):
Explicitly call the Ref constructor to avoid unresolved symbols with VS2015.
Otherwise, VS2015 tries to use CSSPrimitiveValue::operator<Ref<CSSPrimitiveValue> > which doesn't exist.
Source/WebKit/win:
- WebKitDLL.cpp:
(shutDownWebKit):
(loadResourceIntoBuffer): Needs to be exported from WebKit.dll to link with CMake using VS2015.
Source/WTF:
- wtf/StringExtras.h:
(snprintf):
(wtf_vsnprintf):
VS2015 has an implementation of snprintf.
- 11:16 AM Changeset in webkit [187720] by
-
- 1 copy in tags/Safari-601.1.46
New tag.
- 10:11 AM WebKitGTK/2.8.x edited by
- Propose some merges (diff)
- 10:06 AM Changeset in webkit [187719] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merged r187686. rdar://problem/22083354
- 8:34 AM Changeset in webkit [187718] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merged r187687. rdar://problem/21939014
- 8:27 AM Changeset in webkit [187717] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Remove unintentional "print" statement in test case.
https://bugs.webkit.org/show_bug.cgi?id=142567
- tests/stress/class-syntax-definition-semantics.js:
(shouldBeSyntaxError):
- 8:23 AM Changeset in webkit [187716] by
-
- 5 edits in branches/safari-601.1-branch/Source
Versioning.
- 3:55 AM Changeset in webkit [187715] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Replace "unknown-mac" CSS class with "el-capitan"
https://bugs.webkit.org/show_bug.cgi?id=147524
Reviewed by Timothy Hatcher.
- UserInterface/Base/Platform.js:
No need to repeat WebInspector.Platform.version.release for every possible case.
- UserInterface/Views/Toolbar.css:
(body:not(.el-capitan) .toolbar .dashboard-container):
(body:not(.el-capitan) .toolbar .search-bar > input[type="search"]):
(body:not(.el-capitan) .toolbar .search-bar > input[type="search"]:focus):
(body:not(.el-capitan) .toolbar .item.button:active):
(body.window-inactive:not(.el-capitan) .toolbar .dashboard-container):
(body.el-capitan .toolbar .dashboard-container):
(body.el-capitan .toolbar .search-bar > input[type="search"]):
(body.el-capitan .toolbar .search-bar > input[type="search"]:focus):
(@media (-webkit-min-device-pixel-ratio: 2)):
(body.el-capitan .toolbar .item.button:active):
(body.el-capitan.window-inactive .toolbar .dashboard-container):
(body:not(.unknown-mac) .toolbar .dashboard-container): Deleted.
(body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]): Deleted.
(body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]:focus): Deleted.
(body:not(.unknown-mac) .toolbar .item.button:active): Deleted.
(body.window-inactive:not(.unknown-mac) .toolbar .dashboard-container): Deleted.
(body.unknown-mac .toolbar .dashboard-container): Deleted.
(body.unknown-mac .toolbar .search-bar > input[type="search"]): Deleted.
(body.unknown-mac .toolbar .search-bar > input[type="search"]:focus): Deleted.
(body.unknown-mac .toolbar .item.button:active): Deleted.
(body.unknown-mac.window-inactive .toolbar .dashboard-container): Deleted.
