⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 9, 2015:

11:50 PM Changeset in webkit [188206] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[EFL] Use the non-overlay scrollbar
​https://bugs.webkit.org/show_bug.cgi?id=147725

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-08-09
Reviewed by Gyuyoung Kim.

No new tests because there is no behavior change.

  • platform/efl/ScrollbarThemeEfl.cpp:

(WebCore::ScrollbarThemeEfl::usesOverlayScrollbars):
Changed the condition of the 'usesOverlayScrollbars' to use the
setting value.

  • platform/efl/ScrollbarThemeEfl.h:
11:41 PM Changeset in webkit [188205] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.

It's timing out in the bots. My guess is that there's no installer
installed in the bots and gst_install_plugins_supported() returns
false, so we don't even get a permission request because no
installer will be launched.

  • Scripts/run-gtk-tests:

(TestRunner):

9:14 PM Changeset in webkit [188204] by Chris Dumez
  • 3 edits
    4 adds in trunk

Page cache doesn't work for pages actively using Geolocation
​https://bugs.webkit.org/show_bug.cgi?id=147785
<rdar://problem/11147901>

Reviewed by Darin Adler.

Source/WebCore:

Allow pages actively using Geolocation into the PageCache.

Tests: fast/history/page-cache-geolocation-active-oneshot.html

fast/history/page-cache-geolocation-active-watcher.html

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::canSuspendForPageCache):
(WebCore::Geolocation::suspend): Deleted.

  • history/PageCache.cpp:

LayoutTests:

Add layout test coverage for page caching of pages actively using
the Geolocation API.

  • fast/history/page-cache-geolocation-active-oneshot-expected.txt: Added.
  • fast/history/page-cache-geolocation-active-oneshot.html: Added.
  • fast/history/page-cache-geolocation-active-watcher-expected.txt: Added.
  • fast/history/page-cache-geolocation-active-watcher.html: Added.
6:53 PM Changeset in webkit [188203] by commit-queue@webkit.org
  • 14 edits
    2 adds in trunk

AX: CSS table display styles can cause malformed, inaccessible AXTables to be exposed to the AX tree
​https://bugs.webkit.org/show_bug.cgi?id=136415
<rdar://problem/22026625>

Patch by Nan Wang <​n_wang@apple.com> on 2015-08-09
Reviewed by Chris Fleizach.

Source/WebCore:

Applying CSS display styles to tables can end up inserting anonymous RenderTableRows, which is not handled well by the
accessibility code, which treats these as the actual rows. We can address this by diving deeper into anonymous nodes
and finding the real rows and cells we want. In addition, another thing also causing malformed tables is that "grid"
roles are being exposed as AXGrid instead of AXTable.

Test: accessibility/mac/malformed-table.html

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addRowDescendant):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::addTableCellChild):
(WebCore::AccessibilityTable::addChildrenFromSection):

  • accessibility/AccessibilityTable.h:
  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::parentTable):
(WebCore::AccessibilityTableCell::rowIndexRange):

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::parentTable):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(createAccessibilityRoleMap):

LayoutTests:

  • accessibility/aria-table-with-presentational-elements-expected.txt:
  • accessibility/aria-table-with-presentational-elements.html:
  • accessibility/mac/malformed-table-expected.txt: Added.
  • accessibility/mac/malformed-table.html: Added.
  • platform/mac-mavericks/accessibility/roles-exposed-expected.txt:
  • platform/mac/accessibility/aria-table-hierarchy-expected.txt:
  • platform/mac/accessibility/aria-tables-expected.txt:
  • platform/mac/accessibility/roles-exposed-expected.txt:
5:10 PM Changeset in webkit [188202] by Darin Adler
  • 14 edits
    83 deletes in trunk

Remove -webkit-color-correction CSS property
​https://bugs.webkit.org/show_bug.cgi?id=147812

Reviewed by Maciej Stachowiak.

Source/WebCore:

Covered by existing tests.

I am doing some general cleanup of handling of color spaces in WebKit.
This removes the obsolete web-visible property that allowed clients to
get color correction on older Apple platforms where we chose not to do
it all the time for performance reasons. Currently, it has no effect on
any supported platform.

Now that this property is removed, a website can detect that it's not
there if it uses getComputedStyle, but I don't expect this to have
significant compatibility fallout. It's harmless to continue using the
property in legacy content or websites that have not been updated, since
unknown property names are ignored and it had no effect before anyway.

  • css/CSSComputedStyleDeclaration.cpp: Removed

CSSPropertyWebkitColorCorrection from the list of computed properties.
(WebCore::ComputedStyleExtractor::propertyValue): Removed the
CSSPropertyWebkitColorCorrection case.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue): Removed the
CSSPropertyWebkitColorCorrection case.
(WebCore::isKeywordPropertyID): Ditto.
(WebCore::CSSParser::parseValue): Ditto.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Deleted the overload
of this that converts a ColorSpace to a CSSPrimitiveValue.
(WebCore::CSSPrimitiveValue::operator ColorSpace): Deleted.

  • css/CSSPropertyNames.in: Removed -webkit-color-correction.
  • css/CSSValueKeywords.in: Removed the -webkit-color-correction section,

which contained sRGB.

  • css/SVGCSSValueKeywords.in: Uncommented sRGB now that it's not shared

with -webkit-color-correction.

  • rendering/style/RenderStyle.h: Removed setColorSpace and initialColorSpace.

Kept colorSpace around for now, but it simply returns ColorSpaceSRGB.
This prevents us from needing to touch every single call site that passes
the color space in to functions in the platform graphics abstraction.
We'll touch most of those call sites when we change Color to include the
color space and eventually we can delete this.

  • rendering/style/StyleRareInheritedData.cpp: Deleted colorSpace.

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Deleted
code to initialize colorSpace and to copy colorSpace.
(WebCore::StyleRareInheritedData::operator==): Deleted code to compare
colorSpace.

LayoutTests:

Given that -webkit-color-correction had no effect on rendering on any platform in any
configuration we covered, it's amazing how many tests we had for it.

  • fast/css/getComputedStyle/computed-style-expected.txt: Removed expected results for

-webkit-color-correction property.

  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
  • svg/css/getComputedStyle-basic-expected.txt: Ditto.
  • fast/css/getComputedStyle/resources/property-names.js: Removed -webkit-color-correction.
  • fast/css/color-correction-backgrounds-and-text.html: Removed.
  • fast/css/color-correction-on-background-image.html: Removed.
  • fast/css/color-correction-on-backgrounds.html: Removed.
  • fast/css/color-correction-on-box-shadow.html: Removed.
  • fast/css/color-correction-on-text-shadow.html: Removed.
  • fast/css/color-correction-on-text.html: Removed.
  • fast/css/color-correction-untagged-images.html: Removed.
  • fast/css/color-correction.html: Removed.
  • fast/css/parsing-color-correction-expected.txt: Removed.
  • fast/css/parsing-color-correction.html: Removed.
  • fast/css/resources/parsing-color-correction.js: Removed.
  • platform/efl/fast/css/color-correction-backgrounds-and-text-expected.png: Removed.
  • platform/efl/fast/css/color-correction-backgrounds-and-text-expected.txt: Removed.
  • platform/efl/fast/css/color-correction-expected.png: Removed.
  • platform/efl/fast/css/color-correction-expected.txt: Removed.
  • platform/efl/fast/css/color-correction-on-background-image-expected.png: Removed.
  • platform/efl/fast/css/color-correction-on-background-image-expected.txt: Removed.
  • platform/efl/fast/css/color-correction-on-backgrounds-expected.png: Removed.
  • platform/efl/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
  • platform/efl/fast/css/color-correction-on-box-shadow-expected.png: Removed.
  • platform/efl/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
  • platform/efl/fast/css/color-correction-on-text-expected.png: Removed.
  • platform/efl/fast/css/color-correction-on-text-expected.txt: Removed.
  • platform/efl/fast/css/color-correction-on-text-shadow-expected.png: Removed.
  • platform/efl/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
  • platform/efl/fast/css/color-correction-untagged-images-expected.png: Removed.
  • platform/efl/fast/css/color-correction-untagged-images-expected.txt: Removed.
  • platform/gtk/fast/css/color-correction-backgrounds-and-text-expected.png: Removed.
  • platform/gtk/fast/css/color-correction-backgrounds-and-text-expected.txt: Removed.
  • platform/gtk/fast/css/color-correction-expected.png: Removed.
  • platform/gtk/fast/css/color-correction-expected.txt: Removed.
  • platform/gtk/fast/css/color-correction-on-background-image-expected.png: Removed.
  • platform/gtk/fast/css/color-correction-on-background-image-expected.txt: Removed.
  • platform/gtk/fast/css/color-correction-on-backgrounds-expected.png: Removed.
  • platform/gtk/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
  • platform/gtk/fast/css/color-correction-on-box-shadow-expected.png: Removed.
  • platform/gtk/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
  • platform/gtk/fast/css/color-correction-on-text-expected.png: Removed.
  • platform/gtk/fast/css/color-correction-on-text-expected.txt: Removed.
  • platform/gtk/fast/css/color-correction-on-text-shadow-expected.png: Removed.
  • platform/gtk/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
  • platform/gtk/fast/css/color-correction-untagged-images-expected.png: Removed.
  • platform/gtk/fast/css/color-correction-untagged-images-expected.txt: Removed.
  • platform/ios-simulator-wk2/fast/css/color-correction-backgrounds-and-text-expected.txt: Removed.
  • platform/ios-simulator-wk2/fast/css/color-correction-expected.txt: Removed.
  • platform/ios-simulator-wk2/fast/css/color-correction-on-background-image-expected.txt: Removed.
  • platform/ios-simulator-wk2/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
  • platform/ios-simulator-wk2/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
  • platform/ios-simulator-wk2/fast/css/color-correction-on-text-expected.txt: Removed.
  • platform/ios-simulator-wk2/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
  • platform/ios-simulator-wk2/fast/css/color-correction-untagged-images-expected.txt: Removed.
  • platform/ios-simulator/fast/css/color-correction-backgrounds-and-text-expected.txt: Removed.
  • platform/ios-simulator/fast/css/color-correction-expected.txt: Removed.
  • platform/ios-simulator/fast/css/color-correction-on-background-image-expected.txt: Removed.
  • platform/ios-simulator/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
  • platform/ios-simulator/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
  • platform/ios-simulator/fast/css/color-correction-on-text-expected.txt: Removed.
  • platform/ios-simulator/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
  • platform/ios-simulator/fast/css/color-correction-untagged-images-expected.txt: Removed.
  • platform/mac/fast/css/color-correction-backgrounds-and-text-expected.png: Removed.
  • platform/mac/fast/css/color-correction-backgrounds-and-text-expected.txt: Removed.
  • platform/mac/fast/css/color-correction-expected.png: Removed.
  • platform/mac/fast/css/color-correction-expected.txt: Removed.
  • platform/mac/fast/css/color-correction-on-background-image-expected.png: Removed.
  • platform/mac/fast/css/color-correction-on-background-image-expected.txt: Removed.
  • platform/mac/fast/css/color-correction-on-backgrounds-expected.png: Removed.
  • platform/mac/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
  • platform/mac/fast/css/color-correction-on-box-shadow-expected.png: Removed.
  • platform/mac/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
  • platform/mac/fast/css/color-correction-on-text-expected.png: Removed.
  • platform/mac/fast/css/color-correction-on-text-expected.txt: Removed.
  • platform/mac/fast/css/color-correction-on-text-shadow-expected.png: Removed.
  • platform/mac/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
  • platform/mac/fast/css/color-correction-untagged-images-expected.png: Removed.
  • platform/mac/fast/css/color-correction-untagged-images-expected.txt: Removed.
  • platform/win/fast/css/color-correction-backgrounds-and-text-expected.txt: Removed.
  • platform/win/fast/css/color-correction-expected.txt: Removed.
  • platform/win/fast/css/color-correction-on-background-image-expected.txt: Removed.
  • platform/win/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
  • platform/win/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
  • platform/win/fast/css/color-correction-on-text-expected.txt: Removed.
  • platform/win/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
  • platform/win/fast/css/color-correction-untagged-images-expected.txt: Removed.
3:55 PM Changeset in webkit [188201] by Chris Dumez
  • 38 edits
    51 deletes in trunk

Regression(r188105): Seems to have caused crashes during PLT on some iPads
​https://bugs.webkit.org/show_bug.cgi?id=147818

Unreviewed, roll out r188105.

Source/JavaScriptCore:

  • bytecode/ByValInfo.h:

(JSC::ByValInfo::ByValInfo):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::getByValInfoMap): Deleted.
(JSC::CodeBlock::addByValInfo): Deleted.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::getByValInfo):
(JSC::CodeBlock::setNumberOfByValInfos):
(JSC::CodeBlock::numberOfByValInfos):
(JSC::CodeBlock::byValInfo):

  • bytecode/ExitKind.cpp:

(JSC::exitKindToString): Deleted.

  • bytecode/ExitKind.h:
  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFor):
(JSC::GetByIdStatus::computeForStubInfo):
(JSC::GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback): Deleted.

  • bytecode/GetByIdStatus.h:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects): Deleted.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry): Deleted.

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize): Deleted.

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants): Deleted.

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC): Deleted.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode): Deleted.
(JSC::DFG::FixupPhase::observeUseKindOnNode): Deleted.

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasUidOperand): Deleted.
(JSC::DFG::Node::uidOperand): Deleted.

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate): Deleted.

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()): Deleted.
(JSC::DFG::safeToExecute): Deleted.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCheckIdent): Deleted.
(JSC::DFG::SpeculativeJIT::speculateSymbol): Deleted.
(JSC::DFG::SpeculativeJIT::speculate): Deleted.

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Deleted.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Deleted.

  • dfg/DFGUseKind.cpp:

(WTF::printInternal): Deleted.

  • dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor): Deleted.
(JSC::DFG::isCell): Deleted.

  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile): Deleted.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileNode): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::compileCheckIdent): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::lowSymbol): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::speculate): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::isNotSymbol): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::speculateSymbol): Deleted.

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::ByValCompilationInfo::ByValCompilationInfo):
(JSC::JIT::compileGetByValWithCachedId): Deleted.

  • jit/JITInlines.h:

(JSC::JIT::callOperation): Deleted.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_has_indexed_property):
(JSC::JIT::emitSlow_op_has_indexed_property):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_has_indexed_property):
(JSC::JIT::emitSlow_op_has_indexed_property):

  • jit/JITOperations.cpp:

(JSC::getByVal):

  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emitGetByValWithCachedId): Deleted.
(JSC::JIT::privateCompileGetByVal): Deleted.
(JSC::JIT::privateCompileGetByValWithCachedId): Deleted.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emitGetByValWithCachedId): Deleted.

  • runtime/Symbol.h:
  • tests/stress/get-by-val-with-string-constructor.js: Removed.
  • tests/stress/get-by-val-with-string-exit.js: Removed.
  • tests/stress/get-by-val-with-string-generated.js: Removed.
  • tests/stress/get-by-val-with-string-getter.js: Removed.
  • tests/stress/get-by-val-with-string.js: Removed.
  • tests/stress/get-by-val-with-symbol-constructor.js: Removed.
  • tests/stress/get-by-val-with-symbol-exit.js: Removed.
  • tests/stress/get-by-val-with-symbol-getter.js: Removed.
  • tests/stress/get-by-val-with-symbol.js: Removed.

LayoutTests:

  • js/regress/get-by-val-with-string-bimorphic-check-structure-elimination-expected.txt: Removed.
  • js/regress/get-by-val-with-string-bimorphic-check-structure-elimination-simple-expected.txt: Removed.
  • js/regress/get-by-val-with-string-bimorphic-check-structure-elimination-simple.html: Removed.
  • js/regress/get-by-val-with-string-bimorphic-check-structure-elimination.html: Removed.
  • js/regress/get-by-val-with-string-chain-from-try-block-expected.txt: Removed.
  • js/regress/get-by-val-with-string-chain-from-try-block.html: Removed.
  • js/regress/get-by-val-with-string-check-structure-elimination-expected.txt: Removed.
  • js/regress/get-by-val-with-string-check-structure-elimination.html: Removed.
  • js/regress/get-by-val-with-string-proto-or-self-expected.txt: Removed.
  • js/regress/get-by-val-with-string-proto-or-self.html: Removed.
  • js/regress/get-by-val-with-string-quadmorphic-check-structure-elimination-simple-expected.txt: Removed.
  • js/regress/get-by-val-with-string-quadmorphic-check-structure-elimination-simple.html: Removed.
  • js/regress/get-by-val-with-string-self-or-proto-expected.txt: Removed.
  • js/regress/get-by-val-with-string-self-or-proto.html: Removed.
  • js/regress/get-by-val-with-symbol-bimorphic-check-structure-elimination-expected.txt: Removed.
  • js/regress/get-by-val-with-symbol-bimorphic-check-structure-elimination-simple-expected.txt: Removed.
  • js/regress/get-by-val-with-symbol-bimorphic-check-structure-elimination-simple.html: Removed.
  • js/regress/get-by-val-with-symbol-bimorphic-check-structure-elimination.html: Removed.
  • js/regress/get-by-val-with-symbol-chain-from-try-block-expected.txt: Removed.
  • js/regress/get-by-val-with-symbol-chain-from-try-block.html: Removed.
  • js/regress/get-by-val-with-symbol-check-structure-elimination-expected.txt: Removed.
  • js/regress/get-by-val-with-symbol-check-structure-elimination.html: Removed.
  • js/regress/get-by-val-with-symbol-proto-or-self-expected.txt: Removed.
  • js/regress/get-by-val-with-symbol-proto-or-self.html: Removed.
  • js/regress/get-by-val-with-symbol-quadmorphic-check-structure-elimination-simple-expected.txt: Removed.
  • js/regress/get-by-val-with-symbol-quadmorphic-check-structure-elimination-simple.html: Removed.
  • js/regress/get-by-val-with-symbol-self-or-proto-expected.txt: Removed.
  • js/regress/get-by-val-with-symbol-self-or-proto.html: Removed.
  • js/regress/script-tests/get-by-val-with-string-bimorphic-check-structure-elimination-simple.js: Removed.
  • js/regress/script-tests/get-by-val-with-string-bimorphic-check-structure-elimination.js: Removed.
  • js/regress/script-tests/get-by-val-with-string-chain-from-try-block.js: Removed.
  • js/regress/script-tests/get-by-val-with-string-check-structure-elimination.js: Removed.
  • js/regress/script-tests/get-by-val-with-string-proto-or-self.js: Removed.
  • js/regress/script-tests/get-by-val-with-string-quadmorphic-check-structure-elimination-simple.js: Removed.
  • js/regress/script-tests/get-by-val-with-string-self-or-proto.js: Removed.
  • js/regress/script-tests/get-by-val-with-symbol-bimorphic-check-structure-elimination-simple.js: Removed.
  • js/regress/script-tests/get-by-val-with-symbol-bimorphic-check-structure-elimination.js: Removed.
  • js/regress/script-tests/get-by-val-with-symbol-chain-from-try-block.js: Removed.
  • js/regress/script-tests/get-by-val-with-symbol-check-structure-elimination.js: Removed.
  • js/regress/script-tests/get-by-val-with-symbol-proto-or-self.js: Removed.
  • js/regress/script-tests/get-by-val-with-symbol-quadmorphic-check-structure-elimination-simple.js: Removed.
  • js/regress/script-tests/get-by-val-with-symbol-self-or-proto.js: Removed.
3:39 PM Changeset in webkit [188200] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

3:26 PM Changeset in webkit [188199] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.6

New tag.

3:20 PM Changeset in webkit [188198] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

Follow-up nit fixes after r187691.
​https://bugs.webkit.org/show_bug.cgi?id=128006

Reviewed by Gavin Barraclough.

Use modern for-loops instead of explicit iterators.

  • Shared/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::shouldCoalesceChallenge):
(WebKit::AuthenticationManager::coalesceChallengesMatching):

3:15 PM Changeset in webkit [188197] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Merged r188162. rdar://problem/22126518

1:39 PM Changeset in webkit [188196] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Always require ExternalDeviceAutoPlayCandidate flag to AirPlay automatically
​https://bugs.webkit.org/show_bug.cgi?id=147801

Reviewed by Dean Jackson.

Test: http/tests/media/video-media-document-disposition-download.html

  • Modules/mediasession/WebMediaSessionManager.cpp:

(WebCore::WebMediaSessionManager::configurePlaybackTargetClients): Don't tell the last element

to begin playing to the target unless the ExternalDeviceAutoPlayCandidate flag is set and
it is not currently playing.

1:01 PM Changeset in webkit [188195] by mmaxfield@apple.com
  • 3 edits
    2 adds in trunk

Crash in ComplexTextController when laying out obscure text
​https://bugs.webkit.org/show_bug.cgi?id=147806
<rdar://problem/22102378>

Reviewed by Darin Adler.

Source/WebCore:

CTFontDescriptorCopyAttribute(fontDescriptor.get(), kCTFontReferenceURLAttribute) can return nullptr.

Test: fast/text/crash-obscure-text.html

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::safeCFEqual):
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

LayoutTests:

  • fast/text/crash-obscure-text-expected.txt: Added.
  • fast/text/crash-obscure-text.html: Added.
4:15 AM Changeset in webkit [188194] by dino@apple.com
  • 10 edits in trunk

Remove the webkit prefix from CanvasRenderingContext2D imageSmoothingEnabled
​https://bugs.webkit.org/show_bug.cgi?id=147803
<rdar://problem/22200553>

Reviewed by Sam Weinig.

Source/WebCore:

Rename webkitImageSmoothingEnabled to imageSmoothingEnabled.

Updated existing tests, and made sure that the prefixed version is
identical to the standard version.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::imageSmoothingEnabled): Renamed from webkitImageSmoothingEnabled.
(WebCore::CanvasRenderingContext2D::setImageSmoothingEnabled): Renamed from setWebkitImageSmoothingEnabled.
(WebCore::CanvasRenderingContext2D::webkitImageSmoothingEnabled): Deleted.
(WebCore::CanvasRenderingContext2D::setWebkitImageSmoothingEnabled): Deleted.

  • html/canvas/CanvasRenderingContext2D.h: Rename the methods.
  • html/canvas/CanvasRenderingContext2D.idl: Add the non-prefixed form, and mark is as the

implementation of the prefixed form.

LayoutTests:

Use the standard version of imageSmoothingEnabled rather than
the prefixed version.

  • fast/canvas/canvas-imageSmoothingEnabled-expected.txt:
  • fast/canvas/canvas-imageSmoothingEnabled-patterns.html:
  • fast/canvas/canvas-imageSmoothingEnabled-zero-size.html:
  • fast/canvas/script-tests/canvas-imageSmoothingEnabled-repaint.js:

(draw):

  • fast/canvas/script-tests/canvas-imageSmoothingEnabled.js: Add some tests

to make sure the prefixed version correctly maps to the standard version.

1:11 AM Changeset in webkit [188193] by akling@apple.com
  • 9 edits in trunk/Source/WebCore

Ref-ify some functions that always succeed in constructing Documents.
<​https://webkit.org/b/147552>

Reviewed by Sam Weinig.

Update some functions involved in the construction of new Document objects
to codify that they always construct objects.

Bonus: DOMImplementation::createCSSStyleSheet().

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createCSSStyleSheet):
(WebCore::DOMImplementation::createHTMLDocument):
(WebCore::DOMImplementation::createDocument):

  • dom/DOMImplementation.h:
  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::createDocument):
(WebCore::DocumentWriter::begin):

  • loader/DocumentWriter.h:
  • xml/DOMParser.cpp:

(WebCore::DOMParser::parseFromString):

  • xml/DOMParser.h:
  • xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::createDocumentFromSource):

  • xml/XSLTProcessor.h:

Aug 8, 2015:

7:06 PM Changeset in webkit [188192] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Timeline ruler handle tooltip shows wrong value when handles overlap
​https://bugs.webkit.org/show_bug.cgi?id=147652

Reviewed by Timothy Hatcher.

  • UserInterface/Views/TimelineRuler.js:

(WebInspector.TimelineRuler.prototype._updateSelection):
Now changes the title depending on whether the selection start/end is clamped.

6:22 PM Changeset in webkit [188191] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Don't show "No Filter Results" when timeline is empty
​https://bugs.webkit.org/show_bug.cgi?id=147662

Reviewed by Timothy Hatcher.

  • UserInterface/Views/TimelineView.js:

(WebInspector.TimelineView.prototype.reset):
Now hides the empty content placeholder on timeline clear.

11:40 AM Changeset in webkit [188190] by commit-queue@webkit.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r179871.
​https://bugs.webkit.org/show_bug.cgi?id=147810

Breaks product images on ​http://www.apple.com/shop/buy-
mac/macbook (Requested by smfr on #webkit).

Reverted changeset:

"Render: properly update body's background image"
​https://bugs.webkit.org/show_bug.cgi?id=140183
​http://trac.webkit.org/changeset/179871

Note: See TracTimeline for information about the timeline view.