Context Navigation

← Previous Period
Next Period →

Timeline

Aug 10, 2015:

11:42 PM Changeset in webkit [188252] by Chris Dumez

3 edits
2 adds in trunk

The 'prototype' property on interface objects should not be enumerable
https://bugs.webkit.org/show_bug.cgi?id=147861

Reviewed by Darin Adler.

Source/WebCore:

Make the 'prototype' property not enumerable on interface object to comply with the Web IDL specification [1] and to align our behavior with Firefox 38 and Chrome 44.

Also update the 'prototype' property on named constructors to have the following attributes: { Writable: false, Enumerable: false, Configurable: false }

Previously, all these were true in WebKit. The new behavior complies
with the Web IDL specification [2] and aligns our behavior with
Firefox 38. On Chrome 44, the attributes are as follows:
{ Writable: true, Enumerable: false, Configurable: false }

This behavior is also covered by the following W3C test suite:
http://w3c-test.org/dom/interfaces.html

[1] http://heycam.github.io/webidl/#interface-object
[2] http://heycam.github.io/webidl/#named-constructors

Test: fast/dom/prototype-property-not-enumerable.html

bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorHelperMethods):

LayoutTests:

Add layout test to check that the 'prototype' property on interface
objects has the following attributes:
{ Writable: false, Enumerable: false, Configurable: false }

fast/dom/prototype-property-not-enumerable-expected.txt: Added.
fast/dom/prototype-property-not-enumerable.html: Added.

11:40 PM Changeset in webkit [188251] by achristensen@apple.com

3 edits in trunk/Tools

Another build fix after r188239.

TestWebKitAPI/PlatformWin.cmake:

Link with more libraries.

WinLauncher/CMakeLists.txt:

/NODEFAULTLIB:MSVCRT is not just needed for AppleWin.

10:07 PM Changeset in webkit [188250] by bshafiei@apple.com

5 edits in branches/safari-601.1-branch/Source

Versioning.

10:06 PM Changeset in webkit [188249] by bshafiei@apple.com

5 edits in branches/safari-601.1.46-branch/Source

Versioning.

9:59 PM Changeset in webkit [188248] by achristensen@apple.com

2 edits in trunk/Source/WebKit

Another build fix after r188239.

PlatformWin.cmake:

Link WinCairo with Media Foundation libraries.

9:46 PM Changeset in webkit [188247] by achristensen@apple.com

2 edits in trunk/Source/WebCore

Build fix after r188239.

PlatformWinCairo.cmake:

MediaPlayerPrivateMediaFoundation is needed on WinCairo with video properly enabled.

9:25 PM Changeset in webkit [188246] by achristensen@apple.com

2 edits in trunk/Source/ThirdParty

[Win] Unreviewed build fix after r188239.

gtest/CMakeLists.txt:

VS2015 requires STDC_LIMIT_MACROS to be defined for INTMAX_MAX to be defined.

8:46 PM Changeset in webkit [188245] by rniwa@webkit.org

2 edits in trunk/Tools

Build fix after r188237.

Scripts/webkitpy/benchmark_runner/benchmark_builder.py:

(BenchmarkBuilder.enter):

8:15 PM Changeset in webkit [188244] by commit-queue@webkit.org

6 edits in trunk/Tools

Update ReadMe and correct the way to use abstract abstract class.
https://bugs.webkit.org/show_bug.cgi?id=147860

Patch by Dewei Zhu <Dewei Zhu> on 2015-08-10
Reviewed by Ryosuke Niwa.

Update ReadMe according to recent changes. And set ABCMeta to be the metaclass of BrowserDriver and HTTPServerDriver,
so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses.

Scripts/webkitpy/benchmark_runner/README.md:
Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:

(BrowserDriver):

Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:

(OSXBrowserDriver.restore_env):

Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:

(HTTPServerDriver):
(HTTPServerDriver.set_device_id):

Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:

(SimpleHTTPServerDriver.get_return_code):
(SimpleHTTPServerDriver):
(SimpleHTTPServerDriver.set_device_id):

7:49 PM Changeset in webkit [188243] by mmaxfield@apple.com

2 edits in trunk/Source/WebCore

Post-review fixup after r188195
https://bugs.webkit.org/show_bug.cgi?id=147806

Unreviewed.

Covered by fast/text/crash-obscure-text.html.

platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::objectForEqualityCheck):

6:26 PM Changeset in webkit [188242] by ggaren@apple.com

8 edits
3 copies in trunk/Source/JavaScriptCore

Start beating UnlinkedCodeBlock.h/.cpp with the "One Class per File" stick
https://bugs.webkit.org/show_bug.cgi?id=147856

Reviewed by Saam Barati.

Split out UnlinkedFunctionExecutable.h/.cpp and ExecutableInfo.h into separate files.

CMakeLists.txt:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/ExecutableInfo.h: Copied from Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h.

(JSC::ExecutableInfo::ExecutableInfo):
(JSC::UnlinkedStringJumpTable::offsetForValue): Deleted.
(JSC::UnlinkedSimpleJumpTable::add): Deleted.
(JSC::UnlinkedInstruction::UnlinkedInstruction): Deleted.
(JSC::UnlinkedCodeBlock::isConstructor): Deleted.
(JSC::UnlinkedCodeBlock::isStrictMode): Deleted.
(JSC::UnlinkedCodeBlock::usesEval): Deleted.
(JSC::UnlinkedCodeBlock::needsFullScopeChain): Deleted.
(JSC::UnlinkedCodeBlock::hasExpressionInfo): Deleted.
(JSC::UnlinkedCodeBlock::setThisRegister): Deleted.
(JSC::UnlinkedCodeBlock::setScopeRegister): Deleted.
(JSC::UnlinkedCodeBlock::setActivationRegister): Deleted.
(JSC::UnlinkedCodeBlock::usesGlobalObject): Deleted.
(JSC::UnlinkedCodeBlock::setGlobalObjectRegister): Deleted.
(JSC::UnlinkedCodeBlock::globalObjectRegister): Deleted.
(JSC::UnlinkedCodeBlock::setNumParameters): Deleted.
(JSC::UnlinkedCodeBlock::addParameter): Deleted.
(JSC::UnlinkedCodeBlock::numParameters): Deleted.
(JSC::UnlinkedCodeBlock::addRegExp): Deleted.
(JSC::UnlinkedCodeBlock::numberOfRegExps): Deleted.
(JSC::UnlinkedCodeBlock::regexp): Deleted.
(JSC::UnlinkedCodeBlock::numberOfIdentifiers): Deleted.
(JSC::UnlinkedCodeBlock::addIdentifier): Deleted.
(JSC::UnlinkedCodeBlock::identifier): Deleted.
(JSC::UnlinkedCodeBlock::identifiers): Deleted.
(JSC::UnlinkedCodeBlock::addConstant): Deleted.
(JSC::UnlinkedCodeBlock::registerIndexForLinkTimeConstant): Deleted.
(JSC::UnlinkedCodeBlock::constantRegisters): Deleted.
(JSC::UnlinkedCodeBlock::constantRegister): Deleted.
(JSC::UnlinkedCodeBlock::isConstantRegisterIndex): Deleted.
(JSC::UnlinkedCodeBlock::constantsSourceCodeRepresentation): Deleted.
(JSC::UnlinkedCodeBlock::numberOfJumpTargets): Deleted.
(JSC::UnlinkedCodeBlock::addJumpTarget): Deleted.
(JSC::UnlinkedCodeBlock::jumpTarget): Deleted.
(JSC::UnlinkedCodeBlock::lastJumpTarget): Deleted.
(JSC::UnlinkedCodeBlock::isBuiltinFunction): Deleted.
(JSC::UnlinkedCodeBlock::constructorKind): Deleted.
(JSC::UnlinkedCodeBlock::shrinkToFit): Deleted.
(JSC::UnlinkedCodeBlock::numberOfSwitchJumpTables): Deleted.
(JSC::UnlinkedCodeBlock::addSwitchJumpTable): Deleted.
(JSC::UnlinkedCodeBlock::switchJumpTable): Deleted.
(JSC::UnlinkedCodeBlock::numberOfStringSwitchJumpTables): Deleted.
(JSC::UnlinkedCodeBlock::addStringSwitchJumpTable): Deleted.
(JSC::UnlinkedCodeBlock::stringSwitchJumpTable): Deleted.
(JSC::UnlinkedCodeBlock::addFunctionDecl): Deleted.
(JSC::UnlinkedCodeBlock::functionDecl): Deleted.
(JSC::UnlinkedCodeBlock::numberOfFunctionDecls): Deleted.
(JSC::UnlinkedCodeBlock::addFunctionExpr): Deleted.
(JSC::UnlinkedCodeBlock::functionExpr): Deleted.
(JSC::UnlinkedCodeBlock::numberOfFunctionExprs): Deleted.
(JSC::UnlinkedCodeBlock::numberOfExceptionHandlers): Deleted.
(JSC::UnlinkedCodeBlock::addExceptionHandler): Deleted.
(JSC::UnlinkedCodeBlock::exceptionHandler): Deleted.
(JSC::UnlinkedCodeBlock::vm): Deleted.
(JSC::UnlinkedCodeBlock::addArrayProfile): Deleted.
(JSC::UnlinkedCodeBlock::numberOfArrayProfiles): Deleted.
(JSC::UnlinkedCodeBlock::addArrayAllocationProfile): Deleted.
(JSC::UnlinkedCodeBlock::numberOfArrayAllocationProfiles): Deleted.
(JSC::UnlinkedCodeBlock::addObjectAllocationProfile): Deleted.
(JSC::UnlinkedCodeBlock::numberOfObjectAllocationProfiles): Deleted.
(JSC::UnlinkedCodeBlock::addValueProfile): Deleted.
(JSC::UnlinkedCodeBlock::numberOfValueProfiles): Deleted.
(JSC::UnlinkedCodeBlock::addLLIntCallLinkInfo): Deleted.
(JSC::UnlinkedCodeBlock::numberOfLLintCallLinkInfos): Deleted.
(JSC::UnlinkedCodeBlock::codeType): Deleted.
(JSC::UnlinkedCodeBlock::thisRegister): Deleted.
(JSC::UnlinkedCodeBlock::scopeRegister): Deleted.
(JSC::UnlinkedCodeBlock::activationRegister): Deleted.
(JSC::UnlinkedCodeBlock::hasActivationRegister): Deleted.
(JSC::UnlinkedCodeBlock::addPropertyAccessInstruction): Deleted.
(JSC::UnlinkedCodeBlock::numberOfPropertyAccessInstructions): Deleted.
(JSC::UnlinkedCodeBlock::propertyAccessInstructions): Deleted.
(JSC::UnlinkedCodeBlock::constantBufferCount): Deleted.
(JSC::UnlinkedCodeBlock::addConstantBuffer): Deleted.
(JSC::UnlinkedCodeBlock::constantBuffer): Deleted.
(JSC::UnlinkedCodeBlock::hasRareData): Deleted.
(JSC::UnlinkedCodeBlock::recordParse): Deleted.
(JSC::UnlinkedCodeBlock::codeFeatures): Deleted.
(JSC::UnlinkedCodeBlock::hasCapturedVariables): Deleted.
(JSC::UnlinkedCodeBlock::firstLine): Deleted.
(JSC::UnlinkedCodeBlock::lineCount): Deleted.
(JSC::UnlinkedCodeBlock::startColumn): Deleted.
(JSC::UnlinkedCodeBlock::endColumn): Deleted.
(JSC::UnlinkedCodeBlock::addOpProfileControlFlowBytecodeOffset): Deleted.
(JSC::UnlinkedCodeBlock::opProfileControlFlowBytecodeOffsets): Deleted.
(JSC::UnlinkedCodeBlock::finishCreation): Deleted.
(JSC::UnlinkedCodeBlock::createRareDataIfNecessary): Deleted.
(JSC::UnlinkedGlobalCodeBlock::UnlinkedGlobalCodeBlock): Deleted.

bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
(JSC::generateFunctionCodeBlock): Deleted.
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable): Deleted.
(JSC::UnlinkedFunctionExecutable::visitChildren): Deleted.
(JSC::UnlinkedFunctionExecutable::link): Deleted.
(JSC::UnlinkedFunctionExecutable::fromGlobalCode): Deleted.
(JSC::UnlinkedFunctionExecutable::codeBlockFor): Deleted.

bytecode/UnlinkedCodeBlock.h:

bytecode/UnlinkedFunctionExecutable.cpp: Copied from Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp.

(JSC::generateFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::codeBlockFor):
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock): Deleted.
(JSC::UnlinkedCodeBlock::visitChildren): Deleted.
(JSC::UnlinkedCodeBlock::lineNumberForBytecodeOffset): Deleted.
(JSC::UnlinkedCodeBlock::getLineAndColumn): Deleted.
(JSC::dumpLineColumnEntry): Deleted.
(JSC::UnlinkedCodeBlock::dumpExpressionRangeInfo): Deleted.
(JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset): Deleted.
(JSC::UnlinkedCodeBlock::addExpressionInfo): Deleted.
(JSC::UnlinkedCodeBlock::typeProfilerExpressionInfoForBytecodeOffset): Deleted.
(JSC::UnlinkedCodeBlock::addTypeProfilerExpressionInfo): Deleted.
(JSC::UnlinkedProgramCodeBlock::visitChildren): Deleted.
(JSC::UnlinkedCodeBlock::~UnlinkedCodeBlock): Deleted.
(JSC::UnlinkedProgramCodeBlock::destroy): Deleted.
(JSC::UnlinkedEvalCodeBlock::destroy): Deleted.
(JSC::UnlinkedFunctionCodeBlock::destroy): Deleted.
(JSC::UnlinkedFunctionExecutable::destroy): Deleted.
(JSC::UnlinkedCodeBlock::setInstructions): Deleted.
(JSC::UnlinkedCodeBlock::instructions): Deleted.

bytecode/UnlinkedFunctionExecutable.h: Copied from Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h.

(JSC::ExecutableInfo::ExecutableInfo): Deleted.
(JSC::ExecutableInfo::needsActivation): Deleted.
(JSC::ExecutableInfo::usesEval): Deleted.
(JSC::ExecutableInfo::isStrictMode): Deleted.
(JSC::ExecutableInfo::isConstructor): Deleted.
(JSC::ExecutableInfo::isBuiltinFunction): Deleted.
(JSC::ExecutableInfo::constructorKind): Deleted.
(JSC::UnlinkedStringJumpTable::offsetForValue): Deleted.
(JSC::UnlinkedSimpleJumpTable::add): Deleted.
(JSC::UnlinkedInstruction::UnlinkedInstruction): Deleted.
(JSC::UnlinkedCodeBlock::isConstructor): Deleted.
(JSC::UnlinkedCodeBlock::isStrictMode): Deleted.
(JSC::UnlinkedCodeBlock::usesEval): Deleted.
(JSC::UnlinkedCodeBlock::needsFullScopeChain): Deleted.
(JSC::UnlinkedCodeBlock::hasExpressionInfo): Deleted.
(JSC::UnlinkedCodeBlock::setThisRegister): Deleted.
(JSC::UnlinkedCodeBlock::setScopeRegister): Deleted.
(JSC::UnlinkedCodeBlock::setActivationRegister): Deleted.
(JSC::UnlinkedCodeBlock::usesGlobalObject): Deleted.
(JSC::UnlinkedCodeBlock::setGlobalObjectRegister): Deleted.
(JSC::UnlinkedCodeBlock::globalObjectRegister): Deleted.
(JSC::UnlinkedCodeBlock::setNumParameters): Deleted.
(JSC::UnlinkedCodeBlock::addParameter): Deleted.
(JSC::UnlinkedCodeBlock::numParameters): Deleted.
(JSC::UnlinkedCodeBlock::addRegExp): Deleted.
(JSC::UnlinkedCodeBlock::numberOfRegExps): Deleted.
(JSC::UnlinkedCodeBlock::regexp): Deleted.
(JSC::UnlinkedCodeBlock::numberOfIdentifiers): Deleted.
(JSC::UnlinkedCodeBlock::addIdentifier): Deleted.
(JSC::UnlinkedCodeBlock::identifier): Deleted.
(JSC::UnlinkedCodeBlock::identifiers): Deleted.
(JSC::UnlinkedCodeBlock::addConstant): Deleted.
(JSC::UnlinkedCodeBlock::registerIndexForLinkTimeConstant): Deleted.
(JSC::UnlinkedCodeBlock::constantRegisters): Deleted.
(JSC::UnlinkedCodeBlock::constantRegister): Deleted.
(JSC::UnlinkedCodeBlock::isConstantRegisterIndex): Deleted.
(JSC::UnlinkedCodeBlock::constantsSourceCodeRepresentation): Deleted.
(JSC::UnlinkedCodeBlock::numberOfJumpTargets): Deleted.
(JSC::UnlinkedCodeBlock::addJumpTarget): Deleted.
(JSC::UnlinkedCodeBlock::jumpTarget): Deleted.
(JSC::UnlinkedCodeBlock::lastJumpTarget): Deleted.
(JSC::UnlinkedCodeBlock::isBuiltinFunction): Deleted.
(JSC::UnlinkedCodeBlock::constructorKind): Deleted.
(JSC::UnlinkedCodeBlock::shrinkToFit): Deleted.
(JSC::UnlinkedCodeBlock::numberOfSwitchJumpTables): Deleted.
(JSC::UnlinkedCodeBlock::addSwitchJumpTable): Deleted.
(JSC::UnlinkedCodeBlock::switchJumpTable): Deleted.
(JSC::UnlinkedCodeBlock::numberOfStringSwitchJumpTables): Deleted.
(JSC::UnlinkedCodeBlock::addStringSwitchJumpTable): Deleted.
(JSC::UnlinkedCodeBlock::stringSwitchJumpTable): Deleted.
(JSC::UnlinkedCodeBlock::addFunctionDecl): Deleted.
(JSC::UnlinkedCodeBlock::functionDecl): Deleted.
(JSC::UnlinkedCodeBlock::numberOfFunctionDecls): Deleted.
(JSC::UnlinkedCodeBlock::addFunctionExpr): Deleted.
(JSC::UnlinkedCodeBlock::functionExpr): Deleted.
(JSC::UnlinkedCodeBlock::numberOfFunctionExprs): Deleted.
(JSC::UnlinkedCodeBlock::numberOfExceptionHandlers): Deleted.
(JSC::UnlinkedCodeBlock::addExceptionHandler): Deleted.
(JSC::UnlinkedCodeBlock::exceptionHandler): Deleted.
(JSC::UnlinkedCodeBlock::vm): Deleted.
(JSC::UnlinkedCodeBlock::addArrayProfile): Deleted.
(JSC::UnlinkedCodeBlock::numberOfArrayProfiles): Deleted.
(JSC::UnlinkedCodeBlock::addArrayAllocationProfile): Deleted.
(JSC::UnlinkedCodeBlock::numberOfArrayAllocationProfiles): Deleted.
(JSC::UnlinkedCodeBlock::addObjectAllocationProfile): Deleted.
(JSC::UnlinkedCodeBlock::numberOfObjectAllocationProfiles): Deleted.
(JSC::UnlinkedCodeBlock::addValueProfile): Deleted.
(JSC::UnlinkedCodeBlock::numberOfValueProfiles): Deleted.
(JSC::UnlinkedCodeBlock::addLLIntCallLinkInfo): Deleted.
(JSC::UnlinkedCodeBlock::numberOfLLintCallLinkInfos): Deleted.
(JSC::UnlinkedCodeBlock::codeType): Deleted.
(JSC::UnlinkedCodeBlock::thisRegister): Deleted.
(JSC::UnlinkedCodeBlock::scopeRegister): Deleted.
(JSC::UnlinkedCodeBlock::activationRegister): Deleted.
(JSC::UnlinkedCodeBlock::hasActivationRegister): Deleted.
(JSC::UnlinkedCodeBlock::addPropertyAccessInstruction): Deleted.
(JSC::UnlinkedCodeBlock::numberOfPropertyAccessInstructions): Deleted.
(JSC::UnlinkedCodeBlock::propertyAccessInstructions): Deleted.
(JSC::UnlinkedCodeBlock::constantBufferCount): Deleted.
(JSC::UnlinkedCodeBlock::addConstantBuffer): Deleted.
(JSC::UnlinkedCodeBlock::constantBuffer): Deleted.
(JSC::UnlinkedCodeBlock::hasRareData): Deleted.
(JSC::UnlinkedCodeBlock::recordParse): Deleted.
(JSC::UnlinkedCodeBlock::codeFeatures): Deleted.
(JSC::UnlinkedCodeBlock::hasCapturedVariables): Deleted.
(JSC::UnlinkedCodeBlock::firstLine): Deleted.
(JSC::UnlinkedCodeBlock::lineCount): Deleted.
(JSC::UnlinkedCodeBlock::startColumn): Deleted.
(JSC::UnlinkedCodeBlock::endColumn): Deleted.
(JSC::UnlinkedCodeBlock::addOpProfileControlFlowBytecodeOffset): Deleted.
(JSC::UnlinkedCodeBlock::opProfileControlFlowBytecodeOffsets): Deleted.
(JSC::UnlinkedCodeBlock::finishCreation): Deleted.
(JSC::UnlinkedCodeBlock::createRareDataIfNecessary): Deleted.
(JSC::UnlinkedGlobalCodeBlock::UnlinkedGlobalCodeBlock): Deleted.

runtime/Executable.h:

6:11 PM Changeset in webkit [188241] by bshafiei@apple.com

1 copy in tags/Safari-601.1.49

New tag.

5:38 PM Changeset in webkit [188240] by bshafiei@apple.com

1 copy in tags/Safari-601.1.46.7

New tag.

5:09 PM Changeset in webkit [188239] by achristensen@apple.com

16 edits
1 add in trunk

Build TestWebKitAPI with CMake on Windows
https://bugs.webkit.org/show_bug.cgi?id=147851

Reviewed by Chris Dumez.

Source/cmake/OptionsWindows.cmake:

Enable api tests and set USE_SYSTEM_MALLOC to avoid warnings when redefining it.

Source/ThirdParty:

gtest/CMakeLists.txt:

Include DerivedSources to find WTF/WTFHeaderDetection.h.

Source/WebCore:

PlatformWin.cmake:

Remove RenderThemeWin.cpp which is included in RenderingAllInOne.cpp.

WebCorePrefix.h:

Include cmakeconfig.h before wtf/Platform.h like we do in JavaScriptCore's config.h to avoid warnings and redefining ENABLE_* macros.

Source/WebKit:

PlatformWin.cmake:

WinCairo libraries conflict with LIBCMT.lib, AppleWin libraries conflict with MSVCRT.lib,
so different /NODEFAULTLIB is needed to link WebKit.dll successfully.

Tools:

CMakeLists.txt:
TestWebKitAPI/CMakeLists.txt:

Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary.
Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks.
Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win
before we look in Source/WebCore/platform, where another file named HostWindow.h exists.

TestWebKitAPI/PlatformEfl.cmake:
TestWebKitAPI/PlatformGTK.cmake:

Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls.
I did this without changing the directory structure of the existing EFL and GTK builds.

TestWebKitAPI/PlatformWin.cmake: Added.
TestWebKitAPI/win/main.cpp:

(main):
(dllLauncherEntryPoint):
Added so we can launch TestWebKitAPI executables after finding the AAS directory.

WinLauncher/CMakeLists.txt:

AppleWin port needs /NODEFAULTLIB:MSVCRT.

4:56 PM Changeset in webkit [188238] by Devin Rousso

1 edit
8 adds in trunk/Source/WebInspectorUI

Web Inspector: Add numerical input and slider based Visual editors for CSS properties
https://bugs.webkit.org/show_bug.cgi?id=147712

Reviewed by Brian Burg.

Added editors for CSS properties with numerical values for use in the Visual style
details panel in the CSS sidebar, in the form of a combined select and input or an
input range. Also added optional visual linkages to sync values between multiple
editors of this type.

UserInterface/Images/VisualStylePropertyLinked.svg: Added.
UserInterface/Images/VisualStylePropertyUnlinked.svg: Added.

UserInterface/Views/VisualStyleNumberInputBox.css: Added.

(.visual-style-property-container > .visual-style-property-value-container.focused > .focus-ring):
(.visual-style-property-container > .visual-style-property-value-container > .number-input-keyword-select):
(.visual-style-property-container > .visual-style-property-value-container > .number-input-container):
(.visual-style-property-container > .visual-style-property-value-container:not(.number-input-editable) > .number-input-container):
(.visual-style-property-container > .visual-style-property-value-container > .number-input-container > .number-input-value):
(.visual-style-property-container > .visual-style-property-value-container > .number-input-container > span):

UserInterface/Views/VisualStyleNumberInputBox.js: Added.

(WebInspector.VisualStyleNumberInputBox):
(WebInspector.VisualStyleNumberInputBox.prototype.get value):
(WebInspector.VisualStyleNumberInputBox.prototype.set value):
(WebInspector.VisualStyleNumberInputBox.prototype.get units):
(WebInspector.VisualStyleNumberInputBox.prototype.set units):
(WebInspector.VisualStyleNumberInputBox.prototype.get placeholder):
(WebInspector.VisualStyleNumberInputBox.prototype.set placeholder):
(WebInspector.VisualStyleNumberInputBox.prototype.get synthesizedValue):
(WebInspector.VisualStyleNumberInputBox.prototype.get numberInputEditable):
(WebInspector.VisualStyleNumberInputBox.prototype.updateValueFromText):
(WebInspector.VisualStyleNumberInputBox.prototype.parseValue):
(WebInspector.VisualStyleNumberInputBox.prototype._keywordChanged):
(WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown.shiftValue):
(WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown):
(WebInspector.VisualStyleNumberInputBox.prototype._numberInputChanged):
(WebInspector.VisualStyleNumberInputBox.prototype._keywordSelectMouseDown):
(WebInspector.VisualStyleNumberInputBox.prototype._createValueOptions):
(WebInspector.VisualStyleNumberInputBox.prototype._createUnitOptions):
(WebInspector.VisualStyleNumberInputBox.prototype._addAdvancedUnits):
(WebInspector.VisualStyleNumberInputBox.prototype._removeAdvancedUnits):
(WebInspector.VisualStyleNumberInputBox.prototype._focusContentElement):
(WebInspector.VisualStyleNumberInputBox.prototype._blurContentElement):
(WebInspector.VisualStyleNumberInputBox.prototype._toggleTabbingOfSelectableElements):

UserInterface/Views/VisualStylePropertyEditorLink.css: Added.

(.visual-style-property-editor-link):
(.visual-style-property-editor-link.disabled):
(.visual-style-property-editor-link.link-all):
(.visual-style-property-editor-link.link-all.linked):
(.visual-style-property-editor-link > .visual-style-property-editor-link-border):
(.visual-style-property-editor-link.link-all.linked > .visual-style-property-editor-link-icon:hover + .visual-style-property-editor-link-border.right):
(.visual-style-property-editor-link.link-all.linked > .visual-style-property-editor-link-border.left):
(.visual-style-property-editor-link.link-all.linked > .visual-style-property-editor-link-border.right):
(.visual-style-property-editor-link.linked > .visual-style-property-editor-link-border):
(.visual-style-property-editor-link > .visual-style-property-editor-link-border.left):
(.visual-style-property-editor-link > .visual-style-property-editor-link-border.right):
(.visual-style-property-editor-link:not(.link-all) > .visual-style-property-editor-link-border):
(.visual-style-property-editor-link:not(.link-all).linked > .visual-style-property-editor-link-border):
(.visual-style-property-editor-link > .visual-style-property-editor-link-icon):
(.visual-style-property-editor-link > .visual-style-property-editor-link-icon > .unlinked-icon):
(.visual-style-property-editor-link > .visual-style-property-editor-link-icon > .unlinked-icon svg .filled):
(.visual-style-property-editor-link > .visual-style-property-editor-link-icon > .unlinked-icon svg .stroked):
(.visual-style-property-editor-link:not(.link-all) > .visual-style-property-editor-link-icon):
(.visual-style-property-editor-link.link-all > .visual-style-property-editor-link-icon):

UserInterface/Views/VisualStylePropertyEditorLink.js: Added.

(WebInspector.VisualStylePropertyEditorLink):
(WebInspector.VisualStylePropertyEditorLink.prototype.get element):
(WebInspector.VisualStylePropertyEditorLink.prototype.set disabled):
(WebInspector.VisualStylePropertyEditorLink.prototype._linkedPropertyValueChanged):
(WebInspector.VisualStylePropertyEditorLink.prototype._updateLinkedEditors):
(WebInspector.VisualStylePropertyEditorLink.prototype._iconMouseover):
(WebInspector.VisualStylePropertyEditorLink.prototype._iconMouseout):
(WebInspector.VisualStylePropertyEditorLink.prototype._iconClicked):

UserInterface/Views/VisualStyleRelativeNumberSlider.css: Added.

(.visual-style-property-container.number-input-box.relative-number-slider > .visual-style-property-title):
(.visual-style-property-container.number-input-box.relative-number-slider > .visual-style-property-value-container):
(.visual-style-property-container.number-input-box.relative-number-slider.disabled > .relative-slider):
(.visual-style-property-container.number-input-box.relative-number-slider > .visual-style-property-value-container.no-values.no-units):
(.visual-style-property-container.number-input-box.relative-number-slider > .relative-slider):

UserInterface/Views/VisualStyleRelativeNumberSlider.js: Added.

(WebInspector.VisualStyleRelativeNumberSlider):
(WebInspector.VisualStyleRelativeNumberSlider.prototype.set scale):
(WebInspector.VisualStyleRelativeNumberSlider.prototype.updateEditorValues):
(WebInspector.VisualStyleRelativeNumberSlider.prototype._resetSlider):
(WebInspector.VisualStyleRelativeNumberSlider.prototype._sliderChanged):
(WebInspector.VisualStyleRelativeNumberSlider.prototype._numberInputChanged):

4:44 PM Changeset in webkit [188237] by commit-queue@webkit.org

5 edits in trunk/Tools

Make cleanup more robust and minor code cleaning in run benchmark script.
https://bugs.webkit.org/show_bug.cgi?id=147800

Patch by Dewei Zhu <Dewei Zhu> on 2015-08-10
Reviewed by Ryosuke Niwa.

Use 'finnaly' block to make sure cleanup code is always executed.

Scripts/webkitpy/benchmark_runner/benchmark_runner.py:

(built_benchmark):
(built_benchmark.init):
(built_benchmark.enter):
(built_benchmark.exit):
(test_environment):
(test_environment.init):
(test_environment.enter):
(test_environment.exit):
(BenchmarkRunner.init):
(BenchmarkRunner.execute):
(BenchmarkRunner._dump):
(BenchmarkRunner._wrap):
(BenchmarkRunner): Deleted.
(BenchmarkRunner._cleanup): Deleted.

Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:

(BrowserDriver.close_browsers):
(BrowserDriver):
(BrowserDriver.restore_env):

Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:

(SimpleHTTPServerDriver.init): We do not actually need to know external ip address for now.

4:40 PM Changeset in webkit [188236] by mdaiter@apple.com

2 edits in trunk/Source/WebKit2

Add MediaDeviceIdentifier to WebsiteDataTypes
https://bugs.webkit.org/show_bug.cgi?id=147853

Reviewed by Jer Noble.

Shared/WebsiteData/WebsiteDataTypes.h:

4:33 PM Changeset in webkit [188235] by bshafiei@apple.com

2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merged r188223. rdar://problem/21465328

4:27 PM Changeset in webkit [188234] by mdaiter@apple.com

5 edits in trunk/Source/WebCore

HTMLMediaElement needs way to find MediaDeviceInfo
https://bugs.webkit.org/show_bug.cgi?id=147842

Reviewed by Jer Noble.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerMediaDeviceIdentifierStorageDirectory):

html/HTMLMediaElement.h:
page/Settings.h:

(WebCore::Settings::setMediaDeviceIdentifierStorageDirectory):
(WebCore::Settings::mediaDeviceIdentifierStorageDirectory):

platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerMediaDeviceIdentifierStorageDirectory):

3:58 PM Changeset in webkit [188233] by Chris Dumez

4 edits in trunk/Source/WebCore

Simplify code for making Page-cacheability decision
https://bugs.webkit.org/show_bug.cgi?id=147829

Reviewed by Antti Koivisto.

Simplify code for making Page-cacheability decision by merging logging
code and decision making code. Having the same checks in two places was
redundant and error-prone as we needed to keep them in sync.

Also get rid of failure reason enum values as those have not been used
in a while.

history/PageCache.cpp:

(WebCore::canCacheFrame):
(WebCore::canCachePage):
(WebCore::PageCache::canCache):
(WebCore::logPageCacheFailureDiagnosticMessage): Deleted.
(WebCore::PageCache::singleton): Deleted.
(WebCore::PageCache::setMaxSize): Deleted.
(WebCore::PageCache::frameCount): Deleted.
(WebCore::PageCache::markPagesForVisitedLinkStyleRecalc): Deleted.
(WebCore::PageCache::markPagesForFullStyleRecalc): Deleted.
(WebCore::PageCache::markPagesForDeviceOrPageScaleChanged): Deleted.
(WebCore::PageCache::markPagesForContentsSizeChanged): Deleted.
(WebCore::PageCache::markPagesForCaptionPreferencesChanged): Deleted.
(WebCore::pruningReasonToDiagnosticLoggingKey): Deleted.

page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::isDisabledKey):
(WebCore::DiagnosticLoggingKeys::redirectKey):
(WebCore::DiagnosticLoggingKeys::replaceKey):
(WebCore::DiagnosticLoggingKeys::sourceKey):
(WebCore::DiagnosticLoggingKeys::underMemoryPressureKey):
(WebCore::DiagnosticLoggingKeys::reloadFromOriginKey): Deleted.

page/DiagnosticLoggingKeys.h:

3:09 PM Changeset in webkit [188232] by weinig@apple.com

2 edits in trunk/Source/WebKit2

Try to fix the 32-bit build.

UIProcess/API/mac/WKViewInternal.h:

2:54 PM Changeset in webkit [188231] by mark.lam@apple.com

7 edits
3 adds in trunk/Source/JavaScriptCore

Refactor LiveObjectList and LiveObjectData into their own files.
https://bugs.webkit.org/show_bug.cgi?id=147843

Reviewed by Saam Barati.

There is no behavior change in this patch.

CMakeLists.txt:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
heap/HeapVerifier.cpp:

(JSC::HeapVerifier::HeapVerifier):
(JSC::LiveObjectList::findObject): Deleted.

heap/HeapVerifier.h:

(JSC::LiveObjectData::LiveObjectData): Deleted.
(JSC::LiveObjectList::LiveObjectList): Deleted.
(JSC::LiveObjectList::reset): Deleted.

heap/LiveObjectData.h: Added.

(JSC::LiveObjectData::LiveObjectData):

heap/LiveObjectList.cpp: Added.

(JSC::LiveObjectList::findObject):

heap/LiveObjectList.h: Added.

(JSC::LiveObjectList::LiveObjectList):
(JSC::LiveObjectList::reset):

2:35 PM Changeset in webkit [188230] by dburkart@apple.com

5 edits in trunk/Websites/test-results

Fix flakiness dashboard stability and performance issues.
https://bugs.webkit.org/show_bug.cgi?id=147835

Reviewed by Ryosuke Niwa.

init-database.sql:
public/.htaccess:
public/include/json-shared.php:
public/include/test-results.php:

1:56 PM Changeset in webkit [188229] by Devin Rousso

3 edits
30 adds in trunk/Source/WebInspectorUI

Web Inspector: Add different types of non-numerical Visual editors for CSS properties
https://bugs.webkit.org/show_bug.cgi?id=147711

Added editors for keyword based CSS properties for use in the Visual style
details panel in the CSS sidebar. Also added images for keyword values that
are simple enough to be conveyed in an image.

Reviewed by Brian Burg.

UserInterface/Images/ClearBoth.svg: Added.
UserInterface/Images/ClearLeft.svg: Added.
UserInterface/Images/ClearRight.svg: Added.
UserInterface/Images/FloatLeft.svg: Added.
UserInterface/Images/FloatRight.svg: Added.
UserInterface/Images/FontStyleItalic.svg: Added.
UserInterface/Images/FontStyleNormal.svg: Added.
UserInterface/Images/FontVariantSmallCaps.svg: Added.
UserInterface/Images/TextAlignCenter.svg: Added.
UserInterface/Images/TextAlignJustify.svg: Added.
UserInterface/Images/TextAlignLeft.svg: Added.
UserInterface/Images/TextAlignRight.svg: Added.
UserInterface/Images/TextDecorationLineThrough.svg: Added.
UserInterface/Images/TextDecorationOverline.svg: Added.
UserInterface/Images/TextDecorationUnderline.svg: Added.
UserInterface/Images/TextTransformCapitalize.svg: Added.
UserInterface/Images/TextTransformLowercase.svg: Added.
UserInterface/Images/TextTransformUppercase.svg: Added.
UserInterface/Images/VisualStyleNone.svg: Added.
UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
Changed color swatch title.

UserInterface/Views/Slider.js:

(WebInspector.Slider):
(WebInspector.Slider.prototype.set value):
(WebInspector.Slider.prototype.set knobX):
(WebInspector.Slider.prototype.get maxX):
If the given value is below 0, reset it to 0.
(WebInspector.Slider.prototype._handleMousedown):
(WebInspector.Slider.prototype._handleMousemove):
(WebInspector.Slider.prototype.get _maxX): Deleted.

UserInterface/Views/VisualStyleColorPicker.css: Added.

(.visual-style-property-container.input-color-picker > .visual-style-property-value-container):
(.visual-style-property-container.input-color-picker > .visual-style-property-value-container > .visual-style-special-property-placeholder):
(.visual-style-property-container.input-color-picker > .visual-style-property-value-container > .color-swatch):
(.visual-style-property-container.input-color-picker > .visual-style-property-value-container > .color-swatch:hover):
(.visual-style-property-container.input-color-picker > .visual-style-property-value-container > .color-swatch:active):
(.visual-style-property-container.input-color-picker > .visual-style-property-value-container > .color-swatch > span):
(.visual-style-property-container.input-color-picker > .visual-style-property-value-container > input):
(.visual-style-property-container.input-color-picker.multiple > .visual-style-property-value-container > .visual-style-multiple-property-placeholder):

UserInterface/Views/VisualStyleColorPicker.js: Added.

(WebInspector.VisualStyleColorPicker):
(WebInspector.VisualStyleColorPicker.prototype.get value):
(WebInspector.VisualStyleColorPicker.prototype.set value):
(WebInspector.VisualStyleColorPicker.prototype.get placeholder):
(WebInspector.VisualStyleColorPicker.prototype.set placeholder):
(WebInspector.VisualStyleColorPicker.prototype.get synthesizedValue):
(WebInspector.VisualStyleColorPicker.prototype.get hasCompletions):
(WebInspector.VisualStyleColorPicker.prototype.set completions):
(WebInspector.VisualStyleColorPicker.prototype._updateColorSwatch):
(WebInspector.VisualStyleColorPicker.prototype._colorSwatchClicked):
(WebInspector.VisualStyleColorPicker.prototype._colorPickerColorDidChange):
(WebInspector.VisualStyleColorPicker.prototype._completionClicked):
(WebInspector.VisualStyleColorPicker.prototype._textInputKeyDown):
(WebInspector.VisualStyleColorPicker.prototype._textInputKeyUp):
(WebInspector.VisualStyleColorPicker.prototype._showCompletionsIfAble):
(WebInspector.VisualStyleColorPicker.prototype._hideCompletions):
(WebInspector.VisualStyleColorPicker.prototype._toggleTabbingOfSelectableElements):

UserInterface/Views/VisualStyleKeywordCheckbox.css: Added.

(.visual-style-property-container.keyword-checkbox > .visual-style-property-value-container):
(.visual-style-property-container.keyword-checkbox > .visual-style-property-value-container > input):
(.visual-style-property-container.keyword-checkbox > .visual-style-property-value-container > div):

UserInterface/Views/VisualStyleKeywordCheckbox.js: Added.

(WebInspector.VisualStyleKeywordCheckbox):
(WebInspector.VisualStyleKeywordCheckbox.prototype.get value):
(WebInspector.VisualStyleKeywordCheckbox.prototype.set value):
(WebInspector.VisualStyleKeywordCheckbox.prototype.get synthesizedValue):
(WebInspector.VisualStyleKeywordCheckbox.prototype._toggleTabbingOfSelectableElements):

UserInterface/Views/VisualStyleKeywordIconList.css: Added.

(.visual-style-property-container.keyword-icon-list > .visual-style-property-value-container):
(.visual-style-property-container.keyword-icon-list > .visual-style-property-value-container > .keyword-icon-list-container):
(.visual-style-property-container.keyword-icon-list > .visual-style-property-value-container > .keyword-icon-list-container > .keyword-icon):
(.visual-style-property-container.keyword-icon-list > .visual-style-property-value-container > .keyword-icon-list-container > .keyword-icon:first-child):
(.visual-style-property-container.keyword-icon-list > .visual-style-property-value-container > .keyword-icon-list-container > .keyword-icon:last-child):
(.visual-style-property-container.keyword-icon-list > .visual-style-property-value-container > .keyword-icon-list-container > .keyword-icon:matches(.computed, .selected)):
(.visual-style-property-container.keyword-icon-list > .visual-style-property-value-container > .keyword-icon-list-container > .keyword-icon.selected):
(.visual-style-property-container.keyword-icon-list > .visual-style-property-value-container > .keyword-icon-list-container > .keyword-icon.selected svg .stroked):
(.visual-style-property-container.keyword-icon-list > .visual-style-property-value-container > .keyword-icon-list-container > .keyword-icon.selected svg .filled):
(.visual-style-property-container.keyword-icon-list > .visual-style-property-value-container > .keyword-icon-list-container > .keyword-icon:matches(.computed, .selected) + .keyword-icon):
(.visual-style-property-container.keyword-icon-list > .visual-style-property-value-container > .keyword-icon-list-container > .keyword-icon > div):
(.visual-style-property-container.keyword-icon-list > .visual-style-property-value-container > .keyword-icon-list-container > .keyword-icon:not(.selected) > div):

UserInterface/Views/VisualStyleKeywordIconList.js: Added.

(WebInspector.VisualStyleKeywordIconList.dashToCapital):
(WebInspector.VisualStyleKeywordIconList.createListItem):
(WebInspector.VisualStyleKeywordIconList):
(WebInspector.VisualStyleKeywordIconList.prototype.get value):
(WebInspector.VisualStyleKeywordIconList.prototype.set value):
(WebInspector.VisualStyleKeywordIconList.prototype.get synthesizedValue):
(WebInspector.VisualStyleKeywordIconList.prototype._handleKeywordChanged):

UserInterface/Views/VisualStyleKeywordPicker.js: Added.

(WebInspector.VisualStyleKeywordPicker):
(WebInspector.VisualStyleKeywordPicker.prototype.get value):
(WebInspector.VisualStyleKeywordPicker.prototype.set value):
(WebInspector.VisualStyleKeywordPicker.prototype.set placeholder):
(WebInspector.VisualStyleKeywordPicker.prototype.get synthesizedValue):
(WebInspector.VisualStyleKeywordPicker.prototype.updateEditorValues):
(WebInspector.VisualStyleKeywordPicker.prototype._handleKeywordChanged):
(WebInspector.VisualStyleKeywordPicker.prototype._keywordSelectMouseDown):
(WebInspector.VisualStyleKeywordPicker.prototype._addValues):
(WebInspector.VisualStyleKeywordPicker.prototype._addAdvancedValues):
(WebInspector.VisualStyleKeywordPicker.prototype._removeAdvancedValues):
(WebInspector.VisualStyleKeywordPicker.prototype._toggleTabbingOfSelectableElements):

UserInterface/Views/VisualStylePropertyNameInput.js: Added.

(WebInspector.VisualStylePropertyNameInput):
(WebInspector.VisualStylePropertyNameInput.prototype.get value):
(WebInspector.VisualStylePropertyNameInput.prototype.set value):
(WebInspector.VisualStylePropertyNameInput.prototype.get synthesizedValue):
(WebInspector.VisualStylePropertyNameInput.prototype.get hasCompletions):
(WebInspector.VisualStylePropertyNameInput.prototype.set completions):
(WebInspector.VisualStylePropertyNameInput.prototype._completionClicked):
(WebInspector.VisualStylePropertyNameInput.prototype._inputKeyDown):
(WebInspector.VisualStylePropertyNameInput.prototype._inputKeyUp):
(WebInspector.VisualStylePropertyNameInput.prototype._hideCompletions):
(WebInspector.VisualStylePropertyNameInput.prototype._toggleTabbingOfSelectableElements):

UserInterface/Views/VisualStyleURLInput.js: Added.

(WebInspector.VisualStyleURLInput):
(WebInspector.VisualStyleURLInput.prototype.set get value):
(WebInspector.VisualStyleURLInput.prototype.parseValue):

UserInterface/Views/VisualStyleUnitSlider.css: Added.

(.visual-style-property-container.unit-slider > .visual-style-property-value-container > .slider):
(.visual-style-property-container.unit-slider > .visual-style-property-value-container > .slider > img):
(.visual-style-property-container.unit-slider.opacity > .visual-style-property-value-container > .slider):

UserInterface/Views/VisualStyleUnitSlider.js: Added.

(WebInspector.VisualStyleUnitSlider):
(WebInspector.VisualStyleUnitSlider.prototype.set value):
(WebInspector.VisualStyleUnitSlider.prototype.get value):
(WebInspector.VisualStyleUnitSlider.prototype.get synthesizedValue):
(WebInspector.VisualStyleUnitSlider.prototype.sliderValueDidChange):

1:51 PM Changeset in webkit [188228] by weinig@apple.com

26 edits in trunk/Source/WebKit2

Replace WebPageConfiguration with API::PageConfiguration and expose a C-SPI accessor for it
https://bugs.webkit.org/show_bug.cgi?id=147811

Reviewed by Darin Adler.

Adds the missing pieces from WebPageConfiguration into API::PageConfiguration.
Adds C-SPI to set and get the WebsiteDataStore on the WKPageConfigurationRef.
Uses API::PageConfiguration to pass configuration information from WKWebView/WKView to WebPageProxy.
Stores the API::PageConfiguration on the WebPageProxy and exposes a new C-SPI function, WKPageCopyPageConfiguration, to get a copy of it.

UIProcess/API/APIPageConfiguration.cpp:

(API::PageConfiguration::create):
(API::PageConfiguration::PageConfiguration):
(API::PageConfiguration::~PageConfiguration):
(API::PageConfiguration::copy):
(API::PageConfiguration::processPool):
(API::PageConfiguration::setRelatedPage):
(API::PageConfiguration::visitedLinkProvider):
(API::PageConfiguration::setVisitedLinkProvider):
(API::PageConfiguration::websiteDataStore):
(API::PageConfiguration::setWebsiteDataStore):
(API::PageConfiguration::sessionID):
(API::PageConfiguration::setSessionID):
(API::PageConfiguration::webPageConfiguration): Deleted.

UIProcess/API/APIPageConfiguration.h:

(API::PageConfiguration::preferenceValues):
(API::PageConfiguration::treatsSHA1SignedCertificatesAsInsecure):
(API::PageConfiguration::setTreatsSHA1SignedCertificatesAsInsecure):
(API::PageConfiguration::alwaysRunsAtForegroundPriority):
(API::PageConfiguration::setAlwaysRunsAtForegroundPriority):
(API::PageConfiguration::create): Deleted.

UIProcess/API/C/WKPage.cpp:

(WKPageGetPageGroup):
(WKPageCopyPageConfiguration):
(WKPageLoadURL):

UIProcess/API/C/WKPage.h:
UIProcess/API/C/WKPageConfigurationRef.cpp:

(WKPageConfigurationSetRelatedPage):
(WKPageConfigurationGetWebsiteDataStore):
(WKPageConfigurationSetWebsiteDataStore):

UIProcess/API/C/WKPageConfigurationRef.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):

UIProcess/API/ios/WKViewIOS.mm:

(-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

UIProcess/API/mac/WKView.mm:

(-[WKView _setPrimaryTrackingArea:]):
(-[WKView initWithFrame:processPool:configuration:webView:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
(-[WKView initWithFrame:configurationRef:]):
(-[WKView wantsUpdateLayer]):

UIProcess/API/mac/WKViewInternal.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::~WebPageProxy):
(WebKit::WebPageProxy::configuration):
(WebKit::WebPageProxy::processIdentifier):

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::pageID):
(WebKit::WebPageProxy::sessionID):

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createNewWebProcessRespectingProcessCountLimit):
(WebKit::WebProcessPool::createWebPage):
(WebKit::WebProcessPool::download):

UIProcess/WebProcessPool.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::webPage):
(WebKit::WebProcessProxy::createWebPage):

UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::processPool):

UIProcess/ios/WKContentView.h:
UIProcess/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithProcessPool:configuration:]):
(-[WKContentView initWithFrame:processPool:configuration:webView:]):
(-[WKContentView initWithFrame:processPool:configuration:wkView:]):
(-[WKContentView dealloc]):

1:51 PM Changeset in webkit [188227] by Devin Rousso

2 edits in trunk/Source/WebCore

Web Inspector: [iOS] Allow inspector to retrieve a list of system fonts
https://bugs.webkit.org/show_bug.cgi?id=147033

Reviewed by Joseph Pecoraro.

Implement systemFontFamilies for iOS.

platform/graphics/ios/FontCacheIOS.mm:

(WebCore::FontCache::systemFontFamilies):

1:49 PM Changeset in webkit [188226] by Devin Rousso

4 edits
4 adds in trunk/Source/WebInspectorUI

Web Inspector: Add VisualStyleSelectorSection
https://bugs.webkit.org/show_bug.cgi?id=147572

Reviewed by Brian Burg.

Adds a section to the new Visual style sidebar panel that contains the list of
styles for the currently selected node.

UserInterface/Models/CSSRule.js:

(WebInspector.CSSRule.prototype.get mediaText):
Returns a string containing the list of media queries.

UserInterface/Models/CSSStyleDeclaration.js:

(WebInspector.CSSStyleDeclaration):
(WebInspector.CSSStyleDeclaration.prototype.set text):
(WebInspector.CSSStyleDeclaration.prototype.get modified):
(WebInspector.CSSStyleDeclaration.prototype.resetText):
(WebInspector.CSSStyleDeclaration.prototype.generateCSSRuleString):
Generates a formatted string of the style text.

UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection.prototype._handleContextMenuEvent):
(WebInspector.CSSStyleDeclarationSection.prototype._generateCSSRuleString): Deleted.

UserInterface/Views/VisualStyleSelectorSection.css: Added.

(.details-section.visual-style-selector-section > .header):
(.details-section.visual-style-selector-section:not(.collapsed) > .header):
(@media (-webkit-min-device-pixel-ratio: 2)):
(.details-section.visual-style-selector-section > .header > .current-selector):
(.visual-style-selector-section.details-section:not(.collapsed) > .header > .current-selector):
(.details-section.visual-style-selector-section > .header > .current-selector > .icon):
(.details-section.visual-style-selector-section > .header > .current-selector > span):
(.details-section.visual-style-selector-section > .header > .controls):
(.details-section.visual-style-selector-section.collapsed > .header > .controls):
(.details-section.visual-style-selector-section > .header > .controls > .visual-style-selector-section-add-rule):
(.details-section.visual-style-selector-section > .content > .selectors):
(.details-section.visual-style-selector-section > .content > .selectors > .selector-list):
(.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .visual-style-selector-item:nth-child(odd)):
(.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider):
(.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider > .icon):
(.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider > :matches(.disclosure-button, .icon)):
(.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider > .titles > .title):
(.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider ~ .visual-style-selector-item:nth-child(even)):
(.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider ~ .visual-style-selector-item:nth-child(odd)):

UserInterface/Views/VisualStyleSelectorSection.js: Added.

(WebInspector.VisualStyleSelectorSection):
(WebInspector.VisualStyleSelectorSection.prototype.update.createSelectorItem):
(WebInspector.VisualStyleSelectorSection.prototype.update.uniqueOrderedRules):
(WebInspector.VisualStyleSelectorSection.prototype.update.insertAllMatchingPseudoRules):
(WebInspector.VisualStyleSelectorSection.prototype.update):
(WebInspector.VisualStyleSelectorSection.prototype.currentStyle):
(WebInspector.VisualStyleSelectorSection.prototype._selectorChanged):
(WebInspector.VisualStyleSelectorSection.prototype._styleTextReset):
(WebInspector.VisualStyleSelectorSection.prototype._addNewRule):
(WebInspector.VisualStyleSelectorSection.prototype._treeElementCheckboxToggled):
(WebInspector.VisualStyleSelectorSection.prototype._handleMouseOver):
(WebInspector.VisualStyleSelectorSection.prototype._handleMouseOut):

UserInterface/Views/VisualStyleSelectorTreeItem.css:

(.item.visual-style-selector-item):
(.item.visual-style-selector-item.selected):
(.item.visual-style-selector-item > .disclosure-button):
(.item.visual-style-selector-item > input[type="checkbox"]):
(.item.visual-style-selector-item > .icon):
(.item.visual-style-selector-item.modified > .icon):
(.item.visual-style-selector-item.selector-invalid > .icon):
(.item.visual-style-selector-item.selector-invalid > .titles > .title):
(.item.visual-style-selector-item.selector-invalid > .titles > .title::before):
(.item.visual-style-selector-item > .titles):
(.item.visual-style-selector-item:not(.dom-element-icon) > .titles > .title):
(.item.visual-style-selector-item:not(.dom-element-icon).editable > .titles > .title):
(.item.visual-style-selector-item:not(.dom-element-icon).editable > .titles > .title:focus):
(.item.visual-style-selector-item > .titles > .subtitle::before):
(.item.visual-style-selector-item > .titles > .subtitle):

UserInterface/Views/VisualStyleSelectorTreeItem.js:

(WebInspector.VisualStyleSelectorTreeItem):
(WebInspector.VisualStyleSelectorTreeItem.prototype.get iconClassName):
(WebInspector.VisualStyleSelectorTreeItem.prototype.get selectorText):
(WebInspector.VisualStyleSelectorTreeItem.prototype.onattach):
(WebInspector.VisualStyleSelectorTreeItem.prototype.ondeselect):
(WebInspector.VisualStyleSelectorTreeItem.prototype._highlightNodesWithSelector):
(WebInspector.VisualStyleSelectorTreeItem.prototype._hideDOMNodeHighlight):
(WebInspector.VisualStyleSelectorTreeItem.prototype._handleContextMenuEvent):
(WebInspector.VisualStyleSelectorTreeItem.prototype._handleCheckboxChanged):
(WebInspector.VisualStyleSelectorTreeItem.prototype._updateCheckboxTitle):
(WebInspector.VisualStyleSelectorTreeItem.prototype._handleMainTitleMouseDown):
(WebInspector.VisualStyleSelectorTreeItem.prototype._handleMainTitleKeyDown):
(WebInspector.VisualStyleSelectorTreeItem.prototype._commitSelector):
(WebInspector.VisualStyleSelectorTreeItem.prototype._styleTextModified):
(WebInspector.VisualStyleSelectorTreeItem.prototype._selectorChanged):

1:38 PM Changeset in webkit [188225] by dburkart@apple.com

8 edits
2 adds in branches/safari-601.1-branch

Merge r188182. rdar://problem/21254835

1:36 PM Changeset in webkit [188224] by dburkart@apple.com

2 edits in branches/safari-601.1-branch/Source/WebCore

Merge r188196. rdar://problem/22192773

1:36 PM Changeset in webkit [188223] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r187131 and r187286.
https://bugs.webkit.org/show_bug.cgi?id=147839

Causing mroe frequent crashes with invalid layer bounds

(rdar://problem/21465328) (Requested by smfr on #webkit).

Reverted changesets:

"[iOS] Menu drop down such as on nike.com does not stay"
https://bugs.webkit.org/show_bug.cgi?id=147047
http://trac.webkit.org/changeset/187131

"[iOS] REGRESSION (187131): Loading CuteOverload zooms in to
the top left corner."
https://bugs.webkit.org/show_bug.cgi?id=147251
http://trac.webkit.org/changeset/187286

1:33 PM Changeset in webkit [188222] by Devin Rousso

2 edits in trunk/Source/WebCore

Web Inspector: Invalid selectors can be applied to the stylesheet
https://bugs.webkit.org/show_bug.cgi?id=147230

Reviewed by Timothy Hatcher.

inspector/InspectorStyleSheet.cpp:

(WebCore::isValidSelectorListString):
(WebCore::InspectorStyleSheet::setRuleSelector):
Now checks to see that the supplied selector is valid before trying to commit it to the rule.
(WebCore::InspectorStyleSheet::addRule):
(WebCore::checkStyleRuleSelector): Deleted.

1:33 PM Changeset in webkit [188221] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: TDZ in ProbeSetDataGrid construction
https://bugs.webkit.org/show_bug.cgi?id=147834

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-08-10
Reviewed by Timothy Hatcher.

UserInterface/Views/ProbeSetDataGrid.js:

(WebInspector.ProbeSetDataGrid):
Do not use "this" before calling super.

1:32 PM Changeset in webkit [188220] by dburkart@apple.com

4 edits
2 deletes in branches/safari-601.1-branch

Merge r188190. rdar://problem/22191482

1:24 PM Changeset in webkit [188219] by ggaren@apple.com

16 edits in trunk/Source/JavaScriptCore

Let's rename FunctionBodyNode
https://bugs.webkit.org/show_bug.cgi?id=147292

Reviewed by Mark Lam & Saam Barati.

FunctionBodyNode => FunctionMetadataNode

Make FunctionMetadataNode inherit from Node instead of StatementNode
because a FunctionMetadataNode can appear in expression context and does
not have a next statement.

(I decided to continue allocating FunctionMetadataNode in the AST arena,
and to retain "Node" in its name, because it really is a parsing
construct, and we transform its data before consuming it elsewhere.

There is still room for a future patch to distill and simplify the
metadata we track about functions between FunDeclNode/FuncExprNode,
FunctionMetadataNode, and UnlinkedFunctionExecutable. But this is a start.)

builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::createExecutableInternal):

bytecode/UnlinkedCodeBlock.cpp:

(JSC::generateFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):

bytecode/UnlinkedCodeBlock.h:
bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionExpression):

bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::makeFunction):

bytecompiler/NodesCodegen.cpp:

(JSC::EvalNode::emitBytecode):
(JSC::FunctionNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode): Deleted.

parser/ASTBuilder.h:

(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):

parser/NodeConstructors.h:

(JSC::FunctionParameters::FunctionParameters):
(JSC::FuncExprNode::FuncExprNode):
(JSC::FuncDeclNode::FuncDeclNode):

parser/Nodes.cpp:

(JSC::EvalNode::EvalNode):
(JSC::FunctionMetadataNode::FunctionMetadataNode):
(JSC::FunctionMetadataNode::finishParsing):
(JSC::FunctionMetadataNode::setEndPosition):
(JSC::FunctionBodyNode::FunctionBodyNode): Deleted.
(JSC::FunctionBodyNode::finishParsing): Deleted.
(JSC::FunctionBodyNode::setEndPosition): Deleted.

parser/Nodes.h:

(JSC::FuncExprNode::body):
(JSC::FuncDeclNode::body):

parser/Parser.h:

(JSC::Parser::isFunctionMetadataNode):
(JSC::Parser::next):
(JSC::Parser<LexerType>::parse):
(JSC::Parser::isFunctionBodyNode): Deleted.

runtime/CodeCache.cpp:

(JSC::CodeCache::getFunctionExecutableFromGlobalCode):

runtime/CodeCache.h:

12:18 PM Changeset in webkit [188218] by mrajca@apple.com

5 edits in trunk/Source/WebKit2

Media Session: generalize isFocusedContentMediaElementPlaying so it works with other playback attributes
https://bugs.webkit.org/show_bug.cgi?id=147797

Reviewed by Simon Fraser.

UIProcess/API/C/WKMediaSessionFocusManager.cpp:

(WKMediaSessionFocusManagerValueForPlaybackAttribute):
(WKMediaSessionFocusManagerIsFocusedContentMediaElementPlaying): Deleted.

UIProcess/API/C/WKMediaSessionFocusManager.h:
UIProcess/WebMediaSessionFocusManager.cpp:

(WebKit::WebMediaSessionFocusManager::valueForPlaybackAttribute):
(WebKit::WebMediaSessionFocusManager::mediaControlIsEnabledDidChange):
(WebKit::WebMediaSessionFocusManager::isFocusedContentMediaElementPlaying): Deleted.
(WebKit::WebMediaSessionFocusManager::mediaElementIsPlayingDidChange): Deleted.

UIProcess/WebMediaSessionFocusManager.h:

11:57 AM Changeset in webkit [188217] by Chris Dumez

2 edits in trunk/Source/WebKit/mac

Align WebKit1's PageCache size with WebKit2's
https://bugs.webkit.org/show_bug.cgi?id=147831

Reviewed by Sam Weinig.

Align WebKit1's PageCache size with WebKit2's for consistency. Also, we
have data showing that keeping more than 3 pages in the PageCache is
not really useful.

WebView/WebView.mm:

(+[WebView _setCacheModel:]):

11:06 AM Changeset in webkit [188216] by Antti Koivisto

3 edits
2 adds in trunk/LayoutTests

http/tests/cache/disk-cache/disk-cache-validation.html has too many subtests
https://bugs.webkit.org/show_bug.cgi?id=147827

Rubber-stamped by Alexey Proskuryakov.

Also split the no-body variant of this.

http/tests/cache/disk-cache/disk-cache-validation-no-body-expected.txt:
http/tests/cache/disk-cache/disk-cache-validation-no-body.html:
http/tests/cache/disk-cache/disk-cache-vary-no-body-expected.txt: Added.
http/tests/cache/disk-cache/disk-cache-vary-no-body.html: Added.

10:56 AM Changeset in webkit [188215] by peavo@outlook.com

2 edits in trunk/Source/WebKit/win

[Win] Small repaint issues when device scale factor != 1.
https://bugs.webkit.org/show_bug.cgi?id=147825

Reviewed by Alex Christensen.

When scaling, we should scale a FloatRect, and then compute the enclosing IntRect.

WebView.cpp:

(WebView::repaint):
(WebView::scrollBackingStore):
(WebView::paintIntoBackingStore):

9:09 AM Changeset in webkit [188214] by Antti Koivisto

3 edits
2 adds in trunk/LayoutTests

http/tests/cache/disk-cache/disk-cache-validation.html has too many subtests
https://bugs.webkit.org/show_bug.cgi?id=147827

Reviewed by Chris Dumez.

Looks like it occasionally times out because a bot is running slowly and 243 subtests take >30s.

http/tests/cache/disk-cache/disk-cache-validation-expected.txt:
http/tests/cache/disk-cache/disk-cache-validation.html:

Split Vary header cases to a separate test.

http/tests/cache/disk-cache/disk-cache-vary-expected.txt:
http/tests/cache/disk-cache/disk-cache-vary.html:

Reduce test matrix size by no testing Expires header here.

9:01 AM Changeset in webkit [188213] by jcraig@apple.com

7 edits in trunk

AX: Address follow-up comments in bug 145684
https://bugs.webkit.org/show_bug.cgi?id=147817

Reviewed by Dean Jackson.

Minor cleanup and style updates requested by Dean.
Source/WebCore:

Updated Existing Test Expectations.

Modules/mediacontrols/mediaControlsApple.css:

(video::-webkit-media-show-controls):

Modules/mediacontrols/mediaControlsiOS.css:

(video::-webkit-media-show-controls):

LayoutTests:

http/tests/contentextensions/text-track-blocked-expected.txt:
media/video-controls-show-on-kb-or-ax-event.html:
platform/mac/media/track/track-cue-rendering-horizontal-expected.txt:

7:12 AM Changeset in webkit [188212] by zandobersek@gmail.com

3 edits in trunk/Source/WebKit2

[CoordinatedGraphics] Fix forward declarations of CoordinatedGraphicsLayerState, ViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=147823

Reviewed by Carlos Garcia Campos.

WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
WebProcess/WebPage/LayerTreeHost.h:

5:48 AM Changeset in webkit [188211] by Antti Koivisto

22 edits in trunk

Expand network cache tests to cover memory cache behavior
https://bugs.webkit.org/show_bug.cgi?id=147783

Reviewed by Alexey Proskuryakov.

Source/WebCore:

To support testing, include memory cache as a possible source type to XHR responses.

loader/ResourceLoader.cpp:

(WebCore::logResourceResponseSource):

loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::didAddClient):

loader/cache/CachedResource.h:

(WebCore::CachedResource::revalidationInProgress):

platform/network/ResourceResponseBase.h:
testing/Internals.cpp:

(WebCore::Internals::xhrResponseSource):

LayoutTests:

Add another round to existing cache tests with hot memory cache.
This add 691 individual cases worth of memory cache test coverage.

XHR (and main resource, CachedRawResource in general) behaves differently from other resource types. The added
coverage maps this behavior. The regular subresource behavior needs coverage too.

http/tests/cache/disk-cache/disk-cache-204-status-code-expected.txt:
http/tests/cache/disk-cache/disk-cache-302-status-code-expected.txt:
http/tests/cache/disk-cache/disk-cache-307-status-code-expected.txt:
http/tests/cache/disk-cache/disk-cache-404-status-code-expected.txt:
http/tests/cache/disk-cache/disk-cache-disable-expected.txt:
http/tests/cache/disk-cache/disk-cache-media-expected.txt:
http/tests/cache/disk-cache/disk-cache-range-expected.txt:
http/tests/cache/disk-cache/disk-cache-request-headers-expected.txt:
http/tests/cache/disk-cache/disk-cache-request-max-stale-expected.txt:
http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header-expected.txt:
http/tests/cache/disk-cache/disk-cache-validation-attachment-expected.txt:
http/tests/cache/disk-cache/disk-cache-validation-back-navigation-policy-expected.txt:
http/tests/cache/disk-cache/disk-cache-validation-expected.txt:
http/tests/cache/disk-cache/disk-cache-validation-no-body-expected.txt:
http/tests/cache/disk-cache/resources/cache-test.js:

(loadResource):
(loadResourcesWithOptions):
(loadResources):
(.):
(runTests):

3:05 AM Changeset in webkit [188210] by youenn.fablet@crf.canon.fr

7 edits in trunk

Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
https://bugs.webkit.org/show_bug.cgi?id=146414

Reviewed by Darin Adler.

Source/WebCore:

No behavioral changes.

platform/FileSystem.cpp:

(WebCore::MappedFileData::MappedFileData): Making use of convertSafely.

platform/posix/SharedBufferPOSIX.cpp:

(WebCore::SharedBuffer::createFromReadingFile): Making use of convertSafely.

Source/WTF:

Added convertSafely routine based on isInBounds routine.
Updated BoundChecker by adding a third boolean parameter to this template giving whether Target has greater or equal precision than Source.
Removed BoundCheckElider, which is no longer necessary and had some issues.

wtf/CheckedArithmetic.h:

(WTF::isInBounds):
(WTF::convertSafely):

Tools:

TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:

(TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.

3:01 AM Changeset in webkit [188209] by youenn.fablet@crf.canon.fr

3 edits in trunk/Source/WebCore

[Streams API] ReadableStreamReader closed promise should use CachedAttribute
https://bugs.webkit.org/show_bug.cgi?id=147487

Reviewed by Darin Adler.

Covered by existing tests.

Modules/streams/ReadableStreamReader.idl: Made closed a CachedAttribute.
bindings/js/JSReadableStreamReaderCustom.cpp:

(WebCore::JSReadableStreamReader::closed): Updated according CachedAttribute specific field.

1:27 AM Changeset in webkit [188208] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

[GTK] Crash when the web view is destroyed while the screensaver DBUs proxy is being created
https://bugs.webkit.org/show_bug.cgi?id=147780

Reviewed by Sergio Villar Senin.

We should cancel the screenSaverInhibitCancellable on
dispose. Also use adoptGRef() when creating the cancellable object
to not leak it.

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDispose):
(webkitWebViewBaseSendInhibitMessageToScreenSaver):
(webkitWebViewBaseInhibitScreenSaver):

1:24 AM Changeset in webkit [188207] by Carlos Garcia Campos

3 edits in trunk/Tools

[GTK] Test /webkit2/WebKitWebView/submit-form is flaky
https://bugs.webkit.org/show_bug.cgi?id=147727

Reviewed by Sergio Villar Senin.

I think it was not this test in particular, but
/webkit2/WebKitWebView/custom-charset that is affecting the
others. This is because changing the encoding reloads the page,
but we don't wait for the page to be reloaded, so when the test
finishes and other test starts the web process is still reloading
the page.

Scripts/run-gtk-tests:

(TestRunner): Unskip /webkit2/WebKitWebView/submit-form.

TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewCustomCharset): Wait until page is reloaded after
changing the charset.

Aug 9, 2015:

11:50 PM Changeset in webkit [188206] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[EFL] Use the non-overlay scrollbar
https://bugs.webkit.org/show_bug.cgi?id=147725

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-08-09
Reviewed by Gyuyoung Kim.

No new tests because there is no behavior change.

platform/efl/ScrollbarThemeEfl.cpp:

(WebCore::ScrollbarThemeEfl::usesOverlayScrollbars):
Changed the condition of the 'usesOverlayScrollbars' to use the
setting value.

platform/efl/ScrollbarThemeEfl.h:

11:41 PM Changeset in webkit [188205] by Carlos Garcia Campos

2 edits in trunk/Tools

Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.

It's timing out in the bots. My guess is that there's no installer
installed in the bots and gst_install_plugins_supported() returns
false, so we don't even get a permission request because no
installer will be launched.

Scripts/run-gtk-tests:

(TestRunner):

9:14 PM Changeset in webkit [188204] by Chris Dumez

3 edits
4 adds in trunk

Page cache doesn't work for pages actively using Geolocation
https://bugs.webkit.org/show_bug.cgi?id=147785
<rdar://problem/11147901>

Reviewed by Darin Adler.

Source/WebCore:

Allow pages actively using Geolocation into the PageCache.

Tests: fast/history/page-cache-geolocation-active-oneshot.html

fast/history/page-cache-geolocation-active-watcher.html

Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::canSuspendForPageCache):
(WebCore::Geolocation::suspend): Deleted.

history/PageCache.cpp:

LayoutTests:

Add layout test coverage for page caching of pages actively using
the Geolocation API.

fast/history/page-cache-geolocation-active-oneshot-expected.txt: Added.
fast/history/page-cache-geolocation-active-oneshot.html: Added.
fast/history/page-cache-geolocation-active-watcher-expected.txt: Added.
fast/history/page-cache-geolocation-active-watcher.html: Added.

6:53 PM Changeset in webkit [188203] by commit-queue@webkit.org

14 edits
2 adds in trunk

AX: CSS table display styles can cause malformed, inaccessible AXTables to be exposed to the AX tree
https://bugs.webkit.org/show_bug.cgi?id=136415
<rdar://problem/22026625>

Patch by Nan Wang <n_wang@apple.com> on 2015-08-09
Reviewed by Chris Fleizach.

Source/WebCore:

Applying CSS display styles to tables can end up inserting anonymous RenderTableRows, which is not handled well by the
accessibility code, which treats these as the actual rows. We can address this by diving deeper into anonymous nodes
and finding the real rows and cells we want. In addition, another thing also causing malformed tables is that "grid"
roles are being exposed as AXGrid instead of AXTable.

Test: accessibility/mac/malformed-table.html

accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addRowDescendant):

accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::addTableCellChild):
(WebCore::AccessibilityTable::addChildrenFromSection):

accessibility/AccessibilityTable.h:
accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::parentTable):
(WebCore::AccessibilityTableCell::rowIndexRange):

accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::parentTable):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(createAccessibilityRoleMap):

LayoutTests:

accessibility/aria-table-with-presentational-elements-expected.txt:
accessibility/aria-table-with-presentational-elements.html:
accessibility/mac/malformed-table-expected.txt: Added.
accessibility/mac/malformed-table.html: Added.
platform/mac-mavericks/accessibility/roles-exposed-expected.txt:
platform/mac/accessibility/aria-table-hierarchy-expected.txt:
platform/mac/accessibility/aria-tables-expected.txt:
platform/mac/accessibility/roles-exposed-expected.txt:

5:10 PM Changeset in webkit [188202] by Darin Adler

14 edits
83 deletes in trunk

Remove -webkit-color-correction CSS property
https://bugs.webkit.org/show_bug.cgi?id=147812

Reviewed by Maciej Stachowiak.

Source/WebCore:

Covered by existing tests.

I am doing some general cleanup of handling of color spaces in WebKit.
This removes the obsolete web-visible property that allowed clients to
get color correction on older Apple platforms where we chose not to do
it all the time for performance reasons. Currently, it has no effect on
any supported platform.

Now that this property is removed, a website can detect that it's not
there if it uses getComputedStyle, but I don't expect this to have
significant compatibility fallout. It's harmless to continue using the
property in legacy content or websites that have not been updated, since
unknown property names are ignored and it had no effect before anyway.

css/CSSComputedStyleDeclaration.cpp: Removed

CSSPropertyWebkitColorCorrection from the list of computed properties.
(WebCore::ComputedStyleExtractor::propertyValue): Removed the
CSSPropertyWebkitColorCorrection case.

css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue): Removed the
CSSPropertyWebkitColorCorrection case.
(WebCore::isKeywordPropertyID): Ditto.
(WebCore::CSSParser::parseValue): Ditto.

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Deleted the overload
of this that converts a ColorSpace to a CSSPrimitiveValue.
(WebCore::CSSPrimitiveValue::operator ColorSpace): Deleted.

css/CSSPropertyNames.in: Removed -webkit-color-correction.

css/CSSValueKeywords.in: Removed the -webkit-color-correction section,

which contained sRGB.

css/SVGCSSValueKeywords.in: Uncommented sRGB now that it's not shared

with -webkit-color-correction.

rendering/style/RenderStyle.h: Removed setColorSpace and initialColorSpace.

Kept colorSpace around for now, but it simply returns ColorSpaceSRGB.
This prevents us from needing to touch every single call site that passes
the color space in to functions in the platform graphics abstraction.
We'll touch most of those call sites when we change Color to include the
color space and eventually we can delete this.

rendering/style/StyleRareInheritedData.cpp: Deleted colorSpace.

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Deleted
code to initialize colorSpace and to copy colorSpace.
(WebCore::StyleRareInheritedData::operator==): Deleted code to compare
colorSpace.

LayoutTests:

Given that -webkit-color-correction had no effect on rendering on any platform in any
configuration we covered, it's amazing how many tests we had for it.

fast/css/getComputedStyle/computed-style-expected.txt: Removed expected results for

-webkit-color-correction property.

fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
svg/css/getComputedStyle-basic-expected.txt: Ditto.

fast/css/getComputedStyle/resources/property-names.js: Removed -webkit-color-correction.

fast/css/color-correction-backgrounds-and-text.html: Removed.
fast/css/color-correction-on-background-image.html: Removed.
fast/css/color-correction-on-backgrounds.html: Removed.
fast/css/color-correction-on-box-shadow.html: Removed.
fast/css/color-correction-on-text-shadow.html: Removed.
fast/css/color-correction-on-text.html: Removed.
fast/css/color-correction-untagged-images.html: Removed.
fast/css/color-correction.html: Removed.
fast/css/parsing-color-correction-expected.txt: Removed.
fast/css/parsing-color-correction.html: Removed.
fast/css/resources/parsing-color-correction.js: Removed.
platform/efl/fast/css/color-correction-backgrounds-and-text-expected.png: Removed.
platform/efl/fast/css/color-correction-backgrounds-and-text-expected.txt: Removed.
platform/efl/fast/css/color-correction-expected.png: Removed.
platform/efl/fast/css/color-correction-expected.txt: Removed.
platform/efl/fast/css/color-correction-on-background-image-expected.png: Removed.
platform/efl/fast/css/color-correction-on-background-image-expected.txt: Removed.
platform/efl/fast/css/color-correction-on-backgrounds-expected.png: Removed.
platform/efl/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
platform/efl/fast/css/color-correction-on-box-shadow-expected.png: Removed.
platform/efl/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
platform/efl/fast/css/color-correction-on-text-expected.png: Removed.
platform/efl/fast/css/color-correction-on-text-expected.txt: Removed.
platform/efl/fast/css/color-correction-on-text-shadow-expected.png: Removed.
platform/efl/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
platform/efl/fast/css/color-correction-untagged-images-expected.png: Removed.
platform/efl/fast/css/color-correction-untagged-images-expected.txt: Removed.
platform/gtk/fast/css/color-correction-backgrounds-and-text-expected.png: Removed.
platform/gtk/fast/css/color-correction-backgrounds-and-text-expected.txt: Removed.
platform/gtk/fast/css/color-correction-expected.png: Removed.
platform/gtk/fast/css/color-correction-expected.txt: Removed.
platform/gtk/fast/css/color-correction-on-background-image-expected.png: Removed.
platform/gtk/fast/css/color-correction-on-background-image-expected.txt: Removed.
platform/gtk/fast/css/color-correction-on-backgrounds-expected.png: Removed.
platform/gtk/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
platform/gtk/fast/css/color-correction-on-box-shadow-expected.png: Removed.
platform/gtk/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
platform/gtk/fast/css/color-correction-on-text-expected.png: Removed.
platform/gtk/fast/css/color-correction-on-text-expected.txt: Removed.
platform/gtk/fast/css/color-correction-on-text-shadow-expected.png: Removed.
platform/gtk/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
platform/gtk/fast/css/color-correction-untagged-images-expected.png: Removed.
platform/gtk/fast/css/color-correction-untagged-images-expected.txt: Removed.
platform/ios-simulator-wk2/fast/css/color-correction-backgrounds-and-text-expected.txt: Removed.
platform/ios-simulator-wk2/fast/css/color-correction-expected.txt: Removed.
platform/ios-simulator-wk2/fast/css/color-correction-on-background-image-expected.txt: Removed.
platform/ios-simulator-wk2/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
platform/ios-simulator-wk2/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
platform/ios-simulator-wk2/fast/css/color-correction-on-text-expected.txt: Removed.
platform/ios-simulator-wk2/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
platform/ios-simulator-wk2/fast/css/color-correction-untagged-images-expected.txt: Removed.
platform/ios-simulator/fast/css/color-correction-backgrounds-and-text-expected.txt: Removed.
platform/ios-simulator/fast/css/color-correction-expected.txt: Removed.
platform/ios-simulator/fast/css/color-correction-on-background-image-expected.txt: Removed.
platform/ios-simulator/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
platform/ios-simulator/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
platform/ios-simulator/fast/css/color-correction-on-text-expected.txt: Removed.
platform/ios-simulator/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
platform/ios-simulator/fast/css/color-correction-untagged-images-expected.txt: Removed.
platform/mac/fast/css/color-correction-backgrounds-and-text-expected.png: Removed.
platform/mac/fast/css/color-correction-backgrounds-and-text-expected.txt: Removed.
platform/mac/fast/css/color-correction-expected.png: Removed.
platform/mac/fast/css/color-correction-expected.txt: Removed.
platform/mac/fast/css/color-correction-on-background-image-expected.png: Removed.
platform/mac/fast/css/color-correction-on-background-image-expected.txt: Removed.
platform/mac/fast/css/color-correction-on-backgrounds-expected.png: Removed.
platform/mac/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
platform/mac/fast/css/color-correction-on-box-shadow-expected.png: Removed.
platform/mac/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
platform/mac/fast/css/color-correction-on-text-expected.png: Removed.
platform/mac/fast/css/color-correction-on-text-expected.txt: Removed.
platform/mac/fast/css/color-correction-on-text-shadow-expected.png: Removed.
platform/mac/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
platform/mac/fast/css/color-correction-untagged-images-expected.png: Removed.
platform/mac/fast/css/color-correction-untagged-images-expected.txt: Removed.
platform/win/fast/css/color-correction-backgrounds-and-text-expected.txt: Removed.
platform/win/fast/css/color-correction-expected.txt: Removed.
platform/win/fast/css/color-correction-on-background-image-expected.txt: Removed.
platform/win/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
platform/win/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
platform/win/fast/css/color-correction-on-text-expected.txt: Removed.
platform/win/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
platform/win/fast/css/color-correction-untagged-images-expected.txt: Removed.

3:55 PM Changeset in webkit [188201] by Chris Dumez

38 edits
51 deletes in trunk

Regression(r188105): Seems to have caused crashes during PLT on some iPads
https://bugs.webkit.org/show_bug.cgi?id=147818

Unreviewed, roll out r188105.

Source/JavaScriptCore:

bytecode/ByValInfo.h:

(JSC::ByValInfo::ByValInfo):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::getByValInfoMap): Deleted.
(JSC::CodeBlock::addByValInfo): Deleted.

bytecode/CodeBlock.h:

(JSC::CodeBlock::getByValInfo):
(JSC::CodeBlock::setNumberOfByValInfos):
(JSC::CodeBlock::numberOfByValInfos):
(JSC::CodeBlock::byValInfo):

bytecode/ExitKind.cpp:

(JSC::exitKindToString): Deleted.

bytecode/ExitKind.h:
bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFor):
(JSC::GetByIdStatus::computeForStubInfo):
(JSC::GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback): Deleted.

bytecode/GetByIdStatus.h:
dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects): Deleted.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry): Deleted.

dfg/DFGClobberize.h:

(JSC::DFG::clobberize): Deleted.

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants): Deleted.

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC): Deleted.

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode): Deleted.
(JSC::DFG::FixupPhase::observeUseKindOnNode): Deleted.

dfg/DFGNode.h:

(JSC::DFG::Node::hasUidOperand): Deleted.
(JSC::DFG::Node::uidOperand): Deleted.

dfg/DFGNodeType.h:
dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate): Deleted.

dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()): Deleted.
(JSC::DFG::safeToExecute): Deleted.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCheckIdent): Deleted.
(JSC::DFG::SpeculativeJIT::speculateSymbol): Deleted.
(JSC::DFG::SpeculativeJIT::speculate): Deleted.

dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Deleted.

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Deleted.

dfg/DFGUseKind.cpp:

(WTF::printInternal): Deleted.

dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor): Deleted.
(JSC::DFG::isCell): Deleted.

ftl/FTLAbstractHeapRepository.h:
ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile): Deleted.

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileNode): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::compileCheckIdent): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::lowSymbol): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::speculate): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::isNotSymbol): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::speculateSymbol): Deleted.

jit/JIT.cpp:

(JSC::JIT::privateCompile):

jit/JIT.h:

(JSC::ByValCompilationInfo::ByValCompilationInfo):
(JSC::JIT::compileGetByValWithCachedId): Deleted.

jit/JITInlines.h:

(JSC::JIT::callOperation): Deleted.

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_has_indexed_property):
(JSC::JIT::emitSlow_op_has_indexed_property):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_has_indexed_property):
(JSC::JIT::emitSlow_op_has_indexed_property):

jit/JITOperations.cpp:

(JSC::getByVal):

jit/JITOperations.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emitGetByValWithCachedId): Deleted.
(JSC::JIT::privateCompileGetByVal): Deleted.
(JSC::JIT::privateCompileGetByValWithCachedId): Deleted.

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emitGetByValWithCachedId): Deleted.

runtime/Symbol.h:
tests/stress/get-by-val-with-string-constructor.js: Removed.
tests/stress/get-by-val-with-string-exit.js: Removed.
tests/stress/get-by-val-with-string-generated.js: Removed.
tests/stress/get-by-val-with-string-getter.js: Removed.
tests/stress/get-by-val-with-string.js: Removed.
tests/stress/get-by-val-with-symbol-constructor.js: Removed.
tests/stress/get-by-val-with-symbol-exit.js: Removed.
tests/stress/get-by-val-with-symbol-getter.js: Removed.
tests/stress/get-by-val-with-symbol.js: Removed.

LayoutTests:

js/regress/get-by-val-with-string-bimorphic-check-structure-elimination-expected.txt: Removed.
js/regress/get-by-val-with-string-bimorphic-check-structure-elimination-simple-expected.txt: Removed.
js/regress/get-by-val-with-string-bimorphic-check-structure-elimination-simple.html: Removed.
js/regress/get-by-val-with-string-bimorphic-check-structure-elimination.html: Removed.
js/regress/get-by-val-with-string-chain-from-try-block-expected.txt: Removed.
js/regress/get-by-val-with-string-chain-from-try-block.html: Removed.
js/regress/get-by-val-with-string-check-structure-elimination-expected.txt: Removed.
js/regress/get-by-val-with-string-check-structure-elimination.html: Removed.
js/regress/get-by-val-with-string-proto-or-self-expected.txt: Removed.
js/regress/get-by-val-with-string-proto-or-self.html: Removed.
js/regress/get-by-val-with-string-quadmorphic-check-structure-elimination-simple-expected.txt: Removed.
js/regress/get-by-val-with-string-quadmorphic-check-structure-elimination-simple.html: Removed.
js/regress/get-by-val-with-string-self-or-proto-expected.txt: Removed.
js/regress/get-by-val-with-string-self-or-proto.html: Removed.
js/regress/get-by-val-with-symbol-bimorphic-check-structure-elimination-expected.txt: Removed.
js/regress/get-by-val-with-symbol-bimorphic-check-structure-elimination-simple-expected.txt: Removed.
js/regress/get-by-val-with-symbol-bimorphic-check-structure-elimination-simple.html: Removed.
js/regress/get-by-val-with-symbol-bimorphic-check-structure-elimination.html: Removed.
js/regress/get-by-val-with-symbol-chain-from-try-block-expected.txt: Removed.
js/regress/get-by-val-with-symbol-chain-from-try-block.html: Removed.
js/regress/get-by-val-with-symbol-check-structure-elimination-expected.txt: Removed.
js/regress/get-by-val-with-symbol-check-structure-elimination.html: Removed.
js/regress/get-by-val-with-symbol-proto-or-self-expected.txt: Removed.
js/regress/get-by-val-with-symbol-proto-or-self.html: Removed.
js/regress/get-by-val-with-symbol-quadmorphic-check-structure-elimination-simple-expected.txt: Removed.
js/regress/get-by-val-with-symbol-quadmorphic-check-structure-elimination-simple.html: Removed.
js/regress/get-by-val-with-symbol-self-or-proto-expected.txt: Removed.
js/regress/get-by-val-with-symbol-self-or-proto.html: Removed.
js/regress/script-tests/get-by-val-with-string-bimorphic-check-structure-elimination-simple.js: Removed.
js/regress/script-tests/get-by-val-with-string-bimorphic-check-structure-elimination.js: Removed.
js/regress/script-tests/get-by-val-with-string-chain-from-try-block.js: Removed.
js/regress/script-tests/get-by-val-with-string-check-structure-elimination.js: Removed.
js/regress/script-tests/get-by-val-with-string-proto-or-self.js: Removed.
js/regress/script-tests/get-by-val-with-string-quadmorphic-check-structure-elimination-simple.js: Removed.
js/regress/script-tests/get-by-val-with-string-self-or-proto.js: Removed.
js/regress/script-tests/get-by-val-with-symbol-bimorphic-check-structure-elimination-simple.js: Removed.
js/regress/script-tests/get-by-val-with-symbol-bimorphic-check-structure-elimination.js: Removed.
js/regress/script-tests/get-by-val-with-symbol-chain-from-try-block.js: Removed.
js/regress/script-tests/get-by-val-with-symbol-check-structure-elimination.js: Removed.
js/regress/script-tests/get-by-val-with-symbol-proto-or-self.js: Removed.
js/regress/script-tests/get-by-val-with-symbol-quadmorphic-check-structure-elimination-simple.js: Removed.
js/regress/script-tests/get-by-val-with-symbol-self-or-proto.js: Removed.

3:39 PM Changeset in webkit [188200] by bshafiei@apple.com

5 edits in branches/safari-601.1.46-branch/Source

Versioning.

3:26 PM Changeset in webkit [188199] by bshafiei@apple.com

1 copy in tags/Safari-601.1.46.6

New tag.

3:20 PM Changeset in webkit [188198] by Chris Dumez

2 edits in trunk/Source/WebKit2

Follow-up nit fixes after r187691.
https://bugs.webkit.org/show_bug.cgi?id=128006

Reviewed by Gavin Barraclough.

Use modern for-loops instead of explicit iterators.

Shared/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::shouldCoalesceChallenge):
(WebKit::AuthenticationManager::coalesceChallengesMatching):

3:15 PM Changeset in webkit [188197] by bshafiei@apple.com

5 edits in branches/safari-601.1.46-branch/Source

Merged r188162. rdar://problem/22126518

1:39 PM Changeset in webkit [188196] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

[Mac] Always require ExternalDeviceAutoPlayCandidate flag to AirPlay automatically
https://bugs.webkit.org/show_bug.cgi?id=147801

Reviewed by Dean Jackson.

Test: http/tests/media/video-media-document-disposition-download.html

Modules/mediasession/WebMediaSessionManager.cpp:

(WebCore::WebMediaSessionManager::configurePlaybackTargetClients): Don't tell the last element

to begin playing to the target unless the ExternalDeviceAutoPlayCandidate flag is set and
it is not currently playing.

1:01 PM Changeset in webkit [188195] by mmaxfield@apple.com

3 edits
2 adds in trunk

Crash in ComplexTextController when laying out obscure text
https://bugs.webkit.org/show_bug.cgi?id=147806
<rdar://problem/22102378>

Reviewed by Darin Adler.

Source/WebCore:

CTFontDescriptorCopyAttribute(fontDescriptor.get(), kCTFontReferenceURLAttribute) can return nullptr.

Test: fast/text/crash-obscure-text.html

platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::safeCFEqual):
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

LayoutTests:

fast/text/crash-obscure-text-expected.txt: Added.
fast/text/crash-obscure-text.html: Added.

4:15 AM Changeset in webkit [188194] by dino@apple.com

10 edits in trunk

Remove the webkit prefix from CanvasRenderingContext2D imageSmoothingEnabled
https://bugs.webkit.org/show_bug.cgi?id=147803
<rdar://problem/22200553>

Reviewed by Sam Weinig.

Source/WebCore:

Rename webkitImageSmoothingEnabled to imageSmoothingEnabled.

Updated existing tests, and made sure that the prefixed version is
identical to the standard version.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::imageSmoothingEnabled): Renamed from webkitImageSmoothingEnabled.
(WebCore::CanvasRenderingContext2D::setImageSmoothingEnabled): Renamed from setWebkitImageSmoothingEnabled.
(WebCore::CanvasRenderingContext2D::webkitImageSmoothingEnabled): Deleted.
(WebCore::CanvasRenderingContext2D::setWebkitImageSmoothingEnabled): Deleted.

html/canvas/CanvasRenderingContext2D.h: Rename the methods.
html/canvas/CanvasRenderingContext2D.idl: Add the non-prefixed form, and mark is as the

implementation of the prefixed form.

LayoutTests:

Use the standard version of imageSmoothingEnabled rather than
the prefixed version.

fast/canvas/canvas-imageSmoothingEnabled-expected.txt:
fast/canvas/canvas-imageSmoothingEnabled-patterns.html:
fast/canvas/canvas-imageSmoothingEnabled-zero-size.html:
fast/canvas/script-tests/canvas-imageSmoothingEnabled-repaint.js:

(draw):

fast/canvas/script-tests/canvas-imageSmoothingEnabled.js: Add some tests

to make sure the prefixed version correctly maps to the standard version.

1:11 AM Changeset in webkit [188193] by akling@apple.com

9 edits in trunk/Source/WebCore

Ref-ify some functions that always succeed in constructing Documents.
<https://webkit.org/b/147552>

Reviewed by Sam Weinig.

Update some functions involved in the construction of new Document objects
to codify that they always construct objects.

Bonus: DOMImplementation::createCSSStyleSheet().

dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createCSSStyleSheet):
(WebCore::DOMImplementation::createHTMLDocument):
(WebCore::DOMImplementation::createDocument):

dom/DOMImplementation.h:
loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::createDocument):
(WebCore::DocumentWriter::begin):

loader/DocumentWriter.h:
xml/DOMParser.cpp:

(WebCore::DOMParser::parseFromString):

xml/DOMParser.h:
xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::createDocumentFromSource):

xml/XSLTProcessor.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed