Timeline
Aug 30, 2015:
- 11:22 PM Changeset in webkit [189163] by
-
- 2 edits in trunk/LayoutTests
AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
https://bugs.webkit.org/show_bug.cgi?id=125720
Unreviewed. Skip failing tests on Windows due to lack of DRT implementations.
- platform/win/TestExpectations:
- 10:53 PM Changeset in webkit [189162] by
-
- 3 edits in trunk/Source/JavaScriptCore
[ES6] JSON.stringify should ignore object properties that have symbol values and convert the symbol values in array to null
https://bugs.webkit.org/show_bug.cgi?id=148628
Reviewed by Saam Barati.
As per ECMA262 6.0,
- JSON.stringify should ignore object properties that have symbol values.
SerializeJSONProperty[1] will return undefined if the value of the property is a symbol.
In this case, SerializeJSONObject[2] does not append any string for this property.
- JSON.stringify should convert the symbol values in array to null
As the same to the object case, SerializeJSONProperty will return undefined if the value of the property is a symbol.
But in the case of arrays, if the result of SerializeJSONProperty is undefined, it will emit "null"[3].
This behavior is already implemented in the existing JSON.stringify. Added tests to ensure that.
[1]: http://www.ecma-international.org/ecma-262/6.0/#sec-serializejsonproperty
[2]: http://www.ecma-international.org/ecma-262/6.0/#sec-serializejsonobject
[3]: http://www.ecma-international.org/ecma-262/6.0/#sec-serializejsonarray
- runtime/JSONObject.cpp:
(JSC::unwrapBoxedPrimitive):
(JSC::Stringifier::appendStringifiedValue):
(JSC::Stringifier::Holder::appendNextProperty):
- tests/stress/symbol-with-json.js:
(shouldBe):
- 4:29 PM Changeset in webkit [189161] by
-
- 6 edits in trunk/Source/WebCore
[CoordinatedGraphics] Remove unnecessary two virtual methods from TiledBackingStoreClient
https://bugs.webkit.org/show_bug.cgi?id=147137
Reviewed by Gyuyoung Kim.
tiledBackingStoreContentsRect() and tiledBackingStoreVisibleRect() are not
necessary because CoordinatedGraphicsLayer can pass them directly if needed.
This patch removes them in order to simplify code flow between TiledBackingStore
and CoordinatedGraphicsLayer.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::imageBackingVisible):
(WebCore::CoordinatedGraphicsLayer::adjustContentsScale):
(WebCore::clampToContentsRectIfRectIsInfinite):
(WebCore::CoordinatedGraphicsLayer::transformedVisibleRect):
(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreContentsRect): Deleted.
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreVisibleRect): Deleted.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
- platform/graphics/texmap/coordinated/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::createTilesIfNeeded):
(WebCore::TiledBackingStore::coverageRatio):
(WebCore::TiledBackingStore::visibleAreaIsCovered):
Used TiledBackingStore's m_visibleRect and m_rect, cached and scaled values for
visibleRect, contentsRect.
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::removeAllNonVisibleTiles):
(WebCore::TiledBackingStore::coverWithTilesIfNeeded): Renamed to createTilesIfNeeded.
(WebCore::TiledBackingStore::visibleRect): Deleted. nobody used.
- platform/graphics/texmap/coordinated/TiledBackingStore.h:
- platform/graphics/texmap/coordinated/TiledBackingStoreClient.h:
(WebCore::TiledBackingStoreClient::tiledBackingStoreHasPendingTileCreation):
Removed default implementation.
- 3:33 PM Changeset in webkit [189160] by
-
- 10 edits in trunk/Source/JavaScriptCore
JSC property attributes should fit in a byte
https://bugs.webkit.org/show_bug.cgi?id=148611
Reviewed by Sam Weinig.
I want to make room in PropertyMapEntry for more things to support property type inference (see
https://bugs.webkit.org/show_bug.cgi?id=148610). The most obvious candidate for a size reduction is
attributes, since we only have a small number of attribute bits. Even without complex changes, it
would have been possible to reduce the attribute field from 32 bits to 16 bits. Specifically, prior
to this change, the attributes field needed 9 bits. This made it very tempting to trim it so that
it could fit in a byte.
Luckily, many of the attributes bits are for the static lookup hashtables that we use for lazily
building objects in the standard library. Those bits don't need to stay around after the property
has been created, since they are just for telling the code in Lookup how to create the property.
So, this change separates the attributes bits into those that are interesting for Structure and
those that aren't. The ones used by Structure sit in the low 8 bits, allowing for the attributes
field in PropertyMapEntry to be a uint8_t. The attributes bits used only by Lookup use the higher
bits. In production, the conversion from the Lookup attributes to the Structure attributes is just
a cast to uint8_t. In debug, we assert that those bits are not dropped by accident. Code that
intentionally drops those bits calls attributesForStructure().
It turned out that there was a lot of code that was using the Function bit even in code that didn't
involve Lookup. This change removes those uses of Function. Structure does not need to know if we
think that a property points to a function.
- jsc.cpp:
(GlobalObject::finishCreation):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/JSObject.h:
- runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
- runtime/Lookup.h:
(JSC::getStaticPropertySlot):
(JSC::getStaticValueSlot):
(JSC::reifyStaticProperties):
- runtime/MathObject.cpp:
(JSC::MathObject::finishCreation):
- runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::finishCreation):
- runtime/PropertySlot.h:
(JSC::attributesForStructure):
(JSC::PropertySlot::setValue):
(JSC::PropertySlot::setCustom):
(JSC::PropertySlot::setCacheableCustom):
(JSC::PropertySlot::setGetterSlot):
(JSC::PropertySlot::setCacheableGetterSlot):
- runtime/Structure.h:
(JSC::PropertyMapEntry::PropertyMapEntry):
- 12:08 AM Changeset in webkit [189159] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, mark http/tests/w3c/dom/nodes/Element-matches.html as flaky.
Aug 29, 2015:
- 10:54 PM Changeset in webkit [189158] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rebaseline http/tests/w3c/dom/nodes/Element-matches.html
- http/tests/w3c/dom/nodes/Element-matches-expected.txt:
- 10:48 PM Changeset in webkit [189157] by
-
- 2 edits in trunk
Unreviewed build fix after r179923.
- Source/CMakeLists.txt:
bmalloc isn't ported to Windows yet.
- 10:11 PM Changeset in webkit [189156] by
-
- 7 edits in trunk/LayoutTests
Mac test result gardening.
Unmarked tests that no longer flake, updated a a few results.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/mac/compositing/reflections/load-video-in-reflection-expected.txt:
- platform/mac/editing/pasteboard/5478250-expected.png:
- platform/mac/editing/pasteboard/5478250-expected.txt:
- platform/mac/fast/loader/javascript-url-in-embed-expected.txt:
- 10:07 PM Changeset in webkit [189155] by
-
- 2 edits450 adds in trunk/LayoutTests
Import W3C DOM test suite from github.com/w3c/web-platform-tests
https://bugs.webkit.org/show_bug.cgi?id=148546
Reviewed by Alexey Proskuryakov.
Import W3C DOM test suite from github.com/w3c/web-platform-tests
to improve coverage and track progress.
- http/tests/w3c/dom/*: Added.
- 7:07 PM Changeset in webkit [189154] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix PropertyName::isNull() that was introduced in r188994.
The condition was reversed.
- runtime/PropertyName.h:
(JSC::PropertyName::isNull):
- 9:47 AM Changeset in webkit [189153] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Corrected email address
- 9:46 AM Changeset in webkit [189152] by
-
- 2 edits in trunk/Source/WebCore
El Capitan build fix.
- platform/graphics/cocoa/FontCascadeCocoa.mm:
(WebCore::FontCascade::drawGlyphs):
- 8:59 AM Changeset in webkit [189151] by
-
- 2 edits in trunk/Source/WTF
[WTF] Improve a ParkingLot::parkConditionally() comment for a libstdc++ workaround
https://bugs.webkit.org/show_bug.cgi?id=148571
Reviewed by Filip Pizlo.
- wtf/ParkingLot.cpp:
(WTF::ParkingLot::parkConditionally): Adjust the comment about the workaround for
the libstdc++ std::condition_variable implementation, linking to the WebKit bug
that dissected the problem and the GCC bug that originally reported the problem.
- 8:50 AM Changeset in webkit [189150] by
-
- 1 edit in trunk/Websites/webkit.org/ChangeLog
Restored ChangeLog entries that were accidentally deleted in r189110.
- 12:41 AM Changeset in webkit [189149] by
-
- 14 edits18 adds in trunk
AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
https://bugs.webkit.org/show_bug.cgi?id=125720
Reviewed by Daniel Bates.
Source/WebCore:
The scrollToVisible code did not account for scrollable elements that are larger than their viewports.
First, we need to pass the sub-focus up the scroll chain (otherwise we'll scroll some parent to y=0).
Second, we should try to center the focus within the viewport, rather than positioning at the bottom for a
better experience.
This change was adapted from Blink r183926:
https://src.chromium.org/viewvc/blink?view=rev&revision=183926
Tests: accessibility/scroll-to-global-point-iframe-nested.html
accessibility/scroll-to-global-point-iframe.html
accessibility/scroll-to-global-point-main-window.html
accessibility/scroll-to-global-point-nested.html
accessibility/scroll-to-make-visible-div-overflow.html
accessibility/scroll-to-make-visible-iframe.html
accessibility/scroll-to-make-visible-nested-2.html
accessibility/scroll-to-make-visible-nested.html
accessibility/scroll-to-make-visible-with-subfocus.html
- accessibility/AccessibilityObject.cpp:
(WebCore::computeBestScrollOffset):
(WebCore::AccessibilityObject::isOnscreen):
(WebCore::AccessibilityObject::scrollToMakeVisibleWithSubFocus):
(WebCore::AccessibilityObject::scrollToGlobalPoint):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityScrollToVisible]):
(-[WebAccessibilityObjectWrapper _accessibilityScrollToMakeVisibleWithSubFocus:]):
(-[WebAccessibilityObjectWrapper _accessibilityScrollToGlobalPoint:]):
(-[WebAccessibilityObjectWrapper accessibilityPerformAction:]):
Tools:
Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
- DumpRenderTree/AccessibilityUIElement.cpp:
(pressCallback):
(scrollToMakeVisibleWithSubFocusCallback):
(scrollToGlobalPointCallback):
(scrollToMakeVisibleCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
(AccessibilityUIElement::selectedTextRange):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::mathPrescriptsDescription):
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::isTextMarkerValid):
(WTR::AccessibilityUIElement::textMarkerForIndex):
(WTR::AccessibilityUIElement::scrollToMakeVisible):
(WTR::AccessibilityUIElement::scrollToGlobalPoint):
(WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(WTR::AccessibilityUIElement::supportedActions):
(WTR::AccessibilityUIElement::mathPostscriptsDescription):
(WTR::AccessibilityUIElement::mathPrescriptsDescription):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::scrollToMakeVisible):
(WTR::AccessibilityUIElement::scrollToGlobalPoint):
(WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(WTR::AccessibilityUIElement::selectedTextRange):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::scrollToMakeVisible):
(WTR::AccessibilityUIElement::scrollToGlobalPoint):
(WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(WTR::AccessibilityUIElement::selectedTextRange):
LayoutTests:
- accessibility/scroll-to-global-point-iframe-expected.txt: Added.
- accessibility/scroll-to-global-point-iframe-nested-expected.txt: Added.
- accessibility/scroll-to-global-point-iframe-nested.html: Added.
- accessibility/scroll-to-global-point-iframe.html: Added.
- accessibility/scroll-to-global-point-main-window-expected.txt: Added.
- accessibility/scroll-to-global-point-main-window.html: Added.
- accessibility/scroll-to-global-point-nested-expected.txt: Added.
- accessibility/scroll-to-global-point-nested.html: Added.
- accessibility/scroll-to-make-visible-div-overflow-expected.txt: Added.
- accessibility/scroll-to-make-visible-div-overflow.html: Added.
- accessibility/scroll-to-make-visible-iframe-expected.txt: Added.
- accessibility/scroll-to-make-visible-iframe.html: Added.
- accessibility/scroll-to-make-visible-nested-2-expected.txt: Added.
- accessibility/scroll-to-make-visible-nested-2.html: Added.
- accessibility/scroll-to-make-visible-nested-expected.txt: Added.
- accessibility/scroll-to-make-visible-nested.html: Added.
- accessibility/scroll-to-make-visible-with-subfocus-expected.txt: Added.
- accessibility/scroll-to-make-visible-with-subfocus.html: Added.
- 12:26 AM WebKitEFLLayoutTest edited by
- (diff)
