Context Navigation

← Previous Period
Next Period →

Timeline

Sep 5, 2015:

11:30 PM Changeset in webkit [189443] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix JSDollarVMPrototype after r189160.
https://bugs.webkit.org/show_bug.cgi?id=148900

Reviewed by Michael Saboff.

JSDollarVMPrototype needs to be updated to match http://trac.webkit.org/changeset/189160 i.e.
remove the use of JSC::Function bit in its property attributes.

tools/JSDollarVMPrototype.cpp:

(JSC::JSDollarVMPrototype::finishCreation):

7:33 PM Changeset in webkit [189442] by Michael Catanzaro

2 edits in trunk/Source/WebKit2

Leak in WebContextInjectedBundleClient::getInjectedBundleInitializationUserData
https://bugs.webkit.org/show_bug.cgi?id=148769

Fix suggested by Zan Dobersek.

Reviewed by Darin Adler.

UIProcess/WebContextInjectedBundleClient.cpp:

(WebKit::WebContextInjectedBundleClient::getInjectedBundleInitializationUserData):

6:50 PM Changeset in webkit [189441] by ljaehun.lim@samsung.com

2 edits in trunk/Source/WebCore

Remove unused macros from StyleResolver.cpp
https://bugs.webkit.org/show_bug.cgi?id=148163

Reviewed by Andreas Kling.

HANDLE_INHERIT and HANDLE_INHERIT_AND_INITIAL are not used after
StyleBuilder refactoring.

No new tests because there is no behavior change.

css/StyleResolver.cpp:

Remove HANDLE_INHERIT and HANDLE_INHERIT_AND_INITIAL.

5:47 PM WikiStart edited by mmaxfield@apple.com

(diff)

5:46 PM FontSelection edited by mmaxfield@apple.com

(diff)

5:45 PM FontSelection edited by mmaxfield@apple.com

(diff)

5:42 PM Fonts 3.png attached to FontSelection by mmaxfield@apple.com

5:42 PM Fonts 2.png attached to FontSelection by mmaxfield@apple.com

5:42 PM Fonts.png attached to FontSelection by mmaxfield@apple.com

5:37 PM FontSelection created by mmaxfield@apple.com

1:54 PM Changeset in webkit [189440] by jhoneycutt@apple.com

2 edits
4 adds in trunk/LayoutTests

Import a couple of Chromium accesskey tests.
https://bugs.webkit.org/show_bug.cgi?id=148865

Reviewed by Daniel Bates.

fast/forms/access-key-case-insensitive-expected.txt: Added.
fast/forms/access-key-case-insensitive.html: Added.
fast/forms/access-key-mutated-expected.txt: Added.
fast/forms/access-key-mutated.html: Added.
platform/ios-simulator/TestExpectations:

These tests are asynchronous and use unsupported features; skip them on
iOS so they don't time out.

1:43 PM AssociatingInformationWithTests edited by mmaxfield@apple.com

(diff)

1:41 PM AssociatingInformationWithTests edited by mmaxfield@apple.com

(diff)

1:39 PM AssociatingInformationWithTests created by mmaxfield@apple.com

12:45 PM Changeset in webkit [189439] by Yusuke Suzuki

2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix the module name resolution in Windows
https://bugs.webkit.org/show_bug.cgi?id=148689

Attempt to fix the module name resolution in Windows.
A module name is represented as the UNIX path under the current module tests.
This fix split the module name with '/' instead of pathSeparator().

This is only utilized by the jsc.cpp for the local module tests.
So, WebKit production and JavaScriptCore framework are not affected by this change.

jsc.cpp:

(ModuleName::startsWithRoot):
(ModuleName::ModuleName):
(resolvePath):
(GlobalObject::moduleLoaderResolve):

11:52 AM Changeset in webkit [189438] by BJ Burg

72 edits in trunk/Source

Web Inspector: tighten up lifetimes for Agent-owned objects, and initialize agents using contexts
https://bugs.webkit.org/show_bug.cgi?id=148625

Reviewed by Joseph Pecoraro.

All agents own their domain-specific frontend and backend dispatchers. Change so that
they are initialized in constructors rather than when a frontend connects or disconnects.
This may cause additional memory use, but this can be counteracted by lazily creating
some agents that are not required for other agents to function (i.e., runtime and page agents).

To avoid adding frontend/backend dispatcher arguments to every single agent constructor,
change agent construction to take a AgentContext or a subclass of it. This provides agents with
references to objects in the owning InspectorEnvironment subclass that are guaranteed to
outlive all agents. AgentContext and its subclasses follow the existing Agent class hierarchy.

Source/JavaScriptCore:

inspector/InspectorAgentBase.h:

(Inspector::JSAgentContext::JSAgentContext):

inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::disconnectFrontend):
(Inspector::JSGlobalObjectInspectorController::disconnectAllFrontends):
(Inspector::JSGlobalObjectInspectorController::appendExtraAgent):

inspector/JSGlobalObjectInspectorController.h:
inspector/agents/InspectorAgent.cpp:

(Inspector::InspectorAgent::InspectorAgent):
(Inspector::InspectorAgent::didCreateFrontendAndBackend):
(Inspector::InspectorAgent::willDestroyFrontendAndBackend):

inspector/agents/InspectorAgent.h:
inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::InspectorConsoleAgent):
(Inspector::InspectorConsoleAgent::didCreateFrontendAndBackend):
(Inspector::InspectorConsoleAgent::willDestroyFrontendAndBackend):

inspector/agents/InspectorConsoleAgent.h:
inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::InspectorDebuggerAgent):
(Inspector::InspectorDebuggerAgent::didCreateFrontendAndBackend):
(Inspector::InspectorDebuggerAgent::willDestroyFrontendAndBackend):

inspector/agents/InspectorDebuggerAgent.h:
inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::InspectorRuntimeAgent):

inspector/agents/InspectorRuntimeAgent.h:
inspector/agents/JSGlobalObjectConsoleAgent.cpp:

(Inspector::JSGlobalObjectConsoleAgent::JSGlobalObjectConsoleAgent):

inspector/agents/JSGlobalObjectConsoleAgent.h:
inspector/agents/JSGlobalObjectDebuggerAgent.cpp:

(Inspector::JSGlobalObjectDebuggerAgent::JSGlobalObjectDebuggerAgent):

inspector/agents/JSGlobalObjectDebuggerAgent.h:
inspector/agents/JSGlobalObjectRuntimeAgent.cpp:

(Inspector::JSGlobalObjectRuntimeAgent::JSGlobalObjectRuntimeAgent):
(Inspector::JSGlobalObjectRuntimeAgent::didCreateFrontendAndBackend):

inspector/agents/JSGlobalObjectRuntimeAgent.h:
inspector/augmentable/AlternateDispatchableAgent.h:
inspector/augmentable/AugmentableInspectorController.h: Alternate agents should

have access to frontend router and backend dispatcher at construction time.

inspector/scripts/codegen/cpp_generator_templates.py:
inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py:

(CppFrontendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_event):

inspector/scripts/codegen/objc_generator_templates.py:

Source/WebCore:

No new tests, no behavior changed.

bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::removeListener):
(WebCore::WorkerScriptDebugServer::runEventLoopWhilePaused):

bindings/js/WorkerScriptDebugServer.h:
inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::didCreateFrontendAndBackend):
(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::willDestroyFrontendAndBackend):

inspector/InspectorApplicationCacheAgent.h:
inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::didCreateFrontendAndBackend):
(WebCore::InspectorCSSAgent::willDestroyFrontendAndBackend):

inspector/InspectorCSSAgent.h:
inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMAgent::willDestroyFrontendAndBackend):

inspector/InspectorDOMAgent.h:
inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMDebuggerAgent::willDestroyFrontendAndBackend):

inspector/InspectorDOMDebuggerAgent.h:
inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMStorageAgent::findStorageArea):
(WebCore::InspectorDOMStorageAgent::willDestroyFrontendAndBackend):

inspector/InspectorDOMStorageAgent.h:
inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDatabaseAgent::willDestroyFrontendAndBackend):

inspector/InspectorDatabaseAgent.h:
inspector/InspectorIndexedDBAgent.cpp:

(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::didCreateFrontendAndBackend):
(WebCore::InspectorIndexedDBAgent::willDestroyFrontendAndBackend):

inspector/InspectorIndexedDBAgent.h:
inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):

inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):
(WebCore::InspectorLayerTreeAgent::didCreateFrontendAndBackend):
(WebCore::InspectorLayerTreeAgent::willDestroyFrontendAndBackend):

inspector/InspectorLayerTreeAgent.h:
inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::didCreateFrontendAndBackend):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::reload):
(WebCore::InspectorPageAgent::navigate):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::deleteCookie):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::getScriptExecutionStatus):
(WebCore::InspectorPageAgent::setScriptExecutionDisabled):
(WebCore::InspectorPageAgent::mainFrame):
(WebCore::InspectorPageAgent::findFrameWithSecurityOrigin):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
(WebCore::InspectorPageAgent::setEmulatedMedia):
(WebCore::InspectorPageAgent::getCompositingBordersVisible):
(WebCore::InspectorPageAgent::setCompositingBordersVisible):
(WebCore::InspectorPageAgent::snapshotNode):
(WebCore::InspectorPageAgent::snapshotRect):
(WebCore::InspectorPageAgent::archive):
(WebCore::InspectorPageAgent::willDestroyFrontendAndBackend):

inspector/InspectorPageAgent.h:
inspector/InspectorReplayAgent.cpp:

(WebCore::InspectorReplayAgent::InspectorReplayAgent):
(WebCore::InspectorReplayAgent::didCreateFrontendAndBackend):
(WebCore::InspectorReplayAgent::willDestroyFrontendAndBackend):

inspector/InspectorReplayAgent.h:
inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::InspectorResourceAgent):
(WebCore::InspectorResourceAgent::didCreateFrontendAndBackend):
(WebCore::InspectorResourceAgent::willDestroyFrontendAndBackend):

inspector/InspectorResourceAgent.h:
inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorTimelineAgent::page):

inspector/InspectorTimelineAgent.h:
inspector/InspectorWebAgentBase.h:

(WebCore::WebAgentContext::WebAgentContext):
(WebCore::PageAgentContext::PageAgentContext):
(WebCore::WorkerAgentContext::WorkerAgentContext):
(WebCore::InspectorAgentBase::InspectorAgentBase):

inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorWorkerAgent::willDestroyFrontendAndBackend):

inspector/InspectorWorkerAgent.h:
inspector/PageConsoleAgent.cpp:

(WebCore::PageConsoleAgent::PageConsoleAgent):

inspector/PageConsoleAgent.h:
inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::PageDebuggerAgent):
(WebCore::PageDebuggerAgent::sourceMapURLForScript):
(WebCore::PageDebuggerAgent::breakpointActionLog):
(WebCore::PageDebuggerAgent::injectedScriptForEval):

inspector/PageDebuggerAgent.h:
inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::PageRuntimeAgent):
(WebCore::PageRuntimeAgent::didCreateFrontendAndBackend):
(WebCore::PageRuntimeAgent::injectedScriptForEval):
(WebCore::PageRuntimeAgent::reportExecutionContextCreation):
(WebCore::PageRuntimeAgent::willDestroyFrontendAndBackend):

inspector/PageRuntimeAgent.h:
inspector/WebConsoleAgent.cpp:

(WebCore::WebConsoleAgent::WebConsoleAgent):

inspector/WebConsoleAgent.h:
inspector/WebDebuggerAgent.cpp:

(WebCore::WebDebuggerAgent::WebDebuggerAgent):

inspector/WebDebuggerAgent.h:
inspector/WorkerConsoleAgent.cpp:

(WebCore::WorkerConsoleAgent::WorkerConsoleAgent):

inspector/WorkerConsoleAgent.h:
inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::interruptAndDispatchInspectorCommands):
(WebCore::WorkerDebuggerAgent::breakpointActionLog):
(WebCore::WorkerDebuggerAgent::injectedScriptForEval):

inspector/WorkerDebuggerAgent.h:
inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
(WebCore::WorkerRuntimeAgent::didCreateFrontendAndBackend):
(WebCore::WorkerRuntimeAgent::injectedScriptForEval):
(WebCore::WorkerRuntimeAgent::willDestroyFrontendAndBackend):

inspector/WorkerRuntimeAgent.h:

10:44 AM Changeset in webkit [189437] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, skip http/tests/w3c/html/semantics/embedded-content/media-elements/* tests on Win/Debug.

Filed Bug 148903 to track the problem.

platform/win/TestExpectations:

10:33 AM Changeset in webkit [189436] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, mark imported/w3c/css/css-multicol-1/multicol-span-all-001.xht as failing on Windows.

platform/win/TestExpectations:

10:33 AM Changeset in webkit [189435] by commit-queue@webkit.org

4 edits in trunk/Tools

Web Inspector: Improve prepare-ChangeLog for multiple cases
https://bugs.webkit.org/show_bug.cgi?id=148875

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-05
Reviewed by Timothy Hatcher.

Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_javascript):

We were ignoring everything inside of an anonymous function expression, such as (function(){ ... }), which made InjectedScriptSource produce nothing. Better handle this by inserting a few tweaks.
Allow method syntax outside of classes as long as they are at the global level.
Avoid treating "get" and "set" as getter/setter functions in bad contexts.

Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:

(Foo.prototype.method1):
(Foo.prototype.method2):
(Foo.prototype.method3.innerFunction):
(Foo.prototype.method3):
(insideGlobalAnonymousFunctionExpression):
(foo.insideGlobalFunctionExpression):
(IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
(IssueWithMapGetAndSet.prototype.method1):
(IssueWithMapGetAndSet.prototype.method2):
(IssueWithMapGetAndSet.prototype.method3):
(IssueWithMapGetAndSet):

10:27 AM Changeset in webkit [189434] by Chris Dumez

1 edit
28 adds in trunk/LayoutTests

Unreviewed, land Windows baselines for the new W3C html tests imported in r189394.

platform/win/http/tests/w3c/html/dom/interfaces-expected.txt: Added.
platform/win/http/tests/w3c/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt: Added.
platform/win/http/tests/w3c/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-expected.txt: Added.
platform/win/http/tests/w3c/html/semantics/embedded-content/the-img-element/srcset/parse-a-srcset-attribute-expected.txt: Added.
platform/win/http/tests/w3c/html/semantics/embedded-content/the-img-element/srcset/select-an-image-source-expected.txt: Added.
platform/win/http/tests/w3c/html/semantics/embedded-content/the-img-element/update-the-source-set-expected.txt: Added.
platform/win/http/tests/w3c/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt: Added.
platform/win/http/tests/w3c/html/semantics/forms/constraints/form-validation-willValidate-expected.txt: Added.
platform/win/http/tests/w3c/html/semantics/forms/textfieldselection/selection-not-application-expected.txt: Added.
platform/win/http/tests/w3c/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange-expected.txt: Added.
platform/win/http/tests/w3c/html/semantics/forms/the-input-element/color-expected.txt: Added.
platform/win/http/tests/w3c/html/semantics/forms/the-input-element/input-textselection-01-expected.txt: Added.
platform/win/http/tests/w3c/html/semantics/forms/the-input-element/type-change-state-expected.txt: Added.
platform/win/http/tests/w3c/html/semantics/forms/the-input-element/valueMode-expected.txt: Added.

9:06 AM Changeset in webkit [189433] by BJ Burg

75 edits
1 delete in trunk/Source

Web Inspector: agents should send messages through FrontendRouter instead of FrontendChannel
https://bugs.webkit.org/show_bug.cgi?id=148492

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Replace uses of FrontendChannel with FrontendRouter. Minor cleanups along the way.

Make AgentRegistry automatically signal discardAgent() in its destructor, since it always
gets executed in the owning controller's destructor anyway.

inspector/InspectorAgentBase.h:
inspector/InspectorAgentRegistry.cpp:

(Inspector::AgentRegistry::~AgentRegistry):
(Inspector::AgentRegistry::didCreateFrontendAndBackend):
(Inspector::AgentRegistry::willDestroyFrontendAndBackend):
(Inspector::AgentRegistry::discardAgents): Deleted.

inspector/InspectorAgentRegistry.h:
inspector/InspectorBackendDispatcher.cpp:
inspector/InspectorFrontendRouter.cpp:

(Inspector::FrontendRouter::leakChannel): Deleted, no longer necessary.

inspector/InspectorFrontendRouter.h:
inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::appendExtraAgent):
(Inspector::JSGlobalObjectInspectorController::~JSGlobalObjectInspectorController):

inspector/JSGlobalObjectInspectorController.h:
inspector/agents/InspectorAgent.cpp:

(Inspector::InspectorAgent::didCreateFrontendAndBackend):

inspector/agents/InspectorAgent.h:
inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::didCreateFrontendAndBackend):

inspector/agents/InspectorConsoleAgent.h:
inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::didCreateFrontendAndBackend):

inspector/agents/InspectorDebuggerAgent.h:
inspector/agents/JSGlobalObjectRuntimeAgent.cpp:

(Inspector::JSGlobalObjectRuntimeAgent::didCreateFrontendAndBackend):

inspector/agents/JSGlobalObjectRuntimeAgent.h:
inspector/augmentable/AlternateDispatchableAgent.h:
inspector/remote/RemoteInspectorDebuggable.cpp:
inspector/scripts/codegen/cpp_generator_templates.py:
inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:

(CppBackendDispatcherImplementationGenerator.generate_output):

inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:

(CppFrontendDispatcherHeaderGenerator.generate_output.FrontendRouter):
(CppFrontendDispatcherHeaderGenerator.generate_output):

inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py:

(CppFrontendDispatcherImplementationGenerator.generate_output):
(CppFrontendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_event):

inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py:

(ObjCConfigurationImplementationGenerator.generate_output):

inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:

(ObjCFrontendDispatcherImplementationGenerator.generate_output):

Source/WebCore:

Replace uses of FrontendChannel with FrontendRouter. Minor code cleanup along the way.

No new tests, no behavior changed.

WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::didCreateFrontendAndBackend):

inspector/InspectorApplicationCacheAgent.h:
inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::didCreateFrontendAndBackend):

inspector/InspectorCSSAgent.h:
inspector/InspectorController.cpp:

(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::~InspectorController): No need to call discardAgents().

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):

inspector/InspectorDOMAgent.h:
inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::didCreateFrontendAndBackend):

inspector/InspectorDOMDebuggerAgent.h:
inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::didCreateFrontendAndBackend):

inspector/InspectorDOMStorageAgent.h:
inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::didCreateFrontendAndBackend):

inspector/InspectorDatabaseAgent.h:
inspector/InspectorForwarding.h: Removed.
inspector/InspectorIndexedDBAgent.cpp:

(WebCore::InspectorIndexedDBAgent::didCreateFrontendAndBackend):

inspector/InspectorIndexedDBAgent.h:
inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::didCreateFrontendAndBackend):

inspector/InspectorLayerTreeAgent.h:
inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::didCreateFrontendAndBackend):

inspector/InspectorPageAgent.h:
inspector/InspectorReplayAgent.cpp:

(WebCore::InspectorReplayAgent::didCreateFrontendAndBackend):

inspector/InspectorReplayAgent.h:
inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didCreateFrontendAndBackend):

inspector/InspectorResourceAgent.h:
inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend):

inspector/InspectorTimelineAgent.h:
inspector/InspectorWebAgentBase.h:
inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::didCreateFrontendAndBackend):

inspector/InspectorWorkerAgent.h:
inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::didCreateFrontendAndBackend):

inspector/PageRuntimeAgent.h:
inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::connectFrontend):

inspector/WorkerInspectorController.h:
inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::didCreateFrontendAndBackend):

inspector/WorkerRuntimeAgent.h:
page/PageDebuggable.cpp:
testing/Internals.cpp:

Source/WebKit/mac:

WebCoreSupport/WebInspectorClient.h: Clean up the forward declarations, don't use InspectorForwarding.h.
WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::openInspectorFrontend):

Source/WebKit/win:

Stop using InspectorForwarding.h.

WebCoreSupport/WebInspectorClient.h:

Source/WebKit2:

Stop using InspectorForwarding.h.

WebProcess/WebPage/WebInspector.h:
WebProcess/WebPage/WebInspectorUI.h:

1:47 AM Changeset in webkit [189432] by commit-queue@webkit.org

11 edits in trunk/Source/WebCore

Add a new ResourceLoaderOption to avoid page defers loading mechanisms for inspector
https://bugs.webkit.org/show_bug.cgi?id=148727

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-05
Reviewed by Antti Koivisto.

This will be tested shortly by inspector tests.

loader/ResourceLoaderOptions.h:

(WebCore::ResourceLoaderOptions::ResourceLoaderOptions):
(WebCore::ResourceLoaderOptions::defersLoadingPolicy):
(WebCore::ResourceLoaderOptions::setDefersLoadingPolicy):
Add a new policy for defers loading. The default is to allow defers loading.

loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::ResourceLoader):
(WebCore::ResourceLoader::init):
(WebCore::ResourceLoader::setDefersLoading):
Respect the defers loading policy whenever we would set defers loading status.

inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::loadResource):
Switch from incorrectly changing the defersLoading state of the loader
to setting an option to disallow defers loading entirely for the loader.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startLoadingMainResource):

loader/MediaResourceLoader.cpp:

(WebCore::MediaResourceLoader::start):

loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::defaultCachedResourceOptions):

loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading):

platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:

(WebCore::WebCoreAVCFResourceLoader::startLoading):

platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::WebCoreAVFResourceLoader::startLoading):
Add the new value to instance of the longhand ResourceLoaderOptions constructor.

12:44 AM Changeset in webkit [189431] by Yusuke Suzuki

9 edits
156 adds in trunk

[ES6] Enable ES6 Module in JSC shell by default
https://bugs.webkit.org/show_bug.cgi?id=148689

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Enable ES6 Modules in JSC shell by default. Compile time flag is left for WebCore.
Since the entry point to evaluate the modules are completely separated from the usual
entry point to evaluate the script, we can safely enable ES6 modules in JSC shell.

And add bunch of tests for ES6 Modules.

jsc.cpp:

(GlobalObject::finishCreation):
(functionLoadModule):
(runWithScripts):
(printUsageStatement): Deleted.
(CommandLine::parseArguments): Deleted.

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseInner): Deleted.

tests/modules.yaml: Added.
tests/modules/aliasing.js: Added.
tests/modules/aliasing/drink-2.js: Added.

(export.let.Cappuccino.string_appeared_here.export.changeCappuccino):

tests/modules/aliasing/drink.js: Added.

(export.changeCocoa):

tests/modules/cyclic-may-produce-tdz.js: Added.
tests/modules/cyclic-may-produce-tdz/1.js: Added.
tests/modules/cyclic-may-produce-tdz/2.js: Added.
tests/modules/default-error/main.js: Added.
tests/modules/default-value-case-should-be-copied.js: Added.
tests/modules/default-value-case-should-be-copied/module.js: Added.

(export.changeValue):

tests/modules/defaults.js: Added.
tests/modules/defaults/Cappuccino.js: Added.
tests/modules/defaults/Cocoa.js: Added.

(export.default.Cocoa):

tests/modules/defaults/Matcha.js: Added.
tests/modules/destructuring-export.js: Added.
tests/modules/destructuring-export/array.js: Added.
tests/modules/destructuring-export/main.js: Added.
tests/modules/execution-order-cyclic.js: Added.
tests/modules/execution-order-cyclic/1.js: Added.
tests/modules/execution-order-cyclic/10.js: Added.
tests/modules/execution-order-cyclic/11.js: Added.
tests/modules/execution-order-cyclic/2.js: Added.
tests/modules/execution-order-cyclic/3.js: Added.
tests/modules/execution-order-cyclic/4.js: Added.
tests/modules/execution-order-cyclic/5.js: Added.
tests/modules/execution-order-cyclic/6.js: Added.
tests/modules/execution-order-cyclic/7.js: Added.
tests/modules/execution-order-cyclic/8.js: Added.
tests/modules/execution-order-cyclic/9.js: Added.
tests/modules/execution-order-dag.js: Added.
tests/modules/execution-order-dag/1.js: Added.
tests/modules/execution-order-dag/10.js: Added.
tests/modules/execution-order-dag/2.js: Added.
tests/modules/execution-order-dag/3.js: Added.
tests/modules/execution-order-dag/4.js: Added.
tests/modules/execution-order-dag/5.js: Added.
tests/modules/execution-order-dag/6.js: Added.
tests/modules/execution-order-dag/7.js: Added.
tests/modules/execution-order-dag/8.js: Added.
tests/modules/execution-order-dag/9.js: Added.
tests/modules/execution-order-depth.js: Added.
tests/modules/execution-order-depth/1.js: Added.
tests/modules/execution-order-depth/2.js: Added.
tests/modules/execution-order-depth/3.js: Added.
tests/modules/execution-order-self.js: Added.
tests/modules/execution-order-sibling.js: Added.
tests/modules/execution-order-sibling/1.js: Added.
tests/modules/execution-order-sibling/2.js: Added.
tests/modules/execution-order-sibling/3.js: Added.
tests/modules/execution-order-tree.js: Added.
tests/modules/execution-order-tree/1.js: Added.
tests/modules/execution-order-tree/10.js: Added.
tests/modules/execution-order-tree/11.js: Added.
tests/modules/execution-order-tree/2.js: Added.
tests/modules/execution-order-tree/3.js: Added.
tests/modules/execution-order-tree/4.js: Added.
tests/modules/execution-order-tree/5.js: Added.
tests/modules/execution-order-tree/6.js: Added.
tests/modules/execution-order-tree/7.js: Added.
tests/modules/execution-order-tree/8.js: Added.
tests/modules/execution-order-tree/9.js: Added.
tests/modules/export-conflict-ok.js: Added.
tests/modules/export-conflict-ok/A.js: Added.
tests/modules/export-conflict-ok/B.js: Added.
tests/modules/export-conflict-ok/main.js: Added.
tests/modules/export-from.js: Added.
tests/modules/export-from/main.js: Added.
tests/modules/export-from/second.js: Added.
tests/modules/export-with-declarations-list.js: Added.
tests/modules/export-with-declarations-list/main.js: Added.
tests/modules/exported-function-may-be-called-before-module-is-executed.js: Added.
tests/modules/exported-function-may-be-called-before-module-is-executed/1.js: Added.
tests/modules/exported-function-may-be-called-before-module-is-executed/2.js: Added.

(export.add):
(export.raise):

tests/modules/import-error.js: Added.
tests/modules/import-error/export-ambiguous-1.js: Added.
tests/modules/import-error/export-ambiguous-2.js: Added.
tests/modules/import-error/export-ambiguous.js: Added.
tests/modules/import-error/export-default-from-star-2.js: Added.

(export.default.Cocoa):

tests/modules/import-error/export-default-from-star.js: Added.
tests/modules/import-error/export-not-found.js: Added.
tests/modules/import-error/import-ambiguous.js: Added.
tests/modules/import-error/import-default-from-star.js: Added.
tests/modules/import-error/import-not-found.js: Added.
tests/modules/imported-bindings-are-immutable.js: Added.
tests/modules/imported-bindings-are-immutable/bindings.js: Added.

(export.functionDeclaration):
(export.classDeclaration):

tests/modules/imported-bindings-can-be-changed-in-original-module.js: Added.
tests/modules/imported-bindings-can-be-changed-in-original-module/bindings.js: Added.
tests/modules/indirect-export-error.js: Added.
tests/modules/indirect-export-error/indirect-export-ambiguous-2.js: Added.
tests/modules/indirect-export-error/indirect-export-ambiguous-3.js: Added.
tests/modules/indirect-export-error/indirect-export-ambiguous-4.js: Added.
tests/modules/indirect-export-error/indirect-export-ambiguous.js: Added.
tests/modules/indirect-export-error/indirect-export-default-2.js: Added.
tests/modules/indirect-export-error/indirect-export-default-3.js: Added.

(export.default.Cocoa):

tests/modules/indirect-export-error/indirect-export-default.js: Added.
tests/modules/indirect-export-error/indirect-export-not-found-2.js: Added.
tests/modules/indirect-export-error/indirect-export-not-found.js: Added.
tests/modules/module-eval.js: Added.
tests/modules/module-eval/A.js: Added.
tests/modules/module-eval/B.js: Added.
tests/modules/module-eval/drink.js: Added.
tests/modules/module-is-strict-code.js: Added.
tests/modules/namespace-ambiguous.js: Added.
tests/modules/namespace-ambiguous/ambiguous-2.js: Added.
tests/modules/namespace-ambiguous/ambiguous-3.js: Added.
tests/modules/namespace-ambiguous/ambiguous-4.js: Added.
tests/modules/namespace-ambiguous/ambiguous.js: Added.
tests/modules/namespace-error.js: Added.
tests/modules/namespace-error/namespace-local-error-should-hide-global-ambiguity-2.js: Added.
tests/modules/namespace-error/namespace-local-error-should-hide-global-ambiguity-3.js: Added.
tests/modules/namespace-error/namespace-local-error-should-hide-global-ambiguity-4.js: Added.
tests/modules/namespace-error/namespace-local-error-should-hide-global-ambiguity-5.js: Added.
tests/modules/namespace-error/namespace-local-error-should-hide-global-ambiguity-6.js: Added.
tests/modules/namespace-error/namespace-local-error-should-hide-global-ambiguity-7.js: Added.
tests/modules/namespace-error/namespace-local-error-should-hide-global-ambiguity.js: Added.
tests/modules/namespace-tdz.js: Added.
tests/modules/namespace-tdz/A.js: Added.
tests/modules/namespace-tdz/B.js: Added.

(export.later):

tests/modules/namespace-tdz/main.js: Added.
tests/modules/namespace.js: Added.
tests/modules/namespace/additional-drink.js: Added.
tests/modules/namespace/drink.js: Added.

(export.default.changeCappuccino):

tests/modules/namespace/more-additional-drink.js: Added.
tests/modules/resources/assert.js: Added.

(export.shouldBe):
(export.shouldThrow):

tests/modules/scopes.js: Added.
tests/modules/scopes/additional-drink.js: Added.
tests/modules/scopes/drink.js: Added.

(export.default.changeCappuccino):

tests/modules/scopes/more-additional-drink.js: Added.
tests/modules/this-should-be-undefined.js: Added.
tests/stress/modules-syntax-error-with-names.js:
tests/stress/modules-syntax-error.js:
tests/stress/modules-syntax.js:

Tools:

Scripts/run-javascriptcore-tests:

(runJSCStressTests):

Scripts/run-jsc-stress-tests:

12:29 AM Changeset in webkit [189430] by ap@apple.com

4 edits in trunk/LayoutTests

Fix lint warnings on iOS.

This enables the correct expectation for fast/events/scroll-in-scaled-page-with-overflow-hidden.html.
For other tests, I went with the expectation that was currently in effect.

Re-landing, as this had to be rolled out together with another patch.

platform/ios-simulator-wk1/TestExpectations:
platform/ios-simulator-wk2/TestExpectations:
platform/ios-simulator/TestExpectations:

12:22 AM Changeset in webkit [189429] by Yusuke Suzuki

9 edits
2 adds in trunk/Source/JavaScriptCore

[ES6] Implement ModuleNamespaceObject
https://bugs.webkit.org/show_bug.cgi?id=148705

Reviewed by Geoffrey Garen.

Implement Module namespace object.
That is used when importing the module with the form import * as namespace from "mod".
The module namespace object is non-extensible object that has the bindings to the original module
as the property.

CMakeLists.txt:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::moduleNamespaceObjectStructure):

runtime/JSModuleNamespaceObject.cpp: Added.

(JSC::JSModuleNamespaceObject::JSModuleNamespaceObject):
(JSC::JSModuleNamespaceObject::finishCreation):
(JSC::JSModuleNamespaceObject::destroy):
(JSC::JSModuleNamespaceObject::visitChildren):
(JSC::callbackGetter):
(JSC::JSModuleNamespaceObject::getOwnPropertySlot):
(JSC::JSModuleNamespaceObject::put):
(JSC::JSModuleNamespaceObject::putByIndex):
(JSC::JSModuleNamespaceObject::deleteProperty):
(JSC::JSModuleNamespaceObject::getOwnPropertyNames):
(JSC::JSModuleNamespaceObject::defineOwnProperty):
(JSC::moduleNamespaceObjectSymbolIterator):

runtime/JSModuleNamespaceObject.h: Added.

(JSC::JSModuleNamespaceObject::create):
(JSC::JSModuleNamespaceObject::createStructure):
(JSC::JSModuleNamespaceObject::moduleRecord):

runtime/JSModuleRecord.cpp:

(JSC::JSModuleRecord::visitChildren):
(JSC::getExportedNames):
(JSC::JSModuleRecord::getModuleNamespace):
(JSC::JSModuleRecord::instantiateDeclarations):

runtime/JSModuleRecord.h:

12:18 AM Changeset in webkit [189428] by commit-queue@webkit.org

4 edits
2 deletes in trunk/LayoutTests

Unreviewed, rolling out r189372 and r189403.
https://bugs.webkit.org/show_bug.cgi?id=148892

[iOS] All the media tests fail (Requested by ap on #webkit).

Reverted changesets:

"Unreviewed gardening; enabling media/ and http/tests/media/
tests (with expected failures) on ios-simulator"
http://trac.webkit.org/changeset/189372

"Fix lint warnings on iOS."
http://trac.webkit.org/changeset/189403

Sep 4, 2015:

11:44 PM Changeset in webkit [189427] by mmaxfield@apple.com

3 edits in trunk/Source/WebCore

Rename members of CanvasRenderingContext2D::State
https://bugs.webkit.org/show_bug.cgi?id=148889

Reviewed by Tim Horton.

CanvasRenderingContext2D::State is a struct, so its members should not start with m_.

No new tests because there is no behavior change.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::State::operator=):
(WebCore::CanvasRenderingContext2D::restore):
(WebCore::CanvasRenderingContext2D::setStrokeStyle):
(WebCore::CanvasRenderingContext2D::setFillStyle):
(WebCore::CanvasRenderingContext2D::lineWidth):
(WebCore::CanvasRenderingContext2D::setLineWidth):
(WebCore::CanvasRenderingContext2D::lineCap):
(WebCore::CanvasRenderingContext2D::setLineCap):
(WebCore::CanvasRenderingContext2D::lineJoin):
(WebCore::CanvasRenderingContext2D::setLineJoin):
(WebCore::CanvasRenderingContext2D::miterLimit):
(WebCore::CanvasRenderingContext2D::setMiterLimit):
(WebCore::CanvasRenderingContext2D::shadowOffsetX):
(WebCore::CanvasRenderingContext2D::setShadowOffsetX):
(WebCore::CanvasRenderingContext2D::shadowOffsetY):
(WebCore::CanvasRenderingContext2D::setShadowOffsetY):
(WebCore::CanvasRenderingContext2D::shadowBlur):
(WebCore::CanvasRenderingContext2D::setShadowBlur):
(WebCore::CanvasRenderingContext2D::shadowColor):
(WebCore::CanvasRenderingContext2D::setShadowColor):
(WebCore::CanvasRenderingContext2D::getLineDash):
(WebCore::CanvasRenderingContext2D::setLineDash):
(WebCore::CanvasRenderingContext2D::setWebkitLineDash):
(WebCore::CanvasRenderingContext2D::lineDashOffset):
(WebCore::CanvasRenderingContext2D::setLineDashOffset):
(WebCore::CanvasRenderingContext2D::applyLineDash):
(WebCore::CanvasRenderingContext2D::globalAlpha):
(WebCore::CanvasRenderingContext2D::setGlobalAlpha):
(WebCore::CanvasRenderingContext2D::globalCompositeOperation):
(WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
(WebCore::CanvasRenderingContext2D::scale):
(WebCore::CanvasRenderingContext2D::rotate):
(WebCore::CanvasRenderingContext2D::translate):
(WebCore::CanvasRenderingContext2D::transform):
(WebCore::CanvasRenderingContext2D::setTransform):
(WebCore::CanvasRenderingContext2D::setStrokeColor):
(WebCore::CanvasRenderingContext2D::setFillColor):
(WebCore::CanvasRenderingContext2D::fillInternal):
(WebCore::CanvasRenderingContext2D::strokeInternal):
(WebCore::CanvasRenderingContext2D::clipInternal):
(WebCore::CanvasRenderingContext2D::isPointInPathInternal):
(WebCore::CanvasRenderingContext2D::isPointInStrokeInternal):
(WebCore::CanvasRenderingContext2D::clearRect):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::strokeRect):
(WebCore::CanvasRenderingContext2D::setShadow):
(WebCore::CanvasRenderingContext2D::applyShadow):
(WebCore::CanvasRenderingContext2D::shouldDrawShadows):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::transformAreaToDevice):
(WebCore::CanvasRenderingContext2D::rectContainsCanvas):
(WebCore::CanvasRenderingContext2D::compositeBuffer):
(WebCore::CanvasRenderingContext2D::didDraw):
(WebCore::CanvasRenderingContext2D::drawFocusIfNeededInternal):
(WebCore::CanvasRenderingContext2D::font):
(WebCore::CanvasRenderingContext2D::setFont):
(WebCore::CanvasRenderingContext2D::textAlign):
(WebCore::CanvasRenderingContext2D::setTextAlign):
(WebCore::CanvasRenderingContext2D::textBaseline):
(WebCore::CanvasRenderingContext2D::setTextBaseline):
(WebCore::CanvasRenderingContext2D::direction):
(WebCore::CanvasRenderingContext2D::setDirection):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
(WebCore::CanvasRenderingContext2D::inflateStrokeRect):
(WebCore::CanvasRenderingContext2D::imageSmoothingEnabled):
(WebCore::CanvasRenderingContext2D::setImageSmoothingEnabled):

html/canvas/CanvasRenderingContext2D.h:

11:35 PM Changeset in webkit [189426] by ap@apple.com

2 edits in trunk/LayoutTests

Add expectation for some tests that are very flaky on Windows.

platform/win/TestExpectations:

11:11 PM Changeset in webkit [189425] by ap@apple.com

2 edits
2 deletes in trunk/LayoutTests

Get rid of unneeded TestExpectations files.

platform/mac-mavericks/TestExpectations: Removed.
platform/mac-yosemite/TestExpectations: Removed.
platform/mac/TestExpectations:

10:58 PM Changeset in webkit [189424] by ap@apple.com

2 edits in trunk/LayoutTests

REGRESSION (r189407): webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html
fails on Mavericks.

platform/mac/TestExpectations: Mark it as such.

10:49 PM Changeset in webkit [189423] by ap@apple.com

2 edits in trunk/LayoutTests

Newly imported http/tests/w3c/html/semantics/forms/textfieldselection/selection.html
is flaky.

TestExpectations: Mark it as such.

10:43 PM Changeset in webkit [189422] by ap@apple.com

3 edits in trunk/LayoutTests

Update expectations for color input tests, which don't work in Mac WebKit1.

TestExpectations:
platform/mac-wk1/TestExpectations:

10:33 PM Changeset in webkit [189421] by mmaxfield@apple.com

9 edits
3 adds in trunk

Crash when font completes downloading after calling 2D canvas setText() multiple times
https://bugs.webkit.org/show_bug.cgi?id=148789

Reviewed by Darin Adler.

Source/WebCore:

The CSSFontSelector has a list of clients, and when fonts complete downloading, these
clients get a call back. CanvasRenderingContext2D::State is one such of these clients. However,
the CSSFontSelector may be destroyed and recreated at any time. We were getting into a case
where multiple CSSFontSelectors were thinking that the same CanvasRenderingContext2D::State were
their client. When the CanvasRenderingContext2D::State was destroyed, it only unregistered
itself from one of the CSSFontSelectors, which means the CSSFontSelector left over has a dangling
pointer to it.

The solution is to implement a new helper class, FontProxy, to hold the
CanvasRenderingContext2D::State's font, and maintain the invariant that this object is always
registered to exactly one CSSFontSelector, and this CSSFontSelector is the one which is associated
with the FontProxy's FontCascade object. This patch maintains this invariant, as well as protecting
all access to the State's FontCascade object so no one can reach in and change it without going
through functions which maintain the invariant.

Test: fast/canvas/font-selector-crash.html

css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::registerForInvalidationCallbacks):
(WebCore::CSSFontSelector::unregisterForInvalidationCallbacks):
(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):

css/CSSFontSelector.h:
dom/Document.cpp:

(WebCore::Document::fontsNeedUpdate):
(WebCore::Document::fontSelector):
(WebCore::Document::clearStyleResolver):

dom/Document.h:
html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::State::operator=):
(WebCore::CanvasRenderingContext2D::FontProxy::~FontProxy):
(WebCore::CanvasRenderingContext2D::FontProxy::FontProxy):
(WebCore::CanvasRenderingContext2D::FontProxy::update):
(WebCore::CanvasRenderingContext2D::FontProxy::fontsNeedUpdate):
(WebCore::CanvasRenderingContext2D::FontProxy::initialize):
(WebCore::CanvasRenderingContext2D::FontProxy::fontMetrics):
(WebCore::CanvasRenderingContext2D::FontProxy::fontDescription):
(WebCore::CanvasRenderingContext2D::FontProxy::width):
(WebCore::CanvasRenderingContext2D::FontProxy::drawBidiText):
(WebCore::CanvasRenderingContext2D::font):
(WebCore::CanvasRenderingContext2D::setFont):
(WebCore::CanvasRenderingContext2D::measureText):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
(WebCore::CanvasRenderingContext2D::State::~State): Deleted.
(WebCore::CanvasRenderingContext2D::State::fontsNeedUpdate): Deleted.
(WebCore::CanvasRenderingContext2D::accessFont): Deleted.

html/canvas/CanvasRenderingContext2D.h:
platform/graphics/FontSelector.h:

LayoutTests:

fast/canvas/font-selector-crash-expected.txt: Added.
fast/canvas/font-selector-crash.html: Added.
fast/canvas/resources/font-selector-crash.ttf: Added.

10:29 PM Changeset in webkit [189420] by BJ Burg

6 edits in trunk/Source/WebInspectorUI

Web Inspector: combine Test.html resources to make tests run faster
https://bugs.webkit.org/show_bug.cgi?id=148726

Reviewed by Timothy Hatcher.

In an attempt to make inspector tests run faster, always combine resources
on the Test.html page. This cuts down from 110+ resource loads to 5 loads.

To avoid name clashes, add the 'Combined' suffix to files that would clash
with uncombined Test resources, and add the 'Test' prefix when combining
or minifying files that would clash with production minification. So, it
would be possible for Main.html and Test.html to have different minified
versions of CodeMirror or other external libraries if they use different
subsets.

Combining is unlikely to make debugging tests more difficult, since almost
all test code is marshalled and eval'd into existence anyway.

Configurations/WebInspectorUIFramework.xcconfig:
Scripts/combine-resources.pl: Drive-by spelling.

(concatenateFiles):
(concatinateFiles): Deleted.

Scripts/copy-user-interface-resources-dryrun.rb:
Scripts/copy-user-interface-resources.pl:

Drive-by spelling. Add a new code path for combining Test resources, which
doesn't require minification or handling CSS, images, or most externals.

WebInspectorUI.vcxproj/build-webinspectorui.pl:

Always combine Test.html, but also ditto everything into place for
engineering builds.

10:29 PM Changeset in webkit [189419] by commit-queue@webkit.org

22 edits
3 adds in trunk

Unreviewed, rolling out r189386.
https://bugs.webkit.org/show_bug.cgi?id=148883

Made several event dispatch tests assert (Requested by ap on
#webkit).

Reverted changeset:

"dispatchEvent() should throw an InvalidStateError if the
event's initialized flag is not set"
https://bugs.webkit.org/show_bug.cgi?id=148800
http://trac.webkit.org/changeset/189386

9:20 PM Changeset in webkit [189418] by Alan Bujtas

10 edits
9 adds
47 deletes in trunk/LayoutTests

Repaint cleanup:

layer-child-outline.html -> reftest
layer-full-repaint.html -> reftest
layer-hide-when-needs-layout.html -> reftest
layer-visibility.html -> reftest
layout-state-only-positioned.html -> reftest
layout-state-relative.html -> reftest
layout-state-scrolloffset.html -> reftest
layout-state-scrolloffset2.html -> reftest
layout-state-scrolloffset3.html -> reftest

fast/repaint/layer-child-outline-expected.html: Added.
fast/repaint/layer-child-outline.html:
fast/repaint/layer-full-repaint-expected.html: Added.
fast/repaint/layer-full-repaint-expected.txt: Removed.
fast/repaint/layer-full-repaint.html:
fast/repaint/layer-hide-when-needs-layout-expected.html: Added.
fast/repaint/layer-hide-when-needs-layout-expected.png: Removed.
fast/repaint/layer-hide-when-needs-layout-expected.txt: Removed.
fast/repaint/layer-hide-when-needs-layout.html:
fast/repaint/layer-visibility-expected.html: Added.
fast/repaint/layer-visibility-expected.png: Removed.
fast/repaint/layer-visibility-expected.txt: Removed.
fast/repaint/layer-visibility.html:
fast/repaint/layout-state-only-positioned-expected.html: Added.
fast/repaint/layout-state-only-positioned-expected.txt: Removed.
fast/repaint/layout-state-only-positioned.html:
fast/repaint/layout-state-relative-expected.html: Added.
fast/repaint/layout-state-relative.html:
fast/repaint/layout-state-scrolloffset-expected.html: Added.
fast/repaint/layout-state-scrolloffset.html:
fast/repaint/layout-state-scrolloffset2-expected.html: Added.
fast/repaint/layout-state-scrolloffset2.html:
fast/repaint/layout-state-scrolloffset3-expected.html: Added.
fast/repaint/layout-state-scrolloffset3.html:
platform/efl/fast/repaint/layer-child-outline-expected.png: Removed.
platform/efl/fast/repaint/layer-child-outline-expected.txt: Removed.
platform/efl/fast/repaint/layout-state-only-positioned-expected.png: Removed.
platform/efl/fast/repaint/layout-state-relative-expected.png: Removed.
platform/efl/fast/repaint/layout-state-relative-expected.txt: Removed.
platform/efl/fast/repaint/layout-state-scrolloffset-expected.png: Removed.
platform/efl/fast/repaint/layout-state-scrolloffset-expected.txt: Removed.
platform/efl/fast/repaint/layout-state-scrolloffset2-expected.png: Removed.
platform/efl/fast/repaint/layout-state-scrolloffset2-expected.txt: Removed.
platform/efl/fast/repaint/layout-state-scrolloffset3-expected.png: Removed.
platform/efl/fast/repaint/layout-state-scrolloffset3-expected.txt: Removed.
platform/gtk/fast/repaint/layer-child-outline-expected.png: Removed.
platform/gtk/fast/repaint/layer-child-outline-expected.txt: Removed.
platform/gtk/fast/repaint/layout-state-only-positioned-expected.png: Removed.
platform/gtk/fast/repaint/layout-state-relative-expected.png: Removed.
platform/gtk/fast/repaint/layout-state-relative-expected.txt: Removed.
platform/gtk/fast/repaint/layout-state-scrolloffset-expected.png: Removed.
platform/gtk/fast/repaint/layout-state-scrolloffset-expected.txt: Removed.
platform/gtk/fast/repaint/layout-state-scrolloffset2-expected.png: Removed.
platform/gtk/fast/repaint/layout-state-scrolloffset2-expected.txt: Removed.
platform/gtk/fast/repaint/layout-state-scrolloffset3-expected.png: Removed.
platform/gtk/fast/repaint/layout-state-scrolloffset3-expected.txt: Removed.
platform/mac-wk2/fast/repaint/layer-hide-when-needs-layout-expected.txt: Removed.
platform/mac/fast/repaint/layer-child-outline-expected.png: Removed.
platform/mac/fast/repaint/layer-child-outline-expected.txt: Removed.
platform/mac/fast/repaint/layer-hide-when-needs-layout-expected.png: Removed.
platform/mac/fast/repaint/layer-visibility-expected.png: Removed.
platform/mac/fast/repaint/layout-state-only-positioned-expected.png: Removed.
platform/mac/fast/repaint/layout-state-relative-expected.png: Removed.
platform/mac/fast/repaint/layout-state-relative-expected.txt: Removed.
platform/mac/fast/repaint/layout-state-scrolloffset-expected.png: Removed.
platform/mac/fast/repaint/layout-state-scrolloffset-expected.txt: Removed.
platform/mac/fast/repaint/layout-state-scrolloffset2-expected.png: Removed.
platform/mac/fast/repaint/layout-state-scrolloffset2-expected.txt: Removed.
platform/mac/fast/repaint/layout-state-scrolloffset3-expected.png: Removed.
platform/mac/fast/repaint/layout-state-scrolloffset3-expected.txt: Removed.
platform/win/fast/repaint/layer-child-outline-expected.txt: Removed.
platform/win/fast/repaint/layout-state-relative-expected.txt: Removed.
platform/win/fast/repaint/layout-state-scrolloffset-expected.txt: Removed.
platform/win/fast/repaint/layout-state-scrolloffset2-expected.txt: Removed.
platform/win/fast/repaint/layout-state-scrolloffset3-expected.txt: Removed.

8:10 PM Changeset in webkit [189417] by mark.lam@apple.com

15 edits
2 deletes in trunk/Source/JavaScriptCore

Rollout r189411, r189413: Broke JSC tests.

Not reviewed.

API/tests/PingPongStackOverflowTest.cpp: Removed.
API/tests/PingPongStackOverflowTest.h: Removed.
API/tests/testapi.c:

(main):

JavaScriptCore.xcodeproj/project.pbxproj:
interpreter/CallFrame.h:

(JSC::ExecState::operator=):
(JSC::ExecState::callerFrame):
(JSC::ExecState::argIndexForRegister):
(JSC::ExecState::callerFrameOrVMEntryFrame):
(JSC::ExecState::callerFrameAndPC):

interpreter/Interpreter.cpp:

(JSC::UnwindFunctor::UnwindFunctor):
(JSC::UnwindFunctor::operator()):
(JSC::Interpreter::unwind):

interpreter/Interpreter.h:

(JSC::NativeCallFrameTracer::NativeCallFrameTracer):
(JSC::Interpreter::sampler):

jit/CCallHelpers.h:

(JSC::CCallHelpers::jumpToExceptionHandler):

jit/JITExceptions.cpp:

(JSC::genericUnwind):

jit/JITExceptions.h:
jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_catch):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_catch):

jit/JITOperations.cpp:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/VM.h:

(JSC::VM::exceptionOffset):
(JSC::VM::vmEntryFrameForThrowOffset):
(JSC::VM::topVMEntryFrameOffset):
(JSC::VM::callFrameForThrowOffset):

7:38 PM Changeset in webkit [189416] by commit-queue@webkit.org

6 edits
11 adds
1 delete in trunk

Web Inspector: Add tests for DOM highlight commands
https://bugs.webkit.org/show_bug.cgi?id=148786

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-04
Reviewed by Timothy Hatcher.

Source/WebCore:

Tests: inspector/dom/hideHighlight.html

inspector/dom/highlightFrame.html
inspector/dom/highlightNode.html
inspector/dom/highlightQuad.html
inspector/dom/highlightRect.html

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightFrame):
Include an error if a frame is not found.

inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::highlightQuad):
Should have been checking the usePageCoordinates state of the incoming
highlight configuration, not the one that will be replaced.

LayoutTests:

inspector/dom/hideHighlight-expected.txt: Added.
inspector/dom/hideHighlight.html: Added.
inspector/dom/highlightFrame-expected.txt: Added.
inspector/dom/highlightFrame.html: Added.
inspector/dom/highlightNode-expected.txt: Added.
inspector/dom/highlightNode.html: Added.
inspector/dom/highlightQuad-expected.txt: Added.
inspector/dom/highlightQuad.html: Added.
inspector/dom/highlightRect-expected.txt: Added.
inspector/dom/highlightRect.html: Added.
inspector/dom/highlightSelector-expected.txt:
inspector/dom/highlightSelector.html:
inspector/dom/resources/highlight-iframe.html: Renamed from LayoutTests/inspector/dom/resources/highlightSelector-iframe.html.

7:34 PM Changeset in webkit [189415] by commit-queue@webkit.org

6 edits
2 adds in trunk

Web Inspector: Test Runtime.saveResult and $n values
https://bugs.webkit.org/show_bug.cgi?id=148837

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-04
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

inspector/InjectedScriptSource.js:

(InjectedScript.prototype._evaluateOn):
We don't need to be in the console object group to put the value
in the saved results list. That strong reference will ensure $n
values are always alive even if other object groups were used
when creating and subsequently released.

Source/WebInspectorUI:

UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass):
Initialize the dump logging function different if we are in tests or not.
When in tests, using console.log as well as dumping system activity to
the system console results in an infinite loop of logging!

(InspectorBackendClass.prototype.dispatch):
(InspectorBackendClass.prototype._sendCommandToBackendWithCallback):
Use the logging function we figured out earlier.

LayoutTests:

inspector/runtime/parse.html: Remove unncessary debug flag.
inspector/runtime/saveResult-expected.txt: Added.
inspector/runtime/saveResult.html: Added.

7:30 PM Changeset in webkit [189414] by Csaba Osztrogonác

6 edits in trunk/Source

Remove unnecessary compiler guards from mm files
https://bugs.webkit.org/show_bug.cgi?id=148797

Reviewed by Dan Bernstein.

Source/WebCore:

bindings/objc/DOMInternal.mm:
bridge/objc/objc_instance.mm:

Source/WebKit/mac:

Plugins/WebBasePluginPackage.mm:
Plugins/WebNetscapePluginPackage.mm:

6:23 PM Changeset in webkit [189413] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

[Follow up] StackOverflow stack unwinding should stop at native frames.
https://bugs.webkit.org/show_bug.cgi?id=148749

Rubber stamped by Michael Saboff.

Speculative fix for jsc test failure.

interpreter/Interpreter.cpp:

(JSC::Interpreter::unwind):

6:13 PM Changeset in webkit [189412] by Chris Dumez

1 edit
1 add in trunk/LayoutTests

Unreviewed, land baseline for one of the newly imported w3c tests.

http/tests/w3c/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-into-iframe-expected.txt: Added.

6:03 PM Changeset in webkit [189411] by mark.lam@apple.com

15 edits
2 adds in trunk/Source/JavaScriptCore

StackOverflow stack unwinding should stop at native frames.
https://bugs.webkit.org/show_bug.cgi?id=148749

Reviewed by Michael Saboff.

In the present code, after ping-pong'ing back and forth between native and JS
code a few times, if we have a stack overflow on re-entry into the VM to run
JS code's whose stack frame would overflow the JS stack, the code will end up
unwinding past the native function that is making the call to re-enter the VM.
As a result, any clean up code (e.g. destructors for stack variables) in the
skipped native function frame (and its chain of native function callers) will
not be called.

This patch is based on the Michael Saboff's fix of this issue landed on the
jsc-tailcall branch: http://trac.webkit.org/changeset/188555

We now check for the case where there are no JS frames to unwind since the
last native frame, and treat the exception as an unhandled exception. The
native function is responsible for further propagating the exception if needed.

Other supporting work:

Remove vm->vmEntryFrameForThrow. It should always be the same as vm->topVMEntryFrame.
Change operationThrowStackOverflowError() to use the throwStackOverflowError() helper function instead of rolling its own.
In the LLINT vm entry, set vm->topVMEntryFrame as soon as the entry frame is fully initialized (instead of waiting). With this, we can always reliably tell which VMEntryFrame is on top.
Added a test that exercises this edge case. The test should not hang or crash.

API/tests/PingPongStackOverflowTest.cpp: Added.

(PingPongStackOverflowObject_hasInstance):
(testPingPongStackOverflow):

API/tests/PingPongStackOverflowTest.h: Added.
API/tests/testapi.c:

(main):

JavaScriptCore.xcodeproj/project.pbxproj:
interpreter/Interpreter.cpp:

(JSC::unwindCallFrame):
(JSC::getStackFrameCodeType):
(JSC::UnwindFunctor::UnwindFunctor):
(JSC::UnwindFunctor::operator()):
(JSC::Interpreter::unwind):

interpreter/Interpreter.h:

(JSC::NativeCallFrameTracer::NativeCallFrameTracer):
(JSC::NativeCallFrameTracerWithRestore::NativeCallFrameTracerWithRestore):
(JSC::NativeCallFrameTracerWithRestore::~NativeCallFrameTracerWithRestore):
(JSC::Interpreter::sampler):

jit/CCallHelpers.h:

(JSC::CCallHelpers::jumpToExceptionHandler):

jit/JITExceptions.cpp:

(JSC::genericUnwind):

jit/JITExceptions.h:
jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_catch):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_catch):

jit/JITOperations.cpp:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/VM.h:

(JSC::VM::exceptionOffset):
(JSC::VM::callFrameForThrowOffset):
(JSC::VM::vmEntryFrameForThrowOffset): Deleted.
(JSC::VM::topVMEntryFrameOffset): Deleted.

5:58 PM Changeset in webkit [189410] by jhoneycutt@apple.com

1 edit
1 add in trunk

[iOS] Need a test for bug #145539: Uploading an animated GIF from the
photo library uploads a JPEG
https://bugs.webkit.org/show_bug.cgi?id=148849

Reviewed by Daniel Bates.

ManualTests/ios/image-file-uploads-as-original-type.html: Added.

On the Mac, file upload tests use EventSender::beginDragWithFiles. This
functionality doesn't exist on iOS, so we'll add a manual test.
This tests that the first few bytes of the selected file are "GIF".

5:46 PM Changeset in webkit [189409] by basile_clement@apple.com

2 edits in trunk/Tools

Unreviewed, change my email address.

Scripts/webkitpy/common/config/contributors.json:

5:34 PM Changeset in webkit [189408] by jhoneycutt@apple.com

1 edit
2 adds in trunk/LayoutTests

Import a Chromium <input type=color> test.
https://bugs.webkit.org/show_bug.cgi?id=148844

Reviewed by Andy Estes.

fast/forms/color/color-suggestion-picker-crash-on-set-value-expected.txt: Added.
fast/forms/color/color-suggestion-picker-crash-on-set-value.html: Added.

5:32 PM Changeset in webkit [189407] by dino@apple.com

22 edits in trunk/LayoutTests

[WebGL] Update WebGL 1.0.3 conformance tests
https://bugs.webkit.org/show_bug.cgi?id=148858
<rdar://problem/22588694>

Reviewed by Beth Dakin.

Update to the final version of the 1.0.3 WebGL conformance suite.
At the same time, unskip the tests (other than the one that crashes)
and check in results that we can use as progressions (later).

platform/mac/TestExpectations:
webgl/1.0.3/conformance/extensions/oes-texture-half-float-expected.txt:
webgl/1.0.3/conformance/extensions/webgl-compressed-texture-size-limit-expected.txt:
webgl/1.0.3/conformance/extensions/webgl-draw-buffers-expected.txt:
webgl/1.0.3/conformance/glsl/misc/shader-struct-scope-expected.txt:
webgl/1.0.3/conformance/glsl/misc/shaders-with-invariance-expected.txt:
webgl/1.0.3/conformance/glsl/misc/shaders-with-name-conflicts-expected.txt:
webgl/1.0.3/conformance/glsl/misc/struct-nesting-of-variable-names-expected.txt:
webgl/1.0.3/conformance/renderbuffers/feedback-loop-expected.txt:
webgl/1.0.3/conformance/textures/texture-copying-feedback-loops-expected.txt:
webgl/1.0.3/resources/webgl_test_files/conformance/extensions/angle-instanced-arrays.html:
webgl/1.0.3/resources/webgl_test_files/conformance/glsl/misc/shader-with-for-loop.html:
webgl/1.0.3/resources/webgl_test_files/conformance/glsl/misc/ternary-operators-in-global-initializers.html:
webgl/1.0.3/resources/webgl_test_files/conformance/misc/bad-arguments-test.html:
webgl/1.0.3/resources/webgl_test_files/conformance/more/functions/uniformMatrixBadArgs.html:
webgl/1.0.3/resources/webgl_test_files/conformance/more/unit.js:
webgl/1.0.3/resources/webgl_test_files/conformance/ogles/ogles-utils.js:

(OpenGLESTestRunner):

webgl/1.0.3/resources/webgl_test_files/conformance/textures/tex-image-with-invalid-data.html:
webgl/1.0.3/resources/webgl_test_files/conformance/typedarrays/array-unit-tests.html:
webgl/1.0.3/resources/webgl_test_files/conformance/typedarrays/resources/typed-array-worker.js:

(onmessage):

webgl/1.0.3/resources/webgl_test_files/webgl-conformance-tests.html:

5:23 PM Changeset in webkit [189406] by Beth Dakin

3 edits in trunk/LayoutTests

Forgot to mark these expectations.

TestExpectations:
platform/mac-wk2/TestExpectations:

5:14 PM Changeset in webkit [189405] by commit-queue@webkit.org

7 edits in trunk/Source/JavaScriptCore

Implement the division and modulo instructions in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=148791

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-04
Reviewed by Geoffrey Garen.

This patch implements the unsigned division, signed modulo, and unsigned
modulo instructions for 32-bit integers in WebAssembly. It also
implements the context pool index instructions, which are needed for
testing. (pack-asmjs puts numbers that are used more than once in the
constant pool.)

assembler/X86Assembler.h:

(JSC::X86Assembler::divl_r):

tests/stress/wasm-arithmetic.js:
tests/stress/wasm-arithmetic.wasm:
wasm/WASMFunctionCompiler.h:

(JSC::operationMod):
(JSC::operationUnsignedDiv):
(JSC::operationUnsignedMod):
(JSC::WASMFunctionCompiler::buildBinaryI32):
(JSC::WASMFunctionCompiler::callOperation):

wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseConstantPoolIndexExpressionI32):

wasm/WASMFunctionParser.h:

5:12 PM Changeset in webkit [189404] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, add bug number for http/tests/w3c/html/semantics/embedded-content/the-video-element/video_initially_paused.html

TestExpectations:

5:06 PM Changeset in webkit [189403] by ap@apple.com

4 edits in trunk/LayoutTests

Fix lint warnings on iOS.

This enables the correct expectation for fast/events/scroll-in-scaled-page-with-overflow-hidden.html.
As for other tests, I went with the expectation that was currently in effect.

platform/ios-simulator-wk1/TestExpectations:
platform/ios-simulator-wk2/TestExpectations:
platform/ios-simulator/TestExpectations:

4:57 PM Changeset in webkit [189402] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, add bug number for http/tests/w3c/html/semantics/embedded-content/the-embed-element/embed-represent-nothing*.html

TestExpectations:

4:50 PM Changeset in webkit [189401] by eric.carlson@apple.com

3 edits
2 adds in trunk

[mediacontrols] Test AirPlay picker button
https://bugs.webkit.org/show_bug.cgi?id=148836

Reviewed by Dean Jackson.

Source/WebCore:

Test: media/controls/airplay-picker.html

Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.getCurrentControlsStatus.elements.forEach.):
(Controller.prototype.getCurrentControlsStatus):

LayoutTests:

media/controls/airplay-picker-expected.txt: New test.
media/controls/airplay-picker.html: New results.

4:48 PM Changeset in webkit [189400] by Beth Dakin

8 edits
2 adds in trunk

Should have a test to make sure links don't navigate after a cancelled force
click
https://bugs.webkit.org/show_bug.cgi?id=148846

Reviewed by Tim Horton.

Tools:

New EventSender function for a started then cancelled force click.

WebKitTestRunner/EventSenderProxy.h:
WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::mouseForceClick):
(WTR::EventSendingController::startAndCancelMouseForceClick):
(WTR::EventSendingController::mouseForceDown):

WebKitTestRunner/InjectedBundle/EventSendingController.h:
WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::mouseForceClick):
(WTR::EventSenderProxy::startAndCancelMouseForceClick):
(WTR::EventSenderProxy::mouseForceDown):
(WTR::EventSenderProxy::mouseMoveTo):

LayoutTests:

fast/events/cancelled-force-click-link-navigation-expected.txt: Added.
fast/events/cancelled-force-click-link-navigation.html: Added.

4:35 PM Changeset in webkit [189399] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, add bug number for http/tests/w3c/html/semantics/text-level-semantics/the-wbr-element/wbr-element.html

TestExpectations:

4:21 PM Changeset in webkit [189398] by basile_clement@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix debug output for an eval call
https://bugs.webkit.org/show_bug.cgi?id=148839

Reviewed by Filip Pizlo.

jit/ThunkGenerators.cpp:

(JSC::virtualThunkFor):

4:07 PM Changeset in webkit [189397] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, add bug number for http/tests/w3c/html/semantics/document-metadata/the-style-element/html_style_in_comment.html

TestExpectations:

3:47 PM Changeset in webkit [189396] by commit-queue@webkit.org

7 edits in trunk/Source/JavaScriptCore

Implement the signed division instruction in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=148772

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-04
Reviewed by Geoffrey Garen.

This patch implements the signed division instruction in WebAssembly
for 32-bit integers. We use the IDIV instruction on x86 and x86-64 and
use a C function on all other platforms. We throw an exception if

the denominator is zero, or
the numerator is -2^{31 and the denominator is -1.}

jit/JITOperations.cpp:
jit/JITOperations.h:
tests/stress/wasm-arithmetic.js:

(shouldBe):
(shouldThrow):

tests/stress/wasm-arithmetic.wasm:
wasm/WASMFunctionCompiler.h:

(JSC::operationDiv):
(JSC::WASMFunctionCompiler::endFunction):
(JSC::WASMFunctionCompiler::buildBinaryI32):
(JSC::WASMFunctionCompiler::appendCall):
(JSC::WASMFunctionCompiler::appendCallWithExceptionCheck):
(JSC::WASMFunctionCompiler::callOperation):
(JSC::WASMFunctionCompiler::throwStackOverflowError): Deleted.

wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseExpressionI32):

3:41 PM Changeset in webkit [189395] by Beth Dakin

8 edits in trunk/LayoutTests

These tests should be skipped at the LayoutTests level and re-enabled for
WK2.

Rubber-stamped by Tim Horton.

TestExpectations:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac-mavericks/TestExpectations:
platform/mac-wk1/TestExpectations:
platform/mac-wk2/TestExpectations:
platform/win/TestExpectations:

3:26 PM Changeset in webkit [189394] by rniwa@webkit.org

2 edits
1407 adds in trunk/LayoutTests

Import html/semantics test cases from W3C
https://bugs.webkit.org/show_bug.cgi?id=148822
<rdar://problem/22583647>

Patch by Chris Dumez <Chris Dumez> on 2015-09-04
Reviewed by Ryosuke Niwa.

Import 486 html/semantics test cases from W3C.
They take ~30 seconds to run on my MacBookPro.

TestExpectations:
http/tests/w3c/html/semantics/*: Added.

3:11 PM Changeset in webkit [189393] by timothy_horton@apple.com

2 edits in trunk/LayoutTests

Fix style error in last commit.

swipe/resources/swipe-test.js:

(eventQueue.callAfterEventDispatch):

3:09 PM Changeset in webkit [189392] by timothy_horton@apple.com

7 edits
2 adds in trunk

Add a test for r179736 (programmatic navigation during swipe causing a crash)
https://bugs.webkit.org/show_bug.cgi?id=148830

Reviewed by Beth Dakin.

swipe/basic-cached-back-swipe.html:
swipe/pushState-cached-back-swipe.html:
swipe/resources/swipe-test.js:

(eventQueue.callAfterEventDispatch):
(initializeSwipeTest):
(initializeLog): Deleted.

swipe/swipe-start-hysteresis-failures.html:

Refactor some things.
Make sure that we reset the back forward list before testing, because we expect
to start at the "first" item, but there is actually a about:blank before us.

swipe/pushState-programmatic-back-while-swiping-crash-expected.txt: Added.
swipe/pushState-programmatic-back-while-swiping-crash.html: Added.

Add a test that ensures that r179736 does not recur.

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):
Make sure that TestRunner callbacks don't leak between tests!

3:08 PM Changeset in webkit [189391] by Beth Dakin

8 edits
2 adds in trunk/LayoutTests

Should have a test for selection behavior when force clicking text
https://bugs.webkit.org/show_bug.cgi?id=148832

Reviewed by Tim Horton.

fast/events/force-click-text-selection-behavior-expected.txt: Added.
fast/events/force-click-text-selection-behavior.html: Added.
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/ios-simulator/TestExpectations:
platform/mac-mavericks/TestExpectations:
platform/mac-wk1/TestExpectations:
platform/mac-wk2/TestExpectations:
platform/win/TestExpectations:

2:53 PM Changeset in webkit [189390] by andersca@apple.com

2 edits in trunk/Tools

It should be possible to pass relative HTTP test paths to DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=148825
<rdar://problem/22583866>

Reviewed by Tim Horton.

Convert the path to an absolute path if needed.

DumpRenderTree/mac/DumpRenderTree.mm:

(computeTestURL):

2:28 PM Changeset in webkit [189389] by Beth Dakin

7 edits
2 adds in trunk/LayoutTests

Should have a test for selection behavior when deep clicking a link
https://bugs.webkit.org/show_bug.cgi?id=148827

Reviewed by Tim Horton.

fast/events/force-click-link-selection-behavior-expected.txt: Added.
fast/events/force-click-link-selection-behavior.html: Added.
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/ios-simulator/TestExpectations:
platform/mac-mavericks/TestExpectations:
platform/mac-wk1/TestExpectations:
platform/win/TestExpectations:

2:19 PM Changeset in webkit [189388] by Beth Dakin

2 edits in trunk/LayoutTests

Rolling this back in since these tests do still fail on the bots.

platform/mac-wk2/TestExpectations:

2:14 PM Changeset in webkit [189387] by rniwa@webkit.org

1 edit
1 delete in trunk/LayoutTests/imported/w3c

Import new multicolumn layout tests from CSS WG testss
https://bugs.webkit.org/show_bug.cgi?id=148805

Remove a test that didn't have any expected result.

css/css-multicol-1/multicol-rule-shorthand-2.xht: Removed.

2:13 PM Changeset in webkit [189386] by Chris Dumez

22 edits
3 deletes in trunk

dispatchEvent() should throw an InvalidStateError if the event's initialized flag is not set
https://bugs.webkit.org/show_bug.cgi?id=148800
<rdar://problem/22565782>
<rdar://problem/22565485>

Reviewed by Geoffrey Garen.

Source/WebCore:

dispatchEvent() should throw an InvalidStateError if the event's
initialized flag is not set or its dispatch flag is set, and should
allow dispatching events with an empty type as long as it is
initialized:
https://dom.spec.whatwg.org/#dom-eventtarget-dispatchevent (step 1)

Previously, WebKit relied on the event type being empty to throw a
UNSPECIFIED_EVENT_TYPE_ERR: DOM Events Exception 0. However, this
exception type is outdated and initializing Event.type to an empty
string is legal.

No new tests, already covered by existing tests that were rebaselined.

dom/Event.cpp:

(WebCore::Event::Event):
(WebCore::Event::initEvent):

dom/Event.h:

(WebCore::Event::isInitialized):

dom/EventTarget.cpp:

(WebCore::EventTarget::dispatchEvent):

LayoutTests:

dom/html/level2/events/dispatchEvent02-expected.txt:
dom/html/level2/events/dispatchEvent03-expected.txt:
dom/html/level2/events/dispatchEvent04-expected.txt:
dom/html/level2/events/dispatchEvent05-expected.txt:
dom/html/level2/events/dispatchEvent06-expected.txt:
dom/html/level2/events/dispatchEvent07-expected.txt:
dom/xhtml/level2/events/dispatchEvent02-expected.txt:
dom/xhtml/level2/events/dispatchEvent03-expected.txt:
dom/xhtml/level2/events/dispatchEvent04-expected.txt:
dom/xhtml/level2/events/dispatchEvent05-expected.txt:
dom/xhtml/level2/events/dispatchEvent06-expected.txt:
dom/xhtml/level2/events/dispatchEvent07-expected.txt:

Rebaseline, those tests are outdated and their expected results no
longer matches the behavior of the latest DOM specification.

fast/dom/DOMException/EventException-expected.txt: Removed.
fast/dom/DOMException/EventException.html: Removed.
fast/dom/DOMException/resources/EventException.js: Removed.

Drop this test we no longer throw an EventException in this case.

fast/dom/Window/dispatchEvent-expected.txt:

Rebaseline.

fast/events/dispatch-event-being-dispatched-expected.txt:
fast/events/dispatch-event-being-dispatched.html:

Fix the test to expect the new exception types.

http/tests/w3c/dom/events/Event-type-empty-expected.txt:
http/tests/w3c/dom/events/EventTarget-dispatchEvent-expected.txt:

Rebaseline.

2:07 PM Changeset in webkit [189385] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Clean up and modernize DOMTreeManager
https://bugs.webkit.org/show_bug.cgi?id=148821

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-04
Reviewed by Timothy Hatcher.

UserInterface/Controllers/DOMTreeManager.js:

(WebInspector.DOMTreeManager.prototype.requestDocument.onDocumentAvailable):
(WebInspector.DOMTreeManager.prototype.requestDocument):
(WebInspector.DOMTreeManager.prototype.pushNodeByPathToFrontend):
(WebInspector.DOMTreeManager.prototype._wrapClientCallback):
(WebInspector.DOMTreeManager.prototype._attributeModified):
(WebInspector.DOMTreeManager.prototype._attributeRemoved):
(WebInspector.DOMTreeManager.prototype._inlineStyleInvalidated):
(WebInspector.DOMTreeManager.prototype._loadNodeAttributes):
(WebInspector.DOMTreeManager.prototype.cancelSearch):
(WebInspector.DOMTreeManager.prototype.querySelector):
(WebInspector.DOMTreeManager.prototype.querySelectorAll):
(WebInspector.DOMTreeManager.prototype.highlightDOMNode):
(WebInspector.DOMTreeManager.prototype._buildHighlightConfig):
Cleanup and modernize where appropriate.

UserInterface/Views/SearchSidebarPanel.js:

(WebInspector.SearchSidebarPanel.prototype.performSearch):
Callback is now required.

2:04 PM Changeset in webkit [189384] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Triage some of the failures of the CSS WG's multicolumn tests imported in r189364.

TestExpectations:

2:04 PM Changeset in webkit [189383] by jmarcell@apple.com

2 edits in trunk/Tools

Fix Swift unit tests for prepare-ChangeLog.
https://bugs.webkit.org/show_bug.cgi?id=148817

Reviewed by Alexey Proskuryakov.

Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed

Swift unit tests for prepare-ChangeLog.

2:00 PM Changeset in webkit [189382] by commit-queue@webkit.org

5 edits
2 adds in trunk/Source/JavaScriptCore

Implement the GetLocal and SetLocal instructions in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=148793

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-04
Reviewed by Saam Barati.

This patch implements the GetLocal and SetLocal instructions for locals
of type int32 in WebAssembly. A "local" in this context is either an
argument or a local variable.

tests/stress/wasm-locals.js: Added.

(shouldBe):

tests/stress/wasm-locals.wasm: Added.
wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::buildSetLocal):
(JSC::WASMFunctionCompiler::buildGetLocal):

wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseSetLocalStatement):
(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseGetLocalExpressionI32):

wasm/WASMFunctionParser.h:
wasm/WASMFunctionSyntaxChecker.h:

(JSC::WASMFunctionSyntaxChecker::buildSetLocal):
(JSC::WASMFunctionSyntaxChecker::buildGetLocal):

1:59 PM Changeset in webkit [189381] by ap@apple.com

1 edit
2 adds in trunk/LayoutTests

Test Serbian ".срб" domain support
https://bugs.webkit.org/show_bug.cgi?id=148761
<rdar://problem/22569849>

Reviewed by Tim Horton.

fast/url/user-visible/srb-expected.txt: Added.
fast/url/user-visible/srb.html: Added.

1:48 PM Changeset in webkit [189380] by Beth Dakin

2 edits in trunk/LayoutTests

Rubber-stamped by Tim Horton.

The bots appear to have a new enough SDK now.

platform/mac-wk2/TestExpectations:

1:47 PM Changeset in webkit [189379] by Lucas Forschler

3 edits in trunk/Tools

Modifications to the webkit-nightly logic.

WebKitLauncher/WebKitNightlyEnablerSparkle.m:

(updateAlertPanel):

WebKitLauncher/main.m:

(displayErrorAndQuit):

1:24 PM Changeset in webkit [189378] by Beth Dakin

4 edits in trunk

Speculative build fix.

Source/WebCore:

platform/spi/mac/NSEventSPI.h:

Tools:

WebKitTestRunner/mac/EventSenderProxy.mm:

1:20 PM Changeset in webkit [189377] by Alan Bujtas

10 edits
9 adds
45 deletes in trunk/LayoutTests

Repaint cleanup:
gradients-em-stops-repaint.html -> reftest
hover-pseudo-borders.html -> reftest
inline-block-resize.html -> reftest
inline-color-change.html -> reftest
inline-outline-repaint.html -> reftest
inline-relative-positioned.html -> reftest
intermediate-layout-position-clip.html -> reftest
intermediate-layout-position.html -> reftest
invisible-objects.html -> reftest

Unreviewed.

fast/repaint/gradients-em-stops-repaint-expected.html: Added.
fast/repaint/gradients-em-stops-repaint.html:
fast/repaint/hover-pseudo-borders-expected.html: Added.
fast/repaint/hover-pseudo-borders.html:
fast/repaint/inline-block-resize-expected.html: Added.
fast/repaint/inline-block-resize-expected.png: Removed.
fast/repaint/inline-block-resize-expected.txt: Removed.
fast/repaint/inline-block-resize.html:
fast/repaint/inline-color-change-expected.html: Added.
fast/repaint/inline-color-change.html:
fast/repaint/inline-outline-repaint-expected.html: Added.
fast/repaint/inline-outline-repaint.html:
fast/repaint/inline-relative-positioned-expected.html: Added.
fast/repaint/inline-relative-positioned-expected.png: Removed.
fast/repaint/inline-relative-positioned-expected.txt: Removed.
fast/repaint/inline-relative-positioned.html:
fast/repaint/intermediate-layout-position-clip-expected.html: Added.
fast/repaint/intermediate-layout-position-clip-expected.png: Removed.
fast/repaint/intermediate-layout-position-clip-expected.txt: Removed.
fast/repaint/intermediate-layout-position-clip.html:
fast/repaint/intermediate-layout-position-expected.html: Added.
fast/repaint/intermediate-layout-position-expected.txt: Removed.
fast/repaint/intermediate-layout-position.html:
fast/repaint/invisible-objects-expected.html: Added.
fast/repaint/invisible-objects-expected.txt: Removed.
fast/repaint/invisible-objects.html:
platform/efl/fast/repaint/gradients-em-stops-repaint-expected.png: Removed.
platform/efl/fast/repaint/gradients-em-stops-repaint-expected.txt: Removed.
platform/efl/fast/repaint/hover-pseudo-borders-expected.png: Removed.
platform/efl/fast/repaint/hover-pseudo-borders-expected.txt: Removed.
platform/efl/fast/repaint/inline-color-change-expected.png: Removed.
platform/efl/fast/repaint/inline-color-change-expected.txt: Removed.
platform/efl/fast/repaint/inline-outline-repaint-expected.png: Removed.
platform/efl/fast/repaint/inline-outline-repaint-expected.txt: Removed.
platform/efl/fast/repaint/inline-relative-positioned-expected.txt: Removed.
platform/efl/fast/repaint/intermediate-layout-position-expected.png: Removed.
platform/gtk/fast/repaint/gradients-em-stops-repaint-expected.png: Removed.
platform/gtk/fast/repaint/gradients-em-stops-repaint-expected.txt: Removed.
platform/gtk/fast/repaint/hover-pseudo-borders-expected.png: Removed.
platform/gtk/fast/repaint/hover-pseudo-borders-expected.txt: Removed.
platform/gtk/fast/repaint/inline-color-change-expected.png: Removed.
platform/gtk/fast/repaint/inline-color-change-expected.txt: Removed.
platform/gtk/fast/repaint/inline-outline-repaint-expected.png: Removed.
platform/gtk/fast/repaint/inline-outline-repaint-expected.txt: Removed.
platform/gtk/fast/repaint/inline-relative-positioned-expected.png: Removed.
platform/gtk/fast/repaint/inline-relative-positioned-expected.txt: Removed.
platform/gtk/fast/repaint/intermediate-layout-position-expected.png: Removed.
platform/gtk/fast/repaint/repaint/hover-pseudo-borders-expected.png: Removed.
platform/gtk/fast/repaint/repaint/hover-pseudo-borders-expected.txt: Removed.
platform/mac-wk2/fast/repaint/invisible-objects-expected.txt: Removed.
platform/mac/fast/repaint/gradients-em-stops-repaint-expected.png: Removed.
platform/mac/fast/repaint/gradients-em-stops-repaint-expected.txt: Removed.
platform/mac/fast/repaint/hover-pseudo-borders-expected.png: Removed.
platform/mac/fast/repaint/hover-pseudo-borders-expected.txt: Removed.
platform/mac/fast/repaint/inline-block-resize-expected.png: Removed.
platform/mac/fast/repaint/inline-color-change-expected.png: Removed.
platform/mac/fast/repaint/inline-color-change-expected.txt: Removed.
platform/mac/fast/repaint/inline-outline-repaint-expected.png: Removed.
platform/mac/fast/repaint/inline-outline-repaint-expected.txt: Removed.
platform/mac/fast/repaint/intermediate-layout-position-clip-expected.png: Removed.
platform/mac/fast/repaint/intermediate-layout-position-expected.png: Removed.
platform/mac/fast/repaint/invisible-objects-expected.png: Removed.
platform/win/fast/repaint/inline-color-change-expected.txt: Removed.
platform/win/fast/repaint/inline-outline-repaint-expected.txt: Removed.

1:09 PM Changeset in webkit [189376] by basile_clement@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, add missing copyright to file from r189336

bytecompiler/SetForScope.h:

1:00 PM Changeset in webkit [189375] by BJ Burg

47 edits
3 adds in trunk

Web Inspector: InspectorController should support multiple frontend channels
https://bugs.webkit.org/show_bug.cgi?id=148538

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Instead of a singleton, it should be possible to have multiple channels open
at the same time and to individually close channels as frontends come and go.

The FrontendRouter class keeps a list of open FrontendChannels and sends messages
to the appropriate frontends based on whether the message is a response or event.
Each InspectorController owns a single FrontendRouter and BackendDispatcher instance.
Inspector backend code that sends messages to the frontend should switch over to
using the router rather than directly using a FrontendChannel.

CMakeLists.txt:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
inspector/InspectorBackendDispatcher.cpp: Move constructors/destructors out of the header

to avoid including InspectorFrontendRouter everywhere. Use the router instead of a
specific frontend channel. Remove guards that are no longer necessary since the router
is guaranteed to outlive the backend dispatcher.

(Inspector::SupplementalBackendDispatcher::SupplementalBackendDispatcher):
(Inspector::SupplementalBackendDispatcher::~SupplementalBackendDispatcher):
(Inspector::BackendDispatcher::BackendDispatcher):
(Inspector::BackendDispatcher::create):
(Inspector::BackendDispatcher::isActive):
(Inspector::BackendDispatcher::registerDispatcherForDomain):
(Inspector::BackendDispatcher::sendResponse):
(Inspector::BackendDispatcher::sendPendingErrors):

inspector/InspectorBackendDispatcher.h:

(Inspector::SupplementalBackendDispatcher::SupplementalBackendDispatcher): Deleted.
(Inspector::SupplementalBackendDispatcher::~SupplementalBackendDispatcher): Deleted.
(Inspector::BackendDispatcher::clearFrontend): Deleted, no longer necessary.
(Inspector::BackendDispatcher::isActive): Moved to implementation file.
(Inspector::BackendDispatcher::BackendDispatcher): Moved to implementation file.

inspector/InspectorFrontendRouter.cpp: Added.

(Inspector::FrontendRouter::create):
(Inspector::FrontendRouter::connectFrontend):
(Inspector::FrontendRouter::disconnectFrontend):
(Inspector::FrontendRouter::disconnectAllFrontends):
(Inspector::FrontendRouter::leakChannel):
(Inspector::FrontendRouter::hasLocalFrontend):
(Inspector::FrontendRouter::hasRemoteFrontend):
(Inspector::FrontendRouter::sendEvent):
(Inspector::FrontendRouter::sendResponse):

inspector/InspectorFrontendRouter.h: Added.
inspector/JSGlobalObjectInspectorController.cpp: Remove guards that are no longer necessary.

The frontend router and backend dispatcher now have the same lifetime as the controller.
Explicitly connect/disconnect the frontend channel.

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::globalObjectDestroyed):
(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::disconnectFrontend):
(Inspector::JSGlobalObjectInspectorController::disconnectAllFrontends):
(Inspector::JSGlobalObjectInspectorController::dispatchMessageFromFrontend):
(Inspector::JSGlobalObjectInspectorController::appendExtraAgent):
(Inspector::JSGlobalObjectInspectorController::pause): Deleted.

inspector/JSGlobalObjectInspectorController.h:
inspector/agents/InspectorAgent.cpp:
inspector/agents/InspectorConsoleAgent.cpp:
inspector/agents/InspectorDebuggerAgent.cpp:
inspector/agents/InspectorRuntimeAgent.cpp:
inspector/augmentable/AugmentableInspectorController.h:

(Inspector::AugmentableInspectorController::connected):

inspector/remote/RemoteInspectorDebuggable.h:
inspector/remote/RemoteInspectorDebuggableConnection.mm:

(Inspector::RemoteInspectorDebuggableConnection::close):

inspector/scripts/codegen/generate_cpp_alternate_backend_dispatcher_header.py:

(CppAlternateBackendDispatcherHeaderGenerator.generate_output):

inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:

(ObjCFrontendDispatcherImplementationGenerator._generate_event): Use the router.

runtime/JSGlobalObjectDebuggable.cpp:

(JSC::JSGlobalObjectDebuggable::disconnect):

runtime/JSGlobalObjectDebuggable.h:

Source/WebCore:

No new tests, no behavior change from this patch. Teardown scenarios are
covered by existing protocol and inspector tests running under DRT and WKTR.

ForwardingHeaders/inspector/InspectorFrontendRouter.h: Added.
WebCore.vcxproj/WebCore.vcxproj:
inspector/InspectorClient.h: Stop using forwarded types.
inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::hasLocalFrontend):
(WebCore::InspectorController::hasRemoteFrontend):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::disconnectAllFrontends): Added. Disconnects all
frontends and signals DisconnectReason::InspectedTargetDestroyed.

(WebCore::InspectorController::show):
(WebCore::InspectorController::close):
(WebCore::InspectorController::dispatchMessageFromFrontend):

inspector/InspectorController.h: Add default value for isAutomaticInspection.
inspector/InspectorDatabaseAgent.cpp:
inspector/InspectorIndexedDBAgent.cpp:
inspector/InspectorResourceAgent.cpp:
inspector/WorkerInspectorController.cpp: Use a router with a singleton channel

that forwards messages over to the main page.

(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
(WebCore::WorkerInspectorController::dispatchMessageFromFrontend):

inspector/WorkerInspectorController.h:
page/PageDebuggable.cpp:

(WebCore::PageDebuggable::disconnect):

page/PageDebuggable.h:
testing/Internals.cpp: Clear the frontend client before disconnecting frontend channel.

(WebCore::Internals::openDummyInspectorFrontend):
(WebCore::Internals::closeDummyInspectorFrontend):

Source/WebKit/mac:

Remove the notifyInspectorController flag from closeWindow. Since InspectorClients
must now manually disconnect their FrontendChannel(s), we should always
perform the teardown that was guarded by this flag.

WebCoreSupport/WebInspectorClient.h:
WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::bringFrontendToFront): Add a missing assertion.
(WebInspectorFrontendClient::closeWindow):
(WebInspectorFrontendClient::disconnectFromBackend):
(-[WebInspectorWindowController windowShouldClose:]):
(-[WebInspectorWindowController destroyInspectorView]): Always clear the frontend client.
(-[WebInspectorWindowController destroyInspectorView:]): Renamed to above.

Source/WebKit/win:

WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::closeInspectorFrontend):
(WebInspectorFrontendClient::~WebInspectorFrontendClient):
(WebInspectorFrontendClient::closeWindow):
(WebInspectorFrontendClient::destroyInspectorView):

WebCoreSupport/WebInspectorClient.h:

Source/WebKit2:

Explicitly disconnect the frontend channel when closing the frontend.

Rename createInspectorPage/closeFrontend to the symmetric and unambiguous
{open,close}FrontendConnection in the WebInspector class.

WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::openInspectorFrontend):
(WebKit::WebInspectorClient::closeInspectorFrontend):

WebProcess/WebCoreSupport/WebInspectorClient.h: Stop using a forwarded type.
WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::openFrontendConnection):
(WebKit::WebInspector::closeFrontendConnection):
(WebKit::WebInspector::remoteFrontendConnected):
(WebKit::WebInspector::remoteFrontendDisconnected):
(WebKit::WebInspector::createInspectorPage): Deleted.
(WebKit::WebInspector::closeFrontend): Deleted.

WebProcess/WebPage/WebInspector.h:

Tools:

InspectorClients must explicitly disconnect their frontend channel(s) from the
inspected page's InspectorController.

To make this possible, DumpRenderTree should not destroy non-primary views until
it has tried to close any abandoned Web Inspector instances. Performing teardown
in the reverse order prevents disconnection of the frontend channel because that
prematurely destroys the inspector frontend client.

DumpRenderTree/mac/DumpRenderTree.mm:

(runTest):

DumpRenderTree/win/DumpRenderTree.cpp:

(runTest):

12:57 PM Changeset in webkit [189374] by Matt Baker

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Render Frames "Other" task filter checkbox misaligned with text
https://bugs.webkit.org/show_bug.cgi?id=148788

Reviewed by Timothy Hatcher.

UserInterface/Views/ChartDetailsSectionRow.css:

(.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item > label > .color-key):
Adjust "fake" checkbox margin to align with label text.

12:53 PM Changeset in webkit [189373] by commit-queue@webkit.org

5 edits
8 adds in trunk

Web Inspector: Expand Console domain test coverage
https://bugs.webkit.org/show_bug.cgi?id=148740

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-04
Reviewed by Brian Burg.

Source/JavaScriptCore:

inspector/protocol/Console.json:

Update the description of this command now that it only
manipulates $0, and not $1, $2, .. $n.

Source/WebInspectorUI:

UserInterface/Protocol/RemoteObject.js:

Add a few helpers for checking the RemoteObject type.

LayoutTests:

Test more Console domain commands and events.

inspector/console/addInspectedNode-expected.txt: Added.
inspector/console/addInspectedNode.html: Added.
inspector/console/clearMessages-expected.txt: Added.
inspector/console/clearMessages.html: Added.
inspector/console/messageRepeatCountUpdated-expected.txt: Added.
inspector/console/messageRepeatCountUpdated.html: Added.
inspector/console/messagesCleared-expected.txt: Added.
inspector/console/messagesCleared.html: Added.

12:52 PM Changeset in webkit [189372] by jer.noble@apple.com

2 edits
74 adds in trunk/LayoutTests

Unreviewed gardening; enabling media/ and http/tests/media/ tests (with expected failures) on ios-simulator

platform/ios-simulator/TestExpectations:
platform/ios-simulator/http/tests/media/hls/video-controls-live-stream-expected.txt: Added.
platform/ios-simulator/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
platform/ios-simulator/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
platform/ios-simulator/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.
platform/ios-simulator/media/audio-controls-rendering-expected.png: Added.
platform/ios-simulator/media/audio-controls-rendering-expected.txt: Added.
platform/ios-simulator/media/audio-repaint-expected.txt: Added.
platform/ios-simulator/media/controls-after-reload-expected.png: Added.
platform/ios-simulator/media/controls-after-reload-expected.txt: Added.
platform/ios-simulator/media/controls-layout-direction-expected.png: Added.
platform/ios-simulator/media/controls-strict-expected.png: Added.
platform/ios-simulator/media/controls-strict-expected.txt: Added.
platform/ios-simulator/media/controls-strict-mode-expected.txt: Added.
platform/ios-simulator/media/controls-styling-expected.png: Added.
platform/ios-simulator/media/controls-styling-expected.txt: Added.
platform/ios-simulator/media/controls-styling-strict-expected.png: Added.
platform/ios-simulator/media/controls-styling-strict-expected.txt: Added.
platform/ios-simulator/media/controls-without-preload-expected.png: Added.
platform/ios-simulator/media/controls-without-preload-expected.txt: Added.
platform/ios-simulator/media/encrypted-media/encrypted-media-can-play-type-expected.txt: Added.
platform/ios-simulator/media/media-can-play-wav-audio-expected.txt: Added.
platform/ios-simulator/media/media-can-play-webm-expected.txt: Added.
platform/ios-simulator/media/media-controls-clone-expected.png: Added.
platform/ios-simulator/media/media-controls-clone-expected.txt: Added.
platform/ios-simulator/media/media-document-audio-repaint-expected.png: Added.
platform/ios-simulator/media/track/track-cue-rendering-horizontal-expected.png: Added.
platform/ios-simulator/media/track/track-cue-rendering-horizontal-expected.txt: Added.
platform/ios-simulator/media/track/track-cue-rendering-vertical-expected.png: Added.
platform/ios-simulator/media/track/track-cue-rendering-vertical-expected.txt: Added.
platform/ios-simulator/media/track/track-in-band-subtitles-too-large-expected.png: Added.
platform/ios-simulator/media/video-aspect-ratio-expected.png: Added.
platform/ios-simulator/media/video-aspect-ratio-expected.txt: Added.
platform/ios-simulator/media/video-canvas-alpha-expected.png: Added.
platform/ios-simulator/media/video-canvas-drawing-expected.png: Added.
platform/ios-simulator/media/video-colorspace-yuv420-expected.png: Added.
platform/ios-simulator/media/video-colorspace-yuv422-expected.png: Added.
platform/ios-simulator/media/video-controls-captions-trackmenu-expected.txt: Added.
platform/ios-simulator/media/video-controls-captions-trackmenu-hide-on-click-expected.txt: Added.
platform/ios-simulator/media/video-controls-captions-trackmenu-localized-expected.txt: Added.
platform/ios-simulator/media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles-expected.txt: Added.
platform/ios-simulator/media/video-controls-captions-trackmenu-sorted-expected.txt: Added.
platform/ios-simulator/media/video-controls-no-scripting-expected.txt: Added.
platform/ios-simulator/media/video-controls-rendering-expected.png: Added.
platform/ios-simulator/media/video-controls-rendering-expected.txt: Added.
platform/ios-simulator/media/video-display-toggle-expected.png: Added.
platform/ios-simulator/media/video-display-toggle-expected.txt: Added.
platform/ios-simulator/media/video-empty-source-expected.png: Added.
platform/ios-simulator/media/video-empty-source-expected.txt: Added.
platform/ios-simulator/media/video-frame-accurate-seek-expected.png: Added.
platform/ios-simulator/media/video-layer-crash-expected.png: Added.
platform/ios-simulator/media/video-layer-crash-expected.txt: Added.
platform/ios-simulator/media/video-no-audio-expected.png: Added.
platform/ios-simulator/media/video-no-audio-expected.txt: Added.
platform/ios-simulator/media/video-playing-and-pause-expected.png: Added.
platform/ios-simulator/media/video-playing-and-pause-expected.txt: Added.
platform/ios-simulator/media/video-remove-insert-repaints-expected.png: Added.
platform/ios-simulator/media/video-replaces-poster-expected.png: Added.
platform/ios-simulator/media/video-transformed-expected.png: Added.
platform/ios-simulator/media/video-transformed-expected.txt: Added.
platform/ios-simulator/media/video-volume-slider-expected.png: Added.
platform/ios-simulator/media/video-volume-slider-expected.txt: Added.
platform/ios-simulator/media/video-zoom-controls-expected.png: Added.
platform/ios-simulator/media/video-zoom-controls-expected.txt: Added.
platform/ios-simulator/media/video-zoom-expected.png: Added.
platform/ios-simulator/media/video-zoom-expected.txt: Added.
platform/ios-simulator/media/volume-bar-empty-when-muted-expected.txt: Added.

12:48 PM Changeset in webkit [189371] by commit-queue@webkit.org

6 edits
2 adds in trunk

Web Inspector: Test RuntimeAgent.parse, detecting if a script parse error is recoverable
https://bugs.webkit.org/show_bug.cgi?id=148790

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-04
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

parser/Lexer.cpp:

(JSC::Lexer<T>::lex):

parser/Parser.cpp:

(JSC::Parser<LexerType>::printUnexpectedTokenText):

parser/ParserTokens.h:

More consistently name and treat unterminated numeric literals.

parser/Parser.h:

(JSC::Parser<LexerType>::parse):
Treat multiline capable unterminated literals as recoverable.

LayoutTests:

inspector/runtime/parse-expected.txt: Added.
inspector/runtime/parse.html: Added.

12:24 PM Changeset in webkit [189370] by timothy_horton@apple.com

3 edits in trunk/LayoutTests

swipe-start-hysteresis-failures is flaky
https://bugs.webkit.org/show_bug.cgi?id=148809

Reviewed by Alexey Proskuryakov.

swipe/swipe-start-hysteresis-failures.html:
swipe/swipe-start-hysteresis-failures-expected.txt:

Instead of depending on the specific timing of didStartSwipe vs. the events
in this case, just make sure we hit it by the time the test finishes.

12:14 PM Changeset in webkit [189369] by jer.noble@apple.com

4 edits in trunk/Source/WebCore

[iOS] Enable media layout tests to run simultaneously by ignoring system-level interruptions
https://bugs.webkit.org/show_bug.cgi?id=148807

Reviewed by Eric Carlson.

Add an internal property that, when set, will cause system-level interruption notifications
(e.g., due to simultaneous media playback in separate processes) to be ignored by the
PlatformMediaSessionManager, and cause the media playback sessions to continue normally, if
inaudibly.

platform/audio/PlatformMediaSessionManager.h:

(WebCore::PlatformMediaSessionManager::willIgnoreSystemInterruptions):
(WebCore::PlatformMediaSessionManager::setWillIgnoreSystemInterruptions):

platform/audio/ios/MediaSessionManagerIOS.mm:

(-[WebMediaSessionHelper interruption:]):
(-[WebMediaSessionHelper applicationWillEnterForeground:]):
(-[WebMediaSessionHelper applicationDidBecomeActive:]):
(-[WebMediaSessionHelper applicationWillResignActive:]):
(-[WebMediaSessionHelper applicationDidEnterBackground:]):

testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):

12:12 PM Changeset in webkit [189368] by ap@apple.com

2 edits in trunk/LayoutTests

Skip newly imported IndexedDB test on iOS WebKit1, because IndexedDB only works with WebKit2.

platform/ios-simulator-wk1/TestExpectations:

12:00 PM Changeset in webkit [189367] by Csaba Osztrogonác

2 edits in trunk/Source/WTF

Enable reference qualified functions for GCC
https://bugs.webkit.org/show_bug.cgi?id=148526

Reviewed by Darin Adler.

wtf/Compiler.h:

11:58 AM Changeset in webkit [189366] by mitz@apple.com

2 edits in trunk/Source/WebKit2

[iOS] Disable backspace key navigation by default
https://bugs.webkit.org/show_bug.cgi?id=148808

Reviewed by Tim Horton.

Shared/WebPreferencesDefinitions.h: Defined DEFAULT_BACKSPACE_KEY_NAVIGATION_ENABLED as false on iOS, true elsewhere, and made it the default value of the backspaceKeyNavigationEnabled preference key.

11:45 AM Changeset in webkit [189365] by Beth Dakin

19 edits
3 adds in trunk

Need to be able to test default behaviors on force click
https://bugs.webkit.org/show_bug.cgi?id=148758

Reviewed by Tim Horton.

Source/WebCore:

WKTR needs access to this.

platform/spi/mac/NSEventSPI.h:

Source/WebKit2:

The hit test seems to return synchronously in WKTR, so we need to do the hit
test last before we clear state otherwise we will trample the hit test
result.

UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController immediateActionRecognizerWillPrepare:]):
(-[WKImmediateActionController immediateActionRecognizerWillBeginAnimation:]):

Tools:

This patch adds a new eventSender method to do a full, completed force click,
and it re-works all of the existing force methods to dispatch their events in
such a way that they will trigger the NSImmediateAction gesture recognizer.
To do this, first we need to send the events to the app rather than straight
to the view, and also needed to tweak some state and send the events in a
delayed fashion.

New public function mouseForceClick() and private helper functions to make
NSEvents.

WebKitTestRunner/EventSenderProxy.h:

New public function mouseForceClick().

WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::mouseMoveTo):
(WTR::EventSendingController::mouseForceClick):
(WTR::EventSendingController::mouseForceDown):

WebKitTestRunner/InjectedBundle/EventSendingController.h:
WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

initPressureEventAtLocation needs to take a stageTransition and a window.

WebKitTestRunner/mac/EventSenderProxy.mm:

(-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
(-[EventSenderSyntheticEvent stageTransition]):
(-[EventSenderSyntheticEvent timestamp]):
(-[EventSenderSyntheticEvent _cgsEventRecord]):
(-[EventSenderSyntheticEvent window]):

In order to enter the gesture recognizer, we need to start with a mouse down
that has a NSEventMaskPressure modifier.
(WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):

This ensures that the events queue properly for the force monitor in AppKit.
(WTR::spinRunLoopForForce):

We need to start the pressure change events with a began.

(WTR::EventSenderProxy::beginPressureEvent):

These functions can be used to create the NSEvent for a pressure change every
time we need one.
(WTR::EventSenderProxy::pressureChangeEvent):

Send the right series of events to emulate a full, completed force click.
(WTR::EventSenderProxy::mouseForceClick):

Use all of the new things for these existing functions.
(WTR::EventSenderProxy::mouseForceDown):
(WTR::EventSenderProxy::mouseForceUp):
(WTR::EventSenderProxy::mouseForceChanged):

Set NSFakeForceTouchDevice to YES.

WebKitTestRunner/mac/main.mm:

(setDefaultsToConsistentValuesForTesting):

LayoutTests:

One new test that tests a regression found during the work for
http://trac.webkit.org/changeset/181660

fast/events/force-click-on-link-navigation-expected.txt: Added.
fast/events/force-click-on-link-navigation.html: Added.
fast/events/resources/do-not-navigate-here.html: Added.
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/ios-simulator/TestExpectations:
platform/mac-mavericks/TestExpectations:
platform/mac-wk1/TestExpectations:
platform/win/TestExpectations:

11:44 AM Changeset in webkit [189364] by rniwa@webkit.org

3 edits
325 adds
1 delete in trunk/LayoutTests

Import new multicolumn layout tests from CSS WG testss
https://bugs.webkit.org/show_bug.cgi?id=148805

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Imported tests from https://github.com/w3c/csswg-test/tree/master/css-multicol-1 as of
46a095b681f997bef518ebe0a704c0a343a14a05 and removed the old tests in css/multicol directory.

This patch imports 136 new tests.

css/css-multicol-1: Added.
css/css-multicol-1/multicol-basic-001-expected.html: Added.
css/css-multicol-1/multicol-basic-001.html: Added.
css/css-multicol-1/multicol-basic-002-expected.html: Added.
css/css-multicol-1/multicol-basic-002.html: Added.
css/css-multicol-1/multicol-basic-003-expected.html: Added.
css/css-multicol-1/multicol-basic-003.html: Added.
css/css-multicol-1/multicol-basic-004-expected.html: Added.
css/css-multicol-1/multicol-basic-004.html: Added.
css/css-multicol-1/multicol-block-clip-001-expected.xht: Added.
css/css-multicol-1/multicol-block-clip-001.xht: Added.
css/css-multicol-1/multicol-block-clip-002-expected.xht: Added.
css/css-multicol-1/multicol-block-clip-002.xht: Added.
css/css-multicol-1/multicol-br-inside-avoidcolumn-001-expected.xht: Added.
css/css-multicol-1/multicol-br-inside-avoidcolumn-001.xht: Added.
css/css-multicol-1/multicol-break-000-expected.xht: Added.
css/css-multicol-1/multicol-break-000.xht: Added.
css/css-multicol-1/multicol-break-001-expected.xht: Added.
css/css-multicol-1/multicol-break-001.xht: Added.
css/css-multicol-1/multicol-clip-001-expected.xht: Added.
css/css-multicol-1/multicol-clip-001.xht: Added.
css/css-multicol-1/multicol-clip-002-expected.xht: Added.
css/css-multicol-1/multicol-clip-002.xht: Added.
css/css-multicol-1/multicol-collapsing-001-expected.xht: Added.
css/css-multicol-1/multicol-collapsing-001.xht: Added.
css/css-multicol-1/multicol-columns-001-expected.xht: Added.
css/css-multicol-1/multicol-columns-001.xht: Added.
css/css-multicol-1/multicol-columns-002-expected.xht: Added.
css/css-multicol-1/multicol-columns-002.xht: Added.
css/css-multicol-1/multicol-columns-003-expected.xht: Added.
css/css-multicol-1/multicol-columns-003.xht: Added.
css/css-multicol-1/multicol-columns-004-expected.xht: Added.
css/css-multicol-1/multicol-columns-004.xht: Added.
css/css-multicol-1/multicol-columns-005-expected.xht: Added.
css/css-multicol-1/multicol-columns-005.xht: Added.
css/css-multicol-1/multicol-columns-006-expected.xht: Added.
css/css-multicol-1/multicol-columns-006.xht: Added.
css/css-multicol-1/multicol-columns-007-expected.xht: Added.
css/css-multicol-1/multicol-columns-007.xht: Added.
css/css-multicol-1/multicol-columns-invalid-001-expected.xht: Added.
css/css-multicol-1/multicol-columns-invalid-001.xht: Added.
css/css-multicol-1/multicol-columns-invalid-002-expected.xht: Added.
css/css-multicol-1/multicol-columns-invalid-002.xht: Added.
css/css-multicol-1/multicol-columns-toolong-001-expected.xht: Added.
css/css-multicol-1/multicol-columns-toolong-001.xht: Added.
css/css-multicol-1/multicol-containing-001-expected.xht: Added.
css/css-multicol-1/multicol-containing-001.xht: Added.
css/css-multicol-1/multicol-containing-002-expected.xht: Added.
css/css-multicol-1/multicol-containing-002.xht: Added.
css/css-multicol-1/multicol-count-001-expected.xht: Added.
css/css-multicol-1/multicol-count-001.xht: Added.
css/css-multicol-1/multicol-count-002-expected.xht: Added.
css/css-multicol-1/multicol-count-002.xht: Added.
css/css-multicol-1/multicol-count-computed-001-expected.xht: Added.
css/css-multicol-1/multicol-count-computed-001.xht: Added.
css/css-multicol-1/multicol-count-computed-002-expected.xht: Added.
css/css-multicol-1/multicol-count-computed-002.xht: Added.
css/css-multicol-1/multicol-count-computed-003-expected.xht: Added.
css/css-multicol-1/multicol-count-computed-003.xht: Added.
css/css-multicol-1/multicol-count-computed-004-expected.xht: Added.
css/css-multicol-1/multicol-count-computed-004.xht: Added.
css/css-multicol-1/multicol-count-computed-005-expected.xht: Added.
css/css-multicol-1/multicol-count-computed-005.xht: Added.
css/css-multicol-1/multicol-count-large-001-expected.xht: Added.
css/css-multicol-1/multicol-count-large-001.xht: Added.
css/css-multicol-1/multicol-count-large-002-expected.xht: Added.
css/css-multicol-1/multicol-count-large-002.xht: Added.
css/css-multicol-1/multicol-count-negative-001-expected.xht: Added.
css/css-multicol-1/multicol-count-negative-001.xht: Added.
css/css-multicol-1/multicol-count-negative-002-expected.xht: Added.
css/css-multicol-1/multicol-count-negative-002.xht: Added.
css/css-multicol-1/multicol-count-non-integer-001-expected.xht: Added.
css/css-multicol-1/multicol-count-non-integer-001.xht: Added.
css/css-multicol-1/multicol-count-non-integer-002-expected.xht: Added.
css/css-multicol-1/multicol-count-non-integer-002.xht: Added.
css/css-multicol-1/multicol-count-non-integer-003-expected.xht: Added.
css/css-multicol-1/multicol-count-non-integer-003.xht: Added.
css/css-multicol-1/multicol-fill-000-expected.xht: Added.
css/css-multicol-1/multicol-fill-000.xht: Added.
css/css-multicol-1/multicol-fill-001-expected.xht: Added.
css/css-multicol-1/multicol-fill-001.xht: Added.
css/css-multicol-1/multicol-fill-auto-001-expected.xht: Added.
css/css-multicol-1/multicol-fill-auto-001.xht: Added.
css/css-multicol-1/multicol-fill-auto-002-expected.xht: Added.
css/css-multicol-1/multicol-fill-auto-002.xht: Added.
css/css-multicol-1/multicol-fill-auto-003-expected.xht: Added.
css/css-multicol-1/multicol-fill-auto-003.xht: Added.
css/css-multicol-1/multicol-fill-auto-block-children-001-expected.xht: Added.
css/css-multicol-1/multicol-fill-auto-block-children-001.xht: Added.
css/css-multicol-1/multicol-fill-auto-block-children-002-expected.xht: Added.
css/css-multicol-1/multicol-fill-auto-block-children-002.xht: Added.
css/css-multicol-1/multicol-fill-auto-expected.xht: Added.
css/css-multicol-1/multicol-fill-auto.xht: Added.
css/css-multicol-1/multicol-fill-balance-001-expected.xht: Added.
css/css-multicol-1/multicol-fill-balance-001.xht: Added.
css/css-multicol-1/multicol-gap-000-expected.xht: Added.
css/css-multicol-1/multicol-gap-000.xht: Added.
css/css-multicol-1/multicol-gap-001-expected.xht: Added.
css/css-multicol-1/multicol-gap-001.xht: Added.
css/css-multicol-1/multicol-gap-002-expected.xht: Added.
css/css-multicol-1/multicol-gap-002.xht: Added.
css/css-multicol-1/multicol-gap-003-expected.xht: Added.
css/css-multicol-1/multicol-gap-003.xht: Added.
css/css-multicol-1/multicol-gap-fraction-001-expected.xht: Added.
css/css-multicol-1/multicol-gap-fraction-001.xht: Added.
css/css-multicol-1/multicol-gap-large-001-expected.xht: Added.
css/css-multicol-1/multicol-gap-large-001.xht: Added.
css/css-multicol-1/multicol-gap-large-002-expected.xht: Added.
css/css-multicol-1/multicol-gap-large-002.xht: Added.
css/css-multicol-1/multicol-gap-negative-001-expected.xht: Added.
css/css-multicol-1/multicol-gap-negative-001.xht: Added.
css/css-multicol-1/multicol-height-001-expected.xht: Added.
css/css-multicol-1/multicol-height-001.xht: Added.
css/css-multicol-1/multicol-height-block-child-001-expected.xht: Added.
css/css-multicol-1/multicol-height-block-child-001.xht: Added.
css/css-multicol-1/multicol-inherit-001-expected.xht: Added.
css/css-multicol-1/multicol-inherit-001.xht: Added.
css/css-multicol-1/multicol-inherit-002-expected.xht: Added.
css/css-multicol-1/multicol-inherit-002.xht: Added.
css/css-multicol-1/multicol-inherit-003-expected.xht: Added.
css/css-multicol-1/multicol-inherit-003.xht: Added.
css/css-multicol-1/multicol-inherit-004-expected.xht: Added.
css/css-multicol-1/multicol-inherit-004.xht: Added.
css/css-multicol-1/multicol-list-item-001-expected.xht: Added.
css/css-multicol-1/multicol-list-item-001.xht: Added.
css/css-multicol-1/multicol-margin-001-expected.xht: Added.
css/css-multicol-1/multicol-margin-001.xht: Added.
css/css-multicol-1/multicol-margin-002-expected.xht: Added.
css/css-multicol-1/multicol-margin-002.xht: Added.
css/css-multicol-1/multicol-margin-child-001-expected.xht: Added.
css/css-multicol-1/multicol-margin-child-001.xht: Added.
css/css-multicol-1/multicol-nested-002-expected.xht: Added.
css/css-multicol-1/multicol-nested-002.xht: Added.
css/css-multicol-1/multicol-nested-005-expected.xht: Added.
css/css-multicol-1/multicol-nested-005.xht: Added.
css/css-multicol-1/multicol-nested-column-rule-001-expected.xht: Added.
css/css-multicol-1/multicol-nested-column-rule-001.xht: Added.
css/css-multicol-1/multicol-nested-margin-001-expected.xht: Added.
css/css-multicol-1/multicol-nested-margin-001.xht: Added.
css/css-multicol-1/multicol-nested-margin-002-expected.xht: Added.
css/css-multicol-1/multicol-nested-margin-002.xht: Added.
css/css-multicol-1/multicol-nested-margin-003-expected.xht: Added.
css/css-multicol-1/multicol-nested-margin-003.xht: Added.
css/css-multicol-1/multicol-nested-margin-004-expected.xht: Added.
css/css-multicol-1/multicol-nested-margin-004.xht: Added.
css/css-multicol-1/multicol-nested-margin-005-expected.xht: Added.
css/css-multicol-1/multicol-nested-margin-005.xht: Added.
css/css-multicol-1/multicol-overflow-000-expected.xht: Added.
css/css-multicol-1/multicol-overflow-000.xht: Added.
css/css-multicol-1/multicol-overflowing-001-expected.xht: Added.
css/css-multicol-1/multicol-overflowing-001.xht: Added.
css/css-multicol-1/multicol-red.png: Added.
css/css-multicol-1/multicol-reduce-000-expected.xht: Added.
css/css-multicol-1/multicol-reduce-000.xht: Added.
css/css-multicol-1/multicol-rule-000-expected.xht: Added.
css/css-multicol-1/multicol-rule-000.xht: Added.
css/css-multicol-1/multicol-rule-001-expected.xht: Added.
css/css-multicol-1/multicol-rule-001.xht: Added.
css/css-multicol-1/multicol-rule-002-expected.xht: Added.
css/css-multicol-1/multicol-rule-002.xht: Added.
css/css-multicol-1/multicol-rule-003-expected.xht: Added.
css/css-multicol-1/multicol-rule-003.xht: Added.
css/css-multicol-1/multicol-rule-004-expected.xht: Added.
css/css-multicol-1/multicol-rule-004.xht: Added.
css/css-multicol-1/multicol-rule-color-001-expected.xht: Added.
css/css-multicol-1/multicol-rule-color-001.xht: Added.
css/css-multicol-1/multicol-rule-color-inherit-001-expected.xht: Added.
css/css-multicol-1/multicol-rule-color-inherit-001.xht: Added.
css/css-multicol-1/multicol-rule-color-inherit-002-expected.xht: Added.
css/css-multicol-1/multicol-rule-color-inherit-002.xht: Added.
css/css-multicol-1/multicol-rule-dashed-000-expected.xht: Added.
css/css-multicol-1/multicol-rule-dashed-000.xht: Added.
css/css-multicol-1/multicol-rule-dotted-000-expected.xht: Added.
css/css-multicol-1/multicol-rule-dotted-000.xht: Added.
css/css-multicol-1/multicol-rule-double-000-expected.xht: Added.
css/css-multicol-1/multicol-rule-double-000.xht: Added.
css/css-multicol-1/multicol-rule-fraction-001-expected.xht: Added.
css/css-multicol-1/multicol-rule-fraction-001.xht: Added.
css/css-multicol-1/multicol-rule-fraction-002-expected.xht: Added.
css/css-multicol-1/multicol-rule-fraction-002.xht: Added.
css/css-multicol-1/multicol-rule-fraction-003-expected.xht: Added.
css/css-multicol-1/multicol-rule-fraction-003.xht: Added.
css/css-multicol-1/multicol-rule-groove-000-expected.xht: Added.
css/css-multicol-1/multicol-rule-groove-000.xht: Added.
css/css-multicol-1/multicol-rule-hidden-000-expected.xht: Added.
css/css-multicol-1/multicol-rule-hidden-000.xht: Added.
css/css-multicol-1/multicol-rule-inset-000-expected.xht: Added.
css/css-multicol-1/multicol-rule-inset-000.xht: Added.
css/css-multicol-1/multicol-rule-large-001-expected.xht: Added.
css/css-multicol-1/multicol-rule-large-001.xht: Added.
css/css-multicol-1/multicol-rule-none-000-expected.xht: Added.
css/css-multicol-1/multicol-rule-none-000.xht: Added.
css/css-multicol-1/multicol-rule-outset-000-expected.xht: Added.
css/css-multicol-1/multicol-rule-outset-000.xht: Added.
css/css-multicol-1/multicol-rule-percent-001-expected.xht: Added.
css/css-multicol-1/multicol-rule-percent-001.xht: Added.
css/css-multicol-1/multicol-rule-px-001-expected.xht: Added.
css/css-multicol-1/multicol-rule-px-001.xht: Added.
css/css-multicol-1/multicol-rule-ridge-000-expected.xht: Added.
css/css-multicol-1/multicol-rule-ridge-000.xht: Added.
css/css-multicol-1/multicol-rule-samelength-001-expected.xht: Added.
css/css-multicol-1/multicol-rule-samelength-001.xht: Added.
css/css-multicol-1/multicol-rule-shorthand-001-expected.xht: Added.
css/css-multicol-1/multicol-rule-shorthand-001.xht: Added.
css/css-multicol-1/multicol-rule-shorthand-2.xht: Added.
css/css-multicol-1/multicol-rule-solid-000-expected.xht: Added.
css/css-multicol-1/multicol-rule-solid-000.xht: Added.
css/css-multicol-1/multicol-rule-stacking-001-expected.xht: Added.
css/css-multicol-1/multicol-rule-stacking-001.xht: Added.
css/css-multicol-1/multicol-rule-style-groove-001-expected.xht: Added.
css/css-multicol-1/multicol-rule-style-groove-001.xht: Added.
css/css-multicol-1/multicol-rule-style-inset-001-expected.xht: Added.
css/css-multicol-1/multicol-rule-style-inset-001.xht: Added.
css/css-multicol-1/multicol-rule-style-outset-001-expected.xht: Added.
css/css-multicol-1/multicol-rule-style-outset-001.xht: Added.
css/css-multicol-1/multicol-rule-style-ridge-001-expected.xht: Added.
css/css-multicol-1/multicol-rule-style-ridge-001.xht: Added.
css/css-multicol-1/multicol-shorthand-001-expected.xht: Added.
css/css-multicol-1/multicol-shorthand-001.xht: Added.
css/css-multicol-1/multicol-span-000-expected.xht: Added.
css/css-multicol-1/multicol-span-000.xht: Added.
css/css-multicol-1/multicol-span-all-001-expected.xht: Added.
css/css-multicol-1/multicol-span-all-001.xht: Added.
css/css-multicol-1/multicol-span-all-002-expected.xht: Added.
css/css-multicol-1/multicol-span-all-002.xht: Added.
css/css-multicol-1/multicol-span-all-003-expected.xht: Added.
css/css-multicol-1/multicol-span-all-003.xht: Added.
css/css-multicol-1/multicol-span-all-block-sibling-003-expected.xht: Added.
css/css-multicol-1/multicol-span-all-block-sibling-003.xht: Added.
css/css-multicol-1/multicol-span-all-child-001-expected.xht: Added.
css/css-multicol-1/multicol-span-all-child-001.xht: Added.
css/css-multicol-1/multicol-span-all-child-002-expected.xht: Added.
css/css-multicol-1/multicol-span-all-child-002.xht: Added.
css/css-multicol-1/multicol-span-all-margin-001-expected.xht: Added.
css/css-multicol-1/multicol-span-all-margin-001.xht: Added.
css/css-multicol-1/multicol-span-all-margin-002-expected.xht: Added.
css/css-multicol-1/multicol-span-all-margin-002.xht: Added.
css/css-multicol-1/multicol-span-all-margin-bottom-001-expected.xht: Added.
css/css-multicol-1/multicol-span-all-margin-bottom-001.xht: Added.
css/css-multicol-1/multicol-span-all-margin-nested-001-expected.xht: Added.
css/css-multicol-1/multicol-span-all-margin-nested-001.xht: Added.
css/css-multicol-1/multicol-span-all-margin-nested-002-expected.xht: Added.
css/css-multicol-1/multicol-span-all-margin-nested-002.xht: Added.
css/css-multicol-1/multicol-span-all-margin-nested-003-expected.xht: Added.
css/css-multicol-1/multicol-span-all-margin-nested-003.xht: Added.
css/css-multicol-1/multicol-span-all-margin-nested-firstchild-001-expected.xht: Added.
css/css-multicol-1/multicol-span-all-margin-nested-firstchild-001.xht: Added.
css/css-multicol-1/multicol-span-float-001-expected.xht: Added.
css/css-multicol-1/multicol-span-float-001.xht: Added.
css/css-multicol-1/multicol-span-none-001-expected.xht: Added.
css/css-multicol-1/multicol-span-none-001.xht: Added.
css/css-multicol-1/multicol-table-cell-001-expected.xht: Added.
css/css-multicol-1/multicol-table-cell-001.xht: Added.
css/css-multicol-1/multicol-table-cell-height-001-expected.xht: Added.
css/css-multicol-1/multicol-table-cell-height-001.xht: Added.
css/css-multicol-1/multicol-table-cell-height-002-expected.xht: Added.
css/css-multicol-1/multicol-table-cell-height-002.xht: Added.
css/css-multicol-1/multicol-table-cell-vertical-align-001-expected.xht: Added.
css/css-multicol-1/multicol-table-cell-vertical-align-001.xht: Added.
css/css-multicol-1/multicol-width-001-expected.xht: Added.
css/css-multicol-1/multicol-width-001.xht: Added.
css/css-multicol-1/multicol-width-002-expected.xht: Added.
css/css-multicol-1/multicol-width-002.xht: Added.
css/css-multicol-1/multicol-width-003-expected.xht: Added.
css/css-multicol-1/multicol-width-003.xht: Added.
css/css-multicol-1/multicol-width-count-001-expected.xht: Added.
css/css-multicol-1/multicol-width-count-001.xht: Added.
css/css-multicol-1/multicol-width-count-002-expected.xht: Added.
css/css-multicol-1/multicol-width-count-002.xht: Added.
css/css-multicol-1/multicol-width-ems-001-expected.xht: Added.
css/css-multicol-1/multicol-width-ems-001.xht: Added.
css/css-multicol-1/multicol-width-invalid-001-expected.xht: Added.
css/css-multicol-1/multicol-width-invalid-001.xht: Added.
css/css-multicol-1/multicol-width-large-001-expected.xht: Added.
css/css-multicol-1/multicol-width-large-001.xht: Added.
css/css-multicol-1/multicol-width-large-002-expected.xht: Added.
css/css-multicol-1/multicol-width-large-002.xht: Added.
css/css-multicol-1/multicol-width-negative-001-expected.xht: Added.
css/css-multicol-1/multicol-width-negative-001.xht: Added.
css/css-multicol-1/multicol-width-small-001-expected.xht: Added.
css/css-multicol-1/multicol-width-small-001.xht: Added.
css/css-multicol-1/multicol-zero-height-001-expected.xht: Added.
css/css-multicol-1/multicol-zero-height-001.xht: Added.
css/css-multicol-1/support: Added.
css/css-multicol-1/support/1x1-green.png: Added.
css/css-multicol-1/support/1x1-lime.png: Added.
css/css-multicol-1/support/1x1-maroon.png: Added.
css/css-multicol-1/support/1x1-navy.png: Added.
css/css-multicol-1/support/1x1-red.png: Added.
css/css-multicol-1/support/1x1-white.png: Added.
css/css-multicol-1/support/60x60-gg-rr.png: Added.
css/css-multicol-1/support/60x60-green.png: Added.
css/css-multicol-1/support/60x60-red.png: Added.
css/css-multicol-1/support/a-green.css: Added.
css/css-multicol-1/support/b-green.css: Added.
css/css-multicol-1/support/black20x20.png: Added.
css/css-multicol-1/support/c-red.css: Added.
css/css-multicol-1/support/cat.png: Added.
css/css-multicol-1/support/import-green.css: Added.
css/css-multicol-1/support/import-red.css: Added.
css/css-multicol-1/support/pattern-gg-gr.png: Added.
css/css-multicol-1/support/pattern-grg-rgr-grg.png: Added.
css/css-multicol-1/support/pattern-grg-rrg-rgg.png: Added.
css/css-multicol-1/support/pattern-rgr-grg-rgr.png: Added.
css/css-multicol-1/support/pattern-tr.png: Added.
css/css-multicol-1/support/red20x20.png: Added.
css/css-multicol-1/support/square-purple.png: Added.
css/css-multicol-1/support/square-teal.png: Added.
css/css-multicol-1/support/square-white.png: Added.
css/css-multicol-1/support/swatch-blue.png: Added.
css/css-multicol-1/support/swatch-gray.png: Added.
css/css-multicol-1/support/swatch-green.png: Added.
css/css-multicol-1/support/swatch-lime.png: Added.
css/css-multicol-1/support/swatch-navy.png: Added.
css/css-multicol-1/support/swatch-orange.png: Added.
css/css-multicol-1/support/swatch-pink.png: Added.
css/css-multicol-1/support/swatch-purple.png: Added.
css/css-multicol-1/support/swatch-red.png: Added.
css/css-multicol-1/support/swatch-white.png: Added.
css/css-multicol-1/support/swatch-yellow.png: Added.
css/css-multicol-1/support/test-bl.png: Added.
css/css-multicol-1/support/test-br.png: Added.
css/css-multicol-1/support/test-outer.png: Added.
css/css-multicol-1/support/test-tl.png: Added.
css/css-multicol-1/support/test-tr.png: Added.
css/multicol: Removed.
css/multicol/multicol-basic-001-expected.html: Removed.
css/multicol/multicol-basic-001.html: Removed.
css/multicol/multicol-basic-002-expected.html: Removed.
css/multicol/multicol-basic-002.html: Removed.
css/multicol/multicol-basic-003-expected.html: Removed.
css/multicol/multicol-basic-003.html: Removed.
css/multicol/multicol-basic-004-expected.html: Removed.
css/multicol/multicol-basic-004.html: Removed.

LayoutTests:

Added test expectations for newly imported tests.

TestExpectations:

11:29 AM Changeset in webkit [189363] by Csaba Osztrogonác

2 edits in trunk/Source/WTF

webkit-unassigned@lists.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=148525

Reviewed by Darin Adler.

wtf/Compiler.h:

11:24 AM Changeset in webkit [189362] by basile_clement@apple.com

15 edits
1 move
1 delete in trunk/Source/JavaScriptCore

Get rid of FTLValueFormat
https://bugs.webkit.org/show_bug.cgi?id=148448

Reviewed by Michael Saboff.

FTL::ValueFormat is nothing more than DataFormat (and is actually
slightly less). Let's get rid of it.

CMakeLists.txt:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/DataFormat.cpp: Renamed from Source/JavaScriptCore/ftl/FTLValueFormat.h.

(WTF::printInternal):

bytecode/DataFormat.h:
ftl/FTLAvailableRecovery.h:

(JSC::FTL::AvailableRecovery::AvailableRecovery):
(JSC::FTL::AvailableRecovery::format):

ftl/FTLExitArgument.h:

(JSC::FTL::ExitArgument::ExitArgument):
(JSC::FTL::ExitArgument::operator!):
(JSC::FTL::ExitArgument::format):
(JSC::FTL::ExitArgument::withFormat):

ftl/FTLExitValue.cpp:

(JSC::FTL::ExitValue::dataFormat):

ftl/FTLExitValue.h:

(JSC::FTL::ExitValue::recovery):
(JSC::FTL::ExitValue::recoveryFormat):

ftl/FTLFormattedValue.h:

(JSC::FTL::FormattedValue::FormattedValue):
(JSC::FTL::FormattedValue::operator!):
(JSC::FTL::FormattedValue::format):
(JSC::FTL::int32Value):
(JSC::FTL::booleanValue):
(JSC::FTL::jsValueValue):
(JSC::FTL::doubleValue):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileArithAddOrSub):
(JSC::FTL::DFG::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::DFG::LowerDFGToLLVM::convertDoubleToInt32):
(JSC::FTL::DFG::LowerDFGToLLVM::exitValueForNode):
(JSC::FTL::DFG::LowerDFGToLLVM::exitArgument):
(JSC::FTL::DFG::LowerDFGToLLVM::addAvailableRecovery):

ftl/FTLOSRExit.cpp:

(JSC::FTL::OSRExit::OSRExit):

ftl/FTLOSRExit.h:
ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::reboxAccordingToFormat):
(JSC::FTL::compileRecovery):
(JSC::FTL::compileStub):

ftl/FTLValueFormat.cpp: Removed.

11:22 AM Changeset in webkit [189361] by basile_clement@apple.com

4 edits
1 add in trunk/Source/JavaScriptCore

Introduce RegisterMap<T>
https://bugs.webkit.org/show_bug.cgi?id=148335

Reviewed by Michael Saboff.

Introduce RegisterMap<T>, GPRMap<T> and FPRMap<T> dense mappings for
Reg, GPRReg and FPRReg.

JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
jit/RegisterMap.h: Added.

(JSC::RegisterMap::operator[]):
(JSC::GPRMap::operator[]):
(JSC::FPRMap::operator[]):

11:14 AM Changeset in webkit [189360] by akling@apple.com

4 edits in trunk/Source/JavaScriptCore

Remove some unused functions from MarkedBlock and MarkedSpace.
<https://webkit.org/b/148748>

Reviewed by Darin Adler.

ftl/FTLAbstractHeapRepository.h:
heap/MarkedBlock.h:

(JSC::MarkedBlock::offsetOfMarks): Deleted.
(JSC::MarkedBlock::didConsumeEmptyFreeList): Deleted.

heap/MarkedSpace.h:

11:12 AM Changeset in webkit [189359] by dino@apple.com

4 edits
2 adds in trunk

[mediacontrols] Test the ordering of elements in the controls panel
https://bugs.webkit.org/show_bug.cgi?id=148804
<rdar://problem/22579232>

Reviewed by Eric Carlson.

Source/WebCore:

Add information about various controls elements to the status object.

Test: media/controls/elementOrder.html

Modules/mediacontrols/mediaControlsApple.js:

LayoutTests:

Add a new test that checks the visual order of the buttons and
elements in the controls panel. This is helpful because they
are not necessarily in that order within the DOM.

I also added caching of the current state to the testing helper,
to save generating the JSON status multiple times in subsequent
calls.

media/controls/elementOrder.html: New test.
media/controls/elementOrder-expected.txt: New results.
media/controls/controls-test-helpers.js:

(ControlsTest):
(ControlsTest.prototype.get currentState): Added caching.
(ControlsTest.prototype.stateForControlsElement):
(ControlsTest.prototype.isGreaterThan): New test helper.

11:12 AM Changeset in webkit [189358] by dino@apple.com

8 edits in trunk

[mediacontrols] Expose bounding rectangles and computed style to testing
https://bugs.webkit.org/show_bug.cgi?id=148755
<rdar://problems/22567757>

Reviewed by Eric Carlson.

Source/WebCore:

Expose more information on the internal objects to the testing
framework, in particular the bounding client rectangle for an
element as well as its computed style.

These new features are tested by media/controls/statusDisplay*.

Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.getCurrentControlsStatus): Rearrage things so
that it iterates over a list of objects, adding the common things
as well as any extra property values.

LayoutTests:

Update tests to exercise the computed style and bounding rectangles.

media/controls/controls-test-helpers.js:

(ControlsTest.prototype.isNotZero):
(ControlsTest):

media/controls/statusDisplay-expected.txt:
media/controls/statusDisplay.html:
media/controls/statusDisplayBad-expected.txt:
media/controls/statusDisplayBad.html:

11:00 AM Changeset in webkit [189357] by basile_clement@apple.com

8 edits in trunk/Source/JavaScriptCore

Make a bunch of MacroAssembler operations constexpr
https://bugs.webkit.org/show_bug.cgi?id=148334

Reviewed by Saam Barati.

This is in preparation of https://bugs.webkit.org/show_bug.cgi?id=148335 .

assembler/ARM64Assembler.h:

(JSC::ARM64Registers::isSp):
(JSC::ARM64Registers::isZr):
(JSC::ARM64Assembler::firstRegister):
(JSC::ARM64Assembler::lastRegister):
(JSC::ARM64Assembler::firstFPRegister):
(JSC::ARM64Assembler::lastFPRegister):
(JSC::ARM64Assembler::isSp):
(JSC::ARM64Assembler::isZr):

assembler/ARMAssembler.h:

(JSC::ARMAssembler::firstRegister):
(JSC::ARMAssembler::lastRegister):
(JSC::ARMAssembler::firstFPRegister):
(JSC::ARMAssembler::lastFPRegister):

assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::firstRegister):
(JSC::AbstractMacroAssembler::lastRegister):
(JSC::AbstractMacroAssembler::firstFPRegister):
(JSC::AbstractMacroAssembler::lastFPRegister):

assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::firstRegister):
(JSC::MIPSAssembler::lastRegister):
(JSC::MIPSAssembler::firstFPRegister):
(JSC::MIPSAssembler::lastFPRegister):

assembler/MacroAssembler.h:

(JSC::MacroAssembler::nextRegister):
(JSC::MacroAssembler::nextFPRegister):
(JSC::MacroAssembler::numberOfRegisters):
(JSC::MacroAssembler::registerIndex):
(JSC::MacroAssembler::numberOfFPRegisters):
(JSC::MacroAssembler::fpRegisterIndex):
(JSC::MacroAssembler::totalNumberOfRegisters):

assembler/SH4Assembler.h:

(JSC::SH4Assembler::firstRegister):
(JSC::SH4Assembler::lastRegister):
(JSC::SH4Assembler::firstFPRegister):
(JSC::SH4Assembler::lastFPRegister):

assembler/X86Assembler.h:

(JSC::X86Assembler::firstRegister):
(JSC::X86Assembler::lastRegister):
(JSC::X86Assembler::firstFPRegister):
(JSC::X86Assembler::lastFPRegister):

10:43 AM Changeset in webkit [189356] by ap@apple.com

1 edit
2 adds in trunk/LayoutTests

Add tests for different Unicode normalization forms in domain names
https://bugs.webkit.org/show_bug.cgi?id=148762
<rdar://problem/22569933>

Reviewed by Darin Adler.

fast/url/user-visible/cyrillic-NFD-expected.txt: Added.
fast/url/user-visible/cyrillic-NFD.html: Added.

10:43 AM Changeset in webkit [189355] by commit-queue@webkit.org

3 edits
2 adds in trunk/Tools

prepare-ChangeLog needs to know how to parse Swift files.
https://bugs.webkit.org/show_bug.cgi?id=148784
<rdar://problem/22510062>

Patch by Jason Marcell <jmarcell@apple.com> on 2015-09-04
Reviewed by Darin Adler.

Scripts/prepare-ChangeLog:

(get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
(get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
(parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.

Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.

(freeFunction): Ditto.
(MyClass.function): Ditto.
(MyClass.functionWithArgument(_:)): Ditto.
(MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
(MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
(MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
(MyClass.classFunction): Ditto.
(MyClass.readWriteComputedVariable): Ditto.
(MyClass.readOnlyComputedVariable): Ditto.

10:40 AM Changeset in webkit [189354] by Chris Dumez

4 edits in trunk

Document.body should return the first body / frameset child of the html element
https://bugs.webkit.org/show_bug.cgi?id=148787
<rdar://problem/22566850>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Document.body should return the *first* body / frameset child of the html
element as per the specification:
https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2

Chrome and Firefox both behave correctly. However, WebKit was prioritizing
frameset over body. This patch fixes this.

No new tests, already covered by existing test.

dom/Document.cpp:

(WebCore::Document::bodyOrFrameset):

LayoutTests:

Rebaseline test now that a new check is passing.

http/tests/w3c/html/dom/documents/dom-tree-accessors/document.body-getter-expected.txt:

10:21 AM Changeset in webkit [189353] by rniwa@webkit.org

5 edits
94 adds in trunk

Import css/css-color-3
https://bugs.webkit.org/show_bug.cgi?id=148803

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Imported tests from https://github.com/w3c/csswg-test/tree/master/css-color-3 as of
46a095b681f997bef518ebe0a704c0a343a14a05.

css/css-color-3: Added.
css/css-color-3/LICENSE: Added.
css/css-color-3/htaccess: Added.
css/css-color-3/t31-color-currentColor-b-expected.html: Added.
css/css-color-3/t31-color-currentColor-b.xht: Added.
css/css-color-3/t32-opacity-offscreen-multiple-boxes-1-c-expected.html: Added.
css/css-color-3/t32-opacity-offscreen-multiple-boxes-1-c.xht: Added.
css/css-color-3/t32-opacity-offscreen-multiple-boxes-2-c-expected.html: Added.
css/css-color-3/t32-opacity-offscreen-multiple-boxes-2-c.xht: Added.
css/css-color-3/t421-rgb-func-int-a-expected.html: Added.
css/css-color-3/t421-rgb-func-int-a.xht: Added.
css/css-color-3/t421-rgb-func-no-mixed-f-expected.html: Added.
css/css-color-3/t421-rgb-func-no-mixed-f.xht: Added.
css/css-color-3/t421-rgb-func-pct-a-expected.html: Added.
css/css-color-3/t421-rgb-func-pct-a.xht: Added.
css/css-color-3/t421-rgb-func-whitespace-b-expected.html: Added.
css/css-color-3/t421-rgb-func-whitespace-b.xht: Added.
css/css-color-3/t421-rgb-hex-parsing-f-expected.html: Added.
css/css-color-3/t421-rgb-hex-parsing-f.xht: Added.
css/css-color-3/t421-rgb-hex3-a-expected.html: Added.
css/css-color-3/t421-rgb-hex3-a.xht: Added.
css/css-color-3/t421-rgb-hex6-a-expected.html: Added.
css/css-color-3/t421-rgb-hex6-a.xht: Added.
css/css-color-3/t422-rgba-a1.0-a-expected.html: Added.
css/css-color-3/t422-rgba-a1.0-a.xht: Added.
css/css-color-3/t422-rgba-clamping-a0.0-b-expected.html: Added.
css/css-color-3/t422-rgba-clamping-a0.0-b.xht: Added.
css/css-color-3/t422-rgba-clamping-a1.0-b-expected.html: Added.
css/css-color-3/t422-rgba-clamping-a1.0-b.xht: Added.
css/css-color-3/t422-rgba-clip-outside-device-gamut-b-expected.html: Added.
css/css-color-3/t422-rgba-clip-outside-device-gamut-b.xht: Added.
css/css-color-3/t422-rgba-func-int-a-expected.html: Added.
css/css-color-3/t422-rgba-func-int-a.xht: Added.
css/css-color-3/t422-rgba-func-no-mixed-f-expected.html: Added.
css/css-color-3/t422-rgba-func-no-mixed-f.xht: Added.
css/css-color-3/t422-rgba-func-pct-a-expected.html: Added.
css/css-color-3/t422-rgba-func-pct-a.xht: Added.
css/css-color-3/t422-rgba-func-whitespace-b-expected.html: Added.
css/css-color-3/t422-rgba-func-whitespace-b.xht: Added.
css/css-color-3/t422-rgba-onscreen-b-expected.html: Added.
css/css-color-3/t422-rgba-onscreen-b.xht: Added.
css/css-color-3/t422-rgba-onscreen-multiple-boxes-c-expected.html: Added.
css/css-color-3/t422-rgba-onscreen-multiple-boxes-c.xht: Added.
css/css-color-3/t423-transparent-1-a-expected.html: Added.
css/css-color-3/t423-transparent-1-a.xht: Added.
css/css-color-3/t423-transparent-2-a-expected.html: Added.
css/css-color-3/t423-transparent-2-a.xht: Added.
css/css-color-3/t424-hsl-basic-a-expected.html: Added.
css/css-color-3/t424-hsl-basic-a.xht: Added.
css/css-color-3/t424-hsl-clip-outside-gamut-b-expected.html: Added.
css/css-color-3/t424-hsl-clip-outside-gamut-b.xht: Added.
css/css-color-3/t424-hsl-parsing-f-expected.html: Added.
css/css-color-3/t424-hsl-parsing-f.xht: Added.
css/css-color-3/t424-hsl-values-b-1-expected.html: Added.
css/css-color-3/t424-hsl-values-b-1.html: Added.
css/css-color-3/t424-hsl-values-b-10-expected.html: Added.
css/css-color-3/t424-hsl-values-b-10.html: Added.
css/css-color-3/t424-hsl-values-b-11-expected.html: Added.
css/css-color-3/t424-hsl-values-b-11.html: Added.
css/css-color-3/t424-hsl-values-b-12-expected.html: Added.
css/css-color-3/t424-hsl-values-b-12.html: Added.
css/css-color-3/t424-hsl-values-b-13-expected.html: Added.
css/css-color-3/t424-hsl-values-b-13.html: Added.
css/css-color-3/t424-hsl-values-b-14-expected.html: Added.
css/css-color-3/t424-hsl-values-b-14.html: Added.
css/css-color-3/t424-hsl-values-b-15-expected.html: Added.
css/css-color-3/t424-hsl-values-b-15.html: Added.
css/css-color-3/t424-hsl-values-b-2-expected.html: Added.
css/css-color-3/t424-hsl-values-b-2.html: Added.
css/css-color-3/t424-hsl-values-b-3-expected.html: Added.
css/css-color-3/t424-hsl-values-b-3.html: Added.
css/css-color-3/t424-hsl-values-b-4-expected.html: Added.
css/css-color-3/t424-hsl-values-b-4.html: Added.
css/css-color-3/t424-hsl-values-b-5-expected.html: Added.
css/css-color-3/t424-hsl-values-b-5.html: Added.
css/css-color-3/t424-hsl-values-b-6-expected.html: Added.
css/css-color-3/t424-hsl-values-b-6.html: Added.
css/css-color-3/t424-hsl-values-b-7-expected.html: Added.
css/css-color-3/t424-hsl-values-b-7.html: Added.
css/css-color-3/t424-hsl-values-b-8-expected.html: Added.
css/css-color-3/t424-hsl-values-b-8.html: Added.
css/css-color-3/t424-hsl-values-b-9-expected.html: Added.
css/css-color-3/t424-hsl-values-b-9.html: Added.
css/css-color-3/t425-hsla-clip-outside-device-gamut-b-expected.html: Added.
css/css-color-3/t425-hsla-clip-outside-device-gamut-b.xht: Added.
css/css-color-3/t425-hsla-onscreen-multiple-boxes-c-expected.html: Added.
css/css-color-3/t425-hsla-onscreen-multiple-boxes-c.xht: Added.
css/css-color-3/t425-hsla-parsing-f-expected.html: Added.
css/css-color-3/t425-hsla-parsing-f.xht: Added.
css/css-color-3/t425-hsla-values-b-expected.html: Added.
css/css-color-3/t425-hsla-values-b.xht: Added.
css/css-color-3/t44-currentcolor-background-b-expected.html: Added.
css/css-color-3/t44-currentcolor-background-b.xht: Added.
css/css-color-3/t44-currentcolor-border-b-expected.html: Added.
css/css-color-3/t44-currentcolor-border-b.xht: Added.
css/css-color-3/w3c-import.log: Added.

Tools:

Fixed a bug that the imported reference files used the same extention as tests.
This would result in parsing errors if the tests were XML and references were HTML and vice versa.

Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.find_importable_tests):

LayoutTests:

TestExpectations:

9:53 AM Changeset in webkit [189352] by Chris Dumez

1 edit
8 adds in trunk/LayoutTests

Unreviewed, add iOS-specific baselines for a couple of newly imported W3C tests.

platform/ios-simulator/http/tests/w3c/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt: Added.
platform/ios-simulator/http/tests/w3c/html/dom/interfaces-expected.txt: Added.

9:39 AM Changeset in webkit [189351] by basile_clement@apple.com

3 edits in trunk/Source/JavaScriptCore

Add a bunch of operators
https://bugs.webkit.org/show_bug.cgi?id=148337

Reviewed by Saam Barati.

jit/GPRInfo.h:

(JSC::JSValueRegs::operator bool):
(JSC::JSValueRegs::operator==):
(JSC::JSValueRegs::operator!=):
(JSC::JSValueSource::operator bool):
(JSC::JSValueRegs::operator!):
(JSC::JSValueSource::operator!):

jit/Reg.h:

(JSC::Reg::operator bool):

9:32 AM Changeset in webkit [189350] by basile_clement@apple.com

2 edits in trunk/Source/JavaScriptCore

Since r189341, es6.yaml/es6/arrow_functions_no_prototype_property.js is expected to succeed

Rubber stamped by Michael Saboff.

tests/es6.yaml:

9:31 AM Changeset in webkit [189349] by Csaba Osztrogonác

2 edits in trunk/Source/WebCore

Fix the !ENABLE(VIDEO) build after r189023
https://bugs.webkit.org/show_bug.cgi?id=148796

Reviewed by Eric Carlson.

testing/Internals.idl:

9:28 AM Changeset in webkit [189348] by ap@apple.com

2 edits in trunk/LayoutTests

iOS test gardening.

platform/ios-simulator/TestExpectations: Skip pasteboard tests, as many of them

time out.

9:25 AM Changeset in webkit [189347] by rniwa@webkit.org

4 edits in trunk

Range.isPointInRange check root node before verifying offset
https://bugs.webkit.org/show_bug.cgi?id=148776

isPointInRange should never throw WrongDocumentError
https://bugs.webkit.org/show_bug.cgi?id=148779

Reviewed by Darin Adler.

Source/WebCore:

Fixed two bugs since they were inter-dependent on each other.

We use the same trick we used for comparePoint in r189327 to avoid O(n) operation in common cases
and return false when either calls to compareBoundaryPoints yields a WrongDocumentError.

No new tests since this is covered by an existing W3C test.

dom/Range.cpp:

(WebCore::Range::isPointInRange):
(WebCore::Range::comparePoint):

LayoutTests:

Rebaselined the test now that all test cases pass.

http/tests/w3c/dom/ranges/Range-isPointInRange-expected.txt:

9:21 AM Changeset in webkit [189346] by ap@apple.com

2 edits in trunk/LayoutTests

css3/flexbox/csswg/css-flexbox-height-animation-stretch.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=143294

Reviewed by Dean Jackson.

TestExpectations: This test is just inherently flaky.

6:54 AM WebKitGTK/2.8.x edited by Michael Catanzaro

Propose bug #143245 (diff)

6:53 AM WebKitGTK/2.10.x edited by Michael Catanzaro

Propose bug #143245 (diff)

4:48 AM Changeset in webkit [189345] by clopez@igalia.com

2 edits in trunk

Follow-up patch for r189343.
https://bugs.webkit.org/show_bug.cgi?id=148795

Rubber-stamped by Csaba Osztrogonác.

Source/cmake/WebKitCommon.cmake: Relax the Ruby version requirement

to 1.9, since this seems to be enough to fix the build failure.
And 2.0 may cause problems for developers using some distributions like Ubuntu.

4:44 AM Changeset in webkit [189344] by commit-queue@webkit.org

2 edits in trunk

[CMake] Trigger the memory-reduction tricks on armhf too
https://bugs.webkit.org/show_bug.cgi?id=146640

Patch by Emanuele Aina <Emanuele Aina> on 2015-09-04
Reviewed by Csaba Osztrogonác.

Source/cmake/OptionsCommon.cmake:

Activate --no-keep-memory even on armhf to reduce the amount of memory
needed during linking, to avoid out-of-memory failures as much as
possible.

4:26 AM Changeset in webkit [189343] by clopez@igalia.com

2 edits in trunk

REGRESSION(r189293): JavaScriptCore/offlineasm/x86.rb -- Build failure with ruby < 2.0
https://bugs.webkit.org/show_bug.cgi?id=148795

Rubber-stamped by Carlos Garcia Campos.

Source/cmake/WebKitCommon.cmake: Require now at least Ruby 2.0

4:16 AM Changeset in webkit [189342] by Csaba Osztrogonác

2 edits in trunk/Source/JavaScriptCore

[ARM] Fix the ARM Traditional build after r189288
https://bugs.webkit.org/show_bug.cgi?id=148792

Reviewed by Zoltan Herczeg.

assembler/MacroAssemblerARM.h: Make repatchCall public similar to changes in r189288.

(JSC::MacroAssemblerARM::repatchCall):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed