⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 8, 2015:

10:12 PM Changeset in webkit [189534] by mmaxfield@apple.com
  • 2 edits in trunk/Tools

[Cocoa] Fix the tests after r189530

Unreviewed.

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::initializeWebViewConfiguration):

9:59 PM Changeset in webkit [189533] by commit-queue@webkit.org
  • 22 edits in trunk/LayoutTests

Unreviewed, rolling out r189407 and r189424.
https://bugs.webkit.org/show_bug.cgi?id=148993

Broke some tests, and made others flakily time out (Requested
by ap on #webkit).

Reverted changesets:

"[WebGL] Update WebGL 1.0.3 conformance tests"
https://bugs.webkit.org/show_bug.cgi?id=148858
http://trac.webkit.org/changeset/189407

"REGRESSION (r189407): webgl/1.0.3/conformance/extensions
/webgl-draw-buffers.html"
http://trac.webkit.org/changeset/189424

9:19 PM Changeset in webkit [189532] by commit-queue@webkit.org
  • 1 edit
    2 adds
    2 deletes in trunk/Source/JavaScriptCore

Refactor the test for the arithmetic instructions in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=148983

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-08
Reviewed by Mark Lam.

Pass the values into the test functions as Mark Lam suggested in
https://bugs.webkit.org/show_bug.cgi?id=148882#c3

  • tests/stress/wasm-arithmetic-int32.js: Added.

(shouldBe):
(shouldThrow):

  • tests/stress/wasm-arithmetic.js: Removed.

(shouldBe): Deleted.
(shouldThrow): Deleted.

  • tests/stress/wasm/arithmetic-int32.wasm: Added.
  • tests/stress/wasm/arithmetic.wasm: Removed.
9:02 PM Changeset in webkit [189531] by benjamin@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[JSC] reduce the amount of memory access needed for LivenessAnalysisPhase
https://bugs.webkit.org/show_bug.cgi?id=148414

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-09-08
Reviewed by Mark Lam.

LivenessAnalysisPhase still causes a huge number of cache miss.
This patch reduces the amount of accesses needed by the HashTables.

  • dfg/DFGBasicBlock.h:
  • dfg/DFGLivenessAnalysisPhase.cpp:

(JSC::DFG::LivenessAnalysisPhase::run):
(JSC::DFG::LivenessAnalysisPhase::process):

8:27 PM Changeset in webkit [189530] by mmaxfield@apple.com
  • 14 edits
    1 move in trunk/Tools

[WKTR] Allow changing the WKContextConfiguration between successive tests
https://bugs.webkit.org/show_bug.cgi?id=148833

Reviewed by Tim Horton.

Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
However, there are certain tests which require specifying options in this object. This patch makes
our existing code for recreating the test runner web view also recreate the WKContext.

As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
class.

  • WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
  • WebKitTestRunner/PlatformWebView.h:

(WTR::PlatformWebView::options):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):
(WTR::TestController::generateContextConfiguration):
(WTR::TestController::generatePageConfiguration):
(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::ensureViewSupportsOptionsForTest):
(WTR::updateContextConfigurationOptionsFromTestHeader):
(WTR::TestController::contextConfigurationOptionsForTest):
(WTR::TestController::platformCreateWebView):
(WTR::TestController::platformCreateOtherPage):
(WTR::updateViewOptionsFromTestHeader): Deleted.
(WTR::TestController::viewOptionsForTest): Deleted.

  • WebKitTestRunner/TestController.h:

(WTR::TestController::injectedBundlePath):
(WTR::TestController::testPluginDirectory):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::platformCreateWebView):
(WTR::TestController::platformCreateOtherPage):

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):

  • WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
(WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):

  • WebKitTestRunner/gtk/TestControllerGtk.cpp:

(WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
(WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.

  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):

  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
(WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
(WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.

8:01 PM Changeset in webkit [189529] by mmaxfield@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Prospective build fix after r189517

Unreviewed.

  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::Thread::captureStack):

7:40 PM Changeset in webkit [189528] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: No need for [Custom] Implementation of some InspectorFrontendHost methods
https://bugs.webkit.org/show_bug.cgi?id=148990

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-08
Reviewed by Timothy Hatcher.

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::platform): Deleted.
(WebCore::JSInspectorFrontendHost::port): Deleted.

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::platform):
(WebCore::InspectorFrontendHost::port):

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:

Uncustomize a few basic functions.

6:44 PM Changeset in webkit [189527] by aestes@apple.com
  • 10 edits
    4 deletes in branches/safari-601-branch

Reverted r189001.

6:38 PM Changeset in webkit [189526] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore

Crash when WebCore::SQLiteFileSystem::openDatabase is called from multiple threads
https://bugs.webkit.org/show_bug.cgi?id=143245

Reviewed by Darin Adler.

sqlite3_initialize is documented to be thread-safe, and to be called automatically by the
library when needed, so applications should never need to call it directly. The problem is,
it's not thread-safe: we have documented instances of GNOME Builder, Devhelp, Epiphany, and
cinnamon-screensaver crashing when sqlite3_initialize is called simultaneously in separate
threads (usually inside sqlite3_open). So call it manually, guarded using std::call_once, to
make sure that the library is fully initialized before the first call to sqlite3_open. It's
a good idea to do this regardless, because the documentation says it could be required in
a future release of SQLite. (Though the use of std::call_once should not be needed, and is
only used to attempt to work around the crashes.)

This is a workaround for an SQLite bug that might have been fixed upstream, but the SQLite
developers are not really confident in the thread-safety of this function, and have advised
that we carry the workaround. Seems like a good idea.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::SQLiteDatabase):

6:32 PM Changeset in webkit [189525] by Yusuke Suzuki
  • 11 edits in trunk/Source

Source/JavaScriptCore:
Unify symbolTableGet and Put in JSLexicalEnvironment and JSSymbolTableObject
https://bugs.webkit.org/show_bug.cgi?id=148783

Reviewed by Geoffrey Garen.

Unify the symbolTableGet and symbolTablePut into JSSymbolTableObject's one.
Since symbolTablePutWithAttributes in JSLexicalEnvironment is not used, we drop that function.

  • runtime/JSEnvironmentRecord.h:

(JSC::JSEnvironmentRecord::isValidScopeOffset):
(JSC::JSEnvironmentRecord::variableAt):
(JSC::JSEnvironmentRecord::isValid): Deleted.

  • runtime/JSGlobalLexicalEnvironment.cpp:

(JSC::JSGlobalLexicalEnvironment::put):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::put):

  • runtime/JSLexicalEnvironment.cpp:

(JSC::JSLexicalEnvironment::getOwnNonIndexPropertyNames):
(JSC::JSLexicalEnvironment::getOwnPropertySlot):
(JSC::JSLexicalEnvironment::put):
(JSC::JSLexicalEnvironment::symbolTableGet): Deleted.
(JSC::JSLexicalEnvironment::symbolTablePut): Deleted.
(JSC::JSLexicalEnvironment::symbolTablePutWithAttributes): Deleted.

  • runtime/JSLexicalEnvironment.h:
  • runtime/JSModuleRecord.cpp:

(JSC::JSModuleRecord::instantiateDeclarations):

  • runtime/JSSegmentedVariableObject.h:

(JSC::JSSegmentedVariableObject::isValidScopeOffset):

  • runtime/JSSymbolTableObject.h:

(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutTouchWatchpointSet):
(JSC::symbolTablePutInvalidateWatchpointSet):
(JSC::symbolTablePutWithAttributesTouchWatchpointSet):
(JSC::symbolTablePutWithAttributes): Deleted.

Source/WebCore:
Unify symbolTablePut in JSLexicalEnvironment and JSSymbolTableObject
https://bugs.webkit.org/show_bug.cgi?id=148783

Reviewed by Geoffrey Garen.

No behavior change.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::updateDocument):

6:28 PM Changeset in webkit [189524] by commit-queue@webkit.org
  • 10 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r189516.
https://bugs.webkit.org/show_bug.cgi?id=148989

broke tests on windows (Requested by alexchristensen on
#webkit).

Reverted changeset:

"GC should be able to discover new strong CodeBlock references
during marking"
https://bugs.webkit.org/show_bug.cgi?id=148981
http://trac.webkit.org/changeset/189516

6:03 PM Changeset in webkit [189523] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Remove unused DFG::dfgConvertJSValueToInt32()
https://bugs.webkit.org/show_bug.cgi?id=148986

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-08
Reviewed by Geoffrey Garen.

Remove unused DFG::dfgConvertJSValueToInt32() and also remove
DFG::JITCompiler::callOperation(D_JITOperation_EJ operation, ...) which
was introduced in Bug 69806 for dfgConvertJSValueToNumber() and is no
longer used.

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation): Deleted.

6:01 PM Changeset in webkit [189522] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Function.prototype.bind: Bound functions must use the Prototype of their target function instead of Function.prototype
https://bugs.webkit.org/show_bug.cgi?id=145605

Patch by Matthew Hill <matthew.jh@outlook.com> on 2015-09-08
Reviewed by Geoffrey Garen.

  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::create):

  • tests/es6.yaml:
5:46 PM Changeset in webkit [189521] by Said Abou-Hallawa
  • 1 edit
    6 adds in trunk/LayoutTests

[iOS] Unreviewed iOS gardening.

  • platform/ios-simulator/css3/filters/backdrop: Added.
  • platform/ios-simulator/css3/filters/backdrop/blur-input-bounds-expected.txt: Added.
  • platform/ios-simulator/css3/font-feature-settings-preinstalled-fonts-expected.txt: Added.
  • platform/ios-simulator/fast/css/named-images-expected.txt: Added.
  • platform/ios-simulator/fast/forms/select-element-focus-ring-expected.txt: Added.
  • platform/ios-simulator/fast/text/font-weights-expected.txt: Added.
5:26 PM Changeset in webkit [189520] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fixed a bad comment r189517.

Not reviewed.

  • heap/MachineStackMarker.cpp:

(JSC::osRedZoneAdjustment):

5:20 PM Changeset in webkit [189519] by Chris Dumez
  • 1 edit
    2 deletes in trunk/LayoutTests/imported/w3c

Unreviewed, drop imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/location-of-the-media-resource/currentSrc.html.

This recently imported test is flaky.

  • web-platform-tests/html/semantics/embedded-content/media-elements/location-of-the-media-resource/currentSrc-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/location-of-the-media-resource/currentSrc.html: Removed.
5:20 PM Changeset in webkit [189518] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

InlineCallFrames shouldn't be strongly marked by CodeBlock
https://bugs.webkit.org/show_bug.cgi?id=146613

Reviewed by Saam Barati.

This code was vestigial an unnecessary, so I removed it.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::stronglyVisitStrongReferences):

  • bytecode/InlineCallFrame.cpp:

(JSC::InlineCallFrame::calleeConstant):
(JSC::InlineCallFrame::calleeForCallFrame):
(JSC::InlineCallFrame::visitAggregate): Deleted.

  • bytecode/InlineCallFrame.h:

(JSC::InlineCallFrame::specializationKind):

  • bytecode/InlineCallFrameSet.cpp:

(JSC::InlineCallFrameSet::add):
(JSC::InlineCallFrameSet::visitAggregate): Deleted.

  • bytecode/InlineCallFrameSet.h:

(JSC::InlineCallFrameSet::begin):
(JSC::InlineCallFrameSet::end):

5:19 PM Changeset in webkit [189517] by mark.lam@apple.com
  • 4 edits in trunk/Source

GC stack scan should include ABI red zone.
https://bugs.webkit.org/show_bug.cgi?id=148976

Reviewed by Geoffrey Garen and Benjamin Poulain.

Source/JavaScriptCore:

The x86_64 ABI section 3.2.2[1] and ARM64 ABI[2] both state that there is a
128 byte red zone below the stack pointer (reserved by the OS), and that
"functions may use this area for temporary data that is not needed across
function calls".

Hence, it is possible for a thread to store JSCell pointers in the red zone
area, and the conservative GC thread scanner needs to scan that area as well.

Note: the red zone should not be scanned for the GC thread itself (in
gatherFromCurrentThread()). This because we're guaranteed that there will
be GC frames below the lowest (top of stack) frame that we need to scan.
Hence, we are guaranteed that there are no red zone areas there containing
JSObject pointers of relevance.

No test added for this issue because the issue relies on:

  1. the compiler tool chain generating code that stores local variables containing the sole reference to a JS object (that needs to be kept alive) in the stack red zone, and
  2. GC has to run on another thread while that red zone containing the JS object reference is in use.

These conditions require a race that cannot be reliably reproduced.

[1]: http://people.freebsd.org/~obrien/amd64-elf-abi.pdf
[2]: https://developer.apple.com/library/ios/documentation/Xcode/Conceptual/iPhoneOSABIReference/Articles/ARM64FunctionCallingConventions.html#//apple_ref/doc/uid/TP40013702-SW7

  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::Thread::Thread):
(JSC::MachineThreads::Thread::createForCurrentThread):
(JSC::MachineThreads::Thread::freeRegisters):
(JSC::osRedZoneAdjustment):
(JSC::MachineThreads::Thread::captureStack):

Source/WTF:

  • wtf/StackBounds.h:

(WTF::StackBounds::origin):
(WTF::StackBounds::end):
(WTF::StackBounds::size):

5:07 PM Changeset in webkit [189516] by ggaren@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

GC should be able to discover new strong CodeBlock references during marking
https://bugs.webkit.org/show_bug.cgi?id=148981

Reviewed by Mark Lam.

Previously, we required a strong reference to register itself before the
first visit to a CodeBlock. Now, we can discover a strong reference at
any time during the marking phase.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock): Remove the two strong reference state
variables from CodeBlock. Now, a strong reference immediately marks
the CodeBlock and its references at the moment of its discovery, and no
separate state is required.

(JSC::CodeBlock::visitStrongly): New helper function for establishing
a strong reference to a CodeBlock.

(JSC::CodeBlock::visitAggregate): Adopt helper function above.

(JSC::CodeBlock::shouldImmediatelyAssumeLivenessDuringScan): Updated
for state removal.

(JSC::CodeBlock::isKnownToBeLiveDuringGC): Ditto.

(JSC::CodeBlock::stronglyVisitWeakReferences): Be sure to record that
we have proven liveness (by virtue of marking all the references the
proof would check). This is required so that the CodeBlock knows itself
to be live, and it is also an optimization to avoid testing weak references
after we have already visited them.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::clearMarks):
(JSC::CodeBlockSet::mark):
(JSC::CodeBlockSet::clearMarks): Deleted. Updated for state removal.

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::clearCodeBlockMarks):
(JSC::DFG::Plan::checkLivenessAndVisitChildren):

  • dfg/DFGPlan.h: No need to use a CodeBlockSet in order to mark anymore.
  • dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::completeAllPlansForVM):
(JSC::DFG::Worklist::clearCodeBlockMarks):
(JSC::DFG::Worklist::resumeAllThreads):
(JSC::DFG::Worklist::visitWeakReferences):
(JSC::DFG::completeAllPlansForVM):
(JSC::DFG::clearCodeBlockMarks):

  • dfg/DFGWorklist.h:

(JSC::DFG::worklistForIndexOrNull): No need to use a CodeBlockSet in order
to mark anymore.

  • heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::clearMarksForFullCollection):
(JSC::CodeBlockSet::clearMarksForEdenCollection):
(JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced):
(JSC::CodeBlockSet::traceMarked):
(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):
(JSC::CodeBlockSet::dump):

  • heap/CodeBlockSet.h: Keep the currently executing CodeBlocks in RefPtrs

since we can no longer rely on the m_currentlyExecuting bit to keep them
alive. (A currently executing CodeBlock may not be referenced by its
Executable because it may since have been replaced by another CodeBlock.
This is common in the cases of OSR entry and exit.)

  • heap/Heap.cpp:

(JSC::Heap::markRoots):
(JSC::Heap::visitCompilerWorklistWeakReferences):
(JSC::Heap::visitWeakHandles): No need to trace the list of CodeBlocks
on the stack in the weak reference fixpoint because we no longer overload
"on the stack" to include CodeBlocks referenced by the compiler.

4:10 PM Changeset in webkit [189515] by akling@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

[JSC] Remove unused Heap::getConservativeRegisterRoots().
<https://webkit.org/b/148974>

Reviewed by Geoffrey Garen.

Spotted this unused stack root gathering helper in Heap. Let's lose it.

  • heap/Heap.cpp:

(JSC::Heap::getConservativeRegisterRoots): Deleted.

  • interpreter/JSStack.cpp:

(JSC::JSStack::gatherConservativeRoots): Deleted.

  • interpreter/JSStack.h:

(JSC::JSStack::gatherConservativeRoots): Deleted.

4:04 PM Changeset in webkit [189514] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/JavaScriptCore

Implement control flow statements in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=148934

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-08
Reviewed by Geoffrey Garen.

This patch implements if, while, do, label, break, and continue
statements in WebAssembly. Switches will be implemented in a subsequent
patch.

  • tests/stress/wasm-control-flow.js: Added.

(shouldBe):

  • tests/stress/wasm/control-flow.wasm: Added.
  • wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::linkTarget):
(JSC::WASMFunctionCompiler::jumpToTarget):
(JSC::WASMFunctionCompiler::jumpToTargetIf):
(JSC::WASMFunctionCompiler::startLoop):
(JSC::WASMFunctionCompiler::endLoop):
(JSC::WASMFunctionCompiler::startSwitch):
(JSC::WASMFunctionCompiler::endSwitch):
(JSC::WASMFunctionCompiler::startLabel):
(JSC::WASMFunctionCompiler::endLabel):
(JSC::WASMFunctionCompiler::breakTarget):
(JSC::WASMFunctionCompiler::continueTarget):
(JSC::WASMFunctionCompiler::breakLabelTarget):
(JSC::WASMFunctionCompiler::continueLabelTarget):

  • wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseIfStatement):
(JSC::WASMFunctionParser::parseIfElseStatement):
(JSC::WASMFunctionParser::parseWhileStatement):
(JSC::WASMFunctionParser::parseDoStatement):
(JSC::WASMFunctionParser::parseLabelStatement):
(JSC::WASMFunctionParser::parseBreakStatement):
(JSC::WASMFunctionParser::parseBreakLabelStatement):
(JSC::WASMFunctionParser::parseContinueStatement):
(JSC::WASMFunctionParser::parseContinueLabelStatement):

  • wasm/WASMFunctionParser.h:
  • wasm/WASMFunctionSyntaxChecker.h:

(JSC::WASMFunctionSyntaxChecker::linkTarget):
(JSC::WASMFunctionSyntaxChecker::jumpToTarget):
(JSC::WASMFunctionSyntaxChecker::jumpToTargetIf):
(JSC::WASMFunctionSyntaxChecker::startLoop):
(JSC::WASMFunctionSyntaxChecker::endLoop):
(JSC::WASMFunctionSyntaxChecker::startSwitch):
(JSC::WASMFunctionSyntaxChecker::endSwitch):
(JSC::WASMFunctionSyntaxChecker::startLabel):
(JSC::WASMFunctionSyntaxChecker::endLabel):
(JSC::WASMFunctionSyntaxChecker::breakTarget):
(JSC::WASMFunctionSyntaxChecker::continueTarget):
(JSC::WASMFunctionSyntaxChecker::breakLabelTarget):
(JSC::WASMFunctionSyntaxChecker::continueLabelTarget):

4:04 PM Changeset in webkit [189513] by dbates@webkit.org
  • 8 edits in trunk

[Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=148980

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

Expose SPI web preference to enable/disable- and query the state of- accelerated drawing
so that we can toggle this setting in MiniBrowser on Mac.

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _acceleratedDrawingEnabled]): Added.
(-[WKPreferences _setAcceleratedDrawingEnabled:]): Added.

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Tools:

Add setting to enable/disable accelerated drawing so as to support testing
this feature in MiniBrowser on Mac.

  • MiniBrowser/mac/SettingsController.h:
  • MiniBrowser/mac/SettingsController.m:

(-[SettingsController _populateMenu]): Add menu item.
(-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
(-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
(-[SettingsController acceleratedDrawingEnabled]): Added.

  • MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.

3:38 PM Changeset in webkit [189512] by BJ Burg
  • 3 edits in trunk/Source/WebCore

Several inspector-protocol tests are flaky with GuardMalloc
https://bugs.webkit.org/show_bug.cgi?id=136715

Reviewed by Joseph Pecoraro.

Sometimes, the async dispatch task can outlive its owning frontend client.
To avoid problems, make it refcounted instead and add a protector reference.

No new tests, covered by existing tests.

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorBackendDispatchTask::create):
(WebCore::InspectorBackendDispatchTask::dispatch):
(WebCore::InspectorBackendDispatchTask::reset):
(WebCore::InspectorBackendDispatchTask::timerFired):
(WebCore::InspectorBackendDispatchTask::InspectorBackendDispatchTask):
(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::~InspectorFrontendClientLocal):

  • inspector/InspectorFrontendClientLocal.h:
3:33 PM Changeset in webkit [189511] by jmarcell@apple.com
  • 1 edit in trunk/Tools/ChangeLog

Fixup typo from r189510

3:28 PM Changeset in webkit [189510] by jmarcell@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Added myself as a commiter in contributors.json.

  • Scripts/webkitpy/common/config/contributors.json:
3:13 PM Changeset in webkit [189509] by commit-queue@webkit.org
  • 1 edit
    1 delete in trunk/Source/WebKit2

Web Inspector: Remove unused file: WebInspectorFrontendClient.h
https://bugs.webkit.org/show_bug.cgi?id=148979

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-08
Reviewed by Brian Burg.

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h: Removed.

Unused now. WebInspectorUI subclasses InspectorFrontendClient itself.

3:12 PM Changeset in webkit [189508] by Matt Baker
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION (r189189): Missing breakpoint context menu for debugger sidebar tree elements
https://bugs.webkit.org/show_bug.cgi?id=148651

Reviewed by Timothy Hatcher.

  • UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
Create BreakpointPopoverController singleton, expose as public property of global WebInspector object.

  • UserInterface/Views/BreakpointTreeElement.js:

(WebInspector.BreakpointTreeElement.prototype.oncontextmenu):
Use BreakpointPopoverController singleton.

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor):
Don't create BreakpointPopoverController instance.
(WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu):
Use BreakpointPopoverController singleton.

2:57 PM Changeset in webkit [189507] by Chris Dumez
  • 16 edits in trunk

new Comment(undefined) / new Text(undefined) should use default's empty string
https://bugs.webkit.org/show_bug.cgi?id=148973
<rdar://problem/22548042>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

  • web-platform-tests/dom/nodes/Comment-constructor-expected.txt:
  • web-platform-tests/dom/nodes/Text-constructor-expected.txt:
  • web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-07-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-audio-element/audio_constructor-expected.txt:

Rebaseline tests now that new checks are passing.

Source/WebCore:

new Comment(undefined) / new Text(undefined) should use default's empty string instead of converting
undefined to the "undefined" string:

undefined should be treated as if the parameter is missing, in the case the parameter is optional, as
per the Web IDL specification. This patch aligns WebKit's behavior with the specification and the
behavior of Firefox and Chrome.

No new tests, already covered by existing tests.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):

LayoutTests:

Fix a couple of layout tests that were wrongly expecting undefined to
be converted to the "undefined" String for optional DOMString parameters.

  • fast/dom/DOMImplementation/createHTMLDocument-optional-title-expected.txt:
  • fast/dom/DOMImplementation/createHTMLDocument-optional-title.html:
  • fast/dom/Window/custom-constructors-expected.txt:
  • fast/dom/Window/custom-constructors.html:
2:56 PM Changeset in webkit [189506] by peavo@outlook.com
  • 3 edits in trunk/Source/JavaScriptCore

[Win] Compile errors in inspector code.
https://bugs.webkit.org/show_bug.cgi?id=148977

Reviewed by Alex Christensen.

Include definition of class FrontendRouter before use.

  • inspector/InspectorBackendDispatcher.h:
  • inspector/JSGlobalObjectInspectorController.h:
2:51 PM WikiStart edited by mmaxfield@apple.com
(diff)
2:49 PM WikiStart edited by mmaxfield@apple.com
(diff)
2:48 PM WikiStart edited by mmaxfield@apple.com
(diff)
1:50 PM Changeset in webkit [189505] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebInspectorUI

Fix inspector/codemirror tests.

Rubber-stamped by Brian Burg.

  • UserInterface/Test.html:

Reorder includes to be more like Main.html. This ensures that CodeMirror
resources are loaded before Inspector sources use it, like CodeMirrorAdditions
which gets merged into TestCombined.js.

12:43 PM Changeset in webkit [189504] by Yusuke Suzuki
  • 24 edits
    3 adds in trunk

[ES6] Implement computed accessors
https://bugs.webkit.org/show_bug.cgi?id=147883

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Implement the computed accessors functionality for class syntax and object literal syntax.
Added new opcodes, op_put_getter_by_val and op_put_setter_by_val. LLInt and baseline JIT support them.
As the same to the other accessor opcodes (like op_put_getter_by_id etc.), DFG / FTL does not support
them. This is handled here[1].

[1]: https://bugs.webkit.org/show_bug.cgi?id=148860

  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitPutGetterByVal):
(JSC::BytecodeGenerator::emitPutSetterByVal):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_getter_by_val):
(JSC::JIT::emit_op_put_setter_by_val):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_getter_by_val):
(JSC::JIT::emit_op_put_setter_by_val):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LLIntSlowPaths.h:
  • llint/LowLevelInterpreter.asm:
  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createGetterOrSetterProperty):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseGetterSetter):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createGetterOrSetterProperty):

  • tests/es6.yaml:
  • tests/stress/computed-accessor-parsing.js: Added.

(testShouldNotThrow):
(testShouldThrow):
(Val.prototype.get string_appeared_here):
(Val):

  • tests/stress/computed-accessor.js: Added.

(shouldBe):
(.):

  • tests/stress/duplicate-computed-accessors.js: Added.

(shouldBe):

LayoutTests:

Updated the existing tests.

  • js/parser-syntax-check-expected.txt:
  • js/script-tests/parser-syntax-check.js:
12:42 PM Changeset in webkit [189503] by keith_miller@apple.com
  • 2 edits in trunk/Tools

Unreviewed, added myself to the list of contributors.

  • Scripts/webkitpy/common/config/contributors.json:
12:39 PM Changeset in webkit [189502] by Chris Dumez
  • 6 edits in trunk

document.importNode(node, deep): deep's default value should be false
https://bugs.webkit.org/show_bug.cgi?id=148959
<rdar://problem/22558915>

Reviewed by Alexey Proskuryakov.

LayoutTests/imported/w3c:

  • web-platform-tests/dom/nodes/Document-importNode-expected.txt:

Rebaseline now that an additional check is passing.

Source/WebCore:

Switch deep parameter's default value for document.importNode() to
false, as per the latest DOM specification:

Firefox and Chrome follow the specification. However, WebKit was using
"true" for deep's default value.

No new tests, already covered by:
imported/w3c/web-platform-tests/dom/nodes/Document-importNode.html

  • dom/Document.h:

(WebCore::Document::importNode):

LayoutTests:

  • fast/dom/document-importNode-arguments.html:

Explicitly pass deep parameter as the test wants a deep clone.

12:11 PM Changeset in webkit [189501] by commit-queue@webkit.org
  • 9 edits in trunk/Source/JavaScriptCore

baseline JIT should emit better code for UnresolvedProperty in resolve_scope/get_from_scope/put_to_scope
https://bugs.webkit.org/show_bug.cgi?id=148895

Patch by Saam barati <sbarati@apple.com> on 2015-09-08
Reviewed by Geoffrey Garen.

Previously, if a resolve_scope/get_from_scope/put_to_scope with
UnresolvedProperty made it to the baseline JIT, we would hard compile
a jump to the slow path. This is bad and slow. Because UnresolvedProperty
tries to update itself to something more useful, and succeeds at doing so
with high probability, we should be emitting code that checks to see if the
slow path has performed an update, and if it has, execute more efficient code
and not go to the slow path (unless it needs to for var injection check failure,
or other check failures). This increases the speed of this code greatly because
we may decide to compile a program/function before certain resolve_scope/get_from_scope/put_to_scope
operations ever execute. And now, the baseline JIT code better adapts to such
compilation scenarios.

  • bytecode/Watchpoint.h:

(JSC::WatchpointSet::isBeingWatched):
(JSC::WatchpointSet::addressOfState):
(JSC::WatchpointSet::offsetOfState):
(JSC::WatchpointSet::addressOfSetIsNotEmpty):

  • jit/JIT.cpp:

(JSC::JIT::emitNotifyWrite):
(JSC::JIT::assertStackPointerOffset):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emitSlow_op_resolve_scope):
(JSC::JIT::emitGetGlobalProperty):
(JSC::JIT::emitGetVarFromPointer):
(JSC::JIT::emitGetVarFromIndirectPointer):
(JSC::JIT::emitGetClosureVar):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitPutGlobalProperty):
(JSC::JIT::emitPutGlobalVariable):
(JSC::JIT::emitPutGlobalVariableIndirect):
(JSC::JIT::emitPutClosureVar):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitSlow_op_put_to_scope):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emitSlow_op_resolve_scope):
(JSC::JIT::emitGetGlobalProperty):
(JSC::JIT::emitGetVarFromPointer):
(JSC::JIT::emitGetVarFromIndirectPointer):
(JSC::JIT::emitGetClosureVar):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitPutGlobalProperty):
(JSC::JIT::emitPutGlobalVariable):
(JSC::JIT::emitPutGlobalVariableIndirect):
(JSC::JIT::emitPutClosureVar):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitSlow_op_put_to_scope):

  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::tryCachePutToScopeGlobal):
(JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal):

  • runtime/JSScope.cpp:

(JSC::abstractAccess):

  • tests/stress/multiple-files-tests/global-lexical-variable-unresolved-property/first.js:

(foo):

11:47 AM Changeset in webkit [189500] by Joseph Pecoraro
  • 4 edits
    76 copies
    13 adds
    3 deletes in trunk

Web Inspector: Move PrettyPrinting tests into LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=148698

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

  • Tools/PrettyPrinting/index.html:

Modify the relative path to the tests which are now in LayoutTests.

  • UserInterface/Test.html:

Load CodeMirror and related resources for Formatting.

LayoutTests:

  • inspector/codemirror/resources/prettyprinting/css-rule-tests/*: Renamed from Source/WebInspectorUI/Tools/PrettyPrinting/css-rule-tests/*.
  • inspector/codemirror/resources/prettyprinting/css-tests/*: Renamed from Source/WebInspectorUI/Tools/PrettyPrinting/css-tests/*.
  • inspector/codemirror/resources/prettyprinting/javascript-tests/*: Renamed from Source/WebInspectorUI/Tools/PrettyPrinting/js-tests/*.

Move tests from PrettyPrinting tools into LayoutTests.

  • inspector/codemirror/prettyprinting-css-expected.txt: Added.
  • inspector/codemirror/prettyprinting-css-rules-expected.txt: Added.
  • inspector/codemirror/prettyprinting-css-rules.html: Added.
  • inspector/codemirror/prettyprinting-css.html: Added.
  • inspector/codemirror/prettyprinting-javascript-expected.txt: Added.
  • inspector/codemirror/prettyprinting-javascript.html: Added.

Add tests per CodeMirror mode.

  • inspector/codemirror/resources/prettyprinting/utilities.js: Added.

(TestPage.registerInitializer):
Shared code between the pretty printing tests.

11:34 AM Changeset in webkit [189499] by commit-queue@webkit.org
  • 7 edits in trunk/Source/JavaScriptCore

Implement all the arithmetic and logical instructions in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=148882

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-08
Reviewed by Mark Lam.

This patch implements all the arithmetic and logical instructions for
32-bit integers in WebAssembly.

  • tests/stress/wasm-arithmetic.js:
  • tests/stress/wasm/arithmetic.wasm:
  • wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::buildUnaryI32):
(JSC::WASMFunctionCompiler::buildBinaryI32):

  • wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseUnaryExpressionI32):

  • wasm/WASMFunctionParser.h:
  • wasm/WASMFunctionSyntaxChecker.h:

(JSC::WASMFunctionSyntaxChecker::buildUnaryI32):

11:23 AM Changeset in webkit [189498] by peavo@outlook.com
  • 2 edits in trunk/Source/WebCore

[Win][HighDPI] Video window placement is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=148954

Reviewed by Alex Christensen.

We need to scale window dimensions with device scale factor.

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::setSize):

11:18 AM Changeset in webkit [189497] by peavo@outlook.com
  • 3 edits in trunk/Source/WebKit/win

[Win] Implement DOMNode::attributes.
https://bugs.webkit.org/show_bug.cgi?id=148747

Reviewed by Brent Fulgham.

  • DOMCoreClasses.cpp:

(DOMNode::attributes):
(DOMNode::ownerDocument):
(DOMRange::detach):
(DOMNamedNodeMap::DOMNamedNodeMap):
(DOMNamedNodeMap::~DOMNamedNodeMap):
(DOMNamedNodeMap::createInstance):
(DOMNamedNodeMap::QueryInterface):
(DOMNamedNodeMap::getNamedItem):
(DOMNamedNodeMap::setNamedItem):
(DOMNamedNodeMap::removeNamedItem):
(DOMNamedNodeMap::item):
(DOMNamedNodeMap::length):
(DOMNamedNodeMap::getNamedItemNS):
(DOMNamedNodeMap::setNamedItemNS):
(DOMNamedNodeMap::removeNamedItemNS):

  • DOMCoreClasses.h:

(DOMNamedNodeMap::AddRef):
(DOMNamedNodeMap::Release):
(DOMNamedNodeMap::throwException):
(DOMNamedNodeMap::callWebScriptMethod):
(DOMNamedNodeMap::evaluateWebScript):
(DOMNamedNodeMap::removeWebScriptKey):
(DOMNamedNodeMap::stringRepresentation):
(DOMNamedNodeMap::webScriptValueAtIndex):
(DOMNamedNodeMap::setWebScriptValueAtIndex):
(DOMNamedNodeMap::setException):

11:17 AM Changeset in webkit [189496] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix debug by removing an assertion that is not correct anymore.

  • jit/Repatch.cpp:

(JSC::linkFor):

11:05 AM FontSelection edited by Simon Fraser
(diff)
10:47 AM Changeset in webkit [189495] by dbates@webkit.org
  • 4 edits in trunk/LayoutTests

Mark animations/trigger-container-scroll-boundaries.html as failure on iOS

According to Dean Jackson this feature is not supported on iOS at this time.

  • platform/ios-simulator-wk1/TestExpectations: Move existing animation trigger failure expectations from here...
  • platform/ios-simulator-wk2/TestExpectations: and here...
  • platform/ios-simulator/TestExpectations: to here.
10:39 AM Changeset in webkit [189494] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk/Source/JavaScriptCore

Add initial support for doubles in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=148913

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-08
Reviewed by Filip Pizlo.

Implement the ConstantPoolIndex, Immediate, and GetLocal instructions
for doubles (float64) in WebAssembly.

  • tests/stress/wasm-arithmetic-float64.js: Added.

(shouldBe):

  • tests/stress/wasm/arithmetic-float64.wasm: Added.
  • wasm/WASMConstants.h:
  • wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::buildSetLocal):
(JSC::WASMFunctionCompiler::buildReturn):
(JSC::WASMFunctionCompiler::buildImmediateI32):
(JSC::WASMFunctionCompiler::buildImmediateF64):
(JSC::WASMFunctionCompiler::buildGetLocal):

  • wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseExpression):
(JSC::WASMFunctionParser::parseExpressionF64):
(JSC::WASMFunctionParser::parseConstantPoolIndexExpressionF64):
(JSC::WASMFunctionParser::parseImmediateExpressionF64):
(JSC::WASMFunctionParser::parseGetLocalExpressionF64):

  • wasm/WASMFunctionParser.h:
  • wasm/WASMFunctionSyntaxChecker.h:

(JSC::WASMFunctionSyntaxChecker::buildImmediateF64):

  • wasm/WASMReader.cpp:

(JSC::WASMReader::readOpExpressionF64):

  • wasm/WASMReader.h:
10:25 AM Changeset in webkit [189493] by fpizlo@apple.com
  • 3 edits
    1 add in trunk/Source/JavaScriptCore

CallLinkInfo inside StructureStubInfo should not use polymorphic stubs
https://bugs.webkit.org/show_bug.cgi?id=148915

Reviewed by Mark Lam.

There is a subtle bug where if we reset a get_by_id IC that had a getter stub that in
turn had a polymorphic call stub, then the GC won't know to keep the getter stub alive.
This patch documents the bug in a FIXME and disables polymorphic call optimizations for
getters. It also just so happens that the polymorphic call optimizations usually don't
benefit getters, since it's hard to create polymorphism at the point of call without also
introducing polymorphism in the base object's structure.

The added test doesn't reproduce the problem, because it's hard to get the GC to delete
all of the stubs.

  • bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::CallLinkInfo):
(JSC::CallLinkInfo::setCallLocations):
(JSC::CallLinkInfo::allowStubs):
(JSC::CallLinkInfo::disallowStubs):
(JSC::CallLinkInfo::setUpCallFromFTL):

  • jit/Repatch.cpp:

(JSC::generateByIdStub):
(JSC::linkFor):
(JSC::linkPolymorphicCall):

  • tests/stress/poly-call-stub-in-getter-stub.js: Added.

(foo):
(makeGetter):

10:00 AM Changeset in webkit [189492] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

The put_by_id IC store barrier contract should benefit transition over replace
https://bugs.webkit.org/show_bug.cgi?id=148943

Reviewed by Mark Lam.

Previously, we would only emit a barrier if the value being stored was possibly a cell, so
the transition stub code generator would have to emit a barrier for the store of the
structure, just in case the structure was newer than the base object.

This changes the contract so that the put_by_id callsite would always have a barrier on the
base (except if it proved that the base was brand new). That way, the transition doesn't have
to have a barrier unless it allocates.

This is meant to be a perf-neutral change that I need for the IC refactoring in
https://bugs.webkit.org/show_bug.cgi?id=148717.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGStoreBarrierInsertionPhase.cpp:
  • jit/Repatch.cpp:

(JSC::emitPutTransitionStub):

9:54 AM Changeset in webkit [189491] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Mark fast/dom/rtl-scroll-to-leftmost-and-resize.html as a flaky timeout for
https://bugs.webkit.org/show_bug.cgi?id=148951

  • platform/mac-wk2/TestExpectations:
9:01 AM Changeset in webkit [189490] by dbates@webkit.org
  • 2 edits
    4 adds
    2 deletes in trunk

Convert manual test added in http://trac.webkit.org/changeset/70321 to an automated test
https://bugs.webkit.org/show_bug.cgi?id=74729
<rdar://problem/22550195>

Reviewed by Jon Honeycutt.

.:

  • ManualTests/compositing/resources/composited-subframe.html: Removed.
  • ManualTests/compositing/show-composited-iframe-on-back-button.html: Removed.

LayoutTests:

  • compositing/resources/composited-subframe.html: Added.
  • compositing/resources/show-composited-iframe-on-back-button.css: Added.

(.container):
(.box):

  • compositing/show-composited-iframe-on-back-button-expected.html: Added.
  • compositing/show-composited-iframe-on-back-button.html: Added.
8:58 AM Changeset in webkit [189489] by dbates@webkit.org
  • 3 edits in trunk/Tools

Dashboard: Remove use of z-index for ring overlay; use DOM ordering
https://bugs.webkit.org/show_bug.cgi?id=148921

Reviewed by Alexey Proskuryakov.

The ring image is positioned above the platform icon in markup and we specify the CSS
property z-index for the ring image so that it is painted on top of the platform icon
instead of below it (by DOM ordering). Instead we can take advantage of the transparency
of the ring image, switch the order of these DOM elements and remove the use of the CSS
property z-index to achieve a similar effect.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:

(documentReady): Create the platform icon image element before the ring image such that
the ring image is painted on top of the platform icon.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(table.queue-grid td.logo img.ring): Removed property z-index.

8:57 AM Changeset in webkit [189488] by dbates@webkit.org
  • 2 edits in trunk/Tools

Dashboard: Remove duplicate gear icon data URLs
https://bugs.webkit.org/show_bug.cgi?id=148920

Reviewed by Alexey Proskuryakov.

Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
background-image associated with each of the three gear icon states: collapsed (.settings), hover
(.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
as a mask and make use of the CSS background-color to define the fill color for each of these three
states.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(.settings): Use gear icon as mask and define CSS background-color for collapsed state.
(.settings:hover): Override CSS background-color for hover state.
(.settings-visible .settings): Override CSS background-color for expanded state.

8:43 AM Changeset in webkit [189487] by clopez@igalia.com
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.

Update some paths for tests that were renamed.
Remove some tests from the expectations that not longer exist.
Report new failures for the Debug build.

  • platform/gtk/TestExpectations:
8:25 AM Changeset in webkit [189486] by Chris Dumez
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed, land iOS baselines for a couple of html/dom tests.

  • platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/dynamic-markup-insertion/document-write/nested-document-write-1-expected.txt: Added.
  • platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/dynamic-markup-insertion/document-write/nested-document-write-2-expected.txt: Added.
3:50 AM Changeset in webkit [189485] by Gyuyoung Kim
  • 10 edits in trunk/Source/WebCore

Reduce uses of PassRefPtr in fileapi
https://bugs.webkit.org/show_bug.cgi?id=148952

Reviewed by Andreas Kling.

Remove all uses of PassRefPtr in return type. Argument uses of PassRefPtr will be
removed in near future.

  • fileapi/FileError.h:

(WebCore::FileError::create):

  • fileapi/FileReader.cpp:

(WebCore::FileReader::arrayBufferResult):

  • fileapi/FileReader.h:
  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::arrayBufferResult):

  • fileapi/FileReaderLoader.h:
  • fileapi/FileReaderSync.cpp:

(WebCore::FileReaderSync::readAsArrayBuffer):

  • fileapi/FileReaderSync.h:
  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::ThreadableBlobRegistry::getCachedOrigin):

  • fileapi/ThreadableBlobRegistry.h:

Sep 7, 2015:

11:48 PM Changeset in webkit [189484] by Chris Dumez
  • 7 edits
    7 adds in trunk/LayoutTests

LayoutTests/imported/w3c:
Unreviewed, fixup a few recently imported W3C HTML tests.

A few support files were missing.

  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/blank.htm: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/sandbox_allow_script.html: Added.
  • web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-ltr.html:
  • web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/resources/dirname-ltr-iframe.html: Added.
  • web-platform-tests/html/semantics/selectors/pseudo-classes/focus-expected.txt:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/focus.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/resources/focus-iframe.html: Added.

LayoutTests:
Unreviewed gardening.

Update Window baselines for a couple of W3C HTML tests.

  • platform/win/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-expected.txt:
  • platform/win/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set-expected.txt:
11:24 PM Changeset in webkit [189483] by Chris Fleizach
  • 4 edits
    2 adds in trunk

AX: Mavericks: Text cursor does not move along with VoiceOver cursor for text fields
https://bugs.webkit.org/show_bug.cgi?id=148891

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Undo the asynchronous dispatch of accessibility setting values on pre El Capitan machines
because it causes focus to not sync correctly.

Test: accessibility/mac/focus-moves-cursor.html

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]):

LayoutTests:

  • accessibility/mac/focus-moves-cursor-expected.txt: Added.
  • accessibility/mac/focus-moves-cursor.html: Added.
11:20 PM Changeset in webkit [189482] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, update iOS baseline for imported/w3c/web-platform-tests/html/dom/interfaces.html.

  • platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
11:18 PM Changeset in webkit [189481] by Chris Dumez
  • 1 edit
    1 delete in trunk/LayoutTests/imported/w3c

Unreviewed, drop unfinished W3C DOM tests.

Those were not meant to be imported.

  • web-platform-tests/dom/traversal/unfinished/001-expected.txt: Removed.
  • web-platform-tests/dom/traversal/unfinished/001.xml: Removed.
  • web-platform-tests/dom/traversal/unfinished/002-expected.txt: Removed.
  • web-platform-tests/dom/traversal/unfinished/002.xml: Removed.
  • web-platform-tests/dom/traversal/unfinished/003-expected.txt: Removed.
  • web-platform-tests/dom/traversal/unfinished/003.xml: Removed.
  • web-platform-tests/dom/traversal/unfinished/004-expected.txt: Removed.
  • web-platform-tests/dom/traversal/unfinished/004.xml: Removed.
  • web-platform-tests/dom/traversal/unfinished/005-expected.txt: Removed.
  • web-platform-tests/dom/traversal/unfinished/005.xml: Removed.
  • web-platform-tests/dom/traversal/unfinished/006-expected.txt: Removed.
  • web-platform-tests/dom/traversal/unfinished/006.xml: Removed.
  • web-platform-tests/dom/traversal/unfinished/007-expected.txt: Removed.
  • web-platform-tests/dom/traversal/unfinished/007.xml: Removed.
  • web-platform-tests/dom/traversal/unfinished/008-expected.txt: Removed.
  • web-platform-tests/dom/traversal/unfinished/008.xml: Removed.
  • web-platform-tests/dom/traversal/unfinished/009-expected.txt: Removed.
  • web-platform-tests/dom/traversal/unfinished/009.xml: Removed.
  • web-platform-tests/dom/traversal/unfinished/010-expected.txt: Removed.
  • web-platform-tests/dom/traversal/unfinished/010.xml: Removed.
  • web-platform-tests/dom/traversal/unfinished/TODO: Removed.
11:14 PM Changeset in webkit [189480] by Chris Dumez
  • 1 edit
    71 deletes in trunk/LayoutTests/imported/w3c

Unreviewed, drop several W3C html media that were recently imported as they are flaky.

  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-insert-before-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-insert-before.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-moved-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-moved.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-remove-addEventListener-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-remove-no-listener-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-remove-no-listener.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-audio-constructor-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-audio-constructor-no-src-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-audio-constructor-no-src.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-audio-constructor.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-in-sync-event-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-in-sync-event.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-fragment-into-document-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-fragment-into-document.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-into-document-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-into-document.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-parent-into-document-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-parent-into-document.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-in-div-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-in-div.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-in-namespace-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-in-namespace.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-networkState-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-networkState.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-not-in-document-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-not-in-document.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-load-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-load.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-pause-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-pause-networkState-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-pause-networkState.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-pause.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-play-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-play.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-remove-from-document-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-remove-from-document-networkState-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-remove-from-document-networkState.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-remove-from-document.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-remove-src-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-remove-src.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-set-src-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-set-src-in-namespace-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-set-src-in-namespace.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-set-src-networkState-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-set-src-networkState.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-set-src.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-control-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-control.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-br-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-br.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-source-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-source.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-text-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-text.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-source-after-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-source-after.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-source-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-source.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-text-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-text.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-remove-source-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-remove-source.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-remove-src-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-remove-src.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-source-media-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-source-media.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/networkState_during_progress-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/media-elements/networkState_during_progress.html: Removed.
10:43 PM Changeset in webkit [189479] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, skip imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_specified.sub.html

This test causes the next one to be flaky. The issue is tracked by
Bug 148950.

10:31 PM Changeset in webkit [189478] by Chris Dumez
  • 1 edit
    11 deletes in trunk/LayoutTests

Unreviewed, drop W3C support files from http/

Drop W3C support files from http/tests/resources/ and
http/tests/w3c/resources/. These were recently added and are not longer
needed that that the w3c web-platform-tests were moved to imported/w3c.

  • http/tests/resources/WebIDLParser.js: Removed.
  • http/tests/resources/idlharness.js: Removed.
  • http/tests/resources/testharness.css: Removed.
  • http/tests/resources/testharness.js: Removed.
  • http/tests/resources/testharnessreport.js: Removed.
  • http/tests/w3c/resources/css-red.txt: Removed.
  • http/tests/w3c/resources/media.js: Removed.
  • http/tests/w3c/resources/media/A4.mp4: Removed.
  • http/tests/w3c/resources/media/A4.ogv: Removed.
  • http/tests/w3c/resources/media/foo.vtt: Removed.
  • http/tests/w3c/resources/media/foo.vtt.headers: Removed.
  • http/tests/w3c/resources/media/green-at-15.mp4: Removed.
  • http/tests/w3c/resources/media/green-at-15.ogv: Removed.
  • http/tests/w3c/resources/media/movie_300.mp4: Removed.
  • http/tests/w3c/resources/media/movie_300.ogv: Removed.
  • http/tests/w3c/resources/media/movie_5.mp4: Removed.
  • http/tests/w3c/resources/media/movie_5.ogv: Removed.
  • http/tests/w3c/resources/media/poster.png: Removed.
  • http/tests/w3c/resources/media/sound_5.mp3: Removed.
  • http/tests/w3c/resources/media/sound_5.oga: Removed.
  • http/tests/w3c/resources/media/white.mp4: Removed.
  • http/tests/w3c/resources/media/white.webm: Removed.
  • http/tests/w3c/resources/stringifiers.js: Removed.
  • http/tests/w3c/resources/utils.js: Removed.
10:23 PM Changeset in webkit [189477] by Chris Dumez
  • 5 edits
    1 move
    5 adds
    1 delete in trunk/LayoutTests

Unreviewed fixup after r189471 and r189472.

LayoutTests/imported/w3c:

  • web-platform-tests/common/blank.html: Added.

Add missing file used by some tests.

  • web-platform-tests/dom/nodes/Node-parentNode-iframe-expected.txt: Removed.
  • web-platform-tests/dom/nodes/Node-parentNode.html:
  • web-platform-tests/dom/nodes/resources/Node-parentNode-iframe.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-parentNode-iframe.html.

Move html file to resources folder so that WRT does not think it is a test.

LayoutTests:

  • platform/win/TestExpectations:

Skip a couple of failing tests on Windows.

  • platform/win/imported/w3c/web-platform-tests/html/dom/dynamic-markup-insertion/document-write/nested-document-write-1-expected.txt: Added.
  • platform/win/imported/w3c/web-platform-tests/html/dom/dynamic-markup-insertion/document-write/nested-document-write-2-expected.txt: Added.

Land Windows baselines.

  • platform/win/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:

Rebaseline for Windows.

10:08 PM Changeset in webkit [189476] by Chris Dumez
  • 7 edits
    925 copies
    499 adds
    3 deletes in trunk/LayoutTests

Unreviewed, move html/semantics W3C tests to imported/w3c/web-platform-tests/html/semantics
https://bugs.webkit.org/show_bug.cgi?id=148949

LayoutTests/imported/w3c:

  • web-platform-tests/html/semantics/*: Added.

LayoutTests:

8:52 PM Changeset in webkit [189475] by Chris Dumez
  • 3 edits
    54 moves
    4 adds
    1 delete in trunk/LayoutTests

LayoutTests/imported/w3c:
Unreviewed, fix-up for r189472.

  • Add a few missing test expectations.
  • Rename ref-tests expected results to use proper format: -expected.html
  • web-platform-tests/html/dom/dynamic-markup-insertion/document-write/nested-document-write-1-expected.txt: Added.
  • web-platform-tests/html/dom/dynamic-markup-insertion/document-write/nested-document-write-2-expected.txt: Added.
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/004-1-expected.txt: Added.
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/016-1-expected.txt: Added.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-EN-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-EN-L-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-EN-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-EN-R-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-L-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-EN-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-EN-L-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-EN-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-EN-R-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-EN-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-EN-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-L-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-R-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-R-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-L-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-R-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-bdi-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-bdi-L-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-bdi-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-bdi-R-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-dir-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-dir-L-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-dir-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-dir-R-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-dir_auto-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-dir_auto-L-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-dir_auto-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-dir_auto-R-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-script-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-script-L-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-script-L-expected.txt: Removed.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-script-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-script-R-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-style-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-style-L-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-style-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-style-R-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-textarea-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-textarea-L-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-textarea-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-textarea-R-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-EN-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-EN-L-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-EN-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-EN-R-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-L-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-EN-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-EN-L-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-EN-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-EN-R-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-EN-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-EN-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-L-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-R-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-R-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-EN-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-EN-L-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-EN-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-EN-R-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-L-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-EN-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-EN-L-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-EN-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-EN-R-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-EN-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-EN-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-L-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-R-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-R-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-isolate-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-isolate-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-pre-N-EN-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-pre-N-EN-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-pre-N-between-Rs-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-pre-N-between-Rs-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-pre-mixed-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-pre-mixed-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-N-EN-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-N-EN-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-N-between-Rs-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-N-between-Rs-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-mixed-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-mixed-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-N-EN-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-N-EN-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-N-between-Rs-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-N-between-Rs-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-mixed-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-mixed-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/lang-xmllang-01-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/lang-xmllang-01-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/lang-xyzzy-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/lang-xyzzy-ref.html.
  • web-platform-tests/html/dom/elements/global-attributes/style-01-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/style-01-ref.html.

LayoutTests:
Unreviewed, Skip again files that were wrongly unskipped in r189472.

7:53 PM Changeset in webkit [189474] by Gyuyoung Kim
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening. tests of imported/w3c/css/ have been passed since r189358.
Those tests seem to be failed on other ports though, those are passing on EFL port.

  • platform/efl/TestExpectations:
7:13 PM Changeset in webkit [189473] by Gyuyoung Kim
  • 5 edits
    1 delete in trunk/Source/WebCore

[CoordinatedGraphics] Remove ScrollingStateScrollingNodeCoordinatedGraphics.cpp
https://bugs.webkit.org/show_bug.cgi?id=148931

Reviewed by Csaba Osztrogonác.

ScrollingStateScrollingNodeCoordinatedGraphics.cpp implements nothing. Removed it.

  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • page/scrolling/coordinatedgraphics/ScrollingStateScrollingNodeCoordinatedGraphics.cpp: Removed.
7:07 PM Changeset in webkit [189472] by Chris Dumez
  • 4 edits
    503 copies
    43 adds
    3 deletes in trunk/LayoutTests

Unreviewed, move html/dom W3C tests to imported/w3c/web-platform-tests/html/dom/
https://bugs.webkit.org/show_bug.cgi?id=148948

LayoutTests/imported/w3c:

  • web-platform-tests/html/dom/*: Added.

LayoutTests:

  • TestExpectations:
  • http/tests/w3c/html/dom/*: Removed.
  • platform/efl/TestExpectations:
  • platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt: Renamed from LayoutTests/platform/ios-simulator/http/tests/w3c/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt.
  • platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt: Renamed from LayoutTests/platform/ios-simulator/http/tests/w3c/html/dom/interfaces-expected.txt.
  • platform/win/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt: Renamed from LayoutTests/platform/win/http/tests/w3c/html/dom/interfaces-expected.txt.
6:09 PM Changeset in webkit [189471] by Chris Dumez
  • 6 edits
    414 copies
    133 adds
    1 delete in trunk/LayoutTests

Unreviewed, move W3C DOM tests to imported/w3c/web-platform-tests/dom
https://bugs.webkit.org/show_bug.cgi?id=148947

Move W3C DOM tests with other web-platform-tests under:
imported/w3c/web-platform-tests/dom.

LayoutTests/imported/w3c:

  • web-platform-tests/dom/*: Added.

LayoutTests:

  • TestExpectations:
  • http/tests/w3c/dom/collections/w3c-import.log: Removed.
  • http/tests/w3c/dom/events/w3c-import.log: Removed.
  • http/tests/w3c/dom/lists/w3c-import.log: Removed.
  • http/tests/w3c/dom/nodes/Document-URL.sub-expected.txt: Removed.
  • http/tests/w3c/dom/nodes/Document-characterSet-normalization-expected.txt: Removed.
  • http/tests/w3c/dom/nodes/DocumentType-literal-xhtml-expected.txt: Removed.
  • http/tests/w3c/dom/nodes/Element-childElementCount-dynamic-add-xhtml-expected.txt: Removed.
  • http/tests/w3c/dom/nodes/Element-childElementCount-nochild-xhtml-expected.txt: Removed.
  • http/tests/w3c/dom/nodes/Element-firstElementChild-xhtml-expected.txt: Removed.
  • http/tests/w3c/dom/nodes/Element-nextElementSibling-xhtml-expected.txt: Removed.
  • http/tests/w3c/dom/nodes/Element-previousElementSibling-xhtml-expected.txt: Removed.
  • http/tests/w3c/dom/nodes/Node-isEqualNode-xhtml-expected.txt: Removed.
  • http/tests/w3c/dom/nodes/Node-lookupPrefix-xhtml-expected.txt: Removed.
  • http/tests/w3c/dom/nodes/ProcessingInstruction-literal-1-xhtml-expected.txt: Removed.
  • http/tests/w3c/dom/nodes/ProcessingInstruction-literal-2-xhtml-expected.txt: Removed.
  • http/tests/w3c/dom/nodes/getElementsByClassName-10-expected.txt: Removed.
  • http/tests/w3c/dom/nodes/getElementsByClassName-11-expected.txt: Removed.
  • http/tests/w3c/dom/nodes/getElementsByClassName-31-expected.txt: Removed.
  • http/tests/w3c/dom/nodes/w3c-import.log: Removed.
  • http/tests/w3c/dom/ranges/w3c-import.log: Removed.
  • http/tests/w3c/dom/traversal/w3c-import.log: Removed.
  • http/tests/w3c/dom/w3c-import.log: Removed.
  • platform/efl/TestExpectations:
  • platform/ios-simulator/TestExpectations:
4:05 PM Changeset in webkit [189470] by aestes@apple.com
  • 7 edits in trunk

[Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
https://bugs.webkit.org/show_bug.cgi?id=148946
<rdar://problem/22603981>

Reviewed by Dan Bernstein.

Source/WebKit/mac:

  • Configurations/DebugRelease.xcconfig:

Source/WebKit2:

  • Configurations/DebugRelease.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3:46 PM Changeset in webkit [189469] by dbates@webkit.org
  • 11 edits
    8 adds in trunk

ASSERT_WITH_SECURITY_IMPLICATION in WebCore::DocumentOrderedMap::get(); update form
association after subtree insertion
https://bugs.webkit.org/show_bug.cgi?id=148919
<rdar://problem/21868036>

Patch by Daniel Bates <dabates@apple.com> on 2015-09-07
Reviewed by Andy Estes.

Source/WebCore:

Currently we update the form association of a form control upon insertion into
the document. Instead we should update the form association of a form control
after its containing subtree is inserted into the document to avoid an assertion
failure when the containing subtree has an element whose id is identical to both
the id of some other element in the document and the name of the form referenced
by the inserted form control.

Tests: fast/forms/update-form-owner-in-moved-subtree-assertion-failure-2.html

fast/forms/update-form-owner-in-moved-subtree-assertion-failure-3.html
fast/forms/update-form-owner-in-moved-subtree-assertion-failure-4.html
fast/forms/update-form-owner-in-moved-subtree-assertion-failure.html

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::insertedInto): Moved resetFormOwner() from here
to {HTMLFormControlElement, HTMLObjectElement}::finishedInsertingSubtree().

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::insertedInto): Return InsertionShouldCallFinishedInsertingSubtree
so that HTMLFormControlElement::finishedInsertingSubtree() is called.
(WebCore::HTMLFormControlElement::finishedInsertingSubtree): Added; turn around and
call FormAssociatedElement::resetFormOwner().

  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::insertedInto): Return InsertionShouldCallFinishedInsertingSubtree so
that HTMLInputElement::finishedInsertingSubtree() is called and move logic to update radio button
group from here...
(WebCore::HTMLInputElement::finishedInsertingSubtree): to here.

  • html/HTMLInputElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::insertedInto): Return InsertionShouldCallFinishedInsertingSubtree so
that HTMLObjectElement::finishedInsertingSubtree() is called.
(WebCore::HTMLObjectElement::finishedInsertingSubtree): Added; turn around and
call FormAssociatedElement::resetFormOwner().

  • html/HTMLObjectElement.h:
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::insertedInto): Modified to return the result of
HTMLFormControlElementWithState::insertedInto(), which may schedule a callback after subtree
insertion.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::insertedInto): Ditto.

LayoutTests:

Add tests to ensure that updating the form association of a form control in a subtree
does not cause an assertion failure.

  • fast/forms/update-form-owner-in-moved-subtree-assertion-failure-2-expected.txt: Added.
  • fast/forms/update-form-owner-in-moved-subtree-assertion-failure-2.html: Added.
  • fast/forms/update-form-owner-in-moved-subtree-assertion-failure-3-expected.txt: Added.
  • fast/forms/update-form-owner-in-moved-subtree-assertion-failure-3.html: Added.
  • fast/forms/update-form-owner-in-moved-subtree-assertion-failure-4-expected.txt: Added.
  • fast/forms/update-form-owner-in-moved-subtree-assertion-failure-4.html: Added.
  • fast/forms/update-form-owner-in-moved-subtree-assertion-failure-expected.txt: Added.
  • fast/forms/update-form-owner-in-moved-subtree-assertion-failure.html: Added.
3:46 PM Changeset in webkit [189468] by achristensen@apple.com
  • 2 edits
    10 moves in trunk/Source/JavaScriptCore

Windows non-cygwin build fix after r189333.

SVN on Windows (non-cygwin) doesn't like having the * character in file names.
I replaced "*" with "star" in some of Geoff's new tests.

  • tests/es6.yaml:

Changed all _*_ to _star_

  • tests/es6/generators_yield_*_arrays.js: Removed.
  • tests/es6/generators_yield_*_astral_plane_strings.js: Removed.
  • tests/es6/generators_yield_*_generator_instances.js: Removed.
  • tests/es6/generators_yield_*_generic_iterables.js: Removed.
  • tests/es6/generators_yield_*_instances_of_iterables.js: Removed.
  • tests/es6/generators_yield_*_iterator_closing.js: Removed.
  • tests/es6/generators_yield_*_iterator_closing_via_throw.js: Removed.
  • tests/es6/generators_yield_*_on_non-iterables_is_a_runtime_error.js: Removed.
  • tests/es6/generators_yield_*_sparse_arrays.js: Removed.
  • tests/es6/generators_yield_*_strings.js: Removed.
  • tests/es6/generators_yield_star_arrays.js: Copied from tests/es6/generators_yield_*_arrays.js.
  • tests/es6/generators_yield_star_astral_plane_strings.js: Copied from tests/es6/generators_yield_*_astral_plane_strings.js.
  • tests/es6/generators_yield_star_generator_instances.js: Copied from tests/es6/generators_yield_*_generator_instances.js.
  • tests/es6/generators_yield_star_generic_iterables.js: Copied from tests/es6/generators_yield_*_generic_iterables.js.
  • tests/es6/generators_yield_star_instances_of_iterables.js: Copied from tests/es6/generators_yield_*_instances_of_iterables.js.
  • tests/es6/generators_yield_star_iterator_closing.js: Copied from tests/es6/generators_yield_*_iterator_closing.js.
  • tests/es6/generators_yield_star_iterator_closing_via_throw.js: Copied from tests/es6/generators_yield_*_iterator_closing_via_throw.js.
  • tests/es6/generators_yield_star_on_non-iterables_is_a_runtime_error.js: Copied from tests/es6/generators_yield_*_on_non-iterables_is_a_runtime_error.js.
  • tests/es6/generators_yield_star_sparse_arrays.js: Copied from tests/es6/generators_yield_*_sparse_arrays.js.
  • tests/es6/generators_yield_star_strings.js: Copied from tests/es6/generators_yield_*_strings.js.
1:31 PM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com
(diff)
1:12 PM Changeset in webkit [189467] by clopez@igalia.com
  • 2 edits
    47 moves
    1 delete in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.

Report and mark new failures on the GTK TestExpectations file.
Move back all the GTK baselines for the general accessibiliy tests to platform/gtk that r187777 wrongly moved inside accessibility/gtk.

  • accessibility/gtk/disabled-controls-not-focusable-expected.txt: Removed. Same baseline than the general one so not need to move it back to platform/gtk/accessibility.
  • platform/gtk/TestExpectations:
  • platform/gtk/accessibility/aria-checkbox-sends-notification-expected.txt: Renamed from LayoutTests/accessibility/gtk/aria-checkbox-sends-notification-expected.txt.
  • platform/gtk/accessibility/aria-fallback-roles-expected.txt: Renamed from LayoutTests/accessibility/gtk/aria-fallback-roles-expected.txt.
  • platform/gtk/accessibility/aria-help-expected.txt: Renamed from LayoutTests/accessibility/gtk/aria-help-expected.txt.
  • platform/gtk/accessibility/aria-hidden-false-works-in-subtrees-expected.txt: Renamed from LayoutTests/accessibility/gtk/aria-hidden-false-works-in-subtrees-expected.txt.
  • platform/gtk/accessibility/aria-inherits-presentational-expected.txt: Renamed from LayoutTests/accessibility/gtk/aria-inherits-presentational-expected.txt.
  • platform/gtk/accessibility/aria-menubar-menuitems-expected.txt: Renamed from LayoutTests/accessibility/gtk/aria-menubar-menuitems-expected.txt.
  • platform/gtk/accessibility/aria-switch-text-expected.txt: Renamed from LayoutTests/accessibility/gtk/aria-switch-text-expected.txt.
  • platform/gtk/accessibility/aria-table-hierarchy-expected.txt: Renamed from LayoutTests/accessibility/gtk/aria-table-hierarchy-expected.txt.
  • platform/gtk/accessibility/aria-toggle-button-with-title-expected.txt: Renamed from LayoutTests/accessibility/gtk/aria-toggle-button-with-title-expected.txt.
  • platform/gtk/accessibility/color-well-expected.txt: Renamed from LayoutTests/accessibility/gtk/color-well-expected.txt.
  • platform/gtk/accessibility/css-content-attribute-expected.txt: Renamed from LayoutTests/accessibility/gtk/css-content-attribute-expected.txt.
  • platform/gtk/accessibility/dimensions-include-descendants-expected.txt: Renamed from LayoutTests/accessibility/gtk/dimensions-include-descendants-expected.txt.
  • platform/gtk/accessibility/file-upload-button-stringvalue-expected.txt: Renamed from LayoutTests/accessibility/gtk/file-upload-button-stringvalue-expected.txt.
  • platform/gtk/accessibility/image-link-expected.txt: Renamed from LayoutTests/accessibility/gtk/image-link-expected.txt.
  • platform/gtk/accessibility/image-map1-expected.txt: Renamed from LayoutTests/accessibility/gtk/image-map1-expected.txt.
  • platform/gtk/accessibility/image-map2-expected.txt: Renamed from LayoutTests/accessibility/gtk/image-map2-expected.txt.
  • platform/gtk/accessibility/image-with-alt-and-map-expected.txt: Renamed from LayoutTests/accessibility/gtk/image-with-alt-and-map-expected.txt.
  • platform/gtk/accessibility/img-fallsback-to-title-expected.txt: Renamed from LayoutTests/accessibility/gtk/img-fallsback-to-title-expected.txt.
  • platform/gtk/accessibility/inline-continuations-expected.txt: Renamed from LayoutTests/accessibility/gtk/inline-continuations-expected.txt.
  • platform/gtk/accessibility/list-detection-expected.txt: Renamed from LayoutTests/accessibility/gtk/list-detection-expected.txt.
  • platform/gtk/accessibility/lists-expected.txt: Renamed from LayoutTests/accessibility/gtk/lists-expected.txt.
  • platform/gtk/accessibility/math-multiscript-attributes-expected.txt: Renamed from LayoutTests/accessibility/gtk/math-multiscript-attributes-expected.txt.
  • platform/gtk/accessibility/math-text-expected.txt: Renamed from LayoutTests/accessibility/gtk/math-text-expected.txt.
  • platform/gtk/accessibility/media-element-expected.txt: Renamed from LayoutTests/accessibility/gtk/media-element-expected.txt.
  • platform/gtk/accessibility/menu-list-crash2-expected.txt: Renamed from LayoutTests/accessibility/gtk/menu-list-crash2-expected.txt.
  • platform/gtk/accessibility/menu-list-sends-change-notification-expected.txt: Renamed from LayoutTests/accessibility/gtk/menu-list-sends-change-notification-expected.txt.
  • platform/gtk/accessibility/meter-element-expected.txt: Renamed from LayoutTests/accessibility/gtk/meter-element-expected.txt.
  • platform/gtk/accessibility/platform-name-expected.txt: Renamed from LayoutTests/accessibility/gtk/platform-name-expected.txt.
  • platform/gtk/accessibility/plugin-expected.txt: Renamed from LayoutTests/accessibility/gtk/plugin-expected.txt.
  • platform/gtk/accessibility/press-targets-center-point-expected.txt: Renamed from LayoutTests/accessibility/gtk/press-targets-center-point-expected.txt.
  • platform/gtk/accessibility/radio-button-title-label-expected.txt: Renamed from LayoutTests/accessibility/gtk/radio-button-title-label-expected.txt.
  • platform/gtk/accessibility/render-counter-text-expected.txt: Renamed from LayoutTests/accessibility/gtk/render-counter-text-expected.txt.
  • platform/gtk/accessibility/roles-computedRoleString-expected.txt: Renamed from LayoutTests/accessibility/gtk/roles-computedRoleString-expected.txt.
  • platform/gtk/accessibility/roles-exposed-expected.txt: Renamed from LayoutTests/accessibility/gtk/roles-exposed-expected.txt.
  • platform/gtk/accessibility/spinbutton-value-expected.txt: Renamed from LayoutTests/accessibility/gtk/spinbutton-value-expected.txt.
  • platform/gtk/accessibility/tabindex-elements-are-accessible-expected.txt: Renamed from LayoutTests/accessibility/gtk/tabindex-elements-are-accessible-expected.txt.
  • platform/gtk/accessibility/table-attributes-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-attributes-expected.txt.
  • platform/gtk/accessibility/table-cell-spans-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-cell-spans-expected.txt.
  • platform/gtk/accessibility/table-cells-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-cells-expected.txt.
  • platform/gtk/accessibility/table-column-headers-with-captions-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-column-headers-with-captions-expected.txt.
  • platform/gtk/accessibility/table-detection-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-detection-expected.txt.
  • platform/gtk/accessibility/table-hierarchy-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-hierarchy-expected.txt.
  • platform/gtk/accessibility/table-one-cell-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-one-cell-expected.txt.
  • platform/gtk/accessibility/table-roles-hierarchy-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-roles-hierarchy-expected.txt.
  • platform/gtk/accessibility/table-sections-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-sections-expected.txt.
  • platform/gtk/accessibility/table-with-rules-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-with-rules-expected.txt.
  • platform/gtk/accessibility/transformed-element-expected.txt: Renamed from LayoutTests/accessibility/gtk/transformed-element-expected.txt.
11:26 AM Changeset in webkit [189466] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Remove GlyphPage::mayUseMixedFontsWhenFilling
https://bugs.webkit.org/show_bug.cgi?id=148928

Reviewed by Dan Bernstein.

http://trac.webkit.org/188566 removed support for composite fonts. We never need to use mixed
glyph pages for fonts anymore.

  • platform/graphics/Font.cpp:

(WebCore::createAndFillGlyphPage):

  • platform/graphics/GlyphPage.h:

(WebCore::GlyphPage::GlyphPage):
(WebCore::GlyphPage::mayUseMixedFontsWhenFilling): Deleted.

  • platform/graphics/mac/GlyphPageMac.cpp:

(WebCore::shouldUseCoreText):
(WebCore::GlyphPage::fill):
(WebCore::GlyphPage::mayUseMixedFontsWhenFilling): Deleted.

10:42 AM Changeset in webkit [189465] by Antti Koivisto
  • 12 edits in trunk/Source/WebCore

Remove unneeded offset and length arguments from glyph page filling functions
https://bugs.webkit.org/show_bug.cgi?id=148929

Reviewed by Andreas Kling.

They are always passed 0/GlyphPage::size.

  • platform/graphics/Font.cpp:

(WebCore::Font::~Font):
(WebCore::fillGlyphPage):
(WebCore::createAndFillGlyphPage):

  • platform/graphics/Font.h:
  • platform/graphics/GlyphPage.h:

(WebCore::GlyphPage::setGlyphDataForIndex):

  • platform/graphics/mac/GlyphPageMac.cpp:

(WebCore::GlyphPage::mayUseMixedFontsWhenFilling):
(WebCore::GlyphPage::fill):

  • platform/graphics/win/GlyphPageTreeNodeCGWin.cpp:

(WebCore::GlyphPage::fill):

  • platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp:

(WebCore::GlyphPage::fill):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):
(WebCore::SVGFontData::fillSVGGlyphPage):
(WebCore::SVGFontData::fillBMPGlyphs):
(WebCore::SVGFontData::fillNonBMPGlyphs):

  • svg/SVGFontData.h:

(WebCore::SVGFontData::verticalAdvanceY):

7:21 AM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com
(diff)
5:34 AM Changeset in webkit [189464] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[EFL] Many of the css3/device-adapt/* tests failed after r188548.
https://bugs.webkit.org/show_bug.cgi?id=148927

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-09-07
Reviewed by Csaba Osztrogonác.

device-adapt/* tests need the fixedLayout option but useFixedLayout option is
overwritten by updatePlatformSpecificViewOptionsForTest after r188548.

  • WebKitTestRunner/TestController.cpp:

(WTR::shouldUseFixedLayout): Removed the unnecessary indentations.

  • WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.

12:46 AM Changeset in webkit [189463] by aestes@apple.com
  • 2 edits in trunk/Tools

Fix the Production build after r189455.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the

In-App Purchase template instead of the Aggregate template. Whoops.

12:09 AM Changeset in webkit [189462] by aestes@apple.com
  • 10 edits in trunk

WebKit.xcworkspace should be be able to build iOS platforms
https://bugs.webkit.org/show_bug.cgi?id=148881

Reviewed by Daniel Bates.

Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
for all supported platforms.

.:

  • WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Removed the DumpRenderTree target since its All

target was already included. Removed the WebKitTestRunner target and replaced it with its All target.

Source/WebInspectorUI:

  • Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
  • Configurations/WebInspectorUIFramework.xcconfig: Skipped installing on iOS.

Tools:

  • MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
  • MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
  • MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
Note: See TracTimeline for information about the timeline view.