⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 10, 2015:

11:13 PM Changeset in webkit [189608] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

11:12 PM Changeset in webkit [189607] by bshafiei@apple.com
  • 5 edits in branches/safari-601-branch/Source

Versioning.

11:08 PM Changeset in webkit [189606] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.56.2

New tag.

10:54 PM Changeset in webkit [189605] by bshafiei@apple.com
  • 4 edits in tags/Safari-601.1.56.0.1/Source/WebKit/win

Merge patch for rdar://problem/22633105.

10:51 PM Changeset in webkit [189604] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.56.0.1/Source

Versioning.

10:48 PM Changeset in webkit [189603] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.56.0.1

New tag.

6:43 PM Changeset in webkit [189602] by commit-queue@webkit.org
  • 1 edit
    2 deletes in trunk/Source/WebKit2

Web Inspector: Remove unused files
​https://bugs.webkit.org/show_bug.cgi?id=149049

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-10
Reviewed by Brian Burg.

  • WebProcess/WebPage/efl/WebInspectorEfl.cpp: Removed.
  • WebProcess/WebPage/gtk/WebInspectorGtk.cpp: Removed.
6:42 PM Changeset in webkit [189601] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

WebInspectorUI should have a WebPage reference
​https://bugs.webkit.org/show_bug.cgi?id=149046

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-10
Reviewed by Geoffrey Garen.

  • WebProcess/WebPage/WebInspectorUI.cpp:
  • WebProcess/WebPage/WebInspectorUI.h:

(WebKit::WebInspectorUI::page): Deleted.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::inspectorUI):

6:39 PM Changeset in webkit [189600] by commit-queue@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r189595.
​https://bugs.webkit.org/show_bug.cgi?id=149052

The tests still fail (Requested by ap on #webkit).

Reverted changeset:

"Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
error -1"
​https://bugs.webkit.org/show_bug.cgi?id=142929
​http://trac.webkit.org/changeset/189595

6:37 PM Changeset in webkit [189599] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

Implement switch statements in WebAssembly
​https://bugs.webkit.org/show_bug.cgi?id=149051

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-10
Reviewed by Geoffrey Garen.

This patch implements switch statements in WebAssembly using the
JSC::BinarySwitch class.

  • tests/stress/wasm-control-flow.js:
  • tests/stress/wasm/control-flow.wasm:
  • wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::buildSwitch):

  • wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseSwitchStatement):

  • wasm/WASMFunctionSyntaxChecker.h:

(JSC::WASMFunctionSyntaxChecker::buildSwitch):

5:55 PM Changeset in webkit [189598] by Chris Fleizach
  • 4 edits in trunk

AX: Mavericks: Text cursor does not move along with VoiceOver cursor for text fields
​https://bugs.webkit.org/show_bug.cgi?id=148891

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Asychronous focus setting DOES work on Yosemite, just not Mavericks.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]):

LayoutTests:

Mark accessibility focus tests as passing on Yosemite.

  • platform/mac/TestExpectations:
4:19 PM Changeset in webkit [189597] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.2

New tag.

4:07 PM Changeset in webkit [189596] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Structure should be able to tell you if it had ever been a dictionary
​https://bugs.webkit.org/show_bug.cgi?id=149047

Reviewed by Mark Lam.

Introduces the hasBeenDictionary flag to Structure, which tells you if this structure or
any of its ancestors is a dictionary. We already implicitly tracked this for DFG
watchpoint optimizations, so this is mainly just decoupling that existing logic from
watchpoints. Having Structure::hasBeenDictionary() enables some of the heuristics in the
property type inference work (​https://bugs.webkit.org/show_bug.cgi?id=148610).

  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::dump):

  • runtime/Structure.h:
3:59 PM Changeset in webkit [189595] by ap@apple.com
  • 5 edits in trunk

Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
​https://bugs.webkit.org/show_bug.cgi?id=142929

Reviewed by Brent Fulgham.

Tools:

Silence the logging. We'll track fixing the root cause in Radar.

  • Scripts/webkitpy/port/mac.py:

(MacPort.stderr_patterns_to_strip): Added a FIXME.

  • Scripts/webkitpy/port/win.py:

(WinPort.logging_patterns_to_strip): Added.

LayoutTests:

  • platform/win/TestExpectations: Unskip some newly added tests that are affected.

We still skip the whole media directory - updating the results and unskipping those
tests would be a separate project.

3:15 PM Changeset in webkit [189594] by hyatt@apple.com
  • 8 edits
    4 adds in trunk

[New Block-Inside-Inline Model] Self-collapsing block check needs to account for anonymous inline blocks
​https://bugs.webkit.org/show_bug.cgi?id=149042

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/block/inside-inlines/

  • rendering/InlineFlowBox.cpp:
  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::anonymousInlineBlock):
Add a new accessor to get the anonymousInlineBlock() for lines that wrap them.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::childrenPreventSelfCollapsing):
(WebCore::RenderBlock::isSelfCollapsingBlock):
isSelfCollapsingBlock() now calls a virtual method that checks lines/children called childrenPreventSelfCollapsing.
This lets us farm out the lines check to the derived RenderBlockFlow class.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::childrenPreventSelfCollapsing):
Added new virtual method for checking children.

  • rendering/RenderBlockFlow.cpp:
  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::childrenPreventSelfCollapsing):
Overridden to ensure that blocks can still be self-collapsing if they only contain anonymous inline-block lines that
are also self-collapsing.

LayoutTests:

  • fast/block/inside-inlines/new-model/self-collapsing-test-expected.html: Added.
  • fast/block/inside-inlines/new-model/self-collapsing-test.html: Added.
  • fast/block/inside-inlines/self-collapsing-test-expected.html: Added.
  • fast/block/inside-inlines/self-collapsing-test.html: Added.
2:54 PM Changeset in webkit [189593] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles sidebar says Media: all when it should say Media: screen
​https://bugs.webkit.org/show_bug.cgi?id=148436

Patch by Devin Rousso <Devin Rousso> on 2015-09-10
Reviewed by Timothy Hatcher.

Removed filter that prevented "Media: screen" from being displayed.

  • UserInterface/Views/RulesStyleDetailsPanel.js:

(WebInspector.RulesStyleDetailsPanel.prototype.refresh.insertMediaOrInheritanceLabel):
(WebInspector.RulesStyleDetailsPanel.prototype.refresh.filteredMediaList): Deleted.

2:28 PM Changeset in webkit [189592] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Web Inspector: WebInspectorUI does not need to be an API::Object
​https://bugs.webkit.org/show_bug.cgi?id=149045

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-10
Reviewed by Timothy Hatcher.

  • Shared/API/APIObject.h:
  • WebProcess/WebPage/WebInspectorUI.h:
2:24 PM Changeset in webkit [189591] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix Windows file loading in JSC shell after r189583
​https://bugs.webkit.org/show_bug.cgi?id=148917

Should load the script files with the binary mode.
Since these loading functions are only used for the simple test scripts,
we just use ftell / fseek now.

  • jsc.cpp:

(fillBufferWithContentsOfFile):

2:13 PM Changeset in webkit [189590] by Matt Baker
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Prefer calling ContentViewContainer.updateLayout directly
​https://bugs.webkit.org/show_bug.cgi?id=149041

Reviewed by Timothy Hatcher.

Cleaned up two places where a parent view duplicated logic encapsulated by ContentViewContainer.

  • UserInterface/Views/ClusterContentView.js:

(WebInspector.ClusterContentView.prototype.updateLayout):

  • UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype.updateLayout):

2:06 PM Changeset in webkit [189589] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Web Inspector: Remove unused member in WebPage
​https://bugs.webkit.org/show_bug.cgi?id=149040

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-10
Reviewed by Brian Burg.

  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
1:50 PM Changeset in webkit [189588] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r189575): Appears to break ARM64 linux builds
​https://bugs.webkit.org/show_bug.cgi?id=149044

Reviewed by Filip Pizlo.

Changed the use of the ARM64 "fp", a register alias, to be "x29", the real register name.

  • llint/LowLevelInterpreter.asm:
1:13 PM Changeset in webkit [189587] by dbates@webkit.org
  • 3 edits in trunk/Source/WebKit2

sendProcessWillSuspendImminently uses a wrong message flag
​https://bugs.webkit.org/show_bug.cgi?id=148995

Reviewed by Alexey Proskuryakov.

Remove use of flag IPC::InterruptWaitingIfSyncMessageArrives as it does not make
sense when sending a sync message.

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::sendProcessWillSuspendImminently):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::sendProcessWillSuspendImminently):

12:49 PM Changeset in webkit [189586] by fpizlo@apple.com
  • 29 edits
    2 moves
    1 add
    5 deletes in trunk

There should be one stub hanging off an inline cache that contains code for all of the cases, rather than forming a linked list consisting of one stub per case
​https://bugs.webkit.org/show_bug.cgi?id=148717

Reviewed by Michael Saboff.

Source/JavaScriptCore:

This is a major rewrite of the JSC get/put/in inline caches (ICs), motivated by the need to add
fancy new kinds of inline caches for property type inference (​https://webkit.org/b/148610).

Previously, our inline caches had some problems that made them difficult to work with. It was
impossible to change any code that was previously generated by the IC except by blowing the
whole IC away, the ICs scaled poorly if there were many cases, and there was a lot of duplicate
and ad hoc code.

Impossible to regenerate a previously generated stub: Say that some access (o.f = v) causes our
IC code to emit some stub; let's call it stub1. Then later we find that we need to emit a
different stub, stub2, where we think that stub2 might subsume stub1. We say that stub2
subsumes stub1 if failing to execute stub2 to completion means that we are guaranteed to fail
to execute stub1 to completion. This could happen in trunk if stub2 has the same base structure
as stub1 but different prototype conditions. It could happen with property type inference if
stub2 has a looser type check on v than stub1 did. Currently, if this happened, we would emit
stub2 and have its slow path jump to stub1. Hence, we would still end up executing the checks
of stub1 before falling through to the slow path. This gets bad when there are many stubs.
Stub1 might be in front of a bunch of other stubs, so when we add stub2, we will end up
executing both stub2's and stub1's checks before falling through to the other stubs. It would
be better if we could remove stub1 from the list at this point. But since stub1 could be linked
to from a different stub that we had already generated, we'd have to have a way of patching
stubs or regenerating them from scratch. This is currenty impossible because we just don't keep
around enough meta-data to mess with a stub after it's generated. After this change, we never
link new stubs onto a linked list of pre-existing stubs; instead each IC will have one stub
hanging off of it and we always regenerate that one stub from scratch. That one stub contains
either a BinarySwitch or a branch cascade to select one of the AccessCases. Each AccessCase is
an object that describes everything we need to regenerate it in the future. This means that
when we add a new case to an IC stub, we can figure out which previous cases this one subsumes.

Poor scalability when there are many cases: Previously, the cases of a polymorphic inline cache
formed a linked list of branches. This meant that the complexity of an inline cache grew
linearly with the number of cases. This change turns this into a BinarySwitch in most cases,
leading to logarithmic scaling.

Duplicate code between get, put, and in: The code for op_get_by_id, op_put_by_id, and op_in
inline caches grew independently and ended up having a lot of duplicate code. We had the worst
kinds of duplicate code. In some cases, the code was copy-pasted. In other cases, we wrote code
that felt like it was new despite the fact that it was logically identical to code that was
already written elsewhere. The main sources of duplication were in selecting a scratch
register, checking all of the ObjectPropertyConditions and the base structure, the pro forma
involved in generating a stub, and the data structures needed to describe all of the access
cases. This change deduplicates all of that code. Now, all of those ICs use the same classes:
the PolymorphicAccess and AccessCase. There is code in those classes that handles all of the
common things, and for the most part the only code that actually specializes for the kind of
access is in some switch statement in AccessCase::generate().

Special-casing of array length and string length: Previously, array.length and string.length
were handled in an ad hoc manner in the get_by_id repatching code. The handling was separate
from the polymorphic get_by_id handling, which meant that we could not handle polymorphic
length accesses if one of the length cases was either array or string length. For example, if
you had "o.length" where the length was either array length or a vanilla length property, then
the get_by_id inline cache would either emit a monomorphic stub for array length, or a
monomorphic stub for the vanilla length property, but never a polymorphic stub (or list) that
could do both. This change addresses this problem by folding array length and string length
into the polymorphic get_by_id code.

This was meant to be a perf-neutral change to enable property type inference, but it ended up
being a 1% Octane speed-up, mainly because of a 14% speed-up in raytrace. This isn't too
surprising, since that test does use inline caches a lot and this change makes inline caches
more scalable.

This also fixes and adds a test for a BinarySwitch bug. BinarySwitch had an optimization for
consecutive integer cases. Using it on typed array structures triggers this bug. It's a hard
bug to trigger any other way because our other switch optimizations will usually use a jump
table in case of consecutive integers.

(JSC::MacroAssemblerCodePtr::dumpWithName):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::printPutByIdCacheStatus):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::getByValInfoMap):
(JSC::CodeBlock::addStubInfo):
(JSC::CodeBlock::findStubInfo):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::stubInfoBegin):
(JSC::CodeBlock::stubInfoEnd):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback):

  • bytecode/PolymorphicAccess.cpp: Copied from Source/JavaScriptCore/bytecode/PolymorphicGetByIdList.cpp.

(JSC::AccessGenerationState::addWatchpoint):
(JSC::AccessGenerationState::restoreScratch):
(JSC::AccessGenerationState::succeed):
(JSC::AccessCase::AccessCase):
(JSC::AccessCase::get):
(JSC::AccessCase::replace):
(JSC::AccessCase::transition):
(JSC::AccessCase::setter):
(JSC::AccessCase::in):
(JSC::AccessCase::getLength):
(JSC::AccessCase::~AccessCase):
(JSC::AccessCase::fromStructureStubInfo):
(JSC::AccessCase::clone):
(JSC::AccessCase::guardedByStructureCheck):
(JSC::AccessCase::alternateBase):
(JSC::AccessCase::canReplace):
(JSC::AccessCase::dump):
(JSC::AccessCase::visitWeak):
(JSC::AccessCase::generateWithGuard):
(JSC::AccessCase::generate):
(JSC::PolymorphicAccess::PolymorphicAccess):
(JSC::PolymorphicAccess::~PolymorphicAccess):
(JSC::PolymorphicAccess::regenerateWithCases):
(JSC::PolymorphicAccess::regenerateWithCase):
(JSC::PolymorphicAccess::visitWeak):
(JSC::PolymorphicAccess::dump):
(JSC::PolymorphicAccess::regenerate):
(WTF::printInternal):
(JSC::GetByIdAccess::GetByIdAccess): Deleted.
(JSC::GetByIdAccess::~GetByIdAccess): Deleted.
(JSC::GetByIdAccess::fromStructureStubInfo): Deleted.
(JSC::GetByIdAccess::visitWeak): Deleted.
(JSC::PolymorphicGetByIdList::PolymorphicGetByIdList): Deleted.
(JSC::PolymorphicGetByIdList::from): Deleted.
(JSC::PolymorphicGetByIdList::~PolymorphicGetByIdList): Deleted.
(JSC::PolymorphicGetByIdList::currentSlowPathTarget): Deleted.
(JSC::PolymorphicGetByIdList::addAccess): Deleted.
(JSC::PolymorphicGetByIdList::isFull): Deleted.
(JSC::PolymorphicGetByIdList::isAlmostFull): Deleted.
(JSC::PolymorphicGetByIdList::didSelfPatching): Deleted.
(JSC::PolymorphicGetByIdList::visitWeak): Deleted.

  • bytecode/PolymorphicAccess.h: Copied from Source/JavaScriptCore/bytecode/PolymorphicGetByIdList.h.

(JSC::AccessCase::isGet):
(JSC::AccessCase::isPut):
(JSC::AccessCase::isIn):
(JSC::AccessCase::type):
(JSC::AccessCase::offset):
(JSC::AccessCase::viaProxy):
(JSC::AccessCase::structure):
(JSC::AccessCase::newStructure):
(JSC::AccessCase::conditionSet):
(JSC::AccessCase::additionalSet):
(JSC::AccessCase::customSlotBase):
(JSC::AccessCase::doesCalls):
(JSC::AccessCase::callLinkInfo):
(JSC::AccessCase::RareData::RareData):
(JSC::PolymorphicAccess::isEmpty):
(JSC::PolymorphicAccess::size):
(JSC::PolymorphicAccess::at):
(JSC::PolymorphicAccess::operator[]):
(JSC::GetByIdAccess::GetByIdAccess): Deleted.
(JSC::GetByIdAccess::isSet): Deleted.
(JSC::GetByIdAccess::operator!): Deleted.
(JSC::GetByIdAccess::type): Deleted.
(JSC::GetByIdAccess::structure): Deleted.
(JSC::GetByIdAccess::conditionSet): Deleted.
(JSC::GetByIdAccess::stubRoutine): Deleted.
(JSC::GetByIdAccess::doesCalls): Deleted.
(JSC::PolymorphicGetByIdList::isEmpty): Deleted.
(JSC::PolymorphicGetByIdList::size): Deleted.
(JSC::PolymorphicGetByIdList::at): Deleted.
(JSC::PolymorphicGetByIdList::operator[]): Deleted.

  • bytecode/PolymorphicAccessStructureList.h: Removed.
  • bytecode/PolymorphicGetByIdList.cpp: Removed.
  • bytecode/PolymorphicGetByIdList.h: Removed.
  • bytecode/PolymorphicPutByIdList.cpp: Removed.
  • bytecode/PolymorphicPutByIdList.h: Removed.
  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeForStubInfo):

  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::addAccessCase):
(JSC::StructureStubInfo::reset):
(JSC::StructureStubInfo::visitWeakReferences):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::StructureStubInfo):
(JSC::StructureStubInfo::initGetByIdSelf):
(JSC::StructureStubInfo::initPutByIdReplace):
(JSC::StructureStubInfo::initStub):
(JSC::StructureStubInfo::setSeen):
(JSC::getStructureStubInfoCodeOrigin):
(JSC::isGetByIdAccess): Deleted.
(JSC::isPutByIdAccess): Deleted.
(JSC::isInAccess): Deleted.
(JSC::StructureStubInfo::initGetByIdList): Deleted.
(JSC::StructureStubInfo::initPutByIdTransition): Deleted.
(JSC::StructureStubInfo::initPutByIdList): Deleted.
(JSC::StructureStubInfo::initInList): Deleted.
(JSC::StructureStubInfo::addWatchpoint): Deleted.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIn):

  • ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

  • jit/AccessorCallJITStubRoutine.cpp: Removed.
  • jit/AccessorCallJITStubRoutine.h: Removed.
  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::branchIfEmpty):
(JSC::AssemblyHelpers::branchStructure):
(JSC::AssemblyHelpers::boxBooleanPayload):
(JSC::AssemblyHelpers::boxBoolean):
(JSC::AssemblyHelpers::boxInt32):

  • jit/BinarySwitch.cpp:

(JSC::BinarySwitch::BinarySwitch):
(JSC::BinarySwitch::build):
(JSC::BinarySwitch::Case::dump):
(JSC::BinarySwitch::BranchCode::dump):

  • jit/BinarySwitch.h:

(JSC::BinarySwitch::Case::operator<):
(JSC::BinarySwitch::BranchCode::BranchCode):

  • jit/JIT.h:
  • jit/JITInlineCacheGenerator.cpp:

(JSC::garbageStubInfo):
(JSC::JITInlineCacheGenerator::JITInlineCacheGenerator):
(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):

  • jit/JITInlineCacheGenerator.h:

(JSC::JITInlineCacheGenerator::JITInlineCacheGenerator):
(JSC::JITInlineCacheGenerator::stubInfo):
(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITByIdGenerator::reportSlowPathCall):

  • jit/JITOperations.cpp:
  • jit/Repatch.cpp:

(JSC::repatchCall):
(JSC::repatchByIdSelfAccess):
(JSC::resetGetByIDCheckAndLoad):
(JSC::resetPutByIDCheckAndLoad):
(JSC::replaceWithJump):
(JSC::tryCacheGetByID):
(JSC::repatchGetByID):
(JSC::appropriateGenericPutByIdFunction):
(JSC::appropriateOptimizingPutByIdFunction):
(JSC::tryCachePutByID):
(JSC::repatchPutByID):
(JSC::tryRepatchIn):
(JSC::repatchIn):
(JSC::resetGetByID):
(JSC::resetPutByID):
(JSC::checkObjectPropertyCondition): Deleted.
(JSC::checkObjectPropertyConditions): Deleted.
(JSC::emitRestoreScratch): Deleted.
(JSC::linkRestoreScratch): Deleted.
(JSC::toString): Deleted.
(JSC::kindFor): Deleted.
(JSC::customFor): Deleted.
(JSC::generateByIdStub): Deleted.
(JSC::patchJumpToGetByIdStub): Deleted.
(JSC::tryBuildGetByIDList): Deleted.
(JSC::buildGetByIDList): Deleted.
(JSC::appropriateListBuildingPutByIdFunction): Deleted.
(JSC::emitPutReplaceStub): Deleted.
(JSC::emitPutTransitionStub): Deleted.
(JSC::tryBuildPutByIdList): Deleted.
(JSC::buildPutByIdList): Deleted.

  • jit/ScratchRegisterAllocator.cpp:

(JSC::ScratchRegisterAllocator::lock):
(JSC::ScratchRegisterAllocator::allocateScratch):

  • jit/ScratchRegisterAllocator.h:

(JSC::ScratchRegisterAllocator::ScratchRegisterAllocator):

  • jsc.cpp:

(GlobalObject::finishCreation):
(functionQuit):
(functionAbort):
(functionFalse1):
(functionFalse2):

  • runtime/Options.h:
  • tests/stress/array-message-passing.js: Added.

(window.addEventListener):
(window.postMessage):
(window._handleEvents):
(testPassed):
(testFailed):
(classCompare):
(bufferCompare):
(viewCompare):
(typedArrayCompare):
(dataViewCompare):
(dataViewCompare2):
(dataViewCompare3):
(createBuffer):
(createTypedArray):
(createTypedArrayOverBuffer):
(new.DataView):
(testList.testList.concat.basicBufferTypes.map):
(doneTest):

Source/WTF:

Beef up dumping a bit.

  • wtf/PrintStream.h:

(WTF::pointerDump):
(WTF::printInternal):

12:36 PM Changeset in webkit [189585] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

CodeBlock::codeType() doesn't need to compute anything
​https://bugs.webkit.org/show_bug.cgi?id=149039

Reviewed by Michael Saboff.

CodeBlock already has an m_codeType data member.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::codeType):
(JSC::CodeBlock::putByIdContext):

12:34 PM Changeset in webkit [189584] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk/Source/JavaScriptCore

Implement global variables in WebAssembly
​https://bugs.webkit.org/show_bug.cgi?id=149031

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-10
Reviewed by Geoffrey Garen.

This patch implements global variables in WebAssembly. There are two
types of global variables in the current format that we use (the format
used by <​https://github.com/WebAssembly/polyfill-prototype-1>): internal
global variables and imported global variables. This patch does not yet
import values for imported global variables. It will be done in a
subsequent patch.

  • tests/stress/wasm-globals.js: Added.

(shouldBe):

  • tests/stress/wasm/globals.wasm: Added.
  • wasm/JSWASMModule.h:

(JSC::JSWASMModule::globalVariables):

  • wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::buildSetGlobal):
(JSC::WASMFunctionCompiler::buildGetGlobal):

  • wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseStatement):
(JSC::WASMFunctionParser::parseSetGlobalStatement):
(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseGetGlobalExpressionI32):
(JSC::WASMFunctionParser::parseExpressionF64):
(JSC::WASMFunctionParser::parseGetGlobalExpressionF64):

  • wasm/WASMFunctionParser.h:
  • wasm/WASMFunctionSyntaxChecker.h:

(JSC::WASMFunctionSyntaxChecker::buildSetGlobal):
(JSC::WASMFunctionSyntaxChecker::buildGetGlobal):

  • wasm/WASMModuleParser.cpp:

(JSC::WASMModuleParser::parseGlobalSection):

12:19 PM Changeset in webkit [189583] by Yusuke Suzuki
  • 3 edits in trunk/Source/JavaScriptCore

Consider long module path name case in Windows
​https://bugs.webkit.org/show_bug.cgi?id=148917

Reviewed by Alex Christensen.

The local file system module loader in the JSC shell manages the module files by the absolute path.
However, in Windows, _MAX_PATH is defined as 260. So if the path like the current working directory or the path to the module is long,
it will be truncated by the API and it fail to open the file.
In JSC tests in Apple Windows buildbot, since the current working directory is long enough, the tests failed.

This patch introduces the following 3 tweaks.

  1. When retrieving the current working path, we use GetCurrentDirectoryW instead of _getcwd. GetCurrentDirectoryW allows the long path while _getcwd automatically truncate the result by the _MAX_PATH.
  1. Before opening the module file, we prepend "
    ?\" to the path. It converts the local file path to the long UNC path which allows longer path names.
  1. Since Windows ASCII API accepts the characters in the current code page, we use the Unicode APIs like _wfopen instead.

And enable the once disabled module tests in Windows.

Since this functionality is the part of the JSC shell to run the module tests, it is now implemented in jsc.cpp.

  • jsc.cpp:

(stringFromUTF):
(jscSource):
(extractDirectoryName):
(currentWorkingDirectory):
(convertShebangToJSComment):
(fillBufferWithContentsOfFile):
(fetchScriptFromLocalFileSystem):
(fetchModuleFromLocalFileSystem):
(GlobalObject::moduleLoaderFetch):
(functionRun):
(functionLoad):
(functionReadFile):
(functionCheckSyntax):
(functionLoadModule):
(runWithScripts):
(runInteractive):

  • tests/modules.yaml:
12:01 PM Changeset in webkit [189582] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Source/JavaScriptCore

Convert arguments to WebAssembly functions to the declared types
​https://bugs.webkit.org/show_bug.cgi?id=149033

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-10
Reviewed by Geoffrey Garen.

This patch checks the types of arguments to WebAssembly functions and
converts them to the declared types. This is necessary because:

  • For example, if a function expects an argument of type double and we pass 1.0 to it, it will get a JSValue of an integer, not a double.
  • We should follow asm.js's behavior for now, because we want to be able to test WebAssembly apps against asm.js apps. asm.js does type coercion on arguments by using int|0, Math.fround(float), and +double.
  • jit/JITOperations.h:
  • tests/stress/wasm-type-conversion.js: Added.

(shouldBe):
(two.valueOf):

  • tests/stress/wasm/type-conversion.wasm: Added.
  • wasm/WASMFunctionCompiler.h:

(JSC::operationConvertJSValueToInt32):
(JSC::operationConvertJSValueToDouble):
(JSC::WASMFunctionCompiler::startFunction):
(JSC::WASMFunctionCompiler::appendCallSetResult):
(JSC::WASMFunctionCompiler::callOperation):
(JSC::WASMFunctionCompiler::loadValueAndConvertToInt32):
(JSC::WASMFunctionCompiler::loadValueAndConvertToDouble):

11:57 AM Changeset in webkit [189581] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WebGL][GLES] bad shaders should not be linked not only for GL but also for GL ES
​https://bugs.webkit.org/show_bug.cgi?id=148794

Patch by Jinyoung Hur <​hur.ims@navercorp.com> on 2015-09-10
Reviewed by Dean Jackson.

Checking bad shaders, precision matching and varyings packing are all valid for GL ES too.

Test: webgl/1.0.2/conformance/programs/program-test.html

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::linkProgram):

11:47 AM Changeset in webkit [189580] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Static variables in GraphicsContext3DOpenGLCommon should be avoided because of the race condition
​https://bugs.webkit.org/show_bug.cgi?id=148957

Patch by Jinyoung Hur <​hur.ims@navercorp.com> on 2015-09-10
Reviewed by Dean Jackson.

There is no guarantee that only one thread calls GraphicsContext3D::compileShader() at a time so it would be
better to use a thread local storage variable rather than use a static variable.

No new tests. No behavioural changes.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::getCurrentNameHashMapForShader):
(WebCore::setCurrentNameHashMapForShader):
(WebCore::nameHashForShader):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::mappedSymbolName):

11:15 AM Changeset in webkit [189579] by Dewei Zhu
  • 2 edits in trunk/LayoutTests

Update windows platform expected results for bug 148810.
​https://bugs.webkit.org/show_bug.cgi?id=149038

Reviewed by Alexey Proskuryakov.

  • platform/win/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt: Updated.
11:08 AM Changeset in webkit [189578] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r189572.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorTestPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):
Remove the const on the now static methods.

11:04 AM Changeset in webkit [189577] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

JSInternalPromiseDeferred should inherit JSPromiseDeferred
​https://bugs.webkit.org/show_bug.cgi?id=149027

Reviewed by Darin Adler.

JSInternalPromiseDeferred is constructed by using JSPromiseDeferred implementation.
So the class info of JSInternalPromiseDeferred should inherit JSPromiseDeferred.

  • runtime/JSInternalPromiseDeferred.cpp:
11:02 AM Changeset in webkit [189576] by Chris Dumez
  • 131 edits in trunk

Node.appendChild(null) / replaceChild(null, null) / removeChild(null) / insertBefore(null, ref) should throw a TypeError
​https://bugs.webkit.org/show_bug.cgi?id=148971
<rdar://problem/22560883>
<rdar://problem/22559225>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C tests now that more checks are passing.

  • web-platform-tests/dom/interfaces-expected.txt:
  • web-platform-tests/dom/nodes/Node-appendChild-expected.txt:
  • web-platform-tests/dom/nodes/Node-insertBefore-expected.txt:
  • web-platform-tests/dom/nodes/Node-removeChild-expected.txt:
  • web-platform-tests/dom/nodes/Node-replaceChild-expected.txt:
  • web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Node.appendChild(null) / replaceChild(null, null) / removeChild(null)
and insertBefore(null, ref) should throw a TypeError instead of a
NotFoundError, as per the specification:
​https://dom.spec.whatwg.org/#node

The parameters are not nullable so the Web IDL specification says
we should throw a TypeError in this case.

This patch moves the null-checking from ContainerNode to the methods
on Node. The null-checking is supposed to be done by the bindings code
but our generator currently does not support this so we do the null
checking as close to the bindings as possible. The bindings code is
calling the methods on Node. This also makes sure we throw a TypeError
for null-argument when the Node is not a ContainerNode. For e.g.
Text.appendChild(null) should throw a TypeError too.

The methods on ContainerNode now take references insteaad of pointer
parameters now that the null-checking is done at the call site in
Node. This lead to a lot of code update as those methods are used
a lot throughout the code base.

No new tests, already covered by pre-existing layout tests.

Source/WebKit/mac:

ContainerNode::appendChild() now takes a Ref<Node>&& parameter so we
need to update the call site.

  • WebView/WebFrame.mm:

(-[WebFrame _documentFragmentWithNodesAsParagraphs:]):

Source/WebKit2:

ContainerNode::appendChild() now takes a Ref<Node>&& parameter so we
need to update the call sites.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::PDFPlugin):

  • WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:

(WebKit::PDFPluginAnnotation::attach):
(WebKit::PDFPluginAnnotation::~PDFPluginAnnotation):

  • WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:

(WebKit::PDFPluginChoiceAnnotation::createAnnotationElement):

LayoutTests:

Update / rebaseline tests now that we throw a different exception type.

  • fast/dom/Document/replaceChild-null-oldChild-expected.txt:
  • fast/dom/Document/script-tests/replaceChild-null-oldChild.js:
  • fast/dom/Node/fragment-mutation-expected.txt:
  • fast/dom/Node/fragment-mutation.html:
  • fast/dom/incompatible-operations-expected.txt:
  • fast/dom/incompatible-operations.html:
  • fast/dom/move-nodes-across-documents.html:
  • fast/dom/processing-instruction-appendChild-exceptions-expected.txt:
  • fast/dom/processing-instruction-appendChild-exceptions.xhtml:
  • fast/dom/setter-type-enforcement-expected.txt:
  • fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt:
  • fast/inspector-support/uncaught-dom8-exception.html:
10:47 AM Changeset in webkit [189575] by msaboff@apple.com
  • 58 edits
    4 adds
    4 deletes in trunk/Source/JavaScriptCore

Add support for Callee-Saves registers
​https://bugs.webkit.org/show_bug.cgi?id=148666

Reviewed by Filip Pizlo.

We save platform callee save registers right below the call frame header,
in the location(s) starting with VirtualRegister 0. This local space is
allocated in the bytecode compiler. This space is the maximum space
needed for the callee registers that the LLInt and baseline JIT use,
rounded up to a stack aligned number of VirtualRegisters.
The LLInt explicitly saves and restores the registers in the macros
preserveCalleeSavesUsedByLLInt and restoreCalleeSavesUsedByLLInt.
The JITs saves and restores callee saves registers by what registers
are included in m_calleeSaveRegisters in the code block.

Added handling of callee save register restoration to exception handling.
The basic flow is when an exception is thrown or one is recognized to
have been generated in C++ code, we save the current state of all
callee save registers to VM::calleeSaveRegistersBuffer. As we unwind
looking for the corresponding catch, we copy the callee saves from call
frames to the same VM::calleeSaveRegistersBuffer. This is done for all
call frames on the stack up to but not including the call frame that has
the corresponding catch block. When we process the catch, we restore
the callee save registers with the contents of VM::calleeSaveRegistersBuffer.
If there isn't a catch, then handleUncaughtException will restore callee
saves before it returns back to the calling C++.

Eliminated callee saves registers as free registers for various thunk
generators as the callee saves may not have been saved by the function
calling the thunk.

Added code to transition callee saves from one VM's format to the another
as part of OSR entry and OSR exit.

Cleaned up the static RegisterSet's including adding one for LLInt and
baseline JIT callee saves and one to be used to allocate local registers
not including the callee saves or other special registers.

Moved ftl/FTLRegisterAtOffset.{cpp,h} to jit/RegisterAtOffset.{cpp,h}.
Factored out the vector of RegisterAtOffsets in ftl/FTLUnwindInfo.{cpp,h}
into a new class in jit/RegisterAtOffsetList.{cpp,h}.
Eliminted UnwindInfo and changed UnwindInfo::parse() into a standalone
function named parseUnwindInfo. That standalone function now returns
the callee saves RegisterAtOffsetList. This is stored in the CodeBlock
and used instead of UnwindInfo.

Turned off register preservation thunks for outgoing calls from FTL
generated code. THey'll be removed in a subsequent patch.

Changed specialized thinks to save and restore the contents of
tagTypeNumberRegister and tagMaskRegister as they can be called by FTL
compiled functions. We materialize those tag registers for the thunk's
use and then restore the prior contents on function exit.

Also removed the arity check fail return thunk since it is now the
caller's responsibility to restore the stack pointer.

Removed saving of callee save registers and materialization of special
tag registers for 64 bit platforms from vmEntryToJavaScript and
vmEntryToNative.

  • CMakeLists.txt:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • ftl/FTLJITCode.h:
  • ftl/FTLRegisterAtOffset.cpp: Removed.
  • ftl/FTLRegisterAtOffset.h: Removed.
  • ftl/FTLUnwindInfo.cpp:

(JSC::FTL::parseUnwindInfo):
(JSC::FTL::UnwindInfo::UnwindInfo): Deleted.
(JSC::FTL::UnwindInfo::~UnwindInfo): Deleted.
(JSC::FTL::UnwindInfo::parse): Deleted.
(JSC::FTL::UnwindInfo::dump): Deleted.
(JSC::FTL::UnwindInfo::find): Deleted.
(JSC::FTL::UnwindInfo::indexOf): Deleted.

  • ftl/FTLUnwindInfo.h:

(JSC::RegisterAtOffset::dump):

  • jit/RegisterAtOffset.cpp: Added.
  • jit/RegisterAtOffset.h: Added.

(JSC::RegisterAtOffset::RegisterAtOffset):
(JSC::RegisterAtOffset::operator!):
(JSC::RegisterAtOffset::reg):
(JSC::RegisterAtOffset::offset):
(JSC::RegisterAtOffset::offsetAsIndex):
(JSC::RegisterAtOffset::operator==):
(JSC::RegisterAtOffset::operator<):
(JSC::RegisterAtOffset::getReg):

  • jit/RegisterAtOffsetList.cpp: Added.

(JSC::RegisterAtOffsetList::RegisterAtOffsetList):
(JSC::RegisterAtOffsetList::sort):
(JSC::RegisterAtOffsetList::dump):
(JSC::RegisterAtOffsetList::find):
(JSC::RegisterAtOffsetList::indexOf):

  • jit/RegisterAtOffsetList.h: Added.

(JSC::RegisterAtOffsetList::clear):
(JSC::RegisterAtOffsetList::size):
(JSC::RegisterAtOffsetList::at):
(JSC::RegisterAtOffsetList::append):
Move and refactored use of FTLRegisterAtOffset to RegisterAtOffset.
Added RegisterAtOffset and RegisterAtOffsetList to build configurations.
Remove FTLRegisterAtOffset files.

  • bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::setUpCallFromFTL):
Turned off FTL register preservation thunks.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::setCalleeSaveRegisters):
(JSC::roundCalleeSaveSpaceAsVirtualRegisters):
(JSC::CodeBlock::llintBaselineCalleeSaveSpaceAsVirtualRegisters):
(JSC::CodeBlock::calleeSaveSpaceAsVirtualRegisters):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::numberOfLLIntBaselineCalleeSaveRegisters):
(JSC::CodeBlock::calleeSaveRegisters):
(JSC::CodeBlock::llintBaselineCalleeSaveSpaceAsVirtualRegisters):
(JSC::CodeBlock::optimizeAfterWarmUp):
(JSC::CodeBlock::numberOfDFGCompiles):
Methods to manage a set of callee save registers. Also to allocate the appropriate
number of VirtualRegisters for callee saves.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::allocateCalleeSaveSpace):

  • bytecompiler/BytecodeGenerator.h:

Allocate the appropriate number of VirtualRegisters for callee saves needed by LLInt or baseline JIT.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileSetupRegistersForEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::compileExceptionHandlers):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler.h:
  • interpreter/Interpreter.cpp:

(JSC::UnwindFunctor::operator()):
(JSC::UnwindFunctor::copyCalleeSavesToVMCalleeSavesBuffer):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::usedRegisters):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):

  • ftl/FTLCompile.cpp:

(JSC::FTL::fixFunctionBasedOnStackMaps):
(JSC::FTL::compile):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • ftl/FTLThunks.cpp:

(JSC::FTL::osrExitGenerationThunkGenerator):

  • jit/ArityCheckFailReturnThunks.cpp: Removed.
  • jit/ArityCheckFailReturnThunks.h: Removed.
  • jit/JIT.cpp:

(JSC::JIT::emitEnterOptimizationCheck):
(JSC::JIT::privateCompile):
(JSC::JIT::privateCompileExceptionHandlers):

  • jit/JITCall32_64.cpp:

(JSC::JIT::emit_op_ret):

  • jit/JITExceptions.cpp:

(JSC::genericUnwind):

  • jit/JITExceptions.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_enter):
(JSC::JIT::emitSlow_op_loop_hint):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_catch):

  • jit/JITOperations.cpp:
  • jit/Repatch.cpp:

(JSC::generateByIdStub):

  • jit/ThunkGenerators.cpp:
  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:

(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::arityFixupGenerator):

  • runtime/CommonSlowPaths.cpp:

(JSC::setupArityCheckData):

  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):
Emit code to save and restore callee save registers and materialize tagTypeNumberRegister
and tagMaskRegister.
Handle callee saves when tiering up.
Copy callee saves register contents to VM::calleeSaveRegistersBuffer at beginning of
exception processing.
Process callee save registers in frames when unwinding from an exception.
Restore callee saves register contents from VM::calleeSaveRegistersBuffer on catch.
Use appropriate register set to make sure we don't allocate a callee save register when
compiling a thunk.
Helper to populate tagTypeNumberRegister and tagMaskRegister with the appropriate
constants.
Removed arity fixup return thunks.

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):
Restore callee saves from the DFG and save the appropriate ones for the baseline JIT.
Materialize the tag registers on 64 bit platforms.

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitSaveCalleeSavesFor):
(JSC::AssemblyHelpers::emitRestoreCalleeSavesFor):
(JSC::AssemblyHelpers::emitSaveCalleeSaves):
(JSC::AssemblyHelpers::emitRestoreCalleeSaves):
(JSC::AssemblyHelpers::copyCalleeSavesToVMCalleeSavesBuffer):
(JSC::AssemblyHelpers::restoreCalleeSavesFromVMCalleeSavesBuffer):
(JSC::AssemblyHelpers::copyCalleeSavesFromFrameOrRegisterToVMCalleeSavesBuffer):
(JSC::AssemblyHelpers::emitMaterializeTagCheckRegisters):
New helpers to save and restore callee saves as well as materialize the tag registers
contents.

  • jit/FPRInfo.h:
  • jit/GPRInfo.h:

(JSC::GPRInfo::toRegister):
Updated to include FP callee save registers. Added number of callee saves registers and
cleanup register aliases that collide with callee save registers.

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
Uses new stubUnavailableRegisters register set to limit what registers are available for
temporaries.

  • jit/RegisterSet.cpp:

(JSC::RegisterSet::stubUnavailableRegisters):
(JSC::RegisterSet::calleeSaveRegisters):
(JSC::RegisterSet::llintBaselineCalleeSaveRegisters):
(JSC::RegisterSet::dfgCalleeSaveRegisters):
(JSC::RegisterSet::ftlCalleeSaveRegisters):

  • jit/RegisterSet.h:

New register sets with the callee saves used by various tiers as well as one listing registers
not availble to stub code.

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::loadDoubleArgument):
(JSC::SpecializedThunkJIT::returnJSValue):
(JSC::SpecializedThunkJIT::returnDouble):
(JSC::SpecializedThunkJIT::returnInt32):
(JSC::SpecializedThunkJIT::returnJSCell):
(JSC::SpecializedThunkJIT::callDoubleToDoublePreservingReturn):
(JSC::SpecializedThunkJIT::emitSaveThenMaterializeTagRegisters):
(JSC::SpecializedThunkJIT::emitRestoreSavedTagRegisters):
(JSC::SpecializedThunkJIT::tagReturnAsInt32):

  • jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):
Changed to save and restore existing tag register contents as the may contain other values.
After saving the existing values, we materialize the tag constants.

  • jit/TempRegisterSet.h:

(JSC::TempRegisterSet::getFPRByIndex):
(JSC::TempRegisterSet::getFreeFPR):
(JSC::TempRegisterSet::setByIndex):

  • offlineasm/arm64.rb:
  • offlineasm/registers.rb:

Added methods for floating point registers to support callee save FP registers.

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_mod):
Removed unnecessary #if CPU(X86_64) check to this 32 bit only file.

  • offlineasm/x86.rb:

Fixed Windows callee saves naming.

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

(JSC::VM::calleeSaveRegistersBufferOffset):
(JSC::VM::getAllCalleeSaveRegistersMap):
Provide a RegisterSaveMap that has all registers that might be saved. Added a callee save buffer to be
used for OSR exit and for exception processing in a future patch.

10:31 AM Changeset in webkit [189574] by ap@apple.com
  • 2 edits in branches/safari-601-branch/LayoutTests

Test result gardening.

  • platform/mac/TestExpectations:
10:30 AM Changeset in webkit [189573] by aestes@apple.com
  • 3 edits in trunk/Tools

[iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
​https://bugs.webkit.org/show_bug.cgi?id=149022

Reviewed by Daniel Bates.

Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
did not account for this.

  • Scripts/webkitpy/xcode/simulator.py:

(Simulator): Optionally matched a revision at the end of a runtime version number.

  • Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
10:27 AM Changeset in webkit [189572] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

Web Inspector: Make WebInspectorProxy inspectorURL path methods static
​https://bugs.webkit.org/show_bug.cgi?id=149021

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-10
Reviewed by Brian Burg.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::didRelaunchInspectorPageProcess):
(WebKit::isMainOrTestInspectorPage):
(WebKit::decidePolicyForNavigationAction):
(WebKit::WebInspectorProxy::eagerlyCreateInspectorPage):
(WebKit::WebInspectorProxy::createInspectorPage):

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorTestPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorTestPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorTestPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):

10:11 AM Changeset in webkit [189571] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

ModuleProgramExecutable should provide CodeBlock to ScriptExecutable::forEachCodeBlock
​https://bugs.webkit.org/show_bug.cgi?id=149028

Reviewed by Michael Saboff.

ModuleProgramExecutable should provide CodeBlock since ModuleProgramExecutable inherits
ScriptExecutable.

  • bytecode/CodeBlock.h:

(JSC::ScriptExecutable::forEachCodeBlock):

10:08 AM Changeset in webkit [189570] by aestes@apple.com
  • 3 edits in trunk/Tools

[iOS] Teach run-webkit-tests how to parse simctl list when a tvOS SDK is installed
​https://bugs.webkit.org/show_bug.cgi?id=149029
<rdar://problem/22432624>

Reviewed by Daniel Bates.

  • Scripts/webkitpy/xcode/simulator.py:

(Simulator): Taught to parse tvOS runtimes.

  • Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
9:26 AM Changeset in webkit [189569] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Mark some more W3C IDB tests as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=148713

Reviewed by NOBODY.

  • platform/wk2/TestExpectations:
8:50 AM Changeset in webkit [189568] by dbates@webkit.org
  • 5 edits
    2 adds in trunk

Write a test to ensure we don't regress processing of tasks when page defers loading
​https://bugs.webkit.org/show_bug.cgi?id=135882
<rdar://problem/22550497>

Reviewed by Darin Adler.

Source/WebCore:

Towards adding a test for <​https://bugs.webkit.org/show_bug.cgi?id=135688>, add a window.internals
function, setPageDefersLoading, to enable and disable whether the page defers loading.

Test: storage/websql/success-callback-when-page-defers-loading.html

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState): Reset defers loading for the page to false.
(WebCore::Internals::setPageDefersLoading): Added.

  • testing/Internals.h:
  • testing/Internals.idl: Added IDL declaration setPageDefersLoading.

LayoutTests:

Add a test to ensure we do not regress <​https://bugs.webkit.org/show_bug.cgi?id=135688>.

  • storage/websql/success-callback-when-page-defers-loading-expected.txt: Added.
  • storage/websql/success-callback-when-page-defers-loading.html: Added.
8:00 AM WebKitGTK/2.10.x edited by Michael Catanzaro
Change some bug links to trac links (diff)
4:58 AM Changeset in webkit [189567] by svillar@igalia.com
  • 29 edits
    2 adds in trunk

min-width/height should default to auto for flexbox items
​https://bugs.webkit.org/show_bug.cgi?id=146020

Reviewed by David Hyatt.

Based on Blink's r193665, r194062, r194887 and r195930 by <​cbiesinger@chromium.org>.

Source/WebCore:

As specified here
​http://dev.w3.org/csswg/css-flexbox/#min-size-auto the default
value of min-{width|height} is auto for flex items.

In case this patch breaks any website (as it's changing the
default value of those properties) the fix is likely to add:

min-width: 0;
min-height: 0;

to any relevant flexitems.

Test: css3/flexbox/min-size-auto.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::isFlexOrGrid): New helper method to identify grids and flexs.
(WebCore::ComputedStyleExtractor::propertyValue): Return auto
for flex items if min-width/height is auto.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • html/shadow/SliderThumbElement.cpp:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::constrainLogicalHeightByMinMax):
(WebCore::RenderBox::constrainContentBoxLogicalHeightByMinMax):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computeContentLogicalHeight):
(WebCore::RenderBox::computeContentAndScrollbarLogicalHeightUsing):
(WebCore::RenderBox::computeReplacedLogicalWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):

  • rendering/RenderBox.h:
  • rendering/RenderButton.h:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
(WebCore::RenderFlexibleBox::mainAxisExtentIsDefinite):
(WebCore::RenderFlexibleBox::mainAxisLengthIsIndefinite):
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
(WebCore::RenderFlexibleBox::mainAxisOverflowForChild):

  • rendering/RenderFlexibleBox.h:

(WebCore::RenderFlexibleBox::isFlexibleBoxImpl):

  • rendering/RenderFullScreen.h:
  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeUsedBreadthOfSpecifiedLength):

  • rendering/RenderMediaControlElements.h:
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::adjustInnerStyle): Do not longer set
the min-width explicitly.

  • rendering/RenderMenuList.h:
  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::calculateMaxColumnHeight):

  • rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::maxPageLogicalHeight):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):

  • rendering/RenderSlider.h:
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::createInnerBlockStyle): Do not longer set
the min-width explicitly.

  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/style/RenderStyle.h:

LayoutTests:

  • TestExpectations: Removed passing flexbox tests.
  • css3/flexbox/csswg/flex-flow-007.html: Added min-height: 0px.
  • css3/flexbox/flexbox-baseline.html: Ditto.
  • css3/flexbox/min-size-auto-expected.txt: Added.
  • css3/flexbox/min-size-auto.html: Added.
  • css3/flexbox/preferred-widths-orthogonal.html: Added min-height: 0px.
  • fast/css/auto-min-size-expected.txt: Check default computed

styles for min-width/height for flex items.

  • fast/css/auto-min-size.html: Ditto.
2:10 AM Changeset in webkit [189566] by ChangSeok Oh
  • 4 edits in trunk

[GTK] Volume bar is broken
​https://bugs.webkit.org/show_bug.cgi?id=145639

Reviewed by Philippe Normand.

Source/WebCore:

The ControlPart enum values' order has mismatched the one of values in CSSValueKeywords.in
after r180965. The MediaVolumeSliderPart should be prior to the MediaVolumeSliderContainerpart.

Tests: media/click-volume-bar-not-pausing.html

media/volume-bar-empty-when-muted.html

  • platform/ThemeTypes.h:

LayoutTests:

Unblock relevant tests. media/click-volume-bar-not-pausing.html, media/volume-bar-empty-when-muted.html

  • platform/gtk/TestExpectations:

Sep 9, 2015:

7:16 PM Changeset in webkit [189565] by Gyuyoung Kim
  • 27 edits in trunk/Source/WebCore

Remove all uses of PassRefPtr in WebCore/svg
​https://bugs.webkit.org/show_bug.cgi?id=148472

Reviewed by Darin Adler.

Clean up all uses of PassRefPtr in WebCore/svg.

  • Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::addEventListener):

  • Modules/webaudio/AudioScheduledSourceNode.h:
  • Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::addEventListener):

  • Modules/webaudio/ScriptProcessorNode.h:
  • dom/EventListenerMap.cpp:

(WebCore::copyListenersNotCreatedFromMarkupToTarget):

  • dom/EventTarget.cpp:

(WebCore::EventTarget::addEventListener):

  • dom/EventTarget.h:
  • dom/MessagePort.cpp:

(WebCore::MessagePort::addEventListener):

  • dom/MessagePort.h:
  • dom/Node.cpp:

(WebCore::tryAddEventListener):
(WebCore::Node::addEventListener):

  • dom/Node.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::addEventListener):

  • html/HTMLMediaElement.h:
  • html/ImageDocument.cpp:

(WebCore::ImageDocument::createDocumentStructure):

  • html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::showClosedCaptionTrackList):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):

  • page/DOMWindow.h:
  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::addEventListener):

  • svg/SVGElement.h:
  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::pathSegListChanged):

  • svg/SVGPathUtilities.cpp:

(WebCore::appendSVGPathByteStreamFromSVGPathSeg):

  • svg/SVGPathUtilities.h:
  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefTargetEventListener::attach):
(WebCore::SVGTRefElement::buildPendingResource):

  • svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::appendEffectToEffectReferences):

  • svg/graphics/filters/SVGFilterBuilder.h:
7:04 PM Changeset in webkit [189564] by Dewei Zhu
  • 16 edits in trunk

LayoutTests/imported/w3c:
Document.characterSet should return "UTF-8" by default.
​https://bugs.webkit.org/show_bug.cgi?id=148810
<rdar://problem/22548727>

Reviewed by Ryosuke Niwa.

Update the tests which test the default encoding of document.

  • web-platform-tests/dom/interfaces-expected.txt:
  • web-platform-tests/dom/nodes/DOMImplementation-createDocument-expected.txt:
  • web-platform-tests/dom/nodes/Node-properties-expected.txt:
  • web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:
Document.characterSet should return "UTF-8" instead of null by default.
​https://bugs.webkit.org/show_bug.cgi?id=148810
<rdar://problem/22548727>

Reviewed by Ryosuke Niwa.

Document encoding should default to "UTF-8" as is specified in
​https://dom.spec.whatwg.org/#concept-document-encoding. This behavior
is consistent with Firefox and Chrome.

  • dom/Document.cpp:

(WebCore::Document::encoding): Returns nullAtom according to declearation.
(WebCore::Document::characterSetForBindings): Returns "UTF-8" by default instead of null String.

  • dom/Document.h:

(WebCore::Document::charset):
(WebCore::Document::inputEncoding): Deleted.
(WebCore::Document::characterSet): Deleted.

  • dom/Document.idl:
  • dom/InlineStyleSheetOwner.cpp:

(WebCore::InlineStyleSheetOwner::createSheet):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::mainResourceContent):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didFailLoading):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::createDecoderIfNeeded):

  • loader/FormSubmission.cpp:

(WebCore::encodingFromAcceptCharset):

LayoutTests:
Document.characterSet should return "UTF-8" by default.
​https://bugs.webkit.org/show_bug.cgi?id=148810
<rdar://problem/22548727>

Reviewed by Ryosuke Niwa.

Update the tests which test the default encoding of document.

  • dom/xhtml/level3/core/documentgetinputencoding02-expected.txt: Obsolete test.
6:43 PM Changeset in webkit [189563] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/JavaScriptCore

Implement internal calls in WebAssembly
​https://bugs.webkit.org/show_bug.cgi?id=148998

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-09
Reviewed by Filip Pizlo.

This patch implements internal calls to functions that return a 32-bit
integer in WebAssembly.

  • tests/stress/wasm-calls.js: Added.

(shouldBe):

  • tests/stress/wasm/calls.wasm: Added.
  • wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::WASMFunctionCompiler):
(JSC::WASMFunctionCompiler::endFunction):
(JSC::WASMFunctionCompiler::buildCallInternal):
(JSC::WASMFunctionCompiler::appendExpressionList):
(JSC::WASMFunctionCompiler::emitNakedCall):
(JSC::WASMFunctionCompiler::boxArgumentsAndAdjustStackPointer):
(JSC::WASMFunctionCompiler::callAndUnboxResult):

  • wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::compile):
(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseCallInternalExpressionI32):
(JSC::WASMFunctionParser::parseCallArguments):
(JSC::WASMFunctionParser::parseCallInternal):

  • wasm/WASMFunctionParser.h:
  • wasm/WASMFunctionSyntaxChecker.h:

(JSC::WASMFunctionSyntaxChecker::buildCallInternal):
(JSC::WASMFunctionSyntaxChecker::appendExpressionList):

6:38 PM Changeset in webkit [189562] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Web Inspector: Remove dead WebInspectorProxy related code
​https://bugs.webkit.org/show_bug.cgi?id=149019

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-09
Reviewed by Timothy Hatcher.

  • UIProcess/API/C/mac/WKInspectorPrivateMac.h:
  • UIProcess/WebInspectorProxy.cpp:
  • UIProcess/WebInspectorProxy.h:
  • UIProcess/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorProxyObjCAdapter attachRight:]): Deleted.
(-[WKWebInspectorProxyObjCAdapter attachBottom:]): Deleted.

5:27 PM Changeset in webkit [189561] by Chris Dumez
  • 5 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r189522.
​https://bugs.webkit.org/show_bug.cgi?id=149020

"Caused a ~4% Speedometer regression" (Requested by cdumez on
#webkit).

Reverted changeset:

"Function.prototype.bind: Bound functions must use the
Prototype of their target function instead of
Function.prototype"
​https://bugs.webkit.org/show_bug.cgi?id=145605
​http://trac.webkit.org/changeset/189522

Patch by Commit Queue <​commit-queue@webkit.org> on 2015-09-09

4:40 PM Changeset in webkit [189560] by benjamin@webkit.org
  • 3 edits
    6 adds in trunk

CSS general sibling selectors does not work without CSS JIT
​https://bugs.webkit.org/show_bug.cgi?id=148987
rdar://problem/22559860

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-09-09
Reviewed by Andreas Kling.

Source/WebCore:

When traversing with the indirect adjacent combinator, SelectorChecker
was not setting the style invalidation flag on the right element.

Tests: fast/css/indirect-adjacent-style-invalidation-1.html

fast/css/indirect-adjacent-style-invalidation-2.html
fast/css/indirect-adjacent-style-invalidation-3.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively):

LayoutTests:

There are multiple variations of the same tests to test
cases where we JIT and cases without JIT.

  • fast/css/indirect-adjacent-style-invalidation-1-expected.txt: Added.
  • fast/css/indirect-adjacent-style-invalidation-1.html: Added.
  • fast/css/indirect-adjacent-style-invalidation-2-expected.txt: Added.
  • fast/css/indirect-adjacent-style-invalidation-2.html: Added.
  • fast/css/indirect-adjacent-style-invalidation-3-expected.txt: Added.
  • fast/css/indirect-adjacent-style-invalidation-3.html: Added.
4:31 PM Changeset in webkit [189559] by ap@apple.com
  • 3 edits in trunk/Tools

Fix bit rot on bot watcher's dashboard page
​https://bugs.webkit.org/show_bug.cgi?id=149012

Reviewed by Tim Horton.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

The code path used by the metrics page was trying to add properties to an undefined.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:

Silence an expection that would occur when the step has no logs. This should never
happen, but it did (perhaps buildbot was misconfigured for a while).

4:16 PM Changeset in webkit [189558] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Remove unused InspectorFrontendHost methods
​https://bugs.webkit.org/show_bug.cgi?id=149013

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-09
Reviewed by Brian Burg.

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::canSaveAs): Deleted.
(WebCore::InspectorFrontendHost::canInspectWorkers): Deleted.

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
3:42 PM Changeset in webkit [189557] by mmaxfield@apple.com
  • 4 edits
    2 adds in trunk

ASSERTION FAILED: typesettingFeatures & (Kerning | Ligatures) in WebCore::applyFontTransforms
​https://bugs.webkit.org/show_bug.cgi?id=146194

Reviewed by Dean Jackson.

Source/WebCore:

We might trigger shaping even if the author hasn't specified kerning or ligatures.

Test: fast/text/softbank-emoji-no-ligatures-nor-kerning.html

  • platform/graphics/WidthIterator.cpp:

(WebCore::isSoftBankEmoji):
(WebCore::WidthIterator::applyFontTransforms):
(WebCore::WidthIterator::advanceInternal):
(WebCore::applyFontTransforms): Deleted.

  • platform/graphics/WidthIterator.h:

LayoutTests:

  • fast/text/softbank-emoji-no-ligatures-nor-kerning-expected.html: Added
  • fast/text/softbank-emoji-no-ligatures-nor-kerning.html: Added
3:26 PM Changeset in webkit [189556] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2015-09-09 Geoffrey Garen <​ggaren@apple.com>

Fix the no-DFG build.

Unreviewed.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitOSRExitTargets): (JSC::CodeBlock::stronglyVisitStrongReferences):
3:11 PM Changeset in webkit [189555] by Chris Dumez
  • 5 edits in trunk

Setting document.title when there is no title and no head element should no nothing
​https://bugs.webkit.org/show_bug.cgi?id=149005
<rdar://problem/22567524>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline tests now that more checks are passing.

  • web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-01-expected.txt:
  • web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-02-expected.txt:

Source/WebCore:

Setting document.title when there is no title element and no head
element should no nothing:

Firefox and Chrome comply with the specification. However, WebKit
was returning the updated title when querying document.title after
setting it.

No new tests, covered by existing tests.

  • dom/Document.cpp:

(WebCore::Document::setTitle):

3:06 PM Changeset in webkit [189554] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

CodeBlocks should strongly visit their OSR exit targets
​https://bugs.webkit.org/show_bug.cgi?id=148988

Reviewed by Saam Barati.

CodeBlocks jump to their OSR exit targets, so we need to keep them alive
explicitly.

This is a step toward throwing away CodeBlocks, which is only safe
if we keep alive logically in-use CodeBlocks.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::visitStrongly): Added a flag to indicate if visit
strongly had been performed yet, since we are likely to revisit
the same CodeBlock many times now.

(JSC::CodeBlock::visitOSRExitTargets):
(JSC::CodeBlock::stronglyVisitStrongReferences): Do the visiting.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::clearMarks):
(JSC::CodeBlockSet::mark): Added a helper function for clearing out
two flags.

3:00 PM Changeset in webkit [189553] by ggaren@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

2015-09-09 Geoffrey Garen <​ggaren@apple.com>

Unreviewed, rolling back in r189516.
​https://bugs.webkit.org/show_bug.cgi?id=148989

Restored changeset:

"GC should be able to discover new strong CodeBlock references
during marking"
​https://bugs.webkit.org/show_bug.cgi?id=148981
​http://trac.webkit.org/changeset/189516

This patch caused infinite recursion on Windows because of a pre-existing
logical error in the non-parallel GC configuration. Even in non-parallel
GC, we must set the mark bit on a CodeBlock to avoid marking it twice
(or, in the case of our crash, infinitely recursively).

2:35 PM Changeset in webkit [189552] by ap@apple.com
  • 2 edits in trunk/Tools

Update LayoutTestRelay xcconfig file.

Rubber-stamped by Dan Bernstein.

  • LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2:15 PM Changeset in webkit [189551] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Remove an unused NSString SPI constant
​https://bugs.webkit.org/show_bug.cgi?id=149009

Reviewed by Dan Bernstein.

  • UIProcess/API/Cocoa/WKWebView.mm:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
2:11 PM Changeset in webkit [189550] by Manuel Rego Casasnovas
  • 3 edits
    2 adds in trunk

[css-grid] Percentage columns shouldn't include border and padding
​https://bugs.webkit.org/show_bug.cgi?id=148978

Reviewed by Sergio Villar Senin.

Source/WebCore:

Subtract border and padding when we're calculating the breadth of the
columns in LayoutGrid::computeUsedBreadthOfSpecifiedLength().

Added test to check the behavior for both columns and rows.

Test: fast/css-grid-layout/grid-percent-track-margin-border-padding.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeUsedBreadthOfSpecifiedLength):

LayoutTests:

  • fast/css-grid-layout/grid-percent-track-margin-border-padding-expected.txt: Added.
  • fast/css-grid-layout/grid-percent-track-margin-border-padding.html: Added.
2:01 PM Changeset in webkit [189549] by commit-queue@webkit.org
  • 7 edits in trunk/Source/JavaScriptCore

Implement the relational instructions for doubles in WebAssembly
​https://bugs.webkit.org/show_bug.cgi?id=148999

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-09
Reviewed by Filip Pizlo.

Implements the relational instructions for doubles (float64) in
WebAssembly. Also pass the values into the test functions as Mark Lam
suggested in ​https://bugs.webkit.org/show_bug.cgi?id=148882#c3

  • tests/stress/wasm-relational.js:
  • tests/stress/wasm/relational.wasm:
  • wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::buildRelationalF64):

  • wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseRelationalF64ExpressionI32):

  • wasm/WASMFunctionParser.h:
  • wasm/WASMFunctionSyntaxChecker.h:

(JSC::WASMFunctionSyntaxChecker::buildRelationalI32):
(JSC::WASMFunctionSyntaxChecker::buildRelationalF64):

1:58 PM Changeset in webkit [189548] by Said Abou-Hallawa
  • 2 edits in trunk/LayoutTests

Mark http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html as flaky on Windows

This test is marked as flaky on gtk and mak-wk2. It fails on Windows more
than it fails on any other platform.

  • platform/win/TestExpectations:
1:57 PM Changeset in webkit [189547] by mitz@apple.com
  • 32 edits in trunk/Source/WebKit2

Updated availability annotations for iOS 9 and OS X El Capitan.

Rubber-stamped by Anders Carlsson.

  • Shared/API/Cocoa/_WKRenderingProgressEvents.h:
  • UIProcess/API/Cocoa/WKError.h:
  • UIProcess/API/Cocoa/WKErrorPrivate.h:
  • UIProcess/API/Cocoa/WKFrameInfo.h:
  • UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
  • UIProcess/API/Cocoa/WKNavigationDelegate.h:
  • UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/API/Cocoa/WKSecurityOrigin.h:
  • UIProcess/API/Cocoa/WKUIDelegate.h:
  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:
  • UIProcess/API/Cocoa/WKViewPrivate.h:
  • UIProcess/API/Cocoa/WKWebView.h:
  • UIProcess/API/Cocoa/WKWebViewConfiguration.h:
  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/Cocoa/WKWebsiteDataRecord.h:
  • UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h:
  • UIProcess/API/Cocoa/WKWebsiteDataStore.h:
  • UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:
  • UIProcess/API/Cocoa/_WKElementAction.h:
  • UIProcess/API/Cocoa/_WKLayoutMode.h:
  • UIProcess/API/Cocoa/_WKOverlayScrollbarStyle.h:
  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
  • UIProcess/API/Cocoa/_WKUserContentExtensionStore.h:
  • UIProcess/API/Cocoa/_WKUserContentFilter.h:
  • UIProcess/API/Cocoa/_WKWebsiteDataRecord.h:
  • UIProcess/API/Cocoa/_WKWebsiteDataStore.h:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:
1:39 PM Changeset in webkit [189546] by ap@apple.com
  • 4 edits in trunk

fast/dom/rtl-scroll-to-leftmost-and-resize.html is a flaky timeout - IPC drops messages
​https://bugs.webkit.org/show_bug.cgi?id=148951

Reviewed by Anders Carlsson.

Source/WebKit2:

  • Platform/IPC/Connection.cpp:

(IPC::Connection::waitForMessage): Don't modify m_waitingForMessage without holding
a lock. This is not part of this fix, but seems necessary for correctness.
(IPC::Connection::processIncomingMessage): Don't interrupt a wait that has already succeeded.

LayoutTests:

  • platform/mac-wk2/TestExpectations: Unmark the test (it still fails per platform/mac

expectations, which is unrelated).

1:29 PM Changeset in webkit [189545] by youenn.fablet@crf.canon.fr
  • 2 edits in trunk/LayoutTests

http/tests/xmlhttprequest/ontimeout-response-getters.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=148997

Reviewed by Alexey Proskuryakov.

  • http/tests/xmlhttprequest/ontimeout-response-getters.html: Augmenting http response delay to trigger XHR timeout.
1:18 PM Changeset in webkit [189544] by saambarati1@gmail.com
  • 10 edits
    2 adds in trunk

DFG should have a debugging option that runs a phase that flushes all locals
​https://bugs.webkit.org/show_bug.cgi?id=148916

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

There is now an option to enable the DFG's new MaximalFlushInsertionPhase
phase to run. This phase ensures that we keep all locals and arguments flushed
to the stack at all places in the CFG. This phase is helpful for finding
a class of bugs where enabling this phase to run removes the bug.
This may also be useful in the development of a faster debugger
that doesn't capture all variables.

(JSC::DFG::MaximalFlushInsertionPhase::MaximalFlushInsertionPhase):
(JSC::DFG::MaximalFlushInsertionPhase::run):
(JSC::DFG::MaximalFlushInsertionPhase::treatRegularBlock):
(JSC::DFG::MaximalFlushInsertionPhase::treatRootBlock):
(JSC::DFG::MaximalFlushInsertionPhase::newVariableAccessData):
(JSC::DFG::performMaximalFlushInsertion):

  • dfg/DFGMaximalFlushInsertionPhase.h: Added.
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • runtime/Options.cpp:

(JSC::recomputeDependentOptions):

  • runtime/Options.h:

Tools:

  • Scripts/run-jsc-stress-tests:
11:42 AM Changeset in webkit [189543] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

9:56 AM Changeset in webkit [189542] by aestes@apple.com
  • 3 edits
    63 adds in trunk/LayoutTests

[iOS] Add layout tests for QuickLook
​https://bugs.webkit.org/show_bug.cgi?id=148994

Reviewed by Daniel Bates.

Add tests that verify WebKit's ability to preview certain document types on iOS using QuickLook.framework.
These tests do not cover every document type supported by QuickLook, but they do cover common types like .pages,
.numbers, .key, .doc(x), .xls(x), and .ppt(x). These tests should detect regressions in WebKit's conversion code,
as well as regressions in QuickLook itself. The expected results might need to be occasionally updated if QuickLook
changes its preview markup.

These files contain text and images from webkit.org.

  • TestExpectations: Skipped quicklook tests on all platforms.
  • platform/ios-simulator/TestExpectations: Enabled quicklook tests on iOS.
  • quicklook/excel-expected.html: Added.
  • quicklook/excel-legacy-expected.html: Added.
  • quicklook/excel-legacy.html: Added.
  • quicklook/excel.html: Added.
  • quicklook/keynote-09-expected.html: Added.
  • quicklook/keynote-09.html: Added.
  • quicklook/keynote-expected.html: Added.
  • quicklook/keynote.html: Added.
  • quicklook/numbers-09-expected.html: Added.
  • quicklook/numbers-09.html: Added.
  • quicklook/numbers-expected.html: Added.
  • quicklook/numbers.html: Added.
  • quicklook/pages-09-expected.html: Added.
  • quicklook/pages-09.html: Added.
  • quicklook/pages-expected.html: Added.
  • quicklook/pages.html: Added.
  • quicklook/powerpoint-expected.html: Added.
  • quicklook/powerpoint-legacy-expected.html: Added.
  • quicklook/powerpoint-legacy.html: Added.
  • quicklook/powerpoint.html: Added.
  • quicklook/resources/excel-expected.html: Added.
  • quicklook/resources/excel-legacy-expected.html: Added.
  • quicklook/resources/excel-legacy.xls: Added.
  • quicklook/resources/excel.xlsx: Added.
  • quicklook/resources/keynote-09-expected/index.css: Added.
  • quicklook/resources/keynote-09-expected/index.html: Added.
  • quicklook/resources/keynote-09-expected/index.js: Added.
  • quicklook/resources/keynote-09.key: Added.
  • quicklook/resources/keynote-expected.pdf: Added.
  • quicklook/resources/keynote.key: Added.
  • quicklook/resources/numbers-09-expected/canvas.js: Added.
  • quicklook/resources/numbers-09-expected/index.html: Added.
  • quicklook/resources/numbers-09-expected/navigation.css: Added.
  • quicklook/resources/numbers-09-expected/navigation.html: Added.
  • quicklook/resources/numbers-09-expected/sheet_1.html: Added.
  • quicklook/resources/numbers-09.numbers: Added.
  • quicklook/resources/numbers-expected.pdf: Added.
  • quicklook/resources/numbers.numbers: Added.
  • quicklook/resources/pages-09-expected/index.css: Added.
  • quicklook/resources/pages-09-expected/index.html: Added.
  • quicklook/resources/pages-09.pages: Added.
  • quicklook/resources/pages-expected.pdf: Added.
  • quicklook/resources/pages.pages: Added.
  • quicklook/resources/powerpoint-expected.html: Added.
  • quicklook/resources/powerpoint-legacy-expected.html: Added.
  • quicklook/resources/powerpoint-legacy.ppt: Added.
  • quicklook/resources/powerpoint.pptx: Added.
  • quicklook/resources/webkit-icon.pdf: Added.
  • quicklook/resources/webkit-icon.png: Added.
  • quicklook/resources/webkit-icon.tiff: Added.
  • quicklook/resources/word-expected.html: Added.
  • quicklook/resources/word-legacy-expected.html: Added.
  • quicklook/resources/word-legacy.doc: Added.
  • quicklook/resources/word.docx: Added.
  • quicklook/word-expected.html: Added.
  • quicklook/word-legacy-expected.html: Added.
  • quicklook/word-legacy.html: Added.
  • quicklook/word.html: Added.
8:43 AM Changeset in webkit [189541] by commit-queue@webkit.org
  • 29 edits
    4 deletes in trunk

Unreviewed, rolling out r189536 and r189538.
​https://bugs.webkit.org/show_bug.cgi?id=149002

broke tests on mac (Requested by alexchristensen on #webkit).

Reverted changesets:

"min-width/height should default to auto for flexbox items"
​https://bugs.webkit.org/show_bug.cgi?id=146020
​http://trac.webkit.org/changeset/189536

"[css-grid] Percentage columns shouldn't include border and
padding"
​https://bugs.webkit.org/show_bug.cgi?id=148978
​http://trac.webkit.org/changeset/189538

7:42 AM Changeset in webkit [189540] by hyatt@apple.com
  • 5 edits
    2 adds in trunk

REGRESSION: Inline-block baseline is wrong when zero-width replaced child is present
​https://bugs.webkit.org/show_bug.cgi?id=147452
rdar://problem/21943074

Reviewed by Myles Maxfield.

Source/WebCore:

Added new test in fast/inline-block

Treat zero width replaced elements the same as replaced elements with width. Instead of
clearing floats based off having no committed width, we instead track both committed
width and committed replaced objects. We do this with two new booleans in LineWidth
so that we know when we have uncomitted and committed replaced objects.

  • rendering/line/BreakingContext.h:

(WebCore::BreakingContext::handleReplaced):
(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::canBreakAtThisPosition):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):

  • rendering/line/LineWidth.cpp:

(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::commit):
(WebCore::LineWidth::applyOverhang):

  • rendering/line/LineWidth.h:

(WebCore::LineWidth::committedWidth):
(WebCore::LineWidth::availableWidth):
(WebCore::LineWidth::logicalLeftOffset):
(WebCore::LineWidth::hasCommitted):
(WebCore::LineWidth::addUncommittedWidth):
(WebCore::LineWidth::addUncommittedReplacedWidth):

LayoutTests:

  • fast/inline-block/baseline-with-zero-width-replaced-child-expected.html: Added.
  • fast/inline-block/baseline-with-zero-width-replaced-child.html: Added.
5:26 AM Changeset in webkit [189539] by Antti Koivisto
  • 13 edits in trunk/Source/WebCore

Split mixed font GlyphPage functionality to separate class
​https://bugs.webkit.org/show_bug.cgi?id=148965

Reviewed by Myles Maxfield.

Currently GlyphPage class is used for both immutable single font case (in Font) and
for caching mixed font mappings (in FontCascadeFonts). It is cleaner to use separate
classed for these cases. This will also make future improvements easier.

  • platform/graphics/Font.cpp:

(WebCore::Font::~Font):
(WebCore::fillGlyphPage):
(WebCore::createAndFillGlyphPage):
(WebCore::Font::glyphPage):
(WebCore::Font::glyphForCharacter):
(WebCore::Font::glyphDataForCharacter):

  • platform/graphics/Font.h:
  • platform/graphics/FontCascadeFonts.cpp:

(WebCore::MixedFontGlyphPage::MixedFontGlyphPage):
(WebCore::MixedFontGlyphPage::glyphDataForCharacter):
(WebCore::MixedFontGlyphPage::setGlyphDataForCharacter):
(WebCore::MixedFontGlyphPage::setGlyphDataForIndex):

Mixed font pages are now an implementation detail of FontCascadeFonts.

(WebCore::FontCascadeFonts::GlyphPageCacheEntry::glyphDataForCharacter):
(WebCore::FontCascadeFonts::GlyphPageCacheEntry::setGlyphDataForCharacter):
(WebCore::FontCascadeFonts::GlyphPageCacheEntry::setSingleFontPage):

Cache entry is either shared single font GlyphPage or mutable MixedFontGlyphPage.

(WebCore::FontCascadeFonts::FontCascadeFonts):
(WebCore::FontCascadeFonts::glyphDataForCharacter):
(WebCore::FontCascadeFonts::pruneSystemFallbacks):

  • platform/graphics/FontCascadeFonts.h:

(WebCore::FontCascadeFonts::GlyphPageCacheEntry::isNull):
(WebCore::FontCascadeFonts::GlyphPageCacheEntry::isMixedFont):

  • platform/graphics/GlyphPage.h:

GlyphPage is now for single font mappings only.
Use regular allocation instead of variable size tricks.
It is always immutable after initialization (though currently a setter is still needed).

(WebCore::GlyphPage::create):
(WebCore::GlyphPage::~GlyphPage):
(WebCore::GlyphPage::count):
(WebCore::GlyphPage::indexForCharacter):
(WebCore::GlyphPage::glyphDataForCharacter):
(WebCore::GlyphPage::glyphForCharacter):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::glyphForIndex):
(WebCore::GlyphPage::setGlyphForIndex):
(WebCore::GlyphPage::font):
(WebCore::GlyphPage::GlyphPage):
(WebCore::GlyphPage::createForMixedFonts): Deleted.
(WebCore::GlyphPage::createCopyForMixedFonts): Deleted.
(WebCore::GlyphPage::createForSingleFont): Deleted.
(WebCore::GlyphPage::isImmutable): Deleted.
(WebCore::GlyphPage::setImmutable): Deleted.
(WebCore::GlyphPage::glyphAt): Deleted.
(WebCore::GlyphPage::fontForCharacter): Deleted.
(WebCore::GlyphPage::setGlyphDataForCharacter): Deleted.
(WebCore::GlyphPage::setGlyphDataForIndex): Deleted.
(WebCore::GlyphPage::hasPerGlyphFontData): Deleted.

  • platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp:

(WebCore::GlyphPage::fill):

  • platform/graphics/mac/GlyphPageMac.cpp:

(WebCore::GlyphPage::fill):

  • platform/graphics/opentype/OpenTypeVerticalData.cpp:

(WebCore::OpenTypeVerticalData::substituteWithVerticalGlyphs):

  • platform/graphics/win/GlyphPageTreeNodeCGWin.cpp:

(WebCore::GlyphPage::fill):

  • platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp:

(WebCore::GlyphPage::fill):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):
(WebCore::SVGFontData::fillSVGGlyphPage):
(WebCore::SVGFontData::fillBMPGlyphs):
(WebCore::SVGFontData::fillNonBMPGlyphs):

  • svg/SVGFontData.h:

(WebCore::SVGFontData::verticalAdvanceY):

5:16 AM WebKitGTK/2.10.x edited by Michael Catanzaro
Propose bug #145639 (diff)
4:23 AM Changeset in webkit [189538] by Manuel Rego Casasnovas
  • 3 edits
    2 adds in trunk

[css-grid] Percentage columns shouldn't include border and padding
​https://bugs.webkit.org/show_bug.cgi?id=148978

Reviewed by Sergio Villar Senin.

Source/WebCore:

Subtract border and padding when we're calculating the breadth of the
columns in LayoutGrid::computeUsedBreadthOfSpecifiedLength().

Added test to check the behavior for both columns and rows.

Test: fast/css-grid-layout/grid-percent-track-margin-border-padding.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeUsedBreadthOfSpecifiedLength):

LayoutTests:

  • fast/css-grid-layout/grid-percent-track-margin-border-padding-expected.txt: Added.
  • fast/css-grid-layout/grid-percent-track-margin-border-padding.html: Added.
1:49 AM Changeset in webkit [189537] by Chris Dumez
  • 5 edits
    2 adds in trunk

HTMLTableElement.tHead / tFoot / caption should be nullable
​https://bugs.webkit.org/show_bug.cgi?id=148991

Reviewed by Ryosuke Niwa.

Source/WebCore:

According to the specification, HTMLTableElement.tHead / tFoot / caption
should be nullable:
​https://html.spec.whatwg.org/multipage/tables.html#htmltableelement

Upon assigning null, we are supposed to remove the existing tHead / tFoot
/ caption element. However, we had a bug causing us to throw an exception
after removing the element. This is because we would try to insert a null
element and ContainerNode::insertBefore() throws when doing so.

Also, as per the specification, setting tHead / tFoot to something else
than a thead / tfoot element should throw a HierarchyRequestError:
​https://html.spec.whatwg.org/multipage/tables.html#dom-table-thead
​https://html.spec.whatwg.org/multipage/tables.html#dom-table-tfoot

Previously, WebKit did not check the tag and was happy inserting the
element as long as it was an HTMLTableSectionElement. This means that
you could set a tfoot by assigning table.tHead.

This patch corrects both bugs and adds test coverage for it.

Test: fast/dom/HTMLTableElement/nullable-attributes.html

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::setCaption):
Only call insertBefore() if newCaption is not null as insertBefore()
will throw an exception otherwise.

(WebCore::HTMLTableElement::setTHead):

  • Throw a HierarchyRequestError if the HTMLTableSectionElement is not null or a <thead> element, as per the specification.
  • Only call insertBefore() if newHead is not null as insertBefore() will throw an exception otherwise.

(WebCore::HTMLTableElement::setTFoot):

  • Throw a HierarchyRequestError if the HTMLTableSectionElement is not null or a <tfoot> element, as per the specification.
  • Only call insertBefore() if newFoot is not null as insertBefore() will throw an exception otherwise.
  • html/HTMLTableElement.idl:

Use [StrictTypeChecking] for these 3 attributes so that the bindings
will throw a TypeError if the JS tries to assign a value with the
wrong type. When the implementation is called with null, we now know
this is because the JS assigned null (and not an invalid value).
This is important as assigning null is valid since those attributes
are nullable.

LayoutTests:

Add new test that covers the behavior of the following HTMLTableElement
attributes: caption / tHead / tFoot.

  • fast/dom/HTMLTableElement/nullable-attributes-expected.txt: Added.
  • fast/dom/HTMLTableElement/nullable-attributes.html: Added.
  • fast/dom/setter-type-enforcement-expected.txt:
12:37 AM Changeset in webkit [189536] by svillar@igalia.com
  • 29 edits
    2 adds in trunk

min-width/height should default to auto for flexbox items
​https://bugs.webkit.org/show_bug.cgi?id=146020

Reviewed by David Hyatt.

Based on Blink's r193665, r194062, r194887 and r195930 by <​cbiesinger@chromium.org>.

Source/WebCore:

As specified here
​http://dev.w3.org/csswg/css-flexbox/#min-size-auto the default
value of min-{width|height} is auto for flex items.

In case this patch breaks any website (as it's changing the
default value of those properties) the fix is likely to add:

min-width: 0;
min-height: 0;

to any relevant flexitems.

Test: css3/flexbox/min-size-auto.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::isFlexOrGrid): New helper method to identify grids and flexs.
(WebCore::ComputedStyleExtractor::propertyValue): Return auto
for flex items if min-width/height is auto.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • html/shadow/SliderThumbElement.cpp:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::constrainLogicalHeightByMinMax):
(WebCore::RenderBox::constrainContentBoxLogicalHeightByMinMax):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computeContentLogicalHeight):
(WebCore::RenderBox::computeContentAndScrollbarLogicalHeightUsing):
(WebCore::RenderBox::computeReplacedLogicalWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):

  • rendering/RenderBox.h:
  • rendering/RenderButton.h:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
(WebCore::RenderFlexibleBox::mainAxisExtentIsDefinite):
(WebCore::RenderFlexibleBox::mainAxisLengthIsIndefinite):
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
(WebCore::RenderFlexibleBox::mainAxisOverflowForChild):

  • rendering/RenderFlexibleBox.h:

(WebCore::RenderFlexibleBox::isFlexibleBoxImpl):

  • rendering/RenderFullScreen.h:
  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeUsedBreadthOfSpecifiedLength):

  • rendering/RenderMediaControlElements.h:
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::adjustInnerStyle): Do not longer set
the min-width explicitly.

  • rendering/RenderMenuList.h:
  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::calculateMaxColumnHeight):

  • rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::maxPageLogicalHeight):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):

  • rendering/RenderSlider.h:
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::createInnerBlockStyle): Do not longer set
the min-width explicitly.

  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/style/RenderStyle.h:

LayoutTests:

  • TestExpectations: Removed passing flexbox tests.
  • css3/flexbox/csswg/flex-flow-007.html: Added min-height: 0px.
  • css3/flexbox/flexbox-baseline.html: Ditto.
  • css3/flexbox/min-size-auto-expected.txt: Added.
  • css3/flexbox/min-size-auto.html: Added.
  • css3/flexbox/preferred-widths-orthogonal.html: Added min-height: 0px.
  • fast/css/auto-min-size-expected.txt: Check default computed

styles for min-width/height for flex items.

  • fast/css/auto-min-size.html: Ditto.
12:02 AM Changeset in webkit [189535] by mmaxfield@apple.com
  • 14 edits
    1 move in trunk/Tools

Unreviewed, rolling out r189530 and r189534.
​https://bugs.webkit.org/show_bug.cgi?id=148996

Caused assertion failures on Yosemite (Requested by litherum
on #webkit).

Reverted changesets:

"[WKTR] Allow changing the WKContextConfiguration between
successive tests"
​https://bugs.webkit.org/show_bug.cgi?id=148833
​http://trac.webkit.org/changeset/189530

"[Cocoa] Fix the tests after r189530"
​http://trac.webkit.org/changeset/189534

Patch by Commit Queue <​commit-queue@webkit.org> on 2015-09-09

Note: See TracTimeline for information about the timeline view.