⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 12, 2015:

11:46 PM Changeset in webkit [189672] by mmaxfield@apple.com
  • 2 edits in trunk/LayoutTests

Another test fix after r189670.

Unreviewed.

  • platform/mac-wk1/TestExpectations:
11:19 PM Changeset in webkit [189671] by mmaxfield@apple.com
  • 2 edits in trunk/LayoutTests

Test fix after r189670.

Unreviewed.

  • platform/mac/TestExpectations:
9:10 PM Changeset in webkit [189670] by mmaxfield@apple.com
  • 5 edits
    8 moves
    5 adds in trunk/LayoutTests

[Cocoa] Add system-language-specific tests
​https://bugs.webkit.org/show_bug.cgi?id=148775

Reviewed by Alexey Proskuryakov.

This patch adds (or rewrites) tests to take advantage of our new ability to mock
the system language for testing (​https://bugs.webkit.org/show_bug.cgi?id=148671).

It tests these patches:
​https://bugs.webkit.org/show_bug.cgi?id=148164
​https://bugs.webkit.org/show_bug.cgi?id=147504
​https://bugs.webkit.org/show_bug.cgi?id=147862
​https://bugs.webkit.org/show_bug.cgi?id=147964

  • fast/text/international/system-language/arabic-glyph-cache-fill-combine-expected.html: Renamed from LayoutTests/fast/text/arabic-glyph-cache-fill-combine-expected.html.
  • fast/text/international/system-language/arabic-glyph-cache-fill-combine.html: Renamed from LayoutTests/fast/text/arabic-glyph-cache-fill-combine.html.
  • fast/text/international/system-language/han-quotes-expected-mismatch.html: Added.
  • fast/text/international/system-language/han-quotes.html: Added.
  • fast/text/international/system-language/hindi-system-font-punctuation-expected.html: Renamed from LayoutTests/fast/text/hindi-system-font-punctuation-expected.html.
  • fast/text/international/system-language/hindi-system-font-punctuation.html: Renamed from LayoutTests/fast/text/hindi-system-font-punctuation.html.
  • fast/text/international/system-language/system-font-punctuation.html: Renamed from LayoutTests/fast/text/system-font-punctuation.html.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/ios-simulator/fast/text/international/system-language/system-font-punctuation-expected.txt: Renamed from LayoutTests/platform/ios-simulator/fast/text/system-font-punctuation-expected.txt.
  • platform/mac/TestExpectations:
  • platform/mac/fast/text/international/system-language/system-font-punctuation-expected.txt: Renamed from LayoutTests/platform/mac/fast/text/system-font-punctuation-expected.txt.
  • platform/win/TestExpectations:
  • platform/win/fast/text/international/system-language/system-font-punctuation-expected.txt: Renamed from LayoutTests/platform/win/fast/text/system-font-punctuation-expected.txt.
8:47 PM Changeset in webkit [189669] by mmaxfield@apple.com
  • 19 edits
    3 adds in trunk

[Cocoa] Allow testing with the system language
​https://bugs.webkit.org/show_bug.cgi?id=148671

Reviewed by Anders Carlsson and Alexey Proskuryakov.

Source/WebKit2:

This patch adds two new SPI functions for setting and retrieving a vector of
override languages to/from the WKContextConfiguration. The implementation of
these functions holds state inside WebProcessPoolConfiguration. Then, when
we launch a process, the WebProcessProxy will inject these override languages
into the ProcessLauncher::LaunchOptions so that the ProcessLauncher can
inject these languages into the XPC Bootstrap message. Then, in the Web
Process's main(), the XPC Boostrap message is read, and the platform
languages are set via NSUserDefaults setting a volatile domain.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:

(main): Set the volatile domain with NSUserDefaults.

  • UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy):

  • UIProcess/API/APIProcessPoolConfiguration.h: Hold state for the override

languages.

  • UIProcess/API/C/WKContextConfigurationRef.cpp:

(WKContextConfigurationCopyOverrideLanguages): SPI.
(WKContextConfigurationSetOverrideLanguages): Ditto.

  • UIProcess/API/C/WKContextConfigurationRef.h:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::connectToService): Inject the languages into the XPC Bootstrap
message.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getLaunchOptions): Inject the override languages
into the ProcessLauncher::LaunchOptions.

Tools:

React to tests marked with language=lang1,lang2,etc in their header.
Once this information is parsed, pass it to
WKContextConfigurationSetOverrideLanguages().

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize): Don't clobber the language
list.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions): Call
WKContextConfigurationSetOverrideLanguages().
(WTR::updateTestOptionsFromTestHeader): Inspect the language option.

  • WebKitTestRunner/TestOptions.h:
  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
option to restart the web process.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::viewSupportsOptions): Ditto.

LayoutTests:

Add a test for the declarative form of setting the system language.

  • fast/text/international/system-language/declarative-language-expected.txt: Added.
  • fast/text/international/system-language/declarative-language.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • platform/mac/TestExpectations:
7:31 PM Changeset in webkit [189668] by mmaxfield@apple.com
  • 16 edits
    1 move in trunk/Tools

[WKTR] Allow changing the WKContextConfiguration between successive tests
​https://bugs.webkit.org/show_bug.cgi?id=148833

Reviewed by Tim Horton.

Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
However, there are certain tests which require specifying options in this object. This patch makes
our existing code for recreating the test runner web view also recreate the WKContext.

As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
class.

  • WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
  • WebKitTestRunner/PlatformWebView.h:

(WTR::PlatformWebView::options):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):
(WTR::TestController::generateContextConfiguration):
(WTR::TestController::generatePageConfiguration):
(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::ensureViewSupportsOptionsForTest):
(WTR::updateContextConfigurationOptionsFromTestHeader):
(WTR::TestController::contextConfigurationOptionsForTest):
(WTR::TestController::platformCreateWebView):
(WTR::TestController::platformCreateOtherPage):
(WTR::updateViewOptionsFromTestHeader): Deleted.
(WTR::TestController::viewOptionsForTest): Deleted.

  • WebKitTestRunner/TestController.h:

(WTR::TestController::injectedBundlePath):
(WTR::TestController::testPluginDirectory):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::platformCreateWebView):
(WTR::TestController::platformCreateOtherPage):

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):

  • WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
(WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):

  • WebKitTestRunner/gtk/TestControllerGtk.cpp:

(WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
(WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.

  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):

  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
(WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
(WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.

6:15 PM WebKitGTK/2.10.x edited by Michael Catanzaro
Propose more translation updates (diff)
6:14 PM Changeset in webkit [189667] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Updated Spanish translation
​https://bugs.webkit.org/show_bug.cgi?id=145550

Unreviewed.

Patch by Francisco Serrador <​fserrador@gmail.com> on 2015-09-12

  • es.po:
6:11 PM Changeset in webkit [189666] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Updated Slovenian translation
​https://bugs.webkit.org/show_bug.cgi?id=123080

Unreviewed.

Patch by Matej Urbančič <​mateju@svn.gnome.org> on 2015-09-12

  • sl.po:
6:08 PM Changeset in webkit [189665] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Webkit Tamil translations updated
​https://bugs.webkit.org/show_bug.cgi?id=139478

Unreviewed.

Patch by Shantha kumar <​shkumar@redhat.com> on 2015-09-12

  • ta.po:
4:59 PM WebKitGTK/2.10.x edited by Michael Catanzaro
Propose r189663, r189664 (diff)
4:56 PM Changeset in webkit [189664] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Bulgarian translation
​https://bugs.webkit.org/show_bug.cgi?id=142611

Unreviewed.

Patch by Zahari Yurukov <​zahari.yurukov@gmail.com> on 2015-09-12

  • bg.po:
4:54 PM Changeset in webkit [189663] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Polish translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=148475

Unreviewed.

Patch by Piotr Drąg <​piotrdrag@gmail.com> on 2015-09-12

  • pl.po:
4:27 PM Changeset in webkit [189662] by Michael Catanzaro
  • 1 edit in trunk/Source/WebCore/platform/gtk/po/ChangeLog

[GTK] [l10n] Updated Turkish translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=148362

Unreviewed.

Patch by Muhammet Kara <​muhammetk@gmail.com> on 2015-09-12

  • tr.po: Added.
4:21 PM WebKitGTK/2.10.x edited by Michael Catanzaro
Propose r189661 (diff)
4:20 PM Changeset in webkit [189661] by Michael Catanzaro
  • 1 edit
    1 add in trunk/Source/WebCore/platform/gtk/po

[GTK] [l10n] Updated Turkish translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=148362

Unreviewed.

  • tr.po: Added.
2:52 PM Changeset in webkit [189660] by Chris Dumez
  • 15 edits in trunk

window.EventTarget should exist
​https://bugs.webkit.org/show_bug.cgi?id=149085
<rdar://problem/22546774>

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing.

  • web-platform-tests/dom/interface-objects-expected.txt:
  • web-platform-tests/dom/interfaces-expected.txt:
  • web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Drop [NoInterfaceObject] for the EventTarget interface to match Chrome,
Firefox and the specification:
​https://dom.spec.whatwg.org/#interface-eventtarget

No new tests, already covered by existing tests.

  • dom/EventTarget.idl:

LayoutTests:

Update / rebaseline existing test as window.EventTarget now exists.

  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
2:49 PM Changeset in webkit [189659] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

[iOS] Allow UDP networking
​https://bugs.webkit.org/show_bug.cgi?id=149081
rdar://problem/22291743

Reviewed by Sam Weinig.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
1:52 PM Changeset in webkit [189658] by fpizlo@apple.com
  • 3 edits
    1 add in trunk/Source/JavaScriptCore

REGRESSION(r189585): run-perf-tests Speedometer fails with a console error
​https://bugs.webkit.org/show_bug.cgi?id=149066

Reviewed by Michael Saboff.

The bug here was that the new IC code was calling actionForCell() more than once. That's
illegal, since when actionForCell() returns RetryCacheLater, it means that it changed some
object's Structure. The Repatch code was doing things like "if (actionForCell(blah) ==
AttemptToCache)" in more than one place, so that if the first such expression was false, then
we'd fall through to the next one. It's possible for the first call to return RetryCacheLater,
in which case our view of the world just got clobbered and we need to return, and then the
second call will probably return AttemptToCache because it *thinks* that we had bailed the last
time and we're now in a future IC invocation.

The solution is to cache the actionForCell() result. This is a bit tricky, because we need to
do this after we check if we're in a proxy.

Debugging bugs like these requires adding ad hoc bisection code in various places. We already
had the basic hooks for this. This patch makes those hooks a bit more useful. In the case of
the LLInt->JIT tier-up hooks, it adds a CodeBlock* argument so that we can bisect based on the
CodeBlock. In the case of Repatch, it puts the Options::forceICFailure() check in a helper
function that also takes ExecState*, which allows us to bisect on either CodeBlock or
CodeOrigin.

  • jit/Repatch.cpp:

(JSC::actionForCell):
(JSC::forceICFailure):
(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):
(JSC::tryRepatchIn):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::shouldJIT):
(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::entryOSR):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • tests/stress/retry-cache-later.js:
12:02 PM Changeset in webkit [189657] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebKit2

Web Inspector: Extract InspectorFrontendAPI dispatching from WebInspectorUI
​https://bugs.webkit.org/show_bug.cgi?id=149089

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-12
Reviewed by Brian Burg.

  • CMakeLists.txt:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebInspectorFrontendAPIDispatcher.cpp: Added.

(WebKit::WebInspectorFrontendAPIDispatcher::WebInspectorFrontendAPIDispatcher):
(WebKit::WebInspectorFrontendAPIDispatcher::reset):
(WebKit::WebInspectorFrontendAPIDispatcher::frontendLoaded):
(WebKit::WebInspectorFrontendAPIDispatcher::dispatchCommand):
(WebKit::WebInspectorFrontendAPIDispatcher::dispatchMessageAsync):
(WebKit::WebInspectorFrontendAPIDispatcher::evaluateExpressionOnLoad):

  • WebProcess/WebPage/WebInspectorFrontendAPIDispatcher.h: Added.
  • WebProcess/WebPage/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::WebInspectorUI):
(WebKit::WebInspectorUI::establishConnection):
(WebKit::WebInspectorUI::frontendLoaded):
(WebKit::WebInspectorUI::setDockSide):
(WebKit::WebInspectorUI::setDockingUnavailable):
(WebKit::WebInspectorUI::showConsole):
(WebKit::WebInspectorUI::showResources):
(WebKit::WebInspectorUI::showMainResourceForFrame):
(WebKit::WebInspectorUI::startPageProfiling):
(WebKit::WebInspectorUI::stopPageProfiling):
(WebKit::WebInspectorUI::didSave):
(WebKit::WebInspectorUI::didAppend):
(WebKit::WebInspectorUI::sendMessageToFrontend):
(WebKit::WebInspectorUI::evaluateCommandOnLoad): Deleted.
(WebKit::WebInspectorUI::evaluateExpressionOnLoad): Deleted.
(WebKit::WebInspectorUI::evaluatePendingExpressions): Deleted.

  • WebProcess/WebPage/WebInspectorUI.h:

(WebKit::WebInspectorUI::evaluateCommandOnLoad): Deleted.

11:53 AM Changeset in webkit [189656] by ap@apple.com
  • 1 edit
    2 adds
    1 delete in branches/safari-601-branch/LayoutTests

Re-add Mavericks result with the correct path.

  • platform/mac-mavericks/platform/mac/accessibility: Added.
  • platform/mac-mavericks/platform/mac/accessibility/selection-sync-expected.txt: Added.
  • platform/mac-mavericks/platform/mac/accessibilityselection-sync-expected.txt: Removed.
11:31 AM Changeset in webkit [189655] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Web Inspector: Move Already Generic Inspector Page Context Menu to Generic Setup
​https://bugs.webkit.org/show_bug.cgi?id=149088

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-12
Reviewed by Brian Burg.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::getContextMenuFromProposedMenu):
(WebKit::WebInspectorProxy::eagerlyCreateInspectorPage):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::getContextMenuFromProposedMenu): Deleted.
(WebKit::WebInspectorProxy::platformCreateInspectorPage):

10:44 AM Changeset in webkit [189654] by BJ Burg
  • 24 edits in trunk/Source

Web Inspector: disambiguate inspected/frontend controllers and pages in backend code
​https://bugs.webkit.org/show_bug.cgi?id=149071

Reviewed by Joseph Pecoraro.

Source/WebCore:

Be consistent about prefixing pages, inspector controllers, and window controllers
with either "frontend" or "inspected", as appropriate. This change makes obvious some bugs
in the frontend connection code, which are tracked by ​https://webkit.org/b/149006.

No new tests, no behavior change.

  • WebCore.order:
  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::show):
(WebCore::InspectorController::close):

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::~InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::canAttachWindow):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowWidth):
(WebCore::InspectorFrontendClientLocal::openInNewTab):
(WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::showMainResourceForFrame):
(WebCore::InspectorFrontendClientLocal::isUnderTest):

  • inspector/InspectorFrontendClientLocal.h:
  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::freePage):

  • loader/EmptyClients.h:

Source/WebKit/ios:

  • WebCoreSupport/WebInspectorClientIOS.mm:

(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::inspectedPageDestroyed): Renamed.
(WebInspectorClient::openLocalFrontend): Renamed.
(WebInspectorClient::closeLocalFrontend): Renamed.
(WebInspectorClient::inspectorDestroyed): Deleted.
(WebInspectorClient::openInspectorFrontend): Deleted.
(WebInspectorClient::closeInspectorFrontend): Deleted.
(WebInspectorClient::showInspectorIndication):
(WebInspectorClient::hideInspectorIndication):
(WebInspectorClient::didSetSearchingForNode):
(WebInspectorFrontendClient::WebInspectorFrontendClient):

Source/WebKit/mac:

Be consistent about prefixing pages, inspector controllers, and window controllers
with either "frontend" or "inspected", as appropriate. This change makes obvious some bugs
in the frontend connection code, which are tracked by ​https://webkit.org/b/149006.

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::WebInspectorClient): Renamed.
(WebInspectorClient::inspectedPageDestroyed): Renamed.
(WebInspectorClient::openLocalFrontend): Renamed.
(WebInspectorClient::closeLocalFrontend): Renamed.
(WebInspectorClient::didSetSearchingForNode):
(WebInspectorFrontendClient::WebInspectorFrontendClient):
(WebInspectorFrontendClient::attachAvailabilityChanged):
(WebInspectorFrontendClient::canAttach):
(WebInspectorFrontendClient::frontendLoaded):
(WebInspectorFrontendClient::startWindowDrag):
(WebInspectorFrontendClient::bringToFront):
(WebInspectorFrontendClient::closeWindow):
(WebInspectorFrontendClient::disconnectFromBackend):
(WebInspectorFrontendClient::attachWindow):
(WebInspectorFrontendClient::detachWindow):
(WebInspectorFrontendClient::setAttachedWindowHeight):
(WebInspectorFrontendClient::setToolbarHeight):
(WebInspectorFrontendClient::updateWindowTitle):
(WebInspectorFrontendClient::save):
(WebInspectorFrontendClient::append):
(-[WebInspectorWindowController init]):
(-[WebInspectorWindowController initWithInspectedWebView:isUnderTest:]):
(-[WebInspectorWindowController dealloc]):
(-[WebInspectorWindowController frontendWebView]):
(-[WebInspectorWindowController close]):
(-[WebInspectorWindowController showWindow:]):
(-[WebInspectorWindowController setAttachedWindowHeight:]):
(-[WebInspectorWindowController destroyInspectorView]):
(-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
(WebInspectorClient::inspectorDestroyed): Deleted.
(WebInspectorClient::openInspectorFrontend): Deleted.
(WebInspectorClient::closeInspectorFrontend): Deleted.
(-[WebInspectorWindowController webView]): Deleted.

  • WebInspector/WebInspector.h:
  • WebInspector/WebInspector.mm:

(-initWithInspectedWebView:): Renamed.
(-inspectedWebViewClosed): Renamed.
(-showWindow):
(-close:):
(-evaluateInFrontend:script:):
(-releaseFrontend):
(-initWithWebView:): Deleted.
(-webViewClosed): Deleted.

  • WebView/WebView.mm:

(-[WebView _close]):
(-[WebView inspector]):

Source/WebKit/win:

Be consistent about prefixing pages, inspector controllers, and window controllers
with either "frontend" or "inspected", as appropriate. This change makes obvious some bugs
in the frontend connection code, which are tracked by ​https://webkit.org/b/149006.

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::inspectedPageDestroyed): Renamed.
(WebInspectorClient::openLocalFrontend): Renamed.
(WebInspectorClient::closeLocalFrontend): Renamed.
(WebInspectorClient::inspectorDestroyed): Deleted.
(WebInspectorClient::openInspectorFrontend): Deleted.
(WebInspectorClient::closeInspectorFrontend): Deleted.

(WebInspector::createInstance):
(WebInspector::WebInspector):
(WebInspector::inspectedWebViewClosed): Renamed.
(WebInspector::show):
(WebInspector::close):
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
(WebInspector::evaluateInFrontend):
(WebInspector::webViewClosed): Deleted.

(WebView::close):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::inspectedPageDestroyed): Renamed.
(WebKit::WebInspectorClient::openLocalFrontend): Renamed.
(WebKit::WebInspectorClient::closeLocalFrontend): Renamed.
(WebKit::WebInspectorClient::inspectorDestroyed): Deleted.
(WebKit::WebInspectorClient::openInspectorFrontend): Deleted.
(WebKit::WebInspectorClient::closeInspectorFrontend): Deleted.

  • WebProcess/WebCoreSupport/WebInspectorClient.h:
10:33 AM Changeset in webkit [189653] by Chris Dumez
  • 7 edits in trunk

ChildNode.replaceWith() without argument should replace the node with an empty DocumentFragment
​https://bugs.webkit.org/show_bug.cgi?id=149073
<rdar://problem/22547801>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

  • web-platform-tests/dom/nodes/ChildNode-replaceWith-expected.txt:

Source/WebCore:

ChildNode.replaceWith() without argument should replace the node with
an empty DocumentFragment, as per the specification:
​https://dom.spec.whatwg.org/#dom-childnode-replacewith
​https://dom.spec.whatwg.org/#converting-nodes-into-a-node

Previously, WebKit did not do anything in this case. This patch fixes
it.

No new tests, already covered by existing test.

  • dom/Node.cpp:

(WebCore::Node::replaceWith):

LayoutTests:

Fix / rebaseline test now that our behavior has changed.

  • fast/dom/ChildNode-replaceWith-expected.txt:
  • fast/dom/ChildNode-replaceWith.html:
8:58 AM Changeset in webkit [189652] by ap@apple.com
  • 9 edits
    1 copy in branches/safari-601-branch/LayoutTests

Roll out r189649, and just have custom results for Mavericks instead.

  • platform/mac-mavericks/platform/mac/accessibilityselection-sync-expected.txt: Copied from LayoutTests/platform/mac/accessibility/selection-sync-expected.txt.
  • platform/mac/accessibility/removing-textarea-after-edit-crash-expected.txt:
  • platform/mac/accessibility/removing-textarea-after-edit-crash.html:
  • platform/mac/accessibility/select-element-selection-with-optgroups.html:
  • platform/mac/accessibility/selected-rows-table.html:
  • platform/mac/accessibility/selection-notification-focus-change.html:
  • platform/mac/accessibility/selection-sync-expected.txt:
  • platform/mac/accessibility/selection-sync.html:
  • platform/mac/accessibility/setting-attributes-is-asynchronous.html:
1:47 AM Changeset in webkit [189651] by Gyuyoung Kim
  • 12 edits in trunk/Source

Remove all uses of PassRefPtr in WebCore/plugins
​https://bugs.webkit.org/show_bug.cgi?id=149055

Reviewed by Darin Adler.

  • plugins/DOMMimeType.cpp:

(WebCore::DOMMimeType::DOMMimeType):
(WebCore::DOMMimeType::enabledPlugin):

  • plugins/DOMMimeType.h:

(WebCore::DOMMimeType::create):

  • plugins/DOMMimeTypeArray.cpp:

(WebCore::DOMMimeTypeArray::item):

  • plugins/DOMMimeTypeArray.h:
  • plugins/DOMPlugin.cpp:

(WebCore::DOMPlugin::item):

  • plugins/DOMPlugin.h:
  • plugins/DOMPluginArray.cpp:

(WebCore::DOMPluginArray::item):

  • plugins/DOMPluginArray.h:
  • plugins/PluginViewBase.h:

(WebCore::PluginViewBase::bindingInstance):

1:45 AM Changeset in webkit [189650] by Gyuyoung Kim
  • 11 edits in trunk/Source/WebCore

Remove all uses of PassRefPtr in WebCore/accessibility and WebCore/fileapi
​https://bugs.webkit.org/show_bug.cgi?id=149059

Reviewed by Darin Adler.

  • accessibility/AXObjectCache.cpp:
  • accessibility/AccessibilityObject.cpp:

(WebCore::rangeClosestToRange):
(WebCore::AccessibilityObject::rangeOfStringClosestToRangeInDirection):
(WebCore::AccessibilityObject::selectionRange):
(WebCore::AccessibilityObject::selectText):

  • accessibility/AccessibilityObject.h:
  • accessibility/ios/AXObjectCacheIOS.mm:
  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _convertToDOMRange:]):
(-[WebAccessibilityObjectWrapper textMarkerForPosition:]):

  • accessibility/mac/AXObjectCacheMac.mm:
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper _textMarkerForIndex:]):

  • fileapi/FileList.h:

(WebCore::FileList::append):

  • fileapi/WebKitBlobBuilder.cpp:

(WebCore::BlobBuilder::append):

  • fileapi/WebKitBlobBuilder.h:

Sep 11, 2015:

11:02 PM Changeset in webkit [189649] by ap@apple.com
  • 8 edits in branches/safari-601-branch/LayoutTests

Merge r189221.

2015-09-01 Alexey Proskuryakov <​ap@apple.com>

Clean up asynchronous behavior in some accessibility tests
​https://bugs.webkit.org/show_bug.cgi?id=148682

Reviewed by Darin Adler.

  • platform/mac/accessibility/removing-textarea-after-edit-crash-expected.txt:
  • platform/mac/accessibility/removing-textarea-after-edit-crash.html:
  • platform/mac/accessibility/select-element-selection-with-optgroups.html:
  • platform/mac/accessibility/selected-rows-table.html:
  • platform/mac/accessibility/selection-notification-focus-change.html:
  • platform/mac/accessibility/selection-sync-expected.txt:
  • platform/mac/accessibility/selection-sync.html:
  • platform/mac/accessibility/setting-attributes-is-asynchronous.html:
10:28 PM Changeset in webkit [189648] by ap@apple.com
  • 2 edits in branches/safari-601-branch/LayoutTests

Update Mavericks test results after r189611.

This change wasn't needed on trunk because the behavior changed was masked by r189221.

  • platform/mac/accessibility/selection-sync-expected.txt:
9:47 PM Changeset in webkit [189647] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Mark http/tests/cache/disk-cache/disk-cache-cancel.html as flaky for
​https://bugs.webkit.org/show_bug.cgi?id=149087

  • platform/wk2/TestExpectations:
6:51 PM Changeset in webkit [189646] by commit-queue@webkit.org
  • 23 edits
    2 adds in trunk

SVGColor custom text format is different from the CSS color custom text format
​https://bugs.webkit.org/show_bug.cgi?id=148879

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2015-09-11
Reviewed by Daniel Bates.

Source/WebCore:

Implement the serialization of a CSS color value as it is described in
<​https://drafts.csswg.org/cssom/#serializing-css-values>. Add the new
function Color::cssText() which is refactored from the existing function
Color::serialized(). Use the new function for serializing the SVGColor
always and also for Color but only when the alpha component is not 1.

Test: svg/css/computed-style-rgb-color.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText): Move the code
for serializing the color from this function to Color::cssText().

  • platform/graphics/Color.cpp:

(WebCore::Color::serialized): Call Color::cssText() if the alpha component
is not 1 and delete the repeated code.

(WebCore::Color::cssText):

  • platform/graphics/Color.h: Add the new function to the header file.
  • svg/SVGColor.cpp:

(WebCore::SVGColor::customCSSText): Call Color::cssText() always instead
of calling Color::serialized() for serializing the SVGColor.

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/parse-color-int-or-percent-crash.html:
  • platform/mac/svg/webarchive/svg-script-subresouces-expected.txt:
  • svg/css/case-sensitive-tags-expected.txt:
  • svg/css/case-sensitive-tags.html:
  • svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/script-tests/svg-attribute-parser-mode.js:
  • svg/css/svg-attribute-parser-mode-expected.txt:
  • svg/dom/SVGColor-expected.txt:
  • svg/dom/SVGPaint-expected.txt:
  • svg/dom/SVGStyleElement/disable-svg-style-element-expected.txt:
  • svg/dom/SVGStyleElement/script-tests/disable-svg-style-element.js:
  • svg/dom/script-tests/SVGColor.js:
  • svg/dom/script-tests/SVGPaint.js:
  • svg/webarchive/svg-script-subresouces-expected.webarchive:
  • transitions/svg-transitions-expected.txt:

Fix expected results for existing tests

  • svg/css/computed-style-rgb-color-expected.txt: Added.
  • svg/css/computed-style-rgb-color.html: Added.

Ensure that the correct format is returned when getComputedStyle() is
called for an SVG color.

5:57 PM Changeset in webkit [189645] by commit-queue@webkit.org
  • 7 edits in trunk/Source/JavaScriptCore

Implement the relational instructions for floats in WebAssembly
​https://bugs.webkit.org/show_bug.cgi?id=149080

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-11
Reviewed by Geoffrey Garen.

This patch implements the relational instructions for floats (float32)
in WebAssembly by converting float operands to doubles and then
comparing them using the existing double comparison instructions in the
macro assembler.

  • tests/stress/wasm-relational.js:
  • tests/stress/wasm/relational.wasm:
  • wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::buildRelationalF32):

  • wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseRelationalF32ExpressionI32):

  • wasm/WASMFunctionParser.h:
  • wasm/WASMFunctionSyntaxChecker.h:

(JSC::WASMFunctionSyntaxChecker::buildRelationalF32):

5:53 PM Changeset in webkit [189644] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

5:49 PM Changeset in webkit [189643] by bshafiei@apple.com
  • 5 edits in branches/safari-601-branch/Source

Versioning.

5:47 PM Changeset in webkit [189642] by commit-queue@webkit.org
  • 15 edits
    4 adds in trunk

AX: ARIA 1.1 @aria-current
​https://bugs.webkit.org/show_bug.cgi?id=146012

Patch by Nan Wang <​n_wang@apple.com> on 2015-09-11
Reviewed by Chris Fleizach.

Source/JavaScriptCore:

Updated inspector to support aria-current.

  • inspector/protocol/DOM.json:

Source/WebCore:

Tests: accessibility/aria-current.html

inspector/dom/getAccessibilityPropertiesForNode_ariaCurrent.html

Added support for ARIA 1.1 aria-current.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::invalidStatus):
(WebCore::AccessibilityObject::ariaCurrentState):
(WebCore::AccessibilityObject::hasTagName):

  • accessibility/AccessibilityObject.h:
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

  • html/HTMLAttributeNames.in:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

Source/WebInspectorUI:

Added support for ARIA 1.1 aria-current.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Models/DOMNode.js:
  • UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

LayoutTests:

  • accessibility/aria-current-expected.txt: Added.
  • accessibility/aria-current.html: Added.
  • inspector/dom/getAccessibilityPropertiesForNode_ariaCurrent-expected.txt: Added.
  • inspector/dom/getAccessibilityPropertiesForNode_ariaCurrent.html: Added.
  • platform/gtk/TestExpectations:
  • platform/win/TestExpectations:
5:38 PM Changeset in webkit [189641] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.23

New tag.

5:38 PM Changeset in webkit [189640] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.2.4

New tag.

5:15 PM Changeset in webkit [189639] by msaboff@apple.com
  • 2 edits in trunk/Tools

LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
​https://bugs.webkit.org/show_bug.cgi?id=149083

Reviewed by Alexey Proskuryakov.

Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.

  • DumpRenderTree/mac/LayoutTestHelper.m:

(colorProfileURLForDisplay):

4:55 PM Changeset in webkit [189638] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Mark http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html as flaky for
​https://bugs.webkit.org/show_bug.cgi?id=149082

4:05 PM Changeset in webkit [189637] by Beth Dakin
  • 2 edits in trunk/Source/WebKit2

Another build fix.

  • UIProcess/mac/ViewSnapshotStore.h:

(WebKit::ViewSnapshot::size):
(WebKit::ViewSnapshot::imageSizeInBytes):

3:52 PM Changeset in webkit [189636] by Dewei Zhu
  • 2 edits in trunk/LayoutTests

Update test for bug 148971
​https://bugs.webkit.org/show_bug.cgi?id=149076

Reviewed by Chris Dumez.

  • platform/win/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt: Updated.
3:31 PM Changeset in webkit [189635] by Beth Dakin
  • 4 edits in trunk/Source/WebKit2

Still need view snapshotting code for non-IOSurface for the sim
​https://bugs.webkit.org/show_bug.cgi?id=149077

Reviewed by Tim Horton.

This fixes the simulator build.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _takeViewSnapshot]):
(-[WKWebView _zoomToPoint:atScale:animated:]):

  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::removeSwipeSnapshot):

  • UIProcess/mac/ViewSnapshotStore.h:

(WebKit::ViewSnapshot::setDeviceScaleFactor):
(WebKit::ViewSnapshot::deviceScaleFactor):
(WebKit::ViewSnapshot::surface):
(WebKit::ViewSnapshot::imageSizeInBytes):
(WebKit::ViewSnapshot::size):

  • UIProcess/mac/ViewSnapshotStore.mm:

(WebKit::ViewSnapshotStore::singleton):
(WebKit::ViewSnapshotStore::snapshottingContext):
(WebKit::ViewSnapshotStore::didAddImageToSnapshot):
(WebKit::ViewSnapshotStore::discardSnapshotImages):
(WebKit::ViewSnapshot::create):
(WebKit::ViewSnapshot::ViewSnapshot):
(WebKit::ViewSnapshot::~ViewSnapshot):
(WebKit::ViewSnapshot::setSurface):
(WebKit::ViewSnapshot::hasImage):
(WebKit::ViewSnapshot::clearImage):
(WebKit::ViewSnapshot::asLayerContents):

2:40 PM Changeset in webkit [189634] by Sukolsak Sakshuwong
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json

Unreviewed, moved myself to the list of committers.

  • Scripts/webkitpy/common/config/contributors.json:
2:34 PM Changeset in webkit [189633] by keith_miller@apple.com
  • 3 edits
    1 add in trunk/Source/WTF

cryptographicallyRandomValuesFromOS should use CCRandomCopyBytes when available.
​https://bugs.webkit.org/show_bug.cgi?id=148439

Reviewed by Alexey Proskuryakov.

Recently, we switched to using arc4random_buf on Darwin but further research indicates that
arc4random_buf has the same behavior we had before and thus we were just pushing the problem
further down the stack. CCRandomCopyBytes, however, appears to be more advanced and has much
better error handling than we had before.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/OSRandomSource.cpp:

(WTF::cryptographicallyRandomValuesFromOS):

  • wtf/spi/darwin/CommonCryptoSPI.h: Added.
2:33 PM Changeset in webkit [189632] by Chris Dumez
  • 28 edits
    2 adds
    4 deletes in trunk

DOMTokenList update steps for classList don't follow the spec
​https://bugs.webkit.org/show_bug.cgi?id=148589
<rdar://problem/22547443>

Reviewed by Ryosuke Niwa and Darin Adler.

LayoutTests/imported/w3c:

Rebaseline W3C tests for DOMTokenList now that more checks are passing.

  • web-platform-tests/dom/lists/DOMTokenList-stringifier-expected.txt:
  • web-platform-tests/dom/nodes/Element-classlist-expected.txt:

Source/WebCore:

Update our DOMTokenList implementation to behave according to
the latest DOM specification:
​https://dom.spec.whatwg.org/#interface-domtokenlist

In particular, the following changes were made:

  • The stringifier now returns the result of the ordered set serializer for tokens. This means that we drop duplicate spaces and extra spaces [1][2][3].
  • DOMSettableTokenList.value now returns the result of the ordered set serializer for tokens [4] as well.
  • When the DOMTokenList's tokens are updated and there is an associated Element attribute, we set the attribute value to be the the ordered set serializer for tokens. This is according to the DOMTokenList update steps in the specification [6]. Chrome does not match the specification either.

Edge browser behaves according to the specification already. Firefox was
implementing this via [7] but no recent progress. This makes the JS API
nicer to use and interest was shown by jQuery Team.

The following refactoring was done:

  • Merge ClassList / RelList into a single AttributeDOMTokenList class as their code is mostly duplicated and the only thing that changes is which attribute is associated (class vs rel). AttributeDOMTokenList now keeps the attribute name as a member so it could be used for any attribute. AttributeDOMTokenList overrides DOMTokenList's updateAfterTokenChange() to do update the attribute's value as per [6].
  • We no longer use a SpaceSplitString for the internal representation as we need to sanitize the tokens (drop duplicates and extra spaces). DOMTokenList now has an internal Vector<AtomicString> containing the tokens that is constructed from the algorithm in [2]. As a result, most of the logic is now in DOMTokenList instead of its subclasses which means that most methods are no longer virtual. We only have one virtual function named updateAfterTokenChange() to do the update steps as AttributeDOMTokenList needs to update the associated attribute.

This change does not seem to impact Dromaeo.

[1] ​https://dom.spec.whatwg.org/#concept-ordered-set-serializer
[2] ​https://dom.spec.whatwg.org/#ordered%20sets
[3] ​https://dom.spec.whatwg.org/#stringification-behavior
[4] ​https://dom.spec.whatwg.org/#dom-domsettabletokenlist-value
[5] ​https://dom.spec.whatwg.org/#dom-domtokenlist-contains (step 2)
[6] ​https://dom.spec.whatwg.org/#concept-DTL-update
[7] ​https://bugzilla.mozilla.org/show_bug.cgi?id=869788

No new tests, already covered by existing tests.

  • dom/Element.cpp:

(WebCore::Element::classAttributeChanged):
When the class attribute changes, make sure to update the associated
classList if there is one. We could do this lazily if it turns out
to be a performance problem. However, chances are this is not as
classList is rarely used and we only need to update the classList if
it was ever accessed by JS for this Element.

(WebCore::Element::insertedInto):
Drop call to clearClassListValueForQuirksMode() as we no longer need
to maintain a separate SpaceSplitString for classes when in quirks
mode. This is because AttributeDOMTokenList now has its own Vector
of classes in their original cases. It therefore no longer relies on
Element::classNames() which has its case folded when in quirks mode.

(WebCore::Element::classList):
Return a AttributeDOMTokenList instead of a ClassList.

  • html/AttributeDOMTokenList.h: Added.
  • html/AttributeDOMTokenList.cpp: Added.

(WebCore::AttributeDOMTokenList::AttributeDOMTokenList):
Call DOMTokenList::setValue() using the attribute's value so that
DOMTokenList can initialize its token Vector.

(WebCore::AttributeDOMTokenList::attributeValueChanged):
If the attribute value was changed by somebody else that the
AttributeDOMTokenList, call DOMTokenList::setValue() so that it
can update its token Vector.

(WebCore::AttributeDOMTokenList::updateAfterTokenChange):
This is called whenever the token Vector is changed via JS. In
this case, we update the associated attribute's value.

  • html/ClassList.cpp: Removed.
  • html/ClassList.h: Removed.

Now merged into AttributeDOMTokenList.

  • html/DOMSettableTokenList.cpp:
  • html/DOMSettableTokenList.h:

Get rid of most of the code as most of the logic is now in
DOMTokenList parent class.

  • html/DOMTokenList.cpp:

(WebCore::DOMTokenList::validateToken):
Use a String parameter instead of an AtomicString as this method does
not need the input the be an AtomicString. This avoid atomizing
String unnecessarily.

(WebCore::DOMTokenList::validateTokens):
Use a modern loop.

(WebCore::DOMTokenList::contains):
No longer use containsInternal() virtual function. We can now check
the internal token Vector.

(WebCore::DOMTokenList::add):
Now update the internal Vector. Use a modern loop and try to minimize
Vector capacity reallocation.

(WebCore::DOMTokenList::remove):
Now update the internal Vector.

(WebCore::DOMTokenList::toggle):
Now update the internal Vector and refactor the code so that it is
structured exactly as the algorithm in the specification for
clarity.

(WebCore::DOMTokenList::value):
Now return the result of the ordered set serializer for tokens. This
method is used for:

  • The DOMSettableTokenList.value() getter
  • The DOMTokenList stringifier
  • As attribute value when updating the associated attribute in AttributeDOMTokenList.

(WebCore::DOMTokenList::setValue):
Update the internal Vector using the algorithm in [2].

  • html/DOMTokenList.h:

(WebCore::DOMTokenList::length):
No longer virtual, now returns the size of the internal token Vector.

(WebCore::DOMTokenList::item):
No longer virtual, now returns the token at the given index in the
internal Vector.

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::relList):
Now return a AttributeDOMTokenList.

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::relList):
Now return a AttributeDOMTokenList.

  • html/RelList.cpp: Removed.
  • html/RelList.h: Removed.

Now merged into AttributeDOMTokenList.

LayoutTests:

Update / rebaseline existing tests as our behavior changed.

  • fast/dom/HTMLElement/class-list-expected.txt:
  • fast/dom/HTMLElement/class-list-quirks-expected.txt:
  • fast/dom/HTMLElement/script-tests/class-list.js:
  • fast/dom/HTMLOutputElement/dom-settable-token-list-expected.txt:
  • fast/dom/HTMLOutputElement/htmloutputelement-expected.txt:
  • fast/dom/HTMLOutputElement/htmloutputelement.html:
  • fast/dom/HTMLOutputElement/script-tests/dom-settable-token-list.js:
  • fast/dom/rel-list-expected.txt:
  • fast/dom/rel-list.html:
2:28 PM Changeset in webkit [189631] by achristensen@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening to make Windows bot green.

  • platform/win/TestExpectations:

imported/w3c/web-platform-tests/html/dom/interfaces.html is newly imported and fails on Windows.

2:28 PM Changeset in webkit [189630] by Beth Dakin
  • 2 edits in trunk/Source/WebKit2

Build fix

  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::removeSwipeSnapshot):

2:26 PM Changeset in webkit [189629] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Mark svg/animations/svgboolean-animation-1 as flaky for
​https://bugs.webkit.org/show_bug.cgi?id=149072

2:24 PM Changeset in webkit [189628] by Beth Dakin
  • 4 edits in trunk/Source/WebKit2

Should use CARenderServerRenderLayerWithTransform for snapshots on iOS
​https://bugs.webkit.org/show_bug.cgi?id=149069
-and corresponding-
rdar://problem/19726953

Reviewed by Tim Horton.

This will let us own the backing IOSurface, which will let us share more code
with Mac.

Use CARenderServerRenderLayerWithTransform

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _takeViewSnapshot]):
(-[WKWebView _zoomToPoint:atScale:animated:]):

We can eliminate things needed for the slot-based API.

  • UIProcess/mac/ViewSnapshotStore.h:

(WebKit::ViewSnapshot::setDeviceScaleFactor):
(WebKit::ViewSnapshot::deviceScaleFactor):
(WebKit::ViewSnapshot::surface):
(WebKit::ViewSnapshot::imageSizeInBytes):
(WebKit::ViewSnapshot::size):

  • UIProcess/mac/ViewSnapshotStore.mm:

(WebKit::ViewSnapshotStore::singleton):
(WebKit::ViewSnapshotStore::didAddImageToSnapshot):
(WebKit::ViewSnapshotStore::discardSnapshotImages):
(WebKit::ViewSnapshot::create):
(WebKit::ViewSnapshot::ViewSnapshot):
(WebKit::ViewSnapshot::~ViewSnapshot):
(WebKit::ViewSnapshot::setSurface):
(WebKit::ViewSnapshot::hasImage):
(WebKit::ViewSnapshot::clearImage):
(WebKit::ViewSnapshot::asLayerContents):
(WebKit::ViewSnapshotStore::snapshottingContext): Deleted.

2:23 PM Changeset in webkit [189627] by Sukolsak Sakshuwong
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json

Unreviewed, added myself to the list of contributors.

  • Scripts/webkitpy/common/config/contributors.json:
11:59 AM Changeset in webkit [189626] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

fast/hidpi/image-set-without-specified-width.html flakily tries to install multiple callbacks for the same event
​https://bugs.webkit.org/show_bug.cgi?id=149067

Reviewed by Alexey Proskuryakov.

  • fast/hidpi/image-set-without-specified-width.html:

Wait until we've successfully set the deviceScaleFactor
before reloading the page; otherwise, we can end up trying to set it
again after the reload (and depending on how long it takes the callback
to return, again, and again, and again...)

11:44 AM Changeset in webkit [189625] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
​https://bugs.webkit.org/show_bug.cgi?id=149058

Patch by Saam barati <​sbarati@apple.com> on 2015-09-11
Reviewed by Geoffrey Garen.

  • Scripts/run-jsc-stress-tests:
11:40 AM Changeset in webkit [189624] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk/Source/JavaScriptCore

Add initial support for floats in WebAsssembly
​https://bugs.webkit.org/show_bug.cgi?id=149062

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-11
Reviewed by Geoffrey Garen.

Implement the ConstantPoolIndex, Immediate, GetLocal, and GetGlobal
instructions for floats (float32) in WebAssembly.

  • tests/stress/wasm-arithmetic-float32.js: Added.

(shouldBe):

  • tests/stress/wasm-globals.js:
  • tests/stress/wasm-type-conversion.js:
  • tests/stress/wasm/arithmetic-float32.wasm: Added.
  • tests/stress/wasm/globals.wasm:
  • tests/stress/wasm/type-conversion.wasm:
  • wasm/WASMConstants.h:
  • wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::buildSetLocal):
(JSC::WASMFunctionCompiler::buildReturn):
(JSC::WASMFunctionCompiler::buildImmediateF32):
(JSC::WASMFunctionCompiler::buildGetLocal):

  • wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseExpression):
(JSC::WASMFunctionParser::parseExpressionF32):
(JSC::WASMFunctionParser::parseConstantPoolIndexExpressionF32):
(JSC::WASMFunctionParser::parseImmediateExpressionF32):
(JSC::WASMFunctionParser::parseGetLocalExpressionF32):
(JSC::WASMFunctionParser::parseGetGlobalExpressionF32):

  • wasm/WASMFunctionParser.h:
  • wasm/WASMFunctionSyntaxChecker.h:

(JSC::WASMFunctionSyntaxChecker::buildImmediateF32):

  • wasm/WASMReader.cpp:

(JSC::WASMReader::readOpExpressionF32):

  • wasm/WASMReader.h:
10:35 AM Changeset in webkit [189623] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2015-09-11 Geoffrey Garen <​ggaren@apple.com>

Try to fix the CLOOP build.

Unreviewed.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::finalizeBaselineJITInlineCaches): (JSC::CodeBlock::finalizeUnconditionally):
9:56 AM Changeset in webkit [189622] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

[EFL] Fix WASM build
​https://bugs.webkit.org/show_bug.cgi?id=149065

Reviewed by Darin Adler.

  • wasm/WASMFunctionParser.cpp:
9:21 AM Changeset in webkit [189621] by ap@apple.com
  • 2 edits in trunk/LayoutTests

El Capitan test result gardening.

  • platform/mac/TestExpectations: Remove a test that should pass now.
9:08 AM Changeset in webkit [189620] by ggaren@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

JavaScriptCore should discard optimized code after some time
​https://bugs.webkit.org/show_bug.cgi?id=149048

Reviewed by Michael Saboff.

This patch adds a new jettison type -- JettisonDueToOldAge -- and starts
using it for DFG and FTL code. Baseline and LLInt code will come in a
follow-up patch.

The primary goal is to save memory. Some popular websites leave about 10MB
of dead code sitting around immediately after they finish loading.

Throwing away code periodically might also save us from profiling
pathologies that lead to performance dead ends.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate): Updated for rename, and removed a
stale comment.

(JSC::CodeBlock::shouldVisitStrongly): Renamed to shouldVisitStrongly
because the practical effect of this function is to trigger a call to
visitStrongly.

(JSC::CodeBlock::isKnownToBeLiveDuringGC): Check the
m_visitStronglyHasBeenCalled flag instead of
shouldImmediatelyAssumeLivenessDuringScan / shouldVisitStrongly because
m_visitStronglyHasBeenCalled can be set by anybody even if the CodeBlock
would not otherwise visit itself strongly.

(JSC::CodeBlock::shouldJettisonDueToWeakReference): New helper function
for readability.

(JSC::CodeBlock::shouldJettisonDueToOldAge): New helper function that
tells if a CodeBlock is old enough for deletion.

(JSC::CodeBlock::determineLiveness): There's no need to check
shouldImmediatelyAssumeLivenessDuringScan here because we will not call
this function if shouldImmediatelyAssumeLivenessDuringScan is true.
Also, it's just not clear -- if someone chooses to call this function --
that it would be safe to ignore them simply because
shouldImmediatelyAssumeLivenessDuringScan was true.

(JSC::CodeBlock::finalizeLLIntInlineCaches): Moved code out into a helper
function to make the main function more readable.

(JSC::CodeBlock::finalizeBaselineJITInlineCaches): Ditto.

(JSC::CodeBlock::finalizeUnconditionally): Added code for jettisoning a
CodeBlock if it is too old. Moved large sections of code into helper
functions to aid readability in this function.

(JSC::CodeBlock::jettison): Account for the fact that we might jettison
a CodeBlock without OSR exit and without requiring a stack shoot-down.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::setInstallTime):
(JSC::CodeBlock::timeSinceInstall): Track CodeBlock age to help us
decide when to delete.

  • jit/JITCode.h:

(JSC::JITCode::timeToLive): Static limits on CodeBlock lifetime. I got
these numbers from the place where numbers come from.

  • profiler/ProfilerJettisonReason.cpp:

(WTF::printInternal):

  • profiler/ProfilerJettisonReason.h: Updated for new jettison type.
  • runtime/Executable.cpp:

(JSC::ScriptExecutable::installCode): Record install time so that we
can measure how old a CodeBlock is.

9:05 AM Changeset in webkit [189619] by ap@apple.com
  • 2 edits in branches/safari-601-branch/LayoutTests

Test result gardening - correct the paths for the branch.

  • platform/mac/TestExpectations:
7:51 AM Changeset in webkit [189618] by Chris Dumez
  • 10 edits in trunk

Element.tagName should be upper-case for HTML elements in HTML documents
​https://bugs.webkit.org/show_bug.cgi?id=148843
<rdar://problem/22559081>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing.

  • web-platform-tests/dom/nodes/Document-createElementNS-expected.txt:
  • web-platform-tests/dom/nodes/Element-tagName-expected.txt:
  • web-platform-tests/dom/nodes/Node-nodeName-expected.txt:
  • web-platform-tests/html/semantics/tabular-data/the-table-element/table-insertRow-expected.txt:

Source/WebCore:

Element.tagName should be upper-case for HTML elements in HTML documents,
as per the DOM specification:
​https://dom.spec.whatwg.org/#dom-element-tagname

Previously, WebKit would fail to upper-case the tagname if the element's
tag had a prefix. This patch corrects this. This aligns our behavior with
Firefox, Chrome and IE.

No new tests, already covered by existing tests.

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::nodeName):

LayoutTests:

Update / rebaseline test now that our behavior has changed.

  • fast/dom/Node/initial-values-expected.txt:
  • fast/dom/Node/script-tests/initial-values.js:
7:50 AM Changeset in webkit [189617] by Chris Dumez
  • 6 edits in trunk

document.body = "text" should throw a TypeError, not a HierarchyRequestError
​https://bugs.webkit.org/show_bug.cgi?id=149057
<rdar://problem/22567157>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline test now that a new check is passing.

  • web-platform-tests/html/dom/documents/dom-tree-accessors/document.body-setter-01-expected.txt:

Source/WebCore:

document.body = "text" should throw a TypeError, not a
HierarchyRequestError:
​https://html.spec.whatwg.org/multipage/dom.html#dom-document-body

This is because "text" is a DOMString and it cannot be converted into an
HTMLElement?. Therefore, the WebIDL specification says we should throw a
TypeError in this case.

Chrome and Firefox throw the right exception.

No new tests, already covered by existing test.

  • dom/Document.idl:

LayoutTests:

Rebaseline test as we now throw a different exception.

  • fast/dom/setter-type-enforcement-expected.txt:
6:03 AM WebKitGTK/2.8.x edited by clopez@igalia.com
(diff)
2:16 AM Changeset in webkit [189616] by akling@apple.com
  • 74 edits in trunk/Source

[JSC] Weak should only accept cell pointees.
<​https://webkit.org/b/148955>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Since WeakImpls only support pointing to JSCell derived objects,
enforce that at compile time by having the API use JSCell* instead of JSValue.

WeakHandleOwner callbacks now get JSCell& and JSCell*& respectively instead
of wrapping the cell pointer in a Handle<Unknown>.

Also added a static_assert so Weak<T> can't be instantiated with a T that's
not convertible to JSCell.

  • API/JSAPIWrapperObject.mm:

(JSAPIWrapperObjectHandleOwner::finalize):
(JSAPIWrapperObjectHandleOwner::isReachableFromOpaqueRoots):
(JSC::JSAPIWrapperObject::finishCreation):

  • API/JSManagedValue.mm:

(JSManagedValueHandleOwner::isReachableFromOpaqueRoots):
(JSManagedValueHandleOwner::finalize):

  • builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::finalize):

  • builtins/BuiltinExecutables.h:
  • heap/Heap.cpp:

(JSC::Heap::addFinalizer):
(JSC::Heap::FinalizerOwner::finalize):

  • heap/Heap.h:
  • heap/WeakBlock.cpp:

(JSC::WeakBlock::visit):
(JSC::WeakBlock::reap):

  • heap/WeakHandleOwner.cpp:

(JSC::WeakHandleOwner::isReachableFromOpaqueRoots):
(JSC::WeakHandleOwner::finalize):

  • heap/WeakHandleOwner.h:
  • heap/WeakImpl.h:

(JSC::WeakImpl::WeakImpl):
(JSC::WeakImpl::state):
(JSC::WeakImpl::cell):
(JSC::WeakImpl::asWeakImpl):
(JSC::WeakImpl::jsValue): Deleted.

  • heap/WeakInlines.h:

(JSC::Weak<T>::Weak):
(JSC::>):
(JSC::Weak<T>::operator):
(JSC::Weak<T>::get):
(JSC::Weak<T>::was):

  • heap/WeakSet.h:
  • heap/WeakSetInlines.h:

(JSC::WeakSet::allocate):
(JSC::WeakBlock::finalize):

  • jit/JITThunks.cpp:

(JSC::JITThunks::finalize):

  • jit/JITThunks.h:
  • jsc.cpp:

(WTF::ElementHandleOwner::isReachableFromOpaqueRoots): Deleted.

  • runtime/JSCell.h:

(JSC::jsCast):

  • runtime/RegExpCache.cpp:

(JSC::RegExpCache::finalize):

  • runtime/RegExpCache.h:
  • runtime/Structure.cpp:

(JSC::StructureTransitionTable::singleTransition):
(JSC::StructureTransitionTable::setSingleTransition):

Source/WebCore:

Update WebCore bindings for the new Weak and Weak-related signatures.

  • bindings/js/JSCSSRuleListCustom.cpp:

(WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots):

  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
(WebCore::JSCSSValueOwner::finalize):

  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackDataWeak::WeakOwner::isReachableFromOpaqueRoots):

  • bindings/js/JSCallbackData.h:
  • bindings/js/JSMutationObserverCustom.cpp:

(WebCore::JSMutationObserverOwner::isReachableFromOpaqueRoots):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::isReachableFromDOM):
(WebCore::JSNodeOwner::isReachableFromOpaqueRoots):

  • bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):

  • bindings/js/JSTextTrackCueCustom.cpp:

(WebCore::JSTextTrackCueOwner::isReachableFromOpaqueRoots):

  • bindings/js/WebCoreTypedArrayController.cpp:

(WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::isReachableFromOpaqueRoots):
(WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::finalize):

  • bindings/js/WebCoreTypedArrayController.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObjectOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestActiveDOMObjectOwner::finalize):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.h:
  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::JSTestCustomConstructorWithNoInterfaceObjectOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectOwner::finalize):

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.h:
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetterOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestCustomNamedGetterOwner::finalize):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestEventConstructorOwner::finalize):

  • bindings/scripts/test/JS/JSTestEventConstructor.h:
  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTargetOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestEventTargetOwner::finalize):

  • bindings/scripts/test/JS/JSTestEventTarget.h:
  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestExceptionOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestExceptionOwner::finalize):

  • bindings/scripts/test/JS/JSTestException.h:
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachableOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestGenerateIsReachableOwner::finalize):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestInterfaceOwner::finalize):

  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestMediaQueryListListenerOwner::finalize):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestNamedConstructorOwner::finalize):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:
  • bindings/scripts/test/JS/JSTestNondeterministic.cpp:

(WebCore::JSTestNondeterministicOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestNondeterministicOwner::finalize):

  • bindings/scripts/test/JS/JSTestNondeterministic.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestObjOwner::finalize):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestOverloadedConstructorsOwner::finalize):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::JSTestOverrideBuiltinsOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestOverrideBuiltinsOwner::finalize):

  • bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestTypedefsOwner::finalize):

  • bindings/scripts/test/JS/JSTestTypedefs.h:
  • bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::JSattributeOwner::isReachableFromOpaqueRoots):
(WebCore::JSattributeOwner::finalize):

  • bindings/scripts/test/JS/JSattribute.h:
  • bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::JSreadonlyOwner::isReachableFromOpaqueRoots):
(WebCore::JSreadonlyOwner::finalize):

  • bindings/scripts/test/JS/JSreadonly.h:
  • bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::finalize):

  • bridge/runtime_root.h:

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::finalize):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
12:17 AM Changeset in webkit [189615] by bshafiei@apple.com
  • 4 edits in tags/Safari-601.1.56.2

Merged r189598. rdar://problem/22657165

12:15 AM Changeset in webkit [189614] by bshafiei@apple.com
  • 4 edits
    2 copies in tags/Safari-601.1.56.2

Merged r189483. rdar://problem/22657165

12:12 AM Changeset in webkit [189613] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.56.2/Source

Versioning.

12:08 AM Changeset in webkit [189612] by bshafiei@apple.com
  • 4 edits in branches/safari-601-branch

Merged r189598. rdar://problem/22657171

12:07 AM Changeset in webkit [189611] by bshafiei@apple.com
  • 4 edits
    2 copies in branches/safari-601-branch

Merged r189483. rdar://problem/22657171

12:01 AM Changeset in webkit [189610] by bshafiei@apple.com
  • 11 edits
    8 copies in branches/safari-601-branch

Merged r189469. rdar://problem/22316524

12:01 AM Changeset in webkit [189609] by bshafiei@apple.com
  • 11 edits
    8 copies in branches/safari-601.1.46-branch

Merged r189469. rdar://problem/22422752

Note: See TracTimeline for information about the timeline view.