Timeline

Sep 16, 2015:

11:51 PM Changeset in webkit [189907] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Reduce Annotation Update Frequency
​https://bugs.webkit.org/show_bug.cgi?id=149250

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-16
Reviewed by Saam Barati.

• UserInterface/Controllers/BasicBlockAnnotator.js:

(WebInspector.BasicBlockAnnotator.prototype._annotateBasicBlockExecutionRanges):

• UserInterface/Controllers/TypeTokenAnnotator.js:

(WebInspector.BasicBlockAnnotator.prototype.insertAnnotations):
Set a lower bound of 500ms on update frequency for both annotators.

11:12 PM Changeset in webkit [189906] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

removeShadow shouldn't call ChildNodeRemovalNotifier with the shadow host as the removal point
​https://bugs.webkit.org/show_bug.cgi?id=149244

Reviewed by Antti Koivisto.

Since a shadow host is in a different tree than nodes in its shadow tree, it's incorrect to call
removedFrom with the shadow host as the removal point. This causes HTMLSlotElement::removedFrom
which will be added in the bug 149241 to call methods on a wrong ShadowRoot.

We still keep the ad-hoc behavior of using the shadow host as the insertion/removal point when
calling insertedInto and removedFrom on the shadow root itself to update the InDocument node flag.
We may want to re-visit this design in the future.

No new tests since I couldn't quite create a reduction. However, tests I'm adding in the bug 149241
will crash without this change.

I separated this patch from the bug 149241 to isolate the high-risk code change here.

• dom/Element.cpp:

(WebCore::Element::addShadowRoot): Call insertedInto on ShadowRoot, and then call it on all its
children separately with the insertion point set to the shadow root since insertedInto relies on
insertion point's inDocument flag to be true when the shadow host is in the document.
(WebCore::Element::removeShadowRoot): Ditto in the reverse order.

10:40 PM Changeset in webkit [189905] by Gyuyoung Kim

• 27 edits in trunk/Source/WebCore

Remove all uses of PassRefPtr in WebCore/inspector
​https://bugs.webkit.org/show_bug.cgi?id=149156

Reviewed by Darin Adler.

• inspector/DOMEditor.cpp:

(WebCore::DOMEditor::InsertBeforeAction::InsertBeforeAction):
(WebCore::DOMEditor::ReplaceChildNodeAction::ReplaceChildNodeAction):
(WebCore::DOMEditor::insertBefore):
(WebCore::DOMEditor::replaceChild):

• inspector/DOMEditor.h:
• inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::removeChildAndMoveToNew):

• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::highlightSelector):

• inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::didOpenDatabase):

• inspector/InspectorDatabaseAgent.h:
• inspector/InspectorDatabaseInstrumentation.h:
• inspector/InspectorDatabaseResource.h:

(WebCore::InspectorDatabaseResource::setDatabase):

• inspector/InspectorFrontendHost.cpp:

(WebCore::FrontendMenuProvider::create):

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didOpenDatabaseImpl):

• inspector/InspectorLayerTreeAgent.h:
• inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::highlightNodeList):

• inspector/InspectorOverlay.h:
• inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::sharedBufferContent):

• inspector/InspectorPageAgent.h:
• inspector/InspectorResourceAgent.cpp:
• inspector/InspectorTimelineAgent.cpp:

(WebCore::startProfiling):
(WebCore::stopProfiling):
(WebCore::InspectorTimelineAgent::stopFromConsole):

• inspector/InspectorTimelineAgent.h:
• inspector/InspectorWorkerResource.h:

(WebCore::InspectorWorkerResource::create):

• inspector/InstrumentingAgents.h:
• inspector/NetworkResourcesData.cpp:

(WebCore::createOtherResourceTextDecoder):
(WebCore::NetworkResourcesData::addResourceSharedBuffer):

• inspector/NetworkResourcesData.h:
• inspector/TimelineRecordFactory.cpp:

(WebCore::createQuad):

• inspector/WebInjectedScriptHost.h:
• inspector/WebInjectedScriptManager.cpp:

(WebCore::WebInjectedScriptManager::WebInjectedScriptManager):

• inspector/WebInjectedScriptManager.h:

10:22 PM Changeset in webkit [189904] by rniwa@webkit.org

• 2 edits
  1 move in trunk/LayoutTests

Add failing expectation to css3/font-feature-settings-rendering-2.html on Mavericks.
The test failure is tracked by webkit.org/b/149246.

Also rebaseline js/dom/global-constructors-attributes-idb.html on WK1 after r189879.

• js/dom/global-constructors-attributes-idb-expected.txt: Replaced with LayoutTests/platform/wk2/js/dom/global-constructors-attributes-idb-expected.txt.
• platform/mac/TestExpectations:
• platform/wk2/js/dom/global-constructors-attributes-idb-expected.txt: Removed.

10:15 PM Changeset in webkit [189903] by bshafiei@apple.com

• 10 edits
  2 copies in branches/safari-601-branch/Source/WebCore

Merged r189821. rdar://problem/22722908

9:40 PM Changeset in webkit [189902] by bshafiei@apple.com

• 3 edits
  2 copies in branches/safari-601.1.46-branch

Merged r189862. rdar://problem/22710613

9:27 PM Changeset in webkit [189901] by beidson@apple.com

• 4 edits
  2 adds in trunk

Have window.indexedDB.open return an IDBOpenDBRequest.
​https://bugs.webkit.org/show_bug.cgi?id=149234

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/opendatabase-request.html

• Modules/indexeddb/client/IDBFactoryImpl.cpp:

(WebCore::IDBClient::IDBFactory::open):
(WebCore::IDBClient::IDBFactory::openInternal):

• Modules/indexeddb/client/IDBFactoryImpl.h:

LayoutTests:

• storage/indexeddb/modern/opendatabase-request-expected.txt: Added.
• storage/indexeddb/modern/opendatabase-request.html: Added.

9:04 PM Changeset in webkit [189900] by bshafiei@apple.com

• 9 edits
  1 delete in branches/safari-601.1.46.7-branch

Merged r188311. rdar://problem/22618975

8:59 PM Changeset in webkit [189899] by bshafiei@apple.com

• 2 edits
  1 copy in branches/safari-601.1.46.7-branch/Source/JavaScriptCore

Merged r189012. rdar://problem/22619016

8:49 PM Changeset in webkit [189898] by bshafiei@apple.com

• 5 edits in branches/safari-601.1.46.7-branch/Source

Versioning.

8:47 PM Changeset in webkit [189897] by bshafiei@apple.com

• 1 copy in branches/safari-601.1.46.7-branch

New Branch.

8:27 PM Changeset in webkit [189896] by Antti Koivisto

• 5 edits in trunk/Source/WebCore

Turn ChildNodeInsertion/RemovalNotifier classes into functions
​https://bugs.webkit.org/show_bug.cgi?id=149236

Reviewed by Ryosuke Niwa.

Less architecture, more readability.

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::notifyChildInserted):
(WebCore::ContainerNode::notifyChildRemoved):
(WebCore::ContainerNode::removeChildren):

• dom/ContainerNodeAlgorithms.cpp:

(WebCore::notifyDescendantInsertedIntoDocument):
(WebCore::notifyDescendantInsertedIntoTree):
(WebCore::notifyNodeInsertedIntoDocument):
(WebCore::notifyNodeInsertedIntoTree):
(WebCore::notifyChildNodeInserted):
(WebCore::notifyNodeRemovedFromDocument):
(WebCore::notifyNodeRemovedFromTree):
(WebCore::notifyChildNodeRemoved):
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument): Deleted.
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoTree): Deleted.
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument): Deleted.
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromTree): Deleted.

• dom/ContainerNodeAlgorithms.h:

(WebCore::ChildNodeInsertionNotifier::ChildNodeInsertionNotifier): Deleted.
(WebCore::ChildNodeRemovalNotifier::ChildNodeRemovalNotifier): Deleted.
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument): Deleted.
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree): Deleted.
(WebCore::ChildNodeInsertionNotifier::notify): Deleted.
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromDocument): Deleted.
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree): Deleted.
(WebCore::ChildNodeRemovalNotifier::notify): Deleted.

• dom/Element.cpp:

(WebCore::Element::addShadowRoot):
(WebCore::Element::removeShadowRoot):
(WebCore::Element::createShadowRoot):

8:00 PM Changeset in webkit [189895] by Gyuyoung Kim

• 20 edits in trunk/Source/WebCore

Remove all uses of PassRefPtr in WebCore/bindings
​https://bugs.webkit.org/show_bug.cgi?id=149207

Reviewed by Darin Adler.

If RefPtr<>&& argument is passed to new variable or other function, we use copyRef() or WTF::move().
copyRef() should be used when the argument continues to be used in following code. If it is final use
inside function, we have to use WTF::move().

• bridge/NP_jsobject.cpp:
• bridge/NP_jsobject.h:
• bridge/c/CRuntimeObject.cpp:

(JSC::Bindings::CRuntimeObject::CRuntimeObject):

• bridge/c/CRuntimeObject.h:

(JSC::Bindings::CRuntimeObject::create):

• bridge/c/c_instance.cpp:

(JSC::Bindings::CInstance::CInstance):

• bridge/c/c_instance.h:

(JSC::Bindings::CInstance::create):

• bridge/jsc/BridgeJSC.cpp:

(JSC::Bindings::Array::Array):
(JSC::Bindings::Instance::Instance):

• bridge/jsc/BridgeJSC.h:
• bridge/objc/ObjCRuntimeObject.h:

(JSC::Bindings::ObjCRuntimeObject::create):

• bridge/objc/ObjCRuntimeObject.mm:

(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):

• bridge/objc/WebScriptObjectProtocol.h:
• bridge/objc/objc_instance.h:
• bridge/objc/objc_instance.mm:

(ObjcInstance::ObjcInstance):
(ObjcInstance::create):

• bridge/objc/objc_runtime.h:
• bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcArray::ObjcArray):

• bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::RuntimeObject):

• bridge/runtime_object.h:
• bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::create):

• bridge/runtime_root.h:

6:35 PM Changeset in webkit [189894] by Sukolsak Sakshuwong

• 1 edit in trunk/Source/JavaScriptCore/jit/JITOperations.cpp

Build fix for WebAssembly after r189884

• jit/JITOperations.cpp

6:24 PM Changeset in webkit [189893] by Chris Dumez

• 4 edits in trunk

LayoutTests/imported/w3c:
Element's attribute NS API should treat defined undefined namespace as null
​https://bugs.webkit.org/show_bug.cgi?id=149238
<rdar://problem/22562204>

Reviewed by Ryosuke Niwa.

Rebaseline W3C DOM test that one more check is passing.

• web-platform-tests/dom/nodes/attributes-expected.txt:

Source/WebCore:
Element's attribute NS API should defined treat undefined namespace as null
​https://bugs.webkit.org/show_bug.cgi?id=149238
<rdar://problem/22562204>

Reviewed by Ryosuke Niwa.

Element's attribute NS API should treat defined undefined namespace as null
instead of converting it to the "undefined" String. This is because the
namespace parameter is a nullable String as per the DOM spec:

• ​https://dom.spec.whatwg.org/#element

The attribute is nullable and WebIDL says undefined should be converted
to null for nullable parameters:

• ​https://heycam.github.io/webidl/#es-nullable-type (step 3)

Firefox follows the specification.

No new tests, already covered by existing test.

• dom/Element.idl:

6:23 PM Changeset in webkit [189892] by commit-queue@webkit.org

• 9 edits in trunk/Source/JavaScriptCore

Implement indirect calls in WebAssembly
​https://bugs.webkit.org/show_bug.cgi?id=149100

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-16
Reviewed by Geoffrey Garen.

This patch implement indirect calls for WebAssembly files generated by
pack-asmjs <​https://github.com/WebAssembly/polyfill-prototype-1>.
pack-asmjs uses the same indirect call model as asm.js. In asm.js, an
indirect call looks like this:

t[i & n](...)

where t is a variable referring to an array of functions with the same
signature, i is an integer expression, n is an integer that is equal to
(t.length - 1), and t.length is a power of two. pack-asmjs does not
use the '&' operator nor n in the WebAssembly output, but the semantics
is still the same as asm.js.

• tests/stress/wasm-calls.js:
• tests/stress/wasm/calls.wasm:
• wasm/WASMFormat.h:
• wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::buildCallIndirect):

• wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseExpressionF32):
(JSC::WASMFunctionParser::parseExpressionF64):
(JSC::WASMFunctionParser::parseCallIndirect):

• wasm/WASMFunctionParser.h:
• wasm/WASMFunctionSyntaxChecker.h:

(JSC::WASMFunctionSyntaxChecker::buildCallIndirect):

• wasm/WASMModuleParser.cpp:

(JSC::WASMModuleParser::parseFunctionPointerTableSection):
(JSC::WASMModuleParser::parseFunctionDefinitionSection):

6:16 PM Changeset in webkit [189891] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Fix 32-bit build issues in WebAssembly
​https://bugs.webkit.org/show_bug.cgi?id=149240

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-16
Reviewed by Geoffrey Garen.

Fix the syntax error and replace the instructions that are not available on
64-bit platforms.

• wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::startFunction):
(JSC::WASMFunctionCompiler::endFunction):
(JSC::WASMFunctionCompiler::buildReturn):
(JSC::WASMFunctionCompiler::callAndUnboxResult):
(JSC::WASMFunctionCompiler::loadValueAndConvertToDouble):

6:15 PM Changeset in webkit [189890] by mmaxfield@apple.com

• 4 edits
  10 adds in trunk

Create a font which can be used for testing font features
​https://bugs.webkit.org/show_bug.cgi?id=149237

Reviewed by Simon Fraser.

Tools:

This patch adds a new project in the Tools/ directory which generates a font which can
be used for testing font features. This is a standalone project consisting of two files:

1. A file which actually generates the byte vector representing the font. This file has

a single public function: std::vector<uint8_t> generateFont(). This file is not platform
specific, and only relies on the C++ STL.

2. A file with a main() which calls generateFont() and writes out the font, as well as

uses the font to render some demonstration text into a .png file. This file is platform
specific.

The font itself only supports the following characters:
ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
However, the shape of these letters are either an X or a check mark.

The letter "A" always is a check mark.
The letter "B" always is an X.
Without any font features turned on, the rest of the letters are shown as X.

Each font feature has an letter associated with it. When the font feature is enabled,
that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
as a check mark.

Here are the mappings of font features to letters:
liga: C
clig: D
dlig: E
hlig: F
calt: G
subs: H
sups: I
smcp: J
c2sc: K
pcap: L
c2pc: M
unic: N
titl: O
onum: P
pnum: Q
tnum: R
frac: S
afrc: T
ordn: U
zero: V
hist: W
jp78: X
jp83: Y
jp90: Z
jp04: a
smpl: b
trad: c
fwid: d
pwid: e
ruby: f

• FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
• FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.

(integralLog2):
(roundDownToPowerOfTwo):
(isFourByteAligned):
(clampTo):
(append32):
(writeCFFEncodedNumber):
(CFFBuilder::CFFBuilder):
(CFFBuilder::takeResult):
(CFFBuilder::moveTo):
(CFFBuilder::lineTo):
(CFFBuilder::curveToCubic):
(CFFBuilder::closePath):
(CFFBuilder::writePoint):
(generateBoxCharString):
(generateCheckCharString):
(generateXCharString):
(charStringForGlyph):
(Generator::generate):
(Generator::Placeholder::Placeholder):
(Generator::Placeholder::populate):
(Generator::Placeholder::~Placeholder):
(Generator::placeholder):
(Generator::append16):
(Generator::append32):
(Generator::append32BitCode):
(Generator::overwrite16):
(Generator::overwrite32):
(Generator::appendCFFTable):
(Generator::appendSubstitutionSubtable):
(Generator::appendScriptSubtable):
(Generator::appendGSUBTable):
(Generator::appendOS2Table):
(Generator::appendFormat12CMAPTable):
(Generator::appendFormat4CMAPTable):
(Generator::appendCMAPTable):
(Generator::appendHEADTable):
(Generator::appendHHEATable):
(Generator::appendHMTXTable):
(Generator::appendMAXPTable):
(Generator::appendNAMETable):
(Generator::appendPOSTTable):
(Generator::calculateChecksum):
(Generator::appendTable):
(generateFont):

• FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
• FontWithFeatures/FontWithFeatures/main.cpp: Added.

(drawTextWithFeature):
(main):

LayoutTests:

• css3/font-feature-settings-rendering-2-expected.html: Added.
• css3/font-feature-settings-rendering-2.html: Added.
• css3/resources/FontWithFeatures.otf: Added.
• platform/efl/TestExpectations:
• platform/win/TestExpectations:

5:28 PM Changeset in webkit [189889] by ggaren@apple.com

• 12 edits in trunk/Source/JavaScriptCore

JavaScriptCore should discard baseline code after some time
​https://bugs.webkit.org/show_bug.cgi?id=149220

Reviewed by Saam Barati.

This is a bit more complicated than discarding optimized code because
the engine previously assumed that we would never discard baseline code.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock): Record creation time (and compute time since
creation) instead of install time because CodeBlocks can be installed
more than once, and we don't want to have to worry about edge cases
created by CodeBlocks seeming to get younger.

(JSC::CodeBlock::visitAggregate): Be explicit about only doing the
weak reference fixpoint for optimized CodeBlocks. We used to avoid the
fixpoint for baseline CodeBlocks implicitly, since they would always
visit themselves strongly right away. But now baseline CodeBlocks might
not visit themselves strongly, since they might choose to jettison due
to old age.

(JSC::CodeBlock::shouldVisitStrongly): Add old age as a reason not to
visit ourselves strongly, so that baseline CodeBlocks can jettison due
to old age.

(JSC::CodeBlock::shouldJettisonDueToWeakReference): Be explicit about
only jettisoning optimized CodeBlocks due to weak references so that we
don't confuse ourselves into thinking that we will jettison a baseline
CodeBlock due to weak references.

(JSC::CodeBlock::shouldJettisonDueToOldAge): Updated to use creation time.

(JSC::CodeBlock::visitOSRExitTargets): Clarify a comment and add an
ASSERT to help record some things I discovered while debugging.

(JSC::CodeBlock::jettison): Allow a baseline CodeBlock to jettison. Don't
assume that we have an alternative or a profiler.

(JSC::CodeBlock::install): Deleted.

• bytecode/CodeBlock.h:

(JSC::CodeBlock::releaseAlternative): Deleted.
(JSC::CodeBlock::setInstallTime): Deleted.
(JSC::CodeBlock::timeSinceInstall): Deleted.

• dfg/DFGOSRExitPreparation.cpp:

(JSC::DFG::prepareCodeOriginForOSRExit): Simplified the computation of
baseline CodeBlock.

• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::checkLivenessAndVisitChildren): Be sure to strongly
visit our inline callframes because we assume that an optimized CodeBlock
will keep its OSR exit targets alive, but the CodeBlock object won't be
able to mark them for itself until compilation has completed (since it
won't have a JITCode object yet).

• dfg/DFGToFTLDeferredCompilationCallback.cpp:

(JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidComplete):
Updated for interface change.

• jit/JITCode.h:

(JSC::JITCode::timeToLive): Provide a time to live for interpreter and
baseline code, so they will jettison when old. Use seconds in our
code so that we don't need comments. Make DFG 2X interpreter+baseline,
and FTL 2X DFG+interpreter+baseline, also matching the time we allot
before throwing away all code.

• jit/JITToDFGDeferredCompilationCallback.cpp:

(JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::jitCompileAndSetHeuristics): Updated for interface change.

• runtime/Executable.cpp:

(JSC::ScriptExecutable::installCode): Allow our caller to install nullptr,
since we need to do this when jettisoning a baseline CodeBlock. Require
our caller to specify the details of the installation because we can't
rely on a non-null CodeBlock in order to compute them.

(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::ScriptExecutable::prepareForExecutionImpl):

• runtime/Executable.h:

(JSC::ScriptExecutable::recordParse): Updated for interface change.

• runtime/Options.h: Renamed the CodeBlock liveness option since it now

controls baseline and optimized code.

5:16 PM Changeset in webkit [189888] by ggaren@apple.com

• 6 edits
  1 delete in trunk/Source/JavaScriptCore

Remove obsolete code for deleting CodeBlocks
​https://bugs.webkit.org/show_bug.cgi?id=149231

Reviewed by Mark Lam.

• heap/Heap.cpp:

(JSC::Heap::deleteAllCodeBlocks): ASSERT that we're called in a valid
state, and do the compiler waiting ourselves instead of having our
caller do it. This is more appropriate to our new limited use.

(JSC::Heap::collectImpl):
(JSC::Heap::deleteOldCode): Deleted. Don't call deleteAllCodeBlocks
periodically because it's not such a good idea to delete everything
at once, and CodeBlocks now have a more precise individual policy for
when to delete. Also, this function used to fail all or nearly all of
the time because its invariants that we were not executing or compiling
could not be met.

• heap/Heap.h:

• jsc.cpp:

(GlobalObject::finishCreation):
(functionDeleteAllCompiledCode): Deleted.

• tests/stress/deleteAllCompiledCode.js: Removed. Removed this testing

code because it did not do what it thought it did. All of this code
was guaranteed to no-op since it would run JavaScript to call a function
that would return early because JavaScript was running.

• runtime/VM.cpp:

(JSC::VM::deleteAllCode): This code is simpler now becaue
heap.deleteAllCodeBlocks does some work for us.

• runtime/VMEntryScope.cpp:

(JSC::VMEntryScope::VMEntryScope): Don't delete code on VM entry. This
policy was old, and it dated back to a time when we

(a) couldn't run in the interpreter if compilation failed;

(b) didn't reduce the rate of compilation in response to executable
memory pressure;

(c) didn't throw away individual CodeBlocks automatically.

5:10 PM Changeset in webkit [189887] by Chris Dumez

• 9 edits in trunk/Source/WebCore

Possible small iOS PLT regression from r189537
​https://bugs.webkit.org/show_bug.cgi?id=149232

Reviewed by Ryosuke Niwa.

r189537 may have regressed PLT a bit on iOS. That change added a couple
of extra branches to throw exceptions. This patch marks those branches
as UNLIKELY() as we already do for other similar checks in the JS
bindings.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_get_strict_type_checking_attribute):
(webkit_dom_test_obj_set_strict_type_checking_attribute):

• bindings/scripts/test/GObject/WebKitDOMTestObj.h:
• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjStrictTypeCheckingAttribute):
(WebCore::setJSTestObjStrictTypeCheckingAttribute):

• bindings/scripts/test/ObjC/DOMTestObj.h:
• bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj strictTypeCheckingAttribute]):
(-[DOMTestObj setStrictTypeCheckingAttribute:]):

• bindings/scripts/test/TestObj.idl:
• html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::setTHead):
(WebCore::HTMLTableElement::setTFoot):

4:54 PM Changeset in webkit [189886] by bshafiei@apple.com

• 5 edits in trunk/Source

Versioning.

4:50 PM Changeset in webkit [189885] by bshafiei@apple.com

• 1 copy in tags/Safari-602.1.3

New tag.

4:40 PM Changeset in webkit [189884] by msaboff@apple.com

• 43 edits in trunk/Source/JavaScriptCore

[ES6] Implement tail calls in the LLInt and Baseline JIT
​https://bugs.webkit.org/show_bug.cgi?id=148661

Fix for the breakage of Speedometer/Full.html (​https://bugs.webkit.org/show_bug.cgi?id=149162).

Reviewed by Filip Pizlo.
Changed SetupVarargsFrame.cpp::emitSetVarargsFrame to align the callframe size to be a
multiple of stackAlignmentRegisters() in addition to the location of the new frame.

Fixed Reviewed by Filip Pizlo.

• CMakeLists.txt:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
• JavaScriptCore.xcodeproj/project.pbxproj:
• assembler/AbortReason.h:
• assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::Call::Call):
(JSC::AbstractMacroAssembler::repatchNearCall):
(JSC::AbstractMacroAssembler::repatchCompact):

• assembler/CodeLocation.h:

(JSC::CodeLocationNearCall::CodeLocationNearCall):
(JSC::CodeLocationNearCall::callMode):
(JSC::CodeLocationCommon::callAtOffset):
(JSC::CodeLocationCommon::nearCallAtOffset):
(JSC::CodeLocationCommon::dataLabelPtrAtOffset):

• assembler/LinkBuffer.h:

(JSC::LinkBuffer::locationOfNearCall):
(JSC::LinkBuffer::locationOf):

• assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::nearCall):
(JSC::MacroAssemblerARM::nearTailCall):
(JSC::MacroAssemblerARM::call):
(JSC::MacroAssemblerARM::linkCall):

• assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::nearCall):
(JSC::MacroAssemblerARM64::nearTailCall):
(JSC::MacroAssemblerARM64::ret):
(JSC::MacroAssemblerARM64::linkCall):

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::nearCall):
(JSC::MacroAssemblerARMv7::nearTailCall):
(JSC::MacroAssemblerARMv7::call):
(JSC::MacroAssemblerARMv7::linkCall):

• assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::nearCall):
(JSC::MacroAssemblerMIPS::nearTailCall):
(JSC::MacroAssemblerMIPS::call):
(JSC::MacroAssemblerMIPS::linkCall):
(JSC::MacroAssemblerMIPS::repatchCall):

• assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::call):
(JSC::MacroAssemblerSH4::nearTailCall):
(JSC::MacroAssemblerSH4::nearCall):
(JSC::MacroAssemblerSH4::linkCall):
(JSC::MacroAssemblerSH4::repatchCall):

• assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::linkCall):

• assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::breakpoint):
(JSC::MacroAssemblerX86Common::nearTailCall):
(JSC::MacroAssemblerX86Common::nearCall):

• assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::linkCall):

• bytecode/BytecodeList.json:
• bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

• bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::callTypeFor):
(JSC::CallLinkInfo::isVarargsCallType):
(JSC::CallLinkInfo::CallLinkInfo):
(JSC::CallLinkInfo::specializationKind):
(JSC::CallLinkInfo::callModeFor):
(JSC::CallLinkInfo::callMode):
(JSC::CallLinkInfo::isTailCall):
(JSC::CallLinkInfo::isVarargs):
(JSC::CallLinkInfo::registerPreservationMode):

• bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFromLLInt):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCallInTailPosition):
(JSC::BytecodeGenerator::emitCallEval):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargsInTailPosition):
(JSC::BytecodeGenerator::emitConstructVarargs):

• bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):
(JSC::LabelNode::emitBytecode):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addCallWithoutSettingResult):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstruct):

• interpreter/Interpreter.h:

(JSC::Interpreter::isCallBytecode):
(JSC::calleeFrameForVarargs):

• jit/CCallHelpers.h:

(JSC::CCallHelpers::jumpToExceptionHandler):
(JSC::CCallHelpers::prepareForTailCallSlow):

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

• jit/JIT.h:
• jit/JITCall.cpp:

(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::emit_op_call):
(JSC::JIT::emit_op_tail_call):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs):
(JSC::JIT::emit_op_tail_call_varargs):
(JSC::JIT::emit_op_construct_varargs):
(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_tail_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_tail_call_varargs):
(JSC::JIT::emitSlow_op_construct_varargs):

• jit/JITCall32_64.cpp:

(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_tail_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_tail_call_varargs):
(JSC::JIT::emitSlow_op_construct_varargs):
(JSC::JIT::emit_op_call):
(JSC::JIT::emit_op_tail_call):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs):
(JSC::JIT::emit_op_tail_call_varargs):
(JSC::JIT::emit_op_construct_varargs):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):

• jit/JITInlines.h:

(JSC::JIT::emitNakedCall):
(JSC::JIT::emitNakedTailCall):
(JSC::JIT::updateTopCallFrame):

• jit/JITOperations.cpp:
• jit/JITOperations.h:
• jit/Repatch.cpp:

(JSC::linkVirtualFor):
(JSC::linkPolymorphicCall):

• jit/SetupVarargsFrame.cpp:

(JSC::emitSetVarargsFrame):

• jit/ThunkGenerators.cpp:

(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::slowPathFor):
(JSC::linkCallThunkGenerator):
(JSC::virtualThunkFor):
(JSC::arityFixupGenerator):
(JSC::unreachableGenerator):
(JSC::baselineGetterReturnThunkGenerator):

• jit/ThunkGenerators.h:
• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):
(JSC::CommonSlowPaths::opIn):

4:25 PM Changeset in webkit [189883] by commit-queue@webkit.org

• 12 edits in trunk/Source

Web Inspector: Fix common typo "supress" => "suppress"
​https://bugs.webkit.org/show_bug.cgi?id=149199

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-16
Reviewed by Gyuyoung Kim.

Source/WebCore:

• html/shadow/ContentDistributor.h:

(WebCore::ContentDistributor::needsDistribution):

• page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation):

• platform/NotImplemented.h:
• platform/graphics/ca/win/LayerChangesFlusher.cpp:

(WebCore::LayerChangesFlusher::hookCallback):

• platform/mac/HIDGamepadProvider.cpp:

(WebCore::HIDGamepadProvider::deviceRemoved):

• platform/win/makesafeseh.asm:

Source/WebInspectorUI:

• UserInterface/Views/DataGrid.js:

(WebInspector.DataGridNode.prototype.select):
(WebInspector.DataGridNode.prototype.deselect):

• UserInterface/Views/SearchBar.js:

(WebInspector.SearchBar):

Source/WebKit2:

• PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::platformInitializeProcess):

4:07 PM WebKitIDL edited by Chris Dumez

ReturnedNewObject -> NewObject (diff)

4:05 PM Changeset in webkit [189882] by commit-queue@webkit.org

• 4 edits in trunk/Tools

Unreviewed, rolling out r189875 and r189878.
​https://bugs.webkit.org/show_bug.cgi?id=149235

cygwin cmake build not ready yet (Requested by alexchristensen
on #webkit).

Reverted changesets:

"Switch AppleWin build to use CMake"
​https://bugs.webkit.org/show_bug.cgi?id=149163
​http://trac.webkit.org/changeset/189875

"Cygwin build fix after r189875"
​http://trac.webkit.org/changeset/189878

4:01 PM Changeset in webkit [189881] by Chris Dumez

• 60 edits
  4 deletes in trunk/Source/WebCore

WebIDL: Rename [ReturnNewObject] to [NewObject] and use it more consistently in DOM
​https://bugs.webkit.org/show_bug.cgi?id=149192

Reviewed by Darin Adler.

Rename [ReturnNewObject] to [NewObject] and use it more consistently in
DOM.

This aligns our IDL extended attribute naming with standard Web IDL:
​https://heycam.github.io/webidl/#NewObject

We already have [ReturnNewObject] in most places that the DOM
specification uses [NewObject] but we are missing a few so I'll
fix this as well:
​https://dom.spec.whatwg.org/#interface-document

Using [NewObject] lets the bindings generator know that the API in
question always returns new objects and that we can bypass the check
for existing wrappers and directly create a new wrapper for the
returned object.

This patch also adds support for generating the toJSNewlyCreated()
utility function for most types. Previously, to use [ReturnNewObject]
for a new type, you needed to add the type to a hard-coded list in
the bindings generator then provide your own implementation for
toJSNewlyCreated() as custom bindings.

No new-exposed behavior change.

• bindings/js/JSDocumentCustom.cpp:
• bindings/js/JSEventCustom.cpp:
• bindings/js/JSNodeListCustom.cpp:

Add toJSNewlyCreated() custom implementation for Node, Event and
Document, that shares code with the existing toJS() implementation for
those types.

• bindings/js/JSCDATASectionCustom.cpp: Removed.
• bindings/js/JSTextCustom.cpp: Removed.
• bindings/js/JSTouchCustom.cpp: Removed.
• bindings/js/JSTouchListCustom.cpp: Removed.

Drop several custom bindings files as the bindings generator is
now able to generate the toJSNewlyCreated() utility function for
most types.

• bindings/scripts/CodeGeneratorJS.pm:
• Rename [ReturnNewObject] to [NewObject].
• Generate a toJSNewlyCreated() whenever we generate a toJS() already. Get rid of the hard-coded list of types that need a toJSNewlyCreated().

• bindings/scripts/IDLAttributes.txt:

Rename [ReturnNewObject] to [NewObject].

• bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
• bindings/scripts/test/JS/JSTestActiveDOMObject.h:
• bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
• bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.h:
• bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
• bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
• bindings/scripts/test/JS/JSTestEventConstructor.cpp:
• bindings/scripts/test/JS/JSTestEventConstructor.h:
• bindings/scripts/test/JS/JSTestEventTarget.cpp:
• bindings/scripts/test/JS/JSTestEventTarget.h:
• bindings/scripts/test/JS/JSTestException.cpp:
• bindings/scripts/test/JS/JSTestException.h:
• bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
• bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
• bindings/scripts/test/JS/JSTestInterface.cpp:
• bindings/scripts/test/JS/JSTestInterface.h:
• bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
• bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
• bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
• bindings/scripts/test/JS/JSTestNamedConstructor.h:
• bindings/scripts/test/JS/JSTestNondeterministic.cpp:
• bindings/scripts/test/JS/JSTestNondeterministic.h:
• bindings/scripts/test/JS/JSTestObj.cpp:
• bindings/scripts/test/JS/JSTestObj.h:
• bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
• bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
• bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
• bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
• bindings/scripts/test/JS/JSTestTypedefs.cpp:
• bindings/scripts/test/JS/JSTestTypedefs.h:
• bindings/scripts/test/JS/JSattribute.cpp:
• bindings/scripts/test/JS/JSattribute.h:
• bindings/scripts/test/JS/JSreadonly.cpp:
• bindings/scripts/test/JS/JSreadonly.h:

Rebaseline bindings tests.

• dom/Attr.idl:
• dom/CDATASection.idl:
• dom/Comment.idl:
• dom/DocumentFragment.idl:
• dom/DocumentType.idl:
• dom/EntityReference.idl:
• dom/ProcessingInstruction.idl:

Add [JSGenerateToJSObject] so that the bindings generator generates
a toJS() / toJSNewlyCreated() for this type. While it is not strictly
needed, it avoids falling back to using the toJS() from Node which
calls the virtual nodeType() function to determine the node type.
This change was made for efficiency purposes.

• dom/DOMImplementation.idl:

Rename [ReturnNewObject] to [NewObject] and add it to createHTMLDocument()
as well, as per the specification:
​https://dom.spec.whatwg.org/#interface-domimplementation

• dom/Document.idl:

Rename [ReturnNewObject] to [NewObject] and add it to more operations
as per he DOM specification:
​https://dom.spec.whatwg.org/#document

• dom/Node.idl:

Add [NewObject] to cloneNode() as per the DOM specification:
​https://dom.spec.whatwg.org/#node

• dom/ParentNode.idl:

Add [NewObject] to querySelectorAll() as per the DOM specification:
​https://dom.spec.whatwg.org/#parentnode

• dom/Range.idl:

Add [NewObject] for several operations, as per the DOM specification:
​https://dom.spec.whatwg.org/#interface-range

2:04 PM Changeset in webkit [189880] by mmaxfield@apple.com

• 2 edits in trunk

Unreviewed ChangeLog update

1:45 PM Changeset in webkit [189879] by beidson@apple.com

• 11 edits
  4 copies
  7 adds in trunk

Have window.indexedDB.deleteDatabase return an IDBOpenDBRequest.
​https://bugs.webkit.org/show_bug.cgi?id=149229

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/deletedatabase-request.html

storage/indexeddb/modern/deletedatabase-null-name-exception.html

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:

• Modules/indexeddb/IDBDatabaseIdentifier.cpp: Added.

(WebCore::IDBDatabaseIdentifier::IDBDatabaseIdentifier):

• Modules/indexeddb/IDBDatabaseIdentifier.h: Added.

(WebCore::IDBDatabaseIdentifier::IDBDatabaseIdentifier):
(WebCore::IDBDatabaseIdentifier::isHashTableDeletedValue):
(WebCore::IDBDatabaseIdentifier::hash):
(WebCore::IDBDatabaseIdentifier::isValid):
(WebCore::IDBDatabaseIdentifier::operator==):
(WebCore::IDBDatabaseIdentifier::databaseName):
(WebCore::IDBDatabaseIdentifierHash::hash):
(WebCore::IDBDatabaseIdentifierHash::equal):
(WebCore::IDBDatabaseIdentifierHashTraits::isEmptyValue):

• Modules/indexeddb/client/IDBFactoryImpl.cpp:

(WebCore::IDBClient::shouldThrowSecurityException):
(WebCore::IDBClient::IDBFactory::getDatabaseNames):
(WebCore::IDBClient::IDBFactory::open):
(WebCore::IDBClient::IDBFactory::deleteDatabase):

• Modules/indexeddb/client/IDBFactoryImpl.h:

• Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp: Copied from Source/WebCore/Modules/indexeddb/client/IDBFactoryImpl.cpp.

(WebCore::IDBClient::IDBOpenDBRequest::IDBOpenDBRequest):

• Modules/indexeddb/client/IDBOpenDBRequestImpl.h: Copied from Source/WebCore/Modules/indexeddb/client/IDBFactoryImpl.cpp.

(WebCore::IDBClient::IDBOpenDBRequest::create):

• Modules/indexeddb/client/IDBRequestImpl.cpp: Copied from Source/WebCore/Modules/indexeddb/client/IDBFactoryImpl.cpp.

(WebCore::IDBClient::IDBRequest::IDBRequest):
(WebCore::IDBClient::IDBRequest::result):
(WebCore::IDBClient::IDBRequest::errorCode):
(WebCore::IDBClient::IDBRequest::error):
(WebCore::IDBClient::IDBRequest::source):
(WebCore::IDBClient::IDBRequest::transaction):
(WebCore::IDBClient::IDBRequest::readyState):
(WebCore::IDBClient::IDBRequest::eventTargetInterface):
(WebCore::IDBClient::IDBRequest::activeDOMObjectName):
(WebCore::IDBClient::IDBRequest::canSuspendForPageCache):

• Modules/indexeddb/client/IDBRequestImpl.h: Copied from Source/WebCore/Modules/indexeddb/client/IDBFactoryImpl.h.

• platform/Logging.h:

Source/WebKit/mac:

• WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Enable IDB in WK1.

LayoutTests:

• platform/mac-wk1/TestExpectations:
• platform/wk2/TestExpectations:
• storage/indexeddb/modern/deletedatabase-null-name-exception-expected.txt: Added.
• storage/indexeddb/modern/deletedatabase-null-name-exception.html: Added.
• storage/indexeddb/modern/deletedatabase-request-expected.txt: Added.
• storage/indexeddb/modern/deletedatabase-request.html: Added.

12:55 PM Changeset in webkit [189878] by achristensen@apple.com

• 3 edits in trunk/Tools

Cygwin build fix after r189875

• Scripts/build-webkit:
• Scripts/webkitdirs.pm:

(jhbuildWrapperPrefixIfNeeded):
(generateBuildSystemFromCMakeProject):
Make things work with cygwin and cmake.

12:52 PM Changeset in webkit [189877] by mitz@apple.com

• 3 edits in trunk/Source/WebKit2

[iOS] Inline implementation of -[WKImagePreviewViewController previewActions]
​https://bugs.webkit.org/show_bug.cgi?id=149224

Reviewed by Tim Horton.

• Platform/spi/ios/UIKitSPI.h: Declare UIViewControllerPreviewAction and its factory method.
• UIProcess/WKImagePreviewViewController.mm:

(-[WKImagePreviewViewController previewActions]): Moved here.

12:05 PM Changeset in webkit [189876] by Chris Dumez

• 1 edit
  2 deletes in trunk/LayoutTests

Unreviewed, drop dom/xhtml/level3/core/nodegetbaseuri03.xhtml test.

This test is outdated and we have more recent DOM tests covering
the newly expected behavior.

• dom/xhtml/level3/core/nodegetbaseuri03.js: Removed.
• dom/xhtml/level3/core/nodegetbaseuri03.xhtml: Removed.

11:57 AM Changeset in webkit [189875] by achristensen@apple.com

• 3 edits in trunk/Tools

Switch AppleWin build to use CMake
​https://bugs.webkit.org/show_bug.cgi?id=149163

Reviewed by Brent Fulgham.

• Scripts/build-webkit:

Build with CMake.

• Scripts/run-api-tests:

(runTest):
(listAllTests):
(prepareEnvironmentForRunningTestTool):
(testToolPaths):
(testToolPath): Deleted.
Run the API tests as separate executables on Windows.
It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.

11:08 AM Changeset in webkit [189874] by ap@apple.com

• 2 edits in trunk/Tools

Add newer build.webkit.org pages to robots.txt
​https://bugs.webkit.org/show_bug.cgi?id=149219

Reviewed by Darin Adler.

Indexing bot watcher's dashboard can't be good.

• BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:

10:56 AM WebKitIDL edited by Chris Dumez

Add [Unforgeable] (diff)

10:46 AM Changeset in webkit [189873] by Chris Dumez

• 10 edits
  2 adds in trunk

Add initial support for [Unforgeable] IDL extended attribute
​https://bugs.webkit.org/show_bug.cgi?id=149147

Reviewed by Darin Adler.

Source/WebCore:

Add initial support for [Unforgeable] IDL extended attribute:
​https://heycam.github.io/webidl/#Unforgeable

In particular, attributes marked as unforgeable are now:

• on the instance rather than the prototype
• non-configurable. WebKit does not match the Web IDL specification and most properties are currently non-configurable already. However, I added an extra check for [Unforgeable] so that unforgeable attributes stay unconfigurable if we later decide to match the spec and mark properties as configurable.

Operation marked as unforgeable are now non-configurable. However, this
patch does not move them from the prototype to the instance yet. This
needs to be addressed in a follow-up patch as this is a larger change.

This patch also drops support for the undocumented
[OperationsNotDeletable] IDL extended attribute. It is no longer needed
now that we support [Unforgeable] and still support [NotDeletable] for
operations.

Test: fast/dom/unforgeable-attributes.html

• Modules/plugins/QuickTimePluginReplacement.idl:

Drop [OperationsNotDeletable] on the interface and mark the only
operation on this interface as [NotDeletable]. There is no behavior
change but this allows us to drop support for a non-standard and
undocumented IDL extended attribute.

• bindings/scripts/CodeGeneratorJS.pm:

(AttributeShouldBeOnInstance):
(GenerateAttributesHashTable):
(GenerateImplementation):
Add initial support for [Unforgeable] IDL extended attribute.

• bindings/scripts/IDLAttributes.txt:

Add [Unforgeable]. Drop [OperationsNotDeletable].

• crypto/CryptoKeyPair.idl:

Drop [OperationsNotDeletable] on the interface as this interface has
no operations.

• dom/Document.idl:
• page/DOMWindow.idl:
• page/Location.idl:

Mark attributes / interfaces as [Unforgeable] as per the latest HTML
specification:
​https://html.spec.whatwg.org/multipage/dom.html#document
​https://html.spec.whatwg.org/multipage/browsers.html#window
​https://html.spec.whatwg.org/multipage/browsers.html#the-location-interface

LayoutTests:

New test that verifies that well-known [Unforgeable] attributes
are on the instance rather than the prototype and that they are
non-configurable.

• fast/dom/unforgeable-attributes-expected.txt: Added.
• fast/dom/unforgeable-attributes.html: Added.

10:38 AM Changeset in webkit [189872] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Turn off line wrapping in resource text editors
​https://bugs.webkit.org/show_bug.cgi?id=149121

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-16
Reviewed by Darin Adler.

• UserInterface/Views/TextEditor.js:

(WebInspector.TextEditor):

10:35 AM Changeset in webkit [189871] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

[Mac] Allow reading from SubmitDiagInfo.domains in Networking process
​https://bugs.webkit.org/show_bug.cgi?id=149176
rdar://problem/22483680

Reviewed by Darin Adler.

• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:

10:31 AM Changeset in webkit [189870] by Alan Bujtas

• 3 edits
  2 adds in trunk

Simple line layout: Glitch selecting long text.
​https://bugs.webkit.org/show_bug.cgi?id=149204
rdar://problem/22646472

Reviewed by Antti Koivisto.

When long text is split into multiple RenderText objects, we ignore renderer boundaries while
collecting wrapping positions (so that we don't end up wrapping unbreakable fragments at the end of each renderer).
This patch ensures that fragments with hypen character ignore renderer boundaries too.

Source/WebCore:

Test: fast/text/multiple-renderers-with-hypen-on-boundary.html

• rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::TextFragmentIterator::skipToNextPosition):

LayoutTests:

• fast/text/multiple-renderers-with-hypen-on-boundary-expected.html: Added.
• fast/text/multiple-renderers-with-hypen-on-boundary.html: Added.

10:29 AM Changeset in webkit [189869] by ap@apple.com

• 2 edits in trunk/LayoutTests

fast/events/mouse-cursor-change.html is flaky on Mac
​https://bugs.webkit.org/show_bug.cgi?id=149216

Reviewed by Darin Adler.

• fast/events/mouse-cursor-change.html: Increase the timeout. I don't see a way to make

this test 100% reliable, but this change makes it work in my local testing.

10:24 AM Changeset in webkit [189868] by mitz@apple.com

• 2 edits in trunk/Source/WebKit2

[iOS] Unifiy WebKit2PlatformTouchPoint definition
​https://bugs.webkit.org/show_bug.cgi?id=149221

Reviewed by Darin Adler.

• Shared/WebEventConversion.cpp:

(WebKit::touchEventType):
(WebKit::WebKit2PlatformTouchPoint::WebKit2PlatformTouchPoint):

9:55 AM Changeset in webkit [189867] by achristensen@apple.com

• 2 edits in trunk/Tools

Rollout r189851 and 189853 because they didn’t actually fix the permissions issue

• BuildSlaveSupport/built-product-archive:

(unzipArchive):

9:08 AM Changeset in webkit [189866] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, rebaseline W3C html/dom test for iOS after r189842.

• platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:

9:01 AM Changeset in webkit [189865] by ap@apple.com

• 2 edits in trunk/LayoutTests

More test result fixing after r189841.

• platform/mac/js/dom/global-constructors-attributes-expected.txt:

8:57 AM Changeset in webkit [189864] by ap@apple.com

• 2 edits in trunk/LayoutTests

Mark http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html as flaky, because it is.

It was already marked as flaky on mac-wk2.

• platform/ios-simulator-wk2/TestExpectations:

8:32 AM Changeset in webkit [189863] by beidson@apple.com

• 2 edits in trunk/Source/WebCore

Remove stray logging string mistakenly left in r189746.

• Modules/indexeddb/legacy/LegacyFactory.cpp:

(WebCore::LegacyFactory::deleteDatabase):

8:02 AM Changeset in webkit [189862] by Chris Fleizach

• 3 edits
  2 adds in trunk

Source/WebCore:
AX: No VoiceOver typing feedback in some search fields
​https://bugs.webkit.org/show_bug.cgi?id=149177

Reviewed by Mario Sanchez Prada.

If SearchFieldRole is not marked as a TextControl, it does not end up returning the accessibilityValue,
which is needed to output the right text to VoiceOver.

Test: accessibility/ax-value-with-search.html

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isTextControl):

LayoutTests:
AX: No VO typing feedback in some text fields
​https://bugs.webkit.org/show_bug.cgi?id=149177

Reviewed by Mario Sanchez Prada.

• accessibility/ax-value-with-search-expected.txt: Added.
• accessibility/ax-value-with-search.html: Added.

5:48 AM Changeset in webkit [189861] by Csaba Osztrogonác

• 2 edits in trunk/Tools

[EFL] Fix the help message of separated web process option of MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=149212

Reviewed by Gyuyoung Kim.

• MiniBrowser/efl/main.c:

3:09 AM Changeset in webkit [189860] by Manuel Rego Casasnovas

• 3 edits
  2 adds in trunk

[css-grid] Grid container's height should include scrollbar
​https://bugs.webkit.org/show_bug.cgi?id=149210

Reviewed by Sergio Villar Senin.

Source/WebCore:

Add scrollbar's size in the grid container's height calculation at
RenderGrid::layoutGridItems().

Test: fast/css-grid-layout/grid-container-margin-border-padding-scrollbar.html

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutGridItems): Include scrollbarLogicalHeight()
while computing the grid's logical height.

LayoutTests:

Add test to check both height and width (which was already working as
expected) with margins, borders, paddings and scrollbars.

• fast/css-grid-layout/grid-container-margin-border-padding-scrollbar-expected.txt: Added.
• fast/css-grid-layout/grid-container-margin-border-padding-scrollbar.html: Added.

3:09 AM Changeset in webkit [189859] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.9.92

WebKitGTK+ 2.9.92

3:08 AM Changeset in webkit [189858] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.10

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.9.92 release.

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

• gtk/NEWS: Add release notes for 2.9.92.

2:23 AM WebKitGTK/2.10.x edited by Carlos Garcia Campos

(diff)

2:03 AM Changeset in webkit [189857] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2

Merge r189854 - [GTK] Web Process crash recovery no longer works
​https://bugs.webkit.org/show_bug.cgi?id=149064

Reviewed by Žan Doberšek.

After a web process crash the new DrawingArea is never resized, so
nothing is rendered into the web view.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDidRelaunchWebProcess): Queue a widget resize to ensure
the new DrawingAreaProxy is resized.

2:03 AM Changeset in webkit [189856] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r189826 - [GTK] Build failure with ACCELERATED_2D_CANVAS when cairo-gl has built with OpenGLESv2 support only.
​https://bugs.webkit.org/show_bug.cgi?id=149172

Reviewed by Martin Robinson.

No new tests, no behavior change.

• platform/graphics/glx/GLContextGLX.cpp:

(WebCore::GLContextGLX::cairoDevice):

1:29 AM Changeset in webkit [189855] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

Unreviewed. Fix GObject DOM bindings API break after r189676.

webkit_dom_character_data_append_data() used to raise exceptions.

• bindings/scripts/CodeGeneratorGObject.pm:

(FunctionUsedToRaiseException):

1:00 AM Changeset in webkit [189854] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

[GTK] Web Process crash recovery no longer works
​https://bugs.webkit.org/show_bug.cgi?id=149064

Reviewed by Žan Doberšek.

After a web process crash the new DrawingArea is never resized, so
nothing is rendered into the web view.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDidRelaunchWebProcess): Queue a widget resize to ensure
the new DrawingAreaProxy is resized.

12:19 AM Changeset in webkit [189853] by achristensen@apple.com

• 2 edits in trunk/Tools

Fix python syntax after r189851.

• BuildSlaveSupport/built-product-archive:

(unzipArchive):
For loops need a colon.

12:14 AM Changeset in webkit [189852] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Mac rebaseline after r189841.

• platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:

12:06 AM Changeset in webkit [189851] by achristensen@apple.com

• 2 edits in trunk/Tools

Fix Windows test bots after changing to non-cygwin build
​https://bugs.webkit.org/show_bug.cgi?id=149196

Reviewed by Daniel Bates.

• BuildSlaveSupport/built-product-archive:

(unzipArchive):
Using different versions of python makes what I think is ​https://bugs.python.org/issue15795
prevent us from executing files from the archive on the test bots.

Sep 15, 2015:

11:59 PM Changeset in webkit [189850] by commit-queue@webkit.org

• 3 edits
  2 deletes in trunk

Unreviewed, rolling out r189847.
​https://bugs.webkit.org/show_bug.cgi?id=149208

Asserts on all the tests (Requested by ap on #webkit).

Reverted changeset:

"Simple line layout: Glitch selecting long text."
​https://bugs.webkit.org/show_bug.cgi?id=149204
​http://trac.webkit.org/changeset/189847

11:49 PM Changeset in webkit [189849] by Sukolsak Sakshuwong

• 1 edit in trunk/Source/JavaScriptCore/jit/JITOperations.cpp

Build fix for WebAssembly after r189848

• jit/JITOperations.cpp

11:14 PM Changeset in webkit [189848] by msaboff@apple.com

• 42 edits
  5 deletes in trunk/Source/JavaScriptCore

Rollout r189774 and 189818.

Broke Speedometer/Full.html

Not reviewed.

• CMakeLists.txt:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
• JavaScriptCore.xcodeproj/project.pbxproj:
• assembler/AbortReason.h:
• assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::Call::Call):
(JSC::AbstractMacroAssembler::repatchNearCall):
(JSC::AbstractMacroAssembler::repatchCompact):

• assembler/CodeLocation.h:

(JSC::CodeLocationNearCall::CodeLocationNearCall):
(JSC::CodeLocationCommon::callAtOffset):
(JSC::CodeLocationCommon::nearCallAtOffset):
(JSC::CodeLocationCommon::dataLabelPtrAtOffset):
(JSC::CodeLocationNearCall::callMode): Deleted.

• assembler/LinkBuffer.h:

(JSC::LinkBuffer::locationOfNearCall):
(JSC::LinkBuffer::locationOf):

• assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::nearCall):
(JSC::MacroAssemblerARM::call):
(JSC::MacroAssemblerARM::linkCall):
(JSC::MacroAssemblerARM::nearTailCall): Deleted.

• assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::nearCall):
(JSC::MacroAssemblerARM64::ret):
(JSC::MacroAssemblerARM64::linkCall):
(JSC::MacroAssemblerARM64::nearTailCall): Deleted.

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::nearCall):
(JSC::MacroAssemblerARMv7::call):
(JSC::MacroAssemblerARMv7::linkCall):
(JSC::MacroAssemblerARMv7::nearTailCall): Deleted.

• assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::nearCall):
(JSC::MacroAssemblerMIPS::call):
(JSC::MacroAssemblerMIPS::linkCall):
(JSC::MacroAssemblerMIPS::repatchCall):
(JSC::MacroAssemblerMIPS::nearTailCall): Deleted.

• assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::call):
(JSC::MacroAssemblerSH4::nearCall):
(JSC::MacroAssemblerSH4::linkCall):
(JSC::MacroAssemblerSH4::repatchCall):
(JSC::MacroAssemblerSH4::nearTailCall): Deleted.

• assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::linkCall):

• assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::breakpoint):
(JSC::MacroAssemblerX86Common::nearCall):
(JSC::MacroAssemblerX86Common::nearTailCall): Deleted.

• assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::linkCall):

• bytecode/BytecodeList.json:
• bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

• bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::callTypeFor):
(JSC::CallLinkInfo::CallLinkInfo):
(JSC::CallLinkInfo::specializationKind):
(JSC::CallLinkInfo::registerPreservationMode):
(JSC::CallLinkInfo::isVarargsCallType): Deleted.
(JSC::CallLinkInfo::callModeFor): Deleted.
(JSC::CallLinkInfo::callMode): Deleted.
(JSC::CallLinkInfo::isTailCall): Deleted.
(JSC::CallLinkInfo::isVarargs): Deleted.

• bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFromLLInt):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCallInTailPosition):
(JSC::BytecodeGenerator::emitCallEval):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargsInTailPosition):
(JSC::BytecodeGenerator::emitConstructVarargs):

• bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):
(JSC::LabelNode::emitBytecode):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addCallWithoutSettingResult):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstruct):

• interpreter/Interpreter.h:

(JSC::Interpreter::isCallBytecode):

• jit/CCallHelpers.h:

(JSC::CCallHelpers::jumpToExceptionHandler):
(JSC::CCallHelpers::prepareForTailCallSlow): Deleted.

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

• jit/JIT.h:
• jit/JITCall.cpp:

(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::emit_op_call):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs):
(JSC::JIT::emit_op_construct_varargs):
(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct_varargs):
(JSC::JIT::emit_op_tail_call): Deleted.
(JSC::JIT::emit_op_tail_call_varargs): Deleted.
(JSC::JIT::emitSlow_op_tail_call): Deleted.
(JSC::JIT::emitSlow_op_tail_call_varargs): Deleted.

• jit/JITCall32_64.cpp:

(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct_varargs):
(JSC::JIT::emit_op_call):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs):
(JSC::JIT::emit_op_construct_varargs):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::emitSlow_op_tail_call): Deleted.
(JSC::JIT::emitSlow_op_tail_call_varargs): Deleted.
(JSC::JIT::emit_op_tail_call): Deleted.
(JSC::JIT::emit_op_tail_call_varargs): Deleted.

• jit/JITInlines.h:

(JSC::JIT::emitNakedCall):
(JSC::JIT::updateTopCallFrame):
(JSC::JIT::emitNakedTailCall): Deleted.

• jit/JITOperations.cpp:
• jit/JITOperations.h:
• jit/Repatch.cpp:

(JSC::linkVirtualFor):
(JSC::linkPolymorphicCall):

• jit/ThunkGenerators.cpp:

(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::slowPathFor):
(JSC::linkCallThunkGenerator):
(JSC::virtualThunkFor):
(JSC::arityFixupGenerator):
(JSC::baselineGetterReturnThunkGenerator):
(JSC::unreachableGenerator): Deleted.

• jit/ThunkGenerators.h:
• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):
(JSC::CommonSlowPaths::opIn):

• tests/stress/mutual-tail-call-no-stack-overflow.js: Removed.
• tests/stress/tail-call-no-stack-overflow.js: Removed.
• tests/stress/tail-call-recognize.js: Removed.
• tests/stress/tail-call-varargs-no-stack-overflow.js: Removed.
• tests/stress/tail-calls-dont-overwrite-live-stack.js: Removed.

11:07 PM Changeset in webkit [189847] by Alan Bujtas

• 3 edits
  2 adds in trunk

Simple line layout: Glitch selecting long text.
​https://bugs.webkit.org/show_bug.cgi?id=149204
rdar://problem/22646472

Reviewed by Antti Koivisto.

When long text is split into multiple RenderText objects, we ignore renderer boundaries while
collecting wrapping positions (so that we don't end up wrapping unbreakable fragments at the end of each renderer).
This patch ensures that fragments with hypen character ignore renderer boundaries too.

Source/WebCore:

Test: fast/text/multiple-renderers-with-hypen-on-boundary.html

• rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::TextFragmentIterator::skipToNextPosition):

LayoutTests:

• fast/text/multiple-renderers-with-hypen-on-boundary-expected.html: Added.
• fast/text/multiple-renderers-with-hypen-on-boundary.html: Added.

10:49 PM Changeset in webkit [189846] by commit-queue@webkit.org

• 5 edits in trunk/Source/JavaScriptCore

Implement imported global variables in WebAssembly
​https://bugs.webkit.org/show_bug.cgi?id=149206

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-15
Reviewed by Filip Pizlo.

Values can now be imported to a WebAssembly module through properties of
the imports object that is passed to loadWebAssembly(). In order to
avoid any side effect when accessing the imports object, we check that
the properties are data properties. We also check that each value is a
primitive and is not a Symbol. According to the ECMA262 6.0 spec,
calling ToNumber() on a primitive that is not a Symbol should not cause
any side effect.[1]

[1]: ​http://www.ecma-international.org/ecma-262/6.0/#sec-tonumber

• tests/stress/wasm-globals.js:
• tests/stress/wasm/globals.wasm:
• wasm/WASMModuleParser.cpp:

(JSC::WASMModuleParser::parseModule):
(JSC::WASMModuleParser::parseGlobalSection):

• wasm/WASMModuleParser.h:

9:22 PM Changeset in webkit [189845] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Picking unchanged for font-size does not reset back to the unchanged value
​https://bugs.webkit.org/show_bug.cgi?id=148351

Patch by Devin Rousso <Devin Rousso> on 2015-09-15
Reviewed by Brian Burg.

Visual number editors now save any new values in the special placeholder element
to display it whenever the "Unchanged" option is selected by the user.

• UserInterface/Views/VisualStyleNumberInputBox.js:

(WebInspector.VisualStyleNumberInputBox.prototype.set value):
(WebInspector.VisualStyleNumberInputBox.prototype.set units):
(WebInspector.VisualStyleNumberInputBox.prototype._setNumberInputIsEditable):
(WebInspector.VisualStyleNumberInputBox.prototype._keywordChanged):
(WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown.adjustValue):
(WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown):

8:52 PM Changeset in webkit [189844] by commit-queue@webkit.org

• 8 edits in trunk/Source/JavaScriptCore

Fix asm.js errors in WebAssembly tests
​https://bugs.webkit.org/show_bug.cgi?id=149203

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-15
Reviewed by Geoffrey Garen.

Our WebAssembly implementation uses asm.js for testing. Using Firefox to
parse asm.js reveals many errors that are not caught by pack-asmjs. For
example,

• asm.js does not allow the use of the multiplication operator (*) to multiply two integers, because the result can be so large that some lower bits of precision are lost. Math.imul is used instead.
• an int variable must be coerced to either signed (via x|0) or unsigned (via x>>>0) before it's returned.

• tests/stress/wasm-arithmetic-int32.js:
• tests/stress/wasm-calls.js:
• tests/stress/wasm-control-flow.js:
• tests/stress/wasm-globals.js:
• tests/stress/wasm-locals.js:
• tests/stress/wasm-relational.js:
• tests/stress/wasm/control-flow.wasm:

8:46 PM Changeset in webkit [189843] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

GTK+ build fix attempt after r189841.

• PlatformGTK.cmake:

8:36 PM Changeset in webkit [189842] by Chris Dumez

• 14 edits in trunk

Document.createElement(localName) does not handle correctly missing or null parameter
​https://bugs.webkit.org/show_bug.cgi?id=149184
<rdar://problem/22565070>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing.

• web-platform-tests/dom/interfaces-expected.txt:
• web-platform-tests/dom/nodes/Document-createElement-expected.txt:
• web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Document.createElement(localName) does not handle correct missing or
null parameter:

• ​https://dom.spec.whatwg.org/#interface-document

As per the specification, the parameter is a non-nullable DOMString and
is mandatory. Therefore, as per Web IDL, we should have the following
behavior:

1. If the parameter is missing, we should throw an exception
2. If the parameter is null, we should convert it to the "null" string and create a <null> element.

Chrome and Firefox behave according to the specification. However,
WebKit was doing:

1. Create a <undefined> element
2. Throw an InvalidCharacterError

This patch aligns WebKit's behavior with the specification and other
major browsers.

No new tests, already covered by existing tests.

• dom/Document.idl:

LayoutTests:

Update / rebaseline existing tests now that our behavior has changed.

• fast/dom/Document/createElementNS-namespace-err-expected.txt:
• fast/dom/Document/script-tests/createElementNS-namespace-err.js:
• fast/dom/dom-method-document-change.html:
• fast/dom/element-removed-while-inserting-parent-crash.html:
• fast/inspector-support/uncaught-dom3-exception-expected.txt:

7:40 PM Changeset in webkit [189841] by rniwa@webkit.org

• 52 edits
  8 adds in trunk

Add ShadowRoot interface and Element.prototype.attachShadow
​https://bugs.webkit.org/show_bug.cgi?id=149187

Reviewed by Antti Koivisto.

.:

• Source/cmake/OptionsGTK.cmake:

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Add back ShadowRoot IDL interface and Element.prototype.attachShadow in accordance with
​http://w3c.github.io/webcomponents/spec/shadow/ at db27e6e36eab512d86edcdabb33ed27b5751acd7 excluding getSelection(),
elementFromPoint(), elementsFromPoint(), caretPositionFromPoint(), and styleSheets attribute on ShadowRoot interface.

The feature is enabled by default on Mac and iOS ports for testing and disabled by default elsewhere.

Also added HTMLElement::canHaveUserAgentShadowRoot which returns false by default and overridden elsewhere to return true
to distinguish elements for which attachShadow is supposed to throw NotSupported.
See ​https://w3c.github.io/webcomponents/spec/shadow/#widl-Element-attachShadow-ShadowRoot-ShadowRootInit-shadowRootInitDict

Tests: fast/shadow-dom/Element-interface-attachShadow.html

fast/shadow-dom/Element-interface-shadowRoot-attribute.html
fast/shadow-dom/ShadowRoot-interface.html

• CMakeLists.txt:
• Configurations/FeatureDefines.xcconfig:
• DerivedSources.cpp:
• DerivedSources.make:
• PlatformGTK.cmake:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively):

• dom/Element.cpp:

(WebCore::Element::bindingsOffsetParent):
(WebCore::Element::offsetParent):
(WebCore::Element::addShadowRoot):
(WebCore::Element::createShadowRoot):
(WebCore::Element::attachShadow): Added.
(WebCore::Element::bindingShadowRoot): Added. Returns null unless the attached shadow root is in the "open" mode.

• dom/Element.h:
• dom/Element.idl: Added attachShadow and shadowRoot. We only expose these to JS for now since Dictionary argument isn't

supported by other binding code.

• dom/ShadowRoot.cpp: Removed an unused enum.
• dom/ShadowRoot.h:

(WebCore::ShadowRoot::Type): Replaced old-style enum "ShadowRootType" by an enum class named "Type". Also added two new
values Open and Closed for author shadow roots.
(WebCore::ShadowRoot::type):

• dom/ShadowRoot.idl: Added.
• html/HTMLButtonElement.h:
• html/HTMLDetailsElement.h:

(HTMLButtonElement::canHaveUserAgentShadowRoot): Ditto.

• html/HTMLElement.h:

(WebCore::HTMLElement::canHaveUserAgentShadowRoot): Added. Returns false by default.

• html/HTMLInputElement.h:
• html/HTMLKeygenElement.h:
• html/HTMLMarqueeElement.h:
• html/HTMLMediaElement.h:
• html/HTMLMeterElement.h:
• html/HTMLPlugInElement.h:
• html/HTMLProgressElement.h:
• html/HTMLSelectElement.h:
• html/HTMLSummaryElement.h:
• html/HTMLTextAreaElement.h:
• html/shadow/InsertionPoint.h:

(ShadowRootWithInsertionPoints::ShadowRootWithInsertionPoints):

• rendering/RenderElement.cpp:

(WebCore::RenderElement::selectionPseudoStyle):

• rendering/RenderLayer.cpp:

(WebCore::rendererForScrollbar):

• svg/SVGElement.cpp:

(WebCore::SVGElement::correspondingUseElement):

• testing/Internals.cpp:

(WebCore::Internals::shadowRootType):

Source/WebKit/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/FeatureDefines.h:

Tools:

• Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Add new tests for Shadow DOM with failing expectations on all platforms but Mac.

• TestExpectations:
• fast/shadow-dom: Added.
• fast/shadow-dom/Element-interface-attachShadow-expected.txt: Added.
• fast/shadow-dom/Element-interface-attachShadow.html: Added.
• fast/shadow-dom/Element-interface-shadowRoot-attribute-expected.txt: Added.
• fast/shadow-dom/Element-interface-shadowRoot-attribute.html: Added.
• fast/shadow-dom/ShadowRoot-interface-expected.txt: Added.
• fast/shadow-dom/ShadowRoot-interface.html: Added.
• js/dom/dom-static-property-for-in-iteration-expected.txt:
• platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
• platform/mac/TestExpectations:
• platform/mac/js/dom/constructor-length-expected.txt:

7:10 PM Changeset in webkit [189840] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

[Win] Unreviewed release fix after r189832

• platform/graphics/ca/win/PlatformCALayerWin.h: The implementation

should exist in Release builds as well.

7:04 PM Changeset in webkit [189839] by commit-queue@webkit.org

• 3 edits in trunk/Tools

Appscale queue status json output lacks bots
​https://bugs.webkit.org/show_bug.cgi?id=149194
<rdar://problem/22171089>

Patch by Aakash Jain <​aakash_jain@apple.com> on 2015-09-15
Reviewed by Alexey Proskuryakov.

• QueueStatusServer/handlers/queuestatusjson.py:

(QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.

• QueueStatusServer/index.yaml: Index according to appscale requirements.

6:54 PM Changeset in webkit [189838] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

[WebGL] Only require that the stencil value and write masks have as many bits set as the stencil buffer is deep
​https://bugs.webkit.org/show_bug.cgi?id=149174

Patch by Jinyoung Hur <​hur.ims@navercorp.com> on 2015-09-15
Reviewed by Dean Jackson.

Copied the stencil mask related tests from the webgl/1.0.2/resources/webgl_test_files/conformance/state/gl-get-calls.html.

It seems that there is a difference in the way that glGetIntegerV returns an unsigned int type value among
OpenGL implementatios. Some return the whole bits of value(e.g., 0xffffffff -> 0xffffffff), whereas some(e.g., ANGLE)
return a max-int-clamped value(e.g., 0xffffffff -> 0x7fffffff).

It would be good to make this test independent on the OpenGL implementations.

• fast/canvas/webgl/gl-get-calls-expected.txt:
• fast/canvas/webgl/gl-get-calls.html:

6:34 PM Changeset in webkit [189837] by Gyuyoung Kim

• 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening 16th Sep.

Mark fast/css, fast/form tests to failure. Besides some tests of imported/w3c/web-platform-tests/html
are marked to pass on EFL port.

• platform/efl/TestExpectations:

6:31 PM Changeset in webkit [189836] by benjamin@webkit.org

• 6 edits
  6 adds in trunk

Style invalidation affecting siblings does not work with inline-style changes
​https://bugs.webkit.org/show_bug.cgi?id=149189

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-09-15
Reviewed by Antti Koivisto.

Source/WebCore:

Style::resolveTree() made the assumption that inline style changes only affect
descendants and should not participate in "StyleRecalcAffectsNextSiblingElementStyle".
That was wrong. If the inline style change through CSSOM, it can cause the creation
of a style attribute, which is observable through "StyleRecalcAffectsNextSiblingElementStyle".

This patch removes the incorrect assumption. Style invalidation is always propagated now.

Tests: fast/css/style-attribute-invalidation-propagates-to-counted-siblings.html

fast/css/style-attribute-invalidation-propagates-to-direct-siblings.html
fast/css/style-attribute-invalidation-propagates-to-indirect-siblings.html

• css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::InlineCSSStyleDeclaration::didMutate): Deleted.

• dom/StyledElement.cpp:

(WebCore::StyledElement::inlineStyleChanged):

• dom/StyledElement.h:

(WebCore::StyledElement::invalidateStyleAttribute):
Clean up inline-style invalidation a tiny bit.

• style/StyleResolveTree.cpp:

(WebCore::Style::resolveTree):
Fix the bug.

LayoutTests:

• fast/css/style-attribute-invalidation-propagates-to-counted-siblings-expected.txt: Added.
• fast/css/style-attribute-invalidation-propagates-to-counted-siblings.html: Added.
• fast/css/style-attribute-invalidation-propagates-to-direct-siblings-expected.txt: Added.
• fast/css/style-attribute-invalidation-propagates-to-direct-siblings.html: Added.
• fast/css/style-attribute-invalidation-propagates-to-indirect-siblings-expected.txt: Added.
• fast/css/style-attribute-invalidation-propagates-to-indirect-siblings.html: Added.

6:14 PM Changeset in webkit [189835] by Wenson Hsieh

• 2 edits in trunk/Websites/webkit.org

Add anchor tags for scroll snapping examples.

• demos/scroll-snap/index.html: Added anchor tags.

6:03 PM Changeset in webkit [189834] by commit-queue@webkit.org

• 12 edits in trunk/Source

Web Inspector: Paused Debugger prevents page reload
​https://bugs.webkit.org/show_bug.cgi?id=148174

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-15
Reviewed by Brian Burg.

Source/JavaScriptCore:

• debugger/Debugger.h:

(JSC::Debugger::suppressAllPauses):
(JSC::Debugger::setSuppressAllPauses):

• debugger/Debugger.cpp:

(JSC::Debugger::Debugger):
(JSC::Debugger::pauseIfNeeded):

• inspector/agents/InspectorDebuggerAgent.h:
• inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::setSuppressAllPauses):
Provide a way to suppress pauses.

Source/WebCore:

When navigating the page while paused, suppress any pausing until the page
has completed navigation. If not paused and navigating, you can still pause
in pagehide and unload handlers or other late page events.

Could not write a reliable test for this at the moment.
InspectorTest.reloadPage has multiple issues with the output,
so I'll investigate making reload tests more reliable later.

• inspector/InspectorController.h:
• inspector/InspectorController.cpp:

(WebCore::InspectorController::resume): Deleted.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
We now use existing InspectorInstrumentation functions instead of a method
on InspectorController during load. In dropping the method InspectorController
can drop a member variable no longer used.

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willStartProvisionalLoad):
Add a new instrumentation hook.

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willStartProvisionalLoadImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
When starting or completing main frame navigations, let the PageDebuggerAgent do some work.

• inspector/PageDebuggerAgent.h:
• inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::mainFrameStartedLoading):
(WebCore::PageDebuggerAgent::mainFrameStoppedLoading):
(WebCore::PageDebuggerAgent::mainFrameNavigated):
Suppress pausing if navigating while paused. Otherwise behave as normal.

6:00 PM Changeset in webkit [189833] by Brent Fulgham

• 17 edits in trunk

[Win] Provide a means for viewing the layer tree
​https://bugs.webkit.org/show_bug.cgi?id=149165

Reviewed by Simon Fraser.

Source/WebCore:

Revise the old fprintf logic to generate a string
containing the layer tree so that it can be output
to the debugger (or elsewhere).

• platform/graphics/ca/PlatformCALayer.h: Rename 'printTree'

to 'printLayerTree', and make it available in release builds.

• platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::printLayerTree): Added. Calls into
the PlatformCALayer implementation.

• platform/graphics/ca/win/CACFLayerTreeHost.h:
• platform/graphics/ca/win/PlatformCALayerWin.cpp:

(printIndent): Revise to use two-space indent and use StringBuilder.
(printTransform): Ditto.
(printColor): Added helper function.
(printLayer): Revised to output information on the layer contents.
(PlatformCALayerWin::printLayerTree): Renamed from 'printTree'.
(PlatformCALayerWin::printTree): Deleted.

• platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::drawRepaintCounters): Drive-by fix. Match the
cocoa repaint counter logic by not painting counters for the layers that
contain the tile grid.

• platform/graphics/ca/win/PlatformCALayerWin.h:
• platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::drawRepaintCounters):

Source/WebKit/win:

Add a new WebView method "printLayerTree" so that clients
can get a string dump of the current layer tree. Add this
to a new COM interface version so no existing clients break
compatibility.

• Interfaces/IWebViewPrivate.idl:
• WebView.cpp:

(WebView::QueryInterface): Recognize the new interface version.
(WebView::printLayerTree): Added. This just calls the WebCore
implementation.

• WebView.h:

Tools:

Update MiniBrowser with a new Debug menu option that will
dump the current layer tree to the debug console.

• MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
• MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
• MiniBrowser/win/Common.cpp:

(WndProc): Add handler for 'Print Layer Tree' menu option.

• MiniBrowser/win/MiniBrowser.cpp:

(MiniBrowser::printLayerTree): Added Handler.

• MiniBrowser/win/MiniBrowser.h:

5:30 PM Changeset in webkit [189832] by mmaxfield@apple.com

• 6 edits
  2 adds in trunk

Nested isolates can cause an infinite loop when laying out bidi runs
​https://bugs.webkit.org/show_bug.cgi?id=149153

Reviewed by David Hyatt.

Source/WebCore:

When traversing bidi runs, we might encounter a run which is supposed to be isolated. In this
situation, we will append a placeholder run in the run list, and remember a pointer to these
isolated runs inside BidiResolver. Then, once we're done traversing the bidi runs, we return
to the isolated runs and handle them separately (and replace the placeholder with the result).

However, due to the fact that our BidiRuns start at leaf nodes, we have to keep track of which
local root of the render tree we were inspecting (to ensure that we visit the same node
multiple times if there are nested isolate spans). We were not correctly keeping track of this
local root, which was leading us to consider the same root multiple times, thereby leading to
an infinite loop.

The solution is simply to keep root information alongside the isolated run information inside
BidiResolver. However, BidiResolver is inside platform/, which means that this new type should
be a template argument, just like how BidiRun itself is a template argument.

This new type, BidiIsolatedRun, holds all the information that our isolate-revisiting logic
needs inside constructBidiRunsForSegment(). It also holds a reference to the placeholder run
which we will replace.

Test: fast/text/international/unicode-bidi-isolate-nested-crash.html

• platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawBidiText): BidiIsolatedRun template argument is unused, so pass
in Void.

• platform/text/BidiResolver.h: Add template argument.

(WebCore::BidiResolver::isolatedRuns):
(WebCore::IsolatedRun>::~BidiResolver):
(WebCore::IsolatedRun>::appendRun):
(WebCore::IsolatedRun>::embed):
(WebCore::IsolatedRun>::checkDirectionInLowerRaiseEmbeddingLevel):
(WebCore::IsolatedRun>::lowerExplicitEmbeddingLevel):
(WebCore::IsolatedRun>::raiseExplicitEmbeddingLevel):
(WebCore::IsolatedRun>::commitExplicitEmbedding):
(WebCore::IsolatedRun>::updateStatusLastFromCurrentDirection):
(WebCore::IsolatedRun>::reorderRunsFromLevels):
(WebCore::IsolatedRun>::createBidiRunsForLine):
(WebCore::IsolatedRun>::setMidpointForIsolatedRun): Use references instead of pointers.
(WebCore::IsolatedRun>::midpointForIsolatedRun): Ditto.
(WebCore::Run>::~BidiResolver): Deleted.
(WebCore::Run>::appendRun): Deleted.
(WebCore::Run>::embed): Deleted.
(WebCore::Run>::checkDirectionInLowerRaiseEmbeddingLevel): Deleted.
(WebCore::Run>::lowerExplicitEmbeddingLevel): Deleted.
(WebCore::Run>::raiseExplicitEmbeddingLevel): Deleted.
(WebCore::Run>::commitExplicitEmbedding): Deleted.
(WebCore::Run>::updateStatusLastFromCurrentDirection): Deleted.
(WebCore::Run>::reorderRunsFromLevels): Deleted.
(WebCore::Run>::createBidiRunsForLine): Deleted.
(WebCore::Run>::setMidpointForIsolatedRun): Deleted.
(WebCore::Run>::midpointForIsolatedRun): Deleted.

• rendering/InlineIterator.h:

(WebCore::BidiIsolatedRun::BidiIsolatedRun): New type.
(WebCore::addPlaceholderRunForIsolatedInline): Create new type, and include local root
information.
(WebCore::IsolateTracker::addFakeRunIfNecessary): Include local root information.
(WebCore::InlineBidiResolver::appendRun): Ditto.

• rendering/RenderBlockLineLayout.cpp: Update for new BidiIsolatedRun type.

(WebCore::setUpResolverToResumeInIsolate):
(WebCore::constructBidiRunsForSegment):

• rendering/line/TrailingObjects.h:

LayoutTests:

• fast/text/international/unicode-bidi-isolate-nested-crash-expected.html: Added.
• fast/text/international/unicode-bidi-isolate-nested-crash.html: Added.

5:19 PM Changeset in webkit [189831] by beidson@apple.com

• 10 edits
  2 copies
  1 add in trunk/Source

Add empty IDBFactory implementation for Modern IDB.
​https://bugs.webkit.org/show_bug.cgi?id=149191

Reviewed by Jer Noble.

Source/WebCore:

No new tests (No behavior change).

• Modules/indexeddb/DOMWindowIndexedDatabase.cpp:

(WebCore::DOMWindowIndexedDatabase::indexedDB):

• Modules/indexeddb/client/IDBFactoryImpl.cpp:

(WebCore::IDBClient::IDBFactory::create):
(WebCore::IDBClient::IDBFactory::IDBFactory):
(WebCore::IDBClient::IDBFactory::getDatabaseNames):
(WebCore::IDBClient::IDBFactory::open):
(WebCore::IDBClient::IDBFactory::deleteDatabase):
(WebCore::IDBClient::IDBFactory::cmp):

• Modules/indexeddb/client/IDBFactoryImpl.h:

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:

• loader/EmptyClients.cpp:
• page/DatabaseProvider.h:

Source/WebKit:

• Storage/WebDatabaseProvider.h:

Source/WebKit2:

• WebProcess/Databases/WebDatabaseProvider.h:

5:16 PM Changeset in webkit [189830] by Antti Koivisto

• 61 edits in trunk/Source

Split FontDescription into lower and higher level types
​https://bugs.webkit.org/show_bug.cgi?id=149036

Reviewed by Darin Adler.

Currently FontDescription is used through the text subsystem. However much of the data it
carries is only needed by FontCascade and text layout but not by the lower level Font/FontCache
layer. This makes code confusing. For example families specified in FontDescription are ignored
at lower levels.

Split it into a low level FontDescription and a high level FontCascadeDescription type:

FontDescription <-> Font
FontCascadeDescription <-> FontCascade

The former only carries information that is needed to instantiate a Font or fetch it from the FontCache.
The latter has additional data for CSS font cascade semantics and other higher level features.

5:05 PM Changeset in webkit [189829] by mmaxfield@apple.com

• 4 edits in trunk/Source/WebCore

GraphicsContext::drawBidiText()'s BidiResolver should not have isolated runs
​https://bugs.webkit.org/show_bug.cgi?id=149193

Reviewed by Anders Carlsson.

There are two users of BidiResolver, one which needs isolated runs (in RenderBlockLineLayout) and
one which doesn't (in GraphicsContext::drawBidiText()). Because of [1], the isolated runs vector
is migrating to a new type outside of platform/. Therefore, only the first user of BidiResolver
should have this member variable.

This is achieved by creating two subclasses of BidiResolver, and using the Curiously Repeating
Template pattern to downcast into specializations.

[1] ​https://bugs.webkit.org/show_bug.cgi?id=149153

No new tests because there is no behavior change.

• platform/text/BidiResolver.h:

(WebCore::BidiResolverBase::BidiResolverBase):
(WebCore::BidiResolverBase::increment):
(WebCore::BidiResolverBase::appendRun):
(WebCore::BidiResolverBase::incrementInternal):
(WebCore::IsolateRun>::~BidiResolverWithIsolate):
(WebCore::Subclass>::appendRunInternal):
(WebCore::Subclass>::embed):
(WebCore::Subclass>::checkDirectionInLowerRaiseEmbeddingLevel):
(WebCore::Subclass>::lowerExplicitEmbeddingLevel):
(WebCore::Subclass>::raiseExplicitEmbeddingLevel):
(WebCore::Subclass>::commitExplicitEmbedding):
(WebCore::Subclass>::updateStatusLastFromCurrentDirection):
(WebCore::Subclass>::reorderRunsFromLevels):
(WebCore::Subclass>::createBidiRunsForLine):
(WebCore::Subclass>::setMidpointForIsolatedRun):
(WebCore::Subclass>::midpointForIsolatedRun):
(WebCore::BidiResolver::BidiResolver): Deleted.
(WebCore::BidiResolver::increment): Deleted.
(WebCore::BidiResolver::isolatedRuns): Deleted.
(WebCore::Run>::~BidiResolver): Deleted.
(WebCore::Run>::appendRun): Deleted.
(WebCore::Run>::embed): Deleted.
(WebCore::Run>::checkDirectionInLowerRaiseEmbeddingLevel): Deleted.
(WebCore::Run>::lowerExplicitEmbeddingLevel): Deleted.
(WebCore::Run>::raiseExplicitEmbeddingLevel): Deleted.
(WebCore::Run>::commitExplicitEmbedding): Deleted.
(WebCore::Run>::updateStatusLastFromCurrentDirection): Deleted.
(WebCore::Run>::reorderRunsFromLevels): Deleted.
(WebCore::Run>::createBidiRunsForLine): Deleted.
(WebCore::Run>::setMidpointForIsolatedRun): Deleted.
(WebCore::Run>::midpointForIsolatedRun): Deleted.

• rendering/InlineIterator.h:

(WebCore::InlineBidiResolver::incrementInternal):
(WebCore::InlineBidiResolver::appendRunInternal):
(WebCore::InlineBidiResolver::increment): Deleted.
(WebCore::InlineBidiResolver::appendRun): Deleted.

• rendering/line/TrailingObjects.h:

4:44 PM Changeset in webkit [189828] by BJ Burg

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: command-click in NewTabContentView should open new tab without switching to it
​https://bugs.webkit.org/show_bug.cgi?id=149173

Reviewed by Joseph Pecoraro.

To allow a user to quickly restore tabs, it should be possible to command-click
all the tabs that are desired without going back through the [+] tab button.

• UserInterface/Base/Main.js:

(WebInspector.createNewTabWithType): Renamed.

Use an options object and split creating the tab from deleting the
replaced tab and showing the new tab. Add better error checking.

(WebInspector.createNewTab): Deleted.

• UserInterface/Views/NewTabContentView.js:

(WebInspector.NewTabContentView):
(WebInspector.NewTabContentView.prototype._createNewTabWithType): Renamed.

If the meta key is pressed, don't switch to the new tab or remove this view
unless there are no more tabs that can be created beyond the current one.

(WebInspector.NewTabContentView.prototype._allowableTabTypes): Added.
(WebInspector.NewTabContentView.prototype._createNewTab): Deleted.

4:03 PM WebKitGTK/2.8.x edited by clopez@igalia.com

(diff)

3:10 PM Changeset in webkit [189827] by Chris Dumez

• 6 edits in trunk

new Event() without parameter should throw
​https://bugs.webkit.org/show_bug.cgi?id=149146
<rdar://problem/22565070>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C test now that a new check is passing.

• web-platform-tests/dom/events/Event-constructors-expected.txt:

Source/WebCore:

new Event() without parameter should throw because the type parameter
is mandatory as per the specification:
​https://dom.spec.whatwg.org/#interface-event

Both Firefox and Chrome throw in this case. However, WebKit was
creating an event whose type is the string "undefined". This patch
aligns our behavior with the specification and other major browsers.

No new tests, already covered by existing test.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDefinition):

• bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor):

2:50 PM Changeset in webkit [189826] by clopez@igalia.com

• 2 edits in trunk/Source/WebCore

[GTK] Build failure with ACCELERATED_2D_CANVAS when cairo-gl has built with OpenGLESv2 support only.
​https://bugs.webkit.org/show_bug.cgi?id=149172

Reviewed by Martin Robinson.

No new tests, no behavior change.

• platform/graphics/glx/GLContextGLX.cpp:

(WebCore::GLContextGLX::cairoDevice):

2:39 PM Changeset in webkit [189825] by Chris Dumez

• 11 edits in trunk

Element.getAttributeNS() should return null if the attribute does not exist
​https://bugs.webkit.org/show_bug.cgi?id=149180
<rdar://problem/22561011>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline several W3C DOM tests now that more checks are passing.

• web-platform-tests/dom/nodes/attributes-expected.txt:
• web-platform-tests/dom/nodes/case-expected.txt:

Source/WebCore:

Element.getAttributeNS() should return null if the attribute does not
exist, similarly to what Element.getAttribute() does:

• ​https://dom.spec.whatwg.org/#element (both return a nullable DOMString).
• ​https://dom.spec.whatwg.org/#dom-element-getattributens (step 2)

Firefox and Chrome match the specification. However, WebKit was returning
an empty string for getAttributeNS() and null for getAttribute(). This
patch aligns WebKit's behavior with the specification and other browsers.

No new tests, already covered by existing tests.

• dom/Element.idl:

LayoutTests:

Rebaseline / update existing tests now that our behavior has changed.

• fast/dom/Element/attribute-uppercase-expected.txt:
• fast/dom/Element/mozilla-dom-base-tests/test_bug1075702-expected.txt:
• fast/dom/Element/mozilla-dom-base-tests/test_bug1075702.html:
• fast/dom/Element/setAttributeNode-overriding-lowercase-values-1-expected.txt:
• fast/dom/Element/setAttributeNode-overriding-lowercase-values-2-expected.txt:

2:31 PM Changeset in webkit [189824] by rniwa@webkit.org

• 11 edits in trunk/Source/WebCore

ContentDistribution should be only used for details elements
​https://bugs.webkit.org/show_bug.cgi?id=149148

Reviewed by Antti Koivisto.

Extracted ShadowRootWithInsertionPoints out of ShadowRoot for HTMLDetailsElement and HTMLSummaryElement.

We don't add a separate .h and .cpp files since this is a temporary measure until we replace it with
a slot-based shadow DOM implementation.

No new tests. There should be no observable behavioral change.

• dom/Element.cpp:

(WebCore::Element::addShadowRoot): Removed the call to didShadowBoundaryChange since this function is only
called in ensureUserAgentShadowRoot. Also moved the call to didAddUserAgentShadowRoot for
HTMLDetailsElement's shadow root which uses this function instead of ensureUserAgentShadowRoot.
(WebCore::Element::removeShadowRoot): Removed the call to invalidateDistribution since it's only called by
~Element.
(WebCore::Element::createShadowRoot):
(WebCore::Element::ensureUserAgentShadowRoot): Moved the call didAddUserAgentShadowRoot into addShadowRoot
since HTMLDetailsElement uses a subclass of ShadowRoot.
(WebCore::Element::childrenChanged):
(WebCore::Element::removeAllEventListeners):

• dom/Element.h:

(Element::addShadowRoot): Made this function a protected member as it's now used by HTMLDetailsElement.

• dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::childrenChanged): Deleted.

• dom/ShadowRoot.h:

(WebCore::ShadowRoot::distributor): Made this a virtual function and return nullptr by default.
(WebCore::ShadowRoot::isOrphan):

• html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::create): Uses ShadowRootWithInsertionPoints instead of ShadowRoot.

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::runPostTypeUpdateTasks): Removed the call to invalidateDistribution since it's
only relevant for HTMLDetailsElement's shadow DOM.

• html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::create): Uses ShadowRootWithInsertionPoints instead of ShadowRoot.

• html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::ensureDistribution):
(WebCore::ContentDistributor::invalidateDistribution):

• html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::childrenChanged):
(WebCore::InsertionPoint::insertedInto):
(WebCore::InsertionPoint::removedFrom):
(WebCore::findInsertionPointOf):
(WebCore::ShadowRootWithInsertionPoints::childrenChanged): Moved from ShadowRoot.

• html/shadow/InsertionPoint.h:

(WebCore::ShadowRootWithInsertionPoints::create): Added.
(WebCore::ShadowRootWithInsertionPoints::ShadowRootWithInsertionPoints): Added.

1:42 PM Changeset in webkit [189823] by Chris Dumez

• 3 edits in trunk/LayoutTests

Unreviewed, rebaseline several W3C HTML tests on iOS after r189762.

• platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
• platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt:

1:00 PM Changeset in webkit [189822] by commit-queue@webkit.org

• 12 edits in trunk/Source/JavaScriptCore

Implement calls to JavaScript functions in WebAssembly
​https://bugs.webkit.org/show_bug.cgi?id=149093

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-09-15
Reviewed by Filip Pizlo.

This patch implements calls to JavaScript functions in WebAssembly.
WebAssembly functions can only call JavaScript functions that are
imported to their module via an object that is passed into
loadWebAssembly(). References to JavaScript functions are resolved at
the module's load time, just like asm.js.

• jsc.cpp:

(GlobalObject::finishCreation):
(functionLoadWebAssembly):

• tests/stress/wasm-calls.js:
• tests/stress/wasm/calls.wasm:
• wasm/JSWASMModule.cpp:

(JSC::JSWASMModule::visitChildren):

• wasm/JSWASMModule.h:

(JSC::JSWASMModule::importedFunctions):

• wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::buildCallImport):

• wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseExpressionF64):
(JSC::WASMFunctionParser::parseCallImport):

• wasm/WASMFunctionParser.h:
• wasm/WASMFunctionSyntaxChecker.h:

(JSC::WASMFunctionSyntaxChecker::buildCallInternal):
(JSC::WASMFunctionSyntaxChecker::buildCallImport):
(JSC::WASMFunctionSyntaxChecker::updateTempStackHeightForCall):

• wasm/WASMModuleParser.cpp:

(JSC::WASMModuleParser::WASMModuleParser):
(JSC::WASMModuleParser::parse):
(JSC::WASMModuleParser::parseModule):
(JSC::WASMModuleParser::parseFunctionImportSection):
(JSC::WASMModuleParser::getImportedValue):
(JSC::parseWebAssembly):

• wasm/WASMModuleParser.h:

12:56 PM Changeset in webkit [189821] by Brent Fulgham

• 11 edits
  2 adds in trunk/Source/WebCore

[Win] Tiled drawing is rendering more times than it should
​https://bugs.webkit.org/show_bug.cgi?id=149144
<rdar://problem/22313905>

Reviewed by Simon Fraser.

Provide a more faithful implemenation of the Objective C tiled drawing logic.
(1) Create a new WebTiledBackingLayerWin class that represents a the

container of tiles. This matches the Objective C design.

(2) Move implementation of several methods (e.g., isOpaque) to the internal

class implementation so that the Tile Drawing logic can perform special
handling in these cases.

(3) Remove the duplicated Tiled Drawing logic from PlatformCALayerWinInternal,

since it was just duplicating code in TileController and TileGrid.

(4) Clean up the display callback code to avoid performing incorrect flipping

of the coordinate system.

• PlatformAppleWin.cmake: Add new WebTiledBackingLayerWin file.
• WebCore.vcxproj/WebCore.vcxproj: Add the new WebTiledBackingLayerWin files.
• WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
• platform/graphics/ca/PlatformCALayer.cpp:

(PlatformCALayer::flipContext): Added convenience method.
(PlatformCALayer::drawRepaintIndicator): Ditto.

• platform/graphics/ca/TileGrid.cpp:

(TileGrid::platformCALayerPaintContents): Flip the context before drawing the repaint
indicator on Windows.

• platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayerWin::PlatformCALayerWin): Create a WebTiledBackingLayerWin
object if using tiled drawing.
(PlatformCALayerWin::~PlatformCALayerWin):
(PlatformCALayerWin::isOpaque): Move implementation to internal class.
(PlatformCALayerWin::setOpaque): Ditto.
(PlatformCALayerWin::setBorderWidth): Ditto.
(PlatformCALayerWin::setBorderColor): Ditto.
(PlatformCALayerWin::contentsScale): Ditto.
(PlatformCALayerWin::setContentsScale): Ditto.
(PlatformCALayerWin::cornerRadius): Ditto.
(PlatformCALayerWin::tiledBacking): Ditto.
(PlatformCALayerWin::drawTextAtPoint): New helper method to draw repaint counter
text. Needed to work around bug in CG.

• platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::PlatformCALayerWinInternal): Remove tiling-logic
related member variables.
(PlatformCALayerWinInternal::~PlatformCALayerWinInternal):
(shouldInvertBeforeDrawingContent): Added convenience method.
(shouldInvertBeforeDrawingRepaintCounters): Ditto.
(PlatformCALayerWinInternal::displayCallback):
(PlatformCALayerWinInternal::drawRepaintCounters): Helper method to
share code between the two layer classes.
(PlatformCALayerWinInternal::internalSetNeedsDisplay): use nullptr.
(PlatformCALayerWinInternal::setNeedsDisplay): Ditto.
(PlatformCALayerWinInternal::setNeedsDisplayInRect): Move tiled code
to WebTiledBackingLayerWin and simplify the remaing code.
(PlatformCALayerWinInternal::setSublayers): Remove tile code.
(PlatformCALayerWinInternal::getSublayers): Ditto.
(PlatformCALayerWinInternal::removeAllSublayers): Ditto.
(PlatformCALayerWinInternal::insertSublayer): Ditto.
(PlatformCALayerWinInternal::sublayerCount): Ditto.
(PlatformCALayerWinInternal::indexOfSublayer): Ditto.
(PlatformCALayerWinInternal::sublayerAtIndex): Ditto.
(PlatformCALayerWinInternal::setBounds): Ditto.
(PlatformCALayerWinInternal::setFrame): Ditto.
(PlatformCALayerWinInternal::isOpaque): Ditto.
(PlatformCALayerWinInternal::setOpaque): Ditto.
(PlatformCALayerWinInternal::contentsScale): Ditto.
(PlatformCALayerWinInternal::setContentsScale): Ditto.
(PlatformCALayerWinInternal::setBorderWidth): Ditto.
(PlatformCALayerWinInternal::setBorderColor): Ditto.
(layerTypeIsTiled): Deleted.
(PlatformCALayerWinInternal::constrainedSize): Deleted.
(PlatformCALayerWinInternal::tileDisplayCallback): Deleted.
(PlatformCALayerWinInternal::addTile): Deleted.
(PlatformCALayerWinInternal::removeTile): Deleted.
(PlatformCALayerWinInternal::tileAtIndex): Deleted.
(PlatformCALayerWinInternal::tileCount): Deleted.
(PlatformCALayerWinInternal::updateTiles): Deleted.
(PlatformCALayerWinInternal::drawTile): Deleted.
(PlatformCALayerWinInternal::createTileController): Deleted.
(PlatformCALayerWinInternal::tiledBacking): Deleted.

• platform/graphics/ca/win/PlatformCALayerWinInternal.h:

(WebCore::PlatformCALayerWinInternal::owner):

• platform/graphics/ca/win/WebTiledBackingLayerWin.cpp: Added.

(WebTiledBackingLayerWin::WebTiledBackingLayerWin):
(WebTiledBackingLayerWin::~WebTiledBackingLayerWin):
(DisplayOnMainThreadContext::DisplayOnMainThreadContext):
(redispatchOnMainQueue):
(WebTiledBackingLayerWin::displayCallback):
(WebTiledBackingLayerWin::setNeedsDisplay):
(WebTiledBackingLayerWin::setNeedsDisplayInRect):
(WebTiledBackingLayerWin::setBounds):
(WebTiledBackingLayerWin::isOpaque):
(WebTiledBackingLayerWin::setOpaque):
(WebTiledBackingLayerWin::contentsScale):
(WebTiledBackingLayerWin::setContentsScale):
(WebTiledBackingLayerWin::setBorderWidth):
(WebTiledBackingLayerWin::setBorderColor):
(WebTiledBackingLayerWin::createTileController):
(WebTiledBackingLayerWin::tiledBacking):
(WebTiledBackingLayerWin::invalidate):

• platform/graphics/ca/win/WebTiledBackingLayerWin.h: Added.

12:47 PM Changeset in webkit [189820] by Csaba Osztrogonác

• 3 edits in trunk/Source/JavaScriptCore

Fix the !ENABLE(DFG_JIT) build after r188696
​https://bugs.webkit.org/show_bug.cgi?id=149158

Reviewed by Yusuke Suzuki.

• bytecode/GetByIdStatus.cpp:
• bytecode/GetByIdStatus.h:

12:26 PM Changeset in webkit [189819] by commit-queue@webkit.org

• 5 edits in trunk/Source/JavaScriptCore

functions that use try/catch will allocate a top level JSLexicalEnvironment even when it is not necessary
​https://bugs.webkit.org/show_bug.cgi?id=148169

Patch by Saam barati <​sbarati@apple.com> on 2015-09-15
Reviewed by Geoffrey Garen.

We used to do this before we had proper lexical scoping
in the bytecode generator. There is absolutely no reason
why need to allocate a top-level "var" activation when a
function/program uses a "catch" block.

• parser/ASTBuilder.h:

(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::incConstants):
(JSC::ASTBuilder::usesThis):
(JSC::ASTBuilder::usesArguments):
(JSC::ASTBuilder::usesWith):
(JSC::ASTBuilder::usesEval):
(JSC::ASTBuilder::usesCatch): Deleted.

• parser/Nodes.h:

(JSC::ScopeNode::isStrictMode):
(JSC::ScopeNode::setUsesArguments):
(JSC::ScopeNode::usesThis):
(JSC::ScopeNode::needsActivation):
(JSC::ScopeNode::hasCapturedVariables):
(JSC::ScopeNode::captures):
(JSC::ScopeNode::needsActivationForMoreThanVariables): Deleted.

• parser/ParserModes.h:
• runtime/Executable.h:

(JSC::ScriptExecutable::usesEval):
(JSC::ScriptExecutable::usesArguments):
(JSC::ScriptExecutable::needsActivation):
(JSC::ScriptExecutable::isStrictMode):
(JSC::ScriptExecutable::ecmaMode):

12:00 PM Changeset in webkit [189818] by msaboff@apple.com

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r189774): CLoop doesn't build after r189774
​https://bugs.webkit.org/show_bug.cgi?id=149171

Unreviewed build fix for the C Loop.

Added needed C Loop label opcodes.

• bytecode/BytecodeList.json:

11:38 AM Changeset in webkit [189817] by hyatt@apple.com

• 11 edits
  13 adds in trunk

[New Block-Inside-Inline Model] Implement margin collapsing across contiguous anonymous inline blocks.
​https://bugs.webkit.org/show_bug.cgi?id=149132

Reviewed by Zalan Bujtas.

Source/WebCore:

Added new tests inside fast/block/inside-inlines/

• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::anonymousInlineBlock):
Change this accessor to be more robust and be willing to both recur (in case we ever do decide intermediate line boxes should exist)
and to type check. This is not currently needed, but I'm just being paranoid and future proof.

(WebCore::InlineFlowBox::addToLine):
Again, for thoroughness, I am making sure to propagate the hasAnonymousInlineBlock() bit through to parents. This is only needed
if we build intermediate line boxes for lines with anonymous inline blocks.

(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
Anonymous inline blocks receive a layout via layoutBlockChild, in order to make sure that margin collapsing runs. This means
that unlike other line objects, the position of the child has been determined already. Therefore we simply set the position
of the line box that wraps the anonymous inline block to the already-computed position for that block.

Also patch the code that sets lineTop and lineBottom using the root box's dimensions. We don't really care about the root line
box on anonymous inline block lines and just want to set lineTop and lineBottom to fit the anonymous inline block.

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::collapseMargins):
(WebCore::RenderBlockFlow::collapseMarginsWithChildInfo):
Refactor collapseMargins to call a helper function that can pass in a previous "sibling", and that can handle the child
being null. We do this to perform a margin collapse when anonymous inline blocks run up against regular lines (which is like
collapsing with a sibling block "child").

• rendering/RenderBlockFlow.h:

Tweak the MarginInfo constructor to take a const RenderBlockFlow. Tweak some line layout methods to pass in the LineLayoutState
so that MarginInfo is available during line layout.

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::createLineBoxes):
When we create a new line box, if it is not an anonymous inline block line and our previous line was, simulate a margin
collapse in order to possibly push the line box down or up. Re-use the pagination adjustment code to rewind line layout
and perform it again if pushed below a float.

(WebCore::constructBidiRunsForSegment):
(WebCore::RenderBlockFlow::layoutRunsAndFloats):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::layoutLineBoxes):
(WebCore::RenderBlockFlow::determineStartPosition):
(WebCore::RenderBlockFlow::matchedEndLine):
(WebCore::RenderBlockFlow::updateRegionForLine):
(WebCore::RenderBlockFlow::marginCollapseLinesFromStart):
Patch line layout to run margin collapsing when anonymous inline blocks are encountered. This involves making sure
margin info and float bottom positions are passed through so that layoutBlockChild can be properly called on
anonymous inline blocks that we encounter.

In addition line layout when it syncs dirty lines has to run margin collapsing on earlier lines in order to make
sure margin info is properly set up at the first dirty line position.

Note that there will be more improvements/changes in this area (dirty line syncing), as the current model is inefficient
when many anonymous inline blocks are scattered throughout a large-scale line box tree.

• rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::ascentAndDescentForBox):
Make sure to rely on the block layout code for the placement of the boxes themselves. Set up the line box code to not have
an effect on ascent/descent.

• rendering/line/BreakingContext.h:

(WebCore::BreakingContext::BreakingContext):
(WebCore::BreakingContext::handleReplaced):
When we encounter an anonymous inline block, lay it out when it is seen. We have to delay the layout, since we have
to be able to perform it mid-line-layout when the containing block's logical height is at the correct value and all previous
lines are placed. Margin info also has to be current.

• rendering/line/LineBreaker.cpp:
• rendering/line/LineBreaker.h:

Patched to pass LineLayoutState through so that the stuff we need to perform block layout is available (margin info and float vars).

• rendering/line/LineLayoutState.h:

Add the block layout margin and float bottom information to the line layout state so that we have it available when performing
layouts and margin collapses on anonymous inline block children.

LayoutTests:

• fast/block/inside-inlines/new-model/margin-collapse: Added.
• fast/block/inside-inlines/new-model/margin-collapse/001-expected.html: Added.
• fast/block/inside-inlines/new-model/margin-collapse/001.html: Added.
• fast/block/inside-inlines/new-model/margin-collapse/002-expected.html: Added.
• fast/block/inside-inlines/new-model/margin-collapse/002.html: Added.
• fast/block/inside-inlines/new-model/margin-collapse/003-expected.html: Added.
• fast/block/inside-inlines/new-model/margin-collapse/003.html: Added.
• fast/block/inside-inlines/new-model/margin-collapse/004-expected.html: Added.
• fast/block/inside-inlines/new-model/margin-collapse/004.html: Added.

11:36 AM Changeset in webkit [189816] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Watch Expressions uncaught exceptions on page reload
​https://bugs.webkit.org/show_bug.cgi?id=149150

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-15
Reviewed by Brian Burg.

Instead of waiting 50ms to Resume, when the page navigates
Resume immediately. This ensures nobody is using a stale
activeCallFrame after the navigation.

Also clean up the manager a bit by removing some deletes.

• UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.restoreBreakpointsSoon):
(WebInspector.DebuggerManager.prototype.reset):
(WebInspector.DebuggerManager.prototype.debuggerDidPause):
(WebInspector.DebuggerManager.prototype.debuggerDidResume):
(WebInspector.DebuggerManager.prototype._mainResourceDidChange):
(WebInspector.DebuggerManager.prototype._didResumeInternal):
(WebInspector.DebuggerManager.prototype._associateBreakpointsWithSourceCode):
(WebInspector.DebuggerManager.prototype.debuggerDidResume.delayedWork): Deleted.

11:26 AM Changeset in webkit [189815] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Closing the final inspector tab should be allowed
​https://bugs.webkit.org/show_bug.cgi?id=149130

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-15
Reviewed by Brian Burg.

Previously we did not allow closing the last inspector tab. Now, we
will allow closing all inspector tabs, and when the last is closed,
present an unclosable New Tab tab, which would then be used to create
a new tab.

• UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
If we have no tabs to restore, show the New Tab tab.

(WebInspector._openDefaultTab):
When the last tab is closed, the tab bar requests we open a default tab.
Open the New Tab tab.

(WebInspector.TabBar.prototype._handleClick):
Disallow closing the single default tab.

(WebInspector._newTabItemClicked):
(WebInspector.showNewTabTab):
Share logic for showing the New Tab tab.

• UserInterface/Views/NewTabContentView.js:

(WebInspector.NewTabContentView):
Mark the new tab's tab bar item as the "default" tab bar item. It gets
special behavior when it is the single normal tab (cannot be closed).

• UserInterface/Views/TabBar.css:

(body:not(.window-inactive) .tab-bar > .item:hover > .close):
(body:not(.window-inactive) .tab-bar.single-tab > .item.default-tab:hover > .close):
(.tab-bar.single-tab > .item.default-tab > .close):
(body:not(.window-inactive) .tab-bar:not(.single-tab) > .item:not(.hide-close-button):hover > .close): Deleted.
(.tab-bar > .item.hide-close-button > .close): Deleted.
Update styles to only disable the close button on the
"default-tab" when it is the "single-tab" open. Otherwise
always allow closing tabs.

• UserInterface/Views/TabBar.js:

(WebInspector.TabBar.prototype.removeTabBarItem):
(WebInspector.TabBar.prototype.hasNormalTab):
(WebInspector.TabBar.prototype._openDefaultTab):
When removing the last normal tab, send an event to open
the default tab.

• UserInterface/Views/TabBarItem.js:

(WebInspector.TabBarItem.prototype.get default):
(WebInspector.TabBarItem.prototype.get isDefaultTab):
(WebInspector.TabBarItem.prototype.set isDefaultTab):
(WebInspector.TabBarItem.prototype.get hideCloseButton): Deleted.
(WebInspector.TabBarItem.prototype.set hideCloseButton): Deleted.
Switch to marking a tab bar item as the default tab. This tab
will be allowed when it is the single remaining tab. Currently
the default tab is always the "New Tab" tab.

11:18 AM Changeset in webkit [189814] by BJ Burg

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: new tab content view should disallow split console
​https://bugs.webkit.org/show_bug.cgi?id=149164

Reviewed by Joseph Pecoraro.

• UserInterface/Views/NewTabContentView.js:

(WebInspector.NewTabContentView.prototype.get supportsSplitContentBrowser):

11:09 AM Changeset in webkit [189813] by beidson@apple.com

• 10 edits in trunk/Source/WebCore

Make the IDBAny::Type enum into an enum class.
​https://bugs.webkit.org/show_bug.cgi?id=149169.

Reviewed by Oliver Hunt.

No new tests (Cleanup, no behavior change).

• Modules/indexeddb/IDBAny.h:
• Modules/indexeddb/legacy/LegacyAny.cpp:

(WebCore::LegacyAny::createInvalid):
(WebCore::LegacyAny::createNull):
(WebCore::LegacyAny::LegacyAny):
(WebCore::LegacyAny::domStringList):
(WebCore::LegacyAny::idbCursor):
(WebCore::LegacyAny::idbCursorWithValue):
(WebCore::LegacyAny::idbDatabase):
(WebCore::LegacyAny::idbFactory):
(WebCore::LegacyAny::idbIndex):
(WebCore::LegacyAny::idbObjectStore):
(WebCore::LegacyAny::idbTransaction):
(WebCore::LegacyAny::scriptValue):
(WebCore::LegacyAny::string):
(WebCore::LegacyAny::integer):
(WebCore::LegacyAny::legacyCursor):
(WebCore::LegacyAny::legacyCursorWithValue):
(WebCore::LegacyAny::legacyDatabase):
(WebCore::LegacyAny::legacyFactory):
(WebCore::LegacyAny::legacyIndex):
(WebCore::LegacyAny::legacyObjectStore):
(WebCore::LegacyAny::legacyTransaction):

• Modules/indexeddb/legacy/LegacyCursor.cpp:

(WebCore::LegacyCursor::LegacyCursor):
(WebCore::LegacyCursor::effectiveObjectStore):

• Modules/indexeddb/legacy/LegacyObjectStore.cpp:
• Modules/indexeddb/legacy/LegacyOpenDBRequest.cpp:

(WebCore::LegacyOpenDBRequest::dispatchEvent):

• Modules/indexeddb/legacy/LegacyRequest.cpp:

(WebCore::LegacyRequest::getResultCursor):
(WebCore::effectiveObjectStore):

• bindings/js/JSIDBAnyCustom.cpp:

(WebCore::toJS):

• inspector/InspectorIndexedDBAgent.cpp:
• page/DatabaseProvider.h:

10:48 AM Changeset in webkit [189812] by Michael Catanzaro

• 1 edit
  1 delete in trunk/Source/WebCore/platform/gtk/po

[GTK] Remove outdated README under po directory
​https://bugs.webkit.org/show_bug.cgi?id=149166

Reviewed by Martin Robinson.

• README: Removed.

10:43 AM Changeset in webkit [189811] by commit-queue@webkit.org

• 19 edits
  4 adds in trunk

[INTL] Implement supportedLocalesOf on Intl Constructors
​https://bugs.webkit.org/show_bug.cgi?id=147599

Patch by Andy VanWagoner <​thetalecrafter@gmail.com> on 2015-09-15
Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

Implements all of the abstract operations used by supportedLocalesOf,
except during canonicalization it does not replace redundant tags,
or subtags with their preferred values.

• icu/unicode/ucal.h: Added.
• icu/unicode/udat.h: Added.
• icu/unicode/umisc.h: Added.
• icu/unicode/unum.h: Added.
• icu/unicode/utypes.h: Clear the U_SHOW_CPLUSPLUS_API flag to prevent C++ headers from being included.
• runtime/CommonIdentifiers.h: Adde localeMatcher.
• runtime/IntlCollatorConstructor.cpp:

(JSC::IntlCollatorConstructorFuncSupportedLocalesOf): Implemented.

• runtime/IntlDateTimeFormatConstructor.cpp:

(JSC::IntlDateTimeFormatConstructorFuncSupportedLocalesOf): Implemented.

• runtime/IntlNumberFormatConstructor.cpp:

(JSC::IntlNumberFormatConstructorFuncSupportedLocalesOf): Implemented.

• runtime/IntlObject.cpp:

(JSC::canonicalizeLanguageTag):
(JSC::getCanonicalLangTag):
(JSC::getPrivateUseLangTag):
(JSC::getGrandfatheredLangTag):
(JSC::canonicalizeLocaleList):
(JSC::bestAvailableLocale):
(JSC::lookupSupportedLocales):
(JSC::bestFitSupportedLocales):
(JSC::supportedLocales):
(JSC::getIntlStringOption):
(JSC::getIntlBooleanOption):

• runtime/IntlObject.h:
• runtime/JSCJSValue.h: Added toLength.
• runtime/JSCJSValue.cpp: Added toLength.

(JSC::JSValue::toLength): Implement ToLength from ECMA 262 6.0 7.1.15

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::intlCollatorAvailableLocales): Added lazy locale list.
(JSC::JSGlobalObject::intlDateTimeFormatAvailableLocales): Added lazy locale list.
(JSC::JSGlobalObject::intlNumberFormatAvailableLocales): Added lazy locale list.

• runtime/JSGlobalObject.h:

LayoutTests:

• js/intl-collator-expected.txt: Added tests for supportedLocalesOf
• js/intl-datetimeformat-expected.txt: Added tests for supportedLocalesOf
• js/intl-numberformat-expected.txt: Added tests for supportedLocalesOf
• js/script-tests/intl-collator.js: Added tests for supportedLocalesOf
• js/script-tests/intl-datetimeformat.js: Added tests for supportedLocalesOf
• js/script-tests/intl-numberformat.js: Added tests for supportedLocalesOf

9:36 AM Changeset in webkit [189810] by beidson@apple.com

• 10 edits in trunk/Source

Move most IDB object encoding/decoding from WebKit2 to WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=149152

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Cleanup, no behavior change).

• Modules/indexeddb/IDBDatabaseMetadata.h:

(WebCore::IDBDatabaseMetadata::encode):
(WebCore::IDBDatabaseMetadata::decode):

• Modules/indexeddb/IDBIndexMetadata.h:

(WebCore::IDBIndexMetadata::encode):
(WebCore::IDBIndexMetadata::decode):

• Modules/indexeddb/IDBKeyData.h:

(WebCore::IDBKeyData::encode):
(WebCore::IDBKeyData::decode):

• Modules/indexeddb/IDBKeyPath.h:

(WebCore::IDBKeyPath::encode):
(WebCore::IDBKeyPath::decode):

• Modules/indexeddb/IDBKeyRangeData.h:

(WebCore::IDBKeyRangeData::encode):
(WebCore::IDBKeyRangeData::decode):

• Modules/indexeddb/IDBObjectStoreMetadata.h:

(WebCore::IDBObjectStoreMetadata::encode):
(WebCore::IDBObjectStoreMetadata::decode):

Source/WebKit2:

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<IDBDatabaseMetadata>::encode): Deleted.
(IPC::ArgumentCoder<IDBDatabaseMetadata>::decode): Deleted.
(IPC::ArgumentCoder<IDBIndexMetadata>::encode): Deleted.
(IPC::ArgumentCoder<IDBIndexMetadata>::decode): Deleted.
(IPC::ArgumentCoder<IDBKeyData>::encode): Deleted.
(IPC::ArgumentCoder<IDBKeyData>::decode): Deleted.
(IPC::ArgumentCoder<IDBKeyPath>::encode): Deleted.
(IPC::ArgumentCoder<IDBKeyPath>::decode): Deleted.
(IPC::ArgumentCoder<IDBKeyRangeData>::encode): Deleted.
(IPC::ArgumentCoder<IDBKeyRangeData>::decode): Deleted.
(IPC::ArgumentCoder<IDBObjectStoreMetadata>::encode): Deleted.
(IPC::ArgumentCoder<IDBObjectStoreMetadata>::decode): Deleted.

• Shared/WebCoreArgumentCoders.h:

8:51 AM Changeset in webkit [189809] by beidson@apple.com

• 11 edits in trunk/Source

Make the enum IDBKey::Type into a utility enum class.
​https://bugs.webkit.org/show_bug.cgi?id=149149

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Cleanup, no behavior change).

• Modules/indexeddb/IDBKey.cpp:

(WebCore::IDBKey::isValid):
(WebCore::IDBKey::compare):

• Modules/indexeddb/IDBKey.h:

(WebCore::IDBKey::createNumber):
(WebCore::IDBKey::createDate):
(WebCore::IDBKey::createMultiEntryArray):
(WebCore::IDBKey::createArray):
(WebCore::IDBKey::type):
(WebCore::IDBKey::array):
(WebCore::IDBKey::string):
(WebCore::IDBKey::date):
(WebCore::IDBKey::number):
(WebCore::IDBKey::compareTypes):
(WebCore::IDBKey::IDBKey):

• Modules/indexeddb/IDBKeyData.cpp:

(WebCore::IDBKeyData::IDBKeyData):
(WebCore::IDBKeyData::maybeCreateIDBKey):
(WebCore::IDBKeyData::isolatedCopy):
(WebCore::IDBKeyData::encode):
(WebCore::IDBKeyData::decode):
(WebCore::IDBKeyData::compare):
(WebCore::IDBKeyData::loggingString):
(WebCore::IDBKeyData::setArrayValue):
(WebCore::IDBKeyData::setStringValue):
(WebCore::IDBKeyData::setDateValue):
(WebCore::IDBKeyData::setNumberValue):

• Modules/indexeddb/IDBKeyData.h:

(WebCore::IDBKeyData::IDBKeyData):
(WebCore::IDBKeyData::minimum):
(WebCore::IDBKeyData::maximum):

• Modules/indexeddb/IndexedDB.h:
• bindings/js/IDBBindingUtilities.cpp:

(WebCore::idbKeyToJSValue):
(WebCore::createIDBKeyFromValue):
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::generateIndexKeysForValue):

• inspector/InspectorIndexedDBAgent.cpp:

Source/WebKit2:

• DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::putRecordInBackingStore):

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<IDBKeyData>::encode):
(IPC::ArgumentCoder<IDBKeyData>::decode):

8:33 AM Changeset in webkit [189808] by achristensen@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed gardening.

• platform/win/TestExpectations:

Fix Windows tests after r189769.

8:11 AM WebKitGTK/2.10.x edited by Michael Catanzaro

Propose bug #149064 (diff)

8:01 AM Changeset in webkit [189807] by Csaba Osztrogonác

• 2 edits in trunk

[cmake] Enable debug fission only if it is supported
​https://bugs.webkit.org/show_bug.cgi?id=149161

Reviewed by Martin Robinson.

• Source/cmake/OptionsCommon.cmake:

7:48 AM Changeset in webkit [189806] by jfernandez@igalia.com

• 3 edits in trunk/Source/WebCore

[CSS Grid Layout] Using {row, column}-axis terms in alignment related logic
​https://bugs.webkit.org/show_bug.cgi?id=148942

Reviewed by Sergio Villar Senin.

This patch changes the names of several functions and variables
defined to implement the alignment logic. We want to use from now
on the terms row-axis and column-axis when referring to the
alignment direction the logic is applied to.

No new tests, no new functionality.

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::columnAxisOffsetForChild):
(WebCore::RenderGrid::rowAxisOffsetForChild):
(WebCore::RenderGrid::findChildLogicalPosition):

• rendering/RenderGrid.h:

4:06 AM Changeset in webkit [189805] by Sukolsak Sakshuwong

• 1 edit in trunk/Source/JavaScriptCore/jit/JITOperations.cpp

Build fix after r189774

• jit/JITOperations.cpp

1:57 AM Changeset in webkit [189804] by Carlos Garcia Campos

• 7 edits in releases/WebKitGTK/webkit-2.10

Merge r189680 - Document.title does not behave according to specification
​https://bugs.webkit.org/show_bug.cgi?id=149098

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing.

• web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-01-expected.txt:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-02-expected.txt:

Source/WebCore:

Update Document.title to behave according to the latest DOM specification:
​https://html.spec.whatwg.org/multipage/dom.html#document.title

In particular, the following Web-Exposed changes were made:

1. The title Element should be the first title element in the document (in tree order) [1]. Previously, WebKit would use the first title Element *added* to the Document. Document.title returns the text content of the title Element so this change is web-exposed.
2. If the title Element is replaced after the title has been set by the JS (via the document.title setter), we should update the value returned by the document.title getter. Previously, WebKit would set a flag if the title was explicitly set by JS via document.title setter and later title element changes would not override the title set by the JS. This behavior isn't specified and does not match the behavior of other browsers.

The new behavior is also consistent with the behavior of Firefox and
Chrome.

Some refactoring was made for the sake of clarity now that our
implementation has changed. See details below.

[1] ​https://html.spec.whatwg.org/multipage/dom.html#the-title-element-2

No new tests, already covered by existing tests.

• dom/Document.cpp:

(WebCore::Document::updateTitleFromTitleElement):
New convenience method that calls updateTitle() with the text of the
document's current title Element. If there is no title Element, it
clears the title.

(WebCore::Document::updateTitleElement):
Method which updates the Document's title Element whenever a title
Element is added or removed from the Document. Once the title Element
is updated, it takes care of calling updateTitleFromTitleElement() to
update the Document's title.

(WebCore::Document::titleElementAdded):
(WebCore::Document::titleElementRemoved):
(WebCore::Document::titleElementTextChanged):
New Document public API called by HTMLTitleElement / SVGTitleElement
whenever a title Element is added / removed from the Document or
whenever the title element's text has changed. These methods will
take care of calling updateTitleElement() / updateTitleFromTitleElement()
as necessary.
Previously, we would only have 2 methods:

• setTitleElement() which would be called whenever a title Element was added to the document or when its text had changed. The name was confusing because it would not necessarily set the document's title Element and it would be used both for title element update and a simple title update. This method has been split into 2: titleElementAdded() and titleElementTextChanged().
• removeTitle() which would be called whenever a title Element was removed. The naming was confusing because it would not necessarily remove the Document's title Element. This is now called titleElementRemoved().

• html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::insertedInto):
Call the new titleElementAdded() instead of setTitleElement().

(WebCore::HTMLTitleElement::removedFrom):
Call the new titleElementRemoved() instead of removeTitle().

(WebCore::HTMLTitleElement::childrenChanged):
Call the new titleElementTextChanged() instead of
setTitleElement() / removeTitle() as we don't really want
to remove or add a title Element. We merely want to notify
the document that the title element text has changed in
case it is the current title Element of the Document.

(WebCore::HTMLTitleElement::computedTextWithDirection):
Rename textWithDirection() to computedTextWithDirection() to
make it clear it is not a simple getter and make it private
as it is only used to set the m_title member which caches the
computed text.

• html/HTMLTitleElement.h:

Add new textWithDirection() getter which returns m_title. This
is needed so that Document can query the title of the Element.
Previously, HTMLTitleElement would pass directly m_title to
the Document when calling Document::setTitleElement().

• svg/SVGTitleElement.cpp:

(WebCore::SVGTitleElement::insertedInto):
Call the new titleElementAdded() instead of setTitleElement().

(WebCore::SVGTitleElement::removedFrom):
Call the new titleElementRemoved() instead of removeTitle().

(WebCore::SVGTitleElement::childrenChanged):
Call the new titleElementTextChanged() instead of
setTitleElement().

1:52 AM WebKitGTK/2.10.x edited by Carlos Garcia Campos

(diff)

1:39 AM Changeset in webkit [189803] by Carlos Garcia Campos

• 6 edits in releases/WebKitGTK/webkit-2.10

Merge r189679 - document.lastModified should use the user's local time zone
​https://bugs.webkit.org/show_bug.cgi?id=149092
LayoutTests/imported/w3c:

<rdar://problem/22567705>

Reviewed by Ryosuke Niwa.

Rebaseline a couple of W3C tests now that more checks are passing.

• web-platform-tests/html/dom/documents/resource-metadata-management/document-lastModified-01-expected.txt:
• web-platform-tests/html/dom/documents/resource-metadata-management/document-lastModified-expected.txt:

Source/WebCore:

<rdar://problem/22567705>

Reviewed by Ryosuke Niwa.

document.lastModified should use the user's local time zone:
​https://html.spec.whatwg.org/multipage/dom.html#dom-document-lastmodified

Chrome and Firefox comply with the specification but WebKit was using
UTC. This patch aligns WebKit's behavior with the specification and
other browsers.

No new tests, already covered by existing tests.

• dom/Document.cpp:

(WebCore::Document::lastModified):
(WebCore::Document::setCookieURL): Deleted.

LayoutTests:

Reviewed by Ryosuke Niwa.

Update test so that it converts document.lastModified to UTF before
printing it. This is so that we can consistent layout tests results, no
matter the system's timezone.

• http/tests/misc/last-modified-parsing-expected.txt:
• http/tests/resources/last-modified.php:

1:37 AM Changeset in webkit [189802] by Carlos Garcia Campos

• 14 edits
  2 deletes in releases/WebKitGTK/webkit-2.10

Merge r189677 - Node.baseURI should not return null for detached nodes
​https://bugs.webkit.org/show_bug.cgi?id=149104
<rdar://problem/22559535>

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

• web-platform-tests/dom/nodes/Node-baseURI-expected.txt:

Source/WebCore:

Node.baseURI should not return null for detached nodes. It should return
the node document's base URL. The node document is set when the node is
created so it is valid even if the node is detached [1]:
​https://dom.spec.whatwg.org/#dom-node-baseuri

WebKit was traversing the ancestors to find the base URL, which only
works if the node is attached. Also, WebKit was taking into account
the xml:base attribute when computing the baseURI.

Both Chrome and Firefox already dropped support for xml:base:
​https://code.google.com/p/chromium/issues/detail?id=341854
​https://bugzilla.mozilla.org/show_bug.cgi?id=903372

Firefox complies with the specification. Chrome's baseURI still only
works for attached Nodes as their implementation still traverses the
DOM tree, despite dropping support for xml:base.

This patch drops support xml:base when computing Node.baseURI, as
Firefox, Chrome and the latest DOM specification do. It also makes
Node.baseURI work for detached Nodes by returning the base URL of the
node Document. This means we no longer have to traverse the Node's
ancestors in the DOM tree. This is consistent with the behavior of
Firefox and the latest DOM specification.

This patch does not drop the SVGElement.xmlbase attribute yet. However,
we should probably consider making this change as well given that:

• The SVG2 specification dropped it
• Chrome dropped it.
• It no longers impacts Node.baseURI

[1] ​https://www.w3.org/Bugs/Public/show_bug.cgi?id=20976

No new tests, already covered by existing test.

• dom/Document.cpp:

(WebCore::Document::setContent): Deleted.

• dom/Document.h:

(WebCore::Document::inputCursor): Deleted.

• dom/DocumentType.cpp:

(WebCore::DocumentType::nodeName): Deleted.

• dom/DocumentType.h:
• dom/Element.cpp:

(WebCore::Element::imageSourceURL): Deleted.
(WebCore::Element::rendererIsNeeded): Deleted.
(WebCore::Element::createElementRenderer): Deleted.
(WebCore::Element::insertedInto): Deleted.

• dom/Element.h:
• dom/Node.cpp:

(WebCore::Node::baseURI):

• dom/Node.h:
• svg/SVGElement.idl:

LayoutTests:

• dom/xhtml/level3/core/nodegetbaseuri03-expected.txt:

Rebaseline outdated DOM3 test.

• svg/custom/image-base-uri-expected.txt: Removed.
• svg/custom/image-base-uri.svg: Removed.

Drop outdated SVG test. SVG2 no longer support xml:base.

1:15 AM Changeset in webkit [189801] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po

Merge r189673 - Webkit Gujarati Translations
​https://bugs.webkit.org/show_bug.cgi?id=139530

Unreviewed.

Patch by Ankit Patel <​ankit@redhat.com> on 2015-09-13

• gu.po:

1:14 AM Changeset in webkit [189800] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po

Merge r189667 - Updated Spanish translation
​https://bugs.webkit.org/show_bug.cgi?id=145550

Unreviewed.

Patch by Francisco Serrador <​fserrador@gmail.com> on 2015-09-12

• es.po:

1:13 AM Changeset in webkit [189799] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po

Merge r189666 - Updated Slovenian translation
​https://bugs.webkit.org/show_bug.cgi?id=123080

Unreviewed.

Patch by Matej Urbančič <​mateju@svn.gnome.org> on 2015-09-12

• sl.po:

1:13 AM Changeset in webkit [189798] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po

Merge r189665 - Webkit Tamil translations updated
​https://bugs.webkit.org/show_bug.cgi?id=139478

Unreviewed.

Patch by Shantha kumar <​shkumar@redhat.com> on 2015-09-12

• ta.po:

1:12 AM Changeset in webkit [189797] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po

Merge r189664 - [l10n] Updated Bulgarian translation
​https://bugs.webkit.org/show_bug.cgi?id=142611

Unreviewed.

Patch by Zahari Yurukov <​zahari.yurukov@gmail.com> on 2015-09-12

• bg.po:

1:11 AM Changeset in webkit [189796] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po

Merge r189663 - [l10n] Updated Polish translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=148475

Unreviewed.

Patch by Piotr Drąg <​piotrdrag@gmail.com> on 2015-09-12

• pl.po:

1:10 AM Changeset in webkit [189795] by Carlos Garcia Campos

• 1 edit in releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po/ChangeLog

Merge r189662 - [GTK] [l10n] Updated Turkish translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=148362

Unreviewed.

Patch by Muhammet Kara <​muhammetk@gmail.com> on 2015-09-12

• tr.po: Added.

1:10 AM Changeset in webkit [189794] by Carlos Garcia Campos

• 1 edit
  1 add in releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/gtk/po

Merge r189661 - [GTK] [l10n] Updated Turkish translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=148362

Unreviewed.

• tr.po: Added.

1:07 AM Changeset in webkit [189793] by Carlos Garcia Campos

• 8 edits
  4 adds in releases/WebKitGTK/webkit-2.10

Merge r189594 - [New Block-Inside-Inline Model] Self-collapsing block check needs to account for anonymous inline blocks
​https://bugs.webkit.org/show_bug.cgi?id=149042

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/block/inside-inlines/

• rendering/InlineFlowBox.cpp:
• rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::anonymousInlineBlock):
Add a new accessor to get the anonymousInlineBlock() for lines that wrap them.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::childrenPreventSelfCollapsing):
(WebCore::RenderBlock::isSelfCollapsingBlock):
isSelfCollapsingBlock() now calls a virtual method that checks lines/children called childrenPreventSelfCollapsing.
This lets us farm out the lines check to the derived RenderBlockFlow class.

• rendering/RenderBlock.h:

(WebCore::RenderBlock::childrenPreventSelfCollapsing):
Added new virtual method for checking children.

• rendering/RenderBlockFlow.cpp:
• rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::childrenPreventSelfCollapsing):
Overridden to ensure that blocks can still be self-collapsing if they only contain anonymous inline-block lines that
are also self-collapsing.

LayoutTests:

• fast/block/inside-inlines/new-model/self-collapsing-test-expected.html: Added.
• fast/block/inside-inlines/new-model/self-collapsing-test.html: Added.
• fast/block/inside-inlines/self-collapsing-test-expected.html: Added.
• fast/block/inside-inlines/self-collapsing-test.html: Added.

12:59 AM Changeset in webkit [189792] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2

Merge r189587 - sendProcessWillSuspendImminently uses a wrong message flag
​https://bugs.webkit.org/show_bug.cgi?id=148995

Reviewed by Alexey Proskuryakov.

Remove use of flag IPC::InterruptWaitingIfSyncMessageArrives as it does not make
sense when sending a sync message.

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::sendProcessWillSuspendImminently):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::sendProcessWillSuspendImminently):

12:56 AM Changeset in webkit [189791] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r189581 - [WebGL][GLES] bad shaders should not be linked not only for GL but also for GL ES
​https://bugs.webkit.org/show_bug.cgi?id=148794

Patch by Jinyoung Hur <​hur.ims@navercorp.com> on 2015-09-10
Reviewed by Dean Jackson.

Checking bad shaders, precision matching and varyings packing are all valid for GL ES too.

Test: webgl/1.0.2/conformance/programs/program-test.html

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::linkProgram):

12:54 AM Changeset in webkit [189790] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r189580 - Static variables in GraphicsContext3DOpenGLCommon should be avoided because of the race condition
​https://bugs.webkit.org/show_bug.cgi?id=148957

Patch by Jinyoung Hur <​hur.ims@navercorp.com> on 2015-09-10
Reviewed by Dean Jackson.

There is no guarantee that only one thread calls GraphicsContext3D::compileShader() at a time so it would be
better to use a thread local storage variable rather than use a static variable.

No new tests. No behavioural changes.

• platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::getCurrentNameHashMapForShader):
(WebCore::setCurrentNameHashMapForShader):
(WebCore::nameHashForShader):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::mappedSymbolName):

12:52 AM Changeset in webkit [189789] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.10

Merge r189566 - [GTK] Volume bar is broken
​https://bugs.webkit.org/show_bug.cgi?id=145639

Reviewed by Philippe Normand.

Source/WebCore:

The ControlPart enum values' order has mismatched the one of values in CSSValueKeywords.in
after r180965. The MediaVolumeSliderPart should be prior to the MediaVolumeSliderContainerpart.

Tests: media/click-volume-bar-not-pausing.html

media/volume-bar-empty-when-muted.html

• platform/ThemeTypes.h:

LayoutTests:

Unblock relevant tests. media/click-volume-bar-not-pausing.html, media/volume-bar-empty-when-muted.html

• platform/gtk/TestExpectations:

12:41 AM Changeset in webkit [189788] by Carlos Garcia Campos

• 3 edits
  6 adds in releases/WebKitGTK/webkit-2.10

Merge r189560 - CSS general sibling selectors does not work without CSS JIT
​https://bugs.webkit.org/show_bug.cgi?id=148987
rdar://problem/22559860

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-09-09
Reviewed by Andreas Kling.

Source/WebCore:

When traversing with the indirect adjacent combinator, SelectorChecker
was not setting the style invalidation flag on the right element.

Tests: fast/css/indirect-adjacent-style-invalidation-1.html

fast/css/indirect-adjacent-style-invalidation-2.html
fast/css/indirect-adjacent-style-invalidation-3.html

• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively):

LayoutTests:

There are multiple variations of the same tests to test
cases where we JIT and cases without JIT.

• fast/css/indirect-adjacent-style-invalidation-1-expected.txt: Added.
• fast/css/indirect-adjacent-style-invalidation-1.html: Added.
• fast/css/indirect-adjacent-style-invalidation-2-expected.txt: Added.
• fast/css/indirect-adjacent-style-invalidation-2.html: Added.
• fast/css/indirect-adjacent-style-invalidation-3-expected.txt: Added.
• fast/css/indirect-adjacent-style-invalidation-3.html: Added.

12:38 AM Changeset in webkit [189787] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.10

Merge r189555 - Setting document.title when there is no title and no head element should no nothing
​https://bugs.webkit.org/show_bug.cgi?id=149005
<rdar://problem/22567524>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline tests now that more checks are passing.

• web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-01-expected.txt:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-02-expected.txt:

Source/WebCore:

Setting document.title when there is no title element and no head
element should no nothing:

• ​https://html.spec.whatwg.org/multipage/dom.html#document.title

Firefox and Chrome comply with the specification. However, WebKit
was returning the updated title when querying document.title after
setting it.

No new tests, covered by existing tests.

• dom/Document.cpp:

(WebCore::Document::setTitle):

12:33 AM Changeset in webkit [189786] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.10

Merge r189546 - fast/dom/rtl-scroll-to-leftmost-and-resize.html is a flaky timeout - IPC drops messages
​https://bugs.webkit.org/show_bug.cgi?id=148951

Reviewed by Anders Carlsson.

Source/WebKit2:

• Platform/IPC/Connection.cpp:

(IPC::Connection::waitForMessage): Don't modify m_waitingForMessage without holding
a lock. This is not part of this fix, but seems necessary for correctness.
(IPC::Connection::processIncomingMessage): Don't interrupt a wait that has already succeeded.

LayoutTests:

• platform/mac-wk2/TestExpectations: Unmark the test (it still fails per platform/mac

expectations, which is unrelated).

12:28 AM Changeset in webkit [189785] by Carlos Garcia Campos

• 5 edits
  2 adds in releases/WebKitGTK/webkit-2.10

Merge r189540 - REGRESSION: Inline-block baseline is wrong when zero-width replaced child is present
​https://bugs.webkit.org/show_bug.cgi?id=147452
rdar://problem/21943074

Reviewed by Myles Maxfield.

Source/WebCore:

Added new test in fast/inline-block

Treat zero width replaced elements the same as replaced elements with width. Instead of
clearing floats based off having no committed width, we instead track both committed
width and committed replaced objects. We do this with two new booleans in LineWidth
so that we know when we have uncomitted and committed replaced objects.

• rendering/line/BreakingContext.h:

(WebCore::BreakingContext::handleReplaced):
(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::canBreakAtThisPosition):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):

• rendering/line/LineWidth.cpp:

(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::commit):
(WebCore::LineWidth::applyOverhang):

• rendering/line/LineWidth.h:

(WebCore::LineWidth::committedWidth):
(WebCore::LineWidth::availableWidth):
(WebCore::LineWidth::logicalLeftOffset):
(WebCore::LineWidth::hasCommitted):
(WebCore::LineWidth::addUncommittedWidth):
(WebCore::LineWidth::addUncommittedReplacedWidth):

LayoutTests:

• fast/inline-block/baseline-with-zero-width-replaced-child-expected.html: Added.
• fast/inline-block/baseline-with-zero-width-replaced-child.html: Added.

12:25 AM Changeset in webkit [189784] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore

Merge r189531 - [JSC] reduce the amount of memory access needed for LivenessAnalysisPhase
​https://bugs.webkit.org/show_bug.cgi?id=148414

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-09-08
Reviewed by Mark Lam.

LivenessAnalysisPhase still causes a huge number of cache miss.
This patch reduces the amount of accesses needed by the HashTables.

• dfg/DFGBasicBlock.h:
• dfg/DFGLivenessAnalysisPhase.cpp:

(JSC::DFG::LivenessAnalysisPhase::run):
(JSC::DFG::LivenessAnalysisPhase::process):

12:20 AM Changeset in webkit [189783] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r189526 - Crash when WebCore::SQLiteFileSystem::openDatabase is called from multiple threads
​https://bugs.webkit.org/show_bug.cgi?id=143245

Reviewed by Darin Adler.

sqlite3_initialize is documented to be thread-safe, and to be called automatically by the
library when needed, so applications should never need to call it directly. The problem is,
it's not thread-safe: we have documented instances of GNOME Builder, Devhelp, Epiphany, and
cinnamon-screensaver crashing when sqlite3_initialize is called simultaneously in separate
threads (usually inside sqlite3_open). So call it manually, guarded using std::call_once, to
make sure that the library is fully initialized before the first call to sqlite3_open. It's
a good idea to do this regardless, because the documentation says it could be required in
a future release of SQLite. (Though the use of std::call_once should not be needed, and is
only used to attempt to work around the crashes.)

This is a workaround for an SQLite bug that might have been fixed upstream, but the SQLite
developers are not really confident in the thread-safety of this function, and have advised
that we carry the workaround. Seems like a good idea.

• platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::SQLiteDatabase):

12:17 AM Changeset in webkit [189782] by Carlos Garcia Campos

• 5 edits in releases/WebKitGTK/webkit-2.10

Merge r189502 - document.importNode(node, deep): deep's default value should be false
​https://bugs.webkit.org/show_bug.cgi?id=148959
<rdar://problem/22558915>

Reviewed by Alexey Proskuryakov.

LayoutTests/imported/w3c:

• web-platform-tests/dom/nodes/Document-importNode-expected.txt:

Rebaseline now that an additional check is passing.

Source/WebCore:

Switch deep parameter's default value for document.importNode() to
false, as per the latest DOM specification:

• ​https://dom.spec.whatwg.org/#interface-document
• ​https://dom.spec.whatwg.org/#dom-document-importnode

Firefox and Chrome follow the specification. However, WebKit was using
"true" for deep's default value.

No new tests, already covered by:
imported/w3c/web-platform-tests/dom/nodes/Document-importNode.html

• dom/Document.h:

(WebCore::Document::importNode):

LayoutTests:

• fast/dom/document-importNode-arguments.html:

Explicitly pass deep parameter as the test wants a deep clone.