Timeline

Sep 23, 2015:

11:04 PM Changeset in webkit [190197] by bshafiei@apple.com

• 25 edits
  2 deletes in tags/Safari-602.1.4

Merged r190190. rdar://problem/22825602

11:01 PM Changeset in webkit [190196] by bshafiei@apple.com

• 1 copy in tags/Safari-602.1.4

New tag.

9:23 PM Changeset in webkit [190195] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Simplify / Optimize Range::selectNode()
​https://bugs.webkit.org/show_bug.cgi?id=149515

Reviewed by Ryosuke Niwa.

Simplify / Optimize Range::selectNode():

1. Do a null-check on refNode->parentNode() instead of checking the nodeType(), which is virtual. Attr, DocumentFragment and Document Nodes do not have a parent and thus are covered by this check. Also, setStartBefore() / setEndAfter() were already doing a null check on the parent.
2. Call lower-level setStart() / setEnd() directly, instead of using setStartBefore() / setEndAfter() as intermediary. As a result: 2.a. We avoid doing a redundant null checks on refNode and its parent

(inside those intermediate functions)

2.b. We only call refNode->computeNodeIndex() once instead of twice

(in each of those intermediate functions). computeNodeIndex()
is not a trivial getter as its needs to traverse all the
previous siblings.

The implementation now matches exactly the text of the DOM specification
as well:
​https://dom.spec.whatwg.org/#concept-range-select

No new layout tests, no web-exposed behavior intended.

• dom/Range.cpp:

(WebCore::Range::selectNode):

6:52 PM Changeset in webkit [190194] by Chris Dumez

• 2 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline web-platform-tests/html/dom/interfaces.html after r190190

• web-platform-tests/html/dom/interfaces-expected.txt:

6:27 PM Changeset in webkit [190193] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Link highlight rect is too rounded on blocks with border-radius
​https://bugs.webkit.org/show_bug.cgi?id=149511

Reviewed by Dan Bernstein.

• UIProcess/ios/WKContentViewInteraction.mm:

(nsSizeForTapHighlightBorderRadius):
(-[WKContentView _updateTapHighlight]):
Scale the border radius from content to view coordinates, just like
we do for the rects that WebKit returns us.

5:40 PM Changeset in webkit [190192] by mmaxfield@apple.com

• 40 edits
  4 adds in trunk

[Cocoa] [Font Features] Implement font-variant-*
​https://bugs.webkit.org/show_bug.cgi?id=148413

Reviewed by Darin Adler.

Source/WebCore:

This patch is the first pass of implementing of the font-variant-* properties. Specifically,
these properties are:
font-variant-ligatures
font-variant-position
font-variant-caps
font-variant-numeric
font-variant-alternates
font-variant-east-asian

These new properties are held inside FontDescription as bit fields. At font creation time,
we consult with the FontDescription to figure out which variants are specified. We then
convert those variants to font features, and resolve these font features with the additional
features specified by font-feature-settings (as the spec requires). This patch also makes
our caches sensitive to these new properties of FontDescription so we don't look up cached,
stale fonts.

The implementation has some caveats, however. They are listed here:

1. These new properties need to interact correctly with @font-face declarations. In

particular, only certain properties of the FontDescription should be considered when
detecting if a @font-face declaration applies to a particular element. This discrimination
does not happen correctly. In addition, any feature-specific CSS properties inside the
@font-face declaration need to be consulted at a particular point during the feature
resolve. This does not currently occur.

2. One of the properties, font-variant-alternates, has a few values which require custom

CSS functions, which makes modeling the properties as bit fields tricky. These extra values
need to be implemented. This patch implements all the values which do not require extra CSS
features.

3. These new properties have a shorthand, font-variant, which is designed to be backward-

compatible with CSS 2.1's concept of font-variant. In particular, CSS 2.1 allows you to use
"normal" and "small-caps" with font-variant. Both of these values are values of the new
property font-variant-caps. However, our existing implementation of small-caps does not
use font features when they exist; instead, it simply draws text at a smaller font size and
uses (effectively) text-transform to force capital letters. This implementation needs to be
unified with the new font-variant-caps property so that we can expand font-variant to be
a shorthand for the new properties.

4. font-variant-position and font-variant-caps should provide appropriate synthesis if no

matching font-feature exists.

5. FontCascade::typesettingFeatures() is now no-longer accurate. Fixing this would be large

enough to warrant its own patch.

6. These properties are not tested with TrueType fonts.

Tests: css3/font-variant-all-webfont.html

css3/font-variant-parsing.html

• css/CSSComputedStyleDeclaration.cpp: Reconstruct StyleProperties from a RenderStyle.

(WebCore::appendLigaturesValue):
(WebCore::fontVariantLigaturesPropertyValue):
(WebCore::fontVariantPositionPropertyValue):
(WebCore::fontVariantCapsPropertyValue):
(WebCore::fontVariantNumericPropertyValue):
(WebCore::fontVariantAlternatesPropertyValue):
(WebCore::fontVariantEastAsianPropertyValue):
(WebCore::ComputedStyleExtractor::propertyValue):

• css/CSSFontFeatureValue.cpp: Update to FontFeatureTag instead of WTF::String.

(WebCore::CSSFontFeatureValue::CSSFontFeatureValue):
(WebCore::CSSFontFeatureValue::customCSSText):

• css/CSSFontFeatureValue.h: Ditto.

(WebCore::CSSFontFeatureValue::create):
(WebCore::CSSFontFeatureValue::tag):

• css/CSSParser.cpp: Parse the new properties according to the CSS3 fonts spec.

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFontFeatureTag):
(WebCore::CSSParser::parseFontVariantLigatures):
(WebCore::CSSParser::parseFontVariantNumeric):
(WebCore::CSSParser::parseFontVariantEastAsian):

• css/CSSParser.h:
• css/CSSPrimitiveValueMappings.h: For the three properties which are simple keyword value

properties, implement casting operators to automatically convert between RenderStyle
objects and CSS property objects.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator FontVariantPosition):
(WebCore::CSSPrimitiveValue::operator FontVariantCaps):
(WebCore::CSSPrimitiveValue::operator FontVariantAlternates):

• css/CSSPropertyNames.in: New properties.
• css/CSSValueKeywords.in: New values.
• css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertFontFeatureSettings): Update to not use
RefPtrs.

• css/StyleBuilderCustom.h: Properties which are not simple keyword value properties are

decomposed into multiple members of FontDescription. These properties exist to convert
between these aggregate members and the CSS properties.
(WebCore::StyleBuilderCustom::applyInheritFontVariantLigatures):
(WebCore::StyleBuilderCustom::applyInitialFontVariantLigatures):
(WebCore::StyleBuilderCustom::applyValueFontVariantLigatures):
(WebCore::StyleBuilderCustom::applyInheritFontVariantNumeric):
(WebCore::StyleBuilderCustom::applyInitialFontVariantNumeric):
(WebCore::StyleBuilderCustom::applyValueFontVariantNumeric):
(WebCore::StyleBuilderCustom::applyInheritFontVariantEastAsian):
(WebCore::StyleBuilderCustom::applyInitialFontVariantEastAsian):
(WebCore::StyleBuilderCustom::applyValueFontVariantEastAsian):
(WebCore::StyleBuilderCustom::applyInitialWebkitFontVariantLigatures): Deleted.
(WebCore::StyleBuilderCustom::applyInheritWebkitFontVariantLigatures): Deleted.
(WebCore::StyleBuilderCustom::applyValueWebkitFontVariantLigatures): Deleted.

• editing/cocoa/HTMLConverter.mm:

(HTMLConverter::computedAttributesForElement): Unprefix font-variant-ligatures.

• platform/graphics/FontCache.h: Update cache to be sensitive to new state in

FontDescription.
(WebCore::FontDescriptionKey::FontDescriptionKey):
(WebCore::FontDescriptionKey::operator==):
(WebCore::FontDescriptionKey::computeHash):
(WebCore::FontDescriptionKey::makeFlagsKey):
(WebCore::FontDescriptionKey::makeFlagKey): Deleted.

• platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::codePath): These new variants should trigger the complex text
codepath.

• platform/graphics/FontCascade.h:

(WebCore::FontCascade::computeTypesettingFeatures): Update to use new state enum.

• platform/graphics/FontDescription.cpp: Add state to hold new property values.

(WebCore::FontDescription::FontDescription):
(WebCore::FontCascadeDescription::FontCascadeDescription): Deleted.

• platform/graphics/FontDescription.h: Add state to hold new property values.

(WebCore::FontDescription::featureSettings):
(WebCore::FontDescription::variantCommonLigatures):
(WebCore::FontDescription::variantDiscretionaryLigatures):
(WebCore::FontDescription::variantHistoricalLigatures):
(WebCore::FontDescription::variantContextualAlternates):
(WebCore::FontDescription::variantPosition):
(WebCore::FontDescription::variantCaps):
(WebCore::FontDescription::variantNumericFigure):
(WebCore::FontDescription::variantNumericSpacing):
(WebCore::FontDescription::variantNumericFraction):
(WebCore::FontDescription::variantNumericOrdinal):
(WebCore::FontDescription::variantNumericSlashedZero):
(WebCore::FontDescription::variantAlternates):
(WebCore::FontDescription::variantEastAsianVariant):
(WebCore::FontDescription::variantEastAsianWidth):
(WebCore::FontDescription::variantEastAsianRuby):
(WebCore::FontDescription::variantSettings):
(WebCore::FontDescription::setFeatureSettings):
(WebCore::FontDescription::setVariantCommonLigatures):
(WebCore::FontDescription::setVariantDiscretionaryLigatures):
(WebCore::FontDescription::setVariantHistoricalLigatures):
(WebCore::FontDescription::setVariantContextualAlternates):
(WebCore::FontDescription::setVariantPosition):
(WebCore::FontDescription::setVariantCaps):
(WebCore::FontDescription::setVariantNumericFigure):
(WebCore::FontDescription::setVariantNumericSpacing):
(WebCore::FontDescription::setVariantNumericFraction):
(WebCore::FontDescription::setVariantNumericOrdinal):
(WebCore::FontDescription::setVariantNumericSlashedZero):
(WebCore::FontDescription::setVariantAlternates):
(WebCore::FontDescription::setVariantEastAsianVariant):
(WebCore::FontDescription::setVariantEastAsianWidth):
(WebCore::FontDescription::setVariantEastAsianRuby):
(WebCore::FontDescription::operator==):
(WebCore::FontCascadeDescription::initialVariantPosition):
(WebCore::FontCascadeDescription::initialVariantCaps):
(WebCore::FontCascadeDescription::initialVariantAlternates):
(WebCore::FontCascadeDescription::commonLigaturesState): Deleted.
(WebCore::FontCascadeDescription::discretionaryLigaturesState): Deleted.
(WebCore::FontCascadeDescription::historicalLigaturesState): Deleted.
(WebCore::FontCascadeDescription::setCommonLigaturesState): Deleted.
(WebCore::FontCascadeDescription::setDiscretionaryLigaturesState): Deleted.
(WebCore::FontCascadeDescription::setHistoricalLigaturesState): Deleted.
(WebCore::FontCascadeDescription::operator==): Deleted.

• platform/graphics/FontFeatureSettings.cpp: Update to use FontFeatureTag instead of

WTF::String.
(WebCore::FontFeature::FontFeature):
(WebCore::FontFeature::operator==):
(WebCore::FontFeature::operator<):
(WebCore::FontFeatureSettings::hash):
(WebCore::FontFeatureSettings::create): Deleted.

• platform/graphics/FontFeatureSettings.h: Update to use FontFeatureTag instead of

WTF::String.
(WebCore::fontFeatureTag):
(WebCore::FontFeatureTagHash::hash):
(WebCore::FontFeatureTagHash::equal):
(WebCore::FontFeatureTagHashTraits::constructDeletedValue):
(WebCore::FontFeatureTagHashTraits::isDeletedValue):
(WebCore::FontFeature::tag):
(WebCore::FontFeatureSettings::operator==):
(WebCore::FontFeatureSettings::begin):
(WebCore::FontFeatureSettings::end):
(WebCore::FontFeatureSettings::FontFeatureSettings): Deleted.

• platform/graphics/cocoa/FontCacheCoreText.cpp: Ditto. Also, when computing font

features, consult with the state inside FontDescription.
(WebCore::tagEquals):
(WebCore::appendTrueTypeFeature):
(WebCore::appendOpenTypeFeature):
(WebCore::computeFeatureSettingsFromVariants):
(WebCore::preparePlatformFont):
(WebCore::platformFontLookupWithFamily):
(WebCore::fontWithFamily):
(WebCore::FontCache::createFontPlatformData):
(WebCore::FontCache::systemFallbackForCharacters):

• platform/graphics/harfbuzz/HarfBuzzShaper.cpp: Update to use references instead of

pointers.
(WebCore::HarfBuzzShaper::setFontFeatures):

• platform/graphics/mac/FontCacheMac.mm:

(WebCore::platformFontWithFamily): Ditto.

• platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Be sensitive to new state inside FontDescription.

• platform/text/TextFlags.h:

(WebCore::FontVariantSettings::isAllNormal): New state enums.

• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::updateCachedSystemFontDescription): Be sensitive to new state inside
FontDescription.

• rendering/line/BreakingContext.h:

Tools:

Update test font to use "lnum" feature.

• FontWithFeatures/FontWithFeatures/FontCreator.cpp:

(Generator::appendGSUBTable):

LayoutTests:

Updating tests because font-variant-ligatures is being unprefixed.

Also, update css3/resources/FontWithFeatures.otf to support "lnum" feature.

• css3/font-feature-settings-rendering-2-expected.html:
• css3/font-feature-settings-rendering-2.html:
• css3/font-variant-all-webfont-expected.html: Added.
• css3/font-variant-all-webfont.html: Added.
• css3/font-variant-parsing-expected.txt: Added.
• css3/font-variant-parsing.html: Added.
• css3/resources/FontWithFeatures.otf:
• fast/css/getComputedStyle/computed-style-expected.txt:
• fast/css/getComputedStyle/computed-style-font-family-expected.txt:
• fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
• fast/css/getComputedStyle/resources/property-names.js:
• fast/css/parsing-font-variant-ligatures.html:
• fast/text/font-variant-ligatures.html:
• platform/mac/TestExpectations:
• svg/css/getComputedStyle-basic-expected.txt:

5:19 PM Changeset in webkit [190191] by sbarati@apple.com

• 2 edits in trunk/Source/WebInspectorUI

Fix broken inspector tests.

Reviewed by Joseph Pecoraro and Brian Burg.

We can't redeclare a "let" variable and "var" variable using the same
identifier at the top-level of a function.

• UserInterface/Test/InspectorProtocol.js:

(InspectorProtocol.sendCommand):
(InspectorProtocol.addEventListener):
(InspectorProtocol.dispatchMessageFromBackend):

4:52 PM Changeset in webkit [190190] by Chris Dumez

• 25 edits
  2 deletes in trunk

Unreviewed, roll out r190085 as it seems to cause crashes in JSC
<rdar://problem/22825602>

LayoutTests/imported/w3c:

• web-platform-tests/dom/interfaces-expected.txt:
• web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributesHashTable):

• bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
• bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
• bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
• bindings/scripts/test/JS/JSTestEventConstructor.cpp:
• bindings/scripts/test/JS/JSTestEventTarget.cpp:
• bindings/scripts/test/JS/JSTestException.cpp:
• bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
• bindings/scripts/test/JS/JSTestInterface.cpp:
• bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
• bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
• bindings/scripts/test/JS/JSTestNode.cpp:
• bindings/scripts/test/JS/JSTestNondeterministic.cpp:
• bindings/scripts/test/JS/JSTestObj.cpp:
• bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
• bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
• bindings/scripts/test/JS/JSTestTypedefs.cpp:
• bindings/scripts/test/JS/JSattribute.cpp:
• bindings/scripts/test/JS/JSreadonly.cpp:

LayoutTests:

• fast/events/event-prototype-constructor-properties-expected.txt: Removed.
• fast/events/event-prototype-constructor-properties.html: Removed.

3:59 PM Changeset in webkit [190189] by Chris Dumez

• 15 edits
  2 adds in trunk

HTMLOutputElement.htmlFor should be settable
​https://bugs.webkit.org/show_bug.cgi?id=149418

Reviewed by Ryosuke Niwa.

Source/WebCore:

HTMLOutputElement.htmlFor should be settable as per the latest HTML
specification:

• ​https://html.spec.whatwg.org/multipage/forms.html#the-output-element

It is supposed to call DOMSettableTokenList.setValue() with the input
String. This patch adds support for this by adding [PutForwards=value]
IDL extended attribute.

This aligns our behavior with the specification, Firefox and Chrome.

No new tests, already covered by existing test.

• html/AttributeDOMTokenList.cpp:

(WebCore::AttributeDOMTokenList::AttributeDOMTokenList):
(WebCore::AttributeDOMTokenList::attributeValueChanged):

• html/AttributeDOMTokenList.h:
• Have AttributeDOMTokenList subclass DOMSettableTokenList instead of

DOMTokenList so that it can be used in places where the IDL expects
us to return a DOMSettableTokenList (e.g. HTMLOutputElement.htmlFor).

• Mark AttributeDOMTokenList as fast allocated.

• html/DOMSettableTokenList.cpp:

(WebCore::DOMSettableTokenList::setValue):

• html/DOMSettableTokenList.h:
• Move setValue() from DOMTokenList to DOMSettableTokenList as it is only needed by DOMSettableTokenList.
• Get rid of the factory function as all call sites are using AttributeDOMTokenList now.
• Stop inheriting RefCounted as AttributeDOMTokenList handles its own refcounting.

• html/DOMTokenList.cpp:

(WebCore::DOMTokenList::setValueInternal):

• html/DOMTokenList.h:

Rename setValue() to setValueInternal() as this version does not
update the associated attribute value, only the tokens.

• html/HTMLLinkElement.cpp:
• html/HTMLLinkElement.h:
• Have HTMLLinkElement.sizes use an AttributeDOMTokenList instead of a DOMSettableTokenList as there is an associated attribute. The previous code had a bug has setting HTMLLinkElement.sizes would not update the associated 'sizes' attribute. Switching to using AttributeDOMTokenList fixes this and a new layout test has been added to cover this.
• Create the AttributeDOMTokenList lazily to avoid updating it every time the sizes attribute changes until it is actually accessed.

• html/HTMLOutputElement.cpp:
• html/HTMLOutputElement.h:
• Have HTMLLinkElement.htmlFor use an AttributeDOMTokenList instead of a DOMSettableTokenList as there is an associated attribute.
• Create the AttributeDOMTokenList lazily to avoid updating it every time the sizes attribute changes until it is actually accessed.

• html/HTMLOutputElement.idl:

Add [PutForwards=value] on the htmlFor attribute, as per the
HTML specification.

LayoutTests:

• fast/dom/HTMLLinkElement/sizes-setter.html: Added
• fast/dom/HTMLLinkElement/sizes-setter-expected.txt: Added

Add layout test to make sure that setting HTMLLinkElement.sizes actually
updates the 'sizes' associated attribute.

• fast/dom/HTMLOutputElement/dom-settable-token-list-expected.txt:
• fast/dom/HTMLOutputElement/script-tests/dom-settable-token-list.js:

Update existing layout test now that HTMLOutputElement.htmlFor is
settable.

3:37 PM Changeset in webkit [190188] by sbarati@apple.com

• 6 edits in trunk

JSC allows invalid var declarations when the declared name is the same as a let/const variable
​https://bugs.webkit.org/show_bug.cgi?id=147600

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

We had an ordering bug where if you first declared a "let"
variable then a "var" variable with the same name, you wouldn't
get a syntax error. But, if you did it in the reverse order,
you would. This patch fixes this syntax error to be order independent.

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseVariableDeclarationList):
(JSC::Parser<LexerType>::createBindingPattern):
(JSC::Parser<LexerType>::parseFunctionDeclaration):

• parser/Parser.h:

(JSC::Scope::declareVariable):

LayoutTests:

• js/let-syntax-expected.txt:
• js/script-tests/let-syntax.js:

(hasSyntaxError):

2:40 PM Changeset in webkit [190187] by Chris Dumez

• 5 edits in trunk

TreeWalker.previousSibling() / nextSibling() does not behave according to the specification
​https://bugs.webkit.org/show_bug.cgi?id=149493

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline existing W3C DOM test now that more checks are passing.

• web-platform-tests/dom/traversal/TreeWalker-expected.txt:

Source/WebCore:

TreeWalker.previousSibling() / nextSibling() does not behave according
to the specification:

• ​https://dom.spec.whatwg.org/#dom-treewalker-nextsibling
• ​https://dom.spec.whatwg.org/#dom-treewalker-previoussibling
• ​https://dom.spec.whatwg.org/#concept-traverse-siblings

In particular, the previous code would fail to update 'node' variable
in the case acceptNode() returned FILTER_REJECT. This patch fixes this
and refactors the function to match more closely the text of the spec
and avoid code duplication.

No new tests, already covered by existing test.

• dom/TreeWalker.cpp:

(WebCore::TreeWalker::traverseSiblings):
(WebCore::TreeWalker::previousSibling):
(WebCore::TreeWalker::nextSibling):
(WebCore::TreeWalker::previousNode): Deleted.

• dom/TreeWalker.h:

2:03 PM Changeset in webkit [190186] by sbarati@apple.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Don't use bind() when creating internal AST, instead, pass in "this" parameter to map()
​https://bugs.webkit.org/show_bug.cgi?id=149483

Reviewed by Joseph Pecoraro.

• UserInterface/Models/ScriptSyntaxTree.js:

(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
(WebInspector.ScriptSyntaxTree):

1:59 PM Changeset in webkit [190185] by fpizlo@apple.com

• 7 edits in trunk/Source/JavaScriptCore

Parallel copy phase synchronization should be simplified
​https://bugs.webkit.org/show_bug.cgi?id=149509

Reviewed by Mark Lam.

Before this change, we didn't wait for the copy phase to finish before starting to do things to
copied space that presumed that copying was done. Copied space would "detect" that nobody was
copying anymore by waiting for all loaned blocks to be returned. But that would succeed if some
thread had not yet started copying. So, we had weird hacks to ensure that a block was loaned
before any threads started. It also meant that we had two separate mechanisms for waiting for
copying threads to finish - one mechanism in the Heap phase logic and another in the
CopiedSpace::doneCopying() method.

We can get rid of a lot of the weirdness by just having a sound shutdown sequence:

1) Threads concur on when there is no more work. We already have this; once

Heap::getNextBlocksToCopy() returns no work in any thread, it will also return no work in
any other thread that asks for work.

2) Main thread waits for the threads to not be copying anymore.
3) Do whatever we need to do after copying finishes.

Currently, we do (3) before (2) and so we have weird problems. This just changes the code to do
(3) after (2), and so we can get rid of the synchronization in doneCopying() and we can safely
call startCopying() inside GCThread. This also means that we don't need to make CopyVisitor a
property of GCThread. Instead, GCThread just instantiates its own CopyVisitor when it needs to.

• heap/CopiedSpace.cpp:

(JSC::CopiedSpace::doneCopying):

• heap/GCThread.cpp:

(JSC::GCThread::GCThread):
(JSC::GCThread::slotVisitor):
(JSC::GCThread::waitForNextPhase):
(JSC::GCThread::gcThreadMain):
(JSC::GCThread::copyVisitor): Deleted.

• heap/GCThread.h:
• heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::copyBackingStores):
(JSC::Heap::gatherStackRoots):

1:58 PM Changeset in webkit [190184] by sbarati@apple.com

• 6 edits in trunk

Web Inspector: Type bubbles missing for computed methods and methods on object literals
​https://bugs.webkit.org/show_bug.cgi?id=148562

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

This patch makes sure that computed methods are working
for both classes and object literals. Also, methods now
work on object literals. This patch also cleans up the
"isGetterOrSetter" and "getterOrSetterRange" fields.
Basically, we used this as a way to ask the type profiler
for the return types of a function. Now, we just have
a field called "typeProfilingReturnDivot" that is set
on all functions so we don't need to conditionally ask
if it's a getter or setter.

• UserInterface/Controllers/TypeTokenAnnotator.js:

(WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):

• UserInterface/Models/ScriptSyntaxTree.js:

(WebInspector.ScriptSyntaxTree.functionReturnDivot):
(WebInspector.ScriptSyntaxTree.prototype._recurseArray):
(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
(WebInspector.ScriptSyntaxTree):

LayoutTests:

• inspector/model/parse-script-syntax-tree-expected.txt:
• inspector/model/parse-script-syntax-tree.html:

1:34 PM Changeset in webkit [190183] by Beth Dakin

• 2 edits in trunk/LayoutTests

accessibility/mac/aria-expanded-notifications.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=149510

Marking it as such.

• platform/mac/TestExpectations:

1:07 PM Changeset in webkit [190182] by aestes@apple.com

• 2 edits in trunk/Source/WTF

Disable QuickLook on watchOS
​https://bugs.webkit.org/show_bug.cgi?id=149508
<rdar://problem/22517968>

Reviewed by Dan Bernstein.

• wtf/Platform.h:

12:29 PM Changeset in webkit [190181] by achristensen@apple.com

• 2 edits in trunk/Source/WebCore

Fix CMake build.

• CMakeLists.txt:

Use {} instead of () for CMake variables.

12:12 PM Changeset in webkit [190180] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

Try to fix the CMake build.

• CMakeLists.txt:

12:02 PM Changeset in webkit [190179] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Remove unimplemented method Heap::showStatistics
​https://bugs.webkit.org/show_bug.cgi?id=149507

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-23
Reviewed by Darin Adler.

• heap/Heap.h:

11:49 AM Changeset in webkit [190178] by timothy_horton@apple.com

• 9 edits in trunk/Source

Hopefully fix the production build.

• JavaScriptCore.xcodeproj/project.pbxproj:
• PlatformWin.cmake:

• DerivedSources.make:
• WebCore.vcxproj/build-generated-files.pl:
• WebCore.xcodeproj/project.pbxproj:
• generate-js-builtins:
• make-generated-sources.sh:

10:41 AM Changeset in webkit [190177] by bshafiei@apple.com

• 5 edits in trunk/Source

Versioning.

10:00 AM Changeset in webkit [190176] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Mac production build fix attempt after r190155.

• WebCore.xcodeproj/project.pbxproj:

9:23 AM Changeset in webkit [190175] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Avoid unnecessary ancestor traversal in Range::selectNodeContents()
​https://bugs.webkit.org/show_bug.cgi?id=149491

Reviewed by Andreas Kling.

Avoid unnecessary ancestor traversal in Range::selectNodeContents().
A DocumentType Node cannot have children, therefore, there is no need
to check if ancestors are docTypes. We now simply check if the current
node is a DocumentType Node, as per the specification:

• ​https://dom.spec.whatwg.org/#dom-range-selectnodecontents (step 1)

• dom/Range.cpp:

(WebCore::Range::selectNodeContents):

9:21 AM Changeset in webkit [190174] by Chris Dumez

• 9 edits in trunk

Range's setStartBefore() / setStartAfter() / setEndBefore() / setEndAfter() do not match the specification
​https://bugs.webkit.org/show_bug.cgi?id=149490

Reviewed by Andreas Kling.

LayoutTests/imported/w3c:

Rebaseline several W3C DOM tests now that more checks are passing.

• web-platform-tests/dom/ranges/Range-selectNode-expected.txt:
• web-platform-tests/dom/ranges/Range-surroundContents-expected.txt:

Source/WebCore:

Range's setStartBefore() / setStartAfter() / setEndBefore() / setEndAfter()
behavior do not match the DOM specification:

• ​https://dom.spec.whatwg.org/#dom-range-setstartbefore
• ​https://dom.spec.whatwg.org/#dom-range-setstartafter
• ​https://dom.spec.whatwg.org/#dom-range-setendbefore
• ​https://dom.spec.whatwg.org/#dom-range-setendafter

In particular, instead of step 2:
"If parent is null, throw an InvalidNodeTypeError exception."

Our implementation was doing more checks and throwing exceptions in cases
that the specification does not say we should. We were calling
checkNodeBA() which had restrictions on both the node type and its
root type. This is now replaced by a simple null check on the parent,
as per the specification.

Firefox's behavior matches the specification.

No new tests, already covered by existing tests.

• dom/Range.cpp:

(WebCore::Range::setStartAfter):
(WebCore::Range::setEndBefore):
(WebCore::Range::setEndAfter):
(WebCore::Range::setStartBefore):
(WebCore::Range::cloneRange): Deleted.
(WebCore::Range::selectNode): Deleted.
(WebCore::Range::selectNodeContents): Deleted.
(WebCore::Range::absoluteTextRects): Deleted.

• dom/Range.h:

LayoutTests:

Update test that expected an assertion in a case where we no longer
throw. I checked that Firefox does not throw in this case either.

• fast/dom/Range/range-exceptions-expected.txt:
• fast/dom/Range/script-tests/range-exceptions.js:

9:06 AM Changeset in webkit [190173] by commit-queue@webkit.org

• 15 edits
  2 deletes in trunk

Unreviewed, rolling out r190168.
​https://bugs.webkit.org/show_bug.cgi?id=149502

it broke debug builds. (Requested by zalan on #webkit).

Reverted changeset:

"HTMLOutputElement.htmlFor should be settable"
​https://bugs.webkit.org/show_bug.cgi?id=149418
​http://trac.webkit.org/changeset/190168

8:34 AM Changeset in webkit [190172] by commit-queue@webkit.org

• 3 edits
  5 deletes in trunk

Unreviewed, rolling out r190160.
​https://bugs.webkit.org/show_bug.cgi?id=149501

media/media-controls-play-button-updates.html fails on
Yosemite and EFL (Requested by zalan on #webkit).

Reverted changeset:

"[GTK] playbutton in media controls is not changed when it is
clicked."
​https://bugs.webkit.org/show_bug.cgi?id=149113
​http://trac.webkit.org/changeset/190160

8:23 AM Changeset in webkit [190171] by Antti Koivisto

• 3 edits in trunk/Source/WebCore

Try to fix build.

• css/DocumentRuleSets.h:
• inspector/InspectorInstrumentation.h:

8:07 AM Changeset in webkit [190170] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

Fix sorting

• dom/DOMAllInOne.cpp:

8:04 AM Changeset in webkit [190169] by Antti Koivisto

• 33 edits
  2 copies
  2 moves in trunk/Source/WebCore

Split author style code out from DocumentStyleSheetCollection
​https://bugs.webkit.org/show_bug.cgi?id=149446

Reviewed by Andreas Kling.

Shadow trees may have their own author style. Factor the related code out so we can use
it outside the document context.

DocumentStyleSheetCollection is replaced by two classes:

AuthorStyleSheets - author stylesheets and mutation optimization code
ExtensionStyleSheets - user stylesheets, injected author stylesheets, content extension stylesheets

• WebCore.xcodeproj/project.pbxproj:
• contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad):

• css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::didMutateRules):

• css/DocumentRuleSets.cpp:

(WebCore::DocumentRuleSets::~DocumentRuleSets):
(WebCore::DocumentRuleSets::initUserStyle):

• css/DocumentRuleSets.h:

(WebCore::DocumentRuleSets::sibling):
(WebCore::DocumentRuleSets::uncommonAttribute):

• css/InspectorCSSOMWrappers.cpp:

(WebCore::InspectorCSSOMWrappers::collectFromStyleSheets):
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
(WebCore::InspectorCSSOMWrappers::collectFromDocumentStyleSheetCollection): Deleted.

• css/InspectorCSSOMWrappers.h:
• css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::appendAuthorStyleSheets):

• css/StyleSheetList.cpp:

(WebCore::StyleSheetList::styleSheets):
(WebCore::StyleSheetList::detachFromDocument):
(WebCore::StyleSheetList::length):

• dom/AuthorStyleSheets.cpp: Added.

(WebCore::AuthorStyleSheets::AuthorStyleSheets):
(WebCore::AuthorStyleSheets::combineCSSFeatureFlags):
(WebCore::AuthorStyleSheets::resetCSSFeatureFlags):
(WebCore::AuthorStyleSheets::addAuthorSheet):
(WebCore::AuthorStyleSheets::removePendingSheet):
(WebCore::AuthorStyleSheets::addStyleSheetCandidateNode):
(WebCore::AuthorStyleSheets::removeStyleSheetCandidateNode):
(WebCore::AuthorStyleSheets::collectActiveStyleSheets):
(WebCore::AuthorStyleSheets::analyzeStyleSheetChange):
(WebCore::filterEnabledNonemptyCSSStyleSheets):
(WebCore::AuthorStyleSheets::updateActiveStyleSheets):
(WebCore::AuthorStyleSheets::activeStyleSheetsForInspector):
(WebCore::AuthorStyleSheets::activeStyleSheetsContains):
(WebCore::AuthorStyleSheets::detachFromDocument):

• dom/AuthorStyleSheets.h: Added.

(WebCore::AuthorStyleSheets::activeStyleSheets):
(WebCore::AuthorStyleSheets::styleSheets):
(WebCore::AuthorStyleSheets::styleSheetsForStyleSheetList):
(WebCore::AuthorStyleSheets::pendingUpdateType):
(WebCore::AuthorStyleSheets::setPendingUpdateType):
(WebCore::AuthorStyleSheets::flushPendingUpdates):
(WebCore::AuthorStyleSheets::preferredStylesheetSetName):
(WebCore::AuthorStyleSheets::selectedStylesheetSetName):
(WebCore::AuthorStyleSheets::setPreferredStylesheetSetName):
(WebCore::AuthorStyleSheets::setSelectedStylesheetSetName):
(WebCore::AuthorStyleSheets::addPendingSheet):
(WebCore::AuthorStyleSheets::hasPendingSheets):
(WebCore::AuthorStyleSheets::usesFirstLineRules):
(WebCore::AuthorStyleSheets::usesFirstLetterRules):
(WebCore::AuthorStyleSheets::usesRemUnits):
(WebCore::AuthorStyleSheets::setUsesRemUnit):
(WebCore::AuthorStyleSheets::usesStyleBasedEditability):
(WebCore::AuthorStyleSheets::setUsesStyleBasedEditability):

• dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleResolver):
(WebCore::Document::fontsNeedUpdate):
(WebCore::Document::usesStyleBasedEditability):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::preferredStylesheetSet):
(WebCore::Document::selectedStylesheetSet):
(WebCore::Document::setSelectedStylesheetSet):
(WebCore::Document::scheduleOptimizedStyleSheetUpdate):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::haveStylesheetsLoaded):
(WebCore::Document::getCachedLocale):

• dom/Document.h:

(WebCore::Document::authorStyleSheets):
(WebCore::Document::extensionStyleSheets):
(WebCore::Document::gotoAnchorNeededAfterStylesheetsLoad):
(WebCore::Document::setGotoAnchorNeededAfterStylesheetsLoad):
(WebCore::Document::styleSheetCollection): Deleted.

• dom/DocumentStyleSheetCollection.cpp: Removed.
• dom/DocumentStyleSheetCollection.h: Removed.
• dom/ExtensionStyleSheets.cpp: Copied from Source/WebCore/dom/DocumentStyleSheetCollection.cpp.

(WebCore::ExtensionStyleSheets::ExtensionStyleSheets):
(WebCore::ExtensionStyleSheets::pageUserSheet):
(WebCore::ExtensionStyleSheets::clearPageUserSheet):
(WebCore::ExtensionStyleSheets::updatePageUserSheet):
(WebCore::ExtensionStyleSheets::injectedUserStyleSheets):
(WebCore::ExtensionStyleSheets::injectedAuthorStyleSheets):
(WebCore::ExtensionStyleSheets::updateInjectedStyleSheetCache):
(WebCore::ExtensionStyleSheets::invalidateInjectedStyleSheetCache):
(WebCore::ExtensionStyleSheets::addUserSheet):
(WebCore::ExtensionStyleSheets::addDisplayNoneSelector):
(WebCore::ExtensionStyleSheets::maybeAddContentExtensionSheet):
(WebCore::ExtensionStyleSheets::styleResolverChangedTimerFired):
(WebCore::ExtensionStyleSheets::detachFromDocument):
(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection): Deleted.
(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags): Deleted.
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags): Deleted.
(WebCore::DocumentStyleSheetCollection::pageUserSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::clearPageUserSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::updatePageUserSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::injectedUserStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::injectedAuthorStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::updateInjectedStyleSheetCache): Deleted.
(WebCore::DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache): Deleted.
(WebCore::DocumentStyleSheetCollection::addAuthorSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::addUserSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::addDisplayNoneSelector): Deleted.
(WebCore::DocumentStyleSheetCollection::maybeAddContentExtensionSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::styleResolverChangedTimerFired): Deleted.
(WebCore::DocumentStyleSheetCollection::removePendingSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::addStyleSheetCandidateNode): Deleted.
(WebCore::DocumentStyleSheetCollection::removeStyleSheetCandidateNode): Deleted.
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange): Deleted.
(WebCore::filterEnabledNonemptyCSSStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::activeStyleSheetsForInspector): Deleted.
(WebCore::DocumentStyleSheetCollection::activeStyleSheetsContains): Deleted.
(WebCore::DocumentStyleSheetCollection::detachFromDocument): Deleted.

• dom/ExtensionStyleSheets.h: Copied from Source/WebCore/dom/DocumentStyleSheetCollection.h.

(WebCore::ExtensionStyleSheets::documentUserStyleSheets):
(WebCore::DocumentStyleSheetCollection::styleSheetsForStyleSheetList): Deleted.
(WebCore::DocumentStyleSheetCollection::activeAuthorStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::documentUserStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::documentAuthorStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::pendingUpdateType): Deleted.
(WebCore::DocumentStyleSheetCollection::setPendingUpdateType): Deleted.
(WebCore::DocumentStyleSheetCollection::flushPendingUpdates): Deleted.
(WebCore::DocumentStyleSheetCollection::preferredStylesheetSetName): Deleted.
(WebCore::DocumentStyleSheetCollection::selectedStylesheetSetName): Deleted.
(WebCore::DocumentStyleSheetCollection::setPreferredStylesheetSetName): Deleted.
(WebCore::DocumentStyleSheetCollection::setSelectedStylesheetSetName): Deleted.
(WebCore::DocumentStyleSheetCollection::addPendingSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::hasPendingSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::usesFirstLineRules): Deleted.
(WebCore::DocumentStyleSheetCollection::usesFirstLetterRules): Deleted.
(WebCore::DocumentStyleSheetCollection::usesRemUnits): Deleted.
(WebCore::DocumentStyleSheetCollection::setUsesRemUnit): Deleted.
(WebCore::DocumentStyleSheetCollection::usesStyleBasedEditability): Deleted.
(WebCore::DocumentStyleSheetCollection::setUsesStyleBasedEditability): Deleted.

• dom/InlineStyleSheetOwner.cpp:

(WebCore::InlineStyleSheetOwner::insertedIntoDocument):
(WebCore::InlineStyleSheetOwner::removedFromDocument):
(WebCore::InlineStyleSheetOwner::clearDocumentData):
(WebCore::InlineStyleSheetOwner::childrenChanged):
(WebCore::InlineStyleSheetOwner::createSheet):
(WebCore::InlineStyleSheetOwner::sheetLoaded):
(WebCore::InlineStyleSheetOwner::startLoadingDynamicSheet):

• dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::~ProcessingInstruction):
(WebCore::ProcessingInstruction::nodeName):
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::sheetLoaded):
(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):

• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):
(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):

• html/HTMLQuoteElement.cpp:
• inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::collectAllDocumentStyleSheets):
(WebCore::InspectorCSSAgent::buildObjectForRule):

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::commitData):

• page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):
(WebCore::Page::setUserContentController):

• page/PageGroup.cpp:
• page/UserContentController.cpp:

(WebCore::UserContentController::invalidateInjectedStyleSheetCacheInAllFrames):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineHeight):
(WebCore::RenderBlock::getFirstLetter):

• rendering/RenderElement.cpp:

(WebCore::RenderElement::uncachedFirstLineStyle):
(WebCore::RenderElement::cachedFirstLineStyle):

• rendering/RenderElement.h:

(WebCore::RenderElement::firstLineStyle):
(WebCore::RenderElement::setAncestorLineBoxDirty):

• rendering/RenderInline.cpp:

(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
(WebCore::RenderInline::lineHeight):

• rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::lineHeight):

• rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticalPositionForBox):

• style/StyleResolveTree.cpp:

(WebCore::Style::resolveLocal):

7:32 AM Changeset in webkit [190168] by Chris Dumez

• 15 edits
  2 adds in trunk

HTMLOutputElement.htmlFor should be settable
​https://bugs.webkit.org/show_bug.cgi?id=149418

Reviewed by Ryosuke Niwa.

Source/WebCore:

HTMLOutputElement.htmlFor should be settable as per the latest HTML
specification:

• ​https://html.spec.whatwg.org/multipage/forms.html#the-output-element

It is supposed to call DOMSettableTokenList.setValue() with the input
String. This patch adds support for this by adding [PutForwards=value]
IDL extended attribute.

This aligns our behavior with the specification, Firefox and Chrome.

No new tests, already covered by existing test.

• html/AttributeDOMTokenList.cpp:

(WebCore::AttributeDOMTokenList::AttributeDOMTokenList):
(WebCore::AttributeDOMTokenList::attributeValueChanged):

• html/AttributeDOMTokenList.h:
• Have AttributeDOMTokenList subclass DOMSettableTokenList instead of

DOMTokenList so that it can be used in places where the IDL expects
us to return a DOMSettableTokenList (e.g. HTMLOutputElement.htmlFor).

• Mark AttributeDOMTokenList as fast allocated.

• html/DOMSettableTokenList.cpp:

(WebCore::DOMSettableTokenList::setValue):

• html/DOMSettableTokenList.h:
• Move setValue() from DOMTokenList to DOMSettableTokenList as it is only needed by DOMSettableTokenList.
• Get rid of the factory function as all call sites are using AttributeDOMTokenList now.
• Stop inheriting RefCounted as AttributeDOMTokenList handles its own refcounting.

• html/DOMTokenList.cpp:

(WebCore::DOMTokenList::setValueInternal):

• html/DOMTokenList.h:

Rename setValue() to setValueInternal() as this version does not
update the associated attribute value, only the tokens.

• html/HTMLLinkElement.cpp:
• html/HTMLLinkElement.h:
• Have HTMLLinkElement.sizes use an AttributeDOMTokenList instead of a DOMSettableTokenList as there is an associated attribute. The previous code had a bug has setting HTMLLinkElement.sizes would not update the associated 'sizes' attribute. Switching to using AttributeDOMTokenList fixes this and a new layout test has been added to cover this.
• Create the AttributeDOMTokenList lazily to avoid updating it every time the sizes attribute changes until it is actually accessed.

• html/HTMLOutputElement.cpp:
• html/HTMLOutputElement.h:
• Have HTMLLinkElement.htmlFor use an AttributeDOMTokenList instead of a DOMSettableTokenList as there is an associated attribute.
• Create the AttributeDOMTokenList lazily to avoid updating it every time the sizes attribute changes until it is actually accessed.

• html/HTMLOutputElement.idl:

Add [PutForwards=value] on the htmlFor attribute, as per the
HTML specification.

LayoutTests:

• fast/dom/HTMLLinkElement/sizes-setter.html: Added
• fast/dom/HTMLLinkElement/sizes-setter-expected.txt: Added

Add layout test to make sure that setting HTMLLinkElement.sizes actually
updates the 'sizes' associated attribute.

• fast/dom/HTMLOutputElement/dom-settable-token-list-expected.txt:
• fast/dom/HTMLOutputElement/script-tests/dom-settable-token-list.js:

Update existing layout test now that HTMLOutputElement.htmlFor is
settable.

4:33 AM Changeset in webkit [190167] by calvaris@igalia.com

• 1 edit
  2 adds in trunk/LayoutTests

[Streams API] Add transform stream general tests
​https://bugs.webkit.org/show_bug.cgi?id=149267

Reviewed by Darin Adler.

• streams/reference-implementation/transform-stream-expected.txt: Added.
• streams/reference-implementation/transform-stream.html: Added.

4:27 AM Changeset in webkit [190166] by calvaris@igalia.com

• 1 edit
  2 adds in trunk/LayoutTests

[Streams API] Added transform stream error tests
​https://bugs.webkit.org/show_bug.cgi?id=149266

Reviewed by Darin Adler.

• streams/reference-implementation/transform-stream-errors-expected.txt: Added.
• streams/reference-implementation/transform-stream-errors.html: Added.

4:25 AM Changeset in webkit [190165] by calvaris@igalia.com

• 2 edits
  2 adds in trunk/LayoutTests

[Streams API] Added pipe-through transform stream tests
​https://bugs.webkit.org/show_bug.cgi?id=149265

Reviewed by Darin Adler.

• streams/reference-implementation/pipe-through-expected.txt: Added.
• streams/reference-implementation/pipe-through.html: Added.
• streams/reference-implementation/resources/streams-utils.js: Added duckTypedPassThroughTransform function.

4:23 AM Changeset in webkit [190164] by calvaris@igalia.com

• 3 edits in trunk/LayoutTests

[Streams API] Add count queuing strategy tests for writable streams
​https://bugs.webkit.org/show_bug.cgi?id=148303

Reviewed by Darin Adler.

• streams/reference-implementation/count-queuing-strategy-expected.txt: Added new expectations.
• streams/reference-implementation/count-queuing-strategy.html: Added new writable stream tests.

4:17 AM Changeset in webkit [190163] by calvaris@igalia.com

• 3 edits in trunk/LayoutTests

[Streams API] Add byte length queuing strategy tests for writable streams
​https://bugs.webkit.org/show_bug.cgi?id=148302

Reviewed by Darin Adler.

• streams/reference-implementation/byte-length-queuing-strategy-expected.txt: Added new expectations.
• streams/reference-implementation/byte-length-queuing-strategy.html: Added new writable stream tests.

4:14 AM Changeset in webkit [190162] by calvaris@igalia.com

• 3 edits in trunk/LayoutTests

[Streams API] Add brand checks tests for writable streams
​https://bugs.webkit.org/show_bug.cgi?id=148301

Reviewed by Darin Adler.

• streams/reference-implementation/brand-checks-expected.txt: Added new expectations.
• streams/reference-implementation/brand-checks.html: Added new writable stream tests.

4:12 AM Changeset in webkit [190161] by calvaris@igalia.com

• 1 edit
  2 adds in trunk/LayoutTests

[Streams API] bad underlying sinks tests about writable streams
​https://bugs.webkit.org/show_bug.cgi?id=148295

Reviewed by Darin Adler.

• streams/reference-implementation/bad-underlying-sinks-expected.txt: Added.
• streams/reference-implementation/bad-underlying-sinks.html: Added.

4:07 AM Changeset in webkit [190160] by ChangSeok Oh

• 3 edits
  5 adds in trunk

[GTK] playbutton in media controls is not changed when it is clicked.
​https://bugs.webkit.org/show_bug.cgi?id=149113

Reviewed by Philippe Normand.

Source/WebCore:

When the play button in media controls is clicked, a 'paused' class is added or removed
for the element to update its appearance. Although Document::recalcStyle is triggered
by that class attribute change, the play button is not changed since there is
no difference in styles whether having the 'paused' class or not. Gtk port
does not define the -webkit-media-controls-play-button.paused. To fix this,
-webkit-media-controls-play-button.paused is newly defined with a dummy style,
"position: relative;", which should not change the play button appearance,
but be clearly different in style.

Test: media/media-controls-play-button-updates.html

• css/mediaControlsGtk.css:

(video::-webkit-media-controls-play-button.paused):

LayoutTests:

• media/media-controls-play-button-updates-expected.png: Added.
• media/media-controls-play-button-updates-expected.txt: Added.
• media/media-controls-play-button-updates.html: Added.
• platform/gtk/media/media-controls-play-button-updates-expected.png: Added.
• platform/gtk/media/media-controls-play-button-updates-expected.txt: Added.

4:03 AM Changeset in webkit [190159] by calvaris@igalia.com

• 3 edits in trunk/LayoutTests

[Streams API] Add bad strategies writable streams tests
​https://bugs.webkit.org/show_bug.cgi?id=148300

Reviewed by Darin Adler.

• streams/reference-implementation/bad-strategies-expected.txt: Added new expectations.
• streams/reference-implementation/bad-strategies.html: Added new writable stream tests.

3:04 AM Changeset in webkit [190158] by calvaris@igalia.com

• 2 edits in trunk/LayoutTests

[Streams API] Change a const in the tee tests
​https://bugs.webkit.org/show_bug.cgi?id=148294

Reviewed by Darin Adler.

• streams/reference-implementation/readable-stream-tee.html: Dumb change, replaced a const with var and added

the checkpoint of the spec commit.

1:32 AM Changeset in webkit [190157] by ChangSeok Oh

• 3 edits in trunk/LayoutTests

[GTK] media/media-controls-timeline-updates.html timeouts
​https://bugs.webkit.org/show_bug.cgi?id=139363

Reviewed by Philippe Normand.

The default timeout value of gtk port is 6000ms for release build layout tests.
But this is too short to pass some media tests such as media-controls-timeline-updates.html
Let's tweak the test to have shorter test time by seeking.

• media/media-controls-timeline-updates.html:
• platform/gtk/TestExpectations:

12:33 AM Changeset in webkit [190156] by aestes@apple.com

• 4 edits in trunk/Source

Disable QuickLook on tvOS
​https://bugs.webkit.org/show_bug.cgi?id=149492
<rdar://problem/22741586>

Reviewed by Dan Bernstein.

Source/WebKit/mac:

We can't use USE(QUICK_LOOK) in a Private header, and postprocess-headers.sh doesn't know how to strip things
that aren't feature flags. So, if QuickLook is disabled, we'll just always define WebQuickLookFileNameKey and
WebQuickLookUTIKey, and we'll also define -quickLookContentForURL: but have it return nil.

• WebView/WebView.mm:

(-[WebView quickLookContentForURL:]):

Source/WTF:

• wtf/Platform.h: Stopped enabling QuickLook on tvOS.

12:24 AM Changeset in webkit [190155] by youenn.fablet@crf.canon.fr

• 27 edits
  1 copy
  8 adds in trunk

[Streams API] Implement ReadableStream pipeThrough
​https://bugs.webkit.org/show_bug.cgi?id=147556

Reviewed by Darin Adler.

Source/JavaScriptCore:

Updating BuiltIns infrastructure to make it reusable from WebCore.
Extracting macros from BuiltinNames and createBuiltinExecutable from BuiltinExecutables.
Updated generate-js-builtins to allow generating builtin CPP/H files in WebCore namespace.

• JavaScriptCore.xcodeproj/project.pbxproj:
• builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::createDefaultConstructor):
(JSC::BuiltinExecutables::createBuiltinExecutable):
(JSC::createBuiltinExecutable):
(JSC::createExecutableInternal):

• builtins/BuiltinExecutables.h:
• builtins/BuiltinNames.h:

(JSC::BuiltinNames::BuiltinNames): Deleted.

• builtins/BuiltinUtils.h: Extracting code from BuiltinNames and BuiltinExecutables.h.
• bytecode/UnlinkedFunctionExecutable.h:
• generate-js-builtins:

(getFunctions):
(writeIncludeDirectives):

Source/WebCore:

Adding initial support for JS builtins within WebCore.
This patch allows implementing IDL interface methods in JS, by using the new JSBuiltin keyword.
(No support yet for private identifiers, constructors or accessors).
Integration of the built-in executables and names is implemented within WebCoreJSClientData.
Two files are generated for each JS builtin file:

• builtin h/cpp files similar to JSCBuiltins.cpp/.h, generated through WebCore/generate-js-builtins from JavaScriptCore/generate-js-builtins)
• A builtin wrapper file mimicking BuiltinExecutables (generated from WebCore/generate-js-builtins)

Contrary to JSC, each js file is generating its own cpp/h file.
This allows including those files within the JSXX.cpp/.h files generated from the IDL where compilation guard may take effect.

Disabled GObject binding for JSBuiltin methods.

Test: streams/readable-stream-pipeThrough.html

• CMakeLists.txt: Triggering generate-js-builtins for JS files.
• DerivedSources.make: Ditto.
• ForwardingHeaders/builtins/BuiltinUtils.h: Added.
• ForwardingHeaders/bytecode/UnlinkedFunctionExecutable.h: Added.
• ForwardingHeaders/runtime/ConstructAbility.h: Added.
• Modules/streams/ReadableStream.idl: Marking pipeThrough as JS builtin
• Modules/streams/ReadableStream.js: Added.

(pipeThrough):

• bindings/js/JSReadableStreamCustom.cpp:
• bindings/js/WebCoreJSClientData.h: Adding ReadableStreamBuiltinsWrapper to store ReadableStream builtin executable

(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::readableStreamBuiltins):
(WebCore::initNormalWorldClientData):

• bindings/scripts/CodeGeneratorGObject.pm: Disabled GObject binding for JSBuiltin methods.
• bindings/scripts/CodeGeneratorJS.pm: Adding support for JSBuiltin keyword.

(GetFunctionName):
(GenerateHeader):
(GenerateImplementation):
(GenerateHashTableValueArray):
(ComputeFunctionSpecial):
(UseJSBuiltins):

• bindings/scripts/IDLAttributes.txt: Adding JSBuiltin.
• bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_js_builtin_method):
(webkit_dom_test_obj_js_builtin_method_with_args):

• bindings/scripts/test/GObject/WebKitDOMTestObj.h:
• bindings/scripts/test/JS/JSTestObj.cpp:
• bindings/scripts/test/JS/JSTestObj.h:
• bindings/scripts/test/ObjC/DOMTestObj.h:
• bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj jsBuiltinMethod]):
(-[DOMTestObj jsBuiltinMethodWithArgs:strArg:objArg:]):

• bindings/scripts/test/TestObj.idl:
• generate-js-builtins: Added.

LayoutTests:

Rebased test that is now passing.
Adding new tests to improve pipeThrough coverage.

• streams/readable-stream-pipeThrough-expected.txt: Added.
• streams/readable-stream-pipeThrough.html: Added.
• streams/reference-implementation/brand-checks-expected.txt:

Sep 22, 2015:

11:43 PM Changeset in webkit [190154] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Gardening: speculative non-JIT build fix after r189999.

Not reviewed.

• bytecode/ValueRecovery.h:

(JSC::ValueRecovery::jsValueRegs):

6:42 PM Changeset in webkit [190153] by rniwa@webkit.org

• 7 edits
  2 adds in trunk

Event fired on a detached node does not bubble up
​https://bugs.webkit.org/show_bug.cgi?id=149488

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Rebaselined a test now that one more test case passes.

• web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:

Source/WebCore:

The bug was caused by an explicit check inside EventPath to match an old Firefox behavior (see r19897).
Since Firefox's behavior has changed to match DOM4: ​https://dom.spec.whatwg.org/#concept-event-dispatch

Fixed the bug by removing the check. The new behavior matches DO4 and behaviors of Firefox and Chrome.

Test: fast/events/event-propagation-in-detached-tree.html

• dom/EventDispatcher.cpp:

(WebCore::EventPath::EventPath):

LayoutTests:

Added a regression test. Also modified and rebaselined mouseout-dead-node.html added in r19897
since our new behavior matches that of the latest Firefox as well as Chrome.

• fast/events/event-propagation-in-detached-tree-expected.txt: Added.
• fast/events/event-propagation-in-detached-tree.html: Added.
• fast/events/mouseout-dead-node-expected.txt:
• fast/events/mouseout-dead-node.html:

6:37 PM Changeset in webkit [190152] by Gyuyoung Kim

• 6 edits in trunk

Add a file of pointer-lock to cmake ports
​https://bugs.webkit.org/show_bug.cgi?id=149453

Reviewed by Csaba Osztrogonác.

.:

• Source/cmake/OptionsEfl.cmake: Add a ENABLE_POINTER_LOCK.

Source/WebCore:

Some cmake ports will be able to enable POINTER_LOCK. To support it,
this patch adds PointerLockController.cpp, and fix a build break in WK2.

• CMakeLists.txt:

Source/WebKit2:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::navigateToPDFLinkWithSimulatedClick): Fix a build break.

6:35 PM Changeset in webkit [190151] by fpizlo@apple.com

• 18 edits
  2 deletes in trunk/Source/JavaScriptCore

GCThreadSharedData is just a bad way of saying Heap
​https://bugs.webkit.org/show_bug.cgi?id=149435

Reviewed by Mark Lam.

This removes the GCThreadSharedData class and moves its members into Heap. This is a net
simplification since GCThreadSharedData had a 1-to-1 mapping to Heap and the two classes had a
vast contract with a lot of interdependencies. Heap would call a lot of GCThreadSharedData
methods; now a lot of those are inlined since they were only called from the one place in Heap.
This makes it a lot easier to see what is going on. For example, you no longer have to look at
code in two places (Heap and GCThreadSharedData) to figure out the timing and synchronization
of GC phases - all of that code is in Heap now.

This also removes weird indirections in other places. It used to be that a lot of GC helper
classes woud have a pointer to GCThreadSharedData, and then would use that to get to Heap, VM,
and the visitors. Now these helpers just point to Heap.

I think that GCThreadSharedData was only useful for defining the set of things that we need to
know to collect garbage. That's how we decided if something would go into GCThreadSharedData
instead of Heap. But I think that separating things into multiple classes usually makes the
code less hackable, so there should be a very high bar for doing this in a way that produces a
1-to-1 mapping between two classes - where one instance of one of the classes is always paired
with exactly one instance of the other class and vice-versa.

• CMakeLists.txt:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
• JavaScriptCore.xcodeproj/project.pbxproj:
• heap/CopiedSpace.h:
• heap/CopyVisitor.cpp:

(JSC::CopyVisitor::CopyVisitor):
(JSC::CopyVisitor::copyFromShared):

• heap/CopyVisitor.h:
• heap/CopyVisitorInlines.h:

(JSC::CopyVisitor::allocateNewSpaceSlow):
(JSC::CopyVisitor::startCopying):
(JSC::CopyVisitor::doneCopying):
(JSC::CopyVisitor::didCopy):

• heap/GCThread.cpp:

(JSC::GCThread::GCThread):
(JSC::GCThread::waitForNextPhase):
(JSC::GCThread::gcThreadMain):

• heap/GCThread.h:
• heap/GCThreadSharedData.cpp: Removed.
• heap/GCThreadSharedData.h: Removed.
• heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::isPagedOut):
(JSC::Heap::markRoots):
(JSC::Heap::copyBackingStores):
(JSC::Heap::updateObjectCounts):
(JSC::Heap::resetVisitors):
(JSC::Heap::objectCount):
(JSC::Heap::sweepNextLogicallyEmptyWeakBlock):
(JSC::Heap::threadVisitCount):
(JSC::Heap::threadBytesVisited):
(JSC::Heap::threadBytesCopied):
(JSC::Heap::startNextPhase):
(JSC::Heap::endCurrentPhase):

• heap/Heap.h:
• heap/HeapInlines.h:

(JSC::Heap::unregisterWeakGCMap):
(JSC::Heap::getNextBlocksToCopy):

• heap/ListableHandler.h:
• heap/SlotVisitor.cpp:

(JSC::SlotVisitor::SlotVisitor):
(JSC::SlotVisitor::didStartMarking):
(JSC::SlotVisitor::reset):
(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
(JSC::SlotVisitor::mergeOpaqueRoots):
(JSC::SlotVisitor::harvestWeakReferences):
(JSC::SlotVisitor::finalizeUnconditionalFinalizers):

• heap/SlotVisitor.h:

(JSC::SlotVisitor::markStack):
(JSC::SlotVisitor::isEmpty):
(JSC::SlotVisitor::sharedData): Deleted.

• heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::addWeakReferenceHarvester):
(JSC::SlotVisitor::addUnconditionalFinalizer):
(JSC::SlotVisitor::addOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRootTriState):
(JSC::SlotVisitor::opaqueRootCount):
(JSC::SlotVisitor::mergeOpaqueRootsIfNecessary):
(JSC::SlotVisitor::copyLater):
(JSC::SlotVisitor::heap):
(JSC::SlotVisitor::vm):

6:35 PM Changeset in webkit [190150] by Alan Bujtas

• 2 edits in trunk/LayoutTests

Mark http/tests/notifications/events.html flaky again (crash/timeout this time).

Unreviewed.

• TestExpectations:

6:29 PM Changeset in webkit [190149] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: The right sidebar always opens up on breakpoint
​https://bugs.webkit.org/show_bug.cgi?id=149261

Patch by Devin Rousso <Devin Rousso> on 2015-09-22
Reviewed by Timothy Hatcher.

Whenever the debugger was paused, the sidebar was being forced to open.
This has been removed in favor of letting the user decide.

• UserInterface/Base/Main.js:

(WebInspector._debuggerDidPause):

6:13 PM Changeset in webkit [190148] by matthew_hanson@apple.com

• 5 edits in branches/safari-601-branch/Source

Versioning.

6:11 PM Changeset in webkit [190147] by matthew_hanson@apple.com

• 1 copy in tags/Safari-601.2.6

New Tag.

5:39 PM Changeset in webkit [190146] by sbarati@apple.com

• 9 edits
  1 add in trunk

Web Inspector: [ES6] Improve Type Profiler Support for Arrow Functions
​https://bugs.webkit.org/show_bug.cgi?id=143171

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

We now need to take into account TypeProfilerSearchDescriptor when
hashing results for type profiler queries. Before, we've gotten
away with not doing this because before we would never have a text
collision between a return type text offset and a normal expression text
offset. But, with arrow functions, we will have collisions when
the arrow function doesn't have parens around its single parameter.
I.e: "param => { ... };"

• runtime/TypeProfiler.cpp:

(JSC::TypeProfiler::findLocation):

• runtime/TypeProfiler.h:

(JSC::QueryKey::QueryKey):
(JSC::QueryKey::isHashTableDeletedValue):
(JSC::QueryKey::operator==):
(JSC::QueryKey::hash):

• tests/typeProfiler/arrow-functions.js: Added.

Source/WebInspectorUI:

Esprima and JSC both support arrow functions. We just
need to support it in our AST and do the right things
to include support in the type profiler bits.

• UserInterface/Controllers/TypeTokenAnnotator.js:

(WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):
(WebInspector.TypeTokenAnnotator.prototype._translateToOffsetAfterFunctionParameterList.isLineTerminator):
(WebInspector.TypeTokenAnnotator.prototype._translateToOffsetAfterFunctionParameterList):

• UserInterface/Models/ScriptSyntaxTree.js:

(WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement.removeFunctionsFilter):
(WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement):
(WebInspector.ScriptSyntaxTree.functionReturnDivot):
(WebInspector.ScriptSyntaxTree.prototype._recurse):
(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
(WebInspector.ScriptSyntaxTree):

LayoutTests:

• inspector/model/parse-script-syntax-tree-expected.txt:
• inspector/model/parse-script-syntax-tree.html:

5:33 PM Changeset in webkit [190145] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Drop unnecessary ancestor traversal in Range::selectNode()
​https://bugs.webkit.org/show_bug.cgi?id=149482

Reviewed by Ryosuke Niwa.

Drop unnecessary ancestor traversal in Range::selectNode(). It traversed
the ancestors to throw a INVALID_NODE_TYPE_ERR if one of them was a
DocumentType Node. However, it is impossible for a DocumentType Node to
have children.

• dom/Range.cpp:

(WebCore::Range::selectNode):

5:27 PM Changeset in webkit [190144] by Sukolsak Sakshuwong

• 1 edit in trunk/Source/JavaScriptCore/wasm/WASMFunctionSyntaxChecker.h

Unreviewed, fix argument types in WASMFunctionSyntaxChecker.h.

• wasm/WASMFunctionSyntaxChecker.h:

4:51 PM Changeset in webkit [190143] by bweinstein@apple.com

• 2 edits in trunk/Source/WebCore

Error message in ContentExtensionError.cpp shouldn't have two spaces between sentences.
​https://bugs.webkit.org/show_bug.cgi?id=149479

Reviewed by Andy Estes.

• contentextensions/ContentExtensionError.cpp:

(WebCore::ContentExtensions::contentExtensionErrorCategory):

4:49 PM Changeset in webkit [190142] by matthew_hanson@apple.com

• 3 edits in branches/safari-601-branch/Source/WebCore

Merge r189200. rdar://problem/22803080

4:32 PM Changeset in webkit [190141] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

URL of page visited in private browsing still appears in Activity Monitor after page is closed
​https://bugs.webkit.org/show_bug.cgi?id=149475
rdar://problem/22684521

Reviewed by Dan Bernstein.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):
Make sure to call updateActivePages after removing the page from the page map.

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::updateActivePages):
Don't include pages that have private browsing enabled.

4:28 PM Changeset in webkit [190140] by matthew_hanson@apple.com

• 3 edits in branches/safari-601.1-branch/Source/WebCore

Rollout r189200. rdar://problem/22803080

4:14 PM Changeset in webkit [190139] by Chris Dumez

• 4 edits in trunk

Range.surroundContents() should check for partially contained non-Text nodes first
​https://bugs.webkit.org/show_bug.cgi?id=149476

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline existing W3C DOM test now that more checks are passing.

• web-platform-tests/dom/ranges/Range-surroundContents-expected.txt:

Source/WebCore:

Range.surroundContents() should check for partially contained non-Text
nodes first, before checking the type of the newParent parameter:

• ​https://dom.spec.whatwg.org/#dom-range-surroundcontents (step 1 and 2)

Firefox and Chrome follow the specification.

No new tests, already covered by existing test.

• dom/Range.cpp:

(WebCore::Range::surroundContents):

4:06 PM Changeset in webkit [190138] by Chris Dumez

• 19 edits in trunk

Unreviewed, rolling out r190134.
​https://bugs.webkit.org/show_bug.cgi?id=149481

"Seems to cause crashes during garbage collection" (Requested
by cdumez on #webkit).

Reverted changeset:

"HTMLOutputElement.htmlFor should be settable"
​https://bugs.webkit.org/show_bug.cgi?id=149418
​http://trac.webkit.org/changeset/190134

Patch by Commit Queue <​commit-queue@webkit.org> on 2015-09-22

3:35 PM Changeset in webkit [190137] by matthew_hanson@apple.com

• 3 edits in branches/safari-601.1-branch/Source/WebCore

Merge r189200. rdar://problem/22803080

3:27 PM Changeset in webkit [190136] by Chris Dumez

• 4 edits in trunk

Range.intersectsNode() does not behave according to the specification when start / end are equal
​https://bugs.webkit.org/show_bug.cgi?id=148774
<rdar://problem/22571418>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline W3C Range test now that another check is passing.

• web-platform-tests/dom/ranges/Range-intersectsNode-expected.txt:

Source/WebCore:

Range.intersectsNode() does not behave according to the specification
when start / end are equal:
​https://dom.spec.whatwg.org/#dom-range-intersectsnode

The specification says:
"If (parent, offset) is before end and (parent, offset + 1) is after
start, return true."

However, the way we were detecting "is before end" and "is after start"
was flawed in the case where start / end were equal. This is because when
comparePoint() return 0, then it means that the node/offset is not only
equal to start but also equal to end. As such, it is not "after start"
/ "before end".

No new tests, already covered by existing.

• dom/Range.cpp:

(WebCore::Range::intersectsNode):
(WebCore::highestAncestorUnderCommonRoot): Deleted.

2:39 PM Changeset in webkit [190135] by Alan Bujtas

• 2 edits in trunk/LayoutTests

Mark http/tests/notifications/events.html flaky.
​https://bugs.webkit.org/show_bug.cgi?id=149218

Unreviewed.

• TestExpectations:

2:24 PM Changeset in webkit [190134] by Chris Dumez

• 19 edits in trunk

HTMLOutputElement.htmlFor should be settable
​https://bugs.webkit.org/show_bug.cgi?id=149418

Reviewed by Darin Adler.

Source/WebCore:

HTMLOutputElement.htmlFor should be settable as per the latest HTML
specification:

• ​https://html.spec.whatwg.org/multipage/forms.html#the-output-element

It is supposed to call DOMSettableTokenList.setValue() with the input
String. This patch adds support for this by adding [PutForwards=value]
IDL extended attribute.

This aligns our behavior with the specification, Firefox and Chrome.

No new tests, already covered by existing test.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::classList):

• dom/Element.cpp:

(WebCore::Element::classList):

• dom/ElementRareData.h:

(WebCore::ElementRareData::setClassList):

• html/AttributeDOMTokenList.h:
• html/DOMSettableTokenList.h:
• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::relList):

• html/HTMLAnchorElement.h:
• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::relList):

• html/HTMLLinkElement.h:
• html/HTMLOutputElement.cpp:

(WebCore::HTMLOutputElement::HTMLOutputElement):
(WebCore::HTMLOutputElement::parseAttribute):
(WebCore::HTMLOutputElement::childrenChanged): Deleted.

• html/HTMLOutputElement.h:
• html/HTMLOutputElement.idl:

LayoutTests:

Update existing layout test now that HTMLOutputElement.htmlFor is
settable.

• fast/dom/HTMLOutputElement/dom-settable-token-list-expected.txt:
• fast/dom/HTMLOutputElement/script-tests/dom-settable-token-list.js:

2:11 PM Changeset in webkit [190133] by aestes@apple.com

• 2 edits in trunk/Tools

ContentFiltering.AllowDownloadAfterAddData is very flaky
​https://bugs.webkit.org/show_bug.cgi?id=148885
<rdar://problem/22729563>

Reviewed by Alexey Proskuryakov.

The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
but there is no guarantee of this. For tests that should allow a download, spin the runloop until
-_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.

• TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:

(downloadTest):

2:08 PM Changeset in webkit [190132] by timothy_horton@apple.com

• 5 edits in trunk/LayoutTests

Demystify why a few text tests depend on threaded scrolling being disabled

• fast/text/combining-character-sequence-vertical.html:
• fast/text/descent-clip-in-scaled-page-expected.html:
• fast/text/descent-clip-in-scaled-page.html:
• fast/text/vertical-quotation-marks.html:

1:41 PM Changeset in webkit [190131] by fpizlo@apple.com

• 13 edits in trunk/Source

Get rid of ENABLE(PARALLEL_GC)
​https://bugs.webkit.org/show_bug.cgi?id=149436

Reviewed by Mark Lam.

We always enable parallel GC everywhere but Windows, and it doesn't look like it was disabled
there for any good reason. So, get rid of the flag.

Source/JavaScriptCore:

The only effect of this change is that parallel GC will now be enabled on Windows, provided
that the CPU detection finds more than one.

• heap/GCThread.cpp:

(JSC::GCThread::gcThreadMain):

• heap/GCThreadSharedData.cpp:

(JSC::GCThreadSharedData::resetChildren):
(JSC::GCThreadSharedData::childBytesCopied):
(JSC::GCThreadSharedData::GCThreadSharedData):
(JSC::GCThreadSharedData::~GCThreadSharedData):
(JSC::GCThreadSharedData::reset):
(JSC::GCThreadSharedData::didStartMarking):

• heap/Heap.cpp:

(JSC::Heap::converge):
(JSC::Heap::visitWeakHandles):
(JSC::Heap::updateObjectCounts):
(JSC::Heap::resetVisitors):

• heap/MarkedBlock.h:
• heap/SlotVisitor.cpp:

(JSC::SlotVisitor::didStartMarking):
(JSC::SlotVisitor::reset):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
(JSC::SlotVisitor::mergeOpaqueRoots):
(JSC::JSString::tryHashConsLock):
(JSC::JSString::releaseHashConsLock):

• heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::addOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRootTriState):
(JSC::SlotVisitor::opaqueRootCount):
(JSC::SlotVisitor::mergeOpaqueRootsIfNecessary):

• runtime/Options.cpp:

(JSC::computeNumberOfGCMarkers):

Source/WTF:

• wtf/MainThread.cpp:

(WTF::canAccessThreadLocalDataForThread):
(WTF::initializeGCThreads):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):

• wtf/Platform.h:

1:11 PM Changeset in webkit [190130] by Sukolsak Sakshuwong

• 9 edits in trunk/Source/JavaScriptCore

Implement min and max instructions in WebAssembly
​https://bugs.webkit.org/show_bug.cgi?id=149454

Reviewed by Geoffrey Garen.

This patch implements min and max instructions in WebAssembly.

• tests/stress/wasm-arithmetic-float64.js:
• tests/stress/wasm-arithmetic-int32.js:
• tests/stress/wasm/arithmetic-float64.wasm:
• tests/stress/wasm/arithmetic-int32.wasm:
• wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::buildMinOrMaxI32):
(JSC::WASMFunctionCompiler::buildMinOrMaxF64):

• wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseMinOrMaxExpressionI32):
(JSC::WASMFunctionParser::parseExpressionF64):
(JSC::WASMFunctionParser::parseMinOrMaxExpressionF64):

• wasm/WASMFunctionParser.h:
• wasm/WASMFunctionSyntaxChecker.h:

(JSC::WASMFunctionSyntaxChecker::buildMinOrMaxI32):
(JSC::WASMFunctionSyntaxChecker::buildMinOrMaxF64):

1:01 PM Changeset in webkit [190129] by fpizlo@apple.com

• 23 edits in trunk/Source

Get rid of ENABLE(GGC)
​https://bugs.webkit.org/show_bug.cgi?id=149472

Reviewed by Mark Hahnenberg and Mark Lam.

Source/JavaScriptCore:

Getting rid of this feature flag allows us to remove a lot of yuck.

• bytecode/CodeBlock.h:

(JSC::CodeBlockSet::mark):
(JSC::ScriptExecutable::forEachCodeBlock):

• bytecode/PolymorphicAccess.cpp:

(JSC::AccessCase::generate):

• dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::osrWriteBarrier):
(JSC::DFG::adjustAndJumpToTarget):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::linkBranches):
(JSC::DFG::SpeculativeJIT::compileStoreBarrier):
(JSC::DFG::SpeculativeJIT::writeBarrier):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::masqueradesAsUndefinedWatchpointIsStillValid):
(JSC::DFG::SpeculativeJIT::selectScratchGPR):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileBaseValueStoreBarrier):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::moveTrueTo):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileBaseValueStoreBarrier):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::moveTrueTo):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::emitStoreBarrier):

• heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):
(JSC::CodeBlockSet::dump):

• heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::markRoots):
(JSC::Heap::clearRememberedSet):
(JSC::Heap::updateObjectCounts):
(JSC::Heap::flushWriteBarrierBuffer):
(JSC::Heap::shouldDoFullCollection):
(JSC::Heap::addLogicallyEmptyWeakBlock):

• heap/HeapInlines.h:

(JSC::Heap::isWriteBarrierEnabled):
(JSC::Heap::writeBarrier):
(JSC::Heap::reportExtraMemoryAllocated):
(JSC::Heap::reportExtraMemoryVisited):

• heap/MarkedBlock.cpp:

(JSC::MarkedBlock::clearMarks):

• heap/MarkedSpace.cpp:

(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::visitWeakSets):

• heap/MarkedSpace.h:

(JSC::MarkedSpace::didAllocateInBlock):
(JSC::MarkedSpace::objectCount):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emitWriteBarrier):
(JSC::JIT::emitIdentifierCheck):
(JSC::JIT::privateCompilePutByVal):

• llint/LLIntOfflineAsmConfig.h:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:

Source/WebCore:

No new tests because no new behavior.

• bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonVM):

Source/WTF:

• wtf/Platform.h:

12:33 PM Changeset in webkit [190128] by sbarati@apple.com

• 3 edits in trunk/Source/JavaScriptCore

the toInt32 operation inside DFGSpeculativeJIT.cpp can't throw so we shouldn't emit an exceptionCheck after it.
​https://bugs.webkit.org/show_bug.cgi?id=149467

Reviewed by Mark Lam.

The callOperation for toInt32 won't store a call site index in the call frame.
Therefore, if this is the first callOperation in the current compilation,
and we emit an exception check inside a try block, we will hit an assertion
saying that we must have DFGCommonData::codeOrigins.size() be > 0 inside
DFGCommonData::lastCallSite(). Therefore, it is imperative that we don't
emit exception checks for callOperations that don't throw exceptions and
don't store a call site index in the call frame.

• dfg/DFGCommonData.cpp:

(JSC::DFG::CommonData::lastCallSite):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

12:28 PM Changeset in webkit [190127] by ap@apple.com

• 4 edits in trunk/Tools

Mavericks: Media tests start to time out after a few days of bot uptime
​https://bugs.webkit.org/show_bug.cgi?id=149468

Reviewed by Chris Dumez.

• Scripts/webkitpy/port/base.py:
• Scripts/webkitpy/port/driver.py:
• Scripts/webkitpy/port/mac.py:

12:15 PM Changeset in webkit [190126] by clopez@igalia.com

• 2 edits in trunk

[CMake] Allow to enable OpenMP support.
​https://bugs.webkit.org/show_bug.cgi?id=149457

Reviewed by Csaba Osztrogonác.

• Source/cmake/OptionsCommon.cmake: Add the option USE_OPENMP that

will enable the support for OpenMP. Currently this is only used as
an alternative implementation to native threads for the parallelization
of the SVG filters. But name the option with a generic name (USE_OPENMP)
as it could be also used to enable future features that depend on OpenMP.

11:46 AM Changeset in webkit [190125] by Sukolsak Sakshuwong

• 5 edits in trunk/Source/JavaScriptCore

Implement the conditional instruction in WebAssembly
​https://bugs.webkit.org/show_bug.cgi?id=149451

Reviewed by Geoffrey Garen.

This patch implements the conditional (ternary) instruction in WebAssembly.
This is basically "condition ? exp1 : exp2" in JavaScript.

The use of context.discard() in WASMFunctionParser::parseConditional()
is not ideal. We don't discard anything. We just use it to decrement the
stack top in the WebAssembly baseline JIT. When we optimize the JIT by
storing results directly into the destination like the JavaScript
baseline JIT, the code will look like this:

ContextExpression temp = context.newTemporary();
ContextExpression condition = parseExpressionI32(context);
context.jumpToTargetIf(Context::JumpCondition::Zero, condition, elseTarget);

parseExpression(context, temp, expressionType);
context.jumpToTarget(end);

context.linkTarget(elseTarget);
parseExpression(context, temp, expressionType);
context.linkTarget(end);

return temp;

which looks cleaner than using discard().

• tests/stress/wasm-control-flow.js:
• tests/stress/wasm/control-flow.wasm:
• wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseExpressionF32):
(JSC::WASMFunctionParser::parseExpressionF64):
(JSC::WASMFunctionParser::parseConditional):

• wasm/WASMFunctionParser.h:

11:45 AM Changeset in webkit [190124] by timothy_horton@apple.com

• 31 edits in trunk/Source

Make it more obvious when using an unaccelerated image buffer, and fix a few callers who do
​https://bugs.webkit.org/show_bug.cgi?id=149428

Reviewed by Simon Fraser and Darin Adler.

• platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::createCompatibleBuffer):

• platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::create):
Make the RenderingMode parameter to ImageBuffer::create non-optional.

• platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::renderingMode):

• platform/graphics/GraphicsTypes.h:

Add renderingMode() getter so that every caller doesn't need to do the conversion to RenderingMode.

• css/CSSFilterImageValue.cpp:

(WebCore::CSSFilterImageValue::image):

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::LRUImageBufferCache::imageBuffer):

• rendering/shapes/Shape.cpp:

(WebCore::Shape::createRasterShape):

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):

• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::putByteArray):
These five callers create unconditionally unaccelerated ImageBuffers which
should probably instead respect the acceleration bit from the context
that the ImageBuffer will eventually be painted into. Bugs have been filed.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::createCompositingBuffer):

• platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::drawPattern):
Adjust the argument order and remove defaults which are passed explicitly.

• page/FrameSnapshotting.cpp:

(WebCore::snapshotFrameRect):
Snapshots are (currently) meant to be taken without accelerated drawing.
Make this explicit.

• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::drawPattern):
Make use of createCompatibleBuffer. This caller was previously creating
an unconditionally unaccelerated context!

• platform/graphics/NamedImageGeneratedImage.cpp:

(WebCore::NamedImageGeneratedImage::drawPattern):
Remove a comment.

• platform/graphics/ShadowBlur.cpp:

(WebCore::ScratchBuffer::getScratchBuffer):
ShadowBlur is only used with unaccelerated contexts, so it's OK to hardcode Unaccelerated here.

• platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::createImageBufferResult):
Flip the order of the arguments.

(WebCore::FilterEffect::openCLImageToImageBuffer):
This caller was previously creating an unaccelerated buffer; instead, match the destination buffer.

• rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::allocateBackingStoreIfNeeded):
Adjust the argument order and remove defaults which are passed explicitly.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):
Get rid of the unneeded renderingMode local, and factor out retrieval of Frame.

• rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

• rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):
These two callers are unconditionally creating unaccelerated buffers,
and changing this to match the destination context seems to actually
break things. This needs further investigation.

• rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::createMaskAndSwapContextForTextGradient):
This caller was previously creating an unaccelerated buffer; instead, match the destination buffer.

• rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::buildPattern):
Make use of renderingMode().

• rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::createImageBuffer):
Adjust the argument order.

• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::nativeImageForCurrentFrame):

• WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::imageForCurrentSharingServicePickerItem):

• Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.cpp:

(WebKit::ThreadSafeCoordinatedSurface::create):

11:27 AM Changeset in webkit [190123] by Chris Dumez

• 3 edits
  2 adds in trunk

XMLHttpRequest properties should be on the prototype
​https://bugs.webkit.org/show_bug.cgi?id=149465

Reviewed by Darin Adler.

Source/WebCore:

Move most XMLHttpRequest properties to the prototype, as per the Web IDL
specification. This should be web-compatible now that properties on the
prototype are configurable after r190104.

The 'response' / 'responseText' properties are still incorrectly on the
instance because they are currently using a [CustomGetter] in our IDL
and the bindings generator currently does not move such properties to
the prototype.

Test:
fast/xmlhttprequest/xmlhttprequest-properties-prototype.html
js/dom/xhr-prototype-define-property.html

• bindings/scripts/CodeGeneratorJS.pm:

(InterfaceRequiresAttributesOnInstanceForCompatibility): Deleted.

LayoutTests:

Add layout test to check that XMLHttpRequest properties are on the
prototype and have the right properties (enumerable and configurable).

• fast/xmlhttprequest/xmlhttprequest-properties-prototype-expected.txt: Added.
• fast/xmlhttprequest/xmlhttprequest-properties-prototype.html: Added.

10:54 AM Changeset in webkit [190122] by n_wang@apple.com

• 2 edits in trunk/Tools

Unreviewed, add myself to the committers list.

• Scripts/webkitpy/common/config/contributors.json:

10:48 AM Changeset in webkit [190121] by akling@apple.com

• 2 edits in trunk/Source/WebKit2

[WK2][NetworkCache] New entry bodies remain in dirty memory after being written to disk.
<​https://webkit.org/b/149463>

Reviewed by Antti Koivisto.

Call msync(MS_ASYNC) on cache entry bodies after writing their data to a
memory-mapped file. This turns the previously dirty memory into clean memory,
reducing our effective footprint.

I previously believed this would happen automatically when the kernel finds
itself under memory pressure, around the same time as it starts dropping
volatile pages. Turns out that's not the case. Even under considerable pressure,
we never flush this memory to file. So let's take care of it ourselves.

If this ends up generating more IO activity than we're comfortable with on some
scenario, we can look at throttling.

• NetworkProcess/cache/NetworkCacheData.cpp:

(WebKit::NetworkCache::Data::mapToFile):

10:17 AM Changeset in webkit [190120] by Chris Dumez

• 72 edits
  134 deletes in trunk

Drop support for legacy EntityReference DOM Node type
​https://bugs.webkit.org/show_bug.cgi?id=149348

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline W3C DOM test now that more checks are passing.

• web-platform-tests/dom/historical-expected.txt:

Source/WebCore:

Drop support for legacy EntityReference DOM Node type.

EntityReference has been dropped from the DOM specification:

• ​https://dom.spec.whatwg.org/#dom-core-changes

EntityReference is not supported in Firefox:

• ​https://developer.mozilla.org/en-US/docs/Web/API/EntityReference
• ​https://developer.mozilla.org/en-US/docs/Web/API/NodeIterator.expandEntityReferences
• ​https://developer.mozilla.org/en-US/docs/Web/API/TreeWalker.expandEntityReferences

Chrome dropped support for EntityReference a while back (May 2013):

• EntityReference: ​https://code.google.com/p/chromium/issues/detail?id=226628
• NodeFilter / TreeWalker.expandEntityReferences:
  • ​https://groups.google.com/a/chromium.org/d/msg/blink-dev/-ZO3eja4maA/86T13XJwQpUJ
  • ​https://src.chromium.org/viewvc/blink?view=rev&revision=185771

IE also dropped support for EntityReference Nodes:
​https://msdn.microsoft.com/library/ff974819(v=vs.85).aspx (Remarks section)

No new tests, already covered by existing test.

• DerivedSources.cpp:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• bindings/gobject/WebKitDOMPrivate.cpp:

(WebKit::wrap): Deleted.

• bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline): Deleted.

• bindings/objc/DOM.mm:

(kitClass): Deleted.

• bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction): Skip webkit_dom_document_create_entity_reference until Carlos fixes it.

• dom/Attr.cpp:

(WebCore::Attr::childTypeAllowed):
(WebCore::Attr::childrenChanged): Deleted.

• dom/Attr.h:
• dom/ContainerNode.cpp:

(WebCore::checkAcceptChild): Deleted.
(WebCore::checkAcceptChildGuaranteedNodeTypes): Deleted.
(WebCore::ContainerNode::removeChild): Deleted.

• dom/Document.cpp:

(WebCore::Document::createEntityReference):
(WebCore::Document::createNodeIterator):
(WebCore::Document::createTreeWalker):
(WebCore::Document::createEditingTextNode): Deleted.
(WebCore::Document::importNode): Deleted.
(WebCore::Document::adoptNode): Deleted.
(WebCore::Document::scheduleForcedStyleRecalc): Deleted.
(WebCore::Document::scheduleStyleRecalc): Deleted.
(WebCore::Document::childTypeAllowed): Deleted.
(WebCore::Document::canAcceptChild): Deleted.

• dom/Document.h:
• dom/Document.idl:
• dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::childTypeAllowed): Deleted.

• dom/Element.cpp:

(WebCore::Element::childTypeAllowed): Deleted.

• dom/EntityReference.cpp:

(WebCore::EntityReference::EntityReference):

• dom/EntityReference.h:
• dom/EntityReference.idl:
• dom/Node.cpp:

(WebCore::Node::setNodeValue):
(WebCore::Node::dumpStatistics): Deleted.
(WebCore::Node::childNodes): Deleted.
(WebCore::Node::lastDescendant): Deleted.
(WebCore::Node::isDescendantOf): Deleted.
(WebCore::Node::textContent): Deleted.
(WebCore::Node::ancestorElement): Deleted.
(WebCore::hashPointer): Deleted.

• dom/Node.h:

(WebCore::Node::isDocumentTypeNode): Deleted.

• dom/NodeIterator.cpp:

(WebCore::NodeIterator::NodeIterator):

• dom/NodeIterator.h:

(WebCore::NodeIterator::create):

• dom/NodeIterator.idl:
• dom/Range.cpp:

(WebCore::Range::checkDeleteExtract):
(WebCore::lengthOfContentsInNode): Deleted.
(WebCore::Range::processContentsBetweenOffsets): Deleted.
(WebCore::Range::insertNode): Deleted.
(WebCore::Range::checkNodeWOffset): Deleted.
(WebCore::Range::checkNodeBA): Deleted.
(WebCore::Range::cloneRange): Deleted.
(WebCore::Range::selectNode): Deleted.
(WebCore::Range::selectNodeContents): Deleted.
(WebCore::Range::surroundContents): Deleted.
(WebCore::Range::shadowRoot): Deleted.
(WebCore::Range::pastLastNode): Deleted.
(WebCore::Range::absoluteBoundingBox): Deleted.
(WebCore::Range::absoluteTextRects): Deleted.

• dom/Range.h:
• dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::childTypeAllowed): Deleted.

• dom/Traversal.cpp:

(WebCore::NodeIteratorBase::NodeIteratorBase):
(WebCore::NodeIteratorBase::acceptNode): Deleted.

• dom/Traversal.h:

(WebCore::NodeIteratorBase::expandEntityReferences):

• dom/TreeWalker.cpp:

(WebCore::TreeWalker::TreeWalker):

• dom/TreeWalker.h:

(WebCore::TreeWalker::create):

• dom/TreeWalker.idl:
• editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendStartMarkup): Deleted.

• xml/XPathUtil.cpp:

(WebCore::XPath::isValidContextNode): Deleted.

Source/WebKit2:

Drop handling EntityReference Nodes.

• WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:

(WebKit::WKDOMNodeClass): Deleted.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::isAssistableElement):

LayoutTests:

Drop several outdated DOM compliance tests. Update / Rebaseline others.

9:49 AM Changeset in webkit [190119] by bshafiei@apple.com

• 5 edits in branches/safari-601-branch/Source

Versioning.

9:13 AM Changeset in webkit [190118] by Chris Dumez

• 3 edits in trunk/LayoutTests

Unreviewed, rebaseline several W3C html tests on iOS after r190106 and r190085.

• platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
• platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt:

9:13 AM Changeset in webkit [190117] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed 32-bit Yosemite build fix.

• platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:

(WebCore::WebAudioSourceProviderAVFObjC::provideInput):

9:11 AM Changeset in webkit [190116] by Chris Dumez

• 4 edits in trunk/LayoutTests

Unreviewed, rebaseline fast/table/rowindex.html after r190099.

• platform/efl/fast/table/rowindex-expected.txt:
• platform/gtk/fast/table/rowindex-expected.txt:
• platform/win/fast/table/rowindex-expected.txt:

7:31 AM Changeset in webkit [190115] by eric.carlson@apple.com

• 19 edits
  2 adds in trunk/Source/WebCore

[MediaStream Mac] implement WebAudioSourceProvider
​https://bugs.webkit.org/show_bug.cgi?id=149419

Reviewed by Darin Adler.

• Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::audioSourceProvider): New.

• Modules/mediastream/MediaStreamTrack.h:

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaStreamSource): Rewrite.

• Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode): We know the Vector

size, so reserve capacity.

• Modules/webaudio/MediaStreamAudioSource.cpp:

(WebCore::MediaStreamAudioSource::audioSourceProvider): Add.

• Modules/webaudio/MediaStreamAudioSource.h:

(WebCore::MediaStreamAudioSource::~MediaStreamAudioSource):
(WebCore::MediaStreamAudioSource::deviceId):
(WebCore::MediaStreamAudioSource::setDeviceId):
(WebCore::MediaStreamAudioSource::useIDForTrackID): Deleted.

• Modules/webaudio/MediaStreamAudioSourceNode.cpp:

(WebCore::MediaStreamAudioSourceNode::create): Context and track can't be null so take references.
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode): Ditto.
(WebCore::MediaStreamAudioSourceNode::~MediaStreamAudioSourceNode): Clear provider client.
(WebCore::MediaStreamAudioSourceNode::setFormat): Create a resampler when necessary.
(WebCore::MediaStreamAudioSourceNode::process): Process.
(WebCore::MediaStreamAudioSourceNode::reset): Deleted.

• Modules/webaudio/MediaStreamAudioSourceNode.h:

(WebCore::MediaStreamAudioSourceNode::mediaStream):
(WebCore::MediaStreamAudioSourceNode::audioSourceProvider): Deleted.

• WebCore.xcodeproj/project.pbxproj: Add WebAudioSourceProviderAVFObjC.cpp/h.

• platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::audioSourceProvider): New, passthrough to source.

• platform/mediastream/MediaStreamTrackPrivate.h:
• platform/mediastream/RealtimeMediaSource.h:

(WebCore::RealtimeMediaSource::audioSourceProvider):

• platform/mediastream/mac/AVAudioCaptureSource.h:
• platform/mediastream/mac/AVAudioCaptureSource.mm:

(WebCore::AVAudioCaptureSource::audioSourceProvider): New.

• platform/mediastream/mac/AVCaptureDeviceManager.mm:
• platform/mediastream/mac/AVMediaCaptureSource.h:
• platform/mediastream/mac/AVMediaCaptureSource.mm:

(WebCore::AVMediaCaptureSource::audioSourceProvider): Assert, this shouldn't be reachable.

• platform/mediastream/mac/WebAudioSourceProviderAVFObjC.h: Added.
• platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm: Added.

(WebCore::WebAudioSourceProviderAVFObjC::create):
(WebCore::WebAudioSourceProviderAVFObjC::WebAudioSourceProviderAVFObjC):
(WebCore::WebAudioSourceProviderAVFObjC::~WebAudioSourceProviderAVFObjC):
(WebCore::WebAudioSourceProviderAVFObjC::startProducingData):
(WebCore::WebAudioSourceProviderAVFObjC::stopProducingData):
(WebCore::WebAudioSourceProviderAVFObjC::provideInput):
(WebCore::WebAudioSourceProviderAVFObjC::setClient):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::WebAudioSourceProviderAVFObjC::prepare):
(WebCore::WebAudioSourceProviderAVFObjC::unprepare):
(WebCore::WebAudioSourceProviderAVFObjC::process):

6:59 AM Changeset in webkit [190114] by commit-queue@webkit.org

• 6 edits in trunk

Source/WebCore:
CurrentTime on mediaController is set as 0 when playback is completed.
​https://bugs.webkit.org/show_bug.cgi?id=149154

Patch by sangdeug.kim <​sangdeug.kim@samsung.com> on 2015-09-22
Reviewed by Eric Carlson.

Test : media/media-controller-time-clamp.html

• html/MediaController.cpp:

(MediaController::setCurrentTime):
(MediaController::updatePlaybackState):

• html/MediaController.h:

LayoutTests:
Add test for checking currentTime of mediacontroller when playback is completed.
​https://bugs.webkit.org/show_bug.cgi?id=149154

Patch by sangdeug.kim <​sangdeug.kim@samsung.com> on 2015-09-22
Reviewed by Eric Carlson.

• media/media-controller-time-clamp-expected.txt:
• media/media-controller-time-clamp.html:

5:21 AM Changeset in webkit [190113] by commit-queue@webkit.org

• 74 edits in trunk/Source

Unreviewed, rolling out r189616.
​https://bugs.webkit.org/show_bug.cgi?id=149456

suspected cause of multiple regressions (Requested by kling on
#webkit).

Reverted changeset:

"[JSC] Weak should only accept cell pointees."
​https://bugs.webkit.org/show_bug.cgi?id=148955
​http://trac.webkit.org/changeset/189616

3:06 AM Changeset in webkit [190112] by Csaba Osztrogonác

• 3 edits in trunk/Source/WebCore

Fix the all-in-one build with GCC
​https://bugs.webkit.org/show_bug.cgi?id=148428

Reviewed by Darin Adler.

Removed Source/WebCore/inspector/InspectorIndexedDBAgent.cpp from the all-in-one build.

• WebCore.vcxproj/WebCore.vcxproj:
• inspector/InspectorAllInOne.cpp:

2:32 AM Changeset in webkit [190111] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

Fix warnings in IDLParser.pm
​https://bugs.webkit.org/show_bug.cgi?id=149406

Reviewed by Alex Christensen.

• bindings/scripts/IDLParser.pm:

(typeHasNullableSuffix):
(typeRemoveNullableSuffix):

1:26 AM Changeset in webkit [190110] by sbarati@apple.com

• 7 edits in trunk

Web Inspector: update Esprima to latest version
​https://bugs.webkit.org/show_bug.cgi?id=148960

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

Esprima version 2.6 further supports ES6. We're
updating to it so we can support more ES6 features
in our script syntax tree.

• UserInterface/External/Esprima/LICENSE:
• UserInterface/External/Esprima/esprima.js:
• UserInterface/Models/ScriptSyntaxTree.js:

(WebInspector.ScriptSyntaxTree.prototype._gatherIdentifiersInDeclaration.gatherIdentifiers):
(WebInspector.ScriptSyntaxTree.prototype._gatherIdentifiersInDeclaration):
(WebInspector.ScriptSyntaxTree.prototype._recurse):
(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
(WebInspector.ScriptSyntaxTree):

LayoutTests:

• inspector/model/parse-script-syntax-tree-expected.txt:
• inspector/model/parse-script-syntax-tree.html:

1:17 AM Changeset in webkit [190109] by rniwa@webkit.org

• 11 edits in trunk

invalidateSlotAssignments should trigger style recalc
​https://bugs.webkit.org/show_bug.cgi?id=149447

Reviewed by Antti Koivisto.

Source/WebCore:

Invalidate the render tree of a shadow host when a new child is inserted, an existing child is removed,
or slot attribute of a child is modified.

No new tests. Covered by existing tests added in r190101.

• dom/Element.cpp:

(WebCore::Element::childrenChanged): Call invalidateSlotAssignments or invalidateDefaultSlotAssignments
depending on the types of children being inserted or removed since text nodes can only be assigned into
a default slot.

• dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::invalidateSlotAssignments):
(WebCore::ShadowRoot::invalidateDefaultSlotAssignments): Added.

• dom/ShadowRoot.h:
• dom/SlotAssignment.cpp:

(WebCore::SlotAssignment::invalidate): Reconstruct the render tree for the whole host. We can optimize
in the future by only invalidating active slot elements instead.
(WebCore::SlotAssignment::invalidateDefaultSlot): Added.

• dom/SlotAssignment.h:

LayoutTests:

Removed failing expectations from newly passing tests.

Also added test cases for inserting and removing text nodes, and modified the style recalc tests
to force layout between each DOM change to test case separately.

• fast/shadow-dom/shadow-layout-after-host-child-changes.html:
• fast/shadow-dom/shadow-layout-after-inserting-or-removing-host-child.html:
• fast/shadow-dom/shadow-layout-after-slot-changes.html:
• platform/mac/TestExpectations:

12:35 AM Changeset in webkit [190108] by sbarati@apple.com

• 4 edits in trunk/Source/JavaScriptCore

Web Inspector: Basic Block Annotations and Type Profiler annotations wrong for script with "class" with default constructor
​https://bugs.webkit.org/show_bug.cgi?id=149248

Reviewed by Mark Lam.

We keep track of which functions have and have not
executed so we can show visually, inside the inspector,
which functions have and have not executed. With a default
constructor, our parser parses code that isn't in the actual
JavaScript source code of the user. Our parser would then
give us a range of starting at "1" to "1 + default constructor length"
as being the text range of a function. But, this would then pollute
actual source code that was at these ranges.

Therefore, we should treat these default constructor source
codes as having "invalid" ranges. We use [UINT_MAX, UINT_MAX]
as the invalid range. This range has the effect of not polluting
valid ranges inside the source code.

• bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::unlinkedCodeBlockFor):
(JSC::UnlinkedFunctionExecutable::setInvalidTypeProfilingOffsets):

• bytecode/UnlinkedFunctionExecutable.h:
• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitNewDefaultConstructor):

12:29 AM Changeset in webkit [190107] by ryuan.choi@navercorp.com

• 2 edits in trunk

[EFL] Build break when DEVELOPER_MODE is OFF
​https://bugs.webkit.org/show_bug.cgi?id=149448

Reviewed by Gyuyoung Kim.

Since r187191, DatabaseProcessMainUnix is missing in symbol filter.

• Source/cmake/eflsymbols.filter: