Timeline
Sep 25, 2015:
- 11:17 PM Changeset in webkit [190264] by
-
- 2 edits in trunk/LayoutTests
Skip newly added js/regress/getter-richards-try-catch.html on debug builds,
because it times out.
- platform/mac/TestExpectations:
- 7:29 PM Changeset in webkit [190263] by
-
- 12 edits1 delete in trunk/Tools
[Mac] USE_INTERNAL_SDK is used undefined in tools projects
https://bugs.webkit.org/show_bug.cgi?id=149571
Reviewed by Dan Bernstein.
Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig).
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- LayoutTestRelay/Configurations/Base.xcconfig:
- MiniBrowser/Configurations/Base.xcconfig:
- MiniBrowser/Configurations/DebugRelease.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/DebugRelease.xcconfig:
- WebEditingTester/Configurations/Base.xcconfig:
- WebEditingTester/Configurations/DebugRelease.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- WebKitTestRunner/iOS.xcconfig: Removed.
- 7:23 PM Changeset in webkit [190262] by
-
- 28 edits in trunk
Clean up user media request internal API
https://bugs.webkit.org/show_bug.cgi?id=149527
Reviewed by Tim Horton.
Source/WebCore:
No new tests, no functional change.
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::constraintsValidated): Use track persistent ID to create vectors
as that is what the platform code needs to map to a capture device.
(WebCore::UserMediaRequest::userMediaAccessGranted): m_chosenXXDeviceUID -> m_XXDeviceUIDAllowed.
Use the device IDs to create the MediaStream. Switch audio/video parameter order.
(WebCore::UserMediaRequest::didCreateStream): Don't assume constraints are valid.
- Modules/mediastream/UserMediaRequest.h:
(WebCore::UserMediaRequest::videoDeviceUIDs):
(WebCore::UserMediaRequest::audioDeviceUIDs):
(WebCore::UserMediaRequest::allowedVideoDeviceUID):
(WebCore::UserMediaRequest::allowedAudioDeviceUID):
(WebCore::UserMediaRequest::requiresAudio): Deleted.
(WebCore::UserMediaRequest::requiresVideo): Deleted.
(WebCore::UserMediaRequest::firstVideoDeviceUID): Deleted.
(WebCore::UserMediaRequest::firstAudioDeviceUID): Deleted.
- platform/mediastream/mac/AVMediaCaptureSource.mm:
(WebCore::AVMediaCaptureSource::AVMediaCaptureSource): Call setPersistentId.
Source/WebKit/mac:
- WebCoreSupport/WebUserMediaClient.mm:
(WebUserMediaClient::cancelRequest): Put UserMediaRequestsMap in a local instead or calling
userMediaRequestsMap() three times.
(-[WebUserMediaPolicyListener allow]): Get rid of unneeded local variables.
(-[WebUserMediaPolicyListener allowDeviceWithVideoUID]): Deleted, unused.
Source/WebKit2:
- UIProcess/API/C/WKUserMediaPermissionRequest.cpp:
(WKUserMediaPermissionRequestVideoDeviceUIDs): New, renamed from WKUserMediaPermissionRequestDeviceNamesVideo.
(WKUserMediaPermissionRequestAudioDeviceUIDs): New, renamed from WKUserMediaPermissionRequestDeviceNamesAudio.
(WKUserMediaPermissionRequestAllowBest): Deleted.
(WKUserMediaPermissionRequestDeviceNamesVideo): Deleted.
(WKUserMediaPermissionRequestDeviceNamesAudio): Deleted.
(WKUserMediaPermissionRequestFirstVideoDeviceUID): Deleted.
(WKUserMediaPermissionRequestFirstAudioDeviceUID): Deleted.
- UIProcess/API/C/WKUserMediaPermissionRequest.h:
- UIProcess/API/gtk/WebKitUserMediaPermissionRequest.cpp:
(webkitUserMediaPermissionRequestAllow): Update for UserMediaRequest API change.
- UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::createRequest): Get rid of the bool parameters.
Switch audio/video parameter order to be consistent with everywhere else.
(WebKit::UserMediaPermissionRequestManagerProxy::didReceiveUserMediaPermissionDecision): Ditto.
- UIProcess/UserMediaPermissionRequestManagerProxy.h:
- UIProcess/UserMediaPermissionRequestProxy.cpp:
(WebKit::UserMediaPermissionRequestProxy::UserMediaPermissionRequestProxy): Get rid of the bool parameters.
Switch audio/video parameter order to be consistent with everywhere else.
(WebKit::UserMediaPermissionRequestProxy::allow): Switch audio/video parameter order.
(WebKit::UserMediaPermissionRequestProxy::getDeviceNameForUID): Deleted.
- UIProcess/UserMediaPermissionRequestProxy.h:
(WebKit::UserMediaPermissionRequestProxy::create):
(WebKit::UserMediaPermissionRequestProxy::videoDeviceUIDs):
(WebKit::UserMediaPermissionRequestProxy::audioDeviceUIDs):
(WebKit::UserMediaPermissionRequestProxy::firstAudioDeviceUID):
(WebKit::UserMediaPermissionRequestProxy::requiresAudio): Deleted.
(WebKit::UserMediaPermissionRequestProxy::requiresVideo): Deleted.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestUserMediaPermissionForFrame): Get rid of the bool parameters.
Switch audio/video parameter order to be consistent with everywhere else.
- UIProcess/WebPageProxy.h: Ditto.
- UIProcess/WebPageProxy.messages.in: Ditto.
- WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:
(WebKit::UserMediaPermissionRequestManager::startRequest): Get rid of bool params, the device
vectors have the same information.
(WebKit::UserMediaPermissionRequestManager::didReceiveUserMediaPermissionDecision): Switch audio/video
parameter order to be consistent with everywhere else. deviceUIDVideo -> videoDeviceUID,
deviceUIDAudio -> audioDeviceUID.
- WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveUserMediaPermissionDecision): Switch audio/video parameter order.
- WebProcess/WebPage/WebPage.h:
Tools:
- TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
(TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
- 7:10 PM Changeset in webkit [190261] by
-
- 3 edits3 adds in trunk
DFG should use PhantomLocal instead of Flush as liveness preservation mechanism in LiveCatchVariablesPreservationPhase
https://bugs.webkit.org/show_bug.cgi?id=149575
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
LiveCatchVariablesPreservationPhase is no longer forcing all live-at-catch
variables to be flushed to the stack. They are now kept alive to OSR exit
through PhantomLocal. This gives us a speed improvement for try-catch
programs (especially those that don't throw errors very often) because
we can keep locals in registers instead of forcing them onto the stack.
- dfg/DFGLiveCatchVariablePreservationPhase.cpp:
(JSC::DFG::LiveCatchVariablePreservationPhase::LiveCatchVariablePreservationPhase):
(JSC::DFG::LiveCatchVariablePreservationPhase::handleBlock):
(JSC::DFG::performLiveCatchVariablePreservationPhase):
(JSC::DFG::FlushLiveCatchVariablesInsertionPhase::FlushLiveCatchVariablesInsertionPhase): Deleted.
(JSC::DFG::FlushLiveCatchVariablesInsertionPhase::handleBlock): Deleted.
LayoutTests:
- js/regress/getter-richards-try-catch-expected.txt: Added.
- js/regress/getter-richards-try-catch.html: Added.
- js/regress/script-tests/getter-richards-try-catch.js: Added.
(randomException):
(runRichards):
(Scheduler):
(Scheduler.prototype.addIdleTask):
(Scheduler.prototype.addWorkerTask):
(Scheduler.prototype.addHandlerTask):
(Scheduler.prototype.addDeviceTask):
(Scheduler.prototype.addRunningTask):
(Scheduler.prototype.addTask):
(Scheduler.prototype.schedule):
(Scheduler.prototype.release):
(Scheduler.prototype.holdCurrent):
(Scheduler.prototype.suspendCurrent):
(Scheduler.prototype.queue):
(TaskControlBlock):
(TaskControlBlock.prototype.setRunning):
(TaskControlBlock.prototype.markAsNotHeld):
(TaskControlBlock.prototype.markAsHeld):
(TaskControlBlock.prototype.isHeldOrSuspended):
(TaskControlBlock.prototype.markAsSuspended):
(TaskControlBlock.prototype.markAsRunnable):
(TaskControlBlock.prototype.run):
(TaskControlBlock.prototype.checkPriorityAdd):
(TaskControlBlock.prototype.toString):
(IdleTask):
(IdleTask.prototype.run):
(IdleTask.prototype.toString):
(DeviceTask):
(DeviceTask.prototype.run):
(DeviceTask.prototype.toString):
(WorkerTask):
(WorkerTask.prototype.run):
(WorkerTask.prototype.toString):
(HandlerTask):
(HandlerTask.prototype.run):
(HandlerTask.prototype.toString):
(Packet):
(Packet.prototype.addTo):
(Packet.prototype.toString):
- 5:17 PM Changeset in webkit [190260] by
-
- 15 edits12 adds in trunk
[iOS WK2] Add viewport tests and fix runUIScript() timing issues
https://bugs.webkit.org/show_bug.cgi?id=149577
Reviewed by Tim Horton.
Source/WebKit2:
When calling testRunner.runUIScript() from a page load event, the script could run
in the UI process before the current remote layer tree transaction had been handled
there. This meant that runUIScript() could query state which was about to change.
Fix by delaying the execution of the UI script until a layer tree transaction has
been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
This is done using a new C SPI function WKPageCallAfterNextPresentationUpdate(),
which is mirrored in the Obj-C SPI as -_doAfterNextPresentationUpdate:.
Move WKWebView SPI which is testing-related into a WKTesting category. It is expected
that this will grow significantly.
- UIProcess/API/C/WKPage.cpp:
(WKPageCallAfterNextPresentationUpdate):
- UIProcess/API/C/WKPagePrivate.h:
- UIProcess/API/Cocoa/WKWebView.mm:
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::callAfterNextPresentationUpdate):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::dispatchAfterEnsuringDrawing):
Tools:
When calling testRunner.runUIScript() from a page load event, the script could run
in the UI process before the current remote layer tree transaction had been handled
there. This meant that runUIScript() could query state which was about to change.
Fix by delaying the execution of the UI script until a layer tree transaction has
been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
- WebKitTestRunner/TestInvocation.h:
LayoutTests:
New viewport tests which read the scale etc. in the UI process.
- TestExpectations:
- fast/viewport/ios/resources/viewport-test-utils.js: Added.
(getUIScript):
(tableFromJSON):
(getViewport):
(runTest):
- fast/viewport/ios/width-is-device-width-expected.txt: Added.
- fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt: Added.
- fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall.html: Added.
- fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden.html: Added.
- fast/viewport/ios/width-is-device-width-overflowing-expected.txt: Added.
- fast/viewport/ios/width-is-device-width-overflowing-no-shrink-to-fit-expected.txt: Added.
- fast/viewport/ios/width-is-device-width-overflowing-no-shrink-to-fit.html: Added.
- fast/viewport/ios/width-is-device-width-overflowing.html: Added.
- fast/viewport/ios/width-is-device-width.html: Added.
- platform/ios-simulator-wk2/TestExpectations:
- 5:13 PM Changeset in webkit [190259] by
-
- 12 edits in branches/safari-601-branch/Source
Merge r190235. rdar://problem/22852382
2015-09-24 Brent Fulgham <Brent Fulgham>
[Win] Support composited content in WebView render-to-context methods
https://bugs.webkit.org/show_bug.cgi?id=149516
<rdar://problem/22635080>
Reviewed by Simon Fraser.
Source/WebCore:
Extend the CACFLayerTreeHost implementation to render into a passed
device context when requested. When no context is provided (the default
case) paint as normal.
Will be tested by existing compositing tests in a future bug. DumpRenderTree
has to be extended to do this painting properly.
- platform/graphics/ca/win/CACFLayerTreeHost.cpp: (WebCore::CACFLayerTreeHost::paint): Accept an optional HDC argument, and pass it to the render method.
- platform/graphics/ca/win/CACFLayerTreeHost.h:
- platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp: Add missing SOFT_LINK command for the WKCACFViewDrawIntoDC. (WebCore::LegacyCACFLayerTreeHost::paint): Accept optional HDC argument and pass it to the parent class. (WebCore::LegacyCACFLayerTreeHost::render): Accept new optional HDC argument. If provided, call WKCACFViewDrawIntoDC. Otherwise, call WKCACFVIewDraw.
- platform/graphics/ca/win/LegacyCACFLayerTreeHost.h:
- platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Add missing SOFT_LINK command for the WKCACFViewDrawIntoDC. (WebCore::WKCACFViewLayerTreeHost::paint): Accept optional HDC argument and pass it to the parent class. (WebCore::WKCACFViewLayerTreeHost::render): Accept new optional HDC argument. If provided, call WKCACFViewDrawIntoDC. Otherwise, call WKCACFVIewDraw.
- platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:
Source/WebKit/win:
- WebView.cpp: (WebView::paint): Call the new 'paintCompositedContentToHDC' method. If it handles the pain, return. (WebView::paintCompositedContentToHDC): New method to share code with other paint methods. (WebView::paintDocumentRectToContext): Call new 'paintCompositedContentToHDC' to handle any composited layers. Otherwise, use slow drawing path. (WebView::paintScrollViewRectToContextAtPoint): Ditto. (WebView::unused5): Work around a linker issue that may appear when building test infrastructure on this branch.
- WebView.h:
- 4:52 PM Changeset in webkit [190258] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTLOSRExitCompiler incorrectly excludes FPR registers in callee saves loop
https://bugs.webkit.org/show_bug.cgi?id=149540
Reviewed by Saam Barati.
Eliminated the incorrect check that callee saves registers are only GPRs.
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- 3:36 PM Changeset in webkit [190257] by
-
- 17 edits in trunk
[Mac] Media tests start to time out after a few days of bot uptime
https://bugs.webkit.org/show_bug.cgi?id=149468
Reviewed by Darin Adler.
Source/WebKit2:
Make the fix work with WebKit2, and avoid touching user's media cache for WebKit1.
When UI process is not sandboxed, inherit DIRHELPER_USER_DIR_SUFFIX from it.
This means that during testing, WebContent uses a temporary directory of the form
/private/var/folders/.../T/WebKitTestRunner-VKjmz0/com.apple.WebKit.WebContent.Development,
instead of /private/var/folders/.../T/com.apple.WebKit.WebContent.Development+WebKitTestRunner.
WebKit1 now also better respects a temporary directory of the form
/private/var/folders/.../T/DumpRenderTree-VKjmz0, instead of the default, which
makes CoreMedia put its cache inside it.
As a result, almost everything is isolated per testing process, and deleted at the end.
Same with cache directories. The only outliers that I know of are plug-in directories,
which are per-process, but are not under the testing root, and thus aren't deleted.
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::initializeSandbox):
- Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::fromConnection):
(WebKit::ChildProcessProxy::getLaunchOptions):
(WebKit::ChildProcessProxy::connect):
- Shared/ChildProcessProxy.h:
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceInitializerDelegate::getExtraInitializationData):
- Shared/SandboxInitializationParameters.h:
(WebKit::SandboxInitializationParameters::sandboxProfile):
(WebKit::SandboxInitializationParameters::setUserDirectorySuffix):
(WebKit::SandboxInitializationParameters::userDirectorySuffix):
(WebKit::SandboxInitializationParameters::setSystemDirectorySuffix): Deleted.
(WebKit::SandboxInitializationParameters::systemDirectorySuffix): Deleted.
- Shared/ios/ChildProcessIOS.mm:
(WebKit::ChildProcess::initializeSandbox):
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::initializeSandbox):
- UIProcess/Databases/DatabaseProcessProxy.cpp:
(WebKit::DatabaseProcessProxy::getLaunchOptions):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::getLaunchOptions):
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::getLaunchOptions):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getLaunchOptions):
Tools:
Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
all temporary and cache files go to a custom location.
- Scripts/webkitpy/port/base.py:
- Scripts/webkitpy/port/driver.py:
- Scripts/webkitpy/port/mac.py:
- Scripts/webkitpy/port/win.py:
(WinPort._driver_tempdir_for_environment): Deleted unused function.
- 3:06 PM Changeset in webkit [190256] by
-
- 12 edits2 adds in trunk
Implement scoped styling for shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=149230
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: fast/shadow-dom/css-scoping-shadow-with-rules-no-style-leak.html
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRules):
Only use special path here for user agent shadow trees.
- dom/AuthorStyleSheets.cpp:
(WebCore::AuthorStyleSheets::AuthorStyleSheets):
(WebCore::AuthorStyleSheets::removePendingSheet):
(WebCore::AuthorStyleSheets::updateActiveStyleSheets):
Basic support for ShadowRoot scoped stylesheets.
- dom/AuthorStyleSheets.h:
(WebCore::AuthorStyleSheets::activeStyleSheets):
- dom/InlineStyleSheetOwner.cpp:
(WebCore::InlineStyleSheetOwner::~InlineStyleSheetOwner):
(WebCore::authorStyleSheetsForElement):
(WebCore::InlineStyleSheetOwner::insertedIntoDocument):
(WebCore::InlineStyleSheetOwner::removedFromDocument):
(WebCore::InlineStyleSheetOwner::clearDocumentData):
(WebCore::InlineStyleSheetOwner::childrenChanged):
(WebCore::InlineStyleSheetOwner::createSheet):
(WebCore::InlineStyleSheetOwner::isLoading):
(WebCore::InlineStyleSheetOwner::sheetLoaded):
(WebCore::InlineStyleSheetOwner::startLoadingDynamicSheet):
Basic support for ShadowRoot scoped inline stylesheets.
- dom/InlineStyleSheetOwner.h:
(WebCore::InlineStyleSheetOwner::sheet):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::styleResolver):
Create and initialize ShadowRoot scoped style resolver.
(WebCore::ShadowRoot::resetStyleResolver):
(WebCore::ShadowRoot::authorStyleSheets):
Collection of author stylesheets in the shadow tree.
(WebCore::ShadowRoot::updateStyle):
Trigger style recalc when stylesheets change.
(WebCore::ShadowRoot::cloneNode):
- dom/ShadowRoot.h:
(WebCore::ShadowRoot::resetStyleInheritance):
- html/HTMLStyleElement.h:
- svg/SVGStyleElement.h:
LayoutTests:
- fast/shadow-dom/css-scoping-shadow-with-rules-no-style-leak-expected.html: Added.
- fast/shadow-dom/css-scoping-shadow-with-rules-no-style-leak.html: Added.
Add a test that verifies that shadow DOM style doesn't affect normal DOM.
- platform/mac/TestExpectations:
Enable fast/shadow-dom/css-scoping-shadow-with-rules.html
- 3:04 PM Changeset in webkit [190255] by
-
- 12 edits in trunk
Clean up CMake build on Mac
https://bugs.webkit.org/show_bug.cgi?id=149573
Reviewed by Chris Dumez.
.:
- Source/cmake/OptionsMac.cmake:
Source/WebCore:
- CMakeLists.txt:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- PlatformMac.cmake:
- platform/graphics/DisplayRefreshMonitor.cpp:
Source/WebKit:
- PlatformMac.cmake:
Source/WTF:
- wtf/PlatformMac.cmake:
- 3:01 PM Changeset in webkit [190254] by
-
- 6 edits2 adds in trunk
Scrolling a overflow: scroll region makes find overlay holes stick to the edge of the region
https://bugs.webkit.org/show_bug.cgi?id=149572
<rdar://problem/13093602>
Reviewed by Simon Fraser.
Test: fast/text/mark-matches-overflow-clip.html
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintTextMatchMarker):
Clip the rendered marker rect to the overflow rect.
- testing/Internals.cpp:
(WebCore::Internals::dumpMarkerRectsForNode):
- testing/Internals.h:
- testing/Internals.idl:
Add a internals function to dump the rendered rects for a marker.
- fast/text/mark-matches-overflow-clip-expected.txt: Added.
- fast/text/mark-matches-overflow-clip.html: Added.
Add a test ensuring that a find match that is clipped out by overflow
ends up with a clipped rendered rect.
- 2:50 PM Changeset in webkit [190253] by
-
- 9 edits2 copies2 adds in trunk
[Win] Switch to CMake
https://bugs.webkit.org/show_bug.cgi?id=148111
Reviewed by Brent Fulgham.
.:
- Source/cmake/WinTools.make: Added.
- Source/cmake/tools: Added.
- Source/cmake/tools/scripts: Copied from WebKitLibraries/win/tools/scripts.
- Source/cmake/tools/scripts/auto-version.pl: Copied from WebKitLibraries/win/tools/scripts/auto-version.pl.
Source/JavaScriptCore:
- JavaScriptCore.vcxproj/JavaScriptCore.proj:
Source/WebCore:
- WebCore.vcxproj/WebCore.proj:
Source/WebKit:
- WebKit.vcxproj/WebKit.proj:
Source/WTF:
- WTF.vcxproj/WTF.proj:
- 2:35 PM Changeset in webkit [190252] by
-
- 4 edits in trunk/Source
Clicking on a data detected item inside a form control always pops up a map
on force touch trackpad
https://bugs.webkit.org/show_bug.cgi?id=149559
-and corresponding-
rdar://problem/22826796
Reviewed by Tim Horton.
Source/WebCore:
The real bug here appears to be a bug in Lookup, but we can work around it.
For normal text, we call directly into Data Detectors for map results, and
that works fine. For text within form controls, we did not properly extract
the text for DD, so we sent it to Lookup instead, and Lookup has this bug
where they will pop open the map right away. If we properly extract the text
for form controls, then we can work around this bug.
- editing/mac/DataDetection.mm:
(WebCore::detectItemAtPositionWithRange):
(WebCore::DataDetection::detectItemAroundHitTestResult):
Source/WebKit2:
Look for Data Detected text for text nodes and HitTestResults that are over
text inside form controls.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performImmediateActionHitTestAtLocation):
- 2:30 PM Changeset in webkit [190251] by
-
- 4 edits in trunk
Prepare internal AppleWin build for CMake
https://bugs.webkit.org/show_bug.cgi?id=149570
Reviewed by Brent Fulgham.
.:
- Source/PlatformWin.cmake:
Include internal CMake files if they exist.
WebKitLibraries:
- win/tools/scripts/auto-version.pl:
Use the WEBKIT_LIBRARIES environment variable if it exists.
- 12:46 PM Changeset in webkit [190250] by
-
- 31 edits in trunk/Source/WebCore
PassRefPtr<> to RefPtr<> conversion in legacy IndexedDB code.
https://bugs.webkit.org/show_bug.cgi?id=149558
Reviewed by Beth Dakin.
No new tests (No behavior change.)
This patch does not attempt to completely remove all PassRefPtr usage inside legacy IDB.
It just switches over all PassRefPtr usage at the top level IDB interfaces that
modern IDB is implementing.
The rest of the usage inside the legacy implementation can be dealt with later via
git rm.
- Modules/indexeddb/IDBAny.h:
- Modules/indexeddb/IDBCursor.h:
- Modules/indexeddb/IDBDatabase.h:
- Modules/indexeddb/IDBDatabaseError.h:
- Modules/indexeddb/IDBFactory.h:
- Modules/indexeddb/IDBIndex.h:
- Modules/indexeddb/IDBObjectStore.h:
- Modules/indexeddb/IDBRequest.h:
- Modules/indexeddb/IDBTransaction.h:
- Modules/indexeddb/client/IDBFactoryImpl.cpp:
(WebCore::IDBClient::IDBFactory::getDatabaseNames):
(WebCore::IDBClient::IDBFactory::open):
(WebCore::IDBClient::IDBFactory::deleteDatabase):
- Modules/indexeddb/client/IDBFactoryImpl.h:
- Modules/indexeddb/client/IDBRequestImpl.cpp:
(WebCore::IDBClient::IDBRequest::result):
(WebCore::IDBClient::IDBRequest::error):
(WebCore::IDBClient::IDBRequest::source):
(WebCore::IDBClient::IDBRequest::transaction):
- Modules/indexeddb/client/IDBRequestImpl.h:
- Modules/indexeddb/legacy/LegacyAny.cpp:
(WebCore::LegacyAny::createInvalid):
(WebCore::LegacyAny::createNull):
(WebCore::LegacyAny::createString):
(WebCore::LegacyAny::domStringList):
(WebCore::LegacyAny::idbCursor):
(WebCore::LegacyAny::idbCursorWithValue):
(WebCore::LegacyAny::idbDatabase):
(WebCore::LegacyAny::idbFactory):
(WebCore::LegacyAny::idbIndex):
(WebCore::LegacyAny::idbObjectStore):
(WebCore::LegacyAny::idbTransaction):
(WebCore::LegacyAny::LegacyAny):
- Modules/indexeddb/legacy/LegacyAny.h:
(WebCore::LegacyAny::create):
- Modules/indexeddb/legacy/LegacyCursor.cpp:
(WebCore::LegacyCursor::update):
(WebCore::LegacyCursor::deleteFunction):
- Modules/indexeddb/legacy/LegacyCursor.h:
- Modules/indexeddb/legacy/LegacyDatabase.cpp:
(WebCore::LegacyDatabase::objectStoreNames):
(WebCore::LegacyDatabase::createObjectStore):
(WebCore::LegacyDatabase::transaction):
- Modules/indexeddb/legacy/LegacyDatabase.h:
- Modules/indexeddb/legacy/LegacyFactory.cpp:
(WebCore::LegacyFactory::getDatabaseNames):
(WebCore::LegacyFactory::open):
(WebCore::LegacyFactory::deleteDatabase):
- Modules/indexeddb/legacy/LegacyFactory.h:
- Modules/indexeddb/legacy/LegacyIndex.cpp:
(WebCore::LegacyIndex::openCursor):
(WebCore::LegacyIndex::count):
(WebCore::LegacyIndex::openKeyCursor):
(WebCore::LegacyIndex::get):
(WebCore::LegacyIndex::getKey):
- Modules/indexeddb/legacy/LegacyIndex.h:
(WebCore::LegacyIndex::legacyObjectStore):
- Modules/indexeddb/legacy/LegacyObjectStore.cpp:
(WebCore::LegacyObjectStore::indexNames):
(WebCore::LegacyObjectStore::get):
(WebCore::LegacyObjectStore::add):
(WebCore::LegacyObjectStore::put):
(WebCore::LegacyObjectStore::deleteFunction):
(WebCore::LegacyObjectStore::clear):
(WebCore::LegacyObjectStore::createIndex):
(WebCore::LegacyObjectStore::index):
(WebCore::LegacyObjectStore::openCursor):
(WebCore::LegacyObjectStore::count):
- Modules/indexeddb/legacy/LegacyObjectStore.h:
(WebCore::LegacyObjectStore::keyPathAny):
(WebCore::LegacyObjectStore::transaction):
(WebCore::LegacyObjectStore::createIndex):
(WebCore::LegacyObjectStore::count):
- Modules/indexeddb/legacy/LegacyRequest.cpp:
(WebCore::LegacyRequest::result):
(WebCore::LegacyRequest::error):
(WebCore::LegacyRequest::source):
(WebCore::LegacyRequest::transaction):
(WebCore::LegacyRequest::onSuccess):
- Modules/indexeddb/legacy/LegacyRequest.h:
- Modules/indexeddb/legacy/LegacyTransaction.cpp:
(WebCore::LegacyTransaction::objectStore):
- Modules/indexeddb/legacy/LegacyTransaction.h:
- inspector/InspectorIndexedDBAgent.cpp:
- 12:13 PM Changeset in webkit [190249] by
-
- 5 edits in trunk/Source
[WinCairo] Incorrect position for windowless plugins.
https://bugs.webkit.org/show_bug.cgi?id=149524
Reviewed by Alex Christensen.
Source/WebCore:
Added method to get graphics context HDC.
- platform/graphics/GraphicsContext.h:
- platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContext::getWindowsContext):
(WebCore::GraphicsContext::hdc):
(WebCore::GraphicsContextPlatformPrivate::save):
Source/WebKit/win:
Only perform the device context transformation if the plugin is painting
directly into the GraphicsContext HDC. The previous check was not correct
in all cases.
- Plugins/PluginViewWin.cpp:
(WebCore::PluginView::paint):
- 10:52 AM Changeset in webkit [190248] by
-
- 2 edits in trunk/Source/WebCore
Fix the broken !ENABLE(STREAM_API) build
https://bugs.webkit.org/show_bug.cgi?id=149525
Reviewed by Darin Adler.
Removed some #ifdef ENABLE(STREAMS_API) to make build work when STREAMS_API is off.
This is a temporary fix.
- bindings/js/WebCoreJSClientData.h:
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::initNormalWorldClientData):
- 10:51 AM Changeset in webkit [190247] by
-
- 2 edits in trunk/Source/WTF
Simplify Stopwatch::elapsedTime
https://bugs.webkit.org/show_bug.cgi?id=149538
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-25
Reviewed by Darin Adler.
- wtf/Stopwatch.h:
(WTF::Stopwatch::elapsedTime):
Simplify by not starting/stopping but just computing without updating members.
- 10:51 AM Changeset in webkit [190246] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Reloading the page causes the inspector tab to switch back to "Resources" tab
https://bugs.webkit.org/show_bug.cgi?id=148732
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-25
Reviewed by Darin Adler.
- UserInterface/Views/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype._scriptsCleared):
Suppress selection of sibiling tree elements when removing extra folders.
- 10:48 AM Changeset in webkit [190245] by
-
- 2 edits in trunk/LayoutTests
Mark media/media-controls-play-button-updates.html failed for all Mac platforms.
Unreviewed gardening.
- platform/mac/TestExpectations:
- 10:45 AM Changeset in webkit [190244] by
-
- 2 edits1 delete in trunk/Tools
Removed MiniBrowser.entitlements.
Rubber-stamped by Anders Carlsson.
The entitlements weren’t used anyway.
- MiniBrowser/MiniBrowser.entitlements: Removed.
- MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
- 10:25 AM Changeset in webkit [190243] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, nit fix after r190229.
- dom/Range.cpp:
(WebCore::Range::insertNode):
- 9:11 AM Changeset in webkit [190242] by
-
- 5 edits in trunk
Unreviewed, rolling out r190232 and r190236.
https://bugs.webkit.org/show_bug.cgi?id=149555
"It did not help" (Requested by cdumez on #webkit).
Reverted changesets:
"Unreviewed, roll out r187615 as it seems to have caused a ~1%
PLT regression."
http://trac.webkit.org/changeset/190232
"This started failing after this rollout:"
http://trac.webkit.org/changeset/190236
Patch by Commit Queue <commit-queue@webkit.org> on 2015-09-25
- 9:10 AM Changeset in webkit [190241] by
-
- 2 edits in trunk/WebKitLibraries
[Win] Unreviewed build fix.
- win/tools/vsprops/FeatureDefines.props: Let Windows build know about
the STREAMS_API feature.
- 9:09 AM Changeset in webkit [190240] by
-
- 2 edits in trunk/Source/WTF
[Win] Unreviewed build fix.
- wtf/FeatureDefines.h: Don't turn STREAMS_API on by default
on Windows.
- 2:57 AM Changeset in webkit [190239] by
-
- 4 edits1 delete in trunk/Source/WebCore
Remove the need for DOMClass in case of JSBuiltinConstructor WebIDL
https://bugs.webkit.org/show_bug.cgi?id=149522
Reviewed by Darin Adler.
Adding generation of the dummy DOM class for JSBuiltinConstructor interfaces.
This is applied to CountQueuingStrategy.
Covered by existing tests of CountQueuingStrategy.
- Modules/streams/CountQueuingStrategy.h: Removed.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Removal of DOM class header include and generation of dummy class.
(GenerateImplementation): Removal of DOM class header include.
(UseDummyDOMClass): Helper routine.
(GenerateDummyDOMClassForJSBuiltin): Ditto.
- 2:42 AM Changeset in webkit [190238] by
-
- 5 edits in trunk
[GTK] ASSERTION FAILED: !m_inUpdateBackingStoreState in DrawingAreaImpl::display() after DrawingAreaImpl::forceRepaint()
https://bugs.webkit.org/show_bug.cgi?id=148956
Reviewed by Žan Doberšek.
Source/WebKit2:
This is because those tests call notifyDone in the onresize event
handler. InjectedBundlePage::dump() always calls WKBundlePageForceRepaint()
before dumping. When the view is resized DrawingAreaImpl::updateBackingStoreState()
is called, so if the size has changed the FrameView::resize()
method is called and all children are resized, so the onresize
handlers happen at that point, before the
m_inUpdateBackingStoreState is set to false again. For WTR we
could probably just return early from froceReapaint() when
m_inUpdateBackingStoreState is true, because in that case we know
the layout is updated because of the resize and the actual display
is not really needed. But the UI process can also request a force
repaint, so we could wait until the backing store update is done
and then force the repaint. For WTR it will happen after the
dump, but it shouldn't be a problem.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::forceRepaint):
(WebKit::DrawingAreaImpl::updateBackingStoreState):
- WebProcess/WebPage/DrawingAreaImpl.h:
LayoutTests:
Unskip tests that should pass now.
- platform/gtk/TestExpectations:
Sep 24, 2015:
- 11:58 PM Changeset in webkit [190237] by
-
- 4 edits2 adds in trunk
Add WebKitSystemInterface for iOS 9.0
https://bugs.webkit.org/show_bug.cgi?id=149550
Rubber-stamped by Alexey Proskuryakov.
Tools:
- Scripts/copy-webkitlibraries-to-product-directory:
WebKitLibraries:
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceIOSDevice9.0.a: Added.
- libWebKitSystemInterfaceIOSSimulator9.0.a: Added.
- 10:14 PM Changeset in webkit [190236] by
-
- 2 edits in trunk/LayoutTests
This started failing after this rollout:
http://trac.webkit.org/changeset/190232
- platform/mac/TestExpectations:
- 8:41 PM Changeset in webkit [190235] by
-
- 8 edits in trunk/Source
[Win] Support composited content in WebView render-to-context methods
https://bugs.webkit.org/show_bug.cgi?id=149516
<rdar://problem/22635080>
Reviewed by Simon Fraser.
Source/WebCore:
Extend the CACFLayerTreeHost implementation to render into a passed
device context when requested. When no context is provided (the default
case) paint as normal.
Will be tested by existing compositing tests in a future bug. DumpRenderTree
has to be extended to do this painting properly.
- platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::paint): Accept an optional HDC argument, and
pass it to the render method.
- platform/graphics/ca/win/CACFLayerTreeHost.h:
- platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Add missing SOFT_LINK
command for the WKCACFViewDrawIntoDC.
(WebCore::WKCACFViewLayerTreeHost::paint): Accept optional HDC argument and
pass it to the parent class.
(WebCore::WKCACFViewLayerTreeHost::render): Accept new optional HDC argument.
If provided, call WKCACFViewDrawIntoDC. Otherwise, call WKCACFVIewDraw.
(WebCore::WKCACFViewLayerTreeHost::setShouldInvertColors):
- platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:
Source/WebKit/win:
- WebView.cpp:
(WebView::paint): Call the new 'paintCompositedContentToHDC' method. If
it handles the pain, return.
(WebView::paintCompositedContentToHDC): New method to share code with other
paint methods.
(WebView::paintDocumentRectToContext): Call new 'paintCompositedContentToHDC'
to handle any composited layers. Otherwise, use slow drawing path.
(WebView::paintScrollViewRectToContextAtPoint): Ditto.
- WebView.h:
- 7:56 PM Changeset in webkit [190234] by
-
- 4 edits in trunk/Source/WebCore
Drop [NotDeletable] from QuickTimePluginReplacement.postEvent()
https://bugs.webkit.org/show_bug.cgi?id=149547
Reviewed by Eric Carlson.
Drop [NotDeletable] from QuickTimePluginReplacement.postEvent(). It does
not appear to be needed and this is the last user of this non-standard
IDL attribute. This patch also drops support for this IDL attribute.
- Modules/plugins/QuickTimePluginReplacement.idl:
- bindings/scripts/CodeGeneratorJS.pm:
(ComputeFunctionSpecial):
- bindings/scripts/IDLAttributes.txt:
- 7:48 PM Changeset in webkit [190233] by
-
- 7 edits in trunk
Node.replaceChild() does not behave according to the specification
https://bugs.webkit.org/show_bug.cgi?id=149546
<rdar://problem/22571887>
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C DOM test now that one more check is passing.
- web-platform-tests/dom/nodes/MutationObserver-childList-expected.txt:
Source/WebCore:
Node.replaceChild() does not behave according to the specification. In
particular, when replacing |child| with |node| we are supposed to remove
|node| from its parent *before* removing |child| from its parent:
- https://dom.spec.whatwg.org/#concept-node-replace (Steps 10 & 11)
This patch reverses the order as per the specification. Our new behavior
matches Firefox's behavior. Note that this patch also remove an
optimization when replacing a child with its next sibling. This
optimization was observable from JS. It seems likely this case is not
common enough for it to be an issue. However, we can revisit if we see
it regresses things.
This leads to incorrect Mutation Records being queued in some cases.
No new tests, already covered by existing test.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::replaceChild):
LayoutTests:
Update existing test that now throws a different exception.
- fast/events/mutation-during-replace-child-expected.txt:
- fast/events/mutation-during-replace-child.html:
- 6:50 PM Changeset in webkit [190232] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, roll out r187615 as it seems to have caused a ~1% PLT regression.
<rdar://problem/22657123>
- platform/graphics/FontCache.h:
(WebCore::FontDescriptionKey::makeFlagsKey):
- platform/graphics/FontCascade.cpp:
(WebCore::operator==):
(WebCore::makeFontSelectorFlags):
(WebCore::makeFontCascadeCacheKey):
(WebCore::computeFontCascadeCacheHash):
- 5:54 PM Changeset in webkit [190231] by
-
- 13 edits in trunk/Source/WebCore
Keep the already-parsed list of terms in custom property values so that we don't have to re-parse them
later when doing variable resolution.
https://bugs.webkit.org/show_bug.cgi?id=149544
Reviewed by Dean Jackson.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::customPropertyValue):
(WebCore::ComputedStyleExtractor::customPropertyText):
Add a helper for getting the raw text. More closely parallels how non-custom properties work with the
extractor.
(WebCore::ComputedStyleExtractor::propertyValue):
Change propertyValue to use customPropertyText.
(WebCore::ComputedStyleExtractor::copyPropertiesInSet):
Don't copy CSS custom properties into the style declaration. This is just used for things like editing, so
we didn't need to be putting the custom properties into this set.
(WebCore::CSSComputedStyleDeclaration::getPropertyValue):
Patched to go straight to the serialized string value.
(WebCore::ComputedStyleExtractor::customPropertyValue): Deleted.
Replaced by customPropertyText.
- css/CSSComputedStyleDeclaration.h:
Rename customPropertyValue to customPropertyText and make it just return a String.
- css/CSSCustomPropertyValue.h:
(WebCore::CSSCustomPropertyValue::create):
(WebCore::CSSCustomPropertyValue::customCSSText):
(WebCore::CSSCustomPropertyValue::name):
(WebCore::CSSCustomPropertyValue::equals):
(WebCore::CSSCustomPropertyValue::CSSCustomPropertyValue):
(WebCore::CSSCustomPropertyValue::value): Deleted.
Changed to hold both a CSSParserValueList, which it adopts from the CSSParser, and a string value that
is constructed lazily only if the value is serialized. Now the problematic serialization code will only
run if someone uses the CSS OM to trigger a serialization (this should be a rare occurrence, so perf
improves with this change).
- css/CSSGrammar.y.in:
Change parsing of custom properties to be identical to regular properties. This refactoring allows
us to simply invoke the parser from style declarations as well and makes everything behave more
similarly to normal property parsing.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseCustomPropertyValue):
(WebCore::CSSParser::parseCustomPropertyDeclaration):
(WebCore::CSSParser::addCustomPropertyDeclaration): Deleted.
- css/CSSParser.h:
(WebCore::CSSParser::setCustomPropertyName):
We now have a method for parsing custom properties that can be invoked from style declarations. The
parser list is now adopted by the CSSCustomPropertyValue.
- css/CSSParserValues.cpp:
(WebCore::CSSParserValueList::toString):
Build the string serialization code right into CSSParserValueList.
- css/CSSParserValues.h:
Add a toString() method for serialization.
- css/StyleProperties.cpp:
(WebCore::MutableStyleProperties::setProperty):
(WebCore::MutableStyleProperties::setCustomProperty):
Changed to use the new CSSParser functions. This makes the code behave almost identically to regular
property parsing.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- rendering/style/RenderStyle.h:
- rendering/style/StyleCustomPropertyData.h:
Change the mapping on RenderStyle to store the custom CSS values. This way we can get to the original
parser lists for each variable when it comes time to do variable resolution.
- 5:17 PM Changeset in webkit [190230] by
-
- 14 edits in trunk/Source/JavaScriptCore
Remove the use of "Immediate" in JIT function names.
https://bugs.webkit.org/show_bug.cgi?id=149542
Reviewed by Geoffrey Garen.
We will rename the following:
isOperandConstantImmediateDouble => isOperandConstantDouble
isOperandConstantImmediateInt => isOperandConstantInt
isOperandConstantImmediateChar => isOperandConstantChar
getOperandConstantImmediateInt => getOperandConstantInt
getConstantOperandImmediateInt => getOperandConstantInt
emitJumpIfImmediateInteger => emitJumpIfInt
emitJumpIfNotImmediateInteger => emitJumpIfNotInt
emitJumpIfNotImmediateIntegers => emitJumpIfNotInt
emitPatchableJumpIfNotImmediateInteger => emitPatchableJumpIfNotInt
emitJumpSlowCaseIfNotImmediateInteger => emitJumpSlowCaseIfNotInt
emitJumpSlowCaseIfNotImmediateNumber => emitJumpSlowCaseIfNotNumber
emitJumpSlowCaseIfNotImmediateIntegers => emitJumpSlowCaseIfNotInt
emitFastArithReTagImmediate => emitTagInt
emitTagAsBoolImmediate => emitTagBool
emitJumpIfImmediateNumber => emitJumpIfNumber
emitJumpIfNotImmediateNumber => emitJumpIfNotNumber
emitFastArithImmToInt - Deleted because this is an empty function.
emitFastArithIntToImmNoCheck => emitTagInt
emitPutImmediateToCallFrameHeader => emitPutToCallFrameHeader
This is purely a refactoring patch to do the renaming. There is no behavior
change.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileSetupRegistersForEntry):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitPutToCallFrameHeader):
(JSC::AssemblyHelpers::emitPutImmediateToCallFrameHeader): Deleted.
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JIT.h:
(JSC::JIT::emitStoreCell):
(JSC::JIT::getSlowCase):
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_negate):
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emit_op_rshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emit_op_urshift):
(JSC::JIT::emitSlow_op_urshift):
(JSC::JIT::emit_op_unsigned):
(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareAndJumpSlow):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_inc):
(JSC::JIT::emit_op_dec):
(JSC::JIT::emit_op_mod):
(JSC::JIT::compileBinaryArithOp):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_div):
(JSC::JIT::emitSlow_op_div):
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareAndJumpSlow):
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emitRightShiftSlowCase):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSlow_op_sub):
- jit/JITInlines.h:
(JSC::JIT::emitArrayStorageGetByVal):
(JSC::JIT::isOperandConstantDouble):
(JSC::JIT::isOperandConstantChar):
(JSC::JIT::emitJumpSlowCaseIfNotJSCell):
(JSC::JIT::isOperandConstantInt):
(JSC::JIT::getOperandConstantInt):
(JSC::JIT::emitGetVirtualRegisters):
(JSC::JIT::emitLoadInt32ToDouble):
(JSC::JIT::emitJumpIfInt):
(JSC::JIT::emitJumpIfNotInt):
(JSC::JIT::emitPatchableJumpIfNotInt):
(JSC::JIT::emitJumpSlowCaseIfNotInt):
(JSC::JIT::emitJumpSlowCaseIfNotNumber):
(JSC::JIT::emitTagBool):
(JSC::JIT::isOperandConstantImmediateDouble): Deleted.
(JSC::JIT::isOperandConstantImmediateChar): Deleted.
(JSC::JIT::isOperandConstantImmediateInt): Deleted.
(JSC::JIT::getOperandConstantImmediateInt): Deleted.
(JSC::JIT::getConstantOperandImmediateInt): Deleted.
(JSC::JIT::emitJumpIfImmediateInteger): Deleted.
(JSC::JIT::emitJumpIfNotImmediateInteger): Deleted.
(JSC::JIT::emitPatchableJumpIfNotImmediateInteger): Deleted.
(JSC::JIT::emitJumpIfNotImmediateIntegers): Deleted.
(JSC::JIT::emitJumpSlowCaseIfNotImmediateInteger): Deleted.
(JSC::JIT::emitJumpSlowCaseIfNotImmediateIntegers): Deleted.
(JSC::JIT::emitJumpSlowCaseIfNotImmediateNumber): Deleted.
(JSC::JIT::emitFastArithReTagImmediate): Deleted.
(JSC::JIT::emitTagAsBoolImmediate): Deleted.
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_is_boolean):
(JSC::JIT::emit_op_is_number):
(JSC::JIT::emit_op_is_string):
(JSC::JIT::emit_op_is_object):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_to_number):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emit_op_profile_type):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):
- jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::emitJumpIfNotJSCell):
(JSC::JSInterfaceJIT::emitJumpIfNumber):
(JSC::JSInterfaceJIT::emitJumpIfNotNumber):
(JSC::JSInterfaceJIT::emitLoadDouble):
(JSC::JSInterfaceJIT::emitTagInt):
(JSC::JSInterfaceJIT::emitPutToCallFrameHeader):
(JSC::JSInterfaceJIT::emitJumpIfImmediateNumber): Deleted.
(JSC::JSInterfaceJIT::emitJumpIfNotImmediateNumber): Deleted.
(JSC::JSInterfaceJIT::emitFastArithImmToInt): Deleted.
(JSC::JSInterfaceJIT::emitFastArithIntToImmNoCheck): Deleted.
(JSC::JSInterfaceJIT::emitPutImmediateToCallFrameHeader): Deleted.
- jit/ThunkGenerators.cpp:
(JSC::nativeForGenerator):
- wasm/WASMFunctionCompiler.h:
(JSC::WASMFunctionCompiler::startFunction):
(JSC::WASMFunctionCompiler::endFunction):
- 4:33 PM Changeset in webkit [190229] by
-
- 8 edits in trunk
Rewrite Range::insertNode() as per the latest DOM specification
https://bugs.webkit.org/show_bug.cgi?id=149528
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C DOM tests now that more tests are passing.
- web-platform-tests/dom/ranges/Range-insertNode-expected.txt:
- web-platform-tests/dom/ranges/Range-surroundContents-expected.txt:
Source/WebCore:
Rewrite Range::insertNode() as per the latest DOM specification:
Our previous implementation seemed outdated as we were failing a lot of
W3C tests that Firefox is passing.
No new tests, already covered by existing tests.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::ensurePreInsertionValidity):
(WebCore::checkPreReplacementValidity):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
- dom/ContainerNode.h:
- dom/Range.cpp:
(WebCore::Range::insertNode):
(WebCore::Range::surroundContents):
(WebCore::Range::toString): Deleted.
(WebCore::Range::toHTML): Deleted.
(WebCore::Range::text): Deleted.
(WebCore::Range::createContextualFragment): Deleted.
(WebCore::Range::detach): Deleted.
(WebCore::Range::absoluteBoundingBox): Deleted.
- dom/Range.h:
- 4:03 PM Changeset in webkit [190228] by
-
- 2 edits in trunk/Source/WebKit2
Find hole drawn at subframe's 0x0 when a subframe find match is not rendered
https://bugs.webkit.org/show_bug.cgi?id=149543
Reviewed by Beth Dakin.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::rectsForTextMatches):
Don't add empty rects to the list. Later code will just inflate them
and end up drawing a nonsensical find hole.
- 3:53 PM Changeset in webkit [190227] by
-
- 2 edits in trunk/LayoutTests
The same problem happens on El Capitan.
- platform/mac/TestExpectations:
- 3:51 PM Changeset in webkit [190226] by
-
- 1 copy in tags/Safari-601.1.46.10.1
New tag.
- 3:40 PM Changeset in webkit [190225] by
-
- 2 edits in trunk/Source/WebCore
[Win] Unreviewed build failure.
- bindings/js/WebCoreJSClientData.h: Make sure Streams API headers
are only included if the feature is on.
- 2:58 PM Changeset in webkit [190224] by
-
- 4 edits2 copies in branches/safari-601.1.46.10-branch
Merged r189997. rdar://problem/22845894
- 2:56 PM Changeset in webkit [190223] by
-
- 5 edits in branches/safari-601.1.46.10-branch/Source
Versioning.
- 2:53 PM Changeset in webkit [190222] by
-
- 1 copy in branches/safari-601.1.46.10-branch
New Branch.
- 2:45 PM Changeset in webkit [190221] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rebaseline web-platform-tests/html/dom/interfaces.html for iOS after r190190
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- 2:42 PM Changeset in webkit [190220] by
-
- 33 edits in trunk/Source/JavaScriptCore
[ES6] Implement tail calls in the DFG
https://bugs.webkit.org/show_bug.cgi?id=148663
Reviewed by Filip Pizlo.
jsc-tailcall: Implement the tail call opcodes in the DFG
https://bugs.webkit.org/show_bug.cgi?id=146850
This patch adds support for tail calls in the DFG. This requires a slightly high number of nodes:
- TailCall and TailCallVarargs are straightforward. They are terminal nodes and have the semantics of an actual tail call.
- TailCallInlinedCaller and TailCallVarargsInlinedCaller are here to perform a tail call inside an inlined function. They are non terminal nodes, and are performing the call as a regular call after popping an appropriate number of inlined tail call frames.
- TailCallForwardVarargs and TailCallForwardVarargsInlinedCaller are the extension of TailCallVarargs and TailCallVarargsInlinedCaller to enable the varargs forwarding optimization so that we don't lose performance with a tail call instead of a regular call.
This also required two broad kind of changes:
- Changes in the JIT itself (DFGSpeculativeJIT) are pretty straightforward since they are just an extension of the baseline JIT changes introduced previously.
- Changes in the runtime are mostly related with handling inline call frames. The idea here is that we have a special TailCall type for call frames that indicates to the various pieces of code walking the inline call frame that they should (recursively) skip the caller in their analysis.
- bytecode/CallMode.h:
(JSC::specializationKindFor):
- bytecode/CodeOrigin.cpp:
(JSC::CodeOrigin::inlineDepthForCallFrame):
(JSC::CodeOrigin::isApproximatelyEqualTo):
(JSC::CodeOrigin::approximateHash):
(JSC::CodeOrigin::inlineStack):
- bytecode/CodeOrigin.h:
- bytecode/InlineCallFrame.cpp:
(JSC::InlineCallFrame::dumpInContext):
(WTF::printInternal):
- bytecode/InlineCallFrame.h:
(JSC::InlineCallFrame::callModeFor):
(JSC::InlineCallFrame::kindFor):
(JSC::InlineCallFrame::varargsKindFor):
(JSC::InlineCallFrame::specializationKindFor):
(JSC::InlineCallFrame::isVarargs):
(JSC::InlineCallFrame::isTail):
(JSC::InlineCallFrame::computeCallerSkippingDeadFrames):
(JSC::InlineCallFrame::getCallerSkippingDeadFrames):
(JSC::InlineCallFrame::getCallerInlineFrameSkippingDeadFrames):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGArgumentsEliminationPhase.cpp:
- dfg/DFGBasicBlock.h:
(JSC::DFG::BasicBlock::findTerminal):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::inlineCallFrame):
(JSC::DFG::ByteCodeParser::allInlineFramesAreTailCalls):
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::addCallWithoutSettingResult):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::emitArgumentPhantoms):
(JSC::DFG::ByteCodeParser::inliningCost):
(JSC::DFG::ByteCodeParser::inlineCall):
(JSC::DFG::ByteCodeParser::attemptToInlineCall):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::isLiveInBytecode):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::forAllLocalsLiveInBytecode):
- dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::mergeToSuccessors):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::willCatchExceptionInMachineFrame):
- dfg/DFGLiveCatchVariablePreservationPhase.cpp:
(JSC::DFG::FlushLiveCatchVariablesInsertionPhase::willCatchException):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasCallVarargsData):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::hasHeapPrediction):
- dfg/DFGNodeType.h:
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::handleExitCounts):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::osrWriteBarrier):
- dfg/DFGOSRExitPreparation.cpp:
(JSC::DFG::prepareCodeOriginForOSRExit):
- dfg/DFGOperations.cpp:
- dfg/DFGPreciseLocalClobberize.h:
(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validateSSA):
- dfg/DFGVarargsForwardingPhase.cpp:
- interpreter/CallFrame.cpp:
(JSC::CallFrame::bytecodeOffset):
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::gotoNextFrame):
- 2:39 PM Changeset in webkit [190219] by
-
- 2 edits in trunk/Tools
Support building for arbitrary architectures
https://bugs.webkit.org/show_bug.cgi?id=149539
Reviewed by Alexey Proskuryakov.
Teach buildbot to pass the architectures associated with the builder to build-webkit
when building on OS X and iOS. As a side effect of this change we now support building
universal binaries when multiples architectures are specified.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit.start):
- 1:23 PM Changeset in webkit [190218] by
-
- 2 edits in trunk/Tools
Fix the build after <http://trac.webkit.org/changeset/190212>
(http://trac.webkit.org/changeset/190212)
I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
- BuildSlaveSupport/built-product-archive:
(main):
- 1:13 PM Changeset in webkit [190217] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove special case code for the no-parallel-GC case
https://bugs.webkit.org/show_bug.cgi?id=149512
Reviewed by Mark Lam.
Make serial GC just a parallel GC where the helper threads don't do anything. Also make the
idle thread calculation a bit more explicit.
The main outcome is that we no longer use Options::numberOfGCMarkers() as much, so the code is
resilient against the number of GC markers changing.
- heap/Heap.h:
- heap/SlotVisitor.cpp:
(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
- 12:36 PM Changeset in webkit [190216] by
-
- 2 edits in trunk/Tools
Support running unit tests on iOS Simulator test bot
https://bugs.webkit.org/show_bug.cgi?id=149536
Reviewed by Alexey Proskuryakov.
Implements support for running unit tests on a iOS test bot. At the time of writing,
the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
(TestFactory.init): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
- 12:23 PM Changeset in webkit [190215] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
PolymorphicAccess should remember that it checked an ObjectPropertyCondition with a check on some structure
https://bugs.webkit.org/show_bug.cgi?id=149514
Reviewed by Oliver Hunt.
When we checked an ObjectPropertyCondition using an explicit structure check, we would forget to
note the structure in any weak reference table and we would attempt to regenerate the condition
check even if the condition became invalid.
We need to account for this better and we need to prune AccessCases that have an invalid condition
set. This change does both.
- bytecode/PolymorphicAccess.cpp:
(JSC::AccessGenerationState::addWatchpoint):
(JSC::AccessCase::alternateBase):
(JSC::AccessCase::couldStillSucceed):
(JSC::AccessCase::canReplace):
(JSC::AccessCase::generate):
(JSC::PolymorphicAccess::regenerateWithCases):
(JSC::PolymorphicAccess::visitWeak):
(JSC::PolymorphicAccess::regenerate):
- bytecode/PolymorphicAccess.h:
(JSC::AccessCase::callLinkInfo):
- tests/stress/make-dictionary-repatch.js: Added. This used to crash on a release assert. If we removed the release assert, this would return bad results.
- 12:00 PM Changeset in webkit [190214] by
-
- 3 edits4 adds in trunk
Make event dispatching respect slotting
https://bugs.webkit.org/show_bug.cgi?id=149243
Reviewed by Antti Koivisto.
Source/WebCore:
There are primarily two cases to consider: getting out of a shadow root to its host,
and moving into a slot from an assigned node.
When getting out of a shadow root, either the event originated in its shadow tree
including its nodes' shadow trees (1) or it moved into this shadow tree via a slot (2).
In (1), event.target should be set to the shadow host. In (2), it should be set to the
first node in the event path that belongs to the same tree as the shadow host. In order
to find such a node in O(1), we use a stack of event targets in each (shadow) tree. We
push event.target of the current tree whenever we move up to a slot from an assigned node
and pop it out of the stack when we move out of the shadow tree.
A follow up patch is needed to update the code to resolve related targets.
Tests: fast/shadow-dom/event-inside-shadow-tree.html
fast/shadow-dom/event-inside-slotted-node.html
- dom/EventDispatcher.cpp:
(WebCore::EventPath::EventPath):
LayoutTests:
Added tests for dispatching events inside shadow trees and nodes assigned to slots using testharness.js.
- fast/shadow-dom/event-inside-shadow-tree-expected.txt: Added.
- fast/shadow-dom/event-inside-shadow-tree.html: Added.
- fast/shadow-dom/event-inside-slotted-node-expected.txt: Added.
- fast/shadow-dom/event-inside-slotted-node.html: Added.
- 11:38 AM Changeset in webkit [190213] by
-
- 5 edits in trunk/Source/JavaScriptCore
We should only expect a RareCaseProfile to exist if the rare case actually exists.
https://bugs.webkit.org/show_bug.cgi?id=149531
Reviewed by Saam Barati.
The current code that calls rareCaseProfileForBytecodeOffset() assumes that it
will always return a non-null RareCaseProfile. As a result, op_add in the
baseline JIT is forced to add a dummy slow case that will never be taken, only to
ensure that the RareCaseProfile for that bytecode is created. This profile will
always produce a counter value of 0 (since that path will never be taken).
Instead, we'll make the callers of rareCaseProfileForBytecodeOffset() check if
the profile actually exist before dereferencing it.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::rareCaseProfileForBytecodeOffset):
(JSC::CodeBlock::rareCaseProfileCountForBytecodeOffset):
(JSC::CodeBlock::capabilityLevel):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::addRareCaseProfile):
(JSC::CodeBlock::numberOfRareCaseProfiles):
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::rareCaseProfile): Deleted.
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
- 11:36 AM Changeset in webkit [190212] by
-
- 6 edits in trunk/Tools
Add support infrastructure for OpenSource iOS builders and testers
https://bugs.webkit.org/show_bug.cgi?id=149534
Reviewed by Darin Adler.
Towards setting up OpenSource iOS build bots, teach buildbot and its support
scripts about iOS.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
--ios-simulator or --device for a builder/tester whose full platform name begins with
"ios-simulator" or "ios", respectively.
(RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
- BuildSlaveSupport/built-product-archive:
(main): Pass the full platform name to determineWebKitBuildDirectory().
(determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
command line flag when building for iOS.
(archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
parameter fullPlatform. This parameter was originally added in r125066 to support the
Chromium Android port, which has since been removed from the OpenSource WebKit Project.
(extractBuiltProduct): Use the same logic for iOS as we do for Mac.
- BuildSlaveSupport/clean-build:
(main): Call script webkit-build-directory with the appropriate command line flag when
building for iOS.
- BuildSlaveSupport/delete-stale-build-files:
(main): Use the same logic for iOS as we do for Mac.
(webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
flag when building for iOS.
- BuildSlaveSupport/test-result-archive:
(archiveTestResults): Use the same logic for iOS as we do for Mac.
- 11:29 AM Changeset in webkit [190211] by
-
- 2 edits in trunk/Tools
Remove Chromium-specific changes to script built-product-archive
https://bugs.webkit.org/show_bug.cgi?id=149530
Rubber-stamped by Csaba Osztrogonác.
Reverts changes made in r113074 and r113067 to support Chromium testers. The
Chromium code has long since been removed from the OpenSource WebKit Project.
- BuildSlaveSupport/built-product-archive:
(createZipManually):
(createZip):
(archiveBuiltProduct):
- 11:17 AM Changeset in webkit [190210] by
-
- 13 edits in trunk/Source
Drop XPATH_NAMESPACE_NODE from Node::NodeType enum
https://bugs.webkit.org/show_bug.cgi?id=149532
Reviewed by Ryosuke Niwa.
Drop XPATH_NAMESPACE_NODE from Node::NodeType enum as there is currently
no way to construct such Node in WebKit. This avoid having to handle this
Node type everywhere.
Source/WebCore:
- bindings/gobject/WebKitDOMPrivate.cpp:
(WebKit::wrap): Deleted.
- bindings/objc/DOM.mm:
(kitClass): Deleted.
- dom/Document.cpp:
(WebCore::Document::importNode):
(WebCore::Document::adoptNode): Deleted.
(WebCore::Document::childTypeAllowed): Deleted.
(WebCore::Document::canAcceptChild): Deleted.
- dom/Node.cpp:
(WebCore::Node::dumpStatistics): Deleted.
(WebCore::Node::textContent): Deleted.
(WebCore::Node::ancestorElement): Deleted.
- dom/Node.h:
- dom/Range.cpp:
(WebCore::Range::checkNodeWOffset):
(WebCore::lengthOfContentsInNode): Deleted.
(WebCore::Range::processContentsBetweenOffsets): Deleted.
(WebCore::Range::surroundContents): Deleted.
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendStartMarkup): Deleted.
- xml/XPathFunctions.cpp:
(WebCore::XPath::expandedNameLocalPart): Deleted.
- xml/XPathStep.cpp:
(WebCore::XPath::Step::nodesInAxis):
(WebCore::XPath::primaryNodeType): Deleted.
- xml/XPathUtil.cpp:
(WebCore::XPath::stringValue): Deleted.
(WebCore::XPath::isValidContextNode): Deleted.
Source/WebKit2:
- WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:
(WebKit::WKDOMNodeClass): Deleted.
- 11:15 AM Changeset in webkit [190209] by
-
- 19 edits19 adds in trunk
Add support for CSS Custom Properties (in preparation for implementing CSS Variables).
https://bugs.webkit.org/show_bug.cgi?id=130397
Reviewed by Antti Koivisto.
Source/WebCore:
Added new tests in fast/css/custom-properties.
- WebCore.xcodeproj/project.pbxproj:
Add new header files to the project (CSSCustomPropertyValue and StyleCustomPropertyData).
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::customPropertyValue):
(WebCore::ComputedStyleExtractor::propertyValue):
If a custom property value is queried (i.e., it starts with "--"), then we use our
customPropertyValue lookup to go to the RenderStyle and fetch the appropriate custom property
value from the StyleCustomPropertyData.
(WebCore::CSSComputedStyleDeclaration::length):
(WebCore::CSSComputedStyleDeclaration::item):
Patched to include custom properties in the returned array. They appear at the end of the array
after the built-in properties.
(WebCore::ComputedStyleExtractor::propertyMatches):
Patched to check custom properties.
(WebCore::ComputedStyleExtractor::copyPropertiesInSet):
Make sure the custom properties get copied into the StyleDeclaration.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyValue):
Patched to call customPropertyValue for custom properties.
- css/CSSComputedStyleDeclaration.h:
Add customPropertyValue() to ComputedStyleExtractor.
- css/CSSCustomPropertyValue.h: Added.
(WebCore::CSSCustomPropertyValue::create):
(WebCore::CSSCustomPropertyValue::equals):
(WebCore::CSSCustomPropertyValue::customCSSText):
(WebCore::CSSCustomPropertyValue::name):
(WebCore::CSSCustomPropertyValue::value):
(WebCore::CSSCustomPropertyValue::CSSCustomPropertyValue):
Custom properties are parsed as a property with an ID of CSSPropertyCustom and a CSSCustomPropertyValue
that holds both the name and the value of the property. Ultimately we might want to just ditch property IDs in
favor of AtomicStrings for all properties, and then the need to special case custom properties would go
away. For now, though, this is the way we work custom properties into the existing system.
- css/CSSGrammar.y.in:
Add a production for recognizing custom properties and storing them using a property ID of CSSPropertyCustom
and a CSSCustomPropertyValue that has the name/value pair.
- css/CSSParser.cpp:
(WebCore::filterProperties):
Patched to track seen custom properties and to handle them correctly.
(WebCore::CSSParser::createStyleProperties):
Pass in a seenCustomProperties table to ensure we bail when encountering the same custom property twice.
(WebCore::CSSParser::addCustomPropertyDeclaration):
Called from the grammar production to create the CSSCustomPropertyValue.
(WebCore::isCustomPropertyIdentifier):
Recognize the -- custom property during lexing.
(WebCore::CSSParser::parseIdentifier):
Patched to return a CUSTOM_PROPERTY token when a custom property is identified.
- css/CSSParser.h:
(WebCore::isCustomPropertyName):
Add a helper function for asking if a property name is custom.
- css/CSSValue.cpp:
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
Patched to add support for CSSCustomPropertyValue.
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
Add code for handling custom properties in the CSS OM.
- css/StyleProperties.cpp:
(WebCore::StyleProperties::getPropertyValue):
(WebCore::StyleProperties::getCustomPropertyValue):
(WebCore::StyleProperties::getPropertyCSSValue):
(WebCore::StyleProperties::getCustomPropertyCSSValue):
(WebCore::MutableStyleProperties::removeProperty):
(WebCore::MutableStyleProperties::removeCustomProperty):
(WebCore::StyleProperties::propertyIsImportant):
(WebCore::StyleProperties::customPropertyIsImportant):
(WebCore::MutableStyleProperties::setProperty):
(WebCore::MutableStyleProperties::setCustomProperty):
(WebCore::MutableStyleProperties::addParsedProperty):
(WebCore::MutableStyleProperties::findPropertyIndex):
(WebCore::ImmutableStyleProperties::findCustomPropertyIndex):
(WebCore::MutableStyleProperties::findCustomPropertyIndex):
(WebCore::MutableStyleProperties::findCSSPropertyWithID):
(WebCore::MutableStyleProperties::findCustomCSSPropertyWithName):
(WebCore::StyleProperties::propertyMatches):
(WebCore::StyleProperties::PropertyReference::cssName):
- css/StyleProperties.h:
(WebCore::StyleProperties::findCustomPropertyIndex):
Patched to support handling custom properties in the CSS OM. We have to create equivalent methods that operate
on AtomicString propertyNames instead of on property IDs.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::CascadedProperties::customProperties):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::CascadedProperties::set):
(WebCore::StyleResolver::applyCascadedProperties):
The resolver has to hold a HashMap from AtomicStrings to Properties. It matches identically to how built-in
properties work except that an extensible table (HashMap) is used to hold the property data.
- css/makeprop.pl:
Patched to include the special CSSPropertyCustom value of 1 (just after the CSSPropertyInvalid id value but before the first
built-in property value).
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::getText):
(WebCore::lowercasePropertyName):
(WebCore::InspectorStyle::populateAllProperties):
Patch inspector to not lowercase CSS custom property names, since they are case-sensitive.
- rendering/style/RenderStyle.h:
- rendering/style/StyleCustomPropertyData.h: Added.
(WebCore::StyleCustomPropertyData::create):
(WebCore::StyleCustomPropertyData::copy):
(WebCore::StyleCustomPropertyData::operator==):
(WebCore::StyleCustomPropertyData::operator!=):
(WebCore::StyleCustomPropertyData::setCustomPropertyValue):
(WebCore::StyleCustomPropertyData::getCustomPropertyValue):
(WebCore::StyleCustomPropertyData::hasCustomProperty):
(WebCore::StyleCustomPropertyData::StyleCustomPropertyData):
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
The front end storage in the RenderStyle for custom properties. For now, custom properties are always inherited, so the
data is in StyleRareInheritedData.
LayoutTests:
- fast/css/custom-properties: Added.
- fast/css/custom-properties/computed-style-access-expected.html: Added.
- fast/css/custom-properties/computed-style-access-inherited-expected.html: Added.
- fast/css/custom-properties/computed-style-access-inherited.html: Added.
- fast/css/custom-properties/computed-style-access.html: Added.
- fast/css/custom-properties/inline-style-property-get-expected.html: Added.
- fast/css/custom-properties/inline-style-property-get.html: Added.
- fast/css/custom-properties/rule-property-get-css-value-expected.html: Added.
- fast/css/custom-properties/rule-property-get-css-value.html: Added.
- fast/css/custom-properties/rule-property-get-expected.html: Added.
- fast/css/custom-properties/rule-property-get.html: Added.
- fast/css/custom-properties/rule-property-priority-expected.html: Added.
- fast/css/custom-properties/rule-property-priority.html: Added.
- fast/css/custom-properties/rule-property-set-expected.html: Added.
- fast/css/custom-properties/rule-property-set.html: Added.
- fast/css/custom-properties/rule-serialization-expected.html: Added.
- fast/css/custom-properties/rule-serialization.html: Added.
- 10:25 AM Changeset in webkit [190208] by
-
- 2 edits in trunk/Source/WebCore
Optimize Range's lengthOfContentsInNode() for DocumentType Nodes
https://bugs.webkit.org/show_bug.cgi?id=149529
Reviewed by Darin Adler.
Optimize Range's lengthOfContentsInNode() for DocumentType Nodes:
We currently call Node::countChildNodes() unnecessarily on DocumentType
Nodes instead of simply returning 0.
- dom/Range.cpp:
(WebCore::lengthOfContentsInNode):
(WebCore::Range::processContents):
- 10:00 AM Changeset in webkit [190207] by
-
- 2 edits in trunk/Source/WebKit/win
[WinCairo] NULL pointer crash when trying to use tiled backing for frame view.
https://bugs.webkit.org/show_bug.cgi?id=149523
Reviewed by Brent Fulgham.
For WinCairo, disable tiled backing for frame view.
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::shouldUseTiledBackingForFrameView):
- 9:32 AM Changeset in webkit [190206] by
-
- 2 edits in trunk/Tools
Build fix.
- WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
- 8:55 AM Changeset in webkit [190205] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix typo errors in a comment ("passed" -> "Passed", "Overwise" -> "Otherwise")
- css/mediaControlsGtk.css:
- 8:48 AM Changeset in webkit [190204] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rebaseline media/media-controls-play-button-updates.html.
- platform/gtk/media/media-controls-play-button-updates-expected.txt:
- 8:39 AM Changeset in webkit [190203] by
-
- 2 edits in trunk/Tools
Unreviewed. Make Lucas Forschler a WebKit reviewer.
- Scripts/webkitpy/common/config/contributors.json:
- 7:56 AM Changeset in webkit [190202] by
-
- 17 edits in trunk/Source/WebCore
Reduce almost uses of PassRefPtr in Webcore/testing
https://bugs.webkit.org/show_bug.cgi?id=149449
Reviewed by Darin Adler.
This patch removes all uses of PassRefPtr except for Internals::serializeObject() and Internals::deserializeObject().
It will be removed by upcoming patch.
- Modules/encryptedmedia/CDMSessionClearKey.cpp:
(WebCore::CDMSessionClearKey::generateKeyRequest):
- Modules/encryptedmedia/CDMSessionClearKey.h:
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::jsTestOverrideBuiltinsPrototypeFunctionNamedItem):
- platform/graphics/CDMSession.h:
- platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp:
(WebCore::CDMSessionAVFoundationCF::generateKeyRequest):
- platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.h:
- platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:
(WebCore::CDMSessionAVFoundationObjC::generateKeyRequest):
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyRequest):
- testing/InternalSettings.h:
(WebCore::InternalSettings::create):
- testing/Internals.cpp:
(WebCore::Internals::create):
(WebCore::Internals::computedStyleIncludingVisitedInfo):
(WebCore::Internals::markerRangeForNode):
(WebCore::Internals::rangeFromLocationAndLength):
(WebCore::Internals::subrange):
(WebCore::Internals::nodesFromRect):
(WebCore::Internals::mallocStatistics):
(WebCore::Internals::typeConversions):
(WebCore::Internals::memoryInfo):
(WebCore::Internals::serializeObject):
(WebCore::Internals::deserializeBuffer):
(WebCore::Internals::createTimeRanges):
- testing/Internals.h:
- testing/MallocStatistics.h:
(WebCore::MallocStatistics::create):
- testing/MemoryInfo.h:
(WebCore::MemoryInfo::create):
- testing/MockCDM.cpp:
(WebCore::MockCDMSession::generateKeyRequest):
- testing/TypeConversions.h:
(WebCore::TypeConversions::create):
- 7:26 AM Changeset in webkit [190201] by
-
- 12 edits in trunk/Source
Ran sort-Xcode-project-file.
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj:
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
Source/WebInspectorUI:
- WebInspectorUI.xcodeproj/project.pbxproj:
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit2:
- WebKit2.xcodeproj/project.pbxproj:
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- 5:35 AM WebKitIDL edited by
- (diff)
- 5:32 AM WebKitIDL edited by
- (diff)
- 2:41 AM Changeset in webkit [190200] by
-
- 5 edits5 adds in trunk
[GTK] playbutton in media controls is not changed when it is clicked.
https://bugs.webkit.org/show_bug.cgi?id=149113
Reviewed by Philippe Normand.
Source/WebCore:
When the play button in media controls is clicked, a 'paused' class is added or removed
for the element to update its appearance. Although Document::recalcStyle is triggered
by that class attribute change, the play button is not changed since there is
no difference in styles whether having the 'paused' class or not. Gtk port
does not define the -webkit-media-controls-play-button.paused. To fix this,
-webkit-media-controls-play-button.paused is newly defined with a dummy style,
"position: relative;", which should not change the play button appearance,
but be clearly different in style.
Test: media/media-controls-play-button-updates.html
- css/mediaControlsGtk.css:
(video::-webkit-media-controls-play-button.paused):
LayoutTests:
- media/media-controls-play-button-updates-expected.png: Added.
- media/media-controls-play-button-updates-expected.txt: Added.
- media/media-controls-play-button-updates.html: Added.
- platform/efl/TestExpectations: Skip the test.
- platform/gtk/media/media-controls-play-button-updates-expected.png: Added.
- platform/gtk/media/media-controls-play-button-updates-expected.txt: Added.
- platform/mac/TestExpectations: Skip the test on yosemite.
- 2:24 AM Changeset in webkit [190199] by
-
- 10 edits in trunk
Unreviewed. Fix GObject DOM API breaks after r190120.
Source/WebCore:
EntityReference has been removed from the DOM spec. Generate an
empy GObject implementation to keep API and ABI
compatibility. also add a deprecated impementation for the methods
using WebKitEntityReference.
- PlatformGTK.cmake: Do not generate bindings for EntityReference.idl.
- bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_entity_reference_init):
(webkit_dom_entity_reference_class_init):
(webkit_dom_node_iterator_get_expand_entity_references):
(webkit_dom_tree_walker_get_expand_entity_references):
(webkit_dom_document_create_entity_reference):
- bindings/gobject/WebKitDOMDeprecated.h:
- bindings/gobject/WebKitDOMDeprecated.symbols:
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Remove FIXME.
- dom/Document.idl: Do not generate createEntityReference for GObject.
- dom/EntityReference.idl: Do not generate empty files for GObject.
Tools:
Bring back code removed in r169931 to handle documentation of
deleted classes.
- gtk/webkitdom.py:
(WebKitDOMDocGenerator):
(WebKitDOMDocGenerator.write_deleted_classes):
(WebKitDOMDocGenerator.generate):
(write_deleted_classes):
(WebKitDOMDocGeneratorSections._deleted_class):
(WebKitDOMDocGeneratorSections._deleted_class.in):
(WebKitDOMDocGeneratorSections.write_deleted_classes):
(WebKitDOMDocGeneratorSections.write_deleted_classes.with):
- 2:18 AM Changeset in webkit [190198] by
-
- 37 edits1 add1 delete in trunk/Source
[Streams API] Add support for JS builtins constructor
https://bugs.webkit.org/show_bug.cgi?id=149497
Reviewed by Darin Adler.
Source/JavaScriptCore:
- runtime/JSFunction.h: exporting createBuiltinFunction.
Source/WebCore:
Covered by existing tests.
Making CountQueuingStrategy fully JS built-in implemented.
Adding support for calling a JS builtin initialization function just after creating the JSXX object.
This JS function must be named initializeXX and be in XX.Js file.
The JSBuiltinConstructor keyword is added to the binding generator.
- CMakeLists.txt: Adding CountQueuingStrategy.js, removing JSCountQueuingStrategyCustom.cpp.
- DerivedSources.cpp: Ditto.
- DerivedSources.make: Ditto.
- Modules/streams/CountQueuingStrategy.h: Making CountQueuingStrategy a dummy class.
(WebCore::CountQueuingStrategy::create):
(WebCore::CountQueuingStrategy::~CountQueuingStrategy):
(WebCore::CountQueuingStrategy::CountQueuingStrategy):
- Modules/streams/CountQueuingStrategy.idl:
- Modules/streams/CountQueuingStrategy.js: Added.
(size):
(initializeCountQueuingStrategy):
- WebCore.vcxproj/WebCore.vcxproj: Removing JSCountQueuingStrategyCustom.cpp.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSBindingsAllInOne.cpp: Ditto.
- bindings/js/JSCountQueuingStrategyCustom.cpp: Removed.
- bindings/js/JSDOMBinding.cpp: Adding support for DOMConstructorJSBuiltinObject.
(WebCore::callInitializeFunction):
(WebCore::DOMConstructorJSBuiltinObject::visitChildren):
- bindings/js/JSDOMBinding.h: Diitto.
(WebCore::createFromJSBuiltin):
(WebCore::DOMConstructorJSBuiltinObject::DOMConstructorJSBuiltinObject):
- bindings/js/WebCoreJSClientData.h: Adding support for CQS builtins functions.
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::countQueuingStrategyBuiltins):
- bindings/scripts/CodeGeneratorJS.pm:
(GetJSBuiltinFunctionName):
(GetFunctionName):
(InstanceNeedsVisitChildren): Generating visitChildren method in case of JSBuiltinConstructor.
(GetParentConstructorClassName): Refactoring to make JSXXConstructor derive from DOMConstructorJSBuiltinObject in case of JSBuiltinConstructor.
(GenerateConstructorDeclaration): Ditto.
(GenerateConstructorDefinition): Generate specific constructor in case of JSBuiltinConstructor.
(GenerateConstructorHelperMethods): Refactoring to use Base class.
(IsConstructable): Ditto.
(ConstructorHasProperties): Deleted.
- bindings/scripts/IDLAttributes.txt: Adding JSBuiltinConstructor.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectConstructor::JSTestActiveDOMObjectConstructor):
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallbackConstructor::JSTestCallbackConstructor):
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::JSTestCustomConstructorWithNoInterfaceObjectConstructor):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterConstructor::JSTestCustomNamedGetterConstructor):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::JSTestEventConstructorConstructor):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetConstructor::JSTestEventTargetConstructor):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionConstructor::JSTestExceptionConstructor):
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::JSTestGenerateIsReachableConstructor::JSTestGenerateIsReachableConstructor):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorConstructor::JSTestNamedConstructorConstructor):
(WebCore::JSTestNamedConstructorNamedConstructor::JSTestNamedConstructorNamedConstructor):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::JSTestNodeConstructor):
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::JSTestNondeterministicConstructor::JSTestNondeterministicConstructor):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::JSTestObjConstructor):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::JSTestOverloadedConstructorsConstructor):
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::JSTestOverrideBuiltinsConstructor::JSTestOverrideBuiltinsConstructor):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::JSTestTypedefsConstructor):
- bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::JSattributeConstructor::JSattributeConstructor):
- bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::JSreadonlyConstructor::JSreadonlyConstructor):
