Timeline
Sep 30, 2015:
- 11:00 PM Changeset in webkit [190390] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, cleanup after r190385
TypedArray.prototype.js is removed at r190385.
Remove it from CMakeLists.txt as well.
- CMakeLists.txt:
- 10:54 PM Changeset in webkit [190389] by
-
- 2 edits in trunk/Tools
Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)
- BuildSlaveSupport/built-product-archive:
(determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
(extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
- 10:45 PM Changeset in webkit [190388] by
-
- 2 edits in trunk/Tools
Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)
Actually, we need to pass --configuration to script webkit-build-directory to have
it return the path to the configuration-specific build directory.
- BuildSlaveSupport/built-product-archive:
(determineWebKitBuildDirectories):
- 9:57 PM Changeset in webkit [190387] by
-
- 2 edits in trunk/Tools
built-product-archive archives incorrect build directory for iOS port
https://bugs.webkit.org/show_bug.cgi?id=149695
Reviewed by Darin Adler.
Fixes an issue where the script built-product-archive archives a non-existent
build directory for the iOS port. Without loss of generality, the script assumes
the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
Currently the script built-product-archive calls
webkit-build-directory --top-level ...
to determine the top-level build directory and computes the configuration-specific
build directory to be the concatenation of the the top-level build directory and
the configuration (e.g. Release). This is incorrect. Instead we should call
webkit-build-directory omitting the flag --top-level to compute the path to the
configuration-specific build directory.
- BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
(main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
its purpose and added global variable _configurationBuildDirectory to store the path
to the configuration-specific build directory. Ensure that we have a non-empty string
for both the top-level and configuration-specific build directories.
(determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
Compute the configuration-specific build directory and store it in the global variable
_configurationBuildDirectory.
(archiveBuiltProduct): Modified to use _configurationBuildDirectory.
(extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
as needed.
(determineWebKitBuildDirectory): Deleted.
- 9:21 PM Changeset in webkit [190386] by
-
- 2 edits in trunk/Tools
[EFL] css3/device-adapt/* tests failed after r190335.
https://bugs.webkit.org/show_bug.cgi?id=149655
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-09-30
Reviewed by Simon Fraser.
device-adapt/* tests need the fixedLayout option but useFixedLayout option is
overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
- WebKitTestRunner/efl/TestControllerEfl.cpp:
(WTR::shouldUseFixedLayout):
- 9:16 PM Changeset in webkit [190385] by
-
- 19 edits20 deletes in trunk
Unreviewed, rolling out r190367 and r190373.
https://bugs.webkit.org/show_bug.cgi?id=149694
Windows build broken (Requested by smfr on #webkit).
Reverted changesets:
"[ES6] Add TypedArray.prototype functionality."
https://bugs.webkit.org/show_bug.cgi?id=148035
http://trac.webkit.org/changeset/190367
"Unreviewed Windows buildfix."
http://trac.webkit.org/changeset/190373
- 8:55 PM Changeset in webkit [190384] by
-
- 2 edits in trunk/Source/WebCore
[EFL][Gtk] Try to fix the build after r190379.
https://bugs.webkit.org/show_bug.cgi?id=149693
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-09-30
Reviewed by Gyuyoung Kim.
- Modules/indexeddb/server/MemoryIDBBackingStore.h:
- 8:17 PM Changeset in webkit [190383] by
-
- 5 edits2 adds in trunk
Source/WebCore:
Add support for the imageSmoothingQuality property for CanvasRenderingContext2D.
https://bugs.webkit.org/show_bug.cgi?id=149541
Patch by Katlyn Graff <kgraff@apple.com> on 2015-09-30
Reviewed by Ryosuke Niwa.
As documented here: https://html.spec.whatwg.org/multipage/scripting.html#image-smoothing
Exposes the smooothing quality of algorithms used for scaling images. Valid input
values are low, medium, and high: associated algorithms are expected to vary for
differing hardware. setImageSmoothingQuality provides a handle into CGInterpolationQuality.
Test: fast/canvas/canvas-imageSmoothingQuality.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::State::operator=):
(WebCore::smoothingToInterpolationQuality):
(WebCore::CanvasRenderingContext2D::imageSmoothingQuality):
(WebCore::CanvasRenderingContext2D::setImageSmoothingQuality):
(WebCore::CanvasRenderingContext2D::setImageSmoothingEnabled):
- html/canvas/CanvasRenderingContext2D.h:
- html/canvas/CanvasRenderingContext2D.idl:
LayoutTests:
Tests support for imageSmoothingQuality attribute of Canvas element.
https://bugs.webkit.org/show_bug.cgi?id=149541
Patch by Katlyn Graff <kgraff@apple.com> on 2015-09-30
Reviewed by Ryosuke Niwa.
Tests low, medium, high, and default values, value persistence when
imageSmoothingEnabled is changed, and invalid input.
- fast/canvas/canvas-imageSmoothingQuality-expected.txt: Added.
- fast/canvas/canvas-imageSmoothingQuality.html: Added.
- 6:39 PM Changeset in webkit [190382] by
-
- 2 edits in trunk/Source/WebCore
GraphicsContext3D::mappedSymbolName should initialize count variable
https://bugs.webkit.org/show_bug.cgi?id=149692
<rdar://problem/22871304>
Reviewed by Simon Fraser.
While debugging another WebGL issue, I noticed that some
OpenGL renderers can get into a state where they
drop resources (e.g. a GPU reset). If we don't detect that
in time, we might try to ask for the currently attached
resources and our in-parameter will not be set. In this
case, initialize it to zero so that we don't do silly things.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::mappedSymbolName): Initialize count to 0.
- 6:32 PM Changeset in webkit [190381] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: Reduce
deletein Timeline related classes
https://bugs.webkit.org/show_bug.cgi?id=149686
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-30
Reviewed by Timothy Hatcher.
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype.capturingStopped):
- UserInterface/Views/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid.prototype._refreshDirtyDataGridNodes):
(WebInspector.TimelineDataGrid.prototype._sort):
(WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype.updateLayout):
(WebInspector.TimelineOverview.prototype._handleScrollEvent):
- UserInterface/Views/TreeOutlineDataGridSynchronizer.js:
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeOutlineScrolled):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._dataGridScrolled):
- UserInterface/Views/ProbeSetDataGrid.js:
(WebInspector.ProbeSetDataGrid):
(WebInspector.ProbeSetDataGrid.prototype._teardownData):
Remove an unused member variable as well.
- 6:29 PM Changeset in webkit [190380] by
-
- 2 edits in trunk/Source/WebCore
Crash in gleLookupHashObject when context is lost
https://bugs.webkit.org/show_bug.cgi?id=149690
<rdar://problem/22751585>
<rdar://problem/22465495>
Reviewed by Simon Fraser.
When we received notification that the GPU has reset,
we were nulling out and deleting our OpenGL contexts
and then trying to do it all over again. The fix was
to flip the order of operations.
While there I added some logging, and changed the
way we check GPU status to make sure we do a check
after the first draw call.
Unfortunately we can't test automatically because it
involves resetting the GPU which can possibly cause
concurrent tests to fail.
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::checkGPUStatusIfNecessary): Move forceContextLost()
to be the first thing we do after we've realised we need to
bail.
- 6:04 PM Changeset in webkit [190379] by
-
- 19 edits8 copies3 adds in trunk
Add UniqueIDBDatabase object, IDBBackingStore objects, and a database operation thread.
https://bugs.webkit.org/show_bug.cgi?id=149678
Reviewed by Alex Christensen.
Source/WebCore:
Test: storage/indexeddb/modern/opendatabase-request-event.html
- UniqueIDBDatabase represents a specific IDB database instance that can have multiple connections to it.
- IDBBackingStore is an abstract representation of a unique database's backing store, and has a concrete in-memory implementation for now.
- The database thread exists on IDBServer and is for offloading actual database I/O from the main thread.
- CMakeLists.txt:
- Modules/indexeddb/IDBDatabaseIdentifier.cpp:
(WebCore::IDBDatabaseIdentifier::isolatedCopy):
- Modules/indexeddb/IDBDatabaseIdentifier.h:
- Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::openDatabase):
(WebCore::IDBClient::IDBConnectionToServer::didOpenDatabase):
- Modules/indexeddb/client/IDBConnectionToServer.h:
- Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
- Modules/indexeddb/client/IDBFactoryImpl.cpp:
(WebCore::IDBClient::IDBFactory::openInternal):
- Modules/indexeddb/server/IDBBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/server/IDBConnectionToClientDelegate.h.
(WebCore::IDBServer::IDBBackingStore::~IDBBackingStore):
- Modules/indexeddb/server/IDBConnectionToClient.cpp:
(WebCore::IDBServer::IDBConnectionToClient::didOpenDatabase):
- Modules/indexeddb/server/IDBConnectionToClient.h:
- Modules/indexeddb/server/IDBConnectionToClientDelegate.h:
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::IDBServer):
(WebCore::IDBServer::IDBServer::getOrCreateUniqueIDBDatabase):
(WebCore::IDBServer::IDBServer::createBackingStore):
(WebCore::IDBServer::IDBServer::openDatabase):
(WebCore::IDBServer::IDBServer::deleteDatabase):
(WebCore::IDBServer::IDBServer::postDatabaseTask):
(WebCore::IDBServer::IDBServer::postDatabaseTaskReply):
(WebCore::IDBServer::IDBServer::databaseThreadEntry):
(WebCore::IDBServer::IDBServer::databaseRunLoop):
(WebCore::IDBServer::IDBServer::handleTaskRepliesOnMainThread):
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/IDBServerOperation.cpp: Copied from Source/WebCore/Modules/indexeddb/server/IDBConnectionToClientDelegate.h.
(WebCore::IDBServer::IDBServerOperation::create):
(WebCore::IDBServer::IDBServerOperation::IDBServerOperation):
- Modules/indexeddb/server/IDBServerOperation.h: Copied from Source/WebCore/Modules/indexeddb/server/IDBServer.h.
(WebCore::IDBServer::IDBServerOperation::connection):
(WebCore::IDBServer::IDBServerOperation::requestData):
- Modules/indexeddb/server/MemoryIDBBackingStore.cpp: Copied from Source/WebCore/Modules/indexeddb/server/IDBConnectionToClient.cpp.
(WebCore::IDBServer::MemoryIDBBackingStore::create):
(WebCore::IDBServer::MemoryIDBBackingStore::MemoryIDBBackingStore):
(WebCore::IDBServer::MemoryIDBBackingStore::~MemoryIDBBackingStore):
(WebCore::IDBServer::MemoryIDBBackingStore::getOrEstablishDatabaseInfo):
- Modules/indexeddb/server/MemoryIDBBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/server/IDBConnectionToClient.h.
- Modules/indexeddb/server/UniqueIDBDatabase.cpp: Added.
(WebCore::IDBServer::UniqueIDBDatabase::UniqueIDBDatabase):
(WebCore::IDBServer::UniqueIDBDatabase::openDatabaseConnection):
(WebCore::IDBServer::UniqueIDBDatabase::handleOpenDatabaseOperations):
(WebCore::IDBServer::UniqueIDBDatabase::openBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::didOpenBackingStore):
- Modules/indexeddb/server/UniqueIDBDatabase.h: Copied from Source/WebCore/Modules/indexeddb/server/IDBServer.h.
(WebCore::IDBServer::UniqueIDBDatabase::create):
- Modules/indexeddb/shared/IDBDatabaseInfo.cpp: Copied from Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h.
(WebCore::IDBDatabaseInfo::IDBDatabaseInfo):
(WebCore::IDBDatabaseInfo::isolatedCopy):
- Modules/indexeddb/shared/IDBDatabaseInfo.h: Copied from Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h.
(WebCore::IDBDatabaseInfo::IDBDatabaseInfo):
- Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::didDeleteDatabase):
(WebCore::InProcessIDBServer::openDatabase):
(WebCore::InProcessIDBServer::didOpenDatabase):
- Modules/indexeddb/shared/InProcessIDBServer.h:
- WebCore.xcodeproj/project.pbxproj:
- platform/CrossThreadCopier.cpp:
(WebCore::IDBDatabaseInfo>::copy):
(WebCore::IDBDatabaseIdentifier>::copy):
- platform/CrossThreadCopier.h:
LayoutTests:
- storage/indexeddb/modern/opendatabase-request-event-expected.txt: Added.
- storage/indexeddb/modern/opendatabase-request-event.html: Added.
- 5:40 PM Changeset in webkit [190378] by
-
- 2 edits in trunk/Tools
Extend JetStream timeout for slow devices.
Reviewed by Chris Dumez.
Extend JetStream timeout to 20 minutes.
- Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
- 5:26 PM Changeset in webkit [190377] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Thousands of timers fire after switching to JavaScript and Events timeline
https://bugs.webkit.org/show_bug.cgi?id=149682
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-30
Reviewed by Timothy Hatcher.
Setting the status element of a GeneralTreeElement was triggering a
TreeOutline.onchange event. For TreeOutlines with lots of tree elements
(JavaScript & Events with profile nodes) this could result in thousands
of onchange events that causes lots of unnecessary work and blocks
future timers (like scroll synchronization) from firing.
This change eliminates TreeOutline change events for tree element
changes that are not interesting.
- UserInterface/Views/GeneralTreeElement.js:
(WebInspector.GeneralTreeElement.prototype.set status): Deleted.
- UserInterface/Views/TreeOutline.js:
(WebInspector.TreeElement.prototype.set tooltip): Deleted.
- 5:08 PM Changeset in webkit [190376] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: Reduce
deletein TreeElements and DataGridNodes
https://bugs.webkit.org/show_bug.cgi?id=149680
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-30
Reviewed by Timothy Hatcher.
- UserInterface/Views/BreakpointTreeElement.js:
(WebInspector.BreakpointTreeElement):
(WebInspector.BreakpointTreeElement.prototype._removeProbeSet):
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype._editingCommitted.moveToNextCell):
(WebInspector.DataGrid.prototype._editingCommitted):
(WebInspector.DataGrid.prototype._editingCancelled):
(WebInspector.DataGrid.prototype.removeColumn):
(WebInspector.DataGridNode.prototype.refreshIfNeeded):
(WebInspector.DataGridNode.prototype.refresh):
(WebInspector.DataGridNode.prototype.expand):
(WebInspector.DataGridNode.prototype.restorePosition):
(WebInspector.DataGridNode):
- UserInterface/Views/GeneralTreeElement.js:
(WebInspector.GeneralTreeElement.prototype.ondetach):
- UserInterface/Views/ResourceTimelineDataGridNode.js:
(WebInspector.ResourceTimelineDataGridNode.prototype.refresh):
- UserInterface/Views/TreeOutline.js:
(WebInspector.TreeElement.prototype._fireDidChange):
(WebInspector.TreeElement.prototype.expand):
- 5:04 PM Changeset in webkit [190375] by
-
- 4 edits2 adds in trunk
Crash when using an SVG font with > 390 glyphs
https://bugs.webkit.org/show_bug.cgi?id=149677
<rdar://problem/21676402>
Reviewed by Simon Fraser.
Source/WebCore:
The "Charset Index" in OTF are indices into a collection of strings. There are
390 predefined strings in this collection. We were currently assigning each
glyph to one of these strings. However, if there are more glyphs than strings,
we will be using invalid indices.
The values of the strings themselves are not necessary for SVG fonts. Therefore,
the solution is to create a single dummy string, and have all glyphs target it.
Tests: svg/custom/many-glyphs.svg
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::font):
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::appendCFFTable):
LayoutTests:
- svg/custom/many-glyphs-expected.svg: Added.
- svg/custom/many-glyphs.svg: Added.
- 4:56 PM Changeset in webkit [190374] by
-
- 3 edits in trunk/Tools
Rename iOS builders/testers to include version
https://bugs.webkit.org/show_bug.cgi?id=149685
Reviewed by Simon Fraser.
Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
make it clear to a reader the version of iOS these builders/testers are using.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
- 4:34 PM Changeset in webkit [190373] by
-
- 1 edit in trunk/Source/JavaScriptCore/ChangeLog
Fixed change set order to match reality. Some how the tools messed up the merge of ChangeLog entries.
-This line, and those below, will be ignored--
M Source/JavaScriptCore/ChangeLog
- 4:27 PM Changeset in webkit [190372] by
-
- 2 edits in trunk/Source/JavaScriptCore
Relanding r190289 with the following two fixes:
- REGRESSION(r190289): It made Speedometer/Full.html performance test fail https://bugs.webkit.org/show_bug.cgi?id=149621
Reviewed by Saam Barati.
We need to restore callee saves for both the fast and slow paths before making a
tail call in the FTL.
- ftl/FTLJSCallBase.cpp: (JSC::FTL::JSCallBase::emit):
- [ARM] REGRESSION(r190289): It made 374 tests crash on 32 bit ARM Linux https://bugs.webkit.org/show_bug.cgi?id=149619
Reviewed by Filip Pizlo.
Need to check for ARMv7_TRADITIONAL and ARMv7 in addition to ARM in "if"
statement to handle platforms with a link register.
- llint/LowLevelInterpreter.asm: (prepareForTailCall):
Patch by Michael Saboff <msaboff@apple.com> on 2015-09-30
- 4:03 PM Changeset in webkit [190371] by
-
- 3 edits in trunk/Tools
Add iOS criterion for triggering a build
https://bugs.webkit.org/show_bug.cgi?id=149679
Rubber-stamped by Alexey Proskuryakov.
First pass at defining criterion for triggering an iOS build.
- BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
(_should_file_trigger_build):
- BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
(ShouldBuildTest):
(ShouldBuildTest.test_should_build):
- 3:51 PM Writing Layout Tests to test iOS UI features edited by
- (diff)
- 3:48 PM Writing Layout Tests to test iOS UI features edited by
- (diff)
- 3:44 PM Writing Layout Tests to test iOS UI features edited by
- (diff)
- 3:38 PM Writing Layout Tests to test iOS UI features edited by
- (diff)
- 3:28 PM Changeset in webkit [190370] by
-
- 34 edits8 adds in trunk
Source/JavaScriptCore:
Relanding r190289 with the following two fixes:
- REGRESSION(r190289): It made Speedometer/Full.html performance test fail https://bugs.webkit.org/show_bug.cgi?id=149621
Reviewed by Saam Barati.
We need to restore callee saves for both the fast and slow paths before making a
tail call in the FTL.
- ftl/FTLJSCallBase.cpp: (JSC::FTL::JSCallBase::emit):
- [ARM] REGRESSION(r190289): It made 374 tests crash on 32 bit ARM Linux https://bugs.webkit.org/show_bug.cgi?id=149619
Reviewed by Filip Pizlo.
Need to check for ARMv7_TRADITIONAL and ARMv7 in addition to ARM in "if"
statement to handle platforms with a link register.
- llint/LowLevelInterpreter.asm: (prepareForTailCall):
LayoutTests:
Relanding r190289 after fixes tracked in https://bugs.webkit.org/show_bug.cgi?id=149619
and https://bugs.webkit.org/show_bug.cgi?id=149621
Reviewed by Saam Barati.
- 3:26 PM Writing Layout Tests to test iOS UI features edited by
- (diff)
- 3:23 PM Writing Layout Tests to test iOS UI features edited by
- (diff)
- 3:13 PM Writing Layout Tests to test iOS UI features edited by
- (diff)
- 3:11 PM Changeset in webkit [190369] by
-
- 1 edit1 add in trunk/Source/WebInspectorUI
[GTK] Web Inspector: Add GTK+ icon for the Bezier curve visual editor
https://bugs.webkit.org/show_bug.cgi?id=147681
Reviewed by Joseph Pecoraro.
- UserInterface/Images/gtk/CubicBezier.svg: Added.
- 3:08 PM Writing Layout Tests to test iOS UI features edited by
- (diff)
- 3:00 PM Writing Layout Tests to test iOS UI features created by
- 2:56 PM WikiStart edited by
- (diff)
- 2:48 PM Changeset in webkit [190368] by
-
- 15 edits2 copies7 adds in trunk
[iOS] Allow tests to generate user gestures for UI testing
https://bugs.webkit.org/show_bug.cgi?id=149653
Reviewed by Tim Horton.
Tools:
Expose functionality in UIScriptController to allow for testing single- and double-tap,
and to listen for completion of scrolling and zooming in the WKWebView.
Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
which hides the complexity of creating these events. Event dispatch is asynchronous.
We detect when the last event has been handled by dispatching a vendor-specific event,
which is detected via -_handleHIDEvent: in our UIApplication subclass.
- WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
- WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
single and double taps.
- WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
(UIScriptContext::registerCallback): Used to store the callbacks for zooming.
Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
(UIScriptContext::unregisterCallback):
(UIScriptContext::callbackWithID):
(UIScriptContext::fireCallback):
- WebKitTestRunner/UIScriptContext/UIScriptContext.h:
- WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
(WTR::UIScriptController::willBeginZoomingCallback): Ditto.
(WTR::UIScriptController::setDidEndZoomingCallback):
(WTR::UIScriptController::didEndZoomingCallback):
(WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
(WTR::UIScriptController::doubleTapAtPoint): Ditto.
(WTR::UIScriptController::platformSetWillBeginZoomingCallback):
(WTR::UIScriptController::platformSetDidEndZoomingCallback):
- WebKitTestRunner/UIScriptContext/UIScriptController.h:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
- WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
(-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
(-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
(-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
- WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
- WebKitTestRunner/ios/HIDEventGenerator.m: Added.
(simpleDragCurve):
(calculateNextLocation):
(delayBetweenMove):
(+[HIDEventGenerator sharedHIDEventGenerator]):
(+[HIDEventGenerator nextEventCallbackID]):
(-[HIDEventGenerator init]):
(-[HIDEventGenerator _createIOHIDEventType:]):
(-[HIDEventGenerator _sendHIDEvent:]):
(-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
(-[HIDEventGenerator _updateTouchPoints:count:]):
(-[HIDEventGenerator touchDownAtPoints:touchCount:]):
(-[HIDEventGenerator touchDown:touchCount:]):
(-[HIDEventGenerator touchDown:]):
(-[HIDEventGenerator liftUpAtPoints:touchCount:]):
(-[HIDEventGenerator liftUp:touchCount:]):
(-[HIDEventGenerator liftUp:]):
(-[HIDEventGenerator moveToPoints:touchCount:duration:]):
(-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
(-[HIDEventGenerator tap:completionBlock:]):
(-[HIDEventGenerator doubleTap:completionBlock:]):
(-[HIDEventGenerator twoFingerTap:completionBlock:]):
(-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
(-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
(-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
(-[HIDEventGenerator markerEventReceived:]):
- WebKitTestRunner/ios/IOKitSPI.h: Added.
- WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::globalToContentCoordinates):
(WTR::UIScriptController::singleTapAtPoint):
(WTR::UIScriptController::doubleTapAtPoint):
(WTR::UIScriptController::platformSetWillBeginZoomingCallback):
(WTR::UIScriptController::platformSetDidEndZoomingCallback):
- WebKitTestRunner/ios/mainIOS.mm:
(-[WebKitTestRunnerApp _handleHIDEvent:]):
LayoutTests:
Simple tests for single tap triggering a click, and double-tap zoom.
- TestExpectations:
- fast/events/ios/double-tap-zoom-expected.txt: Added.
- fast/events/ios/double-tap-zoom.html: Added.
- fast/events/ios/single-tap-generates-click-expected.txt: Added.
- fast/events/ios/single-tap-generates-click.html: Added.
- platform/ios-simulator-wk2/TestExpectations:
- 2:00 PM Changeset in webkit [190367] by
-
- 19 edits1 copy21 adds in trunk
[ES6] Add TypedArray.prototype functionality.
https://bugs.webkit.org/show_bug.cgi?id=148035
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
This patch should add most of the functionality for
the prototype properties of TypedArray objects in ES6.
There are a few exceptions to this, which will be added
in upcoming patches:
1) First we do not use the species constructor for some
of the TypedArray prototype functions (namely: map, filter,
slice, and subarray). That will need to be added when
species constructors are finished.
2) TypedArrays still have a length, byteOffset, byteLength,
and buffer are still attached to the TypedArray instance (in
the spec they are on the TypedArray.prototype instance object)
since the JIT currently assumes those properties are fixed.
3) The TypedArray.constructor property is not added yet
as it should point to the TypedArray instance object,
which will be added in a future patch.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- builtins/TypedArray.prototype.js: Added.
(every):
(find):
(findIndex):
(forEach):
(some):
(sort.min):
(sort.merge):
(sort.mergeSort):
(sort):
(reduce):
(reduceRight):
(map):
(filter):
(toLocaleString):
- runtime/ArrayPrototype.cpp:
- runtime/ArrayPrototype.h:
- runtime/CommonIdentifiers.h:
- runtime/JSGenericTypedArrayView.h:
(JSC::JSGenericTypedArrayView::toAdaptorNativeFromValue):
(JSC::JSGenericTypedArrayView::setRangeToValue):
(JSC::JSGenericTypedArrayView::sort):
(JSC::JSGenericTypedArrayView::purifyArray):
(JSC::JSGenericTypedArrayView::sortComparison):
(JSC::JSGenericTypedArrayView::sortFloat):
- runtime/JSGenericTypedArrayViewInlines.h:
- runtime/JSGenericTypedArrayViewPrototypeFunctions.h: Added.
(JSC::argumentClampedIndexFromStartOrEnd):
(JSC::genericTypedArrayViewProtoFuncSet):
(JSC::genericTypedArrayViewProtoFuncEntries):
(JSC::genericTypedArrayViewProtoFuncCopyWithin):
(JSC::genericTypedArrayViewProtoFuncFill):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncJoin):
(JSC::genericTypedArrayViewProtoFuncKeys):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):
(JSC::genericTypedArrayViewProtoGetterFuncLength):
(JSC::genericTypedArrayViewProtoGetterFuncByteLength):
(JSC::genericTypedArrayViewProtoGetterFuncByteOffset):
(JSC::genericTypedArrayViewProtoFuncReverse):
(JSC::genericTypedArrayViewPrivateFuncSort):
(JSC::genericTypedArrayViewProtoFuncSlice):
(JSC::genericTypedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncValues):
- runtime/JSGenericTypedArrayViewPrototypeInlines.h:
(JSC::JSGenericTypedArrayViewPrototype<ViewClass>::finishCreation):
(JSC::genericTypedArrayViewProtoFuncSet): Deleted.
(JSC::genericTypedArrayViewProtoFuncSubarray): Deleted.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/JSObject.h:
- runtime/JSTypedArrayPrototypes.cpp:
- runtime/JSTypedArrayPrototypes.h:
- runtime/JSTypedArrayViewPrototype.cpp: Added.
(JSC::typedArrayViewPrivateFuncLength):
(JSC::typedArrayViewPrivateFuncSort):
(JSC::typedArrayViewProtoFuncSet):
(JSC::typedArrayViewProtoFuncEntries):
(JSC::typedArrayViewProtoFuncCopyWithin):
(JSC::typedArrayViewProtoFuncFill):
(JSC::typedArrayViewProtoFuncLastIndexOf):
(JSC::typedArrayViewProtoFuncIndexOf):
(JSC::typedArrayViewProtoFuncJoin):
(JSC::typedArrayViewProtoFuncKeys):
(JSC::typedArrayViewProtoGetterFuncLength):
(JSC::typedArrayViewProtoGetterFuncByteLength):
(JSC::typedArrayViewProtoGetterFuncByteOffset):
(JSC::typedArrayViewProtoFuncReverse):
(JSC::typedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncSlice):
(JSC::typedArrayViewProtoFuncValues):
(JSC::JSTypedArrayViewPrototype::JSTypedArrayViewPrototype):
(JSC::JSTypedArrayViewPrototype::finishCreation):
(JSC::JSTypedArrayViewPrototype::create):
(JSC::JSTypedArrayViewPrototype::createStructure):
- runtime/JSTypedArrayViewPrototype.h: Copied from Source/JavaScriptCore/runtime/JSTypedArrayPrototypes.cpp.
- tests/stress/resources/standalone-pre.js: Added.
(description):
(debug):
(escapeString):
(testPassed):
(testFailed):
(areNumbersEqual):
(areArraysEqual):
(isMinusZero):
(isTypedArray):
(isResultCorrect):
(stringify):
(shouldBe):
(dfgShouldBe):
(shouldBeType):
(shouldBeTrue):
(shouldBeFalse):
(shouldBeNaN):
(shouldBeNull):
(shouldBeEqualToString):
(shouldBeUndefined):
(shouldNotThrow):
(shouldThrow):
(dfgCompiled):
(dfgIncrement):
(noInline):
(finishJSTest):
- tests/stress/resources/typedarray-test-helper-functions.js: Added.
(forEachTypedArray):
(isSameFunctionForEachTypedArrayPrototype.eq):
(isSameFunctionForEachTypedArrayPrototype):
(hasSameValues):
(.foo):
(testPrototypeFunctionHelper):
(testPrototypeFunctionOnSigned):
(testPrototypeFunctionOnFloat):
(testPrototypeFunction):
(.tester):
(testPrototypeReceivesArray):
- tests/stress/typedarray-copyWithin.js: Added.
- tests/stress/typedarray-every.js: Added.
(isBigEnough):
(isBigEnoughAndChange):
(isBigEnoughAndException):
- tests/stress/typedarray-fill.js: Added.
- tests/stress/typedarray-filter.js: Added.
(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):
- tests/stress/typedarray-find.js: Added.
(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):
- tests/stress/typedarray-findIndex.js: Added.
(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):
- tests/stress/typedarray-forEach.js: Added.
(.checkCorrect.let.list):
(.checkCorrect):
(createChecker):
(foo):
(changeArray):
(isBigEnoughAndException):
- tests/stress/typedarray-indexOf.js: Added.
(keepEven):
- tests/stress/typedarray-lastIndexOf.js: Added.
- tests/stress/typedarray-map.js: Added.
(even):
(evenAndChange):
(isBigEnoughAndException):
- tests/stress/typedarray-reduce.js: Added.
(createArray):
(sum):
(createArrayAndChange):
(isBigEnoughAndException):
- tests/stress/typedarray-reduceRight.js: Added.
(createArray):
(sum):
(createArrayAndChange):
(isBigEnoughAndException):
- tests/stress/typedarray-slice.js: Added.
- tests/stress/typedarray-some.js: Added.
(isBigEnough):
(isBigEnoughAndChange):
(isBigEnoughAndException):
- tests/stress/typedarray-sort.js: Added.
(sortBackwards):
(compareException):
LayoutTests:
Fixed tests for new toString behavior on TypedArrays.
- fast/canvas/webgl/type-conversion-test-expected.txt:
- fast/dom/Window/window-postmessage-clone-expected.txt:
- 1:05 PM Changeset in webkit [190366] by
-
- 2 edits in trunk/Tools
git-add-reviewer should trim trailing spaces/newlines
https://bugs.webkit.org/show_bug.cgi?id=149513
Reviewed by Darin Adler.
- Scripts/git-add-reviewer:
(nonInteractive):
- 1:00 PM Changeset in webkit [190365] by
-
- 3 edits in trunk/LayoutTests
Compute document marker rects at use time instead of paint time
https://bugs.webkit.org/show_bug.cgi?id=149643
- fast/text/mark-matches-overflow-clip-expected.txt:
- fast/text/mark-matches-overflow-clip.html:
Adjust one recently-added test and its result slightly.
- 12:44 PM Changeset in webkit [190364] by
-
- 15 edits in trunk/Source
Unreviewed, roll out r188331: "NetworkProcess: DNS prefetch happens in the Web Process"
<rdar://problem/22560715>
Speculative roll out of r188331 as we had a ~2.5% PLT regression around
the time it landed and it seems the most likely culprit. I'll reland if
the perf bots do not recover after the roll out.
Source/WebCore:
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):
- loader/FrameLoaderClient.h:
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLink):
- page/Chrome.cpp:
(WebCore::Chrome::mouseDidMoveOverElement):
Source/WebKit2:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::storageSession): Deleted.
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:
(webkitWebExtensionDidReceiveMessage):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):
- WebProcess/WebProcess.cpp:
- WebProcess/WebProcess.h:
- 12:36 PM Changeset in webkit [190363] by
-
- 27 edits in trunk/Source
Compute document marker rects at use time instead of paint time
https://bugs.webkit.org/show_bug.cgi?id=149643
Reviewed by Darin Adler.
- dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::DocumentMarkerController):
(WebCore::DocumentMarkerController::detach):
Store and zero the Document backpointer.
(WebCore::DocumentMarkerController::addMarker):
(WebCore::DocumentMarkerController::addTextMatchMarker):
(WebCore::DocumentMarkerController::addDictationPhraseWithAlternativesMarker):
(WebCore::DocumentMarkerController::addDictationResultMarker):
(WebCore::DocumentMarkerController::copyMarkers):
Remove some useless comments.
(WebCore::updateRenderedRectsForMarker):
Use Range to compute the (unclipped, absolute) text rects, and store them
on the RenderedDocumentMarker.
(WebCore::DocumentMarkerController::invalidateRectsForAllMarkers):
(WebCore::DocumentMarkerController::invalidateRectsForMarkersInNode):
Mark the relevant markers' rects as invalid, and notify the ChromeClient.
(WebCore::DocumentMarkerController::updateRectsForInvalidatedMarkersOfType):
Run through all markers, computing rects for ones that don't have valid rects.
We will do layout (once) if necessary. However, this is most commonly
called from a place where layout should already be up to date, so this
should not happen often. updateRenderedRectsForMarker also asserts
that layout is up to date.
(WebCore::DocumentMarkerController::renderedRectsForMarkers):
Retrieve all markers of the given type, clip them by overflow clip and
frame clip, and return them to the caller.
(WebCore::DocumentMarkerController::addMarker):
(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::markersFor):
(WebCore::DocumentMarkerController::repaintMarkers):
(WebCore::DocumentMarkerController::shiftMarkers):
(DocumentMarkerController::setMarkersActive):
(DocumentMarkerController::hasMarkers):
Modern iteration.
(WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect): Deleted.
- dom/DocumentMarkerController.h:
- dom/Document.cpp:
(WebCore::Document::Document):
Pass the Document to the DocumentMarkerController.
- dom/RenderedDocumentMarker.h:
(WebCore::RenderedDocumentMarker::contains):
(WebCore::RenderedDocumentMarker::setUnclippedAbsoluteRects):
(WebCore::RenderedDocumentMarker::unclippedAbsoluteRects):
(WebCore::RenderedDocumentMarker::invalidate):
(WebCore::RenderedDocumentMarker::isValid):
(WebCore::RenderedDocumentMarker::addRenderedRect): Deleted.
(WebCore::RenderedDocumentMarker::renderedRects): Deleted.
Instead of keeping "rendered" rects, keep unclipped rects in absolute
document coordinates. Invalidation will happen wholesale instead of
based on dirty rects, because computation no longer happens at paint
time, so it's safe to throw all of the rects away.
Keep track of whether we have valid rects or not.
- editing/Editor.cpp:
(WebCore::Editor::countMatchesForText):
We don't need to do a fake whole-document paint just to compute the
document marker rects. They are computed on demand, using layout information
instead of paint-time information.
- page/ChromeClient.h:
Remove an unnecessary semicolon.
Add didInvalidateDocumentMarkerRects, which DocumentMarkerController
will call whenever document marker rects are invalidated (and when e.g.
the find holes PageOverlay should repaint itself).
- page/FrameView.cpp:
(WebCore::FrameView::layout):
Invalidate document marker's layout-computed rects after layout is complete.
They'll be lazily recomputed when next requested.
(WebCore::FrameView::willPaintContents):
Remove the pre-painting invalidation of document marker rects.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::paintDocumentMarker): Deleted.
(WebCore::InlineTextBox::computeRectForReplacementMarker): Deleted.
(WebCore::InlineTextBox::paintDocumentMarkers): Deleted.
Don't bother computing rendered rects for document markers at paint time.
Just do the actual painting work (which, for replacement markers, is
nothing at all).
- rendering/InlineTextBox.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
When RenderLayers move, invalidate document marker rects.
- rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::paint):
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer): Deleted.
- rendering/svg/SVGInlineFlowBox.h:
- rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::paint):
Don't bother computing rendered rects for document markers at paint time.
- testing/Internals.cpp:
(WebCore::markerTypeFrom):
(WebCore::markerTypesFrom):
Add markerTypeFrom, which returns MarkerType enum values for the input string
instead of a MarkerTypes class.
(WebCore::Internals::dumpMarkerRects):
Dump all markers for the given type, and request them from DocumentMarkerController
instead of from the RenderedDocumentMarker, because we want fully clipped
rects, which can only be obtained from DocumentMarkerController.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::getTextRectangles):
Avoid enclosing unnecessarily, to avoid inflating zero-width text rects
to have a non-zero width. Callers appear to be OK with non-integral positions.
- testing/Internals.h:
- testing/Internals.idl:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::didInvalidateDocumentMarkerRects):
- WebProcess/WebCoreSupport/WebChromeClient.h:
Plumb the notification about invalidated document marker rects through to FindController.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindUIAfterPageScroll):
Make a document-relative PageOverlay, so that we get fast scrolling.
(WebKit::FindController::rectsForTextMatchesInRect):
Return find hole rects in main-FrameView content coordinates, to
match the document-relative page overlay.
We'll only return rects that intersect the passed-in rect, which
comes from the dirty rect passed to drawRect.
(WebKit::FindController::drawRect):
Inflate the dirty rect by the border width so that we hit all relevant
markers in each tile. Otherwise, we would end up missing the border of a marker
that touched the edge of a tile.
(WebKit::FindController::didInvalidateDocumentMarkerRects):
Repaint (for now, the entire overlay) when document marker rects change.
- WebProcess/WebPage/FindController.h:
- WebView/WebHTMLView.mm:
(-[WebHTMLView rectsForTextMatches]):
- WebView.cpp:
(WebView::rectsForTextMatches):
- 12:16 PM Changeset in webkit [190362] by
-
- 15 edits in trunk
REGRESSION(r190262): User media unit test failures after r190262
https://bugs.webkit.org/show_bug.cgi?id=149580
Reviewed by Darin Adler.
Source/WebCore:
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::getStats): Drive-by fix to deal with optional param.
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::constraintsValidated): Swap the track parameter order.
- Modules/mediastream/UserMediaRequest.h:
- platform/mediastream/MediaStreamCreationClient.h:
(WebCore::MediaStreamCreationClient::validateRequestConstraints): Swap the track parameter order.
- platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:
(WebCore::RealtimeMediaSourceCenterMac::validateRequestConstraints): If there is no
constraint for a media type, don't return a device of that type.
- platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:
(WebCore::RealtimeMediaSourceCenterOwr::mediaSourcesAvailable): Ditto.
- platform/mock/MockRealtimeMediaSourceCenter.cpp:
(WebCore::MockRealtimeMediaSourceCenter::validateRequestConstraints): Ditto.
- platform/mock/TimerEventBasedMock.h:
(WebCore::TimerEvent::~TimerEvent): Clear the m_mock pointer.
- platform/mock/UserMediaClientMock.h:
(WebCore::UserMediaClientMock::fire): Deal with empty device vectors.
- testing/Internals.cpp:
(WebCore::Internals::Internals): Don't register UserMediaController, it isn't needed for
WKTR.
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
order to WKUserMediaPermissionRequestAllow.
LayoutTests:
- platform/gtk/TestExpectations: Unskip tests.
- 12:10 PM Changeset in webkit [190361] by
-
- 2 edits in trunk
[Win] Unreviewed build fix after CMake conversion.
- Source/cmake/OptionsWin.cmake: Correct some Windows build flags.
- 11:57 AM Changeset in webkit [190360] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js
Add El Capitan to the dashboard.
- 11:19 AM Changeset in webkit [190359] by
-
- 3 edits in trunk/Tools
Add iOS builders and testers
https://bugs.webkit.org/show_bug.cgi?id=149549
Reviewed by Alexey Proskuryakov.
Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
- BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
- BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
- 10:56 AM Changeset in webkit [190358] by
-
- 2 edits1 add in trunk/Tools
Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
https://bugs.webkit.org/show_bug.cgi?id=149674
Reviewed by Lucas Forschler.
- WebKitLauncher/WebKitLauncher.entitlements: Added.
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
- 10:53 AM Changeset in webkit [190357] by
-
- 5 edits in trunk/Source
Versioning.
- 10:51 AM Changeset in webkit [190356] by
-
- 1 copy in tags/Safari-602.1.5
New tag.
- 10:49 AM Changeset in webkit [190355] by
-
- 2 edits in trunk/Tools
BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
have an associated trac instance.
https://bugs.webkit.org/show_bug.cgi?id=149673
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
have an associated trac instance.
- 10:43 AM Changeset in webkit [190354] by
-
- 2 edits in trunk/Tools
Prioritize testing latest build request on iOS test bots
https://bugs.webkit.org/show_bug.cgi?id=149669
Reviewed by Darin Adler.
We should prioritize testing of the latest build request on the iOS test bots
as we do for Mac and Windows test bots.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(loadBuilderConfig):
- 10:28 AM Changeset in webkit [190353] by
-
- 3 edits in trunk/Tools
Add buildbot category for iOS builders and testers
https://bugs.webkit.org/show_bug.cgi?id=149667
Reviewed by Darin Adler.
Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
for iOS to the build.webkit.org home page.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(loadBuilderConfig):
- BuildSlaveSupport/build.webkit.org-config/templates/root.html:
- 10:23 AM Changeset in webkit [190352] by
-
- 2 edits in trunk/Tools
Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
(https://bugs.webkit.org/show_bug.cgi?id=149539)
I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
in <http://trac.webkit.org/changeset/190351>.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit.start):
- 10:19 AM Changeset in webkit [190351] by
-
- 2 edits in trunk/Tools
Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
(https://bugs.webkit.org/show_bug.cgi?id=149539)
{32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit.start):
- 10:17 AM Changeset in webkit [190350] by
-
- 5 edits in trunk/Source
Unreviewed, rolling out r190324.
https://bugs.webkit.org/show_bug.cgi?id=149671
Caused flaky crashes, rdar://problem/22916304 (Requested by ap
on #webkit).
Reverted changeset:
"ParallelHelperPool::runFunctionInParallel() shouldn't
allocate, and ParallelHelperPool.h shouldn't be included
everywhere"
https://bugs.webkit.org/show_bug.cgi?id=149635
http://trac.webkit.org/changeset/190324
- 9:56 AM Changeset in webkit [190349] by
-
- 2 edits in trunk/Tools
bot210 was configured for a queue instead of bot126.
Unreviewed config.json fix.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 9:35 AM Changeset in webkit [190348] by
-
- 3 edits in trunk/Tools
Bring El Capitan buildbot infrastructure online.
https://bugs.webkit.org/show_bug.cgi?id=149605
Reviewed by Darin Adler.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 8:39 AM Changeset in webkit [190347] by
-
- 18 edits in trunk/Source/WebCore
Use separate style resolver for user agent shadow trees
https://bugs.webkit.org/show_bug.cgi?id=149626
Reviewed by Andreas Kling.
We now support separate style resolvers for shadow trees. Use this mechanism to have a separate
per-document style resolver for user agent shadow trees. This isolates user agent shadow trees
from author style better and simplifies the style resolver. It can also avoid some unnecessary style recalcs.
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::resetAuthorStyle):
(WebCore::DocumentRuleSets::appendAuthorStyleSheets):
Change interface so that only the new rules are provided.
- css/DocumentRuleSets.h:
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::addElementStyleProperties):
(WebCore::ElementRuleCollector::collectMatchingRules):
We can remove special bailout as shadow tree style resolver won't have other author style
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
Remove the exception that disables property whitelists for UA stylesheets. We don't seem to use the feature.
(WebCore::ElementRuleCollector::matchUARules):
(WebCore::MatchingUARulesScope::MatchingUARulesScope): Deleted.
(WebCore::MatchingUARulesScope::~MatchingUARulesScope): Deleted.
(WebCore::MatchingUARulesScope::isMatchingUARules): Deleted.
Remove this unnecessary hack.
- css/ElementRuleCollector.h:
(WebCore::ElementRuleCollector::ElementRuleCollector):
- css/RuleSet.cpp:
(WebCore::RuleSet::addStyleRule):
(WebCore::RuleSet::copyShadowPseudoElementRulesFrom):
Also copy WebVTT rules. They are currently a sort of mixture of UA and author shadow tree.
(WebCore::shrinkMapVectorsToFit):
- css/RuleSet.h:
(WebCore::RuleData::containsUncommonAttributeSelector):
(WebCore::RuleData::linkMatchType):
(WebCore::RuleData::hasDocumentSecurityOrigin):
(WebCore::RuleData::propertyWhitelistType):
(WebCore::RuleData::descendantSelectorIdentifierHashes):
(WebCore::RuleSet::ruleCount):
(WebCore::RuleSet::hasShadowPseudoElementRules):
- css/StyleInvalidationAnalysis.cpp:
(WebCore::StyleInvalidationAnalysis::StyleInvalidationAnalysis):
(WebCore::StyleInvalidationAnalysis::invalidateIfNeeded):
Don't invalidate the whole tree when author shadow pseudo element rules change. Just invalidate the shadow trees.
(WebCore::StyleInvalidationAnalysis::invalidateStyleForTree):
(WebCore::StyleInvalidationAnalysis::invalidateStyle):
(WebCore::invalidateIfNeeded): Deleted.
(WebCore::invalidateStyleForTree): Deleted.
- css/StyleInvalidationAnalysis.h:
(WebCore::StyleInvalidationAnalysis::dirtiesAllStyle):
(WebCore::StyleInvalidationAnalysis::hasShadowPseudoElementRulesInAuthorSheet):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::MatchResult::addMatchedProperties):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::appendAuthorStyleSheets):
Simpler interface.
- css/StyleResolver.h:
(WebCore::StyleResolver::document):
(WebCore::StyleResolver::documentSettings):
(WebCore::StyleResolver::ruleSets):
- dom/AuthorStyleSheets.cpp:
(WebCore::AuthorStyleSheets::collectActiveStyleSheets):
(WebCore::AuthorStyleSheets::analyzeStyleSheetChange):
Cleanups.
(WebCore::filterEnabledNonemptyCSSStyleSheets):
(WebCore::AuthorStyleSheets::updateActiveStyleSheets):
(WebCore::AuthorStyleSheets::updateStyleResolver):
Factor to a function.
Copy any author shadow pseudo elements to user agent shadow tree resolver.
(WebCore::AuthorStyleSheets::activeStyleSheetsForInspector):
- dom/AuthorStyleSheets.h:
- dom/Document.cpp:
(WebCore::Document::createStyleResolver):
(WebCore::Document::userAgentShadowTreeStyleResolver):
Use separate resolver.
(WebCore::Document::fontsNeedUpdate):
(WebCore::Document::clearStyleResolver):
- dom/Document.h:
(WebCore::Document::ensureStyleResolver):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::styleResolver):
Return document-global shadow tree resolver for ua trees.
- style/StyleResolveTree.cpp:
(WebCore::Style::resolveShadowTree):
Take styleChange of shadow root into account.
- 7:07 AM Changeset in webkit [190346] by
-
- 3 edits in trunk/Tools
[GTK] Deprecation warnings in DOMNodeTest
https://bugs.webkit.org/show_bug.cgi?id=149663
After the webkit_dom_document_get_elements_by_tag_name deprecation we
need to update the tests to use webkit_dom_document_query_selector_all
to avoid compilation warnings.
Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
(the suggested replacement for the deprecated function).
Patch by Tomas Popela <tpopela@redhat.com> on 2015-09-30
Reviewed by Carlos Garcia Campos.
- TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
(WebKitDOMNodeTest::testTagNamesNodeList):
(WebKitDOMNodeTest::testTagNamesHTMLCollection):
(registerTests):
(WebKitDOMNodeTest::testTagNames): Deleted.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
(prepareDOMForTagNamesTests):
(testWebKitDOMNodeTagNamesNodeList):
(testWebKitDOMNodeTagNamesHTMLCollection):
(beforeAll):
(testWebKitDOMNodeTagNames): Deleted.
- 5:58 AM WebKitGTK/2.10.x edited by
- (diff)
- 5:55 AM Changeset in webkit [190345] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Build error with -DENABLE_SPELLCHECK=OFF
https://bugs.webkit.org/show_bug.cgi?id=146904
Reviewed by Carlos Garcia Campos.
Add ifdef guards to allow building when SPELLCHECK is not enabled.
- UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::getGuessesForWord):
(WebKit::TextChecker::learnWord):
(WebKit::TextChecker::ignoreWord):
(WebKit::TextChecker::requestCheckingOfString):
(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::setSpellCheckingLanguages):
(WebKit::TextChecker::loadedSpellCheckingLanguages):
- 2:55 AM Changeset in webkit [190344] by
-
- 14 edits in trunk/Source
[GTK] Support HiDPI Properly in WebKitGtk+ with the TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=141782
Reviewed by Carlos Garcia Campos.
Source/WebCore:
This patch fixes HiDPI issue in the TextureMapper.
To support HiDPI in the TextureMapper, we need to draw scaled contents
in the TextureMapperTile, and apply the global scale in the root layer
to apply transforms correctly.
Supporting the device scale is handled at LayerTreeHostGtk and
TextureMapperBackingStore, and GraphicsLayerTextureMapper doesn't handle
the device scale directly.
From the TextureMapperLayer, deviceScale and pageScale do not have to be
handled differently. These are multiplied and provided to
TextureMapperBackingStore.
- platform/graphics/texmap/TextureMapperTile.cpp:
(WebCore::TextureMapperTile::updateContents):
- platform/graphics/texmap/TextureMapperTile.h:
- platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
Modified to increase the cover rect for tiles creation. For the image
contents, it just creates texture with a image size, regardless of the
contents scale.
- platform/graphics/texmap/BitmapTexture.cpp:
(WebCore::BitmapTexture::updateContents):
Apply the device scale to the graphics context before painting contents.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):
Apply the device scale and the page scale to the backing store
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
- UIProcess/gtk/RedirectedXCompositeWindow.cpp:
Modified to create scaled size of window.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::initialize):
(WebKit::LayerTreeHostGtk::deviceOrPageScaleFactorChanged):
We should apply device scale factor to the root layer to apply
the scale matrix before applying other transform matrices.
(WebKit::LayerTreeHostGtk::deviceScaleFactor): Added.
(WebKit::LayerTreeHostGtk::pageScaleFactor): Added.
Sep 29, 2015:
- 11:00 PM Changeset in webkit [190343] by
-
- 1 edit1 add in trunk/LayoutTests
Update iOS-simulator results for fast/text/mark-matches-overflow-clip.html
<https://bugs.webkit.org/show_bug.cgi?id=149637>
Patch by Ryan Haddad <Ryan Haddad> on 2015-09-29
Reviewed by Darin Adler.
- platform/ios-simulator/fast/text/mark-matches-overflow-clip-expected.txt: Added.
- 10:58 PM Changeset in webkit [190342] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Console completion suggestions should include properties on Object (hasOwnProperty, toString, etc)
https://bugs.webkit.org/show_bug.cgi?id=149649
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-29
Reviewed by Darin Adler.
- UserInterface/Base/Utilities.js:
(value):
Since keySets in this instance are often used as hash maps with the
inoperator, create a blank object that won't have Object.prototype
functions that would be seen byin.
- UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
(WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.receivedPropertyNames.compare):
Sort defineGetter and lookupGetter and friends last, since they
are rarely used properties.
- 10:57 PM Changeset in webkit [190341] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Missing completions for Symbol objects, console.error warning
https://bugs.webkit.org/show_bug.cgi?id=149641
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-29
Reviewed by Darin Adler.
- UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
(WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.getCompletions):
(WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.evaluated):
Include completions for symbol types.
- 10:55 PM Changeset in webkit [190340] by
-
- 2 edits in trunk/Source/WebCore
ASSERTION FAILED: !isUnreachableNode(m_target.get()) when hovering over any input element
https://bugs.webkit.org/show_bug.cgi?id=149589
Reviewed by Darin Adler.
The bug was caused by target not being reset across shadow boundary when SHADOW_DOM was disabled.
No new tests since exiting tests cover this in debug builds. e.g. editing/deleting/5290534.html
- dom/EventDispatcher.cpp:
(WebCore::EventPath::EventPath):
- 10:54 PM Changeset in webkit [190339] by
-
- 4 edits2 adds in trunk
Avoid reparsing an XSLT stylesheet after the first failure.
https://bugs.webkit.org/show_bug.cgi?id=149188
<rdar://problem/22709912>
Reviewed by Dave Hyatt.
Patch by Jiewen Tan, jiewen_tan@apple.com.
Source/WebCore:
Test: svg/custom/invalid-xslt-crash.svg
- xml/XSLStyleSheet.h:
Add a new member variable m_compilationFailed that tracks whether
compilation has failed. Default value is false.
- xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::compileStyleSheet):
Return early if the compilation has failed before. After compiling the
style sheet, if we failed, set m_compilationFailed to true.
LayoutTests:
- svg/custom/invalid-xslt-crash-expected.txt: Added.
- svg/custom/invalid-xslt-crash.svg: Added.
- 10:53 PM Changeset in webkit [190338] by
-
- 19 edits in trunk/Source/WebCore
Use modern for-loops in WebCore/loader.
https://bugs.webkit.org/show_bug.cgi?id=149397
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-09-29
Reviewed by Darin Adler.
No new tests because there is no behavior change.
- loader/CrossOriginAccessControl.cpp:
(WebCore::parseAccessControlExposeHeadersAllowList):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::~FrameLoader):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::detachChildren):
(WebCore::FrameLoader::shouldClose):
(WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):
- loader/HistoryController.cpp:
(WebCore::HistoryController::currentFramesMatchItem):
- loader/SubframeLoader.cpp:
(WebCore::findPluginMIMETypeFromURL):
(WebCore::SubframeLoader::createJavaAppletWidget):
- loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::isURLInOnlineWhitelist):
(WebCore::ApplicationCache::urlMatchesFallbackNamespace):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
(WebCore::ApplicationCacheGroup::postListenerTask):
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::stopDeferringEvents):
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::StorageIDJournal::~StorageIDJournal):
(WebCore::ApplicationCacheStorage::store):
(WebCore::ApplicationCacheStorage::getOriginsWithCache):
- loader/archive/Archive.cpp:
(WebCore::Archive::clearAllSubframeArchivesImpl):
- loader/archive/ArchiveResourceCollection.cpp:
(WebCore::ArchiveResourceCollection::addAllResources):
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createPropertyListRepresentation):
(WebCore::LegacyWebArchive::create):
- loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::generateMHTMLData):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::switchClientsToRevalidatedResource):
(WebCore::CachedImage::createImage):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::switchClientsToRevalidatedResource):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):
(WebCore::CachedResourceLoader::garbageCollectDocumentResources):
(WebCore::CachedResourceLoader::isPreloaded):
(WebCore::CachedResourceLoader::printPreloadStats):
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::removeAllIcons):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::iconRecordCountWithData):
(WebCore::IconDatabase::notifyPendingLoadDecisions):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):
(WebCore::IconDatabase::readFromDatabase):
(WebCore::IconDatabase::writeToDatabase):
- 9:31 PM Changeset in webkit [190337] by
-
- 4 edits in trunk
sectionRowIndex must return -1 when its parent is not a table, tbody, thead, or tfoot
https://bugs.webkit.org/show_bug.cgi?id=148841
<rdar://problem/22586870>
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C HTML test now that more checks are passing.
- web-platform-tests/html/semantics/tabular-data/the-tr-element/sectionRowIndex-expected.txt:
Source/WebCore:
Update HTMLTableRowElement.sectionRowIndex to match the specification:
https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex
In particular, it now returns -1 if the parent is not a table, tbody,
thead and tfoot.
No new tests, already covered by existing test.
- html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::sectionRowIndex):
- 6:30 PM Changeset in webkit [190336] by
-
- 10 edits1 copy in trunk/Source
Make WebKit for iOS Simulator build with the public iOS 9 SDK
https://bugs.webkit.org/show_bug.cgi?id=149652
Reviewed by Simon Fraser.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj: Add private header pthreadSPI.h. Also move entry for IDBTransaction.h so that it is in sorted order.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm: Substitute AVPlayerViewControllerDelegate_WebKitOnly for AVPlayerViewControllerDelegate.
- platform/spi/cocoa/AVKitSPI.h: As of iOS 9, AVPlayerViewControllerDelegate is a public protocol. Separate out WebKit-specific SPI into protocol
AVPlayerViewControllerDelegate_WebKitOnly, which extends AVPlayerViewControllerDelegate. Also, the properties -[AVPlayerViewController allowsPictureInPicturePlayback] and -[AVPlayerViewController delegate] are public in iOS 9.
- platform/spi/cocoa/pthreadSPI.h: Added.
- platform/spi/ios/LaunchServicesSPI.h: Add more SPI.
- platform/spi/ios/MediaPlayerSPI.h: Ignore deprecation warnings for UIPopoverController and UIActionSheet.
Source/WebKit2:
- Platform/spi/ios/SafariServicesSPI.h: Add definition for SFSafariViewController.
- Platform/spi/ios/UIKitSPI.h: Add more SPI.
- WebProcess/cocoa/WebProcessCocoa.mm: Include header pthreadSPI.h.
- 6:20 PM Changeset in webkit [190335] by
-
- 12 edits1 copy in trunk/Tools
WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
https://bugs.webkit.org/show_bug.cgi?id=149650
Reviewed by Tim Horton.
TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
looks at the file path, and not the custom options that come from file comments.
Fix by computing TestOptions before making the TestInvocation, and setting them
as const TestInvocation data. This meant changing various call sites to take
the std::string pathOrURL, rather than the TestInvocation itself.
Also initialize TestInvocation with a WKURLRef, rather than a std::string.
- WebKitTestRunner/CMakeLists.txt:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::ensureViewSupportsOptionsForTest):
(WTR::testPath):
(WTR::createTestURL):
(WTR::updateTestOptionsFromTestHeader):
(WTR::TestController::testOptionsForTest):
(WTR::TestController::updateWebViewSizeForTest):
(WTR::TestController::updateWindowScaleForTest):
(WTR::TestController::runTest):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::invoke):
(WTR::createWKURL): Deleted.
(WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
(WTR::TestInvocation::shouldUseFixedLayout): Deleted.
- WebKitTestRunner/TestInvocation.h:
(WTR::TestInvocation::options):
- WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
(WTR::pathContains):
(WTR::shouldMakeViewportFlexible):
(WTR::shouldUseFixedLayout):
(WTR::isSVGTestPath):
(WTR::isHiDPITestPath):
(WTR::TestOptions::TestOptions):
- WebKitTestRunner/TestOptions.h:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/efl/TestControllerEfl.cpp:
(WTR::pathContains):
(WTR::shouldUseFixedLayout):
(WTR::TestController::updatePlatformSpecificTestOptionsForTest):
- WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::updatePlatformSpecificTestOptionsForTest):
- WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::updatePlatformSpecificTestOptionsForTest):
- WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::updatePlatformSpecificTestOptionsForTest):
- 5:29 PM Changeset in webkit [190334] by
-
- 4 edits in trunk/Tools
Flakiness dashboard should support OS X El Capitan
https://bugs.webkit.org/show_bug.cgi?id=149648
Patch by Aakash Jain <aakash_jain@apple.com> on 2015-09-29
Reviewed by Alexey Proskuryakov.
- QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of
difference between new appscale and old Google App Engine implementation.
- TestResultServer/app.yaml: Same.
- TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
- 5:21 PM Changeset in webkit [190333] by
-
- 2 edits in trunk/Tools
configure-xcode-for-ios-development does not work with Xcode 7
https://bugs.webkit.org/show_bug.cgi?id=149640
Reviewed by Alexey Proskuryakov.
When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
because it cannot find the Xcode specification files for iOS simulator and device. These
files have moved to a new location in Xcode 7 distribution. Moreover we must add the
relevant definitions to the Xcode 7 specification files directly as opposed to creating
new specification files with the added definitions (as we did in older versions of Xcode)
in order for Xcode 7 to honor these definitions.
- Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
(updateXcodeSpecificationFilesForSDKIfNeeded): Added.
(updateXcode7SpecificationFile): Added.
(createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
(writeXcodeSpecification): Moved congratulations line to caller so as to write out the
appropriate success message.
(mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
(createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
(createXcodeSpecificationFromSpecificationAndId): Deleted.
- 5:16 PM Changeset in webkit [190332] by
-
- 5 edits in trunk/Source
Followup to "Move WebKit2 AsyncTask to WebCore CrossThreadTask."
https://bugs.webkit.org/show_bug.cgi?id=149651
Rubberstamped by Alex Christensen.
Source/WebCore:
No new tests (No change in behavior).
- platform/CrossThreadTask.h: Now in WebCore, use the WebCore namespace.
Source/WebKit2:
- DatabaseProcess/DatabaseProcess.h: CrossThreadTask is in the WebCore namespace, not WebKit.
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.h: Ditto.
- 4:28 PM Changeset in webkit [190331] by
-
- 8 edits1 move in trunk/Source
Move WebKit2 AsyncTask to WebCore CrossThreadTask.
https://bugs.webkit.org/show_bug.cgi?id=149651
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (No change in behavior).
It will be needed in WebCore to support IndexedDB.
- WebCore.xcodeproj/project.pbxproj:
- platform/CrossThreadTask.h: Renamed from Source/WebKit2/Shared/AsyncTask.h.
(WebKit::CrossThreadTask::CrossThreadTask):
(WebKit::CrossThreadTask::performTask):
(WebKit::createCrossThreadTask):
Source/WebKit2:
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::ensureIndexedDatabaseRelativePathExists):
(WebKit::DatabaseProcess::postDatabaseTask):
(WebKit::DatabaseProcess::performNextDatabaseTask):
(WebKit::DatabaseProcess::fetchWebsiteData):
(WebKit::DatabaseProcess::deleteWebsiteData):
(WebKit::DatabaseProcess::deleteWebsiteDataForOrigins):
- DatabaseProcess/DatabaseProcess.h:
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::shutdown):
(WebKit::UniqueIDBDatabase::shutdownBackingStore):
(WebKit::UniqueIDBDatabase::getOrEstablishIDBDatabaseMetadata):
(WebKit::UniqueIDBDatabase::openBackingStoreAndReadMetadata):
(WebKit::UniqueIDBDatabase::openTransaction):
(WebKit::UniqueIDBDatabase::beginTransaction):
(WebKit::UniqueIDBDatabase::commitTransaction):
(WebKit::UniqueIDBDatabase::resetTransaction):
(WebKit::UniqueIDBDatabase::rollbackTransaction):
(WebKit::UniqueIDBDatabase::postTransactionOperation):
(WebKit::UniqueIDBDatabase::changeDatabaseVersion):
(WebKit::UniqueIDBDatabase::createObjectStore):
(WebKit::UniqueIDBDatabase::deleteObjectStore):
(WebKit::UniqueIDBDatabase::clearObjectStore):
(WebKit::UniqueIDBDatabase::createIndex):
(WebKit::UniqueIDBDatabase::deleteIndex):
(WebKit::UniqueIDBDatabase::putRecord):
(WebKit::UniqueIDBDatabase::getRecord):
(WebKit::UniqueIDBDatabase::openCursor):
(WebKit::UniqueIDBDatabase::cursorAdvance):
(WebKit::UniqueIDBDatabase::cursorIterate):
(WebKit::UniqueIDBDatabase::count):
(WebKit::UniqueIDBDatabase::deleteRange):
(WebKit::UniqueIDBDatabase::openBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::beginBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::commitBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::resetBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::rollbackBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::changeDatabaseVersionInBackingStore):
(WebKit::UniqueIDBDatabase::createObjectStoreInBackingStore):
(WebKit::UniqueIDBDatabase::deleteObjectStoreInBackingStore):
(WebKit::UniqueIDBDatabase::clearObjectStoreInBackingStore):
(WebKit::UniqueIDBDatabase::createIndexInBackingStore):
(WebKit::UniqueIDBDatabase::deleteIndexInBackingStore):
(WebKit::UniqueIDBDatabase::putRecordInBackingStore):
(WebKit::UniqueIDBDatabase::getRecordFromBackingStore):
(WebKit::UniqueIDBDatabase::openCursorInBackingStore):
(WebKit::UniqueIDBDatabase::advanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::iterateCursorInBackingStore):
(WebKit::UniqueIDBDatabase::countInBackingStore):
(WebKit::UniqueIDBDatabase::deleteRangeInBackingStore):
(WebKit::UniqueIDBDatabase::postMainThreadTask):
(WebKit::UniqueIDBDatabase::performNextMainThreadTask):
(WebKit::UniqueIDBDatabase::postDatabaseTask):
(WebKit::UniqueIDBDatabase::performNextDatabaseTask):
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
- WebKit2.xcodeproj/project.pbxproj:
- 3:56 PM Changeset in webkit [190330] by
-
- 10 edits4 adds in trunk
Snap offsets should update when style is programmatically changed
https://bugs.webkit.org/show_bug.cgi?id=135964
<rdar://problem/18162411>
Reviewed by Darin Adler.
Source/WebCore:
Tests: css3/scroll-snap/scroll-snap-style-changed-coordinates.html
css3/scroll-snap/scroll-snap-style-changed-repeat.html
Updating scroll snap style properties now programmatically updates the scroll snap container. Does not yet
handle the case of reparented elements with scroll snap coordinates. Adds some plumbing the FrameView and
RenderLayerCompositor to immediately update the scrolling coordinator when updating the FrameView due to
style changes.
- page/FrameView.cpp:
(WebCore::FrameView::updateScrollingCoordinatorScrollSnapProperties): Calls on the compositor to reupdate scroll snap
properties on the FrameView.
- page/FrameView.h:
- page/scrolling/AsyncScrollingCoordinator.cpp: Sets snap offsets to an empty vector when appropriate.
(WebCore::setStateScrollingNodeSnapOffsetsAsFloat): Ditto.
(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated): Ditto.
(WebCore::AsyncScrollingCoordinator::updateOverflowScrollingNode): Ditto.
(WebCore::AsyncScrollingCoordinator::updateScrollSnapPropertiesWithFrameView): Updates scroll snap properties
from a given FrameView.
- page/scrolling/AsyncScrollingCoordinator.h:
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::updateScrollSnapPropertiesWithFrameView):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateScrollSnapPropertiesWithFrameView): Updates the scrolling coordinator's
scroll snap properties.
- rendering/RenderLayerCompositor.h: Plumb scroll snap property updating to the FrameView.
- rendering/RenderLayerModelObject.cpp: Checks for style changes and updates snap offsets when appropriate.
(WebCore::scrollSnapContainerRequiresUpdateForStyleUpdate): Ditto.
(WebCore::RenderLayerModelObject::styleDidChange): Ditto.
LayoutTests:
Tests style updates in both cases where -points and -coordinates are used to position snap points.
- css3/scroll-snap/scroll-snap-style-changed-coordinates-expected.txt: Added.
- css3/scroll-snap/scroll-snap-style-changed-coordinates.html: Added.
- css3/scroll-snap/scroll-snap-style-changed-repeat-expected.txt: Added.
- css3/scroll-snap/scroll-snap-style-changed-repeat.html: Added.
- 2:25 PM Changeset in webkit [190329] by
-
- 33 edits8 deletes in trunk
Unreviewed, rolling out r190289.
https://bugs.webkit.org/show_bug.cgi?id=149647
Crashing speedometer and some ARM32 tests (Requested by
msaboff on #webkit).
Reverted changeset:
"[ES6] Implement tail calls in the FTL"
https://bugs.webkit.org/show_bug.cgi?id=148664
http://trac.webkit.org/changeset/190289
- 2:16 PM Changeset in webkit [190328] by
-
- 4 edits in trunk/Tools
[Win] Allow 'prepare-ChangeLog' to be used without Cygwin
https://bugs.webkit.org/show_bug.cgi?id=149639
Reviewed by Alex Christensen.
- Scripts/VCSUtils.pm:
(exitStatus): Use 'isWindows()' method.
(isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
an error. This method could probably just go away.
(normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
always changing to Unix style.
(unixPath): Added. Needed so Windows can always show a Unix path in the
ChangeLog file.
(changeLogName): Work around the fact that 'getpwuid' is not available on
a pure Windows build of Perl.
- Scripts/prepare-ChangeLog:
(generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
path on Windows.
(svnUpdateCommand): Added helper function. Needed because Windows Perl does not
support using arrays for 'open' arguments.
(resolveChangeLogsPath): Ditto.
(resolveConflictedChangeLogs): Use new helper functions.
(generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
(diffCommand): Use double-quotes for paths, since Windows doesn't understand single
quotes. Unix systems are happy either way.
(statusCommand): Ditto.
- Scripts/webkitdirs.pm:
(launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
- 2:03 PM Changeset in webkit [190327] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION: WebAudio user-gesture restriction is no longer lifted by touchstart event
https://bugs.webkit.org/show_bug.cgi?id=149367
Reviewed by Eric Carlson.
Use processingUserGestureForMedia() rather than processingUserGesture(),
as the former includes touchstart and the latter does not.
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::willBeginPlayback):
(WebCore::AudioContext::willPausePlayback):
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::playbackPermitted):
(WebCore::MediaElementSession::dataLoadingPermitted):
(WebCore::MediaElementSession::fullscreenPermitted):
(WebCore::MediaElementSession::showPlaybackTargetPicker):
- 2:01 PM Changeset in webkit [190326] by
-
- 2 edits1 add in trunk/LayoutTests
[Win] Rebaseline test.
Rubberstamped by Tim Horton.
- platform/win/TestExpectations: Remove test failure.
- platform/win/fast/text/mark-matches-overflow-clip-expected.txt: Added.
- 1:56 PM Changeset in webkit [190325] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed gardening.
- platform/win/TestExpectations: Mark new test added in
r190254 as failing.
- 1:25 PM Changeset in webkit [190324] by
-
- 5 edits in trunk/Source
ParallelHelperPool::runFunctionInParallel() shouldn't allocate, and ParallelHelperPool.h shouldn't be included everywhere
https://bugs.webkit.org/show_bug.cgi?id=149635
Reviewed by Saam Barati.
Source/JavaScriptCore:
It bugged me that this change caused a whole-world recompile. So, I changed the code so
that ParallelHelperPool.h is only included by Heap.cpp and not by Heap.h.
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::markRoots):
(JSC::Heap::copyBackingStores):
- heap/Heap.h:
Source/WTF:
- wtf/ParallelHelperPool.h:
(WTF::ParallelHelperClient::runFunctionInParallel): Stack-allocate the task instead of heap-allocating it.
- 1:22 PM Changeset in webkit [190323] by
-
- 8 edits in trunk
Update style/layout when a slot is added or removed
https://bugs.webkit.org/show_bug.cgi?id=149593
Reviewed by Antti Koivisto.
Source/WebCore:
Fixed the bug by forcing the render tree reconstruction on the shadow host when a slot is inserted or removed.
We should optimize these reconstructions by only triggering them on the affected slot elements in the future.
Also fixed a bug that we were not invalidating the slot assignments when a default slot is introduced dynamically
after the slot assignment algorithm had run.
Test (existing): fast/shadow-dom/shadow-layout-after-slot-changes.html
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::addSlotElementByName): Passes in ShadowRoot.
(WebCore::ShadowRoot::removeSlotElementByName): Ditto.
- dom/SlotAssignment.cpp:
(WebCore::SlotAssignment::addSlotElementByName): Call setNeedsStyleRecalc.
(WebCore::SlotAssignment::removeSlotElementByName): Call setNeedsStyleRecalc if the host is still alive since this
function can be called while the host is being destructed in which case shadowRoot.host() would be nullptr.
- dom/SlotAssignment.h:
LayoutTests:
Removed failing test expectations from fast/shadow-dom/shadow-layout-after-slot-changes.html
Also added an explicit test case for when a default slot is introduced dynamically after
calling getDistributedNodes() once, thereby forcing the slot assignments.
- fast/shadow-dom/HTMLSlotElement-interface-expected.txt:
- fast/shadow-dom/HTMLSlotElement-interface.html:
- fast/shadow-dom/shadow-layout-after-slot-changes.html:
- platform/mac/TestExpectations:
- 12:20 PM Changeset in webkit [190322] by
-
- 2 edits in trunk/LayoutTests
Update test expectations to mark quicklook/pages.html as crashing
<https://bugs.webkit.org/show_bug.cgi?id=149634>
Patch by Ryan Haddad <Ryan Haddad> on 2015-09-29
Reviewed by David Kilzer.
- platform/ios-simulator/TestExpectations:
- 12:18 PM Changeset in webkit [190321] by
-
- 2 edits in trunk
[GTK][CMake] Warning about CMP0058
https://bugs.webkit.org/show_bug.cgi?id=149627
Reviewed by Martin Robinson.
Opt-in to the new behavior for CMP0058.
- CMakeLists.txt:
- 12:04 PM Changeset in webkit [190320] by
-
- 5 edits2 adds in trunk
Memory cache revalidations should refresh the network disk cache
https://bugs.webkit.org/show_bug.cgi?id=149606
Reviewed by Darin Adler.
Source/WebKit2:
Previously, resource revalidations triggered by the memory cache would
bypass the disk cache entirely because the requests are conditional. As
a result, when the server responds with a 304, we were unable to update
the headers (e.g. new expiration date) of the corresponding entry in
the disk cache.
This patch updates our disk cache implementation to not bypass the disk
cache when the request is conditional. Instead, we look up the cached
entry and force its revalidation from the network. If the server then
returns a 304, we are now able to update the headers of this cached
entry. In such case though, we let the 304 response through to WebCore
unlike revalidations triggered by the disk cache.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::makeUseDecision):
(WebKit::NetworkCache::makeRetrieveDecision):
LayoutTests:
Add layout test to check that revalidations requested by the memory cache
update the corresponding disk cache entry when the server responds with a
304 status code.
- http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache-expected.txt: Added.
- http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache.html: Added.
- 11:35 AM Changeset in webkit [190319] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, mark several newly imported W3C media tests as flaky on Mavericks.
https://bugs.webkit.org/show_bug.cgi?id=149636
- platform/mac/TestExpectations:
- 11:32 AM Changeset in webkit [190318] by
-
- 2 edits in trunk/LayoutTests
[Win] Revise failure case per Alexey's comments.
- platform/win/TestExpectations:
- 11:24 AM Changeset in webkit [190317] by
-
- 1 edit2 adds in trunk/LayoutTests
[Streams API] Add abstract ops tests
https://bugs.webkit.org/show_bug.cgi?id=149629
Reviewed by Darin Adler.
- streams/reference-implementation/abstract-ops-expected.txt: Added.
- streams/reference-implementation/abstract-ops.html: Added.
- 11:08 AM Changeset in webkit [190316] by
-
- 7 edits in trunk/LayoutTests
[Streams API] Update tests according to latest spec
https://bugs.webkit.org/show_bug.cgi?id=149628
Reviewed by Darin Adler.
Added checkpoints and updated all tests that don't disrupt the current implementation and the tests that are
passing now.
- streams/reference-implementation/bad-strategies-expected.txt:
- streams/reference-implementation/bad-strategies.html:
- streams/reference-implementation/pipe-to-options.html:
- streams/reference-implementation/pipe-to.html:
- streams/reference-implementation/writable-stream-abort.html:
- streams/reference-implementation/writable-stream.html:
- 10:53 AM Changeset in webkit [190315] by
-
- 2 edits in trunk/LayoutTests
[Win] Test gardening
- platform/win/TestExpectations: Mark some expected failures.
- 10:49 AM Changeset in webkit [190314] by
-
- 21 edits9 adds in trunk/Source/WebCore
Improve binding of JSBuiltinConstructor classes
https://bugs.webkit.org/show_bug.cgi?id=149556
Reviewed by Darin Adler.
JSBuiltinConstructor classes no longer need definition of a DOM class.
These classes no longer go through the JS wrapper cache.
Removed code related to DOM class handling (m_impl, releaseImpl, WrapperOwner, toJS, ...)
Updated creation code.
Refactoring of the binding generator code to simplify whether generating or not some methods.
Removed unneeded include of DOM class in JSXX.cpp (already done in JSXX.h)
Added new binding test to cover JSBuiltinConstructor keyword.
Covered by binding tests.
- bindings/js/JSDOMBinding.h:
(WebCore::createJSBuiltin):
(WebCore::DOMConstructorObject::createStructure):.
- bindings/scripts/CodeGeneratorJS.pm:
(NeedsImplementationClass):
(ShouldGenerateToWrapped):
(ShouldGenerateWrapperOwnerCode):
(ShouldGenerateToJSDeclaration):
(ShouldGenerateToJSImplementation):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDefinition):
(ComputeFunctionSpecial):.
(UseJSBuiltins):.
- bindings/scripts/test/GObject/WebKitDOMTestJSBuiltinConstructor.cpp: Added.
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestJSBuiltinConstructor):
(webkit_dom_test_js_builtin_constructor_finalize):
(webkit_dom_test_js_builtin_constructor_constructor):
(webkit_dom_test_js_builtin_constructor_class_init):
(webkit_dom_test_js_builtin_constructor_init):
- bindings/scripts/test/GObject/WebKitDOMTestJSBuiltinConstructor.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestJSBuiltinConstructorPrivate.h: Added.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp: Added.
(WebCore::JSTestJSBuiltinConstructorPrototype::create):
(WebCore::JSTestJSBuiltinConstructorPrototype::createStructure):
(WebCore::JSTestJSBuiltinConstructorPrototype::JSTestJSBuiltinConstructorPrototype):
(WebCore::JSTestJSBuiltinConstructorConstructor::create):
(WebCore::JSTestJSBuiltinConstructorConstructor::createStructure):
(WebCore::JSTestJSBuiltinConstructorConstructor::constructJSTestJSBuiltinConstructor):
(WebCore::JSTestJSBuiltinConstructorConstructor::JSTestJSBuiltinConstructorConstructor):
(WebCore::JSTestJSBuiltinConstructorConstructor::finishCreation):
(WebCore::JSTestJSBuiltinConstructorConstructor::getConstructData):
(WebCore::JSTestJSBuiltinConstructorPrototype::finishCreation):
(WebCore::JSTestJSBuiltinConstructor::JSTestJSBuiltinConstructor):
(WebCore::JSTestJSBuiltinConstructor::createPrototype):
(WebCore::JSTestJSBuiltinConstructor::getPrototype):
(WebCore::JSTestJSBuiltinConstructor::destroy):
(WebCore::JSTestJSBuiltinConstructor::~JSTestJSBuiltinConstructor):
(WebCore::jsTestJSBuiltinConstructorConstructor):
(WebCore::JSTestJSBuiltinConstructor::getConstructor):
(WebCore::JSTestJSBuiltinConstructor::visitChildren):
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h: Added.
(WebCore::JSTestJSBuiltinConstructor::create):
(WebCore::JSTestJSBuiltinConstructor::createStructure):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
- bindings/scripts/test/JS/JSTestNode.cpp:
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
- bindings/scripts/test/JS/JSattribute.cpp:
- bindings/scripts/test/JS/JSreadonly.cpp:
- bindings/scripts/test/ObjC/DOMTestJSBuiltinConstructor.h: Added.
- bindings/scripts/test/ObjC/DOMTestJSBuiltinConstructor.mm: Added.
(-[DOMTestJSBuiltinConstructor dealloc]):
(-[DOMTestJSBuiltinConstructor finalize]):
(core):
(kit):
- bindings/scripts/test/ObjC/DOMTestJSBuiltinConstructorInternal.h: Added.
- bindings/scripts/test/TestJSBuiltinConstructor.idl: Added.
- 10:41 AM Changeset in webkit [190313] by
-
- 2 edits in trunk/LayoutTests
[Win] [Font Features] Implement font-variant-*
https://bugs.webkit.org/show_bug.cgi?id=149630
Unreviewed gardening.
- platform/win/TestExpectations: Mark expected failures due
to missing Windows feature.
- 10:24 AM Changeset in webkit [190312] by
-
- 2 edits in trunk/Source/WebCore
[Streams API] [Win] Remove reference to dead CountQueuingStrategy.h
https://bugs.webkit.org/show_bug.cgi?id=149623
Reviewed by Darin Adler.
No new tests needed.
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 10:10 AM Changeset in webkit [190311] by
-
- 2 edits in trunk/Tools
[Win] Unreviewed 64-bit build fix after switch to CMake.
- Scripts/webkitdirs.pm:
(determineIsWin64FromArchitecture): Added.
- 9:39 AM Changeset in webkit [190310] by
-
- 12 edits1 add in trunk/Source
GC copy phase spans too many files
https://bugs.webkit.org/show_bug.cgi?id=149586
Reviewed by Andreas Kling.
Source/JavaScriptCore:
This puts the core logic of the copy phase into Heap::copyBackingStores(). Now, instead of
using many helpers in many places, the actual algorithm is all in one place.
This lets me do a lot of simplification.
- CopyVisitor no longer requires that you call startCopying() before, and doneCopying() and WTF::releaseFastMallocFreeMemoryForThisThread() after. The constructor and destructor now do this for you.
- CopyVisitor no longer contains the algorithm that drives copying. That's all in Heap::copyBackingStores() now. Basically, copyBackingStores() glues together the new WTF::ParallelVectorIterator with the copying algorithm that we used to have in CopyVisitor::copyFromShared().
- Lots of stuff that was in headers is now in .cpp files. That includes all non-hot-path code in CopyVisitor. Also, the code for copying in HeapInlines.h is now in ParallelVectorVisotor, and it's only included by Heap.cpp.
Overall, I like this direction for the GC. I don't think it's useful for Heap.cpp to have
calls to algorithms in some other file, unless those algorithms are either reusable or just
very dense. That's not actually true for the copy phase, and it's probably not true for
some other stuff like marking. I'll probably do the same refactoring for marking in another
bug.
This should have no effect on performance.
- heap/CopyVisitor.cpp:
(JSC::CopyVisitor::CopyVisitor):
(JSC::CopyVisitor::~CopyVisitor):
(JSC::CopyVisitor::copyFromShared): Deleted.
- heap/CopyVisitor.h:
- heap/CopyVisitorInlines.h:
(JSC::CopyVisitor::checkIfShouldCopy):
(JSC::CopyVisitor::allocateNewSpaceSlow):
(JSC::CopyVisitor::didCopy):
(JSC::CopyVisitor::visitItem): Deleted.
(JSC::CopyVisitor::startCopying): Deleted.
(JSC::CopyVisitor::doneCopying): Deleted.
- heap/Heap.cpp:
(JSC::Heap::copyBackingStores):
- heap/Heap.h:
- heap/HeapInlines.h:
(JSC::Heap::unregisterWeakGCMap):
(JSC::Heap::getNextBlocksToCopy): Deleted.
Source/WTF:
Extract the load balancing algorithm used by the GC's copy phase into a reusable template.
The GC copy phase now uses this.
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/ParallelVectorIterator.h: Added.
(WTF::ParallelVectorIterator::ParallelVectorIterator):
(WTF::ParallelVectorIterator::iterate):
- 7:05 AM Changeset in webkit [190309] by
-
- 6 edits1 add in trunk/Source/WebCore
Build WebCore JS Builtins according the ENABLE flags
https://bugs.webkit.org/show_bug.cgi?id=149624
Reviewed by Csaba Osztrogonác.
Created WebCoreJSBuiltins.cpp to include all JSXXBuiltins.cpp files with the right #ifdef.
Added WebCoreJSBuiltins.cpp to CMake, win and mac build systems.
No change in behavior.
- CMakeLists.txt:
- DerivedSources.cpp:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/WebCoreJSBuiltins.cpp: Added.
- 5:32 AM Changeset in webkit [190308] by
-
- 9 edits in trunk
[CSS Grid Layout] Flex tracks sizing alg must handle 0fr values
https://bugs.webkit.org/show_bug.cgi?id=148944
Reviewed by Darin Adler.
Source/WebCore:
We don't allow 0 as flexible size value, which is not following current
specs; it just states that it must be a positive value. This patch
adds such change in the parser but some additional logic must be added
as well to handle 0 values during the flex tracks sizing algorithm.
The old algorithm didn't take 0 values into account, so there is the risk
of division by zero. Additionally, it was not handling fraction values
in the best way. The last versions of the spec changed this algorithm in
order to handle fraction values so that they don't cause exponential
grow of tracks using values bigger than 1.
This patch implements also such new algorithm, so we can deal not only
with 0 values, but managing fraction values properly.
No new tests, just some additional test cases and some of them rebaselined.
- rendering/RenderGrid.cpp:
(WebCore::normalizedFlexFraction):
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::computeFlexFactorUnitSize): Added.
(WebCore::RenderGrid::findFlexFactorUnitSize): Added.
(WebCore::RenderGrid::GridTrackForNormalization): Deleted.
(WebCore::RenderGrid::computeNormalizedFractionBreadth): Deleted.
- rendering/RenderGrid.h:
LayoutTests:
Allow 0 as flex factor value and implement the new flex track sizing algorithm.
- fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html: Updated some cases.
- fast/css-grid-layout/flex-content-resolution-columns-expected.txt:
- fast/css-grid-layout/flex-content-resolution-columns.html: Added some new cases.
- fast/css-grid-layout/flex-content-resolution-rows-expected.txt:
- fast/css-grid-layout/flex-content-resolution-rows.html: Added some new cases.
- 3:23 AM Changeset in webkit [190307] by
-
- 2 edits in trunk/Source/WebCore
Fix the broken !ENABLE(STREAM_API) build
https://bugs.webkit.org/show_bug.cgi?id=149525
Reviewed by Darin Adler.
- bindings/js/WebCoreJSClientData.h: Revert r190225.
- 1:38 AM Changeset in webkit [190306] by
-
- 17 edits in trunk
printing does not use minimum page zoom factor
https://bugs.webkit.org/show_bug.cgi?id=108507
Reviewed by Darin Adler.
Source/WebCore:
- page/PrintContext.cpp:
(WebCore::PrintContext::beginAndComputePageRectsWithPageSize):
Helper function to share common code from numberOfPages() and
spoolAllPagesWithBoundaries().
(WebCore::PrintContext::numberOfPages): Use beginAndComputePageRectsWithPageSize().
(WebCore::PrintContext::spoolAllPagesWithBoundaries): Use
beginAndComputePageRectsWithPageSize() and don't flip the Y axis
for non Cocoa platforms.
- page/PrintContext.h:
Source/WebKit/mac:
Pass a the frame as a reference instead of using pointers.
- Misc/WebCoreStatistics.mm:
(-[WebFrame numberOfPagesWithPageWidth:pageHeight:]):
(-[WebFrame printToCGContext:pageWidth:pageHeight:]):
Source/WebKit2:
Add kWKSnapshotOptionsPrinting flag to indicate the snapshot
should be generated in printing mode.
- Shared/API/c/WKImage.h:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toSnapshotOptions):
- Shared/ImageOptions.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::numberOfPages): Pass the frame as a
reference instead of a pointer.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scaledSnapshotWithOptions): In case of printing,
calculate the bitmap height based on the number of pages.
(WebKit::WebPage::snapshotAtSize): In case of printing, use
PrintContext::spoolAllPagesWithBoundaries() and return.
Tools:
WebKitTestRunner always takes the snapshots from the UI process
(expect for IOS), so in the case of printing, the layout in the
web view is not the expected one. When printing, we need to take
the snapshot in the web process and ensure it's rendered with a
PrintContext.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump): When dumping pixels, pass
kWKSnapshotOptionsPrinting option to
WKBundlePageCreateSnapshotWithOptions() when printing.
LayoutTests:
Unskip printing reftests that should pass now.
- platform/gtk/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 1:01 AM Changeset in webkit [190305] by
-
- 10 edits in trunk/Source
Add support for WebIDL JSBuiltin attributes
https://bugs.webkit.org/show_bug.cgi?id=149554
Reviewed by Darin Adler.
Source/JavaScriptCore:
- runtime/Lookup.cpp:
(JSC::reifyStaticAccessor): Adding support for creating attribute getter from JS builtin functions.
- runtime/Lookup.h:
(JSC::HashTableValue::builtinAccessorGetterGenerator):
(JSC::HashTableValue::builtinAccessorSetterGenerator):
(JSC::reifyStaticProperties): Ensuring that builtin attributes are not treated as Builtin functions.
Source/WebCore:
Covered by bindings tests.
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute): Disabled GObject binding generation of JSBuiltin attribute.
- bindings/scripts/CodeGeneratorJS.pm:
(GetAttributeGetterName): Handling of Builtin function to retrieve BuiltinGenerator.
(GetAttributeSetterName): Ditto.
(GenerateAttributesHashTable): Set JSBuiltin attributes as "Accessor | Builtin".
(GenerateImplementation): Skip implementation for JSBuiltin attributes
- bindings/scripts/test/JS/JSTestObj.cpp: Adding binding test for JSBuiltin attributes.
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj jsBuiltinAttribute]):
(-[DOMTestObj setJsBuiltinAttribute:]):
(-[DOMTestObj jsBuiltinReadOnlyAttribute]):
- bindings/scripts/test/TestObj.idl: Ditto.
