⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 1, 2015:

10:44 PM Changeset in webkit [190456] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix the #if guard in PointerLockController.cpp
https://bugs.webkit.org/show_bug.cgi?id=149705

Reviewed by Gyuyoung Kim.

  • page/PointerLockController.cpp:
10:37 PM Changeset in webkit [190455] by bshafiei@apple.com
  • 3 edits
    6 copies in branches/safari-601.1.46-branch

Merged r190418. rdar://problem/22936628

10:35 PM Changeset in webkit [190454] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r188298. rdar://problem/22936040

9:48 PM Changeset in webkit [190453] by ggaren@apple.com
  • 44 edits in trunk/Source/JavaScriptCore

2015-10-01 Geoffrey Garen <ggaren@apple.com>

Unreviewed, rolling out r190450
https://bugs.webkit.org/show_bug.cgi?id=148560

Crashes seen on el cap wk1 bots.

Reverted changesets:

"CodeBlock should be a GC object"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190450

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::inferredName): (JSC::CodeBlock::dumpAssumingJITType): (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::setNumParameters): (JSC::CodeBlock::specialOSREntryBlockOrNull): (JSC::CodeBlock::visitStrongly): (JSC::CodeBlock::visitAggregate): (JSC::CodeBlock::shouldVisitStrongly): (JSC::CodeBlock::isKnownToBeLiveDuringGC): (JSC::CodeBlock::shouldJettisonDueToWeakReference): (JSC::CodeBlock::shouldJettisonDueToOldAge): (JSC::CodeBlock::determineLiveness): (JSC::CodeBlock::visitWeakReferences): (JSC::CodeBlock::finalizeLLIntInlineCaches): (JSC::CodeBlock::finalizeBaselineJITInlineCaches): (JSC::CodeBlock::finalizeUnconditionally): (JSC::CodeBlock::visitOSRExitTargets): (JSC::CodeBlock::unlinkIncomingCalls): (JSC::CodeBlock::linkIncomingCall): (JSC::CodeBlock::newReplacement): (JSC::ProgramCodeBlock::replacement): (JSC::ModuleProgramCodeBlock::replacement): (JSC::EvalCodeBlock::replacement): (JSC::FunctionCodeBlock::replacement): (JSC::ProgramCodeBlock::capabilityLevelInternal): (JSC::ModuleProgramCodeBlock::capabilityLevelInternal): (JSC::EvalCodeBlock::capabilityLevelInternal): (JSC::FunctionCodeBlock::capabilityLevelInternal): (JSC::WebAssemblyCodeBlock::replacement): (JSC::WebAssemblyCodeBlock::capabilityLevelInternal): (JSC::CodeBlock::jettison): (JSC::CodeBlock::capabilityLevel): (JSC::FunctionCodeBlock::destroy): Deleted. (JSC::WebAssemblyCodeBlock::destroy): Deleted. (JSC::ProgramCodeBlock::destroy): Deleted. (JSC::ModuleProgramCodeBlock::destroy): Deleted. (JSC::EvalCodeBlock::destroy): Deleted. (JSC::CodeBlock::finishCreation): Deleted. (JSC::CodeBlock::setAlternative): Deleted. (JSC::CodeBlock::visitWeakly): Deleted. (JSC::CodeBlock::visitChildren): Deleted. (JSC::timeToLive): Deleted. (JSC::CodeBlock::WeakReferenceHarvester::visitWeakReferences): Deleted. (JSC::CodeBlock::UnconditionalFinalizer::finalizeUnconditionally): Deleted. (JSC::CodeBlock::replacement): Deleted. (JSC::CodeBlock::computeCapabilityLevel): Deleted.
  • bytecode/CodeBlock.h: (JSC::CodeBlock::unlinkedCodeBlock): (JSC::CodeBlock::addressOfNumParameters): (JSC::CodeBlock::offsetOfNumParameters): (JSC::CodeBlock::alternative): (JSC::CodeBlock::setAlternative): (JSC::CodeBlock::forEachRelatedCodeBlock): (JSC::CodeBlock::specializationKind): (JSC::CodeBlock::instructionCount): (JSC::CodeBlock::setJITCode): (JSC::CodeBlock::hasBaselineJITProfiling): (JSC::CodeBlock::capabilityLevelState): (JSC::CodeBlock::addConstant): (JSC::CodeBlock::appendExceptionHandler): (JSC::CodeBlock::setConstantRegisters): (JSC::CodeBlock::replaceConstant): (JSC::GlobalCodeBlock::GlobalCodeBlock): (JSC::ProgramCodeBlock::ProgramCodeBlock): (JSC::ModuleProgramCodeBlock::ModuleProgramCodeBlock): (JSC::EvalCodeBlock::EvalCodeBlock): (JSC::EvalCodeBlock::variable): (JSC::EvalCodeBlock::numVariables): (JSC::EvalCodeBlock::unlinkedEvalCodeBlock): (JSC::FunctionCodeBlock::FunctionCodeBlock): (JSC::WebAssemblyCodeBlock::WebAssemblyCodeBlock): (JSC::ExecState::uncheckedR): (JSC::CodeBlock::clearMarks): (JSC::CodeBlockSet::mark): (JSC::ScriptExecutable::forEachCodeBlock): (JSC::ProgramCodeBlock::create): Deleted. (JSC::ProgramCodeBlock::createStructure): Deleted. (JSC::ModuleProgramCodeBlock::create): Deleted. (JSC::ModuleProgramCodeBlock::createStructure): Deleted. (JSC::EvalCodeBlock::create): Deleted. (JSC::EvalCodeBlock::createStructure): Deleted. (JSC::FunctionCodeBlock::create): Deleted. (JSC::FunctionCodeBlock::createStructure): Deleted. (JSC::WebAssemblyCodeBlock::create): Deleted. (JSC::WebAssemblyCodeBlock::createStructure): Deleted. (JSC::CodeBlock::clearVisitWeaklyHasBeenCalled): Deleted.
  • bytecode/DeferredCompilationCallback.cpp: (JSC::DeferredCompilationCallback::DeferredCompilationCallback): (JSC::DeferredCompilationCallback::~DeferredCompilationCallback): (JSC::DeferredCompilationCallback::compilationDidComplete):
  • bytecode/DeferredCompilationCallback.h:
  • bytecode/EvalCodeCache.h: (JSC::EvalCodeCache::tryGet): (JSC::EvalCodeCache::getSlow):
  • bytecode/PolymorphicAccess.cpp: (JSC::AccessCase::generate): (JSC::PolymorphicAccess::regenerate):
  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::addAccessCase):
  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parse):
  • dfg/DFGDesiredTransitions.cpp: (JSC::DFG::DesiredTransition::reallyAdd):
  • dfg/DFGDesiredWeakReferences.cpp: (JSC::DFG::DesiredWeakReferences::reallyAdd):
  • dfg/DFGDriver.cpp: (JSC::DFG::compile):
  • dfg/DFGGraph.cpp: (JSC::DFG::Graph::Graph):
  • dfg/DFGJITCode.h: (JSC::DFG::JITCode::osrEntryBlock): Deleted. (JSC::DFG::JITCode::setOSREntryBlock): Deleted. (JSC::DFG::JITCode::clearOSREntryBlock): Deleted.
  • dfg/DFGJITFinalizer.cpp: (JSC::DFG::JITFinalizer::finalize): (JSC::DFG::JITFinalizer::finalizeFunction): (JSC::DFG::JITFinalizer::finalizeCommon):
  • dfg/DFGOSRExitCompilerCommon.cpp: (JSC::DFG::adjustAndJumpToTarget):
  • dfg/DFGOperations.cpp:
  • dfg/DFGPlan.cpp: (JSC::DFG::Plan::Plan): (JSC::DFG::Plan::reallyAdd): (JSC::DFG::Plan::notifyReady): (JSC::DFG::Plan::finalizeWithoutNotifyingCallback): (JSC::DFG::Plan::finalizeAndNotifyCallback): (JSC::DFG::Plan::key): (JSC::DFG::Plan::clearCodeBlockMarks): (JSC::DFG::Plan::checkLivenessAndVisitChildren): (JSC::DFG::Plan::rememberCodeBlocks): Deleted.
  • dfg/DFGPlan.h:
  • dfg/DFGToFTLDeferredCompilationCallback.cpp: (JSC::DFG::ToFTLDeferredCompilationCallback::ToFTLDeferredCompilationCallback): (JSC::DFG::ToFTLDeferredCompilationCallback::~ToFTLDeferredCompilationCallback): (JSC::DFG::ToFTLDeferredCompilationCallback::create): (JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously): (JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidComplete):
  • dfg/DFGToFTLDeferredCompilationCallback.h:
  • dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp: (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::ToFTLForOSREntryDeferredCompilationCallback): (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::~ToFTLForOSREntryDeferredCompilationCallback): (JSC::DFG::Ref<ToFTLForOSREntryDeferredCompilationCallback>ToFTLForOSREntryDeferredCompilationCallback::create): (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously): (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidComplete):
  • dfg/DFGToFTLForOSREntryDeferredCompilationCallback.h:
  • dfg/DFGWorklist.cpp: (JSC::DFG::Worklist::completeAllPlansForVM): (JSC::DFG::Worklist::clearCodeBlockMarks): (JSC::DFG::completeAllPlansForVM): (JSC::DFG::clearCodeBlockMarks): (JSC::DFG::Worklist::rememberCodeBlocks): Deleted. (JSC::DFG::rememberCodeBlocks): Deleted.
  • dfg/DFGWorklist.h: (JSC::DFG::worklistForIndexOrNull):
  • ftl/FTLJITFinalizer.cpp: (JSC::FTL::JITFinalizer::finalizeFunction):
  • heap/CodeBlockSet.cpp: (JSC::CodeBlockSet::~CodeBlockSet): (JSC::CodeBlockSet::add): (JSC::CodeBlockSet::clearMarksForFullCollection): (JSC::CodeBlockSet::clearMarksForEdenCollection): (JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced): (JSC::CodeBlockSet::remove): (JSC::CodeBlockSet::traceMarked): (JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks): (JSC::CodeBlockSet::dump):
  • heap/CodeBlockSet.h:
  • heap/Heap.cpp: (JSC::Heap::markRoots): (JSC::Heap::clearLivenessData): (JSC::Heap::traceCodeBlocksAndJITStubRoutines): (JSC::Heap::deleteAllCodeBlocks): (JSC::Heap::deleteAllUnlinkedCodeBlocks): (JSC::Heap::clearUnmarkedExecutables): (JSC::Heap::willStartCollection):
  • interpreter/Interpreter.cpp: (JSC::eval):
  • jit/GCAwareJITStubRoutine.h:
  • jit/JITCode.h: (JSC::JITCode::isJIT): (JSC::JITCode::timeToLive): (JSC::JITCode::isLowerTier):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_enter):
  • jit/JITOperations.cpp:
  • jit/JITToDFGDeferredCompilationCallback.cpp: (JSC::JITToDFGDeferredCompilationCallback::create): (JSC::JITToDFGDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously): (JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):
  • jit/JITToDFGDeferredCompilationCallback.h:
  • jit/Repatch.cpp: (JSC::tryCacheGetByID): (JSC::tryCachePutByID): (JSC::tryRepatchIn): (JSC::linkFor): (JSC::linkPolymorphicCall):
  • llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL): (JSC::LLInt::setUpCall):
  • runtime/CommonSlowPaths.cpp: (JSC::SLOW_PATH_DECL):
  • runtime/CommonSlowPaths.h: (JSC::CommonSlowPaths::tryCachePutToScopeGlobal): (JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal):
  • runtime/Executable.cpp: (JSC::ExecutableBase::clearCode): (JSC::ScriptExecutable::installCode): (JSC::ScriptExecutable::newCodeBlockFor): (JSC::ScriptExecutable::newReplacementCodeBlockFor): (JSC::ScriptExecutable::prepareForExecutionImpl): (JSC::EvalExecutable::visitChildren): (JSC::EvalExecutable::clearCode): (JSC::ProgramExecutable::checkSyntax): (JSC::ProgramExecutable::visitChildren): (JSC::ProgramExecutable::clearCode): (JSC::ModuleProgramExecutable::visitChildren): (JSC::ModuleProgramExecutable::clearCode): (JSC::FunctionExecutable::baselineCodeBlockFor): (JSC::FunctionExecutable::visitChildren): (JSC::FunctionExecutable::clearCode): (JSC::FunctionExecutable::fromGlobalCode): (JSC::WebAssemblyExecutable::visitChildren): (JSC::WebAssemblyExecutable::clearCode): (JSC::WebAssemblyExecutable::prepareForExecution):
  • runtime/Executable.h: (JSC::ExecutableBase::generatedJITCodeForCall): (JSC::ScriptExecutable::prepareForExecution): (JSC::ExecutableBase::clearCodeVirtual):
  • runtime/VM.cpp: (JSC::VM::VM):
  • runtime/VM.h:
9:35 PM Changeset in webkit [190452] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Unreviewed build fix for run-api-tests

  • Scripts/run-api-tests:

(testToolPaths): Windows run needs to specify the binary path.

9:27 PM Changeset in webkit [190451] by Wenson Hsieh
  • 2 edits
    2 adds
    1 delete in trunk

Convert focused-input-should-assist-on-touch.html into an automated test
https://bugs.webkit.org/show_bug.cgi?id=149724

Reviewed by Simon Fraser.

.:

Remove a manual test that can now be rewritten as an automated test.

  • ManualTests/ios/focused-input-should-assist-on-touch.html: Removed.

LayoutTests:

Tests that an input that focuses itself on touch and then prevents default is
able to trigger node assistance, even when it is already focused before the
user gesture.

  • fast/events/ios/focused-input-should-assist-on-touch-expected.txt: Added.
  • fast/events/ios/focused-input-should-assist-on-touch.html: Added.
8:45 PM Changeset in webkit [190450] by ggaren@apple.com
  • 44 edits in trunk/Source/JavaScriptCore

CodeBlock should be a GC object
https://bugs.webkit.org/show_bug.cgi?id=149727

Reviewed by Filip Pizlo.

We want CodeBlock to be a GC object:

(1) Sane write barriers. Because CodeBlock wasn't a GC object, we couldn't
execute a write barrier on it. This caused us to do weird things that
were hard to reason about, like executing a barrier on a related executable
(even though the executable might stop pointing to the CodeBlock before
the next GC), or pretending that an object had written to itself. Now,
when we write to a CodeBlock, we barrier the CodeBlock, and that's that.

(2) Simpler marking and destruction logic. There's no need to have a
custom remembered set or a destruction fixpoint if we just obey normal
GC rules.

  • bytecode/CodeBlock.cpp:

(JSC::FunctionCodeBlock::destroy):
(JSC::WebAssemblyCodeBlock::destroy):
(JSC::ProgramCodeBlock::destroy):
(JSC::ModuleProgramCodeBlock::destroy):
(JSC::EvalCodeBlock::destroy): Add ClassInfo and destroy functions
because our GC object model requires them.

Note that we do not set the needsDestruction flag. Since CodeBlock needs
eager destruction, it runs its destructors through CodeBlockSet,
and not through normal object sweeping.

(JSC::CodeBlock::finishCreation): Factor out finishCreation from the
constructor because our GC object model requires it. Change write
barriers to note the CodeBlock as the owner.

(JSC::CodeBlock::~CodeBlock): Refactor to use the shared
unlinkIncomingCalls() function instead of rolling a copy by hand.

(JSC::CodeBlock::visitWeakly): New helper function for owner executables
to do weak marking that might jettison a CodeBlock. Our new GC logic
says that a CodeBlock pointer is a strong reference by default, and
clients need to opt in if they want to allow a CodeBlock to jettison.
This is easier to get right because it means that only those
specific owners that want jettison behavior need to worry about it,
while all other pointers are valid by default.

(JSC::CodeBlock::visitChildren): The default visit function keeps
everything alive.

(JSC::CodeBlock::shouldVisitStrongly):
(JSC::CodeBlock::isKnownToBeLiveDuringGC): No need to keep special state
anymore. If we're marked, we're live -- just like any other object.

(JSC::timeToLive): Move this code into CodeBlock.cpp so you can mess
with it without recompiling, and also because it's really a CodeBlock
policy.

(JSC::CodeBlock::WeakReferenceHarvester::visitWeakReferences):
(JSC::CodeBlock::UnconditionalFinalizer::finalizeUnconditionally): Use
internal objects for virtual callbacks because GC objects can't have
vtables.

(JSC::CodeBlock::unlinkIncomingCalls): Remove a fast path check that does
not exist in the copy of this code in ~CodeBlock because it is not
actually an optimization.

(JSC::CodeBlock::replacement):
(JSC::CodeBlock::computeCapabilityLevel): Make these functions generic
instead of virtual because GC objects can't have vtables.

(JSC::CodeBlock::visitStrongly): Deleted.
(JSC::CodeBlock::visitAggregate): Deleted.
(JSC::CodeBlock::visitWeakReferences): Deleted.
(JSC::CodeBlock::finalizeUnconditionally): Deleted.
(JSC::ProgramCodeBlock::replacement): Deleted.
(JSC::ModuleProgramCodeBlock::replacement): Deleted.
(JSC::EvalCodeBlock::replacement): Deleted.
(JSC::FunctionCodeBlock::replacement): Deleted.
(JSC::ProgramCodeBlock::capabilityLevelInternal): Deleted.
(JSC::ModuleProgramCodeBlock::capabilityLevelInternal): Deleted.
(JSC::EvalCodeBlock::capabilityLevelInternal): Deleted.
(JSC::FunctionCodeBlock::capabilityLevelInternal): Deleted.
(JSC::WebAssemblyCodeBlock::replacement): Deleted.
(JSC::WebAssemblyCodeBlock::capabilityLevelInternal): Deleted.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::unlinkedCodeBlock):
(JSC::CodeBlock::addressOfNumParameters):
(JSC::CodeBlock::offsetOfNumParameters):
(JSC::CodeBlock::alternative):
(JSC::CodeBlock::forEachRelatedCodeBlock):
(JSC::CodeBlock::specializationKind):
(JSC::CodeBlock::instructionCount):
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::hasBaselineJITProfiling):
(JSC::CodeBlock::capabilityLevelState):
(JSC::CodeBlock::addConstant):
(JSC::CodeBlock::appendExceptionHandler):
(JSC::CodeBlock::setConstantRegisters):
(JSC::CodeBlock::replaceConstant):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::create):
(JSC::ProgramCodeBlock::createStructure):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::ModuleProgramCodeBlock::create):
(JSC::ModuleProgramCodeBlock::createStructure):
(JSC::ModuleProgramCodeBlock::ModuleProgramCodeBlock):
(JSC::EvalCodeBlock::create):
(JSC::EvalCodeBlock::createStructure):
(JSC::EvalCodeBlock::variable):
(JSC::EvalCodeBlock::numVariables):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::EvalCodeBlock::unlinkedEvalCodeBlock):
(JSC::FunctionCodeBlock::create):
(JSC::FunctionCodeBlock::createStructure):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::WebAssemblyCodeBlock::create):
(JSC::WebAssemblyCodeBlock::createStructure):
(JSC::WebAssemblyCodeBlock::WebAssemblyCodeBlock):
(JSC::ExecState::uncheckedR):
(JSC::CodeBlock::clearVisitWeaklyHasBeenCalled):
(JSC::CodeBlockSet::mark):
(JSC::ScriptExecutable::forEachCodeBlock):
(JSC::CodeBlock::setAlternative): Deleted.
(JSC::CodeBlock::clearMarks): Deleted. Lots of mechanical changes to
match the logic changes above.

  • bytecode/DeferredCompilationCallback.cpp:

(JSC::DeferredCompilationCallback::DeferredCompilationCallback):
(JSC::DeferredCompilationCallback::~DeferredCompilationCallback):
(JSC::DeferredCompilationCallback::compilationDidComplete):

  • bytecode/DeferredCompilationCallback.h: Provide a profiledDFGCodeBlock

to all compilation callbacks instead of requiring the callback to
store the profiledDFGCodeBlock. This is how the rest of compilation
around the callback works anyway, and it is easier to do things this
way than to think about how a non-GC malloc'd object should keep its
CodeBlock alive.

  • bytecode/EvalCodeCache.h:

(JSC::EvalCodeCache::tryGet):
(JSC::EvalCodeCache::getSlow):

  • bytecode/PolymorphicAccess.cpp:

(JSC::AccessCase::generate):
(JSC::PolymorphicAccess::regenerate):

  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::addAccessCase): Change the owner for write
barrier purposes to CodeBlock.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGDesiredTransitions.cpp:

(JSC::DFG::DesiredTransition::reallyAdd):

  • dfg/DFGDesiredWeakReferences.cpp:

(JSC::DFG::DesiredWeakReferences::reallyAdd):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph): Ditto.

  • dfg/DFGJITCode.h:

(JSC::DFG::JITCode::osrEntryBlock):
(JSC::DFG::JITCode::setOSREntryBlock):
(JSC::DFG::JITCode::clearOSREntryBlock): Use helper functions for
accessing osrEntryBlock to help with write barrier stuff.

  • dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::finalize):
(JSC::DFG::JITFinalizer::finalizeFunction):
(JSC::DFG::JITFinalizer::finalizeCommon):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::adjustAndJumpToTarget): Use CodeBlock as owner instead of
executable.

  • dfg/DFGOperations.cpp:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::reallyAdd):
(JSC::DFG::Plan::notifyReady):
(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):
(JSC::DFG::Plan::finalizeAndNotifyCallback):
(JSC::DFG::Plan::key):
(JSC::DFG::Plan::rememberCodeBlocks):
(JSC::DFG::Plan::checkLivenessAndVisitChildren):
(JSC::DFG::Plan::clearCodeBlockMarks): Deleted.

  • dfg/DFGPlan.h: Use normal GC write barrier concepts to model the fact

that the compiler writes to CodeBlocks.

  • dfg/DFGToFTLDeferredCompilationCallback.cpp:

(JSC::DFG::ToFTLDeferredCompilationCallback::ToFTLDeferredCompilationCallback):
(JSC::DFG::ToFTLDeferredCompilationCallback::~ToFTLDeferredCompilationCallback):
(JSC::DFG::ToFTLDeferredCompilationCallback::create):
(JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidComplete):

  • dfg/DFGToFTLDeferredCompilationCallback.h:
  • dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:

(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::ToFTLForOSREntryDeferredCompilationCallback):
(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::~ToFTLForOSREntryDeferredCompilationCallback):
(JSC::DFG::Ref<ToFTLForOSREntryDeferredCompilationCallback>ToFTLForOSREntryDeferredCompilationCallback::create):
(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidComplete):

  • dfg/DFGToFTLForOSREntryDeferredCompilationCallback.h: We always have

a profiledDFGCodeBlock passed to use -- see above.

  • dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::completeAllPlansForVM):
(JSC::DFG::Worklist::rememberCodeBlocks):
(JSC::DFG::completeAllPlansForVM):
(JSC::DFG::rememberCodeBlocks):
(JSC::DFG::Worklist::clearCodeBlockMarks): Deleted.
(JSC::DFG::clearCodeBlockMarks): Deleted.

  • dfg/DFGWorklist.h:

(JSC::DFG::worklistForIndexOrNull): Renamed to use remembered set terminology.

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeFunction):

  • heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::~CodeBlockSet):
(JSC::CodeBlockSet::add):
(JSC::CodeBlockSet::clearMarksForFullCollection):
(JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced): No need for a fixpoint
anymore since the GC can tell us if we are live.

(JSC::CodeBlockSet::remove):
(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):
(JSC::CodeBlockSet::dump):
(JSC::CodeBlockSet::clearMarksForEdenCollection): Deleted. No need for
this logic anymore since the GC will clear our mark bit.

(JSC::CodeBlockSet::traceMarked): Deleted. No need for this marking
fixpoint anymore either.

  • heap/CodeBlockSet.h:
  • heap/Heap.cpp:

(JSC::Heap::markRoots): Moved some of this logic around to make the
algorithm clearer.

(JSC::Heap::deleteAllCodeBlocks): Deleting CodeBlocks can only clear
pointers immediately; they won't fully delete until the next GC and sweep.

  • interpreter/Interpreter.cpp:

(JSC::eval):

  • jit/GCAwareJITStubRoutine.h: CodeBlock is owner now.
  • jit/JITCode.h:

(JSC::JITCode::isJIT):
(JSC::JITCode::isLowerTier):
(JSC::JITCode::timeToLive): Deleted.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_enter): CodeBlock is owner now.

  • jit/JITOperations.cpp:
  • jit/JITToDFGDeferredCompilationCallback.cpp:

(JSC::JITToDFGDeferredCompilationCallback::create):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):

  • jit/JITToDFGDeferredCompilationCallback.h:
  • jit/Repatch.cpp:

(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):
(JSC::tryRepatchIn):
(JSC::linkFor):
(JSC::linkPolymorphicCall):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::setUpCall):

  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::tryCachePutToScopeGlobal):
(JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal): CodeBlock is owner now.

  • runtime/Executable.cpp:

(JSC::ExecutableBase::clearCode): Provide a generic clearCode() so that
it can be used on any Executable. This fixes a very subtle bug where
deleteAllCode() does not remove CodeBlocks from non-function executables
that have been saved in stack traces.

(JSC::ScriptExecutable::installCode): WriteBarrier requires special
handling for pointers that may be null.

(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::ScriptExecutable::newReplacementCodeBlockFor):
(JSC::ScriptExecutable::prepareForExecutionImpl): Update for interface
changes.

(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::ModuleProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):
(JSC::WebAssemblyExecutable::visitChildren): Visit weakly because we want
to participate in jettisoning.

(JSC::WebAssemblyExecutable::prepareForExecution):
(JSC::EvalExecutable::clearCode): Deleted.
(JSC::ProgramExecutable::clearCode): Deleted.
(JSC::ModuleProgramExecutable::clearCode): Deleted.
(JSC::FunctionExecutable::clearCode): Deleted.
(JSC::WebAssemblyExecutable::clearCode): Deleted.

  • runtime/Executable.h:

(JSC::ExecutableBase::generatedJITCodeForCall):
(JSC::ScriptExecutable::prepareForExecution):
(JSC::ExecutableBase::clearCodeVirtual): Deleted.

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h: Provide structures because our GC requires it.
7:15 PM Changeset in webkit [190449] by dino@apple.com
  • 8 edits
    2 deletes in trunk

Rollout r190446 for the moment. It broke the build.

6:53 PM Changeset in webkit [190448] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Simplify filterableData processing
https://bugs.webkit.org/show_bug.cgi?id=149730

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-01
Reviewed by Timothy Hatcher.

  • UserInterface/Views/BreakpointTreeElement.js:

(WebInspector.BreakpointTreeElement.prototype.get filterableData):

  • UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement.matchTextFilter):

  • UserInterface/Views/ResourceTreeElement.js:

(WebInspector.ResourceTreeElement.prototype.get filterableData):

  • UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView.prototype.matchTreeElementAgainstCustomFilters): Deleted.

  • UserInterface/Views/SearchResultTreeElement.js:

(WebInspector.SearchResultTreeElement.prototype.get filterableData):
(WebInspector.SearchResultTreeElement):

6:29 PM Changeset in webkit [190447] by ljaehun.lim@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix build warning after r190434

Fix error: variable ‘interruption’ set but not used [-Werror=unused-but-set-variable]

  • testing/Internals.cpp:

(WebCore::Internals::beginMediaSessionInterruption):

6:09 PM Changeset in webkit [190446] by dino@apple.com
  • 8 edits
    2 adds in trunk

Expose WEBGL_debug_renderer_info
https://bugs.webkit.org/show_bug.cgi?id=149735
<rdar://problem/18343500>

Reviewed by Simon Fraser.

Source/WebCore:

Enable the extension that allows content to query
for the GPUs vendor and details.

Now that we're enabling this, there was no need for
the internal setting that identified privileged situations.
However, since this meant that WEBGL_debug_shaders was
also exposed, I explicitly disable it since it is
not yet conformant.

Test: fast/canvas/webgl/webgl-debug-renderer-info.html
as well as the general conformance suite.

  • html/canvas/WebGL2RenderingContext.cpp: No need to guard around allowPrivilegedExtensions().

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContext.cpp: Ditto.

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::allowPrivilegedExtensions): Deleted.

  • html/canvas/WebGLRenderingContextBase.h:
  • page/Settings.in: Remove privilegedWebGLExtensions.
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: Forbid the translated shader

extension while it is still buggy.
(WebCore::Extensions3DOpenGL::supportsExtension):

LayoutTests:

Modify a test from the 1.0.2 conformance suite to make sure
we're actually enabling and passing the info.

  • fast/canvas/webgl/webgl-debug-renderer-info-expected.txt: Added.
  • fast/canvas/webgl/webgl-debug-renderer-info.html: Added.
6:03 PM Changeset in webkit [190445] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.2.7.2

New tag.

6:01 PM Changeset in webkit [190444] by bshafiei@apple.com
  • 5 edits in branches/safari-601.2.7-branch/Source

Versioning.

5:56 PM Changeset in webkit [190443] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.25.1

New tag.

5:56 PM Changeset in webkit [190442] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.2.7.1

New tag.

5:21 PM Changeset in webkit [190441] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaselining fast/text/mark-matches-overflow-clip.html for Win
https://webkit.org/b/149728

Unreviewed test gardening.

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-01

  • platform/win/fast/text/mark-matches-overflow-clip-expected.txt:
5:09 PM Changeset in webkit [190440] by Brent Fulgham
  • 4 edits in trunk

.:
[Win] Unreviewed CMake build fix.

  • Source/cmake/OptionsWin.cmake: Clean up options setttings,

and make sure exception handling is turned off.

Tools:
Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

Following r190424 we can now rely on webkit-build-directory to return the path to
the correct configuration-specific build directory on Windows.

Patch by Daniel Bates <dabates@apple.com> on 2015-10-01

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):

5:03 PM Changeset in webkit [190439] by dbates@webkit.org
  • 2 edits in trunk/Tools

Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

Following r190424 we can now rely on webkit-build-directory to return the path to
the correct configuration-specific build directory on Windows.

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):

4:43 PM Changeset in webkit [190438] by Brent Fulgham
  • 3 edits in trunk/LayoutTests

Unreviewed test fix after r190434.

One test was not updated to pass the new required interruption type
argument to 'internals.beginMediaSessionInterruption'.

  • webaudio/audiocontext-state-interrupted-expected.txt:
  • webaudio/audiocontext-state-interrupted.html:
4:34 PM Changeset in webkit [190437] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Do not immediately create all ProfileNodeTreeElements when showing JavaScript and Events timeline
https://bugs.webkit.org/show_bug.cgi?id=149726

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-01
Reviewed by Timothy Hatcher.

  • UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype.shouldFilterPopulate):
(WebInspector.NavigationSidebarPanel.prototype._updateFilter):
(WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
We were populating during filtering if there were any custom filters.
However the TimelineSidebarPanel has custom filters (based on time and type)
but those don't need to trigger population. Delay population until it
would actually be needed (like a text search).

  • UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel.prototype.shouldFilterPopulate):
Do not populate on filter via this custom filters.

4:33 PM Changeset in webkit [190436] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION (r189567): Toolbar collapses when inspector at minimum height with console open
https://bugs.webkit.org/show_bug.cgi?id=149725

Reviewed by Timothy Hatcher.

CSS Flexible Box Layout Module Level 1 introduces a new auto initial value for the min-{width|height}
of flex box items, breaking some areas of the inspector UI. This is fixed by setting a min-height of
zero for the #main <div>.

  • UserInterface/Views/Main.css:

(#main):

4:21 PM Changeset in webkit [190435] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove unnecessary SpecialFastCaseProfiles.
https://bugs.webkit.org/show_bug.cgi?id=149729

Reviewed by Saam Barati.

The current baseline code creates special fast case profiles records for
bytecodes that don't need them. This was done to keep the DFG from crashing when
it searches for such a profile and don't find one. Instead, we will fix the code
to check for the existence of the profile before dereferencing it to get a count.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::specialFastCaseProfileCountForBytecodeOffset):
(JSC::CodeBlock::couldTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::numberOfArrayProfiles):
(JSC::CodeBlock::arrayProfiles):
(JSC::CodeBlock::addArrayProfile):
(JSC::CodeBlock::likelyToTakeSpecialFastCase): Deleted. Not used.
(JSC::CodeBlock::likelyToTakeAnySlowCase): Deleted. Not used.

  • jit/JITArithmetic.cpp:

(JSC::JIT::compileBinaryArithOp):

  • Only op_mul needs the profile. So, only allocate it in the op_mul case.

(JSC::JIT::emit_op_mul):

  • These op_mul cases create the profile but never increments its counter. Hence, we can get rid of these.
3:32 PM Changeset in webkit [190434] by Brent Fulgham
  • 18 edits in trunk

[iOS] AirPlay should not stop when the screen locks
https://bugs.webkit.org/show_bug.cgi?id=148315
<rdar://problem/22770703>

Patch by Eric Carlson <eric.carlson@apple.com> on 2015-10-01
Reviewed by Jer Noble.

Source/WebCore:

Tested by media/video-interruption-with-resume-allowing-play.html

media/video-interruption-with-resume-not-allowing-play.html

  • Modules/webaudio/AudioContext.h: overrideBackgroundPlaybackRestriction -> shouldOverrideBackgroundPlaybackRestriction.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::suspendPlayback): Fix a typo in the logging.
(WebCore::HTMLMediaElement::mayResumePlayback): Ditto.
(WebCore::HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction): Renamed from

overrideBackgroundPlaybackRestriction.

(WebCore::HTMLMediaElement::overrideBackgroundPlaybackRestriction): Deleted.

  • html/HTMLMediaElement.h:
  • platform/audio/PlatformMediaSession.cpp:

(WebCore::stateName):
(WebCore::interruptionName): New, log the name of the interruption.
(WebCore::PlatformMediaSession::beginInterruption): Log the interruption type. Don't

increment the interruption counter if we are going to ignore it. Incorporate logic
from doInterruption.

(WebCore::PlatformMediaSession::doInterruption): Deleted.
(WebCore::PlatformMediaSession::shouldDoInterruption): Deleted.
(WebCore::PlatformMediaSession::forceInterruption): Deleted.

  • platform/audio/PlatformMediaSession.h: Add SuspendedUnderLock interruption type.
  • platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::applicationDidEnterBackground): Deleted.

  • platform/audio/PlatformMediaSessionManager.h:
  • platform/audio/ios/MediaSessionManagerIOS.h:
  • platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::applicationDidEnterBackground): Call beginInterruption

when appropriate.

LayoutTests:

  • media/video-interruption-with-resume-allowing-play.html:
  • media/video-interruption-with-resume-not-allowing-play.html:
2:40 PM Changeset in webkit [190433] by bshafiei@apple.com
  • 3 edits
    6 copies in branches/safari-601.2.7-branch

Merged r190418. rdar://problem/22936771

2:37 PM Changeset in webkit [190432] by bshafiei@apple.com
  • 5 edits in branches/safari-601.2.7-branch/Source

Versioning.

1:47 PM Changeset in webkit [190431] by bshafiei@apple.com
  • 3 edits
    6 copies in branches/safari-601.1.46.25-branch

Merged r190418. rdar://problem/22936628

1:36 PM Changeset in webkit [190430] by rniwa@webkit.org
  • 3 edits
    4 adds in trunk

Slot elements should support fallback contents
https://bugs.webkit.org/show_bug.cgi?id=149701

Reviewed by Antti Koivisto.

Source/WebCore:

Following discussions on Github discussions [1] [2], we're adding the default rule of display: contents
on slot elements and making slot elements render its children when there are no assigned nodes [3].

Make these changes by attaching renderers on direct-children of slot elements when there are no assigned
nodes during render tree construction. Note display: contents will be aded in webkit.org/b/149439.

[1] https://github.com/w3c/webcomponents/issues/317
[2] https://github.com/w3c/webcomponents/issues/308
[3] https://github.com/w3c/webcomponents/issues/308#issuecomment-143655347

Tests: fast/shadow-dom/css-scoping-shadow-slot-fallback.html

fast/shadow-dom/shadow-layout-after-slot-fallback-changes.html

  • style/StyleResolveTree.cpp:

(WebCore::Style::attachSlotAssignees):
(WebCore::Style::detachSlotAssignees):
(WebCore::Style::resolveSlotAssignees):

LayoutTests:

Added tests for fallback contents in slot elements. One of them could be safely submitted to CSS WG,
and the other one is a style recalc test.

  • fast/shadow-dom/css-scoping-shadow-slot-fallback-expected.html: Added.
  • fast/shadow-dom/css-scoping-shadow-slot-fallback.html: Added.
  • fast/shadow-dom/shadow-layout-after-slot-fallback-changes-expected.html: Added.
  • fast/shadow-dom/shadow-layout-after-slot-fallback-changes.html: Added.
1:24 PM Writing Layout Tests to test iOS UI features edited by Wenson Hsieh
Added documentation on key event testing to UIScriptController wiki page (diff)
1:20 PM Changeset in webkit [190429] by keith_miller@apple.com
  • 19 edits
    1 copy
    21 adds in trunk

[ES6] Add TypedArray.prototype functionality.
https://bugs.webkit.org/show_bug.cgi?id=148035

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This patch should add most of the functionality for
the prototype properties of TypedArray objects in ES6.
There are a few exceptions to this, which will be added
in upcoming patches:

1) First we do not use the species constructor for some
of the TypedArray prototype functions (namely: map, filter,
slice, and subarray). That will need to be added when
species constructors are finished.

2) TypedArrays still have a length, byteOffset, byteLength,
and buffer are still attached to the TypedArray instance (in
the spec they are on the TypedArray.prototype instance object)
since the JIT currently assumes those properties are fixed.

3) The TypedArray.constructor property is not added yet
as it should point to the TypedArray instance object,
which will be added in a future patch.

(every):
(find):
(findIndex):
(forEach):
(some):
(sort.min):
(sort.merge):
(sort.mergeSort):
(sort):
(reduce):
(reduceRight):
(map):
(filter):
(toLocaleString):

  • runtime/ArrayPrototype.cpp:
  • runtime/ArrayPrototype.h:
  • runtime/CommonIdentifiers.h:
  • runtime/JSGenericTypedArrayView.h:

(JSC::JSGenericTypedArrayView::toAdaptorNativeFromValue):
(JSC::JSGenericTypedArrayView::setRangeToValue):
(JSC::JSGenericTypedArrayView::sort):
(JSC::JSGenericTypedArrayView::purifyArray):
(JSC::JSGenericTypedArrayView::sortComparison):
(JSC::JSGenericTypedArrayView::sortFloat):

  • runtime/JSGenericTypedArrayViewInlines.h:
  • runtime/JSGenericTypedArrayViewPrototypeFunctions.h: Added.

(JSC::argumentClampedIndexFromStartOrEnd):
(JSC::genericTypedArrayViewProtoFuncSet):
(JSC::genericTypedArrayViewProtoFuncEntries):
(JSC::genericTypedArrayViewProtoFuncCopyWithin):
(JSC::genericTypedArrayViewProtoFuncFill):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncJoin):
(JSC::genericTypedArrayViewProtoFuncKeys):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):
(JSC::genericTypedArrayViewProtoGetterFuncLength):
(JSC::genericTypedArrayViewProtoGetterFuncByteLength):
(JSC::genericTypedArrayViewProtoGetterFuncByteOffset):
(JSC::genericTypedArrayViewProtoFuncReverse):
(JSC::genericTypedArrayViewPrivateFuncSort):
(JSC::genericTypedArrayViewProtoFuncSlice):
(JSC::genericTypedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncValues):

  • runtime/JSGenericTypedArrayViewPrototypeInlines.h:

(JSC::JSGenericTypedArrayViewPrototype<ViewClass>::finishCreation):
(JSC::genericTypedArrayViewProtoFuncSet): Deleted.
(JSC::genericTypedArrayViewProtoFuncSubarray): Deleted.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSObject.h:
  • runtime/JSTypedArrayPrototypes.cpp:
  • runtime/JSTypedArrayPrototypes.h:
  • runtime/JSTypedArrayViewPrototype.cpp: Added.

(JSC::typedArrayViewPrivateFuncLength):
(JSC::typedArrayViewPrivateFuncSort):
(JSC::typedArrayViewProtoFuncSet):
(JSC::typedArrayViewProtoFuncEntries):
(JSC::typedArrayViewProtoFuncCopyWithin):
(JSC::typedArrayViewProtoFuncFill):
(JSC::typedArrayViewProtoFuncLastIndexOf):
(JSC::typedArrayViewProtoFuncIndexOf):
(JSC::typedArrayViewProtoFuncJoin):
(JSC::typedArrayViewProtoFuncKeys):
(JSC::typedArrayViewProtoGetterFuncLength):
(JSC::typedArrayViewProtoGetterFuncByteLength):
(JSC::typedArrayViewProtoGetterFuncByteOffset):
(JSC::typedArrayViewProtoFuncReverse):
(JSC::typedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncSlice):
(JSC::typedArrayViewProtoFuncValues):
(JSC::JSTypedArrayViewPrototype::JSTypedArrayViewPrototype):
(JSC::JSTypedArrayViewPrototype::finishCreation):
(JSC::JSTypedArrayViewPrototype::create):
(JSC::JSTypedArrayViewPrototype::createStructure):

  • runtime/JSTypedArrayViewPrototype.h: Copied from Source/JavaScriptCore/runtime/JSTypedArrayPrototypes.cpp.
  • tests/es6.yaml:
  • tests/stress/resources/standalone-pre.js: Added.

(description):
(debug):
(escapeString):
(testPassed):
(testFailed):
(areNumbersEqual):
(areArraysEqual):
(isMinusZero):
(isTypedArray):
(isResultCorrect):
(stringify):
(shouldBe):
(dfgShouldBe):
(shouldBeType):
(shouldBeTrue):
(shouldBeFalse):
(shouldBeNaN):
(shouldBeNull):
(shouldBeEqualToString):
(shouldBeUndefined):
(shouldNotThrow):
(shouldThrow):
(dfgCompiled):
(dfgIncrement):
(noInline):
(finishJSTest):

  • tests/stress/resources/typedarray-test-helper-functions.js: Added.

(forEachTypedArray):
(isSameFunctionForEachTypedArrayPrototype.eq):
(isSameFunctionForEachTypedArrayPrototype):
(hasSameValues):
(foo):
(testPrototypeFunctionHelper):
(testPrototypeFunctionOnSigned):
(testPrototypeFunctionOnFloat):
(testPrototypeFunction):
(tester):
(testPrototypeReceivesArray):

  • tests/stress/typedarray-copyWithin.js: Added.
  • tests/stress/typedarray-every.js: Added.

(isBigEnough):
(isBigEnoughAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-fill.js: Added.
  • tests/stress/typedarray-filter.js: Added.

(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-find.js: Added.

(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-findIndex.js: Added.

(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-forEach.js: Added.

(checkCorrect.let.list):
(checkCorrect):
(createChecker):
(foo):
(changeArray):
(isBigEnoughAndException):

  • tests/stress/typedarray-indexOf.js: Added.

(keepEven):

  • tests/stress/typedarray-lastIndexOf.js: Added.
  • tests/stress/typedarray-map.js: Added.

(even):
(evenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-reduce.js: Added.

(createArray):
(sum):
(createArrayAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-reduceRight.js: Added.

(createArray):
(sum):
(createArrayAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-slice.js: Added.
  • tests/stress/typedarray-some.js: Added.

(isBigEnough):
(isBigEnoughAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-sort.js: Added.

(sortBackwards):
(compareException):

LayoutTests:

Fixed tests for new toString behavior on TypedArrays.

  • fast/canvas/webgl/type-conversion-test-expected.txt:
  • fast/dom/Window/window-postmessage-clone-expected.txt:
1:18 PM Changeset in webkit [190428] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Fix TestWebKitAPI build under CMake.

Reviewed by Alex Christensen.

  • TestWebKitAPI/PlatformWin.cmake: Add missing link command

for Psapi.lib.

1:05 PM Changeset in webkit [190427] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46.25-branch/Source/WebCore

Merged r188298. rdar://problem/22936040

12:54 PM Changeset in webkit [190426] by Nikita Vasilyev
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Clip string previews
https://bugs.webkit.org/show_bug.cgi?id=149708

Only show first 140 characters in strings previews.

Reviewed by Joseph Pecoraro.

  • UserInterface/Base/Utilities.js:

(String.prototype.truncate): Added.
A smart trancate function that doesn't split words.

  • UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype._shouldConsiderObjectLossless):

  • UserInterface/Views/FormattedValue.js:

(WebInspector.FormattedValue.createElementForTypesAndValue):

12:50 PM Changeset in webkit [190425] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] Another CMake build fix

  • PlatformWin.cmake: Add missing Psapi.lib to link list.
12:38 PM Changeset in webkit [190424] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Fix behavior of webkit-build-directory script
https://bugs.webkit.org/show_bug.cgi?id=149718

Reviewed by Alex Christensen.

  • Scripts/webkitdirs.pm:

(determineConfigurationProductDir): Do not include the binary
sub-directory in the configuration product directory output.
(jscProductDir): Append correct binary path for Windows build.
(setPathForRunningWebKitApp): Include properly binary subdirectories.
(runSafari): Update for revised productDir behavior.
(runMiniBrowser): Ditto.

12:31 PM Changeset in webkit [190423] by Brent Fulgham
  • 3 edits
    2 adds in trunk

Latch does not clear when a scroll snap animation is triggered
https://bugs.webkit.org/show_bug.cgi?id=149681
<rdar://problem/22733922>

Reviewed by Simon Fraser.

Source/WebCore:

Test: tiled-drawing/scrolling/latched-div-with-scroll-snap.html

The scroll snap animation logic bypasses some of the normal clean-up code used
for wheel event handling. When this happens, the scroll latching state is not
cleared. In some cases this "stale" latch state is used when starting a new
gesture in the same frame. This causes the wrong page element to receive the
mouse wheel events, and hilarity ensues.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::platformNotifyIfEndGesture): Clear latched state when
ending the gesture.

LayoutTests:

Add a new test that confirms latched state is cleared when scroll snap animations
are triggered.

  • tiled-drawing/scrolling/latched-div-with-scroll-snap-expected.txt: Added.
  • tiled-drawing/scrolling/latched-div-with-scroll-snap.html: Added.
12:12 PM Changeset in webkit [190422] by Simon Fraser
  • 4 edits in trunk/LayoutTests

Remove some tests that now pass.

  • TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
11:47 AM Changeset in webkit [190421] by Brent Fulgham
  • 9 edits in trunk/Source

[Win] Unreviewed CMake build fixes.

Source/WebCore:

  • CMakeLists.txt: Match original Windows build flags for WebCoreTest.
  • PlatformAppleWin.cmake: Use the same build defines as the

original Windows build.

Source/WebKit:

  • CMakeLists.txt: Set the same build definitions as the original

project file.

  • PlatformWin.cmake: Remove some soft-linked files from the static

link commands. Set build flags to match original project files.

Source/WTF:

  • wtf/CMakeLists.txt: Correct build flags to match

the original project files.

11:26 AM Changeset in webkit [190420] by Simon Fraser
  • 3 edits
    3 adds in trunk/LayoutTests

Add iOS touch event test
https://bugs.webkit.org/show_bug.cgi?id=149688

Reviewed by Ryosuke Niwa.

Basic touch event test that synthesizes touches in the UI process.

  • TestExpectations:
  • fast/events/touch/ios/touch-event-expected.txt: Added.
  • fast/events/touch/ios/touch-event.html: Added.
  • platform/ios-simulator-wk2/TestExpectations:
11:14 AM Changeset in webkit [190419] by ap@apple.com
  • 2 edits in trunk/Tools

Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
use iOS SDK, like with all the others.

  • Scripts/build-webkit:
11:09 AM Changeset in webkit [190418] by Antti Koivisto
  • 3 edits
    6 adds in trunk

Network cache: Subresource referer header wrong after cached redirect
https://bugs.webkit.org/show_bug.cgi?id=149709
rdar://problem/22917174

Reviewed by Chris Dumez.

Source/WebKit2:

If a main resource is loaded from a cache entry that involved redirects the document
will end up setting the Referer-headers of the subresources to the request URL not the redirected URL

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):

If a cache entry involved a redirect synthesize a minimal willSendRequest message so that WebCore side
runs through the same code paths as when receiving a redirect from network.

LayoutTests:

  • http/tests/cache/redirect-referer-expected.html: Added.
  • http/tests/cache/redirect-referer.html: Added.
  • http/tests/cache/resources/load-and-check-referer.php: Added.
  • http/tests/cache/resources/permanent-redirect.php: Added.
  • http/tests/cache/resources/redirect-referer-iframe.html: Added.
  • http/tests/cache/resources/redirect-referer-iframe-expected.html: Added.
10:45 AM Changeset in webkit [190417] by mmaxfield@apple.com
  • 4 edits in trunk/LayoutTests

accessibility/mac/aria-expanded-notifications.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=149510

Reviewed by Chris Fleizach.

The problem is triggered by our resumable parser. AXLoadComplete gets called
synchronously from DocumentLoader::finishedLoading(). This means that the order of
the AXLoadComplete message isn't FIFO.

If the parser yielded previously, the AXLoadComplete will be handled after some AX
messages had been handled.

If the parser hadn't yielded, the AXLoadComplete will be the first message
processed (no matter what had been queued up before it).

Because making the AXLoadComplete message asynchonous is not desirable, the
solution is to relax the test to handle various orderings.

  • accessibility/mac/aria-expanded-notifications-expected.txt:
  • accessibility/mac/aria-expanded-notifications.html:
  • platform/mac/TestExpectations:
10:42 AM Changeset in webkit [190416] by BJ Burg
  • 6 edits in trunk/Source

Web Inspector: Adjust font size of Developer Tools using Command,+ or Command,-
https://bugs.webkit.org/show_bug.cgi?id=149590

Patch by João Oliveira <hello@jxs.pt> on 2015-09-30
Reviewed by Joseph Pecoraro.

Patch by João Oliveira and Brian Burg.

Source/WebCore:

Expose the frontend page's zoom factor so we can implement relative zoom.

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::zoomFactor): Added.

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • page/Frame.h:

(WebCore::Frame::pageZoomFactor):

Source/WebInspectorUI:

  • UserInterface/Base/Main.js:

(WebInspector.contentLoaded): Add global keyboard shortcuts for zoom in and zoom out.

10:38 AM Changeset in webkit [190415] by dbates@webkit.org
  • 3 edits in trunk/Tools

Attempt to fix the iOS 9 Simulator testers

Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
LayoutTestRelay when building for iOS Simulator.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • Scripts/build-webkit:
10:20 AM Changeset in webkit [190414] by Yusuke Suzuki
  • 8 edits
    1 add in trunk/Source/JavaScriptCore

Introduce SymbolUse optimization into CompareEq and CompareStrictEq
https://bugs.webkit.org/show_bug.cgi?id=149616

Reviewed by Saam Barati.

Since ES6 Symbols are used as an enum value[1] (And WebKit inspector do so for Esprima's type of nodes),
optimizing equality comparison for symbols makes much sense.

This patch leverages SymbolUse for CompareEq and CompareStrictEq.
Optimizations for both DFG and FTL are implemented.

[1]: http://www.2ality.com/2014/12/es6-symbols.html

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateSymbol):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::extractStringImplFromBinarySymbols):
(JSC::DFG::SpeculativeJIT::compileSymbolEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleSymbolEquality):

  • dfg/DFGSpeculativeJIT.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCompareStrictEq):

  • tests/stress/symbol-equality.js: Added.

(shouldBe):
(equal):
(strictEqual):
(list.forEach.result.set 1):

10:18 AM Changeset in webkit [190413] by Carlos Garcia Campos
  • 6 edits in trunk

[GTK] Websites with invalid auth header keep loading forever
https://bugs.webkit.org/show_bug.cgi?id=149710

Reviewed by Martin Robinson.

Source/WebCore:

We don't correctly handle a null realm from the server when
retrieving and storing credentials from libsecret. First
secret_attributes_build() fails because we pass a null domain, and
we pass null attributes to secret_service_search() that returns
early on a g_return macro and the callback is never called so the
load doesn't continue after the auth challenge.

  • platform/network/gtk/CredentialBackingStore.cpp:

(WebCore::createAttributeHashTableFromChallenge):
(WebCore::CredentialBackingStore::credentialForChallenge):
(WebCore::CredentialBackingStore::storeCredentialsForChallenge):

Source/WebKit2:

Do not show the remember credentials checkbutton in the auth
dialog if the realm is empty.

  • UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:

(webkitAuthenticationDialogInitialize):

Tools:

Add test case to check that we can authenticate sites with an
empty realm.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:

(testWebViewAuthenticationEmptyRealm):
(serverCallback):
(beforeAll):

10:16 AM Changeset in webkit [190412] by ap@apple.com
  • 2 edits in trunk/Tools

[Mac] Make run-api-tests work with System Integrity Protection
https://bugs.webkit.org/show_bug.cgi?id=149711
rdar://problem/22928202

Reviewed by Dan Bernstein.

  • Scripts/run-api-tests:

(runTest):
(archCommandLineArgumentsForRestrictedEnvironmentVariables):

10:10 AM Changeset in webkit [190411] by dbates@webkit.org
  • 2 edits in trunk/Tools

Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
For now, use the path to the top-level WebKit build directory instead of using the configuration-
specific build directory.

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):

9:43 AM Changeset in webkit [190410] by dbates@webkit.org
  • 3 edits
    7 moves
    7 adds
    1 delete in trunk/LayoutTests

Move <a ping> tests from LayoutTests/http/tests/navigation to LayoutTests/http/tests/navigation/ping-attribute
https://bugs.webkit.org/show_bug.cgi?id=148828

Reviewed by Alexey Proskuryakov.

Towards adding <area ping> tests (bug #79438), we should move the existing <a ping> tests from
LayoutTests/http/tests/navigation to LayoutTests/http/tests/navigation/ping-attribute and rename
them so as to make it clear from their name that they test the ping attribute on a HTML a element.

  • http/tests/navigation/ping-attribute/anchor-cookie-expected.txt: Renamed from LayoutTests/http/tests/navigation/ping-cookie-expected.txt.
  • http/tests/navigation/ping-attribute/anchor-cookie.html: Renamed from LayoutTests/http/tests/navigation/ping-cookie.html.
  • http/tests/navigation/ping-attribute/anchor-cross-origin-expected.txt: Added.
  • http/tests/navigation/ping-attribute/anchor-cross-origin-from-https-expected.txt: Renamed from LayoutTests/http/tests/navigation/ping-cross-origin-from-https-expected.txt.
  • http/tests/navigation/ping-attribute/anchor-cross-origin-from-https.html: Renamed from LayoutTests/http/tests/navigation/ping-cross-origin-from-https.html.
  • http/tests/navigation/ping-attribute/anchor-cross-origin.html: Renamed from LayoutTests/http/tests/navigation/ping-cross-origin.html.
  • http/tests/navigation/ping-attribute/anchor-same-origin-expected.txt: Renamed from LayoutTests/http/tests/navigation/ping-same-origin-expected.txt.
  • http/tests/navigation/ping-attribute/anchor-same-origin.html: Renamed from LayoutTests/http/tests/navigation/ping-same-origin.html.
  • http/tests/navigation/ping-attribute/resources/check-ping.php: Added.
  • http/tests/navigation/ping-attribute/resources/delete-ping.php: Added.
  • http/tests/navigation/ping-attribute/resources/ping-file-path.php: Added.
  • http/tests/navigation/ping-attribute/resources/save-Ping.php: Added.
  • http/tests/navigation/ping-cross-origin-expected.txt: Removed.
  • platform/ios-simulator-wk2/TestExpectations: Updated as needed for the above file renames.
  • platform/win/TestExpectations: Ditto.
8:39 AM Changeset in webkit [190409] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/Tools

[EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
https://bugs.webkit.org/show_bug.cgi?id=145837

Reviewed by Philippe Normand.

  • efl/jhbuild.modules:
  • efl/patches/openwebrtc-clang-warning-fix.patch: Added.
  • efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
8:18 AM Changeset in webkit [190408] by Wenson Hsieh
  • 2 edits in trunk/Tools

Unreviewed. Fix the iOS build after r190407.

  • WebKitTestRunner/ios/IOKitSPI.h:
7:28 AM Changeset in webkit [190407] by Wenson Hsieh
  • 11 edits
    2 adds in trunk

Implement keyboard event sending for iOS in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=149676

Reviewed by Simon Fraser.

Tools:

Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
allows us to run code when the keyboard is shown or hidden.

  • WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
  • WebKitTestRunner/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::setDidShowKeyboardCallback):
(WTR::UIScriptController::didShowKeyboardCallback):
(WTR::UIScriptController::setDidHideKeyboardCallback):
(WTR::UIScriptController::didHideKeyboardCallback):
(WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
(WTR::UIScriptController::platformSetDidShowKeyboardCallback):
(WTR::UIScriptController::platformSetDidHideKeyboardCallback):

  • WebKitTestRunner/UIScriptContext/UIScriptController.h:
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to

the notifications that the keyboard has been raised or lowered.

(-[TestRunnerWKWebView _keyboardDidShow:]):
(-[TestRunnerWKWebView _keyboardDidHide:]):

  • WebKitTestRunner/ios/HIDEventGenerator.h:
  • WebKitTestRunner/ios/HIDEventGenerator.m:

(-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
(shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
(hidUsageCodeForCharacter): Ditto.
(-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering

a keyDown event in WebKit.

  • WebKitTestRunner/ios/IOKitSPI.h:
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

LayoutTests:

Adds a new basic test for the oninput event listener when typing in a text field.

  • fast/events/ios/input-value-after-oninput-expected.txt: Added.
  • fast/events/ios/input-value-after-oninput.html: Added.
6:38 AM Changeset in webkit [190406] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed, rolling out r190399.

Tests are still failing even after r190362

Reverted changeset:

"Unreviewed. Unskip GTK+ user media unit tests after r190362."
http://trac.webkit.org/changeset/190399

6:38 AM Changeset in webkit [190405] by Andres Gomez
  • 1 edit
    2 adds in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add GTK+ icons for the numerical input and slider based Visual editors for CSS properties
https://bugs.webkit.org/show_bug.cgi?id=147847

Reviewed by Carlos Garcia Campos.

  • UserInterface/Images/gtk/VisualStylePropertyLinked.svg: Added.
  • UserInterface/Images/gtk/VisualStylePropertyUnlinked.svg: Added.
6:36 AM Changeset in webkit [190404] by Andres Gomez
  • 3 edits
    19 adds in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add GTK+ icons for the different types of non-numerical Visual editors for CSS properties
https://bugs.webkit.org/show_bug.cgi?id=147846

Reviewed by Carlos Garcia Campos.

  • UserInterface/Images/gtk/AUTHORS: Updated.
  • UserInterface/Images/gtk/ClearBoth.svg: Added.
  • UserInterface/Images/gtk/ClearLeft.svg: Added.
  • UserInterface/Images/gtk/ClearRight.svg: Added.
  • UserInterface/Images/gtk/CubicBezier.svg: Updated.
  • UserInterface/Images/gtk/FloatLeft.svg: Added.
  • UserInterface/Images/gtk/FloatRight.svg: Added.
  • UserInterface/Images/gtk/FontStyleItalic.svg: Added.
  • UserInterface/Images/gtk/FontStyleNormal.svg: Added.
  • UserInterface/Images/gtk/FontVariantSmallCaps.svg: Added.
  • UserInterface/Images/gtk/TextAlignCenter.svg: Added.
  • UserInterface/Images/gtk/TextAlignJustify.svg: Added.
  • UserInterface/Images/gtk/TextAlignLeft.svg: Added.
  • UserInterface/Images/gtk/TextAlignRight.svg: Added.
  • UserInterface/Images/gtk/TextDecorationLineThrough.svg: Added.
  • UserInterface/Images/gtk/TextDecorationOverline.svg: Added.
  • UserInterface/Images/gtk/TextDecorationUnderline.svg: Added.
  • UserInterface/Images/gtk/TextTransformCapitalize.svg: Added.
  • UserInterface/Images/gtk/TextTransformLowercase.svg: Added.
  • UserInterface/Images/gtk/TextTransformUppercase.svg: Added.
  • UserInterface/Images/gtk/VisualStyleNone.svg: Added.
6:07 AM Changeset in webkit [190403] by youenn.fablet@crf.canon.fr
  • 47 edits in trunk/Source/WebCore

Refactor binding generator to factor JS DOM class m_impl handling
https://bugs.webkit.org/show_bug.cgi?id=149660

Reviewed by Darin Adler.

Added JSDOMWrapperWithImplementation template class to move m_impl out of the binding generator.
Updated custom bindings to use impl() instead of m_impl directly.
Updated binding generator accordingly.

Covered by existing tests and binding tests.

  • bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::getOwnPropertyNames):
(WebCore::JSDOMStringMap::deleteProperty):

  • bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapperWithImplementation::impl):
(WebCore::JSDOMWrapperWithImplementation::~JSDOMWrapperWithImplementation):
(WebCore::JSDOMWrapperWithImplementation::JSDOMWrapperWithImplementation):
(WebCore::JSDOMWrapperWithImplementation::releaseImpl):

  • bindings/js/JSGeolocationCustom.cpp:

(WebCore::JSGeolocation::getCurrentPosition):
(WebCore::JSGeolocation::watchPosition):

  • bindings/js/JSSQLResultSetRowListCustom.cpp:

(WebCore::JSSQLResultSetRowList::item):

  • bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):

  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::JSSubtleCrypto::encrypt):
(WebCore::JSSubtleCrypto::decrypt):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::verify):
(WebCore::JSSubtleCrypto::wrapKey):
(WebCore::JSSubtleCrypto::unwrapKey):

  • bindings/scripts/CodeGeneratorJS.pm:

(GetParentClassName):
(GetImplClassName):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObject::JSTestActiveDOMObject):
(WebCore::JSTestActiveDOMObject::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestActiveDOMObject.h:

(WebCore::JSTestActiveDOMObject::~JSTestActiveDOMObject):

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::JSTestCustomConstructorWithNoInterfaceObject::JSTestCustomConstructorWithNoInterfaceObject):
(WebCore::jsTestCustomConstructorWithNoInterfaceObjectConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.h:

(WebCore::JSTestCustomConstructorWithNoInterfaceObject::~JSTestCustomConstructorWithNoInterfaceObject):
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h:

(WebCore::JSTestCustomNamedGetter::~JSTestCustomNamedGetter):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::JSTestEventConstructor):
(WebCore::jsTestEventConstructorAttr1): Deleted.

  • bindings/scripts/test/JS/JSTestEventConstructor.h:

(WebCore::JSTestEventConstructor::~JSTestEventConstructor):
(WebCore::JSTestEventConstructor::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTarget::JSTestEventTarget):
(WebCore::JSTestEventTarget::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestEventTarget.h:

(WebCore::JSTestEventTarget::~JSTestEventTarget):

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestException::JSTestException):
(WebCore::JSTestException::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestException.h:

(WebCore::JSTestException::~JSTestException):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachable::JSTestGenerateIsReachable):
(WebCore::jsTestGenerateIsReachableConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.h:

(WebCore::JSTestGenerateIsReachable::~JSTestGenerateIsReachable):
(WebCore::JSTestGenerateIsReachable::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::JSTestInterface):
(WebCore::JSTestInterface::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::jsTestJSBuiltinConstructorConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h:

(WebCore::JSTestJSBuiltinConstructor::~JSTestJSBuiltinConstructor):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
(WebCore::jsTestMediaQueryListListenerConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::~JSTestMediaQueryListListener):
(WebCore::JSTestMediaQueryListListener::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::JSTestNamedConstructor):
(WebCore::jsTestNamedConstructorConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:

(WebCore::JSTestNamedConstructor::~JSTestNamedConstructor):
(WebCore::JSTestNamedConstructor::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestNondeterministic.cpp:

(WebCore::JSTestNondeterministic::JSTestNondeterministic):
(WebCore::jsTestNondeterministicNondeterministicReadonlyAttr): Deleted.

  • bindings/scripts/test/JS/JSTestNondeterministic.h:

(WebCore::JSTestNondeterministic::~JSTestNondeterministic):
(WebCore::JSTestNondeterministic::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::JSTestObj):
(WebCore::JSTestObj::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::~JSTestObj):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructors::JSTestOverloadedConstructors):
(WebCore::jsTestOverloadedConstructorsConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.h:

(WebCore::JSTestOverloadedConstructors::~JSTestOverloadedConstructors):
(WebCore::JSTestOverloadedConstructors::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::JSTestOverrideBuiltins::JSTestOverrideBuiltins):
(WebCore::JSTestOverrideBuiltins::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestOverrideBuiltins.h:

(WebCore::JSTestOverrideBuiltins::~JSTestOverrideBuiltins):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
(WebCore::jsTestSerializedScriptValueInterfaceValue): Deleted.

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::~JSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterface::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefs::JSTestTypedefs):
(WebCore::JSTestTypedefs::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestTypedefs.h:

(WebCore::JSTestTypedefs::~JSTestTypedefs):

  • bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::JSattribute::JSattribute):
(WebCore::jsattributeReadonly): Deleted.

  • bindings/scripts/test/JS/JSattribute.h:

(WebCore::JSattribute::~JSattribute):
(WebCore::JSattribute::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::JSreadonly::JSreadonly):
(WebCore::jsreadonlyConstructor): Deleted.

  • bindings/scripts/test/JS/JSreadonly.h:

(WebCore::JSreadonly::~JSreadonly):
(WebCore::JSreadonly::finishCreation): Deleted.

5:59 AM WebKitGTK/2.10.x edited by Andres Gomez
Added Web Inspector icons bugs (diff)
5:35 AM Changeset in webkit [190402] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix the ARM build after r190192
https://bugs.webkit.org/show_bug.cgi?id=149620

Reviewed by Darin Adler.

  • platform/graphics/FontFeatureSettings.h:

(WebCore::fontFeatureTag):

5:30 AM Changeset in webkit [190401] by youenn.fablet@crf.canon.fr
  • 20 edits
    1 copy in trunk

[Streams API] Add support for private WebCore JS builtins functions
https://bugs.webkit.org/show_bug.cgi?id=149518

Reviewed by Darin Adler.

Source/JavaScriptCore:

Adding API to add private identifiers on the fly.
This is used to support private JS Builtin functions/private JS Builtin names in WebCore.

  • builtins/BuiltinNames.h:

(JSC::BuiltinNames::appendExternalName):

  • runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::appendExternalName):

  • runtime/CommonIdentifiers.h:

Source/WebCore:

Using ReadableStream tee method as a testbed to add support for private WebCore JS builtins functions.
Private functions are hooked to JSDOMWindowBase, as it is the one connected to WebCoreClientData.
WebCoreClientData is responsible to export the private function symbols to the VM.

Updated generate-js-builtins script to generate a class that can create and own all JS functions.
This class is used by JSDOMWindowBase to create the JS builtin functions.
It is also used to manage the GC of these objects.

Covered by rebased tests.

  • CMakeLists.txt: Adding ReadableStreamInternals builtin files.
  • DerivedSources.cpp: Ditto.
  • DerivedSources.make: Ditto.
  • Modules/streams/ReadableStream.idl: Adding tee declaration as builtin
  • Modules/streams/ReadableStream.js:

(tee): Calling @teeReadableStream

  • Modules/streams/ReadableStreamInternals.js: Barebone @teeReadableStream implementation.

(teeReadableStream):

  • WebCore.vcxproj/WebCore.vcxproj: Adding ReadableStreamInternals builtin files.
  • WebCore.xcodeproj/project.pbxproj: Adding ReadableStreamInternals builtin files.
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase): Creating ReadableStreamInternalsBuiltinFunctions object.
(WebCore::JSDOMWindowBase::finishCreation): Creating builtin functions through ReadableStreamInternalsBuiltinFunctions and registering them to the JS engine.
(WebCore::JSDOMWindowBase::visitChildren): Ensuring GC does not collect private builtin functions through ReadableStreamInternalsBuiltinFunctions object

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/WebCoreJSClientData.h:

(WebCore::WebCoreJSClientData::WebCoreJSClientData): Exporting private names of ReadableStreamInternalsBuiltins
(WebCore::WebCoreJSClientData::readableStreamBuiltins):
(WebCore::WebCoreJSClientData::readableStreamInternalsBuiltins):

  • generate-js-builtins: Adding support for ReadableStreamInternalsBuiltinFunctions and exportNames.

LayoutTests:

Rebasing tests now that tee is appearing in the IDL, although not yet conformant in its implementation.

  • streams/reference-implementation/readable-stream-expected.txt:
  • streams/reference-implementation/readable-stream-tee-expected.txt:
  • streams/reference-implementation/readable-stream-templated-expected.txt:
3:52 AM Changeset in webkit [190400] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

[jhbuild] switch to new upstream usrsctp library
https://bugs.webkit.org/show_bug.cgi?id=149494

Reviewed by Philippe Normand.

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:
2:28 AM Changeset in webkit [190399] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Unskip GTK+ user media unit tests after r190362.

They should pass now.

  • Scripts/run-gtk-tests:

(TestRunner):

1:12 AM Changeset in webkit [190398] by youenn.fablet@crf.canon.fr
  • 9 edits in trunk/Source/WebCore

Binding generator should make mutable CachedAttribute member fields
https://bugs.webkit.org/show_bug.cgi?id=148056

Reviewed by Chris Dumez.

Making mutable CachedAttribute member fields.
Removing const_cast from custom binding code.
Rebased bindings tests.

No change in behavior.

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::state):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data):

  • bindings/js/JSPopStateEventCustom.cpp:

(WebCore::cacheState):
(WebCore::JSPopStateEvent::state):

  • bindings/js/JSReadableStreamReaderEventCustom.cpp:

(WebCore::JSReadableStreamReader::closed):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::response):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
1:00 AM Changeset in webkit [190397] by bshafiei@apple.com
  • 1 copy in branches/safari-601.2.7-branch

New Branch.

12:44 AM Changeset in webkit [190396] by calvaris@igalia.com
  • 3 edits in trunk/LayoutTests

[Streams API] Update readable-stream tests against latest reference
https://bugs.webkit.org/show_bug.cgi?id=149668

Reviewed by Darin Adler.

  • streams/reference-implementation/readable-stream-expected.txt: Updated expectations.
  • streams/reference-implementation/readable-stream.html: Updated tests.
12:41 AM Changeset in webkit [190395] by calvaris@igalia.com
  • 10 edits in trunk/LayoutTests

[Stream API] Add pending checkpoints for up-to-date readable stream related tests and fix checkpoint URL
https://bugs.webkit.org/show_bug.cgi?id=149666

Reviewed by Darin Adler.

  • streams/readable-stream-reader-read.html:
  • streams/reference-implementation/abstract-ops.html:
  • streams/reference-implementation/bad-strategies.html:
  • streams/reference-implementation/bad-underlying-sources.html:
  • streams/reference-implementation/pipe-to-options.html:
  • streams/reference-implementation/pipe-to.html:
  • streams/reference-implementation/readable-stream-cancel.html:
  • streams/reference-implementation/writable-stream-abort.html:
  • streams/reference-implementation/writable-stream.html: Added and fixed checkpoint URLs.
12:38 AM Changeset in webkit [190394] by calvaris@igalia.com
  • 19 edits
    1 copy
    1 add
    1 delete in trunk

[Streams API] Create ByteLengthQueuingStrategy object as per spec
https://bugs.webkit.org/show_bug.cgi?id=147153

Reviewed by Darin Adler.

Source/WebCore:

Added ByteLengthQueuingStream class as the spec defines at https://streams.spec.whatwg.org/#blqs-class.

Tests are covered by current set.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/WebCoreJSBuiltins.cpp: Added build instructions.
  • Modules/streams/ByteLengthQueuingStrategy.idl: Added.
  • Modules/streams/ByteLengthQueuingStrategy.js: Copied from Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp.

(size): Return byteLength attribute of the chunk.
(initializeByteLengthQueuingStrategy): Initialize the highWaterMark property.

  • bindings/js/WebCoreJSClientData.h:

(WebCore::WebCoreJSClientData::WebCoreJSClientData): Initialize the blqs builtins.
(WebCore::WebCoreJSClientData::byteLengthQueuingStrategyBuiltins): Return the attribute.

LayoutTests:

  • js/dom/global-constructors-attributes-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-expected.txt:
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/win/js/dom/global-constructors-attributes-expected.txt: Added ByteLengthQueuingStrategy to the

constructor expectations.

  • streams/reference-implementation/brand-checks.html:
  • streams/reference-implementation/byte-length-queuing-strategy.html: Removed reference to

byte-length-queuing-strategy.js as it should be now builtin in WebKit.

  • streams/reference-implementation/resources/byte-length-queuing-strategy.js: Removed.

(ByteLengthQueuingStrategy): Deleted.

12:31 AM Changeset in webkit [190393] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46.25-branch/Source

Versioning.

12:29 AM Changeset in webkit [190392] by bshafiei@apple.com
  • 1 copy in branches/safari-601.1.46.25-branch

New Branch.

12:22 AM Changeset in webkit [190391] by Gyuyoung Kim
  • 10 edits in trunk/Source/WebCore

Clean up all uses of PassRefPtr in Modules/geolocation
https://bugs.webkit.org/show_bug.cgi?id=149552

Reviewed by Darin Adler.

  • Modules/geolocation/GeoNotifier.cpp:

(WebCore::GeoNotifier::GeoNotifier):
(WebCore::GeoNotifier::setFatalError):

  • Modules/geolocation/GeoNotifier.h:

(WebCore::GeoNotifier::create):

  • Modules/geolocation/Geolocation.cpp:

(WebCore::createGeoposition):
(WebCore::createPositionError):
(WebCore::Geolocation::Watchers::add):
(WebCore::Geolocation::getCurrentPosition):
(WebCore::Geolocation::watchPosition):
(WebCore::Geolocation::startRequest):

  • Modules/geolocation/Geolocation.h:
  • Modules/geolocation/GeolocationError.h:
  • Modules/geolocation/GeolocationPosition.h:
  • Modules/geolocation/Geoposition.h:

(WebCore::Geoposition::create):
(WebCore::Geoposition::isolatedCopy):
(WebCore::Geoposition::Geoposition):

  • Modules/geolocation/PositionError.h:
  • Modules/geolocation/PositionOptions.h:

Sep 30, 2015:

11:00 PM Changeset in webkit [190390] by ljaehun.lim@samsung.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, cleanup after r190385

TypedArray.prototype.js is removed at r190385.
Remove it from CMakeLists.txt as well.

  • CMakeLists.txt:
10:54 PM Changeset in webkit [190389] by dbates@webkit.org
  • 2 edits in trunk/Tools

Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

  • BuildSlaveSupport/built-product-archive:

(determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
(extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.

10:45 PM Changeset in webkit [190388] by dbates@webkit.org
  • 2 edits in trunk/Tools

Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

Actually, we need to pass --configuration to script webkit-build-directory to have
it return the path to the configuration-specific build directory.

  • BuildSlaveSupport/built-product-archive:

(determineWebKitBuildDirectories):

9:57 PM Changeset in webkit [190387] by dbates@webkit.org
  • 2 edits in trunk/Tools

built-product-archive archives incorrect build directory for iOS port
https://bugs.webkit.org/show_bug.cgi?id=149695

Reviewed by Darin Adler.

Fixes an issue where the script built-product-archive archives a non-existent
build directory for the iOS port. Without loss of generality, the script assumes
the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.

Currently the script built-product-archive calls webkit-build-directory --top-level ...
to determine the top-level build directory and computes the configuration-specific
build directory to be the concatenation of the the top-level build directory and
the configuration (e.g. Release). This is incorrect. Instead we should call
webkit-build-directory omitting the flag --top-level to compute the path to the
configuration-specific build directory.

  • BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.

(main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
its purpose and added global variable _configurationBuildDirectory to store the path
to the configuration-specific build directory. Ensure that we have a non-empty string
for both the top-level and configuration-specific build directories.
(determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
Compute the configuration-specific build directory and store it in the global variable
_configurationBuildDirectory.
(archiveBuiltProduct): Modified to use _configurationBuildDirectory.
(extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
as needed.
(determineWebKitBuildDirectory): Deleted.

9:21 PM Changeset in webkit [190386] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] css3/device-adapt/* tests failed after r190335.
https://bugs.webkit.org/show_bug.cgi?id=149655

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-09-30
Reviewed by Simon Fraser.

device-adapt/* tests need the fixedLayout option but useFixedLayout option is
overwritten by updatePlatformSpecificViewOptionsForTest after r190335.

  • WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::shouldUseFixedLayout):

9:16 PM Changeset in webkit [190385] by commit-queue@webkit.org
  • 19 edits
    20 deletes in trunk

Unreviewed, rolling out r190367 and r190373.
https://bugs.webkit.org/show_bug.cgi?id=149694

Windows build broken (Requested by smfr on #webkit).

Reverted changesets:

"[ES6] Add TypedArray.prototype functionality."
https://bugs.webkit.org/show_bug.cgi?id=148035
http://trac.webkit.org/changeset/190367

"Unreviewed Windows buildfix."
http://trac.webkit.org/changeset/190373

8:55 PM Changeset in webkit [190384] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL][Gtk] Try to fix the build after r190379.
https://bugs.webkit.org/show_bug.cgi?id=149693

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-09-30
Reviewed by Gyuyoung Kim.

  • Modules/indexeddb/server/MemoryIDBBackingStore.h:
8:17 PM Changeset in webkit [190383] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Source/WebCore:
Add support for the imageSmoothingQuality property for CanvasRenderingContext2D.
https://bugs.webkit.org/show_bug.cgi?id=149541

Patch by Katlyn Graff <kgraff@apple.com> on 2015-09-30
Reviewed by Ryosuke Niwa.

As documented here: https://html.spec.whatwg.org/multipage/scripting.html#image-smoothing
Exposes the smooothing quality of algorithms used for scaling images. Valid input
values are low, medium, and high: associated algorithms are expected to vary for
differing hardware. setImageSmoothingQuality provides a handle into CGInterpolationQuality.

Test: fast/canvas/canvas-imageSmoothingQuality.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::State::operator=):
(WebCore::smoothingToInterpolationQuality):
(WebCore::CanvasRenderingContext2D::imageSmoothingQuality):
(WebCore::CanvasRenderingContext2D::setImageSmoothingQuality):
(WebCore::CanvasRenderingContext2D::setImageSmoothingEnabled):

  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:
Tests support for imageSmoothingQuality attribute of Canvas element.
https://bugs.webkit.org/show_bug.cgi?id=149541

Patch by Katlyn Graff <kgraff@apple.com> on 2015-09-30
Reviewed by Ryosuke Niwa.

Tests low, medium, high, and default values, value persistence when
imageSmoothingEnabled is changed, and invalid input.

  • fast/canvas/canvas-imageSmoothingQuality-expected.txt: Added.
  • fast/canvas/canvas-imageSmoothingQuality.html: Added.
6:39 PM Changeset in webkit [190382] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

GraphicsContext3D::mappedSymbolName should initialize count variable
https://bugs.webkit.org/show_bug.cgi?id=149692
<rdar://problem/22871304>

Reviewed by Simon Fraser.

While debugging another WebGL issue, I noticed that some
OpenGL renderers can get into a state where they
drop resources (e.g. a GPU reset). If we don't detect that
in time, we might try to ask for the currently attached
resources and our in-parameter will not be set. In this
case, initialize it to zero so that we don't do silly things.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::mappedSymbolName): Initialize count to 0.

6:32 PM Changeset in webkit [190381] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Reduce delete in Timeline related classes
https://bugs.webkit.org/show_bug.cgi?id=149686

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-30
Reviewed by Timothy Hatcher.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.capturingStopped):

  • UserInterface/Views/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.prototype._refreshDirtyDataGridNodes):
(WebInspector.TimelineDataGrid.prototype._sort):
(WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):

  • UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview.prototype.updateLayout):
(WebInspector.TimelineOverview.prototype._handleScrollEvent):

  • UserInterface/Views/TreeOutlineDataGridSynchronizer.js:

(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeOutlineScrolled):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._dataGridScrolled):

  • UserInterface/Views/ProbeSetDataGrid.js:

(WebInspector.ProbeSetDataGrid):
(WebInspector.ProbeSetDataGrid.prototype._teardownData):
Remove an unused member variable as well.

6:29 PM Changeset in webkit [190380] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Crash in gleLookupHashObject when context is lost
https://bugs.webkit.org/show_bug.cgi?id=149690
<rdar://problem/22751585>
<rdar://problem/22465495>

Reviewed by Simon Fraser.

When we received notification that the GPU has reset,
we were nulling out and deleting our OpenGL contexts
and then trying to do it all over again. The fix was
to flip the order of operations.

While there I added some logging, and changed the
way we check GPU status to make sure we do a check
after the first draw call.

Unfortunately we can't test automatically because it
involves resetting the GPU which can possibly cause
concurrent tests to fail.

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::checkGPUStatusIfNecessary): Move forceContextLost()
to be the first thing we do after we've realised we need to
bail.

6:04 PM Changeset in webkit [190379] by beidson@apple.com
  • 19 edits
    8 copies
    3 adds in trunk

Add UniqueIDBDatabase object, IDBBackingStore objects, and a database operation thread.
https://bugs.webkit.org/show_bug.cgi?id=149678

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/opendatabase-request-event.html

  • UniqueIDBDatabase represents a specific IDB database instance that can have multiple connections to it.
  • IDBBackingStore is an abstract representation of a unique database's backing store, and has a concrete in-memory implementation for now.
  • The database thread exists on IDBServer and is for offloading actual database I/O from the main thread.
  • CMakeLists.txt:
  • Modules/indexeddb/IDBDatabaseIdentifier.cpp:

(WebCore::IDBDatabaseIdentifier::isolatedCopy):

  • Modules/indexeddb/IDBDatabaseIdentifier.h:
  • Modules/indexeddb/client/IDBConnectionToServer.cpp:

(WebCore::IDBClient::IDBConnectionToServer::openDatabase):
(WebCore::IDBClient::IDBConnectionToServer::didOpenDatabase):

  • Modules/indexeddb/client/IDBConnectionToServer.h:
  • Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
  • Modules/indexeddb/client/IDBFactoryImpl.cpp:

(WebCore::IDBClient::IDBFactory::openInternal):

  • Modules/indexeddb/server/IDBBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/server/IDBConnectionToClientDelegate.h.

(WebCore::IDBServer::IDBBackingStore::~IDBBackingStore):

  • Modules/indexeddb/server/IDBConnectionToClient.cpp:

(WebCore::IDBServer::IDBConnectionToClient::didOpenDatabase):

  • Modules/indexeddb/server/IDBConnectionToClient.h:
  • Modules/indexeddb/server/IDBConnectionToClientDelegate.h:
  • Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::IDBServer):
(WebCore::IDBServer::IDBServer::getOrCreateUniqueIDBDatabase):
(WebCore::IDBServer::IDBServer::createBackingStore):
(WebCore::IDBServer::IDBServer::openDatabase):
(WebCore::IDBServer::IDBServer::deleteDatabase):
(WebCore::IDBServer::IDBServer::postDatabaseTask):
(WebCore::IDBServer::IDBServer::postDatabaseTaskReply):
(WebCore::IDBServer::IDBServer::databaseThreadEntry):
(WebCore::IDBServer::IDBServer::databaseRunLoop):
(WebCore::IDBServer::IDBServer::handleTaskRepliesOnMainThread):

  • Modules/indexeddb/server/IDBServer.h:
  • Modules/indexeddb/server/IDBServerOperation.cpp: Copied from Source/WebCore/Modules/indexeddb/server/IDBConnectionToClientDelegate.h.

(WebCore::IDBServer::IDBServerOperation::create):
(WebCore::IDBServer::IDBServerOperation::IDBServerOperation):

  • Modules/indexeddb/server/IDBServerOperation.h: Copied from Source/WebCore/Modules/indexeddb/server/IDBServer.h.

(WebCore::IDBServer::IDBServerOperation::connection):
(WebCore::IDBServer::IDBServerOperation::requestData):

  • Modules/indexeddb/server/MemoryIDBBackingStore.cpp: Copied from Source/WebCore/Modules/indexeddb/server/IDBConnectionToClient.cpp.

(WebCore::IDBServer::MemoryIDBBackingStore::create):
(WebCore::IDBServer::MemoryIDBBackingStore::MemoryIDBBackingStore):
(WebCore::IDBServer::MemoryIDBBackingStore::~MemoryIDBBackingStore):
(WebCore::IDBServer::MemoryIDBBackingStore::getOrEstablishDatabaseInfo):

  • Modules/indexeddb/server/MemoryIDBBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/server/IDBConnectionToClient.h.
  • Modules/indexeddb/server/UniqueIDBDatabase.cpp: Added.

(WebCore::IDBServer::UniqueIDBDatabase::UniqueIDBDatabase):
(WebCore::IDBServer::UniqueIDBDatabase::openDatabaseConnection):
(WebCore::IDBServer::UniqueIDBDatabase::handleOpenDatabaseOperations):
(WebCore::IDBServer::UniqueIDBDatabase::openBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::didOpenBackingStore):

  • Modules/indexeddb/server/UniqueIDBDatabase.h: Copied from Source/WebCore/Modules/indexeddb/server/IDBServer.h.

(WebCore::IDBServer::UniqueIDBDatabase::create):

  • Modules/indexeddb/shared/IDBDatabaseInfo.cpp: Copied from Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h.

(WebCore::IDBDatabaseInfo::IDBDatabaseInfo):
(WebCore::IDBDatabaseInfo::isolatedCopy):

  • Modules/indexeddb/shared/IDBDatabaseInfo.h: Copied from Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h.

(WebCore::IDBDatabaseInfo::IDBDatabaseInfo):

  • Modules/indexeddb/shared/InProcessIDBServer.cpp:

(WebCore::InProcessIDBServer::didDeleteDatabase):
(WebCore::InProcessIDBServer::openDatabase):
(WebCore::InProcessIDBServer::didOpenDatabase):

  • Modules/indexeddb/shared/InProcessIDBServer.h:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/CrossThreadCopier.cpp:

(WebCore::IDBDatabaseInfo>::copy):
(WebCore::IDBDatabaseIdentifier>::copy):

  • platform/CrossThreadCopier.h:

LayoutTests:

  • storage/indexeddb/modern/opendatabase-request-event-expected.txt: Added.
  • storage/indexeddb/modern/opendatabase-request-event.html: Added.
5:40 PM Changeset in webkit [190378] by Dewei Zhu
  • 2 edits in trunk/Tools

Extend JetStream timeout for slow devices.

Reviewed by Chris Dumez.

Extend JetStream timeout to 20 minutes.

  • Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
5:26 PM Changeset in webkit [190377] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Thousands of timers fire after switching to JavaScript and Events timeline
https://bugs.webkit.org/show_bug.cgi?id=149682

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-30
Reviewed by Timothy Hatcher.

Setting the status element of a GeneralTreeElement was triggering a
TreeOutline.onchange event. For TreeOutlines with lots of tree elements
(JavaScript & Events with profile nodes) this could result in thousands
of onchange events that causes lots of unnecessary work and blocks
future timers (like scroll synchronization) from firing.

This change eliminates TreeOutline change events for tree element
changes that are not interesting.

  • UserInterface/Views/GeneralTreeElement.js:

(WebInspector.GeneralTreeElement.prototype.set status): Deleted.

  • UserInterface/Views/TreeOutline.js:

(WebInspector.TreeElement.prototype.set tooltip): Deleted.

5:08 PM Changeset in webkit [190376] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Reduce delete in TreeElements and DataGridNodes
https://bugs.webkit.org/show_bug.cgi?id=149680

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-30
Reviewed by Timothy Hatcher.

  • UserInterface/Views/BreakpointTreeElement.js:

(WebInspector.BreakpointTreeElement):
(WebInspector.BreakpointTreeElement.prototype._removeProbeSet):

  • UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype._editingCommitted.moveToNextCell):
(WebInspector.DataGrid.prototype._editingCommitted):
(WebInspector.DataGrid.prototype._editingCancelled):
(WebInspector.DataGrid.prototype.removeColumn):
(WebInspector.DataGridNode.prototype.refreshIfNeeded):
(WebInspector.DataGridNode.prototype.refresh):
(WebInspector.DataGridNode.prototype.expand):
(WebInspector.DataGridNode.prototype.restorePosition):
(WebInspector.DataGridNode):

  • UserInterface/Views/GeneralTreeElement.js:

(WebInspector.GeneralTreeElement.prototype.ondetach):

  • UserInterface/Views/ResourceTimelineDataGridNode.js:

(WebInspector.ResourceTimelineDataGridNode.prototype.refresh):

  • UserInterface/Views/TreeOutline.js:

(WebInspector.TreeElement.prototype._fireDidChange):
(WebInspector.TreeElement.prototype.expand):

5:04 PM Changeset in webkit [190375] by mmaxfield@apple.com
  • 4 edits
    2 adds in trunk

Crash when using an SVG font with > 390 glyphs
https://bugs.webkit.org/show_bug.cgi?id=149677
<rdar://problem/21676402>

Reviewed by Simon Fraser.

Source/WebCore:

The "Charset Index" in OTF are indices into a collection of strings. There are
390 predefined strings in this collection. We were currently assigning each
glyph to one of these strings. However, if there are more glyphs than strings,
we will be using invalid indices.

The values of the strings themselves are not necessary for SVG fonts. Therefore,
the solution is to create a single dummy string, and have all glyphs target it.

Tests: svg/custom/many-glyphs.svg

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::font):

  • svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::appendCFFTable):

LayoutTests:

  • svg/custom/many-glyphs-expected.svg: Added.
  • svg/custom/many-glyphs.svg: Added.
4:56 PM Changeset in webkit [190374] by dbates@webkit.org
  • 3 edits in trunk/Tools

Rename iOS builders/testers to include version
https://bugs.webkit.org/show_bug.cgi?id=149685

Reviewed by Simon Fraser.

Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
make it clear to a reader the version of iOS these builders/testers are using.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4:34 PM Changeset in webkit [190373] by msaboff@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fixed change set order to match reality. Some how the tools messed up the merge of ChangeLog entries.
-This line, and those below, will be ignored--

M Source/JavaScriptCore/ChangeLog

4:27 PM Changeset in webkit [190372] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Relanding r190289 with the following two fixes:

  1. REGRESSION(r190289): It made Speedometer/Full.html performance test fail https://bugs.webkit.org/show_bug.cgi?id=149621

Reviewed by Saam Barati.

We need to restore callee saves for both the fast and slow paths before making a
tail call in the FTL.

  • ftl/FTLJSCallBase.cpp: (JSC::FTL::JSCallBase::emit):
  1. [ARM] REGRESSION(r190289): It made 374 tests crash on 32 bit ARM Linux https://bugs.webkit.org/show_bug.cgi?id=149619

Reviewed by Filip Pizlo.

Need to check for ARMv7_TRADITIONAL and ARMv7 in addition to ARM in "if"
statement to handle platforms with a link register.

  • llint/LowLevelInterpreter.asm: (prepareForTailCall):

Patch by Michael Saboff <msaboff@apple.com> on 2015-09-30

4:03 PM Changeset in webkit [190371] by dbates@webkit.org
  • 3 edits in trunk/Tools

Add iOS criterion for triggering a build
https://bugs.webkit.org/show_bug.cgi?id=149679

Rubber-stamped by Alexey Proskuryakov.

First pass at defining criterion for triggering an iOS build.

  • BuildSlaveSupport/build.webkit.org-config/wkbuild.py:

(_should_file_trigger_build):

  • BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:

(ShouldBuildTest):
(ShouldBuildTest.test_should_build):

3:51 PM Writing Layout Tests to test iOS UI features edited by Simon Fraser
(diff)
3:48 PM Writing Layout Tests to test iOS UI features edited by Simon Fraser
(diff)
3:44 PM Writing Layout Tests to test iOS UI features edited by Simon Fraser
(diff)
3:38 PM Writing Layout Tests to test iOS UI features edited by Simon Fraser
(diff)
3:28 PM Changeset in webkit [190370] by msaboff@apple.com
  • 34 edits
    8 adds in trunk

Source/JavaScriptCore:
Relanding r190289 with the following two fixes:

  1. REGRESSION(r190289): It made Speedometer/Full.html performance test fail https://bugs.webkit.org/show_bug.cgi?id=149621

Reviewed by Saam Barati.

We need to restore callee saves for both the fast and slow paths before making a
tail call in the FTL.

  • ftl/FTLJSCallBase.cpp: (JSC::FTL::JSCallBase::emit):
  1. [ARM] REGRESSION(r190289): It made 374 tests crash on 32 bit ARM Linux https://bugs.webkit.org/show_bug.cgi?id=149619

Reviewed by Filip Pizlo.

Need to check for ARMv7_TRADITIONAL and ARMv7 in addition to ARM in "if"
statement to handle platforms with a link register.


  • llint/LowLevelInterpreter.asm: (prepareForTailCall):

LayoutTests:
Relanding r190289 after fixes tracked in https://bugs.webkit.org/show_bug.cgi?id=149619
and https://bugs.webkit.org/show_bug.cgi?id=149621

Reviewed by Saam Barati.

3:26 PM Writing Layout Tests to test iOS UI features edited by Simon Fraser
(diff)
3:23 PM Writing Layout Tests to test iOS UI features edited by Simon Fraser
(diff)
3:13 PM Writing Layout Tests to test iOS UI features edited by Simon Fraser
(diff)
3:11 PM Changeset in webkit [190369] by Andres Gomez
  • 1 edit
    1 add in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add GTK+ icon for the Bezier curve visual editor
https://bugs.webkit.org/show_bug.cgi?id=147681

Reviewed by Joseph Pecoraro.

  • UserInterface/Images/gtk/CubicBezier.svg: Added.
3:08 PM Writing Layout Tests to test iOS UI features edited by Simon Fraser
(diff)
3:00 PM Writing Layout Tests to test iOS UI features created by Simon Fraser
2:56 PM WikiStart edited by Simon Fraser
(diff)
2:48 PM Changeset in webkit [190368] by Simon Fraser
  • 15 edits
    2 copies
    7 adds in trunk

[iOS] Allow tests to generate user gestures for UI testing
https://bugs.webkit.org/show_bug.cgi?id=149653

Reviewed by Tim Horton.

Tools:

Expose functionality in UIScriptController to allow for testing single- and double-tap,
and to listen for completion of scrolling and zooming in the WKWebView.

Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
which hides the complexity of creating these events. Event dispatch is asynchronous.
We detect when the last event has been handled by dispatching a vendor-specific event,
which is detected via -_handleHIDEvent: in our UIApplication subclass.

  • WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
  • WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties

for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
single and double taps.

  • WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:

(UIScriptContext::registerCallback): Used to store the callbacks for zooming.
Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
(UIScriptContext::unregisterCallback):
(UIScriptContext::callbackWithID):
(UIScriptContext::fireCallback):

  • WebKitTestRunner/UIScriptContext/UIScriptContext.h:
  • WebKitTestRunner/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
(WTR::UIScriptController::willBeginZoomingCallback): Ditto.
(WTR::UIScriptController::setDidEndZoomingCallback):
(WTR::UIScriptController::didEndZoomingCallback):
(WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
(WTR::UIScriptController::doubleTapAtPoint): Ditto.
(WTR::UIScriptController::platformSetWillBeginZoomingCallback):
(WTR::UIScriptController::platformSetDidEndZoomingCallback):

  • WebKitTestRunner/UIScriptContext/UIScriptController.h:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
(-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
(-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
(-[TestRunnerWKWebView onDidEndZooming:]): Deleted.

  • WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
  • WebKitTestRunner/ios/HIDEventGenerator.m: Added.

(simpleDragCurve):
(calculateNextLocation):
(delayBetweenMove):
(+[HIDEventGenerator sharedHIDEventGenerator]):
(+[HIDEventGenerator nextEventCallbackID]):
(-[HIDEventGenerator init]):
(-[HIDEventGenerator _createIOHIDEventType:]):
(-[HIDEventGenerator _sendHIDEvent:]):
(-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
(-[HIDEventGenerator _updateTouchPoints:count:]):
(-[HIDEventGenerator touchDownAtPoints:touchCount:]):
(-[HIDEventGenerator touchDown:touchCount:]):
(-[HIDEventGenerator touchDown:]):
(-[HIDEventGenerator liftUpAtPoints:touchCount:]):
(-[HIDEventGenerator liftUp:touchCount:]):
(-[HIDEventGenerator liftUp:]):
(-[HIDEventGenerator moveToPoints:touchCount:duration:]):
(-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
(-[HIDEventGenerator tap:completionBlock:]):
(-[HIDEventGenerator doubleTap:completionBlock:]):
(-[HIDEventGenerator twoFingerTap:completionBlock:]):
(-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
(-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
(-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
(-[HIDEventGenerator markerEventReceived:]):

  • WebKitTestRunner/ios/IOKitSPI.h: Added.
  • WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::globalToContentCoordinates):
(WTR::UIScriptController::singleTapAtPoint):
(WTR::UIScriptController::doubleTapAtPoint):
(WTR::UIScriptController::platformSetWillBeginZoomingCallback):
(WTR::UIScriptController::platformSetDidEndZoomingCallback):

  • WebKitTestRunner/ios/mainIOS.mm:

(-[WebKitTestRunnerApp _handleHIDEvent:]):

LayoutTests:

Simple tests for single tap triggering a click, and double-tap zoom.

  • TestExpectations:
  • fast/events/ios/double-tap-zoom-expected.txt: Added.
  • fast/events/ios/double-tap-zoom.html: Added.
  • fast/events/ios/single-tap-generates-click-expected.txt: Added.
  • fast/events/ios/single-tap-generates-click.html: Added.
  • platform/ios-simulator-wk2/TestExpectations:
2:00 PM Changeset in webkit [190367] by keith_miller@apple.com
  • 19 edits
    1 copy
    21 adds in trunk

[ES6] Add TypedArray.prototype functionality.
https://bugs.webkit.org/show_bug.cgi?id=148035

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This patch should add most of the functionality for
the prototype properties of TypedArray objects in ES6.
There are a few exceptions to this, which will be added
in upcoming patches:

1) First we do not use the species constructor for some
of the TypedArray prototype functions (namely: map, filter,
slice, and subarray). That will need to be added when
species constructors are finished.

2) TypedArrays still have a length, byteOffset, byteLength,
and buffer are still attached to the TypedArray instance (in
the spec they are on the TypedArray.prototype instance object)
since the JIT currently assumes those properties are fixed.

3) The TypedArray.constructor property is not added yet
as it should point to the TypedArray instance object,
which will be added in a future patch.

(every):
(find):
(findIndex):
(forEach):
(some):
(sort.min):
(sort.merge):
(sort.mergeSort):
(sort):
(reduce):
(reduceRight):
(map):
(filter):
(toLocaleString):

  • runtime/ArrayPrototype.cpp:
  • runtime/ArrayPrototype.h:
  • runtime/CommonIdentifiers.h:
  • runtime/JSGenericTypedArrayView.h:

(JSC::JSGenericTypedArrayView::toAdaptorNativeFromValue):
(JSC::JSGenericTypedArrayView::setRangeToValue):
(JSC::JSGenericTypedArrayView::sort):
(JSC::JSGenericTypedArrayView::purifyArray):
(JSC::JSGenericTypedArrayView::sortComparison):
(JSC::JSGenericTypedArrayView::sortFloat):

  • runtime/JSGenericTypedArrayViewInlines.h:
  • runtime/JSGenericTypedArrayViewPrototypeFunctions.h: Added.

(JSC::argumentClampedIndexFromStartOrEnd):
(JSC::genericTypedArrayViewProtoFuncSet):
(JSC::genericTypedArrayViewProtoFuncEntries):
(JSC::genericTypedArrayViewProtoFuncCopyWithin):
(JSC::genericTypedArrayViewProtoFuncFill):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncJoin):
(JSC::genericTypedArrayViewProtoFuncKeys):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):
(JSC::genericTypedArrayViewProtoGetterFuncLength):
(JSC::genericTypedArrayViewProtoGetterFuncByteLength):
(JSC::genericTypedArrayViewProtoGetterFuncByteOffset):
(JSC::genericTypedArrayViewProtoFuncReverse):
(JSC::genericTypedArrayViewPrivateFuncSort):
(JSC::genericTypedArrayViewProtoFuncSlice):
(JSC::genericTypedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncValues):

  • runtime/JSGenericTypedArrayViewPrototypeInlines.h:

(JSC::JSGenericTypedArrayViewPrototype<ViewClass>::finishCreation):
(JSC::genericTypedArrayViewProtoFuncSet): Deleted.
(JSC::genericTypedArrayViewProtoFuncSubarray): Deleted.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSObject.h:
  • runtime/JSTypedArrayPrototypes.cpp:
  • runtime/JSTypedArrayPrototypes.h:
  • runtime/JSTypedArrayViewPrototype.cpp: Added.

(JSC::typedArrayViewPrivateFuncLength):
(JSC::typedArrayViewPrivateFuncSort):
(JSC::typedArrayViewProtoFuncSet):
(JSC::typedArrayViewProtoFuncEntries):
(JSC::typedArrayViewProtoFuncCopyWithin):
(JSC::typedArrayViewProtoFuncFill):
(JSC::typedArrayViewProtoFuncLastIndexOf):
(JSC::typedArrayViewProtoFuncIndexOf):
(JSC::typedArrayViewProtoFuncJoin):
(JSC::typedArrayViewProtoFuncKeys):
(JSC::typedArrayViewProtoGetterFuncLength):
(JSC::typedArrayViewProtoGetterFuncByteLength):
(JSC::typedArrayViewProtoGetterFuncByteOffset):
(JSC::typedArrayViewProtoFuncReverse):
(JSC::typedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncSlice):
(JSC::typedArrayViewProtoFuncValues):
(JSC::JSTypedArrayViewPrototype::JSTypedArrayViewPrototype):
(JSC::JSTypedArrayViewPrototype::finishCreation):
(JSC::JSTypedArrayViewPrototype::create):
(JSC::JSTypedArrayViewPrototype::createStructure):

  • runtime/JSTypedArrayViewPrototype.h: Copied from Source/JavaScriptCore/runtime/JSTypedArrayPrototypes.cpp.
  • tests/stress/resources/standalone-pre.js: Added.

(description):
(debug):
(escapeString):
(testPassed):
(testFailed):
(areNumbersEqual):
(areArraysEqual):
(isMinusZero):
(isTypedArray):
(isResultCorrect):
(stringify):
(shouldBe):
(dfgShouldBe):
(shouldBeType):
(shouldBeTrue):
(shouldBeFalse):
(shouldBeNaN):
(shouldBeNull):
(shouldBeEqualToString):
(shouldBeUndefined):
(shouldNotThrow):
(shouldThrow):
(dfgCompiled):
(dfgIncrement):
(noInline):
(finishJSTest):

  • tests/stress/resources/typedarray-test-helper-functions.js: Added.

(forEachTypedArray):
(isSameFunctionForEachTypedArrayPrototype.eq):
(isSameFunctionForEachTypedArrayPrototype):
(hasSameValues):
(.foo):
(testPrototypeFunctionHelper):
(testPrototypeFunctionOnSigned):
(testPrototypeFunctionOnFloat):
(testPrototypeFunction):
(.tester):
(testPrototypeReceivesArray):

  • tests/stress/typedarray-copyWithin.js: Added.
  • tests/stress/typedarray-every.js: Added.

(isBigEnough):
(isBigEnoughAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-fill.js: Added.
  • tests/stress/typedarray-filter.js: Added.

(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-find.js: Added.

(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-findIndex.js: Added.

(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-forEach.js: Added.

(.checkCorrect.let.list):
(.checkCorrect):
(createChecker):
(foo):
(changeArray):
(isBigEnoughAndException):

  • tests/stress/typedarray-indexOf.js: Added.

(keepEven):

  • tests/stress/typedarray-lastIndexOf.js: Added.
  • tests/stress/typedarray-map.js: Added.

(even):
(evenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-reduce.js: Added.

(createArray):
(sum):
(createArrayAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-reduceRight.js: Added.

(createArray):
(sum):
(createArrayAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-slice.js: Added.
  • tests/stress/typedarray-some.js: Added.

(isBigEnough):
(isBigEnoughAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-sort.js: Added.

(sortBackwards):
(compareException):

LayoutTests:

Fixed tests for new toString behavior on TypedArrays.

  • fast/canvas/webgl/type-conversion-test-expected.txt:
  • fast/dom/Window/window-postmessage-clone-expected.txt:
1:05 PM Changeset in webkit [190366] by dburkart@apple.com
  • 2 edits in trunk/Tools

git-add-reviewer should trim trailing spaces/newlines
https://bugs.webkit.org/show_bug.cgi?id=149513

Reviewed by Darin Adler.

  • Scripts/git-add-reviewer:

(nonInteractive):

1:00 PM Changeset in webkit [190365] by timothy_horton@apple.com
  • 3 edits in trunk/LayoutTests

Compute document marker rects at use time instead of paint time
https://bugs.webkit.org/show_bug.cgi?id=149643

  • fast/text/mark-matches-overflow-clip-expected.txt:
  • fast/text/mark-matches-overflow-clip.html:

Adjust one recently-added test and its result slightly.

12:44 PM Changeset in webkit [190364] by Chris Dumez
  • 15 edits in trunk/Source

Unreviewed, roll out r188331: "NetworkProcess: DNS prefetch happens in the Web Process"
<rdar://problem/22560715>

Speculative roll out of r188331 as we had a ~2.5% PLT regression around
the time it landed and it seems the most likely culprit. I'll reland if
the perf bots do not recover after the roll out.

Source/WebCore:

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute):

  • loader/FrameLoaderClient.h:
  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::loadLink):

  • page/Chrome.cpp:

(WebCore::Chrome::mouseDidMoveOverElement):

Source/WebKit2:

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::storageSession): Deleted.

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:

(webkitWebExtensionDidReceiveMessage):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):

  • WebProcess/WebProcess.cpp:
  • WebProcess/WebProcess.h:
12:36 PM Changeset in webkit [190363] by timothy_horton@apple.com
  • 27 edits in trunk/Source

Compute document marker rects at use time instead of paint time
https://bugs.webkit.org/show_bug.cgi?id=149643

Reviewed by Darin Adler.

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::DocumentMarkerController):
(WebCore::DocumentMarkerController::detach):
Store and zero the Document backpointer.

(WebCore::DocumentMarkerController::addMarker):
(WebCore::DocumentMarkerController::addTextMatchMarker):
(WebCore::DocumentMarkerController::addDictationPhraseWithAlternativesMarker):
(WebCore::DocumentMarkerController::addDictationResultMarker):
(WebCore::DocumentMarkerController::copyMarkers):
Remove some useless comments.

(WebCore::updateRenderedRectsForMarker):
Use Range to compute the (unclipped, absolute) text rects, and store them
on the RenderedDocumentMarker.

(WebCore::DocumentMarkerController::invalidateRectsForAllMarkers):
(WebCore::DocumentMarkerController::invalidateRectsForMarkersInNode):
Mark the relevant markers' rects as invalid, and notify the ChromeClient.

(WebCore::DocumentMarkerController::updateRectsForInvalidatedMarkersOfType):
Run through all markers, computing rects for ones that don't have valid rects.
We will do layout (once) if necessary. However, this is most commonly
called from a place where layout should already be up to date, so this
should not happen often. updateRenderedRectsForMarker also asserts
that layout is up to date.

(WebCore::DocumentMarkerController::renderedRectsForMarkers):
Retrieve all markers of the given type, clip them by overflow clip and
frame clip, and return them to the caller.

(WebCore::DocumentMarkerController::addMarker):
(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::markersFor):
(WebCore::DocumentMarkerController::repaintMarkers):
(WebCore::DocumentMarkerController::shiftMarkers):
(DocumentMarkerController::setMarkersActive):
(DocumentMarkerController::hasMarkers):
Modern iteration.

(WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect): Deleted.

  • dom/DocumentMarkerController.h:
  • dom/Document.cpp:

(WebCore::Document::Document):
Pass the Document to the DocumentMarkerController.

  • dom/RenderedDocumentMarker.h:

(WebCore::RenderedDocumentMarker::contains):
(WebCore::RenderedDocumentMarker::setUnclippedAbsoluteRects):
(WebCore::RenderedDocumentMarker::unclippedAbsoluteRects):
(WebCore::RenderedDocumentMarker::invalidate):
(WebCore::RenderedDocumentMarker::isValid):
(WebCore::RenderedDocumentMarker::addRenderedRect): Deleted.
(WebCore::RenderedDocumentMarker::renderedRects): Deleted.
Instead of keeping "rendered" rects, keep unclipped rects in absolute
document coordinates. Invalidation will happen wholesale instead of
based on dirty rects, because computation no longer happens at paint
time, so it's safe to throw all of the rects away.
Keep track of whether we have valid rects or not.

  • editing/Editor.cpp:

(WebCore::Editor::countMatchesForText):
We don't need to do a fake whole-document paint just to compute the
document marker rects. They are computed on demand, using layout information
instead of paint-time information.

  • page/ChromeClient.h:

Remove an unnecessary semicolon.
Add didInvalidateDocumentMarkerRects, which DocumentMarkerController
will call whenever document marker rects are invalidated (and when e.g.
the find holes PageOverlay should repaint itself).

  • page/FrameView.cpp:

(WebCore::FrameView::layout):
Invalidate document marker's layout-computed rects after layout is complete.
They'll be lazily recomputed when next requested.

(WebCore::FrameView::willPaintContents):
Remove the pre-painting invalidation of document marker rects.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::paintDocumentMarker): Deleted.
(WebCore::InlineTextBox::computeRectForReplacementMarker): Deleted.
(WebCore::InlineTextBox::paintDocumentMarkers): Deleted.
Don't bother computing rendered rects for document markers at paint time.
Just do the actual painting work (which, for replacement markers, is
nothing at all).

  • rendering/InlineTextBox.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
When RenderLayers move, invalidate document marker rects.

  • rendering/svg/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::paint):
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer): Deleted.

  • rendering/svg/SVGInlineFlowBox.h:
  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::paint):
Don't bother computing rendered rects for document markers at paint time.

  • testing/Internals.cpp:

(WebCore::markerTypeFrom):
(WebCore::markerTypesFrom):
Add markerTypeFrom, which returns MarkerType enum values for the input string
instead of a MarkerTypes class.

(WebCore::Internals::dumpMarkerRects):
Dump all markers for the given type, and request them from DocumentMarkerController
instead of from the RenderedDocumentMarker, because we want fully clipped
rects, which can only be obtained from DocumentMarkerController.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::getTextRectangles):
Avoid enclosing unnecessarily, to avoid inflating zero-width text rects
to have a non-zero width. Callers appear to be OK with non-integral positions.

  • testing/Internals.h:
  • testing/Internals.idl:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::didInvalidateDocumentMarkerRects):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

Plumb the notification about invalidated document marker rects through to FindController.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindUIAfterPageScroll):
Make a document-relative PageOverlay, so that we get fast scrolling.

(WebKit::FindController::rectsForTextMatchesInRect):
Return find hole rects in main-FrameView content coordinates, to
match the document-relative page overlay.
We'll only return rects that intersect the passed-in rect, which
comes from the dirty rect passed to drawRect.

(WebKit::FindController::drawRect):
Inflate the dirty rect by the border width so that we hit all relevant
markers in each tile. Otherwise, we would end up missing the border of a marker
that touched the edge of a tile.

(WebKit::FindController::didInvalidateDocumentMarkerRects):
Repaint (for now, the entire overlay) when document marker rects change.

  • WebProcess/WebPage/FindController.h:
  • WebView/WebHTMLView.mm:

(-[WebHTMLView rectsForTextMatches]):

  • WebView.cpp:

(WebView::rectsForTextMatches):

12:16 PM Changeset in webkit [190362] by eric.carlson@apple.com
  • 15 edits in trunk

REGRESSION(r190262): User media unit test failures after r190262
https://bugs.webkit.org/show_bug.cgi?id=149580

Reviewed by Darin Adler.

Source/WebCore:

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::getStats): Drive-by fix to deal with optional param.

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::constraintsValidated): Swap the track parameter order.

  • Modules/mediastream/UserMediaRequest.h:
  • platform/mediastream/MediaStreamCreationClient.h:

(WebCore::MediaStreamCreationClient::validateRequestConstraints): Swap the track parameter order.

  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::validateRequestConstraints): If there is no

constraint for a media type, don't return a device of that type.

  • platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:

(WebCore::RealtimeMediaSourceCenterOwr::mediaSourcesAvailable): Ditto.

  • platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::validateRequestConstraints): Ditto.

  • platform/mock/TimerEventBasedMock.h:

(WebCore::TimerEvent::~TimerEvent): Clear the m_mock pointer.

  • platform/mock/UserMediaClientMock.h:

(WebCore::UserMediaClientMock::fire): Deal with empty device vectors.

  • testing/Internals.cpp:

(WebCore::Internals::Internals): Don't register UserMediaController, it isn't needed for

WKTR.

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter

order to WKUserMediaPermissionRequestAllow.

LayoutTests:

  • platform/gtk/TestExpectations: Unskip tests.
12:10 PM Changeset in webkit [190361] by Brent Fulgham
  • 2 edits in trunk

[Win] Unreviewed build fix after CMake conversion.

  • Source/cmake/OptionsWin.cmake: Correct some Windows build flags.
11:57 AM Changeset in webkit [190360] by Lucas Forschler
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js

Add El Capitan to the dashboard.

11:19 AM Changeset in webkit [190359] by dbates@webkit.org
  • 3 edits in trunk/Tools

Add iOS builders and testers
https://bugs.webkit.org/show_bug.cgi?id=149549

Reviewed by Alexey Proskuryakov.

Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
builder that builds universal release binaries for armv7, armv7s and arm64 architectures.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
10:56 AM Changeset in webkit [190358] by timothy@apple.com
  • 2 edits
    1 add in trunk/Tools

Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
https://bugs.webkit.org/show_bug.cgi?id=149674

Reviewed by Lucas Forschler.

  • WebKitLauncher/WebKitLauncher.entitlements: Added.
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
10:53 AM Changeset in webkit [190357] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

10:51 AM Changeset in webkit [190356] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.5

New tag.

10:49 AM Changeset in webkit [190355] by jmarcell@apple.com
  • 2 edits in trunk/Tools

BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
have an associated trac instance.
https://bugs.webkit.org/show_bug.cgi?id=149673

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:

(BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
have an associated trac instance.

10:43 AM Changeset in webkit [190354] by dbates@webkit.org
  • 2 edits in trunk/Tools

Prioritize testing latest build request on iOS test bots
https://bugs.webkit.org/show_bug.cgi?id=149669

Reviewed by Darin Adler.

We should prioritize testing of the latest build request on the iOS test bots
as we do for Mac and Windows test bots.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

10:28 AM Changeset in webkit [190353] by dbates@webkit.org
  • 3 edits in trunk/Tools

Add buildbot category for iOS builders and testers
https://bugs.webkit.org/show_bug.cgi?id=149667

Reviewed by Darin Adler.

Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
for iOS to the build.webkit.org home page.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
10:23 AM Changeset in webkit [190352] by dbates@webkit.org
  • 2 edits in trunk/Tools

Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
(https://bugs.webkit.org/show_bug.cgi?id=149539)

I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
in <http://trac.webkit.org/changeset/190351>.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CompileWebKit.start):

10:19 AM Changeset in webkit [190351] by dbates@webkit.org
  • 2 edits in trunk/Tools

Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
(https://bugs.webkit.org/show_bug.cgi?id=149539)

{32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CompileWebKit.start):

10:17 AM Changeset in webkit [190350] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r190324.
https://bugs.webkit.org/show_bug.cgi?id=149671

Caused flaky crashes, rdar://problem/22916304 (Requested by ap
on #webkit).

Reverted changeset:

"ParallelHelperPool::runFunctionInParallel() shouldn't
allocate, and ParallelHelperPool.h shouldn't be included
everywhere"
https://bugs.webkit.org/show_bug.cgi?id=149635
http://trac.webkit.org/changeset/190324

9:56 AM Changeset in webkit [190349] by Lucas Forschler
  • 2 edits in trunk/Tools

bot210 was configured for a queue instead of bot126.

Unreviewed config.json fix.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
9:35 AM Changeset in webkit [190348] by Lucas Forschler
  • 3 edits in trunk/Tools

Bring El Capitan buildbot infrastructure online.
https://bugs.webkit.org/show_bug.cgi?id=149605

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
8:39 AM Changeset in webkit [190347] by Antti Koivisto
  • 18 edits in trunk/Source/WebCore

Use separate style resolver for user agent shadow trees
https://bugs.webkit.org/show_bug.cgi?id=149626

Reviewed by Andreas Kling.

We now support separate style resolvers for shadow trees. Use this mechanism to have a separate
per-document style resolver for user agent shadow trees. This isolates user agent shadow trees
from author style better and simplifies the style resolver. It can also avoid some unnecessary style recalcs.

  • css/DocumentRuleSets.cpp:

(WebCore::DocumentRuleSets::resetAuthorStyle):
(WebCore::DocumentRuleSets::appendAuthorStyleSheets):

Change interface so that only the new rules are provided.

  • css/DocumentRuleSets.h:
  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::addElementStyleProperties):
(WebCore::ElementRuleCollector::collectMatchingRules):

We can remove special bailout as shadow tree style resolver won't have other author style

(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):

Remove the exception that disables property whitelists for UA stylesheets. We don't seem to use the feature.

(WebCore::ElementRuleCollector::matchUARules):
(WebCore::MatchingUARulesScope::MatchingUARulesScope): Deleted.
(WebCore::MatchingUARulesScope::~MatchingUARulesScope): Deleted.
(WebCore::MatchingUARulesScope::isMatchingUARules): Deleted.

Remove this unnecessary hack.

  • css/ElementRuleCollector.h:

(WebCore::ElementRuleCollector::ElementRuleCollector):

  • css/RuleSet.cpp:

(WebCore::RuleSet::addStyleRule):
(WebCore::RuleSet::copyShadowPseudoElementRulesFrom):

Also copy WebVTT rules. They are currently a sort of mixture of UA and author shadow tree.

(WebCore::shrinkMapVectorsToFit):

  • css/RuleSet.h:

(WebCore::RuleData::containsUncommonAttributeSelector):
(WebCore::RuleData::linkMatchType):
(WebCore::RuleData::hasDocumentSecurityOrigin):
(WebCore::RuleData::propertyWhitelistType):
(WebCore::RuleData::descendantSelectorIdentifierHashes):
(WebCore::RuleSet::ruleCount):
(WebCore::RuleSet::hasShadowPseudoElementRules):

  • css/StyleInvalidationAnalysis.cpp:

(WebCore::StyleInvalidationAnalysis::StyleInvalidationAnalysis):
(WebCore::StyleInvalidationAnalysis::invalidateIfNeeded):

Don't invalidate the whole tree when author shadow pseudo element rules change. Just invalidate the shadow trees.

(WebCore::StyleInvalidationAnalysis::invalidateStyleForTree):
(WebCore::StyleInvalidationAnalysis::invalidateStyle):
(WebCore::invalidateIfNeeded): Deleted.
(WebCore::invalidateStyleForTree): Deleted.

  • css/StyleInvalidationAnalysis.h:

(WebCore::StyleInvalidationAnalysis::dirtiesAllStyle):
(WebCore::StyleInvalidationAnalysis::hasShadowPseudoElementRulesInAuthorSheet):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchResult::addMatchedProperties):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::appendAuthorStyleSheets):

Simpler interface.

  • css/StyleResolver.h:

(WebCore::StyleResolver::document):
(WebCore::StyleResolver::documentSettings):
(WebCore::StyleResolver::ruleSets):

  • dom/AuthorStyleSheets.cpp:

(WebCore::AuthorStyleSheets::collectActiveStyleSheets):
(WebCore::AuthorStyleSheets::analyzeStyleSheetChange):

Cleanups.

(WebCore::filterEnabledNonemptyCSSStyleSheets):
(WebCore::AuthorStyleSheets::updateActiveStyleSheets):
(WebCore::AuthorStyleSheets::updateStyleResolver):

Factor to a function.
Copy any author shadow pseudo elements to user agent shadow tree resolver.

(WebCore::AuthorStyleSheets::activeStyleSheetsForInspector):

  • dom/AuthorStyleSheets.h:
  • dom/Document.cpp:

(WebCore::Document::createStyleResolver):
(WebCore::Document::userAgentShadowTreeStyleResolver):

Use separate resolver.

(WebCore::Document::fontsNeedUpdate):
(WebCore::Document::clearStyleResolver):

  • dom/Document.h:

(WebCore::Document::ensureStyleResolver):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::styleResolver):

Return document-global shadow tree resolver for ua trees.

  • style/StyleResolveTree.cpp:

(WebCore::Style::resolveShadowTree):

Take styleChange of shadow root into account.

7:07 AM Changeset in webkit [190346] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GTK] Deprecation warnings in DOMNodeTest
https://bugs.webkit.org/show_bug.cgi?id=149663

After the webkit_dom_document_get_elements_by_tag_name deprecation we
need to update the tests to use webkit_dom_document_query_selector_all
to avoid compilation warnings.

Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
(the suggested replacement for the deprecated function).

Patch by Tomas Popela <tpopela@redhat.com> on 2015-09-30
Reviewed by Carlos Garcia Campos.

  • TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:

(WebKitDOMNodeTest::testTagNamesNodeList):
(WebKitDOMNodeTest::testTagNamesHTMLCollection):
(registerTests):
(WebKitDOMNodeTest::testTagNames): Deleted.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:

(prepareDOMForTagNamesTests):
(testWebKitDOMNodeTagNamesNodeList):
(testWebKitDOMNodeTagNamesHTMLCollection):
(beforeAll):
(testWebKitDOMNodeTagNames): Deleted.

5:58 AM WebKitGTK/2.10.x edited by clopez@igalia.com
(diff)
5:55 AM Changeset in webkit [190345] by clopez@igalia.com
  • 2 edits in trunk/Source/WebKit2

[GTK] Build error with -DENABLE_SPELLCHECK=OFF
https://bugs.webkit.org/show_bug.cgi?id=146904

Reviewed by Carlos Garcia Campos.

Add ifdef guards to allow building when SPELLCHECK is not enabled.

  • UIProcess/gtk/TextCheckerGtk.cpp:

(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::getGuessesForWord):
(WebKit::TextChecker::learnWord):
(WebKit::TextChecker::ignoreWord):
(WebKit::TextChecker::requestCheckingOfString):
(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::setSpellCheckingLanguages):
(WebKit::TextChecker::loadedSpellCheckingLanguages):

2:55 AM Changeset in webkit [190344] by yoon@igalia.com
  • 14 edits in trunk/Source

[GTK] Support HiDPI Properly in WebKitGtk+ with the TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=141782

Reviewed by Carlos Garcia Campos.

Source/WebCore:

This patch fixes HiDPI issue in the TextureMapper.
To support HiDPI in the TextureMapper, we need to draw scaled contents
in the TextureMapperTile, and apply the global scale in the root layer
to apply transforms correctly.

Supporting the device scale is handled at LayerTreeHostGtk and
TextureMapperBackingStore, and GraphicsLayerTextureMapper doesn't handle
the device scale directly.

From the TextureMapperLayer, deviceScale and pageScale do not have to be
handled differently. These are multiplied and provided to
TextureMapperBackingStore.

  • platform/graphics/texmap/TextureMapperTile.cpp:

(WebCore::TextureMapperTile::updateContents):

  • platform/graphics/texmap/TextureMapperTile.h:
  • platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:

Modified to increase the cover rect for tiles creation. For the image
contents, it just creates texture with a image size, regardless of the
contents scale.

  • platform/graphics/texmap/BitmapTexture.cpp:

(WebCore::BitmapTexture::updateContents):

Apply the device scale to the graphics context before painting contents.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):

Apply the device scale and the page scale to the backing store

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:
  • UIProcess/gtk/RedirectedXCompositeWindow.cpp:

Modified to create scaled size of window.

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::initialize):
(WebKit::LayerTreeHostGtk::deviceOrPageScaleFactorChanged):

We should apply device scale factor to the root layer to apply
the scale matrix before applying other transform matrices.

(WebKit::LayerTreeHostGtk::deviceScaleFactor): Added.
(WebKit::LayerTreeHostGtk::pageScaleFactor): Added.

Note: See TracTimeline for information about the timeline view.