Timeline
Oct 8, 2015:
- 11:01 PM Changeset in webkit [190780] by
-
- 5 edits in trunk
Web Inspector: Stack trace view doesn't properly display lines without function names
https://bugs.webkit.org/show_bug.cgi?id=149922
Source/WebInspectorUI:
Reviewed by Timothy Hatcher.
- UserInterface/Models/StackTrace.js:
(WebInspector.StackTrace._parseStackTrace):
(WebInspector.StackTrace._parseLocation): Added.
LayoutTests:
Test an anomymous function.
Reviewed by Timothy Hatcher.
- inspector/debugger/js-stacktrace-expected.txt: Also, rebaseline one old test.
- inspector/debugger/js-stacktrace.html:
- 10:53 PM Changeset in webkit [190779] by
-
- 4 edits in trunk/Tools
Extend run-benchmark script to support human-readable results conversion.
https://bugs.webkit.org/show_bug.cgi?id=149944
Reviewed by Ryosuke Niwa.
Add '--read-results-json' and '--no-adjust-unit' options.
'--read-results-json' option converts result file to human readable format.
'--no-adjust-unit' option skips scientific notation convertion.
'--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
- Scripts/webkitpy/benchmark_runner/benchmark_results.py:
(BenchmarkResults.format):
(BenchmarkResults._format_tests):
(BenchmarkResults._format_values):
- Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner.init):
(BenchmarkRunner._run_benchmark):
(BenchmarkRunner._dump):
(BenchmarkRunner.show_results):
(BenchmarkRunner._show_results): Deleted.
- Scripts/webkitpy/benchmark_runner/run_benchmark.py:
(parse_args):
(start):
- 10:46 PM Changeset in webkit [190778] by
-
- 31 edits3 copies2 moves11 adds in branches/safari-601.1.46-branch
Merge r188486, r188517, r188531, r188844, r188845, r188851, r188852, r188880, r188881, r188988, r189193, r189289, and r190133.
rdar://problem/22846460
Source/WebCore:
2015-08-26 Andy Estes <aestes@apple.com>
[Content Filtering] Determine navigation and content policy before continuing to filter a load
https://bugs.webkit.org/show_bug.cgi?id=148506
Reviewed by Brady Eidson.
Prior to this change, ContentFilter would hide from DocumentLoader all CachedRawResourceClient callbacks until
a decision was made, then replay the missed callbacks. This approach interacted poorly with some features of
the loader, notably appcache and downloads. In the case of appcache, DocumentLoader might not have a chance to
check for substitute data until the original load has finished, wasting bandwidth, and might receive duplicate
or out-of-order callbacks. In the case of downloads, it would often be too late to convert the existing
connection to a download, leading to restarted downloads or outright failures.
Bandaids were put in place for these issues in r188150, r188486, and r188851 to fix crashes or serious
regressions in behavior, but these weren't complete fixes. They did not solve any of the duplicate data loading
problems, and they did not make downloads work reliably in all cases.
This patch rolls out the bandaids (but keeps their tests) and replaces them with a more robust fix. Instead of
hiding callbacks from DocumentLoader, ContentFilter now delivers willSendRequest(), redirectReceived(), and
responseReceived() to DocumentLoader immediately, and cancels filtering if DocumentLoader decides to ignore the
load, download it, or load substitute data. ContentFilter continues to buffer incoming data to prevent partial
rendering of blocked content.
The existing tests for r188150 and r188851 were kept, the test for r188486 was rewritten to be specific to
content filtering, and new tests were added to cover the case where ContentFilter is still undecided after a
load finishes.
Tests: contentfiltering/allow-never.html
contentfiltering/block-never.html
ContentFiltering.AllowDownloadAfterAddData
ContentFiltering.AllowDownloadAfterFinishedAddingData
ContentFiltering.AllowDownloadAfterRedirect
ContentFiltering.AllowDownloadAfterResponse
ContentFiltering.AllowDownloadAfterWillSendRequest
ContentFiltering.AllowDownloadNever
ContentFiltering.BlockDownloadAfterAddData
ContentFiltering.BlockDownloadAfterFinishedAddingData
ContentFiltering.BlockDownloadAfterRedirect
ContentFiltering.BlockDownloadAfterResponse
ContentFiltering.BlockDownloadAfterWillSendRequest
ContentFiltering.BlockDownloadNever
- bindings/js/JSMockContentFilterSettingsCustom.cpp: (WebCore::JSMockContentFilterSettings::decisionPoint): Taught to handle DecisionPoint::Never, and rewrote to not need a set of const uint8_ts that mirror the DecisionPoint enum. (WebCore::JSMockContentFilterSettings::setDecisionPoint): Ditto. (WebCore::toJSValue): Rewrote to not need a set of const uint8_ts that mirror the Decision enum. (WebCore::toDecision): Ditto.
- loader/ContentFilter.cpp: (WebCore::ContentFilter::createIfEnabled): Renamed from createIfNeeded, and changed to take a DocumentLoader& instead of a DecisionFunction. (WebCore::ContentFilter::ContentFilter): (WebCore::ContentFilter::responseReceived): If m_state != Blocked after filtering, call DocumentLoader::responseReceived(). (WebCore::ContentFilter::dataReceived): If m_state == Allowed after filtering, deliver buffered data to DocumentLoader. If no filtering was necessary, call DocumentLoader::dataReceived() directly. (WebCore::ContentFilter::redirectReceived): If m_state != Blocked after filtering, call DocumentLoader::redirectReceived(). (WebCore::ContentFilter::notifyFinished): If an error occured, call DocumentLoader::notifyFinished() immediately and return. If m_state != Blocked after filtering, deliver buffered data to DocumentLoader and call DocumentLoader::notifyFinished(). If no filtering was necessary and m_state != Blocked, call DocumentLoader::notifyFinished() directly. (WebCore::ContentFilter::didDecide): Called DocumentLoader::contentFilterDidDecide() instead of m_decisionFunction(). (WebCore::ContentFilter::deliverResourceData): Added a helper function to deliver buffered data to DocumentLoader. (WebCore::ContentFilter::createIfNeeded): Renamed to createIfEnabled().
- loader/ContentFilter.h:
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::willSendRequest): Stopped asserting that redirectResponse is null and made it part of the if condition instead, since willSendRequest() will now be called on redirects when there is an active ContentFilter. (WebCore::DocumentLoader::startLoadingMainResource): Called becomeMainResourceClient() instead of becomeMainResourceClientIfFilterAllows(). (WebCore::DocumentLoader::becomeMainResourceClient): Renamed from becomeMainResourceClientIfFilterAllows(). Only called ContentFilter::startFilteringMainResource() if the filter state is Initialized, since ContentFilter might have already made a decision in willSendRequest(). (WebCore::DocumentLoader::contentFilterDidDecide): Stopped deleting m_contentFilter, since it will continue to deliver callbacks even after making a decision. Fixed a bug where we were creating two copies of ContentFilter's replacement data. (WebCore::DocumentLoader::syntheticRedirectReceived): Deleted. (WebCore::DocumentLoader::becomeMainResourceClientIfFilterAllows): Renamed to becomeMainResourceClient().
- loader/DocumentLoader.h:
- loader/EmptyClients.h:
- loader/FrameLoaderClient.h:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequestInternal): Removed part of r188851.
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): Removed part of r188486.
- loader/SubresourceLoader.h:
- loader/cache/CachedRawResource.cpp: (WebCore::CachedRawResource::didAddClient): Removed part of r188150.
- loader/cache/CachedRawResourceClient.h: (WebCore::CachedRawResourceClient::syntheticRedirectReceived): Removed part of r188150.
- testing/MockContentFilterSettings.h: Defined DecisionPoint::Never.
- testing/MockContentFilterSettings.idl: Defined DECISION_POINT_NEVER.
Source/WebKit2:
2015-08-11 Andy Estes <aestes@apple.com>
[Cocoa] Add redirect support to CustomProtocolManager
https://bugs.webkit.org/show_bug.cgi?id=147871
Reviewed by Dan Bernstein.
NSURLProtocols have the ability to generate redirect responses. This change teaches CustomProtocolManager how to handle them.
- Shared/Network/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm: (WebKit::CustomProtocolManager::wasRedirectedToRequest): Called -URLProtocol:wasRedirectedToRequest:redirectResponse: on the NSURLProtocolClient.
- Shared/Network/CustomProtocols/CustomProtocolManager.h:
- Shared/Network/CustomProtocols/CustomProtocolManager.messages.in: Defined WasRedirectedToRequest.
- Shared/Network/CustomProtocols/soup/CustomProtocolManagerSoup.cpp: (WebKit::CustomProtocolManager::wasRedirectedToRequest): Defined empty function.
- UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm: (-[WKCustomProtocolLoader connection:willSendRequest:redirectResponse:]): If a redirect response is received, send WasRedirectedToRequest and return nil to ignore the redirect.
Tools:
2015-09-22 Andy Estes <aestes@apple.com>
ContentFiltering.AllowDownloadAfterAddData is very flaky
https://bugs.webkit.org/show_bug.cgi?id=148885
<rdar://problem/22729563>
Reviewed by Alexey Proskuryakov.
The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
but there is no guarantee of this. For tests that should allow a download, spin the runloop until
-_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: (downloadTest):
2015-08-26 Andy Estes <aestes@apple.com>
[Content Filtering] Determine navigation and content policy before continuing to filter a load
https://bugs.webkit.org/show_bug.cgi?id=148506
Reviewed by Brady Eidson.
Added download API tests covering every decision and decision point.
Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
- TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
- TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
- TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter decision and decision point as a bundle parameter. (+[MockContentFilterEnabler supportsSecureCoding]): (-[MockContentFilterEnabler copyWithZone:]): (-[MockContentFilterEnabler initWithCoder:]): (-[MockContentFilterEnabler initWithDecision:decisionPoint:]): (-[MockContentFilterEnabler encodeWithCoder:]): (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings. (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect. (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload. (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true. (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto. (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true. (downloadTest): Added a helper function to test downloads with a given decision and decision point.
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport. (+[MockContentFilterEnabler supportsSecureCoding]): (-[MockContentFilterEnabler copyWithZone:]): (-[MockContentFilterEnabler initWithCoder:]): (-[MockContentFilterEnabler dealloc]): (-[MockContentFilterEnabler encodeWithCoder:]): (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path. (-[ContentFilteringPlugIn dealloc]): Stop observing. (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler. (+[ServerRedirectPlugIn initialize]): Deleted.
- TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted. (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted. (TEST): Deleted.
2015-08-26 Andy Estes <aestes@apple.com>
Crash when following a Google search link to Twitter with Limit Adult Content enabled
https://bugs.webkit.org/show_bug.cgi?id=147651
Rubber-stamped by Brady Eidson.
Taught TestRunner how to decide the navigation policy after a delay.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
- WebKitTestRunner/InjectedBundle/TestRunner.h: (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
- WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::decidePolicyForNavigationAction):
- WebKitTestRunner/TestController.h: (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
- WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2015-08-24 Andy Estes <aestes@apple.com>
REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
- TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
2015-08-23 Andy Estes <aestes@apple.com>
Addressed a missed piece of review feedback from r188851.
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2015-08-23 Andy Estes <aestes@apple.com>
[Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
https://bugs.webkit.org/show_bug.cgi?id=147872
rdar://problem/22044000
Reviewed by Dan Bernstein.
Added an API test.
- TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added. (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL. (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL. (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]): (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added. (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
- TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
- TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
2015-08-23 Andy Estes <aestes@apple.com>
Fixed the 32-bit Mac build after r188844.
- TestWebKitAPI/WKWebViewConfigurationExtras.h:
- TestWebKitAPI/WKWebViewConfigurationExtras.mm:
2015-08-22 Andy Estes <aestes@apple.com>
[Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
https://bugs.webkit.org/show_bug.cgi?id=148317
Reviewed by Dan Bernstein.
Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
when creating WKWebViews.
Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
added a new API test for bundle parameters.
- TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and named its executable TestWebKitAPI.bundle.
- TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
- TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added. (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
- TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added. (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a bundle parameter and asked for an initial notification. (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter. (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes, mirror its value in the main frame's JSContext.
- TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
- TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added. (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
- TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
- TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
- TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added. (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance. (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response. (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
2015-08-11 Andy Estes <aestes@apple.com>
[Cocoa] Add redirect support to CustomProtocolManager
https://bugs.webkit.org/show_bug.cgi?id=147871
Reviewed by Dan Bernstein.
Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
- TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: (TestWebKitAPI::TEST): Unregesitered TestProtocol.
- TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
- TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL. (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto. (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL. (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false. (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
- TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: (TestWebKitAPI::TEST): Unregistered TestProtocol.
- TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http. (+[TestProtocol canInitWithRequest:]): Changed to use property syntax. (-[TestProtocol startLoading]): Taught to handle redirect responses.
2015-08-13 Andy Estes <aestes@apple.com>
[Cocoa] Downloads do not start if policy decision is made asynchronously
https://bugs.webkit.org/show_bug.cgi?id=147985
Reviewed by Brady Eidson.
Added a new API test.
- TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): (-[AsynchronousDownloadDelegate _downloadDidStart:]): (TEST):
LayoutTests:
2015-09-03 Andy Estes <aestes@apple.com>
REGRESSION: http/tests/contentfiltering/block-after-redirect.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=148684
Reviewed by Alexey Proskuryakov.
Wait for the iframe to load the blocked page before finishing the test.
- http/tests/contentfiltering/block-after-redirect.html:
- platform/mac-wk2/TestExpectations:
2015-08-26 Andy Estes <aestes@apple.com>
[Content Filtering] Determine navigation and content policy before continuing to filter a load
https://bugs.webkit.org/show_bug.cgi?id=148506
Reviewed by Brady Eidson.
Added tests for what happens if the content filter does not make a decision when the load finishes.
- contentfiltering/allow-never-expected.html: Added.
- contentfiltering/allow-never.html: Added.
- contentfiltering/block-never-expected.html: Added.
- contentfiltering/block-never.html: Added.
- contentfiltering/resources/contentfiltering.js:
2015-08-26 Andy Estes <aestes@apple.com>
Crash when following a Google search link to Twitter with Limit Adult Content enabled
https://bugs.webkit.org/show_bug.cgi?id=147651
Rubber-stamped by Brady Eidson.
Added a layout test.
- http/tests/contentfiltering/load-substitute-data-from-appcache-expected.txt: Added.
- http/tests/contentfiltering/load-substitute-data-from-appcache.html: Added.
- http/tests/contentfiltering/resources/appcache.html: Added.
- http/tests/contentfiltering/resources/appcache.manifest: Added.
- platform/mac-wk1/TestExpectations:
- 10:26 PM Changeset in webkit [190777] by
-
- 2 edits in trunk/LayoutTests
http/tests/media/media-source/SourceBuffer-abort-updating.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=149816
Unreviewed, fix updated expectation so it doesn't accidentally cause bots
to run the test on Mavericks (where Media Source is unsupported).
- platform/mac/TestExpectations:
- 9:28 PM Changeset in webkit [190776] by
-
- 4 edits2 adds in trunk/Tools
Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
https://bugs.webkit.org/show_bug.cgi?id=149945
Reviewed by Dan Bernstein.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.ios-9 img.logo):
- 9:01 PM Changeset in webkit [190775] by
-
- 2 edits in trunk/Tools
Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
https://bugs.webkit.org/show_bug.cgi?id=149943
Reviewed by Dan Bernstein.
Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
teach build-webkit to install them when building for iOS device using the public iOS SDK.
- Scripts/build-webkit:
- 7:37 PM Changeset in webkit [190774] by
-
- 3 edits3 copies in branches/safari-601-branch
Merged r190602. rdar://problem/22995830
- 7:29 PM Changeset in webkit [190773] by
-
- 4 edits2 copies in branches/safari-601-branch
Merged r190375. rdar://problem/22881748
- 7:26 PM Changeset in webkit [190772] by
-
- 2 edits1 copy in branches/safari-601-branch/Tools
Merged r190358. rdar://problem/23016109
- 7:18 PM Changeset in webkit [190771] by
-
- 3 edits in branches/safari-601-branch
Merged r189976. rdar://problem/22824652
- 7:16 PM Changeset in webkit [190770] by
-
- 4 edits in branches/safari-601-branch
Merged r189976. rdar://problem/22824652
- 7:06 PM Changeset in webkit [190769] by
-
- 5 edits in branches/safari-601-branch
Included a Radar link in the ChangeLogs for r190766.
- 6:56 PM Changeset in webkit [190768] by
-
- 3 edits1 copy in branches/safari-601-branch/Source/WTF
Merged r189633. rdar://problem/22824646
- 6:50 PM Changeset in webkit [190767] by
-
- 2 edits in branches/safari-601-branch/Source/WTF
Merged r188489. rdar://problem/22824646
- 6:33 PM Changeset in webkit [190766] by
-
- 43 edits3 copies2 moves15 adds in branches/safari-601-branch
Merge r188150, r188517, r188844, r188845, r188851, r188852, r188880, r188881, r188988, r189193, r189289, and r190133.
Source/WebCore:
2015-08-26 Andy Estes <aestes@apple.com>
[Content Filtering] Determine navigation and content policy before continuing to filter a load
https://bugs.webkit.org/show_bug.cgi?id=148506
Reviewed by Brady Eidson.
Prior to this change, ContentFilter would hide from DocumentLoader all CachedRawResourceClient callbacks until
a decision was made, then replay the missed callbacks. This approach interacted poorly with some features of
the loader, notably appcache and downloads. In the case of appcache, DocumentLoader might not have a chance to
check for substitute data until the original load has finished, wasting bandwidth, and might receive duplicate
or out-of-order callbacks. In the case of downloads, it would often be too late to convert the existing
connection to a download, leading to restarted downloads or outright failures.
Bandaids were put in place for these issues in r188150, r188486, and r188851 to fix crashes or serious
regressions in behavior, but these weren't complete fixes. They did not solve any of the duplicate data loading
problems, and they did not make downloads work reliably in all cases.
This patch rolls out the bandaids (but keeps their tests) and replaces them with a more robust fix. Instead of
hiding callbacks from DocumentLoader, ContentFilter now delivers willSendRequest(), redirectReceived(), and
responseReceived() to DocumentLoader immediately, and cancels filtering if DocumentLoader decides to ignore the
load, download it, or load substitute data. ContentFilter continues to buffer incoming data to prevent partial
rendering of blocked content.
The existing tests for r188150 and r188851 were kept, the test for r188486 was rewritten to be specific to
content filtering, and new tests were added to cover the case where ContentFilter is still undecided after a
load finishes.
Tests: contentfiltering/allow-never.html
contentfiltering/block-never.html
ContentFiltering.AllowDownloadAfterAddData
ContentFiltering.AllowDownloadAfterFinishedAddingData
ContentFiltering.AllowDownloadAfterRedirect
ContentFiltering.AllowDownloadAfterResponse
ContentFiltering.AllowDownloadAfterWillSendRequest
ContentFiltering.AllowDownloadNever
ContentFiltering.BlockDownloadAfterAddData
ContentFiltering.BlockDownloadAfterFinishedAddingData
ContentFiltering.BlockDownloadAfterRedirect
ContentFiltering.BlockDownloadAfterResponse
ContentFiltering.BlockDownloadAfterWillSendRequest
ContentFiltering.BlockDownloadNever
- bindings/js/JSMockContentFilterSettingsCustom.cpp: (WebCore::JSMockContentFilterSettings::decisionPoint): Taught to handle DecisionPoint::Never, and rewrote to not need a set of const uint8_ts that mirror the DecisionPoint enum. (WebCore::JSMockContentFilterSettings::setDecisionPoint): Ditto. (WebCore::toJSValue): Rewrote to not need a set of const uint8_ts that mirror the Decision enum. (WebCore::toDecision): Ditto.
- loader/ContentFilter.cpp: (WebCore::ContentFilter::createIfEnabled): Renamed from createIfNeeded, and changed to take a DocumentLoader& instead of a DecisionFunction. (WebCore::ContentFilter::ContentFilter): (WebCore::ContentFilter::responseReceived): If m_state != Blocked after filtering, call DocumentLoader::responseReceived(). (WebCore::ContentFilter::dataReceived): If m_state == Allowed after filtering, deliver buffered data to DocumentLoader. If no filtering was necessary, call DocumentLoader::dataReceived() directly. (WebCore::ContentFilter::redirectReceived): If m_state != Blocked after filtering, call DocumentLoader::redirectReceived(). (WebCore::ContentFilter::notifyFinished): If an error occured, call DocumentLoader::notifyFinished() immediately and return. If m_state != Blocked after filtering, deliver buffered data to DocumentLoader and call DocumentLoader::notifyFinished(). If no filtering was necessary and m_state != Blocked, call DocumentLoader::notifyFinished() directly. (WebCore::ContentFilter::didDecide): Called DocumentLoader::contentFilterDidDecide() instead of m_decisionFunction(). (WebCore::ContentFilter::deliverResourceData): Added a helper function to deliver buffered data to DocumentLoader. (WebCore::ContentFilter::createIfNeeded): Renamed to createIfEnabled().
- loader/ContentFilter.h:
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::willSendRequest): Stopped asserting that redirectResponse is null and made it part of the if condition instead, since willSendRequest() will now be called on redirects when there is an active ContentFilter. (WebCore::DocumentLoader::startLoadingMainResource): Called becomeMainResourceClient() instead of becomeMainResourceClientIfFilterAllows(). (WebCore::DocumentLoader::becomeMainResourceClient): Renamed from becomeMainResourceClientIfFilterAllows(). Only called ContentFilter::startFilteringMainResource() if the filter state is Initialized, since ContentFilter might have already made a decision in willSendRequest(). (WebCore::DocumentLoader::contentFilterDidDecide): Stopped deleting m_contentFilter, since it will continue to deliver callbacks even after making a decision. Fixed a bug where we were creating two copies of ContentFilter's replacement data. (WebCore::DocumentLoader::syntheticRedirectReceived): Deleted. (WebCore::DocumentLoader::becomeMainResourceClientIfFilterAllows): Renamed to becomeMainResourceClient().
- loader/DocumentLoader.h:
- loader/EmptyClients.h:
- loader/FrameLoaderClient.h:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequestInternal): Removed part of r188851.
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): Removed part of r188486.
- loader/SubresourceLoader.h:
- loader/cache/CachedRawResource.cpp: (WebCore::CachedRawResource::didAddClient): Removed part of r188150.
- loader/cache/CachedRawResourceClient.h: (WebCore::CachedRawResourceClient::syntheticRedirectReceived): Removed part of r188150.
- testing/MockContentFilterSettings.h: Defined DecisionPoint::Never.
- testing/MockContentFilterSettings.idl: Defined DECISION_POINT_NEVER.
Source/WebKit/mac:
2015-08-26 Andy Estes <aestes@apple.com>
[Content Filtering] Determine navigation and content policy before continuing to filter a load
https://bugs.webkit.org/show_bug.cgi?id=148506
Reviewed by Brady Eidson.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::convertMainResourceLoadToDownload): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
Source/WebKit2:
2015-08-26 Andy Estes <aestes@apple.com>
[Content Filtering] Determine navigation and content policy before continuing to filter a load
https://bugs.webkit.org/show_bug.cgi?id=148506
Reviewed by Brady Eidson.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::convertMainResourceLoadToDownload):
2015-08-11 Andy Estes <aestes@apple.com>
[Cocoa] Add redirect support to CustomProtocolManager
https://bugs.webkit.org/show_bug.cgi?id=147871
Reviewed by Dan Bernstein.
NSURLProtocols have the ability to generate redirect responses. This change teaches CustomProtocolManager how to handle them.
- Shared/Network/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm: (WebKit::CustomProtocolManager::wasRedirectedToRequest): Called -URLProtocol:wasRedirectedToRequest:redirectResponse: on the NSURLProtocolClient.
- Shared/Network/CustomProtocols/CustomProtocolManager.h:
- Shared/Network/CustomProtocols/CustomProtocolManager.messages.in: Defined WasRedirectedToRequest.
- Shared/Network/CustomProtocols/soup/CustomProtocolManagerSoup.cpp: (WebKit::CustomProtocolManager::wasRedirectedToRequest): Defined empty function.
- UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm: (-[WKCustomProtocolLoader connection:willSendRequest:redirectResponse:]): If a redirect response is received, send WasRedirectedToRequest and return nil to ignore the redirect.
Tools:
2015-09-22 Andy Estes <aestes@apple.com>
ContentFiltering.AllowDownloadAfterAddData is very flaky
https://bugs.webkit.org/show_bug.cgi?id=148885
<rdar://problem/22729563>
Reviewed by Alexey Proskuryakov.
The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
but there is no guarantee of this. For tests that should allow a download, spin the runloop until
-_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: (downloadTest):
2015-08-26 Andy Estes <aestes@apple.com>
[Content Filtering] Determine navigation and content policy before continuing to filter a load
https://bugs.webkit.org/show_bug.cgi?id=148506
Reviewed by Brady Eidson.
Added download API tests covering every decision and decision point.
Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
- TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
- TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
- TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter decision and decision point as a bundle parameter. (+[MockContentFilterEnabler supportsSecureCoding]): (-[MockContentFilterEnabler copyWithZone:]): (-[MockContentFilterEnabler initWithCoder:]): (-[MockContentFilterEnabler initWithDecision:decisionPoint:]): (-[MockContentFilterEnabler encodeWithCoder:]): (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings. (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect. (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload. (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true. (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto. (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true. (downloadTest): Added a helper function to test downloads with a given decision and decision point.
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport. (+[MockContentFilterEnabler supportsSecureCoding]): (-[MockContentFilterEnabler copyWithZone:]): (-[MockContentFilterEnabler initWithCoder:]): (-[MockContentFilterEnabler dealloc]): (-[MockContentFilterEnabler encodeWithCoder:]): (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path. (-[ContentFilteringPlugIn dealloc]): Stop observing. (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler. (+[ServerRedirectPlugIn initialize]): Deleted.
- TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted. (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted. (TEST): Deleted.
2015-08-26 Andy Estes <aestes@apple.com>
Crash when following a Google search link to Twitter with Limit Adult Content enabled
https://bugs.webkit.org/show_bug.cgi?id=147651
Rubber-stamped by Brady Eidson.
Taught TestRunner how to decide the navigation policy after a delay.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
- WebKitTestRunner/InjectedBundle/TestRunner.h: (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
- WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::decidePolicyForNavigationAction):
- WebKitTestRunner/TestController.h: (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
- WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2015-08-24 Andy Estes <aestes@apple.com>
REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
- TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
2015-08-23 Andy Estes <aestes@apple.com>
Addressed a missed piece of review feedback from r188851.
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2015-08-23 Andy Estes <aestes@apple.com>
[Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
https://bugs.webkit.org/show_bug.cgi?id=147872
rdar://problem/22044000
Reviewed by Dan Bernstein.
Added an API test.
- TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added. (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL. (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL. (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]): (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added. (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
- TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
- TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
2015-08-23 Andy Estes <aestes@apple.com>
Fixed the 32-bit Mac build after r188844.
- TestWebKitAPI/WKWebViewConfigurationExtras.h:
- TestWebKitAPI/WKWebViewConfigurationExtras.mm:
2015-08-22 Andy Estes <aestes@apple.com>
[Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
https://bugs.webkit.org/show_bug.cgi?id=148317
Reviewed by Dan Bernstein.
Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
when creating WKWebViews.
Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
added a new API test for bundle parameters.
- TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and named its executable TestWebKitAPI.bundle.
- TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
- TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added. (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
- TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added. (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a bundle parameter and asked for an initial notification. (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter. (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes, mirror its value in the main frame's JSContext.
- TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
- TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added. (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
- TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
- TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
- TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added. (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance. (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response. (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
2015-08-11 Andy Estes <aestes@apple.com>
[Cocoa] Add redirect support to CustomProtocolManager
https://bugs.webkit.org/show_bug.cgi?id=147871
Reviewed by Dan Bernstein.
Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
- TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: (TestWebKitAPI::TEST): Unregesitered TestProtocol.
- TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
- TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL. (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto. (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL. (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false. (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
- TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: (TestWebKitAPI::TEST): Unregistered TestProtocol.
- TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http. (+[TestProtocol canInitWithRequest:]): Changed to use property syntax. (-[TestProtocol startLoading]): Taught to handle redirect responses.
2015-08-13 Andy Estes <aestes@apple.com>
[Cocoa] Downloads do not start if policy decision is made asynchronously
https://bugs.webkit.org/show_bug.cgi?id=147985
Reviewed by Brady Eidson.
Added a new API test.
- TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): (-[AsynchronousDownloadDelegate _downloadDidStart:]): (TEST):
LayoutTests:
2015-09-03 Andy Estes <aestes@apple.com>
REGRESSION: http/tests/contentfiltering/block-after-redirect.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=148684
Reviewed by Alexey Proskuryakov.
Wait for the iframe to load the blocked page before finishing the test.
- http/tests/contentfiltering/block-after-redirect.html:
- platform/mac-wk2/TestExpectations:
2015-08-26 Andy Estes <aestes@apple.com>
[Content Filtering] Determine navigation and content policy before continuing to filter a load
https://bugs.webkit.org/show_bug.cgi?id=148506
Reviewed by Brady Eidson.
Added tests for what happens if the content filter does not make a decision when the load finishes.
- contentfiltering/allow-never-expected.html: Added.
- contentfiltering/allow-never.html: Added.
- contentfiltering/block-never-expected.html: Added.
- contentfiltering/block-never.html: Added.
- contentfiltering/resources/contentfiltering.js:
2015-08-26 Andy Estes <aestes@apple.com>
Crash when following a Google search link to Twitter with Limit Adult Content enabled
https://bugs.webkit.org/show_bug.cgi?id=147651
Rubber-stamped by Brady Eidson.
Added a layout test.
- http/tests/contentfiltering/load-substitute-data-from-appcache-expected.txt: Added.
- http/tests/contentfiltering/load-substitute-data-from-appcache.html: Added.
- http/tests/contentfiltering/resources/appcache.html: Added.
- http/tests/contentfiltering/resources/appcache.manifest: Added.
- platform/mac-wk1/TestExpectations:
- 6:13 PM Changeset in webkit [190765] by
-
- 15 edits2 copies in branches/safari-601-branch/Source/JavaScriptCore
Merged r189454. rdar://problem/22802036
- 6:13 PM Changeset in webkit [190764] by
-
- 2 edits in trunk/Websites/perf.webkit.org
pull-svn.py fails to sync revisions when SVN credentials is not setup
https://bugs.webkit.org/show_bug.cgi?id=149941
Reviewed by Chris Dumez.
Added the support for specifying subversion credentials.
Also added the support for pulling from multiple subversion servers. Subversion servers are specified
in a JSON configuration file specified by --svn-config formatted as follows:
[
{
"name": "WebKit",
"url": "http://svn.webkit.org/repository/webkit",
"username": "webkitten",
"password": "webkitten's password",
"trustCertificate": true,
"accountNameFinderScript":
["python", "/Volumes/Data/WebKit/Tools/Scripts/webkit-patch", "find-users"]
},
...
]
In addition, refactored it to use the shared server config JSON for the dashboard access.
- tools/pull-svn.py:
(main): Now takes --svn-config-json, --server-config-json, --seconds-to-sleep and --max-fetch-count
as required options instead of seven unnamed arguments.
(fetch_commits_and_submit): Extracted from main. Fetches at most max_fetch_count new revisions from
the subversion server, and submits them in accordance with server_config.
(fetch_commit_and_resolve_author): Now takes a single repository dictionary instead of two separate
arguments for name and URL to pass down the repository's authentication info to fetch_commit.
(fetch_commit): Ditto. Add appropriate arguments when username and passwords are specified.
(resolve_author_name_from_account): Use a list argument instead of a single string argument now that
the argument comes from a JSON instead of sys.argv.
- 5:47 PM Changeset in webkit [190763] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, build fix for ENABLE(MEDIA_SESSION) after r190030.
- dom/Document.cpp:
(WebCore::Document::updateIsPlayingMedia):
- 5:31 PM Changeset in webkit [190762] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, build fixes for ENABLE(MEDIA_SESSION) after r190030.
- Modules/mediasession/HTMLMediaElementMediaSession.cpp:
(WebCore::HTMLMediaElementMediaSession::session):
- Modules/mediasession/HTMLMediaElementMediaSession.h:
- Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::controls):
- Modules/mediasession/MediaSession.h:
- 5:16 PM WikiStart edited by
- Add a link to the November contributor's meeting (diff)
- 5:13 PM Changeset in webkit [190761] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG SSA should remove unreachable code
https://bugs.webkit.org/show_bug.cgi?id=149931
Reviewed by Geoffrey Garen.
Rolled back in with a call to m_state.reset(), which fixes the debug asserts.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::run): Remove unreachable code.
- dfg/DFGObjectAllocationSinkingPhase.cpp: Deal with the CFG changing.
- dfg/DFGPutStackSinkingPhase.cpp: Deal with the CFG changing.
- 5:13 PM November 2015 Meeting created by
- Add a template
- 4:45 PM Changeset in webkit [190760] by
-
- 5 edits3 adds in trunk
Gracefully handle XMLDocumentParser being detached by mutation events.
https://bugs.webkit.org/show_bug.cgi?id=149485
<rdar://problem/22811489>
Source/WebCore:
This is a merge of Blink change 200026,
https://codereview.chromium.org/1267283002
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-08
Reviewed by Darin Adler.
Test: fast/parser/xhtml-dom-character-data-modified-crash.html
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::createLeafTextNode):
Renamed from enterText() to make it more descriptive.
(WebCore::XMLDocumentParser::updateLeafTextNode):
Renamed from exitText to firm up this stage.
(WebCore::XMLDocumentParser::end):
Gracefully handle stopped states.
(WebCore::XMLDocumentParser::enterText): Deleted.
(WebCore::XMLDocumentParser::exitText): Deleted.
- xml/parser/XMLDocumentParser.h:
Rename enterText to createLeafTextNode.
Rename exitText to updateLeafTextNode.
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::XMLDocumentParser::characters):
(WebCore::XMLDocumentParser::processingInstruction):
(WebCore::XMLDocumentParser::cdataBlock):
(WebCore::XMLDocumentParser::comment):
(WebCore::XMLDocumentParser::endDocument):
Rename function calls and firm up updateLeafTextNode stage accordingly.
LayoutTests:
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-08
Reviewed by Darin Adler.
- fast/parser/resources/xhtml-overwrite-frame.xhtml: Added.
- fast/parser/xhtml-dom-character-data-modified-crash-expected.txt: Added.
- fast/parser/xhtml-dom-character-data-modified-crash.html: Added.
- 4:34 PM Changeset in webkit [190759] by
-
- 6 edits2 adds in trunk
Add LLVM binaries for iOS 9 device
https://bugs.webkit.org/show_bug.cgi?id=149913
Source/JavaScriptCore:
Reviewed by Filip Pizlo.
Look for locally built/binary dropped LLVM headers and libraries when building for iOS device
in WebKitBuild/usr/local.
Currently Mac and iOS look for the locally built/binary dropped LLVM in different directories:
WebKitBuild/usr/local and /usr/local/LLVMForJavaScriptCore, respectively. This difference is
due to dependencies with the Apple internal build system. We should look to resolve the
Apple internal dependencies and standardize on one location for both platforms.
- Configurations/Base.xcconfig:
Tools:
Reviewed by Filip Pizlo.
Implement support for building LLVM for ARM64-based iOS devices.
- Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
- Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
an existing build earlier in the file such that remove previously built
libraries before building/copying new ones (if applicable).
(fileContains): Moved function outside of if-block.
(isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
(buildLLVM): Added. Extracted machinery to build LLVM into this function and
added logic to build LLVM for ARM64-based iOS devices.
(symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
LLVM into the WebKitBuild directory.
WebKitLibraries:
Rubber-stamped by Filip Pizlo.
Add LLVM 3.6.2 binaries for ARM64-based iOS devices. We make use of LLVM for the FTL,
which is enabled for 64-bit iOS devices.
I built these binaries by performing the following:
1) Check out WebKit to a directory like /some/path/OpenSource.
2) Download and expand the archive <http://llvm.org/releases/3.6.2/llvm-3.6.2.src.tar.xz> into /some/path/OpenSource/llvm.
3) In /some/path/OpenSource, delete the WebKitBuild directory to ensure a clean build.
4) Run
Tools/Scripts/build-jsc --release --device ARCHS=arm64 ONLY_ACTIVE_ARCH=NOto build both LLVM and JavaScriptCore.
5) Run
Tools/Scripts/export-llvm-build -i WebKitLibraries/LLVMIncludesIOSDevice9.tar.bz2 -l WebKitLibraries/LLVMLibrariesIOSDevice9.tar.bz2 -b llvm/wkLLVMBuild -B llvm/wkLLVMBuild/Release+Asserts -s llvmto produce files LLVM{Includes, Libraries}IOS9.tar.bz2.
- LLVMIncludesIOS9.tar.bz2: Added.
- LLVMLibrariesIOS9.tar.bz2: Added.
- 4:30 PM Changeset in webkit [190758] by
-
- 3 edits2 copies in branches/safari-601-branch
Merged r188148. rdar://problem/22802049
- 4:19 PM Changeset in webkit [190757] by
-
- 3 edits in trunk/LayoutTests
Cleaning up after revision 190339
https://bugs.webkit.org/show_bug.cgi?id=149732
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-08
Reviewed by Myles C. Maxfield.
- svg/custom/invalid-xslt-crash.svg:
- svg/custom/invalid-xslt-crash-expected.txt:
Replace render tree dump test with text dump.
- 4:14 PM Changeset in webkit [190756] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r190749.
https://bugs.webkit.org/show_bug.cgi?id=149938
Caused 50+ layout test failures
https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r190749%20(213)/results.html
(Requested by litherum1 on #webkit).
Reverted changeset:
"DFG SSA should remove unreachable code"
https://bugs.webkit.org/show_bug.cgi?id=149931
http://trac.webkit.org/changeset/190749
- 3:59 PM Changeset in webkit [190755] by
-
- 2 edits in trunk/Source/WebCore
data: URLs should not be preloaded
https://bugs.webkit.org/show_bug.cgi?id=149829
Reviewed by Darin Adler.
Fix review comments after r190605:
Use protocolIs() instead of String::startsWith().
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):
- 3:53 PM Changeset in webkit [190754] by
-
- 13 edits in trunk/Source/WebCore
Revert r187626 (and r188025) as it caused a PLT regression
https://bugs.webkit.org/show_bug.cgi?id=149898
<rdar://problem/22657123>
Reviewed by Myles Maxfield.
- css/CSSPropertyNames.in:
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyValueWebkitLocale):
- platform/graphics/Font.cpp:
(WebCore::CharacterFallbackMapKey::CharacterFallbackMapKey):
(WebCore::CharacterFallbackMapKey::operator==):
(WebCore::CharacterFallbackMapKeyHash::hash):
(WebCore::Font::systemFallbackFontForCharacter):
- platform/graphics/FontCache.h:
(WebCore::FontDescriptionKey::operator==):
(WebCore::FontDescriptionKey::FontDescriptionKey): Deleted.
(WebCore::FontDescriptionKey::computeHash): Deleted.
- platform/graphics/FontDescription.cpp:
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::traitsMask): Deleted.
(WebCore::FontCascadeDescription::FontCascadeDescription): Deleted.
- platform/graphics/FontDescription.h:
(WebCore::FontDescription::setScript):
(WebCore::FontDescription::operator==):
(WebCore::FontDescription::setFeatureSettings): Deleted.
(WebCore::FontCascadeDescription::initialVariantAlternates): Deleted.
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::systemFallbackForCharacters):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
- style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
- 3:53 PM Changeset in webkit [190753] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/media/media-source/SourceBuffer-abort-updating.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=149816
Patch by Ryan Haddad <Ryan Haddad> on 2015-10-08
Reviewed by Darin Adler.
- platform/mac/TestExpectations:
- 3:43 PM Changeset in webkit [190752] by
-
- 12 edits2 adds in trunk
Generated frame tree names should be kept reasonably long.
<https://webkit.org/b/149874>
Reviewed by Darin Adler.
Source/WebCore:
Some clumsy advertising script is going around assigning JavaScript source code
to the "name" attribute of iframes. This is causing WebKit to generate way too huge
names for anonymous descendants of such iframes.
Previously, the generated name of an anonymous subframe would be its slash-separated
path from the root frame, with the "name" attribute of each ancestor between the
slashes, or "<!--frame${index in parent}-->" for anonymous ancestors.
These ad scripts are often over 100kB in size, with multiple subframes, so we'd end
up with frame names looking like this:
"<!--framePath <MONSTER BLOB OF JAVASCRIPT FROM HELL>/<!--frame0--><!--frame0-->-->"
While this is worth fixing for the memory usage alone, we've been making it way
worse by also using these paths when recording the back/forward history parts of
WebKit session state.
This patch makes generated paths always use index-in-parent as the "directory name"
for ancestors of anonymous subframes. The above example path will now instead be:
"<!--framePath <!--frame0-->/<!--frame0-->/<!--frame0-->-->"
Test: fast/frames/long-names-in-nested-subframes.html
- page/FrameTree.cpp:
(WebCore::FrameTree::indexInParent):
(WebCore::FrameTree::uniqueChildName):
- page/FrameTree.h:
LayoutTests:
Added a test to document our name generation behavior for subframes with long-named ancestors.
Also rebaselined some tests that exposed the old behavior.
- fast/forms/form-and-frame-interaction-retains-values-expected.txt:
- fast/frames/long-names-in-nested-subframes-expected.txt: Added.
- fast/frames/long-names-in-nested-subframes.html: Added.
- http/tests/navigation/image-load-in-subframe-unload-handler-expected.txt:
- http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
- http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame-2-level-expected.txt:
- http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-to-javscript-url-expected.txt:
- http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-from-javscript-url-expected.txt:
- 3:25 PM Changeset in webkit [190751] by
-
- 4 edits in branches/safari-601-branch/Source/WebInspectorUI
Merge r189011. rdar://problem/22801999
2015-08-26 Nikita Vasilyev <Nikita Vasilyev>
Web Inspector: [Regression] [Mavericks]: Undocked Web Inspector toolbar is two different colors and has extra space
https://bugs.webkit.org/show_bug.cgi?id=148510
Make body element transparent and remove extra padding above the toolbar only for OS X Mavericks.
Reviewed by Timothy Hatcher.
- UserInterface/Base/Main.js: (WebInspector.contentLoaded):
- UserInterface/Views/Main.css: (body:not(.mavericks)): (body): Deleted.
- UserInterface/Views/Toolbar.css: (body:not(.mavericks) .toolbar): (body.window-inactive:not(.mavericks) .toolbar): (body.mac-platform:not(.docked, .mavericks) .toolbar): (.toolbar): Deleted. (body.window-inactive .toolbar): Deleted. (body.mac-platform:not(.docked) .toolbar): Deleted.
- 3:19 PM Changeset in webkit [190750] by
-
- 3 edits in branches/safari-601-branch/Source/WebInspectorUI
Merged r188173. rdar://problem/22801999
- 3:18 PM Changeset in webkit [190749] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG SSA should remove unreachable code
https://bugs.webkit.org/show_bug.cgi?id=149931
Reviewed by Geoffrey Garen.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::run): Remove unreachable code.
- dfg/DFGObjectAllocationSinkingPhase.cpp: Deal with the CFG changing.
- dfg/DFGPutStackSinkingPhase.cpp: Deal with the CFG changing.
- 3:16 PM Changeset in webkit [190748] by
-
- 3 edits in branches/safari-601-branch/Source/WebInspectorUI
Merged r187715. rdar://problem/22801999
- 3:08 PM Changeset in webkit [190747] by
-
- 7 edits in branches/safari-601-branch/Source
Rollout r190745.
- 3:00 PM Changeset in webkit [190746] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r190701.
https://bugs.webkit.org/show_bug.cgi?id=149937
"It did not help, will try a full roll out instead" (Requested
by cdumez on #webkit).
Reverted changeset:
"Partial revert of r187626 as it caused a PLT regression"
https://bugs.webkit.org/show_bug.cgi?id=149898
http://trac.webkit.org/changeset/190701
Patch by Commit Queue <commit-queue@webkit.org> on 2015-10-08
- 2:08 PM Changeset in webkit [190745] by
-
- 7 edits in branches/safari-601-branch/Source
Merged r188443. rdar://problem/22801969
- 1:56 PM Changeset in webkit [190744] by
-
- 5 edits in branches/safari-601-branch/Source/WebInspectorUI
Merged r188378. rdar://problem/22801980
- 1:53 PM Changeset in webkit [190743] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix. Missing forward declaration.
- heap/Heap.h:
- 1:53 PM Changeset in webkit [190742] by
-
- 3 edits in branches/safari-601-branch/Source/WebInspectorUI
Merged r187052. rdar://problem/22801992
- 1:24 PM Changeset in webkit [190741] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed Cloop build fix after bug: https://bugs.webkit.org/show_bug.cgi?id=149601
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::newExceptionHandlingCallSiteIndex):
- jit/JITCode.cpp:
(JSC::NativeJITCode::addressForCall):
(JSC::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
- jit/JITCode.h:
- 1:19 PM Changeset in webkit [190740] by
-
- 3 edits in branches/safari-601.1-branch/Source/WebInspectorUI
Rollout r190736.
- 1:19 PM Changeset in webkit [190739] by
-
- 15 edits in trunk/Source
Clean up Marked classes
https://bugs.webkit.org/show_bug.cgi?id=149853
Reviewed by Darin Adler.
Source/JavaScriptCore:
- heap/Heap.h:
Move include here where it is really needed.
- heap/HeapStatistics.cpp:
- heap/HeapStatistics.h:
Simplify includes.
- heap/MarkedAllocator.h:
Add missing copyright header.
- heap/MarkedBlock.cpp:
- heap/MarkedBlock.h:
(JSC::MarkedBlock::needsSweeping):
Remove unused constants. Add some static asserts. Add someconstness.
- heap/MarkedSpace.h:
(JSC::MarkedSpace::isIterating):
Update comments to better reflect actual values.
Remove unimplemented method (moved to Heap).
- heap/MarkedSpace.cpp:
(JSC::Free::Free):
(JSC::Free::operator()):
(JSC::Free::returnValue): Deleted.
(JSC::FreeOrShrink::FreeOrShrink):
(JSC::FreeOrShrink::operator()):
(JSC::MarkedSpace::~MarkedSpace):
(JSC::MarkedSpace::shrink):
Replace conditional Functor that was not using return value
with simplified targeted VoidFunctors.
(JSC::Shrink::operator()): Deleted.
Remove unused functor.
- heap/WeakBlock.cpp:
- heap/WeakBlock.h:
- runtime/Options.cpp:
Remove dead code.
Source/WTF:
- wtf/PageBlock.h:
Remove duplicate using statement.
- 1:17 PM Changeset in webkit [190738] by
-
- 5 edits in branches/safari-601.1-branch/Source/WebInspectorUI
Rollout r190737.
- 1:05 PM Changeset in webkit [190737] by
-
- 5 edits in branches/safari-601.1-branch/Source/WebInspectorUI
Merged r188378. rdar://problem/22801980
- 1:00 PM Changeset in webkit [190736] by
-
- 3 edits in branches/safari-601.1-branch/Source/WebInspectorUI
Merged r187052. <rdar://problem/22801992>
- 12:37 PM Changeset in webkit [190735] by
-
- 36 edits8 adds in trunk
We should be able to inline getter/setter calls inside an inline cache even when the SpillRegistersMode is NeedsToSpill
https://bugs.webkit.org/show_bug.cgi?id=149601
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Before, if we had a PolymorphicAccess with and a StructureStubInfo
with a NeedToSpill spillMode, we wouldn't generate getter/setter
calls. This patch changes it such that we will generate the
getter/setter call and do the necessary register spilling/filling
around the getter/setter call to preserve any "usedRegisters".
This has an interesting story with how it relates to exception handling
inside the DFG. Because the GetById variants are considered a throwing call
site, we must make sure that we properly restore the registers spilled to the stack
in case of an exception being thrown inside the getter/setter call. We do
this by having the inline cache register itself as a new exception handling
call site. When the inline cache "catches" the exception (i.e, genericUnwind
will jump to this code), it will restore the registers it spilled that are
live inside the original catch handler, and then jump to the original catch
handler. We make sure to only generate this makeshift catch handler when we
actually need to do any cleanup. If we determine that we don't need to restore
any registers, we don't bother generating this makeshift catch handler.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::handlerForIndex):
(JSC::CodeBlock::newExceptionHandlingCallSiteIndex):
(JSC::CodeBlock::removeExceptionHandlerForCallSite):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::appendExceptionHandler):
- bytecode/PolymorphicAccess.cpp:
(JSC::AccessGenerationState::AccessGenerationState):
(JSC::AccessGenerationState::restoreScratch):
(JSC::AccessGenerationState::succeed):
(JSC::AccessGenerationState::calculateLiveRegistersForCallAndExceptionHandling):
(JSC::AccessGenerationState::preserveLiveRegistersToStackForCall):
(JSC::AccessGenerationState::restoreLiveRegistersFromStackForCall):
(JSC::AccessGenerationState::restoreLiveRegistersFromStackForCallWithThrownException):
(JSC::AccessGenerationState::liveRegistersForCall):
(JSC::AccessGenerationState::callSiteIndexForExceptionHandlingOrOriginal):
(JSC::AccessGenerationState::callSiteIndexForExceptionHandling):
(JSC::AccessGenerationState::originalExceptionHandler):
(JSC::AccessGenerationState::numberOfStackBytesUsedForRegisterPreservation):
(JSC::AccessGenerationState::needsToRestoreRegistersIfException):
(JSC::AccessGenerationState::originalCallSiteIndex):
(JSC::AccessGenerationState::liveRegistersToPreserveAtExceptionHandlingCallSite):
(JSC::AccessCase::AccessCase):
(JSC::AccessCase::generate):
(JSC::PolymorphicAccess::regenerateWithCases):
(JSC::PolymorphicAccess::regenerate):
(JSC::PolymorphicAccess::aboutToDie):
- bytecode/PolymorphicAccess.h:
(JSC::AccessCase::doesCalls):
(JSC::AccessCase::isGetter):
(JSC::AccessCase::callLinkInfo):
- bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::aboutToDie):
(JSC::StructureStubInfo::addAccessCase):
- bytecode/StructureStubInfo.h:
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::isInJSValueRegs):
(JSC::ValueRecovery::fpr):
- dfg/DFGCommonData.cpp:
(JSC::DFG::CommonData::addCodeOrigin):
(JSC::DFG::CommonData::addCodeOriginUnconditionally):
(JSC::DFG::CommonData::lastCallSite):
(JSC::DFG::CommonData::removeCallSiteIndex):
(JSC::DFG::CommonData::shrinkToFit):
- dfg/DFGCommonData.h:
- dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::reconstruct):
(JSC::DFG::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
(JSC::DFG::JITCode::checkIfOptimizationThresholdReached):
- dfg/DFGJITCode.h:
(JSC::DFG::JITCode::osrEntryBlock):
(JSC::DFG::JITCode::setOSREntryBlock):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::appendExceptionHandlingOSRExit):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
- dfg/DFGOSRExit.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileIn):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::validateReferences):
(JSC::FTL::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
- ftl/FTLJITCode.h:
(JSC::FTL::JITCode::handles):
(JSC::FTL::JITCode::dataSections):
- jit/GCAwareJITStubRoutine.cpp:
(JSC::GCAwareJITStubRoutine::GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::~GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::observeZeroRefCount):
(JSC::MarkingGCAwareJITStubRoutineWithOneObject::markRequiredObjectsInternal):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::GCAwareJITStubRoutineWithExceptionHandler):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::aboutToDie):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::~GCAwareJITStubRoutineWithExceptionHandler):
(JSC::createJITStubRoutine):
- jit/GCAwareJITStubRoutine.h:
- jit/JITCode.cpp:
(JSC::NativeJITCode::addressForCall):
(JSC::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
- jit/JITCode.h:
- jit/JITInlineCacheGenerator.cpp:
(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
- jit/JITInlineCacheGenerator.h:
(JSC::JITByIdGenerator::reportSlowPathCall):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
- jit/JITStubRoutine.h:
(JSC::JITStubRoutine::createSelfManagedRoutine):
(JSC::JITStubRoutine::aboutToDie):
- jit/RegisterSet.cpp:
(JSC::RegisterSet::webAssemblyCalleeSaveRegisters):
(JSC::RegisterSet::registersToNotSaveForCall):
(JSC::RegisterSet::allGPRs):
- jit/RegisterSet.h:
(JSC::RegisterSet::set):
(JSC::RegisterSet::clear):
- jit/ScratchRegisterAllocator.cpp:
(JSC::ScratchRegisterAllocator::allocateScratchGPR):
(JSC::ScratchRegisterAllocator::allocateScratchFPR):
(JSC::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
(JSC::ScratchRegisterAllocator::usedRegistersForCall):
(JSC::ScratchRegisterAllocator::preserveUsedRegistersToScratchBufferForCall):
(JSC::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBufferForCall):
(JSC::ScratchRegisterAllocator::preserveRegistersToStackForCall):
(JSC::ScratchRegisterAllocator::restoreRegistersFromStackForCall):
- jit/ScratchRegisterAllocator.h:
(JSC::ScratchRegisterAllocator::numberOfReusedRegisters):
(JSC::ScratchRegisterAllocator::usedRegisters):
- jsc.cpp:
(WTF::CustomGetter::CustomGetter):
(WTF::CustomGetter::createStructure):
(WTF::CustomGetter::create):
(WTF::CustomGetter::getOwnPropertySlot):
(WTF::CustomGetter::customGetter):
(WTF::Element::handleOwner):
(GlobalObject::finishCreation):
(functionCreateImpureGetter):
(functionCreateCustomGetterObject):
(functionSetImpureGetterDelegate):
- tests/stress/try-catch-custom-getter-as-get-by-id.js: Added.
(assert):
(bar):
(foo):
- tests/stress/try-catch-getter-as-get-by-id-register-restoration.js: Added.
(assert):
(o1.get f):
(bar):
(foo):
- tests/stress/try-catch-getter-as-get-by-id.js: Added.
(assert):
(o1.get f):
(bar):
(foo):
- tests/stress/try-catch-setter-as-put-by-id.js: Added.
(assert):
(o1.set f):
(bar):
(foo):
- tests/stress/try-catch-stub-routine-replaced.js: Added.
(assert):
(arr):
(hello):
(foo):
(objChain.get f):
(fakeOut.get f):
(o.get f):
LayoutTests:
- js/regress/custom-setter-getter-as-put-get-by-id-expected.txt: Added.
- js/regress/custom-setter-getter-as-put-get-by-id.html: Added.
- js/regress/script-tests/custom-setter-getter-as-put-get-by-id.js: Added.
(assert):
(test):
- 11:46 AM Changeset in webkit [190734] by
-
- 2 edits in trunk/Source/WebCore
Fallback to the RenderView when repaint container is null.
https://bugs.webkit.org/show_bug.cgi?id=149903
Reviewed by Simon Fraser.
Reduces code complexity at the calling sites.
No change in functionality.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
- 10:44 AM Changeset in webkit [190733] by
-
- 4 edits in trunk/LayoutTests
fast/events/scroll-after-click-on-tab-index.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=149859
Reviewed by Simon Fraser.
- fast/events/scroll-after-click-on-tab-index-expected.txt:
- fast/events/scroll-after-click-on-tab-index.html:
- platform/mac/TestExpectations:
- 10:40 AM Changeset in webkit [190732] by
-
- 3 edits2 adds in trunk
Add NULL check for renderBox::layer() on applying zoom level change
https://bugs.webkit.org/show_bug.cgi?id=149302
<rdar://problem/22747292>
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-08
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/css/zoom-on-nested-scroll-crash.html
This is a merge of Blink r158238:
https://chromiumcodereview.appspot.com/23526081
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
LayoutTests:
- fast/css/zoom-on-nested-scroll-crash-expected.txt: Added.
- fast/css/zoom-on-nested-scroll-crash.html: Added.
- 10:35 AM Changeset in webkit [190731] by
-
- 4 edits in trunk/Source/WebCore
Update Inspector to only work with Legacy IDB (for now).
https://bugs.webkit.org/show_bug.cgi?id=149928.
Reviewed by Tim Horton.
- Modules/indexeddb/IDBAny.h:
(WebCore::IDBAny::isLegacy):
- Modules/indexeddb/legacy/LegacyAny.h:
- inspector/InspectorIndexedDBAgent.cpp:
- 10:07 AM Changeset in webkit [190730] by
-
- 2 edits in trunk/Tools
Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
https://bugs.webkit.org/show_bug.cgi?id=149848
Reviewed by Darin Adler.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
- 9:32 AM Changeset in webkit [190729] by
-
- 2 edits in trunk/LayoutTests
Marking fast/events/scroll-after-click-on-tab-index.html as flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=149859
Patch by Ryan Haddad <Ryan Haddad> on 2015-10-08
Reviewed by Darin Adler.
- platform/mac/TestExpectations:
- 9:26 AM Changeset in webkit [190728] by
-
- 3 edits2 adds in trunk
CrashTracer: [USER] com.apple.WebKit.WebContent at …Core::SelectorChecker::checkScrollbarPseudoClass const + 217
https://bugs.webkit.org/show_bug.cgi?id=149921
rdar://problem/22731359
Reviewed by Andreas Kling.
Source/WebCore:
Test: svg/css/use-window-inactive-crash.html
- css/SelectorCheckerTestFunctions.h:
(WebCore::isWindowInactive):
Null check page.
LayoutTests:
The test crashes with shipping WebKit but not with current ToT (probably due to shadow DOM styling changes). Still adding
it for coverage.
- svg/css/use-window-inactive-crash-expected.html: Added.
- svg/css/use-window-inactive-crash.html: Added.
- 8:33 AM Changeset in webkit [190727] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: An error view doesn't get expanded by clicking on the expand arrow
https://bugs.webkit.org/show_bug.cgi?id=149917
Reviewed by Timothy Hatcher.
- UserInterface/Views/ErrorObjectView.css:
(.error-object > .formatted-error::before):
(.error-object.expanded > .formatted-error::before):
(.error-object::before): Deleted.
(.error-object.expanded::before): Deleted.
- 8:29 AM Changeset in webkit [190726] by
-
- 2 edits in trunk/Source/WebKit2
Format string issues in NetworkCache.cpp
https://bugs.webkit.org/show_bug.cgi?id=149867
Reviewed by Csaba Osztrogonác.
Cast enums to ints before printing them to placate GCC's -Wformat.
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::retrieve):
(WebKit::NetworkCache::Cache::store):
- 8:27 AM Changeset in webkit [190725] by
-
- 2 edits in trunk/Source/WebCore
Format string issues in LegacyRequest.cpp
https://bugs.webkit.org/show_bug.cgi?id=149866
Reviewed by Csaba Osztrogonác.
Cast enums to ints before printing them to placate GCC's -Wformat.
- Modules/indexeddb/legacy/LegacyRequest.cpp:
(WebCore::LegacyRequest::dispatchEvent):
(WebCore::LegacyRequest::enqueueEvent):
- 8:27 AM Changeset in webkit [190724] by
-
- 2 edits in trunk/Source/WebKit2
Format string issue in WebResourceLoadScheduler.cpp
https://bugs.webkit.org/show_bug.cgi?id=149868
Reviewed by Csaba Osztrogonác.
Cast enums to ints before printing them to placate GCC's -Wformat.
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad):
- 8:23 AM Changeset in webkit [190723] by
-
- 18 edits1 copy1 delete in trunk/Source
Unreviewed, rolling out r190716.
https://bugs.webkit.org/show_bug.cgi?id=149924
broke mac build from time to time (Requested by youenn on
#webkit).
Reverted changeset:
"Automate WebCore JS builtins generation and build system"
https://bugs.webkit.org/show_bug.cgi?id=149751
http://trac.webkit.org/changeset/190716
- 8:20 AM Changeset in webkit [190722] by
-
- 5 edits in trunk/Source/JavaScriptCore
Fix the WASM build on Linux
https://bugs.webkit.org/show_bug.cgi?id=149919
Reviewed by Mark Lam.
- inspector/ScriptCallStackFactory.cpp:
- wasm/JSWASMModule.cpp:
- wasm/WASMFunctionCompiler.h:
(JSC::sizeOfMemoryType):
- wasm/WASMFunctionLLVMIRGenerator.h:
- 6:28 AM Changeset in webkit [190721] by
-
- 2 edits in trunk/Source/WebCore
[css-grid] Percentages of indefinite sizes to be resolved as auto
https://bugs.webkit.org/show_bug.cgi?id=149810
Reviewed by Darin Adler.
Specs mention that percentages in grid track sizes must be
resolved as 'auto' if the grid container has an indefinite
size in the corresponding axis.
The 'auto' keyword used to be resolved as
minmax(min-content,max-content) but since r189911 it's
resolved as minmax(auto,auto). Updated the implementation so
we properly resolve those percentages.
No new tests as the behavior does not change at all. That's
because 'auto' as min-track sizing function is the same as
min-content (unless we have a specified value for
min-{width|height}, but those cases were already handled in the
code), and as a max sizing function is works as max-content.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::gridTrackSize):
- 5:43 AM CommitQueue edited by
- Updated commit queue status URL (diff)
- 5:26 AM Changeset in webkit [190720] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed CLOOP buildfix after r190718.
- jit/Repatch.h:
(JSC::resetGetByID): Deleted.
(JSC::resetPutByID): Deleted.
(JSC::resetIn): Deleted.
- 3:37 AM Changeset in webkit [190719] by
-
- 2 edits in trunk/Source/WTF
Remove PageReservation.h clang fixme that has been fixed for a while
https://bugs.webkit.org/show_bug.cgi?id=149908
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-08
Reviewed by Csaba Osztrogonác.
- wtf/PageReservation.h:
(WTF::PageReservation::operator bool): Deleted.
- 3:33 AM Changeset in webkit [190718] by
-
- 11 edits in trunk/Source/JavaScriptCore
Remove references to removed class RepatchBuffer
https://bugs.webkit.org/show_bug.cgi?id=149909
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-08
Reviewed by Csaba Osztrogonác.
- assembler/AbstractMacroAssembler.h:
- assembler/MacroAssemblerARM.h:
- assembler/MacroAssemblerARM64.h:
- assembler/MacroAssemblerARMv7.h:
- assembler/MacroAssemblerMIPS.h:
- assembler/MacroAssemblerSH4.h:
- assembler/MacroAssemblerX86.h:
- assembler/MacroAssemblerX86_64.h:
- jit/JITStubRoutine.h:
- jit/Repatch.h:
- 3:06 AM Changeset in webkit [190717] by
-
- 5 edits in trunk
[GTK] Stop using a nested main loop for popup menus
https://bugs.webkit.org/show_bug.cgi?id=149920
Reviewed by Sergio Villar Senin.
Source/WebKit2:
WebPageProxy used to expect the popup menus to run in a nested
main loop and invalidated the menu right after showing it. But
this is no longer the case, so there's no reason to keep using
the nested main loop.
- UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
(WebKit::WebPopupMenuProxyGtk::~WebPopupMenuProxyGtk):
(WebKit::WebPopupMenuProxyGtk::cancelTracking):
(WebKit::WebPopupMenuProxyGtk::menuItemActivated):
(WebKit::WebPopupMenuProxyGtk::WebPopupMenuProxyGtk): Deleted.
(WebKit::WebPopupMenuProxyGtk::showPopupMenu): Deleted.
(WebKit::WebPopupMenuProxyGtk::shutdownRunLoop): Deleted.
(WebKit::WebPopupMenuProxyGtk::menuUnmapped): Deleted.
- UIProcess/gtk/WebPopupMenuProxyGtk.h:
(WebKit::WebPopupMenuProxyGtk::setActiveItem): Deleted.
LayoutTests:
Unskip platform/gtk/fast/forms/menulist-typeahead-find.html that
was timing out because of the nested main loop.
- platform/gtk/TestExpectations:
- 2:55 AM Changeset in webkit [190716] by
-
- 18 edits1 add1 delete in trunk/Source
Automate WebCore JS builtins generation and build system
https://bugs.webkit.org/show_bug.cgi?id=149751
Reviewed by Darin Adler.
Source/JavaScriptCore:
- generate-js-builtins: updating the part related to WebCore JS binding.
Source/WebCore:
Adding annotations to JS files to know whether they should be under a compilation flag and
whether they are JS internals or JS tied to WebIDL.
If a file is said as JS internals, all function names are exported automatically.
Added auto generation of WebCoreJSBuiltins.cpp
Added auto generation of JSBuiltinFunctions class inside WebCoreJSBuiltins that takes the role of
WebCoreJSClientData as wrapper for builtins.
Added auto generation of WebCoreJSBuiltinInternals.h which contain a wrapper around all private functions, used by
JSDOMWindowBase. The class is named JSBuiltinInternalFunctions.
Renamed WebCoreJSClientData to JSVMClientData.
The remaining manual part for private functions is the pairing between private identifiers and
the private JS functions within JSDOMWindowBase::finishCreation.
Covered by existing tests.
- CMakeLists.txt:
- DerivedSources.make:
- Modules/streams/ByteLengthQueuingStrategy.js:
- Modules/streams/CountQueuingStrategy.js:
- Modules/streams/ReadableStream.js:
- Modules/streams/ReadableStreamInternals.js:
- WebCore.order:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::normalWorld):
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::finishCreation):
(WebCore::JSDOMWindowBase::visitChildren):
(WebCore::JSDOMWindowBase::fireFrameClearedWatchpointsForWindow):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::getAllWorlds):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::transferArrayBuffers):
- bindings/js/WebCoreJSClientData.h:
(WebCore::JSClientData::JSClientData):
(WebCore::JSClientData::~JSClientData):
(WebCore::JSClientData::builtinFunctions):
(WebCore::initNormalWorldClientData):
(WebCore::WebCoreJSClientData::WebCoreJSClientData): Deleted.
(WebCore::WebCoreJSClientData::~WebCoreJSClientData): Deleted.
(WebCore::WebCoreJSClientData::readableStreamBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamControllerBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamInternalsBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamReaderBuiltins): Deleted.
(WebCore::WebCoreJSClientData::byteLengthQueuingStrategyBuiltins): Deleted.
(WebCore::WebCoreJSClientData::countQueuingStrategyBuiltins): Deleted.
- generate-js-builtins-allinone: Added.
(retrieveGenerationParameters):
(retrieveFilesWithParameters):
(retrieveFilesWithParameters.FileInput):
(writeConditional):
(JSBuiltinFunctions):
(Private):
(JSBuiltinInternalFunctions):
(copytempfile):
- 12:33 AM Changeset in webkit [190715] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Mark several inspector tests as slow.
- platform/gtk/TestExpectations:
- 12:30 AM Changeset in webkit [190714] by
-
- 53 edits in trunk/Source/WebCore
Binding generated JS constructors should use GlobalObject references
https://bugs.webkit.org/show_bug.cgi?id=149872
Reviewed by Darin Adler.
Updated binding generator to generate JS DOM constructors code with JSDOMGlobalOBject references.
Updated WebCore JS binding layer accordingly.
Covered by updated binding tests.
- bindings/js/DOMConstructorWithDocument.h:
(WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
(WebCore::DOMConstructorWithDocument::finishCreation):
- bindings/js/JSDOMBinding.cpp:
(WebCore::getCachedDOMStructure):
(WebCore::cacheDOMStructure):
- bindings/js/JSDOMBinding.h:
(WebCore::DOMConstructorObject::DOMConstructorObject):
(WebCore::DOMConstructorJSBuiltinObject::DOMConstructorJSBuiltinObject):
(WebCore::getDOMStructure):
(WebCore::deprecatedGetDOMStructure):
(WebCore::getDOMPrototype):
(WebCore::createJSBuiltin):
(WebCore::createWrapper):
- bindings/js/JSDOMConstructor.h:
(WebCore::JSBuiltinConstructor::JSBuiltinConstructor):
- bindings/js/JSDOMGlobalObject.h:
(WebCore::getDOMConstructor):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::image):
(WebCore::JSDOMWindow::touch):
(WebCore::JSDOMWindow::touchList):
- bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapper::JSDOMWrapper):
(WebCore::JSDOMWrapperWithImplementation::JSDOMWrapperWithImplementation):
- bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::JSImageConstructor):
(WebCore::JSImageConstructor::finishCreation):
- bindings/js/JSImageConstructor.h:
(WebCore::JSImageConstructor::create):
(WebCore::JSImageConstructor::createStructure):
- bindings/js/JSReadableStreamPrivateConstructors.cpp:
(WebCore::JSBuiltinReadableStreamReaderPrivateConstructor::createJSObject):
(WebCore::JSBuiltinReadableStreamControllerPrivateConstructor::createJSObject):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateCallbackImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectConstructor::create):
(WebCore::JSTestActiveDOMObjectConstructor::createStructure):
(WebCore::JSTestActiveDOMObjectConstructor::JSTestActiveDOMObjectConstructor):
(WebCore::JSTestActiveDOMObjectConstructor::finishCreation):
(WebCore::JSTestActiveDOMObject::JSTestActiveDOMObject):
(WebCore::JSTestActiveDOMObject::getConstructor):
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
(WebCore::JSTestActiveDOMObject::create):
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallbackConstructor::create):
(WebCore::JSTestCallbackConstructor::createStructure):
(WebCore::JSTestCallbackConstructor::JSTestCallbackConstructor):
(WebCore::JSTestCallback::getConstructor):
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::create):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::createStructure):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::JSTestCustomConstructorWithNoInterfaceObjectConstructor):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::finishCreation):
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::JSTestCustomConstructorWithNoInterfaceObject):
(WebCore::jsTestCustomConstructorWithNoInterfaceObjectConstructor):
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.h:
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::create):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterConstructor::create):
(WebCore::JSTestCustomNamedGetterConstructor::createStructure):
(WebCore::JSTestCustomNamedGetterConstructor::JSTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::getConstructor):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
(WebCore::JSTestCustomNamedGetter::create):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::create):
(WebCore::JSTestEventConstructorConstructor::createStructure):
(WebCore::JSTestEventConstructorConstructor::JSTestEventConstructorConstructor):
(WebCore::JSTestEventConstructorConstructor::finishCreation):
(WebCore::JSTestEventConstructor::JSTestEventConstructor):
(WebCore::JSTestEventConstructor::getConstructor):
- bindings/scripts/test/JS/JSTestEventConstructor.h:
(WebCore::JSTestEventConstructor::create):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetConstructor::create):
(WebCore::JSTestEventTargetConstructor::createStructure):
(WebCore::JSTestEventTargetConstructor::JSTestEventTargetConstructor):
(WebCore::JSTestEventTargetConstructor::finishCreation):
(WebCore::JSTestEventTarget::JSTestEventTarget):
(WebCore::JSTestEventTarget::getConstructor):
- bindings/scripts/test/JS/JSTestEventTarget.h:
(WebCore::JSTestEventTarget::create):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionConstructor::create):
(WebCore::JSTestExceptionConstructor::createStructure):
(WebCore::JSTestExceptionConstructor::JSTestExceptionConstructor):
(WebCore::JSTestExceptionConstructor::finishCreation):
(WebCore::JSTestException::JSTestException):
(WebCore::JSTestException::getConstructor):
- bindings/scripts/test/JS/JSTestException.h:
(WebCore::JSTestException::create):
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::JSTestGenerateIsReachableConstructor::create):
(WebCore::JSTestGenerateIsReachableConstructor::createStructure):
(WebCore::JSTestGenerateIsReachableConstructor::JSTestGenerateIsReachableConstructor):
(WebCore::JSTestGenerateIsReachableConstructor::finishCreation):
(WebCore::JSTestGenerateIsReachable::JSTestGenerateIsReachable):
(WebCore::JSTestGenerateIsReachable::getConstructor):
- bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
(WebCore::JSTestGenerateIsReachable::create):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterfaceConstructor::createStructure):
(WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):
(WebCore::JSTestInterfaceConstructor::finishCreation):
(WebCore::JSTestInterface::JSTestInterface):
(WebCore::JSTestInterface::getConstructor):
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::JSTestJSBuiltinConstructorConstructor::create):
(WebCore::JSTestJSBuiltinConstructorConstructor::createStructure):
(WebCore::JSTestJSBuiltinConstructorConstructor::JSTestJSBuiltinConstructorConstructor):
(WebCore::JSTestJSBuiltinConstructorConstructor::finishCreation):
(WebCore::JSTestJSBuiltinConstructor::JSTestJSBuiltinConstructor):
(WebCore::JSTestJSBuiltinConstructor::getConstructor):
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h:
(WebCore::JSTestJSBuiltinConstructor::create):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListenerConstructor::createStructure):
(WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor):
(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):
(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
(WebCore::JSTestMediaQueryListListener::getConstructor):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListener::create):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorConstructor::create):
(WebCore::JSTestNamedConstructorConstructor::createStructure):
(WebCore::JSTestNamedConstructorNamedConstructor::create):
(WebCore::JSTestNamedConstructorNamedConstructor::createStructure):
(WebCore::JSTestNamedConstructorConstructor::JSTestNamedConstructorConstructor):
(WebCore::JSTestNamedConstructorConstructor::finishCreation):
(WebCore::JSTestNamedConstructorNamedConstructor::JSTestNamedConstructorNamedConstructor):
(WebCore::JSTestNamedConstructorNamedConstructor::finishCreation):
(WebCore::JSTestNamedConstructor::JSTestNamedConstructor):
(WebCore::JSTestNamedConstructor::getConstructor):
(WebCore::JSTestNamedConstructor::getNamedConstructor):
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
(WebCore::JSTestNamedConstructor::create):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::create):
(WebCore::JSTestNodeConstructor::createStructure):
(WebCore::JSTestNodeConstructor::JSTestNodeConstructor):
(WebCore::JSTestNodeConstructor::finishCreation):
(WebCore::JSTestNode::JSTestNode):
(WebCore::JSTestNode::getConstructor):
- bindings/scripts/test/JS/JSTestNode.h:
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::JSTestNondeterministicConstructor::create):
(WebCore::JSTestNondeterministicConstructor::createStructure):
(WebCore::JSTestNondeterministicConstructor::JSTestNondeterministicConstructor):
(WebCore::JSTestNondeterministicConstructor::finishCreation):
(WebCore::JSTestNondeterministic::JSTestNondeterministic):
(WebCore::JSTestNondeterministic::getConstructor):
- bindings/scripts/test/JS/JSTestNondeterministic.h:
(WebCore::JSTestNondeterministic::create):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObjConstructor::createStructure):
(WebCore::JSTestObjConstructor::JSTestObjConstructor):
(WebCore::JSTestObjConstructor::finishCreation):
(WebCore::JSTestObj::JSTestObj):
(WebCore::JSTestObj::getConstructor):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObj::create):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::create):
(WebCore::JSTestOverloadedConstructorsConstructor::createStructure):
(WebCore::JSTestOverloadedConstructorsConstructor::JSTestOverloadedConstructorsConstructor):
(WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):
(WebCore::JSTestOverloadedConstructors::JSTestOverloadedConstructors):
(WebCore::JSTestOverloadedConstructors::getConstructor):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
(WebCore::JSTestOverloadedConstructors::create):
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::JSTestOverrideBuiltinsConstructor::create):
(WebCore::JSTestOverrideBuiltinsConstructor::createStructure):
(WebCore::JSTestOverrideBuiltinsConstructor::JSTestOverrideBuiltinsConstructor):
(WebCore::JSTestOverrideBuiltinsConstructor::finishCreation):
(WebCore::JSTestOverrideBuiltins::JSTestOverrideBuiltins):
(WebCore::JSTestOverrideBuiltins::getConstructor):
- bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
(WebCore::JSTestOverrideBuiltins::create):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterface::getConstructor):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterface::create):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::create):
(WebCore::JSTestTypedefsConstructor::createStructure):
(WebCore::JSTestTypedefsConstructor::JSTestTypedefsConstructor):
(WebCore::JSTestTypedefsConstructor::finishCreation):
(WebCore::JSTestTypedefs::JSTestTypedefs):
(WebCore::JSTestTypedefs::getConstructor):
- bindings/scripts/test/JS/JSTestTypedefs.h:
(WebCore::JSTestTypedefs::create):
- bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::JSattributeConstructor::create):
(WebCore::JSattributeConstructor::createStructure):
(WebCore::JSattributeConstructor::JSattributeConstructor):
(WebCore::JSattributeConstructor::finishCreation):
(WebCore::JSattribute::JSattribute):
(WebCore::JSattribute::getConstructor):
- bindings/scripts/test/JS/JSattribute.h:
(WebCore::JSattribute::create):
- bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::JSreadonlyConstructor::create):
(WebCore::JSreadonlyConstructor::createStructure):
(WebCore::JSreadonlyConstructor::JSreadonlyConstructor):
(WebCore::JSreadonlyConstructor::finishCreation):
(WebCore::JSreadonly::JSreadonly):
(WebCore::JSreadonly::getConstructor):
- bindings/scripts/test/JS/JSreadonly.h:
(WebCore::JSreadonly::create):
- 12:21 AM Changeset in webkit [190713] by
-
- 2 edits in trunk/Source/WebCore
WebRTC: Add event names needed by updated RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=149875
Patch by Philippe Normand <pnormand@igalia.com> on 2015-10-08
Reviewed by Eric Carlson.
The track event name was recently added in the WebRTC spec. The
icegatheringstatechange event has been part of the spec for a while but
was not registered in our DOM events.
- dom/EventNames.h: Add track and icegatheringstatechange even names.
- 12:19 AM Changeset in webkit [190712] by
-
- 8 edits in tags/Safari-602.1.6/Source/JavaScriptCore
Merged r190699. rdar://problem/22998598
- 12:18 AM Changeset in webkit [190711] by
-
- 2 edits in tags/Safari-602.1.6/LayoutTests
Merged r190695. rdar://problem/22998598
- 12:17 AM Changeset in webkit [190710] by
-
- 2 edits in tags/Safari-602.1.6/Source/JavaScriptCore
Merged r190692. rdar://problem/22998598
Oct 7, 2015:
- 11:44 PM Changeset in webkit [190709] by
-
- 3 edits in tags/Safari-601.2.7.2.1/Source/WebKit/win
Merge patch for rdar://problem/23025615.
- 11:39 PM Changeset in webkit [190708] by
-
- 1 copy in tags/Safari-602.1.6
New tag.
- 11:38 PM Changeset in webkit [190707] by
-
- 5 edits in tags/Safari-601.2.7.2.1/Source
Versioning.
- 11:36 PM Changeset in webkit [190706] by
-
- 1 copy in tags/Safari-601.2.7.2.1
New tag.
- 8:48 PM Changeset in webkit [190705] by
-
- 16 edits in trunk/Source/JavaScriptCore
Clean up Copied classes
https://bugs.webkit.org/show_bug.cgi?id=149863
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-07
Reviewed by Saam Barati.
- heap/CopiedAllocator.h:
(JSC::CopiedAllocator::isValid):
- heap/CopiedBlock.h:
- heap/CopiedBlockInlines.h:
- heap/CopiedSpace.cpp:
- heap/CopiedSpace.h:
(JSC::CopiedSpace::isInCopyPhase):
(JSC::CopiedSpace::shouldDoCopyPhase):
- heap/CopiedSpaceInlines.h:
- heap/CopyToken.h:
- heap/CopyVisitor.cpp:
- heap/CopyVisitor.h:
- heap/CopyVisitorInlines.h:
- heap/CopyWorkList.h:
- heap/HandleBlock.h:
- heap/HandleSet.h:
- heap/HeapHelperPool.cpp:
- heap/HeapHelperPool.h:
- 8:12 PM Changeset in webkit [190704] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Unreviewed race condition fix. Exit early when xScale or yScale is not defined.
- public/v2/interactive-chart.js:
(App.InteractiveChartComponent._updateRangeBarRects):
- 7:26 PM Changeset in webkit [190703] by
-
- 6 edits2 adds2 deletes in trunk
script.text shouldn't include text from non-direct children of the script element
https://bugs.webkit.org/show_bug.cgi?id=148851
<rdar://problem/22587759>
Patch by Keith Rollin <Keith Rollin> on 2015-10-07
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Rebaseline several W3C HTML tests now that new checks are passing.
- web-platform-tests/html/semantics/scripting-1/the-script-element/script-text-expected.txt:
- web-platform-tests/html/semantics/scripting-1/the-script-element/script-text-xhtml-expected.txt:
Source/WebCore:
Don't include text from non-direct children in script.text. Per:
https://html.spec.whatwg.org/multipage/scripting.html#dom-script-text
Chrome and Firefox behavior match the spec.
Test: fast/dom/script-subtext-in-script-elements.html
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::scriptContent):
LayoutTests:
script-getElementById-during-insertion removed because it no longer
runs correctly with this change.
- fast/dom/script-getElementById-during-insertion-expected.txt: Removed.
- fast/dom/script-getElementById-during-insertion.html: Removed.
- fast/dom/script-subtext-in-script-elements-expected.txt: Added.
- fast/dom/script-subtext-in-script-elements.html: Added.
- 7:06 PM Changeset in webkit [190702] by
-
- 1 edit1 add in trunk/Websites/perf.webkit.org
Add a page that cycles through v2 dashboards
https://bugs.webkit.org/show_bug.cgi?id=149907
Reviewed by Chris Dumez.
Add cycler.html that goes through each dashboard on v2 UI.
This allows the dashboards to be cycled through on a TV screen.
- public/cycler.html: Added.
(loadURLAt): Appends a new iframe to load the next URL (i is the index of the dashboard to be shown)
at the end of body. We don't immediately show the new iframe since it might take a while to load.
(showNewFrameIfLoaded): Remove the current iframe and show the next iframe if the next dashboard has
finished loading. We can't rely on DOMContentLoaded or load events because we use asynchronous XHR to
load each chart's data. Instead, wait until some chart becomes available or fails to load and none of
charts are still in progress to be shown.
- 7:06 PM Changeset in webkit [190701] by
-
- 2 edits in trunk/Source/WebCore
Partial revert of r187626 as it caused a PLT regression
https://bugs.webkit.org/show_bug.cgi?id=149898
Reviewed by Myles C. Maxfield.
Do a partial revert of r187626 as it caused a regression on PLT.
- platform/graphics/FontCache.h:
(WebCore::FontDescriptionKey::operator==):
(WebCore::FontDescriptionKey::FontDescriptionKey): Deleted.
(WebCore::FontDescriptionKey::computeHash): Deleted.
- 5:55 PM Changeset in webkit [190700] by
-
- 3 edits in trunk/LayoutTests
Test font-variant-* and font-feature-settings with TrueType fonts
https://bugs.webkit.org/show_bug.cgi?id=149776
Unreviewed follow up to r190697.
- css3/font-variant-all-webfont-expected.html:
- css3/font-variant-all-webfont.html:
- 5:47 PM Changeset in webkit [190699] by
-
- 8 edits in trunk/Source/JavaScriptCore
[Follow up 2] Disable tail calls because it is breaking some sites.
https://bugs.webkit.org/show_bug.cgi?id=149900
Rubber stamped by Saam Barati.
Also need to surpress JSC tail call tests.
- tests/es6.yaml:
- tests/stress/dfg-tail-calls.js:
(nonInlinedTailCall.callee):
- tests/stress/mutual-tail-call-no-stack-overflow.js:
(shouldThrow):
- tests/stress/tail-call-in-inline-cache.js:
(tail):
- tests/stress/tail-call-no-stack-overflow.js:
(shouldThrow):
- tests/stress/tail-call-recognize.js:
(callerMustBeRun):
- tests/stress/tail-call-varargs-no-stack-overflow.js:
(shouldThrow):
- 5:35 PM Changeset in webkit [190698] by
-
- 6 edits in trunk/Tools
[Win] Support 64-bit Build and Testing
https://bugs.webkit.org/show_bug.cgi?id=149904
Reviewed by Daniel Bates.
Extend our existing scripts to support 64-bit build and test operations on
Windows.
- Scripts/build-dumprendertree: We don't need to build DRT on its own;
Windows always builds the whole stack.
- Scripts/webkit-build-directory: Add an option to return the location of
the executable files produced by a specific configuration. This change is
actually useful for Gtk and EFL, too.
- Scripts/webkitdirs.pm:
(executableProductDir): Added. This function appends the proper binary
path to the productDir. This is useful for Windows, Gtk, and EFL ports.
(jscProductDir): Use the new 'executableProductDir' method.
(setPathForRunningWebKitApp): Ditto.
(runSafari): Ditto.
(runMiniBrowser): Ditto.
- Scripts/webkitpy/port/factory.py:
(configuration_options): Add a 64-bit option, used on Windows to specify
which binary target should be used for testing.
- Scripts/webkitpy/port/win.py:
(WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
processes when needed.
(WinPort._build_path): Add the correct binary target path to _build_path.
(WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
64-bit paths for 64-bit tests.
(WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
NTSD debugger does not understand this argument.
- 5:33 PM Changeset in webkit [190697] by
-
- 8 edits1 add in trunk
Test font-variant-* and font-feature-settings with TrueType fonts
https://bugs.webkit.org/show_bug.cgi?id=149776
Reviewed by Simon Fraser.
Tools:
This test extends our existing FontWithFeatures project to be able to generate a
TrueType font. This font is conceptually similar as the existing OpenType font,
except the feature -> character mapping is different.
The font itself only supports the following characters:
ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
However, the shape of these letters are either an X or a check mark.
The letter "A" always is a check mark.
The letter "B" always is an X.
Each font feature has an letter associated with it. When the font feature is enabled,
that letter is shown as a check mark. For example, when
"kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
mark.
Here are the mappings of font features to letters:
kLigaturesType / kCommonLigaturesOnSelector: C
kLigaturesType / kContextualLigaturesOnSelector: D
kLigaturesType / kRareLigaturesOnSelector: G
kLigaturesType / kHistoricalLigaturesOnSelector: I
kContextualAlternatesType / kContextualAlternatesOnSelector: L
kVerticalPositionType / kInferiorsSelector: O
kVerticalPositionType / kSuperiorsSelector: P
kLowerCaseType / kLowerCaseSmallCapsSelector: S
kUpperCaseType / kUpperCaseSmallCapsSelector: V
kLowerCaseType / kLowerCasePetiteCapsSelector: T
kUpperCaseType / kUpperCasePetiteCapsSelector: W
kLetterCaseType / 14: Y
kStyleOptionsType / kTitlingCapsSelector: a
kNumberCaseType / kUpperCaseNumbersSelector: c
kNumberCaseType / kLowerCaseNumbersSelector: d
kNumberSpacingType / kProportionalNumbersSelector: f
kNumberSpacingType / kMonospacedNumbersSelector: g
kFractionsType / kDiagonalFractionsSelector: i
kFractionsType / kVerticalFractionsSelector: j
kVerticalPositionType / kOrdinalsSelector: Q
kTypographicExtrasType / kSlashedZeroOnSelector: k
kLigaturesType / kHistoricalLigaturesOnSelector: K
kCharacterShapeType / kJIS1978CharactersSelector: m
kCharacterShapeType / kJIS1983CharactersSelector: n
kCharacterShapeType / kJIS1990CharactersSelector: o
kCharacterShapeType / kJIS2004CharactersSelector: p
kCharacterShapeType / kSimplifiedCharactersSelector: q
kCharacterShapeType / kTraditionalCharactersSelector: r
kTextSpacingType / kMonospacedTextSelector: t
kTextSpacingType / kProportionalTextSelector: u
kRubyKanaType / kRubyKanaOnSelector: v
- FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
- FontWithFeatures/FontWithFeatures/FontCreator.cpp:
(CFFBuilder::moveTo):
(CFFBuilder::lineTo):
(GLYFBuilder::GLYFBuilder):
(GLYFBuilder::takeResult):
(GLYFBuilder::moveTo):
(GLYFBuilder::lineTo):
(GLYFBuilder::closePath):
(GLYFBuilder::writePoint):
(GLYFBuilder::append16):
(generateBoxCharString):
(generateCheckCharString):
(generateXCharString):
(itemForGlyph):
(Generator::generate):
(Generator::insertSelector):
(Generator::insertFeature):
(Generator::generateFeatureDescription):
(Generator::appendCFFTable):
(Generator::appendGLYFTable):
(Generator::appendLOCATable):
(Generator::appendFEATTable):
(Generator::appendMetamorphosisChain):
(Generator::appendMORXTable):
(Generator::appendHEADTable):
(Generator::appendHMTXTable):
(Generator::appendNameSubtable):
(Generator::append2ByteASCIIString):
(Generator::appendNAMETable):
(generateFont):
(CFFBuilder::curveToCubic): Deleted.
(charStringForGlyph): Deleted.
- FontWithFeatures/FontWithFeatures/FontCreator.h:
- FontWithFeatures/FontWithFeatures/main.cpp:
(constructFontWithTrueTypeFeature):
(constructFontWithOpenTypeFeature):
(drawText):
(main):
(drawTextWithFeature): Deleted.
LayoutTests:
- css3/font-feature-settings-rendering-2-expected.html:
- css3/font-feature-settings-rendering-2.html:
- css3/resources/FontWithFeatures.ttf: Added.
- 5:17 PM Changeset in webkit [190696] by
-
- 4 edits in trunk/Websites/perf.webkit.org
Allow custom revisions to be specified in A/B testing
https://bugs.webkit.org/show_bug.cgi?id=149905
Reviewed by Chris Dumez.
Allow custom revision number on each "repository" when creating a test group.
- public/v2/app.css:
(form .analysis-group [name=customValue]): Added.
- public/v2/app.js:
(App.AnalysisTaskController._createConfiguration): Added "Custom" as a revision option.
Also added point labels such as (point 3) on "None" for when some points are missing revision info.
(App.AnalysisTaskController._labelForPoints): Extracted from _createConfiguration.
(App.AnalysisTaskController.actions.createTestGroup): Respect the custom revision number when custom
revision option is selected.
- public/v2/index.html: Added a text field for specifying a custom revision number.
- 4:34 PM Changeset in webkit [190695] by
-
- 2 edits in trunk/LayoutTests
Disable tail calls because it is breaking some sites.
https://bugs.webkit.org/show_bug.cgi?id=149900
Reviewed by Saam Barati.
Updating the expected test result because we disabled tail calls.
- js/caller-property-expected.txt:
- 4:10 PM Changeset in webkit [190694] by
-
- 57 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling back in r190450
https://bugs.webkit.org/show_bug.cgi?id=149727
This time for sure?
The cause of the leak was an invalidated compilation.
There was vestigial manual memory management code that eagerly removed
a CodeBlock from the set of CodeBlocks if compilation was invalidated.
That's not cool since we rely on the set of CodeBlocks when we run
destructors.
The fix is to remove the vestigial code.
I ran the leaks, correctness, and performance tests locally and did not
see any problems.
Restored changesets:
"CodeBlock should be a GC object"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190450
- 3:56 PM Changeset in webkit [190693] by
-
- 3 edits in trunk/Source/WebKit2
Add API for getting a group identifier from a bundle page
https://bugs.webkit.org/show_bug.cgi?id=149902
Reviewed by Tim Horton.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCopyGroupIdentifier):
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- 3:09 PM Changeset in webkit [190692] by
-
- 2 edits in trunk/Source/JavaScriptCore
Disable tail calls because it is breaking some sites.
https://bugs.webkit.org/show_bug.cgi?id=149900
Reviewed by Saam Barati.
This is until we fix whatever the breakage is.
- runtime/Options.h:
- 3:05 PM Changeset in webkit [190691] by
-
- 3 edits in trunk/Source/WebKit2
URTBF after r190678 to fix GTK and EFL builds.
- WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:
(WebKit::InjectedBundle::setBundleParameters):
- WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
(WebKit::InjectedBundle::setBundleParameters):
- 2:57 PM Changeset in webkit [190690] by
-
- 5 edits1 add in trunk/Source/JavaScriptCore
Add an LLVM IR generator for WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=149486
Reviewed by Mark Lam.
This patch adds initial support for an LLVM IR generator in WebAssembly
(polyfill-prototype-1 format). All the methods will be implemented in
subsequent patches.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- wasm/WASMFunctionLLVMIRGenerator.h: Added.
(JSC::WASMFunctionLLVMIRGenerator::MemoryAddress::MemoryAddress):
(JSC::WASMFunctionLLVMIRGenerator::startFunction):
(JSC::WASMFunctionLLVMIRGenerator::endFunction):
(JSC::WASMFunctionLLVMIRGenerator::buildSetLocal):
(JSC::WASMFunctionLLVMIRGenerator::buildSetGlobal):
(JSC::WASMFunctionLLVMIRGenerator::buildReturn):
(JSC::WASMFunctionLLVMIRGenerator::buildImmediateI32):
(JSC::WASMFunctionLLVMIRGenerator::buildImmediateF32):
(JSC::WASMFunctionLLVMIRGenerator::buildImmediateF64):
(JSC::WASMFunctionLLVMIRGenerator::buildGetLocal):
(JSC::WASMFunctionLLVMIRGenerator::buildGetGlobal):
(JSC::WASMFunctionLLVMIRGenerator::buildConvertType):
(JSC::WASMFunctionLLVMIRGenerator::buildLoad):
(JSC::WASMFunctionLLVMIRGenerator::buildStore):
(JSC::WASMFunctionLLVMIRGenerator::buildUnaryI32):
(JSC::WASMFunctionLLVMIRGenerator::buildUnaryF32):
(JSC::WASMFunctionLLVMIRGenerator::buildUnaryF64):
(JSC::WASMFunctionLLVMIRGenerator::buildBinaryI32):
(JSC::WASMFunctionLLVMIRGenerator::buildBinaryF32):
(JSC::WASMFunctionLLVMIRGenerator::buildBinaryF64):
(JSC::WASMFunctionLLVMIRGenerator::buildRelationalI32):
(JSC::WASMFunctionLLVMIRGenerator::buildRelationalF32):
(JSC::WASMFunctionLLVMIRGenerator::buildRelationalF64):
(JSC::WASMFunctionLLVMIRGenerator::buildMinOrMaxI32):
(JSC::WASMFunctionLLVMIRGenerator::buildMinOrMaxF64):
(JSC::WASMFunctionLLVMIRGenerator::buildCallInternal):
(JSC::WASMFunctionLLVMIRGenerator::buildCallIndirect):
(JSC::WASMFunctionLLVMIRGenerator::buildCallImport):
(JSC::WASMFunctionLLVMIRGenerator::appendExpressionList):
(JSC::WASMFunctionLLVMIRGenerator::discard):
(JSC::WASMFunctionLLVMIRGenerator::linkTarget):
(JSC::WASMFunctionLLVMIRGenerator::jumpToTarget):
(JSC::WASMFunctionLLVMIRGenerator::jumpToTargetIf):
(JSC::WASMFunctionLLVMIRGenerator::startLoop):
(JSC::WASMFunctionLLVMIRGenerator::endLoop):
(JSC::WASMFunctionLLVMIRGenerator::startSwitch):
(JSC::WASMFunctionLLVMIRGenerator::endSwitch):
(JSC::WASMFunctionLLVMIRGenerator::startLabel):
(JSC::WASMFunctionLLVMIRGenerator::endLabel):
(JSC::WASMFunctionLLVMIRGenerator::breakTarget):
(JSC::WASMFunctionLLVMIRGenerator::continueTarget):
(JSC::WASMFunctionLLVMIRGenerator::breakLabelTarget):
(JSC::WASMFunctionLLVMIRGenerator::continueLabelTarget):
(JSC::WASMFunctionLLVMIRGenerator::buildSwitch):
- wasm/WASMFunctionParser.cpp:
- 2:34 PM Changeset in webkit [190689] by
-
- 9 edits1 delete in trunk
Unreviewed, rolling out r190572, r190593, r190594, and
r190639.
https://bugs.webkit.org/show_bug.cgi?id=149897
Breaks Mavericks build (Requested by litherum on #webkit).
Reverted changesets:
"Allow WKRetainPtrs to be used as keys in hashing data
structures"
https://bugs.webkit.org/show_bug.cgi?id=149762
http://trac.webkit.org/changeset/190572
"REGRESSION(189668?): http/tests/notifications/events.html
flakily asserts or times out"
https://bugs.webkit.org/show_bug.cgi?id=149218
http://trac.webkit.org/changeset/190593
"Prospective Mavericks build fix."
http://trac.webkit.org/changeset/190594
"Post-review cleanup after r190572."
http://trac.webkit.org/changeset/190639
- 2:25 PM Changeset in webkit [190688] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, more Mac test gardening after r190629.
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 2:24 PM Changeset in webkit [190687] by
-
- 6 edits in trunk/Websites/perf.webkit.org
Make the site name configurable in perf dashboard
https://bugs.webkit.org/show_bug.cgi?id=149894
Reviewed by Chris Dumez.
Added "siteTitle" as a new configuration key to specify the site name.
- public/include/db.php:
(config): Now takes the default value as an argument.
- public/include/manifest.php:
(ManifestGenerator::generate): Include siteTitle in the manifest.
- public/index.html: Update the title and the heading when the manifest is loaded.
- public/v2/index.html: Use App.Manifest.siteTitle as the heading. document.title needs to be updated manually.
- public/v2/manifest.js:
(App.MetricSerializer.normalizePayload): Update document.title and App.Manifest.siteTitle.
- 2:19 PM Changeset in webkit [190686] by
-
- 3 edits in trunk/Source/WebKit2
Provide a way to get a WKFrameInfoRef from a WKFrameRef
https://bugs.webkit.org/show_bug.cgi?id=149896
rdar://problem/23016081
Reviewed by Dan Bernstein.
- UIProcess/API/C/WKFrame.cpp:
(WKFrameCreateFrameInfo):
- UIProcess/API/C/WKFrame.h:
- 2:14 PM Changeset in webkit [190685] by
-
- 26 edits in trunk/Source/WebCore
RenderObject::computeRectForRepaint/computeFloatRectForRepaint should return the computed rectangle.
https://bugs.webkit.org/show_bug.cgi?id=149883
Reviewed by Simon Fraser.
Reduces code complexity at the calling sites.
No change in functionality.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
- rendering/RenderBox.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
- rendering/RenderInline.h:
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::selectionRectForRepaint):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::computeFloatRectForRepaint):
- rendering/RenderObject.h:
(WebCore::RenderObject::computeAbsoluteRepaintRect):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::selectionRectForRepaint):
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeRectForRepaint):
- rendering/RenderTableCell.h:
- rendering/RenderText.cpp:
(WebCore::RenderText::collectSelectionRectsForLineBoxes):
- rendering/RenderView.cpp:
(WebCore::RenderView::computeRectForRepaint):
- rendering/RenderView.h:
- rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::computeFloatRectForRepaint):
(WebCore::RenderSVGForeignObject::computeRectForRepaint):
- rendering/svg/RenderSVGForeignObject.h:
- rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::computeFloatRectForRepaint):
- rendering/svg/RenderSVGInline.h:
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::computeFloatRectForRepaint):
- rendering/svg/RenderSVGModelObject.h:
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeFloatRectForRepaint):
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::computeRectForRepaint):
(WebCore::RenderSVGText::computeFloatRectForRepaint):
- rendering/svg/RenderSVGText.h:
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::computeFloatRectForRepaint):
- rendering/svg/SVGRenderSupport.h:
- 2:12 PM Changeset in webkit [190684] by
-
- 2 edits in trunk/Source/JavaScriptCore
Get rid of LLInt inline/out-of-line storage helpers, they are unused
https://bugs.webkit.org/show_bug.cgi?id=149892
Reviewed by Mark Lam.
Just killing dead code.
- llint/LowLevelInterpreter.asm:
- 1:46 PM Changeset in webkit [190683] by
-
- 3 edits in trunk/Source/WebKit2
Add unreachable URL to _WKObservablePageState
https://bugs.webkit.org/show_bug.cgi?id=149893
<rdar://problem/23017235>
Reviewed by Dan Bernstein.
- UIProcess/API/C/mac/WKPagePrivateMac.h:
- UIProcess/API/C/mac/WKPagePrivateMac.mm:
(-[WKObservablePageState unreachableURL]):
- 1:27 PM Changeset in webkit [190682] by
-
- 3 edits in trunk/Source/JavaScriptCore
Don't setOutOfBounds in JIT code for PutByVal, since the C++ slow path already does it
https://bugs.webkit.org/show_bug.cgi?id=149885
Reviewed by Geoffrey Garen.
This simplifies the slow path code, which will make it easier to put read barriers on all of
the butterflies.
- jit/JITOperations.cpp:
(JSC::getByVal):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_put_by_val):
- 1:25 PM Changeset in webkit [190681] by
-
- 3 edits in trunk/Source/JavaScriptCore
Get rid of JIT::compilePutDirectOffset
https://bugs.webkit.org/show_bug.cgi?id=149884
Reviewed by Andreas Kling.
I'm finding more dead code.
- jit/JIT.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::emitVarInjectionCheck):
(JSC::JIT::compilePutDirectOffset): Deleted.
- 12:59 PM Changeset in webkit [190680] by
-
- 13 edits in trunk
Implement :host pseudo class
https://bugs.webkit.org/show_bug.cgi?id=149440
Source/WebCore:
rdar://problem/22731953
Reviewed by Ryosuke Niwa.
This implements the basic non-function :host syntax.
- css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
- css/CSSSelector.h:
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchHostPseudoClassRules):
(WebCore::ElementRuleCollector::matchUserRules):
- css/ElementRuleCollector.h:
- css/RuleSet.cpp:
(WebCore::computeMatchBasedOnRuleHash):
(WebCore::RuleSet::addRule):
- css/RuleSet.h:
(WebCore::RuleSet::cuePseudoRules):
(WebCore::RuleSet::hostPseudoClassRules):
(WebCore::RuleSet::focusPseudoClassRules):
(WebCore::RuleSet::universalRules):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- css/SelectorPseudoClassAndCompatibilityElementMap.in:
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
LayoutTests:
Reviewed by Ryosuke Niwa.
- fast/shadow-dom/css-scoping-shadow-host-rule.html:
Fix and expand the test case.
- platform/mac/TestExpectations:
- 12:41 PM Changeset in webkit [190679] by
-
- 3 edits in trunk/Source/JavaScriptCore
Heap::isWriteBarrierEnabled is unused
https://bugs.webkit.org/show_bug.cgi?id=149881
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-07
Reviewed by Geoffrey Garen.
- heap/Heap.h:
- heap/HeapInlines.h:
(JSC::Heap::isWriteBarrierEnabled): Deleted.
- 12:40 PM Changeset in webkit [190678] by
-
- 10 edits in trunk/Source/WebKit2
Add -[WKProcessPool _setObjectsForBundleParametersWithDictionary:]
https://bugs.webkit.org/show_bug.cgi?id=149887
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _setObjectsForBundleParametersWithDictionary:]):
Copy the dictionary, archive it, and set the values on the UI side bundle parameter data struct.
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
Add new SPI.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.h:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm:
(-[WKWebProcessBundleParameters setParameter:forKey:]):
We can just call setValue:forKey: on the dictionary; it will do the right thing if value is nil.
(-[WKWebProcessBundleParameters setParametersForKeyWithDictionary:]):
Enumerate the dictionary and call setValue:forKey: on each key/value pair.
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::setBundleParameter):
If we fail to unarchive a parameter, don't set it to null.
(WebKit::InjectedBundle::setBundleParameters):
Unarchive the dictionary and update the bundle parameters.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setInjectedBundleParameters):
Call the injected bundle.
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
Add new message.
- 12:28 PM Changeset in webkit [190677] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, more Mac test gardening after r190629.
- platform/mac-wk1/TestExpectations:
- 11:38 AM Changeset in webkit [190676] by
-
- 5 edits in trunk/Websites/perf.webkit.org
Perf dashboard doesn't show analysis tasks anchored at outliers
https://bugs.webkit.org/show_bug.cgi?id=149870
Reviewed by Chris Dumez.
The bug was caused by the computation of start and end times of analysis tasks being dependent on
time series provided to the interactive chart component even though they are already filtered.
Since the interactive chart component shouldn't be messing with the underlying data models, moved
the code to compute start and end times to App.Pane, to where it belongs, and made the moved code use
the unfiltered time series newly exposed on ChartData.
Also fixed a bug in fetch-from-remote.php which resulted in Ember endlessly fetching same JSON files.
- public/admin/fetch-from-remote.php:
(.): Use the full request URI for HTTP requests and caching. Otherwise, we're going to mix up caches
and Ember can start hanging browsers (took me three hours to debug this).
- public/v2/app.js:
(App.Pane._showOutlierChanged): Added. Resets chartData when showOutlier flag has been changed.
(App.Pane.fetchAnalyticRanges): The old code wasn't filtering analysis tasks by platforms and metrics
at all since it relied on the server-side REST API to do the filtering, which I haven't implemented yet.
Filter the results manually instead.
(App.Pane.ranges): Moved the logic to compute startTime and endTime here from InteractiveChartComponent.
(App.PaneController.toggleShowOutlier): Now that App.Pane responds to showOutlier changes, we don't
need to call a private method on it.
(App.AnalysisTaskController._chartDataChanged): When end points are not found, try showing outliers.
This will cause chartData to be modified so just exit early and wait for getting called again.
- public/v2/interactive-chart.js:
(App.InteractiveChartComponent._rangesChanged): The code to compute start and end time has been moved
to App.Pane.ranges.
- public/v2/manifest.js:
(App.Manifest._formatFetchedData): Added unfiltered time series as new properties as they are now used
to compute the end points of analysis tasks when their end points are outliers.
- 11:26 AM Changeset in webkit [190675] by
-
- 4 edits in trunk/Source/JavaScriptCore
JIT::emitGetGlobalProperty/emitPutGlobalProperty are only called from one place
https://bugs.webkit.org/show_bug.cgi?id=149879
Reviewed by Saam Barati.
To simplify my work to insert barriers on loads of the butterfly, I want to reduce the amount
of abstraction we have around code that loads the butterfly.
- jit/JIT.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitLoadWithStructureCheck):
(JSC::JIT::emitGetVarFromPointer):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitPutGlobalVariable):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitGetGlobalProperty): Deleted.
(JSC::JIT::emitPutGlobalProperty): Deleted.
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitLoadWithStructureCheck):
(JSC::JIT::emitGetVarFromPointer):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitPutGlobalVariable):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitGetGlobalProperty): Deleted.
(JSC::JIT::emitPutGlobalProperty): Deleted.
- 11:17 AM Changeset in webkit [190674] by
-
- 6 edits in trunk
AX: ARIA 1.1 @aria-placeholder
https://bugs.webkit.org/show_bug.cgi?id=148970
Reviewed by Chris Fleizach.
Source/WebCore:
Added support for aria-placeholder attribute.
Modified accessibility/placeholder.html test.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::placeholderValue):
- html/HTMLAttributeNames.in:
LayoutTests:
- accessibility/placeholder-expected.txt:
- accessibility/placeholder.html:
- 11:04 AM Changeset in webkit [190673] by
-
- 4 edits in trunk/Source/JavaScriptCore
JIT::compileGetDirectOffset is useless
https://bugs.webkit.org/show_bug.cgi?id=149878
Reviewed by Mark Lam.
Two of the overloads of this method were never called. The other was called only from one
place, in a manner that rendered most of its code dead. This change removes the dead code and
folds the method into its one caller.
- jit/JIT.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::emitVarInjectionCheck):
(JSC::JIT::emitGetGlobalProperty):
(JSC::JIT::emitGetVarFromPointer):
(JSC::JIT::compileGetDirectOffset): Deleted.
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::emitVarInjectionCheck):
(JSC::JIT::emitGetGlobalProperty):
(JSC::JIT::emitGetVarFromPointer):
(JSC::JIT::compileGetDirectOffset): Deleted.
- 10:28 AM Changeset in webkit [190672] by
-
- 7 edits in trunk/Source/JavaScriptCore
Inline caches should handle out-of-line offsets out-of-line
https://bugs.webkit.org/show_bug.cgi?id=149869
Reviewed by Saam Barati.
If we want to have a concurrent copying GC, then we need a read barrier on copied space
pointers. That makes the convertible load portion of the get_by_id/put_by_id inline caches
rather challenging. Currently we have a load instruction that we can turn into an add
instruction - the add case is when we have an inline offset, and the load case is when we
have an out-of-line offset and we need to load a copied space pointer. But if the load from
copied space requires a barrier, then there is no easy way to convert that back to the inline
case.
This patch removes the convertible load. The inline path of get_by_id/put_by_id only handles
the inline offsets. Out-of-line offsets are now handled using out-of-line stubs.
- bytecode/StructureStubInfo.h:
- ftl/FTLInlineCacheSize.cpp:
(JSC::FTL::sizeOfGetById):
(JSC::FTL::sizeOfPutById):
- jit/JITInlineCacheGenerator.cpp:
(JSC::JITByIdGenerator::finalize):
(JSC::JITByIdGenerator::generateFastPathChecks):
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
(JSC::JITGetByIdGenerator::generateFastPath):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
(JSC::JITPutByIdGenerator::generateFastPath):
- jit/JITInlineCacheGenerator.h:
- jit/Repatch.cpp:
(JSC::repatchByIdSelfAccess):
(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):
- runtime/JSObject.h:
(JSC::JSObject::butterflyTotalSize):
(JSC::indexRelativeToBase):
(JSC::offsetRelativeToBase):
(JSC::maxOffsetRelativeToBase):
(JSC::makeIdentifier):
(JSC::offsetRelativeToPatchedStorage): Deleted.
(JSC::maxOffsetRelativeToPatchedStorage): Deleted.
- 9:41 AM Changeset in webkit [190671] by
-
- 1 edit in trunk/Source/WebKit2/UIProcess/API/Cocoa/WKProcessPoolPrivate.h
Oops, did not mean to commit this.
- 9:39 AM Changeset in webkit [190670] by
-
- 5 edits2 copies in trunk/Source/WebKit2
Expose the bundle parameter object on WKBundleRef
https://bugs.webkit.org/show_bug.cgi?id=149860
Reviewed by Tim Horton.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessBundleParameters.mm:
(-[WKWebProcessBundleParameters description]):
Add a description that includes the parameters.
- WebProcess/InjectedBundle/API/c/mac/WKBundleMac.h:
- WebProcess/InjectedBundle/API/c/mac/WKBundleMac.mm:
(WKBundleGetParameters):
Add getter.
- WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::initialize):
Make sure to decode the bundle parameters before calling out to the bundle.
- 9:29 AM Changeset in webkit [190669] by
-
- 5 edits in trunk/Source
Versioning.
- 9:11 AM Changeset in webkit [190668] by
-
- 18 edits1 delete in trunk/Source
Unreviewed, rolling out r190664.
https://bugs.webkit.org/show_bug.cgi?id=149877
mac build is sometimes borken due to missing generated header
file (Requested by youenn on #webkit).
Reverted changeset:
"Automate WebCore JS builtins generation and build system"
https://bugs.webkit.org/show_bug.cgi?id=149751
http://trac.webkit.org/changeset/190664
- 8:09 AM Changeset in webkit [190667] by
-
- 10 edits2 copies in trunk
will-change should trigger stacking context based purely on properties
https://bugs.webkit.org/show_bug.cgi?id=148068
Reviewed by Zalan Bujtas.
Source/WebCore:
Previously, our will-change implementation didn't trigger stacking context
on an inline if the will-change property didn't apply to inlines (like 'transform').
However, this doesn't agree with the CSS-WG consensus (https://lists.w3.org/Archives/Public/www-style/2015Sep/0112.html).
Change behavior to have stacking context creation behavior for will-change be
identical for inlines and blocks.
Test: fast/css/will-change/will-change-creates-stacking-context-inline.html
- rendering/RenderInline.cpp:
(WebCore::inFlowPositionedInlineAncestor):
- rendering/RenderInline.h:
(WebCore::RenderInline::willChangeCreatesStackingContext):
- rendering/style/WillChangeData.cpp:
(WebCore::propertyCreatesStackingContext):
(WebCore::WillChangeData::addFeature):
(WebCore::propertyCreatesStackingContextOnBoxesOnly): Deleted.
- rendering/style/WillChangeData.h:
(WebCore::WillChangeData::canCreateStackingContextOnInline): Deleted.
LayoutTests:
Previously, our will-change implementation didn't trigger stacking context
on an inline if the will-change property didn't apply to inlines (like 'transform').
However, this doesn't agree with the CSS-WG consensus (https://lists.w3.org/Archives/Public/www-style/2015Sep/0112.html).
Change behavior to have stacking context creation behavior for will-change be
identical for inlines and blocks.
- platform/mac/TestExpectations: Fails on Mavericks because no backdrop-filter there.
- fast/css/will-change/resources/will-change-stacking-helper.js:
(makeStackingInline):
- fast/css/will-change/will-change-creates-stacking-context-inline-expected.html: Added.
- fast/css/will-change/will-change-creates-stacking-context-inline.html: Added.
- 7:59 AM Changeset in webkit [190666] by
-
- 1 edit1 add in trunk/LayoutTests
[EFL] fast/repaint/block-inputrange-repaint.html is failed.
https://bugs.webkit.org/show_bug.cgi?id=149517
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-10-07
Reviewed by Zalan Bujtas.
EFL thumb size is different with mac port, it causes the difference of repaintRect.
So rebaseline the test with failure result.
- platform/efl/fast/repaint/block-inputrange-repaint-expected.txt: Added.
- 6:14 AM Changeset in webkit [190665] by
-
- 5 edits in trunk
[CSS Grid Layout] Modify grid item height doesn't work
https://bugs.webkit.org/show_bug.cgi?id=149840
Reviewed by Sergio Villar Senin.
Source/WebCore:
When computing the logical height of content-sized grid tracks we
need to clear grid item's override height if it needs to be laid
out again.
Currently we are doing so only in the case of percentage heights
or when the grid track's width has changed; these situations would
obviously mark grid items as needing layout.
However, there are other situations, like the one defined in this
bug, which would imply a new layout of the grid items; hence we
need to clear its override value if we want the layout logic to be
computed correctly.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::logicalContentHeightForChild):
LayoutTests:
Added new tests cases to verify content-sized grid tracks are resized
appropriately whenever grid item's height is changed.
- fast/css-grid-layout/grid-items-should-not-be-stretched-when-height-or-width-or-margin-change-expected.txt: Added new test cases.
- fast/css-grid-layout/grid-items-should-not-be-stretched-when-height-or-width-or-margin-change.html: Added new test cases.
- 5:52 AM Changeset in webkit [190664] by
-
- 18 edits1 add in trunk/Source
Automate WebCore JS builtins generation and build system
https://bugs.webkit.org/show_bug.cgi?id=149751
Reviewed by Darin Adler.
Source/JavaScriptCore:
- generate-js-builtins: updating the part related to WebCore JS binding.
Source/WebCore:
Adding annotations to JS files to know whether they should be under a compilation flag and
whether they are JS internals or JS tied to WebIDL.
If a file is said as JS internals, all function names are exported automatically.
Added auto generation of WebCoreJSBuiltins.cpp
Added auto generation of JSBuiltinFunctions class inside WebCoreJSBuiltins that takes the role of
WebCoreJSClientData as wrapper for builtins. Renamed WebCoreJSClientData to JSClientData.
Added auto generation of PrivateWebCoreJSBuiltins that is a wrapper around all private functions, used by
JSDOMWindowBase. The class is named JSBuiltinInternalFunctions.
The remaining manual part for private functions is the pairing between private identifiers and
the private JS functions within JSDOMWindowBase::finishCreation.
Covered by existing tests.
- CMakeLists.txt:
- DerivedSources.make:
- Modules/streams/ByteLengthQueuingStrategy.js:
- Modules/streams/CountQueuingStrategy.js:
- Modules/streams/ReadableStream.js:
- Modules/streams/ReadableStreamInternals.js:
- WebCore.order:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::normalWorld):
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::finishCreation):
(WebCore::JSDOMWindowBase::visitChildren):
(WebCore::JSDOMWindowBase::fireFrameClearedWatchpointsForWindow):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::getAllWorlds):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::transferArrayBuffers):
- bindings/js/WebCoreJSClientData.h:
(WebCore::JSClientData::JSClientData):
(WebCore::JSClientData::~JSClientData):
(WebCore::JSClientData::builtinFunctions):
(WebCore::initNormalWorldClientData):
(WebCore::WebCoreJSClientData::WebCoreJSClientData): Deleted.
(WebCore::WebCoreJSClientData::~WebCoreJSClientData): Deleted.
(WebCore::WebCoreJSClientData::readableStreamBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamControllerBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamInternalsBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamReaderBuiltins): Deleted.
(WebCore::WebCoreJSClientData::byteLengthQueuingStrategyBuiltins): Deleted.
(WebCore::WebCoreJSClientData::countQueuingStrategyBuiltins): Deleted.
- generate-js-builtins-allinone: Added.
(retrieveGenerationParameters):
(retrieveFilesWithParameters):
(retrieveFilesWithParameters.FileInput):
(writeConditional):
(JSBuiltinFunctions):
(Private):
(JSBuiltinInternalFunctions):
(copytempfile):
- 2:40 AM Changeset in webkit [190663] by
-
- 21 edits9 adds in trunk
[css-grid] Implement grid gutters
https://bugs.webkit.org/show_bug.cgi?id=149800
Reviewed by Darin Adler.
Source/WebCore:
Authors can now specify the gutters between grid lines, i.e.,
the space between two consecutive grid lines. This can be done
using the new '-webkit-grid-column-gap 'and
'-webkit-grid-row-gap' properties (or the '-webkit-grid-gap'
shorthand).
From the track sizing algorithm POV, gutters are treated as
fixed size columns. The primary consequence is that grids are
enlarged (depending on the number of tracks). Gutters also
affect the sizing of content-sized tracks and fr tracks as
long as the grid have spanning items. Those tracks will become
smaller as gutters will consume part of the item's size, so
the tracks won't need to grow as much as they used to.
Tests: fast/css-grid-layout/grid-gutters-and-alignment.html
fast/css-grid-layout/grid-gutters-and-flex-content.html
fast/css-grid-layout/grid-gutters-and-tracks.html
fast/css-grid-layout/grid-gutters-get-set.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForGridTrackList):
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::isSimpleLengthPropertyID):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridGapShorthand):
- css/CSSParser.h:
- css/CSSPropertyNames.in:
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::guttersSize):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::populateGridPositions):
(WebCore::RenderGrid::columnAxisOffsetForChild):
(WebCore::RenderGrid::rowAxisOffsetForChild):
- rendering/RenderGrid.h:
- rendering/style/RenderStyle.h:
- rendering/style/StyleGridData.cpp:
(WebCore::StyleGridData::StyleGridData):
- rendering/style/StyleGridData.h:
(WebCore::StyleGridData::operator==):
LayoutTests:
Added several new test cases to verify that gutters are
properly considered when sizing and also to check that they do
not modify the current behavior. As many existing tests were
reused I took the chance to refactor some testing code related
to alignment so that it could be reused by many different
tests.
- fast/css-grid-layout/grid-align-content.html:
- fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-lr.html:
- fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-rl.html:
- fast/css-grid-layout/grid-align-justify-margin-border-padding.html:
- fast/css-grid-layout/grid-align.html:
- fast/css-grid-layout/grid-gutters-and-alignment-expected.txt: Added.
- fast/css-grid-layout/grid-gutters-and-alignment.html: Added.
- fast/css-grid-layout/grid-gutters-and-flex-content-expected.txt: Added.
- fast/css-grid-layout/grid-gutters-and-flex-content.html: Added.
- fast/css-grid-layout/grid-gutters-and-tracks-expected.txt: Added.
- fast/css-grid-layout/grid-gutters-and-tracks.html: Added.
- fast/css-grid-layout/grid-gutters-get-set-expected.txt: Added.
- fast/css-grid-layout/grid-gutters-get-set.html: Added.
- fast/css-grid-layout/grid-justify-content-distribution-vertical-lr.html:
- fast/css-grid-layout/grid-justify-content-distribution-vertical-rl.html:
- fast/css-grid-layout/grid-justify-content.html:
- fast/css-grid-layout/resources/grid-alignment.css: Added.
(.alignSelfAuto):
(.alignSelfStretch):
(.alignSelfStart):
(.alignSelfEnd):
(.alignSelfCenter):
(.alignSelfRight):
(.alignSelfLeft):
(.alignSelfFlexStart):
(.alignSelfFlexEnd):
(.alignSelfSelfStart):
(.alignSelfSelfEnd):
(.alignItemsCenter):
(.alignContentBaseline):
(.alignContentLastBaseline):
(.alignContentStart):
(.alignContentEnd):
(.alignContentCenter):
(.alignContentLeft):
(.alignContentRight):
(.alignContentFlexStart):
(.alignContentFlexEnd):
(.justifyContentBaseline):
(.justifyContentLastBaseline):
(.justifyContentStart):
(.justifyContentEnd):
(.justifyContentCenter):
(.justifyContentLeft):
(.justifyContentRight):
(.justifyContentFlexStart):
(.justifyContentFlexEnd):
(.justifyContentSpaceBetween):
(.justifyContentSpaceAround):
(.justifyContentSpaceEvenly):
(.justifyContentStretch):
(.itemsCenter):
(.itemsEnd):
(.itemsLeft):
(.itemsRight):
(.itemsSelfStart):
(.itemsSelfEnd):
- fast/css-grid-layout/resources/grid-definitions-parsing-utils.js:
(testGridGapDefinitionsValues):
- fast/css-grid-layout/resources/grid.css:
(.firstRowThirdColumn):
(.secondRowThirdColumn):
(.firstRowFourthColumn):
(.secondRowFourthColumn):
- 12:32 AM Changeset in webkit [190662] by
-
- 3 edits5 adds in trunk
[GTK] Progress bar is broken on recent GTK+
https://bugs.webkit.org/show_bug.cgi?id=149831
Reviewed by Carlos Garcia Campos.
Source/WebCore:
The gtk progress bar has been broken after bumping up to Gtk+-3.16. This is because
the way of rendering progress bar changed after gtk+-3.13.7. See more
https://mail.gnome.org/archives/commits-list/2014-August/msg03865.html
gtk_render_activity is no longer valid to paint a progress bar on a newer gtk+.
It should be done with gtk_render_background and gtk_render_frame.
Test: fast/dom/HTMLProgressElement/native-progress-bar.html
- rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintProgressBar):
LayoutTests:
- fast/dom/HTMLProgressElement/native-progress-bar.html: Added.
- platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.png: Added.
- platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.
- platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.png: Added.
- platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.
- 12:11 AM Changeset in webkit [190661] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Unreviewed. Fix a typo in r190645.
- public/include/db.php:
