⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 9, 2015:

8:52 PM Changeset in webkit [190836] by mmaxfield@apple.com
  • 9 edits
    1 copy in trunk

Unreviewed, rolling out r190689
​https://bugs.webkit.org/show_bug.cgi?id=149992

Fixed in other repository.

Reverted changesets:

"Unreviewed, rolling out r190572, r190593, r190594, and r190639."
​https://bugs.webkit.org/show_bug.cgi?id=149897

7:53 PM Changeset in webkit [190835] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Check if start and end positions are still valid after updating them through VisibleSelection.
​https://bugs.webkit.org/show_bug.cgi?id=149982

Reviewed by Ryosuke Niwa.

This patch is required to be able to clean up anonymous tables structure.
In certain edge cases, start/end positions could become nullptr after various text splitting
operations.

Covered by editing/execCommand/crash-137961.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::applyInlineStyle):

7:20 PM Changeset in webkit [190834] by Simon Fraser
  • 23 edits in trunk/Source/WebCore

Rename RenderObject::isRoot() to isDocumentElementRenderer()
​https://bugs.webkit.org/show_bug.cgi?id=149976

Reviewed by Zalan Bujtas.

RenderObject::isRoot() was confusingly named, because it returns true for
the document element's renderer, not for the actual root (the RenderView).
In this way it mismatched RenderLayer::isRootLayer(), which returned true
for the RenderView's layer.

Rename it to the more accurate isDocumentElementRenderer().

  • dom/Node.cpp:

(WebCore::Node::renderRect):

  • page/ios/FrameIOS.mm:

(WebCore::Frame::renderRectForPoint):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::isSelectionRoot):
(WebCore::RenderBlock::selectionGaps):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats):
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::requiresColumns):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleWillChange):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::updateFromStyle):
(WebCore::RenderBox::paintBackground):
(WebCore::RenderBox::computeBackgroundIsKnownToBeObscured):
(WebCore::RenderBox::repaintLayerRectsForImage):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::createsNewFormattingContext):
(WebCore::RenderBox::percentageLogicalHeightIsResolvableFromBlock):

  • rendering/RenderBox.h:

(WebCore::RenderBox::stretchesToViewport):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::fixedBackgroundPaintsInLocalCoordinates):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::styleWillChange):
(WebCore::RenderElement::rendererForRootBackground):
(WebCore::shouldRepaintForImageAnimation):

  • rendering/RenderElement.h:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):

  • rendering/RenderLayer.cpp:

(WebCore::shouldSuppressPaintingLayer):
(WebCore::paintForFixedRootBackground):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::rendererBackgroundColor):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):

  • rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::styleDidChange):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintSlowRepaintObject):
(WebCore::RenderObject::offsetParent):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isDocumentElementRenderer):
(WebCore::RenderObject::isRoot): Deleted.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paint):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::shouldApplyViewportClip):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::isOverflowHidden):

6:08 PM Changeset in webkit [190833] by n_wang@apple.com
  • 22 edits
    2 adds in trunk

AX: ARIA 1.1 implement aria-colcount, aria-colindex, aria-colspan, aria-rowcount, aria-rowindex and aria-rowspan
​https://bugs.webkit.org/show_bug.cgi?id=148967

Reviewed by Chris Fleizach.

Source/WebCore:

Added support for ARIA 1.1 table/grid related attributes. Created new attributes for mac, so
VoiceOver can pick up the information and speak accordingly.

Test: accessibility/mac/aria-table-attributes.html

  • accessibility/AccessibilityARIAGridCell.cpp:

(WebCore::AccessibilityARIAGridCell::AccessibilityARIAGridCell):
(WebCore::AccessibilityARIAGridCell::rowIndexRange):
(WebCore::AccessibilityARIAGridCell::columnIndexRange):
(WebCore::AccessibilityARIAGridCell::parentRowGroup):

  • accessibility/AccessibilityARIAGridCell.h:
  • accessibility/AccessibilityObject.cpp:

(WebCore::initializeRoleMap):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::title):
(WebCore::AccessibilityTable::ariaColumnCount):
(WebCore::AccessibilityTable::ariaRowCount):

  • accessibility/AccessibilityTable.h:
  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::AccessibilityTableCell):
(WebCore::AccessibilityTableCell::titleUIElement):
(WebCore::AccessibilityTableCell::ariaColumnIndex):
(WebCore::AccessibilityTableCell::ariaRowIndex):
(WebCore::AccessibilityTableCell::ariaColumnSpan):
(WebCore::AccessibilityTableCell::ariaRowSpan):

  • accessibility/AccessibilityTableCell.h:

(WebCore::AccessibilityTableCell::setARIAColIndexFromRow):

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::headerObject):
(WebCore::AccessibilityTableRow::addChildren):
(WebCore::AccessibilityTableRow::ariaColumnIndex):
(WebCore::AccessibilityTableRow::ariaRowIndex):

  • accessibility/AccessibilityTableRow.h:
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

  • html/HTMLAttributeNames.in:

LayoutTests:

  • accessibility/mac/aria-columnrowheaders-expected.txt:
  • accessibility/mac/aria-table-attributes-expected.txt: Added.
  • accessibility/mac/aria-table-attributes.html: Added.
  • platform/mac/accessibility/table-attributes-expected.txt:
  • platform/mac/accessibility/table-cell-spans-expected.txt:
  • platform/mac/accessibility/table-cells-expected.txt:
  • platform/mac/accessibility/table-detection-expected.txt:
  • platform/mac/accessibility/table-sections-expected.txt:
  • platform/mac/accessibility/table-with-rules-expected.txt:
4:30 PM Changeset in webkit [190832] by Beth Dakin
  • 6 edits in trunk/Source/WebKit2

Rubber-stamped by Anders Carlsson.

Remove unnecessary includes.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebPage/mac/WebPageMac.mm:
4:19 PM Changeset in webkit [190831] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Modernize and cleanup an NSNumber constant
​https://bugs.webkit.org/show_bug.cgi?id=149962

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-09
Reviewed by Andreas Kling.

  • API/JSVirtualMachine.mm:

(-[JSVirtualMachine addExternalRememberedObject:]):

4:19 PM Changeset in webkit [190830] by Beth Dakin
  • 3 edits
    2 deletes in trunk/Source/WebKit2

Build fix.

  • CMakeLists.txt:
  • Shared/API/APIHitTestResult.cpp: Removed.
  • Shared/API/APIHitTestResult.h: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
4:17 PM Changeset in webkit [190829] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

No need to keep setting needsVisit flag in SmallStrings
​https://bugs.webkit.org/show_bug.cgi?id=149961

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-09
Reviewed by Andreas Kling.

SmallStrings are all initialized at once privately before the VM
enables Garbage Collection. There is no need to keep updating
this flag, as it couldn't have changed.

  • runtime/SmallStrings.cpp:

(JSC::SmallStrings::createEmptyString):
(JSC::SmallStrings::createSingleCharacterString):
(JSC::SmallStrings::initialize):

  • runtime/SmallStrings.h:
4:15 PM Changeset in webkit [190828] by Beth Dakin
  • 2 edits
    2 copies in trunk/Source/WebKit2

Build fix.

  • UIProcess/API/APIHitTestResult.cpp: Copied from Shared/API/APIHitTestResult.cpp.
  • UIProcess/API/APIHitTestResult.h: Copied from Shared/API/APIHitTestResult.h.
  • UIProcess/mac/PageClientImpl.mm:
4:10 PM Changeset in webkit [190827] by ggaren@apple.com
  • 57 edits in trunk/Source/JavaScriptCore

2015-10-09 Geoffrey Garen <​ggaren@apple.com>

Unreviewed, rolling back in r190694
​https://bugs.webkit.org/show_bug.cgi?id=149727

This time for double sure?

The cause of the crash was an incorrect write barrier.

OSR exit was barriering the baseline codeblock for the top of the stack
twice, missing the baseline codeblock for the bottom of the stack.

Restored changesets:

"CodeBlock should be a GC object"
​https://bugs.webkit.org/show_bug.cgi?id=149727
​http://trac.webkit.org/changeset/r190694

3:48 PM Changeset in webkit [190826] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Remove hack that allowed plug-ins to always take over certain image formats
​https://bugs.webkit.org/show_bug.cgi?id=149972

Reviewed by Tim Horton.

This hack was added 8 years ago to allow a certain plug-in to show multi-page TIFF images on uspto.gov.
We now support said TIFFs natively, and the plug-in has been discontinued so it's safe to get rid of this.

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::shouldUsePlugin): Deleted.

3:27 PM Changeset in webkit [190825] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.41

New tag.

3:26 PM Changeset in webkit [190824] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.3.3

New tag.

3:24 PM Changeset in webkit [190823] by Beth Dakin
  • 41 edits
    3 moves
    5 adds in trunk/Source/WebKit2

WKWebView needs SPI to customize immediate actions
​https://bugs.webkit.org/show_bug.cgi?id=149939
-and corresponding-
rdar://problem/20016849

Reviewed by Anders Carlsson.

This patch breaks WebHitTestResult into two files. WebHiTestResultData
continues to live in the WebKit namespace and contains the old
WebHitTestResult::Data struct. The rest of WebHitTestResult is now
API::HitTestResult. The patch also adds _WKHitTestResult as Obj-C API to wrap
API::HitTestResult.

Attempt to keep other ports happy with new files.

  • CMakeLists.txt:

WebKit::WebHitTestResult no longer contains the Data struct and is now called
API::HitTestResult.

  • Shared/API/APIHitTestResult.cpp: Copied from Shared/WebHitTestResult.cpp.

(API::HitTestResult::create):
(WebKit::WebHitTestResult::create): Deleted.
(WebKit::WebHitTestResult::Data::Data): Deleted.
(WebKit::WebHitTestResult::Data::~Data): Deleted.
(WebKit::WebHitTestResult::Data::encode): Deleted.
(WebKit::WebHitTestResult::Data::decode): Deleted.
(WebKit::WebHitTestResult::Data::platformEncode): Deleted.
(WebKit::WebHitTestResult::Data::platformDecode): Deleted.
(WebKit::WebHitTestResult::Data::elementBoundingBoxInWindowCoordinates): Deleted.

  • Shared/API/APIHitTestResult.h: Copied from Shared/WebHitTestResult.h.

(API::HitTestResult::absoluteImageURL):
(API::HitTestResult::absolutePDFURL):
(API::HitTestResult::absoluteLinkURL):
(API::HitTestResult::absoluteMediaURL):
(API::HitTestResult::linkLabel):
(API::HitTestResult::linkTitle):
(API::HitTestResult::lookupText):
(API::HitTestResult::isContentEditable):
(API::HitTestResult::isDownloadableMedia):
(API::HitTestResult::HitTestResult):
(WebKit::WebHitTestResult::absoluteImageURL): Deleted.
(WebKit::WebHitTestResult::absolutePDFURL): Deleted.
(WebKit::WebHitTestResult::absoluteLinkURL): Deleted.
(WebKit::WebHitTestResult::absoluteMediaURL): Deleted.
(WebKit::WebHitTestResult::linkLabel): Deleted.
(WebKit::WebHitTestResult::linkTitle): Deleted.
(WebKit::WebHitTestResult::lookupText): Deleted.
(WebKit::WebHitTestResult::isContentEditable): Deleted.
(WebKit::WebHitTestResult::isDownloadableMedia): Deleted.
(WebKit::WebHitTestResult::WebHitTestResult): Deleted.

This is a new obj-c object that we can use for the modern immediate action
API.

  • Shared/API/Cocoa/_WKHitTestResult.h: Added.
  • Shared/API/Cocoa/_WKHitTestResult.mm: Added.

(-[_WKHitTestResult dealloc]):
(-[_WKHitTestResult absoluteImageURL]):
(-[_WKHitTestResult absolutePDFURL]):
(-[_WKHitTestResult absoluteLinkURL]):
(-[_WKHitTestResult absoluteMediaURL]):
(-[_WKHitTestResult linkLabel]):
(-[_WKHitTestResult linkTitle]):
(-[_WKHitTestResult lookupText]):
(-[_WKHitTestResult isContentEditable]):
(-[_WKHitTestResult elementBoundingBox]):
(-[_WKHitTestResult copyWithZone:]):
(-[_WKHitTestResult _apiObject]):

_WKHitTestResult wraps API::HitTestResult.

  • Shared/API/Cocoa/_WKHitTestResultInternal.h: Added.

(API::wrapper):

  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

Since we want to use the same enum name for the new enum, use a #define instead of a typedef in the old C SPI. This should keep old clients working in the meantime.

  • Shared/API/c/WKImmediateActionTypes.h:

WebHitTestResult::Data is now WebHitTestResultData.

  • Shared/ContextMenuContextData.h:

(WebKit::ContextMenuContextData::webHitTestResultData):
(WebKit::ContextMenuContextData::selectedText):

Remove WebHitTestResult, and add WebHitTestResultData for the Data struct.

  • Shared/WebHitTestResult.cpp: Removed.
  • Shared/WebHitTestResult.h: Removed.
  • Shared/WebHitTestResultData.cpp: Added.

(WebKit::WebHitTestResultData::WebHitTestResultData):
(WebKit::WebHitTestResultData::~WebHitTestResultData):
(WebKit::WebHitTestResultData::encode):
(WebKit::WebHitTestResultData::decode):
(WebKit::WebHitTestResultData::platformEncode):
(WebKit::WebHitTestResultData::platformDecode):
(WebKit::WebHitTestResultData::elementBoundingBoxInWindowCoordinates):

  • Shared/WebHitTestResultData.h: Added.
  • Shared/mac/WebHitTestResult.mm: Removed.
  • Shared/mac/WebHitTestResultData.mm: Copied from Shared/mac/WebHitTestResult.mm.

(WebKit::WebHitTestResultData::platformEncode):
(WebKit::WebHitTestResultData::platformDecode):
(WebKit::WebHitTestResult::Data::platformEncode): Deleted.
(WebKit::WebHitTestResult::Data::platformDecode): Deleted.

WebHitTestResult::Data is now WebHitTestResultData.

  • UIProcess/API/APIContextMenuClient.h:

(API::ContextMenuClient::~ContextMenuClient):
(API::ContextMenuClient::getContextMenuFromProposedMenu):
(API::ContextMenuClient::customContextMenuItemSelected):
(API::ContextMenuClient::contextMenuDismissed):
(API::ContextMenuClient::showContextMenu):

WebHitTestResult is now WebHitTestResult

  • UIProcess/API/APIUIClient.h:

(API::UIClient::runJavaScriptPrompt):
(API::UIClient::setStatusText):
(API::UIClient::mouseDidMoveOverElement):
(API::UIClient::unavailablePluginButtonClicked):
(API::UIClient::pinnedStateDidChange):
(API::UIClient::didBeginTrackingPotentialLongMousePress):
(API::UIClient::didRecognizeLongMousePress):
(API::UIClient::didCancelTrackingPotentialLongMousePress):

  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKHitTestResult.cpp:

(WKHitTestResultGetTypeID):
(WKHitTestResultCopyAbsoluteImageURL):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageContextMenuClient):
(WKPageSetPageUIClient):

New WKWebView SPI _immediateActionAnimationControllerForHitTestResult

  • UIProcess/API/Cocoa/WKViewPrivate.h:
  • UIProcess/API/Cocoa/WKWebView.mm:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:

Attempts to keep other ports happy with the re-name.

  • UIProcess/API/efl/WebAccessibility.cpp:
  • UIProcess/API/gtk/WebKitContextMenuClient.cpp:
  • UIProcess/API/gtk/WebKitHitTestResult.cpp:

(webkit_hit_test_result_class_init):
(webkitHitTestResultCreate):
(stringIsEqualToCString):
(webkitHitTestResultCompare):

  • UIProcess/API/gtk/WebKitHitTestResultPrivate.h:
  • UIProcess/API/gtk/WebKitUIClient.cpp:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewMakePermissionRequest):
(webkitWebViewMouseTargetChanged):
(contextMenuDismissed):
(webkitWebViewPopulateContextMenu):

  • UIProcess/API/gtk/WebKitWebViewPrivate.h:

Re-name, and just use uint32_t for the old SPI.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _didPerformImmediateActionHitTest:contentPreventsDefault:userData:]):
(-[WKView _setDidMoveSwipeSnapshotCallback:]):
(-[WKView _immediateActionAnimationControllerForHitTestResult:withType:userData:]):

  • UIProcess/API/mac/WKViewInternal.h:

PageClient will figure out whether to call into WKWebView or WKView for this
SPI.

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::immediateActionAnimationControllerForHitTestResult):

  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/PageClientImpl.h:
  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::immediateActionAnimationControllerForHitTestResult):

WebKit::WebHitTestResult::Data is now WebKit::WebHitTestResultData.

  • UIProcess/WebPageProxy.messages.in:

WKImmediateActionController calls through to WebPageProxy which calls to
PageClient, which figures out which API to call. Also cache the type as a
uint32_t

  • UIProcess/mac/WKImmediateActionController.h:
  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _updateImmediateActionItem]):

WebHitTestResult::Data is now WebHitTestResultData.

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::platformInitializeShareMenuItem):

New files!

  • WebKit2.xcodeproj/project.pbxproj:

Deal with the #define situation for the enum.

  • WebKit2Prefix.h:

New names for things. WebHitTestResult::Data -> WebHitTestResultData

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/PDF/PDFPlugin.h:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::pointInLayoutSpaceForPointInWindowSpace):
(WebKit::PDFPlugin::lookupTextAtLocation):

  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::mouseDidMoveOverElement):
(WebKit::WebChromeClient::didBeginTrackingPotentialLongMousePress):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performImmediateActionHitTestAtLocation):

3:06 PM Changeset in webkit [190822] by commit-queue@webkit.org
  • 7 edits
    1 delete in trunk/Source/JavaScriptCore

Remove unused RecursiveAllocationScope
​https://bugs.webkit.org/show_bug.cgi?id=149967

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-09
Reviewed by Csaba Osztrogonác.

RecursiveAllocationScope has been unused since r163691.

  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/Heap.cpp:
  • heap/Heap.h:
  • heap/RecursiveAllocationScope.h: Removed.
  • runtime/VM.h:
3:01 PM Changeset in webkit [190821] by BJ Burg
  • 3 edits in trunk/Tools

Teach webkitperl how to figure out IOS versions from the SDK
​https://bugs.webkit.org/show_bug.cgi?id=149963

Reviewed by Daniel Bates.

It should be easier to check the major and minor version of IOS SDKs.

  • Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
  • Scripts/webkitdirs.pm:

(splitVersionString): Added.
(determineOSXVersion): Use splitVersionString.
(determineIOSVersion): Added. Look at the SDK version and make a tuple.
(iosVersion): Added.

2:50 PM Changeset in webkit [190820] by Simon Fraser
  • 3 edits
    2 adds in trunk

Garbage texture data with composited table row
​https://bugs.webkit.org/show_bug.cgi?id=148984

Reviewed by Zalan Bujtas.
Source/WebCore:

Don't pretend to know if the layer for a table header, section or cell is
opaque, since table painting is special.

Test: compositing/contents-opaque/table-parts.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

  • compositing/contents-opaque/table-parts-expected.txt: Added.
  • compositing/contents-opaque/table-parts.html: Added.
2:34 PM Changeset in webkit [190819] by Simon Fraser
  • 3 edits in trunk/Tools

[iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
​https://bugs.webkit.org/show_bug.cgi?id=149960

Reviewed by Tim Horton.

Use adoptWK(), and null out some members (file is not using ARC).

  • WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:

(UIScriptContext::uiScriptComplete):

  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView dealloc]):

2:07 PM Changeset in webkit [190818] by Simon Fraser
  • 7 edits
    2 adds in trunk

Garbage pixels on enphaseenergy.com site
​https://bugs.webkit.org/show_bug.cgi?id=149915
rdar://problem/22976184

Reviewed by Darin Adler.

Source/WebCore:

When the <html> gets a composited RenderLayer, and we ask whether its background
is opaque, return false, since the document element's background propagates
to the root, and is painted by the RenderView.

Also improve the compositing logging to indicate when fore- and background layers
are present.

Test: compositing/contents-opaque/negative-z-before-html.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):

LayoutTests:

New ref test. Also update the expected result for another test that uses negative
z-index children.

  • compositing/contents-opaque/body-background-painted-expected.txt:
  • compositing/contents-opaque/negative-z-before-html-expected.html: Added.
  • compositing/contents-opaque/negative-z-before-html.html: Added.
  • platform/mac-wk2/compositing/contents-opaque/body-background-painted-expected.txt:
2:00 PM Changeset in webkit [190817] by rniwa@webkit.org
  • 3 edits in trunk/Websites/perf.webkit.org

Perf dashboard erroneously shows an old OS build in A/B testing range
​https://bugs.webkit.org/show_bug.cgi?id=149942

Reviewed by Darin Adler.

Ordering OS builds lexicologically turned out be a bad idea since 15A25 falls between 15A242 and 15A251.
Use a fake/synthetic timestamp to force the commonly understood total order instead.

Refactored pull-os-versions.py to share the server config JSON with other scripts. Also made the script
support pulling multiple sources; e.g. both OS X and iOS.

Also removed superfluous feature to submit results in chunks. The perf dashboard can handle thousands of
revisions being submitted at once just fine.

  • public/api/commits.php:

(main): A partial revert of r185574 since we no longer need to order builds lexicologically.

  • tools/pull-os-versions.py:

(main): Takes --os-config-json, --server-config-json, and --seconds-to-sleep as arguments instead of
a single --config argument to share the server config JSON with other scripts.
(OSBuildFetcher): Extracted out of main. This class is instantiated for each OS kind (e.g. OS X).
(OSBuildFetcher.init): Added.
(OSBuildFetcher._fetch_available_builds): Extracted out of main. Fetches available builds from a website
or custom commands.
(OSBuildFetcher.fetch_and_report_new_builds): Extracted out of main. Submits the fetched builds after
filtering out the ones we've already reported.
(OSBuildFetcher._assign_fake_timestamps): Creates a fake timestamp to establish a total order amongst each
OS X / iOS style build number such as 12A3456b.

12:59 PM Changeset in webkit [190816] by commit-queue@webkit.org
  • 8 edits
    14 adds in trunk

Dynamic background color changes do not update until a layout is forced
​https://bugs.webkit.org/show_bug.cgi?id=131623

Source/WebCore:

Compute correct repaint rect for decorated RenderSVGRoots.

The current implementation of clippedOverflowRectForRepaint() uses the
generic repaint-rect calculations in SVGRenderSupport. Those in turn make
use of repaintRectInLocalCoordinates(), which for RenderSVGRoot is the
union of the painted children (w/ some expansion). If there're no children,
or they do not fill the entire content box, then a repaint would not
repaint the correct parts.
Fix by calculating the union of the border-box and the SVG content
when the SVG root is decorated (has background/border/etc.)

Adapted from a Chromium patch by ​fs@opera.com
​https://src.chromium.org/viewvc/blink?revision=170890&view=revision

Patch by Antoine Quint <Antoine Quint> on 2015-10-09
Reviewed by Darin Adler.

Tests: svg/repaint/add-background-property-on-root.html

svg/repaint/add-border-property-on-root.html
svg/repaint/add-outline-property-on-root.html
svg/repaint/change-background-color.html
svg/repaint/remove-background-property-on-root.html
svg/repaint/remove-border-property-on-root.html
svg/repaint/remove-outline-property-on-root.html

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::styleDidChange):
(WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):

LayoutTests:

Add some new tests checking that dynamically updating the "background",
"border" and "outline" CSS properties repaint correctly and rebase a few
existing tests that yield the same rendered results but slightly different
DRT output.

Patch by Antoine Quint <Antoine Quint> on 2015-10-09
Reviewed by Darin Adler.

  • platform/mac/fast/repaint/moving-shadow-on-container-expected.txt:
  • platform/mac/svg/custom/simple-text-double-shadow-expected.txt:
  • svg/css/composite-shadow-example-expected.txt:
  • svg/css/composite-shadow-with-opacity-expected.txt:
  • svg/repaint/add-background-property-on-root-expected.html: Added.
  • svg/repaint/add-background-property-on-root.html: Added.
  • svg/repaint/add-border-property-on-root-expected.html: Added.
  • svg/repaint/add-border-property-on-root.html: Added.
  • svg/repaint/add-outline-property-on-root-expected.html: Added.
  • svg/repaint/add-outline-property-on-root.html: Added.
  • svg/repaint/change-background-color-expected.html: Added.
  • svg/repaint/change-background-color.html: Added.
  • svg/repaint/remove-background-property-on-root-expected.html: Added.
  • svg/repaint/remove-background-property-on-root.html: Added.
  • svg/repaint/remove-border-property-on-root-expected.html: Added.
  • svg/repaint/remove-border-property-on-root.html: Added.
  • svg/repaint/remove-outline-property-on-root-expected.html: Added.
  • svg/repaint/remove-outline-property-on-root.html: Added.
  • svg/repaint/repaint-webkit-svg-shadow-expected.txt:
12:58 PM Changeset in webkit [190815] by bshafiei@apple.com
  • 18 edits in branches/safari-601.1.46-branch

Roll out r190434. rdar://problem/22865007

12:56 PM Changeset in webkit [190814] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46-branch/LayoutTests

Roll out r190438. rdar://problem/22865007

12:55 PM Changeset in webkit [190813] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Roll out r190447. rdar://problem/22865007

12:53 PM Changeset in webkit [190812] by bshafiei@apple.com
  • 19 edits in branches/safari-601.1.46-branch

Roll out r190604. rdar://problem/22993012

11:41 AM Changeset in webkit [190811] by Lucas Forschler
  • 2 edits in branches/safari-601-branch/Source/WebCore

Merged r189168.

11:36 AM Changeset in webkit [190810] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

[iOS WK2] Fix assertion in ViewportConfiguration::setDefaultConfiguration seen in testing
​https://bugs.webkit.org/show_bug.cgi?id=149959

Reviewed by Tim Horton.

When loading tests which set a flexible viewport, ViewportConfiguration::setDefaultConfiguration()
is called first with testingParameters() and then with webpageParameters(). This
would trigger the assertion that m_defaultConfiguration.initialScaleIsSet but
the new initial scale is zero.

The assertion seems wrong anyway; it's consulting m_defaultConfiguration.initialScaleIsSet
but defaultConfiguration.initialScale, so fix it to test defaultConfiguration.initialScaleIsSet.

  • page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::setDefaultConfiguration):

10:54 AM Changeset in webkit [190809] by ggaren@apple.com
  • 57 edits in trunk/Source/JavaScriptCore

2015-10-09 Geoffrey Garen <​ggaren@apple.com>

Unreviewed, rolling out r190694
​https://bugs.webkit.org/show_bug.cgi?id=148560

Crashes seen on PLT bots and facebook.com.

Reverted changesets:

"CodeBlock should be a GC object"
​https://bugs.webkit.org/show_bug.cgi?id=149727
​http://trac.webkit.org/changeset/190694

10:53 AM Changeset in webkit [190808] by Simon Fraser
  • 1 edit
    3 adds in trunk/LayoutTests

Add some missing iOS results.

  • fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-expected.txt: Added.
  • platform/ios-simulator/compositing/transitions/scale-transition-no-start-expected.txt: Added.
  • platform/ios-simulator/compositing/transitions/singular-scale-transition-expected.txt: Added.
10:31 AM Changeset in webkit [190807] by Lucas Forschler
  • 1 edit in branches/safari-601-branch/LayoutTests/http/tests/cache/disk-cache/disk-cache-last-modified-expected.txt

Rebaseline after r190494.

10:30 AM Changeset in webkit [190806] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Remove two unused WKFrame functions
​https://bugs.webkit.org/show_bug.cgi?id=149958

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameCopyChildFrames): Deleted.
(WKFrameGetParentFrame): Deleted.

  • UIProcess/API/C/WKFrame.h:
10:20 AM Changeset in webkit [190805] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Remove ENABLE_SUID_SANDBOX_LINUX cruft
​https://bugs.webkit.org/show_bug.cgi?id=149954

Reviewed by Darin Adler.

  • Scripts/webkitperl/FeatureList.pm:
10:08 AM Changeset in webkit [190804] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix the !ENABLE(STREAM_API) build after r190794
​https://bugs.webkit.org/show_bug.cgi?id=149955

Reviewed by Darin Adler.

  • bindings/js/WebCoreJSBuiltinInternals.h:

(WebCore::JSBuiltinInternalFunctions::visit):
(WebCore::JSBuiltinInternalFunctions::init):

10:04 AM Changeset in webkit [190803] by Csaba Osztrogonác
  • 11 edits in trunk/Source/WebCore

Fix the binding generator after r190785
​https://bugs.webkit.org/show_bug.cgi?id=149956

Reviewed by Darin Adler.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorHelperMethods):

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::JSTestJSBuiltinConstructorConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodeConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::getConstructData):

9:52 AM Changeset in webkit [190802] by BJ Burg
  • 4 edits in trunk/LayoutTests

Unreviewed, more Mac test gardening after r190629.

These more accurate expectations are based on several days
of builds with the newly-imported Blink tests.

  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
9:31 AM WebKitIDL edited by youenn.fablet@crf.canon.fr
(diff)
8:55 AM Changeset in webkit [190801] by dbates@webkit.org
  • 2 edits in trunk/Tools

Make iOS builders generate debug information in a separate dSYM file
​https://bugs.webkit.org/show_bug.cgi?id=149696

Reviewed by Darin Adler.

Similar to the Mac builders, the iOS builders should write debug information
into a separate dSYM file instead of including such information in the binary
itself (default Xcode behavior)

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CompileWebKit.start):

8:18 AM Changeset in webkit [190800] by Wenson Hsieh
  • 5 edits
    2 adds in trunk

Backgrounds bleed out of natively rendered text fields
​https://bugs.webkit.org/show_bug.cgi?id=149843
<rdar://problem/22896977>

Reviewed by Darin Adler.

Source/WebCore:

When natively rendering a text field with a background on Mac, the background bleeds out
of the text field's border when the graphics context is scaled (as a result of a retina
display or zoom/scale effects). This is because when we render the text field in bezeled
style within a certain frame, AppKit adds 1 device pixel insets on all sides of the frame,
which renders a text field that is slightly smaller than the frame. To adjust for this, we
inflate the paint rect.

Test: fast/forms/hidpi-textfield-background-bleeding.html

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintTextField):

LayoutTests:

Add a layout test to check that the background of a natively rendered text field
cell does not bleed.

  • TestExpectations:
  • fast/forms/hidpi-textfield-background-bleeding-expected.html: Added.
  • fast/forms/hidpi-textfield-background-bleeding.html: Added.
7:22 AM Changeset in webkit [190799] by matthew_hanson@apple.com
  • 19 edits in branches/safari-601.1.46-branch

Merge r190604. rdar://problem/22993012

7:22 AM Changeset in webkit [190798] by matthew_hanson@apple.com
  • 3 edits
    3 adds in branches/safari-601.1.46-branch

Merge r190602. rdar://problem/22995810

7:22 AM Changeset in webkit [190797] by matthew_hanson@apple.com
  • 7 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r190568. rdar://problem/22974825

7:22 AM Changeset in webkit [190796] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r190512. rdar://problem/22974818

7:21 AM Changeset in webkit [190795] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r190447. rdar://problem/22865007

7:21 AM Changeset in webkit [190794] by youenn.fablet@crf.canon.fr
  • 19 edits
    2 adds in trunk/Source

Source/JavaScriptCore:
Automate WebCore JS builtins generation and build system
​https://bugs.webkit.org/show_bug.cgi?id=149751

Reviewed by Darin Adler.

  • generate-js-builtins: updating the part related to WebCore JS binding.

Source/WebCore:
Refactor WebCore JS builtins to prepare for automatic generation
​https://bugs.webkit.org/show_bug.cgi?id=149751

Reviewed by Darin Adler.

Adding annotations to JS files to know whether they should be under a compilation flag and
whether they are JS internals or JS tied to WebIDL.
If a file is said as JS internals, all function names should be exported automatically.
Added WebCoreJSBuiltins.h to simplify handling of builtins in JSVMClientData.
Added WebCoreJSInternals.h to simplify handling of builtin private function in JSDOMWindowBase.
Renamed WebCoreJSClientData to JSVMClientData.

Covered by existing tests.

  • CMakeLists.txt:
  • Modules/streams/ByteLengthQueuingStrategy.js:
  • Modules/streams/CountQueuingStrategy.js:
  • Modules/streams/ReadableStream.js:
  • Modules/streams/ReadableStreamController.js:
  • Modules/streams/ReadableStreamInternals.js:
  • Modules/streams/ReadableStreamReader.js:
  • WebCore.order:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::normalWorld):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::finishCreation):
(WebCore::JSDOMWindowBase::visitChildren):
(WebCore::JSDOMWindowBase::fireFrameClearedWatchpointsForWindow):
(WebCore::JSDOMWindowBase::destroy): Deleted.

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::getAllWorlds):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::transferArrayBuffers):

  • bindings/js/WebCoreJSBuiltinInternals.h: Added.

(WebCore::JSBuiltinInternalFunctions::JSBuiltinInternalFunctions):
(WebCore::JSBuiltinInternalFunctions::readableStreamInternals):
(WebCore::JSBuiltinInternalFunctions::visit):
(WebCore::JSBuiltinInternalFunctions::init):

  • bindings/js/WebCoreJSBuiltins.cpp:
  • bindings/js/WebCoreJSBuiltins.h: Added.

(WebCore::JSBuiltinFunctions::JSBuiltinFunctions):
(WebCore::JSBuiltinFunctions::byteLengthQueuingStrategyBuiltins):
(WebCore::JSBuiltinFunctions::countQueuingStrategyBuiltins):
(WebCore::JSBuiltinFunctions::readableStreamBuiltins):
(WebCore::JSBuiltinFunctions::readableStreamControllerBuiltins):
(WebCore::JSBuiltinFunctions::readableStreamInternalsBuiltins):
(WebCore::JSBuiltinFunctions::readableStreamReaderBuiltins):

  • bindings/js/WebCoreJSClientData.h:

(WebCore::JSVMClientData::JSVMClientData):
(WebCore::JSVMClientData::~JSVMClientData):
(WebCore::JSVMClientData::builtinFunctions):
(WebCore::initNormalWorldClientData):
(WebCore::JSVMClientData::normalWorld): Deleted.
(WebCore::JSVMClientData::getAllWorlds): Deleted.

7:21 AM Changeset in webkit [190793] by matthew_hanson@apple.com
  • 3 edits in branches/safari-601.1.46-branch/LayoutTests

Merge r190438. rdar://problem/22865007

7:21 AM Changeset in webkit [190792] by matthew_hanson@apple.com
  • 18 edits in branches/safari-601.1.46-branch

Merge r190434. rdar://problem/22865007

7:21 AM Changeset in webkit [190791] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r189979. rdar://problem/23033080

7:21 AM Changeset in webkit [190790] by matthew_hanson@apple.com
  • 12 edits in branches/safari-601.1.46-branch/Source

Merge r189834. rdar://problem/22807373

7:21 AM Changeset in webkit [190789] by matthew_hanson@apple.com
  • 3 edits
    1 add in branches/safari-601.1.46-branch/Source/WTF

Merge r189633. rdar://problem/22824424

7:21 AM Changeset in webkit [190788] by matthew_hanson@apple.com
  • 3 edits in branches/safari-601.1.46-branch/Source/JavaScriptCore

Merge r189460. rdar://problem/22823239

7:21 AM Changeset in webkit [190787] by matthew_hanson@apple.com
  • 15 edits
    2 adds in branches/safari-601.1.46-branch/Source/JavaScriptCore

Merge r189454. rdar://problem/22823239

7:21 AM Changeset in webkit [190786] by matthew_hanson@apple.com
  • 9 edits
    3 adds in branches/safari-601.1.46-branch

Merge r189421. rdar://problem/22823243

6:44 AM Changeset in webkit [190785] by youenn.fablet@crf.canon.fr
  • 11 edits in trunk/Source/WebCore

Rationalize JSXXConstructor class definition
​https://bugs.webkit.org/show_bug.cgi?id=149923

Reviewed by Darin Adler.

Declaration of JSXXConstructor::construct and JSXXConstructor::getConstructData
as long as JSXX is constructable from JavaScript.

Previously, JSXXConstructor::construct was not generated in case of CustomConstructor.
It is now generated and directly calls the custom constructor function.

getConstructData was declared conditionally with #if in case of ConstructorConditional.
The #if are now within getConstructData body.

Covered by binding tests.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDeclaration):
(GenerateOverloadedConstructorDefinition):
(GenerateConstructorDefinition):
(GenerateConstructorHelperMethods):
(GenerateConstructorDefinitions):.

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::construct):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::getConstructData):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::finishCreation):.

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::construct):
(WebCore::JSTestEventConstructorConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::construct):
(WebCore::JSTestInterfaceConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::JSTestJSBuiltinConstructorConstructor::construct):
(WebCore::JSTestJSBuiltinConstructorConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::construct):
(WebCore::JSTestNamedConstructorNamedConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodeConstructor::construct):
(WebCore::JSTestNodeConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::construct):
(WebCore::JSTestObjConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::constructJSTestOverloadedConstructors1):
(WebCore::constructJSTestOverloadedConstructors2):
(WebCore::constructJSTestOverloadedConstructors3):
(WebCore::constructJSTestOverloadedConstructors4):
(WebCore::constructJSTestOverloadedConstructors5):
(WebCore::JSTestOverloadedConstructorsConstructor::construct):
(WebCore::JSTestOverloadedConstructorsConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::construct):
(WebCore::JSTestTypedefsConstructor::getConstructData):

5:56 AM Changeset in webkit [190784] by svillar@igalia.com
  • 3 edits in trunk/Source/WebCore

[css-grid] Include freeSpace in GridSizingData struct
​https://bugs.webkit.org/show_bug.cgi?id=149876

Reviewed by Darin Adler.

During the layout process we keep the free space for rows and
columns in two variables that are passed to a few methods
along with the GridSizingData struct. Those two variables
should clearly be part of GridSizingData as they're temporary
values used just for the sake of the layout.

No new tests required as this is just a refactoring.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::GridSizingData::GridSizingData):
(WebCore::RenderGrid::GridSizingData::freeSpaceForDirection):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::applyStretchAlignmentToTracksIfNeeded):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::populateGridPositions):
(WebCore::contentDistributionOffset):
(WebCore::RenderGrid::computeContentPositionAndDistributionOffset):

  • rendering/RenderGrid.h:
5:47 AM Changeset in webkit [190783] by svillar@igalia.com
  • 3 edits in trunk/Source/WebCore

[css-grid] Remove unneeded calls to compute(Content)LogicalWidth(Height)
​https://bugs.webkit.org/show_bug.cgi?id=149926

Reviewed by Darin Adler.

In order to resolve a Length to a LayoutUnit we need to
provide a maximum value so that i.e. percentages are correctly
computed. That maximum value was computeLogicalWidth() for
columns and computeContentLogicalHeight() for rows. We were
calling it for every single track with a definite size instead
of computing it once and reusing it multiple times.

This brings some nice performance improvements:

  • 2.9% in /Layout/fixed-grid-lots-of-data
  • 2.95% in /Layout/fixed-grid-lots-of-stretched-data

No new tests required as there is no change in functionality.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::computeUsedBreadthOfMinLength):
(WebCore::RenderGrid::computeUsedBreadthOfMaxLength):
(WebCore::RenderGrid::tracksAreWiderThanMinTrackBreadth):

  • rendering/RenderGrid.h:
2:07 AM Changeset in webkit [190782] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Fix webkitpy tests after r190779
​https://bugs.webkit.org/show_bug.cgi?id=149949

Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/benchmark_runner/benchmark_results.py:

(BenchmarkResults.format):
(BenchmarkResults._format_values):

1:18 AM Changeset in webkit [190781] by Gyuyoung Kim
  • 4 edits in trunk

[CMake] Remove ENABLE_SUBPIXEL_LAYOUT macro
​https://bugs.webkit.org/show_bug.cgi?id=149947

Reviewed by Csaba Osztrogonác.

ENABLE(SUBPIXEL_LAYOUT) was removed though, it is still alive in .cmake.
Removed it.

  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Oct 8, 2015:

11:01 PM Changeset in webkit [190780] by Nikita Vasilyev
  • 5 edits in trunk

Web Inspector: Stack trace view doesn't properly display lines without function names
​https://bugs.webkit.org/show_bug.cgi?id=149922

Source/WebInspectorUI:

Reviewed by Timothy Hatcher.

  • UserInterface/Models/StackTrace.js:

(WebInspector.StackTrace._parseStackTrace):
(WebInspector.StackTrace._parseLocation): Added.

LayoutTests:

Test an anomymous function.

Reviewed by Timothy Hatcher.

  • inspector/debugger/js-stacktrace-expected.txt: Also, rebaseline one old test.
  • inspector/debugger/js-stacktrace.html:
10:53 PM Changeset in webkit [190779] by Dewei Zhu
  • 4 edits in trunk/Tools

Extend run-benchmark script to support human-readable results conversion.
​https://bugs.webkit.org/show_bug.cgi?id=149944

Reviewed by Ryosuke Niwa.

Add '--read-results-json' and '--no-adjust-unit' options.
'--read-results-json' option converts result file to human readable format.
'--no-adjust-unit' option skips scientific notation convertion.
'--platform' defaults to 'osx' and '--browser' defaults to 'safari'.

  • Scripts/webkitpy/benchmark_runner/benchmark_results.py:

(BenchmarkResults.format):
(BenchmarkResults._format_tests):
(BenchmarkResults._format_values):

  • Scripts/webkitpy/benchmark_runner/benchmark_runner.py:

(BenchmarkRunner.init):
(BenchmarkRunner._run_benchmark):
(BenchmarkRunner._dump):
(BenchmarkRunner.show_results):
(BenchmarkRunner._show_results): Deleted.

  • Scripts/webkitpy/benchmark_runner/run_benchmark.py:

(parse_args):
(start):

10:46 PM Changeset in webkit [190778] by aestes@apple.com
  • 31 edits
    3 copies
    2 moves
    11 adds in branches/safari-601.1.46-branch

Merge r188486, r188517, r188531, r188844, r188845, r188851, r188852, r188880, r188881, r188988, r189193, r189289, and r190133.
rdar://problem/22846460

Source/WebCore:

2015-08-26 Andy Estes <​aestes@apple.com>

[Content Filtering] Determine navigation and content policy before continuing to filter a load
​https://bugs.webkit.org/show_bug.cgi?id=148506

Reviewed by Brady Eidson.

Prior to this change, ContentFilter would hide from DocumentLoader all CachedRawResourceClient callbacks until
a decision was made, then replay the missed callbacks. This approach interacted poorly with some features of
the loader, notably appcache and downloads. In the case of appcache, DocumentLoader might not have a chance to
check for substitute data until the original load has finished, wasting bandwidth, and might receive duplicate
or out-of-order callbacks. In the case of downloads, it would often be too late to convert the existing
connection to a download, leading to restarted downloads or outright failures.

Bandaids were put in place for these issues in r188150, r188486, and r188851 to fix crashes or serious
regressions in behavior, but these weren't complete fixes. They did not solve any of the duplicate data loading
problems, and they did not make downloads work reliably in all cases.

This patch rolls out the bandaids (but keeps their tests) and replaces them with a more robust fix. Instead of
hiding callbacks from DocumentLoader, ContentFilter now delivers willSendRequest(), redirectReceived(), and
responseReceived() to DocumentLoader immediately, and cancels filtering if DocumentLoader decides to ignore the
load, download it, or load substitute data. ContentFilter continues to buffer incoming data to prevent partial
rendering of blocked content.

The existing tests for r188150 and r188851 were kept, the test for r188486 was rewritten to be specific to
content filtering, and new tests were added to cover the case where ContentFilter is still undecided after a
load finishes.

Tests: contentfiltering/allow-never.html

contentfiltering/block-never.html
ContentFiltering.AllowDownloadAfterAddData
ContentFiltering.AllowDownloadAfterFinishedAddingData
ContentFiltering.AllowDownloadAfterRedirect
ContentFiltering.AllowDownloadAfterResponse
ContentFiltering.AllowDownloadAfterWillSendRequest
ContentFiltering.AllowDownloadNever
ContentFiltering.BlockDownloadAfterAddData
ContentFiltering.BlockDownloadAfterFinishedAddingData
ContentFiltering.BlockDownloadAfterRedirect
ContentFiltering.BlockDownloadAfterResponse
ContentFiltering.BlockDownloadAfterWillSendRequest
ContentFiltering.BlockDownloadNever

  • bindings/js/JSMockContentFilterSettingsCustom.cpp: (WebCore::JSMockContentFilterSettings::decisionPoint): Taught to handle DecisionPoint::Never, and rewrote to not need a set of const uint8_ts that mirror the DecisionPoint enum. (WebCore::JSMockContentFilterSettings::setDecisionPoint): Ditto. (WebCore::toJSValue): Rewrote to not need a set of const uint8_ts that mirror the Decision enum. (WebCore::toDecision): Ditto.
  • loader/ContentFilter.cpp: (WebCore::ContentFilter::createIfEnabled): Renamed from createIfNeeded, and changed to take a DocumentLoader& instead of a DecisionFunction. (WebCore::ContentFilter::ContentFilter): (WebCore::ContentFilter::responseReceived): If m_state != Blocked after filtering, call DocumentLoader::responseReceived(). (WebCore::ContentFilter::dataReceived): If m_state == Allowed after filtering, deliver buffered data to DocumentLoader. If no filtering was necessary, call DocumentLoader::dataReceived() directly. (WebCore::ContentFilter::redirectReceived): If m_state != Blocked after filtering, call DocumentLoader::redirectReceived(). (WebCore::ContentFilter::notifyFinished): If an error occured, call DocumentLoader::notifyFinished() immediately and return. If m_state != Blocked after filtering, deliver buffered data to DocumentLoader and call DocumentLoader::notifyFinished(). If no filtering was necessary and m_state != Blocked, call DocumentLoader::notifyFinished() directly. (WebCore::ContentFilter::didDecide): Called DocumentLoader::contentFilterDidDecide() instead of m_decisionFunction(). (WebCore::ContentFilter::deliverResourceData): Added a helper function to deliver buffered data to DocumentLoader. (WebCore::ContentFilter::createIfNeeded): Renamed to createIfEnabled().
  • loader/ContentFilter.h:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::willSendRequest): Stopped asserting that redirectResponse is null and made it part of the if condition instead, since willSendRequest() will now be called on redirects when there is an active ContentFilter. (WebCore::DocumentLoader::startLoadingMainResource): Called becomeMainResourceClient() instead of becomeMainResourceClientIfFilterAllows(). (WebCore::DocumentLoader::becomeMainResourceClient): Renamed from becomeMainResourceClientIfFilterAllows(). Only called ContentFilter::startFilteringMainResource() if the filter state is Initialized, since ContentFilter might have already made a decision in willSendRequest(). (WebCore::DocumentLoader::contentFilterDidDecide): Stopped deleting m_contentFilter, since it will continue to deliver callbacks even after making a decision. Fixed a bug where we were creating two copies of ContentFilter's replacement data. (WebCore::DocumentLoader::syntheticRedirectReceived): Deleted. (WebCore::DocumentLoader::becomeMainResourceClientIfFilterAllows): Renamed to becomeMainResourceClient().
  • loader/DocumentLoader.h:
  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequestInternal): Removed part of r188851.
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): Removed part of r188486.
  • loader/SubresourceLoader.h:
  • loader/cache/CachedRawResource.cpp: (WebCore::CachedRawResource::didAddClient): Removed part of r188150.
  • loader/cache/CachedRawResourceClient.h: (WebCore::CachedRawResourceClient::syntheticRedirectReceived): Removed part of r188150.
  • testing/MockContentFilterSettings.h: Defined DecisionPoint::Never.
  • testing/MockContentFilterSettings.idl: Defined DECISION_POINT_NEVER.

Source/WebKit2:

2015-08-11 Andy Estes <​aestes@apple.com>

[Cocoa] Add redirect support to CustomProtocolManager
​https://bugs.webkit.org/show_bug.cgi?id=147871

Reviewed by Dan Bernstein.

NSURLProtocols have the ability to generate redirect responses. This change teaches CustomProtocolManager how to handle them.

  • Shared/Network/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm: (WebKit::CustomProtocolManager::wasRedirectedToRequest): Called -URLProtocol:wasRedirectedToRequest:redirectResponse: on the NSURLProtocolClient.
  • Shared/Network/CustomProtocols/CustomProtocolManager.h:
  • Shared/Network/CustomProtocols/CustomProtocolManager.messages.in: Defined WasRedirectedToRequest.
  • Shared/Network/CustomProtocols/soup/CustomProtocolManagerSoup.cpp: (WebKit::CustomProtocolManager::wasRedirectedToRequest): Defined empty function.
  • UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm: (-[WKCustomProtocolLoader connection:willSendRequest:redirectResponse:]): If a redirect response is received, send WasRedirectedToRequest and return nil to ignore the redirect.

Tools:

2015-09-22 Andy Estes <​aestes@apple.com>

ContentFiltering.AllowDownloadAfterAddData is very flaky
​https://bugs.webkit.org/show_bug.cgi?id=148885
<rdar://problem/22729563>

Reviewed by Alexey Proskuryakov.

The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
but there is no guarantee of this. For tests that should allow a download, spin the runloop until
-_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.

  • TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: (downloadTest):

2015-08-26 Andy Estes <​aestes@apple.com>

[Content Filtering] Determine navigation and content policy before continuing to filter a load
​https://bugs.webkit.org/show_bug.cgi?id=148506

Reviewed by Brady Eidson.

Added download API tests covering every decision and decision point.
Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.

  • TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
  • TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
  • TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter decision and decision point as a bundle parameter. (+[MockContentFilterEnabler supportsSecureCoding]): (-[MockContentFilterEnabler copyWithZone:]): (-[MockContentFilterEnabler initWithCoder:]): (-[MockContentFilterEnabler initWithDecision:decisionPoint:]): (-[MockContentFilterEnabler encodeWithCoder:]): (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings. (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect. (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload. (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true. (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto. (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true. (downloadTest): Added a helper function to test downloads with a given decision and decision point.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport. (+[MockContentFilterEnabler supportsSecureCoding]): (-[MockContentFilterEnabler copyWithZone:]): (-[MockContentFilterEnabler initWithCoder:]): (-[MockContentFilterEnabler dealloc]): (-[MockContentFilterEnabler encodeWithCoder:]): (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path. (-[ContentFilteringPlugIn dealloc]): Stop observing. (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler. (+[ServerRedirectPlugIn initialize]): Deleted.
  • TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted. (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted. (TEST): Deleted.

2015-08-26 Andy Estes <​aestes@apple.com>

Crash when following a Google search link to Twitter with Limit Adult Content enabled
​https://bugs.webkit.org/show_bug.cgi?id=147651

Rubber-stamped by Brady Eidson.

Taught TestRunner how to decide the navigation policy after a delay.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
  • WebKitTestRunner/InjectedBundle/TestRunner.h: (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::decidePolicyForNavigationAction):
  • WebKitTestRunner/TestController.h: (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
  • WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

2015-08-24 Andy Estes <​aestes@apple.com>

REGRESSION (r188851): WebKit2.BundleParameters fails on iOS

  • TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.

2015-08-23 Andy Estes <​aestes@apple.com>

Addressed a missed piece of review feedback from r188851.

  • TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:

2015-08-23 Andy Estes <​aestes@apple.com>

[Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
​https://bugs.webkit.org/show_bug.cgi?id=147872
rdar://problem/22044000

Reviewed by Dan Bernstein.

Added an API test.

  • TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added. (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL. (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL. (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]): (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added. (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
  • TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
  • TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.

2015-08-23 Andy Estes <​aestes@apple.com>

Fixed the 32-bit Mac build after r188844.

  • TestWebKitAPI/WKWebViewConfigurationExtras.h:
  • TestWebKitAPI/WKWebViewConfigurationExtras.mm:

2015-08-22 Andy Estes <​aestes@apple.com>

[Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=148317

Reviewed by Dan Bernstein.

Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
when creating WKWebViews.

Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
added a new API test for bundle parameters.

  • TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and named its executable TestWebKitAPI.bundle.
  • TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
  • TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added. (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
  • TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added. (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a bundle parameter and asked for an initial notification. (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter. (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes, mirror its value in the main frame's JSContext.
  • TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
  • TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added. (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
  • TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
  • TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
  • TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added. (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance. (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response. (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.

2015-08-11 Andy Estes <​aestes@apple.com>

[Cocoa] Add redirect support to CustomProtocolManager
​https://bugs.webkit.org/show_bug.cgi?id=147871

Reviewed by Dan Bernstein.

Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.

  • TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: (TestWebKitAPI::TEST): Unregesitered TestProtocol.
  • TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
  • TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL. (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto. (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL. (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false. (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
  • TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: (TestWebKitAPI::TEST): Unregistered TestProtocol.
  • TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http. (+[TestProtocol canInitWithRequest:]): Changed to use property syntax. (-[TestProtocol startLoading]): Taught to handle redirect responses.

2015-08-13 Andy Estes <​aestes@apple.com>

[Cocoa] Downloads do not start if policy decision is made asynchronously
​https://bugs.webkit.org/show_bug.cgi?id=147985

Reviewed by Brady Eidson.

Added a new API test.

  • TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): (-[AsynchronousDownloadDelegate _downloadDidStart:]): (TEST):

LayoutTests:

2015-09-03 Andy Estes <​aestes@apple.com>

REGRESSION: http/tests/contentfiltering/block-after-redirect.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=148684

Reviewed by Alexey Proskuryakov.

Wait for the iframe to load the blocked page before finishing the test.

  • http/tests/contentfiltering/block-after-redirect.html:
  • platform/mac-wk2/TestExpectations:

2015-08-26 Andy Estes <​aestes@apple.com>

[Content Filtering] Determine navigation and content policy before continuing to filter a load
​https://bugs.webkit.org/show_bug.cgi?id=148506

Reviewed by Brady Eidson.

Added tests for what happens if the content filter does not make a decision when the load finishes.

  • contentfiltering/allow-never-expected.html: Added.
  • contentfiltering/allow-never.html: Added.
  • contentfiltering/block-never-expected.html: Added.
  • contentfiltering/block-never.html: Added.
  • contentfiltering/resources/contentfiltering.js:

2015-08-26 Andy Estes <​aestes@apple.com>

Crash when following a Google search link to Twitter with Limit Adult Content enabled
​https://bugs.webkit.org/show_bug.cgi?id=147651

Rubber-stamped by Brady Eidson.

Added a layout test.

  • http/tests/contentfiltering/load-substitute-data-from-appcache-expected.txt: Added.
  • http/tests/contentfiltering/load-substitute-data-from-appcache.html: Added.
  • http/tests/contentfiltering/resources/appcache.html: Added.
  • http/tests/contentfiltering/resources/appcache.manifest: Added.
  • platform/mac-wk1/TestExpectations:
10:26 PM Changeset in webkit [190777] by BJ Burg
  • 2 edits in trunk/LayoutTests

http/tests/media/media-source/SourceBuffer-abort-updating.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=149816

Unreviewed, fix updated expectation so it doesn't accidentally cause bots
to run the test on Mavericks (where Media Source is unsupported).

  • platform/mac/TestExpectations:
9:28 PM Changeset in webkit [190776] by dbates@webkit.org
  • 4 edits
    2 adds in trunk/Tools

Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
​https://bugs.webkit.org/show_bug.cgi?id=149945

Reviewed by Dan Bernstein.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOS9@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(table.queue-grid tr.platform.ios-9 img.logo):

9:01 PM Changeset in webkit [190775] by dbates@webkit.org
  • 2 edits in trunk/Tools

Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
​https://bugs.webkit.org/show_bug.cgi?id=149943

Reviewed by Dan Bernstein.

Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
teach build-webkit to install them when building for iOS device using the public iOS SDK.

  • Scripts/build-webkit:
7:37 PM Changeset in webkit [190774] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-601-branch

Merged r190602. rdar://problem/22995830

7:29 PM Changeset in webkit [190773] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-601-branch

Merged r190375. rdar://problem/22881748

7:26 PM Changeset in webkit [190772] by Lucas Forschler
  • 2 edits
    1 copy in branches/safari-601-branch/Tools

Merged r190358. rdar://problem/23016109

7:18 PM Changeset in webkit [190771] by Lucas Forschler
  • 3 edits in branches/safari-601-branch

Merged r189976. rdar://problem/22824652

7:16 PM Changeset in webkit [190770] by Lucas Forschler
  • 4 edits in branches/safari-601-branch

Merged r189976. rdar://problem/22824652

7:06 PM Changeset in webkit [190769] by aestes@apple.com
  • 5 edits in branches/safari-601-branch

Included a Radar link in the ChangeLogs for r190766.

6:56 PM Changeset in webkit [190768] by Lucas Forschler
  • 3 edits
    1 copy in branches/safari-601-branch/Source/WTF

Merged r189633. rdar://problem/22824646

6:50 PM Changeset in webkit [190767] by Lucas Forschler
  • 2 edits in branches/safari-601-branch/Source/WTF

Merged r188489. rdar://problem/22824646

6:33 PM Changeset in webkit [190766] by aestes@apple.com
  • 43 edits
    3 copies
    2 moves
    15 adds in branches/safari-601-branch

Merge r188150, r188517, r188844, r188845, r188851, r188852, r188880, r188881, r188988, r189193, r189289, and r190133.

Source/WebCore:

2015-08-26 Andy Estes <​aestes@apple.com>

[Content Filtering] Determine navigation and content policy before continuing to filter a load
​https://bugs.webkit.org/show_bug.cgi?id=148506

Reviewed by Brady Eidson.

Prior to this change, ContentFilter would hide from DocumentLoader all CachedRawResourceClient callbacks until
a decision was made, then replay the missed callbacks. This approach interacted poorly with some features of
the loader, notably appcache and downloads. In the case of appcache, DocumentLoader might not have a chance to
check for substitute data until the original load has finished, wasting bandwidth, and might receive duplicate
or out-of-order callbacks. In the case of downloads, it would often be too late to convert the existing
connection to a download, leading to restarted downloads or outright failures.

Bandaids were put in place for these issues in r188150, r188486, and r188851 to fix crashes or serious
regressions in behavior, but these weren't complete fixes. They did not solve any of the duplicate data loading
problems, and they did not make downloads work reliably in all cases.

This patch rolls out the bandaids (but keeps their tests) and replaces them with a more robust fix. Instead of
hiding callbacks from DocumentLoader, ContentFilter now delivers willSendRequest(), redirectReceived(), and
responseReceived() to DocumentLoader immediately, and cancels filtering if DocumentLoader decides to ignore the
load, download it, or load substitute data. ContentFilter continues to buffer incoming data to prevent partial
rendering of blocked content.

The existing tests for r188150 and r188851 were kept, the test for r188486 was rewritten to be specific to
content filtering, and new tests were added to cover the case where ContentFilter is still undecided after a
load finishes.

Tests: contentfiltering/allow-never.html

contentfiltering/block-never.html
ContentFiltering.AllowDownloadAfterAddData
ContentFiltering.AllowDownloadAfterFinishedAddingData
ContentFiltering.AllowDownloadAfterRedirect
ContentFiltering.AllowDownloadAfterResponse
ContentFiltering.AllowDownloadAfterWillSendRequest
ContentFiltering.AllowDownloadNever
ContentFiltering.BlockDownloadAfterAddData
ContentFiltering.BlockDownloadAfterFinishedAddingData
ContentFiltering.BlockDownloadAfterRedirect
ContentFiltering.BlockDownloadAfterResponse
ContentFiltering.BlockDownloadAfterWillSendRequest
ContentFiltering.BlockDownloadNever

  • bindings/js/JSMockContentFilterSettingsCustom.cpp: (WebCore::JSMockContentFilterSettings::decisionPoint): Taught to handle DecisionPoint::Never, and rewrote to not need a set of const uint8_ts that mirror the DecisionPoint enum. (WebCore::JSMockContentFilterSettings::setDecisionPoint): Ditto. (WebCore::toJSValue): Rewrote to not need a set of const uint8_ts that mirror the Decision enum. (WebCore::toDecision): Ditto.
  • loader/ContentFilter.cpp: (WebCore::ContentFilter::createIfEnabled): Renamed from createIfNeeded, and changed to take a DocumentLoader& instead of a DecisionFunction. (WebCore::ContentFilter::ContentFilter): (WebCore::ContentFilter::responseReceived): If m_state != Blocked after filtering, call DocumentLoader::responseReceived(). (WebCore::ContentFilter::dataReceived): If m_state == Allowed after filtering, deliver buffered data to DocumentLoader. If no filtering was necessary, call DocumentLoader::dataReceived() directly. (WebCore::ContentFilter::redirectReceived): If m_state != Blocked after filtering, call DocumentLoader::redirectReceived(). (WebCore::ContentFilter::notifyFinished): If an error occured, call DocumentLoader::notifyFinished() immediately and return. If m_state != Blocked after filtering, deliver buffered data to DocumentLoader and call DocumentLoader::notifyFinished(). If no filtering was necessary and m_state != Blocked, call DocumentLoader::notifyFinished() directly. (WebCore::ContentFilter::didDecide): Called DocumentLoader::contentFilterDidDecide() instead of m_decisionFunction(). (WebCore::ContentFilter::deliverResourceData): Added a helper function to deliver buffered data to DocumentLoader. (WebCore::ContentFilter::createIfNeeded): Renamed to createIfEnabled().
  • loader/ContentFilter.h:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::willSendRequest): Stopped asserting that redirectResponse is null and made it part of the if condition instead, since willSendRequest() will now be called on redirects when there is an active ContentFilter. (WebCore::DocumentLoader::startLoadingMainResource): Called becomeMainResourceClient() instead of becomeMainResourceClientIfFilterAllows(). (WebCore::DocumentLoader::becomeMainResourceClient): Renamed from becomeMainResourceClientIfFilterAllows(). Only called ContentFilter::startFilteringMainResource() if the filter state is Initialized, since ContentFilter might have already made a decision in willSendRequest(). (WebCore::DocumentLoader::contentFilterDidDecide): Stopped deleting m_contentFilter, since it will continue to deliver callbacks even after making a decision. Fixed a bug where we were creating two copies of ContentFilter's replacement data. (WebCore::DocumentLoader::syntheticRedirectReceived): Deleted. (WebCore::DocumentLoader::becomeMainResourceClientIfFilterAllows): Renamed to becomeMainResourceClient().
  • loader/DocumentLoader.h:
  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequestInternal): Removed part of r188851.
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): Removed part of r188486.
  • loader/SubresourceLoader.h:
  • loader/cache/CachedRawResource.cpp: (WebCore::CachedRawResource::didAddClient): Removed part of r188150.
  • loader/cache/CachedRawResourceClient.h: (WebCore::CachedRawResourceClient::syntheticRedirectReceived): Removed part of r188150.
  • testing/MockContentFilterSettings.h: Defined DecisionPoint::Never.
  • testing/MockContentFilterSettings.idl: Defined DECISION_POINT_NEVER.

Source/WebKit/mac:

2015-08-26 Andy Estes <​aestes@apple.com>

[Content Filtering] Determine navigation and content policy before continuing to filter a load
​https://bugs.webkit.org/show_bug.cgi?id=148506

Reviewed by Brady Eidson.

Deleted parts of r188486 and r188851.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::convertMainResourceLoadToDownload): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):

Source/WebKit2:

2015-08-26 Andy Estes <​aestes@apple.com>

[Content Filtering] Determine navigation and content policy before continuing to filter a load
​https://bugs.webkit.org/show_bug.cgi?id=148506

Reviewed by Brady Eidson.

Deleted parts of r188486 and r188851.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::convertMainResourceLoadToDownload):

2015-08-11 Andy Estes <​aestes@apple.com>

[Cocoa] Add redirect support to CustomProtocolManager
​https://bugs.webkit.org/show_bug.cgi?id=147871

Reviewed by Dan Bernstein.

NSURLProtocols have the ability to generate redirect responses. This change teaches CustomProtocolManager how to handle them.

  • Shared/Network/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm: (WebKit::CustomProtocolManager::wasRedirectedToRequest): Called -URLProtocol:wasRedirectedToRequest:redirectResponse: on the NSURLProtocolClient.
  • Shared/Network/CustomProtocols/CustomProtocolManager.h:
  • Shared/Network/CustomProtocols/CustomProtocolManager.messages.in: Defined WasRedirectedToRequest.
  • Shared/Network/CustomProtocols/soup/CustomProtocolManagerSoup.cpp: (WebKit::CustomProtocolManager::wasRedirectedToRequest): Defined empty function.
  • UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm: (-[WKCustomProtocolLoader connection:willSendRequest:redirectResponse:]): If a redirect response is received, send WasRedirectedToRequest and return nil to ignore the redirect.

Tools:

2015-09-22 Andy Estes <​aestes@apple.com>

ContentFiltering.AllowDownloadAfterAddData is very flaky
​https://bugs.webkit.org/show_bug.cgi?id=148885
<rdar://problem/22729563>

Reviewed by Alexey Proskuryakov.

The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
but there is no guarantee of this. For tests that should allow a download, spin the runloop until
-_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.

  • TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: (downloadTest):

2015-08-26 Andy Estes <​aestes@apple.com>

[Content Filtering] Determine navigation and content policy before continuing to filter a load
​https://bugs.webkit.org/show_bug.cgi?id=148506

Reviewed by Brady Eidson.

Added download API tests covering every decision and decision point.
Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.

  • TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
  • TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
  • TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter decision and decision point as a bundle parameter. (+[MockContentFilterEnabler supportsSecureCoding]): (-[MockContentFilterEnabler copyWithZone:]): (-[MockContentFilterEnabler initWithCoder:]): (-[MockContentFilterEnabler initWithDecision:decisionPoint:]): (-[MockContentFilterEnabler encodeWithCoder:]): (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings. (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect. (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload. (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true. (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto. (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true. (downloadTest): Added a helper function to test downloads with a given decision and decision point.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport. (+[MockContentFilterEnabler supportsSecureCoding]): (-[MockContentFilterEnabler copyWithZone:]): (-[MockContentFilterEnabler initWithCoder:]): (-[MockContentFilterEnabler dealloc]): (-[MockContentFilterEnabler encodeWithCoder:]): (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path. (-[ContentFilteringPlugIn dealloc]): Stop observing. (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler. (+[ServerRedirectPlugIn initialize]): Deleted.
  • TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted. (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted. (TEST): Deleted.

2015-08-26 Andy Estes <​aestes@apple.com>

Crash when following a Google search link to Twitter with Limit Adult Content enabled
​https://bugs.webkit.org/show_bug.cgi?id=147651

Rubber-stamped by Brady Eidson.

Taught TestRunner how to decide the navigation policy after a delay.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
  • WebKitTestRunner/InjectedBundle/TestRunner.h: (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::decidePolicyForNavigationAction):
  • WebKitTestRunner/TestController.h: (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
  • WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

2015-08-24 Andy Estes <​aestes@apple.com>

REGRESSION (r188851): WebKit2.BundleParameters fails on iOS

  • TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.

2015-08-23 Andy Estes <​aestes@apple.com>

Addressed a missed piece of review feedback from r188851.

  • TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:

2015-08-23 Andy Estes <​aestes@apple.com>

[Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
​https://bugs.webkit.org/show_bug.cgi?id=147872
rdar://problem/22044000

Reviewed by Dan Bernstein.

Added an API test.

  • TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added. (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL. (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL. (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]): (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added. (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
  • TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
  • TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.

2015-08-23 Andy Estes <​aestes@apple.com>

Fixed the 32-bit Mac build after r188844.

  • TestWebKitAPI/WKWebViewConfigurationExtras.h:
  • TestWebKitAPI/WKWebViewConfigurationExtras.mm:

2015-08-22 Andy Estes <​aestes@apple.com>

[Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=148317

Reviewed by Dan Bernstein.

Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
when creating WKWebViews.

Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
added a new API test for bundle parameters.

  • TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and named its executable TestWebKitAPI.bundle.
  • TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
  • TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added. (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
  • TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added. (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a bundle parameter and asked for an initial notification. (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter. (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes, mirror its value in the main frame's JSContext.
  • TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
  • TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added. (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
  • TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
  • TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
  • TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added. (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance. (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response. (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.

2015-08-11 Andy Estes <​aestes@apple.com>

[Cocoa] Add redirect support to CustomProtocolManager
​https://bugs.webkit.org/show_bug.cgi?id=147871

Reviewed by Dan Bernstein.

Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.

  • TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: (TestWebKitAPI::TEST): Unregesitered TestProtocol.
  • TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
  • TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL. (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto. (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL. (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false. (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
  • TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: (TestWebKitAPI::TEST): Unregistered TestProtocol.
  • TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http. (+[TestProtocol canInitWithRequest:]): Changed to use property syntax. (-[TestProtocol startLoading]): Taught to handle redirect responses.

2015-08-13 Andy Estes <​aestes@apple.com>

[Cocoa] Downloads do not start if policy decision is made asynchronously
​https://bugs.webkit.org/show_bug.cgi?id=147985

Reviewed by Brady Eidson.

Added a new API test.

  • TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): (-[AsynchronousDownloadDelegate _downloadDidStart:]): (TEST):

LayoutTests:

2015-09-03 Andy Estes <​aestes@apple.com>

REGRESSION: http/tests/contentfiltering/block-after-redirect.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=148684

Reviewed by Alexey Proskuryakov.

Wait for the iframe to load the blocked page before finishing the test.

  • http/tests/contentfiltering/block-after-redirect.html:
  • platform/mac-wk2/TestExpectations:

2015-08-26 Andy Estes <​aestes@apple.com>

[Content Filtering] Determine navigation and content policy before continuing to filter a load
​https://bugs.webkit.org/show_bug.cgi?id=148506

Reviewed by Brady Eidson.

Added tests for what happens if the content filter does not make a decision when the load finishes.

  • contentfiltering/allow-never-expected.html: Added.
  • contentfiltering/allow-never.html: Added.
  • contentfiltering/block-never-expected.html: Added.
  • contentfiltering/block-never.html: Added.
  • contentfiltering/resources/contentfiltering.js:

2015-08-26 Andy Estes <​aestes@apple.com>

Crash when following a Google search link to Twitter with Limit Adult Content enabled
​https://bugs.webkit.org/show_bug.cgi?id=147651

Rubber-stamped by Brady Eidson.

Added a layout test.

  • http/tests/contentfiltering/load-substitute-data-from-appcache-expected.txt: Added.
  • http/tests/contentfiltering/load-substitute-data-from-appcache.html: Added.
  • http/tests/contentfiltering/resources/appcache.html: Added.
  • http/tests/contentfiltering/resources/appcache.manifest: Added.
  • platform/mac-wk1/TestExpectations:
6:13 PM Changeset in webkit [190765] by Lucas Forschler
  • 15 edits
    2 copies in branches/safari-601-branch/Source/JavaScriptCore

Merged r189454. rdar://problem/22802036

6:13 PM Changeset in webkit [190764] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

pull-svn.py fails to sync revisions when SVN credentials is not setup
​https://bugs.webkit.org/show_bug.cgi?id=149941

Reviewed by Chris Dumez.

Added the support for specifying subversion credentials.

Also added the support for pulling from multiple subversion servers. Subversion servers are specified
in a JSON configuration file specified by --svn-config formatted as follows:

[

{

"name": "WebKit",
"url": "​http://svn.webkit.org/repository/webkit",
"username": "webkitten",
"password": "webkitten's password",
"trustCertificate": true,
"accountNameFinderScript":

["python", "/Volumes/Data/WebKit/Tools/Scripts/webkit-patch", "find-users"]

},
...

]

In addition, refactored it to use the shared server config JSON for the dashboard access.

  • tools/pull-svn.py:

(main): Now takes --svn-config-json, --server-config-json, --seconds-to-sleep and --max-fetch-count
as required options instead of seven unnamed arguments.
(fetch_commits_and_submit): Extracted from main. Fetches at most max_fetch_count new revisions from
the subversion server, and submits them in accordance with server_config.
(fetch_commit_and_resolve_author): Now takes a single repository dictionary instead of two separate
arguments for name and URL to pass down the repository's authentication info to fetch_commit.
(fetch_commit): Ditto. Add appropriate arguments when username and passwords are specified.
(resolve_author_name_from_account): Use a list argument instead of a single string argument now that
the argument comes from a JSON instead of sys.argv.

5:47 PM Changeset in webkit [190763] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, build fix for ENABLE(MEDIA_SESSION) after r190030.

  • dom/Document.cpp:

(WebCore::Document::updateIsPlayingMedia):

5:31 PM Changeset in webkit [190762] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Unreviewed, build fixes for ENABLE(MEDIA_SESSION) after r190030.

  • Modules/mediasession/HTMLMediaElementMediaSession.cpp:

(WebCore::HTMLMediaElementMediaSession::session):

  • Modules/mediasession/HTMLMediaElementMediaSession.h:
  • Modules/mediasession/MediaSession.cpp:

(WebCore::MediaSession::controls):

  • Modules/mediasession/MediaSession.h:
5:16 PM WikiStart edited by rniwa@webkit.org
Add a link to the November contributor's meeting (diff)
5:13 PM Changeset in webkit [190761] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG SSA should remove unreachable code
​https://bugs.webkit.org/show_bug.cgi?id=149931

Reviewed by Geoffrey Garen.

Rolled back in with a call to m_state.reset(), which fixes the debug asserts.

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run): Remove unreachable code.

  • dfg/DFGObjectAllocationSinkingPhase.cpp: Deal with the CFG changing.
  • dfg/DFGPutStackSinkingPhase.cpp: Deal with the CFG changing.
5:13 PM November 2015 Meeting created by rniwa@webkit.org
Add a template
4:45 PM Changeset in webkit [190760] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

Gracefully handle XMLDocumentParser being detached by mutation events.
​https://bugs.webkit.org/show_bug.cgi?id=149485
<rdar://problem/22811489>

Source/WebCore:

This is a merge of Blink change 200026,
​https://codereview.chromium.org/1267283002

Patch by Jiewen Tan <​jiewen_tan@apple.com> on 2015-10-08
Reviewed by Darin Adler.

Test: fast/parser/xhtml-dom-character-data-modified-crash.html

  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::createLeafTextNode):
Renamed from enterText() to make it more descriptive.

(WebCore::XMLDocumentParser::updateLeafTextNode):
Renamed from exitText to firm up this stage.

(WebCore::XMLDocumentParser::end):
Gracefully handle stopped states.

(WebCore::XMLDocumentParser::enterText): Deleted.
(WebCore::XMLDocumentParser::exitText): Deleted.

  • xml/parser/XMLDocumentParser.h:

Rename enterText to createLeafTextNode.
Rename exitText to updateLeafTextNode.

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::XMLDocumentParser::characters):
(WebCore::XMLDocumentParser::processingInstruction):
(WebCore::XMLDocumentParser::cdataBlock):
(WebCore::XMLDocumentParser::comment):
(WebCore::XMLDocumentParser::endDocument):
Rename function calls and firm up updateLeafTextNode stage accordingly.

LayoutTests:

Patch by Jiewen Tan <​jiewen_tan@apple.com> on 2015-10-08
Reviewed by Darin Adler.

  • fast/parser/resources/xhtml-overwrite-frame.xhtml: Added.
  • fast/parser/xhtml-dom-character-data-modified-crash-expected.txt: Added.
  • fast/parser/xhtml-dom-character-data-modified-crash.html: Added.
4:34 PM Changeset in webkit [190759] by dbates@webkit.org
  • 6 edits
    2 adds in trunk

Add LLVM binaries for iOS 9 device
​https://bugs.webkit.org/show_bug.cgi?id=149913

Source/JavaScriptCore:

Reviewed by Filip Pizlo.

Look for locally built/binary dropped LLVM headers and libraries when building for iOS device
in WebKitBuild/usr/local.

Currently Mac and iOS look for the locally built/binary dropped LLVM in different directories:
WebKitBuild/usr/local and /usr/local/LLVMForJavaScriptCore, respectively. This difference is
due to dependencies with the Apple internal build system. We should look to resolve the
Apple internal dependencies and standardize on one location for both platforms.

  • Configurations/Base.xcconfig:

Tools:

Reviewed by Filip Pizlo.

Implement support for building LLVM for ARM64-based iOS devices.

  • Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
  • Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean

an existing build earlier in the file such that remove previously built
libraries before building/copying new ones (if applicable).
(fileContains): Moved function outside of if-block.
(isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
(buildLLVM): Added. Extracted machinery to build LLVM into this function and
added logic to build LLVM for ARM64-based iOS devices.
(symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
LLVM into the WebKitBuild directory.

WebKitLibraries:

Rubber-stamped by Filip Pizlo.

Add LLVM 3.6.2 binaries for ARM64-based iOS devices. We make use of LLVM for the FTL,
which is enabled for 64-bit iOS devices.

I built these binaries by performing the following:

1) Check out WebKit to a directory like /some/path/OpenSource.

2) Download and expand the archive <​http://llvm.org/releases/3.6.2/llvm-3.6.2.src.tar.xz> into /some/path/OpenSource/llvm.

3) In /some/path/OpenSource, delete the WebKitBuild directory to ensure a clean build.

4) Run Tools/Scripts/build-jsc --release --device ARCHS=arm64 ONLY_ACTIVE_ARCH=NO to build both LLVM and JavaScriptCore.

5) Run Tools/Scripts/export-llvm-build -i WebKitLibraries/LLVMIncludesIOSDevice9.tar.bz2 -l WebKitLibraries/LLVMLibrariesIOSDevice9.tar.bz2 -b llvm/wkLLVMBuild -B llvm/wkLLVMBuild/Release+Asserts -s llvm to produce files LLVM{Includes, Libraries}IOS9.tar.bz2.

  • LLVMIncludesIOS9.tar.bz2: Added.
  • LLVMLibrariesIOS9.tar.bz2: Added.
4:30 PM Changeset in webkit [190758] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-601-branch

Merged r188148. rdar://problem/22802049

4:19 PM Changeset in webkit [190757] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Cleaning up after revision 190339
​https://bugs.webkit.org/show_bug.cgi?id=149732

Patch by Jiewen Tan <​jiewen_tan@apple.com> on 2015-10-08
Reviewed by Myles C. Maxfield.

  • svg/custom/invalid-xslt-crash.svg:
  • svg/custom/invalid-xslt-crash-expected.txt:

Replace render tree dump test with text dump.

4:14 PM Changeset in webkit [190756] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r190749.
​https://bugs.webkit.org/show_bug.cgi?id=149938

Caused 50+ layout test failures
​https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r190749%20(213)/results.html
(Requested by litherum1 on #webkit).

Reverted changeset:

"DFG SSA should remove unreachable code"
​https://bugs.webkit.org/show_bug.cgi?id=149931
​http://trac.webkit.org/changeset/190749

3:59 PM Changeset in webkit [190755] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

data: URLs should not be preloaded
​https://bugs.webkit.org/show_bug.cgi?id=149829

Reviewed by Darin Adler.

Fix review comments after r190605:
Use protocolIs() instead of String::startsWith().

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):

3:53 PM Changeset in webkit [190754] by Chris Dumez
  • 13 edits in trunk/Source/WebCore

Revert r187626 (and r188025) as it caused a PLT regression
​https://bugs.webkit.org/show_bug.cgi?id=149898
<rdar://problem/22657123>

Reviewed by Myles Maxfield.

  • css/CSSPropertyNames.in:
  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyValueWebkitLocale):

  • platform/graphics/Font.cpp:

(WebCore::CharacterFallbackMapKey::CharacterFallbackMapKey):
(WebCore::CharacterFallbackMapKey::operator==):
(WebCore::CharacterFallbackMapKeyHash::hash):
(WebCore::Font::systemFallbackFontForCharacter):

  • platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::operator==):
(WebCore::FontDescriptionKey::FontDescriptionKey): Deleted.
(WebCore::FontDescriptionKey::computeHash): Deleted.

  • platform/graphics/FontDescription.cpp:

(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::traitsMask): Deleted.
(WebCore::FontCascadeDescription::FontCascadeDescription): Deleted.

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::setScript):
(WebCore::FontDescription::operator==):
(WebCore::FontDescription::setFeatureSettings): Deleted.
(WebCore::FontCascadeDescription::initialVariantAlternates): Deleted.

  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontCache::systemFallbackForCharacters):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:
  • style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):

3:53 PM Changeset in webkit [190753] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Marking http/tests/media/media-source/SourceBuffer-abort-updating.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=149816

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-08
Reviewed by Darin Adler.

  • platform/mac/TestExpectations:
3:43 PM Changeset in webkit [190752] by akling@apple.com
  • 12 edits
    2 adds in trunk

Generated frame tree names should be kept reasonably long.
<​https://webkit.org/b/149874>

Reviewed by Darin Adler.

Source/WebCore:

Some clumsy advertising script is going around assigning JavaScript source code
to the "name" attribute of iframes. This is causing WebKit to generate way too huge
names for anonymous descendants of such iframes.

Previously, the generated name of an anonymous subframe would be its slash-separated
path from the root frame, with the "name" attribute of each ancestor between the
slashes, or "<!--frame${index in parent}-->" for anonymous ancestors.

These ad scripts are often over 100kB in size, with multiple subframes, so we'd end
up with frame names looking like this:

"<!--framePath <MONSTER BLOB OF JAVASCRIPT FROM HELL>/<!--frame0--><!--frame0-->-->"

While this is worth fixing for the memory usage alone, we've been making it way
worse by also using these paths when recording the back/forward history parts of
WebKit session state.

This patch makes generated paths always use index-in-parent as the "directory name"
for ancestors of anonymous subframes. The above example path will now instead be:

"<!--framePath <!--frame0-->/<!--frame0-->/<!--frame0-->-->"

Test: fast/frames/long-names-in-nested-subframes.html

  • page/FrameTree.cpp:

(WebCore::FrameTree::indexInParent):
(WebCore::FrameTree::uniqueChildName):

  • page/FrameTree.h:

LayoutTests:

Added a test to document our name generation behavior for subframes with long-named ancestors.
Also rebaselined some tests that exposed the old behavior.

  • fast/forms/form-and-frame-interaction-retains-values-expected.txt:
  • fast/frames/long-names-in-nested-subframes-expected.txt: Added.
  • fast/frames/long-names-in-nested-subframes.html: Added.
  • http/tests/navigation/image-load-in-subframe-unload-handler-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame-2-level-expected.txt:
  • http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-to-javscript-url-expected.txt:
  • http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-from-javscript-url-expected.txt:
3:25 PM Changeset in webkit [190751] by Lucas Forschler
  • 4 edits in branches/safari-601-branch/Source/WebInspectorUI

Merge r189011. rdar://problem/22801999

2015-08-26 Nikita Vasilyev <Nikita Vasilyev>

Web Inspector: [Regression] [Mavericks]: Undocked Web Inspector toolbar is two different colors and has extra space
​https://bugs.webkit.org/show_bug.cgi?id=148510

Make body element transparent and remove extra padding above the toolbar only for OS X Mavericks.

Reviewed by Timothy Hatcher.

  • UserInterface/Base/Main.js: (WebInspector.contentLoaded):
  • UserInterface/Views/Main.css: (body:not(.mavericks)): (body): Deleted.
  • UserInterface/Views/Toolbar.css: (body:not(.mavericks) .toolbar): (body.window-inactive:not(.mavericks) .toolbar): (body.mac-platform:not(.docked, .mavericks) .toolbar): (.toolbar): Deleted. (body.window-inactive .toolbar): Deleted. (body.mac-platform:not(.docked) .toolbar): Deleted.
3:19 PM Changeset in webkit [190750] by Lucas Forschler
  • 3 edits in branches/safari-601-branch/Source/WebInspectorUI

Merged r188173. rdar://problem/22801999

3:18 PM Changeset in webkit [190749] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG SSA should remove unreachable code
​https://bugs.webkit.org/show_bug.cgi?id=149931

Reviewed by Geoffrey Garen.

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run): Remove unreachable code.

  • dfg/DFGObjectAllocationSinkingPhase.cpp: Deal with the CFG changing.
  • dfg/DFGPutStackSinkingPhase.cpp: Deal with the CFG changing.
3:16 PM Changeset in webkit [190748] by Lucas Forschler
  • 3 edits in branches/safari-601-branch/Source/WebInspectorUI

Merged r187715. rdar://problem/22801999

3:08 PM Changeset in webkit [190747] by Lucas Forschler
  • 7 edits in branches/safari-601-branch/Source

Rollout r190745.

3:00 PM Changeset in webkit [190746] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r190701.
​https://bugs.webkit.org/show_bug.cgi?id=149937

"It did not help, will try a full roll out instead" (Requested
by cdumez on #webkit).

Reverted changeset:

"Partial revert of r187626 as it caused a PLT regression"
​https://bugs.webkit.org/show_bug.cgi?id=149898
​http://trac.webkit.org/changeset/190701

Patch by Commit Queue <​commit-queue@webkit.org> on 2015-10-08

2:08 PM Changeset in webkit [190745] by Lucas Forschler
  • 7 edits in branches/safari-601-branch/Source

Merged r188443. rdar://problem/22801969

1:56 PM Changeset in webkit [190744] by Lucas Forschler
  • 5 edits in branches/safari-601-branch/Source/WebInspectorUI

Merged r188378. rdar://problem/22801980

1:53 PM Changeset in webkit [190743] by Joseph Pecoraro
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix. Missing forward declaration.

  • heap/Heap.h:
1:53 PM Changeset in webkit [190742] by Lucas Forschler
  • 3 edits in branches/safari-601-branch/Source/WebInspectorUI

Merged r187052. rdar://problem/22801992

1:24 PM Changeset in webkit [190741] by sbarati@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed Cloop build fix after bug: ​https://bugs.webkit.org/show_bug.cgi?id=149601

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::newExceptionHandlingCallSiteIndex):

  • jit/JITCode.cpp:

(JSC::NativeJITCode::addressForCall):
(JSC::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):

  • jit/JITCode.h:
1:19 PM Changeset in webkit [190740] by Lucas Forschler
  • 3 edits in branches/safari-601.1-branch/Source/WebInspectorUI

Rollout r190736.

1:19 PM Changeset in webkit [190739] by Joseph Pecoraro
  • 15 edits in trunk/Source

Clean up Marked classes
​https://bugs.webkit.org/show_bug.cgi?id=149853

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • heap/Heap.h:

Move include here where it is really needed.

  • heap/HeapStatistics.cpp:
  • heap/HeapStatistics.h:

Simplify includes.

  • heap/MarkedAllocator.h:

Add missing copyright header.

  • heap/MarkedBlock.cpp:
  • heap/MarkedBlock.h:

(JSC::MarkedBlock::needsSweeping):
Remove unused constants. Add some static asserts. Add some const ness.

  • heap/MarkedSpace.h:

(JSC::MarkedSpace::isIterating):
Update comments to better reflect actual values.
Remove unimplemented method (moved to Heap).

  • heap/MarkedSpace.cpp:

(JSC::Free::Free):
(JSC::Free::operator()):
(JSC::Free::returnValue): Deleted.
(JSC::FreeOrShrink::FreeOrShrink):
(JSC::FreeOrShrink::operator()):
(JSC::MarkedSpace::~MarkedSpace):
(JSC::MarkedSpace::shrink):
Replace conditional Functor that was not using return value
with simplified targeted VoidFunctors.

(JSC::Shrink::operator()): Deleted.
Remove unused functor.

  • heap/WeakBlock.cpp:
  • heap/WeakBlock.h:
  • runtime/Options.cpp:

Remove dead code.

Source/WTF:

  • wtf/PageBlock.h:

Remove duplicate using statement.

1:17 PM Changeset in webkit [190738] by Lucas Forschler
  • 5 edits in branches/safari-601.1-branch/Source/WebInspectorUI

Rollout r190737.

1:05 PM Changeset in webkit [190737] by Lucas Forschler
  • 5 edits in branches/safari-601.1-branch/Source/WebInspectorUI

Merged r188378. rdar://problem/22801980

1:00 PM Changeset in webkit [190736] by Lucas Forschler
  • 3 edits in branches/safari-601.1-branch/Source/WebInspectorUI

Merged r187052. <rdar://problem/22801992>

12:37 PM Changeset in webkit [190735] by sbarati@apple.com
  • 36 edits
    8 adds in trunk

We should be able to inline getter/setter calls inside an inline cache even when the SpillRegistersMode is NeedsToSpill
​https://bugs.webkit.org/show_bug.cgi?id=149601

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Before, if we had a PolymorphicAccess with and a StructureStubInfo
with a NeedToSpill spillMode, we wouldn't generate getter/setter
calls. This patch changes it such that we will generate the
getter/setter call and do the necessary register spilling/filling
around the getter/setter call to preserve any "usedRegisters".

This has an interesting story with how it relates to exception handling
inside the DFG. Because the GetById variants are considered a throwing call
site, we must make sure that we properly restore the registers spilled to the stack
in case of an exception being thrown inside the getter/setter call. We do
this by having the inline cache register itself as a new exception handling
call site. When the inline cache "catches" the exception (i.e, genericUnwind
will jump to this code), it will restore the registers it spilled that are
live inside the original catch handler, and then jump to the original catch
handler. We make sure to only generate this makeshift catch handler when we
actually need to do any cleanup. If we determine that we don't need to restore
any registers, we don't bother generating this makeshift catch handler.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::handlerForIndex):
(JSC::CodeBlock::newExceptionHandlingCallSiteIndex):
(JSC::CodeBlock::removeExceptionHandlerForCallSite):
(JSC::CodeBlock::lineNumberForBytecodeOffset):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::appendExceptionHandler):

  • bytecode/PolymorphicAccess.cpp:

(JSC::AccessGenerationState::AccessGenerationState):
(JSC::AccessGenerationState::restoreScratch):
(JSC::AccessGenerationState::succeed):
(JSC::AccessGenerationState::calculateLiveRegistersForCallAndExceptionHandling):
(JSC::AccessGenerationState::preserveLiveRegistersToStackForCall):
(JSC::AccessGenerationState::restoreLiveRegistersFromStackForCall):
(JSC::AccessGenerationState::restoreLiveRegistersFromStackForCallWithThrownException):
(JSC::AccessGenerationState::liveRegistersForCall):
(JSC::AccessGenerationState::callSiteIndexForExceptionHandlingOrOriginal):
(JSC::AccessGenerationState::callSiteIndexForExceptionHandling):
(JSC::AccessGenerationState::originalExceptionHandler):
(JSC::AccessGenerationState::numberOfStackBytesUsedForRegisterPreservation):
(JSC::AccessGenerationState::needsToRestoreRegistersIfException):
(JSC::AccessGenerationState::originalCallSiteIndex):
(JSC::AccessGenerationState::liveRegistersToPreserveAtExceptionHandlingCallSite):
(JSC::AccessCase::AccessCase):
(JSC::AccessCase::generate):
(JSC::PolymorphicAccess::regenerateWithCases):
(JSC::PolymorphicAccess::regenerate):
(JSC::PolymorphicAccess::aboutToDie):

  • bytecode/PolymorphicAccess.h:

(JSC::AccessCase::doesCalls):
(JSC::AccessCase::isGetter):
(JSC::AccessCase::callLinkInfo):

  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::aboutToDie):
(JSC::StructureStubInfo::addAccessCase):

  • bytecode/StructureStubInfo.h:
  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::isInJSValueRegs):
(JSC::ValueRecovery::fpr):

  • dfg/DFGCommonData.cpp:

(JSC::DFG::CommonData::addCodeOrigin):
(JSC::DFG::CommonData::addCodeOriginUnconditionally):
(JSC::DFG::CommonData::lastCallSite):
(JSC::DFG::CommonData::removeCallSiteIndex):
(JSC::DFG::CommonData::shrinkToFit):

  • dfg/DFGCommonData.h:
  • dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::reconstruct):
(JSC::DFG::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
(JSC::DFG::JITCode::checkIfOptimizationThresholdReached):

  • dfg/DFGJITCode.h:

(JSC::DFG::JITCode::osrEntryBlock):
(JSC::DFG::JITCode::setOSREntryBlock):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::appendExceptionHandlingOSRExit):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):

  • dfg/DFGOSRExit.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIn):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):

  • ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

  • ftl/FTLJITCode.cpp:

(JSC::FTL::JITCode::validateReferences):
(JSC::FTL::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):

  • ftl/FTLJITCode.h:

(JSC::FTL::JITCode::handles):
(JSC::FTL::JITCode::dataSections):

  • jit/GCAwareJITStubRoutine.cpp:

(JSC::GCAwareJITStubRoutine::GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::~GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::observeZeroRefCount):
(JSC::MarkingGCAwareJITStubRoutineWithOneObject::markRequiredObjectsInternal):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::GCAwareJITStubRoutineWithExceptionHandler):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::aboutToDie):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::~GCAwareJITStubRoutineWithExceptionHandler):
(JSC::createJITStubRoutine):

  • jit/GCAwareJITStubRoutine.h:
  • jit/JITCode.cpp:

(JSC::NativeJITCode::addressForCall):
(JSC::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):

  • jit/JITCode.h:
  • jit/JITInlineCacheGenerator.cpp:

(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):

  • jit/JITInlineCacheGenerator.h:

(JSC::JITByIdGenerator::reportSlowPathCall):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):

  • jit/JITStubRoutine.h:

(JSC::JITStubRoutine::createSelfManagedRoutine):
(JSC::JITStubRoutine::aboutToDie):

  • jit/RegisterSet.cpp:

(JSC::RegisterSet::webAssemblyCalleeSaveRegisters):
(JSC::RegisterSet::registersToNotSaveForCall):
(JSC::RegisterSet::allGPRs):

  • jit/RegisterSet.h:

(JSC::RegisterSet::set):
(JSC::RegisterSet::clear):

  • jit/ScratchRegisterAllocator.cpp:

(JSC::ScratchRegisterAllocator::allocateScratchGPR):
(JSC::ScratchRegisterAllocator::allocateScratchFPR):
(JSC::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
(JSC::ScratchRegisterAllocator::usedRegistersForCall):
(JSC::ScratchRegisterAllocator::preserveUsedRegistersToScratchBufferForCall):
(JSC::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBufferForCall):
(JSC::ScratchRegisterAllocator::preserveRegistersToStackForCall):
(JSC::ScratchRegisterAllocator::restoreRegistersFromStackForCall):

  • jit/ScratchRegisterAllocator.h:

(JSC::ScratchRegisterAllocator::numberOfReusedRegisters):
(JSC::ScratchRegisterAllocator::usedRegisters):

  • jsc.cpp:

(WTF::CustomGetter::CustomGetter):
(WTF::CustomGetter::createStructure):
(WTF::CustomGetter::create):
(WTF::CustomGetter::getOwnPropertySlot):
(WTF::CustomGetter::customGetter):
(WTF::Element::handleOwner):
(GlobalObject::finishCreation):
(functionCreateImpureGetter):
(functionCreateCustomGetterObject):
(functionSetImpureGetterDelegate):

  • tests/stress/try-catch-custom-getter-as-get-by-id.js: Added.

(assert):
(bar):
(foo):

  • tests/stress/try-catch-getter-as-get-by-id-register-restoration.js: Added.

(assert):
(o1.get f):
(bar):
(foo):

  • tests/stress/try-catch-getter-as-get-by-id.js: Added.

(assert):
(o1.get f):
(bar):
(foo):

  • tests/stress/try-catch-setter-as-put-by-id.js: Added.

(assert):
(o1.set f):
(bar):
(foo):

  • tests/stress/try-catch-stub-routine-replaced.js: Added.

(assert):
(arr):
(hello):
(foo):
(objChain.get f):
(fakeOut.get f):
(o.get f):

LayoutTests:

  • js/regress/custom-setter-getter-as-put-get-by-id-expected.txt: Added.
  • js/regress/custom-setter-getter-as-put-get-by-id.html: Added.
  • js/regress/script-tests/custom-setter-getter-as-put-get-by-id.js: Added.

(assert):
(test):

11:46 AM Changeset in webkit [190734] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Fallback to the RenderView when repaint container is null.
​https://bugs.webkit.org/show_bug.cgi?id=149903

Reviewed by Simon Fraser.

Reduces code complexity at the calling sites.

No change in functionality.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):

10:44 AM Changeset in webkit [190733] by ap@apple.com
  • 4 edits in trunk/LayoutTests

fast/events/scroll-after-click-on-tab-index.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=149859

Reviewed by Simon Fraser.

  • fast/events/scroll-after-click-on-tab-index-expected.txt:
  • fast/events/scroll-after-click-on-tab-index.html:
  • platform/mac/TestExpectations:
10:40 AM Changeset in webkit [190732] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Add NULL check for renderBox::layer() on applying zoom level change
​https://bugs.webkit.org/show_bug.cgi?id=149302
<rdar://problem/22747292>

Patch by Jiewen Tan <​jiewen_tan@apple.com> on 2015-10-08
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/zoom-on-nested-scroll-crash.html

This is a merge of Blink r158238:
​https://chromiumcodereview.appspot.com/23526081

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

LayoutTests:

  • fast/css/zoom-on-nested-scroll-crash-expected.txt: Added.
  • fast/css/zoom-on-nested-scroll-crash.html: Added.
10:35 AM Changeset in webkit [190731] by beidson@apple.com
  • 4 edits in trunk/Source/WebCore

Update Inspector to only work with Legacy IDB (for now).
​https://bugs.webkit.org/show_bug.cgi?id=149928.

Reviewed by Tim Horton.

  • Modules/indexeddb/IDBAny.h:

(WebCore::IDBAny::isLegacy):

  • Modules/indexeddb/legacy/LegacyAny.h:
  • inspector/InspectorIndexedDBAgent.cpp:
10:07 AM Changeset in webkit [190730] by ap@apple.com
  • 2 edits in trunk/Tools

Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
​https://bugs.webkit.org/show_bug.cgi?id=149848

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
9:32 AM Changeset in webkit [190729] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Marking fast/events/scroll-after-click-on-tab-index.html as flaky on Mac
​https://bugs.webkit.org/show_bug.cgi?id=149859

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-08
Reviewed by Darin Adler.

  • platform/mac/TestExpectations:
9:26 AM Changeset in webkit [190728] by Antti Koivisto
  • 3 edits
    2 adds in trunk

CrashTracer: [USER] com.apple.WebKit.WebContent at …Core::SelectorChecker::checkScrollbarPseudoClass const + 217
​https://bugs.webkit.org/show_bug.cgi?id=149921
rdar://problem/22731359

Reviewed by Andreas Kling.

Source/WebCore:

Test: svg/css/use-window-inactive-crash.html

  • css/SelectorCheckerTestFunctions.h:

(WebCore::isWindowInactive):

Null check page.

LayoutTests:

The test crashes with shipping WebKit but not with current ToT (probably due to shadow DOM styling changes). Still adding
it for coverage.

  • svg/css/use-window-inactive-crash-expected.html: Added.
  • svg/css/use-window-inactive-crash.html: Added.
8:33 AM Changeset in webkit [190727] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: An error view doesn't get expanded by clicking on the expand arrow
​https://bugs.webkit.org/show_bug.cgi?id=149917

Reviewed by Timothy Hatcher.

  • UserInterface/Views/ErrorObjectView.css:

(.error-object > .formatted-error::before):
(.error-object.expanded > .formatted-error::before):
(.error-object::before): Deleted.
(.error-object.expanded::before): Deleted.

8:29 AM Changeset in webkit [190726] by Michael Catanzaro
  • 2 edits in trunk/Source/WebKit2

Format string issues in NetworkCache.cpp
​https://bugs.webkit.org/show_bug.cgi?id=149867

Reviewed by Csaba Osztrogonác.

Cast enums to ints before printing them to placate GCC's -Wformat.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::retrieve):
(WebKit::NetworkCache::Cache::store):

8:27 AM Changeset in webkit [190725] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore

Format string issues in LegacyRequest.cpp
​https://bugs.webkit.org/show_bug.cgi?id=149866

Reviewed by Csaba Osztrogonác.

Cast enums to ints before printing them to placate GCC's -Wformat.

  • Modules/indexeddb/legacy/LegacyRequest.cpp:

(WebCore::LegacyRequest::dispatchEvent):
(WebCore::LegacyRequest::enqueueEvent):

8:27 AM Changeset in webkit [190724] by Michael Catanzaro
  • 2 edits in trunk/Source/WebKit2

Format string issue in WebResourceLoadScheduler.cpp
​https://bugs.webkit.org/show_bug.cgi?id=149868

Reviewed by Csaba Osztrogonác.

Cast enums to ints before printing them to placate GCC's -Wformat.

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleLoad):

8:23 AM Changeset in webkit [190723] by commit-queue@webkit.org
  • 18 edits
    1 copy
    1 delete in trunk/Source

Unreviewed, rolling out r190716.
​https://bugs.webkit.org/show_bug.cgi?id=149924

broke mac build from time to time (Requested by youenn on
#webkit).

Reverted changeset:

"Automate WebCore JS builtins generation and build system"
​https://bugs.webkit.org/show_bug.cgi?id=149751
​http://trac.webkit.org/changeset/190716

8:20 AM Changeset in webkit [190722] by Csaba Osztrogonác
  • 5 edits in trunk/Source/JavaScriptCore

Fix the WASM build on Linux
​https://bugs.webkit.org/show_bug.cgi?id=149919

Reviewed by Mark Lam.

  • inspector/ScriptCallStackFactory.cpp:
  • wasm/JSWASMModule.cpp:
  • wasm/WASMFunctionCompiler.h:

(JSC::sizeOfMemoryType):

  • wasm/WASMFunctionLLVMIRGenerator.h:
6:28 AM Changeset in webkit [190721] by svillar@igalia.com
  • 2 edits in trunk/Source/WebCore

[css-grid] Percentages of indefinite sizes to be resolved as auto
​https://bugs.webkit.org/show_bug.cgi?id=149810

Reviewed by Darin Adler.

Specs mention that percentages in grid track sizes must be
resolved as 'auto' if the grid container has an indefinite
size in the corresponding axis.

The 'auto' keyword used to be resolved as
minmax(min-content,max-content) but since r189911 it's
resolved as minmax(auto,auto). Updated the implementation so
we properly resolve those percentages.

No new tests as the behavior does not change at all. That's
because 'auto' as min-track sizing function is the same as
min-content (unless we have a specified value for
min-{width|height}, but those cases were already handled in the
code), and as a max sizing function is works as max-content.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::gridTrackSize):

5:43 AM CommitQueue edited by sergio@webkit.org
Updated commit queue status URL (diff)
5:26 AM Changeset in webkit [190720] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed CLOOP buildfix after r190718.

  • jit/Repatch.h:

(JSC::resetGetByID): Deleted.
(JSC::resetPutByID): Deleted.
(JSC::resetIn): Deleted.

3:37 AM Changeset in webkit [190719] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Remove PageReservation.h clang fixme that has been fixed for a while
​https://bugs.webkit.org/show_bug.cgi?id=149908

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-08
Reviewed by Csaba Osztrogonác.

  • wtf/PageReservation.h:

(WTF::PageReservation::operator bool): Deleted.

3:33 AM Changeset in webkit [190718] by commit-queue@webkit.org
  • 11 edits in trunk/Source/JavaScriptCore

Remove references to removed class RepatchBuffer
​https://bugs.webkit.org/show_bug.cgi?id=149909

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-08
Reviewed by Csaba Osztrogonác.

  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssemblerARM.h:
  • assembler/MacroAssemblerARM64.h:
  • assembler/MacroAssemblerARMv7.h:
  • assembler/MacroAssemblerMIPS.h:
  • assembler/MacroAssemblerSH4.h:
  • assembler/MacroAssemblerX86.h:
  • assembler/MacroAssemblerX86_64.h:
  • jit/JITStubRoutine.h:
  • jit/Repatch.h:
3:06 AM Changeset in webkit [190717] by Carlos Garcia Campos
  • 5 edits in trunk

[GTK] Stop using a nested main loop for popup menus
​https://bugs.webkit.org/show_bug.cgi?id=149920

Reviewed by Sergio Villar Senin.

Source/WebKit2:

WebPageProxy used to expect the popup menus to run in a nested
main loop and invalidated the menu right after showing it. But
this is no longer the case, so there's no reason to keep using
the nested main loop.

  • UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::~WebPopupMenuProxyGtk):
(WebKit::WebPopupMenuProxyGtk::cancelTracking):
(WebKit::WebPopupMenuProxyGtk::menuItemActivated):
(WebKit::WebPopupMenuProxyGtk::WebPopupMenuProxyGtk): Deleted.
(WebKit::WebPopupMenuProxyGtk::showPopupMenu): Deleted.
(WebKit::WebPopupMenuProxyGtk::shutdownRunLoop): Deleted.
(WebKit::WebPopupMenuProxyGtk::menuUnmapped): Deleted.

  • UIProcess/gtk/WebPopupMenuProxyGtk.h:

(WebKit::WebPopupMenuProxyGtk::setActiveItem): Deleted.

LayoutTests:

Unskip platform/gtk/fast/forms/menulist-typeahead-find.html that
was timing out because of the nested main loop.

  • platform/gtk/TestExpectations:
2:55 AM Changeset in webkit [190716] by youenn.fablet@crf.canon.fr
  • 18 edits
    1 add
    1 delete in trunk/Source

Automate WebCore JS builtins generation and build system
​https://bugs.webkit.org/show_bug.cgi?id=149751

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • generate-js-builtins: updating the part related to WebCore JS binding.

Source/WebCore:

Adding annotations to JS files to know whether they should be under a compilation flag and
whether they are JS internals or JS tied to WebIDL.
If a file is said as JS internals, all function names are exported automatically.
Added auto generation of WebCoreJSBuiltins.cpp
Added auto generation of JSBuiltinFunctions class inside WebCoreJSBuiltins that takes the role of
WebCoreJSClientData as wrapper for builtins.
Added auto generation of WebCoreJSBuiltinInternals.h which contain a wrapper around all private functions, used by
JSDOMWindowBase. The class is named JSBuiltinInternalFunctions.
Renamed WebCoreJSClientData to JSVMClientData.

The remaining manual part for private functions is the pairing between private identifiers and
the private JS functions within JSDOMWindowBase::finishCreation.

Covered by existing tests.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Modules/streams/ByteLengthQueuingStrategy.js:
  • Modules/streams/CountQueuingStrategy.js:
  • Modules/streams/ReadableStream.js:
  • Modules/streams/ReadableStreamInternals.js:
  • WebCore.order:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::normalWorld):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::finishCreation):
(WebCore::JSDOMWindowBase::visitChildren):
(WebCore::JSDOMWindowBase::fireFrameClearedWatchpointsForWindow):

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::getAllWorlds):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::transferArrayBuffers):

  • bindings/js/WebCoreJSClientData.h:

(WebCore::JSClientData::JSClientData):
(WebCore::JSClientData::~JSClientData):
(WebCore::JSClientData::builtinFunctions):
(WebCore::initNormalWorldClientData):
(WebCore::WebCoreJSClientData::WebCoreJSClientData): Deleted.
(WebCore::WebCoreJSClientData::~WebCoreJSClientData): Deleted.
(WebCore::WebCoreJSClientData::readableStreamBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamControllerBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamInternalsBuiltins): Deleted.
(WebCore::WebCoreJSClientData::readableStreamReaderBuiltins): Deleted.
(WebCore::WebCoreJSClientData::byteLengthQueuingStrategyBuiltins): Deleted.
(WebCore::WebCoreJSClientData::countQueuingStrategyBuiltins): Deleted.

  • generate-js-builtins-allinone: Added.

(retrieveGenerationParameters):
(retrieveFilesWithParameters):
(retrieveFilesWithParameters.FileInput):
(writeConditional):
(JSBuiltinFunctions):
(Private):
(JSBuiltinInternalFunctions):
(copytempfile):

12:33 AM Changeset in webkit [190715] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Mark several inspector tests as slow.

  • platform/gtk/TestExpectations:
12:30 AM Changeset in webkit [190714] by youenn.fablet@crf.canon.fr
  • 53 edits in trunk/Source/WebCore

Binding generated JS constructors should use GlobalObject references
​https://bugs.webkit.org/show_bug.cgi?id=149872

Reviewed by Darin Adler.

Updated binding generator to generate JS DOM constructors code with JSDOMGlobalOBject references.
Updated WebCore JS binding layer accordingly.

Covered by updated binding tests.

  • bindings/js/DOMConstructorWithDocument.h:

(WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
(WebCore::DOMConstructorWithDocument::finishCreation):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::getCachedDOMStructure):
(WebCore::cacheDOMStructure):

  • bindings/js/JSDOMBinding.h:

(WebCore::DOMConstructorObject::DOMConstructorObject):
(WebCore::DOMConstructorJSBuiltinObject::DOMConstructorJSBuiltinObject):
(WebCore::getDOMStructure):
(WebCore::deprecatedGetDOMStructure):
(WebCore::getDOMPrototype):
(WebCore::createJSBuiltin):
(WebCore::createWrapper):

  • bindings/js/JSDOMConstructor.h:

(WebCore::JSBuiltinConstructor::JSBuiltinConstructor):

  • bindings/js/JSDOMGlobalObject.h:

(WebCore::getDOMConstructor):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::image):
(WebCore::JSDOMWindow::touch):
(WebCore::JSDOMWindow::touchList):

  • bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::JSDOMWrapper):
(WebCore::JSDOMWrapperWithImplementation::JSDOMWrapperWithImplementation):

  • bindings/js/JSImageConstructor.cpp:

(WebCore::JSImageConstructor::JSImageConstructor):
(WebCore::JSImageConstructor::finishCreation):

  • bindings/js/JSImageConstructor.h:

(WebCore::JSImageConstructor::create):
(WebCore::JSImageConstructor::createStructure):

  • bindings/js/JSReadableStreamPrivateConstructors.cpp:

(WebCore::JSBuiltinReadableStreamReaderPrivateConstructor::createJSObject):
(WebCore::JSBuiltinReadableStreamControllerPrivateConstructor::createJSObject):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateCallbackImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObjectConstructor::create):
(WebCore::JSTestActiveDOMObjectConstructor::createStructure):
(WebCore::JSTestActiveDOMObjectConstructor::JSTestActiveDOMObjectConstructor):
(WebCore::JSTestActiveDOMObjectConstructor::finishCreation):
(WebCore::JSTestActiveDOMObject::JSTestActiveDOMObject):
(WebCore::JSTestActiveDOMObject::getConstructor):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.h:

(WebCore::JSTestActiveDOMObject::create):

  • bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallbackConstructor::create):
(WebCore::JSTestCallbackConstructor::createStructure):
(WebCore::JSTestCallbackConstructor::JSTestCallbackConstructor):
(WebCore::JSTestCallback::getConstructor):

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::create):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::createStructure):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::JSTestCustomConstructorWithNoInterfaceObjectConstructor):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::finishCreation):
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::JSTestCustomConstructorWithNoInterfaceObject):
(WebCore::jsTestCustomConstructorWithNoInterfaceObjectConstructor):

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.h:

(WebCore::JSTestCustomConstructorWithNoInterfaceObject::create):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetterConstructor::create):
(WebCore::JSTestCustomNamedGetterConstructor::createStructure):
(WebCore::JSTestCustomNamedGetterConstructor::JSTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::getConstructor):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h:

(WebCore::JSTestCustomNamedGetter::create):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::create):
(WebCore::JSTestEventConstructorConstructor::createStructure):
(WebCore::JSTestEventConstructorConstructor::JSTestEventConstructorConstructor):
(WebCore::JSTestEventConstructorConstructor::finishCreation):
(WebCore::JSTestEventConstructor::JSTestEventConstructor):
(WebCore::JSTestEventConstructor::getConstructor):

  • bindings/scripts/test/JS/JSTestEventConstructor.h:

(WebCore::JSTestEventConstructor::create):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTargetConstructor::create):
(WebCore::JSTestEventTargetConstructor::createStructure):
(WebCore::JSTestEventTargetConstructor::JSTestEventTargetConstructor):
(WebCore::JSTestEventTargetConstructor::finishCreation):
(WebCore::JSTestEventTarget::JSTestEventTarget):
(WebCore::JSTestEventTarget::getConstructor):

  • bindings/scripts/test/JS/JSTestEventTarget.h:

(WebCore::JSTestEventTarget::create):

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestExceptionConstructor::create):
(WebCore::JSTestExceptionConstructor::createStructure):
(WebCore::JSTestExceptionConstructor::JSTestExceptionConstructor):
(WebCore::JSTestExceptionConstructor::finishCreation):
(WebCore::JSTestException::JSTestException):
(WebCore::JSTestException::getConstructor):

  • bindings/scripts/test/JS/JSTestException.h:

(WebCore::JSTestException::create):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachableConstructor::create):
(WebCore::JSTestGenerateIsReachableConstructor::createStructure):
(WebCore::JSTestGenerateIsReachableConstructor::JSTestGenerateIsReachableConstructor):
(WebCore::JSTestGenerateIsReachableConstructor::finishCreation):
(WebCore::JSTestGenerateIsReachable::JSTestGenerateIsReachable):
(WebCore::JSTestGenerateIsReachable::getConstructor):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.h:

(WebCore::JSTestGenerateIsReachable::create):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterfaceConstructor::createStructure):
(WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):
(WebCore::JSTestInterfaceConstructor::finishCreation):
(WebCore::JSTestInterface::JSTestInterface):
(WebCore::JSTestInterface::getConstructor):

  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::JSTestJSBuiltinConstructorConstructor::create):
(WebCore::JSTestJSBuiltinConstructorConstructor::createStructure):
(WebCore::JSTestJSBuiltinConstructorConstructor::JSTestJSBuiltinConstructorConstructor):
(WebCore::JSTestJSBuiltinConstructorConstructor::finishCreation):
(WebCore::JSTestJSBuiltinConstructor::JSTestJSBuiltinConstructor):
(WebCore::JSTestJSBuiltinConstructor::getConstructor):

  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h:

(WebCore::JSTestJSBuiltinConstructor::create):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListenerConstructor::createStructure):
(WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor):
(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):
(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
(WebCore::JSTestMediaQueryListListener::getConstructor):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::create):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorConstructor::create):
(WebCore::JSTestNamedConstructorConstructor::createStructure):
(WebCore::JSTestNamedConstructorNamedConstructor::create):
(WebCore::JSTestNamedConstructorNamedConstructor::createStructure):
(WebCore::JSTestNamedConstructorConstructor::JSTestNamedConstructorConstructor):
(WebCore::JSTestNamedConstructorConstructor::finishCreation):
(WebCore::JSTestNamedConstructorNamedConstructor::JSTestNamedConstructorNamedConstructor):
(WebCore::JSTestNamedConstructorNamedConstructor::finishCreation):
(WebCore::JSTestNamedConstructor::JSTestNamedConstructor):
(WebCore::JSTestNamedConstructor::getConstructor):
(WebCore::JSTestNamedConstructor::getNamedConstructor):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:

(WebCore::JSTestNamedConstructor::create):

  • bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodeConstructor::create):
(WebCore::JSTestNodeConstructor::createStructure):
(WebCore::JSTestNodeConstructor::JSTestNodeConstructor):
(WebCore::JSTestNodeConstructor::finishCreation):
(WebCore::JSTestNode::JSTestNode):
(WebCore::JSTestNode::getConstructor):

  • bindings/scripts/test/JS/JSTestNode.h:
  • bindings/scripts/test/JS/JSTestNondeterministic.cpp:

(WebCore::JSTestNondeterministicConstructor::create):
(WebCore::JSTestNondeterministicConstructor::createStructure):
(WebCore::JSTestNondeterministicConstructor::JSTestNondeterministicConstructor):
(WebCore::JSTestNondeterministicConstructor::finishCreation):
(WebCore::JSTestNondeterministic::JSTestNondeterministic):
(WebCore::JSTestNondeterministic::getConstructor):

  • bindings/scripts/test/JS/JSTestNondeterministic.h:

(WebCore::JSTestNondeterministic::create):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObjConstructor::createStructure):
(WebCore::JSTestObjConstructor::JSTestObjConstructor):
(WebCore::JSTestObjConstructor::finishCreation):
(WebCore::JSTestObj::JSTestObj):
(WebCore::JSTestObj::getConstructor):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::create):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsConstructor::create):
(WebCore::JSTestOverloadedConstructorsConstructor::createStructure):
(WebCore::JSTestOverloadedConstructorsConstructor::JSTestOverloadedConstructorsConstructor):
(WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):
(WebCore::JSTestOverloadedConstructors::JSTestOverloadedConstructors):
(WebCore::JSTestOverloadedConstructors::getConstructor):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.h:

(WebCore::JSTestOverloadedConstructors::create):

  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::JSTestOverrideBuiltinsConstructor::create):
(WebCore::JSTestOverrideBuiltinsConstructor::createStructure):
(WebCore::JSTestOverrideBuiltinsConstructor::JSTestOverrideBuiltinsConstructor):
(WebCore::JSTestOverrideBuiltinsConstructor::finishCreation):
(WebCore::JSTestOverrideBuiltins::JSTestOverrideBuiltins):
(WebCore::JSTestOverrideBuiltins::getConstructor):

  • bindings/scripts/test/JS/JSTestOverrideBuiltins.h:

(WebCore::JSTestOverrideBuiltins::create):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterface::getConstructor):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::create):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::create):
(WebCore::JSTestTypedefsConstructor::createStructure):
(WebCore::JSTestTypedefsConstructor::JSTestTypedefsConstructor):
(WebCore::JSTestTypedefsConstructor::finishCreation):
(WebCore::JSTestTypedefs::JSTestTypedefs):
(WebCore::JSTestTypedefs::getConstructor):

  • bindings/scripts/test/JS/JSTestTypedefs.h:

(WebCore::JSTestTypedefs::create):

  • bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::JSattributeConstructor::create):
(WebCore::JSattributeConstructor::createStructure):
(WebCore::JSattributeConstructor::JSattributeConstructor):
(WebCore::JSattributeConstructor::finishCreation):
(WebCore::JSattribute::JSattribute):
(WebCore::JSattribute::getConstructor):

  • bindings/scripts/test/JS/JSattribute.h:

(WebCore::JSattribute::create):

  • bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::JSreadonlyConstructor::create):
(WebCore::JSreadonlyConstructor::createStructure):
(WebCore::JSreadonlyConstructor::JSreadonlyConstructor):
(WebCore::JSreadonlyConstructor::finishCreation):
(WebCore::JSreadonly::JSreadonly):
(WebCore::JSreadonly::getConstructor):

  • bindings/scripts/test/JS/JSreadonly.h:

(WebCore::JSreadonly::create):

12:21 AM Changeset in webkit [190713] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

WebRTC: Add event names needed by updated RTCPeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=149875

Patch by Philippe Normand <​pnormand@igalia.com> on 2015-10-08
Reviewed by Eric Carlson.

The track event name was recently added in the WebRTC spec. The
icegatheringstatechange event has been part of the spec for a while but
was not registered in our DOM events.

  • dom/EventNames.h: Add track and icegatheringstatechange even names.
12:19 AM Changeset in webkit [190712] by bshafiei@apple.com
  • 8 edits in tags/Safari-602.1.6/Source/JavaScriptCore

Merged r190699. rdar://problem/22998598

12:18 AM Changeset in webkit [190711] by bshafiei@apple.com
  • 2 edits in tags/Safari-602.1.6/LayoutTests

Merged r190695. rdar://problem/22998598

12:17 AM Changeset in webkit [190710] by bshafiei@apple.com
  • 2 edits in tags/Safari-602.1.6/Source/JavaScriptCore

Merged r190692. rdar://problem/22998598

Note: See TracTimeline for information about the timeline view.