Timeline

Oct 11, 2015:

9:41 PM Changeset in webkit [190850] by BJ Burg

• 2 edits in trunk/Source/WebCore

Add missing builtins files to the Xcode projects
​https://bugs.webkit.org/show_bug.cgi?id=150015

Reviewed by Yusuke Suzuki.

• WebCore.xcodeproj/project.pbxproj:

8:34 PM Changeset in webkit [190849] by Simon Fraser

• 20 edits in trunk/Source/WebCore

Cleanup and simplification of SVG path-related classes
​https://bugs.webkit.org/show_bug.cgi?id=150011

Reviewed by Zalan Bujtas.

Many SVG path-related subclasses were stateful, but only because code in
SVGPathUtilities kept global copies around for no reason. A microbenchmark
showed that there was no benefit to keeping global singletons of SVGPathBuilder,
SVGPathSegListBuilder, SVGPathByteStreamBuilder, SVGPathStringBuilder,
SVGPathTraversalStateBuilder, SVGPathParser and SVGPathBlender.

Making these classes not be re-usable makes the code much simpler, allowing
their SVGPathSources, SVGPathConsumers, SVGPathByteStream etc. to be stored
by reference, and eliminating the cleanup() function which created annoying
ordering issues.

Code that uses SVGPathParser and SVGPathBlender is further simplified by having
these classes expose only static functions, hiding any internal statefulness.

• svg/SVGPathBlender.cpp: Remove the m_progress member variable and instead

pass progress to the various blend functions, as we do for other blend functions.
Expose two only static functions. Pointers to references.
(WebCore::SVGPathBlender::addAnimatedPath):
(WebCore::SVGPathBlender::blendAnimatedPath):
(WebCore::SVGPathBlender::SVGPathBlender):
(WebCore::SVGPathBlender::blendAnimatedDimensonalFloat):
(WebCore::SVGPathBlender::blendAnimatedFloatPoint):
(WebCore::SVGPathBlender::blendMoveToSegment):
(WebCore::SVGPathBlender::blendLineToSegment):
(WebCore::SVGPathBlender::blendLineToHorizontalSegment):
(WebCore::SVGPathBlender::blendLineToVerticalSegment):
(WebCore::SVGPathBlender::blendCurveToCubicSegment):
(WebCore::SVGPathBlender::blendCurveToCubicSmoothSegment):
(WebCore::SVGPathBlender::blendCurveToQuadraticSegment):
(WebCore::SVGPathBlender::blendCurveToQuadraticSmoothSegment):
(WebCore::SVGPathBlender::blendArcToSegment):
(WebCore::SVGPathBlender::cleanup): Deleted.

• svg/SVGPathBlender.h: Make the constructor take a ref to the destination Path,

which is stored by reference.

• svg/SVGPathBuilder.cpp:

(WebCore::SVGPathBuilder::SVGPathBuilder):
(WebCore::SVGPathBuilder::moveTo):
(WebCore::SVGPathBuilder::lineTo):
(WebCore::SVGPathBuilder::curveToCubic):
(WebCore::SVGPathBuilder::closePath):

• svg/SVGPathBuilder.h:

(WebCore::SVGPathBuilder::setCurrentPath): Deleted.

• svg/SVGPathByteStreamBuilder.cpp: References, assertions removed.

(WebCore::SVGPathByteStreamBuilder::SVGPathByteStreamBuilder):

• svg/SVGPathByteStreamBuilder.h:

(WebCore::SVGPathByteStreamBuilder::writeType):
(WebCore::SVGPathByteStreamBuilder::setCurrentByteStream): Deleted.

• svg/SVGPathConsumer.h:
• svg/SVGPathElement.cpp:
• svg/SVGPathParser.cpp: Expose some static helper functions for parsing

to byte streams and strings. References.
(WebCore::SVGPathParser::parse):
(WebCore::SVGPathParser::parseToByteStream):
(WebCore::SVGPathParser::parseToString):
(WebCore::SVGPathParser::SVGPathParser):
(WebCore::SVGPathParser::parseClosePathSegment):
(WebCore::SVGPathParser::parseMoveToSegment):
(WebCore::SVGPathParser::parseLineToSegment):
(WebCore::SVGPathParser::parseLineToHorizontalSegment):
(WebCore::SVGPathParser::parseLineToVerticalSegment):
(WebCore::SVGPathParser::parseCurveToCubicSegment):
(WebCore::SVGPathParser::parseCurveToCubicSmoothSegment):
(WebCore::SVGPathParser::parseCurveToQuadraticSegment):
(WebCore::SVGPathParser::parseCurveToQuadraticSmoothSegment):
(WebCore::SVGPathParser::parseArcToSegment):
(WebCore::SVGPathParser::parsePathData):
(WebCore::SVGPathParser::decomposeArcToCubic):
(WebCore::SVGPathParser::parsePathDataFromSource): Deleted.
(WebCore::SVGPathParser::cleanup): Deleted.

• svg/SVGPathParser.h:

(WebCore::SVGPathParser::setCurrentConsumer): Deleted.
(WebCore::SVGPathParser::setCurrentSource): Deleted.

• svg/SVGPathSegListBuilder.cpp:

(WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder):
(WebCore::SVGPathSegListBuilder::moveTo):
(WebCore::SVGPathSegListBuilder::lineTo):
(WebCore::SVGPathSegListBuilder::lineToHorizontal):
(WebCore::SVGPathSegListBuilder::lineToVertical):
(WebCore::SVGPathSegListBuilder::curveToCubic):
(WebCore::SVGPathSegListBuilder::curveToCubicSmooth):
(WebCore::SVGPathSegListBuilder::curveToQuadratic):
(WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth):
(WebCore::SVGPathSegListBuilder::arcTo):
(WebCore::SVGPathSegListBuilder::closePath):

• svg/SVGPathSegListBuilder.h:

(WebCore::SVGPathSegListBuilder::setCurrentSVGPathElement): Deleted.
(WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegList): Deleted.
(WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegRole): Deleted.

• svg/SVGPathStringBuilder.cpp:

(WebCore::SVGPathStringBuilder::cleanup): Deleted.

• svg/SVGPathStringBuilder.h:
• svg/SVGPathTraversalStateBuilder.cpp:

(WebCore::SVGPathTraversalStateBuilder::SVGPathTraversalStateBuilder):
(WebCore::SVGPathTraversalStateBuilder::moveTo):
(WebCore::SVGPathTraversalStateBuilder::lineTo):
(WebCore::SVGPathTraversalStateBuilder::curveToCubic):
(WebCore::SVGPathTraversalStateBuilder::closePath):
(WebCore::SVGPathTraversalStateBuilder::continueConsuming):
(WebCore::SVGPathTraversalStateBuilder::totalLength):
(WebCore::SVGPathTraversalStateBuilder::currentPoint):
(WebCore::SVGPathTraversalStateBuilder::setDesiredLength): Deleted.

• svg/SVGPathTraversalStateBuilder.h:

(WebCore::SVGPathTraversalStateBuilder::pathSegmentIndex):
(WebCore::SVGPathTraversalStateBuilder::setCurrentTraversalState): Deleted.

• svg/SVGPathUtilities.cpp: Remove globals accessors, making things on the stack

instead. Use SVGPathParser helper functions where possible.
(WebCore::buildPathFromString):
(WebCore::buildSVGPathByteStreamFromSVGPathSegList):
(WebCore::appendSVGPathByteStreamFromSVGPathSeg):
(WebCore::buildPathFromByteStream):
(WebCore::buildSVGPathSegListFromByteStream):
(WebCore::buildStringFromByteStream):
(WebCore::buildStringFromSVGPathSegList):
(WebCore::buildSVGPathByteStreamFromString):
(WebCore::buildAnimatedSVGPathByteStream):
(WebCore::addToSVGPathByteStream):
(WebCore::getSVGPathSegAtLengthFromSVGPathByteStream):
(WebCore::getTotalLengthOfSVGPathByteStream):
(WebCore::getPointAtLengthOfSVGPathByteStream):
(WebCore::buildStringFromPath):
(WebCore::globalSVGPathBuilder): Deleted.
(WebCore::globalSVGPathSegListBuilder): Deleted.
(WebCore::globalSVGPathByteStreamBuilder): Deleted.
(WebCore::globalSVGPathStringBuilder): Deleted.
(WebCore::globalSVGPathTraversalStateBuilder): Deleted.
(WebCore::globalSVGPathParser): Deleted.
(WebCore::globalSVGPathBlender): Deleted.

• svg/SVGPathUtilities.h:
• svg/SVGToOTFFontConversion.cpp: CFFBuilder no longer inherits from SVGPathBuilder.

It did nothing with the Path, re-implemented all the functions, and only made use of
the m_current member var, so just make it inherit from SVGPathConsumer, and have
its own m_current.
(WebCore::SVGToOTFFontConverter::transcodeGlyphPaths):

6:47 PM Writing Layout Tests to test iOS UI features edited by dbates@webkit.org

Fix typos and make the content read well. (diff)

1:23 PM Changeset in webkit [190848] by mmaxfield@apple.com

• 16 edits
  4 copies
  3 adds
  15 deletes in trunk

Test font-variant-* and font-feature-settings with mocked preinstalled fonts
​https://bugs.webkit.org/show_bug.cgi?id=149777

Reviewed by Simon Fraser.

Tools:

Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
to the list of tests to preinstall at startup time.

Also, update the generation of the 'name' table in the FontWithFeatures font.

• DumpRenderTree/mac/DumpRenderTree.mm:

(allowedFontFamilySet):
(activateTestingFonts):
(activateFontsIOS):

• FontWithFeatures/FontWithFeatures/FontCreator.cpp:

(Generator::generate):
(Generator::appendCFFTable):
(Generator::appendNameSubtable):
(Generator::appendNAMETable):

• FontWithFeatures/FontWithFeatures/main.cpp:

(main):

• WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:

(WTR::allowedFontFamilySet):
(WTR::activateFonts):

• WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::allowedFontFamilySet):

LayoutTests:

See per-file comments.

• css3/font-feature-settings-preinstalled-fonts.html: Removed. Superseded by

css3/font-feature-settings-rendering.html.

• css3/font-feature-settings-rendering-2-expected.html: Removed.
• css3/font-feature-settings-rendering-2.html: Removed. Renamed to

css3/font-feature-settings-rendering.html

• css3/font-feature-settings-rendering-expected.html: Added.
• css3/font-feature-settings-rendering.html:
• css3/font-variant-all-expected.html:
• css3/font-variant-all.html:
• css3/resources/FontWithFeatures.otf: Update for new 'name' table.
• css3/resources/FontWithFeatures.ttf: Ditto.

11:46 AM Changeset in webkit [190847] by Yusuke Suzuki

• 9 edits
  1 add in trunk

ES6 classes: When a class extends B, super() invokes B.prototype.constructor() instead of B()
​https://bugs.webkit.org/show_bug.cgi?id=149001

Reviewed by Saam Barati.

Source/JavaScriptCore:

This patch matches the super() call in the constructor to the latest spec.
Before this patch, when calling super(), it loads callee.[[HomeObject]].__proto__.constructor
as a super constructor. But after this patch, it loads callee.__proto__ as a super constructor.
This behavior corresponds to the section 12.3.5.2[1].

[1]: ​http://www.ecma-international.org/ecma-262/6.0/#sec-getsuperconstructor

• bytecompiler/NodesCodegen.cpp:

(JSC::SuperNode::emitBytecode):

• tests/stress/super-call-does-not-look-up-constructor.js: Added.

(shouldBe):
(B):
(C):
(B.prototype):

LayoutTests:

An error message becomes changed.

• js/class-syntax-call-expected.txt:
• js/class-syntax-extends-expected.txt:
• js/class-syntax-super-expected.txt:
• js/script-tests/class-syntax-call.js:
• js/script-tests/class-syntax-extends.js:
• js/script-tests/class-syntax-super.js:

9:09 AM Changeset in webkit [190846] by hur.ims@navercorp.com

• 2 edits in trunk/Tools

Unreviewed. Add Jinyoung Hur as a committer.

• Scripts/webkitpy/common/config/contributors.json:

12:18 AM Changeset in webkit [190845] by Antti Koivisto

• 17 edits
  4 deletes in trunk/Source/WebCore

Remove InsertionPoint and ContentDistributor
​https://bugs.webkit.org/show_bug.cgi?id=150004

Rubber-stamped by Sam Weinig.

Now that <details> is on top of the modern Shadow DOM remove the last vestiges of the V0 Shadow DOM API.

• CMakeLists.txt:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.xcodeproj/project.pbxproj:
• css/SelectorChecker.cpp:
• css/StyleResolver.cpp:
• dom/ContainerNode.cpp:
• dom/Element.cpp:

(WebCore::shouldUseNodeRenderingTraversalSlowPath):
(WebCore::Element::resetNeedsNodeRenderingTraversalSlowPath):

• dom/Node.cpp:

(WebCore::Node::parentOrShadowHostElement):
(WebCore::Node::insertedInto):
(WebCore::Node::insertionParentForBinding): Deleted.

• dom/Node.h:

(WebCore::Node::isCharacterDataNode):
(WebCore::Node::isFrameOwnerElement):
(WebCore::Node::isPluginElement):
(WebCore::Node::isImageControlsRootElement):
(WebCore::Node::isImageControlsButtonElement):
(WebCore::Node::isDocumentFragment):
(WebCore::Node::isShadowRoot):
(WebCore::Node::isInsertionPointNode): Deleted.
(WebCore::Node::isInsertionPoint): Deleted.

• dom/NodeRenderingTraversal.cpp:

(WebCore::NodeRenderingTraversal::traverseParent):
(WebCore::NodeRenderingTraversal::traverseFirstChild):
(WebCore::NodeRenderingTraversal::traverseLastChild):
(WebCore::NodeRenderingTraversal::traverseNextSibling):
(WebCore::NodeRenderingTraversal::traversePreviousSibling):
(WebCore::NodeRenderingTraversal::parentSlow):
(WebCore::NodeRenderingTraversal::nextInScope):
(WebCore::NodeRenderingTraversal::previousInScope):
(WebCore::NodeRenderingTraversal::parentInScope):
(WebCore::NodeRenderingTraversal::lastChildInScope):
(WebCore::NodeRenderingTraversal::nodeCanBeDistributed): Deleted.
(WebCore::NodeRenderingTraversal::findFirstSiblingEnteringInsertionPoints): Deleted.
(WebCore::NodeRenderingTraversal::findFirstEnteringInsertionPoints): Deleted.
(WebCore::NodeRenderingTraversal::findFirstFromDistributedNode): Deleted.
(WebCore::NodeRenderingTraversal::findLastSiblingEnteringInsertionPoints): Deleted.
(WebCore::NodeRenderingTraversal::findLastEnteringInsertionPoints): Deleted.
(WebCore::NodeRenderingTraversal::findLastFromDistributedNode): Deleted.

• dom/ShadowRoot.h:

(WebCore::ShadowRoot::distributor): Deleted.

• html/HTMLInputElement.cpp:
• html/HTMLSlotElement.cpp:
• html/HTMLSlotElement.h:
• html/shadow/ContentDistributor.cpp: Removed.
• html/shadow/ContentDistributor.h: Removed.
• html/shadow/InsertionPoint.cpp: Removed.
• html/shadow/InsertionPoint.h: Removed.
• page/FocusController.cpp:

(WebCore::FocusController::previousFocusableElement):

• testing/Internals.cpp:

Oct 10, 2015:

11:16 PM Changeset in webkit [190844] by Simon Fraser

• 10 edits in trunk/Source/WebCore

Use references and more const in SVGPathUtilities
​https://bugs.webkit.org/show_bug.cgi?id=150007

Reviewed by Zalan Bujtas.

SVGPathUtilities had lots of pointers whose non-nullness was asserted,
little const, and was very trigger-happy with stack allocations. Clean
that all up.

• svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::constructFromString):
(WebCore::SVGAnimatedPathAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedPathAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedPathAnimator::calculateAnimatedValue):

• svg/SVGPathByteStream.h:

(WebCore::SVGPathByteStream::begin):
(WebCore::SVGPathByteStream::end):
(WebCore::SVGPathByteStream::append):

• svg/SVGPathByteStreamSource.cpp:

(WebCore::SVGPathByteStreamSource::SVGPathByteStreamSource):

• svg/SVGPathByteStreamSource.h:
• svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::getTotalLength):
(WebCore::SVGPathElement::getPointAtLength):
(WebCore::SVGPathElement::getPathSegAtLength):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathByteStream):
(WebCore::SVGPathElement::lookupOrCreateDWrapper):
(WebCore::SVGPathElement::pathSegListChanged):
(WebCore::SVGPathElement::SVGPathElement): Deleted.

• svg/SVGPathElement.h:
• svg/SVGPathUtilities.cpp:

(WebCore::globalSVGPathBuilder):
(WebCore::globalSVGPathSegListBuilder):
(WebCore::globalSVGPathByteStreamBuilder):
(WebCore::globalSVGPathStringBuilder):
(WebCore::globalSVGPathTraversalStateBuilder):
(WebCore::globalSVGPathParser):
(WebCore::globalSVGPathBlender):
(WebCore::buildPathFromString):
(WebCore::buildSVGPathByteStreamFromSVGPathSegList):
(WebCore::appendSVGPathByteStreamFromSVGPathSeg):
(WebCore::buildPathFromByteStream):
(WebCore::buildSVGPathSegListFromByteStream):
(WebCore::buildStringFromByteStream):
(WebCore::buildStringFromSVGPathSegList):
(WebCore::buildSVGPathByteStreamFromString):
(WebCore::buildAnimatedSVGPathByteStream):
(WebCore::addToSVGPathByteStream):
(WebCore::getSVGPathSegAtLengthFromSVGPathByteStream):
(WebCore::getTotalLengthOfSVGPathByteStream):
(WebCore::getPointAtLengthOfSVGPathByteStream):
(WebCore::buildStringFromPath):

• svg/SVGPathUtilities.h:
• svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:

(WebCore::SVGAnimatedPathSegListPropertyTearOff::animValDidChange):

2:14 PM Changeset in webkit [190843] by akling@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Reduce pointless malloc traffic in CodeBlock construction.
<​https://webkit.org/b/149999>

Reviewed by Antti Koivisto.

Create the RefCountedArray<Instruction> for CodeBlock's m_instructions directly
instead of first creating a Vector<Instruction> and then creating a RefCountedArray
from that. None of the Vector functionality is needed here anyway.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::insertBasicBlockBoundariesForControlFlowProfiler):

• bytecode/CodeBlock.h:

2:13 PM Changeset in webkit [190842] by akling@apple.com

• 3 edits in trunk/Source/WebCore

Reduce pointless malloc traffic in ElementRuleCollector.
<​https://webkit.org/b/150003>

Reviewed by Antti Koivisto.

Don't use a unique_ptr for the m_matchedRules vector in ElementRuleCollector.
This is one of our heaviest sources of transient allocations, with ~88000
malloc/free pairs on loading theverge.com.

• css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::addMatchedRule):
(WebCore::ElementRuleCollector::clearMatchedRules):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
(WebCore::ElementRuleCollector::sortMatchedRules):
(WebCore::ElementRuleCollector::hasAnyMatchingRules):

• css/ElementRuleCollector.h:

(WebCore::ElementRuleCollector::hasMatchedRules):

1:05 PM Changeset in webkit [190841] by mitz@apple.com

• 66 edits in trunk

[iOS] Remove unnecessary iOS version checks
​https://bugs.webkit.org/show_bug.cgi?id=150002

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

• llvm/library/LLVMExports.cpp:

(initializeAndGetJSCLLVMAPI):

Source/WebCore:

• loader/cache/CachedFont.cpp:

(WebCore::CachedFont::ensureCustomFontData):

• loader/cocoa/DiskCacheMonitorCocoa.h:

(WebCore::DiskCacheMonitor::monitorFileBackingStoreCreation):

• page/mac/SettingsMac.mm:

(WebCore::sansSerifTraditionalHanFontFamily):
(WebCore::sansSerifSimplifiedHanFontFamily):

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::appendOpenTypeFeature):

• platform/graphics/ios/FontCacheIOS.mm:

(WebCore::getSystemFontFallbackForCharacters):
(WebCore::platformLookupFallbackFont):

• platform/ios/PlatformSpeechSynthesizerIOS.mm:

(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):

• platform/ios/WebCoreSystemInterfaceIOS.h:
• platform/ios/WebVideoFullscreenControllerAVKit.mm:
• platform/ios/WebVideoFullscreenInterfaceAVKit.h:
• platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
• platform/ios/wak/WAKWindow.mm:

(+[WAKWindow hasLandscapeOrientation]):
(-[WAKWindow hostLayer]):

• platform/network/cf/CookieJarCFNet.cpp:

(WebCore::copyCookiesForURLWithFirstPartyURL):
(WebCore::createCookies):

• platform/network/mac/CertificateInfoMac.mm:

(WebCore::CertificateInfo::containsNonRootSHA1SignedCertificate):

• platform/spi/cf/CFNetworkSPI.h:
• platform/spi/cocoa/AVKitSPI.h:
• platform/spi/cocoa/CoreTextSPI.h:
• platform/spi/cocoa/NEFilterSourceSPI.h:
• platform/spi/cocoa/QuartzCoreSPI.h:
• platform/spi/cocoa/SecuritySPI.h:
• platform/spi/ios/LaunchServicesSPI.h:
• platform/spi/mac/AVFoundationSPI.h:
• platform/text/TextBreakIterator.cpp:
• platform/text/TextFlags.h:
• platform/text/ios/LocalizedDateCache.mm:

(WebCore::LocalizedDateCache::calculateMaximumWidth):

• platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::LocaleMac):

• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::cachedSystemFontDescription):
(WebCore::RenderThemeIOS::updateCachedSystemFontDescription):

• svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::appendKERNTable):
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter):

Source/WebKit/mac:

• Plugins/WebPluginController.h:
• Plugins/WebPluginController.mm:

(-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
(+[WebPluginController addPlugInView:]):
(+[WebPluginController plugInViewWithArguments:fromPluginPackage:]): Deleted.

• WebCoreSupport/WebFrameLoaderClient.mm:

(pluginView):

• WebView/WebPreferences.mm:

(-[WebPreferences isDNSPrefetchingEnabled]):
(-[WebPreferences setWebInspectorServerEnabled:]): Deleted.
(-[WebPreferences _setAllowCompositingLayerVisualDegradation:]): Deleted.

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(shouldAllowPictureInPictureMediaPlayback):

Source/WebKit2:

• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

• Platform/IPC/mac/ConnectionMac.mm:

(IPC::AccessibilityProcessSuspendedNotification):

• Platform/spi/ios/SafariServicesSPI.h:
• Platform/spi/ios/UIKitSPI.h:
• Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):

• Shared/Network/NetworkProcessCreationParameters.h:
• Shared/Plugins/PluginProcessCreationParameters.cpp:

(WebKit::PluginProcessCreationParameters::encode):
(WebKit::PluginProcessCreationParameters::decode):

• Shared/Plugins/PluginProcessCreationParameters.h:
• Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformTouchPoint::WebKit2PlatformTouchPoint):

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• Shared/ios/NativeWebTouchEventIOS.mm:

(WebKit::NativeWebTouchEvent::extractWebTouchPoint):
(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):

• Shared/ios/WebPlatformTouchPointIOS.cpp:

(WebKit::WebPlatformTouchPoint::encode):
(WebKit::WebPlatformTouchPoint::decode):

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _mayAutomaticallyShowVideoPictureInPicture]):
(shouldAllowPictureInPictureMediaPlayback):
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInitializeNetworkProcess):

• UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::platformInitializePluginProcess):

• UIProcess/ios/ViewGestureControllerIOS.mm:

(-[WKSwipeTransitionController gestureRecognizerForInteractiveTransition:WithTarget:action:]):

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView _ensureFormAccessoryView]):
(-[WKContentView webSelectionAssistant]):
(-[WKContentView selectionInteractionAssistant]):

• UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::create):

• UIProcess/ios/forms/WKFileUploadPanel.mm:

(photoLibraryIcon):
(cameraIcon):
(fallbackIconForFile):
(iconForImageFile):

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Source/WTF:

• wtf/Platform.h:

Tools:

• WebKitTestRunner/ios/HIDEventGenerator.mm:

(-[HIDEventGenerator _createIOHIDEventType:]):
(-[HIDEventGenerator _sendHIDEvent:]):
(-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):

• WebKitTestRunner/ios/UIKitSPI.h:

11:16 AM Changeset in webkit [190840] by Antti Koivisto

• 27 edits in trunk

Rewrite HTMLDetailsElement using HTMLSlotElement
​https://bugs.webkit.org/show_bug.cgi?id=149698

Reviewed by Andreas Kling.

Source/WebCore:

Use the modern Shadow DOM to implement <details> element. After this the legacy InsertionPoint and
related code can be removed.

Based on a patch by Ryosuke.

• dom/Element.cpp:

(WebCore::Element::childrenChanged):

• dom/EventDispatcher.cpp:

(WebCore::EventPath::EventPath):

• dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::~ShadowRoot):
(WebCore::ShadowRoot::removeAllEventListeners):
(WebCore::ShadowRoot::findAssignedSlot):
(WebCore::ShadowRoot::addSlotElementByName):
(WebCore::ShadowRoot::removeSlotElementByName):
(WebCore::ShadowRoot::invalidateSlotAssignments):
(WebCore::ShadowRoot::invalidateDefaultSlotAssignments):
(WebCore::ShadowRoot::assignedNodesForSlot):

• dom/ShadowRoot.h:

(WebCore::ShadowRoot::create):
(WebCore::ShadowRoot::distributor):
(WebCore::ShadowRoot::isOrphan):

• dom/SlotAssignment.cpp:

(WebCore::slotNameFromAttributeValue):

Rename for clarity.

(WebCore::slotNameFromSlotAttribute):

SlotAssignment can now be specialized by providing function that maps from node to slot name.
This is the default function that gets the name from the slot attribute.

(WebCore::SlotAssignment::SlotAssignment):
(WebCore::SlotAssignment::findAssignedSlot):

Use the name mapping function.
Ensure that the slots are assigned.

(WebCore::SlotAssignment::addSlotElementByName):
(WebCore::SlotAssignment::removeSlotElementByName):
(WebCore::SlotAssignment::assignedNodesForSlot):
(WebCore::SlotAssignment::invalidate):
(WebCore::SlotAssignment::invalidateDefaultSlot):
(WebCore::SlotAssignment::resolveAllSlotElements):
(WebCore::SlotAssignment::assignSlots):

Use the name mapping function.

(WebCore::SlotAssignment::assignToSlot):

Factor into function.

(WebCore::treatNullAsEmpty): Deleted.

• dom/SlotAssignment.h:

(WebCore::SlotAssignment::~SlotAssignment):
(WebCore::SlotAssignment::defaultSlotName):

Add static getter for emptyAtom for clarity.

(WebCore::SlotAssignment::SlotAssignment): Deleted.

• html/HTMLDetailsElement.cpp:

(WebCore::summarySlotName):
(WebCore::slotNameFunction):

Slot name function for <details>. It assigns the first <summary> child to the summary slot and others
to the default content slot if the element is open.

(WebCore::HTMLDetailsElement::create):
(WebCore::HTMLDetailsElement::didAddUserAgentShadowRoot):
(WebCore::HTMLDetailsElement::isActiveSummary):
(WebCore::HTMLDetailsElement::parseAttribute):
(WebCore::HTMLDetailsElement::toggleOpen):
(WebCore::summaryQuerySelector): Deleted.
(WebCore::DetailsContentElement::create): Deleted.
(WebCore::DetailsSummaryElement::create): Deleted.
(WebCore::HTMLDetailsElement::findMainSummary): Deleted.
(WebCore::HTMLDetailsElement::childShouldCreateRenderer): Deleted.

• html/HTMLDetailsElement.h:
• html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::create):
(WebCore::HTMLSummaryElement::createElementRenderer):
(WebCore::HTMLSummaryElement::didAddUserAgentShadowRoot):
(WebCore::HTMLSummaryElement::detailsElement):
(WebCore::HTMLSummaryElement::isActiveSummary):
(WebCore::isClickableControl):
(WebCore::HTMLSummaryElement::supportsFocus):
(WebCore::HTMLSummaryElement::defaultEventHandler):
(WebCore::HTMLSummaryElement::willRespondToMouseClickEvents):
(WebCore::SummaryContentElement::create): Deleted.
(WebCore::HTMLSummaryElement::childShouldCreateRenderer): Deleted.
(WebCore::HTMLSummaryElement::isMainSummary): Deleted.

• html/HTMLSummaryElement.h:
• html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::rendererIsNeeded):

• style/RenderTreePosition.cpp:

(WebCore::RenderTreePosition::computeNextSibling):

Skip the verification assert for shadow host children. Getting this right requires
better shadow-aware traversal code.

• style/StyleResolveTree.cpp:

(WebCore::Style::invalidateWhitespaceOnlyTextSiblingsAfterAttachIfNeeded):
(WebCore::Style::attachChildren):
(WebCore::Style::attachShadowRoot):
(WebCore::Style::attachBeforeOrAfterPseudoElementIfNeeded):
(WebCore::Style::attachSlotAssignees):
(WebCore::Style::attachRenderTree):
(WebCore::Style::detachChildren):
(WebCore::Style::detachShadowRoot):
(WebCore::Style::detachSlotAssignees):
(WebCore::Style::detachRenderTree):
(WebCore::Style::resolveChildren):
(WebCore::Style::resolveSlotAssignees):
(WebCore::Style::resolveTree):
(WebCore::Style::attachDistributedChildren): Deleted.
(WebCore::Style::detachDistributedChildren): Deleted.

Remove InsertionPoint related code paths.

LayoutTests:

• TestExpectations:
• platform/mac/fast/html/details-add-child-2-expected.txt:
• platform/mac/fast/html/details-open2-expected.txt:
• platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
• platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:

8:50 AM Changeset in webkit [190839] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Improve error messages for internal Inspector code
​https://bugs.webkit.org/show_bug.cgi?id=149995

Don't log "error.stack" since the error view already includes a nicely formatted stacktrace.

Reviewed by Timothy Hatcher.

• UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass.prototype._dispatchResponseToCallback):
(InspectorBackendClass.prototype._dispatchEvent):

8:27 AM Changeset in webkit [190838] by akling@apple.com

• 4 edits in trunk

SerializedScriptValue should use a compact encoding for 8-bit strings.
<​https://webkit.org/b/149934>

Reviewed by Antti Koivisto.

Source/WebCore:

We were encoding known 8-bit strings in a 16-bit format when serializing script values.

Extend the format to support 8-bit strings. The 8-bittiness is encoded in the highest bit
of the string length. This is possible while supporting all older formats due to string
lengths >= 0x7FFFFFFF being disallowed.

This patch knocks ~1 MB off of theverge.com, where some ad or tracker or whatever likes to
do a ton of postMessage() business.

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CurrentVersion): Bump the serialization format version. Also updated the grammar
comment to describe the new format. Artistic license applied in description of bitfield.

(WebCore::writeLittleEndianUInt16): Deleted.

(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::deserializeString):
(WebCore::CloneDeserializer::readString):
(WebCore::CloneDeserializer::readStringData): Support 8-bit strings. I kept the string
length limit at UINT_MAX/sizeof(UChar) since the highest bit of the length is no longer
available. Besides, it seems flimsy to support longer strings if they happen to have all
8-bit characters.

LayoutTests:

Update a test to reflect changes to the serialization format.

• fast/storage/serialized-script-value.html:

1:40 AM Changeset in webkit [190837] by mitz@apple.com

• 31 edits in trunk/Source

[iOS] Remove project support for iOS 8
​https://bugs.webkit.org/show_bug.cgi?id=149993

Reviewed by Alexey Proskuryakov.

Source/bmalloc:

• Configurations/Base.xcconfig:
• Configurations/bmalloc.xcconfig:
• Configurations/mbmalloc.xcconfig:

Source/JavaScriptCore:

• Configurations/Base.xcconfig:
• Configurations/JSC.xcconfig:
• Configurations/JavaScriptCore.xcconfig:
• Configurations/LLVMForJSC.xcconfig:
• Configurations/ToolExecutable.xcconfig:

Source/ThirdParty/ANGLE:

• Configurations/ANGLE.xcconfig:
• Configurations/Base.xcconfig:

Source/WebCore:

• Configurations/WebCore.xcconfig:
• Configurations/WebCoreTestSupport.xcconfig:

Source/WebKit/mac:

• Configurations/WebKitLegacy.xcconfig:

Source/WebKit2:

• Configurations/Base.xcconfig:
• Configurations/BaseLegacyProcess.xcconfig:
• Configurations/BaseXPCService.xcconfig:
• Configurations/PluginProcessShim.xcconfig:
• Configurations/SecItemShim.xcconfig:
• Configurations/WebKit.xcconfig:
• Configurations/WebKit2.xcconfig:
• Configurations/WebProcessShim.xcconfig:

Source/WTF:

• Configurations/Base.xcconfig:
• Configurations/WTF.xcconfig:
• Configurations/mbmalloc.xcconfig: