Context Navigation

In the current implementation, class methods attempt to declare variables to an upper scope with their method names.
But this is not specified behavior in the ES6 spec.

And as a result, previously, we attempted to declare variables with invalid identifiers.
For example, class A { 1() { } } attempt to declare a variable with name 1.
This (declaring variables with incorrect names) is not allowed in the lexical environment.
And it fires assertions in https://bugs.webkit.org/show_bug.cgi?id=150089.

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass): Deleted.

tests/stress/class-method-does-not-declare-variable-to-upper-scope.js: Added.

(shouldBe):
(A.prototype.method):
(A.staticMethod):
(A):

10:27 PM Changeset in webkit [191085] by ap@apple.com

1 edit
1 copy in trunk/LayoutTests

[Win] Layout Test http/tests/multipart/multipart-replace-non-html-content.php has extra whitespace
https://bugs.webkit.org/show_bug.cgi?id=150130

Landing a custom expectation. The test still passes, although it surprisingly gets
the extra newline.

platform/win/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Copied from LayoutTests/http/tests/multipart/multipart-replace-non-html-content-expected.txt.

10:19 PM Changeset in webkit [191084] by commit-queue@webkit.org

25 edits
2 adds in trunk/Source

Augment <input type=search>’s recent search history with the time each entry was added,
in order to allow time-based clearing of search history.
https://bugs.webkit.org/show_bug.cgi?id=148388.

Patch by Zhuo Li <zachli@apple.com> on 2015-10-14
Reviewed by Darin Adler.

Replace Vector<String> with Vector<RecentSearch>, where RecentSearch is a struct
Source/WebCore:

that consists search string and time, for recent searches in order to store additional time
information.

WebCore.xcodeproj/project.pbxproj: Added SearchPopupMenuCocoa.h and SearchPopupMenuCocoa.mm

and sort the project file.

loader/EmptyClients.cpp:

(WebCore::EmptySearchPopupMenu::saveRecentSearches):
(WebCore::EmptySearchPopupMenu::loadRecentSearches):

platform/SearchPopupMenu.h:
platform/cocoa/SearchPopupMenuCocoa.h: Added methods for SeachPopupMenuMac in WebKit

and WebPageProxyCocoa in WebKit2 to call.

platform/cocoa/SearchPopupMenuCocoa.mm: Added.

(WebCore::searchFieldRecentSearchesStorageDirectory): Recent searches with the new structure
are stored in a new location.
(WebCore::searchFieldRecentSearchesPlistPath): Get the path for the plist of the recent
searches entries.
(WebCore::RetainPtr<NSMutableDictionary> readSearchFieldRecentSearchesPlist): Return the
recent searches plist as NSMutableDictionary.
(WebCore::fromNSDatetoSystemClockTime): Convert from NSDate to system_clock::time_point.
(WebCore::fromSystemClockTimetoNSDate): Convert from system_clock::time_point to NSDate.
(WebCore::SearchPopupMenuCocoa::saveRecentSearches): Add a dictionary where it has two pairs
that the first one is the search string and the second one is the time.
(WebCore::SearchPopupMenuCocoa::loadRecentSearches): We expect the recent search item in the
plist to be a two-pair dictionary, and convert the dictionary to the struct RecentSearch.

platform/win/SearchPopupMenuWin.cpp:

(WebCore::SearchPopupMenuWin::saveRecentSearches): Only save the RecentSearch's search
string on Windows platform, which is what we used to do.
(WebCore::SearchPopupMenuWin::loadRecentSearches): Since we need to construct a
RecentSearch, we get the string from the app's preferences, and set the time to be
std::chrono::system_clock::time_point::min().

platform/win/SearchPopupMenuWin.h:
rendering/RenderSearchField.cpp: Now that m_recentSearches are Vector<RecentSearch>,

we cannot use -removeAll with a search string. Use -removeAllMatching instead to remove the
item that has its member search string equal to the search string user inputs.
(WebCore::RenderSearchField::addSearchResult):
(WebCore::RenderSearchField::itemText):

Source/WebKit/ios:

that consists search string and time, for recent searches in order to store additional time information.

WebCoreSupport/SearchPopupMenuIOS.cpp:

(SearchPopupMenuIOS::saveRecentSearches):
(SearchPopupMenuIOS::loadRecentSearches):

WebCoreSupport/SearchPopupMenuIOS.h:

Source/WebKit/mac:

that consists search string and time, for recent searches in order to store additional time information.

All these new RecentSearches are stored in a plist in which the structure looks like:
Root {

"items": {

autosave name: {

"searches": [

{ "searchString": searchString, "date": date },
...

]

}

}

}

WebCoreSupport/SearchPopupMenuMac.h:
WebCoreSupport/SearchPopupMenuMac.mm:

(SearchPopupMenuMac::saveRecentSearches): Call saveRecentSearches in WebCore::SearchPopupMenuCocoa.
(SearchPopupMenuMac::loadRecentSearches): Call loadRecentSearches in WebCore::SearchPopupMenuCocoa.
(autosaveKey): Deleted.

Source/WebKit2:

that consists search string and time, for recent searches in order to store additional time
information.

All these new RecentSearches are stored in a plist in which the structure looks like:
Root {

"items": {

autosave name: {

"searches": [

{ "searchString": searchString, "date": date },
...

]

}

}

}

Scripts/webkit/messages.py:

(headers_for_type):

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<RecentSearch>::encode): Encode the new struct RecentSearch
(IPC::ArgumentCoder<RecentSearch>::decode): Decode the new struct RecentSearch

Shared/WebCoreArgumentCoders.h:
UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::saveRecentSearches): Call saveRecentSearches in WebCore::SearchPopupMenuCocoa.
(WebKit::WebPageProxy::loadRecentSearches): Call loadRecentSearches in WebCore::SearchPopupMenuCocoa.

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):

UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):

WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:

(WebKit::WebSearchPopupMenu::saveRecentSearches):
(WebKit::WebSearchPopupMenu::loadRecentSearches):

WebProcess/WebCoreSupport/WebSearchPopupMenu.h:

9:55 PM Changeset in webkit [191083] by Simon Fraser

14 edits in trunk/Source/WebCore

Use RefPtr<Image> return type for StyleImage::image()
https://bugs.webkit.org/show_bug.cgi?id=150112

Reviewed by Andreas Kling.

Change StyleImage::image() and subclasses to return RefPtr<Image>
instead of a PassRefPtr<Image>.

WebCore.xcodeproj/project.pbxproj:
rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::image):

rendering/RenderImageResource.h:
rendering/RenderImageResourceStyleImage.cpp:

(WebCore::RenderImageResourceStyleImage::image):

rendering/RenderImageResourceStyleImage.h:
rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::image):

rendering/style/StyleCachedImage.h:
rendering/style/StyleCachedImageSet.cpp:

(WebCore::StyleCachedImageSet::image):

rendering/style/StyleCachedImageSet.h:
rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::image):

rendering/style/StyleGeneratedImage.h:
rendering/style/StyleImage.h:
rendering/style/StylePendingImage.h:

9:47 PM Changeset in webkit [191082] by Simon Fraser

5 edits in trunk/Source/WebCore

Give subclasses of CSSImageGeneratorValue a consistent image() return type
https://bugs.webkit.org/show_bug.cgi?id=150111

Reviewed by Andreas Kling.

CSSImageGeneratorValue and subclasses had signatures of the non-virtual image() function
with mistmatched return types; some returned RefPtr<Image>, and others PassRefPtr<Image>. Make
them all the same.

css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::image):

css/CSSImageGeneratorValue.h:
css/CSSNamedImageValue.cpp:

(WebCore::CSSNamedImageValue::image):

css/CSSNamedImageValue.h:

8:53 PM Changeset in webkit [191081] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

REGRESSION: Web Inspector hangs for many seconds when trying to reload page
https://bugs.webkit.org/show_bug.cgi?id=150065

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-14
Reviewed by Mark Lam.

When debugging Web Pages, the same Debugger (PageScriptDebugServer) is
attached to each of the different JSGlobalObjects on the page. This could
mean multiple frames or isolated scripting contexts. Therefore we should
only need to send sourceParsed events to the frontend for scripts within
this new JSGlobalObject, not any JSGlobalObject that has this debugger.

debugger/Debugger.cpp:

(JSC::Debugger::attach):
Only send sourceParsed events for Scripts in this JSGlobalObject.

6:21 PM Changeset in webkit [191080] by timothy_horton@apple.com

3 edits in trunk/Source/WebCore

Move some EventHandler initialization to the header
https://bugs.webkit.org/show_bug.cgi?id=150139

Reviewed by Andreas Kling.

No new tests, just cleanup.

page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler): Deleted.

page/EventHandler.h:

Also found one member which was unused, and a few that were uninitialized.
It's likely the uninitialized ones didn't actually cause any trouble because
they are reset in lots of places, but this seems better.

6:06 PM Changeset in webkit [191079] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Remove unimplemented methods in CopiedSpace
https://bugs.webkit.org/show_bug.cgi?id=150143

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-14
Reviewed by Andreas Kling.

heap/CopiedSpace.h:

5:57 PM Changeset in webkit [191078] by aestes@apple.com

2 edits in trunk/Tools

[iOS] build-dumprendertree does not build ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=150152

Reviewed by Tim Horton.

run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
WebKit.xcworkspace), tests that rely on image diffing won't work properly.

There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
fine on that platform, and results in ImageDiff being built.

Scripts/build-dumprendertree:

5:52 PM Changeset in webkit [191077] by commit-queue@webkit.org

4 edits
3 adds in trunk

[Content Extensions] Make blocked async XHR call onerror
https://bugs.webkit.org/show_bug.cgi?id=146706

Patch by Alex Christensen <achristensen@webkit.org> on 2015-10-14
Reviewed by Brady Eidson.

Source/WebCore:

Test: http/tests/contentextensions/async-xhr-onerror.html

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::createRequest):
(WebCore::XMLHttpRequest::networkError):
(WebCore::XMLHttpRequest::networkErrorTimerFired):
(WebCore::XMLHttpRequest::abortError):

xml/XMLHttpRequest.h:

Make a timer that calls networkError in 0 time if a content blocker blocks the asynchronous load.
It is necessary to call setPendingActivity and dropProtection (which calls unsetPendingActivity)
to keep a reference to the XMLHttpRequest alive.

LayoutTests:

http/tests/contentextensions/async-xhr-onerror-expected.txt: Added.
http/tests/contentextensions/async-xhr-onerror.html: Added.
http/tests/contentextensions/async-xhr-onerror.html.json: Added.

5:21 PM Changeset in webkit [191076] by aestes@apple.com

5 edits
9 adds in trunk

[iOS] QuickLook documents loaded over https do not load their subresources
https://bugs.webkit.org/show_bug.cgi?id=150145
<rdar://problem/22884521>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

When QuickLook generates an HTML preview of a document, subresources are referenced using the x-apple-ql-id scheme,
for which QuickLook installs an NSURLProtocol. If a document is loaded over https, then this scheme needs to be
considered secure in order to avoid mixed content errors.

Test: http/tests/quicklook/secure-document-with-subresources.html

platform/SchemeRegistry.cpp:

(WebCore::secureSchemes): Registered QLPreviewProtocol() as a secure scheme.

LayoutTests:

TestExpectations: Skipped http/tests/quicklook on all platforms.
http/tests/quicklook/resources/secure-document-with-subresources-expected/index.css: Added.
http/tests/quicklook/resources/secure-document-with-subresources-expected/index.html: Added.
http/tests/quicklook/resources/secure-document-with-subresources.pages: Added.
http/tests/quicklook/resources/webkit-icon.tiff: Added.
http/tests/quicklook/secure-document-with-subresources-expected.html: Added.
http/tests/quicklook/secure-document-with-subresources.html: Added.
platform/ios-simulator/TestExpectations: Expected http/tests/quicklook to pass on iOS.

5:11 PM Changeset in webkit [191075] by Brent Fulgham

8 edits in trunk

[Win] Enforce launcher/library naming scheme
https://bugs.webkit.org/show_bug.cgi?id=150124

Reviewed by Alex Christensen.

Source/JavaScriptCore:

JavaScriptCore.vcxproj/jsc/DLLLauncherMain.cpp: Look for

{name}Lib.dll instead of {name}.dll.
(wWinMain):

shell/PlatformWin.cmake: Add 'Lib' suffix to DLLs.

Tools:

DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
MiniBrowser/win/CMakeLists.txt: Ditto.
TestWebKitAPI/PlatformWin.cmake: Ditto.
win/DLLLauncher/DLLLauncherMain.cpp:

(wWinMain): Look for a DLL named {name}Lib.dll, rather than the
original {name}.dll.

4:19 PM Changeset in webkit [191074] by commit-queue@webkit.org

2 edits in trunk/LayoutTests/imported/w3c

Fixing expectations for imported/w3c/web-platform-tests/html/dom/interfaces.html
https://bugs.webkit.org/show_bug.cgi?id=150144.

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-14
Reviewed by Dean Jackson.

web-platform-tests/html/dom/interfaces-expected.txt:

3:51 PM Changeset in webkit [191073] by matthew_hanson@apple.com

4 edits
2 adds in branches/safari-601-branch

Merge r191008. rdar://problem/23111794

2:20 PM Changeset in webkit [191072] by Wenson Hsieh

5 edits
2 adds in trunk

Web pages with unscalable viewports shouldn't have a single tap delay
https://bugs.webkit.org/show_bug.cgi?id=149968
<rdar://problem/23054453>

Reviewed by Simon Fraser.

Source/WebKit2:

When a viewport is unscalable (specified through the meta viewport tag) we
do not add a delay to our single tap gesture recognizer. We do this by
disabling or reinitializing the WKContentView's double tap gesture recognizer
when the viewport becomes unscalable or scalable, respectively. A viewport is
deemed unscalable when it has user-scalable = no, or when the minimum scale is
greater than or equal to the maximum scale.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _createAndConfigureDoubleTapGestureRecognizer]): Pulled logic

for initializing a double tap gesture recognizer out into a helper function.

(-[WKContentView setupInteraction]):
(-[WKContentView _setDoubleTapGesturesEnabled:]): Turns gesture recognition for double

taps on or off.

LayoutTests:

Add a layout test to check that when a viewport is unscalable (specified through
the meta viewport tag) we do not add a delay to our single tap gesture recognizer.

fast/events/ios/unscalable-viewport-clicks-on-doubletap-expected.txt: Added.
fast/events/ios/unscalable-viewport-clicks-on-doubletap.html: Added.

2:03 PM Changeset in webkit [191071] by Joseph Pecoraro

7 edits in trunk/Source/WebInspectorUI

Web Inspector: Console SearchBar should work more like ContentBrowser FindBanner
https://bugs.webkit.org/show_bug.cgi?id=149505

Patch by João Oliveira <hello@jxs.pt> on 2015-10-13
Reviewed by Joseph Pecoraro.

Console tab now uses findBanner, adapted LogContentView to use findBanner,
and findBanner to be more agnostic to both usecases, either as fixed, on console tab,
and hideable on other inspector tabs.

UserInterface/Views/FindBanner.css:

(.find-banner.console-find-banner):
(.find-banner.console-findbanner input[type="search"]):

UserInterface/Views/FindBanner.js:

(WebInspector.FindBanner):
(WebInspector.FindBanner.set targetElement.delayedWork):
(WebInspector.FindBanner.prototype.set targetElement):
(WebInspector.FindBanner.prototype.get showing):
(WebInspector.FindBanner.prototype.focus):
(WebInspector.FindBanner.prototype._clearAndBlur):
(WebInspector.FindBanner.prototype.show.delayedWork):
(WebInspector.FindBanner.prototype.show):
(WebInspector.FindBanner.prototype.hide):
(WebInspector.FindBanner.prototype.get element): Deleted.
(WebInspector.FindBanner.prototype._inputFieldSearch): Deleted.

UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype.get navigationItems):
(WebInspector.LogContentView.prototype.handleFindEvent):
(WebInspector.LogContentView.prototype.findBannerRevealPreviousResult):
(WebInspector.LogContentView.prototype.findBannerRevealNextResult):
(WebInspector.LogContentView.prototype._filterMessageElements):
(WebInspector.LogContentView.prototype.findBannerPerformSearch):
(WebInspector.LogContentView.prototype.findBannerSearchCleared):
(WebInspector.LogContentView.prototype.revealNextSearchResult):
(WebInspector.LogContentView.prototype.revealPreviousSearchResult):
(WebInspector.LogContentView.prototype._performSearch):
(WebInspector.LogContentView.prototype.searchBarDidActivate): Deleted.
(WebInspector.LogContentView.prototype._searchTextDidChange): Deleted.

1:52 PM Changeset in webkit [191070] by dino@apple.com

2 edits in trunk/LayoutTests/imported/w3c

Update test result for Canvas2DRenderingContext::commit.

web-platform-tests/html/dom/interfaces-expected.txt:

1:45 PM Changeset in webkit [191069] by akling@apple.com

4 edits in trunk

REGRESSION(r190882): Concatenating a character array and an empty string is broken.
<https://webkit.org/b/150135>

Reviewed by Geoffrey Garen.

Source/WTF:

StringAdapter templates for raw character arrays were always using 1 as the array length
in toString().

wtf/text/StringConcatenate.h:

Tools:

Add a new WTF API test that covers this issue.

TestWebKitAPI/Tests/WTF/StringOperators.cpp:

(TestWebKitAPI::build):
(TestWebKitAPI::TEST):

1:25 PM Changeset in webkit [191068] by bshafiei@apple.com

1 copy in tags/Safari-602.1.7

New tag.

1:24 PM Changeset in webkit [191067] by bshafiei@apple.com

5 edits in trunk/Source

Versioning.

1:11 PM Changeset in webkit [191066] by commit-queue@webkit.org

3 edits
2 adds in trunk

Postpone mutation events before invoke Editor::Command command(Document*, const String&, bool).
https://bugs.webkit.org/show_bug.cgi?id=149299
<rdar://problem/22746995>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-14
Reviewed by Andreas Kling.

Source/WebCore:

Test: editing/inserting/insert-with-mutation-event.html

This is a merge of a part of Blink r166294:
https://codereview.chromium.org/141103006

dom/Document.cpp:

(WebCore::Document::execCommand):

LayoutTests:

editing/inserting/insert-with-mutation-event-expected.txt: Added.
editing/inserting/insert-with-mutation-event.html: Added.

1:10 PM Changeset in webkit [191065] by andersca@apple.com

7 edits in trunk/Source/WebKit2

Remove a message that isn't used by anyone
https://bugs.webkit.org/show_bug.cgi?id=150136

Reviewed by Andreas Kling.

UIProcess/API/APILoaderClient.h:

(API::LoaderClient::didRemoveFrameFromHierarchy): Deleted.

UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLoaderClient): Deleted.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didRemoveFrameFromHierarchy): Deleted.

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::detachedFromParent2): Deleted.

1:05 PM Changeset in webkit [191064] by dino@apple.com

4 edits
2 adds in trunk

Implement CanvasRenderingContext2D::commit
https://bugs.webkit.org/show_bug.cgi?id=150110
<rdar://problem/23057398>

Reviewed by Anders Carlsson.

Source/WebCore:

As part of getting as close as possible to the HTML5 specification,
implement the commit() method on 2d canvas, even though it doesn't
do anything.

Test: fast/canvas/commit.html

bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::JSCanvasRenderingContext2D::commit): Intercept it here to
avoid adding a method to the actual implementation.

html/canvas/CanvasRenderingContext2D.idl: Add commit.

LayoutTests:

fast/canvas/commit-expected.txt: Added.
fast/canvas/commit.html: Added.

1:03 PM Changeset in webkit [191063] by achristensen@apple.com

25 edits
3 deletes in trunk

Add SPI for reloading without content blockers
https://bugs.webkit.org/show_bug.cgi?id=150058
rdar://problem/22742222

Reviewed by Sam Weinig.

Source/WebCore:

loader/FrameLoader.cpp:

(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::reload):

loader/FrameLoader.h:
page/Page.h:

(WebCore::Page::userContentController):
(WebCore::Page::userContentExtensionsEnabled): Deleted.
(WebCore::Page::setUserContentExtensionsEnabled): Deleted.

replay/UserInputBridge.cpp:

(WebCore::UserInputBridge::loadRequest):
(WebCore::UserInputBridge::reloadFrame):
(WebCore::UserInputBridge::stopLoadingFrame):

replay/UserInputBridge.h:

Pass a bool from the reloadWithoutContentBlockers call to the DocumentLoader,
which stores the state of whether the content blockers are enabled or not.
Remove the state from the Page and copying the state from the Page to the DocumentLoader
because that caused issues with the content blockers being re-enabled at the wrong time.

Source/WebKit2:

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:
UIProcess/API/C/WKPage.cpp:

(WKPageReload):
(WKPageReloadWithoutContentBlockers):
(WKPageReloadFromOrigin):
(WKPageTryClose):
(WKPageSetUserContentExtensionsEnabled):
(WKPageSupportsTextEncoding):

UIProcess/API/C/WKPage.h:
UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController reload]):
(-[WKBrowsingContextController reloadFromOrigin]):
(-[WKBrowsingContextController applicationNameForUserAgent]):

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView reload]):
(-[WKWebView reloadFromOrigin]):
(-[WKWebView _setUserContentExtensionsEnabled:]):
(-[WKWebView _userContentExtensionsEnabled]):
(-[WKWebView _webProcessIdentifier]):
(-[WKWebView _killWebContentProcess]):
(-[WKWebView _reloadWithoutContentBlockers]):
(-[WKWebView _killWebContentProcessAndResetState]):

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_reload):
(webkit_web_view_reload_bypass_cache):

UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didHandleContentFilterUnblockNavigation):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::stopLoading):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setShouldScaleViewToFitDocument):
(WebKit::WebPageProxy::setUserContentExtensionsEnabled): Deleted.

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::userContentExtensionsEnabled): Deleted.

WebProcess/WebPage/WebPage.cpp:

(WebKit::m_shouldDispatchFakeMouseMoveEvents):
(WebKit::WebPage::setDefersLoading):
(WebKit::WebPage::reload):
(WebKit::WebPage::goForward):
(WebKit::WebPage::createDocumentLoader):
(WebKit::WebPage::setShouldScaleViewToFitDocument):
(WebKit::WebPage::imageOrMediaDocumentSizeChanged):
(WebKit::WebPage::setUserContentExtensionsEnabled): Deleted.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Tools:

WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaResetStateToConsistentValues):

WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformConfigureViewForTest):

LayoutTests:

http/tests/contentextensions/disable-blocker-expected.txt: Removed.
http/tests/contentextensions/disable-blocker.html: Removed.
http/tests/contentextensions/disable-blocker.html.json: Removed.

_userContentExtensionsEnabled is going to be removed, and its functionality is what this test tested.

12:52 PM Changeset in webkit [191062] by matthew_hanson@apple.com

2 edits in branches/safari-601-branch/Source/WebCore

Merge r188477. rdar://problem/22801969

12:52 PM Changeset in webkit [191061] by matthew_hanson@apple.com

2 edits in branches/safari-601-branch/Source/WebCore

Merge r188473. rdar://problem/22801969

12:18 PM Changeset in webkit [191060] by youenn.fablet@crf.canon.fr

49 edits in trunk/Source/WebCore

Rename JSDOMWrapper to JSDOMObject and JSDOMWrapperWithImplementation to JSDOMWrapper
https://bugs.webkit.org/show_bug.cgi?id=150120

Reviewed by Sam Weinig.

No change in behavior.

bindings/js/DOMWrapperWorld.h:
bindings/js/JSDOMBinding.h:

(WebCore::DOMConstructorObject::DOMConstructorObject):
(WebCore::getInlineCachedWrapper):
(WebCore::setInlineCachedWrapper):
(WebCore::clearInlineCachedWrapper):
(WebCore::createWrapper):
(WebCore::getStaticValueSlotEntryWithoutCaching<JSDOMObject>):

bindings/js/JSDOMWrapper.cpp:
bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMObject::JSDOMObject):
(WebCore::JSDOMWrapper::~JSDOMWrapper):
(WebCore::JSDOMWrapper::JSDOMWrapper):

bindings/js/JSElementCustom.cpp:

(WebCore::toJSNewlyCreated):

bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline):

bindings/js/ScriptWrappable.h:
bindings/js/ScriptWrappableInlines.h:

(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::clearWrapper):

bindings/scripts/CodeGeneratorJS.pm:

(GetParentClassName):

bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObject::JSTestActiveDOMObject):

bindings/scripts/test/JS/JSTestActiveDOMObject.h:
bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::JSTestCustomConstructorWithNoInterfaceObject::JSTestCustomConstructorWithNoInterfaceObject):

bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.h:
bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter):

bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::JSTestEventConstructor):

bindings/scripts/test/JS/JSTestEventConstructor.h:
bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTarget::JSTestEventTarget):

bindings/scripts/test/JS/JSTestEventTarget.h:
bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestException::JSTestException):

bindings/scripts/test/JS/JSTestException.h:
bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachable::JSTestGenerateIsReachable):

bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::JSTestInterface):

bindings/scripts/test/JS/JSTestInterface.h:
bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::JSTestJSBuiltinConstructor::JSTestJSBuiltinConstructor):

bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h:
bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):

bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::JSTestNamedConstructor):

bindings/scripts/test/JS/JSTestNamedConstructor.h:
bindings/scripts/test/JS/JSTestNondeterministic.cpp:

(WebCore::JSTestNondeterministic::JSTestNondeterministic):

bindings/scripts/test/JS/JSTestNondeterministic.h:
bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::JSTestObj):

bindings/scripts/test/JS/JSTestObj.h:
bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructors::JSTestOverloadedConstructors):

bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::JSTestOverrideBuiltins::JSTestOverrideBuiltins):

bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefs::JSTestTypedefs):

bindings/scripts/test/JS/JSTestTypedefs.h:
bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::JSattribute::JSattribute):

bindings/scripts/test/JS/JSattribute.h:
bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::JSreadonly::JSreadonly):

bindings/scripts/test/JS/JSreadonly.h:
dom/make_names.pl:

(printWrapperFunctions):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):

12:07 PM Changeset in webkit [191059] by keith_miller@apple.com

13 edits
1 copy
6 adds in trunk/Source/JavaScriptCore

ES6 Fix TypedArray constructors.
https://bugs.webkit.org/show_bug.cgi?id=149975

Reviewed by Geoffrey Garen.

The ES6 spec requires that any object argument passed to a TypedArray constructor that is not a TypedArray
and has an iterator should use the iterator to construct the TypedArray. To avoid performance regressions related
to iterating we check if the iterator attached to the object points to the generic array iterator and length is a value.
If so, we do not use the iterator since there should be no observable difference. Another other interesting note is
that the ES6 spec has the of and from functions on a shared constructor between all the TypedArray constructors.
When the TypedArray is constructed the expectation is to crawl the prototype chain of the this value
passed to the function. If the function finds a known TypedArray constructor (Int32Array, Float64Array,...) then
it creates a TypedArray of that type. This is implemented by adding a private function (@allocateTypedArray) to each
of the constructors that can be called in order to construct the array. By using the private functions the JIT should
hopefully be able to optimize this to a direct call.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
builtins/TypedArrayConstructor.js: Added.

(of):
(from):
(allocateInt8Array):
(allocateInt16Array):
(allocateInt32Array):
(allocateUint32Array):
(allocateUint16Array):
(allocateUint8Array):
(allocateUint8ClampedArray):
(allocateFloat32Array):
(allocateFloat64Array):

runtime/CommonIdentifiers.h:
runtime/JSDataView.cpp:

(JSC::JSDataView::setIndex):

runtime/JSDataView.h:
runtime/JSGenericTypedArrayView.h:

(JSC::JSGenericTypedArrayView::toAdaptorNativeFromValue):

runtime/JSGenericTypedArrayViewConstructor.h:
runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::finishCreation):
(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::create):
(JSC::constructGenericTypedArrayViewFromIterator):
(JSC::constructGenericTypedArrayView):

runtime/JSGenericTypedArrayViewPrototypeFunctions.h:

(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

runtime/JSTypedArrayViewConstructor.cpp: Added.

(JSC::JSTypedArrayViewConstructor::JSTypedArrayViewConstructor):
(JSC::JSTypedArrayViewConstructor::finishCreation):
(JSC::JSTypedArrayViewConstructor::create):
(JSC::JSTypedArrayViewConstructor::createStructure):
(JSC::constructTypedArrayView):
(JSC::JSTypedArrayViewConstructor::getConstructData):
(JSC::JSTypedArrayViewConstructor::getCallData):

runtime/JSTypedArrayViewConstructor.h: Copied from Source/JavaScriptCore/runtime/JSGenericTypedArrayViewConstructor.h.
runtime/JSTypedArrayViewPrototype.cpp:

(JSC::JSTypedArrayViewPrototype::create):

tests/es6.yaml:
tests/stress/resources/typedarray-constructor-helper-functions.js: Added.

(forEachTypedArray):
(hasSameValues):
(foo):
(testConstructorFunction):
(testConstructor):

tests/stress/typedarray-constructor.js: Added.

(A):
(iterator.return.next):
(iterator):
(obj.valueOf):
(iterator2.return.next):
(iterator2):

tests/stress/typedarray-from.js: Added.

(even):
(isBigEnoughAndException):

tests/stress/typedarray-of.js: Added.

11:57 AM Changeset in webkit [191058] by mark.lam@apple.com

56 edits in trunk

Rename some JSC option names to be more uniform.
https://bugs.webkit.org/show_bug.cgi?id=150127

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Renaming JSC_enableXXX options to JSC_useXXX, and JSC_showXXX options to JSC_dumpXXX.
Also will renaming a few other miscellaneous to options, to abide by this scheme.

Also renaming some functions to match the option names where relevant.

API/tests/ExecutionTimeLimitTest.cpp:

(testExecutionTimeLimit):

assembler/AbstractMacroAssembler.h:

(JSC::optimizeForARMv7IDIVSupported):
(JSC::optimizeForARM64):
(JSC::optimizeForX86):

assembler/LinkBuffer.cpp:

(JSC::shouldDumpDisassemblyFor):
(JSC::LinkBuffer::finalizeCodeWithoutDisassembly):
(JSC::shouldShowDisassemblyFor): Deleted.

assembler/LinkBuffer.h:
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::jettison):

bytecode/CodeBlockJettisoningWatchpoint.cpp:

(JSC::CodeBlockJettisoningWatchpoint::fireInternal):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp:

(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::fire):

dfg/DFGAdaptiveStructureWatchpoint.cpp:

(JSC::DFG::AdaptiveStructureWatchpoint::fireInternal):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parse):

dfg/DFGCommon.h:

(JSC::DFG::leastUpperBound):
(JSC::DFG::shouldDumpDisassembly):
(JSC::DFG::shouldShowDisassembly): Deleted.

dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::disassemble):

dfg/DFGJumpReplacement.cpp:

(JSC::DFG::JumpReplacement::fire):

dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

dfg/DFGOSRExitCompiler.cpp:
dfg/DFGOSRExitFuzz.h:

(JSC::DFG::doOSRExitFuzzing):

dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithSqrt):

dfg/DFGTierUpCheckInjectionPhase.cpp:

(JSC::DFG::TierUpCheckInjectionPhase::run):

ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

ftl/FTLJITCode.cpp:

(JSC::FTL::JITCode::~JITCode):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::callCheck):

ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):
(JSC::FTL::compileFTLOSRExit):

ftl/FTLState.h:

(JSC::FTL::verboseCompilationEnabled):
(JSC::FTL::shouldDumpDisassembly):
(JSC::FTL::shouldShowDisassembly): Deleted.

heap/Heap.cpp:

(JSC::Heap::addToRememberedSet):
(JSC::Heap::didFinishCollection):
(JSC::Heap::shouldDoFullCollection):

heap/Heap.h:

(JSC::Heap::isDeferred):
(JSC::Heap::structureIDTable):

heap/HeapStatistics.cpp:

(JSC::StorageStatistics::storageCapacity):
(JSC::HeapStatistics::dumpObjectStatistics):
(JSC::HeapStatistics::showObjectStatistics): Deleted.

heap/HeapStatistics.h:
interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::createArguments):

jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::callExceptionFuzz):

jit/ExecutableAllocationFuzz.cpp:

(JSC::doExecutableAllocationFuzzing):

jit/ExecutableAllocationFuzz.h:

(JSC::doExecutableAllocationFuzzingIfEnabled):

jit/JIT.cpp:

(JSC::JIT::privateCompile):

jit/JITCode.cpp:

(JSC::JITCodeWithCodeRef::~JITCodeWithCodeRef):

jit/PolymorphicCallStubRoutine.cpp:

(JSC::PolymorphicCallNode::unlink):
(JSC::PolymorphicCallNode::clearCallLinkInfo):
(JSC::PolymorphicCallStubRoutine::PolymorphicCallStubRoutine):

jit/Repatch.cpp:

(JSC::linkFor):
(JSC::unlinkFor):
(JSC::linkVirtualFor):

jsc.cpp:

(functionEnableExceptionFuzz):
(jscmain):

llvm/InitializeLLVM.cpp:

(JSC::initializeLLVMImpl):

runtime/ExceptionFuzz.cpp:

(JSC::doExceptionFuzzing):

runtime/ExceptionFuzz.h:

(JSC::doExceptionFuzzingIfEnabled):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

runtime/Options.cpp:

(JSC::recomputeDependentOptions):
(JSC::Options::initialize):
(JSC::Options::dumpOptionsIfNeeded):
(JSC::Options::setOption):
(JSC::Options::dumpAllOptions):
(JSC::Options::dumpAllOptionsInALine):
(JSC::Options::dumpOption):

runtime/Options.h:
runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:

(JSC::VM::exceptionFuzzingBuffer):

runtime/WriteBarrierInlines.h:

(JSC::WriteBarrierBase<T>::set):
(JSC::WriteBarrierBase<Unknown>::set):

tests/executableAllocationFuzz.yaml:
tests/stress/arrowfunction-typeof.js:
tests/stress/disable-function-dot-arguments.js:

(foo):

tests/stress/math-sqrt-basics-disable-architecture-specific-optimizations.js:

(sqrtOnInteger):

tests/stress/regress-148564.js:

Tools:

Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
Scripts/run-jsc-stress-tests:

11:49 AM Changeset in webkit [191057] by matthew_hanson@apple.com

3 edits
2 adds in branches/safari-601-branch

Merge r190570. rdar://problem/23075530

11:49 AM Changeset in webkit [191056] by matthew_hanson@apple.com

2 edits in branches/safari-601-branch/Source/WebCore

Merge r190382. rdar://problem/22934301

11:49 AM Changeset in webkit [191055] by matthew_hanson@apple.com

4 edits
2 adds in branches/safari-601-branch

Merge r190339. rdar://problem/23075538

11:49 AM Changeset in webkit [191054] by matthew_hanson@apple.com

2 edits in branches/safari-601-branch/Source/WebInspectorUI

Merge r190246. rdar://problem/22939682

11:49 AM Changeset in webkit [191053] by matthew_hanson@apple.com

3 edits in branches/safari-601-branch/Source/WebCore

Merge r190097. rdar://problem/23075540

11:49 AM Changeset in webkit [191052] by matthew_hanson@apple.com

4 edits in branches/safari-601-branch/Source/WebCore

Merge r190007. rdar://problem/23075540

11:49 AM Changeset in webkit [191051] by matthew_hanson@apple.com

2 edits in branches/safari-601-branch/Source/WebCore

Merge r189979. rdar://problem/23075525

11:49 AM Changeset in webkit [191050] by matthew_hanson@apple.com

9 edits
3 adds in branches/safari-601-branch

Merge r189421. rdar://problem/22802049

11:10 AM Changeset in webkit [191049] by Simon Fraser

61 edits in trunk/Source

Change GraphicsContext image-drawing functions to take references
https://bugs.webkit.org/show_bug.cgi?id=150108

Reviewed by Tim Horton and Sam Weinig.

Change GraphicsContext::drawImage(), drawTiledImage(), drawImageBuffer(), clipToImageBuffer()
and isCompatibleWithBuffer() to take references, and adjust calling code, adding
null-checks where necessary.

Source/WebCore:

css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::image):

css/CSSFilterImageValue.cpp:

(WebCore::CSSFilterImageValue::image):

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::compositeBuffer):
(WebCore::drawImageToContext):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

html/canvas/CanvasRenderingContext2D.h:
html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::texSubImage2D):

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::texSubImage2D):

html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::drawImageIntoBuffer):
(WebCore::WebGLRenderingContextBase::texImage2D):

html/canvas/WebGLRenderingContextBase.h:
platform/ScrollView.cpp:

(WebCore::ScrollView::paintPanScrollIcon):

platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::drawCrossfadeSubimage):
(WebCore::CrossfadeGeneratedImage::drawCrossfade):

platform/graphics/CrossfadeGeneratedImage.h:
platform/graphics/GradientImage.cpp:

(WebCore::GradientImage::drawPattern):

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
(WebCore::GraphicsContext::drawImageBuffer):
(WebCore::GraphicsContext::clipToImageBuffer):
(WebCore::GraphicsContext::isCompatibleWithBuffer):

platform/graphics/GraphicsContext.h:
platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::drawShadowBuffer):
(WebCore::ShadowBlur::drawRectShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithTiling):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
(WebCore::ShadowBlur::drawLayerPieces):
(WebCore::ShadowBlur::endShadowLayer):

platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::draw):

platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::draw):

platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::platformApplySoftware):

platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::platformApplySoftware):

platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::platformApplySoftware):

platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::platformApplySoftware):

platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::platformApplySoftware):

platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::platformApplySoftware):

platform/graphics/filters/FETile.cpp:

(WebCore::FETile::platformApplySoftware):

platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::platformApplySoftware):

platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::platformApplySoftware):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::paint):

platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:

(WebCore::ImageBackingSurfaceClient::ImageBackingSurfaceClient):
(WebCore::CoordinatedImageBacking::update):

platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::drawCellOrFocusRingWithViewIntoContext):

rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRendererHelper::applyFilterEffect):

rendering/ImageQualityController.cpp:

(WebCore::ImageQualityController::shouldPaintAtLowQuality):

rendering/ImageQualityController.h:
rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::shouldPaintAtLowQuality):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

rendering/RenderBoxModelObject.h:
rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintSnapshotImage):
(WebCore::RenderEmbeddedObject::paintContents):

rendering/RenderEmbeddedObject.h:
rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):

rendering/RenderImageResourceStyleImage.cpp:

(WebCore::RenderImageResourceStyleImage::shutdown):
(WebCore::RenderImageResourceStyleImage::image):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::drawPlatformResizerImage):

rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint):

rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::paintSnapshot):

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintProgressBar):
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):

rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecorationPart):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):

rendering/shapes/Shape.cpp:

(WebCore::Shape::createRasterShape):

rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::createShapeForImage): Deleted.

rendering/style/NinePieceImage.cpp:

(WebCore::NinePieceImage::paint):

rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::paintForeground):

rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):

rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::clipToImageBuffer):
(WebCore::SVGRenderingContext::bufferForeground):

svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::platformApplySoftware):

Source/WebKit/win:

FullscreenVideoController.cpp:

(HUDButton::draw):

Plugins/PluginView.cpp:

(WebCore::PluginView::paintMissingPluginIcon):

Source/WebKit2:

Shared/ContextMenuContextData.cpp:

(WebKit::ContextMenuContextData::ContextMenuContextData):

Shared/WebCoreArgumentCoders.cpp:

(IPC::encodeImage):
(IPC::encodeOptionalImage):
(IPC::ArgumentCoder<Cursor>::encode):

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createSelectionSnapshot):

10:29 AM Changeset in webkit [191048] by commit-queue@webkit.org

5 edits
2 adds in trunk

REGRESSION(r53318): background-repeat: space with gradients doesn't render correctly
https://bugs.webkit.org/show_bug.cgi?id=150068

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-10-14
Reviewed by Simon Fraser.

Source/WebCore:

This is a regression of r53318 in which we were trying to make the pattern
of the gradient image as small as possible: 1-pixel wide or tall. But this
broke the rendering of the background image when container element has the
style background-repeat: space. The reason for this is tiling the gradient
image is done completely by CG. To do the tiling, we start by creating a
CGPattern by calling CGPatternCreate() which takes the rect of the pattern
and the step. If the width or the height of the pattern image is adjusted
to be 1-pixel wide or tall, that will force CG to leave a space after every
it draws the pattern image which is 1-pixel wide or tall which is wrong.

The fix is to disable this optimization altogether if the container element
has the style background-repeat: space.

Test: fast/gradients/background-image-repeat-space.html

platform/graphics/Gradient.cpp:

(WebCore::Gradient::adjustParametersForTiledDrawing):

platform/graphics/Gradient.h:
platform/graphics/GradientImage.cpp:

(WebCore::GradientImage::drawPattern):

LayoutTests:

Ensure the gradient background-image is drawn correctly when it is repeated
with spaces.

fast/gradients/background-image-repeat-space-expected.html: Added.
fast/gradients/background-image-repeat-space.html: Added.

10:23 AM Changeset in webkit [191047] by andersca@apple.com

11 edits in trunk

Change the bundle app cache APIs to take a page
https://bugs.webkit.org/show_bug.cgi?id=150123

Reviewed by Sam Weinig.

Source/WebKit2:

This is another step towards getting rid of ApplicationCacheStorage::singleton().
Ideally the WKTR tests that use this should be converted to API tests.

WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleClearApplicationCache): Deleted.
(WKBundleClearApplicationCacheForOrigin): Deleted.
(WKBundleSetAppCacheMaximumSize): Deleted.
(WKBundleGetAppCacheUsageForOrigin): Deleted.
(WKBundleSetApplicationCacheOriginQuota): Deleted.
(WKBundleResetApplicationCacheOriginQuota): Deleted.
(WKBundleCopyOriginsWithApplicationCache): Deleted.

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageClearApplicationCache):
(WKBundlePageClearApplicationCacheForOrigin):
(WKBundlePageSetAppCacheMaximumSize):
(WKBundlePageGetAppCacheUsageForOrigin):
(WKBundlePageSetApplicationCacheOriginQuota):
(WKBundlePageResetApplicationCacheOriginQuota):
(WKBundlePageCopyOriginsWithApplicationCache):

WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::clearApplicationCache): Deleted.
(WebKit::InjectedBundle::clearApplicationCacheForOrigin): Deleted.
(WebKit::InjectedBundle::setAppCacheMaximumSize): Deleted.
(WebKit::InjectedBundle::appCacheUsageForOrigin): Deleted.
(WebKit::InjectedBundle::setApplicationCacheOriginQuota): Deleted.
(WebKit::InjectedBundle::resetApplicationCacheOriginQuota): Deleted.
(WebKit::InjectedBundle::originsWithApplicationCache): Deleted.

WebProcess/InjectedBundle/InjectedBundle.h:

Tools:

Update APIs.

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):

WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::clearAllApplicationCaches):
(WTR::TestRunner::clearApplicationCacheForOrigin):
(WTR::TestRunner::setAppCacheMaximumSize):
(WTR::TestRunner::applicationCacheDiskUsageForOrigin):
(WTR::TestRunner::originsWithApplicationCache):

9:23 AM Changeset in webkit [191046] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Speculative build fix: the CallSiteIndex constructor is explicit and requires an uint32_t.

Not Reviewed.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::newExceptionHandlingCallSiteIndex):

5:59 AM Changeset in webkit [191045] by peavo@outlook.com

2 edits in trunk/Source/WTF

[Win64] Enable concurrent JIT.
https://bugs.webkit.org/show_bug.cgi?id=150098

Reviewed by Csaba Osztrogonác.

wtf/Platform.h:

5:46 AM Changeset in webkit [191044] by youenn.fablet@crf.canon.fr

1 edit in trunk/LayoutTests/imported/w3c/web-platform-tests

Updating LayoutTests/imported/w3c/web-platform-tests svn:ignore property as done in LayoutTests/imported/w3c/web-platform-tests/.gitignore in revision 191043

5:37 AM Changeset in webkit [191043] by youenn.fablet@crf.canon.fr

15 edits
1 copy
3 adds
1 delete in trunk

Update web-platform-tests tools to the latest revision
https://bugs.webkit.org/show_bug.cgi?id=149645

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Removed tools folder.
Updated ImportExpectations and TestRepositories files to match latest wpt repo revision.
Updated web-platform-tests using the import tool.

resources/ImportExpectations: Skipping new test suites.
resources/TestRepositories: Updating revision of default imported web-platform-tests. Disabled conversion of git submodules information.
resources/web-platform-tests-modules.json: Updated by hand the modules description to align with wpt repo.
web-platform-tests/.gitignore: Marking tools folder as ignored.
web-platform-tests/README.md:
web-platform-tests/common/w3c-import.log:
web-platform-tests/config.default.json:
web-platform-tests/domparsing/w3c-import.log:
web-platform-tests/lint: Added.
web-platform-tests/lint.whitelist: Renamed from LayoutTests/imported/w3c/web-platform-tests/tools/scripts/lint.whitelist.
web-platform-tests/manifest: Added.
web-platform-tests/serve: Added.
web-platform-tests/serve.py:

(main):

web-platform-tests/tools/init.py: Removed.
web-platform-tests/tools/runner/css/bootstrap-theme.min.css: Removed.
web-platform-tests/tools/runner/css/bootstrap.min.css: Removed.
web-platform-tests/tools/runner/css/w3c-import.log: Removed.
web-platform-tests/tools/runner/fonts/glyphicons-halflings-regular.eot: Removed.
web-platform-tests/tools/runner/fonts/glyphicons-halflings-regular.svg: Removed.
web-platform-tests/tools/runner/fonts/glyphicons-halflings-regular.ttf: Removed.
web-platform-tests/tools/runner/fonts/glyphicons-halflings-regular.woff: Removed.
web-platform-tests/tools/runner/fonts/w3c-import.log: Removed.
web-platform-tests/tools/runner/logo.svg: Removed.
web-platform-tests/tools/runner/report.css: Removed.
web-platform-tests/tools/runner/report.py: Removed.
web-platform-tests/tools/runner/runner.css: Removed.
web-platform-tests/tools/runner/runner.js: Removed.
web-platform-tests/tools/runner/update_manifest.py: Removed.
web-platform-tests/tools/runner/w3c-import.log: Removed.
web-platform-tests/tools/scripts/init.py: Removed.
web-platform-tests/tools/scripts/_env.py: Removed.
web-platform-tests/tools/scripts/html5lib_test.xml: Removed.
web-platform-tests/tools/scripts/html5lib_test_fragment.xml: Removed.
web-platform-tests/tools/scripts/id2path.js: Removed.
web-platform-tests/tools/scripts/id2path.json: Removed.
web-platform-tests/tools/scripts/lint.py: Removed.
web-platform-tests/tools/scripts/manifest.js: Removed.
web-platform-tests/tools/scripts/manifest.py: Removed.
web-platform-tests/tools/scripts/package.json: Removed.
web-platform-tests/tools/scripts/toc.js: Removed.
web-platform-tests/tools/scripts/update-directory-structure.js: Removed.
web-platform-tests/tools/scripts/update_html5lib_tests.py: Removed.
web-platform-tests/tools/scripts/w3c-import.log: Removed.
web-platform-tests/tools/sslutils/init.py: Removed.
web-platform-tests/tools/sslutils/base.py: Removed.
web-platform-tests/tools/sslutils/openssl.py: Removed.
web-platform-tests/tools/sslutils/pregenerated.py: Removed.
web-platform-tests/tools/sslutils/w3c-import.log: Removed.
web-platform-tests/tools/w3c-import.log: Removed.
web-platform-tests/tools/webdriver/webdriver/init.py: Removed.
web-platform-tests/tools/webdriver/webdriver/alert.py: Removed.
web-platform-tests/tools/webdriver/webdriver/capabilities.py: Removed.
web-platform-tests/tools/webdriver/webdriver/command.py: Removed.
web-platform-tests/tools/webdriver/webdriver/driver.py: Removed.
web-platform-tests/tools/webdriver/webdriver/exceptions.py: Removed.
web-platform-tests/tools/webdriver/webdriver/keys.py: Removed.
web-platform-tests/tools/webdriver/webdriver/searchcontext.py: Removed.
web-platform-tests/tools/webdriver/webdriver/w3c-import.log: Removed.
web-platform-tests/tools/webdriver/webdriver/wait.py: Removed.
web-platform-tests/tools/webdriver/webdriver/webelement.py: Removed.
web-platform-tests/w3c-import.log:

Tools:

Disabling git submodules information conversion to json install file for web-platform-tests.
Disabling related python unit tests.
The tools submodules contain submodules and the conversion tool does not support that yet.

Updating wpt launcher script to aling it with web-platform-test main script.

Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:

(main):

Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:

(TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.

Scripts/webkitpy/w3c/test_importer_unittest.py:

(TestImporterTest.test_submodules_generation):

3:57 AM Changeset in webkit [191042] by commit-queue@webkit.org

4 edits in trunk

[GTK][EFL] Fix build with cmake 3.4
https://bugs.webkit.org/show_bug.cgi?id=150117

Explicitely include the CheckIncludeFiles module before using
the CHECK_INCLUDE_FILES command.

Patch by Tomas Popela <tpopela@redhat.com> on 2015-10-14
Reviewed by Žan Doberšek.

Source/cmake/FindOpenGL.cmake:
Source/cmake/FindWebP.cmake:
Source/cmake/OptionsEfl.cmake:

3:34 AM Changeset in webkit [191041] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL] Fix the problem in which environment variable included in webprocess-cmd-prefix can't be parsed
https://bugs.webkit.org/show_bug.cgi?id=148616

Patch by Joonghun Park <jh718.park@samsung.com> on 2015-10-14
Reviewed by Gyuyoung Kim.

This patch fixes the problem in which environment variable in web process-cmd-prefix can't be parsed.
process-cmd-prefix option doesn't work in two cases.

When executing run-layout-tests,
When executing MiniBrowser with web process-cmd-prefix environment variable.

UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::parseAndRemoveEnvironments):
(WebKit::ProcessLauncher::launchProcess):

12:59 AM Changeset in webkit [191040] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html flakily times out during Mac-WK2 tests
https://bugs.webkit.org/show_bug.cgi?id=150095

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-14
Reviewed by Alexey Proskuryakov.

platform/mac-wk2/TestExpectations:

12:28 AM Changeset in webkit [191039] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.10.1

WebKitGTK+ 2.10.1

12:28 AM Changeset in webkit [191038] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.10

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.10.1 release.

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

gtk/NEWS: Add release notes for 2.10.1

12:08 AM Changeset in webkit [191037] by commit-queue@webkit.org

8 edits
2 deletes in trunk/Source/JavaScriptCore

Unreviewed, rolling out r191030.
https://bugs.webkit.org/show_bug.cgi?id=150116

caused js/class-syntax-method-names.html to crash on debug
builds (Requested by alexchristensen_ on #webkit).

Reverted changeset:

"[ES6] Class expression should have lexical environment that
has itself as an imutable binding"
https://bugs.webkit.org/show_bug.cgi?id=150089
http://trac.webkit.org/changeset/191030

Oct 13, 2015:

11:26 PM Changeset in webkit [191036] by ap@apple.com

5 edits in trunk/Tools

More debug queue build fixing.

Preserve the build style in one more place. Changed mock build_style from "both"
to "release", as we don't support testing both debug and release.

Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:

(MockCommitQueue.archive_last_test_results):
(MockCommitQueue):
(MockCommitQueue.build_style):
(MockCommitQueue.did_pass_testing_ews):

Scripts/webkitpy/tool/bot/patchanalysistask.py:

(PatchAnalysisTask._test):
(PatchAnalysisTask._build_and_test_without_patch):

Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSystemTest._default_expected_logs):

Scripts/webkitpy/tool/commands/queues_unittest.py:

11:16 PM Changeset in webkit [191035] by Carlos Garcia Campos

34 edits in releases/WebKitGTK/webkit-2.10/Source

Merge r191002 - Avoid useless copies in range-loops that are using 'auto'
https://bugs.webkit.org/show_bug.cgi?id=150091

Reviewed by Sam Weinig.

Avoid useless copies in range-loops that are using 'auto'. Also use
'auto*' instead of 'auto' when range values are pointers for clarity.
Source/bmalloc:

bmalloc/Deallocator.cpp:

(bmalloc::Deallocator::processObjectLog):

Source/WebKit/mac:

WebView/WebFrame.mm:

(-[WebFrame getDictationResultRanges:andMetadatas:]):

Source/WebKit2:

UIProcess/VisitedLinkStore.cpp:

(WebKit::VisitedLinkStore::pendingVisitedLinksTimerFired):
(WebKit::VisitedLinkStore::resizeTable):

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::releaseRemainingIconsForPageURLs):

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchData):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::plugins):

11:11 PM Changeset in webkit [191034] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore

Merge r190991 - REGRESSION: ASSERT (impl->isAtomic()) @ facebook.com
https://bugs.webkit.org/show_bug.cgi?id=149965

Reviewed by Geoffrey Garen.

Edge filtering for CheckIdent ensures that a given value is either Symbol or StringIdent.
However, this filtering is not applied to CheckIdent when propagating a constant value in
the constant folding phase. As a result, it is not guaranteeed that a constant value
propagated in constant folding is Symbol or StringIdent.

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

10:11 PM Changeset in webkit [191033] by ap@apple.com

2 edits in trunk/Tools

More debug queue build fixing.

Add build_style argument to derived classes as well.

Scripts/webkitpy/common/config/ports.py:

(MacPort):
(MacPort.run_webkit_tests_command):
(WinPort.run_bindings_tests_command):
(WinPort):
(WinPort.run_webkit_tests_command):
(GtkWK2Port.build_webkit_command):
(GtkWK2Port):
(GtkWK2Port.run_webkit_tests_command):

10:10 PM Changeset in webkit [191032] by mmaxfield@apple.com

3 edits in trunk/Tools

[iOS] Build fix

Unreviewed.

Mach-O section names are limited to 16 characters.

DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
DumpRenderTree/mac/DumpRenderTree.mm:

(activateFontsIOS):

9:54 PM Changeset in webkit [191031] by ap@apple.com

7 edits in trunk/Tools

Build fix for mac-debug EWS queue.

Unreviewed.

Pass --debug to run-webkit-tests.

While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
will need to be substantially modified to work in EWS, so the dummy implementation
was not helpful.

Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.run_javascriptcore_tests_command):
(DeprecatedPort):
(DeprecatedPort.run_webkit_tests_command):
(DeprecatedPort.run_python_unittests_command):
(DeprecatedPort.run_webkit_unit_tests_command): Deleted.

Scripts/webkitpy/common/config/ports_mock.py:

(MockPort.run_javascriptcore_tests_command):
(MockPort):
(MockPort.run_webkit_tests_command):
(MockPort.run_bindings_tests_command):
(MockPort.run_webkit_unit_tests_command): Deleted.

Scripts/webkitpy/tool/commands/download_unittest.py:
Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

Scripts/webkitpy/tool/steps/runtests_unittest.py:

(RunTestsTest.test_webkit_run_unit_tests):

Scripts/webkitpy/tool/steps/steps_unittest.py:

(StepsTest.test_runtests_args):

8:56 PM Changeset in webkit [191030] by Yusuke Suzuki

8 edits
2 adds in trunk/Source/JavaScriptCore

[ES6] Class expression should have lexical environment that has itself as an imutable binding
https://bugs.webkit.org/show_bug.cgi?id=150089

Reviewed by Geoffrey Garen.

According to ES6 spec, class expression has its own lexical environment that holds itself
as an immutable binding[1] (section 14.5.14 step 2, 3, 4, 23)

As a result, even if the binding declared in the outer scope is overridden, methods inside
class expression can refer its class by the class name.

[1]: http://ecma-international.org/ecma-262/6.0/#sec-runtime-semantics-classdefinitionevaluation

bytecompiler/NodesCodegen.cpp:

(JSC::ClassExprNode::emitBytecode):

parser/ASTBuilder.h:

(JSC::ASTBuilder::createClassExpr):

parser/NodeConstructors.h:

(JSC::ClassExprNode::ClassExprNode):

parser/Nodes.h:
parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):

parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createClassExpr):

tests/es6.yaml:
tests/stress/class-expression-generates-environment.js: Added.

(shouldBe):
(shouldThrow):
(prototype.method):
(staticMethod):
(A.prototype.method):
(A.staticMethod):
(A):

tests/stress/class-expression-should-be-tdz-in-heritage.js: Added.

(shouldThrow):
(shouldThrow.A):

8:05 PM Changeset in webkit [191029] by Alan Bujtas

1 edit
17 adds in trunk/LayoutTests

[iOS] Update anonymous table results for iOS port.

Unreviewed gardening.

platform/ios-simulator/css2.1/tables/table-anonymous-objects-177-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-178-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-179-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-180-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-181-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-189-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-190-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-191-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-192-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-193-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-194-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-195-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-196-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-205-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-206-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-207-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-208-expected.txt: Added.

7:38 PM Changeset in webkit [191028] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Unreviewed EFL Gardening on 13th Oct.
https://bugs.webkit.org/show_bug.cgi?id=150084

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-10-13

platform/efl/TestExpectations:

7:18 PM Changeset in webkit [191027] by matthew_hanson@apple.com

12 edits in branches/safari-601-branch/Source

Merge r189834. rdar://problem/22801966

7:14 PM Changeset in webkit [191026] by Alan Bujtas

1 edit
16 adds in trunk/LayoutTests

[Win] Update anonymous table results for Windows port.

Unreviewed gardening.

platform/win/css2.1/tables/table-anonymous-objects-177-expected.txt: Added.
platform/win/css2.1/tables/table-anonymous-objects-178-expected.txt: Added.
platform/win/css2.1/tables/table-anonymous-objects-179-expected.txt: Added.
platform/win/css2.1/tables/table-anonymous-objects-180-expected.txt: Added.
platform/win/css2.1/tables/table-anonymous-objects-189-expected.txt: Added.
platform/win/css2.1/tables/table-anonymous-objects-190-expected.txt: Added.
platform/win/css2.1/tables/table-anonymous-objects-191-expected.txt: Added.
platform/win/css2.1/tables/table-anonymous-objects-192-expected.txt: Added.
platform/win/css2.1/tables/table-anonymous-objects-193-expected.txt: Added.
platform/win/css2.1/tables/table-anonymous-objects-194-expected.txt: Added.
platform/win/css2.1/tables/table-anonymous-objects-195-expected.txt: Added.
platform/win/css2.1/tables/table-anonymous-objects-196-expected.txt: Added.
platform/win/css2.1/tables/table-anonymous-objects-205-expected.txt: Added.
platform/win/css2.1/tables/table-anonymous-objects-206-expected.txt: Added.
platform/win/css2.1/tables/table-anonymous-objects-207-expected.txt: Added.
platform/win/css2.1/tables/table-anonymous-objects-208-expected.txt: Added.

6:09 PM Changeset in webkit [191025] by bshafiei@apple.com

1 copy in tags/Safari-601.1.46.25.2

New tag.

6:02 PM Changeset in webkit [191024] by bshafiei@apple.com

2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merged r191022. rdar://problem/23100514

5:29 PM Changeset in webkit [191023] by bshafiei@apple.com

2 edits in branches/safari-601.1.46.25-branch/Source/WebKit2

Merged r191022. rdar://problem/23100514

5:25 PM Changeset in webkit [191022] by barraclough@apple.com

2 edits in trunk/Source/WebKit2

Use the correct notification strings for view service applications state change.
https://bugs.webkit.org/show_bug.cgi?id=150107

Use the correct notification names "_UIViewServiceHostDidEnterBackgroundNotification" and
"_UIViewServiceHostWillEnterForegroundNotification" to listen to view service application state changes.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2015-10-13
Reviewed by Gavin Barraclough.

UIProcess/ApplicationStateTracker.mm:

(WebKit::ApplicationStateTracker::ApplicationStateTracker):

5:15 PM Changeset in webkit [191021] by bshafiei@apple.com

5 edits in branches/safari-601.1.46.25-branch/Source

Versioning.

5:15 PM Changeset in webkit [191020] by matthew_hanson@apple.com

3 edits in branches/safari-601-branch/Source/WebKit2

Merge r190141. rdar://problem/23075536

5:15 PM Changeset in webkit [191019] by matthew_hanson@apple.com

7 edits in branches/safari-601-branch/Source

Merge r188443. rdar://problem/22801969

5:15 PM Changeset in webkit [191018] by Brent Fulgham

5 edits in trunk/Tools

[Win] Generate Crash Traces
https://bugs.webkit.org/show_bug.cgi?id=150103

Reviewed by Daniel Bates.

We were using an exception filter to try to emit "#CRASHED" to stderr
when a test program crashed. However, the modern Python implementation
seems capable of recognizing crashes on its own. Furthermore, registering
the exception handler was preventing the JIT debugger (NTSD) from
automatically attaching to the crashing program, so we were not getting
crash traces.

DumpRenderTree/win/DumpRenderTree.cpp:

(main): Don't register an exception filter.
(exceptionFilter): Deleted.

Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs): Add another regular expression to handle a second crash trace
syntax I encountered during testing.
(CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
try the new one. The PID found by the new expression is in hexadecimal, so
convert it to an integer before returning it.

Scripts/webkitpy/port/driver.py:

(Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
check for "#CRASHED" after stripping off the EOL characters.

Scripts/webkitpy/port/win.py:

(WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
invocation. This is apparently used to signal an event when the debugger is finished.

5:14 PM Changeset in webkit [191017] by Simon Fraser

15 edits
1 add in trunk/Source

Add helper funtion for checking pointer equivalency and use it
https://bugs.webkit.org/show_bug.cgi?id=150022

Reviewed by Darin Adler.
Source/WebCore:

A common pattern in WebCore code is to check for equivalency of two pointers,
either both null, or both non-null and with equal values. This was written in
several different ways in different places.

Add arePointingToEqualData() to standardize this pattern.

This obviates the need for StyleImage::imagesEquivalent(), counterDataEquivalent()
etc.

Also change some comparisons of DataRef<> which checked the pointer and then the
values to use DataRef<>::operator== which does the same thing. Comparisons of
m_grid and m_gridItem only checked pointer equality, so this is probably a bug fix there.

page/animation/CSSPropertyAnimation.cpp: if ((!a && !b)

a == b) is redundant so fix,

and add checks for a and b RenderStyle* first.
(WebCore::PropertyWrapperGetter::equals):
(WebCore::StyleImagePropertyWrapper::equals):
(WebCore::PropertyWrapperShadow::equals):
(WebCore::PropertyWrapperMaybeInvalidColor::equals):
(WebCore::FillLayerPropertyWrapperGetter::equals):
(WebCore::FillLayerStyleImagePropertyWrapper::equals):
(WebCore::FillLayersPropertyWrapper::equals):
(WebCore::ShorthandPropertyWrapper::equals):
(WebCore::PropertyWrapperFlex::equals):
(WebCore::PropertyWrapperSVGPaint::equals):

platform/network/ResourceRequestBase.cpp:

(WebCore::equalIgnoringHeaderFields):

rendering/style/FillLayer.cpp:

(WebCore::FillLayer::operator==):

rendering/style/NinePieceImage.cpp:

(WebCore::NinePieceImageData::operator==):

rendering/style/RenderStyle.cpp: Some nullptr cleanup.

(WebCore::RenderStyle::getCachedPseudoStyle):
(WebCore::RenderStyle::addCachedPseudoStyle):
(WebCore::RenderStyle::changeAffectsVisualOverflow):
(WebCore::RenderStyle::changeRequiresLayout):
(WebCore::RenderStyle::changeRequiresLayerRepaint):
(WebCore::RenderStyle::setWillChange):

rendering/style/SVGRenderStyleDefs.cpp:

(WebCore::StyleShadowSVGData::operator==):

rendering/style/ShadowData.cpp:

(WebCore::ShadowData::operator==):

rendering/style/StyleImage.h:

(WebCore::StyleImage::imagesEquivalent): Deleted.

rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::operator==):
(WebCore::cursorDataEquivalent): Deleted.
(WebCore::quotesDataEquivalent): Deleted.
(WebCore::StyleRareInheritedData::shadowDataEquivalent): Deleted.

rendering/style/StyleRareInheritedData.h:
rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::counterDataEquivalent): Deleted.
(WebCore::StyleRareNonInheritedData::shadowDataEquivalent): Deleted.
(WebCore::StyleRareNonInheritedData::willChangeDataEquivalent): Deleted.
(WebCore::StyleRareNonInheritedData::reflectionDataEquivalent): Deleted.
(WebCore::StyleRareNonInheritedData::animationDataEquivalent): Deleted.
(WebCore::StyleRareNonInheritedData::transitionDataEquivalent): Deleted.

rendering/style/StyleRareNonInheritedData.h:

Source/WTF:

Add PointerComparison.h which contains the templated pointer comparison
function.

WTF.xcodeproj/project.pbxproj:
wtf/PointerComparison.h: Added.

(WTF::arePointingToEqualData):

5:12 PM Changeset in webkit [191016] by sbarati@apple.com

3 edits in trunk/Source/JavaScriptCore

We were creating a GCAwareJITStubRoutineWithExceptionHandler when we didn't actually have an exception handler in the CodeBlock's exception handler table
https://bugs.webkit.org/show_bug.cgi?id=150016

Reviewed by Geoffrey Garen.

There was a bug where we created a GCAwareJITStubRoutineWithExceptionHandler
for inline caches that were custom setters/getters (but not JS getters/setters).
This is wrong; we only create GCAwareJITStubRoutineWithExceptionHandler when we have
an inline cache with a JS getter/setter call which causes the inline cache to add itself
to the CodeBlock's exception handling table. The problem was that we created
a GCAwareJITStubRoutineWithExceptionHandler that tried to remove itself from
the exception handler table only to find out that it didn't have an entry in the table.

bytecode/PolymorphicAccess.cpp:

(JSC::PolymorphicAccess::regenerate):

5:10 PM Changeset in webkit [191015] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

Simplify WeakBlock visit and reap phases
https://bugs.webkit.org/show_bug.cgi?id=150045

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-13
Reviewed by Geoffrey Garen.

WeakBlock visiting and reaping both happen after MarkedBlock marking.
All the MarkedBlocks we encounter should be either Marked or Retired.

heap/MarkedBlock.h:

(JSC::MarkedBlock::isMarkedOrRetired):

heap/WeakBlock.cpp:

(JSC::WeakBlock::visit):
(JSC::WeakBlock::reap):

heap/WeakBlock.h:

4:40 PM Changeset in webkit [191014] by mmaxfield@apple.com

26 edits
1 delete in trunk/Source

Split TypesettingFeatures into kerning and ligatures bools
https://bugs.webkit.org/show_bug.cgi?id=150074

Reviewed by Simon Fraser.

Source/WebCore:

Our TypesettingFeatures type represents whether kerning or ligatures are enabled
when laying out text. However, now that I have implemented font-feature-settings
and font-variant-*, this type is wildly inadequate. There are now multiple kinds
of ligatures, and many other features which are neither kerning nor ligatures.
Adding tons of information to this type doesn't make sense because 1) We already
have a FontVariantSettings struct which contains this information, and 2) None
of the users of TypesettingFeatures care about most of these new features.

In this new world of font features, the font-kerning property isn't changing.
Therefore, all the code which relies only on the Kerning value in
TypesettingFeatures doesn't need to change. The places which rely on Ligatures,
however, need to be updated to understand that there are many different kinds
of ligatures.

Indeed, after inspection, all of the places which inspect ligatures are more
interested in a high-level concept of whether or not we can trust some simple
computation. Therefore, we really have two things we care about: Kerning, and
this high-level concept.

This patch is the second step to update our view of the world to include
font-feature-settings and font-variant-*. In particular, this patch simply
splits TypesettingFeatures into two Booleans, one for Kerning, and one for
Ligatures (which has no behavior change). Then, once they are separated, I can
migrate the Ligatures Boolean to take on its new meaning.

This change is purely mechanical.

No new tests because there is no behavior change.

WebCore.xcodeproj/project.pbxproj:
css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator FontCascadeDescription::Kerning):

platform/graphics/Font.cpp:

(WebCore::Font::applyTransforms):

platform/graphics/Font.h:
platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::FontCascade):
(WebCore::FontCascade::operator=):
(WebCore::FontCascade::update):
(WebCore::FontCascade::drawText):
(WebCore::FontCascade::drawEmphasisMarks):
(WebCore::FontCascade::width):
(WebCore::FontCascade::adjustSelectionRectForText):
(WebCore::FontCascade::offsetForPosition):
(WebCore::FontCascade::setDefaultKerning):
(WebCore::FontCascade::setDefaultLigatures):
(WebCore::FontCascade::codePath):
(WebCore::FontCascade::floatWidthForSimpleText):
(WebCore::FontCascade::setDefaultTypesettingFeatures): Deleted.
(WebCore::FontCascade::defaultTypesettingFeatures): Deleted.

platform/graphics/FontCascade.h:

(WebCore::FontCascade::enableKerning):
(WebCore::FontCascade::enableLigatures):
(WebCore::FontCascade::computeEnableKerning):
(WebCore::FontCascade::computeEnableLigatures):
(WebCore::FontCascade::typesettingFeatures): Deleted.
(WebCore::FontCascade::computeTypesettingFeatures): Deleted.

platform/graphics/FontDescription.cpp:

(WebCore::FontCascadeDescription::FontCascadeDescription):

platform/graphics/FontDescription.h:

(WebCore::FontCascadeDescription::setKerning):
(WebCore::FontCascadeDescription::initialKerning):

platform/graphics/TypesettingFeatures.h: Removed.
platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::applyFontTransforms):
(WebCore::WidthIterator::advanceInternal):

platform/graphics/WidthIterator.h:
platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::canRenderCombiningCharacterSequence):

platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::Font::getCFStringAttributes):

rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

rendering/line/BreakingContext.h:

(WebCore::WordTrailingSpace::width):

svg/SVGFontData.h:

Source/WebKit/mac:

WebView/WebView.mm:

(+[WebView initialize]):

Source/WebKit2:

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

Shared/WebProcessCreationParameters.h:
UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

4:28 PM Changeset in webkit [191013] by dino@apple.com

4 edits in trunk/Source/WebKit2

Fix iOS-family builds.

UIProcess/API/C/mac/WKPagePrivateMac.mm:

(WKPageGetObjectRegistry):

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController _remoteObjectRegistry]):

UIProcess/API/mac/WKViewInternal.h:

4:01 PM Changeset in webkit [191012] by Brent Fulgham

3 edits in trunk/LayoutTests

[Win] Unreviewed test gardening after r190995.

Update to correct test output, based on similar changes to Mac expectations.

platform/win/fast/html/details-add-child-2-expected.txt:
platform/win/fast/html/details-open2-expected.txt:

3:53 PM Changeset in webkit [191011] by Alan Bujtas

9 edits
34 adds in trunk

Anonymous table objects: inline parent box requires inline-table child.
https://bugs.webkit.org/show_bug.cgi?id=150090

Reviewed by David Hyatt.

According to the CSS2.1 specification, if a child needs anonymous table wrapper
and the child's parent is an inline box, the generated table needs to be inline-table.
(inline-block and block parents generate non-inline table)

Import W3C CSS2.1 anonymous table tests.

Source/WebCore:

rendering/RenderElement.cpp:

(WebCore::RenderElement::childRequiresTable):
(WebCore::RenderElement::addChild):

rendering/RenderElement.h:
rendering/RenderInline.cpp:

(WebCore::RenderInline::newChildIsInline):
(WebCore::RenderInline::addChildIgnoringContinuation):
(WebCore::RenderInline::addChildToContinuation):

rendering/RenderInline.h:
rendering/RenderTable.cpp:

(WebCore::RenderTable::createAnonymousWithParentRenderer):

LayoutTests:

css2.1/tables/table-anonymous-objects-177.xht: Added.
css2.1/tables/table-anonymous-objects-178.xht: Added.
css2.1/tables/table-anonymous-objects-179.xht: Added.
css2.1/tables/table-anonymous-objects-180.xht: Added.
css2.1/tables/table-anonymous-objects-181.xht: Added.
css2.1/tables/table-anonymous-objects-189.xht: Added.
css2.1/tables/table-anonymous-objects-190.xht: Added.
css2.1/tables/table-anonymous-objects-191.xht: Added.
css2.1/tables/table-anonymous-objects-192.xht: Added.
css2.1/tables/table-anonymous-objects-193.xht: Added.
css2.1/tables/table-anonymous-objects-194.xht: Added.
css2.1/tables/table-anonymous-objects-195.xht: Added.
css2.1/tables/table-anonymous-objects-196.xht: Added.
css2.1/tables/table-anonymous-objects-205.xht: Added.
css2.1/tables/table-anonymous-objects-206.xht: Added.
css2.1/tables/table-anonymous-objects-207.xht: Added.
css2.1/tables/table-anonymous-objects-208.xht: Added.
platform/mac/css2.1/tables/table-anonymous-objects-177-expected.txt: Added.
platform/mac/css2.1/tables/table-anonymous-objects-178-expected.txt: Added.
platform/mac/css2.1/tables/table-anonymous-objects-179-expected.txt: Added.
platform/mac/css2.1/tables/table-anonymous-objects-180-expected.txt: Added.
platform/mac/css2.1/tables/table-anonymous-objects-181-expected.txt: Added.
platform/mac/css2.1/tables/table-anonymous-objects-189-expected.txt: Added.
platform/mac/css2.1/tables/table-anonymous-objects-190-expected.txt: Added.
platform/mac/css2.1/tables/table-anonymous-objects-191-expected.txt: Added.
platform/mac/css2.1/tables/table-anonymous-objects-192-expected.txt: Added.
platform/mac/css2.1/tables/table-anonymous-objects-193-expected.txt: Added.
platform/mac/css2.1/tables/table-anonymous-objects-194-expected.txt: Added.
platform/mac/css2.1/tables/table-anonymous-objects-195-expected.txt: Added.
platform/mac/css2.1/tables/table-anonymous-objects-196-expected.txt: Added.
platform/mac/css2.1/tables/table-anonymous-objects-205-expected.txt: Added.
platform/mac/css2.1/tables/table-anonymous-objects-206-expected.txt: Added.
platform/mac/css2.1/tables/table-anonymous-objects-207-expected.txt: Added.
platform/mac/css2.1/tables/table-anonymous-objects-208-expected.txt: Added.

3:17 PM Changeset in webkit [191010] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Fix 32-bit build.

UIProcess/API/C/mac/WKPagePrivateMac.mm:

(WKPageGetObjectRegistry):

2:56 PM Changeset in webkit [191009] by andersca@apple.com

6 edits in trunk/Source/WebKit2

Add and implement WKPageGetObjectRegistry
https://bugs.webkit.org/show_bug.cgi?id=150102

Reviewed by Tim Horton.

Put the _WKObjectRegistry used by WKPageRef and WKBrowsingContextController on the WKView for now.
If we decide to share more code between WKView and WKWebView, the object registry could live in an object that would be shared
between WKView and WKWebView.

UIProcess/API/C/mac/WKPagePrivateMac.h:
UIProcess/API/C/mac/WKPagePrivateMac.mm:

(WKPageGetObjectRegistry):

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController _remoteObjectRegistry]):
(-[WKBrowsingContextController dealloc]): Deleted.

UIProcess/API/mac/WKView.mm:

(-[WKView dealloc]):
(-[WKView _remoteObjectRegistry]):

UIProcess/API/mac/WKViewInternal.h:

2:46 PM Changeset in webkit [191008] by dino@apple.com

4 edits
2 adds in trunk

Device motion and orientation should only be visible from the main frame's security origin
https://bugs.webkit.org/show_bug.cgi?id=150072
<rdar://problem/23082036>

Reviewed by Brent Fulgham.

Add a manual test for cross-origin device orientation events, while
we're waiting on the mock client to be supported everywhere.

ManualTests/deviceorientation-child-frame.html: Added.
ManualTests/deviceorientation-main-frame-only.html: Added.

Source/WebCore:

There are reports that gyroscope and accelerometer information can
be used to detect keyboard entry. One initial step to reduce the
risk is to forbid device motion and orientation events from
being fired in frames that are a different security origin from the main page.

Manual test: deviceorientation-main-frame-only.html

page/DOMWindow.cpp:

(WebCore::DOMWindow::isSameSecurityOriginAsMainFrame): New helper function.
(WebCore::DOMWindow::addEventListener): Check if we are the main frame, or the
same security origin as the main frame. If not, don't add the event
listeners.

2:45 PM Changeset in webkit [191007] by dino@apple.com

3 edits in trunk/Source/WebCore

ASSERT(m_motionManager) on emgn.com page
https://bugs.webkit.org/show_bug.cgi?id=150070
<rdar://problem/18383732>

Reviewed by Simon Fraser.

In the WebCoreMotionManager init method, we call
into another setup method on the main thread.
However, if a listener was attached before that
ran, we'd ASSERT. This wasn't actually causing a bug
because the main thread initialization would
check the listeners once it got a chance to run.

The fix is to only check status when we've
actually initialized.

platform/ios/WebCoreMotionManager.h: New m_initialized boolean.
platform/ios/WebCoreMotionManager.mm: Check m_initialized before doing real work.

(-[WebCoreMotionManager init]):
(-[WebCoreMotionManager addMotionClient:]):
(-[WebCoreMotionManager removeMotionClient:]):
(-[WebCoreMotionManager addOrientationClient:]):
(-[WebCoreMotionManager removeOrientationClient:]):
(-[WebCoreMotionManager initializeOnMainThread]):

2:28 PM Changeset in webkit [191006] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

A lot of the http/tests/cache/disk-cache/ tests are flaky on mac-wk2, marking them as such.
https://bugs.webkit.org/show_bug.cgi?id=149087

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-13
Reviewed by Alexey Proskuryakov.

platform/mac-wk2/TestExpectations:

1:30 PM Changeset in webkit [191005] by ap@apple.com

4 edits in trunk/Tools

Mac Debug and 32-bit queues should be separate
https://bugs.webkit.org/show_bug.cgi?id=150092

Reviewed by Lucas Forschler.

QueueStatusServer/config/queues.py:
QueueStatusServer/model/queues.py:

(Queue._capitalize_after_dash):
(Queue._caplitalize_after_dash): Deleted.

Scripts/webkitpy/common/config/ews.json:

1:23 PM Changeset in webkit [191004] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

REGRESSION(r189567): Web Inspector: Clipped filter icons when debugger sidebar is narrow
https://bugs.webkit.org/show_bug.cgi?id=150023

r189567 changed flexbox items' default min-width from 0 to auto.
Explicitly set it to 0 in CSS.

Reviewed by Brian Burg.

UserInterface/Views/FilterBar.css:

(.filter-bar > input[type="search"]):

1:08 PM Changeset in webkit [191003] by ggaren@apple.com

3 edits in trunk/Source/JavaScriptCore

CodeBlock write barriers should be precise
https://bugs.webkit.org/show_bug.cgi?id=150042

Reviewed by Saam Barati.

CodeBlock performs lots of unnecessary write barriers. This wastes
performance and makes the code a bit harder to follow, and it might mask
important bugs. Now is a good time to unmask important bugs.

bytecode/CodeBlock.h:

(JSC::CodeBlockSet::mark): Don't write barrier all CodeBlocks on the
stack. Only CodeBlocks that do value profiling need write barriers, and
they do those themselves.

In steady state, when most of our CodeBlocks are old and FTL-compiled,
and we're doing eden GC's, we should almost never visit a CodeBlock.

dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::osrWriteBarrier):
(JSC::DFG::adjustAndJumpToTarget): Don't write barrier all inlined
CodeBlocks on exit. That's not necessary. Instead, write barrier the
CodeBlock(s) we will exit to, along with the one we will write a value
profile to.

12:15 PM Changeset in webkit [191002] by Chris Dumez

35 edits in trunk/Source

Avoid useless copies in range-loops that are using 'auto'
https://bugs.webkit.org/show_bug.cgi?id=150091

Reviewed by Sam Weinig.

Avoid useless copies in range-loops that are using 'auto'. Also use
'auto*' instead of 'auto' when range values are pointers for clarity.
Source/bmalloc:

bmalloc/Deallocator.cpp:

(bmalloc::Deallocator::processObjectLog):

Source/WebKit/mac:

WebView/WebFrame.mm:

(-[WebFrame getDictationResultRanges:andMetadatas:]):

Source/WebKit2:

UIProcess/VisitedLinkStore.cpp:

(WebKit::VisitedLinkStore::pendingVisitedLinksTimerFired):
(WebKit::VisitedLinkStore::resizeTable):

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::releaseRemainingIconsForPageURLs):

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchData):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::plugins):

12:03 PM Changeset in webkit [191001] by Yusuke Suzuki

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Don't shadow global Object constructor in WebInspector.Object class definition
https://bugs.webkit.org/show_bug.cgi?id=150093

Reviewed by Joseph Pecoraro.

Currently, class expression does not define any variables. So even in class Object { },
we were able to touch the global Object constructor (like Object.keys).
However, that is a bug. After https://bugs.webkit.org/show_bug.cgi?id=150089 fixes that bug,
the global Object is shadowed by the user-defined class Object name.

To solve this issue, we changed the class Object to class WebInspectorObject.
And we expose this class as a WebInspector.Object.

UserInterface/Base/Object.js:

12:03 PM Changeset in webkit [191000] by Simon Fraser

6 edits in trunk/Source/WebCore

Move Image::drawPattern for CG into GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=150077

Reviewed by Myles C. Maxfield.

In order to consolidate code that calls into Core Graphics inside
GraphicsContext, move the body of Image::drawPattern() into
GraphicsContextCG.cpp, and do the same for Cairo.

platform/graphics/GraphicsContext.h:
platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawPattern):

platform/graphics/cairo/ImageCairo.cpp:

(WebCore::Image::drawPattern):

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::drawPatternCallback):
(WebCore::patternReleaseCallback):
(WebCore::GraphicsContext::drawPattern):

platform/graphics/cg/ImageCG.cpp:

(WebCore::Image::drawPattern):
(WebCore::drawPatternCallback): Deleted.
(WebCore::patternReleaseCallback): Deleted.

11:49 AM Changeset in webkit [190999] by mmaxfield@apple.com

5 edits in trunk

Unprefix font-kerning
https://bugs.webkit.org/show_bug.cgi?id=150080

Reviewed by Sam Weinig.

This is the last property in CSS3 Fonts which is prefixed.

Source/WebCore:

Test: fast/text/font-kerning.html

css/CSSPropertyNames.in:

LayoutTests:

fast/text/font-kerning-expected.html:
fast/text/font-kerning.html:

11:46 AM Changeset in webkit [190998] by commit-queue@webkit.org

16 edits in trunk/Source

Add debug settings for using giant tiles (4096x4096)
https://bugs.webkit.org/show_bug.cgi?id=149977
<rdar://problem/23017093>

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-10-13
Reviewed by Tim Horton.

Source/WebCore:

Instead of creating the GraphicsLayer with a fixed size 512x512, we need
to read the useGiantTiles setting. If its value is true, we set the layer
tileSize to 4096x4096.

page/Settings.in:

Define the name of the setting and its default value.

platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::tileSize):
Define tileSize() in the base class GraphicsLayerClient. This is going to
be overridden RenderLayerBacking.

platform/graphics/TiledBacking.h:

(WebCore::defaultTileSize):
Define the default tileSize which will depend on the useGiantTiles
setting.

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::platformCALayerTileSize):
Implement the virtual function GraphicsLayerCA::platformCALayerTileSize().
It passes the call to client GraphicsLayerClient which can be RenderLayerBacking
in our case.

platform/graphics/ca/GraphicsLayerCA.h:

Override base class function PlatformCALayerClient::PlatformCALayerClient().

platform/graphics/ca/PlatformCALayerClient.h:

(WebCore::PlatformCALayerClient::platformCALayerTileSize):
Define platformCALayerTileSize() in the base class PlatformCALayerClient.
This is going to be overridden GraphicsLayerCA.

platform/graphics/ca/TileController.cpp:

(WebCore::TileController::TileController):
No need for the member m_tileSize.

(WebCore::TileController::computeTileCoverageRect):
Use the function tileSize() instead of using the static values.

(WebCore::TileController::tileSize):
The tileSize will be retrieved from the owning graphics layer.

platform/graphics/ca/TileController.h:

No need for the member m_tileSize. The tileSize will be retrieved from the owning graphics layer.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::setTiledBackingHasMargins):
Use the function tileSize() instead of using the static values.

(WebCore::RenderLayerBacking::tileSize):
Override base class function GraphicsLayerClient::tileSize().

rendering/RenderLayerBacking.h:

Define the concrete method RenderLayerBacking::tilSize().

Source/WebKit2:

Shared/WebPreferencesDefinitions.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetUseGiantTiles):
(WKPreferencesGetUseGiantTiles):

UIProcess/API/C/WKPreferencesRefPrivate.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

11:35 AM Changeset in webkit [190997] by bshafiei@apple.com

5 edits in branches/safari-601-branch/Source

Versioning.

11:34 AM Changeset in webkit [190996] by bshafiei@apple.com

5 edits in branches/safari-601.1.46-branch/Source

Versioning.

11:34 AM Changeset in webkit [190995] by Antti Koivisto

3 edits in trunk/Source/WebCore

Try to fix ENABLE(DETAILS_ELEMENT) with SHADOW_DOM disabled.

dom/Element.cpp:

(WebCore::Element::attributeChanged):

dom/Node.cpp:

(WebCore::traverseStyleParent):

11:05 AM Changeset in webkit [190994] by ap@apple.com

3 edits
1 delete in trunk/LayoutTests

http/tests/multipart/multipart-replace-non-html-content.php shouldn't exercise
edge cases of multipart parsing
https://bugs.webkit.org/show_bug.cgi?id=149978
rdar://problem/22981062

Reviewed by Anders Carlsson.

This test is not about HTTP edge cases, but about handling of multipart content in WebKit.

http/tests/multipart/multipart-replace-non-html-content.php:
platform/mac/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Removed.
platform/win/TestExpectations:

10:44 AM Changeset in webkit [190993] by youenn.fablet@crf.canon.fr

5 edits in trunk/Source/WebCore

Fix license and copyrights of WebCore js binding builtin files
https://bugs.webkit.org/show_bug.cgi?id=150027

Reviewed by Darin Adler.

Fixing copyright on all three files.
Moving to BSD-like license as they should have been in the first place.
Ordering lexicographically the builtin names in WebCoreBuiltinNames.h.

No change in behaviour.

bindings/js/WebCoreBuiltinNames.h:
bindings/js/WebCoreJSBuiltins.cpp:
bindings/js/WebCoreJSBuiltins.h:
bindings/js/WebCoreJSBuiltinInternals.h:

9:54 AM Changeset in webkit [190992] by Brent Fulgham

2 edits in trunk/Source/WebKit2

[iOS] Avoid crash due to invalid screen bounds
https://bugs.webkit.org/show_bug.cgi?id=150048
<rdar://problem/22112664>

Reviewed by Jer Noble.

Check for an invalid bounds, and reset it to a known state before
attempting to use it.

WebProcess/ios/WebVideoFullscreenManager.mm:

(WebKit::WebVideoFullscreenManager::setVideoLayerFrameFenced):

9:03 AM Changeset in webkit [190991] by Yusuke Suzuki

2 edits in trunk/Source/JavaScriptCore

REGRESSION: ASSERT (impl->isAtomic()) @ facebook.com
https://bugs.webkit.org/show_bug.cgi?id=149965

Reviewed by Geoffrey Garen.

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

8:42 AM Changeset in webkit [190990] by Alan Bujtas

1 edit
47 adds in trunk/LayoutTests

[iOS] Update anonymous table results for iOS port.

Unreviewed gardening.

platform/ios-simulator/css2.1/tables/table-anonymous-objects-015-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-016-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-023-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-024-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-035-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-036-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-037-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-038-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-045-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-046-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-047-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-048-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-049-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-050-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-055-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-056-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-091-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-092-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-099-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-100-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-105-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-106-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-107-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-108-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-109-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-110-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-111-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-112-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-113-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-114-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-115-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-116-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-121-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-122-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-123-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-124-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-139-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-140-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-149-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-150-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-155-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-156-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-159-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-160-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-165-expected.txt: Added.
platform/ios-simulator/css2.1/tables/table-anonymous-objects-166-expected.txt: Added.

8:10 AM Changeset in webkit [190989] by Carlos Garcia Campos

9 edits in releases/WebKitGTK/webkit-2.10

Merge r190987 - [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
https://bugs.webkit.org/show_bug.cgi?id=150085

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Shared/gtk/NativeWebTouchEventGtk.cpp:
Shared/gtk/WebEventFactory.cpp:
Shared/gtk/WebEventFactory.h:
UIProcess/API/gtk/PageClientImpl.cpp:
UIProcess/API/gtk/PageClientImpl.h:
UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkit_web_view_base_class_init):

Tools:

WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

8:09 AM Changeset in webkit [190988] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2

Merge r190930 - Avoid useless copying of Key::HashType in loops in NetworkCache::Storage::synchronize()
https://bugs.webkit.org/show_bug.cgi?id=150061

Reviewed by Carlos Garcia Campos.

Avoid useless copying of Key::HashType in loops in NetworkCache::Storage::synchronize().
Key::HashType is currently a SHA1::Digest, which is a std::array<uint8_t, 20>.

NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::synchronize):

7:42 AM Changeset in webkit [190987] by svillar@igalia.com

9 edits in trunk

[GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
https://bugs.webkit.org/show_bug.cgi?id=150085

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Shared/gtk/NativeWebTouchEventGtk.cpp:
Shared/gtk/WebEventFactory.cpp:
Shared/gtk/WebEventFactory.h:
UIProcess/API/gtk/PageClientImpl.cpp:
UIProcess/API/gtk/PageClientImpl.h:
UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkit_web_view_base_class_init):

Tools:

WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

6:48 AM Changeset in webkit [190986] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2

Merge r189912 - [GTK] Crash in WebKit::BackingStore::createBackend running under Wayland
https://bugs.webkit.org/show_bug.cgi?id=147453

Reviewed by Carlos Garcia Campos.

Except when running on X11, this function always crashes if called before the web view is
realized, as gdk_window_create_similar_surface will return null in that case. Avoid this by
simply realizing the widget before calling that.

Thanks to Carlos Garnacho for some debugging help.

UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::createBackend):

6:48 AM WebKitGTK/2.10.x edited by Carlos Garcia Campos

(diff)

6:47 AM Changeset in webkit [190985] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.10

Merge r190909 - [GTK] OSX linker doesn't understand --whole-archive
https://bugs.webkit.org/show_bug.cgi?id=144557

Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-10-12
Reviewed by Martin Robinson.

Source/cmake/OptionsGTK.cmake: Turn the macro

ADD_WHOLE_ARCHIVE_TO_LIBRARIES into a no-op on Darwin systems,
because XCode's linker doesn't have the --whole-archive option.

Source/WebKit2:

PlatformGTK.cmake: Link with extra libraries on Darwin, since

we don't have the --whole-archive linker option.

6:43 AM WebKitGTK/2.10.x edited by Carlos Garcia Campos

(diff)

6:29 AM Changeset in webkit [190984] by Carlos Garcia Campos

12 edits
4 adds in releases/WebKitGTK/webkit-2.10

Merge r190879 - Clip-path transitions sometimes trigger endless animation timers
https://bugs.webkit.org/show_bug.cgi?id=150018

Reviewed by Tim Horton.

Source/WebCore:

Transitioning -webkit-clip-path could trigger endless animation
timers, because when CompositeAnimation::updateTransitions() calls
isTargetPropertyEqual(), a false negative answer triggers canceling the
current transition and starting a new one over and over.

This happened because StyleRareNonInheritedData simply tested pointer
equality for m_clipPath and m_shapeOutside. Both of these need to do deep
equality testing, requiring the implementation of operator== in BasicShapes
classes.

In addition, the PropertyWrappers in CSSPropertyAnimation need equals()
implementations that also do more than pointer equality testing.

Tests: transitions/clip-path-transitions.html

transitions/shape-outside-transitions.html

page/animation/CSSPropertyAnimation.cpp:

(WebCore::PropertyWrapperClipPath::equals):
(WebCore::PropertyWrapperShape::equals):

rendering/ClipPathOperation.h:
rendering/style/BasicShapes.cpp:

(WebCore::BasicShapeCircle::operator==):
(WebCore::BasicShapeEllipse::operator==):
(WebCore::BasicShapePolygon::operator==):
(WebCore::BasicShapeInset::operator==):

rendering/style/BasicShapes.h:

(WebCore::BasicShapeCenterCoordinate::operator==):
(WebCore::BasicShapeRadius::operator==):

rendering/style/ShapeValue.cpp:

(WebCore::pointersOrValuesEqual):
(WebCore::ShapeValue::operator==):

rendering/style/ShapeValue.h:

(WebCore::ShapeValue::operator!=):
(WebCore::ShapeValue::operator==): Deleted.
(WebCore::ShapeValue::ShapeValue): Deleted.

rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::clipPathOperationsEquivalent):
(WebCore::StyleRareNonInheritedData::shapeOutsideDataEquivalent):

rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

New tests for transitions of clip-path and shape-outside.

transitions/clip-path-transitions-expected.txt: Added.
transitions/clip-path-transitions.html: Added.
transitions/resources/transition-test-helpers.js:

(parseClipPath):
(checkExpectedValue):

transitions/shape-outside-transitions-expected.txt: Added.
transitions/shape-outside-transitions.html: Added.
transitions/svg-transitions-expected.txt:

6:12 AM Changeset in webkit [190983] by Antti Koivisto

18 edits
2 adds in trunk

Implement iterator for traversing composed DOM
https://bugs.webkit.org/show_bug.cgi?id=149997

Reviewed by Ryosuke Niwa.

Source/WebCore:

ComposedTreeIterator traverses the DOM in composed tree order. This means it enters
shadow trees and follows slots created by Shadow DOM API correctly.

auto children = composedTreeChildren(containerNode);
for (auto& composedChild : children)

...

auto descendants = composedTreeDescendants(containerNode);
for (auto& composedDescendant : descendants)

...

WebCore.xcodeproj/project.pbxproj:
dom/ComposedTreeIterator.cpp: Added.

(WebCore::ComposedTreeIterator::initializeShadowStack):
(WebCore::ComposedTreeIterator::traverseNextInShadowTree):
(WebCore::ComposedTreeIterator::traverseNextSiblingSlot):
(WebCore::ComposedTreeIterator::traversePreviousSiblingSlot):
(WebCore::ComposedTreeIterator::traverseParentInShadowTree):

dom/ComposedTreeIterator.h: Added.

(WebCore::ComposedTreeIterator::operator*):
(WebCore::ComposedTreeIterator::operator->):
(WebCore::ComposedTreeIterator::operator==):
(WebCore::ComposedTreeIterator::operator!=):
(WebCore::ComposedTreeIterator::ShadowContext::ShadowContext):
(WebCore::ComposedTreeIterator::ComposedTreeIterator):
(WebCore::ComposedTreeIterator::traverseNext):
(WebCore::ComposedTreeIterator::traverseNextSibling):
(WebCore::ComposedTreeIterator::traversePreviousSibling):
(WebCore::ComposedTreeIterator::traverseParent):
(WebCore::ComposedTreeChildAdapter::Iterator::Iterator):
(WebCore::ComposedTreeChildAdapter::Iterator::operator++):
(WebCore::ComposedTreeChildAdapter::Iterator::operator--):
(WebCore::ComposedTreeChildAdapter::ComposedTreeChildAdapter):
(WebCore::ComposedTreeChildAdapter::begin):
(WebCore::ComposedTreeChildAdapter::end):
(WebCore::ComposedTreeChildAdapter::at):
(WebCore::composedTreeChildren):

dom/NodeRenderingTraversal.cpp:

(WebCore::NodeRenderingTraversal::parentSlow):
(WebCore::NodeRenderingTraversal::nextInScope):
(WebCore::NodeRenderingTraversal::firstChildSlow): Deleted.
(WebCore::NodeRenderingTraversal::nextSiblingSlow): Deleted.
(WebCore::NodeRenderingTraversal::previousSiblingSlow): Deleted.

dom/NodeRenderingTraversal.h:

(WebCore::NodeRenderingTraversal::parent):
(WebCore::NodeRenderingTraversal::firstChild): Deleted.
(WebCore::NodeRenderingTraversal::nextSibling): Deleted.
(WebCore::NodeRenderingTraversal::previousSibling): Deleted.

style/RenderTreePosition.cpp:

(WebCore::RenderTreePosition::computeNextSibling):

Restore the full assert.

(WebCore::RenderTreePosition::invalidateNextSibling):
(WebCore::RenderTreePosition::previousSiblingRenderer):
(WebCore::RenderTreePosition::nextSiblingRenderer):

Make these member functions.
Use the iterator. This is fixes some bugs and allows enabling a test case.

style/RenderTreePosition.h:
style/StyleResolveTree.cpp:

(WebCore::Style::textRendererIsNeeded):

LayoutTests:

TestExpectations:

Re-enable fast/html/details-replace-text.html which is fixed by this change.

fast/forms/select-listbox-focus-displaynone-expected.txt:
fast/repaint/text-in-relative-positioned-inline-expected.txt:
fullscreen/full-screen-fixed-pos-parent-expected.txt:
platform/mac-mavericks/fast/html/details-open2-expected.txt:
platform/mac/fast/html/details-add-child-2-expected.txt:
platform/mac/fast/html/details-open2-expected.txt:

Non-visual whitespace changes.

6:05 AM Changeset in webkit [190982] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore

Merge r190862 - webkit-gtk 2.3.3 fails to build on OS X - Conflicting type "Fixed"
https://bugs.webkit.org/show_bug.cgi?id=126433

Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-10-12
Reviewed by Philippe Normand

Don't include CoreFoundation.h when building the GTK port.

Source/JavaScriptCore/API/WebKitAvailability.h: Add !defined(BUILDING_GTK) to defined(APPLE).

6:03 AM Changeset in webkit [190981] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore

Merge r190857 - webkit-gtk-2.3.4 fails to link JavaScriptCore, missing symbols add_history and readline
https://bugs.webkit.org/show_bug.cgi?id=127059

Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-10-12
Reviewed by Philippe Normand.

shell/CMakeLists.txt: Link JSC with -ledit on Mac OSX.

6:01 AM Changeset in webkit [190980] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.10

Merge r190856 - [GTK] Use --version-script only on Linux
https://bugs.webkit.org/show_bug.cgi?id=144555

Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-10-12
Reviewed by Philippe Normand.

Source/cmake/OptionsGTK.cmake: Don't add --version-script

option on Darwin (whose linker doesn't support it.)

5:46 AM WebKitGTK/2.10.x edited by clopez@igalia.com

(diff)

5:44 AM WebKitGTK/2.8.x edited by clopez@igalia.com

(diff)

5:43 AM Changeset in webkit [190979] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore

Merge r190843 - Reduce pointless malloc traffic in CodeBlock construction.
<https://webkit.org/b/149999>

Reviewed by Antti Koivisto.

Create the RefCountedArray<Instruction> for CodeBlock's m_instructions directly
instead of first creating a Vector<Instruction> and then creating a RefCountedArray
from that. None of the Vector functionality is needed here anyway.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::insertBasicBlockBoundariesForControlFlowProfiler):

bytecode/CodeBlock.h:

5:05 AM Changeset in webkit [190978] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190842 - Reduce pointless malloc traffic in ElementRuleCollector.
<https://webkit.org/b/150003>

Reviewed by Antti Koivisto.

Don't use a unique_ptr for the m_matchedRules vector in ElementRuleCollector.
This is one of our heaviest sources of transient allocations, with ~88000
malloc/free pairs on loading theverge.com.

css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::addMatchedRule):
(WebCore::ElementRuleCollector::clearMatchedRules):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
(WebCore::ElementRuleCollector::sortMatchedRules):
(WebCore::ElementRuleCollector::hasAnyMatchingRules):

css/ElementRuleCollector.h:

(WebCore::ElementRuleCollector::hasMatchedRules):

5:03 AM Changeset in webkit [190977] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190835 - Check if start and end positions are still valid after updating them through VisibleSelection.
https://bugs.webkit.org/show_bug.cgi?id=149982

Reviewed by Ryosuke Niwa.

This patch is required to be able to clean up anonymous tables structure.
In certain edge cases, start/end positions could become nullptr after various text splitting
operations.

Covered by editing/execCommand/crash-137961.html

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::applyInlineStyle):

5:01 AM Changeset in webkit [190976] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.10

Merge r190820 - Garbage texture data with composited table row
https://bugs.webkit.org/show_bug.cgi?id=148984

Reviewed by Zalan Bujtas.
Source/WebCore:

Don't pretend to know if the layer for a table header, section or cell is
opaque, since table painting is special.

Test: compositing/contents-opaque/table-parts.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

compositing/contents-opaque/table-parts-expected.txt: Added.
compositing/contents-opaque/table-parts.html: Added.

5:00 AM Changeset in webkit [190975] by Carlos Garcia Campos

7 edits
2 adds in releases/WebKitGTK/webkit-2.10

Merge r190818 - Garbage pixels on enphaseenergy.com site
https://bugs.webkit.org/show_bug.cgi?id=149915
rdar://problem/22976184

Reviewed by Darin Adler.

Source/WebCore:

When the <html> gets a composited RenderLayer, and we ask whether its background
is opaque, return false, since the document element's background propagates
to the root, and is painted by the RenderView.

Also improve the compositing logging to indicate when fore- and background layers
are present.

Test: compositing/contents-opaque/negative-z-before-html.html

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):

LayoutTests:

New ref test. Also update the expected result for another test that uses negative
z-index children.

compositing/contents-opaque/body-background-painted-expected.txt:
compositing/contents-opaque/negative-z-before-html-expected.html: Added.
compositing/contents-opaque/negative-z-before-html.html: Added.
platform/mac-wk2/compositing/contents-opaque/body-background-painted-expected.txt:

4:56 AM Changeset in webkit [190974] by Carlos Garcia Campos

5 edits
3 adds in releases/WebKitGTK/webkit-2.10

Merge r190760 - Gracefully handle XMLDocumentParser being detached by mutation events.
https://bugs.webkit.org/show_bug.cgi?id=149485
<rdar://problem/22811489>

Source/WebCore:

This is a merge of Blink change 200026,
https://codereview.chromium.org/1267283002

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-08
Reviewed by Darin Adler.

Test: fast/parser/xhtml-dom-character-data-modified-crash.html

xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::createLeafTextNode):
Renamed from enterText() to make it more descriptive.

(WebCore::XMLDocumentParser::updateLeafTextNode):
Renamed from exitText to firm up this stage.

(WebCore::XMLDocumentParser::end):
Gracefully handle stopped states.

(WebCore::XMLDocumentParser::enterText): Deleted.
(WebCore::XMLDocumentParser::exitText): Deleted.

xml/parser/XMLDocumentParser.h:

Rename enterText to createLeafTextNode.
Rename exitText to updateLeafTextNode.

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::XMLDocumentParser::characters):
(WebCore::XMLDocumentParser::processingInstruction):
(WebCore::XMLDocumentParser::cdataBlock):
(WebCore::XMLDocumentParser::comment):
(WebCore::XMLDocumentParser::endDocument):
Rename function calls and firm up updateLeafTextNode stage accordingly.

LayoutTests:

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-08
Reviewed by Darin Adler.

fast/parser/resources/xhtml-overwrite-frame.xhtml: Added.
fast/parser/xhtml-dom-character-data-modified-crash-expected.txt: Added.
fast/parser/xhtml-dom-character-data-modified-crash.html: Added.

4:50 AM Changeset in webkit [190973] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190755 - data: URLs should not be preloaded
https://bugs.webkit.org/show_bug.cgi?id=149829

Reviewed by Darin Adler.

Fix review comments after r190605:
Use protocolIs() instead of String::startsWith().

html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):

4:47 AM Changeset in webkit [190972] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.10

Merge r190732 - Add NULL check for renderBox::layer() on applying zoom level change
https://bugs.webkit.org/show_bug.cgi?id=149302
<rdar://problem/22747292>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-08
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/zoom-on-nested-scroll-crash.html

This is a merge of Blink r158238:
https://chromiumcodereview.appspot.com/23526081

rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

LayoutTests:

fast/css/zoom-on-nested-scroll-crash-expected.txt: Added.
fast/css/zoom-on-nested-scroll-crash.html: Added.

4:38 AM Changeset in webkit [190971] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.10

Merge r190728 - CrashTracer: [USER] com.apple.WebKit.WebContent at …Core::SelectorChecker::checkScrollbarPseudoClass const + 217
https://bugs.webkit.org/show_bug.cgi?id=149921
rdar://problem/22731359

Reviewed by Andreas Kling.

Source/WebCore:

Test: svg/css/use-window-inactive-crash.html

css/SelectorCheckerTestFunctions.h:

(WebCore::isWindowInactive):

Null check page.

LayoutTests:

The test crashes with shipping WebKit but not with current ToT (probably due to shadow DOM styling changes). Still adding
it for coverage.

svg/css/use-window-inactive-crash-expected.html: Added.
svg/css/use-window-inactive-crash.html: Added.

4:30 AM Changeset in webkit [190970] by ChangSeok Oh

2 edits in trunk/Source/WebCore

[GTK] Use GUniquePtr for GtkIconInfo
https://bugs.webkit.org/show_bug.cgi?id=150082

Reviewed by Carlos Garcia Campos.

GtkIconInfo cab be wrapped by a smart pointer, GUniqueptr.

No new test required since no functionality changed.

rendering/RenderThemeGtk.cpp:

(WebCore::getStockSymbolicIconForWidgetType):

4:24 AM Changeset in webkit [190969] by Carlos Garcia Campos

3 edits
5 adds in releases/WebKitGTK/webkit-2.10

Merge r190662 - [GTK] Progress bar is broken on recent GTK+
https://bugs.webkit.org/show_bug.cgi?id=149831

Reviewed by Carlos Garcia Campos.

Source/WebCore:

The gtk progress bar has been broken after bumping up to Gtk+-3.16. This is because
the way of rendering progress bar changed after gtk+-3.13.7. See more
https://mail.gnome.org/archives/commits-list/2014-August/msg03865.html
gtk_render_activity is no longer valid to paint a progress bar on a newer gtk+.
It should be done with gtk_render_background and gtk_render_frame.

Test: fast/dom/HTMLProgressElement/native-progress-bar.html

rendering/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::paintProgressBar):

LayoutTests:

fast/dom/HTMLProgressElement/native-progress-bar.html: Added.
platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.png: Added.
platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.
platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.png: Added.
platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.

4:21 AM Changeset in webkit [190968] by Carlos Garcia Campos

5 edits
2 adds in releases/WebKitGTK/webkit-2.10

Merge r190658 - Paint artifacts when hovering on http://jsfiddle.net/Sherbrow/T87Mn/
https://bugs.webkit.org/show_bug.cgi?id=149535
rdar://problem/22874920

Reviewed by Simon Fraser.

When due to some style change, a renderer's self-painting layer is getting destroyed
and the parent's overflow is no longer set to visible, we don't clean up the overflow part.

When a renderer has a self-painting layer, the parent stops tracking the child's
visual overflow rect. All overflow painting is delegated to the self-painting layer.
However when this layer gets destroyed, no-one issues repaint to clean up
the overflow bits.
This patch ensures that we issue a repaint when the self-painting layer is destroyed
and the triggering style change requires full repaint.

Source/WebCore:

Test: fast/repaint/overflow-hidden-with-self-painting-child-layer.html

rendering/RenderLayer.h:
rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::styleDidChange):

LayoutTests:

css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt: progression.
fast/repaint/absolute-position-change-containing-block-expected.txt: progression.
fast/repaint/overflow-hidden-with-self-painting-child-layer-expected.txt: Added.
fast/repaint/overflow-hidden-with-self-painting-child-layer.html: Added.

4:04 AM Changeset in webkit [190967] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190641 - Refactor TokenPreloadScanner::StartTagScanner::processAttribute()
https://bugs.webkit.org/show_bug.cgi?id=149847

Reviewed by Antti Koivisto.

Refactor TokenPreloadScanner::StartTagScanner::processAttribute() to only
process attributes that make sense given the current tagId. In particular,

We only process the charset parameter if the tag is a link or a script.
We only process the sizes / srcset attributes if the tag is an img.

html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
(WebCore::TokenPreloadScanner::StartTagScanner::setUrlToLoad): Deleted.

4:03 AM Changeset in webkit [190966] by Carlos Garcia Campos

3 edits
4 adds in releases/WebKitGTK/webkit-2.10

Merge r190634 - Fix crash in ApplyStyleCommand::applyRelativeFontStyleChange()
https://bugs.webkit.org/show_bug.cgi?id=149300
<rdar://problem/22747046>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-06
Reviewed by Chris Dumez.

Source/WebCore:

This is a merge of Blink r167845 and r194944:
https://codereview.chromium.org/177093016
https://codereview.chromium.org/1124863003

Test: editing/style/apply-style-crash2.html

editing/style/apply-style-crash3.html

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
The issue was that we would traverse the DOM tree past the beyondEnd
under some circumstances and thus NodeTraversal::next() would return
null unexpectedly. This CL adds a check to make sure startNode != beyondEnd
before traversing to avoid the problem.

Besides that, this CL hardens changing font style over unknown elements.
When adjusting the start node position of where to apply a font style
command, check that we haven't stepped off the end.

This CL also adds a few more assertions to catch similar issues
more easily in the future.

LayoutTests:

editing/style/apply-style-crash2-expected.txt: Added.
editing/style/apply-style-crash2.html: Added.
editing/style/apply-style-crash3-expected.txt: Added.
editing/style/apply-style-crash3.html: Added.

4:02 AM Changeset in webkit [190965] by Carlos Garcia Campos

6 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190627 - Remove redundant isComposited() function and replace
hasLayer() && layer()->isComposited() with RenderObject::isComposited().
https://bugs.webkit.org/show_bug.cgi?id=149846

Reviewed by Simon Fraser.

No change in functionality.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
(WebCore::RenderLayerCompositor::requiresCompositingForFrame):

rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintUsingContainer):

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):

rendering/RenderView.cpp:

(WebCore::rendererObscuresBackground):
(WebCore::isComposited): Deleted.

rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry):

4:00 AM Changeset in webkit [190964] by Carlos Garcia Campos

20 edits in releases/WebKitGTK/webkit-2.10

Merge r190615 - Fix ENABLE_OPENGL=OFF builds
https://bugs.webkit.org/show_bug.cgi?id=146511

Patch by Emanuele Aina <Emanuele Aina> on 2015-10-06
Reviewed by Darin Adler.

Source/cmake/OptionsGTK.cmake: Make ENABLE_WAYLAND_TARGET depend on

ENABLE_OPENGL due to EGL usage.

Source/WebCore:

platform/graphics/texmap/BitmapTextureGL.h:
platform/graphics/texmap/BitmapTextureGL.cpp:
platform/graphics/texmap/TextureMapperGL.h:
platform/graphics/texmap/TextureMapperGL.cpp:
platform/graphics/texmap/TextureMapperShaderProgram.h:
platform/graphics/texmap/TextureMapperShaderProgram.cpp:

Fix TEXTURE_MAPPER_GL vs. TEXTURE_MAPPER guards to make sure that
ENABLE_OPENGL=OFF only disables the GL-related parts.

Source/WebKit2:

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseRealize):
(webkitWebViewBaseDraw):
(webkitWebViewBaseDidRelaunchWebProcess):
Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
webkitWebViewRenderAcceleratedCompositingResults()

UIProcess/DrawingAreaProxyImpl.cpp:
UIProcess/DrawingAreaProxyImpl.h:
WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::DrawingArea):

WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/LayerTreeHost.h:

Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
setNativeSurfaceHandleForCompositing().

UIProcess/gtk/WebPreferencesGtk.cpp:

(WebKit::WebPreferences::platformInitializeStore):
Default to no AC if no GL support has been built.

WebProcess/WebPage/DrawingArea.messages.in:

Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
SetNativeSurfaceHandleForCompositing.

WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
setNativeSurfaceHandleForCompositing().
(WebKit::DrawingAreaImpl::setNativeSurfaceHandleForCompositing):
Force setAcceleratedCompositingEnabled() only if a LayerTreeHost
implementation is available, to avoid crashing when building without
any GL support.

3:57 AM Changeset in webkit [190963] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.10

Merge r190605 - data: URLs should not be preloaded
https://bugs.webkit.org/show_bug.cgi?id=149829

Reviewed by Ryosuke Niwa.

Source/WebCore:

Update the HTMLPreloadScanner so that data: URLs do not get preloaded.
There is no need as the data is already available.

Test: fast/preloader/image-data-url.html

html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):

LayoutTests:

Add layout test to make sure that images with a data: URL do not
get preloaded.

fast/preloader/image-data-url-expected.txt: Added.
fast/preloader/image-data-url.html: Added.

3:56 AM Changeset in webkit [190962] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.10

Merge r190597 - CSSGradientValue should check whether gradientLength is zero or not.
https://bugs.webkit.org/show_bug.cgi?id=149373
<rdar://problem/22771418>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-05
Reviewed by Darin Adler.

Source/WebCore:

This is a merge of Blink r158220,
https://chromiumcodereview.appspot.com/24350008

Test: fast/gradients/css3-repeating-radial-gradients-crash.html

css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::addStops):
Check whether gradientLength > 0 before using it as denominator.

LayoutTests:

fast/gradients/css3-repeating-radial-gradients-crash-expected.txt: Added.
fast/gradients/css3-repeating-radial-gradients-crash.html: Added.

3:55 AM Changeset in webkit [190961] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.10

Merge r190592 - Reference cycles during SVG dependency invalidation
https://bugs.webkit.org/show_bug.cgi?id=149824
<rdar://problem/22771412>

Reviewed by Tim Horton.

Source/WebCore:

Detect any reference cycles as we are invalidating.

This is mostly a merge of the following Blink commit:
https://chromium.googlesource.com/chromium/blink/+/a4bc83453bda89823b672877dc02247652a02d51

Test: svg/custom/reference-cycle.svg

rendering/svg/RenderSVGResource.cpp:

(WebCore::removeFromCacheAndInvalidateDependencies): Keep around a hash
table of dependencies, so that we can detect if an element is already
present before marking it.

LayoutTests:

Adding a test that has a cycle between feImage resources.

Merge Blink commit:
https://chromium.googlesource.com/chromium/blink/+/a4bc83453bda89823b672877dc02247652a02d51

svg/custom/reference-cycle-expected.txt: Added.
svg/custom/reference-cycle.svg: Added.

3:54 AM Changeset in webkit [190960] by Carlos Garcia Campos

7 edits
3 adds in releases/WebKitGTK/webkit-2.10

Merge r190588 - Fix null pointer dereference in WebSocket::connect()
https://bugs.webkit.org/show_bug.cgi?id=149311
<rdar://problem/22748858>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-05
Reviewed by Chris Dumez.

Source/WebCore:

This is a merge of Blink r187441,
https://codereview.chromium.org/785933005

Test: http/tests/websocket/construct-in-detached-frame.html

Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):
Call function implemented below instead of duplicating the code.

page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::shouldBypassMainWorldContentSecurityPolicy):

page/ContentSecurityPolicy.h:

Factor the logic to check shouldBypassMainWorldContentSecurityPolicy into
a function in this class. Check Frame pointers are not null before getting
shouldBypassMainWorldContentSecurityPolicy via those pointers.

page/EventSource.cpp:

(WebCore::EventSource::create):
This got fixed as a bonus.

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):
This got fixed as a bonus too.

LayoutTests:

http/tests/websocket/construct-in-detached-frame-expected.txt: Added.
http/tests/websocket/construct-in-detached-frame.html: Added.
http/tests/websocket/resources/construct-in-detached-frame.html: Added.

3:53 AM Changeset in webkit [190959] by Sebastian Dröge

2 edits in trunk/Tools

Unreviewed, add myself to the committers list.

3:51 AM Changeset in webkit [190958] by Carlos Garcia Campos

3 edits
3 adds in releases/WebKitGTK/webkit-2.10

Merge r190585 - ShadowRoot with leading or trailing white space cause a crash
https://bugs.webkit.org/show_bug.cgi?id=149782

Reviewed by Chris Dumez.

Source/WebCore:

Fixed the crash by adding a null pointer check since a TextNode that appears as a direct child
of a ShadowRoot doesn't have a parent element.

Test: fast/shadow-dom/shadow-root-with-child-whitespace-text-crash.html

style/RenderTreePosition.cpp:

(WebCore::RenderTreePosition::previousSiblingRenderer):

LayoutTests:

Added a regression test.

fast/shadow-dom/shadow-root-with-child-whitespace-text-crash-expected.txt: Added.
fast/shadow-dom/shadow-root-with-child-whitespace-text-crash.html: Added.

3:49 AM Changeset in webkit [190957] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.10

Merge r190570 - Mark the line dirty when RenderQuote's text changes.
https://bugs.webkit.org/show_bug.cgi?id=149784
rdar://problem/22558169

Reviewed by Antti Koivisto.

When quotation mark changes ( " -> ' or empty string), we
need to mark the line dirty to ensure its content gets laid out properly.

Source/WebCore:

Test: fast/inline/quotation-text-changes-dynamically.html

rendering/RenderQuote.cpp:

(WebCore::quoteTextRenderer):
(WebCore::RenderQuote::updateText):
(WebCore::fragmentChild): Deleted.

LayoutTests:

fast/inline/quotation-text-changes-dynamically-expected.txt: Added.
fast/inline/quotation-text-changes-dynamically.html: Added.

3:47 AM Changeset in webkit [190956] by Carlos Garcia Campos

5 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190558 - GLContext should control ownership of context-related objects
https://bugs.webkit.org/show_bug.cgi?id=149794

Reviewed by Martin Robinson.

Creation of GLContext objects can depend on various platform-specific
objects like native window representations. Since these objects are
used solely for the GLContext purposes, it would make sense to allow
GLContext to provide an extensible way to impose ownership on these
objects and control their lifetime.

GLContext::Data is declared with a defaulted virtual destructor.
Users of these implementations can declare classes that derive from
GLContext::Data and store context-related objects in instances of the
derived class, and ensure that these objects are properly cleaned up
when GLContext destroys the Data object.

The GLContext::Data object is managed through a protected
std::unique_ptr<> member in the GLContext class. For now the member
is only set in GLContextEGL::createWindowContext() and is destroyed
during the GLContext destruction.

The local OffscreenContextData class in
PlatformDisplayWayland::createSharingGLContext() derives from
GLContext::Data and is used to store the wl_surface and
EGLNativeWindowType (aka wl_egl_window) objects for offscreen
GLContexts under the Wayland platform that are used for the sharing
context and WebGL, effectively avoiding the leak that would further
propagate problems into the compositor and the graphics library.
(Such offscreen contexts are actually mimicked via a 1x1px
wl_egl_window object that acts as a dummy base for the related
wl_surface object).

platform/graphics/GLContext.h:
platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::createWindowContext):

platform/graphics/egl/GLContextEGL.h:
platform/graphics/wayland/PlatformDisplayWayland.cpp:

(WebCore::PlatformDisplayWayland::createSharingGLContext):

3:45 AM Changeset in webkit [190955] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190557 - Make gdk.h inclusion in FontPlatformDataFreeType.cpp properly GTK-specific
https://bugs.webkit.org/show_bug.cgi?id=149793

Reviewed by Carlos Garcia Campos.

platform/graphics/freetype/FontPlatformDataFreeType.cpp:

Instead of including <gdk/gdk.h> header for all platforms but EFL, only
include it for the GTK platform, since no other platform depends on the
GDK library.

3:41 AM Changeset in webkit [190954] by Carlos Garcia Campos

28 edits in releases/WebKitGTK/webkit-2.10

Merge r190505 - popstate is fired at the wrong time on load
https://bugs.webkit.org/show_bug.cgi?id=94265

Patch by Antoine Quint <Antoine Quint> on 2015-10-02
Reviewed by Darin Adler.

Source/WebCore:

Don't fire popstate event on initial document load

According to the specification [1], a popstate event should only be fired
when the document has a "last entry" and the entry being navigated to isn't
it. A document is created without a "last entry" and gets one just after
this check when it is first navigated to, so a popstate should be fired any
time a document is navigated to except for the first time after it has been
created.

Patch adapted from work by jl@opera.com on Blink [2].

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#traverse-the-history (step 12-14 in particular)
[2] https://src.chromium.org/viewvc/blink?revision=165221&view=revision

dom/Document.cpp:

(WebCore::Document::implicitClose):

Source/WebKit2:

Ensure we have a valid page before trying to get to its drawingArea as this could lead
to a crash as observed with fast/loader/stateobjects/pushstate-object-types.html.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::restoreViewState):

LayoutTests:

Updating tests that relied on a "popstate" event being fired at page load.

fast/history/same-document-iframes-changing-fragment-expected.txt:
fast/history/same-document-iframes-changing-pushstate-expected.txt:
fast/loader/javascript-url-iframe-remove-on-navigate.html:
fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html:
fast/loader/stateobjects/document-destroyed-navigate-back.html:
fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html:
fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html:
fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute.html:
fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html:
fast/loader/stateobjects/popstate-fires-on-history-traversal-expected.txt:
fast/loader/stateobjects/popstate-fires-on-history-traversal.html:
fast/loader/stateobjects/popstate-fires-with-page-cache-expected.txt:
fast/loader/stateobjects/popstate-fires-with-page-cache.html:
fast/loader/stateobjects/pushstate-object-types.html:
fast/loader/stateobjects/pushstate-then-replacestate.html:
fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html:
fast/loader/stateobjects/replacestate-then-pushstate.html:
fast/loader/stateobjects/resources/popstate-fires-with-page-cache-1.html:
fast/loader/stateobjects/resources/popstate-fires-with-page-cache-2.html:
fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html:
http/tests/history/popstate-fires-with-pending-requests.html:
http/tests/navigation/redirect-on-back-updates-history-item-expected.txt:
http/tests/navigation/redirect-on-reload-updates-history-item-expected.txt:

3:35 AM Changeset in webkit [190953] by Carlos Garcia Campos

3 edits
6 adds in releases/WebKitGTK/webkit-2.10

Merge r190418 - Network cache: Subresource referer header wrong after cached redirect
https://bugs.webkit.org/show_bug.cgi?id=149709
rdar://problem/22917174

Reviewed by Chris Dumez.

Source/WebKit2:

If a main resource is loaded from a cache entry that involved redirects the document
will end up setting the Referer-headers of the subresources to the request URL not the redirected URL

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):

If a cache entry involved a redirect synthesize a minimal willSendRequest message so that WebCore side
runs through the same code paths as when receiving a redirect from network.

LayoutTests:

http/tests/cache/redirect-referer-expected.html: Added.
http/tests/cache/redirect-referer.html: Added.
http/tests/cache/resources/load-and-check-referer.php: Added.
http/tests/cache/resources/permanent-redirect.php: Added.
http/tests/cache/resources/redirect-referer-iframe.html: Added.
http/tests/cache/resources/redirect-referer-iframe-expected.html: Added.

3:34 AM Changeset in webkit [190952] by Carlos Garcia Campos

6 edits in releases/WebKitGTK/webkit-2.10

Merge r190413 - [GTK] Websites with invalid auth header keep loading forever
https://bugs.webkit.org/show_bug.cgi?id=149710

Reviewed by Martin Robinson.

Source/WebCore:

We don't correctly handle a null realm from the server when
retrieving and storing credentials from libsecret. First
secret_attributes_build() fails because we pass a null domain, and
we pass null attributes to secret_service_search() that returns
early on a g_return macro and the callback is never called so the
load doesn't continue after the auth challenge.

platform/network/gtk/CredentialBackingStore.cpp:

(WebCore::createAttributeHashTableFromChallenge):
(WebCore::CredentialBackingStore::credentialForChallenge):
(WebCore::CredentialBackingStore::storeCredentialsForChallenge):

Source/WebKit2:

Do not show the remember credentials checkbutton in the auth
dialog if the realm is empty.

UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:

(webkitAuthenticationDialogInitialize):

Tools:

Add test case to check that we can authenticate sites with an
empty realm.

TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:

(testWebViewAuthenticationEmptyRealm):
(serverCallback):
(beforeAll):

3:30 AM Changeset in webkit [190951] by Carlos Garcia Campos

1 edit
2 adds in releases/WebKitGTK/webkit-2.10/Source/WebInspectorUI

Merge r190405 - [GTK] Web Inspector: Add GTK+ icons for the numerical input and slider based Visual editors for CSS properties
https://bugs.webkit.org/show_bug.cgi?id=147847

Reviewed by Carlos Garcia Campos.

UserInterface/Images/gtk/VisualStylePropertyLinked.svg: Added.
UserInterface/Images/gtk/VisualStylePropertyUnlinked.svg: Added.

3:30 AM Changeset in webkit [190950] by Carlos Garcia Campos

3 edits
19 adds in releases/WebKitGTK/webkit-2.10/Source/WebInspectorUI

Merge r190404 - [GTK] Web Inspector: Add GTK+ icons for the different types of non-numerical Visual editors for CSS properties
https://bugs.webkit.org/show_bug.cgi?id=147846

Reviewed by Carlos Garcia Campos.

UserInterface/Images/gtk/AUTHORS: Updated.
UserInterface/Images/gtk/ClearBoth.svg: Added.
UserInterface/Images/gtk/ClearLeft.svg: Added.
UserInterface/Images/gtk/ClearRight.svg: Added.
UserInterface/Images/gtk/CubicBezier.svg: Updated.
UserInterface/Images/gtk/FloatLeft.svg: Added.
UserInterface/Images/gtk/FloatRight.svg: Added.
UserInterface/Images/gtk/FontStyleItalic.svg: Added.
UserInterface/Images/gtk/FontStyleNormal.svg: Added.
UserInterface/Images/gtk/FontVariantSmallCaps.svg: Added.
UserInterface/Images/gtk/TextAlignCenter.svg: Added.
UserInterface/Images/gtk/TextAlignJustify.svg: Added.
UserInterface/Images/gtk/TextAlignLeft.svg: Added.
UserInterface/Images/gtk/TextAlignRight.svg: Added.
UserInterface/Images/gtk/TextDecorationLineThrough.svg: Added.
UserInterface/Images/gtk/TextDecorationOverline.svg: Added.
UserInterface/Images/gtk/TextDecorationUnderline.svg: Added.
UserInterface/Images/gtk/TextTransformCapitalize.svg: Added.
UserInterface/Images/gtk/TextTransformLowercase.svg: Added.
UserInterface/Images/gtk/TextTransformUppercase.svg: Added.
UserInterface/Images/gtk/VisualStyleNone.svg: Added.

3:26 AM Changeset in webkit [190949] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190382 - GraphicsContext3D::mappedSymbolName should initialize count variable
https://bugs.webkit.org/show_bug.cgi?id=149692
<rdar://problem/22871304>

Reviewed by Simon Fraser.

While debugging another WebGL issue, I noticed that some
OpenGL renderers can get into a state where they
drop resources (e.g. a GPU reset). If we don't detect that
in time, we might try to ask for the currently attached
resources and our in-parameter will not be set. In this
case, initialize it to zero so that we don't do silly things.

platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::mappedSymbolName): Initialize count to 0.

3:25 AM Changeset in webkit [190948] by Carlos Garcia Campos

4 edits
2 adds in releases/WebKitGTK/webkit-2.10

Merge r190375 - Crash when using an SVG font with > 390 glyphs
https://bugs.webkit.org/show_bug.cgi?id=149677
<rdar://problem/21676402>

Reviewed by Simon Fraser.

Source/WebCore:

The "Charset Index" in OTF are indices into a collection of strings. There are
390 predefined strings in this collection. We were currently assigning each
glyph to one of these strings. However, if there are more glyphs than strings,
we will be using invalid indices.

The values of the strings themselves are not necessary for SVG fonts. Therefore,
the solution is to create a single dummy string, and have all glyphs target it.

Tests: svg/custom/many-glyphs.svg

css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::font):

svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::appendCFFTable):

LayoutTests:

svg/custom/many-glyphs-expected.svg: Added.
svg/custom/many-glyphs.svg: Added.

3:23 AM Changeset in webkit [190947] by Carlos Garcia Campos

1 edit
1 add in releases/WebKitGTK/webkit-2.10/Source/WebInspectorUI

Merge r190369 - [GTK] Web Inspector: Add GTK+ icon for the Bezier curve visual editor
https://bugs.webkit.org/show_bug.cgi?id=147681

Reviewed by Joseph Pecoraro.

UserInterface/Images/gtk/CubicBezier.svg: Added.

3:23 AM Changeset in webkit [190946] by Carlos Garcia Campos

15 edits in releases/WebKitGTK/webkit-2.10/Source

Merge r190364 - Unreviewed, roll out r188331: "NetworkProcess: DNS prefetch happens in the Web Process"
<rdar://problem/22560715>

Speculative roll out of r188331 as we had a ~2.5% PLT regression around
the time it landed and it seems the most likely culprit. I'll reland if
the perf bots do not recover after the roll out.

Source/WebCore:

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute):

loader/FrameLoaderClient.h:
loader/LinkLoader.cpp:

(WebCore::LinkLoader::loadLink):

page/Chrome.cpp:

(WebCore::Chrome::mouseDidMoveOverElement):

Source/WebKit2:

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::storageSession): Deleted.

NetworkProcess/NetworkConnectionToWebProcess.h:
NetworkProcess/NetworkConnectionToWebProcess.messages.in:
WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:

(webkitWebExtensionDidReceiveMessage):

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):

WebProcess/WebProcess.cpp:
WebProcess/WebProcess.h:

3:17 AM Changeset in webkit [190945] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2

Merge r190345 - [GTK] Build error with -DENABLE_SPELLCHECK=OFF
https://bugs.webkit.org/show_bug.cgi?id=146904

Reviewed by Carlos Garcia Campos.

Add ifdef guards to allow building when SPELLCHECK is not enabled.

UIProcess/gtk/TextCheckerGtk.cpp:

(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::getGuessesForWord):
(WebKit::TextChecker::learnWord):
(WebKit::TextChecker::ignoreWord):
(WebKit::TextChecker::requestCheckingOfString):
(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::setSpellCheckingLanguages):
(WebKit::TextChecker::loadedSpellCheckingLanguages):

3:16 AM Changeset in webkit [190944] by Carlos Garcia Campos

14 edits in releases/WebKitGTK/webkit-2.10/Source

Merge r190344 - [GTK] Support HiDPI Properly in WebKitGtk+ with the TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=141782

Reviewed by Carlos Garcia Campos.

Source/WebCore:

This patch fixes HiDPI issue in the TextureMapper.
To support HiDPI in the TextureMapper, we need to draw scaled contents
in the TextureMapperTile, and apply the global scale in the root layer
to apply transforms correctly.

Supporting the device scale is handled at LayerTreeHostGtk and
TextureMapperBackingStore, and GraphicsLayerTextureMapper doesn't handle
the device scale directly.

From the TextureMapperLayer, deviceScale and pageScale do not have to be
handled differently. These are multiplied and provided to
TextureMapperBackingStore.

platform/graphics/texmap/TextureMapperTile.cpp:

(WebCore::TextureMapperTile::updateContents):

platform/graphics/texmap/TextureMapperTile.h:
platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:

Modified to increase the cover rect for tiles creation. For the image
contents, it just creates texture with a image size, regardless of the
contents scale.

platform/graphics/texmap/BitmapTexture.cpp:

(WebCore::BitmapTexture::updateContents):

Apply the device scale to the graphics context before painting contents.

platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):

Apply the device scale and the page scale to the backing store

Source/WebKit2:

UIProcess/API/gtk/WebKitWebViewBase.cpp:
UIProcess/gtk/RedirectedXCompositeWindow.cpp:

Modified to create scaled size of window.

WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::initialize):
(WebKit::LayerTreeHostGtk::deviceOrPageScaleFactorChanged):

We should apply device scale factor to the root layer to apply
the scale matrix before applying other transform matrices.

(WebKit::LayerTreeHostGtk::deviceScaleFactor): Added.
(WebKit::LayerTreeHostGtk::pageScaleFactor): Added.

3:06 AM Changeset in webkit [190943] by Carlos Garcia Campos

4 edits
2 adds in releases/WebKitGTK/webkit-2.10

Merge r190339 - Avoid reparsing an XSLT stylesheet after the first failure.
https://bugs.webkit.org/show_bug.cgi?id=149188
<rdar://problem/22709912>

Reviewed by Dave Hyatt.

Patch by Jiewen Tan, jiewen_tan@apple.com.

Source/WebCore:

Test: svg/custom/invalid-xslt-crash.svg

xml/XSLStyleSheet.h:

Add a new member variable m_compilationFailed that tracks whether
compilation has failed. Default value is false.

xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::compileStyleSheet):
Return early if the compilation has failed before. After compiling the
style sheet, if we failed, set m_compilationFailed to true.

LayoutTests:

svg/custom/invalid-xslt-crash-expected.txt: Added.
svg/custom/invalid-xslt-crash.svg: Added.

3:00 AM Changeset in webkit [190942] by Carlos Garcia Campos

5 edits
2 adds in releases/WebKitGTK/webkit-2.10

Merge r190320 - Memory cache revalidations should refresh the network disk cache
https://bugs.webkit.org/show_bug.cgi?id=149606

Reviewed by Darin Adler.

Source/WebKit2:

Previously, resource revalidations triggered by the memory cache would
bypass the disk cache entirely because the requests are conditional. As
a result, when the server responds with a 304, we were unable to update
the headers (e.g. new expiration date) of the corresponding entry in
the disk cache.

This patch updates our disk cache implementation to not bypass the disk
cache when the request is conditional. Instead, we look up the cached
entry and force its revalidation from the network. If the server then
returns a 304, we are now able to update the headers of this cached
entry. In such case though, we let the 304 response through to WebCore
unlike revalidations triggered by the disk cache.

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponseAsync):

NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::makeUseDecision):
(WebKit::NetworkCache::makeRetrieveDecision):

LayoutTests:

Add layout test to check that revalidations requested by the memory cache
update the corresponding disk cache entry when the server responds with a
304 status code.

http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache-expected.txt: Added.
http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache.html: Added.

2:48 AM Changeset in webkit [190941] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.10

Merge r190238 - [GTK] ASSERTION FAILED: !m_inUpdateBackingStoreState in DrawingAreaImpl::display() after DrawingAreaImpl::forceRepaint()
https://bugs.webkit.org/show_bug.cgi?id=148956

Reviewed by Žan Doberšek.

Source/WebKit2:

This is because those tests call notifyDone in the onresize event
handler. InjectedBundlePage::dump() always calls WKBundlePageForceRepaint()
before dumping. When the view is resized DrawingAreaImpl::updateBackingStoreState()
is called, so if the size has changed the FrameView::resize()
method is called and all children are resized, so the onresize
handlers happen at that point, before the
m_inUpdateBackingStoreState is set to false again. For WTR we
could probably just return early from froceReapaint() when
m_inUpdateBackingStoreState is true, because in that case we know
the layout is updated because of the resize and the actual display
is not really needed. But the UI process can also request a force
repaint, so we could wait until the backing store update is done
and then force the repaint. For WTR it will happen after the
dump, but it shouldn't be a problem.

WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint):
(WebKit::DrawingAreaImpl::updateBackingStoreState):

WebProcess/WebPage/DrawingAreaImpl.h:

LayoutTests:

Unskip tests that should pass now.

platform/gtk/TestExpectations:

2:40 AM Changeset in webkit [190940] by Carlos Garcia Campos

3 edits
5 adds in releases/WebKitGTK/webkit-2.10

Merge r190160 - [GTK] playbutton in media controls is not changed when it is clicked.
https://bugs.webkit.org/show_bug.cgi?id=149113

Reviewed by Philippe Normand.

Source/WebCore:

When the play button in media controls is clicked, a 'paused' class is added or removed
for the element to update its appearance. Although Document::recalcStyle is triggered
by that class attribute change, the play button is not changed since there is
no difference in styles whether having the 'paused' class or not. Gtk port
does not define the -webkit-media-controls-play-button.paused. To fix this,
-webkit-media-controls-play-button.paused is newly defined with a dummy style,
"position: relative;", which should not change the play button appearance,
but be clearly different in style.

Test: media/media-controls-play-button-updates.html

css/mediaControlsGtk.css:

(video::-webkit-media-controls-play-button.paused):

LayoutTests:

media/media-controls-play-button-updates-expected.png: Added.
media/media-controls-play-button-updates-expected.txt: Added.
media/media-controls-play-button-updates.html: Added.
platform/gtk/media/media-controls-play-button-updates-expected.png: Added.
platform/gtk/media/media-controls-play-button-updates-expected.txt: Added.

2:39 AM Changeset in webkit [190939] by Carlos Garcia Campos

6 edits
2 adds in releases/WebKitGTK/webkit-2.10

Merge r190153 - Event fired on a detached node does not bubble up
https://bugs.webkit.org/show_bug.cgi?id=149488

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Rebaselined a test now that one more test case passes.

web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:

Source/WebCore:

The bug was caused by an explicit check inside EventPath to match an old Firefox behavior (see r19897).
Since Firefox's behavior has changed to match DOM4: https://dom.spec.whatwg.org/#concept-event-dispatch

Fixed the bug by removing the check. The new behavior matches DO4 and behaviors of Firefox and Chrome.

Test: fast/events/event-propagation-in-detached-tree.html

dom/EventDispatcher.cpp:

(WebCore::EventPath::EventPath):

LayoutTests:

Added a regression test. Also modified and rebaselined mouseout-dead-node.html added in r19897
since our new behavior matches that of the latest Firefox as well as Chrome.

fast/events/event-propagation-in-detached-tree-expected.txt: Added.
fast/events/event-propagation-in-detached-tree.html: Added.
fast/events/mouseout-dead-node-expected.txt:
fast/events/mouseout-dead-node.html:

2:35 AM Changeset in webkit [190938] by Carlos Garcia Campos

31 edits in releases/WebKitGTK/webkit-2.10/Source

Merge r190124 - Make it more obvious when using an unaccelerated image buffer, and fix a few callers who do
https://bugs.webkit.org/show_bug.cgi?id=149428

Reviewed by Simon Fraser and Darin Adler.

platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::createCompatibleBuffer):

platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::create):
Make the RenderingMode parameter to ImageBuffer::create non-optional.

platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::renderingMode):

platform/graphics/GraphicsTypes.h:

Add renderingMode() getter so that every caller doesn't need to do the conversion to RenderingMode.

css/CSSFilterImageValue.cpp:

(WebCore::CSSFilterImageValue::image):

html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::LRUImageBufferCache::imageBuffer):

rendering/shapes/Shape.cpp:

(WebCore::Shape::createRasterShape):

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):

platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::putByteArray):
These five callers create unconditionally unaccelerated ImageBuffers which
should probably instead respect the acceleration bit from the context
that the ImageBuffer will eventually be painted into. Bugs have been filed.

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::createCompositingBuffer):

platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::drawPattern):
Adjust the argument order and remove defaults which are passed explicitly.

page/FrameSnapshotting.cpp:

(WebCore::snapshotFrameRect):
Snapshots are (currently) meant to be taken without accelerated drawing.
Make this explicit.

platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::drawPattern):
Make use of createCompatibleBuffer. This caller was previously creating
an unconditionally unaccelerated context!

platform/graphics/NamedImageGeneratedImage.cpp:

(WebCore::NamedImageGeneratedImage::drawPattern):
Remove a comment.

platform/graphics/ShadowBlur.cpp:

(WebCore::ScratchBuffer::getScratchBuffer):
ShadowBlur is only used with unaccelerated contexts, so it's OK to hardcode Unaccelerated here.

platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::createImageBufferResult):
Flip the order of the arguments.

(WebCore::FilterEffect::openCLImageToImageBuffer):
This caller was previously creating an unaccelerated buffer; instead, match the destination buffer.

rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::allocateBackingStoreIfNeeded):
Adjust the argument order and remove defaults which are passed explicitly.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):
Get rid of the unneeded renderingMode local, and factor out retrieval of Frame.

rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):
These two callers are unconditionally creating unaccelerated buffers,
and changing this to match the destination context seems to actually
break things. This needs further investigation.

rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::createMaskAndSwapContextForTextGradient):
This caller was previously creating an unaccelerated buffer; instead, match the destination buffer.

rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::buildPattern):
Make use of renderingMode().

rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::createImageBuffer):
Adjust the argument order.

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::nativeImageForCurrentFrame):

WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::imageForCurrentSharingServicePickerItem):

Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.cpp:

(WebKit::ThreadSafeCoordinatedSurface::create):

2:19 AM Changeset in webkit [190937] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2

Merge r190121 - [WK2][NetworkCache] New entry bodies remain in dirty memory after being written to disk.
<https://webkit.org/b/149463>

Reviewed by Antti Koivisto.

Call msync(MS_ASYNC) on cache entry bodies after writing their data to a
memory-mapped file. This turns the previously dirty memory into clean memory,
reducing our effective footprint.

I previously believed this would happen automatically when the kernel finds
itself under memory pressure, around the same time as it starts dropping
volatile pages. Turns out that's not the case. Even under considerable pressure,
we never flush this memory to file. So let's take care of it ourselves.

If this ends up generating more IO activity than we're comfortable with on some
scenario, we can look at throttling.

NetworkProcess/cache/NetworkCacheData.cpp:

(WebKit::NetworkCache::Data::mapToFile):

2:18 AM Changeset in webkit [190936] by Carlos Garcia Campos

6 edits in releases/WebKitGTK/webkit-2.10

Merge r190114 - Source/WebCore:
CurrentTime on mediaController is set as 0 when playback is completed.
https://bugs.webkit.org/show_bug.cgi?id=149154

Patch by sangdeug.kim <sangdeug.kim@samsung.com> on 2015-09-22
Reviewed by Eric Carlson.

Test : media/media-controller-time-clamp.html

html/MediaController.cpp:

(MediaController::setCurrentTime):
(MediaController::updatePlaybackState):

html/MediaController.h:

LayoutTests:
Add test for checking currentTime of mediacontroller when playback is completed.
https://bugs.webkit.org/show_bug.cgi?id=149154

Patch by sangdeug.kim <sangdeug.kim@samsung.com> on 2015-09-22
Reviewed by Eric Carlson.

media/media-controller-time-clamp-expected.txt:
media/media-controller-time-clamp.html:

2:14 AM Changeset in webkit [190935] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190079 - svg/custom/hidpi-masking-clipping.svg fails with accelerated drawing on
https://bugs.webkit.org/show_bug.cgi?id=149413
<rdar://problem/22787058>

Reviewed by Dean Jackson.

No new tests, this is covered by existing tests.

rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::buildPattern):
(WebCore::RenderSVGResourcePattern::applyResource):
(WebCore::RenderSVGResourcePattern::createTileImage):

rendering/svg/RenderSVGResourcePattern.h:

Make pattern images respect the accelerated bit of the parent GraphicsContext.

2:03 AM Changeset in webkit [190934] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.10

Merge r190054 - [GTK] media controls does not show up when playing video finishes.
https://bugs.webkit.org/show_bug.cgi?id=149112

Reviewed by Philippe Normand.

Source/WebCore:

GTK port does not show controls after playing video. This behavior is different
from what Mac port does. They do show controls when playing video finishes.
At least, we should update the timeline before showing it up not to show incorrect numbers
when reappearing.

Test: media/media-controls-timeline-updates-after-playing.html

Modules/mediacontrols/mediaControlsBase.js:

(Controller.prototype.setPlaying):
(Controller.prototype.showControls):

LayoutTests:

media/media-controls-timeline-updates-after-playing-expected.txt: Added.
media/media-controls-timeline-updates-after-playing.html: Added.

2:02 AM Changeset in webkit [190933] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.10

Merge r190053 - [GTK] timeline is not updated after few seconds when mouse hovers on controls
https://bugs.webkit.org/show_bug.cgi?id=149111

Reviewed by Philippe Normand.

Source/WebCore:

Timeline is not updated if controlsAreHidden is true. The problem here is that
the function does not mean actually 'hidden' since it only checkes 'show' and 'hidden'
class existences. The panel's visibility are not only controlled by the two classes,
but also by video::-webkit-media-controls-panel:hover. The panel could be visible
by setting the pseudo hover class. So we need to check if panel is hovered as well in controlsAreHidden().

Test: media/media-controls-timeline-updates-when-hovered.html

Modules/mediacontrols/mediaControlsBase.js:

(Controller.prototype.controlsAreHidden):

LayoutTests:

media/media-controls-timeline-updates-when-hovered-expected.txt: Added.
media/media-controls-timeline-updates-when-hovered.html: Added.

2:01 AM Changeset in webkit [190932] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.10/Tools

Merge r190046 - [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
https://bugs.webkit.org/show_bug.cgi?id=149252

Reviewed by Darin Adler.

In case of glib tests the test runner notifies about tests
crashing, but for google tests we don't get any feedback, which
means that in case of a test crashing we get a list of PASS
messages and at the summary we are notified that the test suite
has failed, but it's impossible to know which test cases have failed.

Scripts/run-gtk-tests:

(TestRunner._run_google_test): Add a CRASH message if test
case crashed.

1:53 AM Changeset in webkit [190931] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.10

Merge r190013 - Null dereference loading Blink layout test svg/filters/feImage-failed-load-crash.html
https://bugs.webkit.org/show_bug.cgi?id=149316
<rdar://problem/22749532>

Reviewed by Tim Horton.

Source/WebCore:

If an feImage triggered loading a resource, and then was removed from the document,
we'd still try to notify its parent when the resource arrived (or failed).

Merge Blink commit:
https://chromium.googlesource.com/chromium/blink/+/9cbcfd7866bbaff0c4b3c4c8508b7c97b46d6e6a

Test: svg/filters/feImage-failed-load-crash.html

svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::notifyFinished): Add a null check to the parent element
before sending the notification.

LayoutTests:

Merge Blink commit:
https://chromium.googlesource.com/chromium/blink/+/9cbcfd7866bbaff0c4b3c4c8508b7c97b46d6e6a

svg/filters/feImage-failed-load-crash-expected.txt: Added.
svg/filters/feImage-failed-load-crash.html: Added.

1:53 AM Changeset in webkit [190930] by Chris Dumez

2 edits in trunk/Source/WebKit2

Avoid useless copying of Key::HashType in loops in NetworkCache::Storage::synchronize()
https://bugs.webkit.org/show_bug.cgi?id=150061

Reviewed by Carlos Garcia Campos.

Avoid useless copying of Key::HashType in loops in NetworkCache::Storage::synchronize().
Key::HashType is currently a SHA1::Digest, which is a std::array<uint8_t, 20>.

NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::synchronize):

1:52 AM Changeset in webkit [190929] by Carlos Garcia Campos

3 edits
6 adds in releases/WebKitGTK/webkit-2.10

Merge r190012 - Null dereference loading Blink layout test svg/custom/use-href-attr-removal-crash.html
https://bugs.webkit.org/show_bug.cgi?id=149315
<rdar://problem/22749358>

Reviewed by Tim Horton.

Source/WebCore:

We were not checking if the corresponding element referenced from
the SVG <use> actually existed before trying to set attributes on it.
The original Blink change is a little more detailed:
https://chromium.googlesource.com/chromium/blink/+/e2f1087f32bb088160ab7d59a715a1403ef267c7
However, we've significantly diverged at this point.

Tests: svg/custom/use-href-attr-removal-crash.html

svg/custom/use-href-attr-removal-crash2.svg
svg/custom/use-href-change-local-to-invalid-remote.html

svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::transferSizeAttributesToTargetClone):

LayoutTests:

These tests, copied from Blink, should not crash.
The originals come from:
https://chromium.googlesource.com/chromium/blink/+/e2f1087f32bb088160ab7d59a715a1403ef267c7

svg/custom/use-href-attr-removal-crash.html: Added.
svg/custom/use-href-attr-removal-crash-expected.txt: Added.
svg/custom/use-href-attr-removal-crash2.svg: Added.
svg/custom/use-href-attr-removal-crash2-expected.txt: Added.
svg/custom/use-href-change-local-to-invalid-remote.html: Added.
svg/custom/use-href-change-local-to-invalid-remote-expected.txt: Added.

1:49 AM Changeset in webkit [190928] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190097 - Fix release builds with security assertion after r190007.

dom/DocumentOrderedMap.cpp:
dom/DocumentOrderedMap.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed