⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 21, 2015:

11:59 PM Changeset in webkit [191441] by fred.wang@free.fr
  • 2 edits in trunk/Source/WebCore

Unreviewed compilation fix on Mac.

  • platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::platformInit): Add missing font argument.

11:45 PM Changeset in webkit [191440] by fred.wang@free.fr
  • 8 edits in trunk

[Mac] Add support for the USE_TYPO_METRICS flag
​https://bugs.webkit.org/show_bug.cgi?id=150394

Reviewed by Myles C. Maxfield.

Source/WebCore:

Make the Cocoa backend use the typo metrics for fonts with a MATH table when the OS/2 USE_TYPO_METRICS flag is set.

No new tests because this is already tested by fonts/use-typo-metrics-1.html

  • platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::platformInit): Verify whether the OS/2 USE_TYPO_METRICS flag is set and use the typo metrics if that is the case.

LayoutTests:

Update font, reference and Mac expectation for fonts/use-typo-metrics-1.html

  • fonts/lineheight5000-typolineheight2300.woff: Add a MATH table.
  • platform/mac-mavericks/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Updated.
  • platform/mac/TestExpectations: Remove Mac failure expectation.
  • platform/mac/mathml/opentype/opentype-stretchy-expected.txt: Updated.
  • platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Updated.
11:10 PM Changeset in webkit [191439] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

Print out the render tree from command line.
​https://bugs.webkit.org/show_bug.cgi?id=150416

Use system-wide notification server (​https://developer.apple.com/library/mac/documentation/Darwin/Reference/ManPages/man3/notify_register_dispatch.3.html)
to print out the render tree for the live documents.

Usage: notifyutil -p com.apple.WebKit.showRenderTree

Reviewed by Simon Fraser.

No change in functionality.

  • platform/Logging.cpp:

(WebCore::registerNotifyCallback):

  • platform/Logging.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):
(WebCore::printRenderTreeForLiveDocuments):

10:50 PM Changeset in webkit [191438] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix CMake clean build after r191423.

  • CMakeLists.txt:

HTMLBaseFontElement.idl no longer generates any JavaScript bindings.

10:26 PM Changeset in webkit [191437] by BJ Burg
  • 2 edits in trunk/Tools

Unreviewed, update watchlist for JS builtins.

Add a category for JS builtins code generator, similar to other generators.

Add a nag message to rebaseline builtins generator tests when touching
code generator files in Source/JavaScriptCore/Scripts/builtins/.

  • Scripts/webkitpy/common/config/watchlist:
10:13 PM Changeset in webkit [191436] by Gyuyoung Kim
  • 2 edits in trunk/Source/WebKit2

Unreviewed EFL build fix. Remove customizeMenu implementation.

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::customizeMenu): Deleted.

9:51 PM Changeset in webkit [191435] by BJ Burg
  • 2 edits in trunk/Source/WebCore

Unreviewed, CMake build fix after r191433.

  • CMakeLists.txt: add WritableStreamInternals.js to WebCore_BUILTINS_SOURCES.
9:45 PM Changeset in webkit [191434] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit2

Speculative EFL build fix.

  • WebProcess/WebCoreSupport/WebContextMenuClient.h:

Remove another customizeMenu call.

9:39 PM Changeset in webkit [191433] by BJ Burg
  • 14 edits
    6 copies
    1 move
    35 adds
    2 deletes in trunk

Restructure generate-js-bindings script to be modular and testable
​https://bugs.webkit.org/show_bug.cgi?id=149929

Reviewed by Alex Christensen.

Source/JavaScriptCore:

This is a new code generator, based on the replay inputs code generator and
the inspector protocol code generator, which produces various files for JS
builtins.

Relative to the generator it replaces, this one consolidates two scripts in
JavaScriptCore and WebCore into a single script with multiple files. Parsed
information about the builtins file is stored in backend-independent model
objects. Each output file has its own code generator that uses the model to
produce resulting code. Generators are additionally parameterized by the target
framework (to choose correct macros and includes) and output mode (one
header/implementation file per builtin or per framework).

It includes a few simple tests of the generator's functionality. These result-
based tests will become increasingly more important as we start to add support
for builtins annotation such as @optional, @internal, etc. to the code generator.

Some of these complexities, such as having two output modes, will be removed in
subsequent patches. This patch is intended to exactly replace the existing
functionality with a unified script that makes additional cleanups straightforward.

Additional cleanup and consolidation between inspector code generator scripts
and this script will be pursued in followup patches.

New tests:

Scripts/tests/builtins/JavaScriptCore-Builtin.Promise-Combined.js
Scripts/tests/builtins/JavaScriptCore-Builtin.Promise-Separate.js
Scripts/tests/builtins/JavaScriptCore-Builtin.prototype-Combined.js
Scripts/tests/builtins/JavaScriptCore-Builtin.prototype-Separate.js
Scripts/tests/builtins/JavaScriptCore-BuiltinConstructor-Combined.js
Scripts/tests/builtins/JavaScriptCore-BuiltinConstructor-Separate.js
Scripts/tests/builtins/WebCore-GuardedBuiltin-Separate.js
Scripts/tests/builtins/WebCore-GuardedInternalBuiltin-Separate.js
Scripts/tests/builtins/WebCore-UnguardedBuiltin-Separate.js
Scripts/tests/builtins/WebCore-xmlCasingTest-Separate.js

  • CMakeLists.txt:

Copy the scripts that are used by other targets to a staging directory inside
${DERIVED_SOURCES_DIR}/ForwardingHeaders/JavaScriptCore/Scripts.
Define JavaScriptCore_SCRIPTS_DIR to point here so that the add_custom_command
and shared file lists are identical between JavaScriptCore and WebCore. The staged
scripts are a dependency of the main JavaScriptCore target so that they are
always staged, even if JavaScriptCore itself does not use a particular script.

The output files additionally depend on all builtin generator script files
and input files that are combined into the single header/implementation file.

  • DerivedSources.make:

Define JavaScriptCore_SCRIPTS_DIR explicitly so the rule for code generation and
shared file lists are identical between JavaScriptCore and WebCore.

The output files additionally depend on all builtin generator script files
and input files that are combined into the single header/implementation file.

Mark the new builtins generator files as private headers so we can use them from
WebCore.

  • Scripts/UpdateContents.py: Renamed from Source/JavaScriptCore/UpdateContents.py.
  • Scripts/builtins/init.py: Added.
  • Scripts/builtins/builtins.py: Added.
  • Scripts/builtins/builtins_generator.py: Added. This file contains the base generator.

(WK_lcfirst):
(WK_ucfirst):
(BuiltinsGenerator):
(BuiltinsGenerator.init):
(BuiltinsGenerator.model):
(BuiltinsGenerator.generate_license):
(BuiltinsGenerator.generate_includes_from_entries):
(BuiltinsGenerator.generate_output):
(BuiltinsGenerator.output_filename):
(BuiltinsGenerator.mangledNameForFunction):
(BuiltinsGenerator.mangledNameForFunction.toCamel):
(BuiltinsGenerator.generate_embedded_code_string_section_for_function):

  • Scripts/builtins/builtins_model.py: Added. This file contains builtins model objects.

(ParseException):
(Framework):
(Framework.init):
(Framework.setting):
(Framework.fromString):
(Frameworks):
(BuiltinObject):
(BuiltinObject.init):
(BuiltinFunction):
(BuiltinFunction.init):
(BuiltinFunction.fromString):
(BuiltinFunction.str):
(BuiltinsCollection):
(BuiltinsCollection.init):
(BuiltinsCollection.parse_builtins_file):
(BuiltinsCollection.copyrights):
(BuiltinsCollection.all_functions):
(BuiltinsCollection._parse_copyright_lines):
(BuiltinsCollection._parse_functions):

  • Scripts/builtins/builtins_templates.py: Added.

(BuiltinsGeneratorTemplates):

  • Scripts/builtins/builtins_generate_combined_header.py: Added.

(BuiltinsCombinedHeaderGenerator):
(BuiltinsCombinedHeaderGenerator.init):
(BuiltinsCombinedHeaderGenerator.output_filename):
(BuiltinsCombinedHeaderGenerator.generate_output):
(BuiltinsCombinedHeaderGenerator.generate_forward_declarations):
(FunctionExecutable):
(VM):
(ConstructAbility):
(generate_section_for_object):
(generate_externs_for_object):
(generate_macros_for_object):
(generate_defines_for_object):
(generate_section_for_code_table_macro):
(generate_section_for_code_name_macro):

  • Scripts/builtins/builtins_generate_combined_implementation.py: Added.

(BuiltinsCombinedImplementationGenerator):
(BuiltinsCombinedImplementationGenerator.init):
(BuiltinsCombinedImplementationGenerator.output_filename):
(BuiltinsCombinedImplementationGenerator.generate_output):
(BuiltinsCombinedImplementationGenerator.generate_header_includes):

  • Scripts/builtins/builtins_generate_separate_header.py: Added.

(BuiltinsSeparateHeaderGenerator):
(BuiltinsSeparateHeaderGenerator.init):
(BuiltinsSeparateHeaderGenerator.output_filename):
(BuiltinsSeparateHeaderGenerator.macro_prefix):
(BuiltinsSeparateHeaderGenerator.generate_output):
(BuiltinsSeparateHeaderGenerator.generate_forward_declarations):
(FunctionExecutable):
(generate_header_includes):
(generate_section_for_object):
(generate_externs_for_object):
(generate_macros_for_object):
(generate_defines_for_object):
(generate_section_for_code_table_macro):
(generate_section_for_code_name_macro):

  • Scripts/builtins/builtins_generate_separate_implementation.py: Added.

(BuiltinsSeparateImplementationGenerator):
(BuiltinsSeparateImplementationGenerator.init):
(BuiltinsSeparateImplementationGenerator.output_filename):
(BuiltinsSeparateImplementationGenerator.macro_prefix):
(BuiltinsSeparateImplementationGenerator.generate_output):
(BuiltinsSeparateImplementationGenerator.generate_header_includes):

  • Scripts/builtins/builtins_generate_separate_wrapper.py: Added.

(BuiltinsSeparateWrapperGenerator):
(BuiltinsSeparateWrapperGenerator.init):
(BuiltinsSeparateWrapperGenerator.output_filename):
(BuiltinsSeparateWrapperGenerator.macro_prefix):
(BuiltinsSeparateWrapperGenerator.generate_output):
(BuiltinsSeparateWrapperGenerator.generate_header_includes):

  • Scripts/generate-js-builtins.py: Added.

Parse command line options, decide which generators and output modes to use.

(generate_bindings_for_builtins_files):

  • Scripts/lazywriter.py: Copied from the inspector protocol generator.

(LazyFileWriter):
(LazyFileWriter.init):
(LazyFileWriter.write):
(LazyFileWriter.close):

  • Scripts/tests/builtins/JavaScriptCore-Builtin.Promise-Combined.js: Added.
  • Scripts/tests/builtins/JavaScriptCore-Builtin.Promise-Separate.js: Added.
  • Scripts/tests/builtins/JavaScriptCore-Builtin.prototype-Combined.js: Added.
  • Scripts/tests/builtins/JavaScriptCore-Builtin.prototype-Separate.js: Added.
  • Scripts/tests/builtins/JavaScriptCore-BuiltinConstructor-Combined.js: Added.
  • Scripts/tests/builtins/JavaScriptCore-BuiltinConstructor-Separate.js: Added.
  • Scripts/tests/builtins/WebCore-GuardedBuiltin-Separate.js: Added.
  • Scripts/tests/builtins/WebCore-GuardedInternalBuiltin-Separate.js: Added.
  • Scripts/tests/builtins/WebCore-UnguardedBuiltin-Separate.js: Added.
  • Scripts/tests/builtins/WebCore-xmlCasingTest-Separate.js: Added.
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Combined.js-result: Added.
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Separate.js-result: Added.
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Combined.js-result: Added.
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Separate.js-result: Added.
  • Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Combined.js-result: Added.
  • Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Separate.js-result: Added.
  • Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result: Added.
  • Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result: Added.
  • Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result: Added.
  • Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result: Added.
  • builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::BuiltinExecutables):

  • builtins/BuiltinExecutables.h:
  • create_hash_table:

Update the generated builtin macro names.

  • generate-js-builtins: Removed.

Source/WebCore:

  • CMakeLists.txt:

Define JavaScriptCore_SCRIPTS_DIR explicitly so the add_custom_command and
shared file lists are identical between JavaScriptCore and WebCore.

The output files additionally depend on all builtin generator script files.

  • DerivedSources.make:

Use JavaScriptCore_SCRIPTS_DIR so that the rule for code generation and
shared file lists are identical between JavaScriptCore and WebCore.

The output files additionally depend on all builtin generator script files.

  • WebCore.xcodeproj/project.pbxproj:

Define JavaScriptCore_SCRIPTS_DIR before calling DerivedSources.make.
This will eventually be merged with the other similar script paths.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::finishCreation):

Update the generated builtin macro names.

  • generate-js-builtins: Removed.

Tools:

Add a stub shell script and basic webkitpy support for running builtins
generator tests.

  • Scripts/run-builtins-generator-tests: Added.

(main):

  • Scripts/webkitpy/codegen/init.py: Added.
  • Scripts/webkitpy/codegen/main.py: Added.

The only interesting difference here from the inspector protocol
generator equivalent is that this implementation decodes the target
framework and output mode (combined or separate) from the test's file name.

(BuiltinsGeneratorTests):
(BuiltinsGeneratorTests.init):
(BuiltinsGeneratorTests.generate_from_js_builtins):
(BuiltinsGeneratorTests.write_error_file):
(BuiltinsGeneratorTests.detect_changes):
(BuiltinsGeneratorTests.run_tests):
(BuiltinsGeneratorTests.main):

8:17 PM Changeset in webkit [191432] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Recommit r191428.

I don't think it was supposed to be reverted in r191429, and it really does fix the build.

  • loader/EmptyClients.h:

(WebCore::EmptyContextMenuClient::~EmptyContextMenuClient):
Remove customizeMenu again.

7:55 PM Changeset in webkit [191431] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Adding http/tests/media/video-load-suspend.html to the list of flaky media tests
​https://bugs.webkit.org/show_bug.cgi?id=150408

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-21
Reviewed by Alexey Proskuryakov.

  • platform/mac/TestExpectations:
7:49 PM Changeset in webkit [191430] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Marking imported/blink/fast/overflow/hidden-html-auto-body.html as flaky
​https://bugs.webkit.org/show_bug.cgi?id=150419

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-21
Reviewed by Alexey Proskuryakov.

  • platform/mac-wk2/TestExpectations:
7:27 PM Changeset in webkit [191429] by Gyuyoung Kim
  • 12 edits in trunk/Source

[EFL][GTK][WK2] Fix build break since r191402, r191401
​https://bugs.webkit.org/show_bug.cgi?id=150432

Unreviewed EFL and GTK build fix.

Source/WebCore:

  • loader/EmptyClients.h:

Source/WebKit2:

  • CMakeLists.txt:
  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::createContextMenuProxy):

  • UIProcess/CoordinatedGraphics/WebView.h:
  • UIProcess/efl/WebContextMenuProxyEfl.cpp:

(WebKit::WebContextMenuProxyEfl::show):

  • UIProcess/efl/WebContextMenuProxyEfl.h:

(WebKit::WebContextMenuProxyEfl::create): Deleted.

  • UIProcess/efl/WebViewEfl.cpp:

(WebKit::WebViewEfl::createContextMenuProxy):

  • UIProcess/efl/WebViewEfl.h:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::customizeMenu):

  • WebProcess/WebCoreSupport/WebContextMenuClient.h:
7:18 PM Changeset in webkit [191428] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix after r191422.

  • page/ContextMenuClient.h:

(WebCore::ContextMenuClient::~ContextMenuClient):
Completely remove customizeMenu.

7:02 PM Changeset in webkit [191427] by Gyuyoung Kim
  • 2 edits in trunk/Source/WebCore

Remove unnecessary default quota setting in DatabaseContext::databaseExceededQuota
​https://bugs.webkit.org/show_bug.cgi?id=150356

Reviewed by Darin Adler.

All ports have supported DatabaseContext::databaseExceededQuota(). Thus we don't need to
keep a test code to extend database quota anymore.

  • Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::databaseExceededQuota): Deleted.

6:58 PM Changeset in webkit [191426] by benjamin@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

[JSC] Remove FTL Native Inlining, it is dead code
​https://bugs.webkit.org/show_bug.cgi?id=150429

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-10-21
Reviewed by Filip Pizlo.

The code is not used and it is in the way of other changes.

  • ftl/FTLAbbreviations.h:

(JSC::FTL::getFirstInstruction): Deleted.
(JSC::FTL::getNextInstruction): Deleted.
(JSC::FTL::getFirstBasicBlock): Deleted.
(JSC::FTL::getNextBasicBlock): Deleted.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::isInlinableSize): Deleted.

  • runtime/Options.h:
6:57 PM Changeset in webkit [191425] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Remove two useless temporaries from the PutByOffset codegen
​https://bugs.webkit.org/show_bug.cgi?id=150421

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-10-21
Reviewed by Geoffrey Garen.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Deleted.
Looks like they were added by accident in r160796.

6:46 PM Changeset in webkit [191424] by fpizlo@apple.com
  • 11 edits
    1 add
    1 delete in trunk/Source

Factor out the graph node worklists from DFG into WTF
​https://bugs.webkit.org/show_bug.cgi?id=150411

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Rewrite the DFGBlockWorklist.h file as a bunch of typedefs and aliases for things in
wtf/GraphNodeWorklist.h. Most users won't notice, except that some small things got
renamed. For example PreOrder becomes VisitOrder::Pre and item.block becomes item.node.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGBlockWorklist.cpp: Removed.
  • dfg/DFGBlockWorklist.h:

(JSC::DFG::BlockWorklist::notEmpty): Deleted.
(JSC::DFG::BlockWith::BlockWith): Deleted.
(JSC::DFG::BlockWith::operator bool): Deleted.
(JSC::DFG::ExtendedBlockWorklist::ExtendedBlockWorklist): Deleted.
(JSC::DFG::ExtendedBlockWorklist::forcePush): Deleted.
(JSC::DFG::ExtendedBlockWorklist::push): Deleted.
(JSC::DFG::ExtendedBlockWorklist::notEmpty): Deleted.
(JSC::DFG::ExtendedBlockWorklist::pop): Deleted.
(JSC::DFG::BlockWithOrder::BlockWithOrder): Deleted.
(JSC::DFG::BlockWithOrder::operator bool): Deleted.
(JSC::DFG::PostOrderBlockWorklist::push): Deleted.
(JSC::DFG::PostOrderBlockWorklist::notEmpty): Deleted.

  • dfg/DFGDominators.cpp:

(JSC::DFG::Dominators::compute):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::blocksInPostOrder):

  • dfg/DFGPrePostNumbering.cpp:

(JSC::DFG::PrePostNumbering::compute):

Source/WTF:

The new GraphNodeWorklist.h file is basically just the functionality from the old
DFGBlockWorklist.h, but templatized to work for any graph node type and any kind of graph
node set.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/GraphNodeWorklist.h: Added.

(WTF::GraphNodeWorklist::push):
(WTF::GraphNodeWorklist::notEmpty):
(WTF::GraphNodeWorklist::pop):
(WTF::GraphNodeWith::GraphNodeWith):
(WTF::GraphNodeWith::operator bool):
(WTF::ExtendedGraphNodeWorklist::ExtendedGraphNodeWorklist):
(WTF::ExtendedGraphNodeWorklist::forcePush):
(WTF::ExtendedGraphNodeWorklist::push):
(WTF::ExtendedGraphNodeWorklist::notEmpty):
(WTF::ExtendedGraphNodeWorklist::pop):
(WTF::GraphNodeWithOrder::GraphNodeWithOrder):
(WTF::GraphNodeWithOrder::operator bool):
(WTF::PostOrderGraphNodeWorklist::PostOrderGraphNodeWorklist):
(WTF::PostOrderGraphNodeWorklist::~PostOrderGraphNodeWorklist):
(WTF::PostOrderGraphNodeWorklist::pushPre):
(WTF::PostOrderGraphNodeWorklist::pushPost):
(WTF::PostOrderGraphNodeWorklist::push):
(WTF::PostOrderGraphNodeWorklist::notEmpty):
(WTF::PostOrderGraphNodeWorklist::pop):

  • wtf/HashTable.h:

(WTF::HashTableAddResult::HashTableAddResult):
(WTF::HashTableAddResult::operator bool):

5:58 PM Changeset in webkit [191423] by Chris Dumez
  • 40 edits
    24 deletes in trunk

Un-expose obsolete HTMLBaseFontElement
​https://bugs.webkit.org/show_bug.cgi?id=150397

Reviewed by Anders Carlsson.

LayoutTests/imported/w3c:

Rebaseline a couple of W3C HTML tests now that more checks are passing.

  • web-platform-tests/html/dom/interfaces-expected.txt:
  • web-platform-tests/html/semantics/interfaces-expected.txt:

Source/WebCore:

Un-expose obsolete HTMLBaseFontElement:

This means that we no longer expose HTMLBaseFontElement on the global
Window object. Firefox and Chrome do not expose it either.

Also, document.createElement("basefont") now returns an HTMLUnknownElement
as per the specification. Firefox and Chrome return a generic HTMLElement
instead but I don't think this is a big compatibility risk.

No new tests, already covered by existing tests.

  • html/HTMLBaseFontElement.cpp:

(WebCore::HTMLBaseFontElement::HTMLBaseFontElement):

  • html/HTMLBaseFontElement.h:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLTagNames.in:

LayoutTests:

Update existing layout tests to stop expecting HTMLBaseFontElement to
be exposed.

  • dom/html/level2/html/HTMLBaseFontElement01-expected.txt: Removed.
  • dom/html/level2/html/HTMLBaseFontElement01.html: Removed.
  • dom/html/level2/html/HTMLBaseFontElement01.js: Removed.
  • dom/html/level2/html/HTMLBaseFontElement02-expected.txt: Removed.
  • dom/html/level2/html/HTMLBaseFontElement02.html: Removed.
  • dom/html/level2/html/HTMLBaseFontElement02.js: Removed.
  • dom/html/level2/html/HTMLBaseFontElement03-expected.txt: Removed.
  • dom/html/level2/html/HTMLBaseFontElement03.html: Removed.
  • dom/html/level2/html/HTMLBaseFontElement03.js: Removed.
  • dom/html/level2/html/basefont01-expected.txt: Removed.
  • dom/html/level2/html/basefont01.html: Removed.
  • dom/html/level2/html/basefont01.js: Removed.
  • dom/xhtml/level2/html/HTMLBaseFontElement01-expected.txt: Removed.
  • dom/xhtml/level2/html/HTMLBaseFontElement01.js: Removed.
  • dom/xhtml/level2/html/HTMLBaseFontElement01.xhtml: Removed.
  • dom/xhtml/level2/html/HTMLBaseFontElement02-expected.txt: Removed.
  • dom/xhtml/level2/html/HTMLBaseFontElement02.js: Removed.
  • dom/xhtml/level2/html/HTMLBaseFontElement02.xhtml: Removed.
  • dom/xhtml/level2/html/HTMLBaseFontElement03-expected.txt: Removed.
  • dom/xhtml/level2/html/HTMLBaseFontElement03.js: Removed.
  • dom/xhtml/level2/html/HTMLBaseFontElement03.xhtml: Removed.
  • dom/xhtml/level2/html/basefont01-expected.txt: Removed.
  • dom/xhtml/level2/html/basefont01.js: Removed.
  • dom/xhtml/level2/html/basefont01.xhtml: Removed.

Drop Legacy W3C DOM level 2 basefont tests.

  • fast/dom/Window/element-constructors-on-window-expected.txt:
  • fast/dom/Window/element-constructors-on-window.html:
  • fast/dom/Window/get-set-properties-expected.txt:
  • fast/dom/Window/get-set-properties.html:
  • fast/dom/Window/resources/window-properties.js:
  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
  • fast/dom/element-attribute-js-null-expected.txt:
  • fast/dom/element-attribute-js-null.html:
  • fast/dom/html-attribute-types-expected.txt:
  • fast/dom/html-attribute-types.html:
  • fast/dom/wrapper-classes-expected.txt:
  • fast/dom/wrapper-classes.html:
  • js/dom/global-constructors-attributes-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-expected.txt:
  • platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt:
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/win/js/dom/global-constructors-attributes-expected.txt:
5:50 PM Changeset in webkit [191422] by andersca@apple.com
  • 10 edits in trunk/Source

Get rid of WebContextMenuClient::customizeMenu, it's no longer used
​https://bugs.webkit.org/show_bug.cgi?id=150427

Reviewed by Tim Horton.
Source/WebCore:

  • loader/EmptyClients.cpp:

(WebCore::EmptyContextMenuClient::customizeMenu): Deleted.

  • loader/EmptyClients.h:
  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::showContextMenu):

Source/WebKit/win:

  • WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::customizeMenu): Deleted.

  • WebCoreSupport/WebContextMenuClient.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::customizeMenu): Deleted.

  • WebProcess/WebCoreSupport/WebContextMenuClient.h:
5:50 PM Changeset in webkit [191421] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: srcset attributes should have hyperlinks to the resources
​https://bugs.webkit.org/show_bug.cgi?id=150409

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-21
Reviewed by Timothy Hatcher.

The "srcset" attribute parsing is a simplification of:
​https://html.spec.whatwg.org/multipage/embedded-content.html#attr-img-srcset

The "srcset" attribute value is expected to be in comma
separated groups. Within each group we always expect a link,
and an optional descriptor. We want to linkify the link.

  • UserInterface/Views/CodeMirrorAdditions.js:

(tokenizeSrcSetString):
(extendedXMLToken):
When parsing srcset attribute, parse links as link tokens
so that they are linkified in resource content views.

  • UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype._buildAttributeDOM):
When creating the DOMTree DOM for srcset attributes,
create link elements for the link values of attribute value.

5:46 PM Changeset in webkit [191420] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Remove dead MHTML code
​https://bugs.webkit.org/show_bug.cgi?id=150426

Reviewed by Tim Horton.

  • loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::generateMHTMLData):
(WebCore::MHTMLArchive::generateMHTMLDataUsingBinaryEncoding): Deleted.

  • loader/archive/mhtml/MHTMLArchive.h:
5:31 PM Changeset in webkit [191419] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Autocompletion previews in the CSS sidebar do not apply
​https://bugs.webkit.org/show_bug.cgi?id=147720

Patch by Devin Rousso <Devin Rousso> on 2015-10-21
Reviewed by Timothy Hatcher.

When autocompletion hints are added to styles or the console, the history
object used by CodeMirror was edited to remove the last entry. Instead of
using this method (which caused glitchy behaviour when undo-ing), call
CodeMirror.undo() and adjust accordingly. In addition, a marker was being
used as the completion hint instead of applying text, whereas these
changes use actual text, ensuring that completions are previewed in the page.

  • UserInterface/Controllers/CodeMirrorCompletionController.js:

(WebInspector.CodeMirrorCompletionController):
(WebInspector.CodeMirrorCompletionController.prototype.close):
(WebInspector.CodeMirrorCompletionController.prototype._applyCompletionHint.update):
(WebInspector.CodeMirrorCompletionController.prototype._commitCompletionHint.update):
(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.update):
(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint):
(WebInspector.CodeMirrorCompletionController.prototype._handleBeforeChange):
(WebInspector.CodeMirrorCompletionController.prototype._createCompletionHintMarker): Deleted.
(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.clearMarker): Deleted.

5:29 PM Changeset in webkit [191418] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Add forgotten WebInspector.UIString from r190521
​https://bugs.webkit.org/show_bug.cgi?id=150425

Patch by Devin Rousso <Devin Rousso> on 2015-10-21
Reviewed by Timothy Hatcher.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(UserInterface/Views/CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded)

5:26 PM Changeset in webkit [191417] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Adjust usages of classList.toggle to ensure a true/false value instead of undefined
​https://bugs.webkit.org/show_bug.cgi?id=150424

Patch by Devin Rousso <Devin Rousso> on 2015-10-21
Reviewed by Timothy Hatcher.

Adds "!!" in front of force parameters in classList.toggle calls that
could possibly be undefined (thereby breaking the UI).

  • UserInterface/Views/ScopeBarItem.js:

(WebInspector.ScopeBarItem):

  • UserInterface/Views/VisualStyleDetailsPanel.js:

(WebInspector.VisualStyleDetailsPanel.prototype._updateSections):

  • UserInterface/Views/VisualStylePropertyEditor.js:

(WebInspector.VisualStylePropertyEditor):

5:13 PM Changeset in webkit [191416] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Option-Up doesn't increment certain attribute values
​https://bugs.webkit.org/show_bug.cgi?id=149257

Patch by Devin Rousso <Devin Rousso> on 2015-10-21
Reviewed by Brian Burg.

If the user tries to modify a numerical attribute in HTML and the cursor
was at the beginning of the attribute value, the range of the selection
was within a sibling element instead of the text node containin the value.
This patch fixes this issue and ensures that the correct text is selected.

  • UserInterface/Views/EditingSupport.js:

(WebInspector.startEditing.handleEditingResult):
Replaced var with let.

5:07 PM Changeset in webkit [191415] by timothy_horton@apple.com
  • 5 edits
    1 add
    2 deletes in trunk/Source/WebKit2

API-ify the FindMatches client
​https://bugs.webkit.org/show_bug.cgi?id=150422

Reviewed by Anders Carlsson.

  • UIProcess/API/APIFindMatchesClient.h: Renamed from Source/WebKit2/UIProcess/WebFindClient.h.

(API::FindMatchesClient::~FindMatchesClient):
(API::FindMatchesClient::didFindStringMatches):
(API::FindMatchesClient::didGetImageForMatchResult):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageFindMatchesClient):

  • UIProcess/WebFindClient.cpp: Removed.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setFindMatchesClient):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::didGetImageForFindMatch):
(WebKit::WebPageProxy::didFindStringMatches):
(WebKit::WebPageProxy::initializeFindMatchesClient): Deleted.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::findMatchesClient):

  • WebKit2.xcodeproj/project.pbxproj:
5:02 PM Changeset in webkit [191414] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

WebProcess crashes when accessibility bundle is not found.
​https://bugs.webkit.org/show_bug.cgi?id=150414

Reviewed by Dan Bernstein.

The uninitialized pointer to NSError causes the print function to crash.

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::registerWithAccessibility):

4:54 PM Changeset in webkit [191413] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit/win

Simplify context menu handling on Windows
​https://bugs.webkit.org/show_bug.cgi?id=150423

Reviewed by Tim Horton.

Instead of converting a ContextMenu to a HMENU, then back to a ContextMenu, and then back to a HMENU again
just convert it once right before showing it and let the UIDelegate return a new menu at at time where we don't
have to convert it back.

  • WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::customizeMenu):

  • WebView.cpp:

(WebView::createContextMenu):
(WebView::handleContextMenuEvent):

  • WebView.h:
4:14 PM Changeset in webkit [191412] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Move services menu handling out into a separate function
​https://bugs.webkit.org/show_bug.cgi?id=150420

Reviewed by Tim Horton.

  • UIProcess/mac/WebContextMenuProxyMac.h:
  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::showServicesMenu):
(WebKit::WebContextMenuProxyMac::show):
(WebKit::WebContextMenuProxyMac::showContextMenu):
(WebKit::WebContextMenuProxyMac::populate): Deleted.

4:10 PM Changeset in webkit [191411] by bshafiei@apple.com
  • 13 edits
    3 deletes in tags/Safari-602.1.8

Roll out r191360. rdar://problem/23205990

4:05 PM Changeset in webkit [191410] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

run-webkit-tests does not copy all crash logs for layout test failures on Mac
​https://bugs.webkit.org/show_bug.cgi?id=150407
<rdar://problem/22239750>

Patch by Aakash Jain <​aakash_jain@apple.com> on 2015-10-21
Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/port/mac.py:

(MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
(MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
the log directory.
(MacPort.look_for_new_crash_logs): Uses above method to get crash logs
from log directory and merge them with the list of already crashed tests.

3:30 PM Changeset in webkit [191409] by Wenson Hsieh
  • 3 edits in trunk/Source/WebKit2

Single tapping clickable elements in unscalable pages should show a tap highlight
​https://bugs.webkit.org/show_bug.cgi?id=150382

Reviewed by Simon Fraser.

When the double tap gesture recognizer is disabled ahead of time (as in the case of unscalable pages) the tap is
committed before the geometries come in. To fix this, we introduce a flag that allows the single tap to be
committed before the tap highlight arrives. This allows the tap highlight to be immediately animated when receiving
the tap highlight geometries only in the case where double tapping is disabled when recognizing the single tap.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]):
(-[WKContentView _singleTapRecognized:]):
(-[WKContentView _singleTapCommited:]):

3:30 PM Changeset in webkit [191408] by andersca@apple.com
  • 10 edits in trunk/Source/WebKit2

Get rid of useBinaryEncoding from WKPageGetContentsAsMHTMLData
​https://bugs.webkit.org/show_bug.cgi?id=150417

Reviewed by Tim Horton.

The useBinaryEncoding parameter is always false, so just get rid of it.

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetContentsAsMHTMLData):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_page_contents_get):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_save):
(webkit_web_view_save_to_file):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getContentsAsMHTMLData):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getContentsAsMHTMLData):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
3:17 PM Changeset in webkit [191407] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

WebContextMenuProxyMac::setupServicesMenu doesn't need to take a context parameter
​https://bugs.webkit.org/show_bug.cgi?id=150418

Reviewed by Tim Horton.

  • UIProcess/mac/WebContextMenuProxyMac.h:
  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::setupServicesMenu):
(WebKit::WebContextMenuProxyMac::populate):

3:14 PM Changeset in webkit [191406] by Sukolsak Sakshuwong
  • 10 edits in trunk

[INTL] Implement Intl.Collator.prototype.resolvedOptions ()
​https://bugs.webkit.org/show_bug.cgi?id=147601

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

This patch implements Intl.Collator.prototype.resolvedOptions() according
to the ECMAScript 2015 Internationalization API spec (ECMA-402 2nd edition.)
It also implements the abstract operations InitializeCollator, ResolveLocale,
LookupMatcher, and BestFitMatcher.

  • runtime/CommonIdentifiers.h:
  • runtime/IntlCollator.h:

(JSC::IntlCollator::usage):
(JSC::IntlCollator::setUsage):
(JSC::IntlCollator::locale):
(JSC::IntlCollator::setLocale):
(JSC::IntlCollator::collation):
(JSC::IntlCollator::setCollation):
(JSC::IntlCollator::numeric):
(JSC::IntlCollator::setNumeric):
(JSC::IntlCollator::sensitivity):
(JSC::IntlCollator::setSensitivity):
(JSC::IntlCollator::ignorePunctuation):
(JSC::IntlCollator::setIgnorePunctuation):

  • runtime/IntlCollatorConstructor.cpp:

(JSC::sortLocaleData):
(JSC::searchLocaleData):
(JSC::initializeCollator):
(JSC::constructIntlCollator):
(JSC::callIntlCollator):

  • runtime/IntlCollatorPrototype.cpp:

(JSC::IntlCollatorPrototypeFuncResolvedOptions):

  • runtime/IntlObject.cpp:

(JSC::defaultLocale):
(JSC::getIntlBooleanOption):
(JSC::getIntlStringOption):
(JSC::removeUnicodeLocaleExtension):
(JSC::lookupMatcher):
(JSC::bestFitMatcher):
(JSC::resolveLocale):
(JSC::lookupSupportedLocales):

  • runtime/IntlObject.h:

LayoutTests:

  • js/intl-collator-expected.txt:
  • js/script-tests/intl-collator.js:

(testCollator):

3:08 PM Changeset in webkit [191405] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.8

New tag.

2:49 PM Changeset in webkit [191404] by sbarati@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

C calls in PolymorphicAccess shouldn't assume that the top of the stack looks like a JSC JIT frame and enable *ByIdFlush in FTL
​https://bugs.webkit.org/show_bug.cgi?id=125711

Reviewed by Filip Pizlo.

This patch ensures that anytime we need to make a C call inside
PolymorphicAccess, we ensure there is enough space on the stack to do so.

This patch also enables GetByIdFlush/PutByIdFlush inside the FTL.
Because PolymorphicAccess now spills the necessary registers
before making a JS/C call, any registers that LLVM report as
being in use for the patchpoint will be spilled before making
a call by PolymorphicAccess.

  • bytecode/PolymorphicAccess.cpp:

(JSC::AccessGenerationState::restoreScratch):
(JSC::AccessGenerationState::succeed):
(JSC::AccessGenerationState::calculateLiveRegistersForCallAndExceptionHandling):
(JSC::AccessCase::generate):
(JSC::PolymorphicAccess::regenerate):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileNode):
(JSC::FTL::DFG::LowerDFGToLLVM::compileGetById):
(JSC::FTL::DFG::LowerDFGToLLVM::emitStoreBarrier):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitTypeOf):
(JSC::AssemblyHelpers::makeSpaceOnStackForCCall):
(JSC::AssemblyHelpers::reclaimSpaceOnStackForCCall):

  • jit/RegisterSet.cpp:

(JSC::RegisterSet::webAssemblyCalleeSaveRegisters):
(JSC::RegisterSet::registersToNotSaveForJSCall):
(JSC::RegisterSet::registersToNotSaveForCCall):
(JSC::RegisterSet::allGPRs):
(JSC::RegisterSet::registersToNotSaveForCall): Deleted.

  • jit/RegisterSet.h:

(JSC::RegisterSet::set):

  • jit/ScratchRegisterAllocator.cpp:

(JSC::ScratchRegisterAllocator::allocateScratchGPR):
(JSC::ScratchRegisterAllocator::allocateScratchFPR):
(JSC::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
These methods now take an extra parameter indicating if they
should create space for a C call at the top of the stack if
there are any reused registers to spill.

(JSC::ScratchRegisterAllocator::usedRegistersForCall):

  • jit/ScratchRegisterAllocator.h:

(JSC::ScratchRegisterAllocator::usedRegisters):

2:45 PM Changeset in webkit [191403] by dino@apple.com
  • 4 edits
    2 adds in trunk

Null dereference loading Blink layout test svg/filters/display-none-filter-primitive.html
​https://bugs.webkit.org/show_bug.cgi?id=150212
<rdar://problem/23137376>

Reviewed by Brent Fulgham.

Source/WebCore:

Handle the case where a filter element doesn't have a renderer. Inspired by the Blink
commit:
​https://chromium.googlesource.com/chromium/src.git/+/fb79f7fc46552d45127acd2959a23662ad8f271e

Test: svg/filters/display-none-filter-primitive.html

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives):

  • svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::appendEffectToEffectReferences):

LayoutTests:

  • svg/filters/display-none-filter-primitive-expected.txt: Added.
  • svg/filters/display-none-filter-primitive.html: Added.
2:26 PM Changeset in webkit [191402] by andersca@apple.com
  • 11 edits in trunk/Source/WebKit2

WebContextMenuProxy doesn't have to be ref-counted
​https://bugs.webkit.org/show_bug.cgi?id=150415

Reviewed by Tim Horton.

Change WebContextMenuProxy to not inherit from RefCounted. Instead of using RefPtr, use std::unique_ptr.
Get rid of cancelTracking and hideContextMenu and dismiss the menu whenever the menu proxy is destroyed.
Also, rename showContextMenu to show.

  • UIProcess/PageClient.h:
  • UIProcess/WebContextMenuProxy.h:

(WebKit::WebContextMenuProxy::cancelTracking): Deleted.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::internalShowContextMenu):

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::createContextMenuProxy):

  • UIProcess/mac/PageClientImpl.h:
  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createContextMenuProxy):

  • UIProcess/mac/WebContextMenuProxyMac.h:

(WebKit::WebContextMenuProxyMac::create): Deleted.

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::~WebContextMenuProxyMac):
(WebKit::WebContextMenuProxyMac::show):
(WebKit::WebContextMenuProxyMac::showContextMenu): Deleted.
(WebKit::WebContextMenuProxyMac::hideContextMenu): Deleted.
(WebKit::WebContextMenuProxyMac::cancelTracking): Deleted.

2:04 PM Changeset in webkit [191401] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Stop using a popup menu button cell(!) for context menus
​https://bugs.webkit.org/show_bug.cgi?id=150413

Reviewed by Tim Horton.

Just use a regular NSMenu. Also, have the service menu code path store the service menu
in the same member variable.

  • UIProcess/mac/WebContextMenuProxyMac.h:
  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::setupServicesMenu):
(WebKit::WebContextMenuProxyMac::clearServicesMenu):
(WebKit::WebContextMenuProxyMac::populate):
(WebKit::WebContextMenuProxyMac::showContextMenu):
(WebKit::WebContextMenuProxyMac::hideContextMenu):
(WebKit::WebContextMenuProxyMac::cancelTracking):
(WebKit::WebContextMenuProxyMac::~WebContextMenuProxyMac): Deleted.

1:22 PM Changeset in webkit [191400] by beidson@apple.com
  • 30 edits
    2 copies
    4 adds in trunk

Modern IDB: Add basic transaction aborting.
​https://bugs.webkit.org/show_bug.cgi?id=150148

Reviewed by Alex Christensen.

Source/WebCore:

Tests: storage/indexeddb/modern/double-abort.html

storage/indexeddb/modern/versionchange-abort-then-reopen.html

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • Modules/indexeddb/IndexedDB.h:
  • Modules/indexeddb/client/IDBConnectionToServer.cpp:

(WebCore::IDBClient::IDBConnectionToServer::abortTransaction):
(WebCore::IDBClient::IDBConnectionToServer::didAbortTransaction):

  • Modules/indexeddb/client/IDBConnectionToServer.h:
  • Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
  • Modules/indexeddb/client/IDBDatabaseImpl.cpp:

(WebCore::IDBClient::IDBDatabase::abortTransaction):
(WebCore::IDBClient::IDBDatabase::didCommitOrAbortTransaction):

  • Modules/indexeddb/client/IDBDatabaseImpl.h:
  • Modules/indexeddb/client/IDBTransactionImpl.cpp:

(WebCore::IDBClient::IDBTransaction::IDBTransaction):
(WebCore::IDBClient::IDBTransaction::abort):
(WebCore::IDBClient::IDBTransaction::isFinishedOrFinishing):
(WebCore::IDBClient::IDBTransaction::activationTimerFired):
(WebCore::IDBClient::IDBTransaction::didAbort):

  • Modules/indexeddb/client/IDBTransactionImpl.h:
  • Modules/indexeddb/server/IDBBackingStore.h:
  • Modules/indexeddb/server/IDBConnectionToClient.cpp:

(WebCore::IDBServer::IDBConnectionToClient::didAbortTransaction):

  • Modules/indexeddb/server/IDBConnectionToClient.h:
  • Modules/indexeddb/server/IDBConnectionToClientDelegate.h:
  • Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::abortTransaction):

  • Modules/indexeddb/server/IDBServer.h:
  • Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:

(WebCore::IDBServer::MemoryBackingStoreTransaction::create):
(WebCore::IDBServer::MemoryBackingStoreTransaction::MemoryBackingStoreTransaction):
(WebCore::IDBServer::MemoryBackingStoreTransaction::~MemoryBackingStoreTransaction):
(WebCore::IDBServer::MemoryBackingStoreTransaction::abort):
(WebCore::IDBServer::MemoryBackingStoreTransaction::commit):

  • Modules/indexeddb/server/MemoryBackingStoreTransaction.h:

(WebCore::IDBServer::MemoryBackingStoreTransaction::isVersionChange):

  • Modules/indexeddb/server/MemoryIDBBackingStore.cpp:

(WebCore::IDBServer::MemoryIDBBackingStore::setDatabaseInfo):
(WebCore::IDBServer::MemoryIDBBackingStore::beginTransaction):
(WebCore::IDBServer::MemoryIDBBackingStore::abortTransaction):
(WebCore::IDBServer::MemoryIDBBackingStore::commitTransaction):

  • Modules/indexeddb/server/MemoryIDBBackingStore.h:
  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::startVersionChangeTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::beginTransactionInBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::performCommitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformCommitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::performAbortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformAbortTransaction):

  • Modules/indexeddb/server/UniqueIDBDatabase.h:
  • Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:

(WebCore::IDBServer::UniqueIDBDatabaseConnection::didAbortTransaction):

  • Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:
  • Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:

(WebCore::IDBServer::UniqueIDBDatabaseTransaction::UniqueIDBDatabaseTransaction):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::originalDatabaseInfo):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::abort):

  • Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:
  • Modules/indexeddb/shared/IDBError.cpp:

(WebCore::idbErrorName):
(WebCore::idbErrorDescription):

  • Modules/indexeddb/shared/IDBError.h:
  • Modules/indexeddb/shared/InProcessIDBServer.cpp:

(WebCore::InProcessIDBServer::didAbortTransaction):
(WebCore::InProcessIDBServer::abortTransaction):

  • Modules/indexeddb/shared/InProcessIDBServer.h:

LayoutTests:

  • storage/indexeddb/modern/double-abort-expected.txt: Added.
  • storage/indexeddb/modern/double-abort.html: Added.
  • storage/indexeddb/modern/versionchange-abort-then-reopen-expected.txt: Added.
  • storage/indexeddb/modern/versionchange-abort-then-reopen.html: Added.
1:07 PM Changeset in webkit [191399] by commit-queue@webkit.org
  • 10 edits
    1 copy in trunk/Source/WebInspectorUI

Web Inspector: Use some CSS Variables in Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=150405

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-21
Reviewed by Timothy Hatcher.

  • UserInterface/Main.html:

Include the new variables stylesheet.

  • UserInterface/Views/Variables.css: Added.

(:root):
Introduce new global variables.

  • UserInterface/Views/CSSStyleDeclarationTextEditor.css:

(.css-style-text-editor > .CodeMirror .cm-link):

  • UserInterface/Views/ConsoleMessageView.css:

(.console-message-preview-divider):
(.console-message-enclosed):
(.console-message .console-message-extra-parameters-container > li::before):
(.console-saved-variable):

  • UserInterface/Views/DOMTreeOutline.css:

(.dom-tree-outline li.selected > span::after):

  • UserInterface/Views/FormattedValue.css:

(:matches(.formatted-array, .formatted-map, .formatted-set, .formatted-weakmap, .formatted-weakset) > .size):
(.formatted-number):
(.formatted-boolean):
(.formatted-string):
(.formatted-regexp):
(.formatted-symbol):

  • UserInterface/Views/ObjectPreviewView.css:

(.object-preview > .size):

  • UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:

(.object-tree-array-index .index-name):

  • UserInterface/Views/SyntaxHighlightingDefaultTheme.css:

(.syntax-highlighted :matches(.css-keyword, .css-tag, .css-at-rule, .css-important, .javascript-keyword, .html-tag)):
(.syntax-highlighted :matches(.css-number, .javascript-number)):
(.syntax-highlighted :matches(.css-string, .javascript-string, .html-attribute-value)):
(.syntax-highlighted .javascript-regexp):

  • UserInterface/Views/TypeTokenView.css:

(.type-token-symbol):
Make use of variables.

1:04 PM Changeset in webkit [191398] by Chris Dumez
  • 5 edits in trunk

bgsound should use HTMLUnknownElement interface
​https://bugs.webkit.org/show_bug.cgi?id=148857
<rdar://problem/22589036>

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline a couple of W3C HTML tests now that more checks are passing.

  • web-platform-tests/html/dom/interfaces-expected.txt:
  • web-platform-tests/html/semantics/interfaces-expected.txt:

Source/WebCore:

The blink, bgsound, isindex, multicol, nextid, and spacer elements must
use the HTMLUnknownElement interface, as per the HTML specification:
​https://html.spec.whatwg.org/multipage/obsolete.html#other-elements,-attributes-and-apis

WebKit was using HTMLUnknownElement for all of them except bgsound.
This patch fixes the issue and aligns our behavior with Chrome and
Firefox.

No new tests, already covered by existing tests.

  • html/HTMLTagNames.in:
12:56 PM Changeset in webkit [191397] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Web Inspector: Array previews with Symbol objects have too few preview values
​https://bugs.webkit.org/show_bug.cgi?id=150404

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-21
Reviewed by Timothy Hatcher.

  • inspector/InjectedScriptSource.js:

(InjectedScript.RemoteObject.prototype._appendPropertyPreviews):
We should be continuing inside this loop not returning.

11:53 AM Changeset in webkit [191396] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

11:45 AM Changeset in webkit [191395] by fpizlo@apple.com
  • 6 edits in trunk

Failures in PutStackSinkingPhase should be less severe
​https://bugs.webkit.org/show_bug.cgi?id=150400

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Make the PutStackSinkingPhase abort instead of asserting. To test that it's OK to not have
PutStackSinkingPhase run, this adds a test mode where we run without PutStackSinkingPhase.

  • dfg/DFGPlan.cpp: Make it possible to not run PutStackSinkingPhase for tests.

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGPutStackSinkingPhase.cpp: PutStackSinkingPhase should abort instead of asserting, except when validation is enabled.
  • runtime/Options.h: Add an option for disabling PutStackSinkingPhase.

Tools:

Add a test mode for no PutStackSinkingPhase.

  • Scripts/run-jsc-stress-tests:
11:44 AM Changeset in webkit [191394] by sbarati@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

The FTL should place the CallSiteIndex on the call frame for JS calls when it fills in the patchpoint
​https://bugs.webkit.org/show_bug.cgi?id=150104

Reviewed by Filip Pizlo.

We lower JS Calls to patchpoints in LLVM. LLVM may decide to duplicate
these patchpoints (or remove them). We eagerly store the CallSiteIndex on the
call frame when lowering DFG to LLVM. But, because the patchpoint we lower to may
be duplicated, we really don't know the unique CallSiteIndex until we've
actually seen the resulting patchpoints after LLVM has completed its transformations.
To solve this, we now store the unique CallSiteIndex on the call frame header
when generating code to fill into the patchpoint.

  • ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

  • ftl/FTLJSCall.cpp:

(JSC::FTL::JSCall::JSCall):
(JSC::FTL::JSCall::emit):

  • ftl/FTLJSCall.h:

(JSC::FTL::JSCall::stackmapID):

  • ftl/FTLJSCallBase.cpp:

(JSC::FTL::JSCallBase::JSCallBase):
(JSC::FTL::JSCallBase::emit):
(JSC::FTL::JSCallBase::link):

  • ftl/FTLJSCallBase.h:
  • ftl/FTLJSCallVarargs.cpp:

(JSC::FTL::JSCallVarargs::JSCallVarargs):
(JSC::FTL::JSCallVarargs::numSpillSlotsNeeded):
(JSC::FTL::JSCallVarargs::emit):

  • ftl/FTLJSCallVarargs.h:

(JSC::FTL::JSCallVarargs::node):
(JSC::FTL::JSCallVarargs::stackmapID):

  • ftl/FTLJSTailCall.cpp:

(JSC::FTL::JSTailCall::JSTailCall):
(JSC::FTL::m_instructionOffset):
(JSC::FTL::JSTailCall::emit):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToLLVM::callPreflight):
(JSC::FTL::DFG::LowerDFGToLLVM::codeOriginDescriptionOfCallSite):
(JSC::FTL::DFG::LowerDFGToLLVM::callCheck):

11:42 AM Changeset in webkit [191393] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Date creation should share a little code
​https://bugs.webkit.org/show_bug.cgi?id=150399

Reviewed by Filip Pizlo.

I want to fix a bug in this code, but I don't want to fix it in two
different places. (See ​https://bugs.webkit.org/show_bug.cgi?id=150386.)

  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::getOwnPropertySlot):
(JSC::milliseconds): Factored out a shared helper function. If you look
closely, you'll see that one copy of this code previously checked isfinite
while the other checked isnan. isnan returning nan was obviously a no-op,
so I removed it. isfinite, it turns out, is also a no-op -- but less
obviously so, so I kept it for now.

(JSC::constructDate):
(JSC::dateUTC): Use the helper function.

11:29 AM Changeset in webkit [191392] by commit-queue@webkit.org
  • 5 edits
    2 copies
    2 moves in trunk

Support for the SVG onend attribute
​https://bugs.webkit.org/show_bug.cgi?id=150393

Patch by Antoine Quint <Antoine Quint> on 2015-10-21
Reviewed by Dean Jackson.

Source/WebCore:

Add support for the SVG onend attribute to SVG timing and animation elements, which allow the definition
of a JS event listener declaratively for the SVG endEvent event.

Tests: svg/animations/end-event-attribute-expected.svg

svg/animations/end-event-attribute.svg
svg/animations/end-event-syncbase-expected.svg
svg/animations/end-event-syncbase.svg

  • dom/EventNames.h:
  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::parseAttribute):

  • svg/svgattrs.in:

LayoutTests:

Create a new test for the onend attribute and rename the previously-named "end-event-declarative.svg" test to
"end-event-syncbase.svg" since the term "declarative" was a little loose.

  • svg/animations/end-event-attribute-expected.svg: Copied from LayoutTests/svg/animations/end-event-declarative-expected.svg.
  • svg/animations/end-event-attribute.svg: Copied from LayoutTests/svg/animations/end-event-declarative.svg.
  • svg/animations/end-event-syncbase-expected.svg: Renamed from LayoutTests/svg/animations/end-event-declarative-expected.svg.
  • svg/animations/end-event-syncbase.svg: Renamed from LayoutTests/svg/animations/end-event-declarative.svg.
10:46 AM Changeset in webkit [191391] by n_wang@apple.com
  • 9 edits
    2 moves in trunk

AX: Expose table size and cell indexes on iOS
​https://bugs.webkit.org/show_bug.cgi?id=150366

Source/WebCore:

Add support to expose table row/column count and cell indexes on iOS.

Reviewed by Chris Fleizach.

Test: accessibility/aria-table-attributes.html

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper tableParent]):
(-[WebAccessibilityObjectWrapper accessibilityElementForRow:andColumn:]):
(-[WebAccessibilityObjectWrapper accessibilityRowCount]):
(-[WebAccessibilityObjectWrapper accessibilityColumnCount]):
(-[WebAccessibilityObjectWrapper accessibilityARIARowCount]):
(-[WebAccessibilityObjectWrapper accessibilityARIAColumnCount]):
(-[WebAccessibilityObjectWrapper accessibilityARIARowIndex]):
(-[WebAccessibilityObjectWrapper accessibilityARIAColumnIndex]):
(-[WebAccessibilityObjectWrapper accessibilityRowRange]):

Tools:

Reviewed by Chris Fleizach.

  • DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
(AccessibilityUIElement::indexInTable):
(AccessibilityUIElement::numberAttributeValue):

  • WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::indexInTable):

LayoutTests:

Reviewed by Chris Fleizach.

  • accessibility/aria-table-attributes-expected.txt: Added.
  • accessibility/aria-table-attributes.html: Added.
  • accessibility/mac/aria-table-attributes-expected.txt: Removed.
  • accessibility/mac/aria-table-attributes.html: Removed.
  • platform/gtk/TestExpectations:
  • platform/ios-simulator/TestExpectations:
  • platform/win/TestExpectations:
10:12 AM Changeset in webkit [191390] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

Add assertions to NetworkCache::Entry constructor to make sure a key's type is "resource"
​https://bugs.webkit.org/show_bug.cgi?id=150369

Reviewed by Antti Koivisto.

Add assertions to NetworkCache::Entry constructor to make sure a key's
type is "resource" now that the NetworkCache storage supports other
types of entries.

  • NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::Entry):

10:12 AM WebKitNightlyElCapWorkaround edited by timothy@apple.com
(diff)
10:08 AM Changeset in webkit [191389] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

llint: align stack pointer on mips too

[MIPS] LLInt: align stack pointer on MIPS too
​https://bugs.webkit.org/show_bug.cgi?id=150380

Patch by Guillaume Emont <​guijemont@igalia.com> on 2015-10-21
Reviewed by Michael Saboff.

  • llint/LowLevelInterpreter32_64.asm:
10:00 AM Changeset in webkit [191388] by Chris Dumez
  • 7 edits
    2 adds in trunk

HTMLIFrameElement.sandbox should be a DOMSettableTokenList
​https://bugs.webkit.org/show_bug.cgi?id=150377

Reviewed by Ryosuke Niwa.

Source/WebCore:

HTMLIFrameElement.sandbox should be a DOMSettableTokenList as per the
HTML specification:

Chrome and Firefox match the specification but Safari/WebKit was uding
a DOMString.

Test: fast/frames/sandbox-attribute.html

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::sandbox):
(WebCore::HTMLIFrameElement::parseAttribute):

  • html/HTMLIFrameElement.h:
  • html/HTMLIFrameElement.idl:

LayoutTests:

  • fast/frames/sandbox-attribute-expected.txt: Added.
  • fast/frames/sandbox-attribute.html: Added.

Add layout test to check that HTMLIframeElement.sandbox is now a
DOMSettableTokenList.

  • fast/frames/sandboxed-iframe-navigation-allowed-expected.txt:
  • fast/frames/sandboxed-iframe-navigation-allowed.html:

Update test that was using shouldBe() with HTMLIframeElement.sandbox.
shouldBe() does an === check but which now fails before
HTMLIframeElement.sandbox is now a DOMSettableTokenList that can be
stringified, rather than a String.

6:36 AM Changeset in webkit [191387] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Typo in a property name: style.inerhited
​https://bugs.webkit.org/show_bug.cgi?id=150391

Reviewed by Csaba Osztrogonác.

  • UserInterface/Views/RulesStyleDetailsPanel.js:

(WebInspector.RulesStyleDetailsPanel.prototype.refresh):

5:52 AM Changeset in webkit [191386] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

ASSERTION FAILED: markFontData in FontCascade::emphasisMarkHeight
​https://bugs.webkit.org/show_bug.cgi?id=150171

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2015-10-21
Reviewed by Myles C. Maxfield.

It happens with several tests like fast/ruby/text-emphasis.html in
the GTK Debug bot. The tests seem to pass in Release and the rendering
looks correct as well removing the assert. The thing is that
for some reason we can get an empty GlyphData from
FontCascade::getEmphasisMarkGlyphData() when it ends up falling
back to system (FontCascadeFonts::glyphDataForSystemFallback).

  • platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::getEmphasisMarkGlyphData): Return
Optional<GlyphData> instead of returning a boolean and an out
parameter. If we get an invalid GlyphData, Nullopt is
returned. Also use a SurrogatePairAwareTextIterator to handle
surrogate pairs.
(WebCore::FontCascade::emphasisMarkAscent):
(WebCore::FontCascade::emphasisMarkDescent):
(WebCore::FontCascade::emphasisMarkHeight):
(WebCore::FontCascade::drawEmphasisMarks):

  • platform/graphics/FontCascade.h:
  • platform/graphics/GlyphPage.h:

(WebCore::GlyphData::isValid): Return whether the GlyphData is valid.

4:47 AM Changeset in webkit [191385] by svillar@igalia.com
  • 3 edits
    2 adds in trunk

Source/WebCore:
[css-grid] Fix availableLogicalSpace computation with non-zero baseSize flex tracks
​https://bugs.webkit.org/show_bug.cgi?id=150359

Reviewed by Zalan Bujtas.

The availableLogicalSpace computation was incorrect whenever
the flex tracks had a non-zero baseSize before the 1fr unit
size resolution. That happened because when assigning the new
baseSize to the flex track, we were unconditionally
subtracting the whole baseSize to the
availableLogicalSpace. That's correct if the track is a "pure"
flex track, i.e. 2fr, but if the track had a non-zero baseSize
(like minmax(10px, 1fr)) then both the new and the old base
sizes were incorrectly used to compute the
availableLogicalSpace.

We can test the amount of remaining freeSpace by using content
distribution to align and item place on a non-zero baseSize
flex track. The content distribution will be accurate if and
only if the availableLogicalSpace computation is correct.

Test: fast/css-grid-layout/flex-content-distribution.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):

LayoutTests:
[css-grid] Fix freeSpace computation with non-zero baseSize flex tracks
​https://bugs.webkit.org/show_bug.cgi?id=150359

Reviewed by Zalan Bujtas.

  • fast/css-grid-layout/flex-content-distribution-expected.txt: Added.
  • fast/css-grid-layout/flex-content-distribution.html: Added.
1:52 AM Changeset in webkit [191384] by youenn.fablet@crf.canon.fr
  • 2 edits in trunk/LayoutTests

Remove commented lines in TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=150387

Unreviewed.

1:34 AM Changeset in webkit [191383] by calvaris@igalia.com
  • 22 edits
    1 copy in trunk

[Streams API] Construct a writable stream
​https://bugs.webkit.org/show_bug.cgi?id=150360

Reviewed by Darin Adler.

Source/WebCore:

This patch initializes a writable stream according to the spec. To do it we need two internal functions, which
are syncWritableStreamStateWithQueue and errorWritableStream, which are also implemented as a quite direct
translation from the spec.

Current test set suffices, expectations are updated accordingly.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/WebCoreBuiltinNames.h:
  • bindings/js/WebCoreJSBuiltinInternals.h:
  • bindings/js/WebCoreJSBuiltins.cpp:
  • bindings/js/WebCoreJSBuiltins.h: Build infrastructure.
  • Modules/streams/WritableStream.js:

(initializeWritableStream): Function that acts as constructor of WritableStream.

  • Modules/streams/WritableStreamInternals.js:

(syncWritableStreamStateWithQueue):
(errorWritableStream): As per spec.

LayoutTests:

Expectations for the writable stream initialization.

  • streams/reference-implementation/bad-strategies-expected.txt:
  • streams/reference-implementation/bad-underlying-sinks-expected.txt:
  • streams/reference-implementation/brand-checks-expected.txt:
  • streams/reference-implementation/byte-length-queuing-strategy-expected.txt:
  • streams/reference-implementation/count-queuing-strategy-expected.txt:
  • streams/reference-implementation/pipe-through-expected.txt:
  • streams/reference-implementation/pipe-to-expected.txt:
  • streams/reference-implementation/pipe-to-options-expected.txt:
  • streams/reference-implementation/readable-stream-templated-expected.txt:
  • streams/reference-implementation/writable-stream-abort-expected.txt:
  • streams/reference-implementation/writable-stream-expected.txt:
1:18 AM Changeset in webkit [191382] by fred.wang@free.fr
  • 3 edits in trunk/LayoutTests

Unreviewed gardening. Test expectation for use-typo-metrics-1 on Mac and Windows should be "ImageOnlyFailure" not "Failure".

  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
1:08 AM Changeset in webkit [191381] by Carlos Garcia Campos
  • 24 edits in trunk/Source

NetworkProcess: DNS prefetch happens in the Web Process
​https://bugs.webkit.org/show_bug.cgi?id=147824

Reviewed by Chris Dumez.

Source/WebCore:

Use FrameLoaderClient to do the DNS prefetch.

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute):

  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h:
  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::loadLink):

  • page/Chrome.cpp:

(WebCore::Chrome::mouseDidMoveOverElement):

Source/WebKit/mac:

Implement FrameLoaderClient::prefetchDNS().

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

Source/WebKit/win:

Implement FrameLoaderClient::prefetchDNS().

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::prefetchDNS):

  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit2:

DNS prefetch requests started in the WebProcess should be sent to
the network process when it's enabled.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::prefetchDNS): Use NetworkProcess::prefetchDNS().

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in: Add

PrefetchDNS message.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::prefetchDNS): Do the actual DNS prefetch.

  • NetworkProcess/NetworkProcess.h:
  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:

(webkitWebExtensionDidReceiveMessage): Use WebProcess::prefetchDNS().

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::prefetchDNS): Use WebProcess::prefetchDNS().

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::sendTapHighlightForNodeIfNecessary): Use
FrameLoaderClient to do the DNS prefetch.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess): Initialize the DNS prefetched
hosts cleanup hysteresis activity. Clear the cache of DNS
prefetched when hysteresis activity stopped.
(WebKit::WebProcess::prefetchDNS): Send the request to the network
process if it's enabled, otherwise do the actual DNS prefetch.

  • WebProcess/WebProcess.h:
12:53 AM Changeset in webkit [191380] by youenn.fablet@crf.canon.fr
  • 8 edits in trunk

W3C test importer should not import reference files as regular tests
​https://bugs.webkit.org/show_bug.cgi?id=150331

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • resources/ImportExpectations: Removed some Skip expectations as test importer no longer will handle these files as tests, but as reference files.

Tools:

Updated test_parser to return information that a file can be a referencefile or a manual test.
Updated test importer to skip those files.
Updated/Added test parser unit tests accordingly.

Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
to mark these files as Skip, since they are not direct tests.

  • Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.init):
(TestImporter.find_importable_tests):
(TestImporter.import_tests):

  • Scripts/webkitpy/w3c/test_parser.py:

(TestParser.analyze_test):

  • Scripts/webkitpy/w3c/test_parser_unittest.py:

(test_analyze_non_html_file):
(test_reference_test):

LayoutTests:

  • TestExpectations: Adding Skip expectations for web-platform-test resource files (currently commented out as not all are yet imported).
12:44 AM Changeset in webkit [191379] by youenn.fablet@crf.canon.fr
  • 196 edits
    22 copies
    59 adds
    16 deletes in trunk/LayoutTests

Update web-platform-tests tests to the same revision as tools
​https://bugs.webkit.org/show_bug.cgi?id=149656

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Syncing tests with WPT repository.
Some files previously in resources folder are now in not-resources folder.
Updated TestExpectations to skip those files.
web-platform-tests/dom/nodes/resources should be removed for a later patch.

  • web-platform-tests/common/failing-test.html: Removed.
  • web-platform-tests/common/w3c-import.log:
  • web-platform-tests/dom/collections/HTMLCollection-supported-property-names.html:
  • web-platform-tests/dom/collections/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/image-maps/w3c-import.log.
  • web-platform-tests/dom/events/w3c-import.log: Added.
  • web-platform-tests/dom/historical-expected.txt:
  • web-platform-tests/dom/historical.html:
  • web-platform-tests/dom/interfaces-expected.txt:
  • web-platform-tests/dom/interfaces.html:
  • web-platform-tests/dom/lists/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-meter-element/w3c-import.log.
  • web-platform-tests/dom/nodes/DOMImplementation-createDocument-expected.txt:
  • web-platform-tests/dom/nodes/DOMImplementation-createDocument.html:
  • web-platform-tests/dom/nodes/DOMImplementation-createHTMLDocument-expected.txt:
  • web-platform-tests/dom/nodes/DOMImplementation-createHTMLDocument.html:
  • web-platform-tests/dom/nodes/Document-adoptNode.html:
  • web-platform-tests/dom/nodes/Document-characterSet-normalization-expected.txt:
  • web-platform-tests/dom/nodes/Document-characterSet-normalization.html:
  • web-platform-tests/dom/nodes/Document-constructor-expected.txt:
  • web-platform-tests/dom/nodes/Document-constructor.html:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/w3c-import.log: Added.
  • web-platform-tests/dom/nodes/Document-contentType/resources/w3c-import.log: Added.
  • web-platform-tests/dom/nodes/Document-contentType/support/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/disabled-elements/w3c-import.log.
  • web-platform-tests/dom/nodes/Document-createAttribute-expected.txt:
  • web-platform-tests/dom/nodes/Document-createAttribute.html:
  • web-platform-tests/dom/nodes/Document-createElement-namespace-expected.txt:
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_mathml.html: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_mathml.svg: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_mathml.xhtml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_mathml.xml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_svg.html: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_svg.svg: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_svg.xhtml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_svg.xml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_xhtml.html: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/blank.htm.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_xhtml.svg: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/blank.htm.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_xhtml.xhtml: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/blank.htm.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_xhtml.xml: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/blank.htm.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.html: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.svg: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xhtml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/generate.py: Added.

(main):

  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/mathml.html: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/mathml.svg: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/mathml.xhtml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/mathml.xml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/minimal_html.html: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/minimal_html.svg: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/minimal_html.xhtml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/minimal_html.xml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/svg.html: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/svg.svg: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/svg.xhtml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/svg.xml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/w3c-import.log: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml.html: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml.svg: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml.xhtml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml.xml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_changed.html: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_changed.svg: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_changed.xhtml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_changed.xml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_removed.html: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_removed.svg: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_removed.xhtml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_removed.xml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace.html:
  • web-platform-tests/dom/nodes/Document-doctype.html:
  • web-platform-tests/dom/nodes/Document-getElementById.html:
  • web-platform-tests/dom/nodes/Element-matches.html:
  • web-platform-tests/dom/nodes/MutationObserver-characterData-expected.txt:
  • web-platform-tests/dom/nodes/MutationObserver-characterData.html:
  • web-platform-tests/dom/nodes/Node-compareDocumentPosition.html:
  • web-platform-tests/dom/nodes/Node-contains.html:
  • web-platform-tests/dom/nodes/Node-lookupPrefix.xhtml:
  • web-platform-tests/dom/nodes/Node-parentNode-iframe.html: Added.
  • web-platform-tests/dom/nodes/Node-parentNode.html:
  • web-platform-tests/dom/nodes/Node-properties-expected.txt:
  • web-platform-tests/dom/nodes/Node-properties.html:
  • web-platform-tests/dom/nodes/ParentNode-querySelector-All-content.html: Added.
  • web-platform-tests/dom/nodes/ParentNode-querySelector-All-content.xht: Added.
  • web-platform-tests/dom/nodes/ParentNode-querySelector-All.html:
  • web-platform-tests/dom/nodes/getElementsByClassName-14.htm:
  • web-platform-tests/dom/nodes/getElementsByClassName-28.htm:
  • web-platform-tests/dom/nodes/w3c-import.log: Added.
  • web-platform-tests/dom/ranges/w3c-import.log: Added.
  • web-platform-tests/dom/traversal/TreeWalker-acceptNode-filter.html:
  • web-platform-tests/dom/traversal/TreeWalker-basic.html:
  • web-platform-tests/dom/traversal/TreeWalker-currentNode.html:
  • web-platform-tests/dom/traversal/TreeWalker-previousNodeLastChildReject.html:
  • web-platform-tests/dom/traversal/TreeWalker-previousSiblingLastChildSkip.html:
  • web-platform-tests/dom/traversal/TreeWalker-traversal-reject.html:
  • web-platform-tests/dom/traversal/TreeWalker-traversal-skip-most.html:
  • web-platform-tests/dom/traversal/TreeWalker-traversal-skip.html:
  • web-platform-tests/dom/traversal/TreeWalker-walking-outside-a-tree.html:
  • web-platform-tests/dom/traversal/w3c-import.log: Added.
  • web-platform-tests/dom/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/w3c-import.log.
  • web-platform-tests/domparsing/DOMParser-parseFromString-html-expected.txt:
  • web-platform-tests/domparsing/DOMParser-parseFromString-html.html:
  • web-platform-tests/domparsing/w3c-import.log:
  • web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/w3c-import.log: Added.
  • web-platform-tests/html/dom/documents/dom-tree-accessors/w3c-import.log: Added.
  • web-platform-tests/html/dom/documents/resource-metadata-management/document-lastModified-01.html:
  • web-platform-tests/html/dom/documents/resource-metadata-management/w3c-import.log: Added.
  • web-platform-tests/html/dom/dynamic-markup-insertion/closing-the-input-stream/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/disabled-elements/w3c-import.log.
  • web-platform-tests/html/dom/dynamic-markup-insertion/document-write/w3c-import.log: Added.
  • web-platform-tests/html/dom/dynamic-markup-insertion/document-writeln/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/w3c-import.log.
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010-1.html: Added.
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010-2.html: Added.
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010.html: Added.
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/w3c-import.log: Added.
  • web-platform-tests/html/dom/elements/content-models/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-meter-element/w3c-import.log.
  • web-platform-tests/html/dom/elements/element-definitions/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log.
  • web-platform-tests/html/dom/elements/elements-in-the-dom/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/disabled-elements/w3c-import.log.
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-001.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-002.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-003.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-004.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-005.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-006.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-007.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-008.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-009.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-010.html:
  • web-platform-tests/html/dom/elements/global-attributes/w3c-import.log: Added.
  • web-platform-tests/html/dom/elements/wai-aria/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/image-maps/w3c-import.log.
  • web-platform-tests/html/dom/interfaces-expected.txt:
  • web-platform-tests/html/dom/interfaces.html:
  • web-platform-tests/html/dom/w3c-import.log: Added.
  • web-platform-tests/html/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-meter-element/w3c-import.log.
  • web-platform-tests/html/semantics/disabled-elements/w3c-import.log:
  • web-platform-tests/html/semantics/document-metadata/styling/support/w3c-import.log:
  • web-platform-tests/html/semantics/document-metadata/the-base-element/base_multiple.html:
  • web-platform-tests/html/semantics/document-metadata/the-base-element/example.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/resources/example.html.
  • web-platform-tests/html/semantics/document-metadata/the-base-element/example2.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/resources/example2.html.
  • web-platform-tests/html/semantics/document-metadata/the-base-element/w3c-import.log:
  • web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-01-expected.txt:
  • web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  • web-platform-tests/html/semantics/document-metadata/the-link-element/w3c-import.log:
  • web-platform-tests/html/semantics/document-metadata/the-meta-element/w3c-import.log:
  • web-platform-tests/html/semantics/document-metadata/the-style-element/style-error-01-expected.txt:
  • web-platform-tests/html/semantics/document-metadata/the-style-element/style-error-01.html:
  • web-platform-tests/html/semantics/document-metadata/the-style-element/w3c-import.log:
  • web-platform-tests/html/semantics/document-metadata/the-title-element/w3c-import.log:
  • web-platform-tests/html/semantics/edits/the-del-element/w3c-import.log:
  • web-platform-tests/html/semantics/edits/the-ins-element/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/image-maps/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/HTMLElement/HTMLMediaElement/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/HTMLElement/HTMLTrackElement/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCueList/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackList/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TrackEvent/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/media-elements/offsets-into-the-media-resource/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/media-elements/playing-the-media-resource/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/resources/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/media-elements/user-interface/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/media-elements/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-area-element/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-audio-element/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-embed-element/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_javascript_url_01.htm: Removed.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_script-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_script.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_01.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_02.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_03.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_04.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/resources/sandbox_allow_script.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/sandbox_allow_script.html: Removed.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/iframed.sub.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/sizes-iframed.sub.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-object-element/object-handler.html:
  • web-platform-tests/html/semantics/embedded-content/the-object-element/test0.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-object-element/resources/test0.html.
  • web-platform-tests/html/semantics/embedded-content/the-object-element/test1.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-object-element/resources/test1.html.
  • web-platform-tests/html/semantics/embedded-content/the-object-element/test2.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-object-element/resources/test2.html.
  • web-platform-tests/html/semantics/embedded-content/the-object-element/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-video-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-ltr-iframe.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/resources/dirname-ltr-iframe.html.
  • web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-ltr.html:
  • web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/w3c-import.log:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-validity-tooLong-expected.txt:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-validity-tooLong.html:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing.html:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate.html:
  • web-platform-tests/html/semantics/forms/constraints/support/validator.js:

(validator.test_reportValidity):
(validator.set_conditions):
(validator.set_dirty):

  • web-platform-tests/html/semantics/forms/constraints/support/w3c-import.log:
  • web-platform-tests/html/semantics/forms/constraints/w3c-import.log:
  • web-platform-tests/html/semantics/forms/form-control-infrastructure/w3c-import.log:
  • web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log:
  • web-platform-tests/html/semantics/forms/introduction-1/w3c-import.log:
  • web-platform-tests/html/semantics/forms/resetting-a-form/w3c-import.log:
  • web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange-expected.txt:
  • web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange.html:
  • web-platform-tests/html/semantics/forms/textfieldselection/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-button-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-datalist-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-fieldset-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-form-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-input-element/input-textselection-01-expected.txt:
  • web-platform-tests/html/semantics/forms/the-input-element/input-textselection-01.html:
  • web-platform-tests/html/semantics/forms/the-input-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-label-element/label-attributes.html:
  • web-platform-tests/html/semantics/forms/the-label-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-legend-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-meter-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-option-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-output-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-progress-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-select-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-textarea-element/w3c-import.log:
  • web-platform-tests/html/semantics/grouping-content/the-dd-element/w3c-import.log:
  • web-platform-tests/html/semantics/grouping-content/the-div-element/w3c-import.log:
  • web-platform-tests/html/semantics/grouping-content/the-dl-element/w3c-import.log:
  • web-platform-tests/html/semantics/grouping-content/the-dt-element/w3c-import.log:
  • web-platform-tests/html/semantics/grouping-content/the-figcaption-element/w3c-import.log:
  • web-platform-tests/html/semantics/grouping-content/the-figure-element/w3c-import.log:
  • web-platform-tests/html/semantics/grouping-content/the-hr-element/w3c-import.log:
  • web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-002-ref-expected.html: Removed.
  • web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-002-ref.html: Removed.
  • web-platform-tests/html/semantics/grouping-content/the-li-element/w3c-import.log:
  • web-platform-tests/html/semantics/grouping-content/the-ol-element/reversed-1a.html: Added.
  • web-platform-tests/html/semantics/grouping-content/the-ol-element/reversed-1b.html: Added.
  • web-platform-tests/html/semantics/grouping-content/the-ol-element/reversed-1c.html: Added.
  • web-platform-tests/html/semantics/grouping-content/the-ol-element/w3c-import.log:
  • web-platform-tests/html/semantics/grouping-content/the-p-element/w3c-import.log:
  • web-platform-tests/html/semantics/grouping-content/the-pre-element/w3c-import.log:
  • web-platform-tests/html/semantics/grouping-content/the-ul-element/w3c-import.log:
  • web-platform-tests/html/semantics/interactive-elements/commands/w3c-import.log:
  • web-platform-tests/html/semantics/interactive-elements/the-details-element/w3c-import.log:
  • web-platform-tests/html/semantics/interactive-elements/the-dialog-element/w3c-import.log:
  • web-platform-tests/html/semantics/interactive-elements/the-menu-element/w3c-import.log:
  • web-platform-tests/html/semantics/interfaces-expected.txt:
  • web-platform-tests/html/semantics/interfaces.js:
  • web-platform-tests/html/semantics/links/downloading-resources/w3c-import.log:
  • web-platform-tests/html/semantics/links/linktypes/w3c-import.log:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/w3c-import.log:
  • web-platform-tests/html/semantics/scripting-1/the-template-element/additions-to-parsing-xhtml-documents/w3c-import.log:
  • web-platform-tests/html/semantics/scripting-1/the-template-element/additions-to-serializing-xhtml-documents/w3c-import.log:
  • web-platform-tests/html/semantics/scripting-1/the-template-element/additions-to-the-css-user-agent-style-sheet/w3c-import.log:
  • web-platform-tests/html/semantics/scripting-1/the-template-element/additions-to-the-steps-to-clone-a-node/w3c-import.log:
  • web-platform-tests/html/semantics/scripting-1/the-template-element/definitions/template-contents-owner-document-type-expected.txt:
  • web-platform-tests/html/semantics/scripting-1/the-template-element/definitions/template-contents-owner-document-type.html:
  • web-platform-tests/html/semantics/scripting-1/the-template-element/definitions/w3c-import.log:
  • web-platform-tests/html/semantics/scripting-1/the-template-element/innerhtml-on-templates/w3c-import.log:
  • web-platform-tests/html/semantics/scripting-1/the-template-element/resources/w3c-import.log:
  • web-platform-tests/html/semantics/scripting-1/the-template-element/serializing-html-templates/w3c-import.log:
  • web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/template-descendant-frameset-expected.txt:
  • web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/template-descendant-frameset.html:
  • web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/w3c-import.log:
  • web-platform-tests/html/semantics/sections/headings-and-sections/w3c-import.log:
  • web-platform-tests/html/semantics/sections/the-h1-h2-h3-h4-h5-and-h6-elements/w3c-import.log:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/disabled-expected.txt:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/disabled.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/focus-iframe.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/resources/focus-iframe.html.
  • web-platform-tests/html/semantics/selectors/pseudo-classes/focus.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/w3c-import.log:
  • web-platform-tests/html/semantics/tabular-data/attributes-common-to-td-and-th-elements/w3c-import.log:
  • web-platform-tests/html/semantics/tabular-data/processing-model-1/w3c-import.log:
  • web-platform-tests/html/semantics/tabular-data/the-caption-element/w3c-import.log:
  • web-platform-tests/html/semantics/tabular-data/the-table-element/w3c-import.log:
  • web-platform-tests/html/semantics/tabular-data/the-tbody-element/w3c-import.log:
  • web-platform-tests/html/semantics/tabular-data/the-tr-element/w3c-import.log:
  • web-platform-tests/html/semantics/text-level-semantics/the-a-element/w3c-import.log:
  • web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/w3c-import.log:
  • web-platform-tests/html/semantics/text-level-semantics/the-bdo-element/w3c-import.log:
  • web-platform-tests/html/semantics/text-level-semantics/the-br-element/w3c-import.log:
  • web-platform-tests/html/semantics/text-level-semantics/the-time-element/w3c-import.log:
  • web-platform-tests/html/semantics/text-level-semantics/the-wbr-element/w3c-import.log:
  • web-platform-tests/html/semantics/text-level-semantics/the-wbr-element/wbr-element-expected.html:
  • web-platform-tests/html/semantics/text-level-semantics/the-wbr-element/wbr-element-ref.html: Removed.
  • web-platform-tests/html/semantics/text-level-semantics/the-wbr-element/wbr-element.html:
  • web-platform-tests/html/semantics/w3c-import.log:

LayoutTests:

  • TestExpectations: Skipping imported resource files that are not in 'resources' folder.
12:05 AM Changeset in webkit [191378] by fred.wang@free.fr
  • 5 edits
    3 adds in trunk

[FreeType] Add support for the USE_TYPO_METRICS flag
​https://bugs.webkit.org/show_bug.cgi?id=150340

Reviewed by Martin Robinson.

Source/WebCore:

Test: fonts/use-typo-metrics-1.html

Make the FreeType backend use the typo metrics when the OS/2 USE_TYPO_METRICS flag is set.
Similar work should be done for other backends, see bug 131839.

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::Font::platformInit): Verify whether the OS/2 USE_TYPO_METRICS flag is set and use the typo metrics if that's the case.

LayoutTests:

Add a test to verify that the line height of a font is calculated from the typo metrics when the OS/2 USE_TYPO_METRICS flag is set. Currently, the test only passes with the FreeType backend.

  • fonts/lineheight5000-typolineheight2300.woff: Added.
  • fonts/use-typo-metrics-1-expected.html: Added.
  • fonts/use-typo-metrics-1.html: Added.
  • platform/mac/TestExpectations: Mark as failing.
  • platform/win/TestExpectations: Mark as failing.

Oct 20, 2015:

11:41 PM Changeset in webkit [191377] by Chris Dumez
  • 7 edits in trunk/Source/WebKit2

[WK2] Generalize NetworkCacheStorage API so it can store different types of metadata
​https://bugs.webkit.org/show_bug.cgi?id=150221
<rdar://problem/23149771>

Reviewed by Darin Adler and Antti Koivisto.

Generalize NetworkCacheStorage API so it can store different types of
metadata alongside the network resources. This is a pre-requirement to
making our NetworkCache smarter by storing information about the
resources.

To keep the code simple, the entry type is now part of the entry key and
we store records of a specific type in a 'type' subfolder. The cache
structure looks like so:

  • WebKitCache/Version 5/[Partition]/[Type]/[Hash]
  • WebKitCache/Version 5/[Partition]/[Type]/[Hash]-blob (Optional)

Existing cache entries now that the 'resource' type as these are network
resources.

  • NetworkProcess/cache/NetworkCache.cpp:
  • NetworkProcess/cache/NetworkCacheKey.cpp:
  • NetworkProcess/cache/NetworkCacheKey.h:
  • NetworkProcess/cache/NetworkCacheStatistics.cpp:
  • NetworkProcess/cache/NetworkCacheStorage.cpp:
  • NetworkProcess/cache/NetworkCacheStorage.h:
11:20 PM Changeset in webkit [191376] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Marking http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html as flaky on Yosemite
​https://bugs.webkit.org/show_bug.cgi?id=150378

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-20
Reviewed by Alexey Proskuryakov.

  • platform/mac-wk2/TestExpectations:
11:08 PM Changeset in webkit [191375] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Marking http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html as flaky on Yosemite
​https://bugs.webkit.org/show_bug.cgi?id=150363

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-20
Reviewed by Alexey Proskuryakov.

  • platform/mac-wk2/TestExpectations:
10:36 PM Changeset in webkit [191374] by commit-queue@webkit.org
  • 10 edits in trunk

run-webkit-tests does not copy all crash logs for layout test failures on iOS
​https://bugs.webkit.org/show_bug.cgi?id=150056
Tools:

<rdar://problem/9280656>

Patch by Aakash Jain <​aakash_jain@apple.com> on 2015-10-20
Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs.find_all_logs): Generic method to find all crash logs.
(CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
It iterates through log directory and returns all the logs based on timestamp.

  • Scripts/webkitpy/common/system/crashlogs_unittest.py:

(CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
(CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
(CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run): Modified start_time to start counting before simulator launch
so that we can capture crashes during simualator launch.
(Manager._look_for_new_crash_logs): Browse through list of crashes and append
any test which is not already marked as CRASH to the run_results.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationsModel.get_expectations_string): return PASS in case there
are no expectations defined for this test.

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results): Add other_crashes in a separte category in full_results.json.

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
(IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
from the log directory.
(IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
logs from log directory and merge them with the list of already crashed tests.

LayoutTests:

<rdar://problem/22239750>

Patch by Aakash Jain <​aakash_jain@apple.com> on 2015-10-20
Reviewed by Alexey Proskuryakov.

  • fast/harness/results.html: Added the column for Other crashes, this contain

all the newly find crashes from the crash-log directory. Added method forOtherCrashes
which processes othre_crashes section from full_results.json. Also fixed the method
splitExtension to handle the case when there is no extension.

10:09 PM Changeset in webkit [191373] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

Unreviewed, rolling out r191370.
​https://bugs.webkit.org/show_bug.cgi?id=150384

Broke iOS 9 build (Requested by ap on #webkit).

Reverted changeset:

"Fix build for clang-700.0.59.5 by replacing deprecated calls
to convertScreenToBase: with convertRectFromScreen:."
​https://bugs.webkit.org/show_bug.cgi?id=150379
​http://trac.webkit.org/changeset/191370

9:51 PM Changeset in webkit [191372] by dburkart@apple.com
  • 2 edits in trunk/Tools

Fix the build

Unreviewed.

My previous patch was missing a necessary space character.

  • Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
9:25 PM Changeset in webkit [191371] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Pressing Command-S while focused on the styles sidebar should save CSS file
​https://bugs.webkit.org/show_bug.cgi?id=150298

Reviewed by Timothy Hatcher.

  • UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection):
Beep when saving didn't work. Inline CSS and CSS in style attributes aren't curently supported.

7:21 PM Changeset in webkit [191370] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

Fix build for clang-700.0.59.5 by replacing deprecated calls to convertScreenToBase: with convertRectFromScreen:.
​https://bugs.webkit.org/show_bug.cgi?id=150379

Patch by Gordon Sheridan <​gordon_sheridan@apple.com> on 2015-10-20
Reviewed by Simon Fraser.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView characterIndexForPoint:]):
Convert point to rect, and call convertRectFromScreen:.

(-[WebHTMLView firstRectForCharacterRange:]):
Replace convertBaseToScreen: with convertRectToScreen:.

7:12 PM Changeset in webkit [191369] by Hunseop Jeong
  • 50 edits in trunk/Source/WebCore

Replace 0 and NULL with nullptr in WebCore/loader.
​https://bugs.webkit.org/show_bug.cgi?id=149657

Reviewed by Darin Adler.

No new tests because there is no behavior change.

  • loader/CookieJar.cpp:

(WebCore::networkingContext):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::frameLoader):
(WebCore::DocumentLoader::popArchiveForSubframe):
(WebCore::DocumentLoader::clearArchiveResources):
(WebCore::DocumentLoader::clearMainResource):
(WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::cancel):
(WebCore::DocumentThreadableLoader::setDefersLoading):
(WebCore::DocumentThreadableLoader::clearResource):

  • loader/EmptyClients.cpp:

(WebCore::EmptyFrameLoaderClient::createJavaAppletWidget):
(WebCore::EmptyFrameLoaderClient::createNetworkingContext):

  • loader/EmptyClients.h:
  • loader/FTPDirectoryParser.cpp:

(WebCore::parseOneFTPLine):

  • loader/FTPDirectoryParser.h:

(WebCore::ListResult::clear):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::clear):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::clearProvisionalLoad):
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::closeAndRemoveChild):
(WebCore::FrameLoader::detachFromParent):
(WebCore::FrameLoader::detachViewsAndDocumentLoader):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

  • loader/FrameLoader.h:

(WebCore::FrameLoader::stateMachine):

  • loader/FrameNetworkingContext.h:

(WebCore::FrameNetworkingContext::invalidate):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::replaceState):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::updateFromElement):

  • loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::releaseResources):

  • loader/ResourceLoadNotifier.h:
  • loader/ResourceLoadScheduler.cpp:

(WebCore::resourceLoadScheduler):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::releaseResources):

  • loader/TextResourceDecoder.cpp:

(WebCore::TextResourceDecoder::TextResourceDecoder):

  • loader/ThreadableLoaderClientWrapper.h:

(WebCore::ThreadableLoaderClientWrapper::clearClient):
(WebCore::ThreadableLoaderClientWrapper::done):

  • loader/appcache/ApplicationCache.cpp:

(WebCore::fallbackURLLongerThan):
(WebCore::ApplicationCache::ApplicationCache):
(WebCore::ApplicationCache::resourceForRequest):

  • loader/appcache/ApplicationCache.h:

(WebCore::ApplicationCache::fallbackURLs):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::ApplicationCacheGroup):
(WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest):
(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::finishedLoadingMainResource):
(WebCore::ApplicationCacheGroup::failedLoadingMainResource):
(WebCore::ApplicationCacheGroup::manifestNotFound):
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::ApplicationCacheHost):
(WebCore::ApplicationCacheHost::setApplicationCache):

  • loader/appcache/ApplicationCacheHost.h:

(WebCore::ApplicationCacheHost::candidateApplicationCacheGroup):

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::StorageIDJournal::Record::Record):
(WebCore::StorageIDJournal::Record::restore):
(WebCore::ApplicationCacheStorage::loadCacheGroup):
(WebCore::ApplicationCacheStorage::cacheGroupForURL):
(WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
(WebCore::ApplicationCacheStorage::cacheGroupDestroyed):
(WebCore::ApplicationCacheStorage::loadCache):

  • loader/appcache/DOMApplicationCache.cpp:

(WebCore::DOMApplicationCache::disconnectFrameForPageCache):
(WebCore::DOMApplicationCache::willDestroyGlobalObjectInFrame):
(WebCore::DOMApplicationCache::applicationCacheHost):
(WebCore::DOMApplicationCache::scriptExecutionContext):
(WebCore::DOMApplicationCache::toEventType):

  • loader/archive/ArchiveFactory.cpp:

(WebCore::ArchiveFactory::create):
(WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):

  • loader/archive/ArchiveResourceCollection.cpp:

(WebCore::ArchiveResourceCollection::archiveResourceForURL):

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::createPropertyListRepresentation):
(WebCore::LegacyWebArchive::createResource):
(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::rawDataRepresentation):

  • loader/archive/cf/LegacyWebArchiveMac.mm:

(WebCore::LegacyWebArchive::createPropertyListRepresentation):

  • loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::create):
(WebCore::MHTMLArchive::generateMHTMLData):

  • loader/archive/mhtml/MHTMLParser.cpp:

(WebCore::MHTMLParser::parseArchiveWithHeader):
(WebCore::MHTMLParser::parseNextPart):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::CachedImage):

  • loader/cache/CachedImageClient.h:

(WebCore::CachedImageClient::imageChanged):
(WebCore::CachedImageClient::newImageAnimationFrameAvailable):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::calculateIncrementalDataChunk):

  • loader/cache/CachedRawResourceClient.h:

(WebCore::CachedRawResourceClient::dataReceived):
(WebCore::CachedRawResourceClient::redirectReceived):
(WebCore::CachedRawResourceClient::getOrCreateReadBuffer):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::clearResourceToRevalidate):

  • loader/cache/CachedResourceClientWalker.h:

(WebCore::CachedResourceClientWalker::next):

  • loader/cache/CachedResourceHandle.cpp:

(WebCore::CachedResourceHandleBase::CachedResourceHandleBase):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::canRequest): Return value is bool.
(WebCore::CachedResourceLoader::requestResource):

  • loader/cache/CachedResourceLoader.h:

(WebCore::CachedResourceLoader::document):
(WebCore::CachedResourceLoader::setDocument):
(WebCore::CachedResourceLoader::clearDocumentLoader):

  • loader/cache/CachedSVGDocumentReference.cpp:

(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):

  • loader/cf/ResourceLoaderCFNet.cpp:

(WebCore::ResourceLoader::shouldCacheResponse): Return value is bool.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::synchronousNativeIconForPageURL):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::getOrCreatePageURLRecord):
(WebCore::IconDatabase::cleanupSyncThread):

  • loader/icon/IconDatabaseBase.cpp:

(WebCore::IconDatabaseBase::open):
(WebCore::iconDatabase):

  • loader/icon/IconDatabaseBase.h:

(WebCore::EnumCallback::performCallback):
(WebCore::EnumCallback::invalidate):
(WebCore::ObjectCallback::performCallback):
(WebCore::ObjectCallback::invalidate):

  • loader/icon/PageURLRecord.cpp:

(WebCore::PageURLRecord::~PageURLRecord):
(WebCore::PageURLRecord::setIconRecord):

  • loader/mac/ResourceLoaderMac.mm:

(WebCore::ResourceLoader::willCacheResponse):

  • loader/soup/CachedRawResourceSoup.cpp:

(WebCore::CachedRawResource::getOrCreateReadBuffer):

6:53 PM Changeset in webkit [191368] by Hunseop Jeong
  • 2 edits in trunk/Source/WebKit2

[EFL] ContextMenu doesn't work correctly on MiniBrowser after r191194.
​https://bugs.webkit.org/show_bug.cgi?id=150311

Reviewed by Gyuyoung Kim.

Restore the test_ewk2_context_menu API test to check the context menu whether it works correctly.

  • PlatformEfl.cmake:
6:41 PM Changeset in webkit [191367] by dburkart@apple.com
  • 3 edits
    1 add in trunk/Tools

svn-apply fails to apply binary diffs in some cases
​https://bugs.webkit.org/show_bug.cgi?id=64647

Reviewed by Daniel Bates.

  • Scripts/VCSUtils.pm:

(decodeGitBinaryPatchDeltaSize): Modified.
We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".

  • Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
6:10 PM Changeset in webkit [191366] by Conrad Shultz
  • 3 edits in trunk/Source/WebKit2

_WKThumbnailView should support a snapshot-only mode
​https://bugs.webkit.org/show_bug.cgi?id=150106

Reviewed by Tim Horton.

Add a new property to _WKThumbnailView, exclusivelyUsesSnapshot, which causes _WKThumbnailView
to bypass both layer tree reparenting and event suppression on the associated WKView.

Add a new method, -requestSnapshot, which clients can use to force _WKThumbnailView to refresh
on demand.

  • UIProcess/API/Cocoa/_WKThumbnailView.h:
  • UIProcess/API/Cocoa/_WKThumbnailView.mm:

(-[_WKThumbnailView requestSnapshot]):
Extracted from -_requestSnapshotIfNeeded:.
(-[_WKThumbnailView _viewWasUnparented]):
(-[_WKThumbnailView _viewWasParented]):
(-[_WKThumbnailView _requestSnapshotIfNeeded]):

4:40 PM Changeset in webkit [191365] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

Build fix.

  • UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
  • UIProcess/ios/forms/WKFileUploadPanel.mm:
4:38 PM Changeset in webkit [191364] by mark.lam@apple.com
  • 3 edits
    3 adds in trunk

YarrPatternConstructor::containsCapturingTerms() should not assume that its terms.size() is greater than 0.
​https://bugs.webkit.org/show_bug.cgi?id=150372

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • yarr/YarrPattern.cpp:

(JSC::Yarr::CharacterClassConstructor::CharacterClassConstructor):
(JSC::Yarr::YarrPatternConstructor::optimizeBOL):
(JSC::Yarr::YarrPatternConstructor::containsCapturingTerms):
(JSC::Yarr::YarrPatternConstructor::optimizeDotStarWrappedExpressions):

LayoutTests:

  • js/regress-150372-expected.txt: Added.
  • js/regress-150372.html: Added.
  • js/script-tests/regress-150372.js: Added.
4:15 PM Changeset in webkit [191363] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

ASSERT when right clicking on SVG Image generating Share menu - can break Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=150374

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-20
Reviewed by Brian Burg.

When there is no absolute URL or downloadable media URL no system share
menu is created, but we were still appending the null context menu to
the list of context menu items.

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::shareMenuItem):
Bail early if the context menu is null.

(WebKit::WebContextMenuProxyMac::showContextMenu):
Only append the share context menu item if it is non-null.
This matches ContextMenuController.cpp in WebCore.

3:49 PM Changeset in webkit [191362] by ap@apple.com
  • 3 edits in branches/safari-601.1.46-branch/Source/WebKit2

Build fix.

  • UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
  • UIProcess/ios/forms/WKFileUploadPanel.mm:

(photoLibraryIcon):

3:38 PM Changeset in webkit [191361] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Unreviewed, GTK API test fix after r191351.

Reverted API change for GTK bindings.

  • html/HTMLOptionsCollection.idl:
  • html/HTMLSelectElement.idl:
3:02 PM Changeset in webkit [191360] by msaboff@apple.com
  • 13 edits
    3 adds in trunk

REGRESSION (r191175): OSR Exit from an inlined tail callee trashes callee save registers
​https://bugs.webkit.org/show_bug.cgi?id=150336

Reviewed by Mark Lam.

Source/JavaScriptCore:

During OSR exit, we need to restore and transform the active stack into what the baseline
JIT expects. Inlined call frames become true call frames. When we reify an inlined call
frame and it is a tail call which we will be continuing from, we need to restore the tag
constant callee save registers with what was saved by the outermost caller.

Re-enabled tail calls and restored tests for tail calls.

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames): Select whether or not we use the callee save tag register
contents or what was saved by the inlining caller when populating an inlined callee's
callee save registers.

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitSaveCalleeSavesFor): This function no longer needs a stack offset.
(JSC::AssemblyHelpers::emitSaveOrCopyCalleeSavesFor): New helper.

  • runtime/Options.h: Turned tail calls back on.
  • tests/es6.yaml:
  • tests/stress/dfg-tail-calls.js:

(nonInlinedTailCall.callee):

  • tests/stress/mutual-tail-call-no-stack-overflow.js:

(shouldThrow):

  • tests/stress/tail-call-in-inline-cache.js:

(tail):

  • tests/stress/tail-call-no-stack-overflow.js:

(shouldThrow):

  • tests/stress/tail-call-recognize.js:

(callerMustBeRun):

  • tests/stress/tail-call-varargs-no-stack-overflow.js:

(shouldThrow):

LayoutTests:

Added a new regression test and restored tail call test results for js/caller-property.

  • js/caller-property-expected.txt:
  • js/regress-150336-expected.txt: Added.
  • js/regress-150336.html: Added.
  • js/script-tests/regress-150336.js: Added.

(bar):
(foo):
(test):

3:00 PM Changeset in webkit [191359] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, Another GTK build fix after r191351.

  • html/HTMLCollection.idl:
2:51 PM Changeset in webkit [191358] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Unreviewed, Another GTK build fix after r191351.

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::elementsForNativeBindings):
(WebCore::HTMLFieldSetElement::elementsForObjC): Deleted.

  • html/HTMLFieldSetElement.h:
  • html/HTMLFieldSetElement.idl:
2:34 PM Changeset in webkit [191357] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::AccessibilityTable::tableElement const + 116
​https://bugs.webkit.org/show_bug.cgi?id=150349

Reviewed by Brent Fulgham.

The crash point for this bug says that the parentElement of the firstBody is garbage when it's accessed.
Unfortunately, I could not reproduce this in-situ or with a test.
So my speculative solution is to recalculate those body elements to ensure that they're valid before we access.

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::tableElement):
(WebCore::AccessibilityTable::isDataTable):

1:54 PM Changeset in webkit [191356] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Take 2 on rebaselining fast/dynamic/insert-before-table-part-in-continuation.html
​https://bugs.webkit.org/show_bug.cgi?id=150126

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-20
Reviewed by Zalan Bujtas.

  • platform/win/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
1:48 PM Changeset in webkit [191355] by Joseph Pecoraro
  • 12 edits
    2 adds in trunk

Web Inspector: JavaScriptCore should parse sourceURL and sourceMappingURL directives
​https://bugs.webkit.org/show_bug.cgi?id=150096

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • inspector/ContentSearchUtilities.cpp:

(Inspector::ContentSearchUtilities::scriptCommentPattern): Deleted.
(Inspector::ContentSearchUtilities::findScriptSourceURL): Deleted.
(Inspector::ContentSearchUtilities::findScriptSourceMapURL): Deleted.

  • inspector/ContentSearchUtilities.h:

No longer need to search script content.

  • inspector/ScriptDebugServer.cpp:

(Inspector::ScriptDebugServer::dispatchDidParseSource):
Carry over the sourceURL and sourceMappingURL from the SourceProvider.

  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::sourceMapURLForScript):
(Inspector::InspectorDebuggerAgent::didParseSource):
No longer do content searching.

  • parser/Lexer.cpp:

(JSC::Lexer<T>::setCode):
(JSC::Lexer<T>::skipWhitespace):
(JSC::Lexer<T>::parseCommentDirective):
(JSC::Lexer<T>::parseCommentDirectiveValue):
(JSC::Lexer<T>::consume):
(JSC::Lexer<T>::lex):

  • parser/Lexer.h:

(JSC::Lexer::sourceURL):
(JSC::Lexer::sourceMappingURL):
(JSC::Lexer::sourceProvider): Deleted.
Give lexer the ability to detect script comment directives.
This just consumes characters in single line comments and
ultimately sets the sourceURL or sourceMappingURL found.

  • parser/Parser.h:

(JSC::Parser<LexerType>::parse):

  • parser/SourceProvider.h:

(JSC::SourceProvider::url):
(JSC::SourceProvider::sourceURL):
(JSC::SourceProvider::sourceMappingURL):
(JSC::SourceProvider::setSourceURL):
(JSC::SourceProvider::setSourceMappingURL):
After parsing a script, update the Source Provider with the
value of directives that may have been found in the script.

Source/WebInspectorUI:

  • UserInterface/Test/InspectorProtocol.js:

(InspectorProtocol._sendMessage):
(InspectorProtocol.dispatchMessageFromBackend):
This is only used for tests, so avoid console.log
and just dump directly to the system console.

LayoutTests:

  • inspector/debugger/sourceURLs-expected.txt: Added.
  • inspector/debugger/sourceURLs.html: Added.

sourceURL and sourceMappingURL detection.

1:47 PM Changeset in webkit [191354] by Chris Dumez
  • 7 edits in trunk/Source/WebKit2

Unreviewed, rolling out r191306.
​https://bugs.webkit.org/show_bug.cgi?id=150371

"May have caused a significant warm PLT regression" (Requested
by cdumez_ on #webkit).

Reverted changeset:

"[WK2] Generalize NetworkCacheStorage API so it can store
different types of metadata"
​https://bugs.webkit.org/show_bug.cgi?id=150221
​http://trac.webkit.org/changeset/191306

Patch by Commit Queue <​commit-queue@webkit.org> on 2015-10-20

1:42 PM WebKitNightlyElCapWorkaround edited by timothy@apple.com
(diff)
1:42 PM Changeset in webkit [191353] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Unreviewed, GTK build fix after r191351.

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::elementsForNativeBindings):
(WebCore::HTMLFormElement::elementsForObjC): Deleted.

  • html/HTMLFormElement.h:
  • html/HTMLFormElement.idl:
1:38 PM Changeset in webkit [191352] by Simon Fraser
  • 17 edits in trunk/Source/WebCore

Add basic TextStream output for Images
​https://bugs.webkit.org/show_bug.cgi?id=150350

Reviewed by Darin Adler.

Add a TextStream output operator for Image, and virtual dump() member functions
that the various image types override to dump their own data.

Add isFoo() functions for each image type (surprising that these didn't already
exist) so we can print the image type.

Make isAnimated() const, and isBitmapImage() private.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::dump):

  • platform/graphics/BitmapImage.h:
  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::dump):

  • platform/graphics/CrossfadeGeneratedImage.h:
  • platform/graphics/GeneratedImage.cpp:
  • platform/graphics/GeneratedImage.h:
  • platform/graphics/GradientImage.cpp:

(WebCore::GradientImage::dump):

  • platform/graphics/GradientImage.h:
  • platform/graphics/Image.cpp:

(WebCore::Image::dump):
(WebCore::operator<<):

  • platform/graphics/Image.h:

(WebCore::Image::isGeneratedImage):
(WebCore::Image::isCrossfadeGeneratedImage):
(WebCore::Image::isNamedImageGeneratedImage):
(WebCore::Image::isGradientImage):
(WebCore::Image::isSVGImage):
(WebCore::Image::isAnimated):

  • platform/graphics/NamedImageGeneratedImage.cpp:

(WebCore::NamedImageGeneratedImage::dump):

  • platform/graphics/NamedImageGeneratedImage.h:
  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::dump):

  • platform/graphics/cg/PDFDocumentImage.h:
  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dump):

  • svg/graphics/SVGImage.h:
11:48 AM WebKitNightlyElCapWorkaround edited by timothy@apple.com
(diff)
11:48 AM Changeset in webkit [191351] by Chris Dumez
  • 27 edits in trunk/Source/WebCore

Use tighter typing for collections / node lists' item() / namedItem() methods
​https://bugs.webkit.org/show_bug.cgi?id=150347

Reviewed by Darin Adler.

Use tighter typing for collections / node lists' item() / namedItem() methods.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::getDocumentLinks):

  • dom/LiveNodeList.h:
  • dom/StaticNodeList.cpp:

(WebCore::StaticElementList::item):

  • dom/StaticNodeList.h:
  • html/CachedHTMLCollection.h:
  • html/HTMLAllCollection.idl:
  • html/HTMLCollection.idl:
  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::elements):
(WebCore::HTMLFieldSetElement::elementsForObjC):

  • html/HTMLFieldSetElement.h:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFormControlsCollection.cpp:

(WebCore::HTMLFormControlsCollection::customElementAfter):

  • html/HTMLFormControlsCollection.h:
  • html/HTMLFormControlsCollection.idl:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::item):
(WebCore::HTMLFormElement::elements):
(WebCore::HTMLFormElement::elementsForObjC):

  • html/HTMLFormElement.h:
  • html/HTMLFormElement.idl:
  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):

  • html/HTMLOptionsCollection.h:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::namedItem):
(WebCore::HTMLSelectElement::item):
(WebCore::HTMLSelectElement::setOption):

  • html/HTMLSelectElement.idl:
  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::deleteCell):

  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::deleteRow):

  • html/RadioNodeList.cpp:

(WebCore::toRadioButtonInputElement):
(WebCore::RadioNodeList::value):
(WebCore::RadioNodeList::setValue):

  • html/RadioNodeList.h:
  • html/RadioNodeList.idl:
11:45 AM WebKitNightlyElCapWorkaround edited by timothy@apple.com
(diff)
11:43 AM WebKitNightlyElCapWorkaround edited by timothy@apple.com
(diff)
11:37 AM Changeset in webkit [191350] by sbarati@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

GCAwareJITStubRoutineWithExceptionHandler has a stale CodeBlock pointer in its destructor
​https://bugs.webkit.org/show_bug.cgi?id=150351

Reviewed by Mark Lam.

We may regenerate many GCAwareJITStubRoutineWithExceptionHandler stubs per one PolymorphicAccess.
Only the last GCAwareJITStubRoutineWithExceptionHandler stub that was generated will get the CodeBlock's aboutToDie()
notification. All other GCAwareJITStubRoutineWithExceptionHandler stubs will still be holding a stale CodeBlock pointer
that they will use in their destructor. The solution is to have GCAwareJITStubRoutineWithExceptionHandler remove its
exception handler in observeZeroRefCount() instead of its destructor. observeZeroRefCount() will run when a PolymorphicAccess
replaces its m_stubRoutine.

  • jit/GCAwareJITStubRoutine.cpp:

(JSC::GCAwareJITStubRoutineWithExceptionHandler::aboutToDie):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::observeZeroRefCount):
(JSC::createJITStubRoutine):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::~GCAwareJITStubRoutineWithExceptionHandler): Deleted.

  • jit/GCAwareJITStubRoutine.h:
11:33 AM Changeset in webkit [191349] by Chris Dumez
  • 3 edits
    2 adds in trunk

Only HTML spaces should be stripped from a <script>'s 'for' / 'event' attributes
​https://bugs.webkit.org/show_bug.cgi?id=150335

Reviewed by Darin Adler.

Source/WebCore:

Only HTML spaces should be stripped from a <script>'s 'for' / 'event' attributes:
​https://html.spec.whatwg.org/multipage/scripting.html#prepare-a-script (step 12.3)
​https://html.spec.whatwg.org/multipage/infrastructure.html#space-character

Previously, we were uding the wrong stripping function and we were stripping
some non-HTML spaces.

Test: fast/dom/script-for-event-spaces.html

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::isScriptForEventSupported):

LayoutTests:

Add a layout test to check that U+000B does not get stripped from the
script's 'for' / 'event' attributes.

  • fast/dom/script-for-event-spaces-expected.txt: Added.
  • fast/dom/script-for-event-spaces.html: Added.
11:30 AM WebKitNightlyElCapWorkaround edited by timothy@apple.com
(diff)
11:15 AM Changeset in webkit [191348] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba4444.html flakily times out on Mavericks WK1
​https://bugs.webkit.org/show_bug.cgi?id=150367

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-20
Reviewed by Darin Adler.

  • platform/mac-wk1/TestExpectations:
11:00 AM Changeset in webkit [191347] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WTF

Try to fix the build by disabling MAC_GESTURE_EVENTS on 10.9 and 10.10

  • wtf/FeatureDefines.h:
10:56 AM Changeset in webkit [191346] by ap@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Touch a file to trigger a build.

  • UIProcess/ios/forms/WKAirPlayRoutePicker.mm:

(-[WKAirPlayRoutePicker initWithView:]):

10:24 AM WebKitNightlyElCapWorkaround edited by timothy@apple.com
(diff)
10:23 AM WebKitNightlyElCapWorkaround edited by timothy@apple.com
(diff)
10:23 AM WebKitNightlyElCapWorkaround edited by timothy@apple.com
(diff)
10:23 AM WebKitNightlyElCapWorkaround edited by timothy@apple.com
(diff)
10:20 AM WebKitNightlyElCapWorkaround created by timothy@apple.com
Initial workaround steps.
10:19 AM Changeset in webkit [191345] by ap@apple.com
  • 3 edits in trunk/Tools

Mac Debug EWS never finishes when there are failures
​https://bugs.webkit.org/show_bug.cgi?id=150334

Reviewed by Daniel Bates.

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
10:16 AM Changeset in webkit [191344] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix the !ENABLE(CSS_GRID_LAYOUT) build after r191128
​https://bugs.webkit.org/show_bug.cgi?id=150321

Reviewed by Darin Adler.

  • css/CSSGrammar.y.in: Typo fix.
9:41 AM Changeset in webkit [191343] by timothy_horton@apple.com
  • 8 edits in trunk/Source

Try to fix the build by disabling MAC_GESTURE_EVENTS on 10.9 and 10.10

9:02 AM Changeset in webkit [191342] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r191333.
​https://bugs.webkit.org/show_bug.cgi?id=150362

Caused assertions on regression tests (Requested by ap on
#webkit).

Reverted changeset:

"ERROR: Unhandled web process message
'StorageAreaMap:DispatchStorageEvent'"
​https://bugs.webkit.org/show_bug.cgi?id=150315
​http://trac.webkit.org/changeset/191333

8:04 AM Changeset in webkit [191341] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[UNIX] ASSERTION FAILED: m_shouldWaitForSyncReplies in Connection::connectionDidClose()
​https://bugs.webkit.org/show_bug.cgi?id=150361

Reviewed by Martin Robinson.

It doesn't always happen because it depends on how sockets are
closed, and the state of the threads. The problem is that we are
not handling the case when the read fails because we closed the
connection. In that case we log the error and call
Connection::connectionDidClose(). But it was connectionDidClose()
the one closing the socket. So, in this particular case it's not an
error but a normal termination, and we shouldn't try to close the
connection again. Something similar can happen while sending a
message, and we get a broken pipe error, but in that case we are
only printing the error, so it's harmless.

  • Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::readyReadHandler): Only print error and call
connectionDidClose() if we are still connected when read fails.
(IPC::Connection::sendOutgoingMessage): Only print error if we are
still connected when send fails.

5:03 AM Changeset in webkit [191340] by Carlos Garcia Campos
  • 18 edits in trunk/Source/WebKit2

[GTK] Graphics corruption when entering/leaving AC mode quickly
​https://bugs.webkit.org/show_bug.cgi?id=150323

Reviewed by Mario Sanchez Prada.

The UI process is notified when entering accelerated compositing
mode after the layers have been flushed and rendered to avoid
flickering. However, this is producing flickering in the GTK+
port, because we use an offscreen redirected window that is
resized to a minimium size to save memory when not in AC mode. The
web process always uses the current size of the redirected window,
so when entering AC mode, contents are rendered into the 1x1
window, then the UI process is notified, the redirected window is
resized to its actual size, and we force a resize to ask the web
process to render again, now at the correct size. Rendering at 1x1
and then resizing the window is what produces the flickering when
entering AC mode, but it's also inefficient, since we need to
render again after the redirected window is resized. So, this
patch adds a WillEnterAcceleratedCompositing message that is sent
to the UI process when the layer tree host is created but before
the contents have been composited and rendered. This is
implemented by the GTK+ port to prepare for entering AC mode, by
resizing the redirected window. When we actually enter AC mode,
the contents have already been rendered in the web process at the
correct size, so we can just use the redirected window surface
instead of the drawing area one, and paint in the web view without
any flickering. We no longer need the forceResize either.
When leaving accelerated compositing mode, we now clear the redirected
window resources after a short delay. This ensures that we have
already rendered the update sent in the ExitAcceleratedCompositingMode
message, but also that entering/leaving AC mode quickly doesn't
produce any redirected window resize.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::willEnterAcceleratedCompositingMode):

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseClearRedirectedWindowSoon):
(webkitWebViewBaseWillEnterAcceleratedCompositingMode):
(webkitWebViewBaseEnterAcceleratedCompositingMode):
(webkitWebViewBaseExitAcceleratedCompositingMode):

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/CoordinatedGraphics/WebView.h:
  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::willEnterAcceleratedCompositingMode):

  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::willEnterAcceleratedCompositingMode):

  • UIProcess/DrawingAreaProxyImpl.h:

(WebKit::DrawingAreaProxyImpl::forceResize): Deleted.

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::willEnterAcceleratedCompositingMode):

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::willEnterAcceleratedCompositingMode):

  • UIProcess/mac/PageClientImpl.h:
  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::willEnterAcceleratedCompositingMode):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):

4:37 AM Changeset in webkit [191339] by Philippe Normand
  • 3 edits in trunk/Tools

[GTK] Enable OpenWebRTC test video/audio sources in tests

This is needed because we can't expect the buildbots to have
webcam/mic devices plugged in.

Rubber-stamped by Carlos Garcia Campos.

  • Scripts/run-gtk-tests:

(TestRunner._setup_testing_environment):

  • Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_environ_for_server):

3:40 AM Changeset in webkit [191338] by svillar@igalia.com
  • 2 edits in trunk/Source/WebKit2

[GTK] Fix build for ENABLE_PLUGIN_PROCESS_GTK2=OFF
​https://bugs.webkit.org/show_bug.cgi?id=150086

Reviewed by Darin Adler.

  • UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::createBackend):

3:07 AM Changeset in webkit [191337] by calvaris@igalia.com
  • 3 edits in trunk/LayoutTests

[Streams API] Update readable-stream-templated tests to latest spec
​https://bugs.webkit.org/show_bug.cgi?id=149668

Reviewed by Darin Adler.

  • streams/reference-implementation/readable-stream-expected.txt: Updated expectations.
  • streams/reference-implementation/readable-stream.html: Updated tests.
2:57 AM Changeset in webkit [191336] by svillar@igalia.com
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: computeMainAxisExtentForChild(child, MainOrPreferredSize, mainSize) in WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax
​https://bugs.webkit.org/show_bug.cgi?id=149459

Reviewed by Darin Adler.

Source/WebCore:

This was regressed after 189567 where min-height|width:auto
support was added to flex items. The merge from Blink changes
was not correctly done for assertions. In particular we were
asserting if the resolved main size was not strictly greater
than 0, but 0 is actually a valid value.

Test: fast/flexbox/crash-resolved-main-size-zero.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):

LayoutTests:

  • fast/flexbox/crash-resolved-main-size-zero-expected.txt: Added.
  • fast/flexbox/crash-resolved-main-size-zero.html: Added.
2:51 AM Changeset in webkit [191335] by calvaris@igalia.com
  • 14 edits
    1 add in trunk/Source

[Streams API] Rework some readable stream internals that can be common to writable streams
​https://bugs.webkit.org/show_bug.cgi?id=150133

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • runtime/CommonIdentifiers.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init): Added RangeError also as native functions.

Source/WebCore:

There are some things in ReadableStream internals that be be used also for Writable Streams so it was necessary
to move some functions and refactor some code that can be shared by both implementations.

Queue was written with the functions declared at the implementation and keeping the improvement of having the
total size calculated instead of having to transverse the whole array.

The strategy is kept as an object and a common method is used to validate it as per spec.

Promises are reworked to keep in an internal slot inside the promise object the resolve and reject
functions. For convinience three functions were written, one to create the promise (and keep internally the
resolve and reject functions), one to resolve and another to reject. Promises can still be created with
Promise.resolve or reject as the resolve and rejectStreamsPromise functions operate under the assumption that
the internal slots might not exist.

invokeOrNoop and promiseInvokeOrNoop were moved to the common code as they will be also used by WritableStream.

Current test set suffices.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/WebCoreJSBuiltinInternals.h:
  • bindings/js/WebCoreJSBuiltins.cpp:
  • bindings/js/WebCoreJSBuiltins.h: Build infrastructure.
  • Modules/streams/ReadableStream.js:

(initializeReadableStream): Reworked queue and strategy.

  • Modules/streams/ReadableStreamInternals.js:

(privateInitializeReadableStreamReader):
(errorReadableStream):
(getReadableStreamDesiredSize):
(cancelReadableStream):
(closeReadableStream):
(closeReadableStreamReader):
(enqueueInReadableStream):
(readFromReadableStreamReader): Reworked queue, strategy and promises.
(invokeOrNoop): Deleted.
(promiseInvokeOrNoop): Deleted.

  • Modules/streams/StreamInternals.js: Added.

(invokeOrNoop):
(promiseInvokeOrNoop): Moved from ReadableStreamInternals.js.
(validateAndNormalizeQueuingStrategy):
(createNewStreamsPromise):
(resolveStreamsPromise):
(rejectStreamsPromise):
(newQueue):
(dequeueValue):
(enqueueValueWithSize): Added according to the spec.

  • bindings/js/WebCoreBuiltinNames.h: Updated private names according to the new slots.
2:49 AM Changeset in webkit [191334] by yoav@yoav.ws
  • 24 edits in trunk

Rename the PICTURE_SIZES flag to CURRENTSRC
​https://bugs.webkit.org/show_bug.cgi?id=150275

Reviewed by Dean Jackson.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests, since there is no functional change.

  • Configurations/FeatureDefines.xcconfig:
  • html/HTMLImageElement.cpp:
  • html/HTMLImageElement.h:
  • html/HTMLImageElement.idl:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.props:
  • win/tools/vsprops/FeatureDefinesCairo.props:
Note: See TracTimeline for information about the timeline view.