Timeline
Oct 22, 2015:
- 11:11 PM Changeset in webkit [191491] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Fix build break since r191471
https://bugs.webkit.org/show_bug.cgi?id=150487
Patch by Joonghun Park <jh718.park@samsung.com> on 2015-10-22
Reviewed by Žan Doberšek.
- UIProcess/API/gtk/WebKitContextMenuClient.cpp:
- UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::WebContextMenuProxyGtk::populate):
- 9:21 PM Changeset in webkit [191490] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Build break since r191472 and r191473
https://bugs.webkit.org/show_bug.cgi?id=150485
Unreviewed build fix.
- CMakeLists.txt: Remove icu include path and move page include path.
- 7:53 PM Changeset in webkit [191489] by
-
- 2 edits in trunk/Source/WebCore
[OS X] Migrate GraphicsContext::drawLineForDocumentMarker() away from LocalCurrentGraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=150483
Reviewed by Simon Fraser.
LocalCurrentGraphicsContext is an ugly hack to work around the problem that many NS* functions
operate on the current context rather than a context passed as an argument. This patch
migrates from NSRectFillUsingOperation() which has this behavior to CGContextDrawTiledImage()
which performs the same operation but with a passed-in CGContextRef. An added benefit is that
we don't have to mess around with pattern-based NSColors.
No new tests because there is no behavior change.
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::findImage):
(WebCore::GraphicsContext::updateDocumentMarkerResources):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
(WebCore::makePatternColor): Deleted.
- 6:10 PM Changeset in webkit [191488] by
-
- 26 edits6 adds16 deletes in trunk/Source/WebInspectorUI
Web Inspector: Remove generateColoredImagesForCSS and its clients
https://bugs.webkit.org/show_bug.cgi?id=150474
Reviewed by Joseph Pecoraro.
- UserInterface/Base/ImageUtilities.js:
(generateColoredImage): Deleted.
(imageLoaded): Deleted.
(ensureImageIsLoaded): Deleted.
(restoreImages.restoreActiveImages): Deleted.
(restoreImages): Deleted.
(restoreImage): Deleted.
(update): Deleted.
(generateImage): Deleted.
(generateColoredImagesForCSS): Deleted.
- UserInterface/Base/Main.js:
(WebInspector.loaded): Deleted call to _generateDisclosureTriangleImages.
(WebInspector._generateDisclosureTriangleImages): Deleted.
(WebInspector.createGoToArrowButton): Deleted code to generate the states.
- UserInterface/Images/BackArrow.svg: Removed.
- UserInterface/Images/BackForwardArrows.svg: Added.
- UserInterface/Images/DisclosureTriangleSmallClosed.svg: Removed.
- UserInterface/Images/DisclosureTriangleSmallOpen.svg: Removed.
- UserInterface/Images/DisclosureTriangleTinyClosed.svg: Removed.
- UserInterface/Images/DisclosureTriangleTinyOpen.svg: Removed.
- UserInterface/Images/DisclosureTriangles.svg: Added.
- UserInterface/Images/ForwardArrow.svg: Removed.
- UserInterface/Images/GoToArrow.svg:
- UserInterface/Images/Locked.svg: Moved fill color here.
- UserInterface/Images/SortIndicatorArrows.svg: Added.
- UserInterface/Images/SortIndicatorDownArrow.svg: Removed.
- UserInterface/Images/SortIndicatorUpArrow.svg: Removed.
- UserInterface/Images/gtk/BackArrow.svg: Removed.
- UserInterface/Images/gtk/BackForwardArrows.svg: Added.
- UserInterface/Images/gtk/DisclosureTriangleSmallClosed.svg: Removed.
- UserInterface/Images/gtk/DisclosureTriangleSmallOpen.svg: Removed.
- UserInterface/Images/gtk/DisclosureTriangleTinyClosed.svg: Removed.
- UserInterface/Images/gtk/DisclosureTriangleTinyOpen.svg: Removed.
- UserInterface/Images/gtk/DisclosureTriangles.svg: Added.
- UserInterface/Images/gtk/ForwardArrow.svg: Removed.
- UserInterface/Images/gtk/GoToArrow.svg:
- UserInterface/Images/gtk/Locked.svg: Moved fill color here.
- UserInterface/Images/gtk/SortIndicatorArrows.svg: Added.
- UserInterface/Images/gtk/SortIndicatorDownArrow.svg: Removed.
- UserInterface/Images/gtk/SortIndicatorUpArrow.svg: Removed.
- UserInterface/Views/CSSStyleDeclarationSection.css:
(.style-declaration-section.locked > .header::before):
- UserInterface/Views/CSSStyleDeclarationSection.js:
(WebInspector.CSSStyleDeclarationSection): Deleted.
- UserInterface/Views/ConsoleMessageView.css:
(.console-message.expandable .console-top-level-message::before):
(.console-message.expandable.expanded .console-top-level-message::before):
- UserInterface/Views/ContentBrowser.js:
(WebInspector.ContentBrowser): Use BackForwardArrows.svg.
- UserInterface/Views/DOMTreeOutline.css:
(.dom-tree-outline li.parent::before):
(.dom-tree-outline:focus li.parent.selected::before):
(.dom-tree-outline li.parent.expanded::before):
(.dom-tree-outline:focus li.parent.expanded.selected::before):
- UserInterface/Views/DataGrid.css:
(.data-grid th.sort-ascending > div:first-child::after):
(.data-grid th.sort-descending > div:first-child::after):
(.data-grid tr.parent td.disclosure::before):
(.data-grid tr.parent.expanded td.disclosure::before):
(.data-grid:matches(:focus, .force-focus) tr.parent.selected td.disclosure::before):
(.data-grid:matches(:focus, .force-focus) tr.parent.expanded.selected td.disclosure::before):
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid): Deleted call to _generateSortIndicatorImagesIfNeeded.
(WebInspector.DataGrid.prototype._generateSortIndicatorImagesIfNeeded): Deleted.
- UserInterface/Views/DetailsSection.css:
(.details-section > .header::before):
(.details-section > .header:not(.mouse-over-options-element):active::before):
(.details-section.collapsed > .header::before):
(.details-section.collapsed > .header:not(.mouse-over-options-element):active::before):
- UserInterface/Views/DetailsSection.js:
(WebInspector.DetailsSection): Deleted call to _generateDisclosureTrianglesIfNeeded.
(WebInspector.DetailsSection.prototype._generateDisclosureTrianglesIfNeeded): Deleted.
- UserInterface/Views/ErrorObjectView.css:
(.error-object > .formatted-error::before):
(.error-object.expanded > .formatted-error::before):
- UserInterface/Views/FindBanner.css:
(.find-banner > button.segmented.left > .glyph):
(.find-banner > button.segmented.left:active:not(:disabled) > .glyph):
(.find-banner > button.segmented.right > .glyph):
(.find-banner > button.segmented.right:active:not(:disabled) > .glyph):
- UserInterface/Views/FindBanner.js:
(WebInspector.FindBanner): Deleted call to _generateButtonsGlyphsIfNeeded.
(WebInspector.FindBanner.prototype._generateButtonsGlyphsIfNeeded): Deleted.
- UserInterface/Views/LogContentView.css:
(.console-group-title::before):
(.console-group.collapsed .console-group-title::before):
- UserInterface/Views/Main.css:
(.go-to-arrow):
(.go-to-arrow:active):
(:matches(:focus, .force-focus) .selected .go-to-arrow):
(:matches(:focus, .force-focus) .selected .go-to-arrow:active):
- UserInterface/Views/NavigationSidebarPanel.css:
(.navigation-sidebar-panel-content-tree-outline .item .disclosure-button):
(.navigation-sidebar-panel-content-tree-outline:matches(:focus, .force-focus) .item.selected .disclosure-button):
(.navigation-sidebar-panel-content-tree-outline .item.expanded .disclosure-button):
(.navigation-sidebar-panel-content-tree-outline:matches(:focus, .force-focus) .item.selected.expanded .disclosure-button):
- UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel): Deleted call to _generateDisclosureTrianglesIfNeeded.
(WebInspector.NavigationSidebarPanel.prototype._generateDisclosureTrianglesIfNeeded): Deleted.
- UserInterface/Views/ObjectTreePropertyTreeElement.css:
(.object-tree-property.parent > .disclosure-button):
(.object-tree-property.parent.expanded > .disclosure-button):
(.object-tree-property .read-only): Deleted.
- UserInterface/Views/ObjectTreeView.css:
(.object-tree > :matches(.title, .object-preview)::before):
(.object-tree.expanded > :matches(.title, .object-preview)::before):
- UserInterface/Views/TypeTreeElement.css:
(.type-tree-element.parent > .disclosure-button):
(.type-tree-element.parent.expanded > .disclosure-button):
- 5:09 PM Changeset in webkit [191487] by
-
- 11 edits in trunk
Navigations on the same host (but with different schemes and ports) should not trigger universal links
<rdar://problem/22811325>
https://bugs.webkit.org/show_bug.cgi?id=150481
Reviewed by Dan Bernstein.
Source/WebCore:
Add new helper which efficiently compares the hosts of two URLs.
- platform/URL.cpp:
(WebCore::hostsAreEqual):
- platform/URL.h:
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
(shouldTryAppLink):
Update the policy for following universal links to only take host into consideration.
Source/WebKit2:
Update the policy for following universal links to only take host into consideration.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::createNewPage):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::createNewPage):
(WebKit::WebPageProxy::showPage):
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
Update test to test that navigations on the same host but with different schemes does not
trigger universal links, but that changes in the host do.
- 4:31 PM Changeset in webkit [191486] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: CSS Data URIs count against page weight twice
https://bugs.webkit.org/show_bug.cgi?id=150101
Reviewed by Timothy Hatcher.
- UserInterface/Models/DefaultDashboard.js:
(WebInspector.DefaultDashboard.prototype._resourceSizeDidChange):
Exclude resources with a data URI from the total page weight.
- UserInterface/Models/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.prototype.updateForRedirectResponse):
(WebInspector.Resource.prototype.updateForResponse):
(WebInspector.Resource.prototype.markAsFinished):
Removed uses ofdelete.
- 3:56 PM Changeset in webkit [191485] by
-
- 12 edits in trunk/Source
Web Inspector: Remove unused Timeline GCEvent Record type
https://bugs.webkit.org/show_bug.cgi?id=150477
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-22
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Garbage Collection events go through the Heap domain, not the
Timeline domain (long time ago for Chromium).
- inspector/protocol/Timeline.json:
Source/WebCore:
This event is dispatched through the Heap domain, not Timelines.
- inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createGCEventData): Deleted.
- inspector/TimelineRecordFactory.h:
Source/WebInspectorUI:
iOS backends never emitted a GCEvent timeline event.
- UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
- UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
- UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
- Versions/Inspector-iOS-7.0.json:
- Versions/Inspector-iOS-8.0.json:
- Versions/Inspector-iOS-9.0.json:
- 3:36 PM Changeset in webkit [191484] by
-
- 5 edits in trunk/Source
Fix build for clang-700.0.59.5 by replacing deprecated calls to convert points between screen and window coordinates for Mac.
https://bugs.webkit.org/show_bug.cgi?id=150379
Patch by Gordon Sheridan <gordon_sheridan@apple.com> on 2015-10-22
Reviewed by Andy Estes.
Source/WebCore:
Provide WAKWindow versions of the non-deprecated methods for converting an NSRect between
window and screen coordinates, which replace the deprecated methods that operated on an NSPoint.
- platform/ios/wak/WAKWindow.h:
- platform/ios/wak/WAKWindow.mm:
(-[WAKWindow convertRectToScreen:]): Added.
(-[WAKWindow convertRectFromScreen:]): Added.
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView characterIndexForPoint:]):
Convert point to rect, and replace call to deprecated convertScreenToBase: with convertRectFromScreen:.
(-[WebHTMLView firstRectForCharacterRange:]):
Replace call to deprecated convertBaseToScreen: with convertRectToScreen:.
- 3:33 PM Changeset in webkit [191483] by
-
- 2 edits in trunk/Source/WebCore
Fix Mac CMake build after r191433.
- PlatformMac.cmake:
Use CMakeLists.txt to generate UserAgentScripts.h and cpp.
- 3:27 PM Changeset in webkit [191482] by
-
- 3 edits in trunk/Source/WebKit2
Simplify menu creation
https://bugs.webkit.org/show_bug.cgi?id=150476
Reviewed by Tim Horton.
Instead of creating vectors of NSMenuItem objects, just simply build the menu recursively.
- UIProcess/mac/WebContextMenuProxyMac.h:
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::createContextMenuFromItems):
(WebKit::WebContextMenuProxyMac::createContextMenuItem):
(WebKit::WebContextMenuProxyMac::showContextMenu):
(WebKit::populateNSMenu): Deleted.
(WebKit::nsMenuItem): Deleted.
(WebKit::nsMenuItemVector): Deleted.
- 3:25 PM Changeset in webkit [191481] by
-
- 2 edits in trunk/Source/WebKit2
ERROR: Unhandled web process message 'StorageAreaMap:DispatchStorageEvent'
https://bugs.webkit.org/show_bug.cgi?id=150315
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2015-10-22
Reviewed by Andreas Kling.
It was introduced in r184930, that keeps the session storage area
maps alive in the UI process when they are destroyed by the web
process. The problem is that we also keep the listeners, so that
events are also dispatched to the listeners of destroyed areas,
and the message handlers were removed in the web process.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createTransientLocalStorageMap): Add a
listener for the new storage map ID when the map is reused.
(WebKit::StorageManager::destroyStorageMap): Always remove
listeners of destroyed maps.
- 3:14 PM Changeset in webkit [191480] by
-
- 4 edits12 deletes in trunk
Unreviewed, rolling out r191113.
Rollout r144451 since it regressed the visibility of the
search cancel button when a search field is empty or showing
placeholder text. Further investigation is needed.
Reverted changeset:
"[iOS] DOM click event may not be dispatched when page has
:active style and <input type="search">"
https://bugs.webkit.org/show_bug.cgi?id=144451
http://trac.webkit.org/changeset/191113
- 2:54 PM Changeset in webkit [191479] by
-
- 3 edits in trunk/Source/WebKit2
Add a SPI variant of loadData that accepts user data to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=150475
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _loadData:MIMEType:characterEncodingName:baseURL:userData:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- 2:37 PM Changeset in webkit [191478] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: srcset attributes should have hyperlinks to the resources
https://bugs.webkit.org/show_bug.cgi?id=150409
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-22
Reviewed by Timothy Hatcher.
Follow-up tweaks and fixes that were intended to be landed.
- UserInterface/Views/CodeMirrorAdditions.js:
(tokenizeSrcSetString):
Multiline parsing has issues recovering the state CodeMirror
expects, so we just bail in those cases. Leading whitespace
is also handled poorly, but expected to be rare.
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype._buildAttributeDOM):
Trim to eliminate leading whitespace.
- 2:33 PM Changeset in webkit [191477] by
-
- 6 edits in branches/safari-601-branch
Merge r191395. rdar://problem/22847057
- 2:33 PM Changeset in webkit [191476] by
-
- 3 edits3 adds in branches/safari-601-branch
Merge r191364. rdar://problem/22862879
- 2:33 PM Changeset in webkit [191475] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge r191357. rdar://problem/23103279
- 2:29 PM Changeset in webkit [191474] by
-
- 5 edits in trunk/Source/WebCore
Add ways to log to log channels via a functional syntax, and via a TextStream
https://bugs.webkit.org/show_bug.cgi?id=150472
Reviewed by Tim Horton.
Make it possible to write to a WTFLogChannel with a std::function that returns
a const char*, and with stream syntax.
Enhance TextStream to allow it to generate single-line output.
- platform/Logging.cpp:
(WebCore::logFunctionResult):
- platform/Logging.h:
- platform/text/TextStream.cpp:
(WebCore::TextStream::startGroup):
(WebCore::TextStream::endGroup):
(WebCore::TextStream::nextLine):
(WebCore::TextStream::writeIndent):
- platform/text/TextStream.h:
(WebCore::TextStream::TextStream):
- 2:17 PM Changeset in webkit [191473] by
-
- 9 edits in trunk/Source
Progress towards CMake on Mac
https://bugs.webkit.org/show_bug.cgi?id=150466
Reviewed by Chris Dumez.
Source/WebCore:
- PlatformMac.cmake:
- crypto/mac/SerializedCryptoKeyWrapMac.mm:
(WebCore::createAndStoreMasterKey):
- page/mac/WheelEventDeltaFilterMac.mm:
- platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h:
Source/WebKit2:
- CMakeLists.txt:
- PlatformMac.cmake:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
- 2:14 PM Changeset in webkit [191472] by
-
- 7 edits4 deletes in trunk/Source/WebKit2
NativeContextMenuItem isn't needed anymore, remove it
https://bugs.webkit.org/show_bug.cgi?id=150473
Reviewed by Tim Horton.
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- Shared/NativeContextMenuItem.h: Removed.
(WebKit::NativeContextMenuItem::~NativeContextMenuItem): Deleted.
(WebKit::NativeContextMenuItem::nsMenuItem): Deleted.
- Shared/WebContextMenuItem.cpp:
(WebKit::WebContextMenuItem::WebContextMenuItem): Deleted.
- Shared/WebContextMenuItem.h:
(WebKit::WebContextMenuItem::create): Deleted.
(WebKit::WebContextMenuItem::nativeContextMenuItem): Deleted.
- Shared/efl/NativeContextMenuItemEfl.cpp: Removed.
(WebKit::NativeContextMenuItem::NativeContextMenuItem): Deleted.
- Shared/gtk/NativeContextMenuItemGtk.cpp: Removed.
(WebKit::NativeContextMenuItem::NativeContextMenuItem): Deleted.
- Shared/mac/NativeContextMenuItem.mm: Removed.
(WebKit::NativeContextMenuItem::NativeContextMenuItem): Deleted.
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::nsMenuItem): Deleted.
- WebKit2.xcodeproj/project.pbxproj:
- 2:00 PM Changeset in webkit [191471] by
-
- 8 edits in trunk/Source/WebKit2
CTTE WebContextMenuItemData
https://bugs.webkit.org/show_bug.cgi?id=150471
Reviewed by Tim Horton.
- Shared/API/c/WKContextMenuItem.cpp:
(WKContextMenuItemGetTag):
(WKContextMenuItemGetType):
(WKContextMenuItemCopyTitle):
(WKContextMenuItemGetEnabled):
(WKContextMenuItemGetChecked):
- Shared/WebContextMenuItem.cpp:
(WebKit::WebContextMenuItem::create):
- Shared/WebContextMenuItem.h:
(WebKit::WebContextMenuItem::data):
- UIProcess/API/C/WKPage.cpp:
(WKPageSelectContextMenuItem):
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::nsMenuItem):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageClickMenuItem):
- WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):
- 1:37 PM Changeset in webkit [191470] by
-
- 2 edits in trunk/LayoutTests
Skip a racey test until it can be made proper.
https://bugs.webkit.org/show_bug.cgi?id=150455 and
https://bugs.webkit.org/show_bug.cgi?id=150468
- platform/mac-wk1/TestExpectations: Skip storage/indexeddb/modern/createobjectstore-basic.html
- 1:28 PM Changeset in webkit [191469] by
-
- 2 edits in trunk/Source/WebKit2
Handle nil menu items.
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::nsMenuItemVector):
- 1:13 PM Changeset in webkit [191468] by
-
- 3 edits in trunk/Source/WebKit2
Wait to convert the share menu item to a real share menu until after calling out to the client
https://bugs.webkit.org/show_bug.cgi?id=150465
Reviewed by Tim Horton.
This will let us simplify more code in upcoming patches.
- UIProcess/mac/WebContextMenuProxyMac.h:
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::nsMenuItem):
(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::showContextMenu):
- 12:59 PM Changeset in webkit [191467] by
-
- 2 edits in trunk/Source/WebKit/win
Move menu creation to WebView
https://bugs.webkit.org/show_bug.cgi?id=150463
Reviewed by Tim Horton.
- WebView.cpp:
(createContextMenuFromItems):
(WebView::createContextMenu):
- 12:50 PM Changeset in webkit [191466] by
-
- 12 edits in trunk/Source
[Cocoa] Migrate WKSetPatternPhaseInUserSpace() and WKGetUserToBaseCTM() from WKSI
https://bugs.webkit.org/show_bug.cgi?id=150460
Reviewed by Tim Horton.
Source/WebCore:
No reason to use WKSI for these calls.
No new tests because there is no behavior change.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::setPlatformShadow):
- platform/graphics/cg/GraphicsContextCG.h:
(WebCore::getUserToBaseCTM):
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::putByteArray):
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::setPatternPhaseInUserSpace):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
- platform/ios/WebCoreSystemInterfaceIOS.mm:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Deleted.
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Deleted.
- 12:10 PM Changeset in webkit [191465] by
-
- 33 edits2 copies7 adds in trunk
Modern IDB: Basic createObjectStore implementation.
https://bugs.webkit.org/show_bug.cgi?id=150455
Reviewed by Alex Christensen.
Source/WebCore:
Tests: storage/indexeddb/modern/createobjectstore-basic.html
storage/indexeddb/modern/createobjectstore-failures.html
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::createObjectStore):
(WebCore::IDBClient::IDBConnectionToServer::didCreateObjectStore):
- Modules/indexeddb/client/IDBConnectionToServer.h:
- Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
- Modules/indexeddb/client/IDBDatabaseImpl.cpp:
(WebCore::IDBClient::IDBDatabase::objectStoreNames):
(WebCore::IDBClient::IDBDatabase::createObjectStore):
(WebCore::IDBClient::IDBDatabase::didAbortTransaction):
- Modules/indexeddb/client/IDBDatabaseImpl.h:
(WebCore::IDBClient::IDBDatabase::serverConnection):
- Modules/indexeddb/client/IDBObjectStoreImpl.cpp: Added.
(WebCore::IDBClient::IDBObjectStore::create):
(WebCore::IDBClient::IDBObjectStore::IDBObjectStore):
(WebCore::IDBClient::IDBObjectStore::~IDBObjectStore):
(WebCore::IDBClient::IDBObjectStore::id):
(WebCore::IDBClient::IDBObjectStore::name):
(WebCore::IDBClient::IDBObjectStore::keyPathAny):
(WebCore::IDBClient::IDBObjectStore::keyPath):
(WebCore::IDBClient::IDBObjectStore::indexNames):
(WebCore::IDBClient::IDBObjectStore::transaction):
(WebCore::IDBClient::IDBObjectStore::autoIncrement):
(WebCore::IDBClient::IDBObjectStore::add):
(WebCore::IDBClient::IDBObjectStore::put):
(WebCore::IDBClient::IDBObjectStore::openCursor):
(WebCore::IDBClient::IDBObjectStore::get):
(WebCore::IDBClient::IDBObjectStore::deleteFunction):
(WebCore::IDBClient::IDBObjectStore::clear):
(WebCore::IDBClient::IDBObjectStore::createIndex):
(WebCore::IDBClient::IDBObjectStore::index):
(WebCore::IDBClient::IDBObjectStore::deleteIndex):
(WebCore::IDBClient::IDBObjectStore::count):
- Modules/indexeddb/client/IDBObjectStoreImpl.h: Added.
- Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:
(WebCore::IDBClient::IDBOpenDBRequest::requestCompleted):
- Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::serverConnection):
(WebCore::IDBClient::IDBTransaction::objectStore):
(WebCore::IDBClient::IDBTransaction::scheduleOperation):
(WebCore::IDBClient::IDBTransaction::operationTimerFired):
(WebCore::IDBClient::IDBTransaction::finishAbortOrCommit):
(WebCore::IDBClient::IDBTransaction::didAbort):
(WebCore::IDBClient::IDBTransaction::didCommit):
(WebCore::IDBClient::IDBTransaction::createObjectStore):
(WebCore::IDBClient::IDBTransaction::createObjectStoreOnServer):
(WebCore::IDBClient::IDBTransaction::didCreateObjectStoreOnServer):
- Modules/indexeddb/client/IDBTransactionImpl.h:
(WebCore::IDBClient::IDBTransaction::originalDatabaseInfo):
(WebCore::IDBClient::IDBTransaction::isVersionChange):
- Modules/indexeddb/client/TransactionOperation.h: Added.
(WebCore::IDBClient::TransactionOperation::perform):
(WebCore::IDBClient::TransactionOperation::completed):
(WebCore::IDBClient::TransactionOperation::identifier):
(WebCore::IDBClient::TransactionOperation::transactionIdentifier):
(WebCore::IDBClient::TransactionOperation::TransactionOperation):
(WebCore::IDBClient::createTransactionOperation):
- Modules/indexeddb/server/IDBConnectionToClient.cpp:
(WebCore::IDBServer::IDBConnectionToClient::didCreateObjectStore):
- Modules/indexeddb/server/IDBConnectionToClient.h:
- Modules/indexeddb/server/IDBConnectionToClientDelegate.h:
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::createObjectStore):
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::createObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::performCreateObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformCreateObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::performAbortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformAbortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction): Deleted.
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::didCreateObjectStore):
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::isVersionChange):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::createObjectStore):
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:
- Modules/indexeddb/shared/IDBDatabaseInfo.cpp:
(WebCore::IDBDatabaseInfo::hasObjectStore):
(WebCore::IDBDatabaseInfo::createNewObjectStore):
(WebCore::IDBDatabaseInfo::addExistingObjectStore):
(WebCore::IDBDatabaseInfo::objectStoreNames):
- Modules/indexeddb/shared/IDBDatabaseInfo.h:
- Modules/indexeddb/shared/IDBObjectStoreInfo.cpp: Copied from Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.cpp.
(WebCore::IDBObjectStoreInfo::IDBObjectStoreInfo):
(WebCore::IDBObjectStoreInfo::isolatedCopy):
- Modules/indexeddb/shared/IDBObjectStoreInfo.h: Copied from Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.h.
(WebCore::IDBObjectStoreInfo::identifier):
(WebCore::IDBObjectStoreInfo::name):
(WebCore::IDBObjectStoreInfo::keyPath):
(WebCore::IDBObjectStoreInfo::autoIncrement):
- Modules/indexeddb/shared/IDBRequestData.cpp:
(WebCore::IDBRequestData::IDBRequestData):
(WebCore::IDBRequestData::requestIdentifier):
(WebCore::IDBRequestData::transactionIdentifier):
- Modules/indexeddb/shared/IDBRequestData.h:
(WebCore::IDBRequestData::databaseIdentifier):
(WebCore::IDBRequestData::requestIdentifier): Deleted.
- Modules/indexeddb/shared/IDBResultData.cpp:
(WebCore::IDBResultData::IDBResultData):
(WebCore::IDBResultData::createObjectStoreSuccess):
- Modules/indexeddb/shared/IDBResultData.h:
- Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::didCreateObjectStore):
(WebCore::InProcessIDBServer::createObjectStore):
- Modules/indexeddb/shared/InProcessIDBServer.h:
- platform/CrossThreadCopier.cpp:
(WebCore::IDBObjectStoreInfo>::copy):
- platform/CrossThreadCopier.h:
LayoutTests:
- storage/indexeddb/modern/createobjectstore-basic-expected.txt: Added.
- storage/indexeddb/modern/createobjectstore-basic.html: Added.
- storage/indexeddb/modern/createobjectstore-failures-expected.txt: Added.
- storage/indexeddb/modern/createobjectstore-failures.html: Added.
- 11:42 AM Changeset in webkit [191464] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Restore :not(:placeholder-shown) behavior on search bars with comments
https://bugs.webkit.org/show_bug.cgi?id=150452
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-22
Reviewed by Timothy Hatcher.
- UserInterface/Views/FindBanner.css:
(.find-banner.console-find-banner > input[type="search"]:not(:placeholder-shown)):
- UserInterface/Views/SearchBar.css:
(.search-bar > input[type="search"]:not(:placeholder-shown)):
Add back the placeholder-shown related styles and add a comment about what they are for.
- 11:36 AM Changeset in webkit [191463] by
-
- 6 edits in branches/safari-601.1.46-branch
Merge r191395. rdar://problem/22846455
- 11:36 AM Changeset in webkit [191462] by
-
- 3 edits3 adds in branches/safari-601.1.46-branch
Merge r191364. rdar://problem/22864960
- 11:36 AM Changeset in webkit [191461] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r191357. rdar://problem/23103005
- 11:36 AM Changeset in webkit [191460] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r191223. rdar://problem/22900764
- 11:35 AM Changeset in webkit [191459] by
-
- 24 edits3 deletes in branches/safari-601.1.46-branch
Merge r191063. rdar://problem/22900764
- 11:35 AM Changeset in webkit [191458] by
-
- 14 edits3 adds in branches/safari-601.1.46-branch
Merge r190510. rdar://problem/22900764
- 11:00 AM Changeset in webkit [191457] by
-
- 9 edits2 adds in trunk/Source
Initial NSURLSession WebResourceLoader implementation
https://bugs.webkit.org/show_bug.cgi?id=150355
Reviewed by Antti Koivisto.
Source/WebCore:
- platform/network/cf/AuthenticationChallenge.h:
(WebCore::AuthenticationChallenge::AuthenticationChallenge): Export constructor for use in WebKit2.
Source/WebKit2:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::~NetworkResourceLoader):
(WebKit::NetworkResourceLoader::startNetworkLoad):
(WebKit::NetworkResourceLoader::setDefersLoading):
(WebKit::NetworkResourceLoader::cleanup):
(WebKit::NetworkResourceLoader::didConvertHandleToDownload):
(WebKit::NetworkResourceLoader::abort):
(WebKit::NetworkResourceLoader::willPerformHTTPRedirection):
(WebKit::NetworkResourceLoader::didReceiveChallenge):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::didReceiveData):
(WebKit::NetworkResourceLoader::didCompleteWithError):
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
(WebKit::NetworkResourceLoader::willSendRequestAsync):
(WebKit::NetworkResourceLoader::continueWillSendRequest):
(WebKit::NetworkResourceLoader::continueDidReceiveResponse):
(WebKit::NetworkResourceLoader::didSendData):
(WebKit::NetworkResourceLoader::receivedCancellation):
(WebKit::NetworkResourceLoader::startBufferingTimerIfNeeded):
(WebKit::NetworkResourceLoader::bufferingTimerFired):
(WebKit::NetworkResourceLoader::validateCacheEntry):
(WebKit::NetworkResourceLoader::sendAbortingOnFailure):
(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceAsync):
(WebKit::NetworkResourceLoader::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::NetworkResourceLoader::supportsDataArray):
- NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::create):
(WebKit::NetworkResourceLoader::currentRequest):
(WebKit::NetworkResourceLoader::handle):
- NetworkProcess/NetworkSession.h: Added.
(WebKit::NetworkSessionTaskClient::~NetworkSessionTaskClient):
(WebKit::NetworkingDataTask::client):
(WebKit::NetworkingDataTask::clearClient):
(WebKit::NetworkSession::~NetworkSession):
- NetworkProcess/cocoa/NetworkSessionCocoa.mm: Added.
(toNSURLSessionResponseDisposition):
(toNSURLSessionAuthChallengeDisposition):
(-[NetworkSessionDelegate initWithNetworkSession:]):
(-[NetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[NetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(-[NetworkSessionDelegate URLSession:task:didCompleteWithError:]):
(-[NetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
(-[NetworkSessionDelegate URLSession:dataTask:didReceiveData:]):
(WebKit::NetworkSession::create):
(WebKit::NetworkSession::singleton):
(WebKit::configurationForType):
(WebKit::NetworkSession::NetworkSession):
(WebKit::NetworkSession::createDataTaskWithRequest):
(WebKit::NetworkSession::dataTaskForIdentifier):
(WebKit::NetworkingDataTask::NetworkingDataTask):
(WebKit::NetworkingDataTask::~NetworkingDataTask):
(WebKit::NetworkingDataTask::suspend):
(WebKit::NetworkingDataTask::resume):
(WebKit::NetworkingDataTask::taskIdentifier):
- NetworkProcess/mac/NetworkResourceLoaderMac.mm:
(WebKit::NetworkResourceLoader::willCacheResponseAsync):
- WebKit2.xcodeproj/project.pbxproj:
- config.h:
- 10:17 AM Changeset in webkit [191456] by
-
- 8 edits in trunk
[Mac] Add support for the USE_TYPO_METRICS flag
https://bugs.webkit.org/show_bug.cgi?id=150394
Reviewed by Myles C. Maxfield.
Source/WebCore:
Make the Cocoa backend use the typo metrics for fonts with a MATH table when the OS/2 USE_TYPO_METRICS flag is set.
No new tests because this is already tested by fonts/use-typo-metrics-1.html
- platform/graphics/cocoa/FontCocoa.mm:
(WebCore::fontHasMathTable): Add a function to verify whether a font has a MATH table.
(WebCore::Font::platformInit): Verify whether the OS/2 USE_TYPO_METRICS flag is set and use the typo metrics if that is the case.
LayoutTests:
Update font, reference and Mac expectation for fonts/use-typo-metrics-1.html
- fonts/lineheight5000-typolineheight2300.woff: Add a MATH table.
- platform/mac-mavericks/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Updated.
- platform/mac/TestExpectations: Remove Mac failure expectation.
- platform/mac/mathml/opentype/opentype-stretchy-expected.txt: Updated.
- platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Updated.
- 9:12 AM Changeset in webkit [191455] by
-
- 5 edits3 adds in trunk
REGRESSION(r191360): Repro Crash: com.apple.WebKit.WebContent at JavaScriptCore:JSC::ExecState::bytecodeOffset + 174
https://bugs.webkit.org/show_bug.cgi?id=150434
Reviewed by Mark Lam.
Source/JavaScriptCore:
Pass the current frame instead of the caller frame to operationVMHandleException when processing an
exception in one of the native thunks.
- jit/JITExceptions.cpp:
(JSC::genericUnwind): Made debug printing of CodeBlock safe for call frames without one.
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
- jit/ThunkGenerators.cpp:
(JSC::nativeForGenerator):
LayoutTests:
New regression test.
- js/regress-150434-expected.txt: Added.
- js/regress-150434.html: Added.
- js/script-tests/regress-150434.js: Added.
(bar):
(foo):
(test):
- 8:48 AM Changeset in webkit [191454] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Tabbing over CSS properties prepended by * doesn't move the highlighted range
https://bugs.webkit.org/show_bug.cgi?id=150294
Patch by Devin Rousso <Devin Rousso> on 2015-10-22
Reviewed by Timothy Hatcher.
Moving the selected text when tabbing and shift-tabbing now relies upon
the last index of ";" if it exists instead of whether the line ends with it.
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleShiftTabKey):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleTabKey):
- 7:24 AM Changeset in webkit [191453] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed, GTK build fix for disabled redirected XComposite window support.
- UIProcess/API/gtk/WebKitWebViewBase.cpp: Add USE(REDIRECTED_XCOMPOSITE_WINDOW) guards.
- UIProcess/DrawingAreaProxyImpl.h: Mark virtual methods as override to avoid compilation warnings.
- 6:54 AM Changeset in webkit [191452] by
-
- 18 edits7 adds in trunk
Implement touch-action: manipulation; for iOS
https://bugs.webkit.org/show_bug.cgi?id=149854
<rdar://problem/23017145>
Reviewed by Benjamin Poulain.
Source/WebCore:
Implements the manipulation value for the CSS property touch-action. Adds support for
parsing the touch-action property and two of its values: auto and manipulation.
Tests: css3/touch-action/touch-action-computed-style.html
css3/touch-action/touch-action-manipulation-fast-clicks.html
css3/touch-action/touch-action-parsing.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TouchAction):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- dom/Element.cpp:
(WebCore::Element::allowsDoubleTapGesture): Here, we determine whether an element that resulted from
hit-testing a touch should allow double-tap gestures. To do this, we walk up the element's parents,
stopping when we detect an element that disallows double tap gestures by having a touch-action other
than auto or by hitting the root node.
- dom/Element.h:
- dom/Node.h:
(WebCore::Node::allowsDoubleTapGesture):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
Source/WebKit2:
Implements the manipulation value for the CSS property touch-action. Performs hit-testing upon receiving a potential
tap to determine whether to disable double-tap gesture recognition over the duration of the tap. If so, sends a message
from the web process to the UI process indicating that double-tapping should be disabled, allowing single taps to
avoid the delay.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::potentialTapAtPosition):
LayoutTests:
Add tests to check that the manipulation and auto values of the touch-action property can be
properly parsed and can be obtained through computed style. Also tests that putting touch-action:
manipulation on an element and tapping repeatedly on it will fire clicks instead of recognizing
double taps and causing the viewport to zoom.
- TestExpectations:
- css3/touch-action/touch-action-computed-style-expected.txt: Added.
- css3/touch-action/touch-action-computed-style.html: Added.
- css3/touch-action/touch-action-manipulation-fast-clicks-expected.txt: Added.
- css3/touch-action/touch-action-manipulation-fast-clicks.html: Added.
- css3/touch-action/touch-action-parsing-expected.txt: Added.
- css3/touch-action/touch-action-parsing.html: Added.
- platform/ios-simulator-wk2/TestExpectations:
- 4:37 AM Changeset in webkit [191451] by
-
- 16 edits1 add in trunk
REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
https://bugs.webkit.org/show_bug.cgi?id=150428
Reviewed by Antti Koivisto.
Source/WebCore:
The bug was caused by updateFocusAppearance in WebPage::restoreSelectionInFocusedEditableElement
revealing the focused element which was added in r181972. Fixed the bug by adding an option to
suppress this behavior here.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::updateFocusAppearanceSoon):
- dom/Document.h:
- dom/Element.cpp:
(WebCore::Element::focus):
(WebCore::Element::updateFocusAppearanceAfterAttachIfNeeded):
(WebCore::Element::updateFocusAppearance):
- dom/Element.h:
- history/CachedPage.cpp:
(WebCore::CachedPage::restore):
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::updateFocusAppearance):
- html/HTMLAreaElement.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateFocusAppearance):
(WebCore::HTMLInputElement::runPostTypeUpdateTasks):
(WebCore::HTMLInputElement::didAttachRenderers):
- html/HTMLInputElement.h:
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updateFocusAppearance):
- html/HTMLTextAreaElement.h:
Source/WebKit2:
Call updateFocusAppearance with RevealMode::DoNotReveal to avoid revealing the focused element.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::restoreSelectionInFocusedEditableElement):
Tools:
Added a regression test using WebKit API test.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm: Added.
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):
- 3:50 AM Changeset in webkit [191450] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Fix build break since r191439
https://bugs.webkit.org/show_bug.cgi?id=150441
Patch by Joonghun Park <jh718.park@samsung.com> on 2015-10-22
Reviewed by Csaba Osztrogonác.
No new tests, no new behaviours.
- platform/Logging.cpp:
(WebCore::registerNotifyCallback):
- 2:49 AM Changeset in webkit [191449] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed. Fix a crash in GTk+ after r191402.
Since r191402 WebContextMenuProxy is no longer refcounted, and
std::unique_ptr is used instead. This means that when we show the
context menu for the second time in a web view, a new
WebContextMenuProxy is created and the previous one is
destroyed. We were setting the active context menu of the WebView
in the constructor of WebContextMenuProxy, and unsetting it in the
destructor. Now the constructor of the new WebContextMenuProxy
happens before the destructor of the current one that unsets the
WebView active context menu. This patch simply makes the web view
unset its active context menu when it's unmapped and a new one
hasn't been set.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(activeContextMenuUnmapped):
(webkitWebViewBaseSetActiveContextMenuProxy):
- UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk):
- 1:56 AM Changeset in webkit [191448] by
-
- 10 edits in trunk
Unreviewed. Fix GTK+ build after r191423.
Source/WebCore:
Deprecate removed class WebKitDOMHTMLBaseFontElement.
- PlatformGTK.cmake:
- bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_html_base_font_element_init):
(webkit_dom_html_base_font_element_class_init):
(webkit_dom_html_base_font_element_get_color):
(webkit_dom_html_base_font_element_set_color):
(webkit_dom_html_base_font_element_get_face):
(webkit_dom_html_base_font_element_set_face):
(webkit_dom_html_base_font_element_get_size):
(webkit_dom_html_base_font_element_set_size):
- bindings/gobject/WebKitDOMDeprecated.h:
- bindings/gobject/WebKitDOMDeprecated.symbols:
- bindings/gobject/WebKitDOMHTMLPrivate.cpp:
- html/HTMLBaseFontElement.h:
- html/HTMLBaseFontElement.idl:
Tools:
Add WebKitDOMHTMLBaseFontElement to the list of deleted classes.
- gtk/webkitdom.py:
(WebKitDOMDocGenerator):
- 1:08 AM Changeset in webkit [191447] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] Try to fix the build after r191402.
https://bugs.webkit.org/show_bug.cgi?id=150435
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-10-22
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::createPopupMenuProxy):
(WebKit::PageClientImpl::createContextMenuProxy):
(WebKit::PageClientImpl::createColorPicker):
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::WebContextMenuProxyGtk::populate):
(WebKit::WebContextMenuProxyGtk::show):
(WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk):
(WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk):
(WebKit::WebContextMenuProxyGtk::menuPositionFunction):
(WebKit::WebContextMenuProxyGtk::showContextMenu): Deleted.
(WebKit::WebContextMenuProxyGtk::hideContextMenu): Deleted.
(WebKit::WebContextMenuProxyGtk::cancelTracking): Deleted.
- UIProcess/gtk/WebContextMenuProxyGtk.h:
(WebKit::WebContextMenuProxyGtk::gtkMenu):
(WebKit::WebContextMenuProxyGtk::create): Deleted.
- 12:51 AM Changeset in webkit [191446] by
-
- 9 edits in trunk
[Streams API] Add writable stream attributes
https://bugs.webkit.org/show_bug.cgi?id=150389
Reviewed by Darin Adler.
Source/WebCore:
This patch adds the three writable stream attributes, which are closed, ready and state. They are implemented
according to the spec.
Current test set suffices, expectations were adjusted accordingly.
- Modules/streams/WritableStream.js:
(initializeWritableStream): Style fix.
(closed):
(ready):
(state): Implemented according to the spec.
- Modules/streams/WritableStreamInternals.js:
(isWritableStream): Implemented according to the spec.
LayoutTests:
Expectations for the implementation of writable stream attributes.
- streams/reference-implementation/brand-checks-expected.txt:
- streams/reference-implementation/count-queuing-strategy-expected.txt:
- streams/reference-implementation/pipe-to-expected.txt:
- streams/reference-implementation/readable-stream-templated-expected.txt:
- streams/reference-implementation/writable-stream-expected.txt:
- 12:17 AM Changeset in webkit [191445] by
-
- 2 edits in trunk/Tools
[Win][EFL][GTK] webkitpy test failed after r191374.
https://bugs.webkit.org/show_bug.cgi?id=150433
Patch by Aakash Jain <aakash_jain@apple.com> on 2015-10-22
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/common/system/crashlogs_unittest.py:
(CrashLogsTest.test_find_all_log_darwin): Check platform before running test.
(CrashLogsTest.test_find_log_darwin): Same.
- 12:16 AM Changeset in webkit [191444] by
-
- 8 edits in trunk
Rollout r190440 for the moment. It broke the build.
Source/WebCore:
- platform/graphics/cocoa/FontCocoa.mm:
(WebCore::Font::platformInit): Deleted.
LayoutTests:
- fonts/lineheight5000-typolineheight2300.woff:
- platform/mac-mavericks/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/mathml/opentype/opentype-stretchy-expected.txt:
- platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
- 12:09 AM Changeset in webkit [191443] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed compilation fix on Mac.
- platform/graphics/cocoa/FontCocoa.mm:
(WebCore::Font::platformInit): Use a pointer for the third argument of CFArrayContainsValue.
- 12:07 AM Changeset in webkit [191442] by
-
- 2 edits in trunk
[GTK][Mac] ICU-related build fixes
https://bugs.webkit.org/show_bug.cgi?id=150032
Rubber-stamped by Darin Adler.
- Source/cmake/FindICU.cmake: Use pkg-config to hint at icu-i18n's library location.
Oct 21, 2015:
- 11:59 PM Changeset in webkit [191441] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed compilation fix on Mac.
- platform/graphics/cocoa/FontCocoa.mm:
(WebCore::Font::platformInit): Add missing font argument.
- 11:45 PM Changeset in webkit [191440] by
-
- 8 edits in trunk
[Mac] Add support for the USE_TYPO_METRICS flag
https://bugs.webkit.org/show_bug.cgi?id=150394
Reviewed by Myles C. Maxfield.
Source/WebCore:
Make the Cocoa backend use the typo metrics for fonts with a MATH table when the OS/2 USE_TYPO_METRICS flag is set.
No new tests because this is already tested by fonts/use-typo-metrics-1.html
- platform/graphics/cocoa/FontCocoa.mm:
(WebCore::Font::platformInit): Verify whether the OS/2 USE_TYPO_METRICS flag is set and use the typo metrics if that is the case.
LayoutTests:
Update font, reference and Mac expectation for fonts/use-typo-metrics-1.html
- fonts/lineheight5000-typolineheight2300.woff: Add a MATH table.
- platform/mac-mavericks/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Updated.
- platform/mac/TestExpectations: Remove Mac failure expectation.
- platform/mac/mathml/opentype/opentype-stretchy-expected.txt: Updated.
- platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Updated.
- 11:10 PM Changeset in webkit [191439] by
-
- 4 edits in trunk/Source/WebCore
Print out the render tree from command line.
https://bugs.webkit.org/show_bug.cgi?id=150416
Use system-wide notification server (https://developer.apple.com/library/mac/documentation/Darwin/Reference/ManPages/man3/notify_register_dispatch.3.html)
to print out the render tree for the live documents.
Usage: notifyutil -p com.apple.WebKit.showRenderTree
Reviewed by Simon Fraser.
No change in functionality.
- platform/Logging.cpp:
(WebCore::registerNotifyCallback):
- platform/Logging.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
(WebCore::printRenderTreeForLiveDocuments):
- 10:50 PM Changeset in webkit [191438] by
-
- 2 edits in trunk/Source/WebCore
Fix CMake clean build after r191423.
- CMakeLists.txt:
HTMLBaseFontElement.idl no longer generates any JavaScript bindings.
- 10:26 PM Changeset in webkit [191437] by
-
- 2 edits in trunk/Tools
Unreviewed, update watchlist for JS builtins.
Add a category for JS builtins code generator, similar to other generators.
Add a nag message to rebaseline builtins generator tests when touching
code generator files in Source/JavaScriptCore/Scripts/builtins/.
- Scripts/webkitpy/common/config/watchlist:
- 10:13 PM Changeset in webkit [191436] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed EFL build fix. Remove customizeMenu implementation.
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::customizeMenu): Deleted.
- 9:51 PM Changeset in webkit [191435] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, CMake build fix after r191433.
- CMakeLists.txt: add WritableStreamInternals.js to WebCore_BUILTINS_SOURCES.
- 9:45 PM Changeset in webkit [191434] by
-
- 2 edits in trunk/Source/WebKit2
Speculative EFL build fix.
- WebProcess/WebCoreSupport/WebContextMenuClient.h:
Remove another customizeMenu call.
- 9:39 PM Changeset in webkit [191433] by
-
- 14 edits6 copies1 move35 adds2 deletes in trunk
Restructure generate-js-bindings script to be modular and testable
https://bugs.webkit.org/show_bug.cgi?id=149929
Reviewed by Alex Christensen.
Source/JavaScriptCore:
This is a new code generator, based on the replay inputs code generator and
the inspector protocol code generator, which produces various files for JS
builtins.
Relative to the generator it replaces, this one consolidates two scripts in
JavaScriptCore and WebCore into a single script with multiple files. Parsed
information about the builtins file is stored in backend-independent model
objects. Each output file has its own code generator that uses the model to
produce resulting code. Generators are additionally parameterized by the target
framework (to choose correct macros and includes) and output mode (one
header/implementation file per builtin or per framework).
It includes a few simple tests of the generator's functionality. These result-
based tests will become increasingly more important as we start to add support
for builtins annotation such as @optional, @internal, etc. to the code generator.
Some of these complexities, such as having two output modes, will be removed in
subsequent patches. This patch is intended to exactly replace the existing
functionality with a unified script that makes additional cleanups straightforward.
Additional cleanup and consolidation between inspector code generator scripts
and this script will be pursued in followup patches.
New tests:
Scripts/tests/builtins/JavaScriptCore-Builtin.Promise-Combined.js
Scripts/tests/builtins/JavaScriptCore-Builtin.Promise-Separate.js
Scripts/tests/builtins/JavaScriptCore-Builtin.prototype-Combined.js
Scripts/tests/builtins/JavaScriptCore-Builtin.prototype-Separate.js
Scripts/tests/builtins/JavaScriptCore-BuiltinConstructor-Combined.js
Scripts/tests/builtins/JavaScriptCore-BuiltinConstructor-Separate.js
Scripts/tests/builtins/WebCore-GuardedBuiltin-Separate.js
Scripts/tests/builtins/WebCore-GuardedInternalBuiltin-Separate.js
Scripts/tests/builtins/WebCore-UnguardedBuiltin-Separate.js
Scripts/tests/builtins/WebCore-xmlCasingTest-Separate.js
- CMakeLists.txt:
Copy the scripts that are used by other targets to a staging directory inside
${DERIVED_SOURCES_DIR}/ForwardingHeaders/JavaScriptCore/Scripts.
Define JavaScriptCore_SCRIPTS_DIR to point here so that the add_custom_command
and shared file lists are identical between JavaScriptCore and WebCore. The staged
scripts are a dependency of the main JavaScriptCore target so that they are
always staged, even if JavaScriptCore itself does not use a particular script.
The output files additionally depend on all builtin generator script files
and input files that are combined into the single header/implementation file.
- DerivedSources.make:
Define JavaScriptCore_SCRIPTS_DIR explicitly so the rule for code generation and
shared file lists are identical between JavaScriptCore and WebCore.
The output files additionally depend on all builtin generator script files
and input files that are combined into the single header/implementation file.
- JavaScriptCore.xcodeproj/project.pbxproj:
Mark the new builtins generator files as private headers so we can use them from
WebCore.
- Scripts/UpdateContents.py: Renamed from Source/JavaScriptCore/UpdateContents.py.
- Scripts/builtins/init.py: Added.
- Scripts/builtins/builtins.py: Added.
- Scripts/builtins/builtins_generator.py: Added. This file contains the base generator.
(WK_lcfirst):
(WK_ucfirst):
(BuiltinsGenerator):
(BuiltinsGenerator.init):
(BuiltinsGenerator.model):
(BuiltinsGenerator.generate_license):
(BuiltinsGenerator.generate_includes_from_entries):
(BuiltinsGenerator.generate_output):
(BuiltinsGenerator.output_filename):
(BuiltinsGenerator.mangledNameForFunction):
(BuiltinsGenerator.mangledNameForFunction.toCamel):
(BuiltinsGenerator.generate_embedded_code_string_section_for_function):
- Scripts/builtins/builtins_model.py: Added. This file contains builtins model objects.
(ParseException):
(Framework):
(Framework.init):
(Framework.setting):
(Framework.fromString):
(Frameworks):
(BuiltinObject):
(BuiltinObject.init):
(BuiltinFunction):
(BuiltinFunction.init):
(BuiltinFunction.fromString):
(BuiltinFunction.str):
(BuiltinsCollection):
(BuiltinsCollection.init):
(BuiltinsCollection.parse_builtins_file):
(BuiltinsCollection.copyrights):
(BuiltinsCollection.all_functions):
(BuiltinsCollection._parse_copyright_lines):
(BuiltinsCollection._parse_functions):
- Scripts/builtins/builtins_templates.py: Added.
(BuiltinsGeneratorTemplates):
- Scripts/builtins/builtins_generate_combined_header.py: Added.
(BuiltinsCombinedHeaderGenerator):
(BuiltinsCombinedHeaderGenerator.init):
(BuiltinsCombinedHeaderGenerator.output_filename):
(BuiltinsCombinedHeaderGenerator.generate_output):
(BuiltinsCombinedHeaderGenerator.generate_forward_declarations):
(FunctionExecutable):
(VM):
(ConstructAbility):
(generate_section_for_object):
(generate_externs_for_object):
(generate_macros_for_object):
(generate_defines_for_object):
(generate_section_for_code_table_macro):
(generate_section_for_code_name_macro):
- Scripts/builtins/builtins_generate_combined_implementation.py: Added.
(BuiltinsCombinedImplementationGenerator):
(BuiltinsCombinedImplementationGenerator.init):
(BuiltinsCombinedImplementationGenerator.output_filename):
(BuiltinsCombinedImplementationGenerator.generate_output):
(BuiltinsCombinedImplementationGenerator.generate_header_includes):
- Scripts/builtins/builtins_generate_separate_header.py: Added.
(BuiltinsSeparateHeaderGenerator):
(BuiltinsSeparateHeaderGenerator.init):
(BuiltinsSeparateHeaderGenerator.output_filename):
(BuiltinsSeparateHeaderGenerator.macro_prefix):
(BuiltinsSeparateHeaderGenerator.generate_output):
(BuiltinsSeparateHeaderGenerator.generate_forward_declarations):
(FunctionExecutable):
(generate_header_includes):
(generate_section_for_object):
(generate_externs_for_object):
(generate_macros_for_object):
(generate_defines_for_object):
(generate_section_for_code_table_macro):
(generate_section_for_code_name_macro):
- Scripts/builtins/builtins_generate_separate_implementation.py: Added.
(BuiltinsSeparateImplementationGenerator):
(BuiltinsSeparateImplementationGenerator.init):
(BuiltinsSeparateImplementationGenerator.output_filename):
(BuiltinsSeparateImplementationGenerator.macro_prefix):
(BuiltinsSeparateImplementationGenerator.generate_output):
(BuiltinsSeparateImplementationGenerator.generate_header_includes):
- Scripts/builtins/builtins_generate_separate_wrapper.py: Added.
(BuiltinsSeparateWrapperGenerator):
(BuiltinsSeparateWrapperGenerator.init):
(BuiltinsSeparateWrapperGenerator.output_filename):
(BuiltinsSeparateWrapperGenerator.macro_prefix):
(BuiltinsSeparateWrapperGenerator.generate_output):
(BuiltinsSeparateWrapperGenerator.generate_header_includes):
- Scripts/generate-js-builtins.py: Added.
Parse command line options, decide which generators and output modes to use.
(generate_bindings_for_builtins_files):
- Scripts/lazywriter.py: Copied from the inspector protocol generator.
(LazyFileWriter):
(LazyFileWriter.init):
(LazyFileWriter.write):
(LazyFileWriter.close):
- Scripts/tests/builtins/JavaScriptCore-Builtin.Promise-Combined.js: Added.
- Scripts/tests/builtins/JavaScriptCore-Builtin.Promise-Separate.js: Added.
- Scripts/tests/builtins/JavaScriptCore-Builtin.prototype-Combined.js: Added.
- Scripts/tests/builtins/JavaScriptCore-Builtin.prototype-Separate.js: Added.
- Scripts/tests/builtins/JavaScriptCore-BuiltinConstructor-Combined.js: Added.
- Scripts/tests/builtins/JavaScriptCore-BuiltinConstructor-Separate.js: Added.
- Scripts/tests/builtins/WebCore-GuardedBuiltin-Separate.js: Added.
- Scripts/tests/builtins/WebCore-GuardedInternalBuiltin-Separate.js: Added.
- Scripts/tests/builtins/WebCore-UnguardedBuiltin-Separate.js: Added.
- Scripts/tests/builtins/WebCore-xmlCasingTest-Separate.js: Added.
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Combined.js-result: Added.
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Separate.js-result: Added.
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Combined.js-result: Added.
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Separate.js-result: Added.
- Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Combined.js-result: Added.
- Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Separate.js-result: Added.
- Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result: Added.
- Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result: Added.
- Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result: Added.
- Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result: Added.
- builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::BuiltinExecutables):
- builtins/BuiltinExecutables.h:
- create_hash_table:
Update the generated builtin macro names.
- generate-js-builtins: Removed.
Source/WebCore:
- CMakeLists.txt:
Define JavaScriptCore_SCRIPTS_DIR explicitly so the add_custom_command and
shared file lists are identical between JavaScriptCore and WebCore.
The output files additionally depend on all builtin generator script files.
- DerivedSources.make:
Use JavaScriptCore_SCRIPTS_DIR so that the rule for code generation and
shared file lists are identical between JavaScriptCore and WebCore.
The output files additionally depend on all builtin generator script files.
- WebCore.xcodeproj/project.pbxproj:
Define JavaScriptCore_SCRIPTS_DIR before calling DerivedSources.make.
This will eventually be merged with the other similar script paths.
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::finishCreation):
Update the generated builtin macro names.
- generate-js-builtins: Removed.
Tools:
Add a stub shell script and basic webkitpy support for running builtins
generator tests.
- Scripts/run-builtins-generator-tests: Added.
(main):
- Scripts/webkitpy/codegen/init.py: Added.
- Scripts/webkitpy/codegen/main.py: Added.
The only interesting difference here from the inspector protocol
generator equivalent is that this implementation decodes the target
framework and output mode (combined or separate) from the test's file name.
(BuiltinsGeneratorTests):
(BuiltinsGeneratorTests.init):
(BuiltinsGeneratorTests.generate_from_js_builtins):
(BuiltinsGeneratorTests.write_error_file):
(BuiltinsGeneratorTests.detect_changes):
(BuiltinsGeneratorTests.run_tests):
(BuiltinsGeneratorTests.main):
- 8:17 PM Changeset in webkit [191432] by
-
- 2 edits in trunk/Source/WebCore
Recommit r191428.
I don't think it was supposed to be reverted in r191429, and it really does fix the build.
- loader/EmptyClients.h:
(WebCore::EmptyContextMenuClient::~EmptyContextMenuClient):
Remove customizeMenu again.
- 7:55 PM Changeset in webkit [191431] by
-
- 2 edits in trunk/LayoutTests
Adding http/tests/media/video-load-suspend.html to the list of flaky media tests
https://bugs.webkit.org/show_bug.cgi?id=150408
Patch by Ryan Haddad <Ryan Haddad> on 2015-10-21
Reviewed by Alexey Proskuryakov.
- platform/mac/TestExpectations:
- 7:49 PM Changeset in webkit [191430] by
-
- 2 edits in trunk/LayoutTests
Marking imported/blink/fast/overflow/hidden-html-auto-body.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=150419
Patch by Ryan Haddad <Ryan Haddad> on 2015-10-21
Reviewed by Alexey Proskuryakov.
- platform/mac-wk2/TestExpectations:
- 7:27 PM Changeset in webkit [191429] by
-
- 12 edits in trunk/Source
[EFL][GTK][WK2] Fix build break since r191402, r191401
https://bugs.webkit.org/show_bug.cgi?id=150432
Unreviewed EFL and GTK build fix.
Source/WebCore:
- loader/EmptyClients.h:
Source/WebKit2:
- CMakeLists.txt:
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::createContextMenuProxy):
- UIProcess/CoordinatedGraphics/WebView.h:
- UIProcess/efl/WebContextMenuProxyEfl.cpp:
(WebKit::WebContextMenuProxyEfl::show):
- UIProcess/efl/WebContextMenuProxyEfl.h:
(WebKit::WebContextMenuProxyEfl::create): Deleted.
- UIProcess/efl/WebViewEfl.cpp:
(WebKit::WebViewEfl::createContextMenuProxy):
- UIProcess/efl/WebViewEfl.h:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::customizeMenu):
- WebProcess/WebCoreSupport/WebContextMenuClient.h:
- 7:18 PM Changeset in webkit [191428] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r191422.
- page/ContextMenuClient.h:
(WebCore::ContextMenuClient::~ContextMenuClient):
Completely remove customizeMenu.
- 7:02 PM Changeset in webkit [191427] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary default quota setting in DatabaseContext::databaseExceededQuota
https://bugs.webkit.org/show_bug.cgi?id=150356
Reviewed by Darin Adler.
All ports have supported DatabaseContext::databaseExceededQuota(). Thus we don't need to
keep a test code to extend database quota anymore.
- Modules/webdatabase/DatabaseContext.cpp:
(WebCore::DatabaseContext::databaseExceededQuota): Deleted.
- 6:58 PM Changeset in webkit [191426] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] Remove FTL Native Inlining, it is dead code
https://bugs.webkit.org/show_bug.cgi?id=150429
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-10-21
Reviewed by Filip Pizlo.
The code is not used and it is in the way of other changes.
- ftl/FTLAbbreviations.h:
(JSC::FTL::getFirstInstruction): Deleted.
(JSC::FTL::getNextInstruction): Deleted.
(JSC::FTL::getFirstBasicBlock): Deleted.
(JSC::FTL::getNextBasicBlock): Deleted.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::isInlinableSize): Deleted.
- runtime/Options.h:
- 6:57 PM Changeset in webkit [191425] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Remove two useless temporaries from the PutByOffset codegen
https://bugs.webkit.org/show_bug.cgi?id=150421
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-10-21
Reviewed by Geoffrey Garen.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): Deleted.
Looks like they were added by accident in r160796.
- 6:46 PM Changeset in webkit [191424] by
-
- 11 edits1 add1 delete in trunk/Source
Factor out the graph node worklists from DFG into WTF
https://bugs.webkit.org/show_bug.cgi?id=150411
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Rewrite the DFGBlockWorklist.h file as a bunch of typedefs and aliases for things in
wtf/GraphNodeWorklist.h. Most users won't notice, except that some small things got
renamed. For example PreOrder becomes VisitOrder::Pre and item.block becomes item.node.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGBlockWorklist.cpp: Removed.
- dfg/DFGBlockWorklist.h:
(JSC::DFG::BlockWorklist::notEmpty): Deleted.
(JSC::DFG::BlockWith::BlockWith): Deleted.
(JSC::DFG::BlockWith::operator bool): Deleted.
(JSC::DFG::ExtendedBlockWorklist::ExtendedBlockWorklist): Deleted.
(JSC::DFG::ExtendedBlockWorklist::forcePush): Deleted.
(JSC::DFG::ExtendedBlockWorklist::push): Deleted.
(JSC::DFG::ExtendedBlockWorklist::notEmpty): Deleted.
(JSC::DFG::ExtendedBlockWorklist::pop): Deleted.
(JSC::DFG::BlockWithOrder::BlockWithOrder): Deleted.
(JSC::DFG::BlockWithOrder::operator bool): Deleted.
(JSC::DFG::PostOrderBlockWorklist::push): Deleted.
(JSC::DFG::PostOrderBlockWorklist::notEmpty): Deleted.
- dfg/DFGDominators.cpp:
(JSC::DFG::Dominators::compute):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::blocksInPostOrder):
- dfg/DFGPrePostNumbering.cpp:
(JSC::DFG::PrePostNumbering::compute):
Source/WTF:
The new GraphNodeWorklist.h file is basically just the functionality from the old
DFGBlockWorklist.h, but templatized to work for any graph node type and any kind of graph
node set.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/GraphNodeWorklist.h: Added.
(WTF::GraphNodeWorklist::push):
(WTF::GraphNodeWorklist::notEmpty):
(WTF::GraphNodeWorklist::pop):
(WTF::GraphNodeWith::GraphNodeWith):
(WTF::GraphNodeWith::operator bool):
(WTF::ExtendedGraphNodeWorklist::ExtendedGraphNodeWorklist):
(WTF::ExtendedGraphNodeWorklist::forcePush):
(WTF::ExtendedGraphNodeWorklist::push):
(WTF::ExtendedGraphNodeWorklist::notEmpty):
(WTF::ExtendedGraphNodeWorklist::pop):
(WTF::GraphNodeWithOrder::GraphNodeWithOrder):
(WTF::GraphNodeWithOrder::operator bool):
(WTF::PostOrderGraphNodeWorklist::PostOrderGraphNodeWorklist):
(WTF::PostOrderGraphNodeWorklist::~PostOrderGraphNodeWorklist):
(WTF::PostOrderGraphNodeWorklist::pushPre):
(WTF::PostOrderGraphNodeWorklist::pushPost):
(WTF::PostOrderGraphNodeWorklist::push):
(WTF::PostOrderGraphNodeWorklist::notEmpty):
(WTF::PostOrderGraphNodeWorklist::pop):
- wtf/HashTable.h:
(WTF::HashTableAddResult::HashTableAddResult):
(WTF::HashTableAddResult::operator bool):
- 5:58 PM Changeset in webkit [191423] by
-
- 40 edits24 deletes in trunk
Un-expose obsolete HTMLBaseFontElement
https://bugs.webkit.org/show_bug.cgi?id=150397
Reviewed by Anders Carlsson.
LayoutTests/imported/w3c:
Rebaseline a couple of W3C HTML tests now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/semantics/interfaces-expected.txt:
Source/WebCore:
Un-expose obsolete HTMLBaseFontElement:
This means that we no longer expose HTMLBaseFontElement on the global
Window object. Firefox and Chrome do not expose it either.
Also, document.createElement("basefont") now returns an HTMLUnknownElement
as per the specification. Firefox and Chrome return a generic HTMLElement
instead but I don't think this is a big compatibility risk.
No new tests, already covered by existing tests.
- html/HTMLBaseFontElement.cpp:
(WebCore::HTMLBaseFontElement::HTMLBaseFontElement):
- html/HTMLBaseFontElement.h:
- html/HTMLBaseFontElement.idl:
- html/HTMLTagNames.in:
LayoutTests:
Update existing layout tests to stop expecting HTMLBaseFontElement to
be exposed.
- dom/html/level2/html/HTMLBaseFontElement01-expected.txt: Removed.
- dom/html/level2/html/HTMLBaseFontElement01.html: Removed.
- dom/html/level2/html/HTMLBaseFontElement01.js: Removed.
- dom/html/level2/html/HTMLBaseFontElement02-expected.txt: Removed.
- dom/html/level2/html/HTMLBaseFontElement02.html: Removed.
- dom/html/level2/html/HTMLBaseFontElement02.js: Removed.
- dom/html/level2/html/HTMLBaseFontElement03-expected.txt: Removed.
- dom/html/level2/html/HTMLBaseFontElement03.html: Removed.
- dom/html/level2/html/HTMLBaseFontElement03.js: Removed.
- dom/html/level2/html/basefont01-expected.txt: Removed.
- dom/html/level2/html/basefont01.html: Removed.
- dom/html/level2/html/basefont01.js: Removed.
- dom/xhtml/level2/html/HTMLBaseFontElement01-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLBaseFontElement01.js: Removed.
- dom/xhtml/level2/html/HTMLBaseFontElement01.xhtml: Removed.
- dom/xhtml/level2/html/HTMLBaseFontElement02-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLBaseFontElement02.js: Removed.
- dom/xhtml/level2/html/HTMLBaseFontElement02.xhtml: Removed.
- dom/xhtml/level2/html/HTMLBaseFontElement03-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLBaseFontElement03.js: Removed.
- dom/xhtml/level2/html/HTMLBaseFontElement03.xhtml: Removed.
- dom/xhtml/level2/html/basefont01-expected.txt: Removed.
- dom/xhtml/level2/html/basefont01.js: Removed.
- dom/xhtml/level2/html/basefont01.xhtml: Removed.
Drop Legacy W3C DOM level 2 basefont tests.
- fast/dom/Window/element-constructors-on-window-expected.txt:
- fast/dom/Window/element-constructors-on-window.html:
- fast/dom/Window/get-set-properties-expected.txt:
- fast/dom/Window/get-set-properties.html:
- fast/dom/Window/resources/window-properties.js:
- fast/dom/Window/window-lookup-precedence-expected.txt:
- fast/dom/dom-constructors-expected.txt:
- fast/dom/dom-constructors.html:
- fast/dom/element-attribute-js-null-expected.txt:
- fast/dom/element-attribute-js-null.html:
- fast/dom/html-attribute-types-expected.txt:
- fast/dom/html-attribute-types.html:
- fast/dom/wrapper-classes-expected.txt:
- fast/dom/wrapper-classes.html:
- js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 5:50 PM Changeset in webkit [191422] by
-
- 10 edits in trunk/Source
Get rid of WebContextMenuClient::customizeMenu, it's no longer used
https://bugs.webkit.org/show_bug.cgi?id=150427
Reviewed by Tim Horton.
Source/WebCore:
- loader/EmptyClients.cpp:
(WebCore::EmptyContextMenuClient::customizeMenu): Deleted.
- loader/EmptyClients.h:
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::showContextMenu):
Source/WebKit/win:
- WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::customizeMenu): Deleted.
- WebCoreSupport/WebContextMenuClient.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::customizeMenu): Deleted.
- WebProcess/WebCoreSupport/WebContextMenuClient.h:
- 5:50 PM Changeset in webkit [191421] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: srcset attributes should have hyperlinks to the resources
https://bugs.webkit.org/show_bug.cgi?id=150409
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-21
Reviewed by Timothy Hatcher.
The "srcset" attribute parsing is a simplification of:
https://html.spec.whatwg.org/multipage/embedded-content.html#attr-img-srcset
The "srcset" attribute value is expected to be in comma
separated groups. Within each group we always expect a link,
and an optional descriptor. We want to linkify the link.
- UserInterface/Views/CodeMirrorAdditions.js:
(tokenizeSrcSetString):
(extendedXMLToken):
When parsing srcset attribute, parse links as link tokens
so that they are linkified in resource content views.
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype._buildAttributeDOM):
When creating the DOMTree DOM for srcset attributes,
create link elements for the link values of attribute value.
- 5:46 PM Changeset in webkit [191420] by
-
- 3 edits in trunk/Source/WebCore
Remove dead MHTML code
https://bugs.webkit.org/show_bug.cgi?id=150426
Reviewed by Tim Horton.
- loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::generateMHTMLData):
(WebCore::MHTMLArchive::generateMHTMLDataUsingBinaryEncoding): Deleted.
- loader/archive/mhtml/MHTMLArchive.h:
- 5:31 PM Changeset in webkit [191419] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Autocompletion previews in the CSS sidebar do not apply
https://bugs.webkit.org/show_bug.cgi?id=147720
Patch by Devin Rousso <Devin Rousso> on 2015-10-21
Reviewed by Timothy Hatcher.
When autocompletion hints are added to styles or the console, the history
object used by CodeMirror was edited to remove the last entry. Instead of
using this method (which caused glitchy behaviour when undo-ing), call
CodeMirror.undo() and adjust accordingly. In addition, a marker was being
used as the completion hint instead of applying text, whereas these
changes use actual text, ensuring that completions are previewed in the page.
- UserInterface/Controllers/CodeMirrorCompletionController.js:
(WebInspector.CodeMirrorCompletionController):
(WebInspector.CodeMirrorCompletionController.prototype.close):
(WebInspector.CodeMirrorCompletionController.prototype._applyCompletionHint.update):
(WebInspector.CodeMirrorCompletionController.prototype._commitCompletionHint.update):
(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.update):
(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint):
(WebInspector.CodeMirrorCompletionController.prototype._handleBeforeChange):
(WebInspector.CodeMirrorCompletionController.prototype._createCompletionHintMarker): Deleted.
(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.clearMarker): Deleted.
- 5:29 PM Changeset in webkit [191418] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Add forgotten WebInspector.UIString from r190521
https://bugs.webkit.org/show_bug.cgi?id=150425
Patch by Devin Rousso <Devin Rousso> on 2015-10-21
Reviewed by Timothy Hatcher.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(UserInterface/Views/CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded)
- 5:26 PM Changeset in webkit [191417] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Adjust usages of classList.toggle to ensure a true/false value instead of undefined
https://bugs.webkit.org/show_bug.cgi?id=150424
Patch by Devin Rousso <Devin Rousso> on 2015-10-21
Reviewed by Timothy Hatcher.
Adds "!!" in front of force parameters in classList.toggle calls that
could possibly be undefined (thereby breaking the UI).
- UserInterface/Views/ScopeBarItem.js:
(WebInspector.ScopeBarItem):
- UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel.prototype._updateSections):
- UserInterface/Views/VisualStylePropertyEditor.js:
(WebInspector.VisualStylePropertyEditor):
- 5:13 PM Changeset in webkit [191416] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Option-Up doesn't increment certain attribute values
https://bugs.webkit.org/show_bug.cgi?id=149257
Patch by Devin Rousso <Devin Rousso> on 2015-10-21
Reviewed by Brian Burg.
If the user tries to modify a numerical attribute in HTML and the cursor
was at the beginning of the attribute value, the range of the selection
was within a sibling element instead of the text node containin the value.
This patch fixes this issue and ensures that the correct text is selected.
- UserInterface/Views/EditingSupport.js:
(WebInspector.startEditing.handleEditingResult):
Replaced var with let.
- 5:07 PM Changeset in webkit [191415] by
-
- 5 edits1 add2 deletes in trunk/Source/WebKit2
API-ify the FindMatches client
https://bugs.webkit.org/show_bug.cgi?id=150422
Reviewed by Anders Carlsson.
- UIProcess/API/APIFindMatchesClient.h: Renamed from Source/WebKit2/UIProcess/WebFindClient.h.
(API::FindMatchesClient::~FindMatchesClient):
(API::FindMatchesClient::didFindStringMatches):
(API::FindMatchesClient::didGetImageForMatchResult):
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageFindMatchesClient):
- UIProcess/WebFindClient.cpp: Removed.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setFindMatchesClient):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::didGetImageForFindMatch):
(WebKit::WebPageProxy::didFindStringMatches):
(WebKit::WebPageProxy::initializeFindMatchesClient): Deleted.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::findMatchesClient):
- WebKit2.xcodeproj/project.pbxproj:
- 5:02 PM Changeset in webkit [191414] by
-
- 2 edits in trunk/Source/WebKit2
WebProcess crashes when accessibility bundle is not found.
https://bugs.webkit.org/show_bug.cgi?id=150414
Reviewed by Dan Bernstein.
The uninitialized pointer to NSError causes the print function to crash.
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::registerWithAccessibility):
- 4:54 PM Changeset in webkit [191413] by
-
- 4 edits in trunk/Source/WebKit/win
Simplify context menu handling on Windows
https://bugs.webkit.org/show_bug.cgi?id=150423
Reviewed by Tim Horton.
Instead of converting a ContextMenu to a HMENU, then back to a ContextMenu, and then back to a HMENU again
just convert it once right before showing it and let the UIDelegate return a new menu at at time where we don't
have to convert it back.
- WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::customizeMenu):
- WebView.cpp:
(WebView::createContextMenu):
(WebView::handleContextMenuEvent):
- WebView.h:
- 4:14 PM Changeset in webkit [191412] by
-
- 3 edits in trunk/Source/WebKit2
Move services menu handling out into a separate function
https://bugs.webkit.org/show_bug.cgi?id=150420
Reviewed by Tim Horton.
- UIProcess/mac/WebContextMenuProxyMac.h:
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showServicesMenu):
(WebKit::WebContextMenuProxyMac::show):
(WebKit::WebContextMenuProxyMac::showContextMenu):
(WebKit::WebContextMenuProxyMac::populate): Deleted.
- 4:10 PM Changeset in webkit [191411] by
-
- 13 edits3 deletes in tags/Safari-602.1.8
Roll out r191360. rdar://problem/23205990
- 4:05 PM Changeset in webkit [191410] by
-
- 2 edits in trunk/Tools
run-webkit-tests does not copy all crash logs for layout test failures on Mac
https://bugs.webkit.org/show_bug.cgi?id=150407
<rdar://problem/22239750>
Patch by Aakash Jain <aakash_jain@apple.com> on 2015-10-21
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/port/mac.py:
(MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
(MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
the log directory.
(MacPort.look_for_new_crash_logs): Uses above method to get crash logs
from log directory and merge them with the list of already crashed tests.
- 3:30 PM Changeset in webkit [191409] by
-
- 3 edits in trunk/Source/WebKit2
Single tapping clickable elements in unscalable pages should show a tap highlight
https://bugs.webkit.org/show_bug.cgi?id=150382
Reviewed by Simon Fraser.
When the double tap gesture recognizer is disabled ahead of time (as in the case of unscalable pages) the tap is
committed before the geometries come in. To fix this, we introduce a flag that allows the single tap to be
committed before the tap highlight arrives. This allows the tap highlight to be immediately animated when receiving
the tap highlight geometries only in the case where double tapping is disabled when recognizing the single tap.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]):
(-[WKContentView _singleTapRecognized:]):
(-[WKContentView _singleTapCommited:]):
- 3:30 PM Changeset in webkit [191408] by
-
- 10 edits in trunk/Source/WebKit2
Get rid of useBinaryEncoding from WKPageGetContentsAsMHTMLData
https://bugs.webkit.org/show_bug.cgi?id=150417
Reviewed by Tim Horton.
The useBinaryEncoding parameter is always false, so just get rid of it.
- UIProcess/API/C/WKPage.cpp:
(WKPageGetContentsAsMHTMLData):
- UIProcess/API/C/WKPage.h:
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_page_contents_get):
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_save):
(webkit_web_view_save_to_file):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getContentsAsMHTMLData):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getContentsAsMHTMLData):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 3:17 PM Changeset in webkit [191407] by
-
- 3 edits in trunk/Source/WebKit2
WebContextMenuProxyMac::setupServicesMenu doesn't need to take a context parameter
https://bugs.webkit.org/show_bug.cgi?id=150418
Reviewed by Tim Horton.
- UIProcess/mac/WebContextMenuProxyMac.h:
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
(WebKit::WebContextMenuProxyMac::populate):
- 3:14 PM Changeset in webkit [191406] by
-
- 10 edits in trunk
[INTL] Implement Intl.Collator.prototype.resolvedOptions ()
https://bugs.webkit.org/show_bug.cgi?id=147601
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
This patch implements Intl.Collator.prototype.resolvedOptions() according
to the ECMAScript 2015 Internationalization API spec (ECMA-402 2nd edition.)
It also implements the abstract operations InitializeCollator, ResolveLocale,
LookupMatcher, and BestFitMatcher.
- runtime/CommonIdentifiers.h:
- runtime/IntlCollator.h:
(JSC::IntlCollator::usage):
(JSC::IntlCollator::setUsage):
(JSC::IntlCollator::locale):
(JSC::IntlCollator::setLocale):
(JSC::IntlCollator::collation):
(JSC::IntlCollator::setCollation):
(JSC::IntlCollator::numeric):
(JSC::IntlCollator::setNumeric):
(JSC::IntlCollator::sensitivity):
(JSC::IntlCollator::setSensitivity):
(JSC::IntlCollator::ignorePunctuation):
(JSC::IntlCollator::setIgnorePunctuation):
- runtime/IntlCollatorConstructor.cpp:
(JSC::sortLocaleData):
(JSC::searchLocaleData):
(JSC::initializeCollator):
(JSC::constructIntlCollator):
(JSC::callIntlCollator):
- runtime/IntlCollatorPrototype.cpp:
(JSC::IntlCollatorPrototypeFuncResolvedOptions):
- runtime/IntlObject.cpp:
(JSC::defaultLocale):
(JSC::getIntlBooleanOption):
(JSC::getIntlStringOption):
(JSC::removeUnicodeLocaleExtension):
(JSC::lookupMatcher):
(JSC::bestFitMatcher):
(JSC::resolveLocale):
(JSC::lookupSupportedLocales):
- runtime/IntlObject.h:
LayoutTests:
- js/intl-collator-expected.txt:
- js/script-tests/intl-collator.js:
(testCollator):
- 3:08 PM Changeset in webkit [191405] by
-
- 1 copy in tags/Safari-602.1.8
New tag.
- 2:49 PM Changeset in webkit [191404] by
-
- 9 edits in trunk/Source/JavaScriptCore
C calls in PolymorphicAccess shouldn't assume that the top of the stack looks like a JSC JIT frame and enable *ByIdFlush in FTL
https://bugs.webkit.org/show_bug.cgi?id=125711
Reviewed by Filip Pizlo.
This patch ensures that anytime we need to make a C call inside
PolymorphicAccess, we ensure there is enough space on the stack to do so.
This patch also enables GetByIdFlush/PutByIdFlush inside the FTL.
Because PolymorphicAccess now spills the necessary registers
before making a JS/C call, any registers that LLVM report as
being in use for the patchpoint will be spilled before making
a call by PolymorphicAccess.
- bytecode/PolymorphicAccess.cpp:
(JSC::AccessGenerationState::restoreScratch):
(JSC::AccessGenerationState::succeed):
(JSC::AccessGenerationState::calculateLiveRegistersForCallAndExceptionHandling):
(JSC::AccessCase::generate):
(JSC::PolymorphicAccess::regenerate):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileNode):
(JSC::FTL::DFG::LowerDFGToLLVM::compileGetById):
(JSC::FTL::DFG::LowerDFGToLLVM::emitStoreBarrier):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitTypeOf):
(JSC::AssemblyHelpers::makeSpaceOnStackForCCall):
(JSC::AssemblyHelpers::reclaimSpaceOnStackForCCall):
- jit/RegisterSet.cpp:
(JSC::RegisterSet::webAssemblyCalleeSaveRegisters):
(JSC::RegisterSet::registersToNotSaveForJSCall):
(JSC::RegisterSet::registersToNotSaveForCCall):
(JSC::RegisterSet::allGPRs):
(JSC::RegisterSet::registersToNotSaveForCall): Deleted.
- jit/RegisterSet.h:
(JSC::RegisterSet::set):
- jit/ScratchRegisterAllocator.cpp:
(JSC::ScratchRegisterAllocator::allocateScratchGPR):
(JSC::ScratchRegisterAllocator::allocateScratchFPR):
(JSC::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
These methods now take an extra parameter indicating if they
should create space for a C call at the top of the stack if
there are any reused registers to spill.
(JSC::ScratchRegisterAllocator::usedRegistersForCall):
- jit/ScratchRegisterAllocator.h:
(JSC::ScratchRegisterAllocator::usedRegisters):
- 2:45 PM Changeset in webkit [191403] by
-
- 4 edits2 adds in trunk
Null dereference loading Blink layout test svg/filters/display-none-filter-primitive.html
https://bugs.webkit.org/show_bug.cgi?id=150212
<rdar://problem/23137376>
Reviewed by Brent Fulgham.
Source/WebCore:
Handle the case where a filter element doesn't have a renderer. Inspired by the Blink
commit:
https://chromium.googlesource.com/chromium/src.git/+/fb79f7fc46552d45127acd2959a23662ad8f271e
Test: svg/filters/display-none-filter-primitive.html
- rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::buildPrimitives):
- svg/graphics/filters/SVGFilterBuilder.cpp:
(WebCore::SVGFilterBuilder::appendEffectToEffectReferences):
LayoutTests:
- svg/filters/display-none-filter-primitive-expected.txt: Added.
- svg/filters/display-none-filter-primitive.html: Added.
- 2:26 PM Changeset in webkit [191402] by
-
- 11 edits in trunk/Source/WebKit2
WebContextMenuProxy doesn't have to be ref-counted
https://bugs.webkit.org/show_bug.cgi?id=150415
Reviewed by Tim Horton.
Change WebContextMenuProxy to not inherit from RefCounted. Instead of using RefPtr, use std::unique_ptr.
Get rid of cancelTracking and hideContextMenu and dismiss the menu whenever the menu proxy is destroyed.
Also, rename showContextMenu to show.
- UIProcess/PageClient.h:
- UIProcess/WebContextMenuProxy.h:
(WebKit::WebContextMenuProxy::cancelTracking): Deleted.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::internalShowContextMenu):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::createContextMenuProxy):
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::createContextMenuProxy):
- UIProcess/mac/WebContextMenuProxyMac.h:
(WebKit::WebContextMenuProxyMac::create): Deleted.
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::~WebContextMenuProxyMac):
(WebKit::WebContextMenuProxyMac::show):
(WebKit::WebContextMenuProxyMac::showContextMenu): Deleted.
(WebKit::WebContextMenuProxyMac::hideContextMenu): Deleted.
(WebKit::WebContextMenuProxyMac::cancelTracking): Deleted.
- 2:04 PM Changeset in webkit [191401] by
-
- 3 edits in trunk/Source/WebKit2
Stop using a popup menu button cell(!) for context menus
https://bugs.webkit.org/show_bug.cgi?id=150413
Reviewed by Tim Horton.
Just use a regular NSMenu. Also, have the service menu code path store the service menu
in the same member variable.
- UIProcess/mac/WebContextMenuProxyMac.h:
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
(WebKit::WebContextMenuProxyMac::clearServicesMenu):
(WebKit::WebContextMenuProxyMac::populate):
(WebKit::WebContextMenuProxyMac::showContextMenu):
(WebKit::WebContextMenuProxyMac::hideContextMenu):
(WebKit::WebContextMenuProxyMac::cancelTracking):
(WebKit::WebContextMenuProxyMac::~WebContextMenuProxyMac): Deleted.
- 1:22 PM Changeset in webkit [191400] by
-
- 30 edits2 copies4 adds in trunk
Modern IDB: Add basic transaction aborting.
https://bugs.webkit.org/show_bug.cgi?id=150148
Reviewed by Alex Christensen.
Source/WebCore:
Tests: storage/indexeddb/modern/double-abort.html
storage/indexeddb/modern/versionchange-abort-then-reopen.html
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IndexedDB.h:
- Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::abortTransaction):
(WebCore::IDBClient::IDBConnectionToServer::didAbortTransaction):
- Modules/indexeddb/client/IDBConnectionToServer.h:
- Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
- Modules/indexeddb/client/IDBDatabaseImpl.cpp:
(WebCore::IDBClient::IDBDatabase::abortTransaction):
(WebCore::IDBClient::IDBDatabase::didCommitOrAbortTransaction):
- Modules/indexeddb/client/IDBDatabaseImpl.h:
- Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::IDBTransaction):
(WebCore::IDBClient::IDBTransaction::abort):
(WebCore::IDBClient::IDBTransaction::isFinishedOrFinishing):
(WebCore::IDBClient::IDBTransaction::activationTimerFired):
(WebCore::IDBClient::IDBTransaction::didAbort):
- Modules/indexeddb/client/IDBTransactionImpl.h:
- Modules/indexeddb/server/IDBBackingStore.h:
- Modules/indexeddb/server/IDBConnectionToClient.cpp:
(WebCore::IDBServer::IDBConnectionToClient::didAbortTransaction):
- Modules/indexeddb/server/IDBConnectionToClient.h:
- Modules/indexeddb/server/IDBConnectionToClientDelegate.h:
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::abortTransaction):
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:
(WebCore::IDBServer::MemoryBackingStoreTransaction::create):
(WebCore::IDBServer::MemoryBackingStoreTransaction::MemoryBackingStoreTransaction):
(WebCore::IDBServer::MemoryBackingStoreTransaction::~MemoryBackingStoreTransaction):
(WebCore::IDBServer::MemoryBackingStoreTransaction::abort):
(WebCore::IDBServer::MemoryBackingStoreTransaction::commit):
- Modules/indexeddb/server/MemoryBackingStoreTransaction.h:
(WebCore::IDBServer::MemoryBackingStoreTransaction::isVersionChange):
- Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::setDatabaseInfo):
(WebCore::IDBServer::MemoryIDBBackingStore::beginTransaction):
(WebCore::IDBServer::MemoryIDBBackingStore::abortTransaction):
(WebCore::IDBServer::MemoryIDBBackingStore::commitTransaction):
- Modules/indexeddb/server/MemoryIDBBackingStore.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::startVersionChangeTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::beginTransactionInBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::performCommitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformCommitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::performAbortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformAbortTransaction):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::didAbortTransaction):
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::UniqueIDBDatabaseTransaction):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::originalDatabaseInfo):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::abort):
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:
- Modules/indexeddb/shared/IDBError.cpp:
(WebCore::idbErrorName):
(WebCore::idbErrorDescription):
- Modules/indexeddb/shared/IDBError.h:
- Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::didAbortTransaction):
(WebCore::InProcessIDBServer::abortTransaction):
- Modules/indexeddb/shared/InProcessIDBServer.h:
LayoutTests:
- storage/indexeddb/modern/double-abort-expected.txt: Added.
- storage/indexeddb/modern/double-abort.html: Added.
- storage/indexeddb/modern/versionchange-abort-then-reopen-expected.txt: Added.
- storage/indexeddb/modern/versionchange-abort-then-reopen.html: Added.
- 1:07 PM Changeset in webkit [191399] by
-
- 10 edits1 copy in trunk/Source/WebInspectorUI
Web Inspector: Use some CSS Variables in Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=150405
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-21
Reviewed by Timothy Hatcher.
- UserInterface/Main.html:
Include the new variables stylesheet.
- UserInterface/Views/Variables.css: Added.
(:root):
Introduce new global variables.
- UserInterface/Views/CSSStyleDeclarationTextEditor.css:
(.css-style-text-editor > .CodeMirror .cm-link):
- UserInterface/Views/ConsoleMessageView.css:
(.console-message-preview-divider):
(.console-message-enclosed):
(.console-message .console-message-extra-parameters-container > li::before):
(.console-saved-variable):
- UserInterface/Views/DOMTreeOutline.css:
(.dom-tree-outline li.selected > span::after):
- UserInterface/Views/FormattedValue.css:
(:matches(.formatted-array, .formatted-map, .formatted-set, .formatted-weakmap, .formatted-weakset) > .size):
(.formatted-number):
(.formatted-boolean):
(.formatted-string):
(.formatted-regexp):
(.formatted-symbol):
- UserInterface/Views/ObjectPreviewView.css:
(.object-preview > .size):
- UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
(.object-tree-array-index .index-name):
- UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
(.syntax-highlighted :matches(.css-keyword, .css-tag, .css-at-rule, .css-important, .javascript-keyword, .html-tag)):
(.syntax-highlighted :matches(.css-number, .javascript-number)):
(.syntax-highlighted :matches(.css-string, .javascript-string, .html-attribute-value)):
(.syntax-highlighted .javascript-regexp):
- UserInterface/Views/TypeTokenView.css:
(.type-token-symbol):
Make use of variables.
- 1:04 PM Changeset in webkit [191398] by
-
- 5 edits in trunk
bgsound should use HTMLUnknownElement interface
https://bugs.webkit.org/show_bug.cgi?id=148857
<rdar://problem/22589036>
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline a couple of W3C HTML tests now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/semantics/interfaces-expected.txt:
Source/WebCore:
The blink, bgsound, isindex, multicol, nextid, and spacer elements must
use the HTMLUnknownElement interface, as per the HTML specification:
https://html.spec.whatwg.org/multipage/obsolete.html#other-elements,-attributes-and-apis
WebKit was using HTMLUnknownElement for all of them except bgsound.
This patch fixes the issue and aligns our behavior with Chrome and
Firefox.
No new tests, already covered by existing tests.
- html/HTMLTagNames.in:
- 12:56 PM Changeset in webkit [191397] by
-
- 2 edits in trunk/Source/JavaScriptCore
Web Inspector: Array previews with Symbol objects have too few preview values
https://bugs.webkit.org/show_bug.cgi?id=150404
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-21
Reviewed by Timothy Hatcher.
- inspector/InjectedScriptSource.js:
(InjectedScript.RemoteObject.prototype._appendPropertyPreviews):
We should be continuing inside this loop not returning.
- 11:53 AM Changeset in webkit [191396] by
-
- 5 edits in trunk/Source
Versioning.
- 11:45 AM Changeset in webkit [191395] by
-
- 6 edits in trunk
Failures in PutStackSinkingPhase should be less severe
https://bugs.webkit.org/show_bug.cgi?id=150400
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Make the PutStackSinkingPhase abort instead of asserting. To test that it's OK to not have
PutStackSinkingPhase run, this adds a test mode where we run without PutStackSinkingPhase.
- dfg/DFGPlan.cpp: Make it possible to not run PutStackSinkingPhase for tests.
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGPutStackSinkingPhase.cpp: PutStackSinkingPhase should abort instead of asserting, except when validation is enabled.
- runtime/Options.h: Add an option for disabling PutStackSinkingPhase.
Tools:
Add a test mode for no PutStackSinkingPhase.
- Scripts/run-jsc-stress-tests:
- 11:44 AM Changeset in webkit [191394] by
-
- 10 edits in trunk/Source/JavaScriptCore
The FTL should place the CallSiteIndex on the call frame for JS calls when it fills in the patchpoint
https://bugs.webkit.org/show_bug.cgi?id=150104
Reviewed by Filip Pizlo.
We lower JS Calls to patchpoints in LLVM. LLVM may decide to duplicate
these patchpoints (or remove them). We eagerly store the CallSiteIndex on the
call frame when lowering DFG to LLVM. But, because the patchpoint we lower to may
be duplicated, we really don't know the unique CallSiteIndex until we've
actually seen the resulting patchpoints after LLVM has completed its transformations.
To solve this, we now store the unique CallSiteIndex on the call frame header
when generating code to fill into the patchpoint.
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
- ftl/FTLJSCall.cpp:
(JSC::FTL::JSCall::JSCall):
(JSC::FTL::JSCall::emit):
- ftl/FTLJSCall.h:
(JSC::FTL::JSCall::stackmapID):
- ftl/FTLJSCallBase.cpp:
(JSC::FTL::JSCallBase::JSCallBase):
(JSC::FTL::JSCallBase::emit):
(JSC::FTL::JSCallBase::link):
- ftl/FTLJSCallBase.h:
- ftl/FTLJSCallVarargs.cpp:
(JSC::FTL::JSCallVarargs::JSCallVarargs):
(JSC::FTL::JSCallVarargs::numSpillSlotsNeeded):
(JSC::FTL::JSCallVarargs::emit):
- ftl/FTLJSCallVarargs.h:
(JSC::FTL::JSCallVarargs::node):
(JSC::FTL::JSCallVarargs::stackmapID):
- ftl/FTLJSTailCall.cpp:
(JSC::FTL::JSTailCall::JSTailCall):
(JSC::FTL::m_instructionOffset):
(JSC::FTL::JSTailCall::emit):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToLLVM::callPreflight):
(JSC::FTL::DFG::LowerDFGToLLVM::codeOriginDescriptionOfCallSite):
(JSC::FTL::DFG::LowerDFGToLLVM::callCheck):
- 11:42 AM Changeset in webkit [191393] by
-
- 2 edits in trunk/Source/JavaScriptCore
Date creation should share a little code
https://bugs.webkit.org/show_bug.cgi?id=150399
Reviewed by Filip Pizlo.
I want to fix a bug in this code, but I don't want to fix it in two
different places. (See https://bugs.webkit.org/show_bug.cgi?id=150386.)
- runtime/DateConstructor.cpp:
(JSC::DateConstructor::getOwnPropertySlot):
(JSC::milliseconds): Factored out a shared helper function. If you look
closely, you'll see that one copy of this code previously checked isfinite
while the other checked isnan. isnan returning nan was obviously a no-op,
so I removed it. isfinite, it turns out, is also a no-op -- but less
obviously so, so I kept it for now.
(JSC::constructDate):
(JSC::dateUTC): Use the helper function.
- 11:29 AM Changeset in webkit [191392] by
-
- 5 edits2 copies2 moves in trunk
Support for the SVG
onendattribute
https://bugs.webkit.org/show_bug.cgi?id=150393
Patch by Antoine Quint <Antoine Quint> on 2015-10-21
Reviewed by Dean Jackson.
Source/WebCore:
Add support for the SVG
onendattribute to SVG timing and animation elements, which allow the definition
of a JS event listener declaratively for the SVGendEventevent.
Tests: svg/animations/end-event-attribute-expected.svg
svg/animations/end-event-attribute.svg
svg/animations/end-event-syncbase-expected.svg
svg/animations/end-event-syncbase.svg
- dom/EventNames.h:
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::parseAttribute):
- svg/svgattrs.in:
LayoutTests:
Create a new test for the
onendattribute and rename the previously-named "end-event-declarative.svg" test to
"end-event-syncbase.svg" since the term "declarative" was a little loose.
- svg/animations/end-event-attribute-expected.svg: Copied from LayoutTests/svg/animations/end-event-declarative-expected.svg.
- svg/animations/end-event-attribute.svg: Copied from LayoutTests/svg/animations/end-event-declarative.svg.
- svg/animations/end-event-syncbase-expected.svg: Renamed from LayoutTests/svg/animations/end-event-declarative-expected.svg.
- svg/animations/end-event-syncbase.svg: Renamed from LayoutTests/svg/animations/end-event-declarative.svg.
- 10:46 AM Changeset in webkit [191391] by
-
- 9 edits2 moves in trunk
AX: Expose table size and cell indexes on iOS
https://bugs.webkit.org/show_bug.cgi?id=150366
Source/WebCore:
Add support to expose table row/column count and cell indexes on iOS.
Reviewed by Chris Fleizach.
Test: accessibility/aria-table-attributes.html
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper tableParent]):
(-[WebAccessibilityObjectWrapper accessibilityElementForRow:andColumn:]):
(-[WebAccessibilityObjectWrapper accessibilityRowCount]):
(-[WebAccessibilityObjectWrapper accessibilityColumnCount]):
(-[WebAccessibilityObjectWrapper accessibilityARIARowCount]):
(-[WebAccessibilityObjectWrapper accessibilityARIAColumnCount]):
(-[WebAccessibilityObjectWrapper accessibilityARIARowIndex]):
(-[WebAccessibilityObjectWrapper accessibilityARIAColumnIndex]):
(-[WebAccessibilityObjectWrapper accessibilityRowRange]):
Tools:
Reviewed by Chris Fleizach.
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
(AccessibilityUIElement::indexInTable):
(AccessibilityUIElement::numberAttributeValue):
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::indexInTable):
LayoutTests:
Reviewed by Chris Fleizach.
- accessibility/aria-table-attributes-expected.txt: Added.
- accessibility/aria-table-attributes.html: Added.
- accessibility/mac/aria-table-attributes-expected.txt: Removed.
- accessibility/mac/aria-table-attributes.html: Removed.
- platform/gtk/TestExpectations:
- platform/ios-simulator/TestExpectations:
- platform/win/TestExpectations:
- 10:12 AM Changeset in webkit [191390] by
-
- 2 edits in trunk/Source/WebKit2
Add assertions to NetworkCache::Entry constructor to make sure a key's type is "resource"
https://bugs.webkit.org/show_bug.cgi?id=150369
Reviewed by Antti Koivisto.
Add assertions to NetworkCache::Entry constructor to make sure a key's
type is "resource" now that the NetworkCache storage supports other
types of entries.
- NetworkProcess/cache/NetworkCacheEntry.cpp:
(WebKit::NetworkCache::Entry::Entry):
- 10:12 AM WebKitNightlyElCapWorkaround edited by
- (diff)
- 10:08 AM Changeset in webkit [191389] by
-
- 2 edits in trunk/Source/JavaScriptCore
llint: align stack pointer on mips too
[MIPS] LLInt: align stack pointer on MIPS too
https://bugs.webkit.org/show_bug.cgi?id=150380
Patch by Guillaume Emont <guijemont@igalia.com> on 2015-10-21
Reviewed by Michael Saboff.
- llint/LowLevelInterpreter32_64.asm:
- 10:00 AM Changeset in webkit [191388] by
-
- 7 edits2 adds in trunk
HTMLIFrameElement.sandbox should be a DOMSettableTokenList
https://bugs.webkit.org/show_bug.cgi?id=150377
Reviewed by Ryosuke Niwa.
Source/WebCore:
HTMLIFrameElement.sandbox should be a DOMSettableTokenList as per the
HTML specification:
Chrome and Firefox match the specification but Safari/WebKit was uding
a DOMString.
Test: fast/frames/sandbox-attribute.html
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::sandbox):
(WebCore::HTMLIFrameElement::parseAttribute):
- html/HTMLIFrameElement.h:
- html/HTMLIFrameElement.idl:
LayoutTests:
- fast/frames/sandbox-attribute-expected.txt: Added.
- fast/frames/sandbox-attribute.html: Added.
Add layout test to check that HTMLIframeElement.sandbox is now a
DOMSettableTokenList.
- fast/frames/sandboxed-iframe-navigation-allowed-expected.txt:
- fast/frames/sandboxed-iframe-navigation-allowed.html:
Update test that was using shouldBe() with HTMLIframeElement.sandbox.
shouldBe() does an === check but which now fails before
HTMLIframeElement.sandbox is now a DOMSettableTokenList that can be
stringified, rather than a String.
- 6:36 AM Changeset in webkit [191387] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Typo in a property name: style.inerhited
https://bugs.webkit.org/show_bug.cgi?id=150391
Reviewed by Csaba Osztrogonác.
- UserInterface/Views/RulesStyleDetailsPanel.js:
(WebInspector.RulesStyleDetailsPanel.prototype.refresh):
- 5:52 AM Changeset in webkit [191386] by
-
- 4 edits in trunk/Source/WebCore
ASSERTION FAILED: markFontData in FontCascade::emphasisMarkHeight
https://bugs.webkit.org/show_bug.cgi?id=150171
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2015-10-21
Reviewed by Myles C. Maxfield.
It happens with several tests like fast/ruby/text-emphasis.html in
the GTK Debug bot. The tests seem to pass in Release and the rendering
looks correct as well removing the assert. The thing is that
for some reason we can get an empty GlyphData from
FontCascade::getEmphasisMarkGlyphData() when it ends up falling
back to system (FontCascadeFonts::glyphDataForSystemFallback).
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::getEmphasisMarkGlyphData): Return
Optional<GlyphData> instead of returning a boolean and an out
parameter. If we get an invalid GlyphData, Nullopt is
returned. Also use a SurrogatePairAwareTextIterator to handle
surrogate pairs.
(WebCore::FontCascade::emphasisMarkAscent):
(WebCore::FontCascade::emphasisMarkDescent):
(WebCore::FontCascade::emphasisMarkHeight):
(WebCore::FontCascade::drawEmphasisMarks):
- platform/graphics/FontCascade.h:
- platform/graphics/GlyphPage.h:
(WebCore::GlyphData::isValid): Return whether the GlyphData is valid.
- 4:47 AM Changeset in webkit [191385] by
-
- 3 edits2 adds in trunk
Source/WebCore:
[css-grid] Fix availableLogicalSpace computation with non-zero baseSize flex tracks
https://bugs.webkit.org/show_bug.cgi?id=150359
Reviewed by Zalan Bujtas.
The availableLogicalSpace computation was incorrect whenever
the flex tracks had a non-zero baseSize before the 1fr unit
size resolution. That happened because when assigning the new
baseSize to the flex track, we were unconditionally
subtracting the whole baseSize to the
availableLogicalSpace. That's correct if the track is a "pure"
flex track, i.e. 2fr, but if the track had a non-zero baseSize
(like minmax(10px, 1fr)) then both the new and the old base
sizes were incorrectly used to compute the
availableLogicalSpace.
We can test the amount of remaining freeSpace by using content
distribution to align and item place on a non-zero baseSize
flex track. The content distribution will be accurate if and
only if the availableLogicalSpace computation is correct.
Test: fast/css-grid-layout/flex-content-distribution.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
LayoutTests:
[css-grid] Fix freeSpace computation with non-zero baseSize flex tracks
https://bugs.webkit.org/show_bug.cgi?id=150359
Reviewed by Zalan Bujtas.
- fast/css-grid-layout/flex-content-distribution-expected.txt: Added.
- fast/css-grid-layout/flex-content-distribution.html: Added.
- 1:52 AM Changeset in webkit [191384] by
-
- 2 edits in trunk/LayoutTests
Remove commented lines in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=150387
Unreviewed.
- TestExpectations: remove commented lines introduced in bug 150331 bug.
- 1:34 AM Changeset in webkit [191383] by
-
- 22 edits1 copy in trunk
[Streams API] Construct a writable stream
https://bugs.webkit.org/show_bug.cgi?id=150360
Reviewed by Darin Adler.
Source/WebCore:
This patch initializes a writable stream according to the spec. To do it we need two internal functions, which
are syncWritableStreamStateWithQueue and errorWritableStream, which are also implemented as a quite direct
translation from the spec.
Current test set suffices, expectations are updated accordingly.
- CMakeLists.txt:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/WebCoreBuiltinNames.h:
- bindings/js/WebCoreJSBuiltinInternals.h:
- bindings/js/WebCoreJSBuiltins.cpp:
- bindings/js/WebCoreJSBuiltins.h: Build infrastructure.
- Modules/streams/WritableStream.js:
(initializeWritableStream): Function that acts as constructor of WritableStream.
- Modules/streams/WritableStreamInternals.js:
(syncWritableStreamStateWithQueue):
(errorWritableStream): As per spec.
LayoutTests:
Expectations for the writable stream initialization.
- streams/reference-implementation/bad-strategies-expected.txt:
- streams/reference-implementation/bad-underlying-sinks-expected.txt:
- streams/reference-implementation/brand-checks-expected.txt:
- streams/reference-implementation/byte-length-queuing-strategy-expected.txt:
- streams/reference-implementation/count-queuing-strategy-expected.txt:
- streams/reference-implementation/pipe-through-expected.txt:
- streams/reference-implementation/pipe-to-expected.txt:
- streams/reference-implementation/pipe-to-options-expected.txt:
- streams/reference-implementation/readable-stream-templated-expected.txt:
- streams/reference-implementation/writable-stream-abort-expected.txt:
- streams/reference-implementation/writable-stream-expected.txt:
- 1:18 AM Changeset in webkit [191382] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening. Test expectation for use-typo-metrics-1 on Mac and Windows should be "ImageOnlyFailure" not "Failure".
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- 1:08 AM Changeset in webkit [191381] by
-
- 24 edits in trunk/Source
NetworkProcess: DNS prefetch happens in the Web Process
https://bugs.webkit.org/show_bug.cgi?id=147824
Reviewed by Chris Dumez.
Source/WebCore:
Use FrameLoaderClient to do the DNS prefetch.
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):
- loader/EmptyClients.h:
- loader/FrameLoaderClient.h:
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLink):
- page/Chrome.cpp:
(WebCore::Chrome::mouseDidMoveOverElement):
Source/WebKit/mac:
Implement FrameLoaderClient::prefetchDNS().
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
Source/WebKit/win:
Implement FrameLoaderClient::prefetchDNS().
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::prefetchDNS):
- WebCoreSupport/WebFrameLoaderClient.h:
Source/WebKit2:
DNS prefetch requests started in the WebProcess should be sent to
the network process when it's enabled.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::prefetchDNS): Use NetworkProcess::prefetchDNS().
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in: Add
PrefetchDNS message.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::prefetchDNS): Do the actual DNS prefetch.
- NetworkProcess/NetworkProcess.h:
- WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:
(webkitWebExtensionDidReceiveMessage): Use WebProcess::prefetchDNS().
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::prefetchDNS): Use WebProcess::prefetchDNS().
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary): Use
FrameLoaderClient to do the DNS prefetch.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess): Initialize the DNS prefetched
hosts cleanup hysteresis activity. Clear the cache of DNS
prefetched when hysteresis activity stopped.
(WebKit::WebProcess::prefetchDNS): Send the request to the network
process if it's enabled, otherwise do the actual DNS prefetch.
- WebProcess/WebProcess.h:
- 12:53 AM Changeset in webkit [191380] by
-
- 8 edits in trunk
W3C test importer should not import reference files as regular tests
https://bugs.webkit.org/show_bug.cgi?id=150331
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- resources/ImportExpectations: Removed some Skip expectations as test importer no longer will handle these files as tests, but as reference files.
Tools:
Updated test_parser to return information that a file can be a referencefile or a manual test.
Updated test importer to skip those files.
Updated/Added test parser unit tests accordingly.
Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
to mark these files as Skip, since they are not direct tests.
- Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.init):
(TestImporter.find_importable_tests):
(TestImporter.import_tests):
- Scripts/webkitpy/w3c/test_parser.py:
(TestParser.analyze_test):
- Scripts/webkitpy/w3c/test_parser_unittest.py:
(test_analyze_non_html_file):
(test_reference_test):
LayoutTests:
- TestExpectations: Adding Skip expectations for web-platform-test resource files (currently commented out as not all are yet imported).
- 12:44 AM Changeset in webkit [191379] by
-
- 196 edits22 copies59 adds16 deletes in trunk/LayoutTests
Update web-platform-tests tests to the same revision as tools
https://bugs.webkit.org/show_bug.cgi?id=149656
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Syncing tests with WPT repository.
Some files previously in resources folder are now in not-resources folder.
Updated TestExpectations to skip those files.
web-platform-tests/dom/nodes/resources should be removed for a later patch.
- web-platform-tests/common/failing-test.html: Removed.
- web-platform-tests/common/w3c-import.log:
- web-platform-tests/dom/collections/HTMLCollection-supported-property-names.html:
- web-platform-tests/dom/collections/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/image-maps/w3c-import.log.
- web-platform-tests/dom/events/w3c-import.log: Added.
- web-platform-tests/dom/historical-expected.txt:
- web-platform-tests/dom/historical.html:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/interfaces.html:
- web-platform-tests/dom/lists/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-meter-element/w3c-import.log.
- web-platform-tests/dom/nodes/DOMImplementation-createDocument-expected.txt:
- web-platform-tests/dom/nodes/DOMImplementation-createDocument.html:
- web-platform-tests/dom/nodes/DOMImplementation-createHTMLDocument-expected.txt:
- web-platform-tests/dom/nodes/DOMImplementation-createHTMLDocument.html:
- web-platform-tests/dom/nodes/Document-adoptNode.html:
- web-platform-tests/dom/nodes/Document-characterSet-normalization-expected.txt:
- web-platform-tests/dom/nodes/Document-characterSet-normalization.html:
- web-platform-tests/dom/nodes/Document-constructor-expected.txt:
- web-platform-tests/dom/nodes/Document-constructor.html:
- web-platform-tests/dom/nodes/Document-contentType/contentType/w3c-import.log: Added.
- web-platform-tests/dom/nodes/Document-contentType/resources/w3c-import.log: Added.
- web-platform-tests/dom/nodes/Document-contentType/support/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/disabled-elements/w3c-import.log.
- web-platform-tests/dom/nodes/Document-createAttribute-expected.txt:
- web-platform-tests/dom/nodes/Document-createAttribute.html:
- web-platform-tests/dom/nodes/Document-createElement-namespace-expected.txt:
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_mathml.html: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_mathml.svg: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_mathml.xhtml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_mathml.xml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_svg.html: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_svg.svg: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_svg.xhtml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_svg.xml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_xhtml.html: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/blank.htm.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_xhtml.svg: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/blank.htm.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_xhtml.xhtml: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/blank.htm.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/bare_xhtml.xml: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/blank.htm.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.html: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.svg: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xhtml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/generate.py: Added.
(main):
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/mathml.html: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/mathml.svg: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/mathml.xhtml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/mathml.xml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/minimal_html.html: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/minimal_html.svg: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/minimal_html.xhtml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/minimal_html.xml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/svg.html: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/svg.svg: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/svg.xhtml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/svg.xml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/w3c-import.log: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml.html: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml.svg: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml.xhtml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml.xml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_changed.html: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_changed.svg: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_changed.xhtml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_changed.xml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_removed.html: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_removed.svg: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_removed.xhtml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/xhtml_ns_removed.xml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace.html:
- web-platform-tests/dom/nodes/Document-doctype.html:
- web-platform-tests/dom/nodes/Document-getElementById.html:
- web-platform-tests/dom/nodes/Element-matches.html:
- web-platform-tests/dom/nodes/MutationObserver-characterData-expected.txt:
- web-platform-tests/dom/nodes/MutationObserver-characterData.html:
- web-platform-tests/dom/nodes/Node-compareDocumentPosition.html:
- web-platform-tests/dom/nodes/Node-contains.html:
- web-platform-tests/dom/nodes/Node-lookupPrefix.xhtml:
- web-platform-tests/dom/nodes/Node-parentNode-iframe.html: Added.
- web-platform-tests/dom/nodes/Node-parentNode.html:
- web-platform-tests/dom/nodes/Node-properties-expected.txt:
- web-platform-tests/dom/nodes/Node-properties.html:
- web-platform-tests/dom/nodes/ParentNode-querySelector-All-content.html: Added.
- web-platform-tests/dom/nodes/ParentNode-querySelector-All-content.xht: Added.
- web-platform-tests/dom/nodes/ParentNode-querySelector-All.html:
- web-platform-tests/dom/nodes/getElementsByClassName-14.htm:
- web-platform-tests/dom/nodes/getElementsByClassName-28.htm:
- web-platform-tests/dom/nodes/w3c-import.log: Added.
- web-platform-tests/dom/ranges/w3c-import.log: Added.
- web-platform-tests/dom/traversal/TreeWalker-acceptNode-filter.html:
- web-platform-tests/dom/traversal/TreeWalker-basic.html:
- web-platform-tests/dom/traversal/TreeWalker-currentNode.html:
- web-platform-tests/dom/traversal/TreeWalker-previousNodeLastChildReject.html:
- web-platform-tests/dom/traversal/TreeWalker-previousSiblingLastChildSkip.html:
- web-platform-tests/dom/traversal/TreeWalker-traversal-reject.html:
- web-platform-tests/dom/traversal/TreeWalker-traversal-skip-most.html:
- web-platform-tests/dom/traversal/TreeWalker-traversal-skip.html:
- web-platform-tests/dom/traversal/TreeWalker-walking-outside-a-tree.html:
- web-platform-tests/dom/traversal/w3c-import.log: Added.
- web-platform-tests/dom/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/w3c-import.log.
- web-platform-tests/domparsing/DOMParser-parseFromString-html-expected.txt:
- web-platform-tests/domparsing/DOMParser-parseFromString-html.html:
- web-platform-tests/domparsing/w3c-import.log:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/w3c-import.log: Added.
- web-platform-tests/html/dom/documents/dom-tree-accessors/w3c-import.log: Added.
- web-platform-tests/html/dom/documents/resource-metadata-management/document-lastModified-01.html:
- web-platform-tests/html/dom/documents/resource-metadata-management/w3c-import.log: Added.
- web-platform-tests/html/dom/dynamic-markup-insertion/closing-the-input-stream/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/disabled-elements/w3c-import.log.
- web-platform-tests/html/dom/dynamic-markup-insertion/document-write/w3c-import.log: Added.
- web-platform-tests/html/dom/dynamic-markup-insertion/document-writeln/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/w3c-import.log.
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010-1.html: Added.
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010-2.html: Added.
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010.html: Added.
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/w3c-import.log: Added.
- web-platform-tests/html/dom/elements/content-models/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-meter-element/w3c-import.log.
- web-platform-tests/html/dom/elements/element-definitions/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log.
- web-platform-tests/html/dom/elements/elements-in-the-dom/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/disabled-elements/w3c-import.log.
- web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-001.html:
- web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-002.html:
- web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-003.html:
- web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-004.html:
- web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-005.html:
- web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-006.html:
- web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-007.html:
- web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-008.html:
- web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-009.html:
- web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-010.html:
- web-platform-tests/html/dom/elements/global-attributes/w3c-import.log: Added.
- web-platform-tests/html/dom/elements/wai-aria/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/image-maps/w3c-import.log.
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces.html:
- web-platform-tests/html/dom/w3c-import.log: Added.
- web-platform-tests/html/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-meter-element/w3c-import.log.
- web-platform-tests/html/semantics/disabled-elements/w3c-import.log:
- web-platform-tests/html/semantics/document-metadata/styling/support/w3c-import.log:
- web-platform-tests/html/semantics/document-metadata/the-base-element/base_multiple.html:
- web-platform-tests/html/semantics/document-metadata/the-base-element/example.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/resources/example.html.
- web-platform-tests/html/semantics/document-metadata/the-base-element/example2.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/resources/example2.html.
- web-platform-tests/html/semantics/document-metadata/the-base-element/w3c-import.log:
- web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-01-expected.txt:
- web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-01.html:
- web-platform-tests/html/semantics/document-metadata/the-link-element/w3c-import.log:
- web-platform-tests/html/semantics/document-metadata/the-meta-element/w3c-import.log:
- web-platform-tests/html/semantics/document-metadata/the-style-element/style-error-01-expected.txt:
- web-platform-tests/html/semantics/document-metadata/the-style-element/style-error-01.html:
- web-platform-tests/html/semantics/document-metadata/the-style-element/w3c-import.log:
- web-platform-tests/html/semantics/document-metadata/the-title-element/w3c-import.log:
- web-platform-tests/html/semantics/edits/the-del-element/w3c-import.log:
- web-platform-tests/html/semantics/edits/the-ins-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/image-maps/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/HTMLElement/HTMLMediaElement/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/HTMLElement/HTMLTrackElement/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCueList/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackList/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TrackEvent/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/offsets-into-the-media-resource/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/playing-the-media-resource/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/resources/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/user-interface/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-area-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-audio-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-embed-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_javascript_url_01.htm: Removed.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_script-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_script.html: Removed.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_01.html: Removed.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_02.html: Removed.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_03.html: Removed.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_04.html: Removed.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/resources/sandbox_allow_script.html: Removed.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/sandbox_allow_script.html: Removed.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/iframed.sub.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/sizes-iframed.sub.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-img-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-object-element/object-handler.html:
- web-platform-tests/html/semantics/embedded-content/the-object-element/test0.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-object-element/resources/test0.html.
- web-platform-tests/html/semantics/embedded-content/the-object-element/test1.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-object-element/resources/test1.html.
- web-platform-tests/html/semantics/embedded-content/the-object-element/test2.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-object-element/resources/test2.html.
- web-platform-tests/html/semantics/embedded-content/the-object-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-video-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-ltr-iframe.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/resources/dirname-ltr-iframe.html.
- web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-ltr.html:
- web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/w3c-import.log:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-tooLong-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-tooLong.html:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing.html:
- web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate.html:
- web-platform-tests/html/semantics/forms/constraints/support/validator.js:
(validator.test_reportValidity):
(validator.set_conditions):
(validator.set_dirty):
- web-platform-tests/html/semantics/forms/constraints/support/w3c-import.log:
- web-platform-tests/html/semantics/forms/constraints/w3c-import.log:
- web-platform-tests/html/semantics/forms/form-control-infrastructure/w3c-import.log:
- web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log:
- web-platform-tests/html/semantics/forms/introduction-1/w3c-import.log:
- web-platform-tests/html/semantics/forms/resetting-a-form/w3c-import.log:
- web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange-expected.txt:
- web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange.html:
- web-platform-tests/html/semantics/forms/textfieldselection/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-button-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-datalist-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-fieldset-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-form-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-input-element/input-textselection-01-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/input-textselection-01.html:
- web-platform-tests/html/semantics/forms/the-input-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-label-element/label-attributes.html:
- web-platform-tests/html/semantics/forms/the-label-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-legend-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-meter-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-option-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-output-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-progress-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-select-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-textarea-element/w3c-import.log:
- web-platform-tests/html/semantics/grouping-content/the-dd-element/w3c-import.log:
- web-platform-tests/html/semantics/grouping-content/the-div-element/w3c-import.log:
- web-platform-tests/html/semantics/grouping-content/the-dl-element/w3c-import.log:
- web-platform-tests/html/semantics/grouping-content/the-dt-element/w3c-import.log:
- web-platform-tests/html/semantics/grouping-content/the-figcaption-element/w3c-import.log:
- web-platform-tests/html/semantics/grouping-content/the-figure-element/w3c-import.log:
- web-platform-tests/html/semantics/grouping-content/the-hr-element/w3c-import.log:
- web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-002-ref-expected.html: Removed.
- web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-002-ref.html: Removed.
- web-platform-tests/html/semantics/grouping-content/the-li-element/w3c-import.log:
- web-platform-tests/html/semantics/grouping-content/the-ol-element/reversed-1a.html: Added.
- web-platform-tests/html/semantics/grouping-content/the-ol-element/reversed-1b.html: Added.
- web-platform-tests/html/semantics/grouping-content/the-ol-element/reversed-1c.html: Added.
- web-platform-tests/html/semantics/grouping-content/the-ol-element/w3c-import.log:
- web-platform-tests/html/semantics/grouping-content/the-p-element/w3c-import.log:
- web-platform-tests/html/semantics/grouping-content/the-pre-element/w3c-import.log:
- web-platform-tests/html/semantics/grouping-content/the-ul-element/w3c-import.log:
- web-platform-tests/html/semantics/interactive-elements/commands/w3c-import.log:
- web-platform-tests/html/semantics/interactive-elements/the-details-element/w3c-import.log:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/w3c-import.log:
- web-platform-tests/html/semantics/interactive-elements/the-menu-element/w3c-import.log:
- web-platform-tests/html/semantics/interfaces-expected.txt:
- web-platform-tests/html/semantics/interfaces.js:
- web-platform-tests/html/semantics/links/downloading-resources/w3c-import.log:
- web-platform-tests/html/semantics/links/linktypes/w3c-import.log:
- web-platform-tests/html/semantics/scripting-1/the-script-element/w3c-import.log:
- web-platform-tests/html/semantics/scripting-1/the-template-element/additions-to-parsing-xhtml-documents/w3c-import.log:
- web-platform-tests/html/semantics/scripting-1/the-template-element/additions-to-serializing-xhtml-documents/w3c-import.log:
- web-platform-tests/html/semantics/scripting-1/the-template-element/additions-to-the-css-user-agent-style-sheet/w3c-import.log:
- web-platform-tests/html/semantics/scripting-1/the-template-element/additions-to-the-steps-to-clone-a-node/w3c-import.log:
- web-platform-tests/html/semantics/scripting-1/the-template-element/definitions/template-contents-owner-document-type-expected.txt:
- web-platform-tests/html/semantics/scripting-1/the-template-element/definitions/template-contents-owner-document-type.html:
- web-platform-tests/html/semantics/scripting-1/the-template-element/definitions/w3c-import.log:
- web-platform-tests/html/semantics/scripting-1/the-template-element/innerhtml-on-templates/w3c-import.log:
- web-platform-tests/html/semantics/scripting-1/the-template-element/resources/w3c-import.log:
- web-platform-tests/html/semantics/scripting-1/the-template-element/serializing-html-templates/w3c-import.log:
- web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/template-descendant-frameset-expected.txt:
- web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/template-descendant-frameset.html:
- web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/w3c-import.log:
- web-platform-tests/html/semantics/sections/headings-and-sections/w3c-import.log:
- web-platform-tests/html/semantics/sections/the-h1-h2-h3-h4-h5-and-h6-elements/w3c-import.log:
- web-platform-tests/html/semantics/selectors/pseudo-classes/disabled-expected.txt:
- web-platform-tests/html/semantics/selectors/pseudo-classes/disabled.html:
- web-platform-tests/html/semantics/selectors/pseudo-classes/focus-iframe.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/resources/focus-iframe.html.
- web-platform-tests/html/semantics/selectors/pseudo-classes/focus.html:
- web-platform-tests/html/semantics/selectors/pseudo-classes/w3c-import.log:
- web-platform-tests/html/semantics/tabular-data/attributes-common-to-td-and-th-elements/w3c-import.log:
- web-platform-tests/html/semantics/tabular-data/processing-model-1/w3c-import.log:
- web-platform-tests/html/semantics/tabular-data/the-caption-element/w3c-import.log:
- web-platform-tests/html/semantics/tabular-data/the-table-element/w3c-import.log:
- web-platform-tests/html/semantics/tabular-data/the-tbody-element/w3c-import.log:
- web-platform-tests/html/semantics/tabular-data/the-tr-element/w3c-import.log:
- web-platform-tests/html/semantics/text-level-semantics/the-a-element/w3c-import.log:
- web-platform-tests/html/semantics/text-level-semantics/the-bdi-element/w3c-import.log:
- web-platform-tests/html/semantics/text-level-semantics/the-bdo-element/w3c-import.log:
- web-platform-tests/html/semantics/text-level-semantics/the-br-element/w3c-import.log:
- web-platform-tests/html/semantics/text-level-semantics/the-time-element/w3c-import.log:
- web-platform-tests/html/semantics/text-level-semantics/the-wbr-element/w3c-import.log:
- web-platform-tests/html/semantics/text-level-semantics/the-wbr-element/wbr-element-expected.html:
- web-platform-tests/html/semantics/text-level-semantics/the-wbr-element/wbr-element-ref.html: Removed.
- web-platform-tests/html/semantics/text-level-semantics/the-wbr-element/wbr-element.html:
- web-platform-tests/html/semantics/w3c-import.log:
LayoutTests:
- TestExpectations: Skipping imported resource files that are not in 'resources' folder.
- 12:05 AM Changeset in webkit [191378] by
-
- 5 edits3 adds in trunk
[FreeType] Add support for the USE_TYPO_METRICS flag
https://bugs.webkit.org/show_bug.cgi?id=150340
Reviewed by Martin Robinson.
Source/WebCore:
Test: fonts/use-typo-metrics-1.html
Make the FreeType backend use the typo metrics when the OS/2 USE_TYPO_METRICS flag is set.
Similar work should be done for other backends, see bug 131839.
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::Font::platformInit): Verify whether the OS/2 USE_TYPO_METRICS flag is set and use the typo metrics if that's the case.
LayoutTests:
Add a test to verify that the line height of a font is calculated from the typo metrics when the OS/2 USE_TYPO_METRICS flag is set. Currently, the test only passes with the FreeType backend.
- fonts/lineheight5000-typolineheight2300.woff: Added.
- fonts/use-typo-metrics-1-expected.html: Added.
- fonts/use-typo-metrics-1.html: Added.
- platform/mac/TestExpectations: Mark as failing.
- platform/win/TestExpectations: Mark as failing.
