Timeline
Oct 27, 2015:
- 10:20 PM Changeset in webkit [191658] by
-
- 4 edits in trunk
[Cairo] Incorrect dashed and dotted border painting after r177686.
https://bugs.webkit.org/show_bug.cgi?id=141967
Reviewed by Gyuyoung Kim.
Fix the incorrect dashed/dotted border painting in cairo.
Source/WebCore:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLine):
(WebCore::calculateStrokePatternOffset): Deleted.
(WebCore::drawLineOnCairoContext): Deleted.
LayoutTests:
- platform/gtk/TestExpectations: Removed the passed test.
- 10:19 PM Changeset in webkit [191657] by
-
- 3 edits in branches/safari-601-branch/Source/WebCore
Merge r191636. <rdar://problem/23078059>
- 10:19 PM Changeset in webkit [191656] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge r191525. <rdar://problem/23239748> FaradayDotTwo: CrashTracer: com.apple.WebKit.WebContent at ?re: WebCore::RenderObject::localToContainerQuad const + 132
- 10:19 PM Changeset in webkit [191655] by
-
- 6 edits in branches/safari-601-branch
Merge r191395. rdar://problem/22847057
- 10:19 PM Changeset in webkit [191654] by
-
- 2 edits in branches/safari-601-branch/Source/JavaScriptCore
Merge r187510. <rdar://problem/22847057> FaradayDotTwo: Safari crash in com.apple.JavaScriptCore: JSC::DFG::(anonymous namespace)::PutStackSinkingPhase::run + 47593
- 10:19 PM Changeset in webkit [191653] by
-
- 16 edits3 adds in branches/safari-601-branch
Merge r191530. rdar://problem/23206864
- 9:40 PM Changeset in webkit [191652] by
-
- 126 edits2 adds in trunk
id of iframe incorrectly sets window name
https://bugs.webkit.org/show_bug.cgi?id=150565
Reviewed by Darin Adler.
Source/WebCore:
As per the specification, the iframe's contentWindow name should be an
empty string if the frame's name attribute is unset:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-name
Instead, WebKit was using the iframe's id as window name if the name
was unset.
Firefox, IE and Chrome behave according to the specification.
This is a merge of the following Blink commit:
https://src.chromium.org/viewvc/blink?revision=169803&view=revision
Test: fast/frames/iframe-no-name.html
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseAttribute):
(WebCore::HTMLFrameElementBase::insertedInto): Deleted.
LayoutTests:
Add a test to check that id of iframe incorrectly sets the window name
when the iframe's name is not set.
Also set frame names in a lot of layout tests so that they keep giving
the same output.
- fast/css-generated-content/positioned-div-with-floating-after-content-crash.html:
- fast/dom/Window/slow-unload-handler-overwritten-date.html:
- fast/dom/Window/timeout-callback-scope.html:
- fast/dom/Window/window-access-after-navigation.html:
- fast/dom/Window/window-collection-length-no-crash.html:
- fast/dom/Window/window-special-properties-expected.txt:
- fast/dom/microtask-detach.html:
- fast/dom/microtask-inorder.html:
- fast/dom/microtask-reverse.html:
- fast/dom/wrapper-context.html:
- fast/dom/xss-DENIED-javascript-variations.html:
- fast/events/onbeforeunload-focused-iframe.html:
- fast/events/open-window-from-another-frame.html:
- fast/events/popup-blocked-to-post-blank.html:
- fast/events/popup-blocking-click-in-iframe.html:
- fast/events/popup-when-select-change.html:
- fast/frames/detach-frame-during-focus.html:
- fast/frames/frame-inherit-noresize-from-frameset.html:
- fast/frames/frame-programmatic-noresize.html:
- fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html:
- fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html:
- fast/frames/iframe-no-name-expected.txt: Added.
- fast/frames/iframe-no-name.html: Added.
- fast/frames/unload-reparent-sibling-frame.html:
- fast/history/form-submit-in-frame-via-onclick.html:
- fast/history/form-submit-in-frame.html:
- fast/history/same-document-iframes-changing-fragment.html:
- fast/history/same-document-iframes-changing-pushstate.html:
- fast/history/saves-state-after-frame-nav.html:
- fast/images/exif-orientation-image-document.html:
- fast/loader/resources/subframe-navigate-during-main-frame-load2.html:
- fast/overflow/scrollRevealButton.html:
- fast/parser/xml-colon-entity.html:
- fast/parser/xml-declaration-missing-ending-mark.html:
- fast/scrolling/latching/scroll-nested-iframe.html:
- fullscreen/full-screen-frameset.html:
- http/tests/contentextensions/block-cookies-in-csp-report.html:
- http/tests/contentextensions/block-cookies-in-ping.html:
- http/tests/contentextensions/block-cookies-send.html:
- http/tests/contentextensions/block-csp-report.html:
- http/tests/contentextensions/block-everything-unless-domain-iframe.html:
- http/tests/contentextensions/block-ping.html:
- http/tests/contentextensions/hide-on-csp-report.html:
- http/tests/contentextensions/hide-on-ping.html:
- http/tests/loading/text-content-type-with-binary-extension.html:
- http/tests/misc/location-replace-crossdomain.html:
- http/tests/multipart/multipart-wait-before-boundary.html:
- http/tests/navigation/no-referrer-subframe.html:
- http/tests/security/cross-frame-access-child-explicit-domain.html:
- http/tests/security/cross-frame-access-document-direct.html:
- http/tests/security/cross-frame-access-parent-explicit-domain.html:
- http/tests/security/cross-frame-access-port-explicit-domain.html:
- http/tests/security/cross-frame-access-port.html:
- http/tests/security/dataURL/resources/foreign-domain-data-url-accessee-iframe.html:
- http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-iframe.html:
- http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html:
- http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level.html:
- http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame.html:
- http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url.html:
- http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url.html:
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level.html:
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase.html:
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame.html:
- http/tests/security/host-compare-case-insensitive.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode.html:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS.html:
- http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessee-iframe.html:
- http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessor-iframe.html:
- http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame-2-level.html:
- http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame.html:
- http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-from-javscript-url.html:
- http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame.html:
- http/tests/security/protocol-compare-case-insensitive.html:
- http/tests/security/referrer-policy-redirect-link.html:
- http/tests/security/sandboxed-iframe-blocks-access-from-parent.html:
- http/tests/security/srcdoc-inherits-referrer-for-forms.html:
- http/tests/security/xssAuditor/full-block-base-href.html:
- http/tests/security/xssAuditor/full-block-iframe-javascript-url.html:
- http/tests/security/xssAuditor/full-block-iframe-no-inherit.php:
- http/tests/security/xssAuditor/full-block-javascript-link.html:
- http/tests/security/xssAuditor/full-block-link-onclick.html:
- http/tests/security/xssAuditor/full-block-object-tag.html:
- http/tests/security/xssAuditor/full-block-script-tag-cross-domain.html:
- http/tests/security/xssAuditor/full-block-script-tag-with-source.html:
- http/tests/security/xssAuditor/full-block-script-tag.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-1.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-2.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-3.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-4.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-5.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-6.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-7.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-8.html:
- http/tests/security/xssAuditor/malformed-xss-protection-header-9.html:
- http/tests/security/xssAuditor/report-script-tag-replace-state.html:
- http/tests/security/xssAuditor/report-script-tag.html:
- http/tests/security/xssAuditor/resources/utilities.js:
(sendRequestFromIFrame):
- http/tests/security/xssAuditor/xss-protection-parsing-02.html:
- http/tests/security/xssAuditor/xss-protection-parsing-03.html:
- http/tests/security/xssAuditor/xss-protection-parsing-04.html:
- platform/mac/webarchive/archive-empty-frame-dom-expected.txt:
- plugins/plugin-remove-subframe.html:
- webarchive/archive-empty-frame-dom-expected.webarchive:
- webarchive/archive-empty-frame-dom.html:
- 7:44 PM Changeset in webkit [191651] by
-
- 11 edits in trunk/Source
Web Inspector: Remove Timeline MarkDOMContent and MarkLoad, data is already available
https://bugs.webkit.org/show_bug.cgi?id=150615
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-27
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/protocol/Timeline.json:
Source/WebCore:
The timestamp only event data is already available from
Page.domContentEventFired
andPage.loadEventFiredevents. We can drop the Timeline specific events in
favor of these which have existed for a very long time (before iOS 7).
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::loadEventFiredImpl):
(WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl): Deleted.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent): Deleted.
(WebCore::InspectorTimelineAgent::didMarkLoadEvent): Deleted.
(WebCore::toProtocol): Deleted.
- inspector/InspectorTimelineAgent.h:
- inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createMarkData): Deleted.
- inspector/TimelineRecordFactory.h:
Source/WebInspectorUI:
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype._processEvent):
Remove the now unneed mark event handling.
(WebInspector.TimelineManager.prototype.pageDOMContentLoadedEventFired):
(WebInspector.TimelineManager.prototype.pageLoadEventFired):
Update the main frame and create markers for the current recording.
- UserInterface/Protocol/PageObserver.js:
(WebInspector.PageObserver.prototype.domContentEventFired):
(WebInspector.PageObserver.prototype.loadEventFired):
Forward to TimelineManager.
- 5:48 PM Changeset in webkit [191650] by
-
- 2 edits in trunk/Source/WebKit2
Fix the 32-bit build.
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::dragImageForView):
- 5:47 PM Changeset in webkit [191649] by
-
- 2 edits in trunk/Source/WebKit2
Fix the build.
- UIProcess/Cocoa/WebViewImpl.mm:
- 5:44 PM Changeset in webkit [191648] by
-
- 8 edits in trunk/Source/WebKit2
WKView being inside WKWebView leads to weird API issues
https://bugs.webkit.org/show_bug.cgi?id=150174
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView mouseDown:]):
(-[WKView mouseUp:]):
(-[WKView acceptsFirstMouse:]):
(-[WKView shouldDelayWindowOrderingForEvent:]):
(-[WKView pasteboardChangedOwner:]):
(-[WKView pasteboard:provideDataForType:]):
(-[WKView namesOfPromisedFilesDroppedAtDestination:]):
(-[WKView _startWindowDrag]):
(-[WKView _setMouseDownEvent:]): Deleted.
(-[WKView _colorSpace]): Deleted.
(-[WKView _dragImageForView:withImage:at:linkDrag:]): Deleted.
(matchesExtensionOrEquivalent): Deleted.
(-[WKView _setFileAndURLTypes:withExtension:withTitle:withURL:withVisibleURL:forPasteboard:]): Deleted.
(-[WKView _setPromisedDataForImage:withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:forPasteboard:]): Deleted.
(-[WKView _setPromisedDataForAttachment:withExtension:withTitle:withURL:withVisibleURL:forPasteboard:]): Deleted.
(fileExists): Deleted.
(pathWithUniqueFilenameForPath): Deleted.
(-[WKView spellCheckerDocumentTag]): Deleted.
(-[WKView handleAcceptedAlternativeText:]): Deleted.
(-[WKView initWithFrame:processPool:configuration:webView:]): Deleted.
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::handleAcceptedAlternativeText):
(WebKit::WebViewImpl::spellCheckerDocumentTag):
(WebKit::WebViewImpl::startWindowDrag):
(WebKit::WebViewImpl::dragImageForView):
(WebKit::matchesExtensionOrEquivalent):
(WebKit::WebViewImpl::setFileAndURLTypes):
(WebKit::WebViewImpl::setPromisedDataForImage):
(WebKit::WebViewImpl::setPromisedDataForAttachment):
(WebKit::WebViewImpl::pasteboardChangedOwner):
(WebKit::WebViewImpl::provideDataForPasteboard):
(WebKit::fileExists):
(WebKit::pathWithUniqueFilenameForPath):
(WebKit::WebViewImpl::namesOfPromisedFilesDroppedAtDestination):
(WebKit::WebViewImpl::setLastMouseDownEvent):
- UIProcess/mac/CorrectionPanel.h:
- UIProcess/mac/CorrectionPanel.mm:
(WebKit::CorrectionPanel::show):
(WebKit::CorrectionPanel::recordAutocorrectionResponse):
(WebKit::CorrectionPanel::handleAcceptedReplacement):
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::colorSpace):
(WebKit::PageClientImpl::setDragImage):
(WebKit::PageClientImpl::setPromisedDataForImage):
(WebKit::PageClientImpl::setPromisedDataForAttachment):
(WebKit::PageClientImpl::showCorrectionPanel):
(WebKit::PageClientImpl::recordAutocorrectionResponse):
(WebKit::PageClientImpl::showDictationAlternativeUI):
Move some pasteboard and spellcheck code.
- 5:35 PM Changeset in webkit [191647] by
-
- 3 edits2 adds in trunk
Null dereference loading Blink layout test editing/execCommand/format-block-uneditable-crash.html
https://bugs.webkit.org/show_bug.cgi?id=150207
<rdar://problem/23137066>
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-27
Reviewed by Enrica Casucci.
Source/WebCore:
This is a merge of Blink r200238:
https://codereview.chromium.org/1280263002
Test: editing/execCommand/format-block-uneditable-crash.html
- editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded):
splitTextNode() will return early if the given text node is not editable. Hence, check
its editablity before calling the method.
LayoutTests:
- editing/execCommand/format-block-uneditable-crash-expected.txt: Added.
- editing/execCommand/format-block-uneditable-crash.html: Added.
- 5:34 PM Changeset in webkit [191646] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fix a failing iOS WK2 test.
- fast/events/ios/viewport-device-width-allows-double-tap-zoom-out-expected.txt:
- 5:12 PM Changeset in webkit [191645] by
-
- 11 edits4 adds in trunk
Modern IDB: IDBTransaction.objectStore() support.
https://bugs.webkit.org/show_bug.cgi?id=150607
Reviewed by Alex Christensen.
Source/WebCore:
Tests: storage/indexeddb/modern/aborted-put.html
storage/indexeddb/modern/idbtransaction-objectstore-failures.html
- Modules/indexeddb/client/IDBObjectStoreImpl.cpp:
(WebCore::IDBClient::IDBObjectStore::put):
- Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::objectStore):
(WebCore::IDBClient::IDBTransaction::createObjectStoreOnServer):
- Modules/indexeddb/client/IDBTransactionImpl.h:
- Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:
(WebCore::IDBServer::MemoryBackingStoreTransaction::addExistingObjectStore):
- Modules/indexeddb/server/MemoryBackingStoreTransaction.h:
- Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::beginTransaction):
- Modules/indexeddb/shared/IDBDatabaseInfo.cpp:
(WebCore::IDBDatabaseInfo::infoForExistingObjectStore):
- Modules/indexeddb/shared/IDBDatabaseInfo.h:
- Modules/indexeddb/shared/IDBTransactionInfo.h:
(WebCore::IDBTransactionInfo::objectStores):
LayoutTests:
- storage/indexeddb/modern/aborted-put-expected.txt: Added.
- storage/indexeddb/modern/aborted-put.html: Added.
- storage/indexeddb/modern/idbtransaction-objectstore-failures-expected.txt: Added.
- storage/indexeddb/modern/idbtransaction-objectstore-failures.html: Added.
- 4:34 PM Changeset in webkit [191644] by
-
- 22 edits6 adds in trunk
Implement viewport-width-based fast-click heuristic
https://bugs.webkit.org/show_bug.cgi?id=150604
<rdar://problem/23267308>
Reviewed by Simon Fraser.
Source/WebKit2:
Implement a new fast-click heuristic that applies to viewports with width = device-width. The basic rules are
as follows: when a page has viewport width = device-width and is at initial zoom scale, we disable double-tapping
in favor of fast-clicking. However, if the viewport scale is not the initial scale, we allow double tapping. For
fast-clicking to remain useful after the user pinch-zooms, we change our double-tap to zoom out behavior to zoom
to the initial scale rather than the minimum scale. For unscalable viewports, we default to fast-clicking behavior,
and for all other viewports not at device-width, we double-tap to zoom and scroll as normal.
This patch removes some logic previously used for our scroll- and zoom-based fast-clicking heuristic, and adds
information about the viewport width and initial scale to RemoteLayerTreeTransactions. This information is then
used by the UI process to determine whether double tapping should be disabled or enabled.
The fast-click heuristic can be turned off through user default preferences, and a tap highlight for debugging
fast-clicking can also be enabled through a user default preference. A red highlight indicates that a single-
tap was slow, whereas a green highlight indicates a fast single-tap.
- Shared/mac/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::initialScaleFactor):
(WebKit::RemoteLayerTreeTransaction::setInitialScaleFactor):
(WebKit::RemoteLayerTreeTransaction::viewportMetaTagWidth):
(WebKit::RemoteLayerTreeTransaction::setViewportMetaTagWidth):
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView _processDidExit]):
(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _zoomToInitialScaleWithOrigin:animated:]):
(-[WKWebView _allowsDoubleTapGestures]):
(-[WKWebView _setViewportMetaTagWidth:]): Deleted.
(-[WKWebView _contentZoomScale]): Deleted.
(-[WKWebView _viewportMetaTagWidth]): Deleted.
(-[WKWebView _viewportIsUserScalable]): Deleted.
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::disableDoubleTapGesturesDuringTapIfNecessary):
(WebKit::PageClientImpl::didChangeViewportMetaTagWidth): Deleted.
(WebKit::PageClientImpl::disableDoubleTapGesturesUntilTapIsFinishedIfNecessary): Deleted.
- UIProcess/ios/SmartMagnificationController.h:
- UIProcess/ios/SmartMagnificationController.mm:
(WebKit::SmartMagnificationController::didCollectGeometryForSmartMagnificationGesture):
- UIProcess/ios/WKContentView.h:
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _zoomToInitialScaleWithOrigin:]):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView _showTapHighlight]):
(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]):
(-[WKContentView _mayDisableDoubleTapGesturesDuringSingleTap]):
(-[WKContentView _disableDoubleTapGesturesDuringTapIfNecessary:]):
(-[WKContentView _finishInteraction]):
(-[WKContentView _endPotentialTapAndEnableDoubleTapGesturesIfNecessary]):
(-[WKContentView _tapHighlightColorForFastClick:]):
(-[WKContentView _setDoubleTapGesturesEnabled:]):
(-[WKContentView _fastClickZoomThreshold]): Deleted.
(-[WKContentView _allowDoubleTapToZoomForCurrentZoomScale:andTargetZoomScale:]): Deleted.
(-[WKContentView _disableDoubleTapGesturesUntilTapIsFinishedIfNecessary:allowsDoubleTapZoom:targetRect:isReplaced:minimumScale:maximumScale:]): Deleted.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::disableDoubleTapGesturesDuringTapIfNecessary):
(WebKit::WebPageProxy::viewportMetaTagWidthDidChange): Deleted.
(WebKit::WebPageProxy::disableDoubleTapGesturesUntilTapIsFinishedIfNecessary): Deleted.
- WebProcess/WebPage/ViewGestureGeometryCollector.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::willCommitLayerTree):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::potentialTapAtPosition):
(WebKit::WebPage::viewportPropertiesDidChange): Deleted.
LayoutTests:
Implement a new fast-click heuristic that applies to viewports with width = device-width. Adds
new tests to check various fast-clicking behaviors. These three tests check (for pages with width=
device-width) that:
- Double-tapping to zoom still works when the scale is not the initial scale.
- If the page is at initial scale, we fire fast-clicks instead of zooming.
- When zooming out from element scale, we end up at initial scale instead of minimum scale.
- fast/events/ios/viewport-device-width-allows-double-tap-zoom-out-expected.txt: Added.
- fast/events/ios/viewport-device-width-allows-double-tap-zoom-out.html: Added.
- fast/events/ios/viewport-device-width-at-initial-scale-fast-clicks-expected.txt: Added.
- fast/events/ios/viewport-device-width-at-initial-scale-fast-clicks.html: Added.
- fast/events/ios/viewport-zooms-from-element-to-initial-scale-expected.txt: Added.
- fast/events/ios/viewport-zooms-from-element-to-initial-scale.html: Added.
- 3:08 PM Changeset in webkit [191643] by
-
- 12 edits in trunk/Source
Web Inspector: Remove unused / duplicated XHR timeline instrumentation
https://bugs.webkit.org/show_bug.cgi?id=150605
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-27
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/protocol/Timeline.json:
Source/WebCore:
These records are just duplicates of "EventDispatch" records for XHR
load and readystatechange events. Due to the nesting, the XHR records
were themselves never getting looked at, and their data (URL / readyState)
not shown in the frontend.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willDispatchXHRReadyStateChangeEventImpl): Deleted.
(WebCore::InspectorInstrumentation::didDispatchXHRReadyStateChangeEventImpl): Deleted.
(WebCore::InspectorInstrumentation::willDispatchXHRLoadEventImpl): Deleted.
(WebCore::InspectorInstrumentation::didDispatchXHRLoadEventImpl): Deleted.
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willDispatchXHRReadyStateChangeEvent): Deleted.
(WebCore::InspectorInstrumentation::didDispatchXHRReadyStateChangeEvent): Deleted.
(WebCore::InspectorInstrumentation::willDispatchXHRLoadEvent): Deleted.
(WebCore::InspectorInstrumentation::didDispatchXHRLoadEvent): Deleted.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willDispatchXHRReadyStateChangeEvent): Deleted.
(WebCore::InspectorTimelineAgent::didDispatchXHRReadyStateChangeEvent): Deleted.
(WebCore::InspectorTimelineAgent::willDispatchXHRLoadEvent): Deleted.
(WebCore::InspectorTimelineAgent::didDispatchXHRLoadEvent): Deleted.
(WebCore::toProtocol): Deleted.
- inspector/InspectorTimelineAgent.h:
- inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createXHRReadyStateChangeData): Deleted.
(WebCore::TimelineRecordFactory::createXHRLoadData): Deleted.
- inspector/TimelineRecordFactory.h:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::callReadyStateChangeListener): Deleted.
Source/WebInspectorUI:
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype._processRecord):
Remove unused events and add an assert that we don't miss
any script embedders.
- 2:47 PM Changeset in webkit [191642] by
-
- 2 edits in trunk/Tools
WebKitTestRunner leaks in generateWhitelist()
https://bugs.webkit.org/show_bug.cgi?id=150563
Reviewed by Andreas Kling.
- WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::generateWhitelist):
- 2:44 PM Changeset in webkit [191641] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Do not send RenderingFrame TimelineRecords that have no children
https://bugs.webkit.org/show_bug.cgi?id=150600
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-27
Reviewed by Timothy Hatcher.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
The frontend already filters out empty RenderingFrame records
(in TimelineManager.prototype._processRecord). Filter them out
on the backend to reduce protocol traffic / noise.
- 2:42 PM Changeset in webkit [191640] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION: Web Inspector: DOM path bar blinks when modifying inline styles
https://bugs.webkit.org/show_bug.cgi?id=149258
Reviewed by Timothy Hatcher.
Now that Object now longer spams constructor event listeners, ContentBrowser can safely
update the NavigationBar synchronously. This fixes the issue, with zero impact on layout
responsiveness when selecting Rendering Frames tree elements.
- UserInterface/Views/ContentBrowser.js:
(WebInspector.ContentBrowser.prototype._contentViewSelectionPathComponentDidChange):
Force NavigationBar to update synchronously.
- 2:38 PM Changeset in webkit [191639] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Timeline current time marker does not start moving when starting recording after just opening inspector
https://bugs.webkit.org/show_bug.cgi?id=150178
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-27
Reviewed by Brian Burg.
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype.capturingStarted):
- UserInterface/Models/TimelineRecording.js:
(WebInspector.TimelineRecording.prototype.initializeTimeBoundsIfNecessary):
For a recording to start updating current time the recording itself
must have a start time. Provide a setter so that the start time can
be set without waiting for a timeline record. For example the
timestamp that the frontend receives when it starts a recording.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._startUpdatingCurrentTime):
When we have a startTime number (new backends) always use it as the current time.
Previously we were only doing this if current time was NaN, which would be when
re-starting a recording after it had stopped, but not for the initial recording
after opening the inspector.
- UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler.prototype.updateLayout):
Even if we do not need to create new time dividers we may need to perform
other updates like update the current time marker. So do work before bailing.
- 2:36 PM Changeset in webkit [191638] by
-
- 2 edits in trunk/LayoutTests
Cleaning up formatting on recent additions win TestExpectations file
Unreviewed test gardening.
- platform/win/TestExpectations:
- 1:55 PM Changeset in webkit [191637] by
-
- 6 edits in trunk/Source/WebKit2
WKView being inside WKWebView leads to weird API issues
https://bugs.webkit.org/show_bug.cgi?id=150174
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView _superAccessibilityAttributeValue:]):
(-[WKView accessibilityFocusedUIElement]):
(-[WKView accessibilityIsIgnored]):
(-[WKView accessibilityHitTest:]):
(-[WKView accessibilityAttributeValue:]):
(-[WKView _processDidExit]):
(-[WKView _pageClosed]):
(-[WKView _updateRemoteAccessibilityRegistration:]): Deleted.
(-[WKView enableAccessibilityIfNecessary]): Deleted.
(-[WKView _toolTipChangedFrom:to:]): Deleted.
(-[WKView _setAccessibilityWebProcessToken:]): Deleted.
(-[WKView _hasFullScreenWindowController]): Deleted.
(-[WKView _fullScreenWindowController]): Deleted.
(-[WKView _closeFullScreenWindowController]): Deleted.
(-[WKView _setSuppressVisibilityUpdates:]): Deleted.
(-[WKView _suppressVisibilityUpdates]): Deleted.
(-[WKView _primaryTrackingArea]): Deleted.
(-[WKView _setPrimaryTrackingArea:]): Deleted.
(-[WKView initWithFrame:processPool:configuration:webView:]): Deleted.
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/Cocoa/WebViewImpl.h:
(WebKit::WebViewImpl::accessibilityIsIgnored):
(WebKit::WebViewImpl::primaryTrackingArea):
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::trackingAreaOptions):
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setAccessibilityWebProcessToken):
(WebKit::WebViewImpl::updateRemoteAccessibilityRegistration):
(WebKit::WebViewImpl::accessibilityFocusedUIElement):
(WebKit::WebViewImpl::accessibilityHitTest):
(WebKit::WebViewImpl::enableAccessibilityIfNecessary):
(WebKit::WebViewImpl::accessibilityAttributeValue):
(WebKit::WebViewImpl::setPrimaryTrackingArea):
(WebKit::WebViewImpl::toolTipChanged):
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::toolTipChanged):
(WebKit::PageClientImpl::accessibilityWebProcessTokenReceived):
(WebKit::PageClientImpl::recommendedScrollbarStyleDidChange):
(WebKit::PageClientImpl::closeFullScreenManager):
(WebKit::PageClientImpl::isFullScreen):
(WebKit::PageClientImpl::enterFullScreen):
(WebKit::PageClientImpl::exitFullScreen):
(WebKit::PageClientImpl::beganEnterFullScreen):
(WebKit::PageClientImpl::beganExitFullScreen):
Move accessibility code, and fold in some internal-only methods.
- 1:41 PM Changeset in webkit [191636] by
-
- 3 edits in trunk/Source/WebCore
Cancel navigation policy checks like we do content policy checks.
https://bugs.webkit.org/show_bug.cgi?id=150582
rdar://problem/22077579
Reviewed by Brent Fulgham.
This was verified manually and I'll write a layout test for it soon.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::cancelPolicyCheckIfNeeded):
- loader/DocumentLoader.h:
Add a bool to keep track of whether we are waiting for navigation policy checks, like we do with content policy checks.
Without this check, sometimes callbacks are made to DocumentLoaders that do not exist any more because they do not get
cancelled by cancelPolicyCheckIfNeeded when detaching from the frame.
- 1:39 PM Changeset in webkit [191635] by
-
- 53 edits1 copy5 adds in trunk
Modern IDB: Support IDBObjectStore.put/get support.
https://bugs.webkit.org/show_bug.cgi?id=150468
Reviewed by Alex Christensen.
Source/WebCore:
Tests: storage/indexeddb/modern/basic-put.html
storage/indexeddb/modern/keypath-basic.html
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::deletedValue):
(WebCore::IDBKeyData::operator<):
(WebCore::IDBKeyData::operator==):
- Modules/indexeddb/IDBKeyData.h:
(WebCore::IDBKeyData::isValid):
(WebCore::IDBKeyData::operator!=):
(WebCore::IDBKeyData::hash):
(WebCore::IDBKeyData::isDeletedValue):
(WebCore::IDBKeyDataHash::hash):
(WebCore::IDBKeyDataHash::equal):
(WebCore::IDBKeyDataHashTraits::constructDeletedValue):
(WebCore::IDBKeyDataHashTraits::isDeletedValue):
(WebCore::IDBKeyDataHashTraits::emptyValue):
(WebCore::IDBKeyDataHashTraits::isEmptyValue):
- Modules/indexeddb/IndexedDB.h:
- Modules/indexeddb/client/IDBAnyImpl.cpp:
(WebCore::IDBClient::IDBAny::IDBAny):
(WebCore::IDBClient::IDBAny::modernIDBObjectStore):
- Modules/indexeddb/client/IDBAnyImpl.h:
(WebCore::IDBClient::IDBAny::create):
- Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::createObjectStore):
(WebCore::IDBClient::IDBConnectionToServer::didCreateObjectStore):
(WebCore::IDBClient::IDBConnectionToServer::putOrAdd):
(WebCore::IDBClient::IDBConnectionToServer::didPutOrAdd):
(WebCore::IDBClient::IDBConnectionToServer::getRecord):
(WebCore::IDBClient::IDBConnectionToServer::didGetRecord):
(WebCore::IDBClient::IDBConnectionToServer::saveOperation):
(WebCore::IDBClient::IDBConnectionToServer::completeOperation):
- Modules/indexeddb/client/IDBConnectionToServer.h:
- Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
- Modules/indexeddb/client/IDBObjectStoreImpl.cpp:
(WebCore::IDBClient::IDBObjectStore::autoIncrement):
(WebCore::IDBClient::IDBObjectStore::put):
(WebCore::IDBClient::IDBObjectStore::get):
(WebCore::IDBClient::IDBObjectStore::putOrAdd):
- Modules/indexeddb/client/IDBObjectStoreImpl.h:
(WebCore::IDBClient::IDBObjectStore::info):
- Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:
(WebCore::IDBClient::IDBOpenDBRequest::IDBOpenDBRequest): Deleted.
- Modules/indexeddb/client/IDBRequestImpl.cpp:
(WebCore::IDBClient::IDBRequest::create):
(WebCore::IDBClient::IDBRequest::IDBRequest):
(WebCore::IDBClient::IDBRequest::sourceObjectStoreIdentifier):
(WebCore::IDBClient::IDBRequest::hasPendingActivity):
(WebCore::IDBClient::IDBRequest::dispatchEvent):
(WebCore::IDBClient::IDBRequest::setResult):
(WebCore::IDBClient::IDBRequest::setResultToStructuredClone):
(WebCore::IDBClient::IDBRequest::requestCompleted):
(WebCore::IDBClient::IDBRequest::onError):
(WebCore::IDBClient::IDBRequest::onSuccess):
- Modules/indexeddb/client/IDBRequestImpl.h:
- Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::IDBTransaction):
(WebCore::IDBClient::IDBTransaction::hasPendingActivity):
(WebCore::IDBClient::IDBTransaction::isActive):
(WebCore::IDBClient::IDBTransaction::operationTimerFired):
(WebCore::IDBClient::IDBTransaction::commit):
(WebCore::IDBClient::IDBTransaction::didAbort):
(WebCore::IDBClient::IDBTransaction::createObjectStoreOnServer):
(WebCore::IDBClient::IDBTransaction::requestGetRecord):
(WebCore::IDBClient::IDBTransaction::getRecordOnServer):
(WebCore::IDBClient::IDBTransaction::didGetRecordOnServer):
(WebCore::IDBClient::IDBTransaction::requestPutOrAdd):
(WebCore::IDBClient::IDBTransaction::putOrAddOnServer):
(WebCore::IDBClient::IDBTransaction::didPutOrAddOnServer):
(WebCore::IDBClient::IDBTransaction::activate):
(WebCore::IDBClient::IDBTransaction::deactivate):
- Modules/indexeddb/client/IDBTransactionImpl.h:
(WebCore::IDBClient::IDBTransaction::isReadOnly):
(WebCore::IDBClient::TransactionActivator::TransactionActivator):
(WebCore::IDBClient::TransactionActivator::~TransactionActivator):
- Modules/indexeddb/client/TransactionOperation.cpp:
(WebCore::IDBClient::TransactionOperation::TransactionOperation):
- Modules/indexeddb/client/TransactionOperation.h:
(WebCore::IDBClient::TransactionOperation::objectStoreIdentifier):
(WebCore::IDBClient::TransactionOperation::transaction):
(WebCore::IDBClient::createTransactionOperation):
- Modules/indexeddb/server/IDBBackingStore.h:
- Modules/indexeddb/server/IDBConnectionToClient.cpp:
(WebCore::IDBServer::IDBConnectionToClient::didPutOrAdd):
(WebCore::IDBServer::IDBConnectionToClient::didGetRecord):
- Modules/indexeddb/server/IDBConnectionToClient.h:
- Modules/indexeddb/server/IDBConnectionToClientDelegate.h:
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::putOrAdd):
(WebCore::IDBServer::IDBServer::getRecord):
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:
(WebCore::IDBServer::MemoryBackingStoreTransaction::recordValueChanged):
(WebCore::IDBServer::MemoryBackingStoreTransaction::abort):
- Modules/indexeddb/server/MemoryBackingStoreTransaction.h:
- Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBServer::MemoryIDBBackingStore::deleteRecord):
(WebCore::IDBServer::MemoryIDBBackingStore::putRecord):
(WebCore::IDBServer::MemoryIDBBackingStore::getRecord):
- Modules/indexeddb/server/MemoryIDBBackingStore.h:
- Modules/indexeddb/server/MemoryObjectStore.cpp:
(WebCore::IDBServer::MemoryObjectStore::containsRecord):
(WebCore::IDBServer::MemoryObjectStore::deleteRecord):
(WebCore::IDBServer::MemoryObjectStore::putRecord):
(WebCore::IDBServer::MemoryObjectStore::valueForKey):
- Modules/indexeddb/server/MemoryObjectStore.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::storeCallback):
(WebCore::IDBServer::UniqueIDBDatabase::putOrAdd):
(WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformPutOrAdd):
(WebCore::IDBServer::UniqueIDBDatabase::getRecord):
(WebCore::IDBServer::UniqueIDBDatabase::performGetRecord):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformGetRecord):
(WebCore::IDBServer::UniqueIDBDatabase::performKeyDataCallback):
(WebCore::IDBServer::UniqueIDBDatabase::performValueDataCallback):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::isReadOnly):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::putOrAdd):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::getRecord):
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:
- Modules/indexeddb/shared/IDBDatabaseInfo.cpp:
(WebCore::IDBDatabaseInfo::infoForExistingObjectStore):
- Modules/indexeddb/shared/IDBDatabaseInfo.h:
- Modules/indexeddb/shared/IDBError.cpp:
(WebCore::idbErrorName):
(WebCore::idbErrorDescription):
- Modules/indexeddb/shared/IDBError.h:
- Modules/indexeddb/shared/IDBRequestData.cpp:
(WebCore::IDBRequestData::IDBRequestData):
(WebCore::IDBRequestData::serverConnectionIdentifier):
(WebCore::IDBRequestData::objectStoreIdentifier):
- Modules/indexeddb/shared/IDBRequestData.h:
- Modules/indexeddb/shared/IDBResultData.cpp:
(WebCore::IDBResultData::IDBResultData):
(WebCore::IDBResultData::putOrAddSuccess):
(WebCore::IDBResultData::getRecordSuccess):
- Modules/indexeddb/shared/IDBResultData.h:
(WebCore::IDBResultData::resultKey):
(WebCore::IDBResultData::resultData):
- Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::didPutOrAdd):
(WebCore::InProcessIDBServer::didGetRecord):
(WebCore::InProcessIDBServer::putOrAdd):
(WebCore::InProcessIDBServer::getRecord):
- Modules/indexeddb/shared/InProcessIDBServer.h:
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::idbKeyToJSValue):
(WebCore::maybeCreateIDBKeyFromScriptValueAndKeyPath):
(WebCore::canInjectIDBKeyIntoScriptValue):
(WebCore::deserializeIDBValueData):
(WebCore::scriptValueToIDBKey):
(WebCore::idbKeyDataToScriptValue):
- bindings/js/IDBBindingUtilities.h:
- platform/CrossThreadCopier.cpp:
(WebCore::ThreadSafeDataBuffer>::copy):
- platform/CrossThreadCopier.h:
- platform/ThreadSafeDataBuffer.h: Added.
(WebCore::ThreadSafeDataBufferImpl::ThreadSafeDataBufferImpl):
(WebCore::ThreadSafeDataBuffer::adoptVector):
(WebCore::ThreadSafeDataBuffer::copyVector):
(WebCore::ThreadSafeDataBuffer::ThreadSafeDataBuffer):
(WebCore::ThreadSafeDataBuffer::data):
LayoutTests:
- platform/mac-wk1/TestExpectations: Re-enable a test that can now be made reliable.
- storage/indexeddb/modern/basic-put-expected.txt: Added.
- storage/indexeddb/modern/basic-put.html: Added.
- storage/indexeddb/modern/createobjectstore-basic-expected.txt:
- storage/indexeddb/modern/createobjectstore-basic.html:
- storage/indexeddb/modern/keypath-basic-expected.txt: Added.
- storage/indexeddb/modern/keypath-basic.html: Added.
- 1:09 PM Changeset in webkit [191634] by
-
- 8 edits in trunk/Source
WKView being inside WKWebView leads to weird API issues
https://bugs.webkit.org/show_bug.cgi?id=150174
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView scrollWheel:]):
(-[WKView swipeWithEvent:]):
(-[WKView _superSwipeWithEvent:]):
(-[WKView _superMagnifyWithEvent:]):
(-[WKView _superSmartMagnifyWithEvent:]):
(-[WKView _processDidExit]):
(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView allowsBackForwardNavigationGestures]):
(-[WKView setAllowsMagnification:]):
(-[WKView allowsMagnification]):
(-[WKView magnifyWithEvent:]):
(-[WKView rotateWithEvent:]):
(-[WKView _gestureEventWasNotHandledByWebCore:]):
(-[WKView smartMagnifyWithEvent:]):
(-[WKView setMagnification:centeredAtPoint:]):
(-[WKView setMagnification:]):
(-[WKView magnification]):
(-[WKView _setCustomSwipeViews:]):
(-[WKView _setCustomSwipeViewsTopContentInset:]):
(-[WKView _tryToSwipeWithEvent:ignoringPinnedState:]):
(-[WKView _setDidMoveSwipeSnapshotCallback:]):
(-[WKView _ensureGestureController]): Deleted.
(takeWindowSnapshot): Deleted.
(-[WKView _takeViewSnapshot]): Deleted.
(-[WKView _wheelEventWasNotHandledByWebCore:]): Deleted.
(-[WKView _didFirstVisuallyNonEmptyLayoutForMainFrame]): Deleted.
(-[WKView _didFinishLoadForMainFrame]): Deleted.
(-[WKView _didFailLoadForMainFrame]): Deleted.
(-[WKView _didSameDocumentNavigationForMainFrame:]): Deleted.
(-[WKView _removeNavigationGestureSnapshot]): Deleted.
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/Cocoa/WebViewImpl.h:
(WebKit::WebViewImpl::gestureController):
(WebKit::WebViewImpl::allowsBackForwardNavigationGestures):
(WebKit::WebViewImpl::allowsMagnification):
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::takeWindowSnapshot):
(WebKit::WebViewImpl::takeViewSnapshot):
(WebKit::WebViewImpl::ensureGestureController):
(WebKit::WebViewImpl::resetGestureController):
(WebKit::WebViewImpl::setAllowsBackForwardNavigationGestures):
(WebKit::WebViewImpl::setAllowsMagnification):
(WebKit::WebViewImpl::setMagnification):
(WebKit::WebViewImpl::magnification):
(WebKit::WebViewImpl::setCustomSwipeViews):
(WebKit::WebViewImpl::setCustomSwipeViewsTopContentInset):
(WebKit::WebViewImpl::tryToSwipeWithEvent):
(WebKit::WebViewImpl::setDidMoveSwipeSnapshotCallback):
(WebKit::WebViewImpl::scrollWheel):
(WebKit::WebViewImpl::swipeWithEvent):
(WebKit::WebViewImpl::magnifyWithEvent):
(WebKit::WebViewImpl::smartMagnifyWithEvent):
(WebKit::WebViewImpl::rotateWithEvent):
(WebKit::WebViewImpl::gestureEventWasNotHandledByWebCore):
(WebKit::WebViewImpl::gestureEventWasNotHandledByWebCoreFromViewOnly):
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::takeViewSnapshot):
(WebKit::PageClientImpl::wheelEventWasNotHandledByWebCore):
(WebKit::PageClientImpl::didFirstVisuallyNonEmptyLayoutForMainFrame):
(WebKit::PageClientImpl::didFinishLoadForMainFrame):
(WebKit::PageClientImpl::didFailLoadForMainFrame):
(WebKit::PageClientImpl::didSameDocumentNavigationForMainFrame):
(WebKit::PageClientImpl::removeNavigationGestureSnapshot):
Move swipe, zoom, rotate, and snapshotting code.
- platform/spi/cg/CoreGraphicsSPI.h:
- 1:01 PM Changeset in webkit [191633] by
-
- 2 edits in trunk/LayoutTests
Marking newly imported W3C html/semantics/forms tests as flaky on Windows
https://bugs.webkit.org/show_bug.cgi?id=150596
Unreviewed test gardening.
- platform/win/TestExpectations:
- 12:57 PM Changeset in webkit [191632] by
-
- 2 edits in trunk/LayoutTests
Marking newly imported W3C XMLHttpRequest tests as flaky on Windows
https://bugs.webkit.org/show_bug.cgi?id=150594
Unreviewed test gardening.
- platform/win/TestExpectations:
- 12:36 PM Changeset in webkit [191631] by
-
- 6 edits in trunk/LayoutTests
Unreviewed Win gardening(subpixel table fallout).
- platform/win/css2.1/20110323/inline-table-003-expected.txt:
- platform/win/http/tests/misc/acid2-expected.txt:
- platform/win/http/tests/misc/acid2-pixel-expected.txt:
- platform/win/http/tests/misc/generated-content-inside-table-expected.txt:
- platform/win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- 12:18 PM Changeset in webkit [191630] by
-
- 2 edits3 adds in trunk/Tools
Add an API test for _WKRemoteObjectRegistry
https://bugs.webkit.org/show_bug.cgi?id=150597
Reviewed by Andreas Kling.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Added.
- TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Added.
(TEST):
- TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Added.
(-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
(-[RemoteObjectRegistryPlugIn sayHello:]):
- 12:09 PM Changeset in webkit [191629] by
-
- 3 edits in trunk/LayoutTests
table-hover-on-link.html behaves unexpectedly on WK2.
Unreviewed gardening.
- TestExpectations:
- fast/repaint/table-hover-on-link-expected.txt:
- 11:49 AM Changeset in webkit [191628] by
-
- 13 edits in trunk/Source
Add WebKit API to clear data type Search Field Recent Searches.
https://bugs.webkit.org/show_bug.cgi?id=150019.
Patch by Zhuo Li <zachli@apple.com> on 2015-10-27
Reviewed by Anders Carlsson.
Source/WebCore:
- platform/cocoa/SearchPopupMenuCocoa.h: Add a function to remove recent searches based on
time.
- platform/cocoa/SearchPopupMenuCocoa.mm:
(WebCore::typeCheckedRecentSearchesArray): Return nil if the recent searches array is
corrupted, otherwise return the array.
(WebCore::typeCheckedDateInRecentSearch): Return nil if the date in recent search is
corrupted, otherwise return the date.
(WebCore::typeCheckedRecentSearchesRemovingRecentSearchesAddedAfterDate): Return nil if the recent searches plist is
corrupted, otherwise return the recent searches plist.
(WebCore::writeEmptyRecentSearchesPlist): Replace the existing recent searches plist if there is
any with a clean one.
(WebCore::loadRecentSearches): Use -typeCheckedRecentSearchesArray and -typeCheckedDateInRecentSearch.
(WebCore::removeRecentlyModifiedRecentSearches):
When the time passed in is equivalent to [NSDate distantPast], clear all recent searches in
the Recent Searches plist. Otherwise, we only clear the recent searches that were created
after or at the time that is passed in as the parameter. If all recent searches associated
with an autosave name were created after or at the time that is passed in as the parameter,
remove this autosave name key and all of its values in the plist. If all recent searches
associated with every autosave name in the plist were created after or at the time that is
passed in as the parameter, clear all recent searches in the Recent Searches plist.
Also, we clear all recent searches in the Recent Searches plist when we find the plist is
corrupted.
Source/WebKit2:
- Shared/WebsiteData/WebsiteDataTypes.h: Add data type Search Field Recent Searches.
- UIProcess/API/Cocoa/WKWebsiteDataRecord.mm:
(dataTypesToString): Ditto.
- UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h:
(WebKit::toWebsiteDataTypes): Ditto.
(WebKit::toWKWebsiteDataTypes): Ditto.
- UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h: Ditto.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::removeData): Handle the case when data type is Search
Field Recent Searches.
- UIProcess/WebsiteData/WebsiteDataStore.h: Add a private function for removing
recent searches based on time.
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStoreCocoa::platformRemoveRecentSearches): Call the removing
recent searches logic in WebCore.
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebsiteDataStore::platformRemoveRecentSearches): Not implemented.
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebsiteDataStore::platformRemoveRecentSearches): Not implemented.
- 11:27 AM Changeset in webkit [191627] by
-
- 3 edits in trunk/LayoutTests
Unskip and update the test result for El Capitan -> tables/mozilla_expected_failures/bugs/bug8499.html
Unreviewed gardening.
- platform/mac/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
- platform/wk2/TestExpectations:
- 10:53 AM Changeset in webkit [191626] by
-
- 4 edits2 adds in trunk
Do not sanitize user input for input[type=url]
https://bugs.webkit.org/show_bug.cgi?id=150346
<rdar://problem/23243240>
Patch by Keith Rollin <Keith Rollin> on 2015-10-27
Reviewed by Darin Adler.
Source/WebCore:
Do not sanitize user input in text-based input fields that support
the Selection API, in order to not break JavaScript code that expects
element.value to match what's on the screen.
Test: fast/forms/input-user-input-sanitization.html
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::subtreeHasChanged):
LayoutTests:
Test the sanitization of text-based input fields when the user enters
text.
- fast/forms/input-user-input-sanitization-expected.txt: Added.
- fast/forms/input-user-input-sanitization.html: Added.
- 10:48 AM Changeset in webkit [191625] by
-
- 5 edits3 adds in trunk
REGRESSION (r191360): Crash: com.apple.WebKit.WebContent at com.apple.JavaScriptCore: JSC::FTL:: + 386
https://bugs.webkit.org/show_bug.cgi?id=150580
Reviewed by Mark Lam.
Source/JavaScriptCore:
Changed code to box 32 bit integers and booleans arguments when generating the call instead of boxing
them in the shuffler.
The ASSERT in CallFrameShuffler::extendFrameIfNeeded is wrong when called from CallFrameShuffler::spill(),
as we could be making space to spill a register so that we have a spare that we can use for the new
frame's base pointer.
- ftl/FTLJSTailCall.cpp:
(JSC::FTL::DFG::recoveryFor): Added RELEASE_ASSERT to check that we never see unboxed 32 bit
arguments stored in the stack.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::exitValueForTailCall):
- jit/CallFrameShuffler.cpp:
(JSC::CallFrameShuffler::extendFrameIfNeeded): Removed unneeded ASSERT.
LayoutTests:
New regression test.
- js/regress-150580-expected.txt: Added.
- js/regress-150580.html: Added.
- js/script-tests/regress-150580.js: Added.
(addEmUp):
(sumVector):
(test):
- 10:27 AM Changeset in webkit [191624] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 9:38 AM Changeset in webkit [191623] by
-
- 4488 edits438 adds in trunk
Subpixel layout: Convert RenderTable* and AutoTableLayout to use LayoutUnit.
https://bugs.webkit.org/show_bug.cgi?id=149366
Reviewed by David Hyatt.
Source/WebCore:
This patch enables non-integral cell space distribution for both
auto and fixed table layout.
Due to the tight layout, float is used to calculate each cell's dimension/position and
we convert them to LayoutUnits while said values are set on the renderer.
Due to the (lack of) LayoutUnit precision, a fudge factor is applied on table cell's minimum width.
Collapsed table borders are still integral based, tracked here: webkit.org/b/150383
Covered by existing tests.
(WebCore::RenderTableSection::firstLineBaseline): Baseline is still integral (same as normal line layout)
- rendering/RenderTreeAsText.cpp: flooring produces the least amount of rebaseline diff (still over 1200 tests). It doesn't really matter which direction we round
as long as it is consistent.
(WebCore::writeTextRun):
(WebCore::writeSimpleLine):
- platform/graphics/LayoutRect.h:
(WebCore::LayoutRect::LayoutRect):
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
(WebCore::AutoTableLayout::applyPreferredLogicalWidthQuirks):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):
- rendering/AutoTableLayout.h:
- rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
(WebCore::FixedTableLayout::applyPreferredLogicalWidthQuirks):
(WebCore::FixedTableLayout::layout):
- rendering/FixedTableLayout.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computePreferredLogicalWidths):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::updateLogicalWidth):
(WebCore::RenderTable::distributeExtraLogicalHeight):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::addOverflowFromChildren):
(WebCore::RenderTable::computePreferredLogicalWidths):
(WebCore::RenderTable::offsetWidthForColumn):
(WebCore::RenderTable::calcBorderStart):
(WebCore::RenderTable::calcBorderEnd):
(WebCore::RenderTable::outerBorderBefore):
(WebCore::RenderTable::outerBorderAfter):
(WebCore::RenderTable::outerBorderStart):
(WebCore::RenderTable::outerBorderEnd):
- rendering/RenderTable.h:
(WebCore::RenderTable::hBorderSpacing):
(WebCore::RenderTable::vBorderSpacing):
(WebCore::RenderTable::outerBorderLeft):
(WebCore::RenderTable::outerBorderRight):
(WebCore::RenderTable::outerBorderTop):
(WebCore::RenderTable::outerBorderBottom):
(WebCore::RenderTable::columnPositions):
(WebCore::RenderTable::setColumnPosition):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::logicalWidthFromColumns):
(WebCore::RenderTableCell::computeIntrinsicPadding):
(WebCore::RenderTableCell::setCellLogicalWidth):
(WebCore::RenderTableCell::layout):
(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::paddingBefore):
(WebCore::RenderTableCell::paddingAfter):
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::borderLeft):
(WebCore::RenderTableCell::borderRight):
(WebCore::RenderTableCell::borderTop):
(WebCore::RenderTableCell::borderBottom):
(WebCore::RenderTableCell::borderStart):
(WebCore::RenderTableCell::borderEnd):
(WebCore::RenderTableCell::borderBefore):
(WebCore::RenderTableCell::borderAfter):
(WebCore::RenderTableCell::borderHalfLeft):
(WebCore::RenderTableCell::borderHalfRight):
(WebCore::RenderTableCell::borderHalfTop):
(WebCore::RenderTableCell::borderHalfBottom):
(WebCore::RenderTableCell::borderHalfStart):
(WebCore::RenderTableCell::borderHalfEnd):
(WebCore::RenderTableCell::borderHalfBefore):
(WebCore::RenderTableCell::borderHalfAfter):
(WebCore::CollapsedBorders::addBorder):
(WebCore::RenderTableCell::paintCollapsedBorders):
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
(WebCore::RenderTableCell::paintBoxDecorations):
(WebCore::RenderTableCell::paintMask):
- rendering/RenderTableCell.h:
(WebCore::RenderTableCell::logicalHeightForRowSizing):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layout):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToAutoRows):
(WebCore::RenderTableSection::distributeRemainingExtraLogicalHeight):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToRows):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::logicalRectForWritingModeAndDirection):
(WebCore::RenderTableSection::dirtiedColumns):
(WebCore::RenderTableSection::spannedColumns):
(WebCore::RenderTableSection::offsetLeftForRowGroupBorder):
(WebCore::RenderTableSection::offsetTopForRowGroupBorder):
(WebCore::RenderTableSection::verticalRowGroupBorderHeight):
(WebCore::RenderTableSection::horizontalRowGroupBorderWidth):
(WebCore::RenderTableSection::paintRowGroupBorderIfRequired):
(WebCore::RenderTableSection::setLogicalPositionForCell):
- rendering/RenderTableSection.h:
(WebCore::RenderTableSection::outerBorderLeft):
(WebCore::RenderTableSection::outerBorderRight):
(WebCore::RenderTableSection::outerBorderTop):
(WebCore::RenderTableSection::outerBorderBottom):
- rendering/style/CollapsedBorderValue.h:
(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::width):
LayoutTests:
Changeset (due to the massive rebaselining) is too long to list.
- 4:36 AM Changeset in webkit [191622] by
-
- 11 edits in trunk
[Streams API] Add close method to writable stream
https://bugs.webkit.org/show_bug.cgi?id=150560
Reviewed by Darin Adler.
Source/WebCore:
Added the close method which requires three additional writable stream internal functions plus a queuing
function to retrieve a value from the queue according to the spec.
Current test set suffices. Expectations were updated accordingly.
- Modules/streams/StreamInternals.js:
(peekQueueValue):
- Modules/streams/WritableStream.js:
(close):
- Modules/streams/WritableStreamInternals.js:
(callOrScheduleWritableStreamAdvanceQueue):
(writableStreamAdvanceQueue):
(closeWritableStream): Added as per spec.
LayoutTests:
New expectations after adding close method to writable stream.
Two tests were also flagged because of bug 147933 that prevents them from running properly in certain
conditions. So far this only happened in Mac, hence they were flagged only for it.
- platform/mac/TestExpectations:
- streams/reference-implementation/bad-underlying-sinks-expected.txt:
- streams/reference-implementation/brand-checks-expected.txt:
- streams/reference-implementation/pipe-to-expected.txt:
- streams/reference-implementation/writable-stream-abort-expected.txt:
- streams/reference-implementation/writable-stream-expected.txt:
- 12:00 AM Changeset in webkit [191621] by
-
- 24 edits10 adds in trunk/Source/JavaScriptCore
[ES6] Add DFG/FTL support for accessor put operations
https://bugs.webkit.org/show_bug.cgi?id=148860
Reviewed by Geoffrey Garen.
This patch introduces accessor defining ops into DFG and FTL.
The following DFG nodes are introduced.
op_put_getter_by_id => PutGetterById
op_put_setter_by_id => PutSetterById
op_put_getter_setter => PutGetterSetterById
op_put_getter_by_val => PutGetterByVal
op_put_setter_by_val => PutSetterByVal
These DFG nodes just call operations. But it does not prevent compiling in DFG/FTL.
To use operations defined for baseline JIT, we clean up existing operations.
And reuse these operations in DFG and FTL.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasAccessorAttributes):
(JSC::DFG::Node::accessorAttributes):
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutAccessorById):
(JSC::DFG::SpeculativeJIT::compilePutGetterSetterById):
(JSC::DFG::SpeculativeJIT::compilePutAccessorByVal):
We should fill all GPRs before calling flushRegisters().
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileNode):
(JSC::FTL::DFG::LowerDFGToLLVM::compilePutAccessorById):
(JSC::FTL::DFG::LowerDFGToLLVM::compilePutGetterSetterById):
(JSC::FTL::DFG::LowerDFGToLLVM::compilePutAccessorByVal):
- jit/JIT.h:
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_getter_by_id):
(JSC::JIT::emit_op_put_setter_by_id):
(JSC::JIT::emit_op_put_getter_setter):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_getter_by_id):
(JSC::JIT::emit_op_put_setter_by_id):
(JSC::JIT::emit_op_put_getter_setter):
- tests/stress/dfg-put-accessors-by-id-class.js: Added.
(shouldBe):
(testAttribute):
(getter.Cocoa.prototype.get hello):
(getter.Cocoa):
(getter):
(setter.Cocoa):
(setter.Cocoa.prototype.set hello):
(setter):
(accessors.Cocoa):
(accessors.Cocoa.prototype.get hello):
(accessors.Cocoa.prototype.set hello):
(accessors):
- tests/stress/dfg-put-accessors-by-id.js: Added.
(shouldBe):
(testAttribute):
(getter.object.get hello):
(getter):
(setter.object.set hello):
(setter):
(accessors.object.get hello):
(accessors.object.set hello):
(accessors):
- tests/stress/dfg-put-getter-by-id-class.js: Added.
(shouldBe):
(testAttribute):
(getter.Cocoa):
(getter.Cocoa.prototype.get hello):
(getter.Cocoa.prototype.get name):
(getter):
- tests/stress/dfg-put-getter-by-id.js: Added.
(shouldBe):
(testAttribute):
(getter.object.get hello):
(getter):
- tests/stress/dfg-put-getter-by-val-class.js: Added.
(shouldBe):
(testAttribute):
(getter.Cocoa):
(getter.Cocoa.prototype.get name):
(getter):
- tests/stress/dfg-put-getter-by-val.js: Added.
(shouldBe):
(testAttribute):
(getter.object.get name):
(getter):
- tests/stress/dfg-put-setter-by-id-class.js: Added.
(shouldBe):
(testAttribute):
(getter.Cocoa):
(getter.Cocoa.prototype.set hello):
(getter.Cocoa.prototype.get name):
(getter):
- tests/stress/dfg-put-setter-by-id.js: Added.
(shouldBe):
(testAttribute):
(setter.object.set hello):
(setter):
- tests/stress/dfg-put-setter-by-val-class.js: Added.
(shouldBe):
(testAttribute):
(setter.Cocoa):
(setter.Cocoa.prototype.set name):
(setter):
- tests/stress/dfg-put-setter-by-val.js: Added.
(shouldBe):
(testAttribute):
(setter.object.set name):
(setter):
Oct 26, 2015:
- 10:34 PM WebKitGTK/2.10.x edited by
- Start 2.10.4 proposals (diff)
- 10:22 PM Changeset in webkit [191620] by
-
- 18 edits in trunk/Source
Make IDBKeyData from a struct to a class.
https://bugs.webkit.org/show_bug.cgi?id=150576
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (No change in behavior).
- Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::IDBKeyData):
(WebCore::IDBKeyData::maybeCreateIDBKey):
(WebCore::IDBKeyData::isolatedCopy):
(WebCore::IDBKeyData::encode):
(WebCore::IDBKeyData::decode):
(WebCore::IDBKeyData::compare):
(WebCore::IDBKeyData::loggingString):
(WebCore::IDBKeyData::setArrayValue):
(WebCore::IDBKeyData::setStringValue):
(WebCore::IDBKeyData::setDateValue):
(WebCore::IDBKeyData::setNumberValue):
- Modules/indexeddb/IDBKeyData.h:
(WebCore::IDBKeyData::IDBKeyData):
(WebCore::IDBKeyData::minimum):
(WebCore::IDBKeyData::maximum):
(WebCore::IDBKeyData::isNull):
(WebCore::IDBKeyData::type):
(WebCore::IDBKeyData::encode):
(WebCore::IDBKeyData::decode):
- Modules/indexeddb/legacy/IDBTransactionBackendOperations.cpp:
(WebCore::GetOperation::perform):
- bindings/js/IDBBindingUtilities.h:
- platform/CrossThreadCopier.h:
Source/WebKit2:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:
- DatabaseProcess/IndexedDB/IDBSerialization.h:
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::putRecordInBackingStore):
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
- DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
- DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:
(WebKit::buildIndexStatement):
(WebKit::buildObjectStoreStatement):
(WebKit::SQLiteIDBCursor::establishStatement):
(WebKit::SQLiteIDBCursor::createSQLiteStatement):
(WebKit::SQLiteIDBCursor::resetAndRebindStatement):
(WebKit::SQLiteIDBCursor::iterate):
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createIndex):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::didPutRecord):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:
- 10:18 PM EFLWebKit edited by
- (diff)
- 10:16 PM Changeset in webkit [191619] by
-
- 2 edits in trunk/Source/WebCore
[GTK] [Stable] Build GL texture mapper only if USE_TEXTURE_MAPPER_GL
https://bugs.webkit.org/show_bug.cgi?id=148606
Unreviewed, build-only change.
No new tests, build-only change.
Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-10-26
- PlatformGTK.cmake: Remove sources requiring GL from list of
sources that are built when USE_TEXTURE_MAPPER is true, and add a
separate condition within the USE_TEXTURE_MAPPER condition to
build those sources when USE_TEXTURE_MAPPER_GL is true.
- 10:15 PM Changeset in webkit [191618] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] [Stable] InstallMissingMediaPluginsPermissionRequest not defined when building without GStreamer
https://bugs.webkit.org/show_bug.cgi?id=148607
Unreviewed, build fix.
Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-10-26
- UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.h:
Add a stub for the InstallMissingMediaPluginsPermissionRequest class
for the case when video is disabled or not using GStreamer. It's OK
that this class does nothing, because the associated C API contains
an assert_not_reached if video is disabled. We just need to define
the symbol so that the function signature will compile.
- 9:03 PM Changeset in webkit [191617] by
-
- 7 edits in trunk/Source/WebCore
Remove redundant GraphicsContext::clip(const Path&, WindRule)
https://bugs.webkit.org/show_bug.cgi?id=150584
Reviewed by Tim Horton.
GraphicsContext had both clipPath(const Path&, WindRule) and clip(const Path&, WindRule),
which were mostly the same other than GraphicsContext::clipPath() not clipping if the path
was empty (added, I think by mistake, in r72926), and not calling m_data->clip().
Make clipPath() be the winner, and have it behave like clip() with empty paths, and call m_data->clip().
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::clipRoundedRect):
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::clip): Deleted.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clip): Deleted.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow): Making a path, calling addRoundedRect() and then clipping
to the path is the same as context.clipRoundedRect().
- rendering/mathml/RenderMathMLRadicalOperator.cpp:
(WebCore::RenderMathMLRadicalOperator::paint):
- 5:55 PM Changeset in webkit [191616] by
-
- 2 edits in trunk/Tools
Add myself to the reviewers list
https://bugs.webkit.org/show_bug.cgi?id=150581
Unreviewed.
- Scripts/webkitpy/common/config/contributors.json:
- 5:25 PM Changeset in webkit [191615] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: WebInspector.Object can dispatch constructor-level events multiple times
https://bugs.webkit.org/show_bug.cgi?id=150579
Reviewed by Timothy Hatcher.
Use
hasOwnPropertywhen checking for constructor event listeners when walking the
prototype chain. This prevents listeners registered with a base class constructor
from being dispatched multiple times by getting picked up higher in the prototype chain.
- UserInterface/Base/Object.js:
(WebInspector.Object.prototype.dispatchEventToListeners.dispatch):
(WebInspector.Object.prototype.dispatchEventToListeners):
(WebInspector.Object):
- 5:11 PM Changeset in webkit [191614] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Hundreds of failed assertions after switching to Rendering Frames after recording complete
https://bugs.webkit.org/show_bug.cgi?id=150568
Reviewed by Timothy Hatcher.
When the TimelineRecordingContentView responds to the current content view changing,
the TimelineOverview may be swapped out (if switching from a Timelines content view to a
Rendering Frames content view). This patch installs a new overview (if it's changing) prior
to setting the TimelineSidebarPanel's tree outline, as setting the tree outline forces
filters to run.
Filtering tree elements requires that the timeline overview is up to date, which was the
cause the assertion deluge.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
- 5:08 PM Changeset in webkit [191613] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Spacebar to start recording should not cause system beep
https://bugs.webkit.org/show_bug.cgi?id=150573
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-26
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype._toggleRecordingOnSpacebar):
(WebInspector.TimelineSidebarPanel.prototype._toggleNewRecordingOnSpacebar):
The keyboard shortcuts do not implicitly prevent default because they may bail.
So in cases where they do handle the key, prevent default to prevent system beeps.
- 4:53 PM Changeset in webkit [191612] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Cleanup sidebar panels, reduce
deleteand use Maps instead of objects
https://bugs.webkit.org/show_bug.cgi?id=150548
Reviewed by Timothy Hatcher.
- UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
(WebInspector.LayerTreeDetailsSidebarPanel):
(WebInspector.LayerTreeDetailsSidebarPanel.prototype._updateDataGrid):
(WebInspector.LayerTreeDetailsSidebarPanel.prototype._dataGridNodeForLayer):
- UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel):
(WebInspector.NavigationSidebarPanel.restoreStateFromCookie.finalAttemptToRestoreViewStateFromCookie):
(WebInspector.NavigationSidebarPanel.restoreStateFromCookie):
(WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement):
(WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
(WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie):
Switched to using Symbol() to set external properties on tree elements.
- UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._generateCallFramesSection):
- UserInterface/Views/StorageSidebarPanel.js:
(WebInspector.StorageSidebarPanel):
(WebInspector.StorageSidebarPanel.prototype._addDatabase):
(WebInspector.StorageSidebarPanel.prototype._addIndexedDatabase):
(WebInspector.StorageSidebarPanel.prototype._addFrameManifest):
(WebInspector.StorageSidebarPanel.prototype._storageCleared):
- 4:51 PM Changeset in webkit [191611] by
-
- 2 edits in trunk/LayoutTests
Removing duplicated test expectations and removing debug flag from flaky fast/canvas/webgl tests
https://bugs.webkit.org/show_bug.cgi?id=150367
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 4:36 PM Changeset in webkit [191610] by
-
- 9 edits2 adds in trunk
Floating box is misplaced after content change.
https://bugs.webkit.org/show_bug.cgi?id=150271
Reviewed by David Hyatt.
Collapse anonymous block when as the result of a sibling removal only floating siblings are left.
Source/WebCore:
Test: fast/block/collapse-anon-block-with-float-siblings-only.html
- rendering/RenderBlock.cpp:
(WebCore::canCollapseAnonymousBlock):
(WebCore::canMergeContiguousAnonymousBlocks):
(WebCore::RenderBlock::collapseAnonymousBoxChild):
(WebCore::RenderBlock::removeChild):
(WebCore::canMergeAnonymousBlock): Deleted.
- rendering/RenderBlock.h:
- rendering/RenderElement.cpp:
(WebCore::RenderElement::removeAnonymousWrappersForInlinesIfNecessary):
LayoutTests:
- fast/block/collapse-anon-block-with-float-siblings-only-expected.html: Added.
- fast/block/collapse-anon-block-with-float-siblings-only.html: Added.
- 4:08 PM Changeset in webkit [191609] by
-
- 3 edits2 adds in trunk
Null dereference loading Blink layout test editing/execCommand/crash-replacing-list-by-list.html
https://bugs.webkit.org/show_bug.cgi?id=149288
<rdar://problem/22746310>
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-26
Reviewed by Chris Dumez.
Source/WebCore:
This is a merge of Blink r170821:
https://codereview.chromium.org/220233013
Test: editing/execCommand/crash-replacing-list-by-list.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::insertAsListItems):
LayoutTests:
- editing/execCommand/crash-replacing-list-by-list-expected.txt: Added.
- editing/execCommand/crash-replacing-list-by-list.html: Added.
- 4:05 PM Changeset in webkit [191608] by
-
- 3 edits2 adds in trunk
Null dereference loading Blink layout test editing/execCommand/insert-image-changing-visibility-crash.html
https://bugs.webkit.org/show_bug.cgi?id=150208
<rdar://problem/23137109>
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-26
Reviewed by Chris Dumez.
Source/WebCore:
This is a merge from Blink r168502:
https://codereview.chromium.org/183893018
Test: editing/execCommand/insert-image-changing-visibility-crash.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
We should check again the visibility of the inserted position again since
the replacement might change the visibility.
LayoutTests:
- editing/execCommand/insert-image-changing-visibility-crash-expected.txt: Added.
- editing/execCommand/insert-image-changing-visibility-crash.html: Added.
- 3:58 PM Changeset in webkit [191607] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Pipe custom context menu handling through to the UIDelegate object
https://bugs.webkit.org/show_bug.cgi?id=150572
Reviewed by Tim Horton.
- UIProcess/API/APIContextMenuClient.h:
(API::ContextMenuClient::menuFromProposedMenu):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView setUIDelegate:]):
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::createContextMenuClient):
(WebKit::UIDelegate::ContextMenuClient::ContextMenuClient):
(WebKit::UIDelegate::ContextMenuClient::~ContextMenuClient):
(WebKit::UIDelegate::ContextMenuClient::menuFromProposedMenu):
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showContextMenu):
- 3:51 PM Changeset in webkit [191606] by
-
- 4 edits in trunk/Source/WebKit2
WKView being inside WKWebView leads to weird API issues
https://bugs.webkit.org/show_bug.cgi?id=150174
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView mouseDown:]):
(-[WKView mouseDragged:]):
(-[WKView draggedImage:endedAt:operation:]):
(-[WKView draggingEntered:]):
(-[WKView draggingUpdated:]):
(-[WKView draggingExited:]):
(-[WKView prepareForDragOperation:]):
(-[WKView performDragOperation:]):
(-[WKView _hitTest:dragTypes:]):
(-[WKView initWithFrame:processPool:configuration:webView:]):
(-[WKView applicationFlags:]): Deleted.
(maybeCreateSandboxExtensionFromPasteboard): Deleted.
(createSandboxExtensionsForFileUpload): Deleted.
(-[WKView _registerDraggedTypes]): Deleted.
- UIProcess/Cocoa/WebViewImpl.h:
(WebKit::WebViewImpl::ignoresMouseDraggedEvents):
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::setIgnoresMouseDraggedEvents):
(WebKit::WebViewImpl::draggedImage):
(WebKit::applicationFlagsForDrag):
(WebKit::WebViewImpl::draggingEntered):
(WebKit::WebViewImpl::draggingUpdated):
(WebKit::WebViewImpl::draggingExited):
(WebKit::WebViewImpl::prepareForDragOperation):
(WebKit::maybeCreateSandboxExtensionFromPasteboard):
(WebKit::createSandboxExtensionsForFileUpload):
(WebKit::WebViewImpl::performDragOperation):
(WebKit::WebViewImpl::hitTestForDragTypes):
(WebKit::WebViewImpl::registerDraggedTypes):
Move some drag-related things to WebViewImpl.
- 3:49 PM Changeset in webkit [191605] by
-
- 3 edits2 adds in trunk
Null dereference loading Blink layout test editing/execCommand/insert-ordered-list-crash.html
https://bugs.webkit.org/show_bug.cgi?id=150209
<rdar://problem/23137198>
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-26
Reviewed by Chris Dumez.
Source/WebCore:
This is a merge from Blink r168006:
https://codereview.chromium.org/181283002
Test: editing/execCommand/insert-ordered-list-crash.html
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply):
setEndingSelection() might change endingSelection(), we should check again.
LayoutTests:
- editing/execCommand/insert-ordered-list-crash-expected.txt: Added.
- editing/execCommand/insert-ordered-list-crash.html: Added.
- 3:03 PM Changeset in webkit [191604] by
-
- 3 edits2 adds in trunk
Null dereference loading Blink layout test editing/execCommand/insert-html-to-document-element-crash.html
https://bugs.webkit.org/show_bug.cgi?id=149294
<rdar://problem/22746657>
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-26
Reviewed by Darin Adler.
Source/WebCore:
This is a merge of Blink r175019:
https://codereview.chromium.org/300143012
Test: editing/execCommand/insert-html-to-document-element-crash.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
check nullable value |element->parentNode()| before using it.
LayoutTests:
- editing/execCommand/insert-html-to-document-element-crash-expected.txt: Added.
- editing/execCommand/insert-html-to-document-element-crash.html: Added.
- 3:01 PM Changeset in webkit [191603] by
-
- 3 edits2 adds in trunk
Null dereference loading Blink layout test editing/execCommand/indent-nested-blockquotes-crash.html
https://bugs.webkit.org/show_bug.cgi?id=149291
<rdar://problem/22746473>
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-26
Reviewed by Darin Adler.
Source/WebCore:
This is a merge of Blink r172967:
https://codereview.chromium.org/251723003
Test: editing/execCommand/indent-nested-blockquotes-crash.html
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::insertNodeAfter):
LayoutTests:
- editing/execCommand/indent-nested-blockquotes-crash-expected.txt: Added.
- editing/execCommand/indent-nested-blockquotes-crash.html: Added.
- 2:45 PM Changeset in webkit [191602] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add logging to warn about under-estimated FTL inline cache sizes.
https://bugs.webkit.org/show_bug.cgi?id=150570
Reviewed by Geoffrey Garen.
Added 2 options:
- JSC_dumpFailedICSizing - dumps an error message if the FTL encounters IC size estimates that are less than the actual needed code size.
This option is useful for when we add a new IC and want to compute an
estimated size for the IC. To do this:
- Build jsc for the target port with a very small IC size (enough to store the jump instruction needed for the out of line fallback implementation).
- Implement a test suite with scenarios that exercise all the code paths in the IC generator.
- Run jsc with JSC_dumpFailedICSizing=true on the test suite.
- The max value reported by the dumps will be the worst case size needed to store the IC. We should use this value for our estimate.
- Update the IC's estimated size and rebuild jsc.
- Re-run (3) and confirm that there are no more error messages about the IC sizing.
- JSC_assertICSizing - same as JSC_dumpFailedICSizing except that it also crashes the VM each time it encounters an inadequate IC size estimate.
This option is useful for regression testing to ensure that our estimates
do not regress.
- ftl/FTLCompile.cpp:
(JSC::FTL::generateInlineIfPossibleOutOfLineIfNot):
- runtime/Options.h:
- 2:45 PM Changeset in webkit [191601] by
-
- 4 edits in trunk
make analyzeshould build using the debug configuration
https://bugs.webkit.org/show_bug.cgi?id=150571
Reviewed by Lucas Forschler.
.:
- Makefile.shared:
WebKitLibraries:
- Makefile:
- 2:41 PM Changeset in webkit [191600] by
-
- 6 edits in trunk/Source/WebKit2
Pipe custom context menu handling through to the UIDelegate object
https://bugs.webkit.org/show_bug.cgi?id=150572
Reviewed by Tim Horton.
- UIProcess/API/APIContextMenuClient.h:
(API::ContextMenuClient::menuFromProposedMenu):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView setUIDelegate:]):
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::createContextMenuClient):
(WebKit::UIDelegate::ContextMenuClient::ContextMenuClient):
(WebKit::UIDelegate::ContextMenuClient::~ContextMenuClient):
(WebKit::UIDelegate::ContextMenuClient::menuFromProposedMenu):
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showContextMenu):
- 2:09 PM Changeset in webkit [191599] by
-
- 1 edit in trunk/LayoutTests/platform/mac-wk1/TestExpectations
2015-10-26 Ryan Haddad <Ryan Haddad>
Marking svg/repaint/add-background-property-on-root.html as flaky on mac-wk1 due to timeouts
https://bugs.webkit.org/show_bug.cgi?id=150564
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 2:07 PM Changeset in webkit [191598] by
-
- 11 edits2 copies in trunk/Source/WebCore
Modern IDB: Backing store objectStores (plumbing for b/150468).
https://bugs.webkit.org/show_bug.cgi?id=150543
Reviewed by Alex Christensen.
No new tests (No change in behavior, plumbing for future testability)
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/server/IDBBackingStore.h:
- Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:
(WebCore::IDBServer::MemoryBackingStoreTransaction::addNewObjectStore):
(WebCore::IDBServer::MemoryBackingStoreTransaction::abort):
(WebCore::IDBServer::MemoryBackingStoreTransaction::commit):
(WebCore::IDBServer::MemoryBackingStoreTransaction::finish):
- Modules/indexeddb/server/MemoryBackingStoreTransaction.h:
(WebCore::IDBServer::MemoryBackingStoreTransaction::isWriting):
- Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::createObjectStore):
(WebCore::IDBServer::MemoryIDBBackingStore::removeObjectStoreForVersionChangeAbort):
- Modules/indexeddb/server/MemoryIDBBackingStore.h:
- Modules/indexeddb/server/MemoryObjectStore.cpp:
(WebCore::IDBServer::MemoryObjectStore::create):
(WebCore::IDBServer::MemoryObjectStore::MemoryObjectStore):
(WebCore::IDBServer::MemoryObjectStore::~MemoryObjectStore):
(WebCore::IDBServer::MemoryObjectStore::writeTransactionStarted):
(WebCore::IDBServer::MemoryObjectStore::writeTransactionFinished):
- Modules/indexeddb/server/MemoryObjectStore.h:
(WebCore::IDBServer::MemoryObjectStore::info):
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::createObjectStore):
- Modules/indexeddb/shared/IDBError.cpp:
(WebCore::idbErrorName):
(WebCore::idbErrorDescription):
- Modules/indexeddb/shared/IDBError.h:
- 1:16 PM Changeset in webkit [191597] by
-
- 3 edits2 adds in trunk
Null dereference loading Blink layout test editing/execCommand/indent-inline-box-crash.html
https://bugs.webkit.org/show_bug.cgi?id=149290
<rdar://problem/22746435>
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-26
Reviewed by Alex Christensen.
Source/WebCore:
This is a merge of Blink r174952:
https://codereview.chromium.org/297203004
Test: editing/execCommand/indent-inline-box-crash.html
- editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::tryIndentingAsListItem):
LayoutTests:
- editing/execCommand/indent-inline-box-crash-expected.txt: Added.
- editing/execCommand/indent-inline-box-crash.html: Added.
- 1:08 PM Changeset in webkit [191596] by
-
- 3 edits2 adds in trunk
Null dereference loading Blink layout test editing/execCommand/indent-no-visible-contents-crash.html
https://bugs.webkit.org/show_bug.cgi?id=149292
<rdar://problem/22746530>
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-26
Reviewed by Alex Christensen.
Source/WebCore:
This is a merge of Blink r176735:
https://codereview.chromium.org/349143002
Test: editing/execCommand/indent-no-visible-contents-crash.html
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphWithClones):
Sometimes callers of this method will pass null startOfParagraphToMove endOfParagraphToMove, hence check them before proceeding.
LayoutTests:
- editing/execCommand/indent-no-visible-contents-crash-expected.txt: Added.
- editing/execCommand/indent-no-visible-contents-crash.html: Added.
- 1:01 PM Changeset in webkit [191595] by
-
- 2 edits in trunk/Source/WebKit2
Build fix when using NETWORK_SESSION after r191457.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[NetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
Use resourceResponse.
- 12:48 PM Changeset in webkit [191594] by
-
- 5 edits1 add in trunk/Source/JavaScriptCore
r190735 Caused us to maybe trample the base's tag-GPR on 32-bit inline cache when the cache allocates a scratch register and then jumps to the slow path
https://bugs.webkit.org/show_bug.cgi?id=150532
Reviewed by Geoffrey Garen.
The base's tag register used to show up in the used register set
before r190735 because of how the DFG kept track of used register. I changed this
in my work on inline caching because we don't want to spill these registers
when we have a GetByIdFlush/PutByIdFlush and we use the used register set
as the metric of what to spill. That said, these registers should be locked
and not used as scratch registers by the scratch register allocator. The
reason is that our inline cache may fail and jump to the slow path. The slow
path then uses the base's tag register. If the inline cache used the base's tag
register as a scratch and the inline cache fails and jumps to the slow path, we
have a problem because the tag may now be trampled.
Note that this doesn't mean that we can't trample the base's tag register when making
a call. We can totally trample the register as long as the inline cache succeeds in a GetByIdFlush/PutByIdFlush.
The problem is only when we trample it and then jump to the slow path.
This patch fixes this bug by making StructureStubInfo keep track of the base's
tag GPR. PolymorphicAccess then locks this register when using the ScratchRegisterAllocator.
- bytecode/PolymorphicAccess.cpp:
(JSC::AccessCase::generate):
(JSC::PolymorphicAccess::regenerate):
- bytecode/StructureStubInfo.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileIn):
- jit/JITInlineCacheGenerator.cpp:
(JSC::JITByIdGenerator::JITByIdGenerator):
- tests/stress/regress-150532.js: Added.
(assert):
(randomFunction):
(foo):
(i.switch):
- 12:20 PM Changeset in webkit [191593] by
-
- 3 edits in trunk/Source/WebKit2
Remove more dead context menu code
https://bugs.webkit.org/show_bug.cgi?id=150569
Reviewed by Tim Horton.
- UIProcess/API/APIContextMenuClient.h:
(API::ContextMenuClient::contextMenuDismissed): Deleted.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageContextMenuClient): Deleted.
- 12:15 PM Changeset in webkit [191592] by
-
- 2 edits in trunk/Tools
2015-10-26 Ryan Haddad <Ryan Haddad>
Adding myself to contributors.json
- Scripts/webkitpy/common/config/contributors.json:
- 12:01 PM Changeset in webkit [191591] by
-
- 10 edits in trunk/Source
Remove dead context menu code
https://bugs.webkit.org/show_bug.cgi?id=150567
Reviewed by Tim Horton.
Source/WebCore:
- loader/EmptyClients.h:
- page/ContextMenuClient.h:
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::showContextMenu): Deleted.
Source/WebKit/mac:
- WebCoreSupport/WebContextMenuClient.h:
- WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::getCustomMenuFromDefaultItems): Deleted.
Source/WebKit2:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::getCustomMenuFromDefaultItems): Deleted.
- WebProcess/WebCoreSupport/WebContextMenuClient.h:
- 11:39 AM Changeset in webkit [191590] by
-
- 4 edits6 adds in trunk
Implement 'round' and 'space' values for border-image
https://bugs.webkit.org/show_bug.cgi?id=14185
Reviewed by Tim Horton.
Source/WebCore:
Add support for "round" and "space" values for border-image-repeat.
Following "stretch" and "repeat", the code is added to Image::drawTiled().
For "round", we compute an integral number of copies of the image that fit,
and then adjust the tile scale.
For "space", we also compute an integral number N of copies that will fit,
and then divide the remaining space amongst N+1 gaps, adjusting the tiling
phase so that with an even number of images, a gap is centered.
Tests: fast/borders/border-image-round.html
fast/borders/border-image-space.html
- platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawPattern):
LayoutTests:
Ref tests that clip, leaving relevant parts of the images.
- fast/borders/border-image-round-expected.html: Added.
- fast/borders/border-image-round.html: Added.
- fast/borders/border-image-space-expected.html: Added.
- fast/borders/border-image-space.html: Added.
- fast/borders/resources/big-border-image-lines.png: Added.
- fast/borders/resources/big-border-image.png: Added.
- 11:26 AM Changeset in webkit [191589] by
-
- 3 edits2 adds in trunk
Incorrect repeated background-size behavior in keyframes
https://bugs.webkit.org/show_bug.cgi?id=150309
Reviewed by Zalan Bujtas.
Source/WebCore:
After computing the style for a keyframe, we failed to propagate unset
fill-layer properties to all layers, which caused incorrect behavior when
there were multiple background images, but only one value on a background
property in the keyframes.
Fix by calling adjustRenderStyle() on keyframe styles, which invokes
style.adjustBackgroundLayers() which fixes the bug.
Test: animations/multiple-backgrounds.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForKeyframe):
LayoutTests:
- animations/multiple-backgrounds-expected.html: Added.
- animations/multiple-backgrounds.html: Added.
- 11:24 AM Changeset in webkit [191588] by
-
- 5 edits in trunk
Don't expose the whitelist/blacklist in _WKUserStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=150566
Reviewed by Anders Carlsson.
Source/WebKit2:
- UIProcess/API/Cocoa/_WKUserStyleSheet.h:
- UIProcess/API/Cocoa/_WKUserStyleSheet.mm:
(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:]):
(toWTFStrings): Deleted.
(-[_WKUserStyleSheet initWithSource:whitelistedURLPatterns:blacklistedURLPatterns:forMainFrameOnly:]): Deleted.
(-[_WKUserStyleSheet whitelistedURLPatterns]): Deleted.
(-[_WKUserStyleSheet blacklistedURLPatterns]): Deleted.
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
(TEST):
- 11:08 AM Changeset in webkit [191587] by
-
- 5 edits in trunk
Indexing an object with an integer that is not a supported property index should not call the named property getter
https://bugs.webkit.org/show_bug.cgi?id=148871
<rdar://problem/22589952>
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C HTML test now that more checks are passing.
- web-platform-tests/html/semantics/forms/the-form-element/form-elements-matches-expected.txt:
Source/WebCore:
Indexing an object with an integer that is not a supported property
index should not call the named property getter, as per the Web IDL
specification:
https://heycam.github.io/webidl/#idl-indexed-properties (Note in blue)
Firefox and Chrome both already behave according to the specification
here so this patch aligns our behavior with other browsers as well.
No new tests, already covered by existing test.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTarget::getOwnPropertySlot):
(WebCore::JSTestEventTarget::getOwnPropertySlotByIndex): Deleted.
(WebCore::jsTestEventTargetConstructor): Deleted.
- 9:44 AM Changeset in webkit [191586] by
-
- 21 edits1 add in trunk/PerformanceTests
Add an option to output the results of the graphics benchmark in JSON format
https://bugs.webkit.org/show_bug.cgi?id=150484
<rdar://problem/23243721>
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-10-26
Reviewed by Darin Adler.
- Animometer/resources/extensions.js:
(ResultsDashboard): A new class to hold the iterations results.
(ResultsDashboard.prototype.push): Appends an iteration results;
(ResultsDashboard.prototype.toJSON): Converts the iterations results to JSON format.
(RecordTable.prototype.clear): Clears the results table.
(RecordTable.prototype._showTitles): Shows the header titles and appends the sub-titles to a queue.
(RecordTable.prototype._showHeader): Shows the table header titles.
(RecordTable.prototype._showEmpty): Shows an empty table cell.
(RecordTable.prototype._showValue): Shows a number value in the results table.
(RecordTable.prototype._showSamples): Shows a button for the sampled data graph.
(RecordTable.prototype._showTest): Shows the results of a single test.
(RecordTable.prototype._showSuite): Shows the results of a single suite.
(RecordTable.prototype.showRecord): Shows a single iteration for a single test.
(RecordTable.prototype.showIterations): Shows the results of all the suites of the iterations.
(ResultsTable): RecordTable was renamed to ResultsTable.
(ResultsTable.prototype.clear): Clears the table element.
(ResultsTable.prototype._showHeaderRow): Shows a row in the results table header.
(ResultsTable.prototype._showHeader): Shows the results table header.
(ResultsTable.prototype._showEmpty): Shows an empty table cell.
(ResultsTable.prototype._showText): Shows a string in a new table cell.
(ResultsTable.prototype._showFixedNumber): Shows a number in a new table cell.
(ResultsTable.prototype._showGraph): Shows a button for the sampled data graph.
(ResultsTable.prototype._showJSON): Shows a button for the sampled data JSON.
(ResultsTable.prototype._showTest): Shows the results of a single test.
(ResultsTable.prototype._showSuite): Shows the results of a single suite.
(ResultsTable.prototype._showIteration): Shows the results of a single iteration.
(ResultsTable.prototype.showRecord): Shows a single iteration for a single test.
(ResultsTable.prototype.showIterations): Shows all the results.
(RecordTable): Deleted.
(RecordTable.prototype.clear): Deleted.
(RecordTable.prototype._showTitles): Deleted.
(RecordTable.prototype._showHeader): Deleted.
(RecordTable.prototype._showEmpty): Deleted.
(RecordTable.prototype._showValue): Deleted.
(RecordTable.prototype._showSamples): Deleted.
(RecordTable.prototype._showTest): Deleted.
(RecordTable.prototype._showSuite): Deleted.
(RecordTable.prototype.showRecord): Deleted.
(RecordTable.prototype.showIterations): Deleted.
- Animometer/resources/sampler.js:
(Sampler.prototype.startSampling): Use forEach.
(Sampler.prototype.sample): Use forEach.
(Sampler.prototype.toJSON): Converts the sampler data to JSON format.
- Animometer/resources/strings.js: Added.
This new file will be used to associate the strings used by the benchmark
with IDs. A string can be changed in one place without having to change
all the instances of this string in multiple files. There two groups of
strings in this file. The first one is used by the UI elements and the second
group is used when constructing the results JSON.
- Animometer/runner/animometer.html:
- Animometer/runner/resources/animometer.css:
- Animometer/runner/resources/animometer.js:
(window.benchmarkRunnerClient.willAddTestFrame):
(window.benchmarkRunnerClient.willStartFirstIteration):
(window.benchmarkRunnerClient.didRunSuites):
(window.benchmarkRunnerClient.didFinishLastIteration):
Make benchmarkRunnerClient uses ResultsDashboard instead of _iterationsSamplers
Get the JSON from ResultsDashboard.toJSON() and pass it to ResultsTable.showIterations().
Also set the textContent of the "#json" textarea with the results JSON.
(showResults): Delete unneeded code.
(showJson): Shows the "json" section.
(showTestGraph): Rename showGraph() to be showTestGraph().
(showTestJSON): Shows the JSON of a single testResults.
(showGraph): Deleted.
- Animometer/runner/resources/tests.js:
Use the string table instead of putting literal strings.
- Animometer/tests/resources/stage.js:
(StageBenchmark.prototype.showResults):
Fix the parameters which are passed to RecordTable.showRecord().
- Animometer/tests/bouncing-particles/bouncing-canvas-images.html:
- Animometer/tests/bouncing-particles/bouncing-canvas-shapes.html:
- Animometer/tests/bouncing-particles/bouncing-css-images.html:
- Animometer/tests/bouncing-particles/bouncing-css-shapes.html:
- Animometer/tests/bouncing-particles/bouncing-svg-images.html:
- Animometer/tests/bouncing-particles/bouncing-svg-shapes.html:
- Animometer/tests/examples/canvas-electrons.html:
- Animometer/tests/examples/canvas-stars.html:
- Animometer/tests/simple/simple-canvas-paths.html:
- Animometer/tests/template/template-canvas.html:
- Animometer/tests/template/template-css.html:
- Animometer/tests/template/template-svg.html:
- Animometer/tests/text/layering-text.html:
Include the new strings.js file in all the test files.
- 8:59 AM Changeset in webkit [191585] by
-
- 1 edit3 adds in trunk/Websites/webkit.org
Add images needed for shadow DOM blog post
https://bugs.webkit.org/show_bug.cgi?id=150549
Reviewed by Timothy Hatcher.
Added images.
- blog-files/introducing-shadow-dom: Added.
- blog-files/introducing-shadow-dom/commit-queue-contact.png: Added.
- blog-files/introducing-shadow-dom/progress-bar.png: Added.
- 8:09 AM Changeset in webkit [191584] by
-
- 8 edits in trunk
[Streams API] Implement abort method on writable streams
https://bugs.webkit.org/show_bug.cgi?id=150444
Reviewed by Darin Adler.
Source/WebCore:
Abort method on writable streams implemented according to the spec.
Current test set suffices. Expectations are updated accordingly.
- Modules/streams/StreamInternals.js:
(promiseInvokeOrFallbackOrNoop): Implemented according to the spec.
- Modules/streams/WritableStream.js:
(abort): Implemented according to the spec.
LayoutTests:
Test expectations updated.
- streams/reference-implementation/bad-underlying-sinks-expected.txt:
- streams/reference-implementation/brand-checks-expected.txt:
- streams/reference-implementation/pipe-to-expected.txt:
- streams/reference-implementation/writable-stream-abort-expected.txt:
- 5:04 AM Changeset in webkit [191583] by
-
- 4 edits3 adds in trunk
Unreviewed, rolling out r191576.
.:
broke the http/tests/media tests
Reverted changeset:
"[GStreamer] Bump internal jhbuild versions to 1.6.0"
https://bugs.webkit.org/show_bug.cgi?id=149594
http://trac.webkit.org/changeset/191576
Tools:
broke
Reverted changeset:
"[GStreamer] Bump internal jhbuild versions to 1.6.0"
https://bugs.webkit.org/show_bug.cgi?id=149594
http://trac.webkit.org/changeset/191576
- 3:32 AM Changeset in webkit [191582] by
-
- 1 copy in releases/WebKitGTK/webkit-2.10.3
WebKitGTK+ 2.10.3
- 3:31 AM Changeset in webkit [191581] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.10.3 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.10.3
- 2:31 AM Changeset in webkit [191580] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r191549 - [TexMap] Fix a misused flag for GstGL
https://bugs.webkit.org/show_bug.cgi?id=150545
Reviewed by Žan Doberšek.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):
We should pass TextureMapperGL::Flags to the TextureMapperGL::drawTexture instead of
BitmapTexture::Flags.
- 2:30 AM Changeset in webkit [191579] by
-
- 5 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r191541 - [TexMap] Clean up BitmapTexture and BitmapTextureGL.
https://bugs.webkit.org/show_bug.cgi?id=143298
Reviewed by Žan Doberšek.
No new tests, this is just a refactor.
- platform/graphics/texmap/BitmapTexture.h:
(WebCore::BitmapTexture::canReuseWith): Deleted.
Reuseability of a BitmapTexture is only decided by its size.
We can use size() instead of this method.
- platform/graphics/texmap/BitmapTextureGL.h:
(WebCore::driverSupportsExternalTextureBGRA): Deleted.
We do not have to check a suitable texture format in every
update/reset. It is enough to store the formats in construction time
and reuse them.
- 2:26 AM Changeset in webkit [191578] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r191540 - REGRESSION (r187121): Delayed instantaneous animations not honouring ' forwards' fill-mode
https://bugs.webkit.org/show_bug.cgi?id=150326
Reviewed by Darin Adler.
Source/WebCore:
With a zero-duration, delayed fill-forwards animation, we'd end up trying
to interpolate between the last and first keyframes, and picking the first
because AnimationBase::progress() had a special case for zero duration. Removing
this check fixes the bug.
Test: animations/fill-mode-forwards-zero-duration.html
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::progress):
LayoutTests:
Test with a zero-duration, delayed fill-forwards animation.
- animations/fill-mode-forwards-zero-duration-expected.txt: Added.
- animations/fill-mode-forwards-zero-duration.html: Added.
- 2:25 AM Changeset in webkit [191577] by
-
- 16 edits3 adds in releases/WebKitGTK/webkit-2.10
Merge r191530 - REGRESSION (r179357-r179359): WebContent Crash using AOL Mail @ com.apple.JavascriptCore JSC::linkPolymorphicCall(JSC::ExecState*, JSC::CallLinkInfo&, JSC::CallVariant, JSC::RegisterPreservationMode) + 1584
https://bugs.webkit.org/show_bug.cgi?id=150513
Reviewed by Saam Barati.
Source/JavaScriptCore:
Add check in linkPolymorphicCall() to make sure we have a CodeBlock for the newly added variant.
If not, we turn the call into a virtual call.
The bug was caused by a stack overflow when preparing the function for execution. This properly
threw an exception, however linkPolymorphicCall() didn't check for this error case.
Added a new test function "failNextNewCodeBlock()" to test tools to simplify the testing.
- API/JSCTestRunnerUtils.cpp:
(JSC::failNextNewCodeBlock):
(JSC::numberOfDFGCompiles):
- API/JSCTestRunnerUtils.h:
- jit/Repatch.cpp:
(JSC::linkPolymorphicCall):
- jsc.cpp:
(GlobalObject::finishCreation):
(functionTransferArrayBuffer):
(functionFailNextNewCodeBlock):
(functionQuit):
- runtime/Executable.cpp:
(JSC::ScriptExecutable::prepareForExecutionImpl):
- runtime/TestRunnerUtils.cpp:
(JSC::optimizeNextInvocation):
(JSC::failNextNewCodeBlock):
(JSC::numberOfDFGCompiles):
- runtime/TestRunnerUtils.h:
- runtime/VM.h:
(JSC::VM::setFailNextNewCodeBlock):
(JSC::VM::getAndClearFailNextNewCodeBlock):
(JSC::VM::stackPointerAtVMEntry):
Tools:
Added a new test function, failNextNewCodeBlock() to simplify the writing of a regression test.
- DumpRenderTree/TestRunner.cpp:
(simulateWebNotificationClickCallback):
(failNextCodeBlock):
(numberOfDFGCompiles):
(TestRunner::staticFunctions):
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setBlockAllPlugins):
(WTR::TestRunner::failNextCodeBlock):
(WTR::TestRunner::numberOfDFGCompiles):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
LayoutTests:
New regression test.
- js/regress-150513-expected.txt: Added.
- js/regress-150513.html: Added.
- js/script-tests/regress-150513.js: Added.
(test):
- resources/standalone-pre.js: Added failNextNewCodeBlock to testRunner object.
- 1:57 AM Changeset in webkit [191576] by
-
- 4 edits3 deletes in trunk
[GStreamer] Bump internal jhbuild versions to 1.6.0
https://bugs.webkit.org/show_bug.cgi?id=149594
Reviewed by Philippe Normand.
.:
Bump up the minimum reqirement version of gstreamer-gl to 1.6.0.
- Source/cmake/FindGStreamer.cmake:
Tools:
Bump up whole gstreamer libraries to 1.6.0. Relevant patches are no more
useful so they are removed accordingly.
- gtk/jhbuild.modules:
- gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
- gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
- gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
- 1:56 AM Changeset in webkit [191575] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r191525 - Avoid SVG-induced layouts inside Element::absoluteEventBounds()
https://bugs.webkit.org/show_bug.cgi?id=150516
Reviewed by Zalan Bujtas.
Speculative fix for a crash under RenderObject::localToContainerQuad() when
computing the wheel event handler region, which uses Element::absoluteEventHandlerBounds().
Element::absoluteEventBounds() was calling SVGElement::getBoundingBox() in a way
that could trigger a layout.
- dom/Element.cpp:
(WebCore::Element::absoluteEventBounds):
- 1:54 AM Changeset in webkit [191574] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r191503 - [GTK] Minor web editor fixes
https://bugs.webkit.org/show_bug.cgi?id=150501
Reviewed by Carlos Garcia Campos.
- UIProcess/gtk/KeyBindingTranslator.cpp: Remove
"MoveParagraphForward/Backward" as these commands do not exist in
WebKit (anymore?).
- WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
(WebKit::WebEditorClient::executePendingEditorCommands):
Editor::Command can take a String, no need to convert to a C char.
- 1:53 AM Changeset in webkit [191573] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r191502 - REGRESSION (r187121): Multiple-keyframe animations not honouring ' forwards' fill-mode
https://bugs.webkit.org/show_bug.cgi?id=150328
Reviewed by Dean Jackson.
Source/WebCore:
AnimationBase::getElapsedTime() for a finished animation would return 1 (a progress),
rather than a time value as the caller expects. Fix it to return the total duration
if the animation has finished. This fixes the bug.
Change CompositeAnimation::pauseAnimationAtTime() to be more permissive, allowing
testing of filling-forwards animations with the pause API.
Test: animations/fill-forwards-end-state.html
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::getElapsedTime):
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::pauseAnimationAtTime):
LayoutTests:
Filling-forwards test with an animation whose duration is greater than one second,
which showed the bug.
- animations/fill-forwards-end-state-expected.txt: Added.
- animations/fill-forwards-end-state.html: Added.
- 1:47 AM Changeset in webkit [191572] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r191492 - ConvolverNode.buffer must have same sample-rate as the AudioContext
https://bugs.webkit.org/show_bug.cgi?id=150385
Patch by Hyemi Shin <hyemi.sin@samsung.com> on 2015-10-23
Reviewed by Chris Dumez.
ConvolverNode.buffer must be of the same sample-rate as the AudioContext
or an NOT_SUPPORTED_ERR exception MUST be thrown.
Test : webaudio/convolver-setBuffer-different-samplerate.html
- Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::setBuffer):
- Modules/webaudio/ConvolverNode.h:
- Modules/webaudio/ConvolverNode.idl:
LayoutTests:
ConvolverNode.buffer must have same sample rate as the AudioContext
https://bugs.webkit.org/show_bug.cgi?id=150385
Patch by Hyemi Shin <hyemi.sin@samsung.com> on 2015-10-23
Reviewed by Chris Dumez.
- webaudio/convolver-setBuffer-different-samplerate-expected.txt: Added.
- webaudio/convolver-setBuffer-different-samplerate.html: Added.
- 1:37 AM Changeset in webkit [191571] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r191481 - ERROR: Unhandled web process message 'StorageAreaMap:DispatchStorageEvent'
https://bugs.webkit.org/show_bug.cgi?id=150315
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2015-10-22
Reviewed by Andreas Kling.
It was introduced in r184930, that keeps the session storage area
maps alive in the UI process when they are destroyed by the web
process. The problem is that we also keep the listeners, so that
events are also dispatched to the listeners of destroyed areas,
and the message handlers were removed in the web process.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createTransientLocalStorageMap): Add a
listener for the new storage map ID when the map is reused.
(WebKit::StorageManager::destroyStorageMap): Always remove
listeners of destroyed maps.
- 1:36 AM Changeset in webkit [191570] by
-
- 15 edits1 add in releases/WebKitGTK/webkit-2.10
Merge r191451 - REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
https://bugs.webkit.org/show_bug.cgi?id=150428
Reviewed by Antti Koivisto.
Source/WebCore:
The bug was caused by updateFocusAppearance in WebPage::restoreSelectionInFocusedEditableElement
revealing the focused element which was added in r181972. Fixed the bug by adding an option to
suppress this behavior here.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::updateFocusAppearanceSoon):
- dom/Document.h:
- dom/Element.cpp:
(WebCore::Element::focus):
(WebCore::Element::updateFocusAppearanceAfterAttachIfNeeded):
(WebCore::Element::updateFocusAppearance):
- dom/Element.h:
- history/CachedPage.cpp:
(WebCore::CachedPage::restore):
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::updateFocusAppearance):
- html/HTMLAreaElement.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateFocusAppearance):
(WebCore::HTMLInputElement::runPostTypeUpdateTasks):
(WebCore::HTMLInputElement::didAttachRenderers):
- html/HTMLInputElement.h:
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updateFocusAppearance):
- html/HTMLTextAreaElement.h:
Source/WebKit2:
Call updateFocusAppearance with RevealMode::DoNotReveal to avoid revealing the focused element.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::restoreSelectionInFocusedEditableElement):
Tools:
Added a regression test using WebKit API test.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm: Added.
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):
- 1:18 AM Changeset in webkit [191569] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10
Merge r191442 - [GTK][Mac] ICU-related build fixes
https://bugs.webkit.org/show_bug.cgi?id=150032
Rubber-stamped by Darin Adler.
- Source/cmake/FindICU.cmake: Use pkg-config to hint at icu-i18n's library location.
- 1:16 AM Changeset in webkit [191568] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r191403 - Null dereference loading Blink layout test svg/filters/display-none-filter-primitive.html
https://bugs.webkit.org/show_bug.cgi?id=150212
<rdar://problem/23137376>
Reviewed by Brent Fulgham.
Source/WebCore:
Handle the case where a filter element doesn't have a renderer. Inspired by the Blink
commit:
https://chromium.googlesource.com/chromium/src.git/+/fb79f7fc46552d45127acd2959a23662ad8f271e
Test: svg/filters/display-none-filter-primitive.html
- rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::buildPrimitives):
- svg/graphics/filters/SVGFilterBuilder.cpp:
(WebCore::SVGFilterBuilder::appendEffectToEffectReferences):
LayoutTests:
- svg/filters/display-none-filter-primitive-expected.txt: Added.
- svg/filters/display-none-filter-primitive.html: Added.
- 1:10 AM Changeset in webkit [191567] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r191386 - ASSERTION FAILED: markFontData in FontCascade::emphasisMarkHeight
https://bugs.webkit.org/show_bug.cgi?id=150171
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2015-10-21
Reviewed by Myles C. Maxfield.
It happens with several tests like fast/ruby/text-emphasis.html in
the GTK Debug bot. The tests seem to pass in Release and the rendering
looks correct as well removing the assert. The thing is that
for some reason we can get an empty GlyphData from
FontCascade::getEmphasisMarkGlyphData() when it ends up falling
back to system (FontCascadeFonts::glyphDataForSystemFallback).
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::getEmphasisMarkGlyphData): Return
Optional<GlyphData> instead of returning a boolean and an out
parameter. If we get an invalid GlyphData, Nullopt is
returned. Also use a SurrogatePairAwareTextIterator to handle
surrogate pairs.
(WebCore::FontCascade::emphasisMarkAscent):
(WebCore::FontCascade::emphasisMarkDescent):
(WebCore::FontCascade::emphasisMarkHeight):
(WebCore::FontCascade::drawEmphasisMarks):
- platform/graphics/FontCascade.h:
- platform/graphics/GlyphPage.h:
(WebCore::GlyphData::isValid): Return whether the GlyphData is valid.
- 12:54 AM Changeset in webkit [191566] by
-
- 24 edits in releases/WebKitGTK/webkit-2.10/Source
Merge r191381 - NetworkProcess: DNS prefetch happens in the Web Process
https://bugs.webkit.org/show_bug.cgi?id=147824
Reviewed by Chris Dumez.
Source/WebCore:
Use FrameLoaderClient to do the DNS prefetch.
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):
- loader/EmptyClients.h:
- loader/FrameLoaderClient.h:
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLink):
- page/Chrome.cpp:
(WebCore::Chrome::mouseDidMoveOverElement):
Source/WebKit/mac:
Implement FrameLoaderClient::prefetchDNS().
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
Source/WebKit/win:
Implement FrameLoaderClient::prefetchDNS().
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::prefetchDNS):
- WebCoreSupport/WebFrameLoaderClient.h:
Source/WebKit2:
DNS prefetch requests started in the WebProcess should be sent to
the network process when it's enabled.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::prefetchDNS): Use NetworkProcess::prefetchDNS().
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in: Add
PrefetchDNS message.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::prefetchDNS): Do the actual DNS prefetch.
- NetworkProcess/NetworkProcess.h:
- WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:
(webkitWebExtensionDidReceiveMessage): Use WebProcess::prefetchDNS().
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::prefetchDNS): Use WebProcess::prefetchDNS().
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary): Use
FrameLoaderClient to do the DNS prefetch.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess): Initialize the DNS prefetched
hosts cleanup hysteresis activity. Clear the cache of DNS
prefetched when hysteresis activity stopped.
(WebKit::WebProcess::prefetchDNS): Send the request to the network
process if it's enabled, otherwise do the actual DNS prefetch.
- WebProcess/WebProcess.h:
- 12:49 AM Changeset in webkit [191565] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r191357 - AX: CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::AccessibilityTable::tableElement const + 116
https://bugs.webkit.org/show_bug.cgi?id=150349
Reviewed by Brent Fulgham.
The crash point for this bug says that the parentElement of the firstBody is garbage when it's accessed.
Unfortunately, I could not reproduce this in-situ or with a test.
So my speculative solution is to recalculate those body elements to ensure that they're valid before we access.
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::tableElement):
(WebCore::AccessibilityTable::isDataTable):
- 12:47 AM Changeset in webkit [191564] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r191341 - [UNIX] ASSERTION FAILED: m_shouldWaitForSyncReplies in Connection::connectionDidClose()
https://bugs.webkit.org/show_bug.cgi?id=150361
Reviewed by Martin Robinson.
It doesn't always happen because it depends on how sockets are
closed, and the state of the threads. The problem is that we are
not handling the case when the read fails because we closed the
connection. In that case we log the error and call
Connection::connectionDidClose(). But it was connectionDidClose()
the one closing the socket. So, in this particular case it's not an
error but a normal termination, and we shouldn't try to close the
connection again. Something similar can happen while sending a
message, and we get a broken pipe error, but in that case we are
only printing the error, so it's harmless.
- Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::readyReadHandler): Only print error and call
connectionDidClose() if we are still connected when read fails.
(IPC::Connection::sendOutgoingMessage): Only print error if we are
still connected when send fails.
- 12:44 AM Changeset in webkit [191563] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r191338 - [GTK] Fix build for ENABLE_PLUGIN_PROCESS_GTK2=OFF
https://bugs.webkit.org/show_bug.cgi?id=150086
Reviewed by Darin Adler.
- UIProcess/cairo/BackingStoreCairo.cpp:
(WebKit::BackingStore::createBackend):
- 12:43 AM Changeset in webkit [191562] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r191332 - ASSERTION FAILED: m_state == Initialized in SubresourceLoader::didReceiveResponse()
https://bugs.webkit.org/show_bug.cgi?id=150327
Reviewed by Antti Koivisto.
This is how it happens:
- print() is called while the document is still loading, so m_shouldPrintWhenFinishedLoading is set to true
- DataURLDecoder::decode() finishes in the work queue thread, the completion handler is scheduled in the main thread
- The load is cancelled 3.1. SubresourceLoader::willCancel sets m_state = Finishing 3.2. DOMWindow::finishedLoading() is called, and since
m_shouldPrintWhenFinishedLoading is true, it does the print.
3.3. Cancellation finishes and ResourceLoader::releaseResources()
is called that sets m_reachedTerminalState = true
So, between 3.1 and 3.3, the state is Finishing, but
m_reachedTerminalState is false. What happens, in the GTK+ port at
least, is that the nested main loop used to make print()
synchronous, processes the DataURLDecoder::decode() completion
handler that was pending. The completion handler returns early if
m_reachedTerminalState is true, but it's not yet in this
particular case. So, it ends up calling didReceiveResponse,
because the decode didn't fail, when the subresource loader state
is Finishing.
I think there are two things here. One is that we shouldn't start
a print that was waiting for the load to finish when it
failed. That would fix the problem. But it's probably a good idea
to also check for cancellation in the DataURLDecoder::decode()
completion handler.
Fixes printing/print-close-crash.html in GTK+ Debug.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::loadDataURL): Return early from
DataURLDecoder::decode() completion handler if the load was cancelled.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::finishedLoading): Do not start a print that
was witing for the load to finish when it failed.
- 12:38 AM Changeset in webkit [191561] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r191284 - [GTK] ASSERTION FAILED: parent in WebInspectorProxy::platformDetach()
https://bugs.webkit.org/show_bug.cgi?id=150319
Reviewed by Žan Doberšek.
This happens when the inspector is shown/closed very
quickly. Since we start the inspector attached by default, when
the web inspector is created m_isAttached is set to true, so that
when opened, it's attached to the view. If the inspector is closed
before it has been actually attached, the inspector view doesn't
have a parent, even if the m_isAttached is true. So, we should
handle this case instead of asserting. This is what happens in
test http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html.
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformDetach): Remove the view from
its parent container if it was actually attached.
- 12:37 AM Changeset in webkit [191560] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r191272 - [GTK] Remove WebKitContextMenu related missing annotation warnings
https://bugs.webkit.org/show_bug.cgi?id=150299
Patch by Joonghun Park <jh718.park@samsung.com> on 2015-10-18
Reviewed by Darin Adler.
The warnings occur currently because when executing g-ir-scanner,
it doesn't consider WebKitContextMenu related .cpp files,
but only .h files.
- PlatformGTK.cmake: Add WebKitContextMenu related cpp files.
- 12:34 AM Changeset in webkit [191559] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r191233 - Avoid to insert TAB before HTML element.
https://bugs.webkit.org/show_bug.cgi?id=149295
<rdar://problem/22746706>
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-16
Reviewed by Ryosuke Niwa.
Source/WebCore:
This is a merge of Blink r175047:
https://codereview.chromium.org/306583005
This patch avoids InsertTextCommand::insertTab before HTML element because
we can't set Text node as document element.
Test: editing/execCommand/insert-tab-to-html-element-crash.html
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::insertTab):
LayoutTests:
- editing/execCommand/insert-tab-to-html-element-crash-expected.txt: Added.
- editing/execCommand/insert-tab-to-html-element-crash.html: Added.
- 12:30 AM Changeset in webkit [191558] by
-
- 6 edits in releases/WebKitGTK/webkit-2.10/Source/bmalloc
Merge r191196 - bmalloc: per-thread cache data structure should be smaller
https://bugs.webkit.org/show_bug.cgi?id=150218
Reviewed by Andreas Kling.
Reduce the number of entries in the range cache because it's really
big, and the bigness only helps in cases of serious fragmentation, and
it only saves us a little bit of lock acquisition time.
- bmalloc/Allocator.cpp:
(bmalloc::Allocator::scavenge):
(bmalloc::Allocator::refillAllocatorSlowCase):
(bmalloc::Allocator::refillAllocator):
(bmalloc::Allocator::allocateLarge):
(bmalloc::Allocator::allocateSlowCase):
(bmalloc::Allocator::allocateBumpRangeSlowCase): Deleted.
(bmalloc::Allocator::allocateBumpRange): Deleted.
- bmalloc/Allocator.h: Pass through the empty allocator and the range
cache when refilling, and refill both. Otherwise, we always immediately
pop the last item in the range cache, wasting that slot of capacity.
- bmalloc/Heap.cpp:
(bmalloc::Heap::allocateSmallBumpRanges):
(bmalloc::Heap::allocateMediumBumpRanges): Account for the fact that
the range cache is no longer big enough to guarantee that it can hold
all the ranges in a page.
(bmalloc::Heap::refillSmallBumpRangeCache): Deleted.
(bmalloc::Heap::refillMediumBumpRangeCache): Deleted.
- bmalloc/Heap.h: Move VMHeap to the end of the object because it
contains a lot of unused / wasted space, and we want to pack our data
together in memory.
- bmalloc/Sizes.h: Make the range cache smaller.
- 12:28 AM Changeset in webkit [191557] by
-
- 10 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r191195 - First line box in paragraph using initial-letter overflows.
https://bugs.webkit.org/show_bug.cgi?id=147977
<rdar://problem/22901553>
Reviewed by David Hyatt.
When initial-letter float is present, we should shrink the first
line even if it's not intersected with the block's current height.
This is because of the sunken behaviour of initial-letter.
Source/WebCore:
Test: fast/css-generated-content/initial-letter-first-line-wrapping.html
- rendering/RenderBlockFlow.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::positionNewFloatOnLine):
- rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleFloat):
- rendering/line/LineBreaker.cpp:
(WebCore::LineBreaker::skipLeadingWhitespace):
- rendering/line/LineBreaker.h:
(WebCore::LineBreaker::positionNewFloatOnLine):
- rendering/line/LineWidth.cpp:
(WebCore::newFloatShrinksLine):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
- rendering/line/LineWidth.h:
LayoutTests:
- fast/css-generated-content/initial-letter-first-line-wrapping-expected.html: Added.
- fast/css-generated-content/initial-letter-first-line-wrapping.html: Added.
- platform/mac/fast/css-generated-content/initial-letter-basic-expected.txt: progression.
- 12:13 AM Changeset in webkit [191556] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r191174 - [GStreamer] ASSERTION FAILED: !m_adoptionIsRequired in MediaSourceGStreamer::addSourceBuffer
https://bugs.webkit.org/show_bug.cgi?id=150229
Reviewed by Philippe Normand.
This happens in the debug bot in all media source tests that run
that code. The problem is that we are creating a RefPtr without
adopting the reference.
- platform/graphics/gstreamer/MediaSourceGStreamer.cpp:
(WebCore::MediaSourceGStreamer::addSourceBuffer): Use
SourceBufferPrivateGStreamer::create().
- platform/graphics/gstreamer/SourceBufferPrivateGStreamer.cpp:
(WebCore::SourceBufferPrivateGStreamer::create): Added to make
sure you can't create a SourceBufferPrivateGStreamer without
adopting the reference.
(WebCore::SourceBufferPrivateGStreamer::SourceBufferPrivateGStreamer):
Takes a reference to the client instead of a PassRefPtr.
- platform/graphics/gstreamer/SourceBufferPrivateGStreamer.h:
- 12:11 AM Changeset in webkit [191555] by
-
- 6 edits in releases/WebKitGTK/webkit-2.10
Merge r191132 - CSSKeyframesRule::appendRule is deprecated, but is actually the spec
https://bugs.webkit.org/show_bug.cgi?id=150113
Reviewed by Simon Fraser.
Source/WebCore:
I stupidly deprecated the wrong function in
http://trac.webkit.org/changeset/174469
- css/CSSKeyframesRule.cpp:
(WebCore::CSSKeyframesRule::insertRule): Swap the code between these two.
(WebCore::CSSKeyframesRule::appendRule):
LayoutTests:
Update tests to deprecate the correct function.
- animations/change-keyframes-expected.txt:
- animations/keyframes-rule.html:
- animations/unprefixed-keyframes-rule.html:
