Timeline
Nov 4, 2015:
- 11:12 PM Changeset in webkit [192052] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Epiphany with Debug mode compiled WebKitGtk+ 2.10.3 hits ASSERT_ARG on willEnterAcceleratedCompositingMode
https://bugs.webkit.org/show_bug.cgi?id=150620
Reviewed by Mario Sanchez Prada.
WillEnterAcceleratedCompositingMode message is sent when the
LayerTreeHost is created in the Web Process. This can happen while
there's still a DidUpdateBackingStoreState pending, in which case
we are receiving the new backingStoreStateID, but the current one
hasn't been updated yet.
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::willEnterAcceleratedCompositingMode):
Fix the ASSERT to check the given ID is alt least the next one,
and remove the early return since it's valid to not enter AC mode
in the end after the WillEnter message.
- 9:50 PM Changeset in webkit [192051] by
-
- 16 edits in trunk/Source/JavaScriptCore
[JSC] Add B3-to-Air lowering for the shift opcodes
https://bugs.webkit.org/show_bug.cgi?id=150919
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-11-04
Reviewed by Filip Pizlo.
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::rshift64):
(JSC::MacroAssemblerX86_64::urshift64):
- assembler/X86Assembler.h:
(JSC::X86Assembler::shrq_CLr):
- b3/B3Const32Value.cpp:
(JSC::B3::Const32Value::shlConstant):
(JSC::B3::Const32Value::sShrConstant):
(JSC::B3::Const32Value::zShrConstant):
- b3/B3Const32Value.h:
- b3/B3Const64Value.cpp:
(JSC::B3::Const64Value::shlConstant):
(JSC::B3::Const64Value::sShrConstant):
(JSC::B3::Const64Value::zShrConstant):
- b3/B3Const64Value.h:
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::appendShift):
(JSC::B3::Air::LowerToAir::tryShl):
(JSC::B3::Air::LowerToAir::trySShr):
(JSC::B3::Air::LowerToAir::tryZShr):
- b3/B3LoweringMatcher.patterns:
- b3/B3Opcode.h:
- b3/B3ReduceStrength.cpp:
- b3/B3Value.cpp:
(JSC::B3::Value::shlConstant):
(JSC::B3::Value::sShrConstant):
(JSC::B3::Value::zShrConstant):
- b3/B3Value.h:
- b3/air/AirInstInlines.h:
(JSC::B3::Air::isShiftValid):
(JSC::B3::Air::isRshift32Valid):
(JSC::B3::Air::isRshift64Valid):
(JSC::B3::Air::isUrshift32Valid):
(JSC::B3::Air::isUrshift64Valid):
- b3/air/AirOpcode.opcodes:
- b3/testb3.cpp:
(JSC::B3::testShlArgs):
(JSC::B3::testShlImms):
(JSC::B3::testShlArgImm):
(JSC::B3::testShlArgs32):
(JSC::B3::testShlImms32):
(JSC::B3::testShlArgImm32):
(JSC::B3::testSShrArgs):
(JSC::B3::testSShrImms):
(JSC::B3::testSShrArgImm):
(JSC::B3::testSShrArgs32):
(JSC::B3::testSShrImms32):
(JSC::B3::testSShrArgImm32):
(JSC::B3::testZShrArgs):
(JSC::B3::testZShrImms):
(JSC::B3::testZShrArgImm):
(JSC::B3::testZShrArgs32):
(JSC::B3::testZShrImms32):
(JSC::B3::testZShrArgImm32):
(JSC::B3::run):
- 8:09 PM Changeset in webkit [192050] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Load markers persist in timeline ruler after resetting recording
https://bugs.webkit.org/show_bug.cgi?id=150918
Reviewed by Joseph Pecoraro.
- UserInterface/Views/OverviewTimelineView.js:
(WebInspector.OverviewTimelineView):
(WebInspector.OverviewTimelineView.prototype._recordingReset):
Clears ruler markers on recording reset. Adds current time marker back.
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview):
(WebInspector.TimelineOverview.prototype._recordingReset):
Clears ruler markers on recording reset. Adds current time marker back.
- UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler.prototype.clearMarkers):
Added method to clear markers and marker elements.
- 8:07 PM Changeset in webkit [192049] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught Exception opening inspector - TypeError: Attempted to assign to readonly property.
https://bugs.webkit.org/show_bug.cgi?id=150913
Reviewed by Timothy Hatcher.
Fix invalid call to BackForwardEntry.prototype.contentView set.
- UserInterface/Views/ContentViewContainer.js:
(WebInspector.ContentViewContainer.prototype.replaceContentView):
Replace each BackForwardEntry matching the old content view with a new entry.
- 7:21 PM Changeset in webkit [192048] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught exception mousing over CSS resource
https://bugs.webkit.org/show_bug.cgi?id=150917
Reviewed by Joseph Pecoraro.
- UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
(WebInspector.CodeMirrorTokenTrackingController.prototype._processMarkedToken): Add missing parameter.
- 7:16 PM Changeset in webkit [192047] by
-
- 2 edits in trunk/PerformanceTests
Remove "defer" from the scripts' references in the graphics benchmark home page
https://bugs.webkit.org/show_bug.cgi?id=150915
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-11-04
Reviewed by Simon Fraser.
It causes the benchmark to be very flakey.
- Animometer/runner/animometer.html:
- 6:22 PM FeatureFlags edited by
- (diff)
- 5:51 PM Changeset in webkit [192046] by
-
- 2 edits in tags/Safari-602.1.10/Source/WebKit2
Merged r192045. rdar://problem/23402116
- 4:59 PM Changeset in webkit [192045] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r191499): 100% repro crash under _prepareForMoveToWindow:
https://bugs.webkit.org/show_bug.cgi?id=150912
<rdar://problem/23402116>
Reviewed by Simon Fraser.
- UIProcess/API/mac/WKView.mm:
(-[WKView _prepareForMoveToWindow:withCompletionHandler:]):
- 4:54 PM Changeset in webkit [192044] by
-
- 2 edits in trunk/Source/WebKit2
Regression(r192038): Crash in ~SandboxExtension()
https://bugs.webkit.org/show_bug.cgi?id=150898
Reviewed by Alex Christensen.
We are seeing a couple of crashes under ~SandboxExtension() on the bots
after ~SandboxExtension(). The reason is that the SandBoxExtension is
still in use (useCount > 0) when destroyed. This happens due to a bug
in setDefersLoading() that could cause the load to get started more
than once and thus the SandboxExtension to be consumed more than once.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::setDefersLoading):
(WebKit::NetworkResourceLoader::consumeSandboxExtensions):
- 4:46 PM Changeset in webkit [192043] by
-
- 6 edits2 adds in trunk
Null dereference loading Blink layout test editing/execCommand/delete-hidden-crash.html
https://bugs.webkit.org/show_bug.cgi?id=149289
<rdar://problem/22746352>
Reviewed by Enrica Casucci.
Source/WebCore:
This is a merge of Blink r176497:
https://codereview.chromium.org/340713003
It ensures the start & end positions in DeleteSelectionCommand::initializePositionData
are editable.
Test: editing/execCommand/delete-hidden-crash.html
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::initializePositionData):
- editing/Editor.cpp:
(WebCore::Editor::advanceToNextMisspelling):
- editing/htmlediting.cpp:
(WebCore::firstEditablePositionAfterPositionInRoot):
(WebCore::lastEditablePositionBeforePositionInRoot):
These two functions don't make any sense to return VisiblePosition. Change them
to return Position instead. Since there is a viable conversion from Position to
VisiblePosition. It should not change the behavior of any other components depending
on it.
- editing/htmlediting.h:
LayoutTests:
- editing/execCommand/delete-hidden-crash-expected.txt: Added.
- editing/execCommand/delete-hidden-crash.html: Added.
- 4:26 PM Changeset in webkit [192042] by
-
- 7 edits2 adds in trunk
Ruby base ending in tatechuyoko forces a line break before the tatechuyoko
https://bugs.webkit.org/show_bug.cgi?id=150883
Reviewed by Darin Adler.
Source/WebCore:
Asking the width of a 0-length tatechuyoko should return 0.
Test: fast/text/ruby-tatechuyoko.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::width):
LayoutTests:
- platform/mac/fast/text/international/text-combine-image-test-expected.txt: Updated.
- platform/mac/fast/text/tatechuyoko-expected.txt: Ditto.
- fast/text/ruby-tatechuyoko-expected.html: Added.
- fast/text/ruby-tatechuyoko.html: Added.
- 4:01 PM Changeset in webkit [192041] by
-
- 2 edits in trunk/LayoutTests
Updating expectations for fast/forms/HTMLOptionElement_label03.html on win
https://bugs.webkit.org/show_bug.cgi?id=150909
Unreviewed test gardening.
- platform/win/TestExpectations:
- 3:59 PM Changeset in webkit [192040] by
-
- 5 edits2 adds in trunk
Source/WebInspectorUI:
Web Inspector: WebInspector.Color should support #rgba and #rrggbbaa syntax
https://bugs.webkit.org/show_bug.cgi?id=150894
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-11-04
Reviewed by Timothy Hatcher.
Support for hex with alpha color syntax.
- UserInterface/Models/Color.js:
(WebInspector.Color.fromString):
(WebInspector.Color.prototype.nextFormat):
(WebInspector.Color.prototype.copy):
(WebInspector.Color.prototype.toString):
(WebInspector.Color.prototype._toShortHEXAlphaString):
(WebInspector.Color.prototype._toHEXAlphaString):
Add support for new hex syntax. Address some minor issues
like case insensitivity and extra comma separate values.
- UserInterface/Views/CodeMirrorTextMarkers.js:
This prevent trailing hex characters from showing up
when cycling through color variants.
- UserInterface/Views/CodeMirrorAdditions.js:
When CodeMirror stops treating the new values as error
this will give them our hex-color styles.
LayoutTests:
Web Inspector: Support #rgba and #rrggbbaa syntax
https://bugs.webkit.org/show_bug.cgi?id=150894
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-11-04
Reviewed by Timothy Hatcher.
- inspector/model/color-expected.txt: Added.
- inspector/model/color.html: Added.
- 3:34 PM Changeset in webkit [192039] by
-
- 10 edits in trunk
Fix crashing and flaky UIScriptController-based tests in fast/events/ios
https://bugs.webkit.org/show_bug.cgi?id=150901
<rdar://problem/23261499>
Reviewed by Simon Fraser.
Tools:
Clear out zooming and keyboard-related callbacks after uiScriptComplete has been invoked. This prevents
later tests from calling into code which previous tests attached to these callbacks and causing
WebKitTestRunner to crash due to accessing a deallocated UIScriptController.
- WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::platformClearAllCallbacks):
(WTR::UIScriptController::uiScriptComplete):
- WebKitTestRunner/UIScriptContext/UIScriptController.h:
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::platformClearAllCallbacks):
LayoutTests:
Several changes to tests in fast/events/ios that address flaky behavior when running these tests.
Removes an unnecessary (and flaky) check for the initial innerHeight in
keyboard-should-not-trigger-resize.html, refactors unscalable-viewport-clicks-on-doubletap.html to
send successive taps like the other fast-clicking tests, and adjusts input-value-after-oninput.html
to no longer break if typing in an input autocapitalizes the first letter.
- fast/events/ios/input-value-after-oninput.html:
- fast/events/ios/keyboard-should-not-trigger-resize-expected.txt:
- fast/events/ios/keyboard-should-not-trigger-resize.html:
- fast/events/ios/unscalable-viewport-clicks-on-doubletap-expected.txt:
- fast/events/ios/unscalable-viewport-clicks-on-doubletap.html:
- 2:39 PM Changeset in webkit [192038] by
-
- 8 edits6 adds in trunk/Source/WebKit2
[WK2] Extract networking code out of NetworkResourceLoader class to improve reusability
https://bugs.webkit.org/show_bug.cgi?id=150898
Reviewed by Alex Christensen.
Extract networking code out of NetworkResourceLoader class to improve
reusability (will be used for speculative revalidation) and simplify
the NetworkResourceLoader.
- CMakeLists.txt:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):
- NetworkProcess/NetworkLoad.cpp: Added.
- NetworkProcess/NetworkLoad.h: Added.
- NetworkProcess/NetworkLoadClient.h: Added.
- NetworkProcess/NetworkLoadParameters.cpp: Added.
- NetworkProcess/NetworkLoadParameters.h: Added.
- NetworkProcess/NetworkResourceLoader.cpp:
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/mac/NetworkLoadMac.mm: Added.
- NetworkProcess/mac/NetworkResourceLoaderMac.mm:
(WebKit::NetworkResourceLoader::willCacheResponseAsync):
- WebKit2.xcodeproj/project.pbxproj:
- 2:34 PM Changeset in webkit [192037] by
-
- 5 edits in trunk/Source/WebKit2
Link preview doesn't work on XHTML pages with Content-Type header as
application/xhtml+xml
https://bugs.webkit.org/show_bug.cgi?id=150740
-and corresponding-
rdar://problem/23063585
Reviewed by Darin Adler.
My original fix for this bug was incorrect in the presence of non-HTML
elements that happen to have the same local name as HTML elements. Since it
seems silly to have all of this logic in the UI process to determine whether
to treat something as a link or an image, this patch fixes the bug by adding
isLink and isImage to InteractionInformationAtPosition in order to simplify
everything. The only remaining uses of clickableElementName just use it to
compare against isNull and isEmpty, so that can be a bool too.
Add isLink and isImage, and turn clickableElementName into isClickableElement
- Shared/InteractionInformationAtPosition.cpp:
(WebKit::InteractionInformationAtPosition::encode):
(WebKit::InteractionInformationAtPosition::decode):
- Shared/InteractionInformationAtPosition.h:
Use the new isLink, isImage, and isClickableElement
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _actionForLongPress]):
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView _highlightLongPressRecognized:]):
(-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]):
(-[WKContentView _dataForPreviewItemController:atPosition:type:]):
Set everything correctly.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
- 2:21 PM Changeset in webkit [192036] by
-
- 5 edits in trunk
Fix crashing fast-clicking WK2 tests on iOS
https://bugs.webkit.org/show_bug.cgi?id=150896
<rdar://problem/23344491>
Reviewed by Simon Fraser.
Source/WebKit2:
In order for the modified fast-clicking tests to pass, we can't allow hit-testing to
find the tap highlight view. See the Radar for more UIKit-specific descriptions.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _showTapHighlight]):
LayoutTests:
Fix the fast-clicking tests by making them fire an exact number of times rather than
sending continuously until a minimum number of clicks are fired. This causes us to
avoid crashing during the following test when the marker events corresponding to single
taps fired after the test has completed have been handled.
- css3/touch-action/touch-action-manipulation-fast-clicks.html:
- fast/events/ios/viewport-device-width-at-initial-scale-fast-clicks.html:
- 2:15 PM Changeset in webkit [192035] by
-
- 4 edits in trunk/Source/JavaScriptCore
B3 should be able to compile a Check
https://bugs.webkit.org/show_bug.cgi?id=150878
Reviewed by Saam Barati.
The Check opcode in B3 is going to be our main OSR exit mechanism. It is a stackmap
value, so you can pass it any number of additional arguments, and you will get to find
out how those arguments are represented at the point that the value lands in the machine
code. Unlike a Patchpoint, a Check branches on a value, with the goal of supporting full
compare/branch fusion. The stackmap's generator runs in an out-of-line path to which
that branch is linked.
This change fills in the glue necessary to compile a Check and it includes a simple
test of this functionality. That test also happens to check that such simple code will
never use callee-saves, which I think is sensible.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::append):
(JSC::B3::Air::LowerToAir::ensureSpecial):
(JSC::B3::Air::LowerToAir::fillStackmap):
(JSC::B3::Air::LowerToAir::tryStackSlot):
(JSC::B3::Air::LowerToAir::tryPatchpoint):
(JSC::B3::Air::LowerToAir::tryCheck):
(JSC::B3::Air::LowerToAir::tryUpsilon):
- b3/B3LoweringMatcher.patterns:
- b3/testb3.cpp:
(JSC::B3::testSimplePatchpoint):
(JSC::B3::testSimpleCheck):
(JSC::B3::run):
- 1:46 PM Changeset in webkit [192034] by
-
- 7 edits4 adds in trunk
Fix endless OSR exits when creating a rope that contains an object that ToPrimitive's to a number.
https://bugs.webkit.org/show_bug.cgi?id=150583
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
Before we assumed that the result of ToPrimitive on any object was a string.
This had a couple of negative effects. First, the result ToPrimitive on an
object can be overridden to be any primitive type. In fact, as of ES6, ToPrimitive,
when part of a addition expression, will type hint a number value. Second, even after
repeatedly exiting with a bad type we would continue to think that the result
of ToPrimitive would be a string so we continue to convert StrCats into MakeRope.
The fix is to make Prediction Propagation match the behavior of Fixup and move
canOptimizeStringObjectAccess to DFGGraph.
- bytecode/SpeculatedType.h:
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::attemptToForceStringArrayModeByToStringConversion):
(JSC::DFG::FixupPhase::fixupToPrimitive):
(JSC::DFG::FixupPhase::fixupToStringOrCallStringConstructor):
(JSC::DFG::FixupPhase::attemptToMakeFastStringAdd):
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane): Deleted.
(JSC::DFG::FixupPhase::canOptimizeStringObjectAccess): Deleted.
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::isStringPrototypeMethodSane):
(JSC::DFG::Graph::canOptimizeStringObjectAccess):
- dfg/DFGGraph.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::resultOfToPrimitive):
(JSC::DFG::resultOfToPrimitive): Deleted.
- bytecode/SpeculatedType.h:
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::attemptToForceStringArrayModeByToStringConversion):
(JSC::DFG::FixupPhase::fixupToPrimitive):
(JSC::DFG::FixupPhase::fixupToStringOrCallStringConstructor):
(JSC::DFG::FixupPhase::attemptToMakeFastStringAdd):
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane): Deleted.
(JSC::DFG::FixupPhase::canOptimizeStringObjectAccess): Deleted.
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::isStringPrototypeMethodSane):
(JSC::DFG::Graph::canOptimizeStringObjectAccess):
- dfg/DFGGraph.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::resultOfToPrimitive):
(JSC::DFG::resultOfToPrimitive): Deleted.
- tests/stress/string-rope-with-custom-valueof.js: Added.
(catNumber):
(number.valueOf):
(catBool):
(bool.valueOf):
(catUndefined):
(undef.valueOf):
(catRandom):
(random.valueOf):
LayoutTests:
Created a regression test to look for OSRing in string concatenation when
valueOf returns a non-string primitive.
- js/regress/script-tests/string-rope-with-object.js: Added.
(body.f):
(body.String.prototype.valueOf):
(body.bar.valueOf):
(body):
- js/regress/string-rope-with-object-expected.txt: Added.
- js/regress/string-rope-with-object.html: Added.
- 1:28 PM Changeset in webkit [192033] by
-
- 2 edits in trunk/LayoutTests
Rebaselining LayoutTest fast/text/international/thai-baht-space.html on win
https://bugs.webkit.org/show_bug.cgi?id=150865
Unreviewed test gardening.
- platform/win/fast/text/international/thai-baht-space-expected.txt:
- 12:50 PM Changeset in webkit [192032] by
-
- 2 edits in trunk/Source/WebCore
Update the name of a Mail class that we hardcode
https://bugs.webkit.org/show_bug.cgi?id=150879
<rdar://problem/23384627>
Reviewed by Alexey Proskuryakov.
- editing/cocoa/HTMLConverter.mm:
(_WebMessageDocumentClass):
- 11:38 AM Changeset in webkit [192031] by
-
- 2 edits in trunk/Source/WebKit2
PageLoadState::will/didChangeProcessIsResponsive should call observers
https://bugs.webkit.org/show_bug.cgi?id=150870
Reviewed by Dan Bernstein.
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::willChangeProcessIsResponsive):
(WebKit::PageLoadState::didChangeProcessIsResponsive):
- 11:21 AM Changeset in webkit [192030] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Speculative build fix. Missed the checkin for the changelog with r192029.
- UIProcess/API/Cocoa/WKWebView.mm:
- 11:03 AM Changeset in webkit [192029] by
-
- 1 edit in trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
- 10:55 AM Changeset in webkit [192028] by
-
- 14 edits in trunk/Source/WebCore
[MediaStream] A RealtimeMediaSource should begin producing data automatically
https://bugs.webkit.org/show_bug.cgi?id=150851
rdar://problem/23380636
A RealtimeMediaSource should be producing data unless it is muted, which is not under the
control of the application, so a local source should begin producing data as soon as it
is added to a stream. Remove "producing data" and "enabled" observer callbacks because
they don't provide anything that the "muted" callback already provides.
Reviewed by Jer Noble.
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::trackProducingDataChanged): Deleted.
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::didCreateStream): Tell sources to begin producing data.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::load): Don't call stream->startProducingData,
it isn't necessary.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setReadyState): Call characteristicsChanged
when the readyState changes.
- platform/mediastream/MediaStreamPrivate.cpp:
(WebCore::MediaStreamPrivate::trackProducingDataChanged): Deleted.
- platform/mediastream/MediaStreamPrivate.h:
- platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::sourceProducingDataChanged): Deleted.
(WebCore::MediaStreamTrackPrivate::sourceEnabledChanged): Deleted.
- platform/mediastream/MediaStreamTrackPrivate.h:
- platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::isProducingDataDidChange): Deleted.
(WebCore::RealtimeMediaSource::setEnabled): Deleted.
- platform/mediastream/RealtimeMediaSource.h:
- platform/mediastream/mac/AVAudioCaptureSource.mm:
(WebCore::AVAudioCaptureSource::captureOutputDidOutputSampleBufferFromConnection): !enabled() -> muted().
- platform/mediastream/mac/AVMediaCaptureSource.mm:
(WebCore::AVMediaCaptureSource::captureSessionIsRunningDidChange): Don't call isProducingDataDidChange..
- platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::processNewFrame): !enabled() -> muted().
- 10:48 AM Changeset in webkit [192027] by
-
- 12 edits6 adds in trunk
[iOS] <video> elements without audio tracks should not interrupt music
https://bugs.webkit.org/show_bug.cgi?id=149888
Reviewed by Eric Carlson.
Source/WebCore:
Tests: TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm
Only set the AVAudioSession category to "playback" when the video element in question has an
audio track.
Add a new PlatformMediaSessionClient method called canProduceAudio(), overridden in HTMLMediaElement
and AudioContext, which is checked when updating the AudioSession category in
PlatformMediaSessionManager::updateSessionState().
- Modules/webaudio/AudioContext.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged):
- html/HTMLMediaElement.h:
- platform/audio/PlatformMediaSession.cpp:
(WebCore::PlatformMediaSession::activeAudioSessionRequired):
(WebCore::PlatformMediaSession::setCanProduceAudio):
- platform/audio/PlatformMediaSession.h:
(WebCore::PlatformMediaSession::canProduceAudio):
- platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::canProduceAudio):
(WebCore::PlatformMediaSessionManager::sessionCanProduceAudioChanged):
(WebCore::PlatformMediaSessionManager::activeAudioSessionRequired):
(WebCore::PlatformMediaSessionManager::sessionWillBeginPlayback):
- platform/audio/PlatformMediaSessionManager.h:
- platform/audio/mac/MediaSessionManagerMac.cpp:
(PlatformMediaSessionManager::updateSessionState):
Tools:
Add tests to ensure that the AVAudioSession category is correctly set when playing
back media both with and without audio tracks.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm: Added.
(-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html: Added.
- TestWebKitAPI/Tests/WebKit/ios/video-with-audio.mp4: Added.
- TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html: Added.
- TestWebKitAPI/Tests/WebKit/ios/video-without-audio.mp4: Added.
- 10:40 AM Changeset in webkit [192026] by
-
- 2 edits in trunk/LayoutTests
Fixing test added with r192022
https://bugs.webkit.org/show_bug.cgi?id=150670
Unreviewed test gardening.
- accessibility/list-item-with-pseudo-element-crash.html:
- 10:12 AM Changeset in webkit [192025] by
-
- 2 edits in trunk/Tools
iOS test results are not visible on the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=150884
Reviewed by Darin Adler.
Re-generated builders.jsonp using generate_builders_json.py.
I think that this is all that's needed for basic support. There is more work needed
to display test expectations, but that's already mostly broken even for Mac.
- TestResultServer/static-dashboards/builders.jsonp:
- 10:09 AM Changeset in webkit [192024] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove bogus global internal functions for properties and prototype retrieval
https://bugs.webkit.org/show_bug.cgi?id=150892
Reviewed by Darin Adler.
Global @getOwnPropertyNames and @getPrototypeOf point to the floor function, so it is bogus dead code.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init): Removed global @getOwnPropertyNames and @getPrototypeOf.
- 9:49 AM Changeset in webkit [192023] by
-
- 14 edits2 adds8 deletes in trunk
Accept 8 and 4 value hex colors (#RRGGBBAA)
https://bugs.webkit.org/show_bug.cgi?id=150853
<rdar://problem/23380930>
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
Delete these tests. The have been updated in the original repository,
so we'll get the new versions soon. Meanwhile, they are covered by
other tests.
- canvas/2d.fillStyle.parse.invalid.hex4-expected.txt: Removed.
- canvas/2d.fillStyle.parse.invalid.hex4.html: Removed.
- canvas/2d.fillStyle.parse.invalid.hex8-expected.txt: Removed.
- canvas/2d.fillStyle.parse.invalid.hex8.html: Removed.
- css/css-color-3/t421-rgb-hex-parsing-f.xht:
Source/WebCore:
CSS Color Level 4 allows #RGBA and #RRGGBBAA values
for colors.
Test: fast/css/hex-colors.html
- platform/graphics/Color.cpp:
(WebCore::parseHexColorInternal): Update the color parsing for
the new syntax.
LayoutTests:
Add a new test for hex colors that covers 4 and 8 value forms.
Also update existing tests now that the syntax has changed.
For the deleted philip tests, they are now in the W3C web-latform-tests import.
- canvas/philip/tests/2d.fillStyle.parse.invalid.hex4-expected.txt: Removed.
- canvas/philip/tests/2d.fillStyle.parse.invalid.hex4.html: Removed.
- canvas/philip/tests/2d.fillStyle.parse.invalid.hex8-expected.txt: Removed.
- canvas/philip/tests/2d.fillStyle.parse.invalid.hex8.html: Removed.
- fast/css/hex-colors-expected.txt: Added.
- fast/css/hex-colors.html: Added.
- fast/css/invalid-hex-color-expected.txt:
- fast/css/invalid-hex-color.html:
- fast/css/invalid-predefined-color-expected.txt:
- fast/css/invalid-predefined-color.html:
- fast/css/script-tests/invalid-predefined-color.js:
- fast/dom/attribute-legacy-colors-expected.txt:
- fast/dom/script-tests/attribute-legacy-colors.js:
- svg/dom/rgb-color-parser-expected.txt:
- svg/dom/rgb-color-parser.html:
- 6:46 AM Changeset in webkit [192022] by
-
- 4 edits2 adds in trunk
[AX] WebProcess from WebKitGtk+ 2.10.0 compiled in Debug mode hits ASSERT on textUnderElement
https://bugs.webkit.org/show_bug.cgi?id=150670
Source/WebCore:
Patch by Mario Sanchez Prada <mario@webkit.org> on 2015-11-04
Reviewed by Chris Fleizach.
Move the ASSERTs stating that the render tree is stable before using the
TextIterator to their right place, in AccessibilityRenderObject, so that
we don't crash in debug builds in cases when this condition is irrelevant.
Test: accessibility/gtk/list-item-with-pseudo-element-crash.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::textUnderElement): Removed ASSERTs.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement): Added ASSERTs, but
only before calling plainText and using the right document for the node.
LayoutTests:
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2015-11-04
Reviewed by Chris Fleizach.
- accessibility/list-item-with-pseudo-element-crash-expected.txt: Added.
- accessibility/list-item-with-pseudo-element-crash.html: Added.
- 3:15 AM Changeset in webkit [192021] by
-
- 8 edits2 adds in trunk
[Streams API] Shield streams against user replacing the Promise constructor
https://bugs.webkit.org/show_bug.cgi?id=150887
Reviewed by Youenn Fablet.
Source/WebCore:
With this rework, we shield the Streams implementation against the user doing something like "Promise =
function() { /* do garbage */ };".
Test: streams/streams-promises.html.
- Modules/streams/ReadableStream.js:
(initializeReadableStream):
(cancel):
- Modules/streams/ReadableStreamInternals.js:
(privateInitializeReadableStreamReader):
(cancelReadableStream):
(readFromReadableStreamReader):
- Modules/streams/ReadableStreamReader.js:
(cancel):
(read):
(closed):
- Modules/streams/StreamInternals.js:
(promiseInvokeOrNoop):
(promiseInvokeOrFallbackOrNoop):
- Modules/streams/WritableStream.js:
(initializeWritableStream):
(abort):
(close):
(write):
(closed):
(ready):
- Modules/streams/WritableStreamInternals.js:
(syncWritableStreamStateWithQueue):
LayoutTests:
- streams/streams-promises-expected.txt: Added.
- streams/streams-promises.html: Added.
- 2:40 AM Changeset in webkit [192020] by
-
- 6 edits12 adds in trunk
SVG: hit testing region for <text> elements is incorrect
https://bugs.webkit.org/show_bug.cgi?id=150838
Patch by Antoine Quint <Antoine Quint> on 2015-11-04
Reviewed by Dean Jackson.
Source/WebCore:
Hit testing for SVG <text> elements was using the same code as hit testing
for CSS-rendered elements. However, in SVG, text elements should only hit
test based on their character cells, not the rectangular bounds of the
element, see section 16.6 of the SVG 1.1 specification:
http://www.w3.org/TR/SVG11/interact.html#PointerEventsProperty
So we now hit test each SVGTextFragment of each SVGInlineTextBox
that is a child of an SVGRootInlineBox to correctly find whether the
provided HitTestLocation is contained within a character cell.
Tests: svg/hittest/text-dominant-baseline-hanging.svg
svg/hittest/text-multiple-dx-values.svg
svg/hittest/text-with-multiple-tspans.svg
svg/hittest/text-with-text-node-and-content-elements.svg
svg/hittest/text-with-text-node-only.svg
svg/hittest/text-with-text-path.svg
- rendering/RootInlineBox.h:
Remove the final keyword since nodeAtPoint() may now be subclassed as
implemented in SVGRootInlineBox.
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::nodeAtPoint):
Iterate over the SVGTextFragments to look for a fragment containing the
provided HitTestLocation.
- rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::nodeAtPoint):
- rendering/svg/SVGRootInlineBox.h:
Override RootInlineBox::nodeAtPoint() to delegate hit testing to the
children inline boxes.
LayoutTests:
- svg/hittest/text-dominant-baseline-hanging-expected.svg: Added.
- svg/hittest/text-dominant-baseline-hanging.svg: Added.
- svg/hittest/text-multiple-dx-values-expected.svg: Added.
- svg/hittest/text-multiple-dx-values.svg: Added.
- svg/hittest/text-with-multiple-tspans-expected.svg: Added.
- svg/hittest/text-with-multiple-tspans.svg: Added.
- svg/hittest/text-with-text-node-and-content-elements-expected.svg: Added.
- svg/hittest/text-with-text-node-and-content-elements.svg: Added.
- svg/hittest/text-with-text-node-only-expected.svg: Added.
- svg/hittest/text-with-text-node-only.svg: Added.
- svg/hittest/text-with-text-path-expected.svg: Added.
- svg/hittest/text-with-text-path.svg: Added.
- 2:13 AM Changeset in webkit [192019] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] Use RunLoop::Timer for ready state timer in MediaPlayerPrivateGStreamer
https://bugs.webkit.org/show_bug.cgi?id=150836
Reviewed by Philippe Normand.
We don't really need a GThreadSafeMainLoopSource for this simple timer.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::readyTimerFired):
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
(WebCore::MediaPlayerPrivateGStreamer::loadingFailed):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- 1:34 AM Changeset in webkit [192018] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
- platform/win/TestExpectations: Marked 150867 as duplicate of 147933.
- 12:50 AM Changeset in webkit [192017] by
-
- 10 edits2 adds in trunk/Source/WebCore
Add support for the USE_TYPO_METRICS flag on iOS
https://bugs.webkit.org/show_bug.cgi?id=131839
Reviewed by Darin Adler.
Make the iOS Font service use the typo metrics for fonts with a MATH table when the OS/2 USE_TYPO_METRICS flag is set.
The code shared by iOS, OS X and AppleWin is moved into a separate OpenTypeCG module.
No new tests because this is already tested by fonts/use-typo-metrics-1.html
- PlatformAppleWin.cmake: Add OpenTypeCG files.
- PlatformMac.cmake: ditto.
- WebCore.vcxproj/WebCore.vcxproj: ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
- WebCore.xcodeproj/project.pbxproj: ditto.
- platform/graphics/cocoa/FontCocoa.mm:
(WebCore::Font::platformInit): Use functions from OpenTypeCG.
(WebCore::fontHasMathTable): Deleted.
- platform/graphics/ios/FontServicesIOS.mm:
(WebCore::FontServicesIOS::FontServicesIOS): Use the typo metrics for fonts with a MATH table when the OS/2 USE_TYPO_METRICS flag is set.
- platform/graphics/opentype/OpenTypeCG.h: Added.
- platform/graphics/opentype/OpenTypeCG.cpp: Added.
(WebCore::OpenType::fontHasMathTable): Move this code from FontCocoa.mm.
(WebCore::OpenType::readShortFromTable): Inline function to read a 16-bit big endian integer from the OS/2 table and to cast it into a short integer.
(WebCore::OpenType::tryGetTypoMetrics): Move this code from FontCocoa.mm.
- platform/graphics/opentype/OpenTypeTypes.h: Add missing Glyph.h header needed by TableWithCoverage::getCoverageIndex.
- platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::Font::platformInit): Use functions from OpenTypeCG.
- 12:10 AM Changeset in webkit [192016] by
-
- 6 edits in trunk
Regression(r191652): Colloquy doesn’t render any chat content
https://bugs.webkit.org/show_bug.cgi?id=150861
<rdar://problem/23381007>
Reviewed by Antti Koivisto.
Source/WebCore:
Do a partial revert of r191652 as this web-exposed behavior change
broke Colloquy app. This only reverts the code change, the tests
are left as is so that they don't rely of the frame ID setting the
Window name.
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseAttribute):
(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
LayoutTests:
Update / rebaseline a couple of tests as this patch restores the
pre-r191652 behavior.
- fast/dom/Window/window-special-properties-expected.txt:
- fast/frames/iframe-no-name-expected.txt:
- fast/frames/iframe-no-name.html:
Nov 3, 2015:
- 11:59 PM Changeset in webkit [192015] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Add SPI to warm an initial web process
https://bugs.webkit.org/show_bug.cgi?id=150886
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _warmInitialProcess]):
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- 11:35 PM WebKitIDL edited by
- (diff)
- 11:16 PM Changeset in webkit [192014] by
-
- 50 edits8 adds in trunk
Modern IDB: Fill out IDBIndex, create MemoryIndex in backing store.
https://bugs.webkit.org/show_bug.cgi?id=150868
Reviewed by Alex Christensen.
Source/WebCore:
Tests: storage/indexeddb/modern/create-index-failures.html
storage/indexeddb/modern/get-index-failures.html
storage/indexeddb/modern/idbindex-properties-basic.html
Note: The MemoryIndex in the backing store doesn't actually do anything yet.
That's coming next.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBIndex.h:
- Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::createIndex):
(WebCore::IDBClient::IDBConnectionToServer::didCreateIndex):
- Modules/indexeddb/client/IDBConnectionToServer.h:
- Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
- Modules/indexeddb/client/IDBCursorWithValueImpl.h:
- Modules/indexeddb/client/IDBDatabaseImpl.cpp:
(WebCore::IDBClient::IDBDatabase::didCreateIndexInfo):
- Modules/indexeddb/client/IDBDatabaseImpl.h:
- Modules/indexeddb/client/IDBIndexImpl.cpp:
(WebCore::IDBClient::IDBIndex::create):
(WebCore::IDBClient::IDBIndex::IDBIndex):
(WebCore::IDBClient::IDBIndex::objectStore):
(WebCore::IDBClient::IDBIndex::keyPathAny):
(WebCore::IDBClient::IDBIndex::openCursor):
(WebCore::IDBClient::IDBIndex::count):
(WebCore::IDBClient::IDBIndex::openKeyCursor):
(WebCore::IDBClient::IDBIndex::get):
(WebCore::IDBClient::IDBIndex::getKey):
- Modules/indexeddb/client/IDBIndexImpl.h:
- Modules/indexeddb/client/IDBObjectStoreImpl.cpp:
(WebCore::IDBClient::IDBObjectStore::createIndex):
(WebCore::IDBClient::IDBObjectStore::index):
- Modules/indexeddb/client/IDBObjectStoreImpl.h:
- Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::createObjectStore):
(WebCore::IDBClient::IDBTransaction::createIndex):
(WebCore::IDBClient::IDBTransaction::createIndexOnServer):
(WebCore::IDBClient::IDBTransaction::didCreateIndexOnServer):
- Modules/indexeddb/client/IDBTransactionImpl.h:
- Modules/indexeddb/legacy/LegacyIndex.h:
- Modules/indexeddb/server/IDBBackingStore.h:
- Modules/indexeddb/server/IDBConnectionToClient.cpp:
(WebCore::IDBServer::IDBConnectionToClient::didCreateIndex):
- Modules/indexeddb/server/IDBConnectionToClient.h:
- Modules/indexeddb/server/IDBConnectionToClientDelegate.h:
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::createIndex):
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:
(WebCore::IDBServer::MemoryBackingStoreTransaction::addNewIndex):
(WebCore::IDBServer::MemoryBackingStoreTransaction::addExistingIndex):
- Modules/indexeddb/server/MemoryBackingStoreTransaction.h:
- Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::createIndex):
- Modules/indexeddb/server/MemoryIDBBackingStore.h:
- Modules/indexeddb/server/MemoryIndex.cpp: Added.
(WebCore::IDBServer::MemoryIndex::create):
(WebCore::IDBServer::MemoryIndex::MemoryIndex):
(WebCore::IDBServer::MemoryIndex::~MemoryIndex):
- Modules/indexeddb/server/MemoryIndex.h: Added.
(WebCore::IDBServer::MemoryIndex::info):
- Modules/indexeddb/server/MemoryObjectStore.cpp:
(WebCore::IDBServer::MemoryObjectStore::createIndex):
(WebCore::IDBServer::MemoryObjectStore::registerIndex):
(WebCore::IDBServer::MemoryObjectStore::unregisterIndex):
- Modules/indexeddb/server/MemoryObjectStore.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::createIndex):
(WebCore::IDBServer::UniqueIDBDatabase::performCreateIndex):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformCreateIndex):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::didCreateIndex):
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::createIndex):
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:
- Modules/indexeddb/shared/IDBDatabaseInfo.cpp:
(WebCore::IDBDatabaseInfo::getInfoForExistingObjectStore):
(WebCore::IDBDatabaseInfo::infoForExistingObjectStore):
- Modules/indexeddb/shared/IDBDatabaseInfo.h:
- Modules/indexeddb/shared/IDBIndexInfo.cpp:
(WebCore::IDBIndexInfo::IDBIndexInfo):
(WebCore::IDBIndexInfo::isolatedCopy):
- Modules/indexeddb/shared/IDBIndexInfo.h:
(WebCore::IDBIndexInfo::identifier):
(WebCore::IDBIndexInfo::objectStoreIdentifier):
- Modules/indexeddb/shared/IDBObjectStoreInfo.cpp:
(WebCore::IDBObjectStoreInfo::createNewIndex):
(WebCore::IDBObjectStoreInfo::addExistingIndex):
(WebCore::IDBObjectStoreInfo::hasIndex):
(WebCore::IDBObjectStoreInfo::infoForExistingIndex):
(WebCore::IDBObjectStoreInfo::isolatedCopy):
- Modules/indexeddb/shared/IDBObjectStoreInfo.h:
- Modules/indexeddb/shared/IDBResultData.cpp:
(WebCore::IDBResultData::createIndexSuccess):
- Modules/indexeddb/shared/IDBResultData.h:
- Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::didCreateIndex):
(WebCore::InProcessIDBServer::createIndex):
- Modules/indexeddb/shared/InProcessIDBServer.h:
- bindings/js/JSIDBObjectStoreCustom.cpp:
(WebCore::JSIDBObjectStore::createIndex):
- platform/CrossThreadCopier.cpp:
(WebCore::IDBIndexInfo>::copy):
- platform/CrossThreadCopier.h:
LayoutTests:
- platform/mac-wk2/TestExpectations:
- storage/indexeddb/modern/create-index-failures-expected.txt: Added.
- storage/indexeddb/modern/create-index-failures.html: Added.
- storage/indexeddb/modern/get-index-failures-expected.txt: Added.
- storage/indexeddb/modern/get-index-failures.html: Added.
- storage/indexeddb/modern/idbindex-properties-basic-expected.txt: Added.
- storage/indexeddb/modern/idbindex-properties-basic.html: Added.
- 11:06 PM Changeset in webkit [192013] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] Adopt WKWebViewAdditions
https://bugs.webkit.org/show_bug.cgi?id=150885
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKWebView.mm:
- 10:35 PM Changeset in webkit [192012] by
-
- 1 copy in tags/Safari-602.1.10
New tag.
- 10:33 PM Changeset in webkit [192011] by
-
- 5 edits in trunk/Source
Versioning.
- 10:30 PM Changeset in webkit [192010] by
-
- 2 edits in trunk/Source/WebCore
[Cocoa] Only query for kMGQDeviceName on iOS
https://bugs.webkit.org/show_bug.cgi?id=150858
Reviewed by Brent Fulgham.
- platform/ios/Device.cpp:
(WebCore::deviceName): On non-iOS platorms, just return "iPhone" as the device name.
- 9:57 PM FeatureFlags edited by
- Add WEB_ANIMATIONS feature flag (diff)
- 9:45 PM Changeset in webkit [192009] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r191995.
https://bugs.webkit.org/show_bug.cgi?id=150880
Broke iOS tests (Requested by ap on #webkit).
Reverted changeset:
"run-webkit-test should look in --root directory for
LayoutTestRelay"
https://bugs.webkit.org/show_bug.cgi?id=150859
http://trac.webkit.org/changeset/191995
- 9:12 PM Changeset in webkit [192008] by
-
- 13 edits in trunk/Source/JavaScriptCore
[JSC] Add B3-to-Air lowering for BitXor
https://bugs.webkit.org/show_bug.cgi?id=150872
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-11-03
Reviewed by Filip Pizlo.
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::xor32):
Fix the indentation.
- b3/B3Const32Value.cpp:
(JSC::B3::Const32Value::bitXorConstant):
- b3/B3Const32Value.h:
- b3/B3Const64Value.cpp:
(JSC::B3::Const64Value::bitXorConstant):
- b3/B3Const64Value.h:
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::tryXor):
- b3/B3LoweringMatcher.patterns:
- b3/B3ReduceStrength.cpp:
- b3/B3Value.cpp:
(JSC::B3::Value::bitXorConstant):
- b3/B3Value.h:
- b3/air/AirOpcode.opcodes:
- b3/testb3.cpp:
(JSC::B3::testBitXorArgs):
(JSC::B3::testBitXorSameArg):
(JSC::B3::testBitXorImms):
(JSC::B3::testBitXorArgImm):
(JSC::B3::testBitXorImmArg):
(JSC::B3::testBitXorBitXorArgImmImm):
(JSC::B3::testBitXorImmBitXorArgImm):
(JSC::B3::testBitXorArgs32):
(JSC::B3::testBitXorSameArg32):
(JSC::B3::testBitXorImms32):
(JSC::B3::testBitXorArgImm32):
(JSC::B3::testBitXorImmArg32):
(JSC::B3::testBitXorBitXorArgImmImm32):
(JSC::B3::testBitXorImmBitXorArgImm32):
(JSC::B3::run):
- 6:47 PM Changeset in webkit [192007] by
-
- 4 edits2 adds in trunk
[WK1] Null dereference loading Blink layout test editing/input/text-input-controller-no-editable-no-crash.html
https://bugs.webkit.org/show_bug.cgi?id=149484
<rdar://problem/22811338>
Reviewed by Darin Adler.
Source/WebKit/mac:
firstRectForCharacterRange(): don't fall over in an editable-less frame.
- WebView/WebFrame.mm:
(-[WebFrame _convertToDOMRange:]):
LayoutTests:
This test is from Blink r194870:
https://codereview.chromium.org/1122593004
- editing/mac/input/text-input-controller-no-editable-no-crash-expected.txt: Added.
- editing/mac/input/text-input-controller-no-editable-no-crash.html: Added.
- platform/wk2/TestExpectations:
- 5:58 PM Changeset in webkit [192006] by
-
- 1 edit2 adds in trunk/Tools
Add graphics benchmark to performance bot
https://bugs.webkit.org/show_bug.cgi?id=150450
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-11-03
Reviewed by Chris Dumez.
- Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Added.
- Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Added.
Add a patch and a plan to set the defaults of the benchmark, run it,
collect the result and report it to the benchmark runner.
- 5:48 PM Changeset in webkit [192005] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION (r191612): Storage sidebar panel tree outline is broken
https://bugs.webkit.org/show_bug.cgi?id=150862
Reviewed by Joseph Pecoraro.
- UserInterface/Views/ApplicationCacheFrameContentView.js:
Inherit from ContentView.
- UserInterface/Views/StorageSidebarPanel.js:
(WebInspector.StorageSidebarPanel.prototype._addDatabase):
Fixed syntax error.
(WebInspector.StorageSidebarPanel.prototype._addIndexedDatabase):
(WebInspector.StorageSidebarPanel.prototype._addFrameManifest):
WebInspector.TreeOutline.append doesn't exist; changed to appendChild.
- 5:42 PM Changeset in webkit [192004] by
-
- 2 edits in trunk/Source/WebKit2
Duplicate validateUserInterfaceItem in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=150873
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView changeFont:]):
(-[WKWebView startSpeaking:]):
(-[WKWebView validateUserInterfaceItem:]):
(-[WKWebView goBack:]):
- 5:03 PM Changeset in webkit [192003] by
-
- 1 edit1 add in trunk/Source/JavaScriptCore
Add op_add tests to compare behavior of JIT generated code to the LLINT's.
https://bugs.webkit.org/show_bug.cgi?id=150864
Reviewed by Saam Barati.
- tests/stress/op_add.js: Added.
(o1.valueOf):
(generateScenarios):
(printScenarios):
(testCases.func):
(func):
(initializeTestCases):
(runTest):
- 5:01 PM Changeset in webkit [192002] by
-
- 4 edits in trunk/LayoutTests
[iOS] Skip the touch tests
https://bugs.webkit.org/show_bug.cgi?id=150863
Reviewed by Darin Adler.
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 5:01 PM Changeset in webkit [192001] by
-
- 9 edits in tags/Safari-602.1.9.1/Source
Merged r191999. rdar://problem/23376483
- 5:00 PM Changeset in webkit [192000] by
-
- 5 edits in trunk/Source/JavaScriptCore
Rename DFG's compileAdd to compileArithAdd.
https://bugs.webkit.org/show_bug.cgi?id=150866
Reviewed by Benjamin Poulain.
The function is only supposed to generate code to do arithmetic addition on
numeric types. Naming it compileArithAdd() is more accurate, and is consistent
with the name of the node it emits code for (i.e. ArithAdd) as well as other
compiler functions for analogous operations e.g. compileArithSub.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
(JSC::DFG::SpeculativeJIT::compileArithAdd):
(JSC::DFG::SpeculativeJIT::compileAdd): Deleted.
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 4:58 PM Changeset in webkit [191999] by
-
- 9 edits in trunk/Source
2015-11-03 Geoffrey Garen <ggaren@apple.com>
Provide a way to turn off const in WebKit2.
Reviewed by Sam Weinig.
- 4:50 PM Changeset in webkit [191998] by
-
- 12 edits in trunk/Source/WebKit2
Create a NetworkSession for each SessionID
https://bugs.webkit.org/show_bug.cgi?id=150857
Reviewed by Anders Carlsson.
This patch renames SessionTracker::session to storageSession and makes a parallel
structure for NetworkSessions. NetworkSession and NetworkStorageSession should eventually
become the same class in WebCore. Because not everybody uses NetworkSessions yet,
we keep them separate but created, destroyed, and managed together.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::storageSession):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::startNetworkLoad):
(WebKit::NetworkResourceLoader::abort):
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/NetworkSession.h:
(WebKit::NetworkSessionTaskClient::~NetworkSessionTaskClient):
(WebKit::NetworkDataTask::client):
(WebKit::NetworkDataTask::clearClient):
(WebKit::NetworkingDataTask::client): Deleted.
(WebKit::NetworkingDataTask::clearClient): Deleted.
(WebKit::NetworkSession::~NetworkSession): Deleted.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::configurationForType):
(WebKit::defaultNetworkSession):
(WebKit::NetworkSession::defaultSession):
(WebKit::NetworkSession::NetworkSession):
(WebKit::NetworkSession::~NetworkSession):
(WebKit::NetworkSession::createDataTaskWithRequest):
(WebKit::NetworkSession::dataTaskForIdentifier):
(WebKit::NetworkDataTask::NetworkDataTask):
(WebKit::NetworkDataTask::~NetworkDataTask):
(WebKit::NetworkDataTask::cancel):
(WebKit::NetworkDataTask::resume):
(WebKit::NetworkDataTask::taskIdentifier):
(WebKit::NetworkSession::create): Deleted.
(WebKit::NetworkSession::singleton): Deleted.
(WebKit::NetworkingDataTask::NetworkingDataTask): Deleted.
(WebKit::NetworkingDataTask::~NetworkingDataTask): Deleted.
(WebKit::NetworkingDataTask::suspend): Deleted.
(WebKit::NetworkingDataTask::resume): Deleted.
(WebKit::NetworkingDataTask::taskIdentifier): Deleted.
- NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::storageSession):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
- Shared/SessionTracker.cpp:
(WebKit::staticStorageSessionMap):
(WebKit::identifierBase):
(WebKit::SessionTracker::storageSessionMap):
(WebKit::SessionTracker::getIdentifierBase):
(WebKit::SessionTracker::storageSession):
(WebKit::staticSessionMap):
(WebKit::SessionTracker::networkSession):
(WebKit::SessionTracker::sessionID):
(WebKit::SessionTracker::setSession):
(WebKit::SessionTracker::destroySession):
(WebKit::SessionTracker::sessionMap): Deleted.
(WebKit::SessionTracker::session): Deleted.
- Shared/SessionTracker.h:
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::storageSession):
- WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::storageSession):
- 4:43 PM Changeset in webkit [191997] by
-
- 19 edits in trunk/Source
Web Inspector: Remove duplication among ScriptDebugServer subclasses
https://bugs.webkit.org/show_bug.cgi?id=150860
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-11-03
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
ScriptDebugServer expects a list of listeners to dispatch events to.
However each of its subclasses had their own implementation of the
list because of different handling when the first was added or when
the last was removed. Extract common code into ScriptDebugServer
which simplifies things.
Subclasses now only implement a virtual methods "attachDebugger"
and "detachDebugger" which is the unique work done when the first
listener is added or last is removed.
- inspector/JSGlobalObjectScriptDebugServer.cpp:
(Inspector::JSGlobalObjectScriptDebugServer::attachDebugger):
(Inspector::JSGlobalObjectScriptDebugServer::detachDebugger):
(Inspector::JSGlobalObjectScriptDebugServer::addListener): Deleted.
(Inspector::JSGlobalObjectScriptDebugServer::removeListener): Deleted.
- inspector/JSGlobalObjectScriptDebugServer.h:
- inspector/ScriptDebugServer.cpp:
(Inspector::ScriptDebugServer::dispatchBreakpointActionLog):
(Inspector::ScriptDebugServer::dispatchBreakpointActionSound):
(Inspector::ScriptDebugServer::dispatchBreakpointActionProbe):
(Inspector::ScriptDebugServer::sourceParsed):
(Inspector::ScriptDebugServer::dispatchFunctionToListeners):
(Inspector::ScriptDebugServer::addListener):
(Inspector::ScriptDebugServer::removeListener):
- inspector/ScriptDebugServer.h:
- inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::enable):
(Inspector::InspectorDebuggerAgent::disable):
- inspector/agents/InspectorDebuggerAgent.h:
- inspector/agents/JSGlobalObjectDebuggerAgent.cpp:
(Inspector::JSGlobalObjectDebuggerAgent::startListeningScriptDebugServer): Deleted.
(Inspector::JSGlobalObjectDebuggerAgent::stopListeningScriptDebugServer): Deleted.
- inspector/agents/JSGlobalObjectDebuggerAgent.h:
- inspector/ScriptDebugListener.h:
(Inspector::ScriptDebugListener::Script::Script):
Drive-by convert Script to a struct, it has public fields and is used as such.
Source/WebCore:
Refactoring covered by existing tests.
- bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::attachDebugger):
(WebCore::WorkerScriptDebugServer::detachDebugger):
(WebCore::WorkerScriptDebugServer::addListener): Deleted.
(WebCore::WorkerScriptDebugServer::removeListener): Deleted.
- bindings/js/WorkerScriptDebugServer.h:
- inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::startListeningScriptDebugServer): Deleted.
(WebCore::PageDebuggerAgent::stopListeningScriptDebugServer): Deleted.
- inspector/PageDebuggerAgent.h:
- inspector/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::attachDebugger):
(WebCore::PageScriptDebugServer::detachDebugger):
(WebCore::PageScriptDebugServer::addListener): Deleted.
(WebCore::PageScriptDebugServer::removeListener): Deleted.
- inspector/PageScriptDebugServer.h:
- inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer): Deleted.
(WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer): Deleted.
- inspector/WorkerDebuggerAgent.h:
- 4:41 PM Changeset in webkit [191996] by
-
- 5 edits in trunk/Source/JavaScriptCore
B3::LowerToAir should recognize Neg (i.e. Sub($0, value))
https://bugs.webkit.org/show_bug.cgi?id=150759
Reviewed by Benjamin Poulain.
Adds various forms of Sub(0, value) and compiles them as Neg. Also fixes a bug in
StoreSubLoad. This bug was correctness-benign, so I couldn't add a test for it.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::immOrTmp):
(JSC::B3::Air::LowerToAir::appendUnOp):
(JSC::B3::Air::LowerToAir::appendBinOp):
(JSC::B3::Air::LowerToAir::tryAppendStoreUnOp):
(JSC::B3::Air::LowerToAir::tryAppendStoreBinOp):
(JSC::B3::Air::LowerToAir::trySub):
(JSC::B3::Air::LowerToAir::tryStoreSubLoad):
- b3/B3LoweringMatcher.patterns:
- b3/air/AirOpcode.opcodes:
- b3/testb3.cpp:
(JSC::B3::testAdd1Ptr):
(JSC::B3::testNeg32):
(JSC::B3::testNegPtr):
(JSC::B3::testStoreAddLoad):
(JSC::B3::testStoreAddAndLoad):
(JSC::B3::testStoreNegLoad32):
(JSC::B3::testStoreNegLoadPtr):
(JSC::B3::testAdd1Uncommuted):
(JSC::B3::run):
- 4:39 PM Changeset in webkit [191995] by
-
- 2 edits in trunk/Tools
run-webkit-test should look in --root directory for LayoutTestRelay
https://bugs.webkit.org/show_bug.cgi?id=150859
Reviewed by Daniel Bates.
For iOS run-webkit-tests, use LayoutTestRelay specified by --root; otherwise find
LayoutTestRelay in the Mac build directory when --root is unspecified.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.relay_path):
- 4:28 PM Changeset in webkit [191994] by
-
- 18 edits2 adds in trunk/Source/JavaScriptCore
B3::Values that have effects should allow specification of custom HeapRanges
https://bugs.webkit.org/show_bug.cgi?id=150535
Reviewed by Benjamin Poulain.
Add a Effects field to calls and patchpoints. Add a HeapRange to MemoryValues.
In the process, I created a class for the CCall opcode, so that it has somewhere to put
the Effects field.
While doing this, I realized that we didn't have a good way of ensuring that an opcode
that requires a specific subclass was actually created with that subclass. So, I added
assertions for this.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3ArgumentRegValue.h:
- b3/B3CCallValue.cpp: Added.
- b3/B3CCallValue.h: Added.
- b3/B3CheckValue.h:
- b3/B3Const32Value.h:
- b3/B3Const64Value.h:
- b3/B3ConstDoubleValue.h:
(JSC::B3::ConstDoubleValue::ConstDoubleValue):
- b3/B3ControlValue.h:
- b3/B3Effects.h:
(JSC::B3::Effects::forCall):
(JSC::B3::Effects::mustExecute):
- b3/B3MemoryValue.h:
- b3/B3PatchpointValue.h:
- b3/B3StackSlotValue.h:
- b3/B3UpsilonValue.h:
- b3/B3Value.cpp:
(JSC::B3::Value::effects):
(JSC::B3::Value::dumpMeta):
(JSC::B3::Value::checkOpcode):
(JSC::B3::Value::typeFor):
- b3/B3Value.h:
- 4:13 PM Changeset in webkit [191993] by
-
- 37 edits4 adds2 deletes in trunk/Source/JavaScriptCore
B3::Stackmap should be a superclass of B3::PatchpointValue and B3::CheckValue rather than being one of their members
https://bugs.webkit.org/show_bug.cgi?id=150831
Rubber stamped by Benjamin Poulain.
Previously, Stackmap was a value that PatchpointValue and CheckValue would hold as a field.
We'd have convenient ways of getting this field, like via Value::stackmap(). But this was a
bit ridiculous, since Stackmap is logically just a common supertype for Patchpointvalue and
CheckValue. This patch makes this reality by replacing Stackmap with StackmapValue. This makes
the code a lot more reasonable.
I also needed to make dumping a bit more customizable, so I changed dumpMeta() to take a
CommaPrinter&. This gives subclasses better control over whether or not to emit a comma. Also
it's now possible for subclasses of Value to customize how children are printed. StackmapValue
uses this to print the children and their reps together like:
Int32 @2 = Patchpoint(@0:SomeRegister, @1:SomeRegister, generator = 0x1107ec010, clobbered = [], usedRegisters = [], ExitsSideways|ControlDependent|Writes:Top|Reads:Top)
This has no behavior change, it's just a big refactoring. You can see how much simpler this
makes things by looking at the testSimplePatchpoint() test.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3ArgumentRegValue.cpp:
(JSC::B3::ArgumentRegValue::~ArgumentRegValue):
(JSC::B3::ArgumentRegValue::dumpMeta):
- b3/B3ArgumentRegValue.h:
- b3/B3CheckSpecial.cpp:
(JSC::B3::CheckSpecial::generate):
- b3/B3CheckValue.cpp:
(JSC::B3::CheckValue::~CheckValue):
(JSC::B3::CheckValue::CheckValue):
(JSC::B3::CheckValue::dumpMeta): Deleted.
- b3/B3CheckValue.h:
(JSC::B3::CheckValue::accepts):
- b3/B3Const32Value.cpp:
(JSC::B3::Const32Value::notEqualConstant):
(JSC::B3::Const32Value::dumpMeta):
- b3/B3Const32Value.h:
- b3/B3Const64Value.cpp:
(JSC::B3::Const64Value::notEqualConstant):
(JSC::B3::Const64Value::dumpMeta):
- b3/B3Const64Value.h:
- b3/B3ConstDoubleValue.cpp:
(JSC::B3::ConstDoubleValue::notEqualConstant):
(JSC::B3::ConstDoubleValue::dumpMeta):
- b3/B3ConstDoubleValue.h:
- b3/B3ConstrainedValue.cpp: Added.
(JSC::B3::ConstrainedValue::dump):
- b3/B3ConstrainedValue.h: Added.
(JSC::B3::ConstrainedValue::ConstrainedValue):
(JSC::B3::ConstrainedValue::operator bool):
(JSC::B3::ConstrainedValue::value):
(JSC::B3::ConstrainedValue::rep):
- b3/B3ControlValue.cpp:
(JSC::B3::ControlValue::convertToJump):
(JSC::B3::ControlValue::dumpMeta):
- b3/B3ControlValue.h:
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::tryPatchpoint):
- b3/B3MemoryValue.cpp:
(JSC::B3::MemoryValue::accessByteSize):
(JSC::B3::MemoryValue::dumpMeta):
- b3/B3MemoryValue.h:
- b3/B3PatchpointSpecial.cpp:
(JSC::B3::PatchpointSpecial::generate):
- b3/B3PatchpointValue.cpp:
(JSC::B3::PatchpointValue::~PatchpointValue):
(JSC::B3::PatchpointValue::PatchpointValue):
(JSC::B3::PatchpointValue::dumpMeta): Deleted.
- b3/B3PatchpointValue.h:
(JSC::B3::PatchpointValue::accepts):
- b3/B3StackSlotValue.cpp:
(JSC::B3::StackSlotValue::~StackSlotValue):
(JSC::B3::StackSlotValue::dumpMeta):
- b3/B3StackSlotValue.h:
- b3/B3Stackmap.cpp: Removed.
- b3/B3Stackmap.h: Removed.
- b3/B3StackmapSpecial.cpp:
(JSC::B3::StackmapSpecial::reportUsedRegisters):
(JSC::B3::StackmapSpecial::extraClobberedRegs):
(JSC::B3::StackmapSpecial::forEachArgImpl):
(JSC::B3::StackmapSpecial::isValidImpl):
(JSC::B3::StackmapSpecial::admitsStackImpl):
- b3/B3StackmapSpecial.h:
- b3/B3StackmapValue.cpp: Added.
(JSC::B3::StackmapValue::~StackmapValue):
(JSC::B3::StackmapValue::append):
(JSC::B3::StackmapValue::setConstrainedChild):
(JSC::B3::StackmapValue::setConstraint):
(JSC::B3::StackmapValue::dumpChildren):
(JSC::B3::StackmapValue::dumpMeta):
(JSC::B3::StackmapValue::StackmapValue):
- b3/B3StackmapValue.h: Added.
- b3/B3SwitchValue.cpp:
(JSC::B3::SwitchValue::appendCase):
(JSC::B3::SwitchValue::dumpMeta):
(JSC::B3::SwitchValue::SwitchValue):
- b3/B3SwitchValue.h:
- b3/B3UpsilonValue.cpp:
(JSC::B3::UpsilonValue::~UpsilonValue):
(JSC::B3::UpsilonValue::dumpMeta):
- b3/B3UpsilonValue.h:
- b3/B3Validate.cpp:
- b3/B3Value.cpp:
(JSC::B3::Value::dump):
(JSC::B3::Value::dumpChildren):
(JSC::B3::Value::deepDump):
(JSC::B3::Value::performSubstitution):
(JSC::B3::Value::dumpMeta):
- b3/B3Value.h:
- b3/B3ValueInlines.h:
(JSC::B3::Value::asNumber):
(JSC::B3::Value::stackmap): Deleted.
- b3/B3ValueRep.h:
(JSC::B3::ValueRep::kind):
(JSC::B3::ValueRep::operator==):
(JSC::B3::ValueRep::operator!=):
(JSC::B3::ValueRep::operator bool):
(JSC::B3::ValueRep::isAny):
- b3/air/AirInstInlines.h:
- b3/testb3.cpp:
(JSC::B3::testSimplePatchpoint):
- 4:11 PM Changeset in webkit [191992] by
-
- 2 edits in trunk/LayoutTests
Marking streams/reference-implementation/writable-stream-abort.html as flaky on win
https://bugs.webkit.org/show_bug.cgi?id=150867
Unreviewed test gardening.
- platform/win/TestExpectations:
- 4:05 PM Changeset in webkit [191991] by
-
- 3 edits2 adds in trunk
Null dereference loading Blink layout test scrollbars/custom-scrollbar-appearance-property.html
https://bugs.webkit.org/show_bug.cgi?id=149312
<rdar://problem/22748910>
Reviewed by Darin Adler.
Source/WebCore:
This is a merge from Blink r167503:
https://codereview.chromium.org/173433002
Test: scrollbars/custom-scrollbar-appearance-property.html
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecorationPart):
LayoutTests:
- scrollbars/custom-scrollbar-appearance-property-expected.txt: Added.
- scrollbars/custom-scrollbar-appearance-property.html: Added.
- 3:52 PM Changeset in webkit [191990] by
-
- 2 edits in trunk/LayoutTests
Correcting win test expectation for flaky test fast/text/multiple-feature-properties.html
https://bugs.webkit.org/show_bug.cgi?id=150808
Unreviewed test gardening.
- platform/win/TestExpectations:
- 3:47 PM Changeset in webkit [191989] by
-
- 2 edits in trunk/LayoutTests
Skipping test added with r191979 on win
https://bugs.webkit.org/show_bug.cgi?id=150830
Unreviewed test gardening.
- platform/win/TestExpectations:
- 3:39 PM Changeset in webkit [191988] by
-
- 2 edits in trunk/Tools
build.webkit.org/dashboard should use ISO dates in Trac URLs
https://bugs.webkit.org/show_bug.cgi?id=150855
Reviewed by Darin Adler.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
(Trac.prototype._xmlTimelineURL):
- 3:39 PM Changeset in webkit [191987] by
-
- 2 edits in trunk/Source/WebKit2
[CoordinatedGraphics] invisible webview should not paint the content
https://bugs.webkit.org/show_bug.cgi?id=150662
Reviewed by Darin Adler.
Suspend or resume the painting instead of just initializing m_isPaintingSuspended
for invisible webview not to paint the content until visibility is changed.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:
(WebKit::CoordinatedDrawingArea::CoordinatedDrawingArea):
- 3:37 PM Changeset in webkit [191986] by
-
- 2 edits in trunk/LayoutTests
Skipping tests added with r191968 on win.
https://bugs.webkit.org/show_bug.cgi?id=149771
Unreviewed test gardening.
- platform/win/TestExpectations:
- 3:30 PM Changeset in webkit [191985] by
-
- 3 edits in trunk/Source/WebCore
ResourceUsageOverlay should show GC-owned malloc memory.
<https://webkit.org/b/150846>
Reviewed by Anders Carlsson.
Add a memory category for GC-owned malloc memory. This carves a significant chunk off of
the gigantic "bmalloc" mystery slice.
- page/ResourceUsageOverlay.h:
- page/cocoa/ResourceUsageOverlayCocoa.mm:
(WebCore::drawMemoryPie):
(WebCore::ResourceUsageOverlay::draw):
(WebCore::runSamplerThread):
- 3:27 PM Changeset in webkit [191984] by
-
- 5 edits in tags/Safari-602.1.9.1/Source
Merged r191982. rdar://problem/23376483
- 3:24 PM Changeset in webkit [191983] by
-
- 14 edits in trunk/Source/JavaScriptCore
[JSC] Add Air lowering for BitOr and impove BitAnd
https://bugs.webkit.org/show_bug.cgi?id=150827
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-11-03
Reviewed by Filip Pizlo.
In this patch:
-B3 to Air lowering for BirOr.
-Codegen for BitOr.
-Strength reduction for BitOr and BitAnd.
-Tests for BitAnd and BitOr.
-Bug fix: Move64 with a negative value was destroying the top bits.
- b3/B3Const32Value.cpp:
(JSC::B3::Const32Value::bitAndConstant):
(JSC::B3::Const32Value::bitOrConstant):
- b3/B3Const32Value.h:
- b3/B3Const64Value.cpp:
(JSC::B3::Const64Value::bitAndConstant):
(JSC::B3::Const64Value::bitOrConstant):
- b3/B3Const64Value.h:
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::immForMove):
(JSC::B3::Air::LowerToAir::immOrTmpForMove):
(JSC::B3::Air::LowerToAir::tryOr):
(JSC::B3::Air::LowerToAir::tryConst64):
(JSC::B3::Air::LowerToAir::tryUpsilon):
(JSC::B3::Air::LowerToAir::tryIdentity):
(JSC::B3::Air::LowerToAir::tryReturn):
(JSC::B3::Air::LowerToAir::immOrTmp): Deleted.
- b3/B3LoweringMatcher.patterns:
- b3/B3ReduceStrength.cpp:
- b3/B3Value.cpp:
(JSC::B3::Value::bitAndConstant):
(JSC::B3::Value::bitOrConstant):
- b3/B3Value.h:
- b3/air/AirOpcode.opcodes:
- b3/testb3.cpp:
(JSC::B3::testReturnConst64):
(JSC::B3::testBitAndArgs):
(JSC::B3::testBitAndSameArg):
(JSC::B3::testBitAndImms):
(JSC::B3::testBitAndArgImm):
(JSC::B3::testBitAndImmArg):
(JSC::B3::testBitAndBitAndArgImmImm):
(JSC::B3::testBitAndImmBitAndArgImm):
(JSC::B3::testBitAndArgs32):
(JSC::B3::testBitAndSameArg32):
(JSC::B3::testBitAndImms32):
(JSC::B3::testBitAndArgImm32):
(JSC::B3::testBitAndImmArg32):
(JSC::B3::testBitAndBitAndArgImmImm32):
(JSC::B3::testBitAndImmBitAndArgImm32):
(JSC::B3::testBitOrArgs):
(JSC::B3::testBitOrSameArg):
(JSC::B3::testBitOrImms):
(JSC::B3::testBitOrArgImm):
(JSC::B3::testBitOrImmArg):
(JSC::B3::testBitOrBitOrArgImmImm):
(JSC::B3::testBitOrImmBitOrArgImm):
(JSC::B3::testBitOrArgs32):
(JSC::B3::testBitOrSameArg32):
(JSC::B3::testBitOrImms32):
(JSC::B3::testBitOrArgImm32):
(JSC::B3::testBitOrImmArg32):
(JSC::B3::testBitOrBitOrArgImmImm32):
(JSC::B3::testBitOrImmBitOrArgImm32):
(JSC::B3::run):
- 3:23 PM Changeset in webkit [191982] by
-
- 5 edits in trunk/Source
Rewrite "const" as "var" for iTunes/iBooks on the Mac
https://bugs.webkit.org/show_bug.cgi?id=150852
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
VM now has a setting indicating if we should treat
"const" variables as "var" to more closely match
JSC's previous implementation of "const" before ES6.
- parser/Parser.h:
(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):
- runtime/VM.h:
(JSC::VM::setShouldRewriteConstAsVar):
(JSC::VM::shouldRewriteConstAsVar):
Source/WebCore:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonVM):
- 2:51 PM Changeset in webkit [191981] by
-
- 10 edits2 adds in trunk
Implement support for the autocomplete attribute
https://bugs.webkit.org/show_bug.cgi?id=150731
rdar://problem/21078968
LayoutTests/imported/w3c:
Reviewed by Brent Fulgham.
- web-platform-tests/html/dom/interfaces-expected.txt: Rebased.
- web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete-expected.txt:
Rebased.
Source/WebCore:
The autocomplete attribute is defined by
https://html.spec.whatwg.org/multipage/forms.html#autofill.
Reviewed by Brent Fulgham.
Test: fast/forms/autocomplete-tokens.html
- html/HTMLFormControlElement.cpp:
(WebCore::isContactToken):
Return true if this is a contact token.
(WebCore::categoryForAutofillFieldToken):
Adds all of the autofill field tokens to a map, and returns the
category for a given token.
(WebCore::maxTokensForAutofillFieldCategory):
Return the maximum number of tokens an autofill category supports.
(WebCore::HTMLFormControlElement::parseAutocompleteAttribute):
Implement the processing model defined in
https://html.spec.whatwg.org/multipage/forms.html#processing-model-3
with respect to the IDL-exposed autofill value.
(WebCore::HTMLFormControlElement::setAutocomplete):
Set the autocomplete attribute to the given string.
- html/HTMLFormControlElement.h:
Declare setAutocomplete() and autocomplete().
- html/HTMLInputElement.idl:
Remove the Reflect attribute. We now have custom processing for getting
this attribute.
- html/HTMLSelectElement.idl:
Declare the autocomplete attribute.
- html/HTMLTextAreaElement.idl:
Ditto.
LayoutTests:
Reviewed by Brent Fulgham.
- fast/forms/autocomplete-tokens-expected.txt: Added.
- fast/forms/autocomplete-tokens.html: Added.
- 2:24 PM Changeset in webkit [191980] by
-
- 5 edits1 copy7 adds in trunk/Source/WebCore
Modern IDB: Land empty IDBCursor/Index IDL implementations.
https://bugs.webkit.org/show_bug.cgi?id=150839
Reviewed by Alex Christensen.
No new tests (No change in behavior).
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBIndex.h:
- Modules/indexeddb/client/IDBCursorImpl.cpp: Added.
(WebCore::IDBClient::IDBCursor::~IDBCursor):
(WebCore::IDBClient::IDBCursor::direction):
(WebCore::IDBClient::IDBCursor::key):
(WebCore::IDBClient::IDBCursor::primaryKey):
(WebCore::IDBClient::IDBCursor::value):
(WebCore::IDBClient::IDBCursor::source):
(WebCore::IDBClient::IDBCursor::update):
(WebCore::IDBClient::IDBCursor::advance):
(WebCore::IDBClient::IDBCursor::continueFunction):
(WebCore::IDBClient::IDBCursor::deleteFunction):
- Modules/indexeddb/client/IDBCursorImpl.h: Added.
- Modules/indexeddb/client/IDBCursorWithValueImpl.cpp: Added.
- Modules/indexeddb/client/IDBCursorWithValueImpl.h: Added.
- Modules/indexeddb/client/IDBIndexImpl.cpp: Added.
(WebCore::IDBClient::IDBIndex::~IDBIndex):
(WebCore::IDBClient::IDBIndex::name):
(WebCore::IDBClient::IDBIndex::objectStore):
(WebCore::IDBClient::IDBIndex::keyPathAny):
(WebCore::IDBClient::IDBIndex::keyPath):
(WebCore::IDBClient::IDBIndex::unique):
(WebCore::IDBClient::IDBIndex::multiEntry):
(WebCore::IDBClient::IDBIndex::openCursor):
(WebCore::IDBClient::IDBIndex::count):
(WebCore::IDBClient::IDBIndex::openKeyCursor):
(WebCore::IDBClient::IDBIndex::get):
(WebCore::IDBClient::IDBIndex::getKey):
- Modules/indexeddb/client/IDBIndexImpl.h: Copied from Source/WebCore/Modules/indexeddb/IDBIndex.h.
- Modules/indexeddb/legacy/LegacyIndex.h:
(WebCore::LegacyIndex::id):
- Modules/indexeddb/shared/IDBIndexInfo.cpp: Added.
- Modules/indexeddb/shared/IDBIndexInfo.h: Added.
(WebCore::IDBIndexInfo::name):
(WebCore::IDBIndexInfo::keyPath):
(WebCore::IDBIndexInfo::unique):
(WebCore::IDBIndexInfo::multiEntry):
- 2:18 PM Changeset in webkit [191979] by
-
- 2 edits in trunk/Source/WebCore
Addressing post-review comments on r191934.
Unreviewed.
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::supportsFormat):
- 2:13 PM Changeset in webkit [191978] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix some inefficiencies in the baseline usage of JITAddGenerator.
https://bugs.webkit.org/show_bug.cgi?id=150850
Reviewed by Michael Saboff.
- emit_op_add() was loading the operands twice. Removed the redundant load.
- The snippet may decide that it wants to go the slow path route all the time. In that case, emit_op_add will end up emitting a branch to an out of line slow path followed by some dead code to store the result of the fast path on to the stack. We now check if the snippet determined that there's no fast path, and just emit the slow path inline, and skip the dead store of the fast path result.
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_add):
- 2:03 PM Changeset in webkit [191977] by
-
- 3 edits in trunk/Source/JavaScriptCore
B3::LowerToAir should do copy propagation
https://bugs.webkit.org/show_bug.cgi?id=150775
Reviewed by Geoffrey Garen.
What we are trying to do is remove the unnecessary Move's and Move32's from Trunc and ZExt32.
You could think of this as an Air optimization, and indeed, Air is powerful enough that we
could write a phase that does copy propagation through Move's and Move32's. For Move32's it
would only copy-propagate if it proved that the value was already zero-extended. We could
know this by just adding a Def32 role to Air.
But this patch takes a different approach: we ensure that we don't generate such redundant
Move's and Move32's to begin with. The reason is that it's much cheaper to do analysis over
B3 than over Air. So, whenever possible, and optimization should be implemented in B3. In
this case the optimization can't quite be implemented in B3 because you cannot remove a Trunc
or ZExt32 without violating the B3 type system. So, the best place to do this optimization is
during lowering: we can use B3 for our analysis and we can use Air to express the
transformation.
Copy propagating during B3->Air lowering is natural because we are creating "SSA-like" Tmps
from the B3 Values. They are SSA-like in the sense that except the tmp for a Phi, we know
that the Tmp will be assigned once and that the assignment will dominate all uses. So, if we
see an operation like Trunc that is semantically just a Move, we can skip the Move and just
claim that the Trunc has the same Tmp as its child. We do something similar for ZExt32,
except with that one we have to analyze IR to ensure that the value will actually be zero
extended. Note that this kind of reasoning about how Tmps work in Air is only possible in the
B3->Air lowering, since at that point we know for sure which Tmps behave this way. If we
wanted to do anything like this as a later Air phase, we'd have to do more analysis to first
prove that Tmps behave in this way.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::run):
(JSC::B3::Air::LowerToAir::highBitsAreZero):
(JSC::B3::Air::LowerToAir::shouldCopyPropagate):
(JSC::B3::Air::LowerToAir::tmp):
(JSC::B3::Air::LowerToAir::tryStore):
(JSC::B3::Air::LowerToAir::tryTrunc):
(JSC::B3::Air::LowerToAir::tryZExt32):
(JSC::B3::Air::LowerToAir::tryIdentity):
(JSC::B3::Air::LowerToAir::tryTruncArgumentReg): Deleted.
- b3/B3LoweringMatcher.patterns:
- 1:56 PM Changeset in webkit [191976] by
-
- 22 edits1 add in trunk/Source/WebInspectorUI
Web Inspector: Create View base class, refactor some core view classes
https://bugs.webkit.org/show_bug.cgi?id=149186
Reviewed by Brian Burg and Timothy Hatcher.
This patch introduces a new View base class, which encapsulates DOM element creation,
layout scheduling, and subview management. The View class constructor accepts an optional
element parameter, allowing an existing DOM element to be associated with the View object,
rather than dynamically creating a new element. View also adds a__viewproperty to its
associated DOM element to facilitate debugging the Inspector UI.
For the view classes refactored in this patch, the changes are largely mechanical. Dynamically
created DOM elements and redundant element getters have been removed. needsLayout has replaced
updateLayoutIfNeeded where appropriate. updateLayout has been removed entirely for views that
performed no layout other than to cascade layouts to their children.
- UserInterface/Base/Main.js:
Moved TabBar layout updates out of TabBrowser and into Main.js.
- UserInterface/Main.html:
- UserInterface/Views/ConsolePrompt.js:
(WebInspector.ConsolePrompt):
(WebInspector.ConsolePrompt.prototype.layout):
(WebInspector.ConsolePrompt.prototype.get element): Deleted.
(WebInspector.ConsolePrompt.prototype.updateLayout): Deleted.
- UserInterface/Views/ContentBrowser.js:
(WebInspector.ContentBrowser):
(WebInspector.ContentBrowser.prototype.get element): Deleted.
(WebInspector.ContentBrowser.prototype.updateLayout): Deleted.
- UserInterface/Views/ContentBrowserTabContentView.js:
(WebInspector.ContentBrowserTabContentView):
(WebInspector.ContentBrowserTabContentView.prototype.updateLayout): Deleted.
- UserInterface/Views/ContentView.js:
(WebInspector.ContentView):
(WebInspector.ContentView.prototype.get element): Deleted.
(WebInspector.ContentView.prototype.updateLayout): Deleted.
- UserInterface/Views/ContentViewContainer.js:
(WebInspector.ContentViewContainer):
(WebInspector.ContentViewContainer.prototype._showEntry):
(WebInspector.ContentViewContainer.prototype._hideEntry):
(WebInspector.ContentViewContainer.prototype.get element): Deleted.
(WebInspector.ContentViewContainer.prototype.updateLayout): Deleted.
(WebInspector.ContentViewContainer.prototype._addContentViewElement): Deleted.
(WebInspector.ContentViewContainer.prototype._removeContentViewElement): Deleted.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype.autoSizeColumns):
(WebInspector.DataGrid.prototype.layout):
(WebInspector.DataGrid.prototype.applyColumnWidthsMap):
(WebInspector.DataGrid): Deleted.
(WebInspector.DataGrid.prototype.updateLayout): Deleted.
(WebInspector.DataGrid.prototype.resizerDragging): Deleted.
(WebInspector.DataGrid.prototype.resizerDragEnded): Deleted.
- UserInterface/Views/HierarchicalPathNavigationItem.js:
(WebInspector.HierarchicalPathNavigationItem.prototype.set components):
- UserInterface/Views/LayoutTimelineView.js:
(WebInspector.LayoutTimelineView):
(WebInspector.LayoutTimelineView.prototype.layout):
(WebInspector.LayoutTimelineView.prototype.updateLayout): Deleted.
- UserInterface/Views/NavigationBar.js:
(WebInspector.NavigationBar):
(WebInspector.NavigationBar.prototype.insertNavigationItem):
(WebInspector.NavigationBar.prototype.removeNavigationItem):
(WebInspector.NavigationBar.prototype.get minimumWidth):
(WebInspector.NavigationBar.prototype.layout):
(WebInspector.NavigationBar.prototype._mouseDown):
(WebInspector.NavigationBar.prototype._mouseMoved):
(WebInspector.NavigationBar.prototype._mouseUp):
(WebInspector.NavigationBar.prototype._calculateMinimumWidth):
(WebInspector.NavigationBar.prototype.updateLayoutSoon.update): Deleted.
(WebInspector.NavigationBar.prototype.updateLayoutSoon): Deleted.
(WebInspector.NavigationBar.prototype.updateLayout): Deleted.
(WebInspector.NavigationBar.prototype.get element): Deleted.
- UserInterface/Views/NavigationItem.js:
(WebInspector.NavigationItem.prototype.set hidden):
- UserInterface/Views/NetworkTimelineView.js:
(WebInspector.NetworkTimelineView):
(WebInspector.NetworkTimelineView.prototype.layout):
(WebInspector.NetworkTimelineView.prototype.updateLayout): Deleted.
- UserInterface/Views/OverviewTimelineView.js:
(WebInspector.OverviewTimelineView):
(WebInspector.OverviewTimelineView.prototype.layout):
(WebInspector.OverviewTimelineView.prototype.updateLayout): Deleted.
- UserInterface/Views/QuickConsole.js:
(WebInspector.QuickConsole):
(WebInspector.QuickConsole.prototype.layout):
(WebInspector.QuickConsole.prototype.get element): Deleted.
(WebInspector.QuickConsole.prototype.updateLayout): Deleted.
- UserInterface/Views/RenderingFrameTimelineView.js:
(WebInspector.RenderingFrameTimelineView):
(WebInspector.RenderingFrameTimelineView.prototype.layout):
(WebInspector.RenderingFrameTimelineView.prototype.updateLayout): Deleted.
- UserInterface/Views/ScriptTimelineView.js:
(WebInspector.ScriptTimelineView):
(WebInspector.ScriptTimelineView.prototype.layout):
(WebInspector.ScriptTimelineView.prototype.updateLayout): Deleted.
- UserInterface/Views/TabBar.js:
(WebInspector.TabBar):
(WebInspector.TabBar.prototype.insertTabBarItem.animateTabs):
(WebInspector.TabBar.prototype.insertTabBarItem.removeStyles):
(WebInspector.TabBar.prototype.insertTabBarItem):
(WebInspector.TabBar.prototype.removeTabBarItem.animateTabs):
(WebInspector.TabBar.prototype.removeTabBarItem.removeStyles):
(WebInspector.TabBar.prototype.removeTabBarItem):
(WebInspector.TabBar.prototype.hasNormalTab):
(WebInspector.TabBar.prototype.layout):
(WebInspector.TabBar.prototype._recordTabBarItemSizesAndPositions):
(WebInspector.TabBar.prototype._finishExpandingTabsAfterClose.):
(WebInspector.TabBar.prototype._finishExpandingTabsAfterClose):
(WebInspector.TabBar.prototype._handleClick):
(WebInspector.TabBar.prototype._handleMouseMoved):
(WebInspector.TabBar.prototype._handleMouseUp):
(WebInspector.TabBar.prototype._handleMouseLeave):
(WebInspector.TabBar.prototype._handleNewTabMouseEnter):
(WebInspector.TabBar.prototype.updateLayoutSoon.update): Deleted.
(WebInspector.TabBar.prototype.updateLayoutSoon): Deleted.
(WebInspector.TabBar.prototype.updateLayout): Deleted.
(WebInspector.TabBar.prototype.get element): Deleted.
- UserInterface/Views/TabBrowser.js:
(WebInspector.TabBrowser):
(WebInspector.TabBrowser.prototype.get element): Deleted.
(WebInspector.TabBrowser.prototype.updateLayout): Deleted.
- UserInterface/Views/TimelineView.js:
(WebInspector.TimelineView.prototype.filterUpdated):
(WebInspector.TimelineView.prototype.needsLayout):
(WebInspector.TimelineView.prototype.updateLayout): Deleted.
(WebInspector.TimelineView.prototype.updateLayoutIfNeeded): Deleted.
(WebInspector.TimelineView): Deleted.
- UserInterface/Views/Toolbar.js:
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype.set displayMode):
(WebInspector.Toolbar.prototype.set sizeMode):
(WebInspector.Toolbar.prototype.addToolbarItem):
(WebInspector.Toolbar.prototype.layout):
(WebInspector.Toolbar.prototype.customUpdateLayout): Deleted.
Renamed to layout. This eliminated a layering violation in NavigationBar,
where the function previously known as updateLayout checked for a
acustomUpdateLayoutfunction property, and would call it instead of its
own layout logic if found.
- UserInterface/Views/View.js: Added.
(WebInspector.View):
(WebInspector.View.prototype.get element):
(WebInspector.View.prototype.get subviews):
(WebInspector.View.prototype.addSubview):
Appends a view to the end of the subview list.
(WebInspector.View.prototype.insertSubviewBefore):
Inserts a view into subview list before another subview.
(WebInspector.View.prototype.removeSubview):
(WebInspector.View.prototype.replaceSubview):
(WebInspector.View.prototype.updateLayout):
No longer overridden by subclasses.
(WebInspector.View.prototype.updateLayoutIfNeeded):
Forces a layout if one has been scheduled, otherwise does nothing.
(WebInspector.View.prototype.needsLayout):
Schedules a layout for the view.
(WebInspector.View.prototype.layout):
Overridden by views that require special layout logic. Layouts
cascade to child views automatically.
(WebInspector.View.prototype._layoutSubtree):
Main layout entry point. Called by requestAnimationFrame via needsLayut, by
updateLayout when forcing a synchronous layout, and called recursively during
subview traversal.
- 1:52 PM Changeset in webkit [191975] by
-
- 2 edits in trunk/Tools
Unreviewed, add myself to the SVG watchlist.
- Scripts/webkitpy/common/config/watchlist:
- 1:40 PM Changeset in webkit [191974] by
-
- 2 edits in trunk/Tools
Fix touch event sending crash in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=150848
<rdar://problem/23360841>
Reviewed by Simon Fraser.
Fixes a redundant force event generated by HIDEventGenerator. See the Radar diagnosis for more details.
- WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator _createIOHIDEventType:]): Deleted.
- 1:37 PM Changeset in webkit [191973] by
-
- 7 edits in trunk/Source
Web Inspector: Move ScriptDebugServer::Task to WorkerScriptDebugServer where it is actually used
https://bugs.webkit.org/show_bug.cgi?id=150847
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-11-03
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/ScriptDebugServer.h:
Remove Task from here, it isn't needed in the general case.
- parser/SourceProvider.h:
Remove unimplemented method.
Source/WebCore:
- bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::interruptAndRunTask):
- bindings/js/WorkerScriptDebugServer.h:
- inspector/WorkerDebuggerAgent.cpp:
- 1:28 PM Changeset in webkit [191972] by
-
- 2 edits in trunk/LayoutTests
AX: Add support for ARIA 1.1 attribute 'aria-modal' for dialog and alertdialog
https://bugs.webkit.org/show_bug.cgi?id=138566
Skip failing tests on windows platform.
Reviewed by Chris Fleizach.
- platform/win/TestExpectations:
- 1:01 PM Changeset in webkit [191971] by
-
- 5 edits in tags/Safari-602.1.9.1/Source
Versioning.
- 12:56 PM Changeset in webkit [191970] by
-
- 3 edits in trunk/Tools
[Win] Unreviewed build fix after r191958.
- MiniBrowser/win/MiniBrowser.h: Add missing include.
- MiniBrowser/win/MiniBrowserWebHost.h: Ditto.
- 12:52 PM Changeset in webkit [191969] by
-
- 2 edits in trunk/Source/WebCore
Fix the build.
- platform/Widget.h:
(WebCore::Widget::boundsRect):
(WebCore::Widget::resize):
- 12:31 PM Changeset in webkit [191968] by
-
- 21 edits7 adds in trunk
font-variant-* properties in @font-face declarations should be honored
https://bugs.webkit.org/show_bug.cgi?id=149771
Reviewed by Simon Fraser.
Source/WebCore:
According to the CSS Fonts Level 3 spec, web authors are allowed to put
font-feature-settings / font-variant-* inside @font-face blocks. These
properties are supposed to be applied at a specific time during the
font selection algorithm.
This patch gives a FontFeatureSettings object and a FontVariantSettings
object to CSSFontFace, and moves common parsing logic from
StyleBuilderCustom to a shared location. Then, once the two properties
are parsed from the @font-face block, the relevant data structures are
passed down into the font selection algorithm. This algorithm then
consults with these values at the correct time (inside
preparePlatformFont()).
Tests: css3/font-feature-settings-font-face-rendering.html
css3/font-variant-font-face-all.html
css3/font-variant-font-face-override.html
- WebCore.xcodeproj/project.pbxproj: Add a header for the common
location of parsing font-variant-ligatures, font-variant-numeric,
and font-variant-east-asian.
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::font): Pass the relevant data structures
into the font selection algorithm.
- css/CSSFontFace.h: Add FontFeatureSettings and FontVariantSettings
member variables.
(WebCore::CSSFontFace::insertFeature):
(WebCore::CSSFontFace::setVariantCommonLigatures):
(WebCore::CSSFontFace::setVariantDiscretionaryLigatures):
(WebCore::CSSFontFace::setVariantHistoricalLigatures):
(WebCore::CSSFontFace::setVariantContextualAlternates):
(WebCore::CSSFontFace::setVariantPosition):
(WebCore::CSSFontFace::setVariantCaps):
(WebCore::CSSFontFace::setVariantNumericFigure):
(WebCore::CSSFontFace::setVariantNumericSpacing):
(WebCore::CSSFontFace::setVariantNumericFraction):
(WebCore::CSSFontFace::setVariantNumericOrdinal):
(WebCore::CSSFontFace::setVariantNumericSlashedZero):
(WebCore::CSSFontFace::setVariantAlternates):
(WebCore::CSSFontFace::setVariantEastAsianVariant):
(WebCore::CSSFontFace::setVariantEastAsianWidth):
(WebCore::CSSFontFace::setVariantEastAsianRuby):
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::font): Pass the relevant data
structures into the font selection algorithm.
- css/CSSFontFaceSource.h: Ditto.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule): Call the shared
parsing logic to populate the FontFeatureSettings and
FontVariantSettings members.
- css/FontVariantBuilder.h: Added. Destination for shared parsing
logic.
(WebCore::applyValueFontVariantLigatures):
(WebCore::applyValueFontVariantNumeric):
(WebCore::applyValueFontVariantEastAsian):
- css/StyleBuilderCustom.h: Source for shared parsing logic.
(WebCore::StyleBuilderCustom::applyValueFontVariantLigatures):
(WebCore::StyleBuilderCustom::applyValueFontVariantNumeric):
(WebCore::StyleBuilderCustom::applyValueFontVariantEastAsian):
- loader/cache/CachedFont.cpp: Pass the relevant data structures
into the font selection algorithm.
(WebCore::CachedFont::createFont):
(WebCore::CachedFont::platformDataFromCustomData):
- loader/cache/CachedFont.h: Ditto.
- loader/cache/CachedSVGFont.cpp: Ditto.
(WebCore::CachedSVGFont::createFont):
(WebCore::CachedSVGFont::platformDataFromCustomData):
- loader/cache/CachedSVGFont.h: Ditto.
- platform/graphics/FontCache.h: Ditto.
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::codePath): Adjust comment.
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::preparePlatformFont): Consult with the newly parsed values.
(WebCore::fontWithFamily): Pass the relevant data structures into the
font selection algorithm.
(WebCore::FontCache::systemFallbackForCharacters): Ditto.
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Ditto.
- platform/graphics/mac/FontCustomPlatformData.h: Ditto.
LayoutTests:
- css3/font-variant-font-face-override-expected.html: Added
- css3/font-variant-font-face-override.html: Added
- css3/font-feature-settings-font-face-rendering-expected.html: Added.
- css3/font-feature-settings-font-face-rendering.html: Added.
- css3/font-variant-font-face-all-expected.html: Added.
- css3/font-variant-font-face-all.html: Added.
- 12:27 PM Changeset in webkit [191967] by
-
- 12 edits in trunk/Source
Web Inspector: Handle or Remove ParseHTML Timeline Event Records
https://bugs.webkit.org/show_bug.cgi?id=150689
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-11-03
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/protocol/Timeline.json:
Source/WebCore:
Remove ParseHTML nesting recordings. We were not using them
and for most pages their self-time is very small in comparison
to other events. We may consider adding it back later for
UI purposes but for now the frontend doesn't use the records
so lets remove it.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer): Deleted.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willWriteHTMLImpl): Deleted.
(WebCore::InspectorInstrumentation::didWriteHTMLImpl): Deleted.
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willWriteHTML): Deleted.
(WebCore::InspectorInstrumentation::didWriteHTML): Deleted.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willWriteHTML): Deleted.
(WebCore::InspectorTimelineAgent::didWriteHTML): Deleted.
(WebCore::toProtocol): Deleted.
- inspector/InspectorTimelineAgent.h:
- inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createParseHTMLData): Deleted.
- inspector/TimelineRecordFactory.h:
Source/WebInspectorUI:
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype._processRecord):
- 12:19 PM Changeset in webkit [191966] by
-
- 1 copy in tags/Safari-602.1.9.1
New tag.
- 12:02 PM Changeset in webkit [191965] by
-
- 11 edits in trunk/Source/JavaScriptCore
Rename InlineCallFrame:: getCallerSkippingDeadFrames to something more descriptive
https://bugs.webkit.org/show_bug.cgi?id=150832
Reviewed by Geoffrey Garen.
Renamed InlineCallFrame::getCallerSkippingDeadFrames() to getCallerSkippingTailCalls().
Did similar renaming to helper InlineCallFrame::computeCallerSkippingTailCalls() and
InlineCallFrame::getCallerInlineFrameSkippingTailCalls().
- bytecode/InlineCallFrame.h:
(JSC::InlineCallFrame::computeCallerSkippingTailCalls):
(JSC::InlineCallFrame::getCallerSkippingTailCalls):
(JSC::InlineCallFrame::getCallerInlineFrameSkippingTailCalls):
(JSC::InlineCallFrame::computeCallerSkippingDeadFrames): Deleted.
(JSC::InlineCallFrame::getCallerSkippingDeadFrames): Deleted.
(JSC::InlineCallFrame::getCallerInlineFrameSkippingDeadFrames): Deleted.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::allInlineFramesAreTailCalls):
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::isLiveInBytecode):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::forAllLocalsLiveInBytecode):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
- dfg/DFGPreciseLocalClobberize.h:
(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::codeOriginDescriptionOfCallSite):
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::gotoNextFrame):
- 11:59 AM Changeset in webkit [191964] by
-
- 19 edits7 adds76 deletes in trunk
HTMLOptionElement.text should never return the value of label
https://bugs.webkit.org/show_bug.cgi?id=148862
rdar://problem/22589226
Patch by Keith Rollin <Keith Rollin> on 2015-11-03
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline tests to reflect new behavior of option.text.
- web-platform-tests/html/semantics/forms/the-option-element/option-text-label-expected.txt:
Source/WebCore:
According to the HTML spec,
optionelements should have the
following behavior:
- the
textproperty should return text contents of element - the
labelproperty should return value of label attribute if it exists, else return text property - the UI should display label property
12 years ago, in order to be compatibile with browsers of the time, we
diverged from this behavior: the text property behaved like the label
property, and the text property was used for display. This resulted in
our UI incidentally conforming to the spec, but also in the text
property *not* conforming to the spec. See <rdar://problem/3532519>
for discussion on this change.
The behavior of the browsers we were conforming to has changed. In
particular, the text property in Firefox now conforms to the spec
instead of behaving as we did. Therefore, it's less important to
retain our old behavior for the sake of compatibility. This check-in
brings us into conformance with the spec. The result is that the UI
stays the same, but the text property will return different values than
it used to if the option element has a label attribute that used to
hide it.
Updated tests:
- fast/dom/HTMLOptionElement/option-text.html:
- fast/forms/HTMLOptionElement_label01.html:
- fast/forms/HTMLOptionElement_label02.html:
- fast/forms/HTMLOptionElement_label03.html:
- fast/forms/HTMLOptionElement_label04.html:
- fast/forms/HTMLOptionElement_label05.html:
- fast/forms/HTMLOptionElement_label06.html:
- fast/forms/HTMLOptionElement_label07.html:
- fast/forms/option-value-and-label.html:
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::stringValue):
- accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::stringValue):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::text):
(WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
LayoutTests:
Rebaseline tests to reflect new behavior of option.text. Convert some
render tests to reference tests.
- dom/xhtml/level2/html/HTMLOptionElement04-expected.txt:
- fast/dom/HTMLOptionElement/option-text-expected.txt:
- fast/dom/HTMLOptionElement/option-text.html:
- fast/forms/HTMLOptionElement_label01-expected.html: Added.
- fast/forms/HTMLOptionElement_label01.html:
- fast/forms/HTMLOptionElement_label02-expected.html: Added.
- fast/forms/HTMLOptionElement_label02.html:
- fast/forms/HTMLOptionElement_label03-expected.html: Added.
- fast/forms/HTMLOptionElement_label03.html:
- fast/forms/HTMLOptionElement_label04-expected.html: Added.
- fast/forms/HTMLOptionElement_label04.html:
- fast/forms/HTMLOptionElement_label05-expected.html: Added.
- fast/forms/HTMLOptionElement_label05.html:
- fast/forms/HTMLOptionElement_label06-expected.html: Added.
- fast/forms/HTMLOptionElement_label06.html:
- fast/forms/HTMLOptionElement_label07-expected.html: Added.
- fast/forms/HTMLOptionElement_label07.html:
- fast/forms/option-value-and-label-expected.txt:
- fast/forms/option-value-and-label.html:
- platform/efl/fast/forms/HTMLOptionElement_label01-expected.png: Removed.
- platform/efl/fast/forms/HTMLOptionElement_label01-expected.txt: Removed.
- platform/efl/fast/forms/HTMLOptionElement_label02-expected.png: Removed.
- platform/efl/fast/forms/HTMLOptionElement_label02-expected.txt: Removed.
- platform/efl/fast/forms/HTMLOptionElement_label03-expected.png: Removed.
- platform/efl/fast/forms/HTMLOptionElement_label03-expected.txt: Removed.
- platform/efl/fast/forms/HTMLOptionElement_label04-expected.png: Removed.
- platform/efl/fast/forms/HTMLOptionElement_label04-expected.txt: Removed.
- platform/efl/fast/forms/HTMLOptionElement_label05-expected.png: Removed.
- platform/efl/fast/forms/HTMLOptionElement_label05-expected.txt: Removed.
- platform/efl/fast/forms/HTMLOptionElement_label06-expected.png: Removed.
- platform/efl/fast/forms/HTMLOptionElement_label06-expected.txt: Removed.
- platform/efl/fast/forms/HTMLOptionElement_label07-expected.png: Removed.
- platform/efl/fast/forms/HTMLOptionElement_label07-expected.txt: Removed.
- platform/gtk/fast/forms/HTMLOptionElement_label01-expected.png: Removed.
- platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt: Removed.
- platform/gtk/fast/forms/HTMLOptionElement_label02-expected.png: Removed.
- platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt: Removed.
- platform/gtk/fast/forms/HTMLOptionElement_label03-expected.png: Removed.
- platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt: Removed.
- platform/gtk/fast/forms/HTMLOptionElement_label04-expected.png: Removed.
- platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt: Removed.
- platform/gtk/fast/forms/HTMLOptionElement_label05-expected.png: Removed.
- platform/gtk/fast/forms/HTMLOptionElement_label05-expected.txt: Removed.
- platform/gtk/fast/forms/HTMLOptionElement_label06-expected.png: Removed.
- platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt: Removed.
- platform/gtk/fast/forms/HTMLOptionElement_label07-expected.png: Removed.
- platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt: Removed.
- platform/ios-simulator-wk2/fast/forms/HTMLOptionElement_label01-expected.txt: Removed.
- platform/ios-simulator-wk2/fast/forms/HTMLOptionElement_label02-expected.txt: Removed.
- platform/ios-simulator-wk2/fast/forms/HTMLOptionElement_label03-expected.txt: Removed.
- platform/ios-simulator-wk2/fast/forms/HTMLOptionElement_label04-expected.txt: Removed.
- platform/ios-simulator-wk2/fast/forms/HTMLOptionElement_label05-expected.txt: Removed.
- platform/ios-simulator-wk2/fast/forms/HTMLOptionElement_label06-expected.txt: Removed.
- platform/ios-simulator-wk2/fast/forms/HTMLOptionElement_label07-expected.txt: Removed.
- platform/ios-simulator/fast/forms/HTMLOptionElement_label01-expected.txt: Removed.
- platform/ios-simulator/fast/forms/HTMLOptionElement_label02-expected.txt: Removed.
- platform/ios-simulator/fast/forms/HTMLOptionElement_label03-expected.txt: Removed.
- platform/ios-simulator/fast/forms/HTMLOptionElement_label04-expected.txt: Removed.
- platform/ios-simulator/fast/forms/HTMLOptionElement_label05-expected.txt: Removed.
- platform/ios-simulator/fast/forms/HTMLOptionElement_label06-expected.txt: Removed.
- platform/ios-simulator/fast/forms/HTMLOptionElement_label07-expected.txt: Removed.
- platform/mac-mavericks/fast/forms/HTMLOptionElement_label01-expected.png: Removed.
- platform/mac-mavericks/fast/forms/HTMLOptionElement_label01-expected.txt: Removed.
- platform/mac-mavericks/fast/forms/HTMLOptionElement_label02-expected.png: Removed.
- platform/mac-mavericks/fast/forms/HTMLOptionElement_label02-expected.txt: Removed.
- platform/mac-mavericks/fast/forms/HTMLOptionElement_label03-expected.png: Removed.
- platform/mac-mavericks/fast/forms/HTMLOptionElement_label04-expected.png: Removed.
- platform/mac-mavericks/fast/forms/HTMLOptionElement_label04-expected.txt: Removed.
- platform/mac-mavericks/fast/forms/HTMLOptionElement_label05-expected.png: Removed.
- platform/mac-mavericks/fast/forms/HTMLOptionElement_label05-expected.txt: Removed.
- platform/mac/fast/forms/HTMLOptionElement_label01-expected.png: Removed.
- platform/mac/fast/forms/HTMLOptionElement_label01-expected.txt: Removed.
- platform/mac/fast/forms/HTMLOptionElement_label02-expected.png: Removed.
- platform/mac/fast/forms/HTMLOptionElement_label02-expected.txt: Removed.
- platform/mac/fast/forms/HTMLOptionElement_label03-expected.png: Removed.
- platform/mac/fast/forms/HTMLOptionElement_label03-expected.txt: Removed.
- platform/mac/fast/forms/HTMLOptionElement_label04-expected.png: Removed.
- platform/mac/fast/forms/HTMLOptionElement_label04-expected.txt: Removed.
- platform/mac/fast/forms/HTMLOptionElement_label05-expected.png: Removed.
- platform/mac/fast/forms/HTMLOptionElement_label05-expected.txt: Removed.
- platform/mac/fast/forms/HTMLOptionElement_label06-expected.png: Removed.
- platform/mac/fast/forms/HTMLOptionElement_label06-expected.txt: Removed.
- platform/mac/fast/forms/HTMLOptionElement_label07-expected.png: Removed.
- platform/mac/fast/forms/HTMLOptionElement_label07-expected.txt: Removed.
- platform/win/fast/forms/HTMLOptionElement_label01-expected.png: Removed.
- platform/win/fast/forms/HTMLOptionElement_label01-expected.txt: Removed.
- platform/win/fast/forms/HTMLOptionElement_label02-expected.png: Removed.
- platform/win/fast/forms/HTMLOptionElement_label02-expected.txt: Removed.
- platform/win/fast/forms/HTMLOptionElement_label03-expected.png: Removed.
- platform/win/fast/forms/HTMLOptionElement_label03-expected.txt: Removed.
- platform/win/fast/forms/HTMLOptionElement_label04-expected.png: Removed.
- platform/win/fast/forms/HTMLOptionElement_label04-expected.txt: Removed.
- platform/win/fast/forms/HTMLOptionElement_label05-expected.txt: Removed.
- platform/win/fast/forms/HTMLOptionElement_label06-expected.txt: Removed.
- platform/win/fast/forms/HTMLOptionElement_label07-expected.txt: Removed.
- 11:54 AM Changeset in webkit [191963] by
-
- 2 edits in trunk/Source/WebCore
ResourceUsageOverlay should draw itself using WebCore::GraphicsContext.
<https://webkit.org/b/150841>
Reviewed by Antti Koivisto.
Use WebCore text drawing primitives instead of poking at the CGContext directly.
And stop using deprecated CoreGraphics APIs, too.
- page/cocoa/ResourceUsageOverlayCocoa.mm:
(WebCore::drawCpuHistory):
(WebCore::drawGCHistory):
Adjust for unflipped Y axis.
(WebCore::fontCascade):
(WebCore::showText):
Draw using WebCore text drawing primitives.
(WebCore::ResourceUsageOverlay::draw):
Remove CGContext calls and stop flipping the Y axis.
- 11:25 AM Changeset in webkit [191962] by
-
- 3 edits in trunk/Source/WebKit2
Simplify -[_WKRemoteObjectRegistry _invokeMethod:]
https://bugs.webkit.org/show_bug.cgi?id=150844
Reviewed by Tim Horton.
- Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:
(-[_WKRemoteObjectRegistry _invokeMethod:]):
(-[_WKRemoteObjectRegistry _invokeMessageWithInterfaceIdentifier:encodedInvocation:]): Deleted.
- Shared/API/Cocoa/_WKRemoteObjectRegistryInternal.h:
- 11:02 AM Changeset in webkit [191961] by
-
- 2 edits in trunk/Tools
Add Jiewen Tan (jiewen_tan@apple.com) to committer list.
- Scripts/webkitpy/common/config/contributors.json:
- 10:48 AM Changeset in webkit [191960] by
-
- 7 edits1 add in trunk/Source
B3/Air should use bubble sort for their insertion sets, because it's faster than std::stable_sort
https://bugs.webkit.org/show_bug.cgi?id=150828
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Undo the 2% compile time regression caused by http://trac.webkit.org/changeset/191913.
- b3/B3InsertionSet.cpp:
(JSC::B3::InsertionSet::execute): Switch to bubble sort.
- b3/air/AirInsertionSet.cpp:
(JSC::B3::Air::InsertionSet::execute): Switch to bubble sort.
- dfg/DFGBlockInsertionSet.cpp:
(JSC::DFG::BlockInsertionSet::execute): Switch back to quicksort.
Source/WTF:
Add a pretty good bubble sort implementation to WTF. This implementation has three
common tricks:
- Forward and backward scans. This reduces the severity of certain kinds of bubble sort pathologies.
- Return if a scan finds the list to be sorted. This gives the algorithm one of its most attractive properties: it's super fast when the list is already sorted.
- Each scan eliminates one element from future scans. This makes the algorithm no worse than insertion sort.
Why do we want this? Because bubble sort is a really great stable sort for small lists,
or large lists in which only a handful of elements are out of order. Compiler insertion
sets tend to be one of those or somewhere in between: usually they are very small, and
usually they are sorted. It's rare that an element will be out of order, and when it is,
it's usually very close to where it's supposed to be.
This is a significant speed-up for B3 compile times.
- WTF.xcodeproj/project.pbxproj:
- wtf/BubbleSort.h: Added.
(WTF::bubbleSort):
- wtf/CMakeLists.txt:
- 10:44 AM Changeset in webkit [191959] by
-
- 8 edits in trunk/Source/WebKit2
CTTE the responsiveness timer getter
https://bugs.webkit.org/show_bug.cgi?id=150825
Reviewed by Daniel Bates.
- UIProcess/API/C/mac/WKPagePrivateMac.mm:
(-[WKObservablePageState _webProcessIsResponsive]):
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController _webProcessIsResponsive]):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _webProcessIsResponsive]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcessForReload):
(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::tryClose):
(WebKit::WebPageProxy::loadRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::navigateToPDFLinkWithSimulatedClick):
(WebKit::WebPageProxy::stopLoading):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::dispatchViewStateChange):
(WebKit::WebPageProxy::handleMouseEvent):
(WebKit::WebPageProxy::sendWheelEvent):
(WebKit::WebPageProxy::handleKeyboardEvent):
(WebKit::WebPageProxy::handleGestureEvent):
(WebKit::WebPageProxy::handleTouchEventSynchronously):
(WebKit::WebPageProxy::handleTouchEvent):
(WebKit::WebPageProxy::closePage):
(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::runJavaScriptConfirm):
(WebKit::WebPageProxy::runJavaScriptPrompt):
(WebKit::WebPageProxy::runBeforeUnloadConfirmPanel):
(WebKit::WebPageProxy::runOpenPanel):
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::internalShowContextMenu):
(WebKit::WebPageProxy::didReceiveEvent):
(WebKit::WebPageProxy::stopResponsivenessTimer):
(WebKit::WebPageProxy::runModal):
(WebKit::WebPageProxy::updateBackingStoreDiscardableState):
- UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::responsivenessTimer):
- 10:32 AM Changeset in webkit [191958] by
-
- 2 edits in trunk
[Win] CMake build update.
Rubberstamped by Tim Horton.
- Source/PlatformWin.cmake: Add internal tool to build
rules for internal use.
- 10:30 AM Changeset in webkit [191957] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, partially revert r191952.
Removed GCC compiler workarounds (unreachable returns).
- b3/B3Type.h:
(JSC::B3::sizeofType):
- b3/air/AirArg.h:
(JSC::B3::Air::Arg::isUse):
(JSC::B3::Air::Arg::isDef):
(JSC::B3::Air::Arg::isGP):
(JSC::B3::Air::Arg::isFP):
(JSC::B3::Air::Arg::isType):
- b3/air/AirCode.h:
(JSC::B3::Air::Code::newTmp):
(JSC::B3::Air::Code::numTmps):
- 10:29 AM Changeset in webkit [191956] by
-
- 4 edits in trunk/Source/WebCore
[Streams API] Vended promise capabilities should not need @resolve/@reject fields
https://bugs.webkit.org/show_bug.cgi?id=150835
Reviewed by Darin Adler.
No change in behavior, covered by existing tests.
- Modules/streams/ReadableStreamInternals.js:
(privateInitializeReadableStreamReader): Removed @resolve/@reject fields from resolved/rejected @closedPromiseCapability.
- Modules/streams/WritableStream.js:
(initializeWritableStream): Removed @resolve/@reject fields from resolved readyPromiseCapability.
- Modules/streams/WritableStreamInternals.js:
(syncWritableStreamStateWithQueue): Updated code to be closer to spec and removing the need to resolve an already resolved promise.
- 10:24 AM Changeset in webkit [191955] by
-
- 53 edits in trunk/Source/WebCore
Replace 0 and NULL with nullptr in WebCore/dom.
https://bugs.webkit.org/show_bug.cgi?id=150788
Reviewed by Darin Adler.
No new tests because there is no behavior change.
- dom/Attr.cpp:
(WebCore::Attr::Attr):
(WebCore::Attr::detachFromElementWithValue):
(WebCore::Attr::attachToElement):
- dom/Attr.h:
- dom/CheckedRadioButtons.cpp:
(WebCore::RadioButtonGroup::updateCheckedState):
(WebCore::CheckedRadioButtons::checkedButtonForGroup):
(WebCore::CheckedRadioButtons::isInRequiredGroup):
- dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationAccumulator::enqueueMutationRecord):
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeBetween):
- dom/ContainerNode.h:
(WebCore::ContainerNode::ContainerNode):
- dom/ContainerNodeAlgorithms.cpp:
(WebCore::notifyNodeRemovedFromDocument):
- dom/Document.h:
(WebCore::Document::wellFormed):
(WebCore::Document::scriptRunner):
(WebCore::Document::moduleLoader):
(WebCore::Document::currentScript):
(WebCore::Document::webkitFullscreenElement):
- dom/DocumentOrderedMap.h:
(WebCore::DocumentOrderedMap::MapEntry::MapEntry):
- dom/DocumentParser.cpp:
(WebCore::DocumentParser::detach):
(WebCore::DocumentParser::suspendScheduledTasks):
- dom/Element.cpp:
(WebCore::Element::setAttributeInternal):
(WebCore::Element::shadowRoot):
(WebCore::Element::blur):
(WebCore::Element::beforePseudoElement):
(WebCore::Element::afterPseudoElement):
(WebCore::Element::setBeforePseudoElement):
- dom/Event.cpp:
(WebCore::Event::Event):
- dom/Event.h:
(WebCore::Event::legacyReturnValue):
(WebCore::Event::setLegacyReturnValue):
(WebCore::Event::clipboardData):
- dom/EventContext.cpp:
(WebCore::MouseOrFocusEventContext::MouseOrFocusEventContext):
- dom/EventDispatcher.cpp:
(WebCore::EventPath::lastContextIfExists):
(WebCore::EventDispatcher::dispatchEvent):
- dom/EventListenerMap.cpp:
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::EventListenerIterator):
- dom/EventListenerMap.h:
- dom/EventTarget.cpp:
(WebCore::EventTarget::fireEventListeners):
- dom/FocusEvent.cpp:
(WebCore::FocusEventInit::FocusEventInit):
- dom/GenericEventQueue.cpp:
(WebCore::GenericEventQueue::enqueueEvent):
- dom/IdTargetObserverRegistry.h:
(WebCore::IdTargetObserverRegistry::IdTargetObserverRegistry):
(WebCore::IdTargetObserverRegistry::notifyObservers):
- dom/IgnoreDestructiveWriteCountIncrementer.h:
(WebCore::IgnoreDestructiveWriteCountIncrementer::IgnoreDestructiveWriteCountIncrementer):
- dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent):
- dom/MessageEvent.h:
- dom/MessagePort.cpp:
(WebCore::MessagePort::contextDestroyed):
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::locallyEntangledPort):
(WebCore::MessagePort::disentanglePorts):
- dom/MouseEvent.cpp:
(WebCore::MouseEventInit::MouseEventInit):
(WebCore::MouseEvent::cloneFor):
- dom/MouseEvent.h:
(WebCore::MouseEvent::dataTransfer):
- dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
(WebCore::MouseRelatedEvent::computeRelativePosition):
- dom/MutationEvent.h:
- dom/Node.cpp:
(WebCore::Node::nodeLists):
(WebCore::Node::clearNodeLists):
(WebCore::Node::nonShadowBoundaryParentNode):
(WebCore::Node::parentOrShadowHostElement):
- dom/Node.h:
- dom/NodeRareData.h:
(WebCore::NodeListsNodeData::removeCachedCollection):
(WebCore::NodeListsNodeData::isEmpty):
- dom/PendingScript.cpp:
(WebCore::PendingScript::releaseElementAndClear):
- dom/PopStateEvent.cpp:
(WebCore::PopStateEvent::PopStateEvent):
- dom/Position.h:
(WebCore::Position::deprecatedNode):
(WebCore::Position::document):
(WebCore::Position::rootEditableElement):
- dom/PositionIterator.cpp:
(WebCore::PositionIterator::decrement):
- dom/PositionIterator.h:
(WebCore::PositionIterator::PositionIterator):
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::ProcessingInstruction):
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::parseStyleSheet):
- dom/ProcessingInstruction.h:
- dom/RangeBoundaryPoint.h:
(WebCore::RangeBoundaryPoint::RangeBoundaryPoint):
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::stopLoadRequest):
(WebCore::ScriptElement::notifyFinished):
(WebCore::ScriptElement::ignoresLoadRequest):
- dom/ScriptedAnimationController.h:
(WebCore::ScriptedAnimationController::create):
(WebCore::ScriptedAnimationController::clearDocumentPointer):
- dom/StyledElement.cpp:
(WebCore::PresentationAttributeCacheKey::PresentationAttributeCacheKey):
(WebCore::StyledElement::addSubresourceAttributeURLs):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):
- dom/StyledElement.h:
(WebCore::StyledElement::additionalPresentationAttributeStyle):
(WebCore::StyledElement::inlineStyle):
- dom/TemplateContentDocumentFragment.h:
- dom/TextEvent.cpp:
(WebCore::TextEvent::TextEvent):
- dom/UIEvent.cpp:
(WebCore::UIEventInit::UIEventInit):
- dom/UserTypingGestureIndicator.cpp:
(WebCore::UserTypingGestureIndicator::UserTypingGestureIndicator):
(WebCore::UserTypingGestureIndicator::~UserTypingGestureIndicator):
- dom/ViewportArguments.cpp:
(WebCore::restrictScaleFactorToInitialScaleIfNotUserScalable):
(WebCore::numericPrefix):
- dom/default/PlatformMessagePortChannel.cpp:
(WebCore::MessagePortChannel::disentangle):
(WebCore::MessagePortChannel::postMessageToRemote):
(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
- dom/default/PlatformMessagePortChannel.h:
- 9:15 AM Changeset in webkit [191954] by
-
- 4 edits2 adds in trunk
Tapping *below* some <input>s can focus them in Mobile Safari
https://bugs.webkit.org/show_bug.cgi?id=146244
<rdar://problem/21509310>
Reviewed by Darin Adler.
Source/WebCore:
Removes iOS-specific logic in positionForPointRespectingEditingBoundaries that was causing us to focus inputs by
tapping on the document element. We believe this logic, which causes VisiblePosition finding to recurse from a non-
editable element to an editable child, is not necessary to focus editable elements underneath non-editable elements,
since hit-testing will already have selected the contentEditable element prior to searching for a suitable
VisiblePosition. Further investigation shows that this logic was added to fix <rdar://problem/5545799>, in which the
first character in a Notes document could not be selected. However, I have not been able to reproduce this bug after
removing this logic.
As a result of this change, we can also enable a WK1 test, editing/selection/click-outside-editable-div.html, that
had also been marked as failing due to positionForPointRespectingEditingBoundaries recursing into a contentEditable
div.
Test: fast/events/ios/clicking-document-should-not-trigger-focus.html
- rendering/RenderBlock.cpp:
(WebCore::positionForPointRespectingEditingBoundaries): Deleted.
LayoutTests:
Enables a now-passing WK1 editing test (editing/selection/click-outside-editable-div.html) and also add a new
WK2 test that verifies an input node won't be focused by clicking anywhere in the document outside of the body.
- fast/events/ios/clicking-document-should-not-trigger-focus-expected.txt: Added.
- fast/events/ios/clicking-document-should-not-trigger-focus.html: Added.
- platform/ios-simulator-wk1/TestExpectations: No longer disable editing/selection/click-outside-editable-div.html.
- 9:13 AM Changeset in webkit [191953] by
-
- 5 edits2 adds in trunk
Update to match text-orientation spec
https://bugs.webkit.org/show_bug.cgi?id=150765
Reviewed by Darin Adler.
Source/WebCore:
The CSS spec has removed the "sideways-right" value of text-orientation in favor
of "sideways." This patch makes the parser treat "sideways-right" the same as
"sideways."
Test: fast/text/orientation-sideways-right.html
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator TextOrientation):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Deleted.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::fontAndGlyphOrientation): Deleted.
- rendering/style/RenderStyleConstants.h:
LayoutTests:
- fast/text/orientation-sideways-right-expected.html: Added.
- fast/text/orientation-sideways-right.html: Added.
- 7:50 AM Changeset in webkit [191952] by
-
- 9 edits in trunk/Source/JavaScriptCore
Fix the ENABLE(B3_JIT) build on Linux
https://bugs.webkit.org/show_bug.cgi?id=150794
Reviewed by Darin Adler.
- CMakeLists.txt:
- b3/B3HeapRange.h:
- b3/B3IndexSet.h:
(JSC::B3::IndexSet::Iterable::iterator::operator++):
- b3/B3Type.h:
(JSC::B3::sizeofType):
- b3/air/AirArg.cpp:
(JSC::B3::Air::Arg::dump):
- b3/air/AirArg.h:
(JSC::B3::Air::Arg::isUse):
(JSC::B3::Air::Arg::isDef):
(JSC::B3::Air::Arg::isGP):
(JSC::B3::Air::Arg::isFP):
(JSC::B3::Air::Arg::isType):
- b3/air/AirCode.h:
(JSC::B3::Air::Code::newTmp):
(JSC::B3::Air::Code::numTmps):
- b3/air/AirSpecial.cpp:
- 7:32 AM Changeset in webkit [191951] by
-
- 2 edits in trunk/Tools
Unreviewed, add unittest after r191827.
- BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
- 6:52 AM Changeset in webkit [191950] by
-
- 7 edits in trunk/Source/WebCore
[Streams API] Rework promises to use @newPromiseCapability
https://bugs.webkit.org/show_bug.cgi?id=150627
Reviewed by Youenn Fablet.
We are removing the stream promises functions in favor of @newPromiseCapabity which basically provides the same
functionality (keeping the resolve and reject functions without external slots). Slots and variables were
renamed as *PromiseCapability to show that they no longer hold just a promise, but a promise capability.
Internal rework, no new tests needed.
- Modules/streams/ReadableStreamInternals.js:
(privateInitializeReadableStreamReader.this.closedPromiseCapability.resolve):
(privateInitializeReadableStreamReader.this.closedPromiseCapability.reject):
(privateInitializeReadableStreamReader):
(teeReadableStream):
(teeReadableStreamBranch2CancelFunction):
(errorReadableStream):
(closeReadableStreamReader):
(enqueueInReadableStream):
(readFromReadableStreamReader):
- Modules/streams/ReadableStreamReader.js:
(closed):
- Modules/streams/StreamInternals.js:
(createNewStreamsPromise): Deleted.
(resolveStreamsPromise): Deleted.
(rejectStreamsPromise): Deleted.
- Modules/streams/WritableStream.js:
(this.readyPromiseCapability.resolve):
(this.readyPromiseCapability.reject):
(initializeWritableStream):
(close):
(write):
(closed):
(ready):
- Modules/streams/WritableStreamInternals.js:
(syncWritableStreamStateWithQueue):
(errorWritableStream):
- bindings/js/WebCoreBuiltinNames.h:
- 5:43 AM Changeset in webkit [191949] by
-
- 16 edits1 add5 deletes in trunk
Move webkitGetUserMedia to JS Builtin
https://bugs.webkit.org/show_bug.cgi?id=149499
Reviewed by Darin Adler.
Source/WebCore:
Implemented webkitGetUserMedia as a JSBuiltin wrapper around navigator.mediaDevices.getUserMedia.
Removed cpp based version.
The js builting implementation checks for argument but does not raise exception when the request is not supported.
The error callback is called instead, in an asynchronous fashion.
The js builtin implementation does not check first that it is called on navigator, contrary to the cpp implementation.
This is done afterwards when calling navigator.MediaDevices.@getUserMedia.
Covered by existing and modified tests.
- CMakeLists.txt: Adding NavigatorUserMedia.js as built-in JS file.
- DerivedSources.make: Ditto.
- Modules/mediastream/NavigatorUserMedia.idl: Making webkitGetUserMedia JSBuiltin
- Modules/mediastream/NavigatorUserMedia.js:
(webkitGetUserMedia):
- Modules/mediastream/NavigatorUserMediaErrorCallback.h: Removed.
- Modules/mediastream/NavigatorUserMediaErrorCallback.idl: Removed.
- Modules/mediastream/NavigatorUserMediaSuccessCallback.h: Removed.
- Modules/mediastream/NavigatorUserMediaSuccessCallback.idl: Removed.
- Modules/mediastream/UserMediaRequest.cpp:
- Modules/mediastream/UserMediaRequest.h:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::finishCreation): Style modifications.
- bindings/js/JSNavigatorCustom.cpp: Removed.
- bindings/js/WebCoreJSBuiltins.cpp: Adding support for NavigatorUserMedia.js built-in JS file.
- bindings/js/WebCoreJSBuiltins.h: Ditto.
(WebCore::JSBuiltinFunctions::JSBuiltinFunctions):
(WebCore::JSBuiltinFunctions::navigatorUserMediaBuiltins):
LayoutTests:
- fast/mediastream/argument-types-expected.txt:
- fast/mediastream/getusermedia-expected.txt:
- fast/mediastream/getusermedia.html:
- fast/mediastream/script-tests/argument-types.js:
- http/tests/media/media-stream/disconnected-frame-already-expected.txt:
- 2:43 AM Changeset in webkit [191948] by
-
- 7 edits in trunk/Source/WebCore
[GStreamer] Use GstBus sync message handler and schedule tasks to the main thread with RunLoop::dispatch
https://bugs.webkit.org/show_bug.cgi?id=150800
Reviewed by Philippe Normand.
This way we would avoid all the GScource + polling mechanism that
GST uses internally to handle messages asynchronously in the main thread.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef):
(WTF::refGPtr<GstMessage>):
(WTF::derefGPtr<GstMessage>):
- platform/graphics/gstreamer/GRefPtrGStreamer.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
Initialize the WeakPtr factory.
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
reset the GstBus sync handler.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Make it void.
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Add a
GstBus sync message handler and schedule the messages to the main
thread with RunLoop::main().dispatch().
(WebCore::mediaPlayerPrivateMessageCallback): Deleted.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(WebCore::MediaPlayerPrivateGStreamer::createWeakPtr): Create a WeakPtr.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::handleSyncMessage):
Handle the need context message that needs to be handled in the
caller thread.
(WebCore::mediaPlayerPrivateNeedContextMessageCallback): Deleted.
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::setPipeline): Do not
connect to sync-message signal, handleSyncMessage() will be called
to handled messages synchronously.
(WebCore::MediaPlayerPrivateGStreamerBase::handleNeedContextMessage): Deleted.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- 2:40 AM Changeset in webkit [191947] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Cleanup the iradio properties
https://bugs.webkit.org/show_bug.cgi?id=148522
Reviewed by Philippe Normand.
Remove unused icecast code.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::handleResponseReceived):
(webKitWebSrcGetProperty): Deleted.
(webKitWebSrcStop): Deleted.
- 2:36 AM Changeset in webkit [191946] by
-
- 5 edits in trunk/Source/JavaScriptCore
Clean up ENABLE(ES6_ARROWFUNCTION_SYNTAX) ifdefs and keep minimal set of them
https://bugs.webkit.org/show_bug.cgi?id=150793
Reviewed by Darin Adler.
Fix the !ENABLE(ES6_ARROWFUNCTION_SYNTAX) build after r191875.
This patch drops many ENABLE(ES6_ARROWFUNCTION_SYNTAX) ifdefs and keep only one of them;
the ifdef in parseAssignmentExpression.
This prevents functionality of parsing arrow function syntax.
- parser/Lexer.cpp:
(JSC::Lexer<T>::lex):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseInner): Deleted.
- parser/Parser.h:
(JSC::Parser::isArrowFunctionParamters): Deleted.
- parser/ParserTokens.h:
- 1:49 AM Changeset in webkit [191945] by
-
- 1 copy in releases/WebKitGTK/webkit-2.11.1
WebKitGTK+ 2.11.1
- 1:47 AM Changeset in webkit [191944] by
-
- 4 edits in trunk
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.11.1 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.11.1.
- 1:28 AM Changeset in webkit [191943] by
-
- 2 edits in trunk/Source/WebKit2
Use the same cookie storage as WebCore when using NETWORK_SESSION
https://bugs.webkit.org/show_bug.cgi?id=150833
Patch by Alex Christensen <achristensen@webkit.org> on 2015-11-03
Reviewed by Antti Koivisto.
This fixes 12 tests when using NETWORK_SESSION.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSession::NetworkSession):
- 1:16 AM Changeset in webkit [191942] by
-
- 4 edits in trunk/Source/WebKit2
Clean up NETWORK_SESSION code after r191848
https://bugs.webkit.org/show_bug.cgi?id=150829
Patch by Alex Christensen <achristensen@webkit.org> on 2015-11-03
Reviewed by Darin Adler.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveData):
(WebKit::NetworkResourceLoader::didCompleteWithError):
- NetworkProcess/NetworkSession.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSession::NetworkSession):
(WebKit::NetworkSession::createDataTaskWithRequest):
(WebKit::NetworkSession::dataTaskForIdentifier):
