Context Navigation

← Previous Period
Next Period →

Timeline

Nov 8, 2015:

11:03 PM Changeset in webkit [192148] by Gyuyoung Kim

4 edits
2 adds in trunk/Source

[EFL] Add UserAgentEFl.cpp|h
https://bugs.webkit.org/show_bug.cgi?id=151007

Reviewed by Darin Adler.

As other ports EFL port starts to have UserAgentEfl class in order to support more detailed
UA.

Source/WebCore:

No new tests, no behavior change.

PlatformEfl.cmake:
platform/efl/UserAgentEfl.cpp: Added.

(WebCore::platformForUAString):
(WebCore::platformVersionForUAString):
(WebCore::versionForUAString):
(WebCore::standardUserAgent):

platform/efl/UserAgentEfl.h: Added.

Source/WebKit2:

UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::standardUserAgent): Call WebCore::standardUserAgent().

5:34 PM Changeset in webkit [192147] by Yusuke Suzuki

11 edits in trunk/Source/JavaScriptCore

[ES6] Minimize ES6_CLASS_SYNTAX ifdefs
https://bugs.webkit.org/show_bug.cgi?id=151006

Reviewed by Darin Adler.

This patch minimizes ENABLE_ES6_CLASS_SYNTAX ifdefs.
It keeps several ENABLE_ES6_CLASS_SYNTAX ifdefs in Parser.cpp.

super meta property
class declaration parsing
class expression parsing
class with import declaration

This change makes difference minimal between the enabled and disabled configurations;
reducing accidental build breaks of the disabled configuration.

bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::constructorKind): Deleted.

bytecompiler/NodesCodegen.cpp:
parser/ASTBuilder.h:
parser/NodeConstructors.h:
parser/Nodes.h:
parser/Parser.cpp:
parser/Parser.h:

(JSC::Scope::hasDirectSuper): Deleted.
(JSC::Scope::needsSuperBinding): Deleted.

parser/ParserFunctionInfo.h:
parser/ParserTokens.h:
parser/SyntaxChecker.h:

10:36 AM Changeset in webkit [192146] by Sukolsak Sakshuwong

2 edits in trunk/Source/JavaScriptCore

Use StringView::upconvertedCharacters() to make a 16-bit copy in String.prototype.normalize
https://bugs.webkit.org/show_bug.cgi?id=151005

Reviewed by Michael Saboff.

The ICU's unorm_normalize function used by String.prototype.normalize
requires a 16-bit string. This patch uses StringView::upconvertedCharacters()
to make a 16-bit copy of a string.

runtime/StringPrototype.cpp:

(JSC::stringProtoFuncNormalize):

9:16 AM Changeset in webkit [192145] by Simon Fraser

2 edits in trunk/Source/WebKit/win

Another Windows build fix.

WebView.cpp:

(WebView::paintIntoBackingStore):

9:11 AM Changeset in webkit [192144] by Simon Fraser

3 edits in trunk/Source/WebKit/win

Fix the Windows build after r192140.

FullscreenVideoController.cpp:

(HUDButton::draw):
(HUDSlider::draw):
(FullscreenVideoController::draw):

Plugins/PluginView.cpp:

(WebCore::PluginView::paintMissingPluginIcon):

7:32 AM Changeset in webkit [192143] by ddkilzer@apple.com

4 edits in trunk/Source/WebCore

REGRESSION (r192140): Windows build broke after removing ColorSpace argument to all drawing calls
<http://webkit.org/b/150967>

Unreviewed attempt to fix the Windows build.

platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayerWin::drawTextAtPoint):

platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::drawFrameMatchingSourceSize):

rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecorationPart):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):

3:40 AM Changeset in webkit [192142] by youenn.fablet@crf.canon.fr

10 edits in trunk/Source

generate-js-builtins.js should support @internal annotation
https://bugs.webkit.org/show_bug.cgi?id=150929

Reviewed by Darin Adler.

Source/JavaScriptCore:

Scripts/builtins/builtins_generate_separate_header.py:

(BuiltinsSeparateHeaderGenerator.generate_output): Generate internal boilerplate code only if @internal annotation is available.

Scripts/builtins/builtins_templates.py: Split boilerplate in two templates (one that is used for all built-ins and one dedicated to internals).
Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result: Removed internal boilerplate.
Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result: Ditto.
Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result: Ditto.

Source/WebCore:

No change in behavior.

Modules/streams/ReadableStreamInternals.js: Renamed @internals to @internal.
Modules/streams/StreamInternals.js: Ditto.
Modules/streams/WritableStreamInternals.js: Ditto.

12:03 AM Changeset in webkit [192141] by Yusuke Suzuki

12 edits in trunk/Source/JavaScriptCore

[ES6] Minimize ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX ifdefs
https://bugs.webkit.org/show_bug.cgi?id=150998

Reviewed by Geoffrey Garen.

This patch minimizes ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX ifdefs.
It only keeps 2 ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX in Parser.cpp, one for
template literals and one for tagged templates.
This change makes difference minimal between the enabled and disabled configurations;
reducing accidental build breaks of the disabled configuration.

bytecompiler/BytecodeGenerator.cpp:
bytecompiler/BytecodeGenerator.h:
bytecompiler/NodesCodegen.cpp:
parser/ASTBuilder.h:
parser/Lexer.cpp:

(JSC::Lexer<T>::Lexer): Deleted.
(JSC::Lexer<T>::lex): Deleted.

parser/Lexer.h:
parser/NodeConstructors.h:
parser/Nodes.h:
parser/Parser.cpp:
parser/Parser.h:
parser/SyntaxChecker.h:

Nov 7, 2015:

11:17 PM Changeset in webkit [192140] by Simon Fraser

160 edits in trunk/Source

Remove ColorSpace argument to all the drawing calls
https://bugs.webkit.org/show_bug.cgi?id=150967

Reviewed by Darin Adler.

Source/WebCore:

Since the -webkit-color-correction CSS property was removed in r188202, and ColorSpaceDeviceRGB
and ColorSpaceSRGB are functionally equivalent, we can remove all the ColorSpace arguments passed
to drawing functions, and remove RenderStyle::colorSpace(), which was hardcoded to return ColorSpaceSRGB.

Fill and stroke ColorSpaces are also remove from graphics state, simplifying color save/restore.

bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

css/CSSFilterImageValue.cpp:

(WebCore::CSSFilterImageValue::image):

editing/FrameSelection.cpp:

(WebCore::CaretBase::paintCaret):

editing/cocoa/HTMLConverter.mm:

(_platformColor):

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::clearRect):
(WebCore::CanvasRenderingContext2D::applyShadow):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::compositeBuffer):
(WebCore::drawImageToContext):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

html/canvas/CanvasRenderingContext2D.h:
html/canvas/CanvasStyle.cpp:

(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):

html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::drawImageIntoBuffer):

page/DebugPageOverlays.cpp:

(WebCore::RegionOverlay::drawRect):

page/FrameView.cpp:

(WebCore::FrameView::paintScrollCorner):
(WebCore::FrameView::paintScrollbar):
(WebCore::FrameView::paintContents):

page/PrintContext.cpp:

(WebCore::PrintContext::spoolAllPagesWithBoundaries):

platform/ScrollView.cpp:

(WebCore::ScrollView::paintPanScrollIcon):

platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::defaultPaintScrollCorner):

platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::paintScrollCorner):
(WebCore::ScrollbarThemeComposite::paintOverhangAreas):

platform/Theme.cpp:

(WebCore::Theme::drawNamedImage):

platform/cocoa/ThemeCocoa.cpp:

(WebCore::ThemeCocoa::drawNamedImage):

platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::drawPattern):

platform/graphics/BitmapImage.h:
platform/graphics/Color.h:
platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::drawCrossfadeSubimage):
(WebCore::CrossfadeGeneratedImage::draw):
(WebCore::CrossfadeGeneratedImage::drawPattern):

platform/graphics/CrossfadeGeneratedImage.h:
platform/graphics/GeneratedImage.h:
platform/graphics/GradientImage.cpp:

(WebCore::GradientImage::draw):
(WebCore::GradientImage::drawPattern):

platform/graphics/GradientImage.h:
platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawRaisedEllipse):
(WebCore::GraphicsContext::setStrokeColor):
(WebCore::GraphicsContext::setShadow):
(WebCore::GraphicsContext::setLegacyShadow):
(WebCore::GraphicsContext::getShadow):
(WebCore::GraphicsContext::setFillColor):
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
(WebCore::GraphicsContext::drawImageBuffer):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
(WebCore::GraphicsContext::clearShadow): Deleted.

platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::strokeColorSpace): Deleted.
(WebCore::GraphicsContext::fillColorSpace): Deleted.

platform/graphics/Image.cpp:

(WebCore::Image::fillWithSolidColor):
(WebCore::Image::drawTiled):

platform/graphics/Image.h:

(WebCore::Image::drawFrameMatchingSourceSize):

platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::create):

platform/graphics/NamedImageGeneratedImage.cpp:

(WebCore::NamedImageGeneratedImage::draw):
(WebCore::NamedImageGeneratedImage::drawPattern):

platform/graphics/NamedImageGeneratedImage.h:
platform/graphics/ShadowBlur.cpp:

(WebCore::ScratchBuffer::setCachedShadowValues):
(WebCore::ScratchBuffer::setCachedInsetShadowValues):
(WebCore::ShadowBlur::ShadowBlur):
(WebCore::ShadowBlur::setShadowValues):
(WebCore::ShadowBlur::drawShadowBuffer):
(WebCore::ShadowBlur::drawRectShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithTiling):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
(WebCore::ShadowBlur::drawLayerPieces):
(WebCore::ShadowBlur::blurAndColorShadowBuffer):
(WebCore::ShadowBlur::beginShadowLayer):
(WebCore::ShadowBlur::endShadowLayer):

platform/graphics/ShadowBlur.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setContentsToImage): Deleted.

platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::platformCALayerPaintContents):

platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::drawRepaintCounters):

platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::draw):

platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::platformFillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
(WebCore::GraphicsContext::drawPattern):

platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):

platform/graphics/cairo/ImageCairo.cpp:

(WebCore::Image::drawPattern):

platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::BitmapImage::draw):

platform/graphics/cg/ColorCG.cpp:

(WebCore::leakCGColor):
(WebCore::cachedCGColor):

platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::paintToCanvas):

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::setCGFillColor):
(WebCore::setCGStrokeColor):
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::drawPattern):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::platformFillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::drawLinesForText):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::sRGBColorSpaceRef): Deleted.

platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):

platform/graphics/cg/ImageCG.cpp:

(WebCore::Image::drawPattern):
(WebCore::Image::imageWithColorSpace): Deleted.

platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::draw):

platform/graphics/cg/PDFDocumentImage.h:
platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::FontCascade::drawGlyphs):

platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::platformApplySoftware):

platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::platformApplySoftware):

platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::platformApplySoftware):

platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::platformApplySoftware):

platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::platformApplySoftware):

platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::platformApplySoftware):

platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::platformApplySoftware):

platform/graphics/filters/FETile.cpp:

(WebCore::FETile::platformApplySoftware):

platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::platformApplySoftware):

platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::platformApplySoftware):

platform/graphics/ios/IconIOS.mm:

(WebCore::Icon::paint):

platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
platform/graphics/texmap/coordinated/UpdateAtlas.cpp:
platform/graphics/win/FontCGWin.cpp:

(WebCore::FontCascade::drawGlyphs):

platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::drawFocusRing):

platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

platform/graphics/win/ImageCairoWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

platform/ios/LegacyTileCache.mm:

(WebCore::LegacyTileCache::drawLayer):

platform/ios/LegacyTileGridTile.mm:

(WebCore::LegacyTileGridTile::showBorder):

platform/ios/WebVideoFullscreenControllerAVKit.mm:

(WebVideoFullscreenControllerContext::didSetupFullscreen):

platform/mac/DragImageMac.mm:

(WebCore::drawAtPoint):

platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::setUpOverhangAreaBackground):

platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::drawCellOrFocusRingWithViewIntoContext):

platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::paintCurrentFrameInContext):

platform/mock/ScrollbarThemeMock.cpp:

(WebCore::ScrollbarThemeMock::paintTrackBackground):
(WebCore::ScrollbarThemeMock::paintThumb):

platform/win/DragImageWin.cpp:

(WebCore::createDragImageForLink):

platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::paint):

platform/win/WebCoreTextRenderer.cpp:

(WebCore::doDrawTextAtPoint):

rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::paintSelection):

rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRendererHelper::applyFilterEffect):

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::blockSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):

rendering/RenderBox.cpp:

(WebCore::RenderBox::paintClippingMask):

rendering/RenderBoxModelObject.cpp:

(WebCore::applyBoxShadowForBackground):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
(WebCore::RenderBoxModelObject::paintBoxShadow):

rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::paint):

rendering/RenderElement.cpp:

(WebCore::RenderElement::drawLineForBoxSide):
(WebCore::RenderElement::paintOutline):

rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintSnapshotImage):
(WebCore::RenderEmbeddedObject::paintReplaced):

rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):

rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::beginTransparencyLayers):
(WebCore::RenderLayer::paintScrollCorner):
(WebCore::RenderLayer::drawPlatformResizerImage):
(WebCore::RenderLayer::paintResizer):

rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):

rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint):

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::paint):

rendering/RenderScrollbarTheme.cpp:

(WebCore::RenderScrollbarTheme::paintScrollCorner):

rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::paintSnapshot):

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paintSliderTicks):

rendering/RenderThemeIOS.mm:

(WebCore::drawAxialGradient):
(WebCore::drawRadialGradient):
(WebCore::RenderThemeIOS::paintCheckboxDecorations):
(WebCore::RenderThemeIOS::paintRadioDecorations):
(WebCore::RenderThemeIOS::paintMenuListButtonDecorations):
(WebCore::RenderThemeIOS::paintSliderTrack):
(WebCore::RenderThemeIOS::paintProgressBar):
(WebCore::RenderThemeIOS::paintFileUploadIconDecorations):

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintProgressBar):
(WebCore::RenderThemeMac::paintMenuListButtonDecorations):
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):
(WebCore::titleTextColorForAttachment):
(WebCore::AttachmentLayout::layOutSubtitle):
(WebCore::paintAttachmentIconBackground):
(WebCore::paintAttachmentTitleBackground):
(WebCore::paintAttachmentProgress):

rendering/RenderView.cpp:

(WebCore::RenderView::paint):
(WebCore::RenderView::paintBoxDecorations):

rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint):

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::lineSelectionGap):

rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintDebugBorders):

rendering/TextPaintStyle.cpp:

(WebCore::TextPaintStyle::TextPaintStyle):
(WebCore::adjustColorForVisibilityOnBackground):
(WebCore::computeTextPaintStyle):
(WebCore::updateGraphicsContext):

rendering/TextPaintStyle.h:

(WebCore::TextPaintStyle::TextPaintStyle):

rendering/TextPainter.cpp:

(WebCore::ShadowApplier::ShadowApplier):
(WebCore::paintTextWithShadows):

rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::paint):

rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::paint):

rendering/mathml/RenderMathMLMenclose.cpp:

(WebCore::RenderMathMLMenclose::paint):

rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::paint):

rendering/mathml/RenderMathMLRadicalOperator.cpp:

(WebCore::RenderMathMLRadicalOperator::paint):

rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::paint):

rendering/shapes/Shape.cpp:

(WebCore::Shape::createRasterShape):

rendering/style/NinePieceImage.cpp:

(WebCore::NinePieceImage::paint):

rendering/style/RenderStyle.h:
rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::paintForeground):

rendering/svg/RenderSVGPath.cpp:

(WebCore::useStrokeStyleToFill):

rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):

rendering/svg/RenderSVGResourceSolidColor.cpp:

(WebCore::RenderSVGResourceSolidColor::applyResource):

rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintSelectionBackground):

rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
(WebCore::SVGRenderingContext::bufferForeground):

svg/SVGAnimatedColor.cpp:

(WebCore::SVGAnimatedColorAnimator::calculateAnimatedValue):

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawForContainer):
(WebCore::SVGImage::nativeImageForCurrentFrame):
(WebCore::SVGImage::drawPatternForContainer):
(WebCore::SVGImage::draw):

svg/graphics/SVGImage.h:
svg/graphics/SVGImageForContainer.cpp:

(WebCore::SVGImageForContainer::draw):
(WebCore::SVGImageForContainer::drawPattern):

svg/graphics/SVGImageForContainer.h:
svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::platformApplySoftware):

testing/MockPageOverlayClient.cpp:

(WebCore::MockPageOverlayClient::drawRect):

Source/WebKit/ios:

WebView/WebPDFViewIOS.mm:

(-[WebPDFView drawPage:]):

WebView/WebPlainWhiteView.mm:

Source/WebKit/mac:

Misc/WebKitNSStringExtras.mm:

(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):

WebInspector/WebNodeHighlightView.mm:

(-[WebNodeHighlightView _layoutForNodeHighlight:parent:]):
(-[WebNodeHighlightView _layoutForRectsHighlight:parent:]):

WebView/WebFrame.mm:

(-[WebFrame _bodyBackgroundColor]):

WebView/WebFrameView.mm:

(-[WebFrameView drawRect:]):

WebView/WebIndicateLayer.mm:

Source/WebKit2:

Shared/API/c/cg/WKImageCG.cpp:

(WKImageCreateFromCGImage):

Shared/ContextMenuContextData.cpp:

(WebKit::ContextMenuContextData::ContextMenuContextData):

Shared/WebCoreArgumentCoders.cpp:

(IPC::encodeImage):

Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::drawInContext):

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _updateScrollViewBackground]):

UIProcess/WKInspectorHighlightView.mm:

(-[WKInspectorHighlightView _layoutForNodeHighlight:offset:]):
(-[WKInspectorHighlightView _layoutForRectsHighlight:]):

UIProcess/ios/ViewGestureControllerIOS.mm:

(WebKit::ViewGestureController::beginSwipeGesture):

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _updateTapHighlight]):

UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::beginSwipeGesture):

WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::drawRect):

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createSelectionSnapshot):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotAtSize):

WebProcess/WebPage/ios/FindControllerIOS.mm:

(WebKit::FindIndicatorOverlayClientIOS::drawRect):

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation):

WebProcess/ios/WebVideoFullscreenManager.mm:

(WebKit::WebVideoFullscreenManager::didSetupFullscreen):

10:57 PM Changeset in webkit [192139] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed gardening, update fast/replaced/replaced-breaking.html

Update fast/replaced/replaced-breaking.html so that it outputs the
same result on all platforms.

fast/replaced/replaced-breaking.html:

10:31 PM Changeset in webkit [192138] by Simon Fraser

24 edits in trunk/Source

Use ColorSpaceSRGB for image buffers everywhere
https://bugs.webkit.org/show_bug.cgi?id=150990

Reviewed by Zalan Bujtas.

ColorSpaceSRGB and ColorSpaceDeviceRGB are equivalent now, so convert
code that creates image buffers tagged with ColorSpaceDeviceRGB to use ColorSpaceSRGB.

Source/WebCore:

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::createCompatibleBuffer):

platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::create):

platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::BitmapImage::checkForSolidColor):

platform/graphics/cg/ColorCG.cpp:

(WebCore::Color::Color):

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::sRGBColorSpaceRef): Deleted.

platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::putByteArray):

platform/graphics/cocoa/IOSurface.mm:

(IOSurface::createFromImage):

platform/graphics/filters/FEFlood.h:
platform/graphics/filters/FETile.cpp:

(WebCore::FETile::platformApplySoftware):

platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::FilterEffect):

platform/graphics/filters/SourceGraphic.h:

(WebCore::SourceGraphic::SourceGraphic):

rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::apply):

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintProgressBar):

rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives):

rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::createMaskAndSwapContextForTextGradient):

rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):

rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::createTileImage):

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawPatternForContainer):

svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::platformApplySoftware):

Source/WebKit2:

Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::decode):
(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer):

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _takeViewSnapshot]):
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):

8:04 PM Changeset in webkit [192137] by dbates@webkit.org

2 edits in trunk/Tools

Attempt to fix the Windows EWS bot after r192087
(https://bugs.webkit.org/show_bug.cgi?id=150859)

Following r192087 Port._build_path() stores the computed root directory path in option
_cached_root instead of overwriting option root. We need to teach the Windows-specific
logic to make use of option _cached_root instead of option root when computing its adjusted
path and to cache its adjusted in _cached_root instead of root.

Scripts/webkitpy/port/win.py:

(WinPort._build_path):

7:33 PM Changeset in webkit [192136] by Alan Bujtas

2 edits in trunk/LayoutTests

DRT does not reset the frame rect between 2 runs.
https://bugs.webkit.org/show_bug.cgi?id=151003

Set the min frame rect for 800*600 for now.

Unreviewed gardening.

fast/dynamic/crash-subtree-layout-when-auto-size-enabled.html:

6:10 PM Changeset in webkit [192135] by fpizlo@apple.com

4 edits
3 deletes in trunk/Source/JavaScriptCore

B3->Air lowering should do pattern matching the old fashioned way
https://bugs.webkit.org/show_bug.cgi?id=150994

Reviewed by Geoffrey Garen.

When I first wrote the B3->Air lowering prototype, I was convinced that the patterns would get
so gnarly that we'd want a pattern language to write them in. So I made one, and that's what
the lowering has used. But as we've worked with the IR, we've found that it's very easy to
pattern match in C++ using the B3 API, and we've also found that most of the patterns we wrote
using the pattern language were mostly trivial. So this change removes the pattern match code
generator and the patterns files, and redoes the lowering using good old fashioned switch
statements. This actually reduces the total code of the lowering.

I also took the opportunity to refactoring UnOp and BinOp lowering. We had a lot of repetetive
code for 32-vs-64-bit opcode selection, so I factored that out into a helper. This also saves a
lot of code.

CMakeLists.txt:
DerivedSources.make:
b3/B3AddressMatcher.patterns: Removed.
b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::LowerToAir):
(JSC::B3::Air::LowerToAir::run):
(JSC::B3::Air::LowerToAir::highBitsAreZero):
(JSC::B3::Air::LowerToAir::tmp):
(JSC::B3::Air::LowerToAir::canBeInternal):
(JSC::B3::Air::LowerToAir::commitInternal):
(JSC::B3::Air::LowerToAir::crossesInterference):
(JSC::B3::Air::LowerToAir::effectiveAddr):
(JSC::B3::Air::LowerToAir::addr):
(JSC::B3::Air::LowerToAir::loadPromise):
(JSC::B3::Air::LowerToAir::imm):
(JSC::B3::Air::LowerToAir::immForMove):
(JSC::B3::Air::LowerToAir::immOrTmpForMove):
(JSC::B3::Air::LowerToAir::tryOpcodeForType):
(JSC::B3::Air::LowerToAir::opcodeForType):
(JSC::B3::Air::LowerToAir::appendUnOp):
(JSC::B3::Air::LowerToAir::appendBinOp):
(JSC::B3::Air::LowerToAir::appendShift):
(JSC::B3::Air::LowerToAir::tryAppendStoreUnOp):
(JSC::B3::Air::LowerToAir::tryAppendStoreBinOp):
(JSC::B3::Air::LowerToAir::append):
(JSC::B3::Air::LowerToAir::ensureSpecial):
(JSC::B3::Air::LowerToAir::fillStackmap):
(JSC::B3::Air::LowerToAir::createGenericCompare):
(JSC::B3::Air::LowerToAir::createBranch):
(JSC::B3::Air::LowerToAir::createCompare):
(JSC::B3::Air::LowerToAir::lower):
(JSC::B3::Air::LowerToAir::immOrTmp): Deleted.
(JSC::B3::Air::LowerToAir::AddressSelector::AddressSelector): Deleted.
(JSC::B3::Air::LowerToAir::AddressSelector::acceptRoot): Deleted.
(JSC::B3::Air::LowerToAir::AddressSelector::acceptRootLate): Deleted.
(JSC::B3::Air::LowerToAir::AddressSelector::acceptInternals): Deleted.
(JSC::B3::Air::LowerToAir::AddressSelector::acceptInternalsLate): Deleted.
(JSC::B3::Air::LowerToAir::AddressSelector::acceptOperands): Deleted.
(JSC::B3::Air::LowerToAir::AddressSelector::acceptOperandsLate): Deleted.
(JSC::B3::Air::LowerToAir::AddressSelector::tryAddShift1): Deleted.
(JSC::B3::Air::LowerToAir::AddressSelector::tryAddShift2): Deleted.
(JSC::B3::Air::LowerToAir::AddressSelector::tryAdd): Deleted.
(JSC::B3::Air::LowerToAir::AddressSelector::tryFramePointer): Deleted.
(JSC::B3::Air::LowerToAir::AddressSelector::tryStackSlot): Deleted.
(JSC::B3::Air::LowerToAir::AddressSelector::tryDirect): Deleted.
(JSC::B3::Air::LowerToAir::acceptRoot): Deleted.
(JSC::B3::Air::LowerToAir::acceptRootLate): Deleted.
(JSC::B3::Air::LowerToAir::acceptInternals): Deleted.
(JSC::B3::Air::LowerToAir::acceptInternalsLate): Deleted.
(JSC::B3::Air::LowerToAir::acceptOperands): Deleted.
(JSC::B3::Air::LowerToAir::acceptOperandsLate): Deleted.
(JSC::B3::Air::LowerToAir::tryLoad): Deleted.
(JSC::B3::Air::LowerToAir::tryLoad8S): Deleted.
(JSC::B3::Air::LowerToAir::tryLoad8Z): Deleted.
(JSC::B3::Air::LowerToAir::tryLoad16S): Deleted.
(JSC::B3::Air::LowerToAir::tryLoad16Z): Deleted.
(JSC::B3::Air::LowerToAir::tryAdd): Deleted.
(JSC::B3::Air::LowerToAir::trySub): Deleted.
(JSC::B3::Air::LowerToAir::tryAnd): Deleted.
(JSC::B3::Air::LowerToAir::tryOr): Deleted.
(JSC::B3::Air::LowerToAir::tryXor): Deleted.
(JSC::B3::Air::LowerToAir::tryShl): Deleted.
(JSC::B3::Air::LowerToAir::trySShr): Deleted.
(JSC::B3::Air::LowerToAir::tryZShr): Deleted.
(JSC::B3::Air::LowerToAir::tryStoreAddLoad): Deleted.
(JSC::B3::Air::LowerToAir::tryStoreSubLoad): Deleted.
(JSC::B3::Air::LowerToAir::tryStoreAndLoad): Deleted.
(JSC::B3::Air::LowerToAir::tryStore): Deleted.
(JSC::B3::Air::LowerToAir::tryTrunc): Deleted.
(JSC::B3::Air::LowerToAir::tryZExt32): Deleted.
(JSC::B3::Air::LowerToAir::tryArgumentReg): Deleted.
(JSC::B3::Air::LowerToAir::tryConst32): Deleted.
(JSC::B3::Air::LowerToAir::tryConst64): Deleted.
(JSC::B3::Air::LowerToAir::tryFramePointer): Deleted.
(JSC::B3::Air::LowerToAir::tryStackSlot): Deleted.
(JSC::B3::Air::LowerToAir::tryEqual): Deleted.
(JSC::B3::Air::LowerToAir::tryNotEqual): Deleted.
(JSC::B3::Air::LowerToAir::tryLessThan): Deleted.
(JSC::B3::Air::LowerToAir::tryGreaterThan): Deleted.
(JSC::B3::Air::LowerToAir::tryLessEqual): Deleted.
(JSC::B3::Air::LowerToAir::tryGreaterEqual): Deleted.
(JSC::B3::Air::LowerToAir::tryAbove): Deleted.
(JSC::B3::Air::LowerToAir::tryBelow): Deleted.
(JSC::B3::Air::LowerToAir::tryAboveEqual): Deleted.
(JSC::B3::Air::LowerToAir::tryBelowEqual): Deleted.
(JSC::B3::Air::LowerToAir::tryPatchpoint): Deleted.
(JSC::B3::Air::LowerToAir::tryCheck): Deleted.
(JSC::B3::Air::LowerToAir::tryUpsilon): Deleted.
(JSC::B3::Air::LowerToAir::tryPhi): Deleted.
(JSC::B3::Air::LowerToAir::tryBranch): Deleted.
(JSC::B3::Air::LowerToAir::tryJump): Deleted.
(JSC::B3::Air::LowerToAir::tryIdentity): Deleted.
(JSC::B3::Air::LowerToAir::tryReturn): Deleted.

b3/B3LoweringMatcher.patterns: Removed.
b3/generate_pattern_matcher.rb: Removed.

5:29 PM Changeset in webkit [192134] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: [Regression] [Mavericks] Toolbar is too dark while docked
https://bugs.webkit.org/show_bug.cgi?id=150977

Set the toolbar color of the docked inspector to be the same as on OS X 10.10+.
Undocked toolbar color on Mavericks is unnaffected.

Reviewed by Timothy Hatcher.

UserInterface/Views/Toolbar.css:

(body.mavericks.docked .toolbar):
(body:not(.mavericks) .toolbar): Added.

4:50 PM Changeset in webkit [192133] by Alan Bujtas

7 edits
2 adds in trunk

Crash when subtree layout is set on FrameView while auto size mode is enabled.
https://bugs.webkit.org/show_bug.cgi?id=150995
rdar://problem/22785262

Reviewed by Beth Dakin.

Autosizing initiates multiple synchronous layouts to calculate preferred view width for current content.
FrameView::autoSizeIfEnabled() is called from FrameView::layout() while we are in InPreLayout state.
It is safe to do during full layout.
However, since we setup the subtree state just before the autoSizeIfEnabled() call, reentering it with
a newly issued layout confuses SubtreeLayoutStateMaintainer.

This patch reverses the order of autoSizeIfEnabled() call and the subtree layout state setup.
It also ensures that the first layout requested by autoSizeIfEnabled() always runs on the whole tree.

Source/WebCore:

Test: fast/dynamic/crash-subtree-layout-when-auto-size-enabled.html

page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore::FrameView::convertSubtreeLayoutToFullLayout):
(WebCore::FrameView::scheduleRelayout):
(WebCore::FrameView::scheduleRelayoutOfSubtree):
(WebCore::FrameView::autoSizeIfEnabled):

page/FrameView.h:
testing/Internals.cpp:

(WebCore::Internals::enableAutoSizeMode):

testing/Internals.h:
testing/Internals.idl:

LayoutTests:

fast/dynamic/crash-subtree-layout-when-auto-size-enabled-expected.txt: Added.
fast/dynamic/crash-subtree-layout-when-auto-size-enabled.html: Added.

3:48 PM Changeset in webkit [192132] by Chris Dumez

19 edits in trunk

embed element without src and type attributes should represent nothing
https://bugs.webkit.org/show_bug.cgi?id=148853
<rdar://problem/22588235>

Reviewed by Zalan Bujtas.

LayoutTests/imported/w3c:

Rebaseline existing tests.

web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt:
web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-05-expected.txt:

Source/WebCore:

As per the HTML specification, an embed element without src and type
attributes should represent nothing:
https://html.spec.whatwg.org/multipage/embedded-content.html#the-embed-element

This patch fixes the issue by making sure we don't construct a
renderer for such embed elements.

The new behavior is consistent with Firefox but differs from Chrome.

No new tests, already covered by existing tests.

html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::rendererIsNeeded):

LayoutTests:

TestExpectations:

Unskip 2 ref-tests that were previously failing.

accessibility/inline-block-assertion-expected.txt:
editing/execCommand/crash-140261-expected.txt:
fast/block/float/4145535Crash-expected.txt:
fast/dom/HTMLDocument/document-plugins-expected.txt:
fast/dom/insertedIntoDocument-child-expected.txt:
fast/dom/insertedIntoDocument-sibling-expected.txt:
fast/dom/plugin-attributes-enumeration-expected.txt:
fast/replaced/percent-height-in-anonymous-block-widget.html:
fast/replaced/replaced-breaking.html:
fast/replaced/table-percent-height.html:
fast/text/international/embed-bidi-style-in-isolate-crash-expected.txt:
imported/blink/fast/css-grid-layout/grid-add-positioned-block-item-after-inline-item-expected.txt:

Rebaseline / update existing tests.

10:11 AM Changeset in webkit [192131] by msaboff@apple.com

3 edits in trunk/Source/JavaScriptCore

Add conditional moves to the MacroAssembler
https://bugs.webkit.org/show_bug.cgi?id=150761

Reviewed by Filip Pizlo.

Added moveConditionally, moveConditionallyTest & moveConditionallyDouble to X86 macro assemblers.
Bench tested correct opcodes and operations on X86-64 and X86 for a select number of comparisons.

assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::moveConditionally):
(JSC::MacroAssemblerX86Common::moveConditionallyTest):
(JSC::MacroAssemblerX86Common::moveConditionallyDouble):

assembler/X86Assembler.h:

(JSC::X86Assembler::cmovcc):
(JSC::X86Assembler::cmovl_rr):
(JSC::X86Assembler::cmovl_mr):
(JSC::X86Assembler::cmovel_rr):
(JSC::X86Assembler::cmovnel_rr):
(JSC::X86Assembler::cmovpl_rr):
(JSC::X86Assembler::cmovnpl_rr):
(JSC::X86Assembler::cmovq_rr):
(JSC::X86Assembler::cmovq_mr):
(JSC::X86Assembler::cmoveq_rr):
(JSC::X86Assembler::cmovneq_rr):
(JSC::X86Assembler::cmovpq_rr):
(JSC::X86Assembler::cmovnpq_rr):
(JSC::X86Assembler::X86InstructionFormatter::twoByteOp64):

9:17 AM Changeset in webkit [192130] by Michael Catanzaro

2 edits in trunk/Source/WebCore

Node.h:392:12: warning: 'this' pointer cannot be null in well-defined C++ code
https://bugs.webkit.org/show_bug.cgi?id=150996

Reviewed by Andreas Kling.

Remove ASSERT(this) statement that is triggering hundreds of warnings from Clang.

dom/Node.h:

(WebCore::Node::document):

7:22 AM Changeset in webkit [192129] by Michael Catanzaro

2 edits in trunk/Source/WebCore

Unreviewed, fix GTK build after r191981

html/HTMLFormControlElement.cpp:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed